Bug 5749 - cannot resolve L2 ep for ext GW

Subnet GW may also be an external endpoint.
It has not been considered before.

Change-Id: I260c151608c2e28e769708f1a4d7e57f4bf7619c
Signed-off-by: Tomas Cechvala <tcechval@cisco.com>

Add dependency on javax.validation validation-api

In order to upgrade to org.eclipse.persistence to 2.6.0+ in odlparent,
downstream consumers must include the dependency on javax.validation
validation-api version 1.1.0.Final as described here:

http://stackoverflow.com/questions/28568154/
how-to-get-eclipselink-2-6-0-m3-working-with-jersey-1-18-3

The work to upgrade odlparent's moxy version is included in this patch:
https://git.opendaylight.org/gerrit/#/c/37541/

Change-Id: I950cf10e58f96d16abe6a99ace9273d70cd8eda5
Signed-off-by: Ryan Goulding <ryandgoulding@gmail.com>

Merge "Do not deploy the karaf artifact"

Bug 5617: policy enforcer symmetric action chain fix

Change-Id: I4a2e71891b01a5344fe5af8a6267cebbfcd3d116
Signed-off-by: Matej Perina <matej.perina@pantheon.sk>

Do not deploy the karaf artifact

The karaf artifact is only used for testing. It does not need to be
released to the world.

Change-Id: I0894ac9f45dbc80b26162d5557abed7fd008e3b6
Signed-off-by: Thanh Ha <thanh.ha@linuxfoundation.org>

Bug 5617: Added UT for GroupTable and ChainActionFlows

Signed-off-by: Vladimir Lavor <vlavor@cisco.com>
Change-Id: I2a45247bbc7a3b611baa6a1cf55b26da06ef9232
(cherry picked from commit 619e7bf903b9f096af6617432350b9e8b5ff072a)

Bug 5617: OfOverlay Refactoring - Destination mapper

Signed-off-by: Vladimir Lavor <vlavor@cisco.com>
Change-Id: I7e1ac58b066f8eda1a5c989d1980459ee22a1960

Bug 5617: OfOverlay refactoring - Source Mapper

Signed-off-by: Vladimir Lavor <vlavor@cisco.com>
Change-Id: I2fa6b9a38d9a4b221308045c55ac6af425b7ce70

Bug 5617: ExternalMapper refactoring

Change-Id: I11869b14877599b6314c7bc5f93d8223a10d248d
Signed-off-by: Matej Perina <matej.perina@pantheon.sk>

Bug 5617: policy enforcer refactor

Change-Id: Ic2df05411fce29f3538464f06650f835cc284874
Signed-off-by: Matej Perina <matej.perina@pantheon.sk>

Bug 5409 - setting orders in single rule contract

Rules and subjects are prioritized by order parameter.
More specific rules have lower order.

Change-Id: Ieb9948b2e9281e378341775509dd09a144dda3f8
Signed-off-by: Tomas Cechvala <tcechval@cisco.com>

Merge "Use pre-compiled Pattern for replacement"

Use pre-compiled Pattern for replacement

String.replaceAll() compiles the pattern each time, precompile it for
speed. Also replace "".equals(res) with res.isEmpty(), which is faster,
since res is known to be non-null in this context.

Change-Id: Id7d28ba355d62607a75dbbe6504b50f6da8085d1
Signed-off-by: Robert Varga <rovarga@cisco.com>

Bug 5483 - added support for num values in rules

Added mapping for numerical values of neutron
security-group-rules.

Change-Id: Id4166300a2a922a30fb553ea5593385fed408652
Signed-off-by: Tomas Cechvala <tcechval@cisco.com>

Merge "Bug 5510 - making sure that br-int is created"

Bug 5617: OfOverlayRefactoring - IngressNatMapper + EgressNatMappe

Signed-off-by: Vladimir Lavor <vlavor@cisco.com>

Bug 5617: OfOverlay refactoring initial + PortSecurity

Signed-off-by: Vladimir Lavor <vlavor@cisco.com>
Change-Id: I12cf020828826c32e3eee0887a1f1144579bce0b
(cherry picked from commit 3e2119a5e3fc75918511dc273b6830cf33e65fd3)

Bug 5510 - making sure that br-int is created

When a node with OvsdbNodeAugmentation does not have
reference to br-int node with OvsdbBridge augmentation,
the missing bridge node is created by writing it
into DS.

Change-Id: Ie0054d311916ece0030ad63647ebe3ca3f06d797
Signed-off-by: Tomas Cechvala <tcechval@cisco.com>

Bug 5428: Ovsdb Termination Point is null issue

- adding condition to check if TP is null,then log and skip processing.

Change-Id: Idd4c7fbbe5398d15dc153927338421ffc3fef67c
Signed-off-by: Michal Cmarada <mcmarada@cisco.com>

BUG 5402 - PolicyEnforcer creates wrong directed flows

Change-Id: I55479bfc1d188a9b946912e82cf127c115777cf1
Signed-off-by: Matej Perina <matej.perina@pantheon.sk>

Bug5427: Added JavaDoc for OfOverlay rendeder (flow description)

Signed-off-by: Vladimir Lavor <vlavor@cisco.com>
Change-Id: Ifd26bcf2abc3be211adeaf7369c7f93f8e59de7e

Merge "Bug 5342: Fix for SF appearing as Endpoint"

Merge "Bug 3738: GBP coexistence fixes"

Merge "Bug 5326 - endpoint can reach nodes outside internal domain"

Bug 5342: Fix for SF appearing as Endpoint

Still not sure what is Root Cause but don't want to hold up release. This will unblock

Change-Id: Ia18b94144b1f55495086991d9e7fe7c58f69ee18
Signed-off-by: Keith Burns (alagalah) <alagalah@gmail.com>
Signed-off-by: Matej Perina <matej.perina@pantheon.sk>

Bug 3738: GBP coexistence fixes

- chmod scripts, small script issues

Change-Id: Ice6c53dbcf134fb35f68985c7a3902e263cddcff
Signed-off-by: Keith Burns (alagalah) <alagalah@gmail.com>
Signed-off-by: Matej Perina <matej.perina@pantheon.sk>

Merge "Bug 5214 - ARP fix for external VLAN traffic"

Merge "Bug 4988: OF statistics & REST client"

Merge "Bug 5117 - More bad file formats and chmod breaks"

Bug 5326 - endpoint can reach nodes outside internal domain

Traffic of endpoints connected to OVS switch can be forwarded
to external domain.

Change-Id: Icdf23726a411ae7d22ed792f2f9cfa08cb95b1de
Signed-off-by: Tomas Cechvala <tcechval@cisco.com>
Signed-off-by: Matej Perina <matej.perina@pantheon.sk>

Bug 5214 - ARP fix for external VLAN traffic

External endpoints can receive tagged ARP response.

Change-Id: I0cd1b5d9a47aee8ded8d9a0c3f93598a159bf814
Signed-off-by: Tomas Cechvala <tcechval@cisco.com>
Signed-off-by: Martin Sunal <msunal@cisco.com>
Signed-off-by: Matej Perina <matej.perina@pantheon.sk>

Bug 4988: OF statistics & REST client

Change-Id: I48c8302196f997abf6c6180e36beae5886d7be48
Signed-off-by: Konstantin Blagov <kblagov@cisco.com>
Signed-off-by: Keith Burns (alagalah) <alagalah@gmail.com>
Signed-off-by: Martin Sunal <msunal@cisco.com>
Signed-off-by: Matej Perina <matej.perina@pantheon.sk>

Bug 5117 - More bad file formats and chmod breaks

Change-Id: If9d42b4db8d0089a948aef26bb929ddc3bcece71
Signed-off-by: Keith Burns (alagalah) <alagalah@gmail.com>
(cherry picked from commit 69d6de639550c7aa04bbca09f2e62fdd4730081c)

Bug 3738: GBP coexistence with SFC

Change-Id: If5ed0e87485b88e02f525dab1072b75462d16a1f
Signed-off-by: Vladimir Lavor <vlavor@cisco.com>
Signed-off-by: Keith Burns (alagalah) <alagalah@gmail.com>
Signed-off-by: Martin Sunal <msunal@cisco.com>
Signed-off-by: Matej Perina <matej.perina@pantheon.sk>

Bug 5325 Missing sfc action in rules

Change-Id: I1b90da5deb3fa7615249fef95f87983404f429e7
Signed-off-by: Martin Sunal <msunal@cisco.com>
Signed-off-by: Keith Burns (alagalah) <alagalah@gmail.com>
Signed-off-by: Matej Perina <matej.perina@pantheon.sk>

BUG 5370 - changes required by java8

- powermockito versions are removed
  so this commit depends on Change 35210

Change-Id: I81f43b6d49a45308d85a9f29c22c3fb95b739d0e
Signed-off-by: Matej Perina <matej.perina@pantheon.sk>

BUG 5248: reading statistics not working

Change-Id: I5798209e03149702abb94417af038997b4ede2cd
Signed-off-by: Matej Perina <matej.perina@pantheon.sk>

Merge "Bug 5208 - flows don't get removed on update"

Bug 5208 - flows don't get removed on update

Fixed by ensuring that the current state of flow tables is overriden
only after the DS was updated.

Change-Id: I2d6e482fbd4f5e2ed5210b2f5983dbefd0760d37
Signed-off-by: Tomas Cechvala <tcechval@cisco.com>

Bug 5213 - Missing segmentation-id for physical networks

segmentation-id is stored to DS if a neutron network is backed by physical network

Change-Id: Id7334fc0a088a32879396ce7f2e48cdb06d250dc
Signed-off-by: Tomas Cechvala <tcechval@cisco.com>

Merge "Bug 5117 - DOS chars in shell script"

devstack changes for sfc-tacker OPNFV demo

- using for two projects
-- sfc-vnfm-tacker testing and changes
-- openflow co-existence

Change-Id: Id2aa44fe4869730212f804c273c91eee642373ff
Signed-off-by: Keith Burns (alagalah) <alagalah@gmail.com>
Signed-off-by: Michal Cmarada <mcmarada@cisco.com>

Bug 5212 - Neutron-mapper has dependency on Ofoverlay renderer

NeutronFloatingAware - adds NAT augmentation to endpoint-l3
NeutronNetworkAware - creates EXTERNAL_group EPG (as External
  Implicit Group (EIG)) if neutron external network is created
EXTERNAL_group EPG - provides contracts with allow IPv4/6 In/Out
L3-prefix-endpoint 0.0.0.0/0 belongs to EXTERNAL_group EPG
neutron ports where deviceOwner is router_gateway and router_interface
  are not mapped to endpoints
removed unused mappings
removed dependency on ofoverlay
neutron-ovsdb - added portByEndpoint listener which adds port-name to Ep, EpL3
ofoverlay - added listeners for ofoverlay endpoint context - add location(node,
  node-connector-id) based on port name
OvsdbNodeListener - creates of-overlay augmentation with external ports
(cherry picked from commit f9b3d2ffd80c2d623d199d789bff7192b678de40)

Change-Id: If2a582d00f8771c433994154a02febf7c2a702cd
Signed-off-by: Martin Sunal <msunal@cisco.com>
(cherry picked from commit f9b3d2ffd80c2d623d199d789bff7192b678de40)

Changes based on fix of Bug 5137 - Neutron routes

This is needed fix after [1] was merged.
[1] https://git.opendaylight.org/gerrit/#/c/33846/
(cherry picked from commit c2f141f0ff466ae316bcf714d2c5eb6d02ac62d9)

Change-Id: I51fa7c3fd9ab86c330967df5cb0877f4fa2aad76
Signed-off-by: Martin Sunal <msunal@cisco.com>

UT: ofoverlay-arp

Change-Id: I7982604cb94ffa25218fb8db20e1eb123c08b5d0
Signed-off-by: Matej Perina <matej.perina@pantheon.sk>

UT: Added FaaS unit tests

Change-Id: I522e1d9aa3b04f201dcd7dd08386c6c6b21adf35
Signed-off-by: Khaldoon Al-zoubi <khalAlzoubi@gmail.com>

Bug 5117 - DOS chars in shell script

Removing nested DOS line endings

Change-Id: I4297ccc946f6c20b8fb9a1171f99632e8ef73159
Signed-off-by: Tomas Cechvala <tcechval@cisco.com>

Bug5105: gitignore adds OSX system files

Change-Id: I8bb3361f82f43c9b44b70c350b00432f48113313
Signed-off-by: Keith Burns (alagalah) <alagalah@gmail.com>

Bug 5102 - NoSuchMethodError in EndpointManager

- keySet method in ConcurrentHashMap changed in Java 8.
- error occurend when the code was built with Java 8 and
  ran on Java 7.
- fixed by compatible interface ConcurrentMap

Change-Id: I672f7102db8b9b3874d1f18419dd01bff3064704
Signed-off-by: Tomas Cechvala <tcechval@cisco.com>

Bug3738: Coexistence demo environment

Document: https://docs.google.com/document/d/1-O6GoKeV9WLCiDU5xGv7rArAw_w2VJX-Ju6WOhRJ8s0/edit#

Change-Id: Id016afd8b52b094c9e7b1f97d985db6db0e34c13
Signed-off-by: Vladimir Lavor <vlavor@cisco.com>

BUG 4993 ArpTasker failing when Nodes are not initialized in DS

condition fixed

Change-Id: I84e808fedfd28536b320ea1a81fd0a3193b75481
Signed-off-by: Matej Perina <matej.perina@pantheon.sk>

Merge "BUG 4973 - Wrong time type in statistics and statistics-store"

Bug 4987 - ExternalMapper flows not populated

 - fixed by removing redundant condition

Change-Id: I3d0e43c6abebab776b21a9c12c91a5a570d0e55c
Signed-off-by: Tomas Cechvala <tcechval@cisco.com>

BUG 4973 - Wrong time type in statistics and statistics-store

Timestamp type changed to uint64

Change-Id: I448c7cf3d1f0066c6e434e4a86da41c5b3e8630c
Signed-off-by: Matej Perina <matej.perina@pantheon.sk>

Bump versions by 0.1.0 for next dev cycle

Change-Id: I9de10228d37af63807918ac1f8ee115561ae0abb
Signed-off-by: Thanh Ha <thanh.ha@linuxfoundation.org>

Merge "Iovisor renderer REST client"

Merge "VLAN support for external networks"

Merge "GBP coexistence - OF renderer can remove only its own flows from node"

Merge "added timestamp for statistics storage"

Iovisor renderer REST client

Change-Id: I24e658760b767672c1ceee4cbef506f701e40a47
Signed-off-by: Keith Burns (alagalah) <alagalah@gmail.com>

VLAN support for external networks

 - tagging is applied on external ports of switches
 - link connected to external port is considered as trunk port
 - native VLAN not supported yet
 - mapping VLANs from Openstack not in scope here

Change-Id: Iaeeaa4d7966d49f2c7179ba22a9cc5972fd33b0a
Signed-off-by: Tomas Cechvala <tcechval@cisco.com>

added timestamp for statistics storage

Change-Id: I4bf3e2e7ce4e1670f75dcecae7d7fd7a9dfebaa4
Signed-off-by: Matej Perina <matej.perina@pantheon.sk>

Merge "Scripts and Vagrantfile to run sFlow on gbp1"

GBP coexistence - OF renderer can remove only its own flows from node

Signed-off-by: Vladimir Lavor.com <vlavor@cisco.com>
Change-Id: Ibd52a8e494bbd845b215464f834fd557e38317fd

Merge "Using Box file to remove external dependencies such as github."

Scripts and Vagrantfile to run sFlow on gbp1

Change-Id: I74ccf8e90719280d80dcde9273c5224d290843bb
Signed-off-by: Konstantin Blagov <kblagov@cisco.com>

Using Box file to remove external dependencies such as github.

- Quicker more stable.
- Box file can be semantically versioned for the release of ODL GBP

Change-Id: I24eb68a22f3ec26edc3e7b52402acf5d64e5b56c
Signed-off-by: Keith Burns (alagalah) <alagalah@gmail.com>

Fixed NAT in OFOverlay based on EIG

- NAT is triggered when traffic goes between internal and external endpoint
- external/internal location was removed from ofoverlay EP augmentation
  because it is replaced with internal/external based on terminology below

Terminology:
- EIG: External Implicit Group - endpointgroup representing outside of policy domain
- internal endpoint: none of endpointgroups from endoint is EIG
- external endpoint: an endpointgroup from endpoint is EIG

Change-Id: Ib7b802948cc6dd109efde4ec7113c4b9038a7525
Signed-off-by: Martin Sunal <msunal@cisco.com>

Added NAT address for an endpoint-l3

Change-Id: Ica2661040c6f96f62fc823c785488c9c6a0ac865
Signed-off-by: Martin Sunal <msunal@cisco.com>

Endpoint processing more scalable

 - no processing was triggered after removing location
   augmentation from an endpoint
 - processing of events made more scalable
 - added test cases for removing/adding location
   augmentation from/to an endpoint

Change-Id: I5a9295a3e8b16d60921359887e9361302e926f55
Signed-off-by: Tomas Cechvala <tcechval@cisco.com>

statistics support

Change-Id: If61e5812a06f66432558830a3193308a32630e75
Signed-off-by: Matej Perina <matej.perina@pantheon.sk>

Integrating FAAS renderer with the faas fabric mapping services. Also,
put tenants external explicit groups in resolved policies to be accessible
by renderers.

Change-Id: I41447bb41c71ca1e6cfb4fa001c4dd736b02a37e
Signed-off-by: Khaldoon Al-zoubi <khalAlzoubi@gmail.com>

IOvisor policy processing

Change-Id: I0a37067028e69c048b8d3dcfdb744a2d3f15ba00
Signed-off-by: Keith Burns (alagalah) <alagalah@gmail.com>

Fixed Subtree typo

Change-Id: I5d4be5257deb9441ff8a64d4a3f25c220fad8559
Signed-off-by: Keith Burns (alagalah) <alagalah@gmail.com>

Added SFs, EP handling, Resolved Policy for IOVisorRenderer

- Cleaned up some core utils and IidFactory
- adding addition of IOVisor Module entry when Endpoint Aug is present

Change-Id: If8c952cc9b6f891eca7b88ccd63d6378bb2be6c9
Signed-off-by: Keith Burns (alagalah) <alagalah@gmail.com>

Merge "Directions and flow creation for symmetric chain corrected"

Fix for PolicyResolver multi-writer problem

Problem:
There was a listener per Tenant. Listeners tried to store resolved-policies
to datastore concurrently.

Fix:
Only one listener is registered for wildcard tenant. The listener handles all changes
in tenants.

Signed-off-by: Martin Sunal <msunal@cisco.com>

Fix for Neutron NB change 31324

Change-Id: I5600f4f853f4edc215bea24ef4aee936515d6f43
Signed-off-by: Keith Burns (alagalah) <alagalah@gmail.com>

Directions and flow creation for symmetric chain corrected

Signed-off-by: Vladimir Lavor.com <vladimir.lavor@pantheon.sk>
Change-Id: I9a2efbb3355936c3e974becd4062bfc92f2c5cb2

Merge "registration of action validators for to gbp-base"

Merge "Bug 3424 use MAC from external node connector"

Merge "Add missing license headers"

Merge "Clean up permissions on demo"

registration of action validators for to gbp-base

Change-Id: I062305d5c22493eb1d0040244f09134129723947
Signed-off-by: Michal Cmarada <mcmarada@cisco.com>

Bug 3424 use MAC from external node connector

Change-Id: I909cca7631eff92fa60d0c1375fde738956b8f0b
Signed-off-by: Martin Sunal <msunal@cisco.com>

Merge "Tenant name changed to be consistent with CSIT."

Add missing license headers

Change-Id: I6ebb47e4c9335682f16bff606108031770a61968
Signed-off-by: Thanh Ha <thanh.ha@linuxfoundation.org>

Registered simple classifier-instance validators

- classifier-instance validators based on renderer's capabilities
- this simple classifier-instance validators are registerd automaticly
if PolicyValidatorRegistry is available

Change-Id: Ie418fb7cebbd38fc25fdb7daed4f6745ac0fbe98
Signed-off-by: Martin Sunal <msunal@cisco.com>

making service for PolicyResolver and EndpointRpcRegistry

Change-Id: Ieb489292492a87be72800dde7841330eb1b3db9b
Signed-off-by: Michal Cmarada <michal.cmarada@pantheon.sk>
Signed-off-by: Vladimir Lavor <vladimir.lavor@pantheon.sk>

Clean up permissions on demo

Change-Id: I5a05811790026028da02a0cc04a8af5e49c5f973
Signed-off-by: Keith Burns (alagalah) <alagalah@gmail.com>

Fix .gitignore

renderers/ofoverlay/src/test/java/org/opendaylight/groupbasedpolicy/resolver/ should
not be ignored.

Change-Id: Ia7d0e24c948bb160fda0549fcb9686df81e0ae9a
Signed-off-by: Robert Varga <rovarga@cisco.com>

Bug 4724 added containers to tenant

Change-Id: Ibec940580f8ef9f741cdc4b4adf3f01bbf477e51
Signed-off-by: Martin Sunal <msunal@cisco.com>

Tenant name changed to be consistent with CSIT.

Change-Id: I582919e11a262f743512115a8a71cc90ec9c3cc3
Signed-off-by: Dileep <dileep.ranganathan@intel.com>

added .gitignore for demos

Signed-off-by: Martin Sunal <msunal@cisco.com>

added demos to the repo

Signed-off-by: Martin Sunal <msunal@cisco.com>

Moving of classes between packages in groupbasedpolicy

- classes are in packages based on type
- introduced EpRendererAugmentationRegistrar, PolicyValidatorRegistrar

Change-Id: Ia603624eeebd52821802f30f0adb2f18c5a59627
Signed-off-by: Martin Sunal <msunal@cisco.com>

Removed PolicyListener and PolicyResolver methods

- renderer should listen on resolved-policy from resolved-policy.yang
- removed public methods from PolicyResolver

Change-Id: Ife1e165b7264910a5be2f859b72f2b454dd04027
Signed-off-by: Martin Sunal <msunal@cisco.com>

Added interests to renderer.yang

Signed-off-by: Martin Sunal <msunal@cisco.com>

Add a REST APIs support for IOVIsor module

- provide aaa authentication
- path is: /controller/sb/iovisor/{SERVICE}

For now we have one service being: /policies
Through this one we will POST a list of policies for the
IOVisor module to GET.

To play with thee REST interface, you can use this
postman collection: https://www.getpostman.com/collections/3b1fe6ef1ec0ead72ee7

Another patch will implement the POST correctly

Change-Id: I5186df6b5d0501dca8b244bfd04e22dd54649b40
Signed-off-by: adetalhouet <adetalhouet@inocybe.com>

Removed mocks from unit tests

removed mocks breaking API contracts

Change-Id: Ie18f75c213d78c053102722f29450ed209ddb492
Signed-off-by: Martin Sunal <msunal@cisco.com>