git.opendaylight Code Review

Updated git submodules

Project: odlparent master 1fe85fda59f9bb9dd838c7903ea62a25a878d7bc

Add SpotBugs dependencies

SpotBugs is the maintained replacement for FindBugs, which has been
abandoned. See https://spotbugs.github.io/ for details.

This patch is phase 1 of the (long-term) migration from FindBugs to
SpotBugs: it adds the spotbugs-maven-plugin to plugin management with
the appropriate version specifications and default configuration.

Change-Id: I29a47604bdd25a20dc0fe56f41cd0083ad934e13
Signed-off-by: Stephen Kitt <skitt@redhat.com>

Updated git submodules

Project: bgpcep master f4b87f6ab68fbb8be93e6176cc0360e05bcc1bd8

Fix missing version for maven reports

Change-Id: I45f229b90731d22d1099d38c690b2e6bb8ad5763
Signed-off-by: Claudio D. Gasparini <claudio.gasparini@pantheon.tech>

Updated git submodules

Project: releng/builder master d3c4b28d550eaaeb69cc44744117189cd83ff2f0

Update to global-jjb v0.12.0

Change-Id: I0316072ca2a2a204c3e1da38315b4cb78ed65dc4
Signed-off-by: Thanh Ha <thanh.ha@linuxfoundation.org>

Updated git submodules

Project: netvirt master a1654d52ef4733dcbb952c24defb72a2d5e18877

Revert "INFRAUTILS-18: @Ignore AclServiceStatefulTest until JobCoordinator fixed"

This reverts commit fbde3eaa72bb40528df7bb482feef8103b812e9b,
because https://jira.opendaylight.org/browse/INFRAUTILS-18 is fixed.

Change-Id: I849d7c6abf5d53cf0d1cba5f8349318f6f45f0e8
Signed-off-by: Michael Vorburger <vorburger@redhat.com>

Updated git submodules

Project: genius master 5cbde4cb077fe5db5e00deeb4d34fbb29b8746aa

Handle logging symmetrically in FutureRpcResults

This patch treats logging and result (or error) processing
independently, in a symmetrical fashion for both success and error
cases.

* LogLevel handles the logging façade in front of Logger.
* A new NONE LogLevel allows logging (by the default handler) to be
disabled.
* The success log level is configurable (including NONE).
* The default consumers do nothing (logging is handled separately).
* The onSuccess/onFailure handlers follow the same pattern, and the
onFailure handler is re-used for external error handling.

Change-Id: Ie4f799d4ba655c438ac1616b04b323a11a913684
Signed-off-by: Stephen Kitt <skitt@redhat.com>

Updated git submodules

Project: genius master 0590bce7a1a3a19b854923d6ab7a21aba3321c7b

Refactor FlowBasedIngress/Egress classes to non-static

Change-Id: Idef01d927a79acd2cbad2a9f930de3f8244bacb7
Signed-off-by: Tom Pantelis <tompantelis@gmail.com>

Updated git submodules

Project: genius master 3e27aae03754437abfa66eec22f9a314a37f170a

Refactor AlivenessMonitorUtils to non-static

Change-Id: I940bfe61b6e18e54db18a5a5145e2d95fa688954
Signed-off-by: Tom Pantelis <tompantelis@gmail.com>

ODL Parent Oxygen M1 read-out

Change-Id: I6af301fbbee37195c8f78806f1e3ef820706b49f
Signed-off-by: Stephen Kitt <skitt@redhat.com>

Merge "Update unimgr docs for Presto NRP support"

Updated git submodules

Project: releng/builder master 797ef45fa024e6aa7bccb89388bd5abc53a22a0d

Add p4plugin jobs to Jenkins

Change-Id: Ic3e4e6d16a88f19c17346e363d8aefd22c6e520e
Signed-off-by: Wsx25289 <10200860@zte.com.cn>

Updated git submodules

Project: genius master 3a4853b5b001d087b1bcda53e8ee7c8c4603b550

Convert to JobCoordinator in interfacemanager

Also cleaned up some statics in the process.

Change-Id: I0f26b145e8d587554e6daff275a00218a65c1932
Signed-off-by: Tom Pantelis <tompantelis@gmail.com>

Updated git submodules

Project: infrautils master f5a8b0183899cc631e6ec5c22bb170d75f4ce2c0

StackTraces getCallerMethodName()

I'd like to use this in org.opendaylight.genius.infra.FutureRpcResults
to offer a variant without the explicit String rpcMethodName, and
instead implicitly get it from this.

This is motivated by seeing first users starting to adopt
FutureRpcResults, e.g. in I04553678580ff53217c7757594cdd836aa8abfae,
getting that rpcMethodName wrong (not once but twice).

Change-Id: Id67f619fabd390485b44420c5d5669f12e5fd82d
Signed-off-by: Michael Vorburger <vorburger@redhat.com>

Updated git submodules

Project: netconf master 4788b31c2c898c442309f9323580852e0752eae4

Restore the deprecated credentials name.

Renaming caused downstream breakage so restore the old name.

Change-Id: I835b178d8f62b1c693f81f11316eeb67c146bf8c
Signed-off-by: Tomas Cere <tcere@cisco.com>

Updated git submodules

Project: bgpcep master 048cf910960206bf92a7dbfbc1a02b24a41f6591

Create pcep topology parent aggregator

Change-Id: I3fbf0eb152ba84da138881f1080eb7b65d15469c
Signed-off-by: Claudio D. Gasparini <claudio.gasparini@pantheon.tech>
BUG-9079 Make PCEP session recoverable from exception

This patch makes PCEP session recoverable from any netty exception.
Whenever an exception happens, PCEP session will be closed. So it
will be at a clean state when the next session retry comes.

Change-Id: I38a983c44519fd5c12cb9cd0da09fa14c4177ac7
Signed-off-by: Kevin Wang <kevixw@gmail.com>

Updated git submodules

Project: genius master 689c44419ecd07139cb9089380753835ee49b140

Convert to JobCoordinator in idmanager-impl

Change-Id: I75a0edccef1b47ecf1c246c9e51e7717916f1da2
Signed-off-by: Tom Pantelis <tompantelis@gmail.com>

Updated git submodules

Project: infrautils master 12ec1270674b8349edb17b80946c5e1697f09f4d

INFRAUTILS-18: JobCoordinatorCounters should not be static

Changed JobCoordinatorCounters to a class wih AtomicLong fields.
Previously, it used OccurenceCounter internally which is essentially
an AtomicLong but has other fields which aren't used anywhere. In
addition, it internally stores each OccurenceCounter instance in a
static Set (ugh - more statics...). We don't need the added overhead
of OccurenceCounter.

Change-Id: I787500aec20215af5a14627af7be75cca03a61fa
Signed-off-by: Tom Pantelis <tompantelis@gmail.com>

Updated git submodules

Project: genius master 8e218f546fbeb34b1abe6c903fb80c4dcb2e6968

INFRAUTILS-18: TestableJobCoordinatorEventsWaiter 2 min. instead 30s

and include details of JobCoordinator state when stuck

Requires Iac27dbdd707a599fcb912bb68425e6cbe969d0e3 c/64806 in infrautils
for the new JobCoordinator toString() implementations.

Change-Id: Ibaf06bd75a8f5f5ba48ffc6e0f1c26fbab3d96f5
Signed-off-by: Michael Vorburger <vorburger@redhat.com>

Updated git submodules

Project: infrautils master 1c530a5ec2b12a425b18684348059aa0951b7246

INFRAUTILS-18: JobCoordinator toString()

so that we can get more details about it when it's "stuck"

Requires Ibaf06bd75a8f5f5ba48ffc6e0f1c26fbab3d96f5 (c/64805) in genius

Change-Id: Iac27dbdd707a599fcb912bb68425e6cbe969d0e3
Signed-off-by: Michael Vorburger <vorburger@redhat.com>

Updated git submodules

Project: netvirt master e33e94ff7729c54671f18d8eca4d26c451d3844f

Refactor/cleanup BgpConfigurationManager

- converted static fields to instance fields
- changed all instance fields to private
- removed unused fields/variables/code
- fix warnings

Change-Id: Ic6629f39558ec5280718c42d56a6af9c6a194e46
Signed-off-by: Tom Pantelis <tompantelis@gmail.com>

Updated git submodules

Project: netvirt master 886ccecc396ed98f28de7fe6d5f296f921e9600c

Convert dhcpservice to use mdsal EOS APIs

The controller EOS APIs are deprecated.

Change-Id: I2670160dd459b4f3ff64aff2a877b2a6f0683988
Signed-off-by: Tom Pantelis <tompantelis@gmail.com>

Updated git submodules

Project: coe master 6057ca8206275124f03c22e1c761086a4ac8efab

Update the watcher APIs

update the watcher APIs to match changes
that happen in the yang model

Change-Id: Iab9d0295701729adbe14db47ac389e063cd1e0f0
Signed-off-by: Mohamed ElSerngawy <m.elserngawy@gmail.com>

Updated git submodules

Project: integration/test master b0a7b6d8232a197a139412f7bef9a872b743e4f0

Migrate AAA CSIT to use Variables.robot from .py

Also removing unused, empty suite.

Change-Id: I1ad9c2951c73373dda4dc38f4bf77a33eba0822e
Signed-off-by: Jamo Luhrsen <jluhrsen@redhat.com>

Updated git submodules

Project: genius master 5bbfa094bb5be1ff03fe9d97d3f279d26985e81f

Fix the listeners closing process

In some cases, dataChangeListenerRegistration might be null, provoking
an NPE. This fixes that problem.

Change-Id: Iaa1a22a54b47b38783eddf15edbf42b14b0bb84a
Signed-off-by: David Suarez <david.suarez.fuentes@gmail.com>

Merge "Add BGP release session doc"

Merge changes from topic 'milestone-status'

* changes:
Structure M0 status for parsing
Add a script to generate M0 status

Update unimgr docs for Presto NRP support

Change-Id: Ie71e45274a88aa089463780f7583d04c3cc08bd8
Signed-off-by: Bartosz Michalik <Bartosz.Michalik@amartus.com>

Updated git submodules

Project: sfc master dd48656bc2f31601c27c2587b2818e906e6d90a7

Deprecate the abstract listeners included in sfc-provider

The AbstractClusteredDataTreeChangeListener and
AbstractDataTreeChangeListener are replaced by the classes present in
Genius' package org.opendaylight.genius.datastoreutils.listeners.

Change-Id: I2fcb0187e2b3f43b7ea9d872c50de1543e89f384
Signed-off-by: David Suarez <david.suarez.fuentes@gmail.com>

Updated git submodules

Project: sfc master 737725e4fb38e19e2dbcccccc5f447d8ae2f393e

Migrate the rest of the sfc-provider's listeners

Migrate the rest of the sfc-provider listener to use Genius' listeners

Change-Id: Idafd8020f1f7620ae22e7d894ac0c0a38e7285fb
Signed-off-by: David Suarez <david.suarez.fuentes@gmail.com>

Add BGP release session doc

Change-Id: I6b9c81dafc4191c6e608b2200eed71406c4adafc
Signed-off-by: Claudio D. Gasparini <claudio.gasparini@pantheon.tech>

Updated git submodules

Project: netconf master 4653c163772a24ebefdcb21a08315f539678ad4e

Merge "Remove the default loopback mount from the old connector feature"

Remove the default loopback mount from the old connector feature

This is conflicting in sft when two projects pull in the old feature
and the new clustered topology feature. Cfg subsystem should have no
users now so remove it.

Change-Id: I97819282f39af332fa78bf58cbb99321ffa79ae0
Signed-off-by: Tomas Cere <tcere@cisco.com>

Updated git submodules

Project: netvirt master fbde3eaa72bb40528df7bb482feef8103b812e9b

INFRAUTILS-18: @Ignore AclServiceStatefulTest until JobCoordinator fixed

Change-Id: I6f53a51a26442572a001db2cc5f49c062f2de1a5
Signed-off-by: Michael Vorburger <vorburger@redhat.com>

Updated git submodules

Project: netconf master 5503d46fd502913e25b978018a1fffa607b35d38

Merge changes from topic 'keyauth-refactor'

* changes:
  BUG-9261: rename pair-id to key-id
  BUG-9262 Add rpc for remove-device
  BUG-9261: Move keystore to use Config datastore.
  Do not return null in RpcHandlerDefault
  BUG-9261: Add basic public key auth to testtool
  BUG-9261: Add credential handler for PublicKey auth
  BUG-9261: introduce netconf keystore service
  BUG-9261: introduce new Credential types

BUG-9261: rename pair-id to key-id

Makes more sense since we are not dealing with pairs.

Change-Id: I3f15304506844a23232541703182c73a7256379d
Signed-off-by: Tomas Cere <tcere@cisco.com>
BUG-9262 Add rpc for remove-device

Change-Id: I0abb373b29e6c3e89b4b2c0b424782c57c70418e
Signed-off-by: Tomas Cere <tcere@cisco.com>
BUG-9261: Move keystore to use Config datastore.

We want the keystore persisted since we want to keep the
configuration valid across restarts so keep this in the persisted ds.

Change-Id: I806271f4fac3b66113253616baeedae42784896c
Signed-off-by: Tomas Cere <tcere@cisco.com>
Do not return null in RpcHandlerDefault

Change-Id: I692a03a65e1bd8dbd471ec2756320d374e397261
Signed-off-by: Tomas Cere <tcere@cisco.com>
BUG-9261: Add basic public key auth to testtool

Adds public key authenticator that accepts every connection to
testtool.

Change-Id: I49e98613cf5fb5dc33c8ccb465cdc16044b33f5e
Signed-off-by: Tomas Cere <tcere@cisco.com>
BUG-9261: Add credential handler for PublicKey auth

Change-Id: I073188bede6fb592147da5891793cf84abced276
Signed-off-by: Tomas Cere <tcere@cisco.com>
BUG-9261: introduce netconf keystore service

Change-Id: I97e1e65029c339bd28557787841d485392cf9c44
Signed-off-by: Tomas Cere <tcere@cisco.com>
BUG-9261: introduce new Credential types

Introduces credential types for:
  -encrypted passwords
  -unencrypted passwords
  -key-pair authentication

While keeping backwards compatibility with the old way of storing
credentials as a deprecated case.

Change-Id: Ifb7cfaa5284467639d6c0e1d8bac2b4b5876bedc
Signed-off-by: Tomas Cere <tcere@cisco.com>

Updated git submodules

Project: netvirt master 7a57198d127db52706009dc135180fd910748739

Bug9245: Table=21 related exceptions fixes

https://jira.opendaylight.org/browse/NETVIRT-940

Change-Id: I66ae23bd3fd9ad1e2a80648672f8120ffd3beea3
Signed-off-by: ehvkand <hanamantagoud.v.kandagal@ericsson.com>
Signed-off-by: HANAMANTAGOUD V Kandagal <hanamantagoud.v.kandagal@ericsson.com>

Updated git submodules

Project: infrautils master 1b3c5ee62a7d076833b55ca1fd4057785eb9e23a

Stop JobQueueHandler thread gracefully on destroy

In the JobCoordinatorImpl, we should stop the JobQueueHandler thread
as part of destroy. I've seen unit tests fail due to a
RejectedExecutionException from the fjPool (due to error logged
with the LogCaptureRule) b/c the thread isn't stopped.

Change-Id: Ib7ea6333f06406a77b5410868b9235a54b582033
Signed-off-by: Tom Pantelis <tompantelis@gmail.com>

Updated git submodules

Project: genius master 96a31e940c928a6d1db1dc7c3d49bf08e1703149

testutils InterfaceHelper with correct @NonNull read

Change-Id: I0936c2894c7cd153016b51dc5717c104714e1c27
Signed-off-by: Michael Vorburger <vorburger@redhat.com>

Updated git submodules

Project: genius master fbc84c5c40738f446bb32cd3026bd7334c39c54d

SRM: Add implementation code

This adds the following:
1. RPC Implementation in impl and required util class
2. CLI for SRM as mentioned in spec.
3. Debug CLI to clear out SRM operDS.

These cover Work Items 3 and 4 of SRM Spec.

Change-Id: I04553678580ff53217c7757594cdd836aa8abfae
Signed-off-by: Vishal Thapar <vishal.thapar@ericsson.com>

Updated git submodules

Project: netvirt master bdce2dc854bdc636961fd684ccedbd83dcea25eb

Use JobCoordinatorTestModule in aclservice component tests

This is required to be merged into netvirt at the same time as the
related change https://git.opendaylight.org/gerrit/#/c/60303/ goes into
genius; that one introduces the JobCoordinatorTestModule as part of
making genius' DJC delegate to infrautils' JC (and by doing so, breaks
the aclservice component tests).

Change-Id: I0f2c5258315f40f9db88806fe0a33619f0f7bb77
Signed-off-by: Michael Vorburger <vorburger@redhat.com>

Updated git submodules

Project: integration/test master 2366630d84886473298f9441bc3f0abed78f8d9a

IPv6: get IPV6_ADDR_POOL values from Variables

Get values for NET1_IPV6_ADDR_POOL and NET2_IPV6_ADDR_POOL from
netvirt/Variables.robot, instead of declare them at the beginning.

Change-Id: Idac6f6df96e95e7193bb756c3d5f657dd8e74034
Signed-off-by: Valentina Krasnobaeva <valentina.krasnobaeva@6wind.com>

Updated git submodules

Project: integration/test master 6c85946682eb1f2af02f495ff523ad2e36becb8e

CSIT: move NET1_IPV6_ADDR_POOL in Variables

Change-Id: If49d1179cdab507c351cbfab39afd4732a1ed75e
Signed-off-by: Valentina Krasnobaeva <valentina.krasnobaeva@6wind.com>

Updated git submodules

Project: integration/test master 3368174b1f602df2748aca11cf1e311614b5a42e

Fix VTN Coordinator Oxygen Job Failure

VTN Coordinator Oxygen fails to install VTN Coordinator.
* Path added to the test file to be able to download and install
VTN Coordinator.
* Patch also modifies the image path/name for Nitrogen/Carbon also.

Change-Id: I4882a1d6d7dfd837bf4e507b764802cfe6c54de4
Signed-off-by: ananth <ananth.y@hcl.com>

Structure M0 status for parsing

Change-Id: I5859f89e5f5440aae06b66db8fdfb3ecc6a0f257
Signed-off-by: Thanh Ha <thanh.ha@linuxfoundation.org>

Add a script to generate M0 status

New script generates M0 status report from all of the available m0
status documents. This requires that projects submit documents in a well
formed parsable text so we need to be more strict about formatting when
projects submit these documents.

Change-Id: Ib8bc0d18278d607379f6d1940669cf2fef1a0e10
Signed-off-by: Thanh Ha <thanh.ha@linuxfoundation.org>

Updated git submodules

Project: genius master e9b4ff57b74356e8ef0b5178924b3731f50e690e

Make @Deprecated DataStoreJobCoordinator delegate to infrautils'

In an ideal world, we would instead now switch all uses of the
@Deprecated DataStoreJobCoordinator everywhere in genius and netvirt to
the new infrautils' JobCoordinator @OsgiService instead of having to do
this, but I would propose to do it in 2 steps and get this in first
(now), and then starting migrating, and then once everyone is off
DataStoreJobCoordinator and there are no usages left, delete it.

At least like this we would have only one version of this code, instead
of maintaining 2 split incarnations in genius and infrautils.

Also, and importantly, this change includes new infrastructure making it
easy to use JobCoordinator in the netvirt aclservice and genius
interfacemanager component tests, as used in IdManagerTest, see also
TestableJobCoordinatorEventsWaiterTest.

This change must be merged into genius at the same time as
I0f2c5258315f40f9db88806fe0a33619f0f7bb77 will go into netvirt.

This change requires I5e423212e8f720fb4b20837f12ad59de6f2a66d4 in
infrautils.

This change includes the fix for bug GENIUS-93.

Change-Id: I2043d32d612fb63990721908ccfff33a3ddf0689
Signed-off-by: Michael Vorburger <vorburger@redhat.com>

Updated git submodules

Project: integration/test master 8055df6c2033a4216eebd1dc957987d7de2c9451

Remove VPN service and BGP VPN service

VPN service suite is already being run in
netvirt job, so don't run it again in the
l2gw job.

A new job will be created for BGP VPN
test suite.

Change-Id: Ia84de3da41c8e9155b217aeccd032c719bc06d6c
Signed-off-by: Victor Pickard <vpickard@redhat.com>

Updated git submodules

Project: integration/test master 39bdbc25b9d9fe7456d271aa6c7a4c03c6b3d55c

Remove unused BFD suite

this suite is not in use. Email discussion here:
https://lists.opendaylight.org/pipermail/genius-dev/2017-October/001929.html

Change-Id: Ibb121029e19a8ac5333895265217c742db69f613
Signed-off-by: Jamo Luhrsen <jluhrsen@redhat.com>

Updated git submodules

Project: integration/test master 206bf0e24e9980d6293c38c92368f33af334c327

Ignore pep8 E722

Existing code has started to fail on this error and causing
verify jobs to fail that have nothing to do with said existing
code. For now, we can ignore this to let work continue in
the int/test repo.

A jira ticket will be opened for someone to fix those related
erorrs (example below) and then remove this ignore = E722
statement.

Example:
./csit/libraries/AAAJsonUtils.py:208:13: E722 do not use bare except'
except:
^
Change-Id: Iee989ea6f2bcc3149988eb2e430fc7246c2d97e2
Signed-off-by: Jamo Luhrsen <jluhrsen@redhat.com>

Updated git submodules

Project: releng/builder master df471eb655b5343e5ea9359e5200cb2bddc75b01

Add case to capture exception log

Change-Id: I2610be4386c804e2667381b76347398ef4cbf47a
Signed-off-by: Sam Hague <shague@redhat.com>

Updated git submodules

Project: genius master 376ea56b13c0ee170566c3dc7d351325735ea509

JavaDoc for AbstractAsyncDataTreeChangeListener

Change-Id: Ie8acafc15f280c9a7e08c13a6dcbcb5d2ee0bdf5
Signed-off-by: Michael Vorburger <vorburger@redhat.com>
Signed-off-by: David Suarez <david.suarez.fuentes@gmail.com>

Fix formatting to remove block quotes

Change-Id: I18487a7712a33005d6779eb5ed518f9aedb267cf
Signed-off-by: Thanh Ha <thanh.ha@linuxfoundation.org>

Updated git submodules

Project: sfc master d5e94d3ee53ce1552e64f2cacee33ead4b27e6bc

Migrate ServiceFunctionChainListener to Genius' Listeners

Change-Id: I26eaa162202c497fd286d1c028216c519997e69b
Signed-off-by: David Suarez <david.suarez.fuentes@gmail.com>

Updated git submodules

Project: sfc master 2db2da7700557b01238ba2bc17f1e7c52bbe9f1f

Migrate ServiceFunctionForwarderListener to Genius' Listeners

Change-Id: Ie09ee0efe4fde576b366a95a85ff41cd55f87488
Signed-off-by: David Suarez <david.suarez.fuentes@gmail.com>

Updated git submodules

Project: genius master ab859e6ab07dfbc8b96912c9c5c861f56bd304dc

Remove IdManager from ItmManagerRpcService & ItmUtils as unused there

NB however that it *IS* used in some other ITM classes, incl. e.g.
ItmProvider, TransportZoneListener, ItmTepRemoveWorker, ItmTepAddWorker.

Change-Id: I8fa1f2f21dd9de343ba45c5bfa80e674c880d78e
Signed-off-by: Michael Vorburger <vorburger@redhat.com>

Updated git submodules

Project: genius master fec0073065ffaac5207b22aeaecf7996c6ff63bd

Add component-based removeFlow()

... which will be used in NetVirt to simplify flow removal methods.

Change-Id: Id882570c15f018ce751b3829fac4a446f4aecfc8
Signed-off-by: Stephen Kitt <skitt@redhat.com>

Updated git submodules

Project: genius master 17d37057bc0d5d0f660db55f28fc9bc9fb3ac452

Interface manager: split makeTunnelIngressFlow

Having separate add/remove methods allows the removal path to be
simplified, and avoids having an obscure “addOrRemove” parameter.

Change-Id: Ie144e64fd8ab6cc84cfb1ed9ebc265df00e8e6b7
Signed-off-by: Stephen Kitt <skitt@redhat.com>

Updated git submodules

Project: genius master ab2faf37a4795404152f6c867564d5f42bcdb86d

Aliveness monitor: manage transactions

Use the transaction manager to handle all write transactions.

Change-Id: I8d8b4d4fbf1bb03aaee54e19f37d2345dc36bb56
Signed-off-by: Stephen Kitt <skitt@redhat.com>

Updated git submodules

Project: netvirt master 78ed7962fdc857d0f06e87e84aac8691132a701f

Convert aclservice-impl to use mdsal EOS APIs

The controller EOS APIs are deprecated.

Change-Id: I8471f5e1734d12ce88d05e1ff9ee120822e591eb
Signed-off-by: Tom Pantelis <tompantelis@gmail.com>

Updated git submodules

Project: netvirt master a0a50eed57b327df5338fcb61f6d812bed7af76a

Convert neutronvpn-imp to use mdsal EOS APIs

The controller EOS APIs are deprecated.

Change-Id: I9c4fba9147a72ab48ff7bc1bdb38a02a8c38515e
Signed-off-by: Tom Pantelis <tompantelis@gmail.com>

Updated git submodules

Project: netvirt master 9af10efe3016eea3de1f203538ac1966d54421e7

Convert elanmanager-impl to use mdsal EOS APIs

The controller EOS APIs are deprecated.

Change-Id: Ic0b4cbc2fc6b3e11958841d2704407f38edf7504
Signed-off-by: Tom Pantelis <tompantelis@gmail.com>

Updated git submodules

Project: netvirt master d3ac7e5e5be4fe913d8eb919c4b20b1c0d89a7d4

Convert vpnmanager-impl to use mdsal EOS APIs

The controller EOS APIs are deprecated.

The ArpMonitoringHandler previously used the EntityOwnerUtils to
register its candidate which has the side effect of registering
a global EntityOwnershipListener that maintains local ownership
state for all entities in a static cache. It also stores change
events in a static (unsycnhronized) EVENTS_HISTORY list which grows
unbounded. It seems this is only used in one place to print the
history via a CLI command. Both these side effects are problematic
and I don't think need/should be propagated forward.

Change-Id: Ied8e3f061c798de9a0e8af97e13fc9dd7e5d51a6
Signed-off-by: Tom Pantelis <tompantelis@gmail.com>

Updated git submodules

Project: releng/builder master cc5e42171b07d6abdafc30a79d69b49a6e163500

Merge "Fix for generating log.html in Netvirt CSIT jobs"

Fix for generating log.html in Netvirt CSIT jobs

This patch adds "--flattenkeywords" option to pybot so that
we can avoid the debug from the loops in the test cases.
suggestion based on this url -[0]
[0]- https://github.com/robotframework/robotframework/issues/1833

Change-Id: Iebdf0745666a8c009ddab1292d4c2b8986207418
Signed-off-by: gvrangan <venkatrangang@hcl.com>

Updated git submodules

Project: releng/builder master 0b05846188c0cab8aa0b7f08fa41fd268e1f4221

Merge "Rename l2gw csit trigger for netvirt"

Rename l2gw csit trigger for netvirt

Make the trigger for l2gw csit consistent between ovsdb
and netvirt.

Going forward, to trigger the l2gw csit for netvirt patches:
test-netvirt-l2gw

for ovsdb patches:
test-ovsdb-l2gw

Change-Id: I5f5e2f48dc4aaa9cc2b5b5cc58fd5b49edee8822
Signed-off-by: Victor Pickard <vpickard@redhat.com>

Merge "Make project name consistent between m0 and m1"

Make project name consistent between m0 and m1

Project names are inconsistent between m0 and m1 milestone
readouts.

Change project names in m0 and/or m1 for inconsistent
projects to make them consistent.

Change-Id: I89139d2e4997ce85d91f1ea1bd1e348d5c8862e4
Signed-off-by: klou <klou.external@gmail.com>

Updated git submodules

Project: ovsdb master bf3ddd35cfe8293cc9dfb99b2222c386a0e33ad3

bug 8712 vlan bindings update fix

when global node and physical switch node are updated in same transaction
from application, vlan bindings are missing.

Make vlan bindings participate in dependency workflow.

Do not create/delete port from controller.
Only update the port from controller.
port creation happens from device always.

Added port reconciliation when port is added later.

Change-Id: Ic86a3545428e186f3aeb26c8a36a783f774ecf53
Signed-off-by: K.V Suneelu Verma <k.v.suneelu.verma@ericsson.com>
bug 7599 avoid unnecessary mdsal reads

avoid the un necessary reads.
skip monitoring version column

Change-Id: I82e50b973a93c57eb65dd34c6dd624c8e47e2344
Signed-off-by: K.V Suneelu Verma <k.v.suneelu.verma@ericsson.com>

Updated git submodules

Project: netvirt master b48fb802cbfbb7f5fa39a6a3e39dc50f97897e98

NETVIRT-926 - Maxpath value should be between 1 to 64 in BGP multipath

Adding a check to ensure maxpath value for BGP multipath is in the range 1 to 64

Change-Id: I6797caca05efe35242ed6a44b73ca28827b5edfe
Signed-off-by: Gowri R <gowri.r@ericsson.com>

Updated git submodules

Project: netvirt master 8578c324970e83e30bb10b8bdd85620ffe980599

Bug 9234: CSS programmed wrongly with TOR mac

With these changes following improvement has been done.
1. All cache update are now happening inside DJC job .(DPNInterfaces
cache , ELan L2gwDevices , ELan Devices and Mac addresses)
2. Upon node Disconnect macs are not being withdrawn now from other
devices.
3. Upon node reconnect macs are scanned for stale entries and are
cleared .

LocalUcastMacListener has been added newly with the new childListener
class which listenes to parent node and processes child node if
required.
DPN cache , TOR cache and Mac cache were not synchronized properly
,leading to race conditions which is fixed in this.

Change-Id: I440e17750c86bc132b75222a91a06654126f9b75
Signed-off-by: eaksahu <a.k.sahu@ericsson.com>

Updated git submodules

Project: netvirt master 0a7fbc937676e07eda33d5f026241b47a9b26bbb

Refactor/cleanup BgpRouter

- eliminated static instance
- converted static nature of fields to class fields
- removed unused fields

Change-Id: Ia7264795ccedb34125da8e35d756ddd3df18643b
Signed-off-by: Tom Pantelis <tompantelis@gmail.com>

Updated git submodules

Project: netvirt master 468e422d0c974775daa00d30601bb4975a221fac

Updated to use bind-service update instead of bind and unbind in Acl VPN
listener

This commit has a dependency on below genius commit:
https://git.opendaylight.org/gerrit/#/c/64123/

Depends-On: Ib05a8fcfac8e74fa5a925edd0db49b7254bbed6a
Change-Id: I3acfe6f7f3f3e98139eb2413774d559ba8c25f8d
Signed-off-by: Shashidhar Raja <shashidharr@altencalsoftlabs.com>

Updated git submodules

Project: genius master 5fa214a8a771af24af3a70077db87dea57bf97c1

Enable bound services update

An update for bound services was ignored by the Bound Services Listener.
It has to be allowed for ACL Service in order fix breakage in
communication between two tenant networks using default security groups
(stateful mode).

Change-Id: Ib05a8fcfac8e74fa5a925edd0db49b7254bbed6a
Signed-off-by: Shashidhar Raja <shashidharr@altencalsoftlabs.com>
Signed-off-by: Sam Hague <shague@redhat.com>

Updated git submodules

Project: sfc master 1a78ea1a330928b130cc0c6a3c6418ee4140ce9f

Migrate ServiceFunctionListener listener to use the new Listeners FW

Migrate the ServiceFunctionListener listener to use the new Listeners
framework available since [1].

[1] https://git.opendaylight.org/gerrit/#/c/59177/

Change-Id: Ie7306de4cf4af48d88a645dd872a3143337be5c7
Signed-off-by: David Suarez <david.suarez.fuentes@gmail.com>

Merge "VTN Oxygen M1 Status"

Updated git submodules

Project: coe master 4f990d16b00e2035cf060b157b1f1f7ea783dc31

Add the endpoints attributes

Adding the endpoints attributes in order to
have the related info of pods and services

Change-Id: I85675a59286ef11c5cdac1c817477dcb0193076f
Signed-off-by: Mohamed ElSerngawy <m.elserngawy@gmail.com>

VTN Oxygen M1 Status

Change-Id: Ic0d840b0407e3387c688495df97477e931e0b5d9
Signed-off-by: ananth <ananth.y@hcl.com>

Updated git submodules

Project: releng/builder master 72703eb8650fc7cbb38b7fd5fba10e3fb9785e73

Bump stack timeout to 15 minutes

Also lower stack retries to 2. This ensures that the overall timeout of
the job does not increase too. This is an attempt to workaround RS
potentially taking too long to spin up servers as a reason the nodes are
not coming online.

Let us see if a 15 minute timeout improves the situation any.

Change-Id: I2ed403aab37233b2e69022daf7e0f58dff8fc3c9
Signed-off-by: Thanh Ha <thanh.ha@linuxfoundation.org>

Updated git submodules

Project: netconf master 31cdc343cbeb04eebcfc6775608b3e1a97da3768

Merge "Add missing flush() on buffered writer."

Add missing flush() on buffered writer.

Missing flush caused, that backing ByteArrayOutputStream was empty
and thus mounted resources was not showing up in apidoc.

Change-Id: I14445b9f85cea1918321e59519129e21cb37dd81
Signed-off-by: Andrej Záň <andrej.zan@pantheon.tech>

Updated git submodules

Project: infrautils master 6fde16dbe296143182342db4ad3046d5e07b0302

JobCoordinatorImpl OSGi service re. via BundleActivator instead BP

Required (temporarily) by I2043d32d612fb63990721908ccfff33a3ddf0689

Will probably be reverted once DataStoreJobCoordinator is removed.

Change-Id: I5e423212e8f720fb4b20837f12ad59de6f2a66d4
Signed-off-by: Michael Vorburger <vorburger@redhat.com>

Updated git submodules

Project: genius master 605c8e3778e45ceca405470c027834c744835966

Fix broken netvirt build following TestInterfaceManager change

Several tests in netvirt (in both aclservice and elanmanager) actually
use TestInterfaceManager without a DataBroker... so the netvirt build
broke following merge of I873999721e135c3cc968ef0d1aa239d794d12cb3.

My first attempt in I31ab80c583c2f1da73edc5b42cd7419311897bae was to
"just" fix those tests, but after 1h into that I'm giving up (and will
let Riyazahmed Talikoti finish it up), and instead put together this
workaround, which basically lets one still use TestInterfaceManager
without a DataBroker, like before, for now.

Change-Id: I3a9b551acd4b145af18d41549fba1fc25e4cf0ea
Signed-off-by: Michael Vorburger <vorburger@redhat.com>

Merge "LISP Flow Mapping Oxygen M1 Status"

LISP Flow Mapping Oxygen M1 Status

Change-Id: I93798c5e88ac196ba8e6bf52c301b399fcdc91fd
Signed-off-by: vermagan@cisco.com <vermagan@cisco.com>

Updated git submodules

Project: genius master 4cdeb76fdc0541a50b37a5673cb049de018992b2

RetryingManagedNewTransactionRunner for OptimisticLockFailedException

TODO in xN future follow-up changes: Start fixing (many)
OptimisticLockFailedException that appear in logs, by using this... ;)

Change-Id: I8fee2b50b562dc2c0f416d59082ad4bded0cdf58
Signed-off-by: Michael Vorburger <vorburger@redhat.com>

Updated git submodules

Project: aaa master fd35cb9dfbbad96bed772c73eec38fef02b898ef

BUG-9261: add PKIUtil decrypt overloads for StringReader

Change-Id: If22b57e300873211887deb9b0eb718b5482b764c
Signed-off-by: Tomas Cere <tcere@cisco.com>

Updated git submodules

Project: genius master c5ef29f711c9af34229c45ab8162a70212d67d26

DataBrokerFailures failSubmits with int howManyTimes

This is particularly useful e.g. to test OptimisticLockFailedException,
and will be used in I8fee2b50b562dc2c0f416d59082ad4bded0cdf58.

Change-Id: I775f394d30b67e69d59560f8f3b8f2a750373155
Signed-off-by: Michael Vorburger <vorburger@redhat.com>

Merge "SNMP4SDN M1 status"

Updated git submodules

Project: netvirt master 2ff79cb741171714b8a78c2e1e01d20326a53c41

Refactor qosservice-mpl to remove statics

Several of the classes contained static fields and methods which
generally isn't best practice. Most of it centered around QosNeutronUtils
where users of the class pass service instances, eg DataBroker,
INeutronVpnManager et al, into the static methods. Instead of
QosNeutronUtils being static, I changed it to a singleton with the
services injected. This simpplifies users as they no longer have to
inject the services merely to pass into QosNeutronUtils methods.

Change-Id: Ib3c5efc1224979cd9b800d82fca1b631af9cf403
Signed-off-by: Tom Pantelis <tompantelis@gmail.com>
Convert qosservice-impl to use mdsal EOS APIs

The controller EOS APIs are deprecated.

Change-Id: I5f10f11322e1533c540821726649c61acf48ae35
Signed-off-by: Tom Pantelis <tompantelis@gmail.com>

SNMP4SDN M1 status

Change-Id: I295a513f4cc834050490134b0a611d79e16819cd
Signed-off-by: ylhsieh <ylhsieh@itri.org.tw>

Merge "Genius Oxygen M1 Status"

Updated git submodules

Project: integration/test master 70a22bad1af960642b2452339758ececff9706c3

Add a snippet about using jjb-deploy keyword

Change-Id: Ia3c1a602a7c629943c906ca3bbb57152bd66e98c
Signed-off-by: Jamo Luhrsen <jluhrsen@redhat.com>

Genius Oxygen M1 Status

Change-Id: I5ec1b60d6c05b4dc4260c6c011c9c13c72f35c32
Signed-off-by: Vivek Srivastava <vivek.v.srivastava@ericsson.com>

Merge "OVSDB Oxygen M1 Milestone"

Merge "Add BGPCEP submodule and BGP Cli documentation"

Updated git submodules

Project: sfc master 10929bcbd6ba0c0bc870c92012447959a0800f62

Minor cleanup

More changes will follow.

Change-Id: Ib4a0a2adb59ea206fc7d27cf68201732653db508
Signed-off-by: David Suarez <david.suarez.fuentes@gmail.com>

Updated git submodules

Project: sfc master 2803b69599b3f669488f414f3a9625687e769f99

Minor cleanup

Change-Id: I5023ca7b29220611c4b5545ce800ea958cee111f
Signed-off-by: David Suarez <david.suarez.fuentes@gmail.com>

Add BGPCEP submodule and BGP Cli documentation

Change-Id: Iee7d89a8b1ff1cc707afe9683eb794a8bff2dc53
Signed-off-by: Claudio D. Gasparini <claudio.gasparini@pantheon.tech>

Updated git submodules

Project: genius master 4b7a73a7315deb2578954ffb0be8dc524bbed9b9

TestStubs for Elan-Evpn Junit

Teststubs are written for InterfaceManager and ITM
Right now these stubs contains testcode mainly required by Elan. These can
be expanded as we write more testcases.

Added addInterfaceInfo and addTunnelInterfaceInfo methods.

Elan Junit Testcases are written and raised as seperate review in netvirt
https://git.opendaylight.org/gerrit/#/c/62894/

Change-Id: I873999721e135c3cc968ef0d1aa239d794d12cb3
Signed-off-by: Riyazahmed D Talikoti <riyazahmed.d.talikoti@ericsson.com>

Updated git submodules

Project: genius master 1094c4a9eb8c1d32ea0c2da449a883e5c5899d74

Use JobCoordinator in TestableJobCoordinatorEventsWaiter

Added support for JobCoordinator in TestableJobCoordinatorEventsWaiter.
Support for DataStoreJobCoordinator was retained for now for
compatibility.

The other alternative is to move TestableJobCoordinatorEventsWaiter et al
to infrautils, see https://git.opendaylight.org/gerrit/#/c/64468/, but
it got -1. Maybe we can revisit that later.

Change-Id: Id483fbb1515c24d448e874ba358dd5477fa0c53a
Signed-off-by: Tom Pantelis <tompantelis@gmail.com>

OVSDB Oxygen M1 Milestone

Change-Id: I8075cf6f2af772b2b3349ae0de5bc360b00fc7b5
Signed-off-by: Anil Vishnoi <vishnoianil@gmail.com>

Updated git submodules

Project: genius master f165dd51e277545aa55b8c76dae0022cb4014cdc

ManagedNewTransactionRunnerImplTest with new negative DB failure tests

These 2 new tests will be customized in
I8fee2b50b562dc2c0f416d59082ad4bded0cdf58 to illustrate how the
RetryingManagedNewTransactionRunner, contrary to the
ManagedNewTransactionRunnerImpl, handles the
OptimisticLockFailedException.

Change-Id: I8e0da146cde5ddd853f9f388cf2ee6ba895ef086
Signed-off-by: Michael Vorburger <vorburger@redhat.com>

Updated git submodules

Project: netvirt master a7ebebb119395a98fcbb6a3af4765b23547ec930

Replace deprecated Futures.addCallback by the newer version

The method addCallback(ListenableFuture<V> future,
FutureCallback<? super V> callback) is deprecated and will be replaced
by a new its new version addCallback(ListenableFuture<V> future,
FutureCallback<? super V> callback, Executor executor) in April 2018.

Some other minor changes to pass the new version of checkstyle.

Change-Id: I3e288aad0aeee3e5f8cc9aeb777dd3d2cfb5c00a
Signed-off-by: David Suarez <david.suarez.fuentes@gmail.com>