Keith Burns [Tue, 10 Dec 2013 17:55:08 +0000 (09:55 -0800)]
- Added insertMirrorRow
- Fixed bug in _insertTableRow for trIndex=0
- Added "mirrors" to Bridge Table
- removed println debugging
Change-Id: I6fa0917d67ed69bfe18ac46003295dac0db5f0ab
Signed-off-by: Keith Burns <alagalah@gmail.com>
Brent Salisbury [Sun, 8 Dec 2013 05:11:57 +0000 (05:11 +0000)]
Merge "Added resources/ folder to track all the associated scripts and config files."
Brent Salisbury [Sun, 8 Dec 2013 05:11:28 +0000 (05:11 +0000)]
Merge "Installing NORMAL rules on all the default neutron bridges."
Madhu Venugopal [Sat, 7 Dec 2013 13:57:01 +0000 (05:57 -0800)]
Added resources/ folder to track all the associated scripts and config files.
Currently it is sub-divided into 2 directories : openstack and commons.
commons/ contains all the common script/config files such as POSTMAN scripts.
openstack/ contains all the openstack/devstack related config and scripts.
Each of these directories contain README.
We can expand this resources/ directory with more scripts as we see fit.
Change-Id: I86e7f82bfe0916b29fc069d62fb99a4a265156d8
Signed-off-by: Madhu Venugopal <mavenugo@gmail.com>
Madhu Venugopal [Fri, 6 Dec 2013 21:27:30 +0000 (13:27 -0800)]
Installing NORMAL rules on all the default neutron bridges.
Opendaylight controller's OF1.0 plugin deletes all the OF rules upon initial connection.
This could be a valid scenario on regular scenario, but it breaks some basic assumptions
in a Openstack/devstack deployment. Hence this fix will override that behaviour by installing
a NORMAL rule as the default rule to avoid data traffic to be punted to the controller.
This is a temporary measure to solves some major issues seen on couple of deployment scenarios.
We will address it more elagantly once we integrate with the new OF plugin.
Change-Id: Ie53c85c3e1549d07392d6c8129adb05806ed32cd
Signed-off-by: Madhu Venugopal <mavenugo@gmail.com>
Madhu Venugopal [Fri, 6 Dec 2013 07:02:42 +0000 (07:02 +0000)]
Merge "- Addressed Queue/QoS special parent column type dependency - New files found, and added to branch - Saving changes before trying SSL (0|1) check. - Complete insert sFlow insert/delete. - Modified integer type in QoS table, insert/delete for QoS and Queue ROOT tables - Added Queue table insert/delete operations (ROOT TABLE) - Netflow table insert/delete plus changes to Bridge and Netflow table definitions. - Fixed NetFlow table (wrong tablename) - Complete insert/delete Manager row - Capability row unable to be tested."
Keith Burns [Fri, 29 Nov 2013 23:05:03 +0000 (15:05 -0800)]
- Addressed Queue/QoS special parent column type dependency
- New files found, and added to branch
- Saving changes before trying SSL (0|1) check.
- Complete insert sFlow insert/delete.
- Modified integer type in QoS table, insert/delete for QoS and Queue ROOT tables
- Added Queue table insert/delete operations (ROOT TABLE)
- Netflow table insert/delete plus changes to Bridge and Netflow table definitions.
- Fixed NetFlow table (wrong tablename)
- Complete insert/delete Manager row
- Capability row unable to be tested.
Change-Id: Iaedad50f0c15a87179904b7ca01983cd7febc4ce
Signed-off-by: Keith Burns <alagalah@gmail.com>
Madhu Venugopal [Thu, 5 Dec 2013 08:24:34 +0000 (00:24 -0800)]
Made changes in Internal Network creation to also takes care of creating br-int & its patch-ports if they are missing.
Please note that the current implementation creates br-int, br-tun and the patch ports upon detecting a new Node.
This can be improved by creating these bridges just when the Neutron events begin. Since this functionality is now
boxed into a single method call, it can be taken care as a future fix.
Change-Id: I71f52348d042a8ef1653fcd8e094a7a1d87d78d6
Signed-off-by: Madhu Venugopal <mavenugo@gmail.com>
Hugo Trippaers [Tue, 3 Dec 2013 21:55:22 +0000 (22:55 +0100)]
Make the eventHandler more robust. Set broad exception handlers on the process functions to catch exceptions that would otherwise cause the thread to break.
Change-Id: I7f21daba508b32e556af5215d8a3d5f4426a35ae
Signed-off-by: Hugo Trippaers <hugo@trippaers.nl>
Brent Salisbury [Wed, 4 Dec 2013 16:14:14 +0000 (16:14 +0000)]
Merge "Identifying and ignoring uninterested SouthBound updates."
Brent Salisbury [Wed, 4 Dec 2013 16:11:17 +0000 (16:11 +0000)]
Merge "Fixed JSON Deserializer to retain empty objects as empty rather than NULL. During Update operations, ovsdb-server sends NULL values for the columns that are not changed. If there is a change from an empty map to valid value, then that change goes undetected. Hence we need to retain the emptiness of the map and array intact in order to differentiate the behaviour."
Madhu Venugopal [Wed, 4 Dec 2013 12:23:43 +0000 (04:23 -0800)]
Identifying and ignoring uninterested SouthBound updates.
Neutron bundle relies heavily on the Southbound events, especially the updates for its basic operations.
Many updates, especially the Packet statistics updates from Interface table are fast and furious and we
end up processing a lot of it unneccessarily. Due to the current implementation philosophy of maintaining
absolutely minimum cache in the neutron bundle, it relies heavily on the existing network states. Hence
such updates ends up reaching various layers. Hence identifying those updates and ignoring them becomes
critical for the stability of the system.
Change-Id: I10eb492e6e16be7931ec094bfcff54cc6b8696d6
Signed-off-by: Madhu Venugopal <mavenugo@gmail.com>
Madhu Venugopal [Wed, 4 Dec 2013 00:41:21 +0000 (16:41 -0800)]
Fixed JSON Deserializer to retain empty objects as empty rather than NULL.
During Update operations, ovsdb-server sends NULL values for the columns that are not changed.
If there is a change from an empty map to valid value, then that change goes undetected.
Hence we need to retain the emptiness of the map and array intact in order to differentiate the
behaviour.
Change-Id: I9ff356c0f390aeaf0cb5d43bd2ba756206f3e345
Signed-off-by: Madhu Venugopal <mavenugo@gmail.com>
Hugo Trippaers [Tue, 3 Dec 2013 13:49:07 +0000 (14:49 +0100)]
Get rid of all e.printStackTrace() statements and cleanup some exception handling.
Change-Id: I6bb8c4fc8c3315dcd909ab4b35a1bd5b8ebf1f13
Signed-off-by: Hugo Trippaers <hugo@trippaers.nl>
Hugo Trippaers [Fri, 29 Nov 2013 13:47:50 +0000 (14:47 +0100)]
When the controller already exists, the caller still expects to get its uuid.
Change-Id: I7f2aac02ae2d6b678abb4cd0866dcd6ee287604a
Signed-off-by: Hugo Trippaers <hugo@trippaers.nl>
Hugo Trippaers [Thu, 28 Nov 2013 22:43:13 +0000 (23:43 +0100)]
Introduce a root pom in the top of the project.
Change-Id: I487312165dd5223d04b1d6bc91111a61c61b7713
Signed-off-by: Hugo Trippaers <hugo@trippaers.nl>
Hugo Trippaers [Thu, 28 Nov 2013 21:05:14 +0000 (22:05 +0100)]
Fixup the pom files to add neutron to the main build profile and add both neutron and northbound to the distribution pom
Change-Id: I5d4f1d6e826b6d17e6e325d67d03facc011dbf02
Signed-off-by: Hugo Trippaers <hugo@trippaers.nl>
Madhu Venugopal [Fri, 29 Nov 2013 17:27:38 +0000 (09:27 -0800)]
Modified the insertRow methods to return StatusWithUuid instead of Status
This is in addition to Hugo's existing fixes.
Change-Id: I9671ee4afbd5e29c29e2b762f2dca91019db1e02
Signed-off-by: Madhu Venugopal <mavenugo@gmail.com>
Madhu Venugopal [Fri, 29 Nov 2013 16:45:51 +0000 (08:45 -0800)]
Simple Null check missing in setOFControllers when there are no existing bridges.
Change-Id: Icf8ffc49d0c3ebbe9ea9ead3a04a7fd0e5be8754
Signed-off-by: Madhu Venugopal <mavenugo@gmail.com>
Madhu Venugopal [Thu, 28 Nov 2013 19:27:47 +0000 (19:27 +0000)]
Merge "Enabling LLDP programming again. Upon debugging, it was found that the timeouts and instability observed on the controller were due to permgen issues (caused by multi-node devstack consuming up most of the laptop memory)."
Madhu Venugopal [Thu, 28 Nov 2013 19:27:17 +0000 (19:27 +0000)]
Merge "Minor Logging issues and removing an annoying error false positive message"
Madhu Venugopal [Thu, 28 Nov 2013 18:28:03 +0000 (10:28 -0800)]
Enabling LLDP programming again.
Upon debugging, it was found that the timeouts and instability observed on the controller were due to
permgen issues (caused by multi-node devstack consuming up most of the laptop memory).
Change-Id: Ic401615d67bd59f79369d3ff69429a2b366e817f
Signed-off-by: Madhu Venugopal <mavenugo@gmail.com>
Madhu Venugopal [Thu, 28 Nov 2013 18:17:41 +0000 (10:17 -0800)]
Minor Logging issues and removing an annoying error false positive message
Change-Id: I0439972846bd69e96555e6e8cc97c4dc226bc3d1
Signed-off-by: Madhu Venugopal <mavenugo@gmail.com>
Brent Salisbury [Thu, 28 Nov 2013 09:28:35 +0000 (09:28 +0000)]
Merge "Disabling the installation of LLDP Punt rules to Controller."
Madhu Venugopal [Thu, 28 Nov 2013 09:25:02 +0000 (01:25 -0800)]
Disabling the installation of LLDP Punt rules to Controller.
In a multi-node devstack setup, LLDP installation seems to cause issues with the Controller
(CPU spike and some OF message timeouts). It is better to debug that and once we have an idea,
we can enable it again. There is NO functional impact to the Neutron integration with OVSDB
by disabling LLDP flow installation.
Change-Id: I51e64253e09b6e863e2eea89f2570e436d3cc93f
Signed-off-by: Madhu Venugopal <mavenugo@gmail.com>
Madhu Venugopal [Thu, 28 Nov 2013 08:57:37 +0000 (08:57 +0000)]
Merge "Made changes to exception throwing."
Madhu Venugopal [Thu, 28 Nov 2013 08:14:26 +0000 (00:14 -0800)]
Broadcast/Unknown unicast support. Also added LLDP punt to Controller.
Change-Id: Ia36ddd7f8cbdcb9f9ed164ffbc7332b5763fc931
Signed-off-by: Madhu Venugopal <mavenugo@gmail.com>
Keith Burns [Tue, 26 Nov 2013 23:37:37 +0000 (15:37 -0800)]
Made changes to exception throwing.
Change-Id: I8615f44e8dd98302d5ddc54b548640a1f969ef0b
Signed-off-by: Keith Burns <alagalah@gmail.com>
Madhu Venugopal [Tue, 26 Nov 2013 19:35:46 +0000 (11:35 -0800)]
OF Flow programming on br-int (NORMAL) and bidirectional br-tun (based on tenant mac/vlan)
Change-Id: I611e8fed23996b3b03a77640853fadb38b8c9513
Signed-off-by: Madhu Venugopal <mavenugo@gmail.com>
Madhu Venugopal [Tue, 26 Nov 2013 10:34:19 +0000 (02:34 -0800)]
Consolidated Container logic in 1 place and is configurable. Also fixed OF controller connection for br-tun.
Change-Id: I33f4986317f386b5707e95cb90f7db532812159c
Signed-off-by: Madhu Venugopal <mavenugo@gmail.com>
Keith Burns [Tue, 26 Nov 2013 01:14:12 +0000 (17:14 -0800)]
Refactored delete{Table}Row to use generic _deleteTableRow()
Signed-off-by: Keith Burns <alagalah@gmail.com>
Madhu Venugopal [Sun, 24 Nov 2013 13:30:46 +0000 (05:30 -0800)]
VM location aware of Full-mesh Tenant-specific GRE Tunnel support over OF1.0 datapath.
This push also includes the following major changes :
1. OVSDB Port tagging on the internal integration bridge (br-int) on Tenant VM connected ports
2. Proper Container support with Flow Spec (internal Vlan) and Openflow ports as Container NodeConnectors
3. Moved most of the logic away from the Neutron Northbound Handlers to the Southbound Handler
4. More fixes to make the OVSDB bundles restartable without the need to force restart the Openstack components.
5. Moved the Southbound events to be handled in its own event thread.
Change-Id: Icb9ffc3a18f1dc15ca0b459ab690d98ce5d91b8f
Signed-off-by: Madhu Venugopal <mavenugo@gmail.com>
Madhu Venugopal [Sat, 23 Nov 2013 01:06:18 +0000 (17:06 -0800)]
Added br-tun bridge installation code via InternalNetworkManager in cases when the Node is not ready for overlay.
In DevStack environement, the Controller node is also used as compute. But the OVS is not populated with the
appropriate internal networks (such as br-tun and the corresponding patch-ports).
Witht his commit, this condition is identified and appropriate installation is done on the br-tun and br-int.
Change-Id: I8f1f65da864bd8a016912b46dbed3ed9a926ef2e
Signed-off-by: Madhu Venugopal <mavenugo@gmail.com>
Madhu Venugopal [Fri, 22 Nov 2013 21:01:27 +0000 (13:01 -0800)]
Skeleton code for the NetworkManagers : Provider, Internal and Tenant.
Also added a ConfigManager for the Tunnel-End point configuration that is currently proposed to be configured as :
ovs-vsctl set Open_vSwitch <uuid> other_config={"local-ip"="192.168.56.101"}.
Change-Id: I7b14fed5fdc5a1c4f6714faf41679c2f1cb9d0f5
Signed-off-by: Madhu Venugopal <mavenugo@gmail.com>
Brent Salisbury [Sun, 24 Nov 2013 19:19:51 +0000 (19:19 +0000)]
Merge "Skeleton Event handlers for the Neutron integration with OVSDB. As per the design, the ovsdb.neutron plugin will be a bunch of event handlers which converts the events into corresponding OVSDB/OF programming. The 5 events of interests are 1. NeutronNetwork events 2. NeutronPort events 3. NeutronSubnet events 4. Southbound Node Connectivity events 5. Southbound Port table update events This push just brings in the barebones of these event handlers."
Keith Burns [Sat, 23 Nov 2013 05:56:02 +0000 (21:56 -0800)]
Added delete[Port|Interface|Controller]Row methods
Change-Id: I740180d2f8a533e2c264c850aa7d1e6e0ae13f6a
Signed-off-by: Keith Burns <alagalah@gmail.com>
Madhu Venugopal [Fri, 22 Nov 2013 06:34:45 +0000 (22:34 -0800)]
Skeleton Event handlers for the Neutron integration with OVSDB.
As per the design, the ovsdb.neutron plugin will be a bunch of event handlers which
converts the events into corresponding OVSDB/OF programming. The 5 events of interests are
1. NeutronNetwork events
2. NeutronPort events
3. NeutronSubnet events
4. Southbound Node Connectivity events
5. Southbound Port table update events
This push just brings in the barebones of these event handlers.
Change-Id: Ic94429672303bee29de0c245558669e9462c0a01
Signed-off-by: Madhu Venugopal <mavenugo@gmail.com>
Madhu Venugopal [Wed, 20 Nov 2013 22:41:20 +0000 (14:41 -0800)]
Moved OF-Controller helper routines to ConnectionService and starting to use the insert*Row due to the service requirements.
Also moved some verbose debugs to traces.
Change-Id: I7c68dc599bb193af3905d3cd709381f2fae72b31
Signed-off-by: Madhu Venugopal <mavenugo@gmail.com>
Madhu Venugopal [Wed, 20 Nov 2013 09:33:22 +0000 (01:33 -0800)]
Added insertControllerRow and fixed getSerializedRow. getRows still need to return unserialized form
which will be used by the neutron integration piece. Also the insertControllerRow is used for that
cause.
Change-Id: I0a8b03b24a22dcb31b67d1ee5f606bd0220c34dc
Signed-off-by: Madhu Venugopal <mavenugo@gmail.com>
Keith Burns [Tue, 19 Nov 2013 16:55:46 +0000 (08:55 -0800)]
Added insertInterfaceRow() method to ConfigurationService.java.
Change-Id: I08c41351e1a8f03c48fd0f416cbab89feeb34793
Signed-off-by: Keith Burns <alagalah@gmail.com>
Brent Salisbury [Thu, 14 Nov 2013 15:45:11 +0000 (15:45 +0000)]
Merge "Update, Delete and Read support for base tables."
Madhu Venugopal [Thu, 14 Nov 2013 02:30:47 +0000 (18:30 -0800)]
Update, Delete and Read support for base tables.
Change-Id: I1c5f6fb8d2d6f0dee952542ad9d41866cf0d3077
Signed-off-by: Madhu Venugopal <mavenugo@gmail.com>
Brent Salisbury [Thu, 14 Nov 2013 00:14:34 +0000 (00:14 +0000)]
Merge "Northbound support for inserting table rows"
Madhu Venugopal [Mon, 11 Nov 2013 00:23:23 +0000 (16:23 -0800)]
Northbound support for inserting table rows
Change-Id: Ifc006389046028c814ebb4d2090d4b5882745bed
Signed-off-by: Madhu Venugopal <mavenugo@gmail.com>
Brent Salisbury [Mon, 11 Nov 2013 18:25:38 +0000 (18:25 +0000)]
Merge "Controller IP-Address filtered using the "of.address" controller configuration from a list of all the exposed ip-addresses of the system."
Hugo Trippaers [Mon, 11 Nov 2013 08:11:40 +0000 (09:11 +0100)]
Remove eclipse project files from the source repository
Change-Id: Ie101a06e780c790c8b61207342799034cd2c6a12
Signed-off-by: Hugo Trippaers <hugo@trippaers.nl>
Madhu Venugopal [Sun, 10 Nov 2013 17:19:11 +0000 (09:19 -0800)]
Updating OpenFlow Node Description that is learnt from the OVSDB bridge table.
In order to compensate for a bug in the way Openflow plugin overrides a null value on the switchmanage node description,
this fix also adds a scheduled reexecution of the description update message after a few seconds to make sure the updates
are not lost.
Change-Id: I605a2ff237d13cb72cdeb60ecf55ad19295c3133
Signed-off-by: Madhu Venugopal <mavenugo@gmail.com>
Madhu Venugopal [Sun, 10 Nov 2013 11:59:03 +0000 (03:59 -0800)]
Controller IP-Address filtered using the "of.address" controller configuration from a list of all the exposed ip-addresses of the system.
As per the current implementation, when a new bridge is added, the Configuration Service automatically sets up the OF Controller field
of the bridge to point back at the OpenDaylight Openflow plugin. This is done by scanning all the open interfaces with valid IP-Addresses
and sets it in the Bridge table's controller column.
This can be better handled by filtering it further by using just the Admin prefered ip-address of the controller.
This configuration item is called "of.address" in configuration/config.ini.
Change-Id: Icdfeb0dfc4e68e61e926f09b49461fe0c1dd3060
Signed-off-by: Madhu Venugopal <mavenugo@gmail.com>
Madhu Venugopal [Sun, 10 Nov 2013 02:18:43 +0000 (18:18 -0800)]
Fixed OVSDB Passive Connection interaction bugs with Connection Manager.
Luis (from the integration project) identified the SAL Connection service interaction issues
during OVSDB Passive connection to the controller.
Also introduced the disconnect handling, including cleaning up the tableCache for that node.
Change-Id: Ieb7ed88e164574c3f27413d8ccae38222e82d89f
Signed-off-by: Madhu Venugopal <mavenugo@gmail.com>
Madhu Venugopal [Sat, 9 Nov 2013 07:54:15 +0000 (07:54 +0000)]
Merge "Allow to change the controller ip and port for the integration test from the maven command line (or the pom.xml)"
Madhu Venugopal [Sat, 9 Nov 2013 07:52:33 +0000 (07:52 +0000)]
Merge "Change all the tests that need an ovsdb controller to integration tests and centrallize the connection routine."
Madhu Venugopal [Sat, 9 Nov 2013 07:41:19 +0000 (07:41 +0000)]
Merge "Split unit and integration tests and add a profile to active integration tests."
Madhu Venugopal [Sat, 9 Nov 2013 07:36:39 +0000 (07:36 +0000)]
Merge "Implemented the deleteBridgeDomain method in ConfigurationService"
Brent Salisbury [Fri, 8 Nov 2013 08:59:31 +0000 (03:59 -0500)]
Implemented the deleteBridgeDomain method in ConfigurationService
I missed the last comment from Madhu in p2. I verfied all
methods modified. Thanks very much for the assist.
Change-Id: I628f31ed8af66d4c18ac2b61b6200043a8b779d8
Signed-off-by: Brent Salisbury <brent.salisbury@gmail.com>
Hugo Trippaers [Fri, 8 Nov 2013 15:48:50 +0000 (16:48 +0100)]
Allow to change the controller ip and port for the integration test from the maven command line (or the pom.xml)
To execute the integration tests use mvn -Pintegrationtest -Dovsdbserver.ipaddress=x.x.x.x -Dovsdbserver.port=x verify
Change-Id: Ie2df5528f650301c992c3712715df49b0c24227e
Signed-off-by: Hugo Trippaers <hugo@trippaers.nl>
Hugo Trippaers [Fri, 8 Nov 2013 15:24:03 +0000 (16:24 +0100)]
Change all the tests that need an ovsdb controller to integration tests and centrallize the connection routine.
Change-Id: I62bcab3cec789c0b1a6a4d85aebbae8d3e3212a5
Signed-off-by: Hugo Trippaers <hugo@trippaers.nl>
Hugo Trippaers [Fri, 8 Nov 2013 12:29:22 +0000 (13:29 +0100)]
Split unit and integration tests and add a profile to active integration tests.
Add properties file to configure the integration test
Make the integration test die if the remote is not reachable
Change-Id: I2029c6ff14362bae72ce8d4f562361e181604c01
Signed-off-by: Hugo Trippaers <hugo@trippaers.nl>
Madhu Venugopal [Fri, 8 Nov 2013 10:11:43 +0000 (10:11 +0000)]
Merge "We are using JDK 1.7 specific functions in our code, so we should enforce source level 1.7"
Madhu Venugopal [Fri, 8 Nov 2013 09:59:48 +0000 (09:59 +0000)]
Merge "Fix potential NPE when the ovsdb-server returns null responses on parts of a transact return object"
Hugo Trippaers [Thu, 7 Nov 2013 17:43:40 +0000 (18:43 +0100)]
We are using JDK 1.7 specific functions in our code, so we should enforce source level 1.7
See ConfigurationService.java:631 function getLoopbackAddress
Change-Id: I3f83bfe84dca05819aa7e04decfa3b01763af0eb
Signed-off-by: Hugo Trippaers <hugo@trippaers.nl>
Hugo Trippaers [Thu, 7 Nov 2013 17:53:11 +0000 (18:53 +0100)]
Fix potential NPE when the ovsdb-server returns null responses on parts of a transact return object
Change-Id: I7acc2dd51821e7dabb8dd80ae593d1f779a4267d
Signed-off-by: Hugo Trippaers <hugo@trippaers.nl>
Hugo Trippaers [Thu, 7 Nov 2013 17:50:46 +0000 (18:50 +0100)]
Update the config version of teh ovsdb when adding a bridge
Change-Id: I459ad71f4ed75e39f71b0cd970190780b1411ec4
Signed-off-by: Hugo Trippaers <hugo@trippaers.nl>
Madhu Venugopal [Wed, 6 Nov 2013 22:58:28 +0000 (14:58 -0800)]
Merge branch 'topic/netty'
Collapsing the branch to master
Signed-off-by: Madhu Venugopal <mavenugo@gmail.com>
Conflicts:
ovsdb/.classpath
ovsdb/src/main/java/org/opendaylight/ovsdb/internal/ConfigurationService.java
Change-Id: I4bc7cd4b921b5eb8b14cfe4d1c2811214f03e78c
Signed-off-by: Madhu Venugopal <mavenugo@gmail.com>
Madhu Venugopal [Wed, 6 Nov 2013 21:48:09 +0000 (13:48 -0800)]
Bumping up the version to 0.5.0-SNAPSHOT prior to the collapse
Signed-off-by: Madhu Venugopal <mavenugo@gmail.com>
Brent Salisbury [Wed, 6 Nov 2013 19:24:46 +0000 (14:24 -0500)]
Adjusted null check to cache rather then connection.
Signed-off-by: Brent Salisbury <brent.salisbury@gmail.com>
Madhu Venugopal [Wed, 6 Nov 2013 18:05:14 +0000 (10:05 -0800)]
Support for Port Types = patch, Vlan and Tunnel.
Signed-off-by: Madhu Venugopal <mavenugo@gmail.com>
Madhu Venugopal [Tue, 5 Nov 2013 18:08:02 +0000 (10:08 -0800)]
Minor fix to make Junit happy.
Due to the introduction of the passive connection support, the Monitor and Schema was pushed to a
separate thread. Also the connection was deemed successful only if the monitor was successful.
That doesnt work well with the current (buggy) implemenation of JUnit. But since the JUnit is very
handy in testing out the functionality, reversing the ovsdbConnection management.
Change-Id: Ifa833014c587e94baa63a5925959c87d9e27c6fc
Signed-off-by: Madhu Venugopal <mavenugo@gmail.com>
Brent Salisbury [Wed, 6 Nov 2013 16:53:21 +0000 (11:53 -0500)]
Added add/del-port and hooked into OSGI CLI
Signed-off-by: Brent Salisbury <brent.salisbury@gmail.com>
Brent Salisbury [Wed, 6 Nov 2013 01:06:35 +0000 (20:06 -0500)]
Added set-controller functionality.
Signed-off-by: Brent Salisbury <brent.salisbury@gmail.com>
Madhu Venugopal [Tue, 5 Nov 2013 11:06:09 +0000 (03:06 -0800)]
Add Utility methods to get a list of controller-ip-addresses and OF Port
Change-Id: Id73a705903c2f465a1c697e9935b8bdbd27df3be
Signed-off-by: Madhu Venugopal <mavenugo@gmail.com>
Madhu Venugopal [Sun, 3 Nov 2013 10:53:39 +0000 (05:53 -0500)]
OVSDB Manager Passive listen support
This change brings in the following :
1. ovsdb manager passive listen on port 6640. With this change, the OVSDB-server can connect to the controller via set-manager configuration.
2. Default listening and connecting port is changed to 6640 (as per the IANA port assignment)
3. Reorganized ConnectionManager a bit to share the exact same Channel handling code for both Active and Passive ovsdb connections.
Change-Id: I76836aa53b519af08aaf3399ba104351d94ddd4c
Signed-off-by: Madhu Venugopal <mavenugo@gmail.com>
Madhu Venugopal [Sun, 3 Nov 2013 10:49:30 +0000 (05:49 -0500)]
Fixing a collateral damage due to a recent commit.
During a recent change, the brideName is missing in Bridge and Port Row during addBridge() command.
Change-Id: I6d44bdadb9eeec06daf4918b0f1a4b14bd6f96a9
Signed-off-by: Madhu Venugopal <mavenugo@gmail.com>
Madhu Venugopal [Fri, 1 Nov 2013 22:07:19 +0000 (18:07 -0400)]
InsertOperation cleanup to get rid of Generic HashMaps to proper Row inserting using Table classes.
In addition, Set & Map serializers are taken care as well.
Change-Id: I0e3d34b6ae30e7b4f5f7da876b465f0dfd93479c
Signed-off-by: Madhu Venugopal <mavenugo@gmail.com>
Hugo Trippaers [Fri, 1 Nov 2013 15:57:18 +0000 (16:57 +0100)]
Check the tables we want to monitor against the schema that we got from the node.
The monitor can throw an error, so handle it.
As details is defined as being part of the error we can include it in the base response.
Change-Id: I950d36ff16eebdf1d46cf8047ec8dd620007aab6
Signed-off-by: Hugo Trippaers <trippie@gmail.com>
Madhu Venugopal [Thu, 31 Oct 2013 10:28:00 +0000 (03:28 -0700)]
Parsed & cached the Database Schema along with the initial monitor response.
This is a start to make use of Schema based Table management instead of static class as defined today.
Signed-off-by: Madhu Venugopal <mavenugo@gmail.com>
Madhu Venugopal [Tue, 29 Oct 2013 22:54:32 +0000 (15:54 -0700)]
Configuration Service's Add Bridge integrated with the new netty library.
Signed-off-by: Madhu Venugopal <mavenugo@gmail.com>
Change-Id: I4e4e61f68f4e1a2c4a9753c4ee6f74a26018c03c
Madhu Venugopal [Tue, 29 Oct 2013 20:09:13 +0000 (13:09 -0700)]
First Plugin integration with the Library starting with ConnectionService and InventoryService
Also,
1. removed the UnitTest dependancy on ChannelHandlers and moved directly under ConnectionService.
2. renamed OVSDB to OvsdbRPC
3. Modified OVSDBNettyFactoryTest to accomodate the above integration and refactoring.
Signed-off-by: Madhu Venugopal <mavenugo@gmail.com>
Madhu Venugopal [Tue, 29 Oct 2013 18:22:32 +0000 (11:22 -0700)]
Removing Plugin dependancies from the Library in lieu of bundle isolation.
Signed-off-by: Madhu Venugopal <mavenugo@gmail.com>
Madhu Venugopal [Tue, 29 Oct 2013 15:34:07 +0000 (08:34 -0700)]
Enabling the LoggingHandler back
Signed-off-by: Madhu Venugopal <mavenugo@gmail.com>
Madhu Venugopal [Tue, 29 Oct 2013 15:31:53 +0000 (08:31 -0700)]
Disable JUnit temporarily in maven build until we integrate plugins cleanly with library
Signed-off-by: Madhu Venugopal <mavenugo@gmail.com>
Madhu Venugopal [Tue, 29 Oct 2013 02:34:25 +0000 (19:34 -0700)]
Library support for the Notification handling & Update processing to keep cache upto date.
Signed-off-by: Madhu Venugopal <mavenugo@gmail.com>
Madhu Venugopal [Mon, 28 Oct 2013 22:02:43 +0000 (15:02 -0700)]
Fixed Transact response handling and updated the operation response for each request
Signed-off-by: Madhu Venugopal <mavenugo@gmail.com>
Madhu Venugopal [Mon, 28 Oct 2013 04:18:36 +0000 (21:18 -0700)]
Added initial Response handling code. Error handling needs more work & needs some library changes
and will be handled in a different commit.
Signed-off-by: Madhu Venugopal <mavenugo@gmail.com>
Madhu Venugopal [Sun, 27 Oct 2013 18:52:56 +0000 (11:52 -0700)]
Fixed UUID Custom Serialization & used it in UT.
Signed-off-by: Madhu Venugopal <mavenugo@gmail.com>
Madhu Venugopal [Sun, 27 Oct 2013 16:40:21 +0000 (09:40 -0700)]
InventoryService caching and First-level Transaction Support
Few more changes pending on the Transaction side.
Once the Update/Notification callback processing from Ashwin is done,
we will have a good base to start integrating with the plugin code.
Signed-off-by: Madhu Venugopal <mavenugo@gmail.com>
Madhu Venugopal [Sat, 26 Oct 2013 20:16:09 +0000 (13:16 -0700)]
Added Request specific files & Few more package name changes to reflect the OVSDB Draft.
Signed-off-by: Madhu Venugopal <mavenugo@gmail.com>
Madhu Venugopal [Thu, 24 Oct 2013 10:54:13 +0000 (03:54 -0700)]
Package name changes to reflect functionality differences between Library and Plugin.
This is just the first step towards pulling the OVSDB Library into its own bundle.
Signed-off-by: Madhu Venugopal <mavenugo@gmail.com>
Madhu Venugopal [Thu, 24 Oct 2013 10:24:17 +0000 (03:24 -0700)]
Initial Netty + JSON Deserializer + all the enhancements happening in many private repos.
With so many changes, am finding it hard to maintain it in my local repo and hence am pushing
it into the the topic/netty branch.
NOTE TO COMMITTERS : PLEASE DONT USE THIS YET. I have some more major cleanup and development
to be done to make this branch useful.
Signed-off-by: Madhu Venugopal <mavenugo@gmail.com>
Change-Id: I70a43dcecee002199d38ffd46a43ca5b20174df4
Brent Salisbury [Tue, 22 Oct 2013 21:02:51 +0000 (17:02 -0400)]
Added external_id bridgeDom support for ovsdb
Applied patch from Madhu. Thanks.
Added a column entries to get review
for needing a generic parameter for
set <table> <column> <param>.
Junit will update the external_id column in
the Bridge table. The method will be modified
to accept columns as opposed to
"external_id" only. Netty branch addresses
this with POJOs but this is for current
functionality.
Signed-off-by: Brent Salisbury <brent.salisbury@gmail.com>
Change-Id: Iba1913a91dea258541d16ca348179bc541a7422f
Brent Salisbury [Thu, 17 Oct 2013 02:31:21 +0000 (22:31 -0400)]
Added the ability to set the OF controller by the OVSDB Manager
Adds controller:ip:port to the Controller table, bridge row with the column target and the bridge UUID to the controller column in the Bridge table. This is for basic functionality and testing while the jsonrpc4j library is being replaced with Netty in another branch.
Signed-off-by: Brent Salisbury <brent.salisbury@gmail.com>
Matt Oswalt [Wed, 16 Oct 2013 05:38:03 +0000 (22:38 -0700)]
Filled out delete port method and created associated classes
Signed-off-by: Matt Oswalt <matt@keepingitclassless.net>
Brent Salisbury [Fri, 9 Aug 2013 08:06:58 +0000 (04:06 -0400)]
Adjusted key name to the JSON value
as recommended by Madhu, member still overlaps with the protocol so stays as unique. Ty Madhu
Signed-off-by: Brent Salisbury <brent.salisbury@gmail.com>
Ed Warnicke [Wed, 7 Aug 2013 12:38:23 +0000 (07:38 -0500)]
Changed parent pom to hit our nexus mirror cache for all dependencies.
Changed parent pom to hit the nexus.opendaylight.org caching mirror
of jsonrpc4j
Signed-off-by: Ed Warnicke <eaw@cisco.com>
Ed Warnicke [Mon, 5 Aug 2013 04:17:16 +0000 (23:17 -0500)]
Moved commons/ to commons/parent
Allows for things like a local commons/checkstyle etc.
Change-Id: I920af99eec7ea4af051fcd90f60ac6ef698c7889
Signed-off-by: Ed Warnicke <eaw@cisco.com>
Ed Warnicke [Mon, 5 Aug 2013 04:11:22 +0000 (23:11 -0500)]
Added distribution directory
- Added a distribution/opendaylight directory
- Modified commons directory to build all modules
- Modified commons directory to use the controller checkstyle
Note: This won't work correctly until
https://git.opendaylight.org/gerrit/#/c/781/ is merged
Note: The Jenkins job should be modified to build commons/
(which will build all submodules).
Change-Id: I64f4721ba65cabcc0c48db6b9f531aa73e266807
Signed-off-by: Ed Warnicke <eaw@cisco.com>
Brent Salisbury [Fri, 2 Aug 2013 16:54:47 +0000 (12:54 -0400)]
Implemented OVS list bridge functionality and Junit
Signed-off-by: Brent Salisbury <brent.salisbury@gmail.com>
Madhu Venugopal [Fri, 2 Aug 2013 05:36:58 +0000 (22:36 -0700)]
Fixed the embed-dependancy issue on a few dependant packages for json-rpc.
Change-Id: I22d445006cd32e08e4173a5a3a024d556d412c0f
Signed-off-by: Madhu Venugopal <vmadhu@cisco.com>
Madhu Venugopal [Fri, 2 Aug 2013 04:20:27 +0000 (21:20 -0700)]
Porting the OVSDB services to use the Controller SAL services : Connection and BridgeDomain Configuration.
Removed some unused files and added some OSGi console commands for interactive manual testing.
Change-Id: I40730bdc0cea0910c3858623fe4b5dc20398ab35
Signed-off-by: Madhu Venugopal <vmadhu@cisco.com>
Evan Zeller [Tue, 30 Jul 2013 16:50:14 +0000 (12:50 -0400)]
Removed unneeded & unused classes.
Signed-off-by: Evan Zeller <evanrzeller@gmail.com>
Giovanni Meo [Mon, 29 Jul 2013 18:24:49 +0000 (20:24 +0200)]
Trial commit to trigger gerrit build
Change-Id: Ibef701439baca4b60168df510934dd727b9d5001
Signed-off-by: Giovanni Meo <gmeo@cisco.com>