Convert openflowplugin-it to use DTCL instead of DCL

Change-Id: I8a3f3b690bef5d29dcd9b51e243bd83ad5c501c6
Signed-off-by: Andrej Leitner <andrej.leitner@pantheon.tech>

Bumping versions by 0.0.1 for next dev cycle

Change-Id: If04c10d7c9a489faec364428265f5a979dadcd70
Signed-off-by: Anil Belur <abelur@linuxfoundation.org>

BUG-6595: Adding a retry for the issue when the
mastership of the switch hasnot been established while
the port status is processed

Change-Id: I5c49bb4a6c4f223150d44d200f32cd1108dac0f7
Signed-off-by: Shuva Kar <shuva.jyoti.kar@ericsson.com>

Merge "Bug 6176 - Decrease logging level in Sal-F/G/M-Service and use synchronized BiMap" into stable/boron

Bug 6554 Fix rejecting connections

- two way device context close removed
- txManager lambda improvements
- txManager logs improvements
- device context lazy initialization
- role context close improvement

Change-Id: I1a9f5890f267ada9a2978f9a92f792ab2411c1aa
Signed-off-by: Jozef Bacigal <jozef.bacigal@pantheon.tech>
(cherry picked from commit 5eb3934ab14beb9646f039e09f698dd1b118fb9b)

Revert "BUG6595: Adding a retry for getting a transactionsafely"

This reverts commit b26b58ec652a1e7d8eb77f571b39604bf5e3cc86.

Change-Id: Ifcbbdbff26b3f1bbf7b9af336ea048403dcdde9a
Signed-off-by: Anil Vishnoi <vishnoianil@gmail.com>

Bug 6176 - Decrease logging level in Sal-F/G/M-Service and use synchronized BiMap

 - decrease logging level to prevent overloading of netty
   thread with logging errors (seen in troughput test)
 - despite the fact that unsuccesful RPCresult brings errors
   from device there is no reason for throwing error since
   it is not error of karaf ot OFP itself (therefore debug)
 - change BiMap to synchronized because of ConcurrentModificationException
   seen in tests

Change-Id: Ia37212647a9c119ecd51d6685ea8fffb8ee94a39
Signed-off-by: Andrej Leitner <andrej.leitner@pantheon.tech>

BUG6595: Adding a retry for getting a transactionsafely

since the RCA for the issue pointed to the fact that the
mastership of the switch hadnot been established while
the port status is processed.

Change-Id: If243a051b8417b35160144213dd268f1c2bf4225
Signed-off-by: Shuva Kar <shuva.jyoti.kar@ericsson.com>

BUG-6595: Need more information in logging

Enabling port information in the logging to
understand better which port status addition
is failing

Change-Id: I9eb116fa58e85ddb711ca423071ee1d78a088f19
Signed-off-by: Shuva Kar <shuva.jyoti.kar@ericsson.com>

Bug 6524 FlowDescriptor instead of SwitchFlowId in FRS

Change-Id: Ibb02c310be27f02c7543e157d2f5e7ca7cc430a8
Signed-off-by: Andrej Leitner <andrej.leitner@pantheon.tech>

Bug 6513 Remove FD from registry immediately

 - remove FlowDescriptor from DeviceFlowRegistry immeadiately
   instead of marking it as to-be-removed
 - updated tests

Change-Id: I269a510fa67b6d04181039515aaefda90b53b827
Signed-off-by: Andrej Leitner <andrej.leitner@pantheon.tech>

Bug 6465 Controller goes into slave mode

- Changed lifecycle service in order to
create lazy initilization of context in cluster
- Removed clustering initialization per context
- Changed reconnect strategy if not in disconnecting state
- Some performance improvements
- Removed OFManager general API

Change-Id: I37e8f99a0590633a3e5c179b092c6b1c65e9cb1d
Signed-off-by: Jozef Bacigal <jozef.bacigal@pantheon.tech>

BUG-5464,5954: making table features configurable for the Li plugin.
DEFAULT will be OFF, can be TURNED ON.

Change-Id: I22a7ad0cb74515d7c203f851a62be0b4a896ea1d
Signed-off-by: Shuva Kar <shuva.jyoti.kar@ericsson.com>

Bug 5596 Singleton API test

- added missing test for lifecycle service
- added missing test for role context

Change-Id: I306a668fa7748c3b1ee658f5225ba64bea6412e9
Signed-off-by: Jozef Bacigal <jozef.bacigal@pantheon.tech>

Bug 5596 - restart devices management improvement

Change-Id: I61b384062e780eec342d7b7eb0ffa05bc0f6c7de
Signed-off-by: Jozef Bacigal <jozef.bacigal@pantheon.tech>

Bug 6357 - FRM integration with singleton

 - using ClusterSingletonServiceProvider instead if EOS
 - junit tests update

Change-Id: I07033627ba08e64f58fff117be57dcfe0f030d52
Signed-off-by: Andrej Leitner <andrej.leitner@pantheon.tech>

Bug 5596 Initial commit failed

- added closing connection after unsuccessful initial submit
- added enum with possible connection state after handshake

Change-Id: I62e06f8189dc593bc40267c96d253fdfe53b3a20
Signed-off-by: Jozef Bacigal <jozef.bacigal@pantheon.tech>

DeviceFlowRegistry - prevent NPE

- Added more nonNull filters to DeviceFlowRegistry.fillFromDatastore
- Added nonNull filters when printing debug info of added flows
  in LifecycleServiceImpl
- Added more JUnit tests to test fail cases of DeviceFlowRegistry.fill
- More detailed log output for DeviceFlowRegistry

Change-Id: Iec965c8a3cee8d2c0c3276a00a4494f786344e4e
Signed-off-by: Tomas Slusny <tomas.slusny@pantheon.sk>

Bug 5596 Changes when closing device

- speed up device closing process
- prevent to wait for closing device context
- log improvements
- Added nonNull filters when filling DeviceFlowRegistry
- Updated unit tests to test for above case

Change-Id: Ib6b22b1622f2eb6f97101719c3f746c129d05499
Signed-off-by: Jozef Bacigal <jozef.bacigal@pantheon.tech>

Bug 5596 Cleaning lifecycle conductor

- removed lifecycle conductor

Change-Id: I7143726358c7d2145e2109e269e8d50e2c865a1f
Signed-off-by: Jozef Bacigal <jbacigal@cisco.com>

Bug 5596 Cleaning part 4

Change-Id: I967cab5cb220bfbd91ff32552c0d9e8e157ab0fd
Signed-off-by: Jozef Bacigal <jbacigal@cisco.com>

Bug 5596 Cleaning part 3

- Role Context
- Role Manager
- Rpc Context
- Rpc Manager

Change-Id: If9a144950a86abfef51fb3cb70c2a22e52e7fa37
Signed-off-by: Jozef Bacigal <jbacigal@cisco.com>

Bug 5596 Cleaning part 2

- Statistics Context
- Statistics Manager

Change-Id: I29fc3c358207039184811e09d5c98368656a9ee0
Signed-off-by: Jozef Bacigal <jbacigal@cisco.com>

Bug 5596 Cleaning part 1

- Device Context
- Device Manager
- Device State

Change-Id: I85a1269f1acc17a3e09cbe1d92fb993a9be5a4da
Signed-off-by: Jozef Bacigal <jbacigal@cisco.com>

Bug 5596 Added cluster provider

Change-Id: I1954b28bfaaf026aebb171fb5c51ef26a6df585c
Signed-off-by: Jozef Bacigal <jbacigal@cisco.com>

Bug 5596 Change of start up services

Change-Id: I6bae36251f4d01e6d851f8f09a976e790665ef20
Signed-off-by: Jozef Bacigal <jbacigal@cisco.com>

Bug 5596 Created lifecycle service

- created general API for cluster services
- changed OFPContext and OFPManager API

Change-Id: I6506a1dcc328e98aca21446d46b8dd09445a4b61
Signed-off-by: Jozef Bacigal <jbacigal@cisco.com>

Bug 6133 - and more improvements

- LOGs improvements
- RoleContext closing speed up
- Race condition for protocol v 1.0
- OVS remains in disconected state bug 6133

Change-Id: I220c9ab84357c58c4b6887bec76fe274fec7a03f
Signed-off-by: Jozef Bacigal <jbacigal@cisco.com>
(cherry picked from commit 66149ccf887da6a65b9a7287b8a43ab9e1b49663)

BUG-6458:

The issue occurred since during update the older
flowregistry key wasnot getting removed when the
newer one was getting stored. This was because the
match/priority/cookie all forms part of the flow-registry
key.

Change-Id: Ibed34e79b6310723f7c8078bf54b8a2b4f9ab2b2
Signed-off-by: Shuva Kar <shuva.jyoti.kar@ericsson.com>

Merge "Bug 6366 - of-switch-config-pusher - DTCL instead of DTL" into stable/boron

Merge "Sonar - technical debt of FRS app" into stable/boron

Adding learn action - Bug 6445

Change-Id: Iab58e54230003dc8a5ea48bbc7a4d173c305cf8f
Signed-off-by: Slava <slava.radune@hpe.com>
(cherry picked from commit 122bf80)

Merge "Bug 6374 topology-manager - DTCL instead of DTL" into stable/boron

Merge "SONAR TD - FlatBatchUtil, DeviceInitializationUtils" into stable/boron

Merge "SONAR TD - Remove unused fields, fix naming" into stable/boron

Merge "SONAR TD - Group actions redundancy" into stable/boron

Merge "SONAR TD - Sal*ServiceImpl" into stable/boron

Merge "SONAR TD - AbstractService" into stable/boron

Merge "SONAR TD - *ToNotificationTransformer private constr." into stable/boron

Merge "Technical debt MeterUtil, GroupUtil, FlowUtil" into stable/boron

Merge "Drop Felix Gogo" into stable/boron

Merge "Bug 6372 table-miss-enforcer - DTCL instead of DTL" into stable/boron

Removed duplicate declaration in pom.xml.

The pom.xml in the model directory had duplicate declaration of
ietf-yang-types-20130715.

Change-Id: Ib9164412a8e564f98fc92892678bd86196b77734
Signed-off-by: Hideyuki Tai <Hideyuki.Tai@necam.com>
(cherry picked from commit 294d813a27bc402b462a9565683aa90e1f2a4200)

Merge "Bug 6278: Switch to use odlparent's karaf-parent" into stable/boron

Sonar - technical debt of FRS app

Change-Id: I2951c3e85f3599aec951844289de22e25b652a36
Signed-off-by: Andrej Leitner <andrej.leitner@pantheon.tech>

SONAR TD - Remove unused fields, fix naming

- Added private constructor to EventsTimeCounter
- Removed unused fields
- Fixed naming of constants

Change-Id: I4321e2b75af71abb3473eef5e5cc6b92e36c76c4
Signed-off-by: Tomas Slusny <tomas.slusny@pantheon.sk>

SONAR TD - FlatBatchUtil, DeviceInitializationUtils

- Removed unused fields
- Reduced cyclomatic complexity of code
- Added private constructor to DeviceInitializationUtils

Change-Id: I280c9534ad87a6d6826e2a209d07edb1ff25c624
Signed-off-by: Tomas Slusny <tomas.slusny@pantheon.sk>
(cherry picked from commit 81ec040affdf77f72ae1060436e7010386f410ed)

Bug 6278: Switch to use odlparent's karaf-parent

Change-Id: If65dbe7d41cee7f14f56479634627d107df50d6f
Signed-off-by: Ryan Goulding <ryandgoulding@gmail.com>

SONAR TD - Group actions redundancy

- Moved logic that converts list of action types to group actions bitmap
  to single method in GroupUtil

Change-Id: Ie8fc71945c4a5412c5adf88cb66d26f2d9a9a229
Signed-off-by: Tomas Slusny <tomas.slusny@pantheon.sk>
(cherry picked from commit 44da2880eee5acbc7da23f82c4807b0337efed66)

SONAR TD - Sal*ServiceImpl

- Changes some anonymous classes to named inner classes
- Shortened big lambda in SalFlatBatchService

Change-Id: I04d9f73ba92928144b2de1d2a86b8c4feac0ad22
Signed-off-by: Tomas Slusny <tomas.slusny@pantheon.sk>
(cherry picked from commit 5c2b5676715352cc935daa146c660e6b79c7bd03)

SONAR TD - AbstractService

- Remove WAIT_TIME, PRIMARY_CONNECTION unused fields
- Changed buildRequest to throw ServiceException
  instead of generic Exception

Change-Id: If5620887623c2119065a4120e91189120441bbda
Signed-off-by: Tomas Slusny <tomas.slusny@pantheon.sk>
(cherry picked from commit c53071b939c82b032d8ec6468c531f4abd79fa4c)

SONAR TD - *ToNotificationTransformer private constr.

- Added private constructors to ToNotificationTransformer classes

Change-Id: If64db7a5922ffdc613685c56d077ada7d1c38c7f
Signed-off-by: Tomas Slusny <tomas.slusny@pantheon.sk>
(cherry picked from commit 70a6663897b6d25e7748a148b74f6d12bb51a0b3)

Technical debt MeterUtil, GroupUtil, FlowUtil

- Reduce anonymous classes number of lines
- Remove unused "LOG" field

Change-Id: I8d7fe786edc7f82d35abd9a6bb097e52118d6827
Signed-off-by: miroslav.macko <miroslav.macko@pantheon.tech>
(cherry picked from commit 340e46e9d770c6aa21ac2dc3dd6d2ed1639a1656)

Drop Felix Gogo

This is obsolete and appears to be unused.

Change-Id: I755c976567bde2747ec332b0834cc58fdc2ee22d
Signed-off-by: Stephen Kitt <skitt@redhat.com>
(cherry picked from commit 96eb290ba1b9f05606f83541453a5d7d07898158)

Removed unused logger and fixed javadoc links

Change-Id: I595c97b39b6093d0b96f1f00a2bbc08274c8fda5
Signed-off-by: Andrej Leitner <andrej.leitner@pantheon.tech>

Bug 6380 lldp-speaker - DTCL instead of DTL

 - lldp-speaker app converted to use DataTreeChangeListener
   instead of deprecated DataChangeListener
 - updated tests

Change-Id: I8d424e8bc6c93e2addc25a9149177ca6f7b90a27
Signed-off-by: Andrej Leitner <andrej.leitner@pantheon.tech>

Bug 6366 - of-switch-config-pusher - DTCL instead of DTL

 - of-switch-config-pusher app converted to use DataTreeChangeListener
   instead of deprecated DataChangeListener
 - updated tests

Change-Id: Ic0f125ac87b52f67febbb16924227152a2bf7b25
Signed-off-by: Andrej Leitner <andrej.leitner@pantheon.tech>

Bug 6374 topology-manager - DTCL instead of DTL

 - topology-manager app converted to use DataTreeChangeListener
   instead of deprecated DataChangeListener
 - updated tests

Change-Id: Ibc242d4dbd4238153813762bd8ed56510ccf2706
Signed-off-by: Andrej Leitner <andrej.leitner@pantheon.tech>

Bug 6372 table-miss-enforcer - DTCL instead of DTL

 - table-miss-enforcer app converted to use DataTreeChangeListener
   instead of deprecated DataChangeListener
 - updated tests

Change-Id: I74c2c6755c1d6604a25bfee8d58d79787bef1c48
Signed-off-by: Andrej Leitner <andrej.leitner@pantheon.tech>

Bug5822:Ensuring that the flowId, is unique for a flow
in a table

* also optimising map/list accresses
*reducing addFlow rpc latency

Change-Id: Ida607fc7134c0488c7c3bcc82e38966be2325e71
Signed-off-by: Shuva Kar <shuva.jyoti.kar@ericsson.com>
(cherry picked from commit 7cd1a52c3c6b025e7797a92b8bf25b7b97d9aec5)

Merge "Fix Ipv6 format compression" into stable/boron

Fix Ipv6 format compression

 - removed regex and replaced with existing methods
 - altered method that compresses Ipv6Address to take it
   as argument and not to accept any string
 - used Ipv6Address instead of String
 - updated IpConversionUtilTest
 - fixed yang descriptions

Change-Id: I303d3f3c68bf463de9f017e0e65ec36adaf4e489
Signed-off-by: Andrej Leitner <andrej.leitner@pantheon.tech>
Signed-off-by: Tomas Slusny <tomas.slusny@pantheon.sk>

Support new matches and actions in ovs nsh patch

New matches: encap_eth_type, encap_eth_src, encap_eth_dst, nsh_np, nsh_mdtype, tun_gpe_np
New actions: push_nsh, pop_nsh
Rebase and change topic back to 37937
Fixed some Unit test failures

Change-Id: I20dbc6e1c04de34d3221b6cbfa652aafe75e5510
Signed-off-by: Yi Yang <yi.y.yang@intel.com>

Update .gitreview for stable/boron

Change-Id: I6caf2ebe1e13b331fc17b6157ed0e9f8ef7d4f32
Signed-off-by: Thanh Ha <thanh.ha@linuxfoundation.org>

Merge "Bug 5540 - ActionConvertor ordering"

Merge "BUG-6354: Altering the log-level to trace for triggering the loop whilw retrieving the flowId."

Bug 5540 - ActionConvertor ordering

- Fixed ordering of actions in ActionConvertor

Change-Id: I84c7d8bebb3b6ded2f52d97ab45232daa71a75e7
Signed-off-by: Tomas Slusny <tomas.slusny@pantheon.sk>

Merge "Mask Support for TCP and UDP ports in nicira extension "

BUG-6354: Altering the log-level to trace for triggering the
loop whilw retrieving the flowId.

Change-Id: I9664bd98fd20d5e57dbd55aff4c9676306ae2dd8
Signed-off-by: Shuva Kar <shuva.jyoti.kar@ericsson.com>

Bug 6259 - ArbitraryBitMask compare

- Updated MatchComparatorHelper to compare properly
  address-no-mask + arbitrary-bitmask fields with
  ipv4/6-source

Change-Id: Id58a715769c16cc443547055ee770b5306f210ae
Signed-off-by: Tomas Slusny <tomas.slusny@pantheon.sk>

Merge "Device*Registry quickfix - add failed"

Merge "Sonar issues"

Device*Registry quickfix - add failed

 - remove *Descriptor from cache if add* request failed
 [*-Flow/Group/Meter]

Change-Id: I7b88db179c54de9670e2f7ecb4903074aa4dc6a9
Signed-off-by: Andrej Leitner <andrej.leitner@pantheon.tech>

Bug 5540 - Remove ConvertorManager singleton

- Removed singleton from ConvertorManager
- Added ConvertorManagerFactory
- Now ConvertorManager lookup is also based on Openflow version
- New test for ConvertorManager

Change-Id: Ib23fa304143d6e2fb7f09781acc1fd0c6a3be5e8
Signed-off-by: Tomas Slusny <tomas.slusny@pantheon.sk>

Bug 5540 - Multiple convert types for one convertor

- Now convertor can specify multiple source types to convert
- Changed previous method of getting multiple source types from
  single source type to throw warning when it is used

Change-Id: If1e4cc9087f71dd5a0a38c10b053f7239de78998
Signed-off-by: Tomas Slusny <tomas.slusny@pantheon.sk>

Bug 5540 - ConvertorManager DataContainer source, one Convertor interface

- Changed source type for Convertor interface and ConvertorManager to must extend
  YANG DataContainer
- Started using getImplementedInterface() to get source type

Change-Id: Ic229c278516074f42218b45a5040d3601b386bd7
Signed-off-by: Tomas Slusny <tomas.slusny@pantheon.sk>

Bug 5540 - ConvertorProcessor DataContainer source, optimization

- Changed source type for ConvertorProcessor to must extend
  YANG DataContainer
- Removed double lookups
- Changed map with conversions to concurrent hash map
- Stopped using reflection for getting source type,
  instead use getImplementedInterface() from DataContainer

Change-Id: I82e4ded70526a9219125340e5dbf3b6f05d77296
Signed-off-by: Tomas Slusny <tomas.slusny@pantheon.sk>

Bug 5540 - ConvertorManager optimization, concurrency

- Split ConvertorManager functionality to interfaces ConvertorRegistrator and
  ConvertorExecutor
- Changed convertor maps to concurrent hash maps
- registerConvertor now returns old convertor if already registered instead of boolean
- Better type extraction from collections
- Removed duplicate map lookups
- Better log messages

Change-Id: I38c6bc119861fef844535c50740c65fa7ae43192
Signed-off-by: Tomas Slusny <tomas.slusny@pantheon.sk>

Bug 5540 - FlowConvertor, FlowStatsResponseConvertor, FlowInstructionResponseConvertor

- Reworked FlowConvertor, FlowStatsResponseConvertor to use new ConvertorManager design
- Added FlowInstructionResponseConvertor (moved some loic from FlowStatsResponseConvertor)
- Updated tests and usages accordingly

Change-Id: Iff2dc752aab73473adb955394cf852d7524fddd9
Signed-off-by: Tomas Slusny <tomas.slusny@pantheon.sk>

Bug 5540 - PacketOutConvertor

- Reworked PacketOutConvertor to use new ConvertorManager design
- Updated tests and usage of PacketOutConvertor accordingly

Change-Id: I9df612a7d9c3b9604c8119f86d2266723066e68a
Signed-off-by: Tomas Slusny <tomas.slusny@pantheon.sk>

Bug 5540 - GroupConvertor, GroupStatsConvertor, GroupDescStatsConvertor

- Reworked GroupConvertor and GroupStatsConvertor to new ConvertorManager design
- Added GroupDescStatsConvertor (moved some logic from GroupStatsConvertor)
- Updated (and fixed) tests, and updated usages accordingly

Change-Id: Iabae7191ceeefeb208487ab5cf0280e8f8186c3e
Signed-off-by: Tomas Slusny <tomas.slusny@pantheon.sk>

Bug 5540 - ActionConvertor, ActionResponseConvertor

- Reworked ActionConvertor to use new ConvertorManager desing
- Added new ActionResponseConvertor (moved a bit of logic from ActionConvertor)
- Updated tests and usages accordingly

Change-Id: I76a9b345942272dc555e4d75766968931ee4ecdb
Signed-off-by: Tomas Slusny <tomas.slusny@pantheon.sk>

Bug 5540 - PortConvertor, MatchConvertor

- Reworked MatchConvertorImpl and MatchConvertorV10Impl (extracted some logic from it)
- Added MatchResponseConvertor and MatchV10ResponseConvertor
- Updated and added new tests, and updated usage of match convertors
- Reworked PortConvertor to use new ConvertorManager design
- Updated tests and usage of PortConvertor accordingly

Change-Id: If53d7c521bf4a718a466ec7cd11d28e57d8cf4bd
Signed-off-by: Tomas Slusny <tomas.slusny@pantheon.sk>

Bug 5540 - MeterStatsResponseConvertor, MeterConfigStatsResponseConvertor

- Reworked MeterStatsResponseConvertor to use new ConvertorManager desing
- Moved part of logic of MeterStatsResponseConvertor to new
  MeterConfigStatsResponseConvertor
- Updated tests and usage of MeterStatsResponseConvertor and
  MeterConfigStatsResponseConvertor accordingly

Change-Id: I5555fae748fd8d3c2e0baa8d2b56ee450fe4697b
Signed-off-by: Tomas Slusny <tomas.slusny@pantheon.sk>

Bug 5540 - MeterConvertor

- Reworked MeterConvertor to use new ConvertorManager design
- Updated tests and usage of TableFeaturesConvertor accordingly

Change-Id: Icaf9a28d569ae76e396427d79241401f6517a46c
Signed-off-by: Tomas Slusny <tomas.slusny@pantheon.sk>

Bug 5540 - TableFeaturesResponseConvertor

- Reworked TableFeaturesReplyConvertor (renamed to TableFeaturesResponseConvertor) to
  use new ConvertorManager desing
- Updated tests and usage of TableFeaturesReplyConvertor/TableFeaturesResponseConvertor

Change-Id: Ifc48f3228ba09d6ee8cf87d902178957c3a67f7d
Signed-off-by: Tomas Slusny <tomas.slusny@pantheon.sk>

Bug 5540 - TableFeaturesConvertor

- Reworked TableFeaturesConvertor to use new ConvertorManager design
- Updated tests and usage of TableFeaturesConvertor accordingly

Change-Id: Ic2430412edac4cc0658f1fa7ccdecb5ebf937eef
Signed-off-by: Tomas Slusny <tomas.slusny@pantheon.sk>

Bug 5540 - ConvertorManager base

- Added base for ConvertorManager
- Removed datapathId from Convertor interface (as it was not needed anymore)
- Updated usages and tests accordingly
- Moved IPProtocols and IPConversionUtil to package
  org.opendaylight.openflowplugin.openflow.md.core.sal.convertor.common

Change-Id: I22940403495be5f0398682cab4e3377ee86ce7be
Signed-off-by: Tomas Slusny <tomas.slusny@pantheon.sk>

Bug 5895 - Support of Ext109 openflow tcp flag matching in openflowplugin

Flow matching based on TCP FLAGs is now ONF approved
extension for OpenFlow Spec 1.3.X. OVS also support this
extension as well as it's own version of Nicira Extension.

Depends-On: https://git.opendaylight.org/gerrit/#/c/42954/2

Change-Id: I23c1e9956112e72b28d24a088b375f2732e5523c
Signed-off-by: Anil Vishnoi <vishnoianil@gmail.com>

BUG:6058 - Currently the Operational Datastore does not get cleaned up and the switch
continues to persist if the node that is connected to the switch goes
down. The patch addresses it

Change-Id: I0e8a65c8f38ac9d4de1def65be1daf7afbab5d18
Signed-off-by: Shuva Kar <shuva.jyoti.kar@ericsson.com>

Mask Support for TCP and UDP ports in nicira extension

Reverting https://git.opendaylight.org/gerrit/#/c/40163/ The support is
added as a part of nicira extension and a part of standard of spec.

Change-Id: Id254155f026216f11c76264e6ff5ece57f306a94
Signed-off-by: Aswin Suryanarayanan <asuryana@redhat.com>

Added feature for forwardingrules-sync app

Change-Id: Ia9a65769e9a5466a536dd79802214f45f149a0ec
Signed-off-by: Andrej Leitner <anleitne@cisco.com>

Merge "Bug 6146 - Some Flows not found in DeviceFlowRegistry"

FRS - sonar issues and repackage

 - forwarders moved to strategy package
 - functions converted to labmdas
 - simplified statements
 - remove comments

Change-Id: I103d02f0dab3234ca9338f207a4102d814da2019
Signed-off-by: Andrej Leitner <anleitne@cisco.com>

Use SyncupEntry in syncup method (Bug 6170 cleaning)

 - used wrapper object SyncupEntry instead of two
   FCN objects in syncup (enriched with source DS types)
 - fixed skipping Config/Operational change in retry
   decorator with using SyncupEntry
 - made updateCompressionState more comprehensible
 - updated junit tests & improved logging

Change-Id: Iedcc94e9ce806c425e47f719e391cf7110ddb2c3
Signed-off-by: Andrej Leitner <anleitne@cisco.com>

Bug 6170 + Bug 5919 - made FRS cluster-aware

 - NodeListener changed to clustered DTCL
 - added ClusterRegistration per connected device
   with corresponding actions (on mastership change)
 - added ClusterServiceManager to register services
   at the provider and keep these registrations
 - added ClusterDecorator to skip modifications
   if device is not currently mastered
 - added and updated tests

Change-Id: I4fd9459e67cc5127f7eacca93adbd456a34fab0f
Signed-off-by: Andrej Leitner <anleitne@cisco.com>

Sonar issues

Change-Id: Ide7595adaf29db0d7f09456a60d8b8277ef497be
Signed-off-by: Icaro Camelo <icamelo@inocybe.com>

Cleaning and preparation before bug 6170

 - refactored name RetryRegistry -> ReconciliationRegistry
 - merged operational listener w/ retry subclass (since not needed)
 - extracted Modification util methods into new class
 - moved SwitchFlowId to utils
 - added some finals, lambdas and fixed typos
 - removed dead code

Change-Id: I4d62c157a39490e14be198e3757d206f3b780558
Signed-off-by: Andrej Leitner <anleitne@cisco.com>

Merge "Move empty match constant into OFConstants"

Merge "SONAR TD - SinglePurposeMultipartReplyTranslator - CC"