Bug 5412: Remove unnecessary import statement.

manager.neutron never uses DOM API.

Change-Id: I9feeb9582d2d7b560b80bb5d25ec3eb1c4c8004d
Signed-off-by: Shigeru Yasuda <s-yasuda@da.jp.nec.com>
(cherry picked from commit 48dfb61955d990bd6901a1b5f934c341eb1e5cd0)

Pull in PowerMock from odlparent.

Odlparent now manages dependencies for PowerMock, in sync with Mockito.
Rely on that instead of defining our own versions.

Change-Id: Ia07d06d7bf72c6ea1cfa2be1f9eb5acb5d537da5
Signed-off-by: Hideyuki Tai <Hideyuki.Tai@necam.com>

Fixed UT/IT breakage.

  * Use powermock 1.6.4.
  * Don't load mockito into IT container.

Change-Id: Ib15d9025ed76699b5ad7cf2497b345f48621a4d4
Signed-off-by: Shigeru Yasuda <s-yasuda@da.jp.nec.com>

Merge "Removed unused code in manager/neutron/src."

Removed unused code in manager/neutron/src.

  * Removed unused variables.
  * Removed unnecessary comments.

Change-Id: I87029846018f41a22f88515aac2020ddde30ef14
Signed-off-by: Hideyuki Tai <Hideyuki.Tai@necam.com>
(cherry picked from commit e40e830aaa8bd9954ab1d36aa5cd661f291578a5)

Removed unnecessary mocking in manager.neutron UT.

Other change:

  * Removed unused variables.

Change-Id: I3865cc4dc9b62bdf3160930f2512b2f8757c132e
Signed-off-by: Hideyuki Tai <Hideyuki.Tai@necam.com>
(cherry picked from commit ea24e0733844ce988dca607f8d81ab4ebd6f9add)

Removed unused code.

Other changes:

  * VNodeIdentifier.java: No need to check VNodeType in equals() and
    hashCode() because VNodeType is value is tied to VNodeIdentifier
    subclass and never shared with other class.

Change-Id: I213cd7375265413f0ee0a0929113907887fe0335
Signed-off-by: Shigeru Yasuda <s-yasuda@da.jp.nec.com>

Fixed sonar warning.

  * Utility classes should not have a public constructor

Other changes:

  * Increate unit test coverage.
  * Remove debugging code in unit test.

Change-Id: Ief8c10b02736f810a6b41eaf9e7d0a505f7614e1
Signed-off-by: Shigeru Yasuda <s-yasuda@da.jp.nec.com>
(cherry picked from commit 2e10dbcd0e3e551b1b50f81ece9a3db7d86684a1)

Fixed IT breakage.

Change-Id: I2b2e3e962562cd59ec657f4f76dbfa6df99e57dd
Signed-off-by: Shigeru Yasuda <s-yasuda@da.jp.nec.com>

Increase unit test coverage.

Other changes:

  * implementation: FlowActionConverter, BridgeIdentifier:
    Remove unnecessary constructor.

Change-Id: I315555c4df7d7cc70268be9228b64f8e12113e7c
Signed-off-by: Shigeru Yasuda <s-yasuda@da.jp.nec.com>
(cherry picked from commit 05590ed19fc439602ecfb6864a1fa3d3f25d4923)

Bug 5341 Fix for Failure in Fetching dataflows for vlan mapping

Change-Id: Id48cf634919138b3d203477250f9aff742e77ca0
Signed-off-by: gvrangan <venkatrangang@hcl.com>
(cherry picked from commit c1353ecf9d0178d0cb330b5132ee2b00c0d940d4)

Increase unit test coverage.

  * Added unit tests for manager.internal.vnode.xml package.

Other changes:

  * Fixed incorrect javadoc comments.
  * implementation: XmlVInterface.java: Don't use raw type.
  * it/util: VTNInetAddrAction.java: Added @Override annotation.

Change-Id: Id5c0652c3a163f900a99dc64cdc53421cc25305c
Signed-off-by: Shigeru Yasuda <s-yasuda@da.jp.nec.com>
(cherry picked from commit 708de22d43ac3b06aaaee49fe9e22863d283cd7e)

Fixed unstable integration test.

  * Wait for completion of asynchronous tasks as needed.

Change-Id: Id323640c029fc536890b9152e74d4529ee696680
Signed-off-by: Shigeru Yasuda <s-yasuda@da.jp.nec.com>
(cherry picked from commit e9f68a64593c93485b2142234b547f15628176af)

Merge "BUG 4678: Fixed Port map configuration with OpenStack Liberty"

BUG 4678: Fixed Port map configuration with OpenStack Liberty

Change-Id: I36b4f2692aed5997792dc552bd839d31b15d733a
Signed-off-by: ananthip <ananthip@hcl.com>
(cherry picked from commit 6baea77be7a4c72df434d380fd262d355a7689bf)

BUG 5234: Fixed FT scripts in VTN Coordinator

* Modified FT scripts in VTN Coordinator for VTN Manager RESTCONF
* Updated VBR, VBRIF_PORTMAP, VTERM, VTERMIF_PORTMAP, VBRIF/VTERMIF
  Flowfilter keytypes and its audit FT files.
* Modified Multi-Controller FT files.
* Modified the datafiles for the above Keytypes to support RESTCONF.
* Modified the validate functions in test scripts.

Change-Id: Iabdeb197687f5b04c019f790359cb1aaf82134fb
Signed-off-by: Karthik.S <siva-karthik@hcl.com>
(cherry picked from commit 8fbe60bf97169fa8eaa2a73e307b59c9d85f387c)

BUG 5300: Fixed UT for ODCdriver in VTN Coordinator

* Modified the UT for ODCdriver module in VTN Coordinator for
  the RESTCONF changes in VTN Manager.
* Fixed the UT failures in ODCdriver module.

Change-Id: Id0676211b62d30e1853dbc5f9a55f6af647a7a4f
Signed-off-by: yogalakshmi.pa <yogalakshmi.pa@hcl.com>
(cherry picked from commit 28ebb41f2e9de0dce2c4ded2ed918b4c7a1b848d)

Merge "Bug 5286: Fixed description attribute issue in create operation."

Merge "Bug 5294: Fixed update issue in flowfilter and flowlist keytypes"

Bug 5286: Fixed description attribute issue in create operation.

* Addressed for vtn/vbrif/vterminal/vtermif keytpes

Change-Id: I530a655370eecf6404dabc939009ac8646aaec8a
Signed-off-by: yogalakshmi.pa <yogalakshmi.pa@hcl.com>
(cherry picked from commit 1b3aec2a3b58f0525d7c2ee29995611cd8bf309d)

Bug 5294: Fixed update issue in flowfilter and flowlist keytypes

* vBrflowfilter update fails due to redirect node destination
  error
* vTermifflowfitler update to redirect fails due to dl_src mac
  address issue
* Addressed the same issue in vtnflowfilter
* Flowlistentry update fails in srcIp and destIp with
  src_prefix and dest_preifx attributes.

Change-Id: I647e44f868823abfd5a87994f349883a7b3e3e64
Signed-off-by: yogalakshmi.pa <yogalakshmi.pa@hcl.com>
(cherry picked from commit 0877a006611c49c4981b1f47687d3d8e636e65c9)

Bug 5279: Fixed vlan-map create issue while configuring logicalportid.

* When vlanmap is configured along with logicalportid
  the create operation fails.
* Resolved the same for update operation also.

Change-Id: I4f75203dde4d4fa848022e6c5f5eb32d1a0662b0
Signed-off-by: yogalakshmi.pa <yogalakshmi.pa@hcl.com>
(cherry picked from commit 81605229d9063cc96617252f1cbb2c8695475d0f)

Bug 5277: Fixed vbrifflowfilter create operation issue.

* Issue in vbrifflowiflter-redirect creation while configuring
  dl_dst mac address attribute.

Change-Id: I4cb79ca79e8157472595e494c0023477ad2ee360
Signed-off-by: yogalakshmi.pa <yogalakshmi.pa@hcl.com>
(cherry picked from commit f7ff809fff06bae73c640900597b820309158a68)

Merge "BUG 5204: Fixed issue with portmap delete operation"

BUG 5230: Fixed the pathinfo processing issue in dataflow

* Pathinfo information was replicated multiple times
  in KT_VTN_DATALFOW and KT_DATAFLOW.
* Provided fix for the replication issue in both the
  dataflow keytypes.

Change-Id: I16376719713a9dd6c5408f532c14b2b04d26a536
Signed-off-by: yogalakshmi.pa <yogalakshmi.pa@hcl.com>
(cherry picked from commit aee34b8317ecb76f4e9333bb0e66f13aa9bf6231)

BUG 5204: Fixed issue with portmap delete operation

* portmap delete fails for the vbrif.
* Addressed the same for vterminalif keytpe.

Change-Id: I8e342cf47b9d1bb354e050b432117a288d6190dd
Signed-off-by: yogalakshmi.pa <yogalakshmi.pa@hcl.com>
(cherry picked from commit 2d9be5800e7a931953e51d12dcb1eed726942f72)

Merge "BUG 5189: Fix for portmap creation with vlan-id issue."

BUG 5189: Fix for portmap creation with vlan-id issue.

* Portmap creation fails when vlan-id is configured
* Addressed the same for vbrif and vterminalif portmap
  configuration

Signed-off-by: yogalakshmi.pa <yogalakshmi.pa@hcl.com>
Change-Id: Ib6003c3e1fdabbccfe41992ccdaf414971245f35
(cherry picked from commit e6217c57f66a6174d896e91a160074c85d5b2792)

Bug 4967: Fixed the Inet-Match attribute issue in Dataflow Key types

* Changes in the Auto-generated script of ODCdriver module
  for the Inet and action attributes in Dataflow keytype
* Incorrect direction set for the flowfilter key types

Change-Id: I6114b2fe4427c58f17e850efc53049ce3ae735f7
Signed-off-by: yogalakshmi.pa <yogalakshmi.pa@hcl.com>
(cherry picked from commit ac804c94bf93be0cf2f826d661e202c8ae0f8a06)

Merge "Bug 5123: Fixed stand-alone flowcondition delete issue."

Merge "Bug 5063: Supress debug statements in VTN Coordinator build."

Bug 5123: Fixed stand-alone flowcondition delete issue.

* Fixed the stand-alone flowcondition delete issue
  in ODCdriver module which was present in VTNManager
  even after the flowfilter was deleted.

Change-Id: I6804810e8758c1101b9590b79ec357f66cbe2634
Signed-off-by: yogalakshmi.pa <yogalakshmi.pa@hcl.com>
(cherry picked from commit 42e54bbd235fba75363014f244450f2c03297ab2)

Bug 5122: Fixed build issues reported in Ubuntu14.04

* Ubuntu 14.04 uses gcc 4.8.2
* Compilation warnings reported are addressed

Change-Id: I63b66f56f5398b1a3fc28195ed409199ced59aba
Signed-off-by: yogalakshmi.pa <yogalakshmi.pa@hcl.com>
(cherry picked from commit 6a4229fc08bc4de53e5627aa15f00b8b98539409)

Bug 5063: Supress debug statements in VTN Coordinator build.

* Supressing the debug statements in the Auto-generated script
  of ODCdriver module build.

Change-Id: I170cf321b2b3f418a8f5a3da5889a410464a4e34
Signed-off-by: yogalakshmi.pa <yogalakshmi.pa@hcl.com>
(cherry picked from commit 22f93095b0d9176516b250a2afe7f7db5339930d)

BUG 4965: Fetch issue with KT_VTN_DATAFLOWS

* Incorrect valid flag value set for Match count
  attribute in val_flow_cmn structure.
* Incorrect format of the  Logical port-id value.
* Incorrect interface state assigned to interfaces,
  resulted in issues in port mapped interfaces.

Change-Id: I77c1040fa658af39d107a0be265bc7c909969603
Signed-off-by: yogalakshmi.pa <yogalakshmi.pa@hcl.com>
(cherry picked from commit d2a6a1daabb72877c36523116cfb77ea420d94f5)

Bug 5236: Fixed inappropriate node name in VTN configuration file.

  * Use <vinterface> for virtual interface configuration.

Change-Id: Ie4656e3d5c26926fa1ac10334f506916709488f6
Signed-off-by: Shigeru Yasuda <s-yasuda@da.jp.nec.com>
(cherry picked from commit 52c912fe34fba56739037ecb71acede2ecbbae34)

Fixed typo and wrong indentation.

Change-Id: I1f2fc4c17af9626877fa85ff5ab5c9d065f3d842
Signed-off-by: Hideyuki Tai <Hideyuki.Tai@necam.com>
(cherry picked from commit 425a8d6af633eec6f9dcf8cfbfd16cea750d62f1)

BUG-2625: do not pull in mockito-all

Mockito-all seems to conflict with pax-exam, pull in only the bare
needed things.

Change-Id: I55452c0b6032a71adad91c13cfb30b1acf97c70f
Signed-off-by: Robert Varga <rovarga@cisco.com>
Signed-off-by: Shigeru Yasuda <s-yasuda@da.jp.nec.com>

BUG-2625: bump to equinox 3.9.1

Change-Id: If1268c6ac57d04d561d55e09024ad8f5334299e8
Signed-off-by: Robert Varga <rovarga@cisco.com>

Run integration tests without openflowplugin application.

Change-Id: I07404dc55bffd46fa8619b4ecb2cbd12d5eb7416
Signed-off-by: Shigeru Yasuda <s-yasuda@da.jp.nec.com>
(cherry picked from commit c0de14ae4fd45c9c82c450d000d0c918bf9e85e0)

Bug 4772 Fix to add ethernet interface as port to the bridge.

addPortToBridge method was adding the termination point
to the parent node instead of the bridge node entry.
Current fix fetches the bridge node from the configuration
DS  after bridge is added and then adds the termination point.

Change-Id: Id7a7eadf2b7be2d15495d7475e6bdfe214934420
Signed-off-by: gvrangan <venkatrangang@hcl.com>
(cherry picked from commit 5ff2710011995ea040a4a9d4a85b6613a56320f8)

Bug 5094: Fixed a bug in VTNManagerProviderImpl.isOwner(VTNEntityState).

It threw an IllegalStateException if the controller is not the owner
of the specified entity.

Change-Id: I59314cb156f7992086a9704d6faf00ad00903e6b
Signed-off-by: Shigeru Yasuda <s-yasuda@da.jp.nec.com>
(cherry picked from commit 5ebf5ef1711b66b2609d6d529fc09588201cdde8)

Increase integration test coverage.

  * MAC mapping

Change-Id: I62215e3e7ce8134c588168188ddebe1af9f71de1
Signed-off-by: Shigeru Yasuda <s-yasuda@da.jp.nec.com>
(cherry picked from commit 3f6047a0d09b08a3b7175f3e71cd989174f4ed0f)

Merge "Bug 5051: Fixed bug in get-mac-mapped-host RPC."

Merge "BUG 4966: Fetch issue for KT_DATAFLOWS"

Merge "VTN Manager - Neutron UT Files."

Bug 5051: Fixed bug in get-mac-mapped-host RPC.

  * get-mac-mapped-host should return host information specified by
    mac-addresses in RPC input.

Change-Id: I0bd98273cc9bec3c388b0c69ba6b849f0d02a3c7
Signed-off-by: Shigeru Yasuda <s-yasuda@da.jp.nec.com>
(cherry picked from commit 758e37b7bae129724ac913c7c86fa40da3e98bfc)

BUG 4966: Fetch issue for KT_DATAFLOWS

Change-Id: Iecbb359b860faf2b327005eefc70472cc13e026f
Signed-off-by: yogalakshmi.pa <yogalakshmi.pa@hcl.com>

Bump yangtools to 1.0.0-SNAPSHOT

Change-Id: I05a4620a3af2a7c609ad1f6a483a4182bd6dbead
Signed-off-by: Thanh Ha <thanh.ha@linuxfoundation.org>

VTN Manager - Neutron UT Files.

   * Added the listener UT files.

Change-Id: I412702aec061e8bdb6b2d5369e361ea63a5c1a88
Signed-off-by: ananthip <ananthip@hcl.com>

Bump versions by 0.1.0 for next dev cycle

Change-Id: I3650ef911740fe662f0707ce008f8f38be179151
Signed-off-by: Thanh Ha <thanh.ha@linuxfoundation.org>

Merge "Support for fetching  dataflows from VTN Manager"

Support for fetching  dataflows from VTN Manager

* Support operations are dataflows,vtn dataflows,
* Known Issues-odc_vtn_dataflow.cc:Refer to BugId:4965
* odc_dataflow.cc:Refer to BugId:4966
* Fetching Inet-Match in dataflows:Refer to BugId:4967

Change-Id: Iefca12dc269fe460982355a0204269e5b663283d
Signed-off-by: yogalakshmi.pa <yogalakshmi.pa@hcl.com>

Merge "VTN Manager - Neutron UT Files."

Merge "Support for fetching VTN Stations."

Support for fetching VTN Stations.

Change-Id: Id68a45ef1db5ea4cc75a30107603646674583e59
Signed-off-by: bharathi.m <bharathi.m@hcl.com>

VTN Manager - Neutron UT Files.

* Added Unit test Files for VTN-Manager Neutron Files.

Change-Id: Ie2652a66d36c43a5ac60f7de297dca28d918eb94
Signed-off-by: Arthi.b <arthi.b@hcl.com>

Bug 4961: Fix for audit failure in VTN
Coordinator

Signed-off-by: bharathi.m <bharathi.m@hcl.com>
Change-Id: I5515d41e9f48a33eeef53d142f0bba0fcac4725c

Modified Flowfilter,Flowfilterentry keytypes in VTN
Coordinator to invoke VTN Manager RPC.

* Supported operations are vtn_flowfilter,vbr_flowfilter,
  vbrif_flowfilter and vtermif_flowfilter.

Change-Id: Ibc623680f9fd5d277659330f82473571833fa223
Signed-off-by: yogalakshmi.pa <yogalakshmi.pa@hcl.com>

Modified Flowlist,FLowlistentry Keytypes in  VTN Coordinator
to invoke VTN Manager RPC

Change-Id: Ib35d0929c231cb9aa70417c965aa4d6db7716e26
Signed-off-by: yogalakshmi.pa <yogalakshmi.pa@hcl.com>

Fixed bug of MAC mapping RPCs.

  * Duplicate hosts in allowed-hosts should be eliminated.

Change-Id: Idad6caf5a6610173281a03b334f65c6301f70663
Signed-off-by: Shigeru Yasuda <s-yasuda@da.jp.nec.com>

Increase integration test coverage.

  * Flow condition

Change-Id: I7f8fbf62fe27256acd6c42f3a88e341f65aa2d80
Signed-off-by: Shigeru Yasuda <s-yasuda@da.jp.nec.com>

Increase integration test coverage.

  * Path map

Change-Id: Iae5ab95ff9d33ec147c9ef4dc6f79b88a08bbeb6
Signed-off-by: Shigeru Yasuda <s-yasuda@da.jp.nec.com>

Bug 4885: Fixed coordinator UT error on Fedora 22 (x86_64).

Change-Id: Ia8ee6ecbf99e93c4685dd2944c3f943477b10f2c
Signed-off-by: Shigeru Yasuda <s-yasuda@da.jp.nec.com>

Merge "Modify VTN Coordinator to invoke VTN RPC instead of REST API"

Modify VTN Coordinator to invoke VTN RPC instead of REST API

* Supported operations are Vtn, Vbridge, Vterminal,
  Vbr_vlanmap, Vbrif, Vtermif, Vbrif_portmap, Vtermif_portmap.
* Audit is working.
* Disabled UT temporarily.

Change-Id: Ib34b620ee14677753a88985e2c09d5ad01ff2edc
Signed-off-by: yogalakshmi.pa <yogalakshmi.pa@hcl.com>

Increase integration test coverage.

  * Flow filter
  * Path policy

Change-Id: I2b9c58fa298b53fd65f7b90a7969dc5810730087
Signed-off-by: Shigeru Yasuda <s-yasuda@da.jp.nec.com>

Merge "Added strict verification of vnode-path-fields."

Merge "Bug 4839: Reduce unnecessary barrier request on remove-flow RPC call."

Split too large integration test class.

Change-Id: I276fcc873e07da95419470d02a358867f27afff5
Signed-off-by: Shigeru Yasuda <s-yasuda@da.jp.nec.com>

Refactoring: Use DS transaction specific logger.

Change-Id: I52e6a75979fcbc12f238e758a6157aded47f1d09
Signed-off-by: Shigeru Yasuda <s-yasuda@da.jp.nec.com>

Added strict verification of vnode-path-fields.

A vnode-path-fields should be treated as an invalid path if it does not
specify the virtual bridge though it specifies the virtual interface.

Change-Id: I16f6328581fa8ff8e6d478d2974fac65bf0d87d7
Signed-off-by: Shigeru Yasuda <s-yasuda@da.jp.nec.com>

Suppress sonar warnings.

  * Declarations should use Java collection interfaces such as "List"
    rather than specific implementation classes such as "LinkedList"

Change-Id: Ie5b438854f063456de08f6299755ef295bfb2443
Signed-off-by: Shigeru Yasuda <s-yasuda@da.jp.nec.com>

Bug 4839: Reduce unnecessary barrier request on remove-flow RPC call.

Change-Id: I97bddad29371f5972de72ec1030c38b370e23a99
Signed-off-by: Shigeru Yasuda <s-yasuda@da.jp.nec.com>

Merge "Added MD-SAL clustering support."

Suppress sonar warnings.

  * Security - Array is stored directly

Change-Id: I691bca12209e14088fa1745b15f2aecf6e030555
Signed-off-by: Shigeru Yasuda <s-yasuda@da.jp.nec.com>

Added MD-SAL clustering support.

  * Use ClusteredDataChangeListener as appropriate.
  * Changed default value of vtn-config.init-timeout to 10 seconds.

Change-Id: I6d732bf1d6ff3c993c4b974d2b5d01caba4942e6
Signed-off-by: Shigeru Yasuda <s-yasuda@da.jp.nec.com>

Removed unused file.

Change-Id: Ia78878069514146426c6901e07326d1b94559ba1
Signed-off-by: Shigeru Yasuda <s-yasuda@da.jp.nec.com>

Merge "Removed listconfig application"

Removed listconfig application

Change-Id: I00d0c60d512dc5854bab39d81f43e6291011f6cf
Signed-off-by: ananthip <ananthip@hcl.com>

Merge "Fix Comments and space in neutron xml/yang files."

Fix Comments and space in neutron xml/yang files.

   * Fixed misleading description in vtn-neutron yang file
   * Fixed the space in config xml file

Change-Id: Ib767c0c7fb683e377c1ead0696bb1fd9264d6f7a
Signed-off-by: ananthip <ananthip@hcl.com>

Merge "Add profiles to enable vtncoordinator and vtnapps"

Merge "Use new MD-SAL notification API."

Merge "Ignore IntelliJ files"

Ignore IntelliJ files

Change-Id: Ie696aa46f2cce2595b7ffd92cf1b8a6362353865
Signed-off-by: Stephen Kitt <skitt@redhat.com>

Use odlparent-provided versions of junit and hamcrest

it/util is currently disabled, but for consistency's sake, this patch
pulls the versions of junit and hamcrest defined in odlparent.

Change-Id: I8075f40091ea5fc7a0a070d4a013adc09e920ccf
Signed-off-by: Stephen Kitt <skitt@redhat.com>

Use new MD-SAL notification API.

Change-Id: I24b3fe8d0643c4f1fa92139852e36284a7c3a8de
Signed-off-by: Shigeru Yasuda <s-yasuda@da.jp.nec.com>

Migrated integration tests to MD-SAL.

Change-Id: I481521ef7abe219b029de49744d1ff7e8427d501
Signed-off-by: Shigeru Yasuda <s-yasuda@da.jp.nec.com>

Add profiles to enable vtncoordinator and vtnapps

This patch adds 2 profiles vtncoordinator and vtnapps to allow users to
enable each feature respectively. Both profiles are disabled by default
and can be enabled as part of a Maven build by setting
-Pvtncoordinator,vtnapps.

Alternatively the 2 profiles can be enabled via passing a parameter
-Djenkins. This is useful for OpenDaylight CI to ensure these features
are activated during CI builds.

Change-Id: I19c26e2be0160742223f7f202ab58b0369fe286b
Also-by: Thanh Ha
Signed-off-by: gvrangan <venkatrangang@hcl.com>

Bug 4765: Reject negative DPID in node-id or node-connector-id.

Change-Id: Ib265cbd8a58388df178a87ec5eefe45d66fc9bc7
Signed-off-by: Shigeru Yasuda <s-yasuda@da.jp.nec.com>

Fixed bug that set invalid vTerminal state.

If a new disabled virtual interface is added to a vTerminal,
the vTerminal state should not be changed to DOWN.

Change-Id: Icab3f4c97da3af97a2976c856b9afcd47de77bb5
Signed-off-by: Shigeru Yasuda <s-yasuda@da.jp.nec.com>

Revert "Don't build VTN Coordinator and apps by default."

This reverts commit d5f175269d98aea6e366f6b3995ac30fe07b4b62
because it breaks autorelease build.

Change-Id: Ifde71c2ffc702f011870fe53c5e7148f2c24330d
Signed-off-by: Shigeru Yasuda <s-yasuda@da.jp.nec.com>

Don't build VTN Coordinator and apps by default.

  * Build the VTN Coordinator only if vtncoordinator profile is
    activated.

  * Build VTN applications only if vtnapps profile is activated.

Change-Id: Ie61b0d20107e09859cdf45987ed3869bf07b99f5
Signed-off-by: gvrangan <venkatrangang@hcl.com>

Reduced sonar warnings.

  * Methods should not be too complex.
  * Declarations should use Java collection interfaces such as "List"
    rather than specific implementation classes such as "LinkedList"
  * Avoid cycle between java packages
  * Collapsible "if" statements should be merged
  * Unused local variables should be removed
  * Unused private fields should be removed
  * Singular Field
  * String literals should not be duplicated
  * Useless imports should be removed

Change-Id: Ic5edefa8f9d92f7f5b54e89692ada674503c58b7
Signed-off-by: Shigeru Yasuda <s-yasuda@da.jp.nec.com>

Bug 4710: Fixed bug that set invalid error tag into RPC result.

Change-Id: I81fa0d4dafe64cb1b3b36016788671843087ccc8
Signed-off-by: Shigeru Yasuda <s-yasuda@da.jp.nec.com>

Removed all the AD-SAL APIs.

VTN no longer depends on AD-SAL.

  * This patch disables integration tests temporarily.
    It will be enabled again when it is migrated to MD-SAL.
  * Reduced lint warnings.
  * Refined some unit tests.

Change-Id: I03a2f6dae300488be8e2a9965e4c8d6f75d836a4
Signed-off-by: Shigeru Yasuda <s-yasuda@da.jp.nec.com>

Removed use of AD-SAL in manager.neutron.

Other changes:

  * Moved all internal classes to neutron.impl package so that they are
    not exported to other bundles.
  * Fixed bug that manager.neutron might break DatapathId specified by
    ovsdb.
  * Use InstanceIdentifierBuilder when manager.neutron creates an instance
    identifier that contains more than one path components.
  * Use new version of InstanceIdentifier.firstKeyOf().
  * Eliminate use of invalid doclet.
  * Suppressed FindBugs warnings.

Change-Id: I88582a81e0dcf08aded33b1f6bf4c402dccb2882
Signed-off-by: Shigeru Yasuda <s-yasuda@da.jp.nec.com>

Fixed unstable unit test for VTN Coordinator.

  * upll (vbr_entry_test.Redirect_Field_2)
    Fixed unstable test due to uninitialized memory.

Change-Id: I546335167c2b00c7c3f81385942860728e2f2e55
Signed-off-by: Shigeru Yasuda <s-yasuda@da.jp.nec.com>

Build VTN Manager API javadoc only if "docs" profile is activated.

  * Use maven plugins specified by odlparent.
    * maven-javadoc-plugin
    * maven-dependency-plugin
    * build-helper-maven-plugin

Change-Id: I1e9e1ef5a03c898f452a42045a55d35525d8c1b6
Signed-off-by: Shigeru Yasuda <s-yasuda@da.jp.nec.com>