Bug 3695 - UT GBP - 6 - neutron/ovsdb

NeutronHelper (93.2%)
EndpointHelper (97.0%)
InventoryHelper (90.0%)

Change-Id: Ibc373d7c250db3855a92181627220ce328b7f320
Signed-off-by: Kinsey Nietzsche <knietzsc@cisco.com>

Bug-3836: Don't catch Throwable (use Exception).

Throwables shouldn't be caught, and the code should
instead catch Exceptions. This patch fixes bugs of
this kind that were found by sonar.

Change-Id: If9eda19712141107efea6b4432cdb6b4d5c8bf29
Signed-off-by: Thomas Bachman <tbachman@yahoo.com>

Bug 3988 - Jenkins Build failing due to Changes is NeutronCRUDInterfaces

- NeutronRouterAware.java
- NeutronFloatingIpAware.java

See https://git.opendaylight.org/gerrit/#/c/23961/

Change-Id: I5329faa4fafe60494dfb37e688fa94ef747223bb
Signed-off-by: Dileep Ranganathan <dileep.ranganathan@intel.com>

Merge "Bug 3836 - sonar: Throwable and Error classes should not be caught - part1"

Merge "Bug 3854 - GBP sonar: System.out and System.err should not be used as loggers"

Bug 3836 - sonar: Throwable and Error classes should not be caught - part1

Change-Id: Ia994ac86100aca4f31dbe00d9f0a61db786a929a
Signed-off-by: Ruijing Guo <ruijing.guo@intel.com>

Bug 3914 - GBP sonar: Constants should be declared "final static"

Change-Id: Idbee2311dfa6ae94b4623f5167d1ec91993d873d
Signed-off-by: Ruijing Guo <ruijing.guo@intel.com>

Bug 3692 Ofoverlay-renderer - renderer/ofoverlay/sf

- ChainAction
- ClassificationResult

Change-Id: Iaa706247d8477d5cdd2606f898a546925cb4a400
Signed-off-by: Kinsey Nietzsche <knietzsc@cisco.com>

Bug 3854 - GBP sonar: System.out and System.err should not be used as loggers

Change-Id: Ib3e998bba62aba9a5a4bd683cd43a891cfffaa36
Signed-off-by: Ruijing Guo <ruijing.guo@intel.com>

Revert "Bug 3773: L2 EP is missing L3 Context + IP."

This reverts commit b39be843c7c41c13c3e5e053aa8f90ca9f572ae5.

Change-Id: I6b5a748c3838e982d8be0d23e1c09f05009f6c4b
Signed-off-by: Keith Burns (alagalah) <alagalah@gmail.com>
(cherry picked from commit 2a7626f09ca3953b21a3412c7c6b212afa6e309f)

Merge "Removal of POC."

Merge "Bug 3618: Tenant.OPER not removed when Tenant.CONF removed"

Removal of POC.

This will be handled via Vagrant etc.

Change-Id: I55156fd78de74dd8ab92dffbad13853c5044ab29
Signed-off-by: Keith Burns (alagalah) <alagalah@gmail.com>

Merge "Bug 3746 added check if node is also in oper DS"

Merge "Sonar bug fixes for SwitchManager.java"

Bug 3746 added check if node is also in oper DS

Based on info from OF plugin team:
if a node exists in OPER DS then routed RPC implementation is already registered

Change-Id: I6a7a9f6b5cde60d7b47dcbb3761c921163d35415
Signed-off-by: Martin Sunal <msunal@cisco.com>

Merge "BUG3517 - switched sigma topology to jointjs"

Merge "Bug 3446 - clear Inventory CONF augmentations"

BUG3517 - switched sigma topology to jointjs

Change-Id: Ic1652cc50a9bdd17ec4c9e3abb77a04759f1c760
Signed-off-by: Juraj Sebin <jsebin@cisco.com>

Bug 3446 - clear Inventory CONF augmentations

Inventory in CONF DS is cleared of tunnel and external interface
information when a switch manager connection disconnects.

Change-Id: If996c37947d71a57227ded49546120f1130272c7
Signed-off-by: Tomas Cechvala <tcechval@cisco.com>

BUG 3686 - Fixed refreshing selectboxes in contract detail

Change-Id: Ifc3d0c40a4cc81f6e219e41cab0678df02500bab
Signed-off-by: Zdenko Krnac <zkrnac@cisco.com>
Signed-off-by: Juraj Sebin <jsebin@cisco.com>

Bug 3618: Tenant.OPER not removed when Tenant.CONF removed

Change-Id: I010489727f36c390ff4fe59f259e79c9a06968ae
Signed-off-by: Konstantin Blagov <kblagov@cisco.com>

Bug 3690 - unit tests #4

SwitchManager

Change-Id: Id83aac3065fa276a76c582fff354882b9166c7a1
Signed-off-by: Kinsey Nietzsche <knietzsc@cisco.com>

Bug 3608 - Floating IP notifications fixed.

- Also fixed nasty Map NPE for unregister/register EP.
- Overuse of Maps are the devil's hand-maiden.

Change-Id: I144a528c54df036217fedffc0a3c6deccc31867b
Signed-off-by: Keith Burns (alagalah) <alagalah@gmail.com>

Merge "Bug 3791: Add gateway MAC to Prefix flowmod match."

Merge "Bug 3773: L2 EP is missing L3 Context + IP."

Bug 3791: Add gateway MAC to Prefix flowmod match.

The current implementation of flow-mods for
Layer 3 IP prefixes doesn't provide a gateway
MAC address for the matcher. This patch creates
separate flow-mods for each subnet with a gateway
on the node for this prefix.

Change-Id: I11b652d5cfe714e2d7a112632e94826482a931d5
Signed-off-by: Thomas Bachman <tbachman@yahoo.com>

Bug 3608 - Distributed External Gateway - flows only needed on local node for VM

Change-Id: Iacce577bd12cb6d08abeff2eea6d927b13caaaca
Signed-off-by: Keith Burns (alagalah) <alagalah@gmail.com>

Bug 3773: L2 EP is missing L3 Context + IP.

When an L2 EP is created after resolving the ARP
request for an external gateway, an external L2 EP
is created for it. That EP is missing the L3 information
(L3 Context + IP). This patch fixes that.

Change-Id: I55175773b697635e17c285be2cbc0af6fef1b2ec
Signed-off-by: Thomas Bachman <tbachman@yahoo.com>

Merge "Bug 3751 registration of INeutronSecurityRuleAware service"

Bug 3764: Duplicate L3 EPs.

This patch fixes duplicate L3 EPs, which happen
when an EP is reparented to a new L3 context
(e.g. when assigning an EP to a router in
OpenStack).

Change-Id: I4391ef517a35e59402fad427e24c44663855fa46
Signed-off-by: Thomas Bachman <tbachman@yahoo.com>

Merge "Bug 3751 registration of INeutronSecurityRuleAware service"

Bug 3751 registration of INeutronSecurityRuleAware service

Change-Id: I38489994a47f604f76ebb32aa524bad6764f7251
Signed-off-by: Martin Sunal <msunal@cisco.com>

Bug 3745: Fix for null tunnel port.

This fixes a bug where a list in an augmentation
is set to null, causing an IllegalArgumentExcpetion.

Change-Id: Ie183a97555216a2fb0538a5356941d71265bfd58
Signed-off-by: Thomas Bachman <tbachman@yahoo.com>

Bug 3751 registration of INeutronSecurityRuleAware service

Change-Id: I00713198bbb79bebf3b9386f5506e7d31e0301e1
Signed-off-by: Martin Sunal <msunal@cisco.com>

Merge "Bug 3740: Intra-subnet broken with multinode."

Bug 3244 - SFC support for symmetric and asymmetric chains.

Change-Id: I93de828b4a1dd12ce854ce7d9a9f673308a90fc3
Signed-off-by: Keith Burns (alagalah) <alagalah@gmail.com>

Bug 3740: Intra-subnet broken with multinode.

This patch fixes multinode forwarding when integrating
with devstack.

Change-Id: I184cef779eb2dbc97871f50035e763559522264a
Signed-off-by: Thomas Bachman <tbachman@yahoo.com>

Bug 3424: Adding support for L2 External Networks.

This patch is preparation for the rest of the fixes
to support L2 External networks. It moves the creation
of the L3 Endpoint for the gateway from when the gateway
port is attached to the router to when the subnet is
created.

Change-Id: Ieadf3b11604cb3378066e05b4ddf1b68205419d3
Signed-off-by: Thomas Bachman <tbachman@yahoo.com>

Bug 3588 getting of MAC based on ARP

- adds possibility to use ARP for getting missing MAC address of external router
- ARP is handling by packet In and Out openflow animal style

Change-Id: Id10aa70525e2b5e5317eb2c4ce789bb82e3da4b0
Signed-off-by: Martin Sunal <msunal@cisco.com>

Merge "Bug 3691 increased test coverage #6"

Bug 3691 increased test coverage #6

FlowEquivalence
MatchEquivalence

Signed-off-by: Kinsey Nietzsche <knietzsc@cisco.com>

bug3243 - unit tests #5

FlowCapableNodeConnectionListener
FlowCapableNodeListener
OfOverlayNodeListener

Change-Id: I4a65813ccab3b7653d4ea5f6ac26b67c0840bb2c
Signed-off-by: Kinsey Nietzsche <knietzsc@cisco.com>

Merge "Bug 3651: Fix creation of External EPG."

Merge "BUG3685, BUG3686"

Sonar bug fixes for SwitchManager.java

Fixed missing curly brace,
Block of commented-out lines of code removed,
Removed empty statement.

Change-Id: I88b5dd52ae1f02d3eb4b0fe11a23d39411bb6d08
Signed-off-by: Dileep Ranganathan <dileep.ranganathan@intel.com>

Bug 3244 - SFC Improvements for distributed classifier, robustness

- Added specific ChainActionFlow class for handling of chain specific flows.
- Added simultaneous multiencap support (VXLAN, VXLANGPE)
- Ensure non-symmetric chain, path. Not supported Li
- Added setting of C1/C2 in ExternalTable per destination
- "visited" pairs fixed for assymetry

Change-Id: Icf9118dec65a8d1e57a24d5702c9334b3b33aea3
Signed-off-by: Keith Burns (alagalah) <alagalah@gmail.com>

BUG3685, BUG3686

- sticky tenant
- action reference wizard fired from contract in expressed policy

Change-Id: I858a2645dd59f044ca85b1461157f046a78480bf
Signed-off-by: Daniel Malachovsky <dmalacho@cisco.com>

Merge "Bug 3268: OVSDB TP listener not processing deletes"

Revert "Bug 3460 removed ip prefix from DHCP/DNS flows"

This reverts commit c3f90110063549169ea1ca982d9b79edbdbdc89e.

Change-Id: Id45311f333a93379e10580fd45b190e534ccac87
Signed-off-by: Martin Sunal <msunal@cisco.com>

Bug 3268: OVSDB TP listener not processing deletes

Change-Id: Ic7d5153382c462cc277651c53ecfc43fa637f62c
Signed-off-by: Konstantin Blagov <kblagov@cisco.com>

Bug 3460 removed ip prefix from DHCP/DNS flows

Removes ip-prefix of EIC from and DHCP and DNS flows.
Only traffic based on destination port of these service is allowed.
IP prefix of EIC for ICMP is still part of flow match.

Removed comparison of flow priority in FlowEquivalence - duplicit flows are ignored

THIS COMMIT HAS IMPACT ON FLOW COUNT IN TABLE 4

Signed-off-by: Martin Sunal <msunal@cisco.com>

Bug 3651: Fix creation of External EPG.

The External EPG isn't created because the tenant
for it doesn't yet exist. This fixes that by adding
the true flag to the put, which causes the parent
node to be created.

Change-Id: I3eae011e0337dc191f070ef40433b24bdbbeff8e
Signed-off-by: Thomas Bachman <tbachman@yahoo.com>

Merge "Bug 3540: Implementation of FlowIds based on match data"

Merge "Bug 3607: Removing OpFlex from Sonar coverage."

Merge "BUG3619 - css mismatch with dlux"

BUG3619 - css mismatch with dlux

Change-Id: I15fe5a8bf9076a529ba11fe669b51dcc7bb8e007
Signed-off-by: Daniel Malachovsky <dmalacho@cisco.com>

Bug 3607: Removing OpFlex from Sonar coverage.

Change-Id: I2671696383ef89be351b35caa9d148d1071a0be8
Signed-off-by: Thomas Bachman <tbachman@yahoo.com>

Bug 3606: Fix features so UI pulls in backend.

The UI feature should pull in the backend feature. This
patch changes the UI feature so that it pulls in the
backend feature.

Change-Id: I281349277c09f708ed0db138b7059d2d36a8073e
Signed-off-by: Thomas Bachman <tbachman@yahoo.com>

Bug 3540: Implementation of FlowIds based on match data

Change-Id: Id5766bfbe3c065d5d4816402be73d79cee8f3871
Signed-off-by: Konstantin Blagov <kblagov@cisco.com>

BUG3582 - GBP UI - Subject detail in the Delivered policy
BUG3583 - GBP UI - Different element design in jointjs
BUG3584 - GBP UI -Positioning of elements
BUG3587 - GBP UI - missing links in expressed policy

Change-Id: Ic7606e6161416df15189f661639e8e22c11922b7
Signed-off-by: Daniel Malachovsky <dmalacho@cisco.com>

Merge "groupbased policy ui-rework"

Bug 3269 - Neutron External Gateway not functioning with floatingIP

Adding processing of NAT and External tables in OfOverlay

Change-Id: Ief7bf77fc2e805515488efb533ba1901dff63b59
Signed-off-by: Keith Burns (alagalah) <alagalah@gmail.com>

Bug 3243 increased test coverage #3

EndpointManager

Change-Id: Ibd034c26e9f5deaefa0f6cf36f5220021c0f916c
Signed-off-by: Kinsey Nietzsche <knietzsc@cisco.com>

groupbased policy ui-rework

reworked ui - pushed provisioning part to background
created governance part
-expressed policy
-delivered policy
-renderer state
-renderer configuration
-jointjs load fixed
- fixed design issues

created placeholders for other parts

Change-Id: I7a61934268e37899064be4c882206a2cbd1b7708
Signed-off-by: Juraj Sebin <jsebin@cisco.com>
Signed-off-by: Daniel Malachovsky <dmalacho@cisco.com>

Bug 3242: Tenant CONF -> OPER validation in PolicyEnforcer pattern not returning correct result

Change-Id: I05413d84ad1a7c6fbe7d0d07b39fe448b7f67186
Signed-off-by: Andrej Kincel <akincel@cisco.com>
Signed-off-by: Peter Žeby <peter.zeby@pantheon.sk>

Bug3318 removed groupbasedpolicy-openstackendpoint-config

Change-Id: I28ade2169917ff6cf62766f5607369df8d442761
Signed-off-by: Kinsey Nietzsche <knietzsc@cisco.com>

Incrementing versions by 0.1.0 for post-lithium master branch

Change-Id: Ie3302d76efa113ff30be151e4ed00e9062365f64
Signed-off-by: Thomas Bachman <tbachman@yahoo.com>

Bug3269 - Support for L3PrefixEndpoint and external endpoints in OfOverlay

Change-Id: I1cc40a963eca9b2a3f2ac2f334f7443c9a90e3cc
Signed-off-by: Keith Burns (alagalah) <alagalah@gmail.com>

PortSecurity changes for looping off EP instead of EPG.

Also adds support for external port.

Change-Id: Iafc3a961ef3ba9f60434ef8b2b65ce45b085fd1d
Signed-off-by: Keith Burns (alagalah) <alagalah@gmail.com>

Fixed issues with Inventory augmentations being over-written (ExternalInterfaces/Tunnel)

Externals
Neutron-ovsdb: InventoryHelper is writing these to CONF
SwitchManager is reading these from OfOverlayNodeConfig which comes from
CONF but it handles these inside a loop that is processing things from
FCNC.OPER.

Tunnels:
Neutron-ovsdb: InventoryHelper is writing these to OPER (which you never
see in POSTMAN… weird but squirrel).
SwitchManager handles these in two places: Looping on FCNC.OPER looking
for “*vxlan*", and processing OfOverlayNodeConfig from CONF.

Change-Id: I12a5738e3832228032368f0b5b45dcb050023a16
Signed-off-by: Keith Burns (alagalah) <alagalah@gmail.com>

Possible fix for OfOverlay overwrite (#2).

This is an attempt to fix an overwrite of data
in the Inventory Node's OfOverlay augmentation.
It changes the writes of the entire augmentation
to just a write of the tunnel elements.

Change-Id: I5a22dd31381558300544dfb3fcc154f18d71e337
Signed-off-by: Thomas Bachman <tbachman@yahoo.com>

Yang models for internal system health and fault aggregration.

- Instrumentation, leveraging data store instead of log to generate sane log messages.

Change-Id: I5e7eafd8a7f527c77fd5f47b3bc41b65b8cd0ed5
Signed-off-by: Keith Burns (alagalah) <alagalah@gmail.com>

Removal of OpenStackEndpoint YANG

Change-Id: I9be44f2bf640fa59026de2d7935bf61a40078ea6
Signed-off-by: Keith Burns (alagalah) <alagalah@gmail.com>

Merge "Bug 2814 - logical OR to AND in classifier"

Remove OpenStackEndpointGBP

- not needed. Openstack GBP API integration uses standard API and was back-ported to OpenStack Juno.

Change-Id: I1007410cdc6eabba5afdc362458aeddc4bb6bee4
Signed-off-by: Keith Burns (alagalah) <alagalah@gmail.com>

Bug 2814 - logical OR to AND in classifier

Fix of the logical OR behaviour within a rule and update of error messages accross all the
classifiers.

Change-Id: Id1e5157915772e13fcc5ff431321c40d3863ffdc
Signed-off-by: Tomas Cechvala <tcechval@cisco.com>

Added new FlowTables (NATMapper, ExternalMapper)
- IpPrefix support in DestMapper
- Implemented tableOffset as adding new tables that need skipping for NAT

Updated neutron-ovsdb to make NeutronGbpMapperListener

Added L3Endpoint for External Gateway Map

Change-Id: I1cdf13750ca3d28ab6bda6718e8983e95af44331
Signed-off-by: Keith Burns (alagalah) <alagalah@gmail.com>
Signed-off-by: Martin Sunal <msunal@cisco.com>

Merge "GBP UI fixes"

Changing of IidFactory

- solves compilation error

Signed-off-by: Martin Sunal <msunal@cisco.com>

Merge "Bug 3388 Added DNS and ICMP rules for DHCP EPG"

Merge "Bug 3269 Implementation of floating ip in neutron-mapper"

Merge "Bug 3359 - Duplication of methods for IID factory"

Bug 3388 Added DNS and ICMP rules for DHCP EPG

Change-Id: I7531ce8e391003ce415f6adb0ab2e52baece000e
Signed-off-by: Martin Sunal <msunal@cisco.com>

Bug 3243 increased test coverage #2

 - increased test coverage in groupbasedpolicy base
 - FIX PolicyScope.removeFromScope(

Change-Id: I5551736c8cdd81a9ebd270e2b4421454a0af0af9
Signed-off-by: Kinsey Nietzsche <knietzsc@cisco.com>

Merge "Bug 3051: Fix Unit Tests for IpPrefix."

Merge "Bug 3173 - group flows rendering fix."

Merge "Bug 3281 duplicate flow programming"

Merge "Removal of OpenContrail Renderer and config."

Bug 3359 - Duplication of methods for IID factory

Change-Id: Icbf2babc99aec5fda99f85fc392e62256777d372
Signed-off-by: Kinsey Nietzsche <knietzsc@cisco.com>

Merge "Adding EIC."

Bug 3269 Implementation of floating ip in neutron-mapper

- creates an endpoint representing floating ip port
- creates floating-ip-association-mappings
- creates endpoints-by-floating-ip-ports and floating-ip-ports-by-endpoints mappings
- contains workaround becaue of https://bugs.opendaylight.org/show_bug.cgi?id=3368

Signed-off-by: Martin Sunal <msunal@cisco.com>

Fix sonar test coverage reporting

 - added sonar-jacoco-listeners dependency - picks up jacoco report and
   transforms it into sonar report
 - modified jacoco-maven-plugin - so that sonar is able to pick up jacoco report

Change-Id: Iebd90d8afe96f9255ec11d427de970791316ff42
Signed-off-by: Michal Polkorab <michal.polkorab@pantheon.sk>

GBP UI fixes

Fixed labels in topology
Selecting topology when selecting items from right sidebar
Reorder buttons under Policy - moved L2L3 to bottom
added back and home buttons in #ff7300 color
network containment field is now selectbox
added required fields into endpoints
tenant added to registering EP
fixed access model wizard
fixed access model wizard design

Change-Id: Ie07073902959bacbb918530a7d1539bdc58b94d9
Signed-off-by: Juraj Sebin <jsebin@cisco.com>
Signed-off-by: Daniel Malachovsky <dmalacho@cisco.com>

Adding EIC.

This includes Endpoint Constraints in policy
resolution.

Change-Id: I29ed8014f598683f37174289ce66190a319c2775
Signed-off-by: Martin Sunal <msunal@cisco.com>
Signed-off-by: Thomas Bachman <tbachman@yahoo.com>

Bug 3243 increased test coverage #1

- increased test coverage in groupbasedpolicy base
- FIX EgKey.compareTo()

Change-Id: I189169fe1be6e60ed781c016d707f04429a1f950
Signed-off-by: Kinsey Nietzsche <knietzsc@cisco.com>

Bug 3269 Floating IP association in a model

Change-Id: Ieaab358da8f2b37712ec31d5064954d60aa6d30d
Signed-off-by: Martin Sunal <msunal@cisco.com>

Add Endpoints for external gateway and subnet.

- Endpoint for Router Gateway Interface
- L3PrefixEndpoints for subnet routes
- Subnet map for external gateways
- Check for port updates without tenant.

Change-Id: I8bc8825abb1f3c2972b79c73a434ee0047951948
Also-by: Martin Sunal <msunal@cisco.com>
Signed-off-by: Keith Burns (alagalah) <alagalah@gmail.com>
Signed-off-by: Martin Sunal <msunal@cisco.com>

Add underlay external port for inventory to OVSDB listener.

- leverages DevStack writing "other-config" for provider network and physical port.
- this it to determine egress from OfOverlay (external)

Change-Id: If346089a16d1cfb7d08e98499ed0555f02bd5b4f
Also-By: Thomas Bachman <tbachman@yahoo.com>
Signed-off-by: Keith Burns (alagalah) <alagalah@gmail.com>
Signed-off-by: Thomas Bachman <tbachman@yahoo.com>

Centralising DataStore and IidFactory.

- Needed this for L3PrefixEp.
- Can move other sub-project general helpers here
- Potentially can be structured as
-- General (all GBP)
-- Feature specific packages

Change-Id: I627b7ec6dcf82eda8ecb9b251e76f4ea77582ac3
Signed-off-by: Keith Burns (alagalah) <alagalah@gmail.com>