Jozef Gloncak [Mon, 7 Apr 2014 06:27:19 +0000 (08:27 +0200)]
bug - missing excaping of % character in String.format() method
Change-Id: Ic44ff0cf558efbba9c465ac760da13fcf3add2cb
Signed-off-by: Jozef Gloncak <jgloncak@cisco.com>
Ed Warnicke [Fri, 4 Apr 2014 16:41:22 +0000 (16:41 +0000)]
Merge "Resolve Bug:654 - Fix config-persister exception handling."
Tomas Olvecky [Fri, 4 Apr 2014 10:29:19 +0000 (12:29 +0200)]
Resolve Bug:654 - Fix config-persister exception handling.
Modify NetconfUtil to fail on any <rpc-error>, not detecting transaction conflicts. Move
exception handling to ConfigPusher.
Also fix bug when config-netconf-connector detects discrepancy between yang store and
config manager factories: persister will retry as if some capabilities were not found.
Change-Id: Ibd80fd3859031ae41301481dad9b50f74207e64c
Signed-off-by: Tomas Olvecky <tolvecky@cisco.com>
Tony Tkacik [Mon, 31 Mar 2014 07:20:57 +0000 (07:20 +0000)]
Merge "Bug 564 - add missing sal-remote dependency."
Tony Tkacik [Fri, 28 Mar 2014 19:13:21 +0000 (19:13 +0000)]
Merge "Resolve Bug:593. Persister should communicate via OSGi SR instead of TCP."
Robert Varga [Sun, 9 Mar 2014 13:57:41 +0000 (14:57 +0100)]
Bump netty.io to 4.0.17.Final
Change-Id: I0f8c3d6ec41561c9c85cba5f36119a0f1b635347
Signed-off-by: Robert Varga <rovarga@cisco.com>
Tomas Olvecky [Wed, 26 Mar 2014 09:11:26 +0000 (10:11 +0100)]
Resolve Bug:593. Persister should communicate via OSGi SR instead of TCP.
Config persister now pushes configuration to netconf service directly by
java calls instead of using TCP connection to localhost. This allows
removing netconf client dependency from config-netconf-connector and
removes confusion when running more than one ODL process with same
configuration.
Change-Id: I96426b0fd1fe7110a59111a2b563e7494ebb811b
Signed-off-by: Tomas Olvecky <tolvecky@cisco.com>
Milos Fabian [Tue, 25 Mar 2014 08:44:40 +0000 (09:44 +0100)]
Bug 564 - add missing sal-remote dependency.
Change-Id: Ic6968699f0214226dd9881d08684febeaf031525
Signed-off-by: Milos Fabian <milfabia@cisco.com>
Tony Tkacik [Tue, 25 Mar 2014 05:11:38 +0000 (05:11 +0000)]
Merge "Do not catch Throwables, but rather Exceptions"
Robert Varga [Fri, 14 Feb 2014 23:08:05 +0000 (00:08 +0100)]
Do not catch Throwables, but rather Exceptions
This turns catch Throwable into catch Exception, as doing the former
catches Errors, which are documented to be pretty much irrecoverable
conditions. Looking at
http://docs.oracle.com/javase/7/docs/api/java/lang/Error.html non of
these call sites can recover from an Error happening, so they should
never catch them.
Change-Id: I85237594f307a5a8778fb5a63f9dad4d120fc9d7
Signed-off-by: Robert Varga <rovarga@cisco.com>
Tony Tkacik [Tue, 18 Mar 2014 10:45:26 +0000 (10:45 +0000)]
Merge "Resolve Bug:448 - Remove yang-store api and impl."
Tomas Olvecky [Mon, 10 Mar 2014 08:56:13 +0000 (09:56 +0100)]
Resolve Bug:448 - Remove yang-store api and impl.
Depends on yangtools commit https://git.opendaylight.org/gerrit/#/c/5579/ .
Instead of having multiple bundle trackers for config and netconf, keep only
one. Each bundle containing yang files should use sal code generator, which
generates YangModuleInfo objects. Using this instead of speculatively having
to parse all current yang files for each adding bundle event allows not having
to deal with broken yang dependencies when bundle events come in wrong order.
Put SchemaContextProvider to OSGi SR in config-manager, so that any bundle
working with yang can use it. This replaces too specific YangStoreService which
was coupled with yang-jmx-generator. Users can listen for changes directly
on OSGi SR - they receive service changed event when yang module is added or
removed.
Change-Id: Iabcb35929a1eeef0df328f3f948d70e1bfcbba0d
Signed-off-by: Tomas Olvecky <tolvecky@cisco.com>
Tony Tkacik [Wed, 12 Mar 2014 10:16:42 +0000 (10:16 +0000)]
Merge "Bug 453 - sal-rest-connector doesn't provide stream discovery feature"
Tony Tkacik [Tue, 11 Mar 2014 11:21:44 +0000 (11:21 +0000)]
Merge "Cleanup warnings in restconf-broker NotificationService"
Tony Tkacik [Tue, 11 Mar 2014 11:17:54 +0000 (11:17 +0000)]
Merge "Prune long-deprecated APIs"
Robert Varga [Fri, 28 Feb 2014 13:27:51 +0000 (14:27 +0100)]
Cleanup warnings in restconf-broker NotificationService
The registration map is not needed and the executor is not used, so
remove them. Also reuse AbstractListenerRegistration in place of a
custom-coded class.
Change-Id: Ia4060370faa03fb85d9a90471938501a583072d3
Signed-off-by: Robert Varga <rovarga@cisco.com>
Robert Varga [Fri, 28 Feb 2014 12:42:05 +0000 (13:42 +0100)]
Prune long-deprecated APIs
Prune APIs which have been deprecated well before the Hydrogen release.
No outside users should be relying on them at this point.
Change-Id: I5b966c98733912ece175ce8fa5a4a821c3b2c6d9
Signed-off-by: Robert Varga <rovarga@cisco.com>
Robert Varga [Sun, 9 Mar 2014 13:44:46 +0000 (14:44 +0100)]
Remove unused import and raw type references
Fixes a couple of warnings just by removing imports and adding <?> to
Iterator.
Change-Id: I71f9a1e0176a1a72fb402e972b1e39ac6c1bba0f
Signed-off-by: Robert Varga <rovarga@cisco.com>
Martin Bobak [Mon, 3 Mar 2014 15:46:11 +0000 (16:46 +0100)]
Bug 453 - sal-rest-connector doesn't provide stream discovery feature
Change-Id: I01f21b5b27512f9a8a4babac9148eacf6e6ac36a
Signed-off-by: Martin Bobak <mbobak@cisco.com>
Tony Tkacik [Wed, 5 Mar 2014 09:25:41 +0000 (09:25 +0000)]
Merge "Remove duplicate netconf namespace constant"
Tony Tkacik [Wed, 5 Mar 2014 09:25:17 +0000 (09:25 +0000)]
Merge "Get rid of netconf operation filters"
Maros Marsalek [Tue, 4 Mar 2014 14:30:10 +0000 (15:30 +0100)]
Remove duplicate netconf namespace constant
Change-Id: I7af2cb2631136fb4ae947f7150ad2e5d8f2df567
Signed-off-by: Maros Marsalek <mmarsale@cisco.com>
Maros Marsalek [Tue, 4 Mar 2014 10:20:26 +0000 (11:20 +0100)]
Get rid of netconf operation filters
Merge NetconfOperationFilter interface into NetconfOperation
Execute all operations that can handle a certain request in chained execution (ordered by priority)
Reimplement all current filters as chained operations
Remove NetconfOperationRouter parameter from NetconfOperation
NetconfOperations handling the same request must have different priorities
Change-Id: Iab9c680e6eceab4059feb77616a9d006fb613711
Signed-off-by: Maros Marsalek <mmarsale@cisco.com>
Tony Tkacik [Mon, 3 Mar 2014 10:41:25 +0000 (10:41 +0000)]
Merge "Bug 383 - exception raised if key part of URI is incorrect"
Tony Tkacik [Mon, 3 Mar 2014 09:39:47 +0000 (09:39 +0000)]
Merge "Eradicate exificient from the repository"
Tony Tkacik [Mon, 3 Mar 2014 09:30:03 +0000 (09:30 +0000)]
Merge "Do not use currently-deprecated APIs"
Tony Tkacik [Mon, 3 Mar 2014 09:29:24 +0000 (09:29 +0000)]
Merge "Deprecate NetconfMessageHeader test class"
Tony Tkacik [Fri, 28 Feb 2014 14:03:52 +0000 (14:03 +0000)]
Merge "Cleanup dependencyManagement overrides"
Robert Varga [Fri, 28 Feb 2014 12:56:28 +0000 (13:56 +0100)]
Do not use currently-deprecated APIs
SchemaServiceListener has been renamed to SchemaContextListener
upstream, with the usual migration strategy. Let's use the latter where
possible.
Change-Id: Ic24596a424322d3bfbc0bca27a94cf281cde85e5
Signed-off-by: Robert Varga <rovarga@cisco.com>
Robert Varga [Fri, 28 Feb 2014 12:45:26 +0000 (13:45 +0100)]
Deprecate NetconfMessageHeader test class
This gets rid of the deprecation warnings, as the entire test will go
when NetconfMessageHeader goes.
Change-Id: Icfc90299d2a9227125671ed1ce0ef56632572f4e
Signed-off-by: Robert Varga <rovarga@cisco.com>
Robert Varga [Sat, 1 Feb 2014 08:01:20 +0000 (09:01 +0100)]
Eradicate exificient from the repository
Change-Id: I08e05f72818c22b6a46aee02a00c539006006905
Signed-off-by: Robert Varga <rovarga@cisco.com>
Tony Tkacik [Thu, 27 Feb 2014 16:06:03 +0000 (16:06 +0000)]
Merge "Exception for URI /restconf/operations/module_name:rpc ended with slash"
Robert Varga [Thu, 27 Feb 2014 12:19:48 +0000 (13:19 +0100)]
Cleanup dependencyManagement overrides
This patch gets rid of a few warnings coming from overriding version
specified in parent dependencyManagement section.
Change-Id: Ida9662498bd152cc91954dc1843045c0553164ba
Signed-off-by: Robert Varga <rovarga@cisco.com>
Jozef Gloncak [Fri, 14 Feb 2014 10:14:12 +0000 (11:14 +0100)]
Bug 383 - exception raised if key part of URI is incorrect
Null pointer exception was caused for case when it wasn't possible to
decode key part of URI (null value was returned)
For case when key leaf type was identityref and wasn't specified as
module_name:identity_name NullPointerException was raised.
Change-Id: I6343d98e6549c02906628c78f61f97c18b244fe4
Signed-off-by: Jozef Gloncak <jgloncak@cisco.com>
Tony Tkacik [Tue, 25 Feb 2014 18:40:06 +0000 (18:40 +0000)]
Merge "Refactor configuration for ConfigPersister."
Tony Tkacik [Tue, 25 Feb 2014 18:13:31 +0000 (18:13 +0000)]
Merge "Prune long-deprecated APIs"
Robert Varga [Wed, 19 Feb 2014 10:44:06 +0000 (11:44 +0100)]
Prune long-deprecated APIs
These APIs are from prototype days and have never properly worked. Prune
them to reduce the baggage we carry around.
Change-Id: I9ac89552edf76f0740c660c100ec0426627b413a
Signed-off-by: Robert Varga <rovarga@cisco.com>
Tony Tkacik [Tue, 25 Feb 2014 14:58:10 +0000 (14:58 +0000)]
Merge "Better exception handling when instantiating YangModelBindingProvider, fix confignetconfconnector activator."
Tomas Olvecky [Tue, 25 Feb 2014 13:44:26 +0000 (14:44 +0100)]
Better exception handling when instantiating YangModelBindingProvider, fix confignetconfconnector activator.
Do not just log exception if it occurs while calling getModuleInfo, but add it as nested exception.
Fix confignetconfconnector activator: if activator fails to find ConfigRegistry, stop method should interrupt searching for it.
Change-Id: I0b97e5a044be0fd2304b35d34f46a1c540aac248
Signed-off-by: Tomas Olvecky <tolvecky@cisco.com>
Tony Tkacik [Tue, 25 Feb 2014 11:58:13 +0000 (11:58 +0000)]
Merge "Integration test added to netconf-it to test identity (de)serialization."
Milos Fabian [Tue, 18 Feb 2014 09:44:24 +0000 (10:44 +0100)]
SalRemoteClientDeployer - instantiate SalRemoteClient for given URL.
SalRemoteClient:
-Creates schema context.
-Initialize mapping service
-Creates restconf client
-Starts sal remote service broker
-Provides consumer registaration
Change-Id: Idc0d8be4c088bac8a4df24b98e482184a6e54665
Signed-off-by: Milos Fabian <milfabia@cisco.com>
Tony Tkacik [Tue, 25 Feb 2014 11:24:49 +0000 (11:24 +0000)]
Merge "Reuse AbstractListenerRegistration"
Robert Varga [Wed, 19 Feb 2014 02:54:03 +0000 (03:54 +0100)]
Reuse AbstractListenerRegistration
No sense in defining a new class -- just reuse what's already there.
Also uncovers the fact that we're losing an underlying registration --
but let's deal with that once the ListenerRegistration API changes not
to throw exceptions on close().
Change-Id: I5a12b1d7ca89f1608bc54b3f1a520223e650d53f
Signed-off-by: Robert Varga <rovarga@cisco.com>
Maros Marsalek [Tue, 11 Feb 2014 16:40:39 +0000 (17:40 +0100)]
Refactor configuration for ConfigPersister.
Pulled Configuration class from ConfigPusher that contains all the delays, timeouts and attempts numbers.
Add tests for config perister.
Change-Id: I187e721e0120931d0cca519353db840905816a20
Signed-off-by: Maros Marsalek <mmarsale@cisco.com>
Tony Tkacik [Mon, 24 Feb 2014 17:22:10 +0000 (17:22 +0000)]
Merge "Modify config-api exceptions, bump config and netconf to 0.2.5-SNAPSHOT."
Jozef Gloncak [Tue, 18 Feb 2014 13:05:44 +0000 (14:05 +0100)]
Exception for URI /restconf/operations/module_name:rpc ended with slash
If URI of type /restconf/operations/module_name:rpc ends with slash
character (/) then exception with HTTP return code 404 and text
"Identifier IDENTIFIER_NAME can't contain slash character (/). If slash is
part of identifier name then use %2F placeholder."
Change-Id: Idbed90515280b414c10d28dc608faeee24986a29
Signed-off-by: Jozef Gloncak <jgloncak@cisco.com>
Ladislav Borak [Fri, 21 Feb 2014 12:19:50 +0000 (13:19 +0100)]
Added documentation into web socket in RestConf
Change-Id: I36fae4c8916c6d25a1b9619390467e48b64e8a3d
Signed-off-by: Ladislav Borak <lborak@cisco.com>
Maros Marsalek [Tue, 11 Feb 2014 15:36:32 +0000 (16:36 +0100)]
Modify config-api exceptions, bump config and netconf to 0.2.5-SNAPSHOT.
Change ConflictingVersionException and ValidationException to be checked instead of
runtime exceptions.
Fix ConfigPusher's ConflictVersionException handling that was introduced when IOException was
used to wrap RuntimeException.
Small fixes in netconf, more refactoring of exception handling will be needed there.
Maros Marsalek: Rebase commit + fix compliation issue in ShutdownTest
Change-Id: Iab89de6ef6ced0de0a267470f860912ae3c56892
Signed-off-by: Tomas Olvecky <tolvecky@cisco.com>
Signed-off-by: Maros Marsalek <mmarsale@cisco.com>
Maros Marsalek [Fri, 21 Feb 2014 10:48:44 +0000 (11:48 +0100)]
Integration test added to netconf-it to test identity (de)serialization.
Change-Id: I637011107edea916aaab35e8d2298bbbbabed653
Signed-off-by: Maros Marsalek <mmarsale@cisco.com>
Tony Tkacik [Fri, 21 Feb 2014 10:44:16 +0000 (10:44 +0000)]
Merge "Fix message aggregator for chunked netconf messages."
Maros Marsalek [Thu, 20 Feb 2014 12:19:03 +0000 (13:19 +0100)]
Fix message aggregator for chunked netconf messages.
Aggregator did not work with 1 message in multiple chunks.
Change-Id: I03cc89c3fc56a52f077fd21f77bd98e47ea358a9
Signed-off-by: Maros Marsalek <mmarsale@cisco.com>
Maros Marsalek [Tue, 18 Feb 2014 11:58:47 +0000 (12:58 +0100)]
Make use of new sendMessage method in AbstractNegotiator
Change-Id: Ieeb104aa34b8140936a1daf8011ba3b0effc79d5
Signed-off-by: Maros Marsalek <mmarsale@cisco.com>
Tony Tkacik [Wed, 19 Feb 2014 15:29:03 +0000 (15:29 +0000)]
Merge "bug 433 NPE in onGlobalContextUpdated of ControllerContext class"
Maros Marsalek [Tue, 18 Feb 2014 15:51:09 +0000 (16:51 +0100)]
Add ModuleInfoBackedContext loading strategy to RuntimeGeneratedMapping service.
RuntimeGeneratedMappingServiceImpl is now started by the config-manager.
ModuleInfoBackedContext is filled by BundleTracker in config-manager.
This fix allows use of yang identities in netconf and restconf.
Change-Id: Id59d9d2ce08bfc9216d90cb5673e2d02aafd9151
Signed-off-by: Maros Marsalek <mmarsale@cisco.com>
Jozef Gloncak [Wed, 19 Feb 2014 12:32:51 +0000 (13:32 +0100)]
bug 433 NPE in onGlobalContextUpdated of ControllerContext class
Input parameter of type SchemaContext of method onGlobalContextUpdated is
now checked if is different from null to be able to call getOperations method.
In addition clearing of map of rpcs was added.
Change-Id: I2b69d7f50acba041ade17acba8b3f2af7b3e4d9c
Signed-off-by: Jozef Gloncak <jgloncak@cisco.com>
Tomas Olvecky [Wed, 19 Feb 2014 10:58:33 +0000 (11:58 +0100)]
Stop config-manager as first bundle when shutting down container.
If config-manager is stopped after a configured module's bundle has been stopped, config-manager will be unable to cleanly
close other instances, so it needs to be stopped as first bundle.
GlobalEventExecutorModule (netty-global-event-executor) is singleton, enforce it in only allowing one instance
called 'singleton'.
Make shutdown grace period smaller in order to close netty threads sooner that shutdown issues System.exit(1).
Change-Id: I042c606a5bedc49492784dcb0a5ad4dcbdcb0939
Signed-off-by: Tomas Olvecky <tolvecky@cisco.com>
Tony Tkacik [Tue, 18 Feb 2014 15:18:53 +0000 (15:18 +0000)]
Merge "bug 344 interpretation of slashes ('/') in URI"
Jozef Gloncak [Mon, 17 Feb 2014 14:13:56 +0000 (15:13 +0100)]
bug 344 interpretation of slashes ('/') in URI
If slash (/) should be part of path parameter from URI it can be specified with %2F
placeholder.
e.g. list which key is "ke/y_1" CAN'T be specified as
list_name/ke/y_1
but should be constructed as
list_name/ke%2Fy_1
It is also necessary to add to target distribution folder
/opendaylight/configuration/config.ini
following line
org.apache.tomcat.util.buf.UDecoder.ALLOW_ENCODED_SLASH=true
Change-Id: Id07e7969247f3b60a44b808c95dac6375cebc011
Signed-off-by: Jozef Gloncak <jgloncak@cisco.com>
Maros Marsalek [Mon, 17 Feb 2014 14:03:57 +0000 (15:03 +0100)]
Fix warnings in netconf-api and netconf-util
Change-Id: Icd7f605796ddb38cc01ac08c4de7e3c62cc8da39
Signed-off-by: Maros Marsalek <mmarsale@cisco.com>
Robert Varga [Sat, 15 Feb 2014 17:24:21 +0000 (18:24 +0100)]
Improve NETCONF encoding performance
This changes the protocol encoder such that it is piped directly into
the output buffer rather than constructing intermediate buffers and
strings.
Change-Id: I4938b2fd72b2321d21617c4e9c8a4d491778b657
Signed-off-by: Robert Varga <rovarga@cisco.com>
Tony Tkacik [Tue, 18 Feb 2014 11:05:27 +0000 (11:05 +0000)]
Merge "Untangle the XML/Hello message decoders"
Tony Tkacik [Tue, 18 Feb 2014 11:01:13 +0000 (11:01 +0000)]
Merge "Do not instantiate multiple DocumentBuilderFactories"
Tony Tkacik [Tue, 18 Feb 2014 10:59:36 +0000 (10:59 +0000)]
Merge "Split message aggregators"
Tony Tkacik [Tue, 18 Feb 2014 10:58:25 +0000 (10:58 +0000)]
Merge "Correct encoding"
Tony Tkacik [Tue, 18 Feb 2014 10:57:13 +0000 (10:57 +0000)]
Merge "Cleanup framing mechanisms"
Robert Varga [Tue, 18 Feb 2014 08:53:30 +0000 (09:53 +0100)]
Fix a few more warnings
- Remove unused string constants
- Add type arguments
- Removed unused field
Change-Id: I8fbbd238a805d9445eecc4d7c65176ce4ff36b6d
Signed-off-by: Robert Varga <rovarga@cisco.com>
Robert Varga [Sun, 16 Feb 2014 05:46:06 +0000 (06:46 +0100)]
Untangle the XML/Hello message decoders
The tie between these classes was completely unnecessary -- we had this
complicated contract just for the sake of reusing couple of lines of
code. Untangle and optimize.
Change-Id: I6fd29ba0ff5d87a5fb2362e87e4fb1361544429f
Signed-off-by: Robert Varga <rovarga@cisco.com>
Robert Varga [Sun, 16 Feb 2014 05:44:49 +0000 (06:44 +0100)]
Do not instantiate multiple DocumentBuilderFactories
We're instantiating builders themsenves, so we can safely reuse a single
factory. No sense in initiating it more than once.
Change-Id: I70dfa2d5cc51a09722bb7ad41ce4d61f8691ac3d
Signed-off-by: Robert Varga <rovarga@cisco.com>
Robert Varga [Sun, 16 Feb 2014 04:29:51 +0000 (05:29 +0100)]
Split message aggregators
This splits the EOM aggregator and the chunked encoding aggregator. The
chunked encoding can be much more efficient and hardened as it allows
for proper stream processing.
We do not go the entire way here, just tighten the chunk header parsing
by keeping an explicit state machine. We still need to gather the entire
message before shifting it, as our downstream expects to see the message
in its entirety.
Change-Id: I60947b6d018b73581a56adda5212d3482dda61ea
Signed-off-by: Robert Varga <rovarga@cisco.com>
Robert Varga [Sun, 16 Feb 2014 03:31:16 +0000 (04:31 +0100)]
Correct encoding
NETCONF chunked encoding is transferred in US_ASCII, not UTF-8.
Change-Id: I33d45b0d2806c91aaf5c22fcaf3731fdad6cf7f6
Signed-off-by: Robert Varga <rovarga@cisco.com>
Robert Varga [Sat, 15 Feb 2014 22:21:51 +0000 (23:21 +0100)]
Cleanup framing mechanisms
This gets rid of pre-instantiated NetconfMessageHeader in favor of
creating a static constructor method.
Furthermore allow our output chunking to be variable and bump the
default from 1K to 8K. The upper limit on chunk size is 16M.
Change-Id: I0ab4405fc7d750cca5875049f03b053aa80037ef
Signed-off-by: Robert Varga <rovarga@cisco.com>
Tony Tkacik [Mon, 17 Feb 2014 16:30:03 +0000 (16:30 +0000)]
Merge changes I393151af,I0a302cde
* changes:
Fix unused field warnings
Fix warnings about overriden versions
Tony Tkacik [Mon, 17 Feb 2014 16:19:09 +0000 (16:19 +0000)]
Merge "Fix namespaces for netconf monitoring extensions."
Robert Varga [Sun, 16 Feb 2014 11:22:03 +0000 (12:22 +0100)]
Fix unused field warnings
Removes affected fields, add @Override annotations and make constant
fields final.
Change-Id: I393151af1459e31eeded0786cf32223068635172
Signed-off-by: Robert Varga <rovarga@cisco.com>
Robert Varga [Sun, 16 Feb 2014 11:03:08 +0000 (12:03 +0100)]
Fix warnings about overriden versions
With proper parent structure, version overrides should not be present.
Change-Id: I0a302cde1c619af76f9290f7e5ca5080ff4fe251
Signed-off-by: Robert Varga <rovarga@cisco.com>
Maros Marsalek [Tue, 11 Feb 2014 10:13:02 +0000 (11:13 +0100)]
Fix namespaces for netconf monitoring extensions.
Change-Id: Ib191dbcb121ead95db65263b4b478b8eac64c004
Signed-off-by: Maros Marsalek <mmarsale@cisco.com>
Robert Varga [Sun, 16 Feb 2014 10:22:45 +0000 (11:22 +0100)]
Cleanup warnings
Change-Id: I26d45b3f3856ddd893b54089521b5366deb34db3
Signed-off-by: Robert Varga <rovarga@cisco.com>
Tony Tkacik [Mon, 17 Feb 2014 09:56:36 +0000 (09:56 +0000)]
Merge "Do not access static methods through object instances"
Robert Varga [Sun, 16 Feb 2014 09:48:01 +0000 (10:48 +0100)]
Do not access static methods through object instances
Stops eclipse from complaining.
Change-Id: I153b651068cceb8263f2f4a8ea65b8de45a1ba50
Signed-off-by: Robert Varga <rovarga@cisco.com>
Martin Bobak [Thu, 13 Feb 2014 14:48:42 +0000 (15:48 +0100)]
removed obsolete config yang and RuntimeGeneratedMappingService
Change-Id: I86c721ecce6132bd545778fe9a7380684c53c8f8
Signed-off-by: Martin Bobak <mbobak@cisco.com>
Ed Warnicke [Thu, 13 Feb 2014 11:44:11 +0000 (11:44 +0000)]
Merge "Refactor Additional header for netconf hello message."
Ed Warnicke [Thu, 13 Feb 2014 11:31:25 +0000 (11:31 +0000)]
Merge "sal-restconf-broker initial implementation needs https://git.opendaylight.org/gerrit/#/c/5259/ and https://git.opendaylight.org/gerrit/#/c/5282/ to be merged for successful build"
Maros Marsalek [Tue, 11 Feb 2014 17:19:42 +0000 (18:19 +0100)]
Refactor Additional header for netconf hello message.
Allow additional header only for hello messages.
Introduce customized (en|decoders) for hello message to parse/serialize additional header.
These handlers are replaced after successful negotiation.
Change-Id: I54c441bc166e7141f503888f0eb1934882971045
Signed-off-by: Maros Marsalek <mmarsale@cisco.com>
Ed Warnicke [Wed, 12 Feb 2014 15:32:33 +0000 (15:32 +0000)]
Merge "Rework NETCONF interfaces"
Ed Warnicke [Wed, 12 Feb 2014 15:32:00 +0000 (15:32 +0000)]
Merge "Fix thread safety issues in netconf client"
Ed Warnicke [Wed, 12 Feb 2014 15:31:42 +0000 (15:31 +0000)]
Merge "Cache sessionID to increase readability"
Ed Warnicke [Wed, 12 Feb 2014 15:29:27 +0000 (15:29 +0000)]
Merge "Remove unused DefaultNetconfOperation marker"
Martin Bobak [Mon, 20 Jan 2014 13:27:44 +0000 (14:27 +0100)]
sal-restconf-broker initial implementation
needs https://git.opendaylight.org/gerrit/#/c/5259/
and https://git.opendaylight.org/gerrit/#/c/5282/ to be merged for
successful build
Change-Id: Ic665eaf25c908ed7633cfeee7629354d647ef09f
Signed-off-by: Martin Bobak <mbobak@cisco.com>
Robert Varga [Sun, 9 Feb 2014 22:41:45 +0000 (23:41 +0100)]
Rework NETCONF interfaces
NetconfSession and NetconfClientSessionListener are supposed to be
interfaces, not classes. Convert them to such and introduce utility
classes which retain their current functionality. Remove an unused
method and fix type safety warnings while we're at it.
Change-Id: Id7d78c831e3c3d46abb4379efe4a5ca353cd55ff
Signed-off-by: Robert Varga <rovarga@cisco.com>
Robert Varga [Sun, 9 Feb 2014 19:32:33 +0000 (20:32 +0100)]
Fix thread safety issues in netconf client
This patch introduces a proper asynchronous interface and reworks
internals such that thread safety is maintained.
Change-Id: I6eb1c56518b0b3cc6f64c1df8bc0c857298f79b9
Signed-off-by: Robert Varga <rovarga@cisco.com>
Robert Varga [Sun, 9 Feb 2014 17:04:16 +0000 (18:04 +0100)]
Cache sessionID to increase readability
Change-Id: Ia4440f8a30cdc9b987139879f471be67ffe1dc3f
Signed-off-by: Robert Varga <rovarga@cisco.com>
Robert Varga [Sun, 9 Feb 2014 15:48:01 +0000 (16:48 +0100)]
Remove unused DefaultNetconfOperation marker
DefaultCloseSession and DefaultGetSchema do not need the netconf
session. so drop their use of DefaultNetconfOperation.
Change-Id: I724bd56d913b0f836c88ca8d1b436be308852a30
Signed-off-by: Robert Varga <rovarga@cisco.com>
Robert Varga [Tue, 11 Feb 2014 14:42:42 +0000 (15:42 +0100)]
Fix yangtools API incompatibility
Change-Id: Ia6883492a49765f1ffcd38128fcd6084636bc470
Signed-off-by: Robert Varga <rovarga@cisco.com>
Ed Warnicke [Tue, 11 Feb 2014 01:51:11 +0000 (01:51 +0000)]
Merge "Fix a warning"
Robert Varga [Sun, 9 Feb 2014 15:16:06 +0000 (16:16 +0100)]
Fix a warning
Change-Id: I8605ada63c471d9446ebf7fe31fb518138422cd4
Signed-off-by: Robert Varga <rovarga@cisco.com>
Robert Varga [Sat, 8 Feb 2014 02:45:52 +0000 (03:45 +0100)]
Rewrite POSSIBLE_ENDS and POSSIBLE_STARTS
These two are really simple byte arrays, initialized them as such
withouth going through strings/UTF8.
Change-Id: Id80151d9ff57df4b7a5595f76f30a379d89af3dd
Signed-off-by: Robert Varga <rovarga@cisco.com>
Ed Warnicke [Tue, 11 Feb 2014 00:08:29 +0000 (00:08 +0000)]
Merge "Some methods should be final"
Ed Warnicke [Mon, 10 Feb 2014 23:50:32 +0000 (23:50 +0000)]
Merge "Expose ChannelFuture from sendMessage()"
Ed Warnicke [Mon, 10 Feb 2014 23:49:36 +0000 (23:49 +0000)]
Merge "Getter methods should be final"
Ed Warnicke [Mon, 10 Feb 2014 23:44:58 +0000 (23:44 +0000)]
Merge "Fix a warning and make field final"