Tomas Cere [Wed, 27 Jul 2016 11:12:03 +0000 (13:12 +0200)]
Revert "Bump apache mina to 1.2.0"
This reverts commit
3911a32461cf5817787c807cad676d4164f0cbd4.
Change-Id: Ia4cdf9a281706157933326f7e8de1ef95bcbb6a6
Signed-off-by: Tomas Cere <tcere@cisco.com>
Jakub Toth [Fri, 8 Jul 2016 13:44:52 +0000 (15:44 +0200)]
Bug 3959 - support netconf notification
*added dependency for converting JSON to XML
*created new notification listener adapter extended
by DOMNotificationListener
*added augment for sal-remote to add new param
for input of create-notification-stream rpc to
make a choice between JSON or XML output of
notification (not mandatory - default is XML)
*added unit tests
Change-Id: I7f5909208dce71e2280fd1bc6dbe49cb7533523a
Signed-off-by: Jakub Toth <jatoth@cisco.com>
Tomas Cere [Mon, 25 Jul 2016 12:11:49 +0000 (12:11 +0000)]
Merge "Bump apache mina to 1.2.0"
Thanh Ha [Sat, 23 Jul 2016 03:12:52 +0000 (23:12 -0400)]
Add missing license headers
Change-Id: Ic4bb7ae58d821c8c00849db4b934c5eeb3bf5b68
Signed-off-by: Thanh Ha <thanh.ha@linuxfoundation.org>
Robert Varga [Thu, 14 Jul 2016 12:19:18 +0000 (14:19 +0200)]
Bump apache mina to 1.2.0
Bumps the dependency from pre-release to the current
release. Also adjusts implementation to match changed APIs.
Change-Id: Ia5d7479e32cbd25c9f9f67a5866a5d2830f146d6
Signed-off-by: Robert Varga <rovarga@cisco.com>
Tomas Cere [Tue, 19 Jul 2016 07:57:28 +0000 (07:57 +0000)]
Merge "Switch to using StandardCharsets"
Robert Varga [Mon, 18 Jul 2016 14:52:02 +0000 (16:52 +0200)]
Switch to using StandardCharsets
Guava's Charsets should not be used in recent Java
environments.
Change-Id: I24d14cd2410ba3d249037e802b7863a6141c89db
Signed-off-by: Robert Varga <rovarga@cisco.com>
Jakub Morvay [Mon, 18 Jul 2016 14:18:58 +0000 (16:18 +0200)]
Use upgraded ietf-{inet,yang}-types in test-tool
Change-Id: I5c99b7bb815f723bbc7640b4c118f5ee395fe6cf
Signed-off-by: Jakub Morvay <jmorvay@cisco.com>
Tomas Cere [Mon, 18 Jul 2016 07:58:42 +0000 (07:58 +0000)]
Merge "Organize Import to conform to Checkstyle guidelines."
Tomas Cere [Mon, 18 Jul 2016 07:53:16 +0000 (07:53 +0000)]
Merge "Bug 5682 - MDSAL netconf northbound yang library"
Jakub Morvay [Sun, 19 Jun 2016 19:07:28 +0000 (21:07 +0200)]
Bug 5682 - MDSAL netconf northbound yang library
This adds support for ietf-yang-library for MDSAL netconf northbound
server
Change-Id: Iab6178d2fc975860f7c5c835517fc3c120faebb7
Signed-off-by: Jakub Morvay <jmorvay@cisco.com>
Jakub Morvay [Thu, 14 Jul 2016 08:37:30 +0000 (10:37 +0200)]
Bug 6154 - Connection to config subsystem netconf endpoint refused
Makes config subsystem SSH server listen on address 0.0.0.0 instead of
127.0.0.1.
Change-Id: I7577629763b7d5a0d86d92ea0e997a80e841f360
Signed-off-by: Jakub Morvay <jmorvay@cisco.com>
Robert Varga [Sun, 17 Jul 2016 08:25:10 +0000 (10:25 +0200)]
Adjust tests to new ietf-inet-types
Change-Id: I39d6bebfb178950f828bce912a8b3e533b0e1abc
Signed-off-by: Robert Varga <rovarga@cisco.com>
Michael Vorburger [Mon, 30 May 2016 17:20:02 +0000 (19:20 +0200)]
Organize Import to conform to Checkstyle guidelines.
Change-Id: Ia766cb2af1c13808a7a0b28761fdd241c781319b
Signed-off-by: Michael Vorburger <vorburger@redhat.com>
Lorand Jakab [Wed, 6 Jul 2016 13:56:38 +0000 (08:56 -0500)]
Upgrade ietf-{inet,yang}-types to 2013-07-15
Change-Id: I632370c6e9b078817c69a19b3f7c1c17846ce249
Signed-off-by: Lorand Jakab <lojakab@cisco.com>
Jakub Toth [Fri, 6 May 2016 09:42:27 +0000 (11:42 +0200)]
Bug 5526 - Testing - RestconfModulesService
Unit tests for RestconfModulesServiceImpl + repackaging of tests
Change-Id: I0cb9c7b753d5c4c54d4d4d393d86787294a0903e
Signed-off-by: Jakub Toth <jatoth@cisco.com>
Ivan Hrasko [Mon, 9 May 2016 13:42:24 +0000 (15:42 +0200)]
Bug 5526 - Testing - Utils - Mapping
Unit test for RestconfMappingNodeUtil
Change-Id: I8c2be08791b1e87a59b198c5f145ef3fe0961376
Signed-off-by: Ivan Hrasko <ivan.hrasko@pantheon.tech>
Signed-off-by: Ivan Hrasko <ihrasko@cisco.com>
Jakub Toth [Mon, 13 Jun 2016 16:05:13 +0000 (18:05 +0200)]
Bug 5528 - Connecting RESTful part to restconf + fix bugs
*new wrapper for transaction services
*wrapper for transaction and base services
*fix bugs
*fix serializer of YII for create right prefix of namespace
Change-Id: I847eb536d94ff0e1b0c1e34cbb8d7c110b744ac4
Signed-off-by: Jakub Toth <jatoth@cisco.com>
Jakub Toth [Thu, 9 Jun 2016 09:48:48 +0000 (11:48 +0200)]
Bug 5528 - Subscribing to stream impl
*preparing dom data broker handler
Change-Id: Id90c13e8ebba1b60237a45808c973ccdf3a8dcda
Signed-off-by: Jakub Toth <jatoth@cisco.com>
Jakub Toth [Wed, 8 Jun 2016 16:37:16 +0000 (18:37 +0200)]
Bug 5528 - Create stream for DS
Change-Id: I2bdd16302aebd70c8929bbedfa99672358a96c91
Signed-off-by: Jakub Toth <jatoth@cisco.com>
Jakub Toth [Tue, 7 Jun 2016 09:18:05 +0000 (11:18 +0200)]
Bug 5528 - Streams service impl - prepare impl by interface
Change-Id: Ib3d2a755159ee90b2fdafde2aa203f1f5dacbcbd
Signed-off-by: Jakub Toth <jatoth@cisco.com>
Jakub Toth [Mon, 6 Jun 2016 14:00:49 +0000 (16:00 +0200)]
Bug 5528 - Invoke RPC impl
*create RpcServiceHandler for handling service of rpc
*create factory of rpc result
Change-Id: I2b2fff5558887e8c6f5e370b36d197dbde271955
Signed-off-by: Jakub Toth <jatoth@cisco.com>
Jakub Toth [Thu, 2 Jun 2016 08:26:19 +0000 (10:26 +0200)]
Bug 5528 - RPC invoke impl - prepare impl of interface
Change-Id: I571166124fbe7588f187091976af6b8d6deb6e22
Signed-off-by: Jakub Toth <jatoth@cisco.com>
Jakub Toth [Tue, 31 May 2016 08:41:25 +0000 (10:41 +0200)]
Bug 5528 - Delete data impl
Change-Id: I47955a4f6563c3ae5ab5d5db38823530bf013cba
Signed-off-by: Jakub Toth <jatoth@cisco.com>
Jakub Toth [Sun, 29 May 2016 08:55:37 +0000 (10:55 +0200)]
Bug 5528 - Impl Post data
*added new constant for post data
*added location to response factory
*moved ensureParentsByMerge to common util class of Put and Post
Change-Id: I2d525a1e602170ef41fd332bb8db9dfabd59e188
Signed-off-by: Jakub Toth <jatoth@cisco.com>
Jakub Toth [Thu, 26 May 2016 13:50:31 +0000 (15:50 +0200)]
Bug 5528 - Put data impl
*make FutureCallbackTx more generaly
*factory for NormalizedNode(READ) and Response(PUT) from Future
*fix ReadDataTransactionUtil after remake of FutureCallbackTx
Change-Id: Iec2d35271881c7ffe630cdd832510a3f0df7616a
Signed-off-by: Jakub Toth <jatoth@cisco.com>
Jakub Toth [Thu, 26 May 2016 08:32:29 +0000 (10:32 +0200)]
Bug 5528 - Read data impl
*impl RestconfDataService
*util class for constants
*wrapper for transaction vars
Change-Id: I61f4662b61ac9cf15535492f31bc896a863ce986
Signed-off-by: Jakub Toth <jatoth@cisco.com>
Jakub Toth [Thu, 26 May 2016 08:25:57 +0000 (10:25 +0200)]
Bug 5528 - Handlers
*make handlers immutable
*DOMMountPointServiceHandler
*SchemaContextHandler
*TransactionChainHandler
*common interface for all handlers
*fix dependencies of these changes
Change-Id: I4f3a78103036d88a5129f084bd088cd51c5b549c
Signed-off-by: Jakub Toth <jatoth@cisco.com>
Jakub Toth [Thu, 12 May 2016 08:58:35 +0000 (10:58 +0200)]
Bug 5528 - Preparing enviroment for impl of restful services
* repackeging
* fixing changes
Change-Id: I2ece0416ed09c3fc3517957427e18673406013de
Signed-off-by: Jakub Toth <jatoth@cisco.com>
Jakub Morvay [Tue, 21 Jun 2016 11:23:03 +0000 (13:23 +0200)]
Bug 5403 - Support yang-library schema resolution
Change-Id: I3599d3cf857cbb7b40c17aafadc9db7c83c4b09d
Signed-off-by: Jakub Morvay <jmorvay@cisco.com>
Tomas Cere [Tue, 28 Jun 2016 08:26:12 +0000 (08:26 +0000)]
Merge "Bug 5526 - Unit testing"
Tomas Cere [Tue, 28 Jun 2016 08:07:41 +0000 (08:07 +0000)]
Merge ".gitignore .factorypath created by m2e-apt"
Ivan Hrasko [Tue, 28 Jun 2016 07:42:02 +0000 (09:42 +0200)]
Bug 5526 - Unit testing
Fix for streams service unit testing. Prepare test streams
before tests are run and clean test streams after tests completed.
Change-Id: Ic61b7adcdc8aa48ee54d2f164143152729c6a899
Signed-off-by: Ivan Hrasko <ihrasko@cisco.com>
Jakub Toth [Fri, 6 May 2016 08:38:32 +0000 (10:38 +0200)]
Bug 5528 - API for RESTful - transaction part of CRUD
Change-Id: I2e8fad15f1ee2f9fbef1dfabdd36258c59c9d86e
Signed-off-by: Jakub Toth <jatoth@cisco.com>
Tomas Cere [Tue, 21 Jun 2016 11:02:11 +0000 (11:02 +0000)]
Merge "Add simulated discard-changes to testtool default datastore"
Tomas Cere [Tue, 21 Jun 2016 10:31:17 +0000 (10:31 +0000)]
Merge "Stop using blocking invoke for lock and editConfig."
Tomas Cere [Tue, 21 Jun 2016 10:24:33 +0000 (12:24 +0200)]
Add simulated discard-changes to testtool default datastore
Change-Id: Id07a30610399ba498fd35cff3086134aaf20bcb7
Signed-off-by: Tomas Cere <tcere@cisco.com>
Tomas Cere [Mon, 20 Jun 2016 13:35:32 +0000 (13:35 +0000)]
Merge "Propagate reconnectOnSchemasChanged flag to ClusteredNetconfDevice"
Tomas Cere [Mon, 20 Jun 2016 11:42:32 +0000 (11:42 +0000)]
Merge "Bug 5708 - Schemaless mount point notifications"
Tomas Cere [Mon, 20 Jun 2016 09:00:18 +0000 (09:00 +0000)]
Merge changes Ife737bb3,Ifa1e8774
* changes:
Bug 5527: Unit testing - serializer
Bug 5527: Unit testing - codec
Tomas Cere [Mon, 20 Jun 2016 08:58:36 +0000 (08:58 +0000)]
Merge "Bug 5527: Unit testing - deserializer"
Tomas Cere [Mon, 20 Jun 2016 08:55:29 +0000 (08:55 +0000)]
Merge "Bug 5526 - Testing - Utils - Schema util"
Ivan Hrasko [Mon, 9 May 2016 13:45:38 +0000 (15:45 +0200)]
Bug 5526 - Testing - Utils - Parser identifier
Unit tests for ParserIdentifier
+ added check if identifier does not contain multiple slashes
Change-Id: I1d4e446be60133cb5fa432a49fb88cb59f85702c
Signed-off-by: Ivan Hrasko <ivan.hrasko@pantheon.tech>
Ivan Hrasko [Mon, 9 May 2016 13:48:38 +0000 (15:48 +0200)]
Bug 5526 - Testing - Utils - Schema util
Unit tests for RestconfSchemaUtil
Change-Id: I375f9fe9c3845c63cee261ed37fbf3cd253e27e1
Signed-off-by: Ivan Hrasko <ivan.hrasko@pantheon.tech>
Michael Vorburger [Sun, 19 Jun 2016 16:03:51 +0000 (18:03 +0200)]
.gitignore .factorypath created by m2e-apt
https://github.com/vorburger/opendaylight-eclipse-setup now bundles
https://github.com/jbosstools/m2e-apt, which creates .factorypath files
all over the place.
Also .checkstyle created by Eclipse Checkstyle plugin.
Change-Id: Ibc9dc3d6a471f216d1e3a9adf76523e4061a0099
Signed-off-by: Michael Vorburger <vorburger@redhat.com>
adetalhouet [Mon, 21 Dec 2015 11:22:16 +0000 (12:22 +0100)]
Stop using blocking invoke for lock and editConfig.
Change-Id: I1ad68bb19c741f2f967dada37749e9ab9f2b2b87
Signed-off-by: adetalhouet <adetalhouet@inocybe.com>
Jakub Morvay [Thu, 19 May 2016 16:05:52 +0000 (18:05 +0200)]
Bug 5708 - Schemaless mount point notifications
Add support for notifications for schemaless mountpoints.
SchemalessMessageTransformer treats notification's payload as anyxml
node. To conform to API transformer wraps this payload in container node
with notification type as node identifier.
Change-Id: I4aceee416c8d630fe7689738b34fda3778d9f10f
Signed-off-by: Jakub Morvay <jmorvay@cisco.com>
Tomas Cere [Fri, 17 Jun 2016 14:09:27 +0000 (14:09 +0000)]
Merge "BUG 5634 : Implement concurrent message limit"
Ivan Hrasko [Tue, 17 May 2016 09:49:29 +0000 (11:49 +0200)]
Bug 5527: Unit testing - deserializer
Unit tests for YangInstanceIdentifierDeserializer
Change-Id: Ia09e2393fa0e29e31f8c116fe6db14b1736a96bb
Signed-off-by: Ivan Hrasko <ivan.hrasko@pantheon.tech>
Ryan Goulding [Thu, 16 Jun 2016 17:04:07 +0000 (13:04 -0400)]
Propagate reconnectOnSchemasChanged flag to ClusteredNetconfDevice
Currently, the "reconnectOnSchemasChanged" is not propagated to
ClusteredNetconfDevice. This change propagates the value so it
may be used in setting up the NetconfDevice.
Change-Id: If59d5a91cbb8cad4ab26640b8c474a82113ac5cf
Signed-off-by: Ryan Goulding <ryandgoulding@gmail.com>
Tomas Cere [Thu, 16 Jun 2016 13:51:45 +0000 (13:51 +0000)]
Merge "Remove unused isMaster variable in ClusteredNetconfDevice"
miroslav.kovac [Tue, 29 Mar 2016 14:44:08 +0000 (16:44 +0200)]
BUG 5634 : Implement concurrent message limit
This adds optional feature of limiting maximum concurrently sent rpc
requests. When we reach limit, next request will fail. Queue is freed
when reply message is received.
Change-Id: I5c49206ab929300ac973b12d5ccee58c70536c41
Signed-off-by: miroslav.kovac <miroslav.kovac@pantheon.tech>
Signed-off-by: Jakub Morvay <jmorvay@cisco.com>
Ivan Hrasko [Wed, 18 May 2016 09:05:35 +0000 (11:05 +0200)]
Bug 5527: Unit testing - serializer
Unit tests for YangInstanceIdentifierSerializer
Change-Id: Ife737bb38f43e7855a9b8657fa56bd49adf1be18
Signed-off-by: Ivan Hrasko <ivan.hrasko@pantheon.tech>
Ivan Hrasko [Wed, 18 May 2016 06:51:51 +0000 (08:51 +0200)]
Bug 5527: Unit testing - codec
Unit tests for IdentifierCodec mostly according to examples in restconf specification
Change-Id: Ifa1e8774a69b6f24521cc8a73b8df9720980b43f
Signed-off-by: Ivan Hrasko <ivan.hrasko@pantheon.tech>
Tony Tkacik [Wed, 15 Jun 2016 18:30:17 +0000 (18:30 +0000)]
Merge "BUG-865: Do not use QName.cachedReference()"
Tomas Cere [Wed, 15 Jun 2016 11:15:22 +0000 (11:15 +0000)]
Merge "Bug 5529 - Restconf M5 - Clean-up sonar issues"
Robert Varga [Tue, 14 Jun 2016 23:02:09 +0000 (01:02 +0200)]
BUG-865: Do not use QName.cachedReference()
QName.intern() is the modernized method. Also use it for all constants,
allowing greater reuse inside the JVM.
Also create NodeIdentifier and LeafNode constants for things that are
invariant, improving GC behavior.
Finally import YangInstanceIdentifer.{NodeIdentifier,PathArg} to make
the code more readable.
Change-Id: Id8587407dfbf8746a369fadb23102357082e7535
Signed-off-by: Robert Varga <rovarga@cisco.com>
Ivan Hrasko [Mon, 13 Jun 2016 13:09:35 +0000 (15:09 +0200)]
Bug 5529 - Restconf M5 - Clean-up sonar issues
Remove critical issues
Change-Id: Ie14934864976b5f9496af836a81293f052f4666d
Signed-off-by: Ivan Hrasko <ivan.hrasko@pantheon.tech>
Ivan Hrasko [Thu, 2 Jun 2016 14:14:27 +0000 (16:14 +0200)]
Bug 5911 - Restconf draft11 - bad parsing
- fix for leaf-list deserialization
- fix for YangInstanceIdentifier.EMPTY serialization and deserialization
(YangInstanceIdentifier.EMPTY is serialized to single slash and single
slash is deserialized to YangInstanceIdentifier.EMPTY)
- fix: parser recognizes all reserved characters according to rfc3986
- fix for list keys serialization
- fix for percent encoded characters decoding
- add check if leaf list instance value was supplied, error otherwise
- fix: module name before identifier is required only if node was not
defined in parents module
Change-Id: I48a944ed6139da5b7be0835cc99e219e11dc0072
Signed-off-by: Ivan Hrasko <ivan.hrasko@pantheon.tech>
Tomas Cere [Tue, 14 Jun 2016 08:41:19 +0000 (08:41 +0000)]
Merge "Bug 5708: Schemaless netconf mount point"
Jakub Morvay [Mon, 13 Jun 2016 08:30:50 +0000 (10:30 +0200)]
Improve logging in netconf test tool
This adds debug logs to TesttoolNegotiationFactory to help distinguish
cached operation service from newly created one. Also logs passed
parameters to netconf test tool.
Change-Id: I52dbc86a926724f97490ef2d939da22e71a3925a
Signed-off-by: Jakub Morvay <jmorvay@cisco.com>
Ryan Goulding [Mon, 13 Jun 2016 20:02:33 +0000 (16:02 -0400)]
Remove unused isMaster variable in ClusteredNetconfDevice
isMaster is never used, so it should be removed.
Change-Id: I5419d281062e9d25cf91e7a710cec06c609765e9
Signed-off-by: Ryan Goulding <ryandgoulding@gmail.com>
Tomas Cere [Mon, 13 Jun 2016 13:22:19 +0000 (13:22 +0000)]
Merge "Fix bug 5810, 5812: 1. only when node's config statement is true, such apis as GET/PUT/POST/DELETE config are added for this node; 2. when there are two or more top container/list nodes whose config statement is true in module, make sure that only one root post link is added for this module."
Tomas Cere [Mon, 13 Jun 2016 08:58:28 +0000 (08:58 +0000)]
Merge "Bug 5526 - Testing - Rest implementations - Streams"
Tomas Cere [Mon, 13 Jun 2016 08:51:37 +0000 (08:51 +0000)]
Merge changes from topic 'parser-post-removal'
* changes:
BUG-865: Remove reference to ExtendedType
BUG-865: remove references to obsolete types
Nafee Chan [Fri, 3 Jun 2016 01:21:37 +0000 (09:21 +0800)]
Fix bug 5810, 5812:
1. only when node's config statement is true, such apis as
GET/PUT/POST/DELETE config are added for this node;
2. when there are two or more top container/list nodes whose config
statement is true in module, make sure that only one root post link is added for this module.
Change-Id: I96d0b485c5943ad9bee63327c5d10e3cd0e5cb77
Signed-off-by: Nafee Chan <nafee.chan@gmail.com>
Ivan Hrasko [Mon, 9 May 2016 13:32:43 +0000 (15:32 +0200)]
Bug 5526 - Testing - Rest implementations - Streams
Unit tests for RestconfStreamsServiceImpl
Change-Id: I7c120cda262786b898e8918381747f98cb935329
Signed-off-by: Ivan Hrasko <ivan.hrasko@pantheon.tech>
Jakub Toth [Wed, 8 Jun 2016 07:54:27 +0000 (09:54 +0200)]
BUG-865: Remove reference to ExtendedType
ExtendedTypes are no longer generated by the parser
and the class has been deprecated. Remove references
to it so it can be removed.
Change-Id: Id74fd89b5a8dcd3489f4b0856716e39324a75cc9
Signed-off-by: Jakub Toth <jatoth@cisco.com>
Ivan Hrasko [Thu, 9 Jun 2016 07:51:59 +0000 (09:51 +0200)]
BUG-865: remove tests dependend on pre-Beryllium parser
Removed tests have had unclear logic and were removed.
Change-Id: I7410a6f3e7959f709947222636b75e8fcad66afe
Signed-off-by: Ivan Hrasko <ivan.hrasko@pantheon.tech>
Tomas Cere [Thu, 9 Jun 2016 11:12:55 +0000 (11:12 +0000)]
Merge "Bug 6023 - Add default address setting"
Jakub Toth [Wed, 8 Jun 2016 07:40:44 +0000 (09:40 +0200)]
BUG-865: remove references to obsolete types
TypeDefinition subclasses in model.util are deprecated.
Use their model.util.type equivalents available through BaseTypes.
Added one negative test into NnToXmlTest.
Change-Id: Id5bda10663b12e782a24731bc73d3e771ea242f1
Signed-off-by: Jakub Toth <jatoth@cisco.com>
Tomas Cere [Wed, 8 Jun 2016 16:52:10 +0000 (16:52 +0000)]
Merge "Bug 5527 - Testing - Provider"
Jakub Morvay [Tue, 7 Jun 2016 11:03:51 +0000 (13:03 +0200)]
Bug 6023 - Add default address setting
Adds default address and ssh private key path setting for config
subsystem netconf endpoint.
Change-Id: Id3169847a26f50e701aa5acfb592d9092abeeaf6
Signed-off-by: Jakub Morvay <jmorvay@cisco.com>
Ivan Hrasko [Mon, 9 May 2016 13:27:33 +0000 (15:27 +0200)]
Bug 5526 - Testing - Rest implementations - Schema
- unit tests for RestconfSchemaService
- small fix for found bug in validation
Change-Id: I37f14db187c27be4192f1fdbd7984bcbc5e927fd
Signed-off-by: Ivan Hrasko <ivan.hrasko@pantheon.tech>
Ivan Hrasko [Mon, 9 May 2016 09:23:20 +0000 (11:23 +0200)]
Bug 5527 - Testing - Provider
Unit tests for RestConnectorProvider
Change-Id: I97c592808a5e33b127b1de4b44b9b209d4353caf
Signed-off-by: Ivan Hrasko <ivan.hrasko@pantheon.tech>
Ivan Hrasko [Tue, 7 Jun 2016 07:13:55 +0000 (09:13 +0200)]
Fix of build breakage caused by changes in Yangtools
- use the RevisionSourceIdentifier implementation of SourceIdentifier
abstract class
Change-Id: I8ffceca436c1477a676e87f69e31ce7c4722c061
Signed-off-by: Ivan Hrasko <ivan.hrasko@pantheon.tech>
Tomas Cere [Mon, 6 Jun 2016 10:58:52 +0000 (12:58 +0200)]
BUG 4968: Clear transaction after proxy tx is submitted.
Change-Id: I2038a25cdd0ae17e6517a1f0ac375850a3c17479
Signed-off-by: Tomas Cere <tcere@cisco.com>
Tomas Cere [Fri, 3 Jun 2016 11:20:05 +0000 (13:20 +0200)]
Fix broken tree of modules in sonar analysis
Change-Id: Ie978c3696e814b6765d340736c5853c13e12bd02
Signed-off-by: Tomas Cere <tcere@cisco.com>
Jakub Morvay [Fri, 3 Jun 2016 07:37:14 +0000 (09:37 +0200)]
Fix XPath expression in NetconfMappingTest
Netconf replies constructed in config subsystem netconf endpoint now
contain correct namespaces when in DOM format. Fix XPath expression in
NetconfMappingTest to contain these namespaces.
See https://git.opendaylight.org/gerrit/#/c/39492/
Change-Id: I5ec33403059a9f0f046fda6f00122d52a0885ffa
Signed-off-by: Jakub Morvay <jmorvay@cisco.com>
Rashmi Pujar [Tue, 31 May 2016 19:05:49 +0000 (15:05 -0400)]
Netconf Karaf CLI code clean-up
- Fix show-device command argument checking
- Remove default values for strings to make Help look cleaner
- Check for null node to avoid NPE
Change-Id: I5376e76e252cbe3743410f84c8b20722a483e20d
Signed-off-by: Rashmi Pujar <rpujar@inocybe.com>
Tomas Cere [Tue, 31 May 2016 14:45:35 +0000 (14:45 +0000)]
Merge "Bug 5912 - Restconf draft11 - utils"
Tomas Cere [Mon, 30 May 2016 14:34:30 +0000 (16:34 +0200)]
Replace old yang parser usages in netconf.
Change-Id: Ice3cbfe4863f14f6c1f75df212c62d1e370c5297
Signed-off-by: Tomas Cere <tcere@cisco.com>
Maros Marsalek [Tue, 31 May 2016 11:14:11 +0000 (11:14 +0000)]
Merge "Add logger implementation to netconf-impl test scope"
Tomas Cere [Tue, 31 May 2016 10:56:27 +0000 (10:56 +0000)]
Merge "Add Karaf CLI for NETCONF CRUD commands"
Tomas Cere [Tue, 31 May 2016 10:52:29 +0000 (10:52 +0000)]
Merge "Bump ietf-yang-library module to newest draft"
Tomas Cere [Tue, 31 May 2016 10:33:21 +0000 (12:33 +0200)]
Add logger implementation to netconf-impl test scope
Also rethrow exceptions on failures in ConcurrentClientsTest to
make issues more apparent.
Change-Id: I3e907568c6a384f9512a81c05ae798e11972f607
Signed-off-by: Tomas Cere <tcere@cisco.com>
Tomas Cere [Tue, 31 May 2016 07:04:42 +0000 (07:04 +0000)]
Merge "Clean up a lot of JavaDoc etc. to conform to current Checkstyle rules"
Tomas Cere [Tue, 31 May 2016 07:01:05 +0000 (07:01 +0000)]
Merge "Name Logger field LOG instead of _logger and make it static (Checkstyle)"
Tomas Cere [Tue, 31 May 2016 06:58:36 +0000 (06:58 +0000)]
Merge "Log exception instead of using printStackTrace, and warn instead debug."
Michael Vorburger [Mon, 30 May 2016 17:41:35 +0000 (19:41 +0200)]
Clean up a lot of JavaDoc etc. to conform to current Checkstyle rules
Change-Id: I1b5613ad00633e6b59626dacca08f8c458f076f3
Signed-off-by: Michael Vorburger <vorburger@redhat.com>
Michael Vorburger [Mon, 30 May 2016 17:24:27 +0000 (19:24 +0200)]
Name Logger field LOG instead of _logger and make it static (Checkstyle)
Change-Id: If57f5b6dda95345f0ae3fe4584507aef1c3e0e08
Signed-off-by: Michael Vorburger <vorburger@redhat.com>
Michael Vorburger [Mon, 30 May 2016 13:03:17 +0000 (15:03 +0200)]
Log exception instead of using printStackTrace, and warn instead debug.
The formatting etc. changes are done automatically now (eclipse-setup).
Bug 5980 root cause does not actually show up in log with this, but
still seems like a good idea.
Bug: 5980
Change-Id: Ib07f029b5350928e3f0d3c70bcc9dbc9cc3a318d
Signed-off-by: Michael Vorburger <vorburger@redhat.com>
Jakub Toth [Mon, 30 May 2016 16:10:08 +0000 (18:10 +0200)]
Replace old yang parser usages in restconf
Change-Id: Ib82a0577592f2e443120aea16bdfa329eba4c43b
Signed-off-by: Jakub Toth <jatoth@cisco.com>
Jakub Morvay [Mon, 30 May 2016 11:03:51 +0000 (13:03 +0200)]
Bump ietf-yang-library module to newest draft
Bump ietf-yang-library yang module to confrom to
draft-ietf-netconf-yang-library-06 described in
https://tools.ietf.org/html/draft-ietf-netconf-yang-library-06
Change-Id: I765d14f1401f06aec33fe08299cc6df1413df0b4
Signed-off-by: Jakub Morvay <jmorvay@cisco.com>
Ivan Hrasko [Tue, 24 May 2016 15:19:24 +0000 (17:19 +0200)]
Bug 5912 - Restconf draft11 - utils
Fixing bugs of Draft11 implementation found by unit tests
in RestconfSchemaServiceTest:
- wrong condition
in ParserIdentifier#toSchemaExportContextFromIdentifier
- slash at the end of mount point identifier
in ParserIdentifier#toInstanceIdentifier
- wrong condition at the end of the input
in YangInstanceIdentifierDeserializer#create
- module names validation
Change-Id: Ib4031fd6d2830a49845191d1792e695a19d04e93
Signed-off-by: Ivan Hrasko <ivan.hrasko@pantheon.tech>
Andrej Mak [Mon, 2 May 2016 14:37:29 +0000 (16:37 +0200)]
Bug 5708: Schemaless netconf mount point
Schemaless mount point can be used to connect to devices
which doesn't provide their schemas. In that case,
both rpc input and output must be of anyxml type.
Data broker and transactions works with anyxml too. Read transaction path
Yang instance identifier is transformed to xml filter structure
used in get-config rpc. Resulting data are selected from rpc-reply
according to path, wrapped in data element(to be able to return lists)
and returned as anyxml. Write transaction path is transformed to
xml structure. Data are appended to the last element of this structure.
This is done by SchemalessRpcStructureTransformer. It is strategy
used in NetconfBaseOps class. For standard mount points
NetconfRpcStructureTransformer is used.
Change-Id: I38c70fc6b676941ef6d731a52a6b12ae7c10eec6
Signed-off-by: Andrej Mak <andmak@cisco.com>
Signed-off-by: Jakub Morvay <jmorvay@cisco.com>
Robert Varga [Wed, 25 May 2016 12:56:22 +0000 (14:56 +0200)]
Improve SAXTransformerFactory instantiation
This is just a correctness fix to follow the API contract.
Change-Id: Ia69b5b0d8d6b1ed8165cdeabbb4ff4278b9bfa12
Signed-off-by: Robert Varga <rovarga@cisco.com>
Tomas Cere [Tue, 24 May 2016 12:07:39 +0000 (12:07 +0000)]
Merge "Bug 5526 - Testing - Utils - Validation"
Dhevendran [Thu, 19 May 2016 04:56:01 +0000 (10:26 +0530)]
Fix for the Bug 3880 - inconsistent code fragments in netconf
Change-Id: If9094546b18c11cf1c2755253bc33be1c5a12907
Signed-off-by: Dhevendran <dhevendran.k@tcs.com>
Jakub Toth [Mon, 23 May 2016 12:59:05 +0000 (14:59 +0200)]
HOTFIX - Fix upgrade of jackson in ODL parent
Change-Id: Ic2efcb0b825b9bf82899863e8bfe282c30b9369c
Signed-off-by: Jakub Toth <jatoth@cisco.com>