netconf.git
5 years agoUse mockito ArgumentMatchers in protocol-framework 15/77615/1
Jakub Morvay [Thu, 8 Nov 2018 11:34:10 +0000 (12:34 +0100)]
Use mockito ArgumentMatchers in protocol-framework

org.mockito.Matchers class is deprecated so use
org.mockito.ArgumentMatchers class instead in protocol-framework
ServerTest.

Change-Id: Ia7e2d0daf40bb8ef1f3b616638e1a91f0c3ba30a
Signed-off-by: Jakub Morvay <jmorvay@frinx.io>
5 years agoMigrate sal-rest-docgen to MD-SAL APIs 85/77485/8
Robert Varga [Sun, 4 Nov 2018 23:59:58 +0000 (00:59 +0100)]
Migrate sal-rest-docgen to MD-SAL APIs

This performs a straight-forward migration of sal-rest-docgen.

Change-Id: I18dd4382e16b0716b8551ead1cf15abb9dc14eca
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
5 years agoMigrate from JSONCodecFactory.getShared() 28/77528/1
Robert Varga [Tue, 6 Nov 2018 09:30:18 +0000 (10:30 +0100)]
Migrate from JSONCodecFactory.getShared()

This method is deprecated, move to using its replacement.

Change-Id: I8dd4a8ed31d43dacd3bfc9dc0fe9ac7581333384
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
5 years agoSimplify MultivaluedHashMap.getFirst() 26/77526/3
Robert Varga [Tue, 6 Nov 2018 08:36:29 +0000 (09:36 +0100)]
Simplify MultivaluedHashMap.getFirst()

Rather than using an if/else block, use a trigraph, fixing a minor
eclipse warning about an unnecessary 'else'.

Change-Id: I8cc0d6d5bb4ac51fb2672e5aa047030919a47202
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
5 years agoSimplify MultivaluedHashMap.addAll(Object, Object...) 25/77525/3
Robert Varga [Tue, 6 Nov 2018 08:33:15 +0000 (09:33 +0100)]
Simplify MultivaluedHashMap.addAll(Object, Object...)

This method is a copy of addAll(Object, List) and it induces
a varargs warnings. Make it final, annotate it with @SafeVarArgs
and use Arrays.asList() to forward to addAll(Object, List).

This saves some code and fixes the warning.

Change-Id: I5d4ab405de168d54a0b941afdb28d13d6ed7dcef
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
5 years agoDo not allocate a short-lived ByteBuf 24/77524/3
Robert Varga [Tue, 6 Nov 2018 08:21:26 +0000 (09:21 +0100)]
Do not allocate a short-lived ByteBuf

ByteBuf.writeCharSequence() allows us to bypass manual buffer
management, use that.

Change-Id: I85dc57a8411a057843ec45b5b70fea8907ae9bed
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
5 years agoDo not hard-code OK status code 23/77523/3
Robert Varga [Tue, 6 Nov 2018 08:18:19 +0000 (09:18 +0100)]
Do not hard-code OK status code

HttpStatusResponse.OK gives us everything we need, simplify
response handling using its equals() method.

Change-Id: I16cb7bc0a6e6e8a8ac10a046538566e32019a59c
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
5 years agoMigrate use of deprecated netty API elements 22/77522/3
Robert Varga [Tue, 6 Nov 2018 08:11:42 +0000 (09:11 +0100)]
Migrate use of deprecated netty API elements

Straightforward change to use recommended equivalents.

Change-Id: I092eb6f0a2c745b5b39cde3f35ab21f612a62215
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
5 years agoRemove use of commons-lang3 in restconf-nb-rfc8040 97/77497/1
Robert Varga [Mon, 5 Nov 2018 09:42:21 +0000 (10:42 +0100)]
Remove use of commons-lang3 in restconf-nb-rfc8040

ODL uses its own Builder concept, use that instead of pulling
in commons-lang3.

Change-Id: I27ab400ddc67f8535a651c8c0018846ac04be45f
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
5 years agoReduce of CheckedFuture in RestconfImpl 84/77484/1
Robert Varga [Sun, 4 Nov 2018 23:56:16 +0000 (00:56 +0100)]
Reduce of CheckedFuture in RestconfImpl

RPC invocation is not using checkedGet(), hence a plain
ListenableFuture is okay. This reduces the number of warnings
and prepares us for migration to MD-SAL.

Change-Id: I9b3f739c070b14d70af61536ada88d0fc2a5ba24
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
5 years agoMerge "Get rid of odl-netconf-connector-ssh feature"
Jakub Morvay [Wed, 31 Oct 2018 11:08:25 +0000 (11:08 +0000)]
Merge "Get rid of odl-netconf-connector-ssh feature"

5 years agoGet rid of odl-netconf-connector-ssh feature 80/77280/4
Jakub Morvay [Thu, 25 Oct 2018 17:40:16 +0000 (19:40 +0200)]
Get rid of odl-netconf-connector-ssh feature

The feature is historically linked with config-subsystem northbound
endpoint and loopback connection to this endpoint. It has been
deprecated for a while and now it just wraps odl-netconf-topology
feature.

Delete this feature as it does not provide any added value over
using odl-netconf-topology feature directly.

Change-Id: Iaabe2fc4dc2be797531fb2898f2042c38a077c76
Signed-off-by: Jakub Morvay <jmorvay@frinx.io>
5 years agoMerge "Add subscribeToStream to JSONRestConfService"
Tom Pantelis [Tue, 30 Oct 2018 12:47:36 +0000 (12:47 +0000)]
Merge "Add subscribeToStream to JSONRestConfService"

5 years agoMerge "Fix mounting logic in clustered topology"
Jakub Morvay [Mon, 29 Oct 2018 10:06:25 +0000 (10:06 +0000)]
Merge "Fix mounting logic in clustered topology"

5 years agoMerge "Upgrade xercesImpl"
Jakub Morvay [Mon, 29 Oct 2018 08:05:37 +0000 (08:05 +0000)]
Merge "Upgrade xercesImpl"

5 years agoAdd subscribeToStream to JSONRestConfService 10/77310/3
Josh [Sun, 28 Oct 2018 12:34:50 +0000 (14:34 +0200)]
Add subscribeToStream to JSONRestConfService

The idea here is to allow applications to
pre-register websocket listeners.

Change-Id: Ic7e55f19251e0b139256435ad215b44a596b84d9
Signed-off-by: Josh <jhershbe@redhat.com>
5 years agoRemove test dependency on xerces 95/77295/1
Robert Varga [Fri, 26 Oct 2018 09:25:05 +0000 (11:25 +0200)]
Remove test dependency on xerces

The test is mucking into a concrete implementation, use normal
API method to acquire the value for assertion.

Change-Id: I32699f6e37f922ca43d1791d0fa2604dd0aa9412
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
5 years agoFix mounting logic in clustered topology 53/77153/7
Jakub Morvay [Thu, 25 Oct 2018 17:28:58 +0000 (19:28 +0200)]
Fix mounting logic in clustered topology

https://git.opendaylight.org/gerrit/#/c/75655/ prepared netconf
southbound plugin to support action statements, but it missed to adjust
clustered netconf topology MasterSalFacade to the changes.

Fix that.

JIRA: NETCONF-575
Change-Id: I0b2fa9258cf362d1227f62127c2c3b44126677f3
Signed-off-by: Jakub Morvay <jmorvay@frinx.io>
5 years agoUpgrade xercesImpl 65/77265/1
Robert Varga [Wed, 24 Oct 2018 18:06:25 +0000 (20:06 +0200)]
Upgrade xercesImpl

exificient is pulling in an old xerces implementation, let's
override it so we do not lug around five-year old buggy code.

Change-Id: I317c8d9e09914fa19007c635f111e28dd123575e
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
5 years agoIntegrate MRI projects for Neon 66/74966/53
Robert Varga [Thu, 9 Aug 2018 10:07:50 +0000 (12:07 +0200)]
Integrate MRI projects for Neon

This patch bumps:
- odlparent to 4.0.2
- yangtools to 2.1.2
- mdsal to 3.0.1

It deals with the fallout in following ways:
- xmlunit -> xmlunit-legacy
- fix unstubbed methods
- migrate to java.util.Optional where needed
- update test data to account for automatic list removal
- update to sshd-2.0.0
- account for ietf-{inet,yang}-types moving
- remove explicit null in blueprint
- use isNull() instead of any(Class<T>) where we want to match null
- prevent UnnecessaryStubbingException in TestRestconfUtils class
- remove jersey-related version overrides
- reuse NoOpListenerRegistration

JIRA: NETCONF-555
JIRA: NETCONF-564
Change-Id: Ib2b6bc8cfe868f1c268b243052429e6a10cfb5e8
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
Signed-off-by: Jakub Morvay <jmorvay@frinx.io>
5 years agoRelease the buffer only after we are done with it 84/77084/1
Robert Varga [Thu, 18 Oct 2018 15:25:55 +0000 (17:25 +0200)]
Release the buffer only after we are done with it

We may end up touching the buffer after we have release()'d it,
which means it may have been recycled by the time we call
resetReaderIndex().

Move the release() call to after the check so we do not end up
releasing it prematurely.

Change-Id: I43156dbe2e6c53a552a322e7b5ea27f8da3873c2
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
5 years agoReuse AbstractListenerRegistration 34/76734/1
Robert Varga [Mon, 8 Oct 2018 09:32:51 +0000 (11:32 +0200)]
Reuse AbstractListenerRegistration

Instead of brewing our own, non-idempotent implementation of
ListenerRegistration use AbstractListenerRegistration which takes
care of being idempotent and holding the listener instance.

Change-Id: I1525f5011c455a0f170d492f164cdeb3b7290b9b
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
5 years agoMerge "Remove use of ThreadPools in sal-netconf-connector"
Jakub Morvay [Mon, 1 Oct 2018 22:14:57 +0000 (22:14 +0000)]
Merge "Remove use of ThreadPools in sal-netconf-connector"

5 years agoMerge changes I629c0bbd,Ia47c3163
Jakub Morvay [Mon, 1 Oct 2018 22:01:18 +0000 (22:01 +0000)]
Merge changes I629c0bbd,Ia47c3163

* changes:
  Use a dedicated no-op listener class
  Do not retain the list of RPCs

5 years agoMerge "Fix AbstractCommonSubscriber close method"
Jakub Morvay [Mon, 1 Oct 2018 21:10:26 +0000 (21:10 +0000)]
Merge "Fix AbstractCommonSubscriber close method"

5 years agoRemove use of ThreadPools in sal-netconf-connector 36/76536/4
Robert Varga [Mon, 1 Oct 2018 16:20:15 +0000 (18:20 +0200)]
Remove use of ThreadPools in sal-netconf-connector

We really just need a {Listening,Scheduled}ExecutorService, nothing
else. Propagating this outwords from NetconfDevice(Builder), eliminates
the need for per-session ListeningDecorator and proxies, saving us
at least 56 bytes for each connected device.

Change-Id: Ide69bd1a8f36eca1473313e3fd2cafb76d754464
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
5 years agoUse a dedicated no-op listener class 38/76538/3
Robert Varga [Mon, 1 Oct 2018 16:50:17 +0000 (18:50 +0200)]
Use a dedicated no-op listener class

This saves a few bytes per session by not retaining anything
but the listener implementation.

Change-Id: I629c0bbd686ec734f36d8e8d307df3f1f733fa1c
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
5 years agoDo not retain the list of RPCs 37/76537/3
Robert Varga [Mon, 1 Oct 2018 16:45:43 +0000 (18:45 +0200)]
Do not retain the list of RPCs

These RPCs are only used when a listener registers, there is simply
no point to retain them in a transformed collection. We can always
re-create them as needed from the SchemaContext.

Change-Id: Ia47c3163bff5232d079f8768420bfa6360fe3b49
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
5 years agoFix AbstractCommonSubscriber close method 41/76541/2
Jakub Morvay [Mon, 1 Oct 2018 18:10:29 +0000 (20:10 +0200)]
Fix AbstractCommonSubscriber close method

Check for null registration before trying to close it.

JIRA: NETCONF-565
Change-Id: I23861ce7c1857c00334ca40fac91389200368fed
Signed-off-by: Jakub Morvay <jmorvay@frinx.io>
5 years agoCleanup SimulatedCreateSubscription 35/76535/1
Robert Varga [Thu, 27 Sep 2018 12:04:11 +0000 (14:04 +0200)]
Cleanup SimulatedCreateSubscription

Using .get().get() twice is ugly, create a local variable.

Change-Id: I0c18c9138146c349c4c1c4003b5c53439893354e
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
(cherry picked from commit a4ac79f5adaceb503100ba3bb0a45edf7e2cc363)

5 years agoMerge "Fix config-only thinko"
Tom Pantelis [Wed, 26 Sep 2018 11:59:39 +0000 (11:59 +0000)]
Merge "Fix config-only thinko"

5 years agoMerge "Allow SshProxyServer to share AsynchronousChannelGroup"
Jakub Morvay [Wed, 26 Sep 2018 11:54:56 +0000 (11:54 +0000)]
Merge "Allow SshProxyServer to share AsynchronousChannelGroup"

5 years agoHonor EXI flag in testtool 54/76454/1
Robert Varga [Wed, 26 Sep 2018 09:47:19 +0000 (11:47 +0200)]
Honor EXI flag in testtool

NETCONF test tool should honor the exi flag and translate it to
proper capabilities.

Change-Id: I50acf9188eb5fd2aea60d593dfd9713e54badda4
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
5 years agoAllow SshProxyServer to share AsynchronousChannelGroup 52/76452/1
Robert Varga [Tue, 25 Sep 2018 17:51:33 +0000 (19:51 +0200)]
Allow SshProxyServer to share AsynchronousChannelGroup

For testing purposes it is good to have the ability to share a single
thread group, as ach of them implies a dedicated thread. This patch
exposes an alternative constructor and allows multiple SshProxyServers
to share that group -- lowering resources needed significantly, both
in terms of threads, memory and file descriptors used.

Change-Id: I237ab0790e9a70c26288a116c59f5a541f236a74
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
5 years agoFix config-only thinko 43/76443/1
Robert Varga [Tue, 25 Sep 2018 13:07:24 +0000 (15:07 +0200)]
Fix config-only thinko

This fixes JSON template thinko, so that the variable matches
XML.

Change-Id: Ief03b46dc61a0be733a4f139837d19c8c981da7f
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
(cherry picked from commit 015197b0642caa75fc2403a6268a700ca3279dc8)

5 years agoMerge "NETCONF-553 : Stack traces need to suppressed and error messages should be...
Jakub Morvay [Mon, 24 Sep 2018 13:51:29 +0000 (13:51 +0000)]
Merge "NETCONF-553 : Stack traces need to suppressed and error messages should be propagated for mounted devices"

5 years agoNETCONF-553 : Stack traces need to suppressed and error messages should 97/75597/2
Balaji Varadaraju [Thu, 30 Aug 2018 23:23:35 +0000 (18:23 -0500)]
NETCONF-553 : Stack traces need to suppressed and error messages should
be propagated for mounted devices

Traversed entire error info to capture all error messages returned by the
NETCONF device. Also suppressed the stack traces in the RESTCONF output.

Change-Id: I9afc5948a9b48c12e649b9960d011870a4d9ee73
Signed-off-by: Balaji Varadaraju <bvaradar@luminanetworks.com>
Signed-off-by: Jakub Morvay <jmorvay@frinx.io>
5 years agoMerge "Cleanup NetconfRemoteSchemaYangSourceProvider"
Jakub Morvay [Sun, 23 Sep 2018 13:38:46 +0000 (13:38 +0000)]
Merge "Cleanup NetconfRemoteSchemaYangSourceProvider"

5 years agoCleanup NetconfRemoteSchemaYangSourceProvider 46/76346/5
Robert Varga [Fri, 21 Sep 2018 12:15:53 +0000 (14:15 +0200)]
Cleanup NetconfRemoteSchemaYangSourceProvider

Use Java 8 constructs instead of Guava where needed, cleanup source
code formatting and turn an internal class into a simple(r) lambda.

Change-Id: Ie79188f18186bd0afa2cfb5ab781e25123ed1549
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
Signed-off-by: Jakub Morvay <jmorvay@frinx.io>
5 years agoMerge "Remove use of deprecated Guava methods from testtool"
Jakub Morvay [Sat, 22 Sep 2018 18:09:41 +0000 (18:09 +0000)]
Merge "Remove use of deprecated Guava methods from testtool"

5 years agoRemove use of deprecated Guava methods from testtool 48/76348/1
Robert Varga [Fri, 21 Sep 2018 14:26:13 +0000 (16:26 +0200)]
Remove use of deprecated Guava methods from testtool

Files.read() and Files.write() are scheduled for removal,
use their replacements.

Change-Id: Ic4b49611c6371c39a194b1f248b298e04e5d0c76
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
5 years agoSpeed up YangLibrarySchemaYangSourceProvider 43/76343/1
Robert Varga [Fri, 21 Sep 2018 12:04:07 +0000 (14:04 +0200)]
Speed up YangLibrarySchemaYangSourceProvider

We can potentially have a lot of schemas for a mount point, hence
we should be using an immutable map. Also do not use Map.contains()
before issuing a Map.get(), saving one lookup.

Change-Id: Ic80d2299fa5e67afcbb1578db5e43f999b1a96e5
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
5 years agoCache SchemaPath for well-known netconf operations 42/76342/1
Robert Varga [Fri, 21 Sep 2018 11:48:25 +0000 (13:48 +0200)]
Cache SchemaPath for well-known netconf operations

Rather than invoking toPath(QName) on each invocation, allocate
a SchemaPath constant for common operations and reuse it across
invocations.

Change-Id: Iefd0b24ec3dd900ddfe54dc4f89baffa1eec91a1
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
5 years agoMigrate netconf docs to project repo 88/76188/2
Thanh Ha [Mon, 17 Sep 2018 16:41:56 +0000 (12:41 -0400)]
Migrate netconf docs to project repo

Issue: DOCS-69
Change-Id: I2941d5aa1ea90ee99c9ffe9269b118ea70648fcb
Signed-off-by: Thanh Ha <thanh.ha@linuxfoundation.org>
5 years agoBootstrap netconf documentation 87/76187/2
Thanh Ha [Mon, 17 Sep 2018 16:38:37 +0000 (12:38 -0400)]
Bootstrap netconf documentation

Issue: DOCS-69
Change-Id: I131c540aca45c6ad742565193801204227554d43
Signed-off-by: Thanh Ha <thanh.ha@linuxfoundation.org>
5 years agoFix missing support of actions in KeepaliveSalFacade 14/75814/1
Jakub Tóth [Thu, 6 Sep 2018 09:23:38 +0000 (11:23 +0200)]
Fix missing support of actions in KeepaliveSalFacade

Change-Id: I1696a92d699debbd5d97219769f9beabc6ef8624
Signed-off-by: Jakub Tóth <jakub.toth@pantheon.tech>
(cherry picked from commit 332280c42305db34b1b1ca0b59f59964cb5e305f)

5 years agoDo not instantiate NormalizedNodes for filter 13/75513/8
Robert Varga [Mon, 27 Aug 2018 10:43:27 +0000 (12:43 +0200)]
Do not instantiate NormalizedNodes for filter

Using ImmutableNodes.fromInstanceId() does not work for leaf nodes,
as we do not have a value, which violates LeafNode contract -- leading
to an IllegalStateException when a user attempts to read() a single
leaf via a transaction.

As it turns out, this is completely unnecessary, as all we are doing
is iterating through the temporary NormalizedNode and creating
NormalizedNodeStreamWriter events based on that.

This patch replicates ImmutableNodes.fromInstanceId() logic, but
simplifies it for this particular task, short-cutting NormalizedNode
creation and emitting events directly as we are iterating over
the YangInstanceIdentifier.

JIRA: NETCONF-563
Change-Id: I0781e81d812ee979deaafb9dfa811e143866f4af
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
5 years agoDo not allocate an AtomicBoolean 86/75486/1
Robert Varga [Sun, 26 Aug 2018 20:14:00 +0000 (22:14 +0200)]
Do not allocate an AtomicBoolean

This is costing us an object and therefore a potential cache miss.
We can do better with an explicit AtomicFieldUpdater, saving 16-28
bytes per instance.

Change-Id: Ie5680fed2d6c20487d475621978cf455c492229b
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
5 years agoOptimize sal-netconf-connector translation 74/75474/3
Robert Varga [Fri, 24 Aug 2018 15:29:05 +0000 (17:29 +0200)]
Optimize sal-netconf-connector translation

Use pre-computed filter type and notably NodeIdentifiers rather than
creating them from QName constants.

Change-Id: I388594484c09757b6f66f5f9e5120359658b02ca
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
5 years agoAbstractEdit: improve error message on missing schema node 66/75366/1
Marek Gradzki [Tue, 21 Aug 2018 13:47:45 +0000 (15:47 +0200)]
AbstractEdit: improve error message on missing schema node

Include node name in the error message.

Change-Id: Ife8f95cb333e2e1065c2c27d51acb406710cc375
Signed-off-by: Marek Gradzki <mgradzki@cisco.com>
5 years agoMerge "Add the ability to use schema-aware coding"
Jakub Morvay [Tue, 21 Aug 2018 09:15:53 +0000 (09:15 +0000)]
Merge "Add the ability to use schema-aware coding"

5 years agoMerge "NETCONF-557: Add support for URL capability"
Jakub Morvay [Tue, 21 Aug 2018 09:15:07 +0000 (09:15 +0000)]
Merge "NETCONF-557: Add support for URL capability"

5 years agoAdd the ability to use schema-aware coding 36/35136/26
Robert Varga [Wed, 17 Jan 2018 18:43:52 +0000 (19:43 +0100)]
Add the ability to use schema-aware coding

With the switch to Exificient we can actually use schema-informed
encoding -- add basic support for that.

Change-Id: If24a418302d151114407ee647ec5e12c3d3b3e76
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
5 years agoReturn Set instead of Iterable in test setup 35/75335/1
Robert Varga [Mon, 20 Aug 2018 17:20:30 +0000 (19:20 +0200)]
Return Set instead of Iterable in test setup

This allows us to define equality in superclass, hence return
proper Set.

Change-Id: I48c37054440e5983e5033a0ed927080a7d255e72
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
5 years agoFix argument strings 23/75323/9
Robert Varga [Mon, 20 Aug 2018 10:29:30 +0000 (12:29 +0200)]
Fix argument strings

When logging an exception we should not have an explicit placeholder
and also we should properly constify arguments. This is pointed out
by updated findbugs.

Change-Id: I71a0b23b5510a36bfe9808dfe92c27717e24fbb3
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
5 years agoFix checkstyle violations 22/75322/1
Robert Varga [Mon, 20 Aug 2018 10:45:14 +0000 (12:45 +0200)]
Fix checkstyle violations

Updated checkstyle is better at catching violations, fix them up
before upgrading.

Change-Id: I6a2e6f262dabbb753f905f12c1f2161c409a94ed
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
5 years agoNETCONF-557: Add support for URL capability 17/75317/1
Marek Gradzki [Thu, 9 Aug 2018 11:45:54 +0000 (13:45 +0200)]
NETCONF-557: Add support for URL capability

This patch brings support of URL capability
in <edit-config> and <copy-config> RPCs
to mdsal-netconf-connector.

Remote config upload is not supported.
Remote to remote operations are not supported.

The capability is advertised as:

urn:ietf:params:netconf:capability:url:1.0?scheme=file

but config download is also supported via http and https.

Change-Id: Idb5bae4e24ff2a098bc60bf24c36fb40113fd8f5
Signed-off-by: Marek Gradzki <mgradzki@cisco.com>
5 years agoPrepare netconf to support YANG 1.1 actions 45/74745/17
Jakub Tóth [Mon, 6 Aug 2018 14:11:29 +0000 (16:11 +0200)]
Prepare netconf to support YANG 1.1 actions

This allows implementation of a factory for creating of DOMActionService
of a connected device. This service is going to be part of services provided
by the device's mountpoint.

Change-Id: I1c79b4bc8f1b1c63f7ffb2306f07ea9872f15882
Signed-off-by: Jakub Tóth <jakub.toth@pantheon.tech>
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
5 years agoBump argparse4j to 0.8.1 35/75135/2
Robert Varga [Sat, 11 Aug 2018 12:53:26 +0000 (14:53 +0200)]
Bump argparse4j to 0.8.1

Major bump.

Change-Id: Ife645b9d0ec6aa07d24eb02bfe604ed87cb1c17e
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
5 years agoBump async-http-client to 1.9.40 34/75134/2
Robert Varga [Sat, 11 Aug 2018 12:47:32 +0000 (14:47 +0200)]
Bump async-http-client to 1.9.40

Minor bump

Change-Id: I6f711a040efca3d01d3f4395e57ba6e77652fa80
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
5 years agoRemove references to mdsal-model-artifacts 23/75123/1
Robert Varga [Sat, 11 Aug 2018 07:40:14 +0000 (09:40 +0200)]
Remove references to mdsal-model-artifacts

This artifact is going away, migrate to mdsal-artifacts.

Change-Id: Ia36440d8428418e94fa9d79dd0a1a7ed2035b5d8
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
5 years agoBump versions by x.(y+1).z for next dev cycle 95/74995/1
Anil Belur [Thu, 9 Aug 2018 12:40:15 +0000 (18:10 +0530)]
Bump versions by x.(y+1).z for next dev cycle

Change-Id: I2b6cfd51fe110a8a04b45a6c3101cc30d98c0245
Signed-off-by: Anil Belur <abelur@linuxfoundation.org>
5 years agoBump yangtools to 2.0.10 81/74881/1
Robert Varga [Mon, 6 Aug 2018 15:45:12 +0000 (17:45 +0200)]
Bump yangtools to 2.0.10

This fixes an issue with actions, hence we need it in Fluorine.

Change-Id: Ic6b2c3e7f118512f04bce3d223b480e2ab784098
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
5 years agoMerge "NECONF-524 : Setting the netconf keepalive logic to be more proactive."
Jakub Morvay [Mon, 6 Aug 2018 14:50:23 +0000 (14:50 +0000)]
Merge "NECONF-524 : Setting the netconf keepalive logic to be more proactive."

5 years agoMerge "Improve error message on <validate> failure"
Jakub Morvay [Mon, 6 Aug 2018 08:01:19 +0000 (08:01 +0000)]
Merge "Improve error message on <validate> failure"

5 years agoUse Controller's MappingCheckedFuture 28/74828/3
Robert Varga [Sat, 4 Aug 2018 01:14:22 +0000 (03:14 +0200)]
Use Controller's MappingCheckedFuture

This class is being moved from mdsal to controller, adjust for that.

Change-Id: I0b680405789a8bc230cfac54f8cf23ecde768494
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
5 years agoBump exificient to 1.0.1 20/74820/6
Robert Varga [Fri, 3 Aug 2018 22:35:19 +0000 (00:35 +0200)]
Bump exificient to 1.0.1

https://github.com/EXIficient/exificient/compare/exificient-0.9.7...exificient-1.0.0
https://github.com/EXIficient/exificient/compare/exificient-1.0.0...exificient-1.0.1
https://github.com/EXIficient/exificient-core/compare/exificient-core-0.9.7...exificient-core-1.0.0
https://github.com/EXIficient/exificient-core/compare/exificient-core-1.0.0...exificient-core-1.0.1

Change-Id: Id811993f3232f6e96dd4c3c4da95c86db9038c24
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
5 years agoRemove unneeded version declaration 19/74819/1
Robert Varga [Fri, 3 Aug 2018 22:34:02 +0000 (00:34 +0200)]
Remove unneeded version declaration

We are getting aaa versions from dependencyManagement, do not repeat
them again.

Change-Id: I860d63075e5fb004518c1c5955cb96d88f24cc55
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
5 years agoImprove error message on <validate> failure 96/74796/2
Marek Gradzki [Fri, 3 Aug 2018 12:28:56 +0000 (14:28 +0200)]
Improve error message on <validate> failure

Change-Id: I1af1c918c0a21645380ce3ce55c608729365f140
Signed-off-by: Marek Gradzki <mgradzki@cisco.com>
5 years agoBump yangtools to 2.0.9 74/74574/2
Robert Varga [Fri, 27 Jul 2018 12:09:39 +0000 (14:09 +0200)]
Bump yangtools to 2.0.9

This patch bumps yangtools to latest release.

Change-Id: I9b170a51f632a9ef059cdfd3a434c909d46d1cb2
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
5 years agoNETCONF-551 : Invalid CSS URI in apidocs explorer 90/74590/1
Richard Kosegi [Fri, 27 Jul 2018 16:02:27 +0000 (18:02 +0200)]
NETCONF-551 : Invalid CSS URI in apidocs explorer

Change-Id: Iaabea829d3fa03be019075045ee86bdd233ed066
Signed-off-by: Richard Kosegi <richard.kosegi@gmail.com>
5 years agoMerge "Simplify code using Java 8 features"
Jakub Morvay [Fri, 27 Jul 2018 14:27:16 +0000 (14:27 +0000)]
Merge "Simplify code using Java 8 features"

5 years agoSimplify code using Java 8 features 86/74486/3
Stephen Kitt [Thu, 26 Jul 2018 08:35:02 +0000 (10:35 +0200)]
Simplify code using Java 8 features

* method references
* lambda expressions
* Map::computeIfAbsent

Change-Id: Icbfa5c0a76b5b6f2b4339dbbd49b8a44e7b14fb2
Signed-off-by: Stephen Kitt <skitt@redhat.com>
5 years agoBump to odlparent 3.1.3 00/74200/2
Stephen Kitt [Wed, 18 Jul 2018 16:06:41 +0000 (18:06 +0200)]
Bump to odlparent 3.1.3

Change-Id: I8e2d3a5dd33195daaf2884e2093a5720fd31a7f1
Signed-off-by: Stephen Kitt <skitt@redhat.com>
5 years agoMerge "Remove unused exceptions"
Jakub Morvay [Wed, 25 Jul 2018 10:35:45 +0000 (10:35 +0000)]
Merge "Remove unused exceptions"

5 years agoMerge "Remove netconf-it"
Jakub Morvay [Wed, 25 Jul 2018 10:35:34 +0000 (10:35 +0000)]
Merge "Remove netconf-it"

5 years agoMerge "Use moved BindingReflections"
Tom Pantelis [Tue, 24 Jul 2018 17:01:12 +0000 (17:01 +0000)]
Merge "Use moved BindingReflections"

5 years agoRemove netconf-it 09/74409/1
Robert Varga [Tue, 24 Jul 2018 16:43:12 +0000 (18:43 +0200)]
Remove netconf-it

This does not build and we are not using it. Remove it.

Change-Id: I2827d1b430036d2c41f44827cba0b66b0ad3ba7b
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
5 years agoRemove unused exceptions 96/74396/3
Stephen Kitt [Tue, 24 Jul 2018 13:10:43 +0000 (15:10 +0200)]
Remove unused exceptions

This drops exception declarations which are never used. If nothing
else, it allows simplifying declarations in upstream projects too.

Change-Id: I692a50ebb43e76c15a3a57ad88138be53184ce7b
Signed-off-by: Stephen Kitt <skitt@redhat.com>
5 years agoUse moved BindingReflections 87/74387/1
Robert Varga [Tue, 24 Jul 2018 11:10:07 +0000 (13:10 +0200)]
Use moved BindingReflections

BindingReflections are being evacuated from yang-binding, use them
from their new location.

Change-Id: Icb0a53635dee002f14ed9ddfe779fde198db8fc8
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
5 years agoUse minimal ietf-topology 21/74221/2
Robert Varga [Thu, 19 Jul 2018 08:33:02 +0000 (10:33 +0200)]
Use minimal ietf-topology

We do not need the examples, just the baseline topology.

Change-Id: I7f19c8fc5a6b20d2b8cc7c659edf4dea305756da
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
5 years agoUse union's stringValue() 12/74212/4
Robert Varga [Wed, 18 Jul 2018 17:10:19 +0000 (19:10 +0200)]
Use union's stringValue()

With the union codegen improvement we can use stringValue() to
directly bind to generated code.

JIRA: MDSAL-364
Change-Id: Ic210e2a86831ddc5b78601928cc02ac8e32cbbe5
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
5 years agoRemove use of powermock 84/74184/2
Robert Varga [Wed, 18 Jul 2018 11:11:39 +0000 (13:11 +0200)]
Remove use of powermock

Rather than mocking a static method setup the class properly.

Change-Id: Idfd4c0c655c708f5c0e8c83287051b77a4544774
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
5 years agoodl-restconf-base should import odl-mdsal-model feature 88/74088/1
Robert Varga [Mon, 16 Jul 2018 20:56:46 +0000 (22:56 +0200)]
odl-restconf-base should import odl-mdsal-model feature

Rather than re-packaging restconf here, use upstream feature.

Change-Id: I9c0b8789ef4b166f0b056193a5156871d888156f
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
5 years agoDepend on yanglib feature 84/74084/2
Robert Varga [Mon, 16 Jul 2018 20:08:59 +0000 (22:08 +0200)]
Depend on yanglib feature

yanglib is package upstream, use that packaging.

Change-Id: I260e9e213b964da7c839bc7ce904073cb5066af2
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
5 years agoodl-netconf-connector needs only clemm-ietf-topology 87/74087/1
Robert Varga [Mon, 16 Jul 2018 20:42:32 +0000 (22:42 +0200)]
odl-netconf-connector needs only clemm-ietf-topology

We do not need all mdsal models, only the topology model, express
that in a minimal dependency.

Change-Id: I30125a6b3f9e5be48948ddcd15fddf382ff7c145
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
5 years agoodl-restconf-common requires ietf-yang-library only 86/74086/1
Robert Varga [Mon, 16 Jul 2018 20:46:50 +0000 (22:46 +0200)]
odl-restconf-common requires ietf-yang-library only

Rather than depending on all models, pull it the bare minium
required so we can speed up startup.

Change-Id: I490343232ffd48c8112719a6008f44ce6ca162f7
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
5 years agoDo not package jars multiple times 83/74083/1
Robert Varga [Mon, 16 Jul 2018 18:46:54 +0000 (20:46 +0200)]
Do not package jars multiple times

odl-restconf-nb-rfc8040 has a dependency on netconf-api, use
odl-netconf-api to resolve that (and other) dependencies.

Change-Id: If9fe9600f13838af229c7f5f7c2587e0d863fa22
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
5 years agoUse ConcurrentDataBrokerTestCustomizer in UTs 86/73486/6
Tom Pantelis [Mon, 25 Jun 2018 03:37:10 +0000 (23:37 -0400)]
Use ConcurrentDataBrokerTestCustomizer in UTs

... to do the DataBroker wiring.

Change-Id: I32060a8d17343a6b3818cab3ec9caf03e7f0bb09
Signed-off-by: Tom Pantelis <tompantelis@gmail.com>
5 years agoUse DOMExtensibleService.getExtensions() 40/73940/7
Robert Varga [Wed, 11 Jul 2018 13:44:37 +0000 (15:44 +0200)]
Use DOMExtensibleService.getExtensions()

getExtensions() provides a better return value, so we can arrive
at individual extensions in a type-safe manner.

Change-Id: If52c0d9c5a05a70953fd17e27c3f2af155fcb3ee
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
5 years agoMerge "Remove netconf-node-inventory"
Jakub Morvay [Thu, 12 Jul 2018 08:24:47 +0000 (08:24 +0000)]
Merge "Remove netconf-node-inventory"

5 years agoMerge "Add explicit getExtensions()"
Jakub Morvay [Thu, 12 Jul 2018 08:14:31 +0000 (08:14 +0000)]
Merge "Add explicit getExtensions()"

5 years agoMerge changes from topic 'no-chararray'
Jakub Morvay [Thu, 12 Jul 2018 08:12:59 +0000 (08:12 +0000)]
Merge changes from topic 'no-chararray'

* changes:
  Rely in ietf-inet-util to convert IpAddress to string
  Do not rely on union char[] values

5 years agoAdd explicit getExtensions() 60/73960/1
Robert Varga [Wed, 11 Jul 2018 22:23:11 +0000 (00:23 +0200)]
Add explicit getExtensions()

getExtensions() will become a mandatory method, make sure we are
ready for that.

Change-Id: Idca41be7d2a14c836345ea5d4b77857f6bbeca76
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
5 years agoRemove netconf-node-inventory 47/73947/5
Robert Varga [Wed, 11 Jul 2018 15:43:29 +0000 (17:43 +0200)]
Remove netconf-node-inventory

This model is not used anywhere, remove it and simplify RemoteDeviceId
so that it is purely topology-based.

Change-Id: Ia4d6738ceab8c1ed9864dd0f6277ea462377e584
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
5 years agoRely in ietf-inet-util to convert IpAddress to string 53/73953/2
Robert Varga [Wed, 11 Jul 2018 18:48:42 +0000 (20:48 +0200)]
Rely in ietf-inet-util to convert IpAddress to string

Union-based getValue() is char[]-based for JMX, do not use it.

Change-Id: I67f913e01ee06e26714eaf6554ec2623391cf1b8
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
5 years agoDo not rely on union char[] values 52/73952/2
Robert Varga [Wed, 11 Jul 2018 18:47:21 +0000 (20:47 +0200)]
Do not rely on union char[] values

This removes the dependency on synthetic getValue() and the union
constructor for JMX.

Change-Id: I46eaa2922e8cc83505a3198a9b29561f8ab1b32a
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
5 years agoMerge "Remove redundant code constructs"
Jakub Morvay [Wed, 11 Jul 2018 17:30:36 +0000 (17:30 +0000)]
Merge "Remove redundant code constructs"

5 years agoRemove redundant code constructs 23/73923/2
Jakub Morvay [Wed, 11 Jul 2018 10:36:00 +0000 (12:36 +0200)]
Remove redundant code constructs

- Remove redundant type arguments
- Remove redundant type casts

Change-Id: I943060df1f465ff019b62abd5e72bc9ff7bc8ef9
Signed-off-by: Jakub Morvay <jmorvay@frinx.io>
5 years agoMigrate sal.core.api.mount.MountProvisionListener users 88/73888/5
Robert Varga [Tue, 10 Jul 2018 18:03:32 +0000 (20:03 +0200)]
Migrate sal.core.api.mount.MountProvisionListener users

DOMMountPointListener is the replacement interface, use it.

Change-Id: I51222f1f2bc133d90dd59a029fe538826dde48c0
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>