Ed Warnicke [Mon, 22 Sep 2014 18:31:51 +0000 (18:31 +0000)]
Merge "Bug 1025: Fixed incorrect revision in sal-remote-augment, which caused log polution."
Tony Tkacik [Mon, 22 Sep 2014 15:12:13 +0000 (17:12 +0200)]
Bug 1025: Fixed incorrect revision in sal-remote-augment, which caused log polution.
Change-Id: I5db5bfb43217d21bad58c913de8dedac5d7cdf23
Signed-off-by: Tony Tkacik <ttkacik@cisco.com>
Tony Tkacik [Sat, 20 Sep 2014 14:46:54 +0000 (14:46 +0000)]
Merge "BUG-1953: fix bad values in netconf monitoring test"
Robert Varga [Fri, 19 Sep 2014 19:40:36 +0000 (21:40 +0200)]
BUG-1953: fix bad values in netconf monitoring test
Uses string values which do not match the format prescribed by the
model. Fix them.
Change-Id: I55efcdd87aea24bcfd805a865319fe324e663768
Signed-off-by: Robert Varga <rovarga@cisco.com>
Maros Marsalek [Thu, 18 Sep 2014 15:58:48 +0000 (17:58 +0200)]
BUG-1949 Fix race condition in AsyncSshHandler
Remove pending limit due to unexpected behaviour with chunked messages.
Extract Reader/Writer into separate classes.
Also lower the amount of requests sent in SSH Stress integration test.
Change-Id: Idff719ac3a6bed9e8939efa01b8306f2884848fe
Signed-off-by: Maros Marsalek <mmarsale@cisco.com>
Ed Warnicke [Fri, 19 Sep 2014 02:38:22 +0000 (21:38 -0500)]
Bug 1970: Disabling NetconfITSecureTest test
Change-Id: Id937c37cd237ee4340a0e8e5bd63561d1e1afe21
Signed-off-by: Ed Warnicke <eaw@cisco.com>
Tony Tkacik [Thu, 18 Sep 2014 12:56:57 +0000 (12:56 +0000)]
Merge "BUG-692 Fix major issues reported by sonar for netconf subsystem"
Filip Tehlar [Wed, 17 Sep 2014 10:39:29 +0000 (12:39 +0200)]
BUG-1521 netconf-util line coverage
Change-Id: I90fc67622d95fa1b1e06fcf3c10a4d0ea40000c4
Signed-off-by: Filip Tehlar <ftehlar@cisco.com>
Maros Marsalek [Wed, 17 Sep 2014 14:11:14 +0000 (16:11 +0200)]
BUG-692 Fix major issues reported by sonar for netconf subsystem
Change-Id: I2f7cd479a773b7c3edc111c45add8ab5510fb47f
Signed-off-by: Maros Marsalek <mmarsale@cisco.com>
Tony Tkacik [Wed, 17 Sep 2014 11:21:52 +0000 (11:21 +0000)]
Merge "BUG 1659 - non unified returning data default format"
Tony Tkacik [Wed, 17 Sep 2014 10:45:28 +0000 (10:45 +0000)]
Merge "BUG-1842 Fix byte buffer handling for pending messages"
Jozef Gloncak [Tue, 16 Sep 2014 12:59:34 +0000 (14:59 +0200)]
BUG 1659 - non unified returning data default format
Returning value (errors and data) will be by default in JSON format
Change-Id: I65368da31b1364c3e8153d39ab66e1fd8ecc49d3
Signed-off-by: Jozef Gloncak <jgloncak@cisco.com>
Maros Marsalek [Tue, 16 Sep 2014 11:22:57 +0000 (13:22 +0200)]
BUG-1842 Fix byte buffer handling for pending messages
Change-Id: I54cd873e12d73779e20be280226480d090d9e8c5
Signed-off-by: Maros Marsalek <mmarsale@cisco.com>
Tony Tkacik [Mon, 15 Sep 2014 09:23:08 +0000 (09:23 +0000)]
Merge "BUG-1521 netconf-client line coverage"
Tony Tkacik [Fri, 12 Sep 2014 11:06:50 +0000 (11:06 +0000)]
Merge "BUG-1521 Unit tests for netconf-util xml package."
Filip Tehlar [Thu, 11 Sep 2014 13:07:26 +0000 (15:07 +0200)]
BUG-1521 netconf-client line coverage
Change-Id: I44c7d6a627e21aabe9c46ea678a90d81268ef438
Signed-off-by: Filip Tehlar <ftehlar@cisco.com>
Maros Marsalek [Thu, 11 Sep 2014 10:53:55 +0000 (12:53 +0200)]
BUG-1521 Unit tests for netconf-util xml package.
Change-Id: Iaafba131555b948130a9916127b808c00016f502
Signed-off-by: Maros Marsalek <mmarsale@cisco.com>
Maros Marsalek [Wed, 10 Sep 2014 13:26:28 +0000 (15:26 +0200)]
BUG-600 Netconf testtool for scale test, set connection timeout on server side.
Change-Id: I21507bce0961dc9b149db6f10b31f34c27188b3a
Signed-off-by: Maros Marsalek <mmarsale@cisco.com>
Tony Tkacik [Thu, 11 Sep 2014 11:57:24 +0000 (11:57 +0000)]
Merge "BUG-1521 Netconf-netty-util missing unit tests"
Tony Tkacik [Thu, 11 Sep 2014 09:54:46 +0000 (09:54 +0000)]
Merge "BUG 1582 - PUT fails validate outer object name"
Maros Marsalek [Tue, 9 Sep 2014 13:54:48 +0000 (15:54 +0200)]
BUG-1521 Netconf-netty-util missing unit tests
Change-Id: I1cb19296d2c428214212f342fab64999ad3eb5f3
Signed-off-by: Maros Marsalek <mmarsale@cisco.com>
Robert Varga [Tue, 9 Sep 2014 12:23:23 +0000 (14:23 +0200)]
BUG-1704: do not emit separator
When reusing JSONNormalizedNodeStreamWriter, it retains enough state to
know to emit a separator, so if we do it here, we will break the output.
Change-Id: Ie7acc269b4546230fad532f0abf14c0ba6c4121a
Signed-off-by: Robert Varga <rovarga@cisco.com>
Tony Tkacik [Tue, 9 Sep 2014 07:18:46 +0000 (07:18 +0000)]
Merge "BUG-1521 Add missing unit tests for config-persister-impl"
Jozef Gloncak [Mon, 8 Sep 2014 12:48:53 +0000 (14:48 +0200)]
BUG 1582 - PUT fails validate outer object name
validateTopLevelNodeName method was added.
Change-Id: I6f48ba9350b31d98f765fcb4afb367b8435b4cbd
Signed-off-by: Jozef Gloncak <jgloncak@cisco.com>
Tony Tkacik [Mon, 8 Sep 2014 08:41:17 +0000 (08:41 +0000)]
Merge "Make generated address configurable for netconf testtool"
Maros Marsalek [Fri, 5 Sep 2014 13:59:06 +0000 (15:59 +0200)]
Make generated address configurable for netconf testtool
Change-Id: Ia112bc4108c9d7d8756b755f8e6e660e255a046e
Signed-off-by: Maros Marsalek <mmarsale@cisco.com>
Maros Marsalek [Fri, 5 Sep 2014 09:21:01 +0000 (11:21 +0200)]
BUG-1521 Add missing unit tests for config-persister-impl
Change-Id: Id9b6f024da20ea71daa6b29353e39fbdb81e0fb2
Signed-off-by: Maros Marsalek <mmarsale@cisco.com>
Devin Avery [Thu, 4 Sep 2014 22:41:44 +0000 (22:41 +0000)]
Merge "Initial clustering feature"
Ed Warnicke [Wed, 27 Aug 2014 21:09:18 +0000 (16:09 -0500)]
Initial clustering feature
Besides the clustering feature changes a couple of other changes
had to be made to the distributed data store and remote rpc modules
to make the solution work with karaf
1. The akka.conf in sal-clustering-config has now been changed so that
it works in a single node cluster out of the box. Specifically the hostnames
have been set to 127.0.0.1 and the member role has been set to member-1
2. The distributed-data-store and the remote-rpcconnector now load akka
configuration from the configuration/initial folder. The positive thing about
this is that even in a multi-node cluster one does not need to pass the location
of akka.conf on the command line. The negative thing about this is that you
cannot change the location from which the akka configuration can be picked up.
Though this should be ok because we specifically pick modules.conf and
module-shards.conf from the configuration/initial folder as well.
3. The Protobuf bundle has now been wrapped and a Dynamic Import has been
added to it so that it can deserialized specific protocol buffer messages
4. The RestConfProvider was not written to shutdown correctly. While this is
not normally an issue it does become an issue when the clustering feature is
loaded for the first time because in that case the RestConfProvider may need
to be shutdown by the config sub-system
Change-Id: I1701ae8e9508c82779483963fb73b6af91095d7d
Signed-off-by: Ed Warnicke <eaw@cisco.com>
Signed-off-by: Moiz Raja <moraja@cisco.com>
Ed Warnicke [Thu, 4 Sep 2014 17:01:41 +0000 (17:01 +0000)]
Merge changes I9aa41251,Ibd0fb687
* changes:
Bug 1703: Fixed memory leak in TransactionChain
Bug 222: Added basic Restconf operational statistics
Tony Tkacik [Thu, 4 Sep 2014 11:48:08 +0000 (13:48 +0200)]
Bug 222: Added basic Restconf operational statistics
Added basic restconf statistics which counts
incoming requests and exported it via Config subsystem.
Export via config subsystem provides this
statistics via JMX and Netconf. In distribution, where
sal-netconf-connector is present and 99-sal-netconf-connector.xml is enabled,
Restconf statistics are also available via
restconf/operational/opendaylight-inventory:nodes/node/controller-config/yang-ext:mount/config:modules/module/rest-connector-default-impl
Change-Id: Ibd0fb6875104d1a90eeaf62271c9a2f87d2f85f0
Signed-off-by: Tony Tkacik <ttkacik@cisco.com>
Tony Tkacik [Thu, 4 Sep 2014 11:38:34 +0000 (11:38 +0000)]
Merge "Fix netconf testtool after recent changes to auth in netconf"
Tony Tkacik [Thu, 4 Sep 2014 11:38:22 +0000 (11:38 +0000)]
Merge "Refactor integration tests for netconf in netconf-it"
Maros Marsalek [Wed, 3 Sep 2014 15:26:11 +0000 (17:26 +0200)]
Fix netconf testtool after recent changes to auth in netconf
Change-Id: I924057380d2a63d062ef33a4d9bc29af61265dc3
Signed-off-by: Maros Marsalek <mmarsale@cisco.com>
Maros Marsalek [Wed, 3 Sep 2014 12:22:43 +0000 (14:22 +0200)]
Refactor integration tests for netconf in netconf-it
Change-Id: I03c8a9220dc1fa115f6489219df6a45297bbd28e
Signed-off-by: Maros Marsalek <mmarsale@cisco.com>
Ed Warnicke [Wed, 3 Sep 2014 15:01:54 +0000 (15:01 +0000)]
Merge "Bug 1664: Fixed JSON/XML serialization of reading mount point root data."
Tony Tkacik [Wed, 3 Sep 2014 13:02:55 +0000 (15:02 +0200)]
Bug 1664: Fixed JSON/XML serialization of reading mount point root data.
Change-Id: I3ff08d907abc0c11e4166cc8c70695325df95868
Signed-off-by: Tony Tkacik <ttkacik@cisco.com>
Tony Tkacik [Mon, 1 Sep 2014 19:56:45 +0000 (21:56 +0200)]
Bug 1441: Added proper handling of reading JSON list items.
Fixed handling of reading nested data in JSON codec.
Initial integration contained bug, which did use JSON
codec correctly, which ended in 500 for reading list item.
Change-Id: I38ef0b40cea1a22e313d22f64db3806c293d67d6
Signed-off-by: Tony Tkacik <ttkacik@cisco.com>
Tony Tkacik [Tue, 2 Sep 2014 05:37:54 +0000 (05:37 +0000)]
Merge "BUG-1442: integrate XML/JSON Normalized Node writers with Restconf"
Robert Varga [Tue, 19 Aug 2014 08:42:00 +0000 (10:42 +0200)]
BUG-1442: integrate XML/JSON Normalized Node writers with Restconf
Integrated XML and JSON NormalizedNodeWriters for returning
data from Restconf. This writers does stream processing
and writes data into input stream without any intermediate
representations.
This will help with larger data sets, since it theoretically
reduces memory footprint of reading data from MD-SAL.
Change-Id: I36564b7a5a1bc50d60e1cb6d5b2b45f92c2caf0b
Signed-off-by: Jozef Gloncak <jgloncak@cisco.com>
Signed-off-by: Robert Varga <rovarga@cisco.com>
Ed Warnicke [Sun, 31 Aug 2014 01:43:24 +0000 (20:43 -0500)]
Added sal-rest-docgen to features.
Change-Id: I85af2296a1e0c8a1be599a611424418d4297f6a1
Signed-off-by: Ed Warnicke <eaw@cisco.com>
Ed Warnicke [Fri, 29 Aug 2014 03:18:53 +0000 (03:18 +0000)]
Merge "Added AAA AuthN filter to RESTConf web.xml"
Ed Warnicke [Thu, 28 Aug 2014 16:08:13 +0000 (16:08 +0000)]
Merge "Bug 1636: Config Netconf Connector did not serialize service type"
Tony Tkacik [Thu, 28 Aug 2014 15:47:25 +0000 (15:47 +0000)]
Merge "BUG-1617 Extract AuthProvider from netconf ssh"
Tony Tkacik [Thu, 28 Aug 2014 11:20:58 +0000 (13:20 +0200)]
Bug 1636: Config Netconf Connector did not serialize service type
Config Netconf connector did not serialized service type
in list of service dependencies properly, which resulted
in invalid string 'prefix:null'
Change-Id: I02cc56e2069b56737167d9b694f8cb8309bbd74d
Signed-off-by: Tony Tkacik <ttkacik@cisco.com>
Tony Tkacik [Wed, 27 Aug 2014 15:11:16 +0000 (15:11 +0000)]
Merge "BUG-1621 Fix reconnecting."
Maros Marsalek [Wed, 27 Aug 2014 12:51:12 +0000 (14:51 +0200)]
BUG-1621 Fix reconnecting.
Netconf-connector did not reconnect after recent changes (Ssh mina integration)
SshHandler was in pipeline after listener in reconnect, thats why the listener received no event about session down.
Change-Id: Id39062f51bc3a0caf066ca49682a2acc837b06ef
Signed-off-by: Maros Marsalek <mmarsale@cisco.com>
Liem Nguyen [Tue, 26 Aug 2014 19:57:18 +0000 (12:57 -0700)]
Added AAA AuthN filter to RESTConf web.xml
Change-Id: I78d57335e805165c99038b4a6f89f8c5229253a5
Signed-off-by: Liem Nguyen <liem_m_nguyen@hp.com>
Moiz Raja [Tue, 26 Aug 2014 15:39:07 +0000 (15:39 +0000)]
Merge "Bug 1616: Issues with using container and default values in config yang"
Maros Marsalek [Tue, 26 Aug 2014 14:53:07 +0000 (16:53 +0200)]
BUG-1617 Extract AuthProvider from netconf ssh
Change-Id: Ib6f47c0dca5b4b3604b639ae8bca3565f8dd934c
Signed-off-by: Maros Marsalek <mmarsale@cisco.com>
Tony Tkacik [Tue, 26 Aug 2014 14:09:48 +0000 (14:09 +0000)]
Merge "BUG-1618 Handle pending writes in ssh netconfclient"
Maros Marsalek [Tue, 26 Aug 2014 11:46:32 +0000 (13:46 +0200)]
BUG-1618 Handle pending writes in ssh netconfclient
Change-Id: If4371860e81cf4153c4baaa8a9b0d3c45334ab5c
Signed-off-by: Maros Marsalek <mmarsale@cisco.com>
Tony Tkacik [Tue, 26 Aug 2014 07:37:44 +0000 (07:37 +0000)]
Merge "BUG-1521 Increase test coverage of netconf-netty-util"
Tony Tkacik [Tue, 26 Aug 2014 07:37:31 +0000 (07:37 +0000)]
Merge "BUG-1568 Remove unused VirtualSocket"
Tony Tkacik [Tue, 26 Aug 2014 07:37:20 +0000 (07:37 +0000)]
Merge "BUG-1521 Netconf-monitoring test coverage raise"
Maros Marsalek [Mon, 25 Aug 2014 15:14:11 +0000 (17:14 +0200)]
BUG-1521 Increase test coverage of netconf-netty-util
Change-Id: I962e16da8d4112b4ec6a1c90170be3036041eddd
Signed-off-by: Maros Marsalek <mmarsale@cisco.com>
Maros Marsalek [Mon, 25 Aug 2014 15:13:36 +0000 (17:13 +0200)]
BUG-1568 Remove unused VirtualSocket
Change-Id: I75682c0ec0b0956ba04060cdbcdee32a53a459c9
Signed-off-by: Maros Marsalek <mmarsale@cisco.com>
Maros Marsalek [Mon, 25 Aug 2014 13:07:50 +0000 (15:07 +0200)]
BUG-1521 Netconf-monitoring test coverage raise
Change-Id: Ibcbcd7df788c75879fa0c9a554125144aa5c1545
Signed-off-by: Maros Marsalek <mmarsale@cisco.com>
Ed Warnicke [Mon, 25 Aug 2014 11:15:10 +0000 (11:15 +0000)]
Merge "BUG-1568 Remove ganymed Ssh client adapter"
Ed Warnicke [Mon, 25 Aug 2014 11:14:59 +0000 (11:14 +0000)]
Merge "BUG-1568 Ssh Handler for netconf client Mina implementation"
Maros Marsalek [Mon, 25 Aug 2014 08:11:25 +0000 (10:11 +0200)]
BUG-1568 Remove ganymed Ssh client adapter
Change-Id: Id4ec6140df3e91fd8a219b03ceabca67732af568
Signed-off-by: Maros Marsalek <mmarsale@cisco.com>
Signed-off-by: Robert Varga <rovarga@cisco.com>
Maros Marsalek [Mon, 25 Aug 2014 08:01:47 +0000 (10:01 +0200)]
BUG-1568 Ssh Handler for netconf client Mina implementation
This implementation of Ssh Handler is asynchronous and based on Apache Mina SSHD.
+ Add Mina SSHD to distribution.
Change-Id: I51f51e2eb56b5f97a87c3d068ea90f8a44adca09
Signed-off-by: Maros Marsalek <mmarsale@cisco.com>
Signed-off-by: Robert Varga <rovarga@cisco.com>
Moiz Raja [Mon, 25 Aug 2014 04:56:54 +0000 (04:56 +0000)]
Merge "Fix for possible NPE if Bundle is stopped."
tpantelis [Sat, 23 Aug 2014 13:51:00 +0000 (09:51 -0400)]
Bug 1616: Issues with using container and default values in config yang
Fixed issues as outlined in bug 1616.
Change-Id: I6170a6d25e2fb243d6526d15058057191058bb82
Signed-off-by: tpantelis <tpanteli@brocade.com>
Ed Warnicke [Thu, 21 Aug 2014 14:38:56 +0000 (14:38 +0000)]
Merge "Bug 1586: Do not use JaxRS 2.0 unnecessarily"
Tony Tkacik [Thu, 21 Aug 2014 09:09:01 +0000 (09:09 +0000)]
Merge "BUG-1568 Getting rid of StreamGobller from netconf ssh client."
Tony Tkacik [Thu, 21 Aug 2014 09:08:47 +0000 (09:08 +0000)]
Merge "BUG-1541 Make EXI and clientConnectTimeout configurable in testtool."
Tony Tkacik [Thu, 21 Aug 2014 09:08:33 +0000 (09:08 +0000)]
Merge "Fix race condition in SSH NETCONF server"
Tony Tkacik [Thu, 21 Aug 2014 08:32:11 +0000 (10:32 +0200)]
Bug 1586: Do not use JaxRS 2.0 unnecessarily
As it turned out our container uses jax-rs 1.0 so we removed
unnecessarily call to 2.0 constructor.
Change-Id: I23c38871050c34d721b21369da5b162a18925a9d
Signed-off-by: Tony Tkacik <ttkacik@cisco.com>
Maros Marsalek [Wed, 20 Aug 2014 13:11:35 +0000 (15:11 +0200)]
BUG-1568 Getting rid of StreamGobller from netconf ssh client.
We have another thread in SshClientAdapter that works as StreamGobller
http://www.ganymed.ethz.ch/ssh2/FAQ.html#blocking
Change-Id: I3f61b14cb22396d8b5898028bd83f62d98c6866d
Signed-off-by: Maros Marsalek <mmarsale@cisco.com>
Tony Tkacik [Thu, 21 Aug 2014 07:20:59 +0000 (07:20 +0000)]
Merge "NETCONF scalability: share instances"
Devin Avery [Wed, 20 Aug 2014 13:14:36 +0000 (13:14 +0000)]
Merge "BUG 932 - Swagger HTTP POST contains incorrect object"
Robert Varga [Wed, 20 Aug 2014 12:29:07 +0000 (14:29 +0200)]
NETCONF scalability: share instances
Scalability testing shows that the netconf session code:
- retains XML document reference
- does not reuse QName instances
Change-Id: I6b58355e3fa74d67872d665d0f8dc2d16abe156c
Signed-off-by: Robert Varga <rovarga@cisco.com>
Maros Marsalek [Wed, 20 Aug 2014 11:28:34 +0000 (13:28 +0200)]
BUG-1541 Make EXI and clientConnectTimeout configurable in testtool.
Change-Id: I0152a78691b87a2d2674b0ecf0e4844f0ca9b35b
Signed-off-by: Maros Marsalek <mmarsale@cisco.com>
Maros Marsalek [Wed, 20 Aug 2014 09:32:44 +0000 (11:32 +0200)]
Fix race condition in SSH NETCONF server
Change-Id: I205a1670b30dcfad4230418c133fd87e069e15e6
Signed-off-by: Maros Marsalek <mmarsale@cisco.com>
Jozef Gloncak [Wed, 16 Jul 2014 12:03:20 +0000 (14:03 +0200)]
BUG 932 - Swagger HTTP POST contains incorrect object
POST link now contains specific JSON structure which ends with POST suffix
and contains all containers and lists which are direct subchildren of
current node (URI link). It is list of possible objects which can be used
in POST request. Concretelly are these objects specified below this *POST
JSON object and are also all specified in Parameters section of GUI POST
URI link with ** prefix. Two stars (**) mean that only one of parameters
with ** prefix should be specified.
Change-Id: I3acdfd1f181fbef7cca0060d534b706d934bb1e3
Signed-off-by: Jozef Gloncak <jgloncak@cisco.com>
Ed Warnicke [Tue, 12 Aug 2014 15:45:34 +0000 (10:45 -0500)]
Fix for possible NPE if Bundle is stopped.
Change-Id: Iaf1d44f8b600e69392452b74042812b35e8101de
Signed-off-by: Ed Warnicke <eaw@cisco.com>
Devin Avery [Mon, 18 Aug 2014 15:24:20 +0000 (15:24 +0000)]
Merge "Modifications to error handling in restconf"
Ed Warnicke [Mon, 18 Aug 2014 15:20:04 +0000 (15:20 +0000)]
Merge "BUG-1541 Netconf device simulating testtool"
Ed Warnicke [Mon, 18 Aug 2014 15:19:51 +0000 (15:19 +0000)]
Merge "BUG-1541 Extract AuthProvider interface"
Ed Warnicke [Mon, 18 Aug 2014 14:52:17 +0000 (14:52 +0000)]
Merge "Fix precondition formatting"
Maros Marsalek [Tue, 12 Aug 2014 13:31:27 +0000 (15:31 +0200)]
BUG-1541 Netconf device simulating testtool
Produces executable jar file.
The jar can simulate arbitrary number of netconf devices that listen on configured ports
Schemas are loaded from a provided folder
Can also generate ODL initial config files for started simulated devices to support testing with ODL distribution
Change-Id: I8fce73fa7c568a272c29073f26a4e8aafeebfd82
Signed-off-by: Maros Marsalek <mmarsale@cisco.com>
Maros Marsalek [Tue, 12 Aug 2014 13:30:57 +0000 (15:30 +0200)]
BUG-1541 Extract AuthProvider interface
Change-Id: I8df939b1c712fe85f3cd269df50b01ceee2d9538
Signed-off-by: Maros Marsalek <mmarsale@cisco.com>
Ed Warnicke [Fri, 15 Aug 2014 19:27:38 +0000 (19:27 +0000)]
Merge "Bug 1503: RestconfError "data-missing" is error code 404."
Robert Varga [Tue, 12 Aug 2014 18:08:49 +0000 (20:08 +0200)]
Bug 1503: RestconfError "data-missing" is error code 404.
The base specification listed the error code to be 409, which is in
direct violation on HTTP. The restconf specification will be fixed in
the upcoming draft, meanwhile we are going for the new, sane behavior
regardless.
Change-Id: I7a6cf67a794f8348d746ba94b7de9580d0472a61
Signed-off-by: Vratko Polak <vrpolak@cisco.com>
Signed-off-by: Robert Varga <rovarga@cisco.com>
tpantelis [Wed, 13 Aug 2014 12:55:16 +0000 (08:55 -0400)]
Modifications to error handling in restconf
Modified error handling for read and write Tx to transfer to transfer
RpcError info from ReadFailedException and
TransactionCommitFailedException to the RestconfDocumentedException.
Change-Id: Ifb47f0cdfda5a11d53add9d7ef8fbe50954c0206
Signed-off-by: tpantelis <tpanteli@brocade.com>
Robert Varga [Thu, 14 Aug 2014 19:45:42 +0000 (21:45 +0200)]
Fix precondition formatting
Preconditions take String.format() arguments, not {} placeholders.
Change-Id: I6fe863e3954ccb0c6a861ec969691072933406a2
Signed-off-by: Robert Varga <rovarga@cisco.com>
Ed Warnicke [Wed, 13 Aug 2014 13:43:31 +0000 (13:43 +0000)]
Merge "BUG-997 Use shared schema context factory in netconf-connector"
Tom Pantelis [Wed, 13 Aug 2014 12:12:10 +0000 (12:12 +0000)]
Merge "Add exists method on DOMStoreReadTransaction and DOMDataReadTransaction"
Moiz Raja [Sun, 10 Aug 2014 23:18:33 +0000 (16:18 -0700)]
Add exists method on DOMStoreReadTransaction and DOMDataReadTransaction
Introducing this API does not impact clients as it is mostly internal.
One reason for adding this API is because of ensureParentsByMerge used in a couple of places
which keeps checking if a parent node exists by reading a node to figure out if it exists. This is
fine for the InMemoryDataStore but it can be terrible in a distributed data store where the shard
which contains the data is remote. All sorts of overhead is associated with a remote read including
serialization which can actually be pretty expensive.
Change-Id: Ib5be5f6dc60be683d7a04c81dad08c56cd5681f4
Signed-off-by: Moiz Raja <moraja@cisco.com>
Devin Avery [Tue, 12 Aug 2014 15:48:07 +0000 (15:48 +0000)]
Merge "Minor changes to config-persister to allow for karaf"
Maros Marsalek [Mon, 4 Aug 2014 14:35:47 +0000 (16:35 +0200)]
BUG-997 Use shared schema context factory in netconf-connector
+ Fix disconnect by netconf-connector. Until now, the connection to remote device was still open even if initialization failed.
Change-Id: I23ee999c7898665498519abf19610deef3d410a3
Signed-off-by: Maros Marsalek <mmarsale@cisco.com>
Ed Warnicke [Mon, 11 Aug 2014 02:43:06 +0000 (21:43 -0500)]
Minor changes to config-persister to allow for karaf
These minor changes expose a ConfigPusher service for use
by a config-persister-feature-adapter (to follow) that
can push configs attached to features.
Change-Id: I382d2ab578d19ea9c24afa521a9a5a047360fc50
Signed-off-by: Ed Warnicke <eaw@cisco.com>
Devin Avery [Mon, 11 Aug 2014 14:05:57 +0000 (14:05 +0000)]
Merge "BUG 907 distinguish augmented nodes"
Jozef Gloncak [Tue, 15 Jul 2014 09:10:57 +0000 (11:10 +0200)]
BUG 907 distinguish augmented nodes
All nodes and their child contains also information about module from
which they comes from (module_name:node_name)
Change-Id: I7b146e820da1b5d3bdb62510a48e6845a78c80a2
Signed-off-by: Jozef Gloncak <jgloncak@cisco.com>
Jozef Gloncak [Tue, 5 Aug 2014 08:59:55 +0000 (10:59 +0200)]
BUG 1162 - problem to post list data
If last path arguments of instance identifier are list with keys then in
POST operation it is necessary to append it to instance identifier as
nodeWithKey.
This code was part of RestconfImpl but it was probably deleted
accidentaly.
Change-Id: I117cbcc39dcb97e8bc5ecc852ce2e9e7da7070cf
Signed-off-by: Jozef Gloncak <jgloncak@cisco.com>
Tony Tkacik [Thu, 7 Aug 2014 06:09:50 +0000 (06:09 +0000)]
Merge "Fix test coverage not being reported in Sonar"
Ed Warnicke [Wed, 6 Aug 2014 19:21:31 +0000 (19:21 +0000)]
Merge "Remove old dependencies"
Robert Varga [Wed, 6 Aug 2014 05:45:21 +0000 (07:45 +0200)]
Fix test coverage not being reported in Sonar
Change-Id: Id8ff02a986b1bfdab01a481fcb11cef111757de9
Signed-off-by: Robert Varga <rovarga@cisco.com>
Tony Tkacik [Wed, 6 Aug 2014 15:52:19 +0000 (15:52 +0000)]
Merge "Optimilization the method datastoreNormalizedNodeToCompositeNode"