Merge "BUG-5006: rework SouthboundProviderTest, clean up"

Merge "Use registerAbstractHandlerService consistently"

Merge "Bug 5368 - NeutronL3Adapter ipv6 work around for mac address resolver"

Merge "Cleanup exception logging"

Cleanup exception logging

Change-Id: Icc711755baad9f377efb00da0ec8b57e5b89f7e3
Signed-off-by: Sam Hague <shague@redhat.com>
Signed-off-by: Stephen Kitt <skitt@redhat.com>

Merge "Bug 5261 - Missing dependency on sal-binding-broker-impl in Boron build"

BUG 5366: SB and hwvtep exceptions when both inuse

When hwvtep and ovsdbSB both are enabled their respective
connectionManagers don't check if relevant DB is present or not.

Change-Id: I213ff3495d13a2bb2377ae3146290599280d4489
Signed-off-by: Vishal Thapar <vishal.thapar@ericsson.com>

Bug 5261 - Missing dependency on sal-binding-broker-impl in Boron build

The sal-binding-broker-impl was set at 1.3.0. Boron is at 1.4.0. Removed
the version tag since config-parent will eventually bring in the
mdsal artifacts and the right version.

Change-Id: I2b6cfea13b5bd3eefcd1886855ac315ad1b640a4
Signed-off-by: Sam Hague <shague@redhat.com>

Update directory descriptions for Beryllium

Change-Id: If49b424e494cb0040bd90a0ef2d518fda024827d
Signed-off-by: Sam Hague <shague@redhat.com>
Conflicts:
README

Change-Id: If49b424e494cb0040bd90a0ef2d518fda024827d
Signed-off-by: Sam Hague <shague@redhat.com>

Use registerAbstractHandlerService consistently

NeutronL3Adapter is an AbstractHandler service yet was registered
"manually"; this patch converts it to use
registerAbstractHandlerService.

DistributedArpService is registered following the same pattern but
isn't an AbstractHandler service...

Change-Id: I06cf3c9167d1b2bcb1c08d5ec462beb4d3ac1a38
Signed-off-by: Stephen Kitt <skitt@redhat.com>

Merge "Bug 5351 Connection state tracking  bit values are changed to match the Ovs2.5 implementiaon."

Merge "removing ovsdb-all feature"

Merge "Remove references to odl-ovsdb-all"

Remove references to odl-ovsdb-all

Now that the feature has been removed, update the documentation to
avoid listing it in the examples.

Change-Id: Ibd40e2088df955b8ab46cfcde354f364b1419cb6
Signed-off-by: Stephen Kitt <skitt@redhat.com>

removing ovsdb-all feature

- from the looks of the featuretree graph [0] it seems that
  ovsdb-all is not providing any benefit and probably would
  confuse an end-user, since all it would install is the
  ovsdb-library, which is pulled in by other features as
  needed.

[0]  https://wiki.opendaylight.org/view/OVSDB_Integration/FeatureTree

Change-Id: I968f33f64f8683d00d9a49904e2aa74795267308
Signed-off-by: Jamo Luhrsen <jluhrsen@redhat.com>

Bug 5368 - NeutronL3Adapter ipv6 work around for mac address resolver

Right now mac address resolver only supports IPv4 arp, not IPv6
neighbor discovery. So if fixed ip is IPv6, it is ignored for now
to avoid exception as follows.

> 2016-01-21 19:10:01,192 | ERROR | ntDispatcherImpl | EventDispatcher                  | 279 - org.opendaylight.ovsdb.openstack.net-virt - 1.2.1.SNAPSHOT | Exception in dispatching event NorthboundEvent [handler=NEUTRON_PORT, action=UPDATE, port=NeutronPort [portUUID=dc49dbb5-24eb-4126-9112-6e8a6b117e7a, networkUUID=43e6202f-5ca4-48d7-99ec-1c88b3403efd, name=, adminStateUp=true, status=null, macAddress=FA:16:3E:BB:B6:5E, fixedIPs=[Neutron_IPs{ipAddress='2001:db8::1', subnetUUID='938d6b11-3a12-4d15-ac59-fa00f8ca68d6'}, Neutron_IPs{ipAddress='172.24.4.2', subnetUUID='4bdaf41a-37ce-4efe-bfbd-ef5aa804bee2'}], deviceID=b93bd54f-5eb9-47a0-9767-a486b2ff688a, deviceOwner=network:router_gateway, tenantID=76b28f13a97842299499a47bcbf498f3, securityGroups=[], bindinghostID=, bindingvnicType=normal, bindingvnicType=normal], subnet=null, router=null, routerInterface=null, floatingIP=null, network=null, loadBalancer=null, loadBalancerPool=null, loadBalancerPoolMember=null, neutronsecurityRule=null]
> java.lang.IllegalArgumentException: Supplied value "2001:db8::1" does not match required pattern "^(([0-9]|[1-9][0-9]|1[0-9][0-9]|2[0-4][0-9]|25[0-5])\.){3}([0-9]|[1-9][0-9]|1[0-9][0-9]|2[0-4][0-9]|25[0-5])(%[\p{N}\p{L}]+)?$"
>         at com.google.common.base.Preconditions.checkArgument(Preconditions.java:145)[38:com.google.guava:18.0.0]
>         at org.opendaylight.yang.gen.v1.urn.ietf.params.xml.ns.yang.ietf.inet.types.rev100924.Ipv4Address.<init>(Ipv4Address.java:51)[70:org.opendaylight.mdsal.model.ietf-inet-types:2010.9.24.8-SNAPSHOT]
>         at org.opendaylight.ovsdb.openstack.netvirt.impl.NeutronL3Adapter.triggerGatewayMacResolver(NeutronL3Adapter.java:1529)[279:org.opendaylight.ovsdb.openstack.net-virt:1.2.1.SNAPSHOT]
>         at org.opendaylight.ovsdb.openstack.netvirt.impl.NeutronL3Adapter.handleNeutronPortEvent(NeutronL3Adapter.java:443)[279:org.opendaylight.ovsdb.openstack.net-virt:1.2.1.SNAPSHOT]
>         at org.opendaylight.ovsdb.openstack.netvirt.PortHandler.doNeutronPortUpdated(PortHandler.java:96)[279:org.opendaylight.ovsdb.openstack.net-virt:1.2.1.SNAPSHOT]
>         at org.opendaylight.ovsdb.openstack.netvirt.PortHandler.processEvent(PortHandler.java:167)[279:org.opendaylight.ovsdb.openstack.net-virt:1.2.1.SNAPSHOT]
>         at org.opendaylight.ovsdb.openstack.netvirt.impl.EventDispatcherImpl.dispatchEvent(EventDispatcherImpl.java:95)[279:org.opendaylight.ovsdb.openstack.net-virt:1.2.1.SNAPSHOT]
>         at org.opendaylight.ovsdb.openstack.netvirt.impl.EventDispatcherImpl.access$200(EventDispatcherImpl.java:27)[279:org.opendaylight.ovsdb.openstack.net-virt:1.2.1.SNAPSHOT]
>         at org.opendaylight.ovsdb.openstack.netvirt.impl.EventDispatcherImpl$1.run(EventDispatcherImpl.java:56)[279:org.opendaylight.ovsdb.openstack.net-virt:1.2.1.SNAPSHOT]
>         at java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:511)[:1.8.0_72-internal]
>         at java.util.concurrent.FutureTask.run(FutureTask.java:266)[:1.8.0_72-internal]
>         at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1142)[:1.8.0_72-internal]
>         at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:617)[:1.8.0_72-internal]
>         at java.lang.Thread.run(Thread.java:745)[:1.8.0_72-internal]

Change-Id: Ice966c994c2565c17da2f7953f6febc6bf370e57
Signed-off-by: Isaku Yamahata <isaku.yamahata@intel.com>

Bug 5351 Connection state tracking  bit values are changed to match the
Ovs2.5 implementiaon.

Change-Id: Ia163223a7a25de3b7bca4360c3f6dbadd87851f5
Signed-off-by: Aswin Suryanarayanan <aswin.suryanarayanan@hp.com>

BUG-5006: rework SouthboundProviderTest, clean up

SouthboundProviderTest doesn't need PowerMock, rework it to drive
everything through public methods and verify data-store side-effects
instead of method invocations.

Clean up a few unneeded exception declarations on close() methods.

Remove the last traces of PowerMock from SouthboundMapperTest.

Change-Id: I9b634680211fa528780b6a8b9edc4153744aba08
Signed-off-by: Stephen Kitt <skitt@redhat.com>

Bug 4550
Changed the comparater to .equals.

Change-Id: Ie16cc681fc8e387cd2d85d097a3c380fd60f0e86
Signed-off-by: Aswin Suryanarayanan <aswin.suryanarayanan@hp.com>

BUG-4917 Ensure all OVS flows are deleted

This commit is basically a revert of this change:
https://git.opendaylight.org/gerrit/#/c/27521/
With that change the cache cleanup in fact never ran because the
port is removed before the code is actually run.
The bug for which that commit was a fix is resolved
with this code new commit as well.

In addition, updateL3ForNeutronPort() now allows
deleting flows even when networkId is not found
in networkIdToRouterMacCache. This takes care of
some of the DHCP issues.

Change-Id: Idc3c1ff4b57f5471615ccc6c627ca8f411c37db2
Signed-off-by: Josh <jhershbe@redhat.com>
Signed-off-by: Anil Vishnoi <vishnoianil@gmail.com>
(cherry picked from commit 5824899205c6eb36b45064a3a3f54668e1117a40)

BUG-5006: rework SouthboundMapperTest without PowerMock

A number of tests were meaningless, these have all been fixed to
verify SouthboundMapper's behaviour.

Conflicts:
southbound/southbound-impl/src/test/java/org/opendaylight/ovsdb/southbound/SouthboundMapperTest.java

Change-Id: Ia349e545bde9706d2b1840530abd46c09ac55e45
Signed-off-by: Stephen Kitt <skitt@redhat.com>
Signed-off-by: Sam Hague <shague@redhat.com>

Merge "Clean up SouthboundMapper (and fix createQosType())"

Merge "Bug 4550 - always rebuild security group rule in security group"

Merge "Bug 4917  For fixing SG dangling flows. Extended port cache logic to TenantNetworkManagerImpl and SouthboundHandler."

Bug 4550 - always rebuild security group rule in security group

The change set of 906836c289a7e4c3d33669d90515d77e75cfb6d in
neutron northbound repository, the effort transparent neutron
northbound api, caused not to update security group rule in
security group.
So always rebuild rules in NeutronSecurityGroup and keep
security group rule in security group of yang model empty list.

openstack service provider that uses MD-SAL should not use
security group rules in security rule. But it should listen to
data change notification on security group rules.

Change-Id: Ic975e028c01462a2c7267f65c16b3bd857496c73
Signed-off-by: Isaku Yamahata <isaku.yamahata@intel.com>
(cherry picked from commit a18e3f5a3744392c4475c82e4937af2a27d729fa)

Bug 4917  For fixing SG dangling flows. Extended port cache logic to
TenantNetworkManagerImpl and SouthboundHandler.

Added cache for NeutronNetwork. Changed the portcLeanUpCache from set to
map as the entries were not getting cleaned up from the cache.

Change-Id: Id02f2ff85d3d67845d8b618fbcdfded1f7958553
Signed-off-by: Aswin Suryanarayanan <aswin.suryanarayanan@hp.com>
(cherry picked from commit c619afb3a9f8d93b05225daf0b257c28079d4216)

BUG 5164 Cleanup Floating IP Rules when VM is deleted.

Patch set 3: Address review comments.

Patch set 2: Fixed unit test.

When a VM is deleted, Neutron does not send a notification
to update/delete any floatingip that may have been associated
with a port. As a result, openflow rules for the floating ip
are left installed.

Neutron team says this is expected behavior for floating ip.
So, to cleanup, use neutron port delete event, and find
any associated floating ip, and cleanup installed OF
rules.

Change-Id: If9e2ffc5b16f0da636b3e9b6b1c4fbfd46fd6aff
Signed-off-by: Victor Pickard <vpickard@redhat.com>

Clean up SouthboundMapper (and fix createQosType())

SouthboundMapper has a few unused imports and one unused method; this
patch removes them.

It also fixes the default QoS type returned by createQosType().

Change-Id: Ic664ee98b9c4f99d8c28b1b1071837c352e63f81
Signed-off-by: Stephen Kitt <skitt@redhat.com>

Bug-5040 : LLDP Spoofing attack warning when using Openstack with ODL Cluster

Change-Id: Ife9fa1bd8fcd02ca4af67c71d2d3429f6477310f
Signed-off-by: Anil Vishnoi <vishnoianil@gmail.com>

OVSDB Qos and Queue - Postman examples

Adds a Postman collection of RESTCONF commands for doing
CRUD operations with Qos and Queue entries.

v2 - remove tabs
v3 - remove tabs in right file

Change-Id: I8e98b2f9b5c6e517a5a60516fe21fce063e169e2
Signed-off-by: Eric Multanen <eric.w.multanen@intel.com>

Bug 4996 - Wrong flows when using SFC coexistence

Signed-off-by: Sam Hague <shague@redhat.com>
(cherry picked from commit e0bf1166f4ad2515859ab43080a28115975a2cf5)

Change-Id: I0874c752f8777d8a3f6a7f8f60db22c605c986a3
Signed-off-by: Sam Hague <shague@redhat.com>

Bug 4996 - Wrong flows when using SFC coexistence

Signed-off-by: Sam Hague <shague@redhat.com>
(cherry picked from commit 498fe4df2997839fdf12555eb5961008ce9eab1a)

Change-Id: Ibf950ae9b56317441014497ffd4260580326d802
Signed-off-by: Sam Hague <shague@redhat.com>

Merge "Fix for changes to neutron-l3.yang"

Merge "BUG-5006: rework tests using AbstractDataBrokerTest"

Merge "Use constants for NeutronSecurityRule"

Fix for changes to neutron-l3.yang

Fix for BUG5137 in neutron breaks any code using routes option of
NeutronRouter. This fix is to change type of routes from String to Routes
as per yang changes.

Change-Id: I89866b31003a8b384c45ef9b451c5d189961df60
Signed-off-by: Vishal Thapar <vishal.thapar@ericsson.com>
(cherry picked from commit 61b1b633dfcd9fc1080286ef32d5683e41dff5a5)

Fixes Bug 5187
remote security group will continue the addition/deletion of rules after
logging if not found in cache.

Change-Id: Ic6129b0e8884a185e0907789de66a5df3eee39c0
Signed-off-by: Aswin Suryanarayanan <aswin.suryanarayanan@hp.com>

BUG-5006: rework tests using AbstractDataBrokerTest

Change-Id: I5d7acd00cfc71291e622bd79dc850a24be63f084
Signed-off-by: Stephen Kitt <skitt@redhat.com>

BUG 5172: Handle SchemaVersionMismatchException for lldp column

Change-Id: I3014048642b298bdb347660c3ac0704c23996e22
Signed-off-by: Rashmi Pujar <rpujar@inocybe.com>

Use constants for NeutronSecurityRule

This patch introduces constants for the directions, protocols and
ethertypes in NeutronSecurityRule.

There's also a bunch of small clean-ups in the affected classes.

Change-Id: Ia07efa48eb431f560d9f1f947170e1fb68e24ddb
Signed-off-by: Stephen Kitt <skitt@redhat.com>

BUG-4892:fixed Not getting Arp flows if there is no Router

  *Moved the ARP handling part to a new file, This way the
   ARP Entries are not restricted to l3 operations only.
  *Tested L2 and L3 operations.

From our understanding

In router scenario whenever router created using openstack, netvirt
south bound handler will receive interface update event. ARP responder
will program the arp rules for the router interface event through
distributed arp service class.
(openstack àrouter create àsouthbound handleràprocess event àprocess interface updateàARP handleinterface eventàprogram ARP)

In normal L2 scenario whenever tenant network created using openstack,
netvirt  will receive neutron port add event distributed arp service
class use this neutron port details to program arp rules for the DHCP IP.

Whenever VM instance created using openstack, netvirt will receive
neutron port event distributed arp service class use this neutron port
details to program arp rules for particular VM IP.

 (openstackàVM instance à port handleràprocess eventà do neutronport(ADD/UPDATE/DELETE) à handle port àprogram ARP)

Change-Id: Ie56bd5d407f501b8a82f9fe3ad0672e57448eeef
Signed-off-by: hari.pr <hari.pr@hcl.com>

Merge "BUG-5110 Enable pinging any router"

Merge "Bug 5149: Support LLDP on ovsdb interface"

Bug 5149: Support LLDP on ovsdb interface

Change-Id: I9b61d2e149479ae95f6978ae04e4f4e3e2a6df53
Signed-off-by: Rashmi Pujar <rpujar@inocybe.com>

BUG-5110 Enable pinging any router

Works like this:
In table 60, routed packets have their src MACs
saved to reg4 and reg5

In table 70:
ICMP echos are responded to, for routed packets
and for pings to routers on the same LAN

Change-Id: I23e3a6ef5397aa687e14745841efeccc3f7a5301
Signed-off-by: Josh <jhershbe@redhat.com>

Merge "Add IPv6 SecurityGroup tests."

Add IPv6 SecurityGroup tests.

This patch also includes fix for Bug-5134: Address exceptions when SG
remote_group_id has both IPv4 and IPv6 addresses.

Change-Id: I25855fa0bd5fe1938efb68a459982d790f4bdb27
Signed-off-by: Sridhar Gaddam <sgaddam@redhat.com>

Bug 4996 - Wrong flows when using SFC coexistence

Signed-off-by: Sam Hague <shague@redhat.com>
(cherry picked from commit d0a7d318ebf445da858aee508b477d0584977fa6)

Change-Id: I6c54b206cd9653868d16f1799ff21891af6333da
Signed-off-by: Sam Hague <shague@redhat.com>

Bug 5147 - Wrong logging level for ConfigProperties not found with defaults

Change-Id: Ib53ef62942c4248fc258d752aea5f570447312c3
Signed-off-by: Sam Hague <shague@redhat.com>

Bug 4996 - Wrong flows when using SFC coexistence

Signed-off-by: Sam Hague <shague@redhat.com>
(cherry picked from commit f00b01e77a14b1ad53b6553296499c9d30365808)

Change-Id: I25fd28e89f78fb101c1e187d0ce06eba02567dfb
Signed-off-by: Sam Hague <shague@redhat.com>

Unit tests for OVSDB clustering

Added some unit tests to OVSDB Clustering work done
during 'Be'.

V2: Removed unit test for deleteNode as this method was unused.

Change-Id: Icd18b87cd472d06317a5a7368acfc19c66f1cef4
Signed-off-by: Sharad Mishra <sharad.d.mishra@intel.com>

Merge "[Bug 5131]- Hard-coded base url in Ovsdb-ui"

Merge "BUG-4794: use the transaction invoker for hwvtep"

Merge "BUG-2625: remove unneeded equinox dependencies"

Merge "Remove SouthboundUtil::deleteNode()"

[Bug 5131]- Hard-coded base url in Ovsdb-ui

- Localhost is hard-coded in Northbond handler, so make it dynamic.
- Use a empty gif has logo so you won't see a broken image and 404 error
  log

Change-Id: Ie30c15b8e818ccec2038908af5ffb02a2b595a7a
Signed-off-by: Maxime Millette-Coulombe <mmcoulombe@inocybe.com>

BUG-4794: use the transaction invoker for hwvtep

HwvtepConnectionManager can delete a connection without going through
the transaction invoker. This patch fixes this and removes the
now-obsolete deleteNode method from HwvtepSouthboundUtil.

Change-Id: I623016599a7de2cc7e6edf72865e10af452f3a8b
Signed-off-by: Stephen Kitt <skitt@redhat.com>

BUG-2625: remove unneeded equinox dependencies

These dependecies are not needed, remove them.

Change-Id: I4dccd9c3e080047b8d958e201ddf0cc84c78f2a6
Signed-off-by: Robert Varga <rovarga@cisco.com>

Fix generics for JDK 8

Change-Id: I473fcee5429f9b7736b175ed4633cc9d7dafded2
Signed-off-by: Stephen Kitt <skitt@redhat.com>

Remove SouthboundUtil::deleteNode()

This method is unused and, since it doesn't use the transaction
invoker, potentially dangerous.

Change-Id: Ibbc674a5983d8e52094888a58eb6c7382daac467
Signed-off-by: Stephen Kitt <skitt@redhat.com>

Bug-5069 Disable ovs in-band mode: cosmetics remove redundant line

Change-Id: Ibdf949f1aeff25fe4f69d5fe7f04bcabb7392c68
Signed-off-by: Flavio Fernandes <ffernand@redhat.com>

Boron: remove dependencies for neutron::dummyprovider

Now that neutron northbound project is no longer
requiring a neutron provider to exist [1], there is no
need to depend on that dummy feature. :)

[1]: https://git.opendaylight.org/gerrit/#/c/27291

Change-Id: Iedbb7253183f1830b64a2aa6ff0c5c5f498135f8
Signed-off-by: Flavio Fernandes <ffernand@redhat.com>

BUG-4794: use the transaction invoker to queue the clean-up

When a manager disconnection comes in, an OvsdbRemoveNodeCommand is
queued in the transaction invoker to remove the corresponding nodes.
If an ownership change is detected, an "emergency" clean-up is
executed, but without going through the transaction invoker; it's
executed using the MD-SAL data broker directly. Both of these
operations try to protect themselves by checking the presence of
appropriate nodes before running; but in some cases we see
manager-node-entry list item deletions being attempted on a deleted
manager-node-entry list, which causes a crash.

To avoid the race which leads to these crashes, this patch queues the
emergency clean-up with the transaction invoker, ensuring that the
operations will be serialised with any other clean-ups. In this way
the protection checks will be effective and avoid deleting items from
no-longer-existent lists.

Change-Id: Ia4ff31677e61d897720ce3209d6da7eed5e5ee8d
Signed-off-by: Stephen Kitt <skitt@redhat.com>

Merge "Bug 5008 - QoS and Queue fixes for ovsdb southbound"

Fixes Bug 4643
The fix for the bug 4205 is extented to instances where neutron
port cache is used.

Change-Id: I5e3e90f2e3335e65dca29112a551ccd053823f53
Signed-off-by: Aswin Suryanarayanan <aswin.suryanarayanan@hp.com>

Fixes Bug 4769
The fix for the bug 4205 is extented to other instances where neutron
port cache is used.

Change-Id: Ic69142c1804a37725a9dc9c611d583302284d18c
Signed-off-by: Aswin Suryanarayanan <aswin.suryanarayanan@hp.com>

Bug 5066 - ConflictingModificationAppliedException: Node was created by other transaction.

Signed-off-by: Sam Hague <shague@redhat.com>
(cherry picked from commit ef9d4d8fdd25d26d8d13b9d69e269a2e4becbbd6)

Change-Id: I175b007213908abd41f7a1168ad160fc86d337e9
Signed-off-by: Sam Hague <shague@redhat.com>

Bug 5008 - QoS and Queue fixes for ovsdb southbound

Update the operational MD-SAL for Queue and Qos updates from the OVS
host.

Support configuration of QoS and Queue via configuration MD-SAL.

- Support for adding and deleting QoS entries.  A qos-id is used
  as a handle for qos entries in the MD-SAL.  This is added to
  the 'external-ids' of the qos entry.  Qos entries originating
  from the OVS host are assigned a qos-id of "qos://<uuid>".
- Qos entries can be assigned to a Port (termination point)
  which is present in the MD-SAL by setting the port qos
  attribute to the UUID of the relevant Qos entry.
- Qos entries are cleared from a port by updating the
  port configuration with the qos attribute removed.
- Support for adding and deleting Queue entries. a queue-id
  is used as a handle for queue entries in the MD-SAL.  This
  is added to the 'external-ids' of the queue entry.  Queue
  entries originating from the OVS host are assign a qos-id
  of "queue://<uuid>".
- Queue entries can be added or deleted to the queue list
  of a Qos entry present in the config by filling out (or
  removing from) the queue-list attribute of the qos entry.

v2 - added setting of exising qos uuid to an existing port
   - added clearing of a qos setting for a port
v3 - ovsdb.yang whitespace fixes
   - fixes for failed tests
v4 - fixed model - queue list in Qos entries needed
     a queuenumber key value
   - fixed up comments on whitespace and log messages
v5 - finished set/clear of queues list in a qos entry
   - added more description about the functionality in
     the patch set.
v6 - fixed up more whitespace, and copyright comments.
v7 - address review comments:
     - white space
     - remove unnecessary code
     - remove commented out code
     - adjust some LOG levels
     - remove unused imports

Change-Id: Idec02aaa82e1ffa66e58862ecfc5edff05050444
Signed-off-by: Eric Multanen <eric.w.multanen@intel.com>

Merge "SouthboundIT: make "value mandatory" a builder property"

Merge "IPv6 support in Security Groups."

Merge "Fixed UT and cleaned up code.   1. Fixed the UT issues in IngressAclServiceTest and EgressAclServiceTest.   2. Cleaned up unused method and UT in IngressAclService and EgressAclService."

SouthboundIT: make "value mandatory" a builder property

Instead of coding explicit instanceof tests, turn the mandatory nature
of the value into a builder property.

Reset the builders immediately after use.

Change-Id: I5fc20a17ff903cb01a0b8c091300c099c84ab3e4
Signed-off-by: Stephen Kitt <skitt@redhat.com>

Re-enable net-virt-sfc

Change-Id: Id54c96b226b832db5d91987fce8d549a35ad228a
Signed-off-by: Thanh Ha <thanh.ha@linuxfoundation.org>

Bump yangtools to 1.0.0-SNAPSHOT

Change-Id: I1c28f5240c202bc8d79e0c0ecd3ae84e7582c00b
Signed-off-by: Thanh Ha <thanh.ha@linuxfoundation.org>

Fixed UT and cleaned up code.
  1. Fixed the UT issues in IngressAclServiceTest and
EgressAclServiceTest.
  2. Cleaned up unused method and UT in IngressAclService and
EgressAclService.

Change-Id: I8632eb28ae292ea7a50968291cf9f6bdfc92fdaf
Signed-off-by: Aswin Suryanarayanan <aswin.suryanarayanan@hp.com>

IPv6 support in Security Groups.

This patch implements IPv6 support for Security Groups in OVSDB
Net-virt.
Pending: Test cases will be added in a subsequent patch.

Change-Id: If692c9b205af87517d69cbcc9f8c1be4decc917e
Signed-off-by: Sridhar Gaddam <sgaddam@redhat.com>

BUG-5013 Fix check logic in MatchUtils.createICMPv4Match

The original logic checked that *either* of the
input params was non-null instead of checking
each.

Change-Id: I941133c00b09335eb0cf4a48b9abf35d8b305438
Signed-off-by: Josh <jhershbe@redhat.com>

Merge "Bug 5007 - Reenable SG IT"

Merge "BUG-5006: Rework testEnqueueEvent to avoid private methods"

Merge "BUG-5006: Reduce usage of PowerMock"

Bug 5007 - Reenable SG IT

Change-Id: I5526fcc356b58484613d9dfcbfa453d66c0e354a
Signed-off-by: raveek <raveek@hp.com>

BUG-5006: Rework testEnqueueEvent to avoid private methods

Instead of checking calls to dispatchEvent(), provision an event
handler and use that to make sure the queue is processed. Stop the
event processing thread to avoid races in the assertions.

Change-Id: Ic385314e15dead0c1f796c25863136a3a60099ac
Signed-off-by: Stephen Kitt <skitt@redhat.com>

BUG-5006: Reduce usage of PowerMock

Make ServiceHelper and ConfigProperties overridable; this allows most
of the tests using PowerMock to switch to plain Mockito.

Change-Id: I50c5c64f687fb0b0aa73194fb3d6266951eedb23
Signed-off-by: Stephen Kitt <skitt@redhat.com>

Merge "Bug 4996 - Wrong flows when using SFC coexistence"

Bug 4997 - Fix for ConnectionInfo parsing in showMdsal tool

Change-Id: If3fee23373829c520fcc532ba70b1a45061aa2b3
Signed-off-by: Sam Hague <shague@redhat.com>

Bug 4996 - Wrong flows when using SFC coexistence

Change-Id: Icb9cab27b271f0e5462ecb87ead7a10f0f083bd1
Signed-off-by: Sam Hague <shague@redhat.com>

Merge "BUG-4205 : VM delete doesnot remove all related flows"

Merge "Fixes an issue in induvidual security rule update, when remote SG is selected."

BUG-4205 : VM delete doesnot remove all related flows

Patch set 3: Rebase and add ref to bug 4971
Patch set 5: Rebase again and move processSecurityGroupUpdate()

Change-Id: Ia3cbba3087232cb56eee6e5424cdd011a01ce266
Signed-off-by: bviswa <badrinath_viswanatha@dell.com>
Signed-off-by: Flavio Fernandes <ffernand@redhat.com>

Bump versions by 0.1.0 for next dev cycle

Change-Id: I647f1e840b4d4bc587f6cbce4018ed187922a7a0
Signed-off-by: Thanh Ha <thanh.ha@linuxfoundation.org>

Fixes an issue in induvidual security rule update, when remote SG is
selected.

Change-Id: Id8d5ea6c6235c31f9147556244f619a15a279382
Signed-off-by: Aswin Suryanarayanan <aswin.suryanarayanan@hp.com>

Merge "Add support for bfd-status for monitoring"

Merge "Workaround for failing Netvirt SG IT"

Workaround for failing Netvirt SG IT

Change-Id: I2e9ed58680ebefb6ceed912af5518b5eb543da7d
Signed-off-by: Sam Hague <shague@redhat.com>

Added cluster aware mdsal utils class to net-virt (redo)

Looks like while code cleanup we removed the MdsalUtils.java from the master branch
and while merging master branch to net-virt-clustering, it got removed as well.
Net-virt-clustering had a modified version of MdsalUtils.java, where put/merge/delete
transactions are only done by the master instances of net-virt. ClusterAwareMdsalUtils
class bring those changes back.

Patch set 2: Explicitly callback into OvsdbInventoryService when netVirt becomes owner.
Patch set 3: Undo patch set 2; make ProviderEntityListener to happen earlier

Change-Id: I42ab5f2969bcff7737d90f2651d2762897e74c9a
Signed-off-by: Anil Vishnoi <vishnoianil@gmail.com>
Signed-off-by: Flavio Fernandes <ffernand@redhat.com>

Merge "Revert "Added cluster aware mdsal utils class to net-virt.""

Revert "Added cluster aware mdsal utils class to net-virt."

This reverts commit e9ec56b353a2d9098e77d623b7c756069bb58cb9.

This causes a regression in that netvirt:1 is never written to mdsal. to be re-visited.

Change-Id: I683dcac86c23445762d460183fa3e651a600f2c2
Signed-off-by: Flavio Fernandes <ffernand@redhat.com>

Merge "Drop testRegisterNewInterface() entirely"

Add support for bfd-status for monitoring

bfd-status gives information about current state of tunnels. This required
to monitor tunnels and know when they go up/down.

Change-Id: I5d864d46adf1444b00382acef58e298df5dc155e
Signed-off-by: Vishal Thapar <vishal.thapar@ericsson.com>

Drop testRegisterNewInterface() entirely

This test requires a bundle context to work properly, so it's not
really doable in a unit test.

Change-Id: I29a5a74597146dc3342c6fe7906a28fe89d6d22a
Signed-off-by: Stephen Kitt <skitt@redhat.com>