bgpcep.git
6 years agoBGPCEP-710: Create Network Topology Loader 12/65712/11
Claudio D. Gasparini [Wed, 15 Nov 2017 15:18:45 +0000 (16:18 +0100)]
BGPCEP-710: Create Network Topology Loader

- Rework config loader
- Rename config-file examples
- Create config file example for pcep
- Dont use deployer for config loaders,
  use DS straight
- Remove no longer required Deployer interfaces

Change-Id: Id9beea9f321c01061fc65923b6a4838be30d7bb0
Signed-off-by: Claudio D. Gasparini <claudio.gasparini@pantheon.tech>
6 years agoBGPCEP-580: Implement PCEP stats DS rendering 37/65537/10
Claudio D. Gasparini [Wed, 29 Nov 2017 09:46:02 +0000 (10:46 +0100)]
BGPCEP-580: Implement PCEP stats DS rendering

- create Pcep Topology stats models
- create new PCEP State interfaces
- augment network pcep topology
with pcep session state
- implement PCEP Stats Registry for register
Node Stats and store stats udner DS

Change-Id: Ib33a05c7e3fcb9ef7c485bed7a33e543ed6c7d14
Signed-off-by: Claudio D. Gasparini <claudio.gasparini@pantheon.tech>
6 years agoRename bgp release-session rpc 05/66005/2
Claudio D. Gasparini [Tue, 28 Nov 2017 13:34:12 +0000 (14:34 +0100)]
Rename bgp release-session rpc

for a more proper name based on what
actually do.

Change-Id: Ib4d14e9f5642710c62bff08dcedf2474be77016c
Signed-off-by: Claudio D. Gasparini <claudio.gasparini@pantheon.tech>
6 years agoBGPCEP-704: Rework Pcep teardown session rpc 07/66007/1
Claudio D. Gasparini [Tue, 28 Nov 2017 13:54:09 +0000 (14:54 +0100)]
BGPCEP-704: Rework Pcep teardown session rpc

return void RpcResult instead future void

Change-Id: I2813f84d8bc03b47539f489b769921c7b04b1e84
Signed-off-by: Claudio D. Gasparini <claudio.gasparini@pantheon.tech>
6 years agoBGPCEP-704: Rework Deployer 02/66002/1
Claudio D. Gasparini [Tue, 28 Nov 2017 12:39:28 +0000 (13:39 +0100)]
BGPCEP-704: Rework Deployer

- Filter Pcep Network Topologies

Change-Id: Icafdfe5c06251ad740ee2d44b931459a9d93af1c
Signed-off-by: Claudio D. Gasparini <claudio.gasparini@pantheon.tech>
6 years agoBGPCEP-704: Add restart session rpc 97/65997/3
Claudio D. Gasparini [Fri, 24 Nov 2017 11:55:03 +0000 (12:55 +0100)]
BGPCEP-704: Add restart session rpc

as a replacement for Css rpc removed

Change-Id: If5e6e08c9a673289cf44c519d675dcb9626c45bc
Signed-off-by: Claudio D. Gasparini <claudio.gasparini@pantheon.tech>
6 years agoBGPCEP-704: Update Topology Deployer 48/65848/4
Claudio D. Gasparini [Fri, 10 Nov 2017 11:21:59 +0000 (12:21 +0100)]
BGPCEP-704: Update Topology Deployer

Deploy topology based on network topology
config, and remove CSS Config.

Change-Id: Ifb90294e7a69869ef4c357e0124bcf2a5cb96d00
Signed-off-by: Claudio D. Gasparini <claudio.gasparini@pantheon.tech>
6 years agoBGPCEP-704: PCEP Config models 02/65402/7
Claudio D. Gasparini [Fri, 10 Nov 2017 07:39:44 +0000 (08:39 +0100)]
BGPCEP-704: PCEP Config models

Create PCEP models config as a replacement for
deprecated CSS Config

Change-Id: I2328345ea8440edd2aae66b596807753da483f1b
Signed-off-by: Claudio D. Gasparini <claudio.gasparini@pantheon.tech>
6 years agoBGPCEP-685: Remove Path selection Css config 52/65952/2
Claudio D. Gasparini [Mon, 20 Nov 2017 12:39:21 +0000 (13:39 +0100)]
BGPCEP-685: Remove Path selection Css config

no longer required models and files

Change-Id: I0b588d2e19aa8df9c272fcd6cc00cabdfd82e1cf
Signed-off-by: Claudio D. Gasparini <claudio.gasparini@pantheon.tech>
6 years agoBGPCEP-704: Remove PCEP Dispatcher CSS modules 01/65401/3
Claudio D. Gasparini [Fri, 10 Nov 2017 07:46:30 +0000 (08:46 +0100)]
BGPCEP-704: Remove PCEP Dispatcher CSS modules

Remove deprecated and no longer required PCEP
Dipatcher CSS models

Change-Id: Iaa3734c6b1e6a9847f4d3f44c9e15759cea2590f
Signed-off-by: Claudio D. Gasparini <claudio.gasparini@pantheon.tech>
6 years agoBGPCEP-704: Rework Programming 60/65360/5
Claudio D. Gasparini [Thu, 9 Nov 2017 10:21:35 +0000 (11:21 +0100)]
BGPCEP-704: Rework Programming

- Remove Programming CSS Configuration
- remove css config models
- Introduce a Factory service for InstructionSchedulers
- enforce checkstyle

Change-Id: I48bbaaa6a764e9ac46859dd482f4fe05c7e6d0c1
Signed-off-by: Claudio D. Gasparini <claudio.gasparini@pantheon.tech>
6 years agoBGPCEP-704: Remove PCEP/Programming Controller 99/65399/5
Claudio D. Gasparini [Fri, 10 Nov 2017 07:22:00 +0000 (08:22 +0100)]
BGPCEP-704: Remove PCEP/Programming Controller

config files

Change-Id: I7c697d7f84009c7d5a84ffddf87372140b9e7ba0
Signed-off-by: Claudio D. Gasparini <claudio.gasparini@pantheon.tech>
6 years agoFix odlparent reference 67/65867/1
Robert Varga [Thu, 23 Nov 2017 13:41:11 +0000 (14:41 +0100)]
Fix odlparent reference

The reference should point to 2.0.5, not 1.9.0.

Change-Id: I739d260b1509ce981b803a7a0b7e087a55f97159
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
6 years agoBGPCEP-717: Add logback config file 42/65542/2
Claudio D. Gasparini [Wed, 15 Nov 2017 12:20:56 +0000 (13:20 +0100)]
BGPCEP-717: Add logback config file

 for reduce log level of yang parser.
As a result we reduce 1G output to
only 12M

- set debug loglevel for test

Change-Id: If9265b0a025d2171fbe5578d527abf89c0b0af60
Signed-off-by: Claudio D. Gasparini <claudio.gasparini@pantheon.tech>
6 years agoBGPCEP-709: Operational OpenConfig BGP RIB output is not seen for all controllers... 72/64772/9
Ajay Lele [Thu, 26 Oct 2017 19:04:59 +0000 (12:04 -0700)]
BGPCEP-709: Operational OpenConfig BGP RIB output is not seen for all controllers in the 3 node cluster

- StateProviderImpl uses clustering singleton service to run only 1 instance in cluster.
  Problem is that if BGP speaker needs to be kept separate across the cluster nodes
  e.g. for scalability issues (creating separate shard for bgp rib and openconfig module and
  disabling replication for them), since the singleton service name is same across
  the nodes, only 1 instance of the service runs and so operational data is available
  only on that node.
- This PR changes this to run operational data collection/update service on all nodes,
  but perform the activity only for rib and peer that are active on that node.
- Updated unit-tests.

Change-Id: I7284b249b8ec68b4c6905a92bbb221816d196cae
Signed-off-by: Ajay Lele <ajayslele@gmail.com>
6 years agoBGPCEP-704: Remove integration test 78/65478/1
Claudio D. Gasparini [Fri, 10 Nov 2017 17:07:19 +0000 (18:07 +0100)]
BGPCEP-704: Remove integration test

already covered by tests under PCEP

Change-Id: I7227106d63645efd0699573752e4abe688bea070
Signed-off-by: Claudio D. Gasparini <claudio.gasparini@pantheon.tech>
6 years agoBGPCEP-718: Hide InterruptedException 70/65470/2
Claudio D. Gasparini [Sun, 12 Nov 2017 18:45:35 +0000 (19:45 +0100)]
BGPCEP-718: Hide InterruptedException

coming from closing thread, when closing module.
Avoiding confuse message.

Change-Id: Ica45c84b33f5d3b30ea3f61e5b76cf01bad5c03d
Signed-off-by: Claudio D. Gasparini <claudio.gasparini@pantheon.tech>
6 years agoBGPCEP-717: Add logback config file 67/65467/2
Claudio D. Gasparini [Sat, 11 Nov 2017 18:54:35 +0000 (19:54 +0100)]
BGPCEP-717: Add logback config file

 for reduce log level of yang parser.
As a result we reduce 1G output to
only 12M

- set debug loglevel for test
- set info loglevel for yang parser

Change-Id: I29f4480d2bc9e27bb77be4cdb18d621f06d40bcb
Signed-off-by: Claudio D. Gasparini <claudio.gasparini@pantheon.tech>
6 years agoRemove PCEPDipatcher deprecated method 59/65359/1
Claudio D. Gasparini [Thu, 9 Nov 2017 10:34:07 +0000 (11:34 +0100)]
Remove PCEPDipatcher deprecated method

Change-Id: Ie2aa3b0734372b2dd1c5d37c0dc7f34866d8911a
Signed-off-by: Claudio D. Gasparini <claudio.gasparini@pantheon.tech>
6 years agoEnforce BMP SPI/ API Checkstyle 08/65308/2
Claudio D. Gasparini [Wed, 8 Nov 2017 11:40:43 +0000 (12:40 +0100)]
Enforce BMP SPI/ API Checkstyle

Change-Id: I4cbbc75a30362967bca4a7edcd0001ef32dc8536
Signed-off-by: Claudio D. Gasparini <claudio.gasparini@pantheon.tech>
6 years agoBGPCEP-685: Remove rib config css models 09/65309/1
Claudio D. Gasparini [Tue, 7 Nov 2017 16:00:43 +0000 (17:00 +0100)]
BGPCEP-685: Remove rib config css models

Change-Id: I91f4e4633fbbacbdf4b61bca11310534d77e129c
Signed-off-by: Claudio D. Gasparini <claudio.gasparini@pantheon.tech>
6 years agoRemove deprecated methods under BMP API 62/65262/2
Claudio D. Gasparini [Tue, 7 Nov 2017 10:31:58 +0000 (11:31 +0100)]
Remove deprecated methods under BMP API

Change-Id: I6ffe7f210331f08539a260cb0871be77b7f1ec8a
Signed-off-by: Claudio D. Gasparini <claudio.gasparini@pantheon.tech>
6 years agoBGPCEP-711: BMP test tool clustering support 61/65261/2
Claudio D. Gasparini [Tue, 7 Nov 2017 10:28:57 +0000 (11:28 +0100)]
BGPCEP-711: BMP test tool clustering support

Make test tool able to connect to multiple nodes

Change-Id: Ic0011095140e7a31e598bc475f66713c85ed3038
Signed-off-by: Claudio D. Gasparini <claudio.gasparini@pantheon.tech>
6 years agoSplit artifacts in multiple artifacts 23/65223/3
Claudio D. Gasparini [Mon, 6 Nov 2017 17:23:33 +0000 (18:23 +0100)]
Split artifacts in multiple artifacts

Change-Id: Ib90ecdde2568738a2066c88e01af27ac2eea231b
Signed-off-by: Claudio D. Gasparini <claudio.gasparini@pantheon.tech>
6 years agoRemove dulicated module 18/65218/5
Claudio D. Gasparini [Mon, 6 Nov 2017 16:23:17 +0000 (17:23 +0100)]
Remove dulicated module

Change-Id: I43c941e38b391ed34cb236742e2e74b42fa649d7
Signed-off-by: Claudio D. Gasparini <claudio.gasparini@pantheon.tech>
6 years agoBGPCEP-688: Add odl-bgpcep-bmp-config-example 52/65252/1
Claudio D. Gasparini [Tue, 7 Nov 2017 10:05:43 +0000 (11:05 +0100)]
BGPCEP-688: Add odl-bgpcep-bmp-config-example

to features-bmp

Change-Id: I6d49057747ea80a66dbee4e3fb9ce100ea4e4008
Signed-off-by: Claudio D. Gasparini <claudio.gasparini@pantheon.tech>
6 years agomove bmp to bmp aggregator 22/65222/2
Claudio D. Gasparini [Mon, 6 Nov 2017 13:07:27 +0000 (14:07 +0100)]
move bmp to bmp aggregator

Change-Id: I78ac37a18987378ce066effbff0972ee9e04c8c9
Signed-off-by: Claudio D. Gasparini <claudio.gasparini@pantheon.tech>
6 years agoBGPCEP-706: Fix BGP Flowspec NumbericOphrand 46/64746/8
Kevin Wang [Mon, 23 Oct 2017 21:05:27 +0000 (14:05 -0700)]
BGPCEP-706: Fix BGP Flowspec NumbericOphrand

Right now when serializing a NumbericOphrand, the "end-of-list"
bit is not properly set. The last entry in the ophrand list
should have this bit set according to RFC [1]. Otherwise the packet
will be in malformed format.
This patch fix BGP flowspec NumbericOphrand to set the "end-of-list"
field properly. When the serialization happens, the end-of-list
field will be set in runtime.

[1] https://tools.ietf.org/html/rfc5575

Change-Id: Ib8841360b47137dc0ec0f54c3ef156a298ba3c81
Signed-off-by: Kevin Wang <kevixw@gmail.com>
6 years agoBGPCEP-685: Remove BGP Config subsystem models 30/65030/2
Claudio D. Gasparini [Wed, 25 Oct 2017 06:57:28 +0000 (08:57 +0200)]
BGPCEP-685: Remove BGP Config subsystem models

Change-Id: I1d66738f637882eb1aadbbd9f94a4e1fd65d795a
Signed-off-by: Claudio D. Gasparini <claudio.gasparini@pantheon.tech>
6 years agoBGPCEP-701: Remove old statistics, keep only openconfig stats 29/65029/2
Claudio D. Gasparini [Mon, 23 Oct 2017 16:07:20 +0000 (18:07 +0200)]
BGPCEP-701: Remove old statistics, keep only openconfig stats

Change-Id: I729d20bc958396c70c761e9d40097a69850b4872
Signed-off-by: Claudio D. Gasparini <claudio.gasparini@pantheon.tech>
6 years agoBGPCEP-685: Add Peer Release session rpc 28/65028/3
Claudio D. Gasparini [Fri, 27 Oct 2017 12:45:46 +0000 (14:45 +0200)]
BGPCEP-685: Add Peer Release session rpc

old reset session rpc has been removed by
removal of cfg models. Therefore create a new
rpc providing the same service.
Change-Id: If17936e78642b5718126e79b6c197209af5ed268
Signed-off-by: Claudio D. Gasparini <claudio.gasparini@pantheon.tech>
6 years agoBGPCEP-702: Migrate Cli to Operational State 27/65027/3
Claudio D. Gasparini [Fri, 20 Oct 2017 08:29:25 +0000 (10:29 +0200)]
BGPCEP-702: Migrate Cli to Operational State

Old bgp stats are being removed, therefore
we use new operational state stats for cli
- Enforce checkstyle

Change-Id: Iabe50a392db7eacb70b0533c65ecee7e683aba4c
Signed-off-by: Claudio D. Gasparini <claudio.gasparini@pantheon.tech>
6 years agoBGPCEP-685: Remove controller config 45/65045/5
Claudio D. Gasparini [Thu, 2 Nov 2017 10:55:03 +0000 (11:55 +0100)]
BGPCEP-685: Remove controller config

and create config example module

Change-Id: I247a0a5749fafeac053cb5ddab04edc5865f6c5b
Signed-off-by: Claudio D. Gasparini <claudio.gasparini@pantheon.tech>
6 years agoBGPCEP-704: Remove no longer required BMP CSS Config file 04/64404/9
Claudio D. Gasparini [Tue, 17 Oct 2017 13:56:42 +0000 (15:56 +0200)]
BGPCEP-704: Remove no longer required BMP CSS Config file

Change-Id: I9f906c90c1035c6256e9331101fe2542f53261c2
Signed-off-by: Claudio D. Gasparini <claudio.gasparini@pantheon.tech>
6 years agoBGPCEP-688: BMP Config Loader 03/64403/13
Claudio D. Gasparini [Tue, 17 Oct 2017 10:35:43 +0000 (12:35 +0200)]
BGPCEP-688: BMP Config Loader

- Create BMP Config file loader
- Remove no longer required CSS config files
- Create BMP Config file example

Change-Id: I1bbdac4fd9efb29ae541a00952db02ad16e6f5be
Signed-off-by: Claudio D. Gasparini <claudio.gasparini@pantheon.tech>
6 years agoBGPCEP-694: Dont install bgp example configuration by default 44/65044/3
Claudio D. Gasparini [Thu, 2 Nov 2017 10:40:25 +0000 (11:40 +0100)]
BGPCEP-694: Dont install bgp example configuration by default

Change-Id: I23327a9f82f0993f2e0f82eb3ffc64b0aedfd380
Signed-off-by: Claudio D. Gasparini <claudio.gasparini@pantheon.tech>
6 years agoBGPCEP-710: Config loader feature 45/64945/13
Claudio D. Gasparini [Mon, 30 Oct 2017 20:17:51 +0000 (21:17 +0100)]
BGPCEP-710: Config loader feature

-module bgp config loader can be reused for pcep.
Therefore we move to the top level, and we share it as
a new feature.
-Enforce checkstyle

Change-Id: I49058a9156841ec14eb8320738feb6503013f4ab
Signed-off-by: Claudio D. Gasparini <claudio.gasparini@pantheon.tech>
6 years agoReorder the modifiers to comply with the Java Language Specification 07/64407/7
Claudio D. Gasparini [Tue, 17 Oct 2017 14:22:53 +0000 (16:22 +0200)]
Reorder the modifiers to comply with the Java Language Specification

Change-Id: I0017515575a08271a3a1d6aeeedae3b6a072a9fb
Signed-off-by: Claudio D. Gasparini <claudio.gasparini@pantheon.tech>
6 years agoRemove deploy-site.xml 95/64895/2
Thanh Ha [Mon, 30 Oct 2017 20:53:42 +0000 (16:53 -0400)]
Remove deploy-site.xml

With the javadoc jobs now available to generate javadoc it is time to
remove the maven-sites and related files.

Change-Id: I27ab85cca6733c8ebe6a5a95c9c4b675789c9454
Signed-off-by: Thanh Ha <thanh.ha@linuxfoundation.org>
6 years agoUse bulk operation 83/64883/2
Claudio D. Gasparini [Sat, 28 Oct 2017 21:13:13 +0000 (23:13 +0200)]
Use bulk operation

Change-Id: Id8da3f1394551ec6c879bfab847fdd93fda3e0a1
Signed-off-by: Claudio D. Gasparini <claudio.gasparini@pantheon.tech>
6 years agoMigrate Jave 5 Stringbuffer 82/64882/2
Claudio D. Gasparini [Sat, 28 Oct 2017 20:50:01 +0000 (22:50 +0200)]
Migrate Jave 5 Stringbuffer

Change-Id: I57a2e07fa111dc6cf87d5920cf388169f4fe41e3
Signed-off-by: Claudio D. Gasparini <claudio.gasparini@pantheon.tech>
6 years agoRemove unnecesary boxing 81/64881/1
Claudio D. Gasparini [Sat, 28 Oct 2017 20:49:24 +0000 (22:49 +0200)]
Remove unnecesary boxing

Change-Id: I48a32e366ab320a31b868bb9af8e11014bf1aa12
Signed-off-by: Claudio D. Gasparini <claudio.gasparini@pantheon.tech>
6 years agoFix missing version for maven reports 80/64880/1
Claudio D. Gasparini [Sat, 28 Oct 2017 20:47:24 +0000 (22:47 +0200)]
Fix missing version for maven reports

Change-Id: I45f229b90731d22d1099d38c690b2e6bb8ad5763
Signed-off-by: Claudio D. Gasparini <claudio.gasparini@pantheon.tech>
6 years agoCreate pcep topology parent aggregator 15/64815/1
Claudio D. Gasparini [Wed, 25 Oct 2017 12:20:01 +0000 (14:20 +0200)]
Create pcep topology parent aggregator

Change-Id: I3fbf0eb152ba84da138881f1080eb7b65d15469c
Signed-off-by: Claudio D. Gasparini <claudio.gasparini@pantheon.tech>
6 years agoBUG-9079 Make PCEP session recoverable from exception 72/62472/14
Kevin Wang [Wed, 30 Aug 2017 22:46:39 +0000 (15:46 -0700)]
BUG-9079 Make PCEP session recoverable from exception

This patch makes PCEP session recoverable from any netty exception.
Whenever an exception happens, PCEP session will be closed. So it
will be at a clean state when the next session retry comes.

Change-Id: I38a983c44519fd5c12cb9cd0da09fa14c4177ac7
Signed-off-by: Kevin Wang <kevixw@gmail.com>
6 years agoBUG-9192 / BUG-9191 50/64250/10
Claudio D. Gasparini [Fri, 13 Oct 2017 13:01:30 +0000 (15:01 +0200)]
BUG-9192 / BUG-9191

Enforce that each bundle under bgp is part of exactly one
feature by introducing new topology-api and concepts features.

Change-Id: Ifc6898b7154ba3451f1af7cfeba638c90c3c7a31
Signed-off-by: Claudio D. Gasparini <claudio.gasparini@pantheon.tech>
6 years agoRemove table type deprecated model 80/62380/4
Claudio D. Gasparini [Sun, 27 Aug 2017 11:23:31 +0000 (13:23 +0200)]
Remove table type deprecated model

Change-Id: Ic08f591d2952a5cc839aac48677323edb1bca31d
Signed-off-by: Claudio D. Gasparini <claudio.gasparini@pantheon.tech>
6 years agoRemove addpathcapability deprecated model 79/62379/4
Claudio D. Gasparini [Sun, 27 Aug 2017 10:42:55 +0000 (12:42 +0200)]
Remove addpathcapability deprecated model

Change-Id: Ifd17ee8a8374c85fba978666295c0520ca5b7047
Signed-off-by: Claudio D. Gasparini <claudio.gasparini@pantheon.tech>
6 years agoRemove deprecated binding type / value models 78/62378/5
Claudio D. Gasparini [Sat, 26 Aug 2017 23:00:06 +0000 (01:00 +0200)]
Remove deprecated binding type / value models

Change-Id: I1afd5a57f34f8531574578ed007d7fcaf7ffd0d8
Signed-off-by: Claudio D. Gasparini <claudio.gasparini@pantheon.tech>
6 years agoBug 9205: NPE received while receiving BGP peers 65/63465/4
Ajay Lele [Fri, 22 Sep 2017 21:53:10 +0000 (14:53 -0700)]
Bug 9205: NPE received while receiving BGP peers

Change-Id: I05383a406b03e5dc460e5ae013da82280920981e
Signed-off-by: Ajay Lele <ajayslele@gmail.com>
Signed-off-by: Claudio D. Gasparini <claudio.gasparini@pantheon.tech>
6 years agoBUG-9218: eliminate duplicate bundles 66/64066/3
Robert Varga [Mon, 9 Oct 2017 12:31:14 +0000 (14:31 +0200)]
BUG-9218: eliminate duplicate bundles

Packaging api bundles in multiple features causes inefficiency
in Karaf4. Introduce org-bgpcep-{bmp,rsvp,bgp-parser}-api
features to hold them.

Change-Id: I6351c945bbf3e272187dcd875854bff40c9b4f11
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
6 years agoBUG-8929: NPE during singleton startup 70/62870/4
Yrineu Rodrigues [Thu, 7 Sep 2017 21:08:12 +0000 (18:08 -0300)]
BUG-8929: NPE during singleton startup

Avoid NPE when installing features 'odl-bgpcep-bgp-api' and
'odl-bgpcep-bgp-impl' individually

Change-Id: Id651dff7c813544bd07a03b435069de5e723721d
Signed-off-by: Yrineu Rodrigues <yrineu.rodrigues@serro.com>
6 years agoBUG-8987: Print Exception when Css registration fails 28/62628/3
Claudio D. Gasparini [Mon, 4 Sep 2017 11:02:48 +0000 (13:02 +0200)]
BUG-8987: Print Exception when Css registration fails

Change-Id: I34236ac8546358fe3c00985fbbf40f69aa0bef19
Signed-off-by: Claudio D. Gasparini <claudio.gasparini@pantheon.tech>
6 years agoBump odlparent 2.0.4 to 2.0.5 64/63664/2
Stephen Kitt [Wed, 27 Sep 2017 13:36:39 +0000 (15:36 +0200)]
Bump odlparent 2.0.4 to 2.0.5

Change-Id: I0764041e6638fb24bc73deba3d158c265669ed66
Signed-off-by: Stephen Kitt <skitt@redhat.com>
6 years agoBump bgpcep to use yangtools 1.2.0 23/63823/1
Anil Belur [Fri, 29 Sep 2017 02:34:21 +0000 (12:34 +1000)]
Bump bgpcep to use yangtools 1.2.0

Jira: releng-485

Change-Id: I322b6c2595c75b61a829a74dc5ebfdd12784f1c7
Signed-off-by: Anil Belur <abelur@linuxfoundation.org>
6 years agoremove RD and Distinguisher deprecated models 77/62377/2
Claudio D. Gasparini [Sat, 26 Aug 2017 22:07:27 +0000 (00:07 +0200)]
remove RD and Distinguisher deprecated models

Change-Id: I57d9073358b0284d9a7cef2463f05406a9653b24
Signed-off-by: Claudio D. Gasparini <claudio.gasparini@pantheon.tech>
6 years agoBUG-9141: Fix Stateful07TopologySessionListener failing test 60/62960/2
Claudio D. Gasparini [Mon, 11 Sep 2017 09:57:07 +0000 (11:57 +0200)]
BUG-9141: Fix Stateful07TopologySessionListener failing test

Some of the timers are rounding down, which is ending
on some statistics results in 0, when we have better
performance than expected.  Update the code to round up.

Use LongAdder instead of long for counters

Change-Id: I958f1c252ba94f8cd392979fe469555aee3f8d48
Signed-off-by: Claudio D. Gasparini <claudio.gasparini@pantheon.tech>
6 years agoMigrate if to switch statement 76/62376/2
Claudio D. Gasparini [Sat, 26 Aug 2017 22:04:16 +0000 (00:04 +0200)]
Migrate if to switch statement

Change-Id: Iacd0e96cd33884da88ce443f9a6f04e438996c7e
Signed-off-by: Claudio D. Gasparini <claudio.gasparini@pantheon.tech>
6 years agoMigrate iterables to java 8 75/62375/2
Claudio D. Gasparini [Sat, 26 Aug 2017 22:03:00 +0000 (00:03 +0200)]
Migrate iterables to java 8

Change-Id: I8cb6a37d1bc961c27b87b4fcb62ec93620288759
Signed-off-by: Claudio D. Gasparini <claudio.gasparini@pantheon.tech>
6 years agoremove unnecesary boxing / unboxing 16/62316/4
Claudio D. Gasparini [Fri, 25 Aug 2017 11:28:57 +0000 (13:28 +0200)]
remove unnecesary boxing / unboxing

Change-Id: Ia0600f1684cb122bd41b2b0bb056ac60f50593c6
Signed-off-by: Claudio D. Gasparini <claudio.gasparini@pantheon.tech>
6 years agoAdjust for mdsal-binding-dom-codec movement 16/62616/7
Robert Varga [Mon, 4 Sep 2017 11:52:35 +0000 (13:52 +0200)]
Adjust for mdsal-binding-dom-codec movement

The codec is moveing its package, adjust for that. Also migrate
to using mdsal infra instead of controller, where possible.

Change-Id: I89306996d0a80908176c2918c1bff5f04e7bcad8
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
Signed-off-by: Claudio D. Gasparini <claudio.gasparini@pantheon.tech>
6 years agoBUG-8987: check for null keys 49/62649/1
Robert Varga [Mon, 4 Sep 2017 16:02:56 +0000 (18:02 +0200)]
BUG-8987: check for null keys

Keys can be passed down as null, hence we need to check for this
happening.

Change-Id: I67018107b0925244f32b0cde6d8b53605594d521
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
6 years agoMigrate to using mdsal binding codec APIs 14/62614/1
Robert Varga [Mon, 4 Sep 2017 11:43:46 +0000 (13:43 +0200)]
Migrate to using mdsal binding codec APIs

yangtools.binding.codec is deprected, migrate away from it.

Change-Id: Id11820a63bed195cd71578c9b92c7b29a642a844
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
6 years agoRemove redundant cast 15/62315/3
Claudio D. Gasparini [Fri, 25 Aug 2017 10:09:58 +0000 (12:09 +0200)]
Remove redundant cast

Change-Id: I8bb65db4621c817df641e8ed5c3a63b57d4b3f9c
Signed-off-by: Claudio D. Gasparini <claudio.gasparini@pantheon.tech>
6 years agoRemove unnecesary imports 14/62314/3
Claudio D. Gasparini [Fri, 25 Aug 2017 10:00:31 +0000 (12:00 +0200)]
Remove unnecesary imports

Change-Id: Ib51f90fae97a00962ebe44989b8c134546fada96
Signed-off-by: Claudio D. Gasparini <claudio.gasparini@pantheon.tech>
6 years agoRemove unnecesary interface modifiers 13/62313/1
Claudio D. Gasparini [Fri, 25 Aug 2017 09:59:53 +0000 (11:59 +0200)]
Remove unnecesary interface modifiers

Change-Id: I4d55d622e5f8431f0ee7d5650025b0a1bfd448dc
Signed-off-by: Claudio D. Gasparini <claudio.gasparini@pantheon.tech>
6 years agoFix wrong return of null when it should be optional 12/62312/1
Claudio D. Gasparini [Fri, 25 Aug 2017 09:58:43 +0000 (11:58 +0200)]
Fix wrong return of null when it should be optional

Change-Id: Iaa90b7dea002ea24da40973cab9d3a18e6955a1b
Signed-off-by: Claudio D. Gasparini <claudio.gasparini@pantheon.tech>
6 years agoBug 9046: Bring back data change counter feature 91/62291/2
Vratko Polak [Fri, 25 Aug 2017 08:17:25 +0000 (10:17 +0200)]
Bug 9046: Bring back data change counter feature

Tests which rely on data change counter do not work without this.

Change-Id: I0a82674c50887f7282cc6ed7a6a54573da73d637
Signed-off-by: Vratko Polak <vrpolak@cisco.com>
6 years agoBug-8942: Fix DelegatedLspsCount 83/62183/4
Ajay Lele [Thu, 10 Aug 2017 21:49:50 +0000 (14:49 -0700)]
Bug-8942: Fix DelegatedLspsCount

mbean value returns count of all LSPs and not just
the ones that are delegated

- Fixed code to return count of delegated LSPs only
- Added unit-test

Change-Id: I067b4cff8c7503fa878742ab6605fca2685a6c15
Signed-off-by: Ajay Lele <ajayl.bro@gmail.com>
Signed-off-by: Claudio D. Gasparini <claudio.gasparini@pantheon.tech>
6 years agoenforce check-style for rsvp impl 07/61407/3
Claudio D. Gasparini [Wed, 9 Aug 2017 08:04:54 +0000 (10:04 +0200)]
enforce check-style for rsvp impl

Change-Id: I50a5540b58bcffe0c60687a5b37474f2ac27656f
Signed-off-by: Claudio D. Gasparini <claudio.gasparini@pantheon.tech>
6 years agoReplace Preconditions.CheckNotNull per RequireNonNull 04/62104/3
Claudio D. Gasparini [Mon, 21 Aug 2017 07:40:08 +0000 (09:40 +0200)]
Replace Preconditions.CheckNotNull per RequireNonNull

Change-Id: I41b155a876cdb10911ea28a31fe4040f5fe1bd53
Signed-off-by: Claudio D. Gasparini <claudio.gasparini@pantheon.tech>
6 years agoBUG-8156 : conflicting listener fix 87/62187/1
Dana Kutenicsova [Sun, 6 Aug 2017 10:18:35 +0000 (12:18 +0200)]
BUG-8156 : conflicting listener fix

In case another session listener is in conflict
with the existing one, close the new listener.

Change-Id: I1a594c3876eb1d28133dcc08b31f38deb5ceb27a
Signed-off-by: Dana Kutenicsova <dana.kutenics@gmail.com>
Signed-off-by: Kevin Wang <kevixw@gmail.com>
6 years agoBUG-8156 : fixed start of session manager 85/62185/2
Dana Kutenicsova [Sun, 6 Aug 2017 08:53:58 +0000 (10:53 +0200)]
BUG-8156 : fixed start of session manager

Upon restart of session manager, its close flag was never
set to false, causing pcep sessions to be rejected as they
rely on this value.

Change-Id: I676ea5774cea4cbbee84222d2ad562bea70e83f3
Signed-off-by: Dana Kutenicsova <dana.kutenics@gmail.com>
Signed-off-by: Kevin Wang <kevixw@gmail.com>
Signed-off-by: Claudio D. Gasparini <claudio.gasparini@pantheon.tech>
6 years agoBUG-8156 : duplicate session up fixed 81/62181/1
Dana Kutenicsova [Sat, 5 Aug 2017 23:00:49 +0000 (01:00 +0200)]
BUG-8156 : duplicate session up fixed

In case of session up twice, the second session gets
deleted from pcep and controller.

Change-Id: I25894bcbc0cc9e7a2d7759278244e4d93553122d
Signed-off-by: Dana Kutenicsova <dana.kutenics@gmail.com>
Signed-off-by: Kevin Wang <kevixw@gmail.com>
6 years agoEnforce checkstyle for rsvp api/spi 09/61409/6
Claudio D. Gasparini [Mon, 7 Aug 2017 14:56:00 +0000 (16:56 +0200)]
Enforce checkstyle for rsvp api/spi

Change-Id: I7ceb91c1eaf1a1b3fb583eec31f08f5a497e4c8a
Signed-off-by: Claudio D. Gasparini <claudio.gasparini@pantheon.tech>
6 years agoEnforce check-style under rsvp spi tests 78/61578/2
Claudio D. Gasparini [Sun, 13 Aug 2017 20:54:08 +0000 (22:54 +0200)]
Enforce check-style under rsvp spi tests

Change-Id: If52a4ab3a18c3618009127cd14ac7f3fa53a09dd
Signed-off-by: Claudio D. Gasparini <claudio.gasparini@pantheon.tech>
6 years agoEnforche check-stile under rsvp api 77/61577/2
Claudio D. Gasparini [Sun, 13 Aug 2017 20:55:14 +0000 (22:55 +0200)]
Enforche check-stile under rsvp api

Change-Id: I4bdd959b3c27353bc945e6c9282a948c97afaaa7
Signed-off-by: Claudio D. Gasparini <claudio.gasparini@pantheon.tech>
6 years agoBump versions by x.(y+1).z for next dev cycle 75/61675/1
Thanh Ha [Mon, 14 Aug 2017 17:15:46 +0000 (13:15 -0400)]
Bump versions by x.(y+1).z for next dev cycle

Change-Id: I75484ae00ea56a89a168cc408714ca4dd898eb49
Signed-off-by: Thanh Ha <thanh.ha@linuxfoundation.org>
6 years agoBump odlparent 2.0.2 to 2.0.4 64/61364/4
Stephen Kitt [Tue, 8 Aug 2017 16:14:19 +0000 (18:14 +0200)]
Bump odlparent 2.0.2 to 2.0.4

Change-Id: Ieee18f9e069a0d9eb6ca8cc9e12237654d958105
Signed-off-by: Stephen Kitt <skitt@redhat.com>
6 years agoBUG-8335: Adjust instantiation 17/60317/8
Claudio D. Gasparini [Sat, 6 May 2017 18:37:21 +0000 (20:37 +0200)]
BUG-8335: Adjust instantiation

The hanging issue stems from the use of a blocking dispatch for DTCL,
which means we are calling into user code while holding listener
registration lock. This does not happen in production environment.

This patch adds an explicit test for this scenario and migrates
the hanging test to call properly initialize its base class.

Also cleans up warnings in the implementation, as it has not seen much
love lately.

Change-Id: I6c424acfad87244c7a23b013ea91da543ecf72a8
Signed-off-by: Claudio D. Gasparini <claudio.gasparini@pantheon.tech>
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
6 years agoClean up 80/61280/1
Claudio D. Gasparini [Mon, 7 Aug 2017 11:48:17 +0000 (13:48 +0200)]
Clean up

- Migrate Futures.addCallback
- Move test to shorter package

Change-Id: I7c5f8f9743cd7220414d68d043ca912261edec4d
Signed-off-by: Claudio D. Gasparini <claudio.gasparini@pantheon.tech>
6 years agoCleanup eclipse warnings 26/61226/5
Robert Varga [Sat, 5 Aug 2017 22:36:33 +0000 (00:36 +0200)]
Cleanup eclipse warnings

- static methods
- deprecated classes
- raw types
- unneded version declarations

Change-Id: Ibfe2f1f3203ebca416d8badd1f149d669ddc2415
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
6 years agoEnforce no split packages 14/61214/1
Robert Varga [Fri, 4 Aug 2017 22:03:38 +0000 (00:03 +0200)]
Enforce no split packages

This patch augments Export-Packages with a directive to fail build
if a split package is detected.

Change-Id: I52a2a157f992cb97fd8c6a88cf45c933ed0fd953
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
6 years agoBUG-8722: fix regression introduced by BUG-5876 11/61211/1
Robert Varga [Fri, 4 Aug 2017 21:18:26 +0000 (23:18 +0200)]
BUG-8722: fix regression introduced by BUG-5876

Change I707914f3ab0786c0ad8ba71a5476b3b7e322b0cd regressed
bgp-rib-impl packaging such that it massively over-included
classes, leading to split package.

This patch fixes that regression.

Change-Id: I6366972b88e3881675c3dd70517fc4e95c050261
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
6 years agoRe add features-bgpcep-extra to integration test 56/60056/5
Claudio D. Gasparini [Fri, 7 Jul 2017 07:28:56 +0000 (09:28 +0200)]
Re add features-bgpcep-extra to integration test

Change-Id: Ic61d66e420f5281dbde1a836b5adbc1ba78be777
Signed-off-by: Claudio D. Gasparini <claudio.gasparini@pantheon.tech>
6 years agoRemove deprecated CSS Topology provider configuration 20/60220/2
Claudio D. Gasparini [Tue, 11 Jul 2017 21:09:15 +0000 (23:09 +0200)]
Remove deprecated CSS Topology provider configuration

replaced by openconfig configuration

Change-Id: I569f75217302e3867a2106065ca9936981a4a126
Signed-off-by: Claudio D. Gasparini <claudio.gasparini@pantheon.tech>
6 years agoBUG-6978: Integrate BMP collector with Cluster Singleton Service 12/57612/6
Claudio D. Gasparini [Fri, 19 May 2017 10:51:57 +0000 (12:51 +0200)]
BUG-6978: Integrate BMP collector with Cluster Singleton Service

Implement bmp HA by introducing CSS to BmpMonitoringStation

Change-Id: I657c367c33fc6b1946c3db19a71725a78917925a
Signed-off-by: Claudio D. Gasparini <claudio.gasparini@pantheon.tech>
6 years agoBug 8675: Follow-up fix to new XML parser change in yangtools 68/59268/6
Igor Foltin [Wed, 21 Jun 2017 09:06:24 +0000 (11:06 +0200)]
Bug 8675: Follow-up fix to new XML parser change in yangtools

Behaviour of the new XML parser in yangtools project needs
to be changed a bit so that RESTCONF/NETCONF projects can be
migrated to the new parser. However, these changes break some
parts of BGPCEP which have already been using it.

This patch provides a fix for the issue and should be merged
right after the following yangtools patch goes in:
https://git.opendaylight.org/gerrit/#/c/59036/

Change-Id: I23a5677e31b01fee7f67c8a5eb6b4081bd976f8b
Signed-off-by: Igor Foltin <igor.foltin@pantheon.tech>
6 years agoMove tests to base package 25/60425/1
Robert Varga [Sat, 15 Jul 2017 12:42:14 +0000 (14:42 +0200)]
Move tests to base package

Test FQCN is used by surefire to generate a report file, which has
limits on its length, causing problems with archival.

Move these tests to base model package to keep the file name short.

Change-Id: I90a49004c235590c87cb331e7cd31f693b3cd6d1
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
6 years agoBump odlparent to 2.0.2 12/60112/1
Robert Varga [Sun, 9 Jul 2017 17:16:08 +0000 (19:16 +0200)]
Bump odlparent to 2.0.2

Automated bump to latest release.

Change-Id: Ib8ecc4751f93c75f93262fa42d43566b0d6094d2
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
6 years agoBug 8667 - PCEP: When peer closes got IO exception 38/58638/12
matcauf [Fri, 9 Jun 2017 21:10:03 +0000 (17:10 -0400)]
Bug 8667 - PCEP: When peer closes got IO exception

When peer closes the pcep session, it results on IO
Exception.
it is due to this close is not recognized as local pcep
PCEP session termination.
It was first implemented as a local pcep session
termination.
https://git.opendaylight.org/gerrit/#/c/906/1/pcep/impl/src/main/java/org/opendaylight/protocol/pcep/impl/PCEPSessionImpl.java
Solution: Use the reason encapsulated in the close message to close the session.

Change-Id: Ia423f5c10b117ef21af5a3bddc28652ebb659e26
Signed-off-by: matcauf <mcauffiez@inocybe.ca>
6 years agoRemove missing dependency features-extras 90/59990/1
Thanh Ha [Thu, 6 Jul 2017 01:32:19 +0000 (21:32 -0400)]
Remove missing dependency features-extras

This appears to have been removed via
I6db5b40c398fbe5e7cb4077d2c2a321a0286fab0

Change-Id: I161964a0ed1d7e52a8a5d6a7dd28f771de2b29b2
Signed-off-by: Thanh Ha <thanh.ha@linuxfoundation.org>
6 years agoBUG-7027 : Remove Data change counter CSS configuration 10/56010/10
Dana Kutenicsova [Tue, 25 Apr 2017 15:21:17 +0000 (17:21 +0200)]
BUG-7027 : Remove Data change counter CSS configuration

since is not longer need it. New configuration is done via REST.

Change-Id: I32c3ffcfa66108d72dd8033e44b1cbd7596537eb
Signed-off-by: Dana Kutenicsova <dana.kutenics@gmail.com>
Signed-off-by: Claudio D. Gasparini <claudio.gasparini@pantheon.tech>
6 years agoBump odlparent dependency to 2.0.1 25/59725/3
Claudio D. Gasparini [Fri, 30 Jun 2017 06:01:08 +0000 (08:01 +0200)]
Bump odlparent dependency to 2.0.1

Change-Id: Ic2c34fb71552aeb6365ce37374c73f0bb909e14a
Signed-off-by: Claudio D. Gasparini <claudio.gasparini@pantheon.tech>
6 years agoBump odlparent dependency to 2.0.0 79/59279/12
Claudio D. Gasparini [Wed, 21 Jun 2017 11:19:50 +0000 (13:19 +0200)]
Bump odlparent dependency to 2.0.0

also rename karaf4 features

Change-Id: I4d9d9274d12e4bb098884d70827d7ed57e8d7b48
Signed-off-by: Claudio D. Gasparini <claudio.gasparini@pantheon.tech>
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
6 years agoRemove BGPCEP Karaf 3 features 82/59282/3
Claudio D. Gasparini [Wed, 21 Jun 2017 11:45:59 +0000 (13:45 +0200)]
Remove BGPCEP Karaf 3 features

Change-Id: I6db5b40c398fbe5e7cb4077d2c2a321a0286fab0
Signed-off-by: Claudio D. Gasparini <claudio.gasparini@pantheon.tech>
6 years agoRemove no longer required 31-bgp.xml for bgp feature 78/59278/1
Claudio D. Gasparini [Wed, 21 Jun 2017 10:31:20 +0000 (12:31 +0200)]
Remove no longer required 31-bgp.xml for bgp feature

CSS configuration is not longer supported under nitrogen.
Therefore 31-bgp.xml is no longer required for bgp feature.

Change-Id: I43aa0a52d919a03e90133a2f908505941285773a
Signed-off-by: Claudio D. Gasparini <claudio.gasparini@pantheon.tech>
6 years agoBUG-6976: Migrate BMP collector to use BP wiring 11/57611/6
Claudio D. Gasparini [Wed, 17 May 2017 14:04:00 +0000 (16:04 +0200)]
BUG-6976: Migrate BMP collector to use BP wiring

Migrate to BP wiring

Change-Id: I6d7d33029123039d27493b014ae459da1333a77c
Signed-off-by: Claudio D. Gasparini <claudio.gasparini@pantheon.tech>
6 years agoKeyMapping rework 59/57959/13
Claudio D. Gasparini [Mon, 29 May 2017 09:44:01 +0000 (11:44 +0200)]
KeyMapping rework

Change-Id: I76a1a1c0353219d453963422b64cd7bcf86bb523
Signed-off-by: Claudio D. Gasparini <claudio.gasparini@pantheon.tech>
6 years agoBUG-6801: Remove deprecated bgpcep *-all features 80/57280/7
Claudio D. Gasparini [Mon, 15 May 2017 08:49:48 +0000 (10:49 +0200)]
BUG-6801: Remove deprecated bgpcep *-all features

Remove deprecated bgpcep *-all features

Change-Id: Ib87ea2d091e2eead955b8cf959a02f071365a7f9
Signed-off-by: Claudio D. Gasparini <claudio.gasparini@pantheon.tech>