Mark potentially-static methods as static

Eclipse is pointing out a large number of warnings around methods
not being static. Fix these up.

Change-Id: Id8ff43ef4556b8e21aa01296e95af36747425489
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Migrate users of Class.newInstance()

This method has been deprecated for removal since Java 9, migrate
the three call sites.

Change-Id: I7527ae2958c22e4f83e436c3293cc06abc1e4f65
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Remove unused @SuppressWarnings

There is nothing deprecated here, remove unused suppression.

Change-Id: If74ee6d0746f3a0a03f5fa565e5682b5b64657a3
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Remove superfluous FluentFuture adaptation

MD-SAL APIs are giving us a FluentFuture already, do not call the
deprecated FluentFuture.from() variant.

Change-Id: I32a7d0bd4ee3e4e1b129cef943e6c022db939fe1
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Do not override managed versions

We are getting these versions from artifacts declaration, do not
specify them again.

Change-Id: Iba7a1697a0ee3c69ede9e2fe2e0cddac0bee8c30
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Bump versions by x.(y+1).z for next dev cycle

Signed-off-by: Thanh Ha <zxiiro@gmail.com>
Change-Id: I35e45232b3a21555975ac5c8b99e9282444b7ecc

Fix loose typing in ItmMonitorWorker

Having a type-variant constructor with internal instanceof checks
prevents proper type safety. Fix this by introducing two separate
constructors. Fixes:

java.lang.ClassCastException: class org.opendaylight.yangtools.yang.common.Uint16 cannot be cast to class java.lang.Integer
at org.opendaylight.genius.itm.confighelpers.ItmMonitorWorker.<init>(ItmMonitorWorker.java:71) ~[bundleFile:?]
at org.opendaylight.genius.itm.listeners.TunnelMonitorIntervalListener.add(TunnelMonitorIntervalListener.java:127) ~[bundleFile:?]
at org.opendaylight.genius.itm.listeners.TunnelMonitorIntervalListener.add(TunnelMonitorIntervalListener.java:34) ~[bundleFile:?]
at org.opendaylight.serviceutils.tools.listener.DataTreeChangeListenerActions.onDataTreeChanged(DataTreeChangeListenerActions.java:65) ~[bundleFile:?]
at org.opendaylight.serviceutils.tools.listener.AbstractSyncDataTreeChangeListener.onDataTreeChanged(AbstractSyncDataTreeChangeListener.java:50) ~[bundleFile:?]
at org.opendaylight.mdsal.binding.dom.adapter.BindingDOMDataTreeChangeListenerAdapter.onDataTreeChanged(BindingDOMDataTreeChangeListenerAdapter.java:37) ~[bundleFile:?]
at org.opendaylight.controller.cluster.datastore.DataTreeChangeListenerActor.dataTreeChanged(DataTreeChangeListenerActor.java:83) [bundleFile:?]
at org.opendaylight.controller.cluster.datastore.DataTreeChangeListenerActor.handleReceive(DataTreeChangeListenerActor.java:44) [bundleFile:?]

Change-Id: I3d6e312532dead3b1668e03fe58984d77b40d6de
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Fix: Datapathfailure observed for unknown tunnels

Alarm was getting raised even when the tunnel state was unknown. Hence
the condition is changed to explicitly check if the tunnel state is
down.

Change-Id: Ia58d52c1994cfe8b943b906e93c61505f5904c95
Signed-off-by: Apurba Mukherjee <apurba.mukherjee@ericsson.com>

Fix: Reconnect updates the tunnel state

Check if tunnels State has an entry for this interface.
If so, then this Inventory Add is due to the compute re-connection. Then, ONLY update the state
to UP as previously the compute would have disconnected and so the state will be UNKNOWN.

Change-Id: I957c0e5892763bcae43dbd481ad0620b1d193f0f
Signed-off-by: Apurba Mukherjee <apurba.mukherjee@ericsson.com>

Fix: ITM tunnels going to Unknown state after cic reboot

As part of cic-1 reboot, DPNs connected to cic-1 got disconnected.
The tunnels associated to those DPNs went to unknown state. Those DPNs
then connected back to cic-3. When cic-3 became entity owner,
EoSListener was not invoked by MDSAL since ITM unregisters the listener
after 1st invocation. So EoSHandler could not set the unknown tunnels to
up. To fix this issue, the listener unregistration is removed.

Change-Id: I96c4f7fc4a94d2eeca8f9ea962a26b900c390493
Signed-off-by: Apurba Mukherjee <apurba.mukherjee@ericsson.com>

Fix: Tunnels are in UNKNOWN state after CSS upgrade

Tunnels went into unknown state because the connects events were missed
by ITM due to EoS switchover. This fix will recover the unknown tunnels
based on inventory oper data store.

Change-Id: Ifa70f91825f73a2dc8c384d97d2e0b54d5f97074
Signed-off-by: Apurba Mukherjee <apurba.mukherjee@ericsson.com>

Do not pull in javax.inject into runtime

We are not using injection on OSGi runtime, we should be relying on it
being provided by the injectipn framework when needed. Also minimize
dependencies on infrautils' inject.

JIRA: INFRAUTILS-65
Change-Id: I91010efe1139a12f8e8bc90765d1a555a748dcc2
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Fix infrautils reference

We want to use a direct reference rather than a property.

Change-Id: I7d17123919c10d8d1e988aa916ae212b5dc0925a
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Use released version of infrautils

infrautils-1.8.0 has been released, use released version instead
of snapshots.

Change-Id: Ie33387d191e6d65e3e1c6fd6de8f45ff8c6835de
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Bump odlparent/yangtools/mdsal/controller

Adopt upstream versions:
- odlparent-7.0.5
- yangtools-5.0.5
- mdsal-6.0.4
- controller-2.0.3

Change-Id: I221bfd55fefc4f412efcf2a605782f29d3e1bde6
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Shard Status logic in genius

- idmanager mbean waits on shards specified in network constants
- this reference will be available to others only when shard leader
  election is done
- any mbean which reads/writes to the data store would have to wait
- ItmProvider and Ifmprovider already wait on idmanager, hence not
  included
- other mbeans which are directly or inderectly on such providers/mbeans
  do not need idmanager reference explicitly

Change-Id: Ia1c77ebcc978da51a3897e0741ea7570937d16a4
Signed-off-by: Edw7n <n.edwin.anthony@ericsson.com>
Signed-off-by: Faseela K <faseela.k@ericsson.com>

Convert MDSALManager to use NamedLocks

MDSALManager is using synchronized(String.intern()), which makes
the locking domain absolutely opaque. Replace this antipattern
with NamedLocks with appropriate keys.

Change-Id: If9d43362cc23d5e25f979b71f4c024b05d6f8dd5
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Remove CacheUtil and CacheTestUtil

CacheUtil has only a single user in netvirt, which is being removed
and CacheTestUtil has only a single internal user. Remove them both.

Change-Id: I6e7e4311f60f82ec87e13a248657bc89d1bb759d
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Set master branch to Aluminium

Signed-off-by: Thanh Ha <zxiiro@gmail.com>
Change-Id: Iab2bc8e2dc1fe6166d57045ed517a832dcb75aad

Updating tep:show command.

Removing redundant/unwanted fields.

Signed-off-by: Nishchya Gupta <nishchyag@altencalsoftlabs.com>
Change-Id: If0a48884a1be07d784e3a3e225acea49a8814abd

TEP is part of old and new TZ when tz is updated after  del-manager

Issue observed:
1. TZA was present and TEPs were part of it.
2. ovsdb connection is removed by running delete-manager command on
switch
3. Change transport-zone of TEPs from TZA to TZC
4. ovsdb connection is set again by running set-manager command on
switch
5. TEPs go under teps-not-hosted since TZC is not yet present. It is
noted here that TEPs are still part of TZA in ITM config DS.
6. TZC is created from northbound
7. TEPs are moved from teps-not-hosted to TZC.
8. In the end, TEPs are part of TZA and TZC both. This is issue.

Fix provided:
When TEPs add notification come again with updated TZC, then
check if same TEP (key: dpid) is already present in any other TZ.
If present, then remove TEP from old TZ and then add TEP into newly
configured TZ.

Signed-off-by: Nishchya Gupta <nishchyag@altencalsoftlabs.com>
Change-Id: I98c3c89f70e60676ea9c5f73d90b1a750943e7a5

L2GW Junit failure

Description:
Th Junit case as adding DeviceTeps for External tunnels only into
default-transport-zone and was querying in TZA resulting in read
failure.

Since the current RPC only have ip and node-id as inputs, Changes are
done in addL2GwMlagDevice() API to add the given Teps in all available
transportzone.

Signed-off-by: Chetan Arakere Gowdru <chetan.arakere@altencalsoftlabs.com>
Change-Id: I75db7338b696471db653417bd3124bc742e5e85d
Signed-off-by: Chetan Arakere Gowdru <chetan.arakere@altencalsoftlabs.com>

Migrate ListenableFutures.addErrorLogging() callers

ListenableFutures.addErrorLogging() has been migrated to
LoggingFutures, use these methods from their new home.

Change-Id: Ic23e8d67be04e1b1eb864c6307f8ffb6fc9a95a7
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Turn ActionableResource into an abstract class

This prevents outside instantiation of the interface, so that
we can hide the details of dispatch from outside world, making
it an implementation detail.

JIRA: GENIUS-281
Change-Id: I5fa6208515501bc7f8f915544da69ac47cd3a8cc
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Hide ActionableResourceImpl

With all users migrated to ActionableResources, we can safely hide
this implementation class and remove the now-unused setters, making
things neatly final and predictable.

JIRA: GENIUS-281
Change-Id: I00caad5574526369b62d50f018d1c95423f370ff
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Unblock the Aluminium Jenkins Verified Build Pass

Issue
=====
Post Openflowplugin https://git.opendaylight.org/gerrit/c/openflowplugin/+/90390
merge, genius build is starting to get, failed with below key related issues.

/w/workspace/genius-distribution-check-aluminium/genius/interfacemanager/
interfacemanager-impl/src/main/java/org/opendaylterfacemanager/pmcounters/NodeConnectorStatsImpl.java:cannot find symbol
13:24:17   symbol:   class FlowAndStatisticsMapListKey
13:24:17   location: package org.opendaylight.yang.gen.v1.urn.opendaylight.flow.statistics.rev130819.flow.and.statistics.map.list

Signed-off-by: Nishchya Gupta <nishchyag@altencalsoftlabs.com>
Change-Id: I0b31725a3871f178ae2f1256670442a601ecf8bf

Use Assert.assertThrows()

org.opendaylight.infrautils.testutils.Asserts.assertThrows() has been
deprecated, as we now have a more modern JUnit, which provides this
facility. Migrate all users and remove dependency on
infrautils-testutils where is it no longer required.

Change-Id: If7bb59bf45ad290fb79747105c690af4a684dfdb
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Use a range for MDSAL feature

odl-mdsal-model-rfc7224 should be referred to via a range to ease
MRI project upgrades, do that now.

Change-Id: I1bee9318e99a56f7ae7bd7c5630b1037615d6cb3
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Integrate controller-2.0.2

This bumps versions to the following:
- odlparent-7.0.3
- yangtools-5.0.3
- mdsal-6.0.2
- controller-2.0.2

Change-Id: Ida57ff1454c9298715de0a3dd2653b624cba5622
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Bug fixes after MRI version bump

Change-Id: I9fc2351cf37877427c698fdb6a2d38a0ce5b02f4
Signed-off-by: R P Karthika <r.p.karthika@ericsson.com>
Signed-off-by: Apurba Mukherjee <apurba.mukherjee@ericsson.com>
Signed-off-by: R P Karthika <r.p.karthika@ericsson.com>

Clean up mis-migration

This is a follow-up to 8a228e4974b9e6909df0a4aa7866eadfee9e438c,
correcting a minor change in semantics.

Change-Id: I4478c1df8b12c7a798c73b9707cf903705cc1587
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Integrate controller-2.0.1

This bumps versions to the following:
- odlparent-7.0.2
- yangtools-5.0.2
- mdsal-6.0.1
- controller-2.0.1

Also fix up MD-SAL API migration.

JIRA: GENIUS-279
Change-Id: Iac4963fa4d833481e34e9683450cb61a339df3d7
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Remove commented-out dependencies

Dependencies on controller artifacts are commented out, remove
them to prevent them from coming back.

Change-Id: Ibbfecf1ae7f185be650eba78541b36d9786ef827
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

ignore test testMultithreadedIdAllocationFromReleaseIds of Idmanager

This test is failing and causing build faliure for other patches.
It seems like the issue with test framework and required investigation.
For now ignoring the test so that build can go through for other
patches.

Signed-off-by: Ankit Jain <ankit.j.jain@ericsson.com>
Change-Id: Id613ac771b6d8774f26c4902c8a3a24bb6cfe331

MRI version bump for Aluminium

This bumps versions to the following:
- odlparent-7.0.1
- yangtools-5.0.1
- mdsal-6.0.0
- controller-2.0.0

Signed-off-by: R P Karthika <r.p.karthika@ericsson.com>
Signed-off-by: Nidhi Adhvaryu <nidhi.adhvaryu@ericsson.com>
Signed-off-by: Apurba Mukherjee <apurba.mukherjee@ericsson.com>
Change-Id: I508ba70555f52da12439a3963d642fc60cfe7775

Fix javadoc failures in genius

Fixing javadoc failures post MDSAL-API migration.

Change-Id: I9e6c5408c5f132006bc0c737a0980ac0fe6425c8
Signed-off-by: Nidhi Adhvaryu <nidhi.adhvaryu@ericsson.com>
Signed-off-by: Apurba Mukherjee <apurba.mukherjee@ericsson.com>
Signed-off-by: R P Karthika <r.p.karthika@ericsson.com>

InfraUtil JobCordinator Changes.

Desc:
https://git.opendaylight.org/gerrit/c/infrautils/+/89057

Change-Id: I76744bf161cc6d1edadf013f2310f6aa6bb1efae
Signed-off-by: Chetan Arakere Gowdru <chetan.arakere@altencalsoftlabs.com>
Signed-off-by: R P Karthika <r.p.karthika@ericsson.com>

MDSAL-API Migration

1)Change Futures to FluentFuture
- Remove ReadFailedException
- Replace TrnasactionCommitfailedException with Execution
  and Interrupted exception
- submit() -> commit()
- checkedGet() -> get()

2)Change org.opendaylight.controller.md.sal package to org.opendaylight.mdsal
- Primarily databroker, all transactions
- ReadOnlyTransaction -> ReadTransaction

3)Change com.google.common.base.Optional to java.util.Optional

4)Change serviceutils.tools.mdsal.listener to serviceutils.tools.listener

Change-Id: I91f6178e1ef363d989cd19e2ab7048001e811ed7
Signed-off-by: R P Karthika <r.p.karthika@ericsson.com>

Use Magnesium controller

As part of controller transition to being MRI, downgrade the version
used to Magnesium release. This will be bumped to Aluminium proper
during the MRI window.

Change-Id: I84d1c7cdeaf8ae9bd3b00070c434e8a27ba23665
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Revert "doesExists() utility method"

This reverts commit 8b0a3fd63b457589f0f869897c46c696994c618c.

Reason for revert: Remove Deprecated APIs

Signed-off-by: Hema Gopalakrishnan <hema.gopalkrishnan@ericsson.com>
Change-Id: I60b0723c3e927ffe65ed0f55f05e2241bb4c51b1

doesExists() utility method

Common utility method doesExists() added to check whether any DS entry
exists or not in SingleTransactionDataBroker

Change-Id: I92a8f5bda8d4d924be6a820e6a18acd598a40dae
Signed-off-by: Shashidhar Raja <shashidharr@altencalsoftlabs.com>

Bump versions by x.y.(z+1)

Signed-off-by: jenkins-releng <jenkins-releng@opendaylight.org>
Change-Id: I897b2682f347c8e1eb9f03e211882a1c008df499

Encapsulate ActionableResourceImpl

This provides ActionableResources for use by external users, which
enforce well-formedness off ActionableResource. This allows us to
eliminate the need for ActionableResource.getKey(), which is not
used anywhere aside from ResourceBatchingManager, where we can
simply default to ActionableResource.toString().

This eliminates the need to eagerly invoke InstanceIdentifier.toString()
just to enqueue a task and makes sure this is not done unless the
resource is constructed using deprecated interfaces.

JIRA: GENIUS-281
Change-Id: I48691f9d3dbcbf2715f7eddaf775b0e9a37fd7b4
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

GENIUS-282 Resolving genius yang model errors

Some errors that appeared while testing the Yang models,
https://logs.opendaylight.org/releng/vex-yul-odl-jenkins-1/distribution-merge-managed-magnesium/657/opendaylight-models/genius/
which is being addressed in this patch

Signed-off-by: Nidhi Adhvaryu <nidhi.adhvaryu@ericsson.com>
Change-Id: Id0b3f212983876e7908f6b4ee142d91c538d6d59

Revert "Packet duplication due to forwarding from HWvTEP tunnel to ITM"

This reverts commit a1b8a5918a7f9319214d597ffe85e212004ae71c.

Change-Id: I377f5e67a311a18493baa606ff926a05ef3fb6cf
Signed-off-by: Hema Gopalakrishnan <hema.gopalkrishnan@ericsson.com>

Packet duplication due to forwarding from HWvTEP tunnel to ITM

Fix details:
--------------
ELAN_DMAC_TABLE = 51 has been refactored into two
ELAN_LOCAL_DMAC_TABLE = 51 and ELAN_REMOTE_DMAC_TABLE=52

Signed-off-by: Amitesh Soni <amitesh.soni@ericsson.com>
Change-Id: I6ad9d4267ab6b48c28120e7631917ec3038cea9a

Fix odl-genius-api

Multiple things done here:
- use artifacts to import proper upstream versions
- add dependency on odl-openflowplugin-eric-extensions
  to prevent duplicate packaging of Ericsson extensions

Change-Id: I79f51be20559798a0539a65e1cf924bbc32f2278
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Fix odl-genius

Multiple things done to clean up packaging:
- use properly-imported artifacts poms from upstream to eliminate
  properties
- add proper dependency on odl-serviceutils-listener to eliminate
  duplicate packaging
- eliminate unneeded explicit dependencies, they are pulled in as
  needed
- cloudscaler dependency on javax.annotation is optional, as it is
  not used in Karaf and should not be pulled into the feature

Change-Id: I1313695530bd7354c2e8f75d45ee8f99525fcb05
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Bump to odlparent-6.0.4/yangtools-4.0.6/mdsal-5.0.9

Pick up latest fixes and upgrades.

Change-Id: I8680b14deaec92583bb89a9a10088fc3d34b5b51
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Change the log level to debug

JIRA: NETVIRT-1656

Signed-off-by: Chandra Shekar S <chandra.shekar.s@ericsson.com>
Change-Id: Ic7e501cb82046d2d5077d047ac92956fed66cd17

Remove ARIES-1923 workaround

We now have proper monkey-patch in place and can therefore remove
this workaround.

Change-Id: Ia69518cb72aaa99de9f4eb83c6a295d9715928a0
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Bump odlparent/yangtools/mdsal to 6.0.3/4.0.3/5.0.6

Pick up the latest upgrades and fixes.

Change-Id: I127543de2d469e3aa626a427450e1db2a37d0dfb
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Expose TypedReadTransaction.exists(InstanceIdentifier)

This operation was not exposed at the binding layer when these
utilities were conceived and thus is lacking here, even when they
are available as part of MDSAL-389.

The MD-SAL version of TypedReadTransaction has been updated back
then, this patch backports these changes to legacy Genius APIs.

Also converts a few callers to use this capability, potentially
improving performance.

JIRA: MDSAL-389
Change-Id: Ieb870a49c8239ee74e697d7d36dea431b24362ae
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
(cherry picked from commit 7144e4db6a02daf37f8ba055745a359d0a80c21e)

Optimize String formatting

In some hot paths we end up calling String.format() where a simple
concatenation would suffice. Fix that up.

Change-Id: Ib173fc0599899f40012410b75e243dd3873019a3
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Remove ActionableResource setters

This removes previously-deprecated setters, so that the resource
itself has an immutable surface.

JIRA: GENIUS-281
Change-Id: Ic621cb4afb5567442b29a7c69fdaf0bcb7c5430e
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Update docs header to Magnesium in the master

Should be Magnesium on master and Sodium on stable/sodium.

Signed-off-by: Anushka Bhandari <anushka16134@iiitd.ac.in>
Change-Id: I6aa4bcd7742ee5efcdf44ad4f1511f952278e196

Cleaning Oper DS during scalein

- to key tunnel remove events on tunnel name
- uses tombstone api

Signed-off-by: Nidhi Adhvaryu <nidhi.adhvaryu@ericsson.com>
Change-Id: I46470cc20c477c2301e20d2da480a2746d949ee3

Bump to odlparent-6.0.1/yangtools-4.0.2/mdsal-5.0.4

This picks up latest upgrades and fixes.

Change-Id: I8db358b0af81394a561071d98bffea168dda47cc
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Addessing NPE and UnsupportedOperationException in Genius

Signed-off-by: xcheara <chetan.arakere@altencalsoftlabs.com>
Change-Id: Ie71bd0096968057574a018a04cec0da18b0196c4

Deprecate ActionableResource setters

ActionableResource should not allow modification of parameters
once built. Deprecate setters in the base interface, retaining
them in the implementation.

JIRA: GENIUS-281
Change-Id: Iaf64bb20b67e3d39cfb769bffad0ddbd669cf169
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Downgrate aggregator's javadoc plugin

It seems javadoc-verify/merge jobs are affected by some bug in
maven-javadoc-plugin -- it would filter iana-if-type dependency,
leading to a a failure in javadoc:aggregate.

Change-Id: I8efd03b24cffd509de7f44c9ab1c103c1ee50bad
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Bump version odlparent->6.0.0,mdsal->5.0.3

This adopts new version of MRI projects and adjusts for the changes
therein. Most notably DPs/DPNs are identified by Uint64, not
BigInteger.

Some drive-by cleanups are performed, mostly to eliminate valid
Eclipse complaints.

Change-Id: Ib73c963d515f55f0865775584de3632e3731820c
Signed-off-by: xcheara <chetan.arakere@altencalsoftlabs.com>
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Bump mdsal to 4.0.6

This picks up the latest fixes.

Change-Id: I8ec178ca726c1df504efc4f19d2c9c80965d93be
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Bump yangtools to 3.0.5

This picks up the latest fixes.

Change-Id: Ic37a0d36367f6d89768bec2b92618b4b55aa844f
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Bump odlparent to 5.0.2

This bumps odlparent to pick up latest references.

Change-Id: Ica16c98bd6eeeb2530bdc9cee4bb7f198e4a6ab0
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Fix checkstyle

This fixes up violations reported by upgraded checkstyle.

Change-Id: Ic0db886bc974a31692b228667c93375a958c3618
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Retry on DS if read fails

Issue: During the initialization of ID Manager, ID Manager reads
ID pools DS. If this DS read fails, ID Manager does not come up
and other applications dependent on ID Manager do not come up.

Fix: Fix is made to retry on DS until read succeeds.

Change-Id: I627846e1c84f75461f43d9248e98e561b1ffd5bd
Signed-off-by: Amitesh Soni <amitesh.soni@ericsson.com>

Fix minor typo in the csit document

Change-Id: Ic832ecd4c8817d8fd4f810d31183d1f2d574e3af
Signed-off-by: Faseela K <faseela.k@ericsson.com>

GENIUS-202 GENIUS-257 Retry for Unlock() & IdManager calls tryLock()

** LockManager's unlock() method now retries 10 times in case of
exception is thrown. The interval between retries is 1 sec.

** LockManager's lock() method now eternally retries in case of
DataStoreUnavailableException and OptimisticLockFailedException
otherwise it returns FailedRpcResult.

** IdManager no longer calls LockManager's lock() api. It now calls
LockManager's tryLock() api which internally retries for 10 times.
Idmanager returns failure if lock is not acquired after specified lock
attempts. After this change, it is the responsibility of the consumers of
Idmanager to handle these failures.

Change-Id: Ic230e2e4edce4f95ee461ef22ff895368af9663d
Signed-off-by: Ankit Jain <ankit.j.jain@ericsson.com>
Signed-off-by: Amitesh Soni <amitesh.soni@ericsson.com>

GENIUS-171 IdManager's releaseId() returns id being released

The releaseId() RPC now returns the release-id upon successful release
so that applications can use the same for cleaning-up their id which
they might have cached in their states.

Signed-off-by: Amitesh Soni <amitesh.soni@ericsson.com>
Change-Id: I811a2b1b4daf7124162b35c5d88159b6a917f8c2

Adding test classes for scale-in/scale-out functionality

Change-Id: Ie038ca19a4199316b8a5c432e20295cd58e967a1
Signed-off-by: manojna v <manojna.vijayakrishna@ericsson.com>

GENIUS-254 GENIUS-119 GRE and L2GW tunnel missing

There is a race condition between creation of tun port and
bridge ref, port not created. When we are trying to add bridge
to ovsdb from SB, NB is trying to add port for same bridge.
during which NB will check DS for bridge entry,which will be
empty as SB is trying to add it in ovsdb at the same time.
So we are adding eventcallback to synchronize both events.

Change-Id: I7f6c0583d90d5aa91e0ae063123680bdece08998
Signed-off-by: Nidhi <nidhi.adhvaryu@ericsson.com>

GENIUS-251 Documentation for genius event logging using log4j2

Signed-off-by: Nidhi Adhvaryu <nidhi.adhvaryu@ericsson.com>
Change-Id: I5b7ed401482dfda550b450d9beb1e425292e7923

"Adding scale-in/scale-out functionality""

This patch has to go in along with the corresponding netvirt patch.
Else genius merge jobs will start failing

Change-Id: I654fbdf30a7e1b5565d238878a5eca7a96960de9
Signed-off-by: Faseela K <faseela.k@ericsson.com>

NETVIRT-1586

OVS Based NA Responder for IPv6 default Gateway

Change-Id: Idd52407babc7bbd9bc45da1910cb0767c4511af3
Signed-off-by: nithi thomas <nithi.t@altencalsoftlabs.com>

Grep not working for Karaf commands

This cover changes for idmanager.
The fix is to replace Session.getConsole() with System.print().

Change-Id: Ic85a495ae5386b996942b47c7a6b75f281dd3f3c
Signed-off-by: Manu B <amitesh.soni@ericsson.com>

Bump mdsal to 4.0.4

This brings in latest fixes.

Change-Id: I59f89ef4fe76ef16fcdc9b59f8d9b50aa0849847
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Bump versions by x.y.(z+1)

Signed-off-by: jenkins-releng <jenkins-releng@opendaylight.org>
Change-Id: I04a508da4a70d18d5b297b98fbedfed89e0df6d5

GENIUS-251: Event Logger for Genius

Separate Logger to capture events for debugging.

Change-Id: I2410d8b336ab83ba2ec186ebcdbfb77e915dbf1b
Signed-off-by: Nidhi <nidhi.adhvaryu@ericsson.com>

ITM recovery is not working

Tunnels were not getting recovered and what we found is
Itm Direct Tunnel support was missing for tep and
transportzone recovery. So this patch is adding that.

Change-Id: Ie0c4df35065384e26dce9d271d229868daa4c8ce
Signed-off-by: Nidhi <nidhi.adhvaryu@ericsson.com>

Selective BFD: Fix to enable BFD on both
Source and Destination DPN.

Change-Id: I18ac0ae566c89b9e5f7055d30a36e440abacba31
Signed-off-by: Dimple Jain <dimple.jain@ericsson.com>

Enable interface-manager-stats polling by default

Currently a flag in genius-ifm-config.xlm which controls
the Performance counter is disabled by default.
Making this flag enable by default will make these
counters available to be queried using mbean by default.
As the polling interval is 15 mintues, it should not hurt performance.

Change-Id: I4d904dcacbc13e42e695a1f9d37f20a61cf6eafa
Signed-off-by: Naveen Kumar Verma <naveen.kumar.verma@ericsson.com>

VNF BFD packets are dropped by OVS when Tunnel monitoring
BFD is turned ON.
Adding BFD MAC filter on tunnels to fix this issue.

Change-Id: I5bbb13ac3aae82bffbebdef7e373a10fea9418bc
Signed-off-by: Dimple Jain <dimple.jain@ericsson.com>

Bump mdsal to 4.0.3

This bumps mdsal to 4.0.3, bringing in latest fixes and improvements.

Change-Id: Ie8e03aab1f31edf80bc9f1d7896c334c9d83be8d
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Bump yangtools to 3.0.4

This picks up latest fixes and improvements.

Change-Id: I03201927d23762acf641c1ab0ff3419ba8b94969
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Bump odlparent to 5.0.1

This picks up the latest upgrades.

Change-Id: If6006a94197839a9718cd5eae16b0a025913af93
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Issue:  uuid was not coming from interface manager as portNameCache
which pmcounters where using was not getting update.

Solution: EOS of INTERFACE_CONFIG was preventing the
cache to be modified on other Cics. Now adding and removing entries into
portNameCache as moved before the EOS check.

Change-Id: Ia64d56e5dd59ef4044617b77139c35a1ee2a77ea
Signed-off-by: Naveen Kumar Verma <naveen.kumar.verma@ericsson.com>

Revert "Adding scale-in/scale-out functionality"

This reverts commit 1e7bda5287304ba3a5dde948b5fe38124b56349b.

Change-Id: I6d5c7df57439bacf80f4c540c34dcdd75acdfa1b
Signed-off-by: Faseela K <faseela.k@ericsson.com>

Handle Node Repair in IFM

Handle Node Repair in IFM, check for UNKNOWN state.

Change-Id: I48a0e66d396b9072e897f96a71108fc1d4ea8fc6
Signed-off-by: Nobin Mathew <nobin.mathew@ericsson.com>

Adding scale-in/scale-out functionality

Change-Id: Ic28ed5c32a3d26cfc608cd9c0ad87e37ad1b552a
Signed-off-by: manojna v <manojna.vijayakrishna@ericsson.com>

GENIUS-266: Deletion of OF-Port along with status
- takes care of deleting of-Port
- takes case of deleting tunnels to and from this port
- takes care of deleting ingress and egress flows

Change-Id: I8d42b02134d163e5ebf6b18aa7734cc65237ab33
Signed-off-by: Apurba Mukherjee <apurba.mukherjee@ericsson.com>

JIRA: GENIUS-271-ITM Tunnel state operational DS population
The changes are made to populate the tunnel states for OF tunnels

Change-Id: If77d0311bccc8fb67720d927344adb5c05cdac63
Signed-off-by: Apurba Mukherjee <apurba.mukherjee@ericsson.com>

Fix for NPE in ArpUtil

Change-Id: I9411a1576cf2d74950b685a6bd2d10e5bb3ea0ab
Signed-off-by: Nidhi <nidhi.adhvaryu@ericsson.com>

Fixing NullPointerException.
ITM was not processing the parked NC event due to a wrong lookup.
As a result all the parked NC events were lost.

Change-Id: Ie6ca0a603c83de778c6741abdeefe3b345a48555
Signed-off-by: Dimple Jain <dimple.jain@ericsson.com>

Remove JSR305 dependencies

JSR305 is not used anywhere, remove it from dependencies.

Change-Id: Ia8129823dc2ac78d967ca23a2502e799d5148d31
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Remove DataStoreCache

Caches based on this class have been eradicated, with the only
user being CLI trying to find it. Remove the class and references
to it.

Change-Id: I9e4848ae9e491d04d9a2fa771fc8cdf5b3545e2f
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Skipping tunnel ports when colleting port stats...

Incomplete statistics comes for Tunnel ports from ovs:

 "bytes_received": "-1",
 "bytes_sent": "-1",
 "duration": "65373",
 "packets_received": "-1",
 "packets_received_drop": "-1",
 "packets_received_error": "-1",
 "packets_received_on_tunnel": "0",
 "packets_sent": "-1",
 "packets_sent_on_tunnel": "0",
 "port_id": "23",
 "tenant_id": "3ecca858-98cd-4923-9011-e8c750f7b9a8",
 "uuid": "9e94558d-9dbf-4a82-88df-b99d8fe056fa"

Change-Id: I116020f735bc341864b3fd80ee6d866deac155f8
Signed-off-by: Naveen Kumar Verma <naveen.kumar.verma@ericsson.com>

Move Pm Counter processing to new thread

Porcessing of RPC response has been moved to a newer thread.

Change-Id: I2fcf385847924f164d6799d59ea390b2acdcd059
Signed-off-by: Naveen Kumar Verma <naveen.kumar.verma@ericsson.com>

Issue: Table-0 to Table-36 flow was missing
As part of ITM Yang Models Cleanup, internal flag was removed which
caused the issue. The internal flag is brought back to fix the issue.

Change-Id: Ia069fc52ecbd3223fa7ca7c4713ffb475fb3a353
Signed-off-by: Apurba Mukherjee <apurba.mukherjee@ericsson.com>

Make Batching size and interval as configurable parameters
in ITM

Define batch size and interval in itm-config.yang and use that instead
of using it from system.properties(),so it can be configured if needed.

Change-Id: I6f292bad3323fd4b5cd1d1be6cb6e575e41c3c1a
Signed-off-by: R P Karthika <r.p.karthika@ericsson.com>