Update README with instructions on how to update bundles in karaf

Change-Id: Ied0613a4ec961f668c5b5587cd65b3f13edfcfef
Signed-off-by: Sam Hague <shague@redhat.com>

Merge "Fix critical Sonar Issue: ConfigurationServiceImpl.java"

Fix critical Sonar Issue: ConfigurationServiceImpl.java

Fix for the following issue:
- Throwable.printStackTrace(...) should never be called

https://sonar.opendaylight.org/component/index#component=org.opendaylight.ovsdb%3Aplugin%3Amaster%3Asrc%2Fmain%2Fjava%2Forg%2Fopendaylight%2Fovsdb%2Fplugin%2Fimpl%2FConfigurationServiceImpl.java&settings=issues&blocks=959%2C967&tab=issues&item=.js-filter-CRITICAL-issues&line=963

patch 2: replace 'e.fillInStackTrace()' with 'e'
patch 3: set log level to error

Change-Id: I91af7d1548b3c7563126ace9ad33a0f1b8877379
Signed-off-by: Flavio Fernandes <ffernand@redhat.com>

Fix Critcal Sonar Issue: ConfigurationServiceImpl.java.

Fixes the following issues:
- Use a logger to log this exception.

https://sonar.opendaylight.org/component/index#component=org.opendaylight.ovsdb%3Aplugin%3Amaster%3Asrc%2Fmain%2Fjava%2Forg%2Fopendaylight%2Fovsdb%2Fplugin%2Fimpl%2FConfigurationServiceImpl.java&settings=issues&blocks=959%2C967&tab=issues&item=.js-filter-CRITICAL-issues

Change-Id: I37465b04134122d932d48ea26655057bbf5ea3ca
Signed-off-by: Marcus Koontz <marcus.g.koontz@intel.com>

Fix Major Sonar Issues: SouthboundEvent.java.

Fixes the following issues:
- Removed semi-colon to fix empty statement error
- 12 Avoid using If/If else/For statements without curly braces

https://sonar.opendaylight.org/component#component=org.opendaylight.ovsdb:openstack.net-virt:master:src/main/java/org/opendaylight/ovsdb/openstack/netvirt/SouthboundEvent.java

Change-Id: Ic3adee50ec4a3f6f0d48c3d8330cfde9654d423f
Signed-off-by: Marcus Koontz <marcus.g.koontz@intel.com>

Fix Major Sonar Issues: NorthboundEvent.java.

Fixes the following issues:
- 22 Avoid using If/If else/For statements without curly braces

https://sonar.opendaylight.org/component#component=org.opendaylight.ovsdb:openstack.net-virt:master:src/main/java/org/opendaylight/ovsdb/openstack/netvirt/NorthboundEvent.java

Change-Id: I84271baabf37d732fbaf34869b4a60ba697789e8
Signed-off-by: Marcus Koontz <marcus.g.koontz@intel.com>

Fix Major Sonar Issues: LBaaSPoolHandler.java.

Fixes the following issues:
- 13 Avoid using If/If else/For statements without curly braces

https://sonar.opendaylight.org/component#component=org.opendaylight.ovsdb:openstack.net-virt:master:src/main/java/org/opendaylight/ovsdb/openstack/netvirt/LBaaSPoolHandler.java

Change-Id: I7655947f05731f213a54fee2c39b00a0ae8c945a
Signed-off-by: Marcus Koontz <marcus.g.koontz@intel.com>

Fix Major & Minor Sonar Issues: LBaaSHandler.java.

Fixes the following issues:
- Comments should not be located at the end of lines of code
- 9 Avoid using If/If else/For statements without curly braces

https://sonar.opendaylight.org/component#component=org.opendaylight.ovsdb:openstack.net-virt:master:src/main/java/org/opendaylight/ovsdb/openstack/netvirt/LBaaSHandler.java

Change-Id: I30152177b433cc3de4034e174fd4a42641f81994
Signed-off-by: Marcus Koontz <marcus.g.koontz@intel.com>

Add log to indicate the schema version

Change-Id: Idd381fed334d5053f10287ed205b217dc7b594a9
Signed-off-by: Sam Hague <shague@redhat.com>

Make method names consistent

Change-Id: I4c410970cceb8cc6d2a78fafe6615cea6d1d4f5a
Signed-off-by: Sam Hague <shague@redhat.com>

Fix tests where schema version is not supported

Tests were failing on earlier ovs versions because the schema version did not support certain tables. In these cases a bridge was created and not deleted because only part of the test ran.

Add assumeTrue() around the schema version check to all tests with a problem schema version to allow the test to continue.

Change-Id: I752c52ed483c252a4564fd24d6353654fc209a33
Signed-off-by: Sam Hague <shague@redhat.com>

Use features-integration as base for ovsdb karaf distro

Change-Id: I9613abdabe8e33c62accceb6552a45573ac74012
Signed-off-by: Sam Hague <shague@redhat.com>

Merge "Remove unused schema code."

Merge changes Ibe8d0d9f,I31935e1e,I0f1f3bee

* changes:
  Add checkstyle to utils.mdsal-openflow
  Add checkstyle to utils.config
  Add checkstyle to plugin-shell

Merge changes I8fe016c2,I75842f8e

* changes:
  Add assumeTrue around hardware_vtep schema check
  Add README.txt file with details on how to use hardware_vtep schema

Add checkstyle to utils.mdsal-openflow

Change-Id: Ibe8d0d9fef466ce02a2e5988cc8e28a9d709e609
Signed-off-by: Sam Hague <shague@redhat.com>

Add checkstyle to utils.config

Change-Id: I31935e1ef583e3dd8d7465330f05db3db96532cb
Signed-off-by: Sam Hague <shague@redhat.com>

Add checkstyle to plugin-shell

Change-Id: I0f1f3bee18eb8b706ae0e04fc540cf1ad1523a35
Signed-off-by: Sam Hague <shague@redhat.com>

Remove unused schema code.

The existing integration tests in schema were adapted to pax-exam and moved to the integrationtest bundle.

Change-Id: Ie255d4b81410d0b0e128959d55332ab8a3d39917
Signed-off-by: Sam Hague <shague@redhat.com>

Add assumeTrue around hardware_vtep schema check

The images used in the jenkins jobs do not support hardware_vtep so this is needed to pass the test.

Change-Id: I8fe016c29613d0a520585d9419d63aa4887a3864
Signed-off-by: Sam Hague <shague@redhat.com>

Merge "Add pax-exam integration-tests for hardware_vtep"

Add README.txt file with details on how to use hardware_vtep schema

Change-Id: I75842f8e32fec9d8fbd8edea418c72725ea39544
Signed-off-by: Sam Hague <shague@redhat.com>

Add pax-exam integration-tests for hardware_vtep

Change-Id: Iaf68ff38b5dbe58cf06f75c2fc54f429c1eae9a8
Signed-off-by: Sam Hague <shague@redhat.com>

Merge "Add pax exam schema integration tests"

Add pax exam schema integration tests

Patch Set 4: Fix verify error

Patch Set 3: checkstyle fixes

Patch Set 2:
- Adapted old tests to use pax exam
- Fixed some issues in existing tests that were not correct. In most cases this would be cleaning up orphaned columns in tables.
- Added new tests to cover untested code
- Added monitoring code to all tests to test that integration
- Refactored some methods to be common

Patch Set 1: Early draft, not to be merged

Change-Id: Ieb301fb75e8857bf682237fa6486676ca170363d
Signed-off-by: Sam Hague <shague@redhat.com>

Fix for Sonar Issue(A catch statement should never catch throwable)

Signed-off-by: Bindya Narayan <bindya.narayan@intel.com>

Fix for Sonar "Avoid Catching Throwable" error.

This patch fixes the error caught by sonar by catching exception
and not throwing 'Throwable' in processGetTableSchema method which
seems to be redundant.

Signed-off-by: Sharad Mishra <sharad.d.mishra@intel.com>

Fix Sonar issue: Utility classes should not have a public constructor

Fix name of artifact to be less generic.

Change-Id: Ib09fd1c49d2d666ef2d5f19bbe4f6971301a7d8d
Signed-off-by: Flavio Fernandes <ffernand@redhat.com>

Merge "Complete PrintCache unit-test"

Merge "Bug 2021 - NORMAL and CONTROLLER flows should not use hard coded strings"

Add jacoco-maven-plugin to the rest of the projects in OVSDB

adding the plugin to the rest of the projects will allow Sonar to get coverage information on the projects.

Change-Id: I51f47bbff9c64f53d0e17eb202c1ff3bda8c8966
Signed-off-by: Sam Hague <shague@redhat.com>

Complete PrintCache unit-test

Change-Id: I6fd66157b4615114591ba94beaff1aebcd12ab44
Signed-off-by: Sam Hague <shague@redhat.com>

Bug 2021 - NORMAL and CONTROLLER flows should not use hard coded strings

The output port value should be using the node connector id assembled
from the sal-compatibility library, which is provided by the controller.

Patch 3: Add feedback from code review

Change-Id: I3aa503bfd54e3cfcd7fa6dd730849b88f90a38c1
Signed-off-by: Flavio Fernandes <ffernand@redhat.com>

Updating the control.vm.box in Vagrantfile to use the right type

Change-Id: I18a4e14767318475abad245c8deeb3ead3e27090
Signed-off-by: Srini Seetharaman <srini.seetharaman@gmail.com>

Merge "Bug 2316 - Fixing equals() in LoadBalancerMember class to be compliant and also use .equals instead of == for comparing Strings"

Bug 2316 - Fixing equals() in LoadBalancerMember class to be compliant
and also use .equals instead of == for comparing Strings

Change-Id: I5a4cad3f66540abe9c9d8ff5b2d2211aa9b6d0f4
Signed-off-by: Srini Seetharaman <srini.seetharaman@gmail.com>

Add adsal-compatibility to ovs-sfc features since sal-compatibility was added to md-sal-openflow

Change-Id: I168787d5c26cabe0c4307fb49d7b437ff96819cb
Signed-off-by: Sam Hague <shague@redhat.com>

Merge "Fixes to get ovsdb running in eclipse"

Fixes to get ovsdb running in eclipse

This gerritt fixes the lifecycle and plugin maven errors. With this fix I don't see any more major errors. There are still some warnings that I will look at in a later commit.

Change-Id: Ic4a60fe47298f8f40069552ae3cb627d88ea1a80
Signed-off-by: Sam Hague <shague@redhat.com>

Add unit-tests for ConfigProperties

Patch 4: Implement feedback from shague

Change-Id: I23cc7b70032e3b884171b00d52fa5c8630fda587
Signed-off-by: Flavio Fernandes <ffernand@redhat.com>

Merge "Fix issue found by sonar: Method call on object which may be null"

Add workaround because sfc models changed.

This workaround simply comments out the offending lines. The ovs-sfc code will be updated when the models settle down.

Change-Id: I33dbd1aef42cfa0a3dce9e88288fb62489d37f42
Signed-off-by: Sam Hague <shague@redhat.com>

Fix issue found by sonar: Method call on object which may be null

Change-Id: I937dddbe08fa12cbe38ad01a5990a90c4ac19df1
Signed-off-by: Flavio Fernandes <ffernand@redhat.com>

Bug 2214 - Unable to set the external_ids field of the Qos object

Fix typo on external_ids for QoS table, to conform with
http://openvswitch.org/ovs-vswitchd.conf.db.5.pdf page 38.

Change-Id: I97ac25bf1355b18d9944de3e78bbe6edadd3399d
Signed-off-by: Flavio Fernandes <ffernand@redhat.com>

Merge changes I89f90cf4,I248403b7

* changes:
  Add unit-tests for OvsdbNorthboundV3
  Add printCache unit tests.

Update readme to include karaf run description.

Change-Id: Ic3ee9daad40f7c67433fe931757aae10c99f9cfd
Signed-off-by: Sam Hague <shague@redhat.com>

Add unit-tests for OvsdbNorthboundV3

Change-Id: I89f90cf46f6dd0895ca64ce9b19055e0ea6660c0
Signed-off-by: Sam Hague <shague@redhat.com>

Add printCache unit tests.

Change-Id: I248403b7a60d91e47f35bbcb3d49a33d2b461ff3
Signed-off-by: Sam Hague <shague@redhat.com>

Merge "Ignore testGetOpenflowVersion: it is no longer applicable"

Merge "Enable SSL connection for ovsdb server."

Enable SSL connection for ovsdb server.

Change-Id: I61213343be3aec2907b9b5d3b1f3446335d55fde
Signed-off-by: Hsin-Yi Shen <syshen66@gmail.com>

Ignore testGetOpenflowVersion: it is no longer applicable

The openFlow version is now determined by configuration's getProperty("ovsdb.of.version", "1.3").
Thus, the ovs version attribute (returned by ovs' OpenVSwitch table) is not used to determine what is
the openFlow version chosen by netVirtConfigurationService.

See: https://git.opendaylight.org/gerrit/#/c/11084/
     https://github.com/opendaylight/ovsdb/commit/2bc58c9cca16dc3e389cdfc18593578748fd52d5

Patch 2: include Sam's feedback

Change-Id: Icf4f3f633b2131a4521ef2509c02bcb0c7223abf
Signed-off-by: Flavio Fernandes <ffernand@redhat.com>

Merge "Add template unit-tests for bundles that don't have any."

Add template unit-tests for bundles that don't have any.

Change-Id: I2c08732fd83cfe6ad08bd2147791e9c650483e26
Signed-off-by: Sam Hague <shague@redhat.com>

Bug 2192 - Part 3 - Make ovsdb library not depend on ovsdb.utils.config

The ovsdb library is designed as Java modular component that can work in
both OSGi and non-OSGi environments. Thus, it should depend on as few
bundles/jar as possible.

Patch 4: Implement feedback from Sam H.

Change-Id: If2aca5ac2f2e883907e28d9ddb7986f0a5c8c1ab
Signed-off-by: Hsin-Yi Shen <syshen66@gmail.com>
Signed-off-by: Flavio Fernandes <ffernand@redhat.com>

Fix NeutronIT testGetTunnelEndpoint

The test was broken in that it attempted to update all fields of the OpenVSwitch
row. That is not valid due to immutable columns, such as _version.

Change-Id: I214e96914d85a0ca8321bf7c3e498f9a46f24f0e
Signed-off-by: Flavio Fernandes <ffernand@redhat.com>

Cleaning up code of InventoryServiceImpl to remove function updateOFBridgeName() that is never used.

Change-Id: I68e32b090ac8701cd08e252df294ef83785a6055
Signed-off-by: Srini Seetharaman <srini.seetharaman@gmail.com>

Update readme with minor corrections.

Change-Id: If002b736329482ac9f57a552506e13958c8eff27
Signed-off-by: Sam Hague <shague@redhat.com>

Bug 2192 - Part2 - Move getProperty() to a common util module

With this change, the calls to obtain non-default configurations for OVSDB
have been moved to a single function.

Patch 2: Rename utils.common to utils.config
         Remove utils.config dependency from common/parent/pom.xml (not needed by all)

Change-Id: Ibf7e1ee2747c5cafc59da97b5f1f8a4390d95ca2
Signed-off-by: Flavio Fernandes <ffernand@redhat.com>

Revert "Retructuring the utils folder to make it a broader toolkit beyond just a mdsal toolkit. This will make room for adding the config prop utils."

This reverts commit 353b7ec925f3a82aabf52bb21a40189397c5176e.

Change-Id: I73a57bc8d6c2fee5bb79838e99af1500e0b99cc1
Signed-off-by: Flavio Fernandes <ffernand@redhat.com>

Retructuring the utils folder to make it a broader toolkit beyond just
a mdsal toolkit. This will make room for adding the config prop utils.

Change-Id: I3df261ece22b9674c8e7a9cbd145ae766c961e64
Signed-off-by: Srini Seetharaman <srini.seetharaman@gmail.com>

Merge "Add missing feature dependencies to ovsdb karaf distro"

Add missing feature dependencies to ovsdb karaf distro

Change-Id: Ib2514bc331928e34a10ae2d7a257a1d1d2193cdd
Signed-off-by: Sam Hague <shague@redhat.com>

Bug 2076 - Routing does not work unless node contains vms on all vlans (segIds)

The logic for determining whether or not entries should be added to table 70 was
not taking into consideration the fact that vms on non-local vlans are also needed.

The fix simply fixes the logic used to filter out L3 fwd entries.

Change-Id: I0b7836a8f267c6346c24dad0adae6af87471dd57
Signed-off-by: Flavio Fernandes <ffernand@redhat.com>

Bug 2192 - Fix access to custom.properties, so non-default values can be provided

When OVSDB changed to use Karaf, the custom variables in config.ini got moved to
custom.properties. With that change, OVSDB was not grabbing its custom values from
the right place, causing all OVSDB related properties to get ignored.

Change-Id: Ic43d547e3d30e69c86718ac03314c4b74c61b561
Signed-off-by: Flavio Fernandes <ffernand@redhat.com>
(cherry picked from commit ff43d8c79ab0157a6d1b36f3c75c350878c66083)

Merge "Fix some compiler warnings."

Fix some compiler warnings.

1. Duplicated dependencies in many poms.
2. Dynamic versions for artifact ids.

Change-Id: I95ca1e1abd220b308a52e6b3d2b59bb978ec34fb
Signed-off-by: Sam Hague <shague@redhat.com>

Update README to include all current projects.

Change-Id: I417e14fffafbb0ac1ab33193c039d646c4e4dc25
Signed-off-by: Sam Hague <shague@redhat.com>

Add import statements for o.o.o.o.n.a.ConfigurationService

Change-Id: Id72133738a78dea3f4fb6b9c87bf726b1f6aeb04
Signed-off-by: Cédric Ollivier <ollivier.cedric@gmail.com>

Incrementing versions by 0.1.0 for post-Helium master branch

Change-Id: I83919752fe6ba2cbb2fbfd2ace0e060dd6b3f019
Signed-off-by: Colin Dixon <colin@colindixon.com>

Bug 2096 - LBaaS pool member deletion is not resetting rules properly

The LBConfig cloning is losing the segmentationID. This is fixed here.

Change-Id: If6f828fca09c3a02fa9bfc16ef97c439a702ae4a
Signed-off-by: Srini Seetharaman <srini.seetharaman@gmail.com>

Bug 2092 - Invalid code in LBaaS handlers that extracts MAC address of member without paying attention to the subnet-ID.

This prevent ID address overlap of LBaaS pools and wrong rules written to switch.

Change-Id: I9624a7e503810a5cbc8db0ca00b2cfc9d1dc8191
Signed-off-by: Srini Seetharaman <srini.seetharaman@gmail.com>

Merge "Bug 1806 - Null destination InetAddress in OF13Provider.handleInterfaceUpdate"

Bug 1806 - Null destination InetAddress in OF13Provider.handleInterfaceUpdate

The error is caused when ovsdb can not find the local_ip address from the open_vSwitch table other_config row. this address is used to get the src or dst ip address to be used for tunnels.

Added null chcks around the src and dst ip addresses. Log a warning if either is missing.

Change-Id: I57e0c69d699552d5ed07262210e25c8a4555ca66
Signed-off-by: Sam Hague <shague@redhat.com>

Merge "Bug 2013 Vlan flows needs merging from traditional rules to a single L2Fwding Service"

Bug 2013 Vlan flows needs merging from traditional rules to a single L2Fwding Service

Add fixes for the interface delete cases:
- include the latest rules that needed to be removed
- rework the bcast rule in the piece where a port is removed from the output list. The existing method assumed that the only actions in the apply actions case are all output actions, but the vlan bcast rule has an output to ethPort, followed by popVlan and then the output to flood ports. Also the md-sal does not maintain the order that rules were entered so that cannot be relied upon. This required creating anew method to handle the cases and ensure the proper actions are recreated.

Change-Id: Ie3438a0ecc73d0853ca1fdc01ba250bdd2794596
Signed-off-by: Sam Hague <shague@redhat.com>

Swap segmentation Id when routing between subnets

Fixes bug 2052
https://gist.github.com/803a61717fdc153fde5a

Change-Id: I4f61531d5e58cf7969e8a26f80cc2c015338da54
Signed-off-by: Flavio Fernandes <ffernandes@redhat.com>
Signed-off-by: Dave Tucker <djt@redhat.com>

Merge "Bug 2013 - Vlan flows needs merging from traditional rules to a single L2Fwding Service"

Bug 2013 - Vlan flows needs merging from traditional rules to a single L2Fwding Service

Patch set 2: Remove loogger in handleInterfaceUpdate.

Patch set 1:
Main problem is the vlan flows required two l2 tables, one for ingress and the other for egress. The existing flows made assumptions that those two tables existed. The pipeline changes reduced the l2 forwarding to a single table.

The classifier table has:
- unicast rules to take traffic from the local ports and tag them withthe tenant id
- ingress vlan rules to forward vlan tagged packets from the network
- drop everything else coming from the local ports

The l2 forwarding tables has:
- drop everything not matching the other rules
- unicast rules to forward traffic to the local port after stripping the tag
- broadcast rules to forward tagged packets to the network with the tag and to strip the tag and forward to the local ports
- catch all, forward vlan tagged packets to the network

The old rules looked like this:
Old rules:
1. table=0, in_port=2,dl_vlan=101 actions=goto_table:20
2. table=0, in_port=1,dl_src=fa:16:3e:9d:2e:27 actions=push_vlan:0x8100,set_field:101->vlan_vid,goto_table:10
3. table=0, priority=8192,in_port=1 actions=drop
4. table=0, dl_type=0x88cc actions=CONTROLLER:65535

5. table=10, priority=8192,dl_vlan=101 actions=output:2
6. table=10, priority=16384,dl_vlan=101,dl_dst=01:00:00:00:00:00/01:00:00:00:00:00 actions=output:2,goto_table:20
7. table=10, dl_vlan=101,dl_dst=fa:16:3e:9d:2e:27 actions=goto_table:20

8. table=20, priority=8192,dl_vlan=101 actions=drop
9. table=20, priority=16384,dl_vlan=101,dl_dst=01:00:00:00:00:00/01:00:00:00:00:00 actions=strip_vlan,output:1
10. table=20, dl_vlan=101,dl_dst=fa:16:3e:9d:2e:27 actions=strip_vlan,output:1

The new rules look like this.
1. table=0,in_port=1,vlan_tci=0x0000/0x1fff,dl_src=fa:16:3e:85:80:97 actions=push_vlan:0x8100,set_field:6097->vlan_vid,goto_table:20
2. table=0,in_port=2,dl_vlan=2001 actions=goto_table:20
3. table=0,priority=8192,in_port=1 actions=drop
4. table=0,dl_type=0x88cc actions=CONTROLLER:65535

5. table=110,priority=0 actions=drop
6. table=110,dl_vlan=2001,dl_dst=fa:16:3e:85:80:97 actions=pop_vlan,output:1
7. table=110,priority=16384,dl_vlan=2001,dl_dst=01:00:00:00:00:00/01:00:00:00:00:00 actions=output:2,pop_vlan,output:1,output:3,output:4
8. table=110,priority=8192,dl_vlan=2001 actions=output:2

In this example there is a router port and two vms on an openstack control node and a second compute node with two vms.

Compute + network node with two vlans and a vm in each vlan:
[odl@fedora41 devstack]$ sudo ovs-ofctl --protocol=OpenFlow13  dump-flows br-int
OFPST_FLOW reply (OF1.3) (xid=0x2):
cookie=0x0, duration=1594.264s, table=0, n_packets=29, n_bytes=2490, send_flow_rem in_port=4,vlan_tci=0x0000/0x1fff,dl_src=fa:16:3e:7a:12:25 actions=push_vlan:0x8100,set_field:6097->vlan_vid,goto_table:20
cookie=0x0, duration=1678.603s, table=0, n_packets=20, n_bytes=1376, send_flow_rem in_port=1,vlan_tci=0x0000/0x1fff,dl_src=fa:16:3e:85:80:97 actions=push_vlan:0x8100,set_field:6097->vlan_vid,goto_table:20
cookie=0x0, duration=1597.280s, table=0, n_packets=26, n_bytes=3220, send_flow_rem in_port=3,vlan_tci=0x0000/0x1fff,dl_src=fa:16:3e:6e:d8:df actions=push_vlan:0x8100,set_field:6097->vlan_vid,goto_table:20
cookie=0x0, duration=95.810s, table=0, n_packets=21, n_bytes=2042, send_flow_rem in_port=7,vlan_tci=0x0000/0x1fff,dl_src=fa:16:3e:13:e8:9b actions=push_vlan:0x8100,set_field:6098->vlan_vid,goto_table:20
cookie=0x0, duration=104.865s, table=0, n_packets=17, n_bytes=1138, send_flow_rem in_port=5,vlan_tci=0x0000/0x1fff,dl_src=fa:16:3e:6e:fd:9b actions=push_vlan:0x8100,set_field:6098->vlan_vid,goto_table:20
cookie=0x0, duration=101.849s, table=0, n_packets=26, n_bytes=3220, send_flow_rem in_port=6,vlan_tci=0x0000/0x1fff,dl_src=fa:16:3e:25:4a:26 actions=push_vlan:0x8100,set_field:6098->vlan_vid,goto_table:20
cookie=0x0, duration=102.857s, table=0, n_packets=19, n_bytes=1926, send_flow_rem in_port=2,dl_vlan=2002 actions=goto_table:20
cookie=0x0, duration=1676.601s, table=0, n_packets=26, n_bytes=2332, send_flow_rem in_port=2,dl_vlan=2001 actions=goto_table:20
cookie=0x0, duration=95.310s, table=0, n_packets=0, n_bytes=0, send_flow_rem priority=8192,in_port=7 actions=drop
cookie=0x0, duration=1596.706s, table=0, n_packets=0, n_bytes=0, send_flow_rem priority=8192,in_port=3 actions=drop
cookie=0x0, duration=101.339s, table=0, n_packets=0, n_bytes=0, send_flow_rem priority=8192,in_port=6 actions=drop
cookie=0x0, duration=104.364s, table=0, n_packets=0, n_bytes=0, send_flow_rem priority=8192,in_port=5 actions=drop
cookie=0x0, duration=1678.113s, table=0, n_packets=0, n_bytes=0, send_flow_rem priority=8192,in_port=1 actions=drop
cookie=0x0, duration=1593.762s, table=0, n_packets=0, n_bytes=0, send_flow_rem priority=8192,in_port=4 actions=drop
cookie=0x0, duration=1763.032s, table=0, n_packets=881, n_bytes=45681, send_flow_rem priority=0 actions=goto_table:20
cookie=0x0, duration=1763.868s, table=0, n_packets=0, n_bytes=0, send_flow_rem dl_type=0x88cc actions=CONTROLLER:65535
cookie=0x0, duration=1762.531s, table=20, n_packets=1065, n_bytes=63425, send_flow_rem priority=0 actions=goto_table:30
cookie=0x0, duration=1762.026s, table=30, n_packets=1065, n_bytes=63425, send_flow_rem priority=0 actions=goto_table:40
cookie=0x0, duration=1761.523s, table=40, n_packets=1065, n_bytes=63425, send_flow_rem priority=0 actions=goto_table:50
cookie=0x0, duration=1761.019s, table=50, n_packets=1065, n_bytes=63425, send_flow_rem priority=0 actions=goto_table:60
cookie=0x0, duration=1760.515s, table=60, n_packets=1065, n_bytes=63425, send_flow_rem priority=0 actions=goto_table:70
cookie=0x0, duration=1760.011s, table=70, n_packets=1065, n_bytes=63425, send_flow_rem priority=0 actions=goto_table:80
cookie=0x0, duration=1759.507s, table=80, n_packets=1065, n_bytes=63425, send_flow_rem priority=0 actions=goto_table:90
cookie=0x0, duration=1759.003s, table=90, n_packets=1065, n_bytes=63425, send_flow_rem priority=0 actions=goto_table:100
cookie=0x0, duration=1758.496s, table=100, n_packets=1065, n_bytes=63425, send_flow_rem priority=0 actions=goto_table:110
cookie=0x0, duration=1757.988s, table=110, n_packets=889, n_bytes=46261, send_flow_rem priority=0 actions=drop
cookie=0x0, duration=1593.258s, table=110, n_packets=22, n_bytes=2084, send_flow_rem dl_vlan=2001,dl_dst=fa:16:3e:7a:12:25 actions=pop_vlan,output:4
cookie=0x0, duration=1677.600s, table=110, n_packets=7, n_bytes=526, send_flow_rem dl_vlan=2001,dl_dst=fa:16:3e:85:80:97 actions=pop_vlan,output:1
cookie=0x0, duration=100.836s, table=110, n_packets=12, n_bytes=1024, send_flow_rem dl_vlan=2002,dl_dst=fa:16:3e:25:4a:26 actions=pop_vlan,output:6
cookie=0x0, duration=103.861s, table=110, n_packets=4, n_bytes=288, send_flow_rem dl_vlan=2002,dl_dst=fa:16:3e:6e:fd:9b actions=pop_vlan,output:5
cookie=0x0, duration=94.808s, table=110, n_packets=14, n_bytes=1616, send_flow_rem dl_vlan=2002,dl_dst=fa:16:3e:13:e8:9b actions=pop_vlan,output:7
cookie=0x0, duration=1596.275s, table=110, n_packets=12, n_bytes=1024, send_flow_rem dl_vlan=2001,dl_dst=fa:16:3e:6e:d8:df actions=pop_vlan,output:3
cookie=0x0, duration=102.354s, table=110, n_packets=30, n_bytes=3156, send_flow_rem priority=16384,dl_vlan=2002,dl_dst=01:00:00:00:00:00/01:00:00:00:00:00 actions=output:2,pop_vlan,output:5,output:6,output:7
cookie=0x0, duration=1676.095s, table=110, n_packets=32, n_bytes=3332, send_flow_rem priority=16384,dl_vlan=2001,dl_dst=01:00:00:00:00:00/01:00:00:00:00:00 actions=output:2,pop_vlan,output:1,output:3,output:4
cookie=0x0, duration=1677.102s, table=110, n_packets=24, n_bytes=2172, send_flow_rem priority=8192,dl_vlan=2001 actions=output:2
cookie=0x0, duration=103.359s, table=110, n_packets=19, n_bytes=1942, send_flow_rem priority=8192,dl_vlan=2002 actions=output:2

Compute node with two vlans and a vm in each vlan:
[odl@fedora42 devstack]$ sudo ovs-ofctl --protocol=OpenFlow13 dump-flows br-int
OFPST_FLOW reply (OF1.3) (xid=0x2):
cookie=0x0, duration=1406.878s, table=0, n_packets=21, n_bytes=2042, send_flow_rem in_port=1,vlan_tci=0x0000/0x1fff,dl_src=fa:16:3e:6e:46:15 actions=push_vlan:0x8100,set_field:6097->vlan_vid,goto_table:20
cookie=0x0, duration=151.628s, table=0, n_packets=22, n_bytes=2365, send_flow_rem in_port=3,vlan_tci=0x0000/0x1fff,dl_src=fa:16:3e:d6:cc:a8 actions=push_vlan:0x8100,set_field:6098->vlan_vid,goto_table:20
cookie=0x0, duration=149.620s, table=0, n_packets=18, n_bytes=1924, send_flow_rem in_port=2,dl_vlan=2002 actions=goto_table:20
cookie=0x0, duration=1404.872s, table=0, n_packets=15, n_bytes=1682, send_flow_rem in_port=2,dl_vlan=2001 actions=goto_table:20
cookie=0x0, duration=151.128s, table=0, n_packets=0, n_bytes=0, send_flow_rem priority=8192,in_port=3 actions=drop
cookie=0x0, duration=1406.379s, table=0, n_packets=0, n_bytes=0, send_flow_rem priority=8192,in_port=1 actions=drop
cookie=0x0, duration=1473.298s, table=0, n_packets=733, n_bytes=39306, send_flow_rem priority=0 actions=goto_table:20
cookie=0x0, duration=1474.295s, table=0, n_packets=0, n_bytes=0, send_flow_rem dl_type=0x88cc actions=CONTROLLER:65535
cookie=0x0, duration=1472.797s, table=20, n_packets=809, n_bytes=47319, send_flow_rem priority=0 actions=goto_table:30
cookie=0x0, duration=1472.286s, table=30, n_packets=809, n_bytes=47319, send_flow_rem priority=0 actions=goto_table:40
cookie=0x0, duration=1471.792s, table=40, n_packets=809, n_bytes=47319, send_flow_rem priority=0 actions=goto_table:50
cookie=0x0, duration=1471.291s, table=50, n_packets=809, n_bytes=47319, send_flow_rem priority=0 actions=goto_table:60
cookie=0x0, duration=1470.788s, table=60, n_packets=809, n_bytes=47319, send_flow_rem priority=0 actions=goto_table:70
cookie=0x0, duration=1470.286s, table=70, n_packets=809, n_bytes=47319, send_flow_rem priority=0 actions=goto_table:80
cookie=0x0, duration=1469.784s, table=80, n_packets=809, n_bytes=47319, send_flow_rem priority=0 actions=goto_table:90
cookie=0x0, duration=1469.282s, table=90, n_packets=809, n_bytes=47319, send_flow_rem priority=0 actions=goto_table:100
cookie=0x0, duration=1468.780s, table=100, n_packets=809, n_bytes=47319, send_flow_rem priority=0 actions=goto_table:110
cookie=0x0, duration=1468.278s, table=110, n_packets=736, n_bytes=39797, send_flow_rem priority=0 actions=drop
cookie=0x0, duration=1405.876s, table=110, n_packets=15, n_bytes=1682, send_flow_rem dl_vlan=2001,dl_dst=fa:16:3e:6e:46:15 actions=pop_vlan,output:1
cookie=0x0, duration=150.626s, table=110, n_packets=15, n_bytes=1682, send_flow_rem dl_vlan=2002,dl_dst=fa:16:3e:d6:cc:a8 actions=pop_vlan,output:3
cookie=0x0, duration=149.115s, table=110, n_packets=11, n_bytes=1256, send_flow_rem priority=16384,dl_vlan=2002,dl_dst=01:00:00:00:00:00/01:00:00:00:00:00 actions=output:2,pop_vlan,output:3
cookie=0x0, duration=1404.370s, table=110, n_packets=11, n_bytes=1252, send_flow_rem priority=16384,dl_vlan=2001,dl_dst=01:00:00:00:00:00/01:00:00:00:00:00 actions=output:2,pop_vlan,output:1
cookie=0x0, duration=1405.374s, table=110, n_packets=10, n_bytes=790, send_flow_rem priority=8192,dl_vlan=2001 actions=output:2
cookie=0x0, duration=150.122s, table=110, n_packets=11, n_bytes=860, send_flow_rem priority=8192,dl_vlan=2002 actions=output:2

Change-Id: I68d051d2b56a7dfc054ceb39996b013c8ae4fd74
Signed-off-by: Sam Hague <shague@redhat.com>

Merge "Bug 2041 - Fixing bug where the tunnel-id is not set in the LBaaS pipeline rules"

Merge "Bug 1859 - Remove the fake limitation that LBaaS only works with HTTP and HTTPS."

Merge "Bug 2036 - Adding code to parse dummy neutron port assigned for the VIP"

Bug 2045 - Egress / Ingress ACL swap broke the pipeline

Introduced by the fix for Bug 1752

Change-Id: Ibb4b23561871a6b076fe440b622842738076a930
Signed-off-by: Madhu Venugopal <mavenugo@gmail.com>

Bug 2041 - Fixing bug where the tunnel-id is not set in the LBaaS pipeline rules

Change-Id: I552ed7823d06851677fe133f2a750dc590ab52c8
Signed-off-by: Srini Seetharaman <srini.seetharaman@gmail.com>

Bug 1859 - Remove the fake limitation that LBaaS only works with
HTTP and HTTPS.

Now it allows all TCP ports. The user needs to take
caution not to lock themselves out by letting LBaaS take over
critical ports for direct access. The user also needs to ensure
that the members are all using same TCP ports.

Change-Id: I8bec4bf893446cf9478480d9cc9e76a8cb3ca9c9
Signed-off-by: Srini Seetharaman <srini.seetharaman@gmail.com>

Bug 2036 - Adding code to parse dummy neutron port assigned for the VIP

In case you wish to use the LB instance within a subnet without assigning
a floating IP, then you need to add a dummy neutron port to the subnet and
use the IP assigned to that as the VIP. The patch will pick that up and use
it in the reverse traffic rules.

Change-Id: I3e973cfe747c5c1dcb0e639734cdb291ac23210b
Signed-off-by: Srini Seetharaman <srini.seetharaman@gmail.com>

Merge "Bug #1752 swap egress/ingress ACLs"

Merge "Add L3 Forwarding Table to Pipeline"

Bug #1752 swap egress/ingress ACLs

Patch#2: updated comments

Change-Id: I6d0bb1c3f0e3245f128ad084df1a19cb3122af4f
Signed-off-by: Brent Salisbury <brent.salisbury@gmail.com>

Merge "Only use single Apply Actions instruction"

Add L3 Forwarding Table to Pipeline

Fixes bug 2033

Change-Id: Id1fdb87ea617d83d3d8c035993aa3b9abcbfb258
Signed-off-by: Dave Tucker <djt@redhat.com>

Only use single Apply Actions instruction

There should only be one Apply Actions instruction in an Instruction Set
Fixes bug 2029

Change-Id: I415a00c36e951b4b228cde60633b6361df23f77d
Signed-off-by: Dave Tucker <djt@redhat.com>

Bug 1705: Expect default gateways mac to be provided

Patch 4: Move check to caller of RoutingService::programDefaultRouteEntry()
Patch 5: noop

Change-Id: I115febb115134fb7c7af0d0264700c769c4e95ad
Signed-off-by: Flavio Fernandes <ffernand@redhat.com>

Merge "Bug 1915 : Configuration knob for enabling L3 fwd in OVSDB"

Bug 1695 - ignoring pipeline rules for any non-forwarding bridge

By design, the AbstractServiceInstance kept the isBridgeInPipeline as an abstract method for its child concrete Services
to determine the behaviour.

But, the most important and basic case of allowing the pipeline flows on br-int and ignoring on all other Bridge seems
reasonable default in AbstractServiceInstance. This can be overriden by child Services if need be.

In addition to this fix, have also introduced a minor delay in PipelineOrchestrator as soon as a Node event is observed.
This should workaround one of the basic bugs (1997) on the pipeline management case at the minimum.

Change-Id: I34f1d24d3f72695851bda4379483c8ea2b292308
Signed-off-by: Madhu Venugopal <mavenugo@gmail.com>

Bug 2004 - Fixing issue where local ports are not receivers for flood originating from another local port

The fix was to update classifier to track whether a flood is coming from local or
remote, and then matching on it to apply the enumerated flood action. The fix also
required OF13Provider to register local ports with the flood rule creation logic.

Reg0 is used by Classifier and LBaaS is moved to Reg1 + Reg2.

Change-Id: I619247349631f909dcc77177bd4cfe733afe7d50
Signed-off-by: Srini Seetharaman <srini.seetharaman@gmail.com>

Merge "Fixing files in resources that are for debugging help."

Bug 1915 : Configuration knob for enabling L3 fwd in OVSDB

OVSDB L3 fwd code will check for system property 'ovsdb.l3.fwd.enabled'
to determine whether it should be enabled upon OVSDB init.

To enable it, all that is needed is something like:
   echo 'ovsdb.l3.fwd.enabled=yes' >> ./configuration/config.ini

To disable, all that is needed is something like:
   sed -i -e 's/ovsdb\.l3\.fwd\.enabled\=.*$/ovsdb\.l3\.fwd\.enabled=no/'  ./configuration/config.ini

Change-Id: Ia00bcc0058b94d23b8497077241c5208ebae2081
Signed-off-by: Flavio Fernandes <ffernand@redhat.com>

Bug 2008 - Local Instance rules are failed to get programmed in L2FwdService table in presence of security groups

Change-Id: I0f628ba0099e3acfbbf06dfb381d35317647970d
Signed-off-by: Madhu Venugopal <mavenugo@gmail.com>

Fixing files in resources that are for debugging help.

1. Fixing puppet bootstrap for vagrant initialization. Currently,
it references to puppetlabs-release-saucy.deb that doesn't exist.
2. Adding postman collection for the LBaaS

Change-Id: I915d9a73e9865fb16d910b0971907acee63fc65c
Signed-off-by: Srini Seetharaman <srini.seetharaman@gmail.com>