git.opendaylight Code Review

Updated git submodules

Project: aaa master def725fc269a3f8f8526810b050b34a25966a4c2

Fix issues in checkstyle enforcement for module aaa-h2-store

- Copyright section
- Order imports
- Line lengths
- Remove IllegalCatch
- Improve exception handling
- Declare some static constants properly
- JavaDocs
- Move overloaded methods closer to each other
- Change variables and methods names
- Enforcement in pom.xml

Change-Id: If9ce15fdfcacaa7d94e56368cdf8c74b1b140ece
Signed-off-by: David Suarez <david.suarez.fuentes@ericsson.com>

Updated git submodules

Project: netvirt master abf0999ebb8ff9b3635f932808ab4d1ceba1d9d8

Bug 8581: DNAT failure with openstack/ocata

Problem Statement:
===================
DNAT traffic is getting failed because of missing DNAT flows in switch
(DPN). This issue was observed in openstack stable/ocata only.

Solution:
==========
Due to invalid check in NeutronPortListener.update(), certain FIP DS entry
where not populated and as a result, required DNAT flows where not installed.
Changes done to create required FIB DS entries properly.

Change-Id: Ia11a7e1d28288d762d26c3897d1612401d4ee8fa
Signed-off-by: cgowdru <chetan.arakere@altencalsoftlabs.com>

Updated git submodules

Project: netvirt master 2af3f3ebc2b9dbeb48e8a9cd29de86fcfa0385d3

elanName is null

Check for elanName. If null, return.

Change-Id: I72c931477c6d8ae464a654095383f8537ef6748e
Signed-off-by: Janki Chhatbar <jchhatba@redhat.com>

Updated git submodules

Project: netvirt master 5d61b15abfe8a630fda0f5e7884da9a53c89d514

Bug 8586: Alarm raised due to stale stats polling

Root cause - When port stats polling is enabled, first poll returns
old data (Rx bytes and Dropped bytes) when QoS alert was not enabled.
Alert may get logged if stale stats has dropped % > threshold value

Fix - Alert should not be logged based on first poll data. Use first poll data
to set the baseline counts and raise alert on subsequent polls based on the delta
of counts between the polls.

Change-Id: Ic12f3d41e7c0277109acc51ab548e1a7d0b4d13b
Signed-off-by: Arun Sharma <arun.e.sharma@ericsson.com>

Updated git submodules

Project: netvirt master dccba9d008ac0ef5ba531d0c9340b2cd10038189

Replace LOGGER by LOG

Replace LOGGER by LOG to follow the
OpenDaylight recommendations [1].

[1]
https://wiki.opendaylight.org/view/BestPractices/Logging_Best_Practices

Change-Id: I038b8fc9a16b7443fcdefcad1bc12283151ba503
Signed-off-by: David Suarez <david.suarez.fuentes@ericsson.com>

Updated git submodules

Project: integration/test master d007155581bc732cf0881386c855ad8787fb1449

Use different prefix for restarted producer

Change-Id: I9a3dda87bc890b8b7582e05729bc41688fb7adff
Signed-off-by: Peter Gubka <pgubka@cisco.com>

Updated git submodules

Project: netconf master a0bb7fc528753efe1d91a73d864ee9579f5697eb

Merge "Un-deprecate JSONRestconfService(Impl)"

Un-deprecate JSONRestconfService(Impl)

Patch https://git.opendaylight.org/gerrit/#/c/56391/ deprecated
JSONRestconfService and JSONRestconfServiceImpl however no reason
was given in the patch message (in fact the patch was about fixing
checkstyle violations) nor were any comments added to the classes
as to why they're deprecated.

There really shouldn't be any reason to deprecate these classes
as they are useful and are used in applications. Therefore I remove
the @Deprecated annotation.

Change-Id: I335c8e8665cc2b489e4d3b690d8cac7dbd157b4f
Signed-off-by: Tom Pantelis <tompantelis@gmail.com>

Updated git submodules

Project: aaa master eba846877031f734a570009638a44dfd795374ca

Merge "Fix issues in checkstyle enforcement for module aaa-cert"

Fix issues in checkstyle enforcement for module aaa-cert

- Copyright section
- Line lengths
- JavaDocs
- Order imports
- Declare some static constants properly
- Move overloaded methods closer to each other
- Returning variables directly
- Change variables and methods names
- Enforcement in pom.xml

Change-Id: I15fffbeb9de5f08e10aebd640437ddbbc97cf94b
Signed-off-by: David Suarez <david.suarez.fuentes@ericsson.com>

Updated git submodules

Project: aaa master df170b50c619021447cb6bdfc9f1a3f1a78c0b9b

Merge "Bug 8437: remove deprecated aaa-authn-store bundle"

Bug 8437: remove deprecated aaa-authn-store bundle

This was deprecated long ago. This is the removal of the bundle.

Change-Id: I42caef0fe749a7d52a1e0cbf8a2440bbaf93d548
Signed-off-by: Ryan Goulding <ryandgoulding@gmail.com>

Updated git submodules

Project: netconf master 8806a5c53252ca592562d681c4a1963fcffbe4eb

BUG 8566 direct writes to ordered list fail

Incorrect handling of direct writes into a mapEntry which tries
to merge an empty parent list instead of an exists check but doesnt
correctly handle the possibility of an OrderedMapNode as a parent.

Change-Id: Ia2c75cc50e6ff4c9c7c9be36846c08cc85cff491
Signed-off-by: Tomas Cere <tcere@cisco.com>

Updated git submodules

Project: integration/test master a33b3319276f4b606f7966e178ec067cb6c30339

Increase http timeout for shard stability to 2m

Change-Id: I0db5a818b543389c727ec16fb525f4ab74d088e8
Signed-off-by: Peter Gubka <pgubka@cisco.com>

Updated git submodules

Project: genius master 394b52de43d8cf2df981f65c3fc7df73bc4ddf5b

Merge "Simplify boolean expressions"

Simplify boolean expressions

Change-Id: I09d1f3a22a5496f3dbf8281a378c9eea4112e68f
Signed-off-by: Stephen Kitt <skitt@redhat.com>

Updated git submodules

Project: genius master 8418bff8fdafbd48dfafe86603dfa82bb2907199

Merge "Make testutils a JAR instead of a POM"

Make testutils a JAR instead of a POM

and start to use it for holding test fakes of genius APIs

Change-Id: Iaa44b3c7031f2d5a6129354e993157f8eb82680d
Signed-off-by: Michael Vorburger <vorburger@redhat.com>

Updated git submodules

Project: netvirt master 648861894b7e36fdcef028e991cffdd416d63811

Clean up Optional uses

This patch reverts Optional and related streaming uses where they
result in more convoluted code than necessary (or, in the case of
Optional, where Optional instances are created only for conditions).

Change-Id: I8d0b2c456ff0a477e440fb029b8495476aabed27
Signed-off-by: Stephen Kitt <skitt@redhat.com>

Updated git submodules

Project: releng/builder master 002b9147e8ea4ac1d83543ac89663b45c1c0ecf0

Use -m pip from python instead of pip directly

When the workspace is too long, as can happen with long
job names, there is trouble running commands in the
virtualenv.

this is trying to find all the places this would be
needed, but specifically to address a few current
problems like [0] which sometimes completes but cannot
push logs because the job name is too long.

The idea came from shague [1] which came from
openstack [2].

[0] https://jenkins.opendaylight.org/releng/user/jluhrsen/my-views/view/netvirt%20csit/job/netvirt-csit-1node-openstack-newton-nodl-v2-upstream-stateful-snat-conntrack-carbon/
[1] https://git.opendaylight.org/gerrit/#/c/51699
[2] https://review.openstack.org/#/c/399754

Change-Id: I9e99893d8de69ef0eb7b36309983cedc0befb549
Signed-off-by: Jamo Luhrsen <jluhrsen@redhat.com>

Updated git submodules

Project: netvirt master cd8f85bb86ef6549f4e0251ceae49e3c520278f2

Replace logger and log by LOG

Replace logger and log by LOG to follow the
OpenDaylight recommendations [1].

[1]
https://wiki.opendaylight.org/view/BestPractices/Logging_Best_Practices

Change-Id: Ia4f5a1c1692133efa0e49873ba954a360572989b
Signed-off-by: David Suarez <david.suarez.fuentes@ericsson.com>
Signed-off-by: Sam Hague <shague@redhat.com>

Updated git submodules

Project: netvirt master 7365717f35ca522b09523695672f935a57934199

Bug 8589: Fix regression in Ipv6PktHandler

Following this change [1], Ipv6PktHandler is not getting
invoked for RS/NS meant for router interfaces. This patch
fixes this issue.

[1] https://git.opendaylight.org/gerrit/#/c/54389/

Change-Id: I5b98b742623df2552205f8bbb24d70ae17ba1325
Signed-off-by: Sridhar Gaddam <sgaddam@redhat.com>

Updated git submodules

Project: genius master 4123b9c7c7c2e43b2bb6f6b307a18f805d36bc69

EVPN RT2 : L2VNI Demux Table id

For EVPN RT2 a new table(table 24) is introduced to demux the l2vni from packets
coming from DC-GW

Spec is approved and is available at : https://git.opendaylight.org/gerrit/#/c/51693/

Change-Id: Ie23457df4d9d20a01f53e271c5b7ece77342225f
Signed-off-by: Vyshakh Krishnan CH <vyshakh.krishnan.c.h@ericsson.com>

Updated git submodules

Project: netvirt master 8473f8298999238c8e744945979a9b17bd36eff9

Use named constants in ElanUtils

... instead of commented true or false.

Change-Id: I7f0738f11666f9433ae0942b2be538514d08311b
Signed-off-by: Stephen Kitt <skitt@redhat.com>

Updated git submodules

Project: aaa master 324f0822ea4be98c9eaeba530a8f179900d98865

Fix issues in checkstyle enforcement for module aaa-idmlight

- Copyright section
- Order imports
- Line lengths
- JavaDocs
- Improve exception handling
- Change variables and methods names
- Move variables closer to their use
- Move overloaded methods closer to each other
- Declare some static constants properly
- Enforcement in pom.xml

Change-Id: Ic673b8239c3abd7ba0c23a242293fe32cc48b103
Signed-off-by: David Suarez <david.suarez.fuentes@ericsson.com>

Updated git submodules

Project: aaa master dd026c6a5140cfd44c466c8df70ed88a876fee43

Merge "Fix issues in checkstyle enforcement for module aaa-cli"

Fix issues in checkstyle enforcement for module aaa-cli

- Copyright section
- Line lengths
- JavaDocs
- Order imports
- Declare some static constants properly
- Remove IllegalCatch
- Change variables and methods names
- Enforcement in pom.xml

- Move overloaded methods closer to each other
- Returning variables directly

Change-Id: I4bd93465b43610cfd931b104803142b371c42240
Signed-off-by: David Suarez <david.suarez.fuentes@ericsson.com>

Updated git submodules

Project: netvirt master 1ca3d9bd99330507c013476046d7756944833973

Use direct comparisons instead of Objects.isNull

There is no reason to ever use Objects.isNull() directly, it’s
equivalent to “== null”. Its documentation explains its purpose: “This
method exists to be used as a Predicate, filter(Objects::isNull)”.

Change-Id: I86123fec65c09a1d26906935cad6df79750fa2d8
Signed-off-by: Stephen Kitt <skitt@redhat.com>

Updated git submodules

Project: netvirt master 37c5ed8eae135d6be93b277a96568b2a6b421d60

Bug 7451 - VPN service cleanup of Table 17

Whenever a VM is deleted (or) a VPN where a VM
resides in is removed, the dispatcher-table
entries for that VMs VPN Interface were not
getting removed.

The fix here makes sure that dispatcher Table
(Table 17) gets cleaned up by VPN Service.

The related ELAN patch to clean up dispatcher
table for ELAN service entries is here;
https://git.opendaylight.org/gerrit/#/c/57767

Change-Id: I6460b8a12a37236275e72606bc58c4b59db440cb
Signed-off-by: Vivekanandan Narasimhan <n.vivekanandan@ericsson.com>

Updated git submodules

Project: netvirt master 1d84249e86cf09402280d09361c72760f76ab3f7

SNAT performance improvement for Controller-Based SNAT

Description :
Following changes were done to address SNAT performance improvement
in following area.

1) Seperate Queue for first SNAT packet, retry packet and Flow removed
event on Idle Timeout.
2) Multithreading: using 25 threads for processing first SNAT packets, 25
thread for processing retry packets and 1 thread for processing Flow
Removed event.
3) Updated checkIpPortMap API to have direct query based on routerid,protocol,
internalip+port criteria thus preventing unnecessary looping.
4) Moved the code of getting externalMac Address and external address to
get executed only for first packet, thus preventing the retry packet from
executing it which is unnecessary.

Change-Id: Ib34aa8726295381d0e4ffd1f3cec74292d422c4f
Signed-off-by: cgowdru <chetan.arakere@altencalsoftlabs.com>

Updated git submodules

Project: netvirt master b1b96e5ee69f56038d615657f9ab7b3d9166ce43

Bug 8417 - [l3vpn_ecmp] Deleting MPLS GRE Tunnel port doesn't delete the

bucket entry in the group

Change-Id: Ic7287a9611bf27453713e47f6dde11373fea3172
Signed-off-by: epgoraj <p.govinda.rajulu@ericsson.com>

Updated git submodules

Project: netvirt master bc9b27f2a0d061187dbf883937e7bfbb953c0415

Revert "Revert "Minor Checkstyle fix Custom Import Order error""

This reverts commit 0cb7bc37f4a94363ddb994c07fa43611d57edddd.

Change-Id: I1155651e318112ef3b8b2c0a8b8a3304399f98a7
Signed-off-by: Sam Hague <shague@redhat.com>

Updated git submodules

Project: netvirt master 9f3cdb6ca6e5ed380f681ede998ce3ae225ca6f6

Bug 7451 - Leftovers in dispatcher table when unbind and ietf-state delete

occurs simultaneously

Change-Id: Id3c44e94da203ddda9dbc3e6fb8b6885523c7fa3
Signed-off-by: epgoraj <p.govinda.rajulu@ericsson.com>
Signed-off-by: Periyasamy Palanisamy <periyasamy.palanisamy@ericsson.com>
Signed-off-by: Sam Hague <shague@redhat.com>

Updated git submodules

Project: netvirt master a36f28ba0a308379f55d114b0935faaa5446fe64

Bug 8498 - ICMP traffic from DHCP NS not blocked when ICMP rule to allow
VM-VM traffic is added in learn mode.

The wrong filter table to be used for learn ingress/egress service is
fixed.

Change-Id: I15e8841314c24b10556128bac354ebab1d80a698
Signed-off-by: Aswin Suryanarayanan <asuryana@redhat.com>

Updated git submodules

Project: genius master 7c9093e831fb84e1feb2fce6b39c3de6c061d305

Merge "Utility api to configure icmpv6 type"

Utility api to configure icmpv6 type

Change-Id: I6c7f2def23e043872957d5272f0fe1217f323c8b
Signed-off-by: Sridhar Gaddam <sgaddam@redhat.com>

Updated git submodules

Project: netvirt master 2af664ef2272c3d1fcb12096d921f8a9ddd1ba7e

Add JUnits for InterVpnLinkLocator

+ Only 2 so far:
    -  testFindInterVpnLinksSameGroup
    -  testSelectSuitableDpns_moreDpnsThanIvpnLinks

+ It adds an L3vpnCatalog that contains several VPN test data
   to play with

+ Idem with InterVpnLinkTestCatalog

Change-Id: I1c6866ec5fe2570a469dd9ea9e5a6591d11dffa4
Signed-off-by: Miguel Perez <francisco.miguel.perez@ericsson.com>

Updated git submodules

Project: netvirt master 6e97b0cd7c528460f989e65b06a0c1c12a38afab

Fix a few non-null collections

In general, methods returning collections should never return null.
This patch fixes L2GatewayConnectionUtils and propagates the non-null
results.

Change-Id: If249aec9b8494de736c362f0ea04139151670d68
Signed-off-by: Stephen Kitt <skitt@redhat.com>

Updated git submodules

Project: netvirt master 29478b32eac8dee2489d1381e81f3d0e7af33cea

Bug 8376: Fix DHCP for external tunnels

DHCP for external tunnels does not work with neutron
DHCP server.

ODL is installing rules to punt DHCP packets received
on external tunnels to controller, even when ODL
DHCP is disabled. But, since ODL DHCP is disabled,
no DHCP response is sent by ODL. And, with these
rules installed, neutron dhcp server never sees the
DHCP packet. As a result, VM will not get IP
address.

Do not start listeners that are responsible for
installing DHCP rules to punt DHCP packets to
ODL controller when ODL DHCP is disabled.

Change-Id: Ib0e243a9bca5866e50a5d1cb4c70cd4441dd01e6
Signed-off-by: Victor Pickard <vpickard@redhat.com>

Updated git submodules

Project: netvirt master 863c01607b901d60df01da1df9a9d9c8aaa26436

BUG:8341 IAE seen in CSIT logs when port/vlan name is not matching UUID

Change-Id: If90482540cc5cc7c28d16397f84a39f3774eab7b
Signed-off-by: epgoraj <p.govinda.rajulu@ericsson.com>

Updated git submodules

Project: netvirt master 2966a98cfaf35f11de2214135e7c761cff2f4a4f

bug 7599 hwvtep ucast mac add performance improv

Changes for performance improvement.
Added new Cmd TunnelIpCommand and also changed function getKey to return
actual key Identifier in place of String value.

Change-Id: I0fd84c87db6feefcba4c119fe0c05193751ab8cb
Signed-off-by: Akash <a.k.sahu@ericsson.com>

Updated git submodules

Project: netvirt master 193552e98e3894ef72ac4ea7bebb3cea14b7ef1d

elanmanager-impl <dependency> interfacemanager-impl <scope>test

It is wrong to directly depend on interfacemanager-impl from
elanmanager-impl. This may only be done with <scope>test, for component
tests.

Remove the sole usage of a util from ITM - genius has the same util.

Change-Id: I0dda82184d547cefa5a447361111438ed3fe40c1
Signed-off-by: Michael Vorburger <vorburger@redhat.com>

Updated git submodules

Project: netvirt master 1e406c3a3fe9c3c43f341fcc1db8ee60661a1705

Use named constants for PolicyAceFlowWrapper

Instead of commenting each use of true or false, use constants.

Change-Id: Ibf8b19b67dc54e99e6caffe8056a0e04b62601c2
Signed-off-by: Stephen Kitt <skitt@redhat.com>

Updated git submodules

Project: netvirt master f0137f7215d3579edeaf382213c0ef71f63a36a2

Adjust tunnel state listeners for logical tunnel

If the logical tunnel exists between the source and destination DPNs it will
be set as the lport-tag of register6 in the remote nexthop actions.

Spec: https://git.opendaylight.org/gerrit/50779/

Change-Id: I98ff89efd047e056529e4bbdf06493e548c561d1
Signed-off-by: Olga Schukin <olga.schukin@hpe.com>
Signed-off-by: Sam Hague <shague@redhat.com>

Updated git submodules

Project: coe master bc3bcb560ffd019226d5b1947b01399400cbd015

Altered the name of configure_csc script to configure_odl

Change-Id: I06d15384a7359419d5830f36c56e43c330c8e41b
Signed-off-by: Rihab Banday <rihab.banday@ericsson.com>

Updated git submodules

Project: coe master bc24ef7460b00ea8d1615671cfdb2c9ab1401644

Added get-ip script referenced by cni-odl

Change-Id: I2222a2b1f3247be04ed56c9b79ff9d94b21e5e7b
Signed-off-by: Rihab Banday <rihab.banday@ericsson.com>

Updated git submodules

Project: coe master dd6647db63b492de81ba2789a17d9a268ba970e6

Modified cni-odl with new ip address allocation mechanism; added get-ip script referenced by the file

Change-Id: I9a9acc1058d241020e3728b00d0df5f57565f488
Signed-off-by: Rihab Banday <rihab.banday@ericsson.com>

Updated git submodules

Project: netvirt master 761ddac1b5ebc6f625555a29bbb3a3a775fed473

BUG:8232 updating BGPVPN with the List of RDs

       *Problem: When a new Extra-route is added and if there are not enough RDs
        for the VPN then the new extra-routes are not handled.
        These unprocessed extra-routes will be handled during vpninstance update
        (ie when new RDs are added(Update) to the existing VPN)

Change-Id: Ic380b6aaabdd0d44484c2ec1a33de7cde9c01366
Signed-off-by: epgoraj <p.govinda.rajulu@ericsson.com>

Updated git submodules

Project: netvirt master 89e81c08e8677e679b24181c5cea7f735700ddb7

Fix Unused log and private final

Delete unused log and their imports.
Change initailized private final var to
private static final in order to use less memory.

Change-Id: Ieecaf3cf75ac67b55e2bfd87c1c78eb1bbd77782
Signed-off-by: mcauffiez <mcauffiez@inocybe.com>

Updated git submodules

Project: netvirt master aad19ee8e896c4e8a8cd79dbd2686bae44930a8e

EVPN RT2 : Silent host changes

When the flow created on packet received from silent host expires,
prefix is removed from macEntry container and prefix is withdrawn,
There is no necessity to withdraw prefix from here, it will be
duplication.

Change-Id: Iab970736a182efaddf4dfc44a5a11377ca22b111
Signed-off-by: Yugandhar Reddy Kaku <yugandhar.reddy.kaku@ericsson.com>

Updated git submodules

Project: netvirt master 399407168cfd710003ca9f49a90bd5e886aa5ed9

Bug 8508 : Id-manager exception during releasing id for router

Description : Even though opendaylight-semantics is disabled,
the following EVPN NAT use-cases require VNI to be allocated from
OpenDaylight VNI Pool:

a. All traffic on external network will be using a VNI allocated for the
external-VPN aka Internet VPN.

b. Similarly all traffic from Non-NAPT switch to NAPTSwitch will be using
the VNI allocated for the router from the OpenDaylight VNI Pool.
For VNI-L3-L3 Fowarding feature also, a VNI must be allocated for every
router from the OpenDaylight VNI Pool as that VNI will be used for
Non-NAPT to NAPTSwitch traffic.

This fix makes that allocation as only release alone was done earlier.

Changes done to allocate a vni for router(when router-gatway-set done)
and been released during ext-router entry is deleted. In CSIT(having
non-EVPN use-case) were executed, an attempt to release the non-allocated
id was done during when ext-router entry is deleted resulting in exception.
Change done to make sure an id is allocated when router-gateway-set is done to
prevent such occurance of exception.

Change-Id: Ic1e696d6b4c8d0c56eac8b16ed0731d072b5b135
Signed-off-by: cgowdru <chetan.arakere@altencalsoftlabs.com>

Updated git submodules

Project: netvirt master c2367b94f9264b7a635e5d253c2bfdc70515839d

Bug 8539: IPv6 L3 Forwarding broken.

The merge of the following review;
https://git.opendaylight.org/gerrit/57145
broke L3 Forwarding for IPv6 addressed ports.

The fix here addresses the breakage by making
sure that L3_GW_MAC_TABLE entries are filled
correctly for both IPv4 and IPv6 router-interface
ports, before embarking on writing PING
Responder flows for IPv4 based router-interfaces.

Change-Id: Ieb190edda470264006609c62e4af9fc0d94d4a2c
Signed-off-by: Vivekanandan Narasimhan <n.vivekanandan@ericsson.com>

Updated git submodules

Project: releng/builder master 08788236830ef4f7d667d395d75b86f766f27195

Remove auto job creation for Beryllium

now that Carbon is released, we are no longer dealing
with Beryllium

Change-Id: Iae74afd9742b03b9ba1e6907a8e3bfd335c4a00e
Signed-off-by: Jamo Luhrsen <jluhrsen@redhat.com>

Updated git submodules

Project: aaa master 76cc4054ec1442f906b8dd5a52289e95904b46c3

Bug 8437: Move oauth2 functionality into the shiro module

odl-aaa-shiro is the only consumer of the oauth2 functionality in ODL.
The fact that aaa-authn-sts is aggregated as a separate bundle for
this functionality is confusing and superfluous. This change moves
the functionality, does some good renaming, and puts in some docs
surrounding the current status of aaa-authn-sts and aaa-shiro.

This change was tested manually with odl-restconf and works
correctly.

In the future, in a follow up, aaa-authn-sts will be completely
removed. For now it is still keeping track of the various "services"
that we are working to converge.

Change-Id: Id9cc5bd70e0866d72b712ddc559c1cd0154268d9
Signed-off-by: Ryan Goulding <ryandgoulding@gmail.com>

Updated git submodules

Project: netvirt master eb9a7c091b4661eeb20a058a84a0dd736eaf8c56

Bug 8485 : EVPN was also coming as Layer_3 VRF

Problem:
Even after configuring EVPN Layer 2 VRFs in quagga its coming as EVPN Layer 3 VRFs.

Solution:
Changes to modify the layer type was missing in VPN engine

Change-Id: I8f45b06c02f3920512f16563d77b13b8ba076a9d
Signed-off-by: Vyshakh Krishnan CH <vyshakh.krishnan.c.h@ericsson.com>

Updated git submodules

Project: genius master 95995cc876e8fc8ecf9822f706ab76947511be51

Merge "Make ActionInfo.toString() generic"

Make ActionInfo.toString() generic

Subclasses don’t need to override it, so use the actual class name in
toString() (for example, ActionDrop can “just work”).

Change-Id: Idf68b65867e4cb8ba969d1db91ee5a4b03389c06
Signed-off-by: Stephen Kitt <skitt@redhat.com>

Updated git submodules

Project: odlparent master 96c5d1630019ccc8b4484a91bdb3119a02e77aba

BUG-4219: fix karaf CLI reload

Controller's blueprint extenstion is pulling in an optional
dependency of pax-logging, causing it to reload, effectively
restarting everything. Wire osgi-service before starting up
to eliminate this.

Change-Id: Idf0170d805e98362e7f3560db7f166c68a18d19d
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Updated git submodules

Project: netvirt master a62846380ada2a042243647ad85778817957a2d2

Bug 8358 - Local next hop group not deleted after VM migration

Issue:

When a VM is migrated from one DPN to another, the FIB flows are not
programmed for the VM in the DPN to which it is migrated.

Analysis and Fix:

The l3nexthop container is used to check whether the local next hop group
is already present for a prefix. If it exits, no new group is created and just
the reference count is increased. When this prefix is removed, this
reference is decreased & the group is removed when the reference count is
0. It was observed that for the first VM creation, the reference count is
2(it should be 1) because of redundant calls to createlocalnexthop. A
check has been added to prevent this.

Also some other minor fixes have been done related to ECMP

1. The addition/deletion of extra route also changes the above mentioned
flow reference count. This caused problems while just updating the
extraroutes(the flow reference count keeps increasing and so the local
next hop group would never be deleted). Now, the addition/deletion of
extra routes doesnt change the flow reference count in the l3nexthop DS.

2. When there is no change in routepath of the extraroute(updated extra
route also present in the same DPN), there is no change in odl-fib DS and
so handling has been added to implicitly call the refresvrfEntry which
would update the FIB flows.

Change-Id: I4d7b435aed73268383b36e1c635c499c71e54c60
Signed-off-by: gobinath <gobinath@ericsson.com>

Updated git submodules

Project: integration/test master 3f23459066c7630fc532d8249ed5e09acdb6da2b

Remove beryllium specific tests and testplans

Change-Id: Id34a84e2591f5dbf57888b20c14c28c79bd14899
Signed-off-by: Peter Gubka <pgubka@cisco.com>

Updated git submodules

Project: releng/builder master 187770b9d3918a4d9a5528c29780af96e2ce5b74

Auto Update CSIT Jobs to run

Change-Id: I469ed201c7fccc20a93e39d9a8accdc4941e5bad
Signed-off-by: jenkins-releng <jenkins-releng@opendaylight.org>
Signed-off-by: Jamo Luhrsen <jluhrsen@redhat.com>

Updated git submodules

Project: aaa master 92500eb8af692b81cd0befdd74f7c3439efdaa54

Merge "Fix a gitignore and accidentally added file"

Fix a gitignore and accidentally added file

Change-Id: I15bd3190baa5298d953e2cfa52ed8dfed13b8418
Signed-off-by: Ryan Goulding <ryandgoulding@gmail.com>

Updated git submodules

Project: netvirt master 0fff130ba2c2a2815b53e9da13b748c708b3429e

Bug 8412 - NPE while adding and removing elanmacentry

1. While advertising RT2 route prefix is Optional, hence added a safer
null check. if prefix is not present, still go ahead and advertise RT2
route
2. During withdraw if prefix is not present, return with error log.
3. Remove the elanName null check as its never null.

Change-Id: I3009bb9d19f3413d448031ff47771a986ef10746
Signed-off-by: Janki <jchhatba@redhat.com>

Updated git submodules

Project: netvirt master cd053e3d6b745897b912dac4cb9ee3437836ebc4

BUG 8537: Get destination from interface remote ip

Genius will not set the tunnel destination IP address until the very
last action. Classifier egress cannot expect to have this IP address
available on it's own pipeline.

Solve this by setting the IP address on REG0 on the egress service
binding actions. This will be the remote IP of the bound interface in
case of tunnel or the local IP otherwise.

To avoid overuse of registries, a REG is no longer used to set the
SFF IP address on table 101. This IP will be set directly on the path
specific flows of table 223 if needed. Previously this REG was being
used to know if the SFF was remote by comparing with the local IP in
these flows but that is not needed as it can be known at configuration
time.

Change-Id: If7a474391ed2d643cc3b3f34743d60c5f418b2e5
Signed-off-by: Jaime Caamaño Ruiz <jaime.caamano.ruiz@ericsson.com>

Updated git submodules

Project: netvirt master 7d8b86941a9b8d664afbc92d2df61fa26bb95310

Replace toUpperCase().equals by equalsIgnoreCase()

Change-Id: I54ac6903362c15c6caab05810861de852d2619a5
Signed-off-by: David Suarez <david.suarez.fuentes@ericsson.com>

Updated git submodules

Project: netvirt master e9030481cd8052227d74c4c38e5ae2c25fe9cee2

BUG-3874: BGP Manager / fib-show shell cmd triggers an exception on
usage

When using fib-show, instead of displaying null label, the string <not
set> is displayed.

Change-Id: I563bb3ff435cba94ba1e918ea09cbf7be6ae7f91
Signed-off-by: Philippe Guibert <philippe.guibert@6wind.com>
Signed-off-by: Sam Hague <shague@redhat.com>

Updated git submodules

Project: genius master 57cd4eb4079da02c7ffcf2550d8daaf509e9e74e

Remove TestableDataTreeChangeListenerModule from ResourceManagerTest

It's currently not used anyway, and (because it's not used!) it can
occasionally cause the "heisenbug" (i.e. arbitrary test failure on some
runs, but not always) problem "IllegalStateException: Test forgot an
awaitEventsConsumption()".

see also (new) doc on
https://wiki.opendaylight.org/view/BestPractices/Component_Tests#Async

Change-Id: I8140df5e06b1b35deae4d4137af768c2c275b68b
Signed-off-by: Michael Vorburger <vorburger@redhat.com>

Updated git submodules

Project: aaa master 9d73469fe4d723d710d45bf1c2940b112f38ead4

Remove unused UnauthorizedException

This is not used, and should be removed.

Change-Id: I3e9390df44652d153565f97dab8f390f2b7339f3
Signed-off-by: Ryan Goulding <ryandgoulding@gmail.com>

Updated git submodules

Project: netvirt master 781815434f154a98f8f0d9cb2cfd61e80265f0d6

cleanup differences between master and carbon

Change-Id: I792ff3d5193438800b2e8001d1edb309ad0c7909
Signed-off-by: Sam Hague <shague@redhat.com>

Updated git submodules

Project: genius master f1c3d0c82a67b6392bd1794c833fba50ada04db9

Add missing @Override and serialVersionUID to genius.mdsalutil

Change-Id: Ib1079a5c59390d9b902d8f6653931f9c62ecf7ac
Signed-off-by: Michael Vorburger <vorburger@redhat.com>

Updated git submodules

Project: infrautils master 43f8ed810b5c2cfcf65e45eddbe91bab4a702a80

Bug 8415: SystemReadyImpl using ready-lib instead of bundles4test

This is required after 5a5c88b66af3e63532472ed02cfec99342369c07

Change-Id: I66ebbdd659b67cc841d1279ef62fda2431f5e115
Signed-off-by: Michael Vorburger <vorburger@redhat.com>

Updated git submodules

Project: genius master d4bb95042b34d8a4c907ea7a53e474456e00abcb

Merge "Add Unit Test (only) for ActionDrop equals"

Add Unit Test (only) for ActionDrop equals

as a reminder that ActionDrop's equals actually works just fine, even
though it's not overriden (because ActionInfo's equals() has a
getClass() != other.getClass()) ... this confused me for a moment, and a
suspected a classical hashCode / equals bug - but it's actually fine as
is - this new test serves as a regression assurance - and as a "reminder
in code".

Change-Id: I0916b238d23f86e7248beefa68a5b4851da9e9ab
Signed-off-by: Michael Vorburger <vorburger@redhat.com>

Updated git submodules

Project: genius master 6bdf04b81571e2acf693c555febbb42b6722e123

Merge "Add yangtools:testutils to mdsalutil-testutils"

Add yangtools:testutils to mdsalutil-testutils

To make it possible to depend on mdsalutil-testutils in a new component
test for netvirt fibmanager, without having to declare a dependency to
yangtools:testutils (one should not have to).

Change-Id: Ia54921fb24edc0a37f03974be960a6b6b4bfe317
Signed-off-by: Michael Vorburger <vorburger@redhat.com>

Updated git submodules

Project: genius master b5f656cf54661bf12cf99ab0ae43c05e402c0949

Merge "Support for moving Src/Dest IPv6 addresses in NxRegMove action"

Support for moving Src/Dest IPv6 addresses in NxRegMove action

Depends-On: https://git.opendaylight.org/gerrit/#/c/56969

Change-Id: Ib4ba7baf50416b4e6e43705fbf796f65f4e00aa7
Signed-off-by: Sridhar Gaddam <sgaddam@redhat.com>

Updated git submodules

Project: genius master 455abc3969f2cd154762acc7bae0a399a4f39c76

Merge "Support API that configures IPv6 address as sourceAddress"

Support API that configures IPv6 address as sourceAddress

Change-Id: I23e2f04315ca023be9886d7e1570f78230b65dd7
Signed-off-by: Sridhar Gaddam <sgaddam@redhat.com>

Updated git submodules

Project: integration/test master cb65e7e5826bdd4b6d3af6909fb858aa4f94c1f8

Fix exabgp flowspec config

Change-Id: I3a732b1cfdd671d35c826bfdee94bceab04cd3ff
Signed-off-by: Claudio D. Gasparini <claudio.gasparini@pantheon.tech>

Updated git submodules

Project: aaa master 95dd6c9e09c446d79fa1dc9c9bb9127084e7d042

Merge "Bug 8572: Remove unused SecureBlockingQueue"

Bug 8572: Remove unused SecureBlockingQueue

This is unused and needs to be removed.

Change-Id: I141af03f6852bb69fbc8518eb7cf10e685cebca4
Signed-off-by: Ryan Goulding <ryandgoulding@gmail.com>

Updated git submodules

Project: aaa master a5ef66ccc7664c3cbeadb71569af2cfe027d7c8a

Merge "Fix issues in checkstyle enforcement for module aaa-shiro-api"

Fix issues in checkstyle enforcement for module aaa-shiro-api

- Enforcement in pom.xml

Change-Id: I4b0e3a696b8f1b8b5486fd5500f960126cd6887f
Signed-off-by: David Suarez <david.suarez.fuentes@ericsson.com>

Updated git submodules

Project: odlparent master f0866fbc2f36c899f38280c226eac0ef99a0e3e1

Remove remote repositories

Our ODL Karaf distributions should never download artifacts from
maven.org or repository.springsource.com (we prepare an offline Maven
repo under the system/ directory in our Karaf distribution during
build).

This also adds the missing Apache Aries Quiesce API to system/ to fix
another problem; this may always have gotten downloaded at runtime, but
we never noticed this problem before removing the remote repos (above),
re. "Could not find artifact
org.apache.aries.quiesce:org.apache.aries.quiesce.api:jar:1.0.0"

I've noticed this while trying to work offline on the plane to SFO for
the DDF! ;)

Change-Id: Ib8d1390c463d22130e3dc46d27ac2951a808a8d6
Signed-off-by: Michael Vorburger <vorburger@redhat.com>

Updated git submodules

Project: odlparent master 47a59ed7e69bd155b6ca1f3af25e1dd922a87af1

Relax Checkstyle RightCurly rule for LITERAL_DO

The change [1] try to avoid checkstyle forcing this
"...} while (condition)" statement to be split in two lines by
removing the LITERAL_WHILE from odl_checkstyle, but the correct
token should have been LITERAL_DO.

LITERAL_WHILE avoids forcing this [2]:
while(line !=null)
{ // We do not want this
   process(line);
   line = in.readLine();
}

LITERAL_DO avoids forcing the following [3]:
do
{ // We do not want this
   x = rand.nextInt(10);
} // neither this
while(x < 5);

[1] https://git.opendaylight.org/gerrit/#/c/55264/
[2] http://checkstyle.sourceforge.net/apidocs/com/puppycrawl/tools/checkstyle/api/TokenTypes.html#LITERAL_WHILE
[3] http://checkstyle.sourceforge.net/apidocs/com/puppycrawl/tools/checkstyle/api/TokenTypes.html#LITERAL_DO

Change-Id: I2054e44f140e7b92480da954c45169a31931d683
Signed-off-by: David Suarez <david.suarez.fuentes@ericsson.com>

Updated git submodules

Project: infrautils master da10ad12ec54abcdfa540674ac3bf3f966e74560

Fix issues in checkstyle enforcement for module counters-api

- Copyright section
- Order imports
- Move overloaded methods closer to each other
- Change variables and methods names
- Move constructors to be the first methods
- Enforcement in pom.xml

Change-Id: I29f9b6bca662c790dc32c58dd77d5928d8a0ee70
Signed-off-by: David Suarez <david.suarez.fuentes@ericsson.com>

Updated git submodules

Project: odlparent master bd07c3f410e3c8e8534a9091b8db7da58bb1ac21

Better gitignore rule for vim tmp files

Old one just caught the first backup, this catches additional.

Change-Id: I01802aeee8b578c6cac25bcb626e06e3d194098d
Signed-off-by: Daniel Farrell <dfarrell@redhat.com>

Updated git submodules

Project: releng/builder master 75b8d9a07513cd1a6323b72078df5ed45da3b345

Add a workaround for missing taglist.log

Since we fail the build now if any line in a script fails this is
causing validate-autorelease to fail unexpectedly. Temporarily put in
place a workaround on the problematic line so that it passes until we
put in a proper fix.

Change-Id: I31999f0f78d5ca360f20fa14536310924263c0a4
Signed-off-by: Thanh Ha <thanh.ha@linuxfoundation.org>

Updated git submodules

Project: genius master 77f6823fb315c65000a1edc8248e0a0f0ead4016

Replace LOGGER by LOG

Replace LOGGER by LOG to follow the
OpenDaylight recommendations [1].

[1]
https://wiki.opendaylight.org/view/BestPractices/Logging_Best_Practices

Change-Id: Ib1cf70417092a120eaf11b523e54b056774fe35c
Signed-off-by: David Suarez <david.suarez.fuentes@ericsson.com>

Updated git submodules

Project: integration/test master 2a4bb34c25737cb2492b50039c3e64110978819d

Set WARN log level in OF perf jobs

Change-Id: Ib1a4d10d89d51248808e37f6fb6c589891d19451
Signed-off-by: Luis Gomez <ecelgp@gmail.com>

Updated git submodules

Project: releng/builder master 12a5e3c805a1cd10a2ea3be272df0254d63aa8a5

Merge "Add Boron branch and csit jobs for jsonrpc"

Add Boron branch and csit jobs for jsonrpc

Change-Id: I2d61fa52846e5ff2b0aa7471f5d39e1fa3d33b41
Signed-off-by: Sreekalyan Devaraj <kalyan.ds@gmail.com>

Updated git submodules

Project: releng/builder master 8ad961fad6d4a35e7447e62ebf98191795ac82dc

Remove unsupported Beryllium jobs

Since Carbon has been officially released Beryllium is no longer
supported so remove the jobs.

Change-Id: Iaef265dc8dbc1bc7be87a0b0bed56bb84cf77c25
Signed-off-by: Thanh Ha <thanh.ha@linuxfoundation.org>

Updated git submodules

Project: releng/builder master 8f09a881eae993f36bb4fa193523cf401ebb9a01

Merge "Migrate csit templates to lf-infra-publish"

Migrate csit templates to lf-infra-publish

Pull in updated global-jjb which contains changes to allow archiving via
ARCHIVE_ARTIFACTS variable.

Jira: RELENG-140
Change-Id: I32cb19ecc962d1849ada527470c21a77782217c5
Signed-off-by: Thanh Ha <thanh.ha@linuxfoundation.org>

Updated git submodules

Project: releng/builder master 2e0dab50ed55b594a839a55859a87dbe26e1e339

Better YAML formatting, remove ignore rule

Change-Id: Iaa314b155c1607affdfca9174d861d081dab5a26
Signed-off-by: Daniel Farrell <dfarrell@redhat.com>

Updated git submodules

Project: integration/test master 9b6473789ef58a493a4fbd4a713035db635f318b

Pin requests==2.15.1 for tox coala

Otherwise there is a conflict on chardet version.

Change-Id: Id2e2ada4fc95ad92ce90c355d8ff56ac0508d9db
Signed-off-by: Vratko Polak <vrpolak@cisco.com>

Updated git submodules

Project: releng/builder master 3c95c3a1ce8d676001797741f2bcafc09aba78ca

Merge "Move git-review into LFTOOLs comment block"

Move git-review into LFTOOLs comment block

Change-Id: Ie901a2d53489dab163e49952d9482313cf83bbdd
Signed-off-by: Thanh Ha <thanh.ha@linuxfoundation.org>

Updated git submodules

Project: integration/packaging master 4244966d534c4aee7a971be53da935f79288b5cb

Add vars for Carbon's .deb build

Change-Id: Ia3fed1e209a780803970c320610511964886413b
Signed-off-by: Akshita Jha <zenith158@gmail.com>

Updated git submodules

Project: releng/builder master ecb8462b3d0e5fea3ab2caba8969cb7237e002c7

Merge "Add jobs for all pup-odl branches"

Add jobs for all pup-odl branches

Change-Id: I968fd0d8056f7273bd6fc58289f5cdf785be2c13
Signed-off-by: Daniel Farrell <dfarrell@redhat.com>

Updated git submodules

Project: releng/builder master 35bb75e7b5c38b61b08be8ade5f772416863808a

Merge "Update cloud image list docs"

Update cloud image list docs

Change-Id: I27c5ed107b45a59642c1fe2902d2087785fa46b6
Signed-off-by: jenkins-releng <jenkins-releng@opendaylight.org>

Pin requests to <2.16

The new requests library pulls in a chardet dependency that is in
conflict with coala packages. Pin the version of requests to ensure
we're pulling in a supported version

Change-Id: Ifcc3012b7ea4288342b41db295c53b3958bcab78
Signed-off-by: Thanh Ha <thanh.ha@linuxfoundation.org>

Updated git submodules

Project: releng/builder master 8da2a76e4a945a5ceac0896631c22eb49a4cec2c

Merge "Fix version bump git-review publish code"

Fix version bump git-review publish code

Change-Id: I9efe5744448813a495b03f8fbda300254d25d621
Signed-off-by: Thanh Ha <thanh.ha@linuxfoundation.org>

Updated git submodules

Project: integration/packaging master e8e21b560ba376856054919bdbe7421f3f379883

Pin requests to <2.16

The new requests library pulls in a chardet dependency that is in
conflict with coala packages. Pin the version of requests to ensure
we're pulling in a supported version.

Copied change by Thanh.

Change-Id: I345f37da5b96f40da5dce077635b6e85bb8638ff
Signed-off-by: Daniel Farrell <dfarrell@redhat.com>

Updated git submodules

Project: releng/builder master fdf3efdfd4733a69ee54e09aaf89ab78ea382339

Merge "Fix cleanup stale stacks job"

Fix cleanup stale stacks job

commit dcba567b0ce17e7cbb3c80b38c45ceb6e490e79d was rebased/merged
does not handle stack status correctly. This change should fix the
issue.

Change-Id: I244d2499eb0dabe2f196e401e4f94cc0869685a2
Signed-off-by: Anil Belur <abelur@linuxfoundation.org>

Updated git submodules

Project: odlparent master 5a5c88b66af3e63532472ed02cfec99342369c07

Bug 8415 related: Make TestBundleDiag a lib

This is the alternative to c/56848 requested by Robert.

We're changing this so that we can consume bundles-test-lib in the
infrautils.ready implementation as a service for both Karaf v3 and v4.

As a (VERY nice!) side effect, this allows us to remove the duplicated
Java code we had between bundles-test and bundles4-test. That was,
originally, intended to only be like it still is for a short while, but
with the Karaf 4 situation being what it is, this code duplication is
still there - and the respective code has started diverging a bit; so
unifying this in the new bundles-test-lib is great.

Change-Id: I0fd2c954fdc4a6c84505bef51729d15e4ba2888c
Signed-off-by: Michael Vorburger <vorburger@redhat.com>

Updated git submodules

Project: odlparent master b3f6452b13964c5e14b42700c0b47b27657ad10c

Pin requests to <2.16

The new requests library pulls in a chardet dependency that is in
conflict with coala packages. Pin the version of requests to ensure
we're pulling in a supported version.

Copied change by Thanh.

Change-Id: I3b29f2ab809a1373a9e148120db9f004f3e3fba2
Signed-off-by: Daniel Farrell <dfarrell@redhat.com>

Updated git submodules

Project: netconf master eb0b7276ab613485543ffa63f49427614a7f5e5b

Merge "Test RestconfWrapperProviders"

Test RestconfWrapperProviders

Change-Id: Id95c607bba19c56c6924938ba5ef107f8937a76b
Signed-off-by: Jakub Toth <jatoth@cisco.com>
Signed-off-by: Ivan Hrasko <ivan.hrasko@pantheon.tech>

Updated git submodules

Project: netconf master 65f25b777f3a931ec5cc5c315a3fbdcb798c0967

Merge changes Ieb46b050,I6bff6467

* changes:
Bug 8533: Not possible to invoke RPC on mount points with new Restconf
Bug 7933: NPE when posting using XML

Bug 8533: Not possible to invoke RPC on mount points with new Restconf

- put identifer of RPC into InstanceIdentiferContext
instead of mount point identifer which leads to fail
in unit test

- when working with mount point use mount point's
schema context to find RPC module, previously used
controller's schema context leads to NPE

- repaired imports in RestconfApplication to use
new implementation

Change-Id: Ieb46b050e881c89ea58bb9f521be69554733d575
Signed-off-by: Ivan Hrasko <ivan.hrasko@pantheon.tech>
Bug 7933: NPE when posting using XML

PUT operation:
- fix issue when putting malformed XML body did not
fail with appropriate status.

Change-Id: I6bff6467f4b99bed9adf1ac39def54822899761e
Signed-off-by: matus.kubica <matus.kubica@pantheon.tech>
Signed-off-by: Ivan Hrasko <ivan.hrasko@pantheon.tech>

Updated git submodules

Project: genius master 14076841748800ee05e06b547957deadd2531681

Fix vlanIdModified test

OvsVlanMemberConfigUpdateHelper.vlanIdModified() has an apparent
copy-paste error in its null/non-null check. The whole test simplifies
down to !Object.equals(), so this patch just uses that.

Change-Id: I6b3548da5441e8318cf20eab3f4817d162c97fa6
Signed-off-by: Stephen Kitt <skitt@redhat.com>

Updated git submodules

Project: releng/builder master 6cefa01d7bd2a44559006080c568a59d5b5f5cac

Merge "Install git-review through yum repositories"

Install git-review through yum repositories

Installing through pip as root on the base image is not
recommend practice since this could impact other deps.

Change-Id: I12f1a4aa1e129a65af43736879ac46f7fe7c3c81
Signed-off-by: Anil Belur <abelur@linuxfoundation.org>

Updated git submodules

Project: releng/builder master 2359085020fea128acd0330ad3fa0a15ef3a9974

Merge "Improve multipatch patches-to-build param docs"

Improve multipatch patches-to-build param docs

Change-Id: I6c805dd8ad3c05f1980e7f6a49efca21f3fc3e73
Signed-off-by: Daniel Farrell <dfarrell@redhat.com>

Updated git submodules

Project: releng/builder master 3bc367a4cad1b304609d9403190a097612173dbd

Add ansible-opendaylight test jobs

Change-Id: I911ff41623739782261aef909774f8f30e2732e9
Signed-off-by: Daniel Farrell <dfarrell@redhat.com>

Updated git submodules

Project: genius master 7075c058b552e959f2433e69b8c0d31ace19c439

Simplify ResourceManager

- Simplify the initialization process refactoring some methods and using
System.getProperty with default values
- Change names of constants
- Improved coverage to from 70% to 81%.

More refactoring in later change.

Change-Id: I6670355d36b7af0806fa2032178103ef3d1a0099
Signed-off-by: David Suarez <david.suarez.fuentes@ericsson.com>