artifact: remove duplicated features-neutron-test dependency

eliminate the following warning.

> [WARNING] Some problems were encountered while building the effective model for org.opendaylight.neutron:neutron-artifacts:pom:0.9.0-SNAPSHOT
> [WARNING] 'dependencyManagement.dependencies.dependency.(groupId:artifactId:type:classifier)' must be unique: ${project.groupId}:features-neutron-test:xml:features -> duplicate declaration of version ${project.version} @ line 69, column 25
> [WARNING]
> [WARNING] It is highly recommended to fix these problems because they threaten the stability of your build.
> [WARNING]
> [WARNING] For this reason, future Maven versions might no longer support building such malformed projects.

Change-Id: I127ee79eae5701a7c1d2f9805171dfa82c317233
Signed-off-by: Isaku Yamahata <isaku.yamahata@intel.com>

features: make prerequisite=true for features of integration test

Change-Id: I9bc113574c1a90bf2caea849ed89d54a388eaa36
Signed-off-by: Isaku Yamahata <isaku.yamahata@intel.com>

Merge "rename SocketInfoTest alternative val"

rename SocketInfoTest alternative val

Change BIS with ALT for alternative val

Change-Id: I1c3ce33f29b63b3ea8cc9718514d0b8a9e7d6677
Signed-off-by: matcauf <mcauffiez@inocybe.ca>

Merge "use maven-blueprint-plugin"

use maven-blueprint-plugin

TODO: figure out how to convert NeutronHostconfigVppListener

Change-Id: Id3361cc5a1c4847484c1dfa6db3ca2ea7b87b5cb
Signed-off-by: Isaku Yamahata <isaku.yamahata@intel.com>

Add unit test for SocketInfo

Change-Id: Ifd8fea3a65db3431f337208fabfb966c057c55d4
Signed-off-by: matthieu <mcauffiez@inocybe.com>

drop 4 from karaf4

Change-Id: I851a95c97fc5e91a9ee585a89e18165966360746
Signed-off-by: Isaku Yamahata <isaku.yamahata@intel.com>

Bump odlparent dependency to 2.0.0

This patch updates the dependency to 2.0.0.

and remove karaf3 related files.

Change-Id: I578d280d0525577ae27db44a747956d530409437
Signed-off-by: Isaku Yamahata <isaku.yamahata@intel.com>

features.xml: fix indent

Change-Id: I0adcd06fae8fc604dd664762adcbc61f801dbd62
Signed-off-by: Isaku Yamahata <isaku.yamahata@intel.com>

Integration Test migrate to Karaf4

Fix integration test to make it work on Karaf4
and enable integration test which was disabled by
https://git.opendaylight.org/gerrit/#/c/58869/

Change-Id: I7e16ecd09895f1f599eb447805ce7083fb700435
Signed-off-by: Dileep Ranganathan <dileep.ranganathan@intel.com>
Signed-off-by: Isaku Yamahata <isaku.yamahata@intel.com>

Migrate to odlparent 1.9.0

For now, integration test is disabled to avoid patch dependency.
The test will be re-enabled by follow up patch,
https://git.opendaylight.org/gerrit/#/c/55128/

Change-Id: I618f31a1fdf4da1236454620e21b3a7435c81d11
Signed-off-by: Thanh Ha <thanh.ha@linuxfoundation.org>
Signed-off-by: Isaku Yamahata <isaku.yamahata@intel.com>

misc minor code clean up

typo in comment, remove unnecesarry parens.

Change-Id: I6a3bc45761305fdd40ecd76b9d1f02f32b8911f8
Signed-off-by: Isaku Yamahata <isaku.yamahata@intel.com>

remove unnecessary cast

Change-Id: Ie6d73f1fef4ca977f95d5beaed90c96ee79f66ae
Signed-off-by: Isaku Yamahata <isaku.yamahata@intel.com>

more on remove type from <>

Change-Id: I12b499eaccc4db65a5fd40f371f8d199da9a7d8a
Signed-off-by: Isaku Yamahata <isaku.yamahata@intel.com>

Add missing override annotations

Change-Id: I6a87bee9b9638c52bef17921ccd12e5a3d29110e
Signed-off-by: David Suarez <david.suarez.fuentes@ericsson.com>
Signed-off-by: Isaku Yamahata <isaku.yamahata@intel.com>

Merge "integration/test/pom.xml: add logger for jacoco"

integration/test/pom.xml: add logger for jacoco

nueutron logger was missing for jacoco.
and fix indent.

Change-Id: I941442e0421e722e94b597bde504d829d4d6f96e
Signed-off-by: Isaku Yamahata <isaku.yamahata@intel.com>

Replace LOGGER by LOG

Replace LOGGER by LOG to follow the OpenDaylight recommendations.

https://wiki.opendaylight.org/view/BestPractices/Logging_Best_Practices

Change-Id: Idad0d8a3d38e51dc5e0fd3d3e7d41a4b6c129eb1
Signed-off-by: David Suarez <david.suarez.fuentes@ericsson.com>

Merge "Code Clean up: remove type from <>"

Code Clean up: remove type from <>

Since Java 7 is not necessary to explicit type from <>

Change-Id: Iccec01a57a0bd6d0bc19cebca153fabfa825c9ca
Signed-off-by: matthieu <mcauffiez@inocybe.com>

Bug 8660: use southbound-artifacts

Instead of pulling in odl-ovsdb-southbound-api as an artifact POM, use
southbound-artifacts.

Change-Id: I6ca7f82b66fa4e2680393afc3efbac0ce151cd20
Signed-off-by: Stephen Kitt <skitt@redhat.com>

unbreak build

The dependency needs update otherwise, the following error occurs.

> [INFO] --- maven-surefire-plugin:2.18.1:test (default) @ odl-neutron-hostconfig-vpp ---
> [INFO] Surefire report directory: /home/yamahata/opendaylight/upstream/neutron/features/production/odl-neutron-hostconfig-vpp/target/surefire-reports
>
> -------------------------------------------------------
>  T E S T S
> -------------------------------------------------------
> Running org.opendaylight.odlparent.featuretest.SingleFeatureTest
> Tests run: 1, Failures: 0, Errors: 1, Skipped: 0, Time elapsed: 11.912 sec <<< FAILURE! - in org.opendaylight.odlparent.featuretest.SingleFeatureTest
> installFeatureCatchAndLog(org.opendaylight.odlparent.featuretest.SingleFeatureTest)[repoUrl: file:/home/yamahata/opendaylight/upstream/neutron/features/production/odl-neutron-hostconfig-vpp/target/feature/feature.xml, Feature: odl-neutron-hostconfig-vpp 0.9.0.SNAPSHOT]  Time elapsed: 11.342 sec  <<< ERROR!
> org.osgi.service.resolver.ResolutionException: Unable to resolve root: missing requirement [root] osgi.identity; osgi.identity=odl-netconf-util; type=karaf.feature; version=1.3.0.SNAPSHOT; filter:="(&(osgi.identity=odl-netconf-util)(type=karaf.feature)(version>=1.3.0.SNAPSHOT))" [caused by: Unable to resolve odl-netconf-util/1.3.0.SNAPSHOT: missing requirement [odl-netconf-util/1.3.0.SNAPSHOT] osgi.identity; osgi.identity=odl-netconf-mapping-api; type=karaf.feature; version="[1.3.0.SNAPSHOT,1.3.0.SNAPSHOT]" [caused by: Unable to resolve odl-netconf-mapping-api/1.3.0.SNAPSHOT: missing requirement [odl-netconf-mapping-api/1.3.0.SNAPSHOT] osgi.identity; osgi.identity=odl-netconf-api; type=karaf.feature; version="[1.3.0.SNAPSHOT,1.3.0.SNAPSHOT]" [caused by: Unable to resolve odl-netconf-api/1.3.0.SNAPSHOT: missing requirement [odl-netconf-api/1.3.0.SNAPSHOT] osgi.identity; osgi.identity=org.opendaylight.controller.yang-jmx-generator; type=osgi.bundle; version="[0.7.0.SNAPSHOT,0.7.0.SNAPSHOT]"; resolution:=mandatory [caused by: Unable to resolve org.opendaylight.controller.yang-jmx-generator/0.7.0.SNAPSHOT: missing requirement [org.opendaylight.controller.yang-jmx-generator/0.7.0.SNAPSHOT] osgi.wiring.package; filter:="(&(osgi.wiring.package=org.opendaylight.mdsal.binding.generator.spi)(version>=0.11.0)(!(version>=1.0.0)))"]]]]
>  at org.apache.felix.resolver.ResolutionError.toException(ResolutionError.java:42)
>  at org.apache.felix.resolver.ResolverImpl.doResolve(ResolverImpl.java:389)
>  at org.apache.felix.resolver.ResolverImpl.resolve(ResolverImpl.java:375)
>  at org.apache.felix.resolver.ResolverImpl.resolve(ResolverImpl.java:347)
>  at org.apache.karaf.features.internal.region.SubsystemResolver.resolve(SubsystemResolver.java:216)
>  at org.apache.karaf.features.internal.service.Deployer.deploy(Deployer.java:263)
>  at org.apache.karaf.features.internal.service.Deployer.deploy(Deployer.java:259)
>  at org.apache.karaf.features.internal.service.Deployer.deploy(Deployer.java:259)
>  at org.apache.karaf.features.internal.service.FeaturesServiceImpl.doProvision(FeaturesServiceImpl.java:1176)
>  at org.apache.karaf.features.internal.service.FeaturesServiceImpl$1.call(FeaturesServiceImpl.java:1074)
>  at java.util.concurrent.FutureTask.run(FutureTask.java:266)
>  at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1142)
>  at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:617)
>  at java.lang.Thread.run(Thread.java:748)
>
>
> Results :
>
> Tests in error:
>   Unable to resolve root: missing requirement [root] osgi.identity; osgi.identity=odl-netconf-util; type=karaf.feature; version=1.3.0.SNAPSHOT; filter:="(&(osgi.identity=odl-netconf-util)(type=karaf.feature)(version>=1.3.0.SNAPSHOT))" [caused by: Unable to resolve odl-netconf-util/1.3.0.SNAPSHOT: missing requirement [odl-netconf-util/1.3.0.SNAPSHOT] osgi.identity; osgi.identity=odl-netconf-mapping-api; type=karaf.feature; version="[1.3.0.SNAPSHOT,1.3.0.SNAPSHOT]" [caused by: Unable to resolve odl-netconf-mapping-api/1.3.0.SNAPSHOT: missing requirement [odl-netconf-mapping-api/1.3.0.SNAPSHOT] osgi.identity; osgi.identity=odl-netconf-api; type=karaf.feature; version="[1.3.0.SNAPSHOT,1.3.0.SNAPSHOT]" [caused by: Unable to resolve odl-netconf-api/1.3.0.SNAPSHOT: missing requirement [odl-netconf-api/1.3.0.SNAPSHOT] osgi.identity; osgi.identity=org.opendaylight.controller.yang-jmx-generator; type=osgi.bundle; version="[0.7.0.SNAPSHOT,0.7.0.SNAPSHOT]"; resolution:=mandatory [caused by: Unable to resolve org.opendaylight.controller.yang-jmx-generator/0.7.0.SNAPSHOT: missing requirement [org.opendaylight.controller.yang-jmx-generator/0.7.0.SNAPSHOT] osgi.wiring.package; filter:="(&(osgi.wiring.package=org.opendaylight.mdsal.binding.generator.spi)(version>=0.11.0)(!(version>=1.0.0)))"]]]]
>
> Tests run: 1, Failures: 0, Errors: 1, Skipped: 0

Change-Id: If869c8d7ccb71a1651046e1134b69645cd44112e
Signed-off-by: Isaku Yamahata <isaku.yamahata@intel.com>

Migrate to odlparent 1.8.0-Carbon

Per request of odlparent project we are downgrading all Nitrogen
projects to use the released odlparent 1.8.0-Carbon to allow for the
odlparent project to start performing semver style releases.

Change-Id: I08967c90e05ce6534055a81ea93510a587dfde6a
Jira: RELENG-159
RT: 41406
Signed-off-by: Thanh Ha <thanh.ha@linuxfoundation.org>

neutron spi: consolidate extractFields() method

Change-Id: Ibe9479b88004865724a5fa443f49a5297b541369
Signed-off-by: Isaku Yamahata <isaku.yamahata@intel.com>

Merge "Fix sonar issue: multiple if statements"

Fix sonar issue: multiple if statements

Change multiple if statements on string with a
switch case, It can also be changed with an enum.
This is solving some sonar complexity code issues,
giving a cleaner and maybe faster code.
Add warn log for ignored fields

Change-Id: I1cc717e4d0935a9c3c4c74307fbf2c0696e1648e
Signed-off-by: matthieu <mcauffiez@inocybe.com>

Merge "Code cleanup: ternary operator."

Code cleanup: ternary operator.

Remove conditional var assignment and use
ternary operator instead, in order to have less
assignment and a cleaner code.
Assigne directly the conditional operation result
to the boolean var firstpage.

Change-Id: Id124a84f513b7e1a506c6d1d13eaf8539cf2e8d6
Signed-off-by: matthieu <mcauffiez@inocybe.com>

Code cleanup: Useless assignment

Remove one useless assignment.

Change-Id: I4d3dcc76f84e3529daea43061e4857d3d9dae659
Signed-off-by: matthieu <mcauffiez@inocybe.com>

Merge "Fix Sonar issue: Code readability"

Merge "Fix sonar issue: unused LOG"

Fix Sonar issue: Code readability

Adress Major sonar issues for NeutronHostconfigVppListener.java file.
This patch improves code readability.

Use final temporary var instead of using the method parameter
vhostMode.
Reduce the lambda content by creating a new method:
processDataTreeModification.
Reduce the cyclomatic complexity of validateVppNode by adding the
boolean function isCapabilitiesPresent.

Change-Id: Ie2b3fa85772707f8c86901415dd1ca8d0a7eef47
Signed-off-by: mcauffiez <mcauffiez@inocybe.com>

Fix sonar issue: unused LOG

Remove unused Log and corresponding imports

Change-Id: Ie32e2aa8eb74fe880c368d8a7bc7fd990096074b
Signed-off-by: mcauffiez <mcauffiez@inocybe.com>

FIX sonar issue: Commented code

Remove ; in order to stop raising the issue

Change-Id: I164c7bed6e555d3cca9c11fbafdfcb98c8ea22f7
Signed-off-by: mcauffiez <mcauffiez@inocybe.com>

use com.google.common.net.InetAddresses.forString()

instead of InteAddress.getByName(), use
com.google.common.net.InetAddresses.forString which  is better.

Change-Id: Ic7405524882f94ecdd614f0b533deb093db0c8f3
Signed-off-by: Isaku Yamahata <isaku.yamahata@intel.com>

Updating yang revisions in hostconfig for VPP

Added 2017-03-15 revision for honeycomb 1704
Config file is automatically copied to ${KARAF}/etc

Change-Id: I1b8bfa4d1f7230252286ead5b95af8c1c3192f70
SIGned-off-by: Tomas Cechvala <tcechval@cisco.com>
Signed-off-by: Dileep <dileep.ranganathan@intel.com>

Merge "Add service-provider-feature for operational port status"

Add service-provider-feature for operational port status

This commit adds a service-provider-feature for port-status,
operational-port-status. This feature should be set in operational
when netvirt knows how to update port status in operational when
a port becomes active.

Change-Id: I7fe7c6998f67380338e240355def7d2676c98335
Signed-off-by: Josh <jhershbe@redhat.com>

Prepare for checkstyle version upgrade

Checkstyle will be upgraded from 6.16 to 7.6.1 with [0]. This patch
fixes failres seen by the new version.

[0] https://git.opendaylight.org/gerrit/#/c/54981/

Change-Id: Ia84e1515810d162e0e813bdfeaec10721d06bba5
Signed-off-by: Lorand Jakab <lojakab@cisco.com>

Bump versions by x.(y+1).z for next dev cycle

Change-Id: I791386fdba5e478e85df5c78c95fc8fbb1dcfe99
Signed-off-by: Anil Belur <abelur@linuxfoundation.org>

transcriber: remove redundant code in l2gw

Change-Id: I44c48614c1b2fa2aa2268c0cecf275b7638e7e68
Signed-off-by: Isaku Yamahata <isaku.yamahata@intel.com>

Merge "transcriber: qos policy rule"

Merge "Neutron Model update"

transcriber: qos policy rule

QosPolicyRuleBuilder is wrongly allocated.
It should be allocated per each rule.

Change-Id: Ib5f35c48e7933bbbfe133993f64abd7a5379286d
Signed-off-by: Isaku Yamahata <isaku.yamahata@intel.com>

Neutron Model update

This patch includes Neutron API/model changes being
introduced.
1) Status field to be moved to operational datastore
Breaking out the status field from this patch
for ease of review and merge process.
Link to status field patch
https://git.opendaylight.org/gerrit/#/c/51981/
2) Project id field is going to depreciate tenant id
https://lists.opendaylight.org/pipermail/neutron-dev/2016-December/001083.html
This fix addresses top level tenant-id used my most models.
Some models internally also use tenant-id in sub-fields. Those
cases will be addressed in Nitrogen.
3) revision number field to be added. This is a monotonic
counter that will be updated whenever an object is updated
on the neutron server.

Change-Id: I8a76fe5ff1147a9e4456c0713913377f266cec24
Signed-off-by: Ritu Sood <ritu.sood@intel.com>
Signed-off-by: Isaku Yamahata <isaku.yamahata@intel.com>

Karaf4 migration

Based on https://wiki.opendaylight.org/view/Karaf_4_migration
This patch try to implement karaf4 migration patch. not tested yet.
The some dependency needs fix.
Can odlparent/features-test be used with karaf4?

Change-Id: I24928524c478b5b4083ccfbd9deffba05826f65b
Signed-off-by: Isaku Yamahata <isaku.yamahata@intel.com>
Signed-off-by: Dileep Ranganathan <dileep.ranganathan@intel.com>

updating neutron-qos yang file for Qos Rule Types to change the model from Config to Operational and incorporating the review comments.

Change-Id: Ib195c222f5009b190e4307c904517ad96ff27e22
Signed-off-by: chandrag <chandramohan.grandhi@tcs.com>

Merge "Add missing <name> fields for pom.xml files"

Merge "Bug 7848: Allow neutron port create with security disabled."

Merge "Add missing <name> fields for pom.xml files"

Add missing <name> fields for pom.xml files

The patchset of b184367fef0217aa0466f86d6614cf821d74cf60
added name fields to pom.xml. Due to patch merge order,
neutron-hostconfig/vpp/pom.xml isn't updated.
This patch fixes it up by adding <name> fields to it.

Change-Id: I256390812a40fa2727fc2d33592aec047cafe8c5
Signed-off-by: Isaku Yamahata <isaku.yamahata@intel.com>

Hostconfig for VPP

L2 configuration is currently supported for VPP devices.
Vhostuser vif-type is used for VMs (endpoints).
Configurable fields:
 - socket directory
 - socket prefix
 - vhostuser-mode (client, server)

 ODL connects to VPP nodes via NETCONF. When a node is
 recognized as VPP node based on its capabilitites
 host configration is written to datastore.

Change-Id: I78b6ad2eeb3d1b11b09317f4c9be0e6878e71df8
Signed-off-by: Tomas Cechvala <tcechval@cisco.com>

Add missing <name> fields for pom.xml files

This is used by autorelease scripts to automatically parse which project
is failing a build and report to the mailing list automatically. We need
names in the format:

    ODL :: <groupId> :: <artifactId>

This patch formats in the same format as found in the startup archetypes
patch found here: https://git.opendaylight.org/gerrit/52522

Change-Id: I08fff282973944e135b981f98fcebcde156c7e60
Signed-off-by: Anil Belur <abelur@linuxfoundation.org>

Merge "Adding checkstyle checks to hostconfig"

Merge "yang model: add service provider feature model"

Bug 7848: Allow neutron port create with security disabled.

Add default parameters in test validation.

Change-Id: Id5fcf5701763d72274a96f1a0af29a7546bc24f8
Signed-off-by: Isaku Yamahata <isaku.yamahata@intel.com>
Signed-off-by: Achuth Maniyedath <achuth.m@altencalsoftlabs.com>

AbstractNeutronNorthbound: remove unused local variable

remove unused local variable, parameterizedType, in
AbstractNeutronNorthbound.

Change-Id: I7b77750abb3455b39ff3eeb636f1b9cc255ca2a6
Signed-off-by: Isaku Yamahata <isaku.yamahata@intel.com>

yang model: add service provider feature model

As ODL is starting to add more functionalities like port status update
for networking-odl, the negotiation between networking-odl and ODL
openstack service provider to keep compatibility.
networking-odl is supposed to work with multiple versions of ODL,
multiple instances of openstack service providers. So networking-odl
needs to know what neutron extensions/features is supported by
given ODL version/openstack service provider.
This patch defines a yang model for it so that networking-odl can
retrieve from ODL at start up and configure itself.

Change-Id: I90b6bbc3079559209fb444ab79cc88af6a2dc58a
Signed-off-by: Isaku Yamahata <isaku.yamahata@intel.com>

Adding checkstyle checks to hostconfig

Hostconfig directory is missing checkstyle checks.
Updated pom file to add checkstyle and also fixed
checkstyle issues.

Change-Id: Id0ff1226e3b23ebac521959de15da0331af7118a
Signed-off-by: Ritu Sood <ritu.sood@intel.com>

model/neutron extension: add configuration string

Add configuration string to neutron-extension-attribute.
So that ODL openstack service provide can negotiate with networking-odl
about more details on each extension.
For example, neutron QoS API needs supported QoS rules.
key" "neutron:qos"
configuration: {"supported_rules_types": ["bandwidth-limit"...] }
Also neutron-extension can be used for general negotiation between
ODL and networking-odl. e.g. port::status update is supported etc.
key: "ODL:status-update"
configuration: ["network", "port", "router", ...]

TODO: coordinate/document key/configuration in central places.

Change-Id: I7ba7dc21ac0fda7fb40c5f44b99c3b3753c79b9d
Signed-off-by: Isaku Yamahata <isaku.yamahata@intel.com>

Move hostconfig functionality to Neutron Northbound

This patch moves hostconfig functionality from Netvirt
to NN project. The code is organized to support multiple
southbound implementations. This patch includes
support for hostconfig for OVS.

Change-Id: If428cd3e0c1c466342888f46f17a1916176f0fc6
Signed-off-by: Ritu Sood <ritu.sood@intel.com>

gitignore: remove MANIFEST.MF

Now MANIFEST.MF is created under target directory.
There is no need to ignore MANIFEST.MF and MANIFEST that is not under
target/ directory should not be ignored.

Change-Id: If87003eb0fa38e78164df6ee36a9ed4471c35fcf
Signed-off-by: Isaku Yamahata <isaku.yamahata@intel.com>

Merge "deploy-site.xml: update version"

pom: create MANIFEST.MF under target directory

Somehow MANIFEST.MF is generated as src/main/resources/META-INF/MANIFEST.MF.
This causes that mvn clean doesn't remove it.
It's not usually expected. make manifestLocation property default to
be created under target directory.

Change-Id: Id5610e1c824805446fbff0e8cafa5c9a484f05d3
Signed-off-by: Isaku Yamahata <isaku.yamahata@intel.com>

deploy-site.xml: update version

Change-Id: I07991a89890e27d39e5304ad98277f27bbdf8ed3
Signed-off-by: Isaku Yamahata <isaku.yamahata@intel.com>

Add support for Openstack Neutron Trunkport APIs

This adds the following:
1. Yang model for TrunkPort Openstack Neuton v2 extension
2. Implementation of API (spi, api and transcriber)
3. UTs for testing spi
4. ITs for E2E testing of API

External References:
https://blueprints.launchpad.net/neutron/+spec/vlan-aware-vms
http://specs.openstack.org/openstack/neutron-specs/specs/newton/vlan-aware-vms.html
https://wiki.openstack.org/wiki/Neutron/TrunkPort

ODL Driver: https://review.openstack.org/#/c/421895/

Change-Id: I1428e44f93a5bc4507ad5b39c1f2f9f92540fab8
Signed-off-by: Vishal Thapar <vishal.thapar@ericsson.com>

Merge "neutorn-spi: more remove neutron prefix of field"

neutorn-spi: more remove neutron prefix of field

The changeset of a2f1a28cb8b6c226f49716434cd8ccc34c43eaa4
the change id of I81984a294b4601bfb18b24140d03d615dba1424a was
imcomplete somehow.This patch removes remaining neutron prefix in spi.

Change-Id: I935e2028fc436cd01e8eb930eb5811f4dca26575
Signed-off-by: Isaku Yamahata <isaku.yamahata@intel.com>

NeutronLogger: minor code clean up

remove unnecessary methods in NeutronLogger

Change-Id: I72cd2ebc6093cd48d714ed4d11abb6a47405c65e
Signed-off-by: Isaku Yamahata <isaku.yamahata@intel.com>

apiece unchecked cast warning

Eliminate unchecked cast warnings.
In some places we have to use @SuppressWarnings("unchecked")
unfortunately.

Change-Id: Ibaaeebabe86ec645bc61d68389c611b0a0bdc399
Signed-off-by: Isaku Yamahata <isaku.yamahata@intel.com>

neutorn-spi: remove neutron prefix of field

field name of neutron spi doesn't prefix neutron.
The following three classes have the fields with neutorn prefix.
NeutronL2gateway, NeutronL2gatewayDevice, NeutronLoadBalancerListener
remove prefix of the fields of those classes For consistency.

Change-Id: I81984a294b4601bfb18b24140d03d615dba1424a
Signed-off-by: Isaku Yamahata <isaku.yamahata@intel.com>

checkstyle: remove suppression

Now there is no need of suppression for checkstyle.
remove checkstyle-suppressions.xml.

Change-Id: I1fe08a85542f52fcd94bf76f369b66bd0d02def6
Signed-off-by: Isaku Yamahata <isaku.yamahata@intel.com>

checkstyle: AbbreviationAsWordInName

fix AbbreviationAsWordInName and enable AbbreviationAsWordInName.

Change-Id: I6d0756598b7d2a000325b4986e2752aacfd30eb3
Signed-off-by: Isaku Yamahata <isaku.yamahata@intel.com>

checkstyle: TypeName

eliminate TypeName violation and enable it.

Change-Id: I97af3891eafc965176fa34f17176b62d897122a9
Signed-off-by: Isaku Yamahata <isaku.yamahata@intel.com>

checkstyle: JavadocStyleCheck

fix JavadocStyleCheck and enable it.

Change-Id: I1689aebded15605474c3ef388e433a87577d190a
Signed-off-by: Isaku Yamahata <isaku.yamahata@intel.com>

checkstyle: enable SummaryJavadoc

fix SummaryJavadoc and enable it.

Change-Id: I68a464c78aacbb54d54b198b267d616d228e7403
Signed-off-by: Isaku Yamahata <isaku.yamahata@intel.com>

checkstyle: enable JavadocTagContinuationIndentation

Eliminate the violation of JavadocTagContinuationIndentation and enable
it.

Change-Id: If854fa71db3115200f57faa8c06c0dd1e8995c0c
Signed-off-by: Isaku Yamahata <isaku.yamahata@intel.com>

checkstyle: enable JavadocParagraph

Eliminate the violation of JavadocParagraph and enable it.

Change-Id: I1f114f516d96bf0d3f5530d92e876b788cd73af6
Signed-off-by: Isaku Yamahata <isaku.yamahata@intel.com>

checkstyle: eliminate ConstantName violation

Eliminate ConstantName violation of checkstyle and enable it.

Change-Id: If124294de812c3b6f022edbe0d1540c78eeae2d8
Signed-off-by: Isaku Yamahata <isaku.yamahata@intel.com>

checkstyle: enable LocalVariableName

fix LocalVariableName violation of checkstyle and enable it.

Change-Id: I6945ac54f3851772cc848093c56111c142d0723d
Signed-off-by: Isaku Yamahata <isaku.yamahata@intel.com>

checkstyle: ParameterName

Fix PrameterName checkstyle violation and enable it.

Change-Id: I7f06123fcd1fb5a6db1f47672c788aeb521814ec
Signed-off-by: Isaku Yamahata <isaku.yamahata@intel.com>

checkstyle: suppression to ignore files under target

the changeset of f1c4e8a94515118893477c19effbaec53d4356d8
change id of I8b2ec5ee6d46dc108e781031996a1022b8c5330a
in odlparent introduced new supression to ignore sources under
target. This patch catches up it.

Change-Id: I7f35dffea41dbfc939238db0014632a2cd44fa18
Signed-off-by: Isaku Yamahata <isaku.yamahata@intel.com>

checkstyle: use our own checkstyle-suppressions.xml

The changeset of f1c4e8a94515118893477c19effbaec53d4356d8
change id of I8b2ec5ee6d46dc108e781031996a1022b8c5330a in odlparent
defines its own checktyle-suppressions.xml. so that neutron northbound
fails to build because unintented suppression rule is used.
Make it sure that intended supressions are used.

Change-Id: Ifb14d25e5b7b374515274ef9644e35fe64dde5a4
Signed-off-by: Isaku Yamahata <isaku.yamahata@intel.com>

BUG-7259: pool-attributes have wrong description

n neutron-lbaasv2.yang, the description of healthmonitor-id in
pool-attributes is as follow:
    leaf healthmonitor-id {
 type yang:uuid;
 description "List of healthmonitors
 associated with this pool.";
    }
here, healthmonitor-id is not a list, so the description need to be modified

Change-Id: I69709af3585bf66c8a4e25a239bc3e071e9bc809
Signed-off-by: wangqianyu <wang.qianyu@zte.com.cn>

BUG-7185 NeutronLoadBalancerListener has wrong xmlElement name

Fixes bug 7185
    lb listener from openstack uses loadbalancers as xml key value,
    so the XmlElement name of load_balancers in
    NeutronLoadBalancerListener need to be changed to loadbalancers

Change-Id: Id05e4fedc9e516aca45f4c2fac4b3763ee9a1ed8
Signed-off-by: wangqianyu <wang.qianyu@zte.com.cn>

NeutornLogger: print data when node is deleted

Log data of deleted node.

Change-Id: I84ae522cb49453f3d5d2b7812aecfe00628fa9dd
Signed-off-by: Isaku Yamahata <isaku.yamahata@intel.com>

Merge "Bug 6938 - Handle unknown protocol name as bad request"

Bug 6278: Switch to use odlparent's karaf-parent

Change-Id: I36e42dac7ccc13f0f796bb95a28a6f30f141b05c
Signed-off-by: Ryan Goulding <ryandgoulding@gmail.com>

Bug 6938 - Handle unknown protocol name as bad request

Fwaas, security group rule handled unknown protocol
name as internal server error. Changed that to respond
with bad request. lbaas ignored the wrong protocol field.
Also chaged that to respond with bad request.

Change-Id: I681d67b8704015b392ee811b0f4b1556a63b5809
Signed-off-by: Ritu Sood <ritu.sood@intel.com>

Bug 6865 - Transcriber skips the uppercase protocol field

Networking-sfc sends protocol string in lowercase
(e.g tcp and not TCP), but neutron spi try to find
it using the uppercase and don't find it and
eventually ignore this field. To be consistent with
other API's, flow classifier will only accept lowercase
protocol name and return 400 (Bad Request) for any other
protocol string.

Change-Id: I204f58c9cf1cf13446122c8f818ce498866a2caf
Signed-off-by: Anil Vishnoi <vishnoianil@gmail.com>

Fix checkstyle issues related to exception handling

This is based on the Guidelines given here
https://wiki.opendaylight.org/view/BestPractices/Coding_Guidelines#IllegalCatch

Change-Id: I70f9841f706c8d5c38b0834dba04b79ad8fbfa71
Signed-off-by: Ritu Sood <ritu.sood@intel.com>

Merge "sonar: Move this trailing comment on the previous empty line."

Merge "sonar: use dedicated exception instead of RuntimeException"

Bug 6796 - Fixes Priority bugs in integration-test

1.NeutronL2gatewayConnectionNorthbound.java:118,
EC_UNRELATED_TYPES, Priority: High

This method calls equals(Object) on two references of different class
types and analysis suggests they will be to objects of different
classes at runtime

2.NeutronL2gatewayNorthbound.java:116, EC_UNRELATED_CLASS_AND_INTERFACE
This method calls equals(Object) on two references, one of which is a
class and the other an interface,where neither the class nor any of
its non-abstract subclasses implement the interface.

3.NeutronRoutersNorthbound.java:102, EC_UNRELATED_TYPES - Same as 1st
Bug

Change-Id: I23cda778f807ba02179c7d9d4e682b9561a378d4
Signed-off-by: pramod <pramod.raghavendra.jayathirth@intel.com>

sonar: Move this trailing comment on the previous empty line.

remove trailing comment by moving it on the previous empty line.

Change-Id: I72d7e93dd4d60c4773b437c36368d3297e8154d4
Signed-off-by: Isaku Yamahata <isaku.yamahata@intel.com>

sonar: use dedicated exception instead of RuntimeException

use IllegalArgumentException instead of RuntimeException

Change-Id: I32c17078499ff3cfd17f2d3b445a3e1bdac99574
Signed-off-by: Isaku Yamahata <isaku.yamahata@intel.com>

remove unused inUse method

Change-Id: I10053b258e899324c30fff836c9ebd88c2ef216c
Signed-off-by: Isaku Yamahata <isaku.yamahata@intel.com>

transscriber: consolidate createInstanceIdentifier(T item)

Consolidate InstanceIdentifier<T> createInstanceIdentifier(T item)
into AbstractNeutronInterface.

Change-Id: If6aedc24d9cc4a15cefa7c21ce3d00c51610c0f0
Signed-off-by: Isaku Yamahata <isaku.yamahata@intel.com>

transcriber: consolidate createInstanceIdentifier()

This patch consolidate createInstanceIdentifier() into parent class.

Change-Id: I6acf69e2ac328bf71cff3efbd846a72db02df6a9
Signed-off-by: Isaku Yamahata <isaku.yamahata@intel.com>