Test coverage for Service Path ID

- Hopefully 100% test coverage for Service Path ID file and algorithm
- Refactored RSP Test to use same abstract class as SPID

Change-Id: Iffe877abcea245d00d7f69e9a8f1dc2fdcbfefb7
Signed-off-by: Reinaldo Penno <[email protected]>

Merge "Migrate netconf/restconf dependencies"

Migrate netconf/restconf dependencies

Change-Id: Ic3c17dc3701dc97f23691fe73875573a2b630766
Signed-off-by: Tomas Cere <[email protected]>

Add new type support while mapping

When mapping OVS bridges to SFFs or mapping SFFs to OVS briges,
we add new port types(dpdk/dpdkvhost/dpdkvhostuser) support.

Change Log:
v1: Add null test for otherLocatorType.

Change-Id: I067370eea27a7ed4176a76b619cabc367169690d
Signed-off-by: Johnson Li <[email protected]>

Add new fields for OVS Options

When creating VxLAN + GPE + NSH tunnel ports, we may use
in_nsp/in_nsi/out_nsp/out_nsi as port options. These options
should also be translated when mapping SFFs to OVSs or mapping
OVSs to SFFs.

Change-Id: Ib2e928107820108aca33f25ce9334ff887f7e4d3
Signed-off-by: Johnson Li <[email protected]>

Merge "Service Path ID API"

Service Path ID API

Change-Id: Iee5c06b12f8f4b086ae0469d45b2353cce71a6bc
Signed-off-by: Reinaldo Penno <[email protected]>

Merge "Set ofPort info to SFF's DPL while mapping"

Merge "Cleaned out unused repos and dependencies."

Merge "Remove dependency on LogBack... should use karaf logging config instead"

Set ofPort info to SFF's DPL while mapping

Each port of OVS gets a unique of_port. The of_port can be used
to steer traffics. This patch sets the ofPort infomation for
while mapping the OVS's port to SFF's DPL.

Change-Id: I2a70b66d2c7c8b0315c1ea27e927acf66856c531
Signed-off-by: Johnson Li <[email protected]>

Remove unused dependency on odl-inventory-model in odl-sfc-provider

Change-Id: I375205a0a06cb6bcc94a941995d6d0a1d2df6599
Signed-off-by: Ed Warnicke <[email protected]>

Cleaned out unused repos and dependencies.

Change-Id: I2196976bebee762e5da0e3e173c0972e2194d23d
Signed-off-by: Ed Warnicke <[email protected]>

Remove dependency on LogBack... should use karaf logging config instead

Change-Id: If59600c1343d10aeb096e594184f550755125362
Signed-off-by: Ed Warnicke <[email protected]>

Removing sal-common and netconf-connector from bootstrap

Change-Id: I4f3827dab95b7f1353fe3ccf206bd49c12149b14
Signed-off-by: Reinaldo Penno <[email protected]>

Merge "Fix sfclisp to use new lispflowmapping APIs"

Merge "Break out sfc-bootstrap from sfc-provider"

Fix sfclisp to use new lispflowmapping APIs

Gerrits 25567 and 25567 introduce a considerable number of
API changes. This patch updates sfclisp to leverage the new code.

Change-Id: Ic36fe82a37039bc6ece36eccbc686f97db2c20d6
Signed-off-by: Florin Coras <[email protected]>

Bug 4035: Removed unused dependency on sal-common

sal-common is being removed as its unused since Hydrogen, but needs
to be removed here so the build doesn't break.

See gerrit: https://git.opendaylight.org/gerrit/#/c/24467
where sal-common is being removed from controller.

Change-Id: I2655471e8739d61abbae84b8d2a50e4603d6f8ae
Signed-off-by: Ed Warnicke <[email protected]>

Break out sfc-bootstrap from sfc-provider

Change-Id: I720bf5e96eba59ed72c8b4b6131ff98a02d1254f
Signed-off-by: Ed Warnicke <[email protected]>

Merge "BUG4116: VNID->VNID mapping was over-writing C2->VNID on last flow."

Misc SFF Client Improvements

- Improve help string
- Improve doc strings
- Fix bug while log printing
- Simplify inner header construction with class

Change-Id: Ia54d7714d87d7bcda42508f4740497004aa46b21
Signed-off-by: Reinaldo Penno <[email protected]>

BUG4116: VNID->VNID mapping was over-writing C2->VNID on last flow.

Change-Id: I9e79f7b32b721b01e048298d857056f2c6398f28
Signed-off-by: Keith Burns (alagalah) <[email protected]>

Fix license header violations in sfc-netconf

Change-Id: I5fbac751fb0224a5a73edb74aa2974a301147443
Signed-off-by: Thanh Ha <[email protected]>

Fix license header violations in sfcofl2

Change-Id: I2eb4172ff94a6d7a999d3a8bc5dc3bf1cf9919f7
Signed-off-by: Thanh Ha <[email protected]>

Fix license header violations in sfc-ovs

Change-Id: If4a072f3442a21be56755db61431342715154fd8
Signed-off-by: Thanh Ha <[email protected]>

Fix license header violations in sfc-sb-rest

Change-Id: Ic3230d773fe6ad71ba858926e319c562c78c54e1
Signed-off-by: Thanh Ha <[email protected]>

Fix license header violations in sfc-ui

Change-Id: I5af399cdabfa869be781e9c81cdf8c19d319612e
Signed-off-by: Thanh Ha <[email protected]>

Fix license header violations in sfc-test-consumer

Change-Id: I60086118f77c79ba7af97bc42df9ce7b91265017
Signed-off-by: Thanh Ha <[email protected]>

Fix license header violations in sfc-provider

Change-Id: I82f7d94495e466ba8fe28f6f4e3bcbe10d51ca25
Signed-off-by: Thanh Ha <[email protected]>

Service Path-id Model Changes

- Leaf to allow different generation algorithms
- Broke allocated and free into two lists

Change-Id: I769455b5bf96bb1be2a904a23570457a92f82a74
Signed-off-by: Reinaldo Penno <[email protected]>

Merge "Service Path-Id Model"

Service Path-Id Model

This allows a few use-cases and critical functionality

- Reservation of path ids
- Association of a tenant with path-id(s)
- Proper tracking of path-ids outside SFP/RSP
- Clustering and persistence

Change-Id: I90b2eee1b54752fd7565d4beb26402dd83ff2905
Signed-off-by: Reinaldo Penno <[email protected]>

Merge "Factor out a proper -rest feature for odl-sfc-provider."

Bug 4093 - Yang module Fixes for pyang --ietf

Generation of new Yin files

Change-Id: I48bdbec97192296f01259c783a1de246b78beac2
Signed-off-by: Reinaldo Penno <[email protected]>

Merge "Move netconf-related SF description and monitoring info report into sfc-netconf"

Bug 4093 - Yang module Fixes for pyang --ietf

Also moved symmetric path attribute assigned into
creation method

Change-Id: I1726a6d8723c302e545530d49d7c4084f713471c
Signed-off-by: Reinaldo Penno <[email protected]>

Factor out a proper -rest feature for odl-sfc-provider.

Please note: I've replaced all dependencies on odl-sf-provider
with odl-sfc-provider-rest.  I suspect that no all such features
properly *need* the rest bit, but the safe way to proceed seemed
to be this until they can each be considered.

Also moved odl-mdsal-apidocs to the odl-sfc-ui feature.

Change-Id: I2fa23933bf50390cbb1cee85954a992de8e32e05
Signed-off-by: Ed Warnicke <[email protected]>

Move netconf-related SF description and monitoring info report into sfc-netconf

  - Rework SF description and monitoring info report
  - Enable netconf-based SF creation
  - Separate SF description and monitoring info report from sfc-provider
  - Move all the netconf-related pieces into sfc-netconf

Change-Id: I5ccdcc8bced89eb50ffc041bdc601dcf890caa60
Signed-off-by: Yi Yang <[email protected]>

Bug 4080 - Symmetric Path ID is not present in RSP

symmetric path-ids are implicitly consecutive but
they do not need to be for many reasons. Therefore
they must be present in RSP structure

Change-Id: I7877bc467c5ad12b5823fbd2b0b641364ac641ca
Signed-off-by: Reinaldo Penno <[email protected]>

Merge "Sfc-provider: add new unit tests + API update"

Merge "Sfc unit tests update & increased stability"

Sfc-provider: add new unit tests + API update

Change-Id: I61666e321fb78cb187d29c3efdccdb87507da726
Signed-off-by: Vladimir Lavor <[email protected]>
Signed-off-by: Igor Bartak <[email protected]>
Signed-off-by: Peter Palmar <[email protected]>

Sfc unit tests update & increased stability

Change-Id: I0b31e37902804594dda3683556005a3b40414159
Signed-off-by: Igor Bartak <[email protected]>
Signed-off-by: Vladimir Lavor <[email protected]>

Bug 3940 - fixed augmentations handling for SFF

When SFF gets to conf DS sooner than topology is populated in operational
DS, augmentations for ovsdb bridge and termination point fail to be
written into config DS. This patch solves this issue.

Change-Id: Icb2e81d88efd5a1806f9a0c304ea1cfe01a3c676
Signed-off-by: Tomas Cechvala <[email protected]>

Merge "Fixing a bug in the client tool for SFCOFL2 demo:"

Fixing a bug in the client tool for SFCOFL2 demo:

    - VLAN id masking value was wrong

Change-Id: I7a5a4399fc4af62c9fa622c4ba779847e9648070
Signed-off-by: Ricardo Noriega <[email protected]>

Explicitly set git-review branch to master

Change-Id: Id88b01dc5dd074b1e26b4921f9f03fe0cdc43b07
Signed-off-by: Thanh Ha <[email protected]>

Bug 4031 - SFC client broken for VXLAN legacy and GpeIP

SFC Client broken for VXLAN legacy

https://git.opendaylight.org/gerrit/#/c/24278/4

with this change

            # logger.debug('%s: Sending packets to %s', self.service_type, addr)
            # if nsh_decode.is_vxlan_nsh_legacy_message(data):
            # Disregard source port of received packet and send packet back to 6633
            # addr_l = list(addr)
            # addr_l[1] = 6633
            # addr = tuple(addr_l

Change-Id: I8af644f316f01a44e48da3f55d50eb9053567f37
Signed-off-by: Reinaldo Penno <[email protected]>

Updating Pypi Package After Classifier Support for NSH Type 1,3, Legacy

Change-Id: I7aa177be0cbfd543615c9d336dd2a59eb055daf8
Signed-off-by: Reinaldo Penno <[email protected]>

NSH  type 3 fixes

Change-Id: I8d89a25f0ca2e9f2750812258c9bcd91f095b46d
Signed-off-by: Marcel Sestak <[email protected]>

Fixing flow problems when multi SFs are on the same SFF

- Also removing some rest_sender changes that
  were accidentally added in a previous patch

Change-Id: I0eb6b898965297858c77566575565d88b6706f0f
Signed-off-by: Brady Johnson <[email protected]>

Updating Pypi package with lastest changes

Change-Id: Id88716fff06cb5f27c3062beb8c6077540612127
Signed-off-by: Reinaldo Penno <[email protected]>

uploading SFC python package to Pypi server in JJ sfc-verify-python-master

Change-Id: Ib48df64a14fafa5667419d4d162ff8893d6e47e0
Signed-off-by: Marcel Sestak <[email protected]>

Bug 3928 - SFC sonar: Constructor Calls Overridable Method

Change-Id: I3a47c5f06076c0856fefcbb4d1d3fe2bce49ead1
Signed-off-by: Ruijing Guo <[email protected]>

Bug 3996 - SFC and OVS interop: SFC Client needs to send Dest IP in context header 1

Change-Id: Ia0e67467bb363ac213fc9e13efb3d0c52eaa57ba
Signed-off-by: Reinaldo Penno <[email protected]>

BUG 3994 Fixing sfcofl2 crash when deleting RSPs.

- https://bugs.opendaylight.org/show_bug.cgi?id=3994

Change-Id: Iaa70139efcc3fc29b0859636d65930c57cde36c9
Signed-off-by: Brady Johnson <[email protected]>

Bug 3983 - NSH Inner Packet headers not constructed properly

Change-Id: Ib96a661e2aa73d4a50abba3e16c24736118e4e87
Signed-off-by: Reinaldo Penno <[email protected]>

Bug 3982 - SFC Agent does not work with OVS NSH v8

- NSH Client and Agent fixes for OVS Interop
- Python regression tests for SFC OVS
- Process packets with the format:
  IP + UDP + VXLAN (not GPE) + NSH .. on port 6633
  correctly
- If legacy NSH always send pakets on port 6633

Change-Id: I123186983900bbce07d39b940e560e443300c20e
Signed-off-by: Reinaldo Penno <[email protected]>

Bug 3980 - NSH client broken - Not able to send packets

the following patch broke NSH client

https://git.opendaylight.org/gerrit/#/c/23415/1

root@SFF-1-p:/vagrant/sfc-py/sfc# python3.4 sff_client.py --remote-sff-ip 192.168.33.31
 --remote-sff-port 6633 --sfp-id 1 --sfp-index 255
ERROR:asyncio:Exception in callback <bound method MyVxlanGpeNshIpClient.connection_made
of <__main__.MyVxlanGpeNshIpClient object at 0x7f52828a6f28>>(<asyncio.selector_events._
SelectorDatagramTransport object at 0x7f528296f748>,)
handle: Handle(<bound method MyVxlanGpeNshIpClient.connection_made of <__main__.MyVxlanG
peNshIpClient object at 0x7f52828a6f28>>, (<asyncio.selector_events._SelectorDatagramTra
nsport object at 0x7f528296f748>,))
Traceback (most recent call last):
  File "/usr/lib/python3.4/asyncio/events.py", line 39, in _run
    self._callback(*self._args)
  File "sff_client.py", line 90, in connection_made
    udp_packet = build_udp_packet(self.dest_addr, "10.0.1.1", 10000, self.dest_port, "te
st".encode('utf-8'))
  File "/vagrant/sfc-py/sfc/nsh/encode.py", line 282, in build_udp_packet
    ip_header, ip_header_pack = build_ipv4_header(total_len, socket.IPPROTO_UDP, src_ip,
 dest_ip)
  File "/vagrant/sfc-py/sfc/nsh/encode.py", line 237, in build_ipv4_header
    ip_header = IPHEADER(IP_HEADER_LEN, IPV4_VERSION, IPV4_TOS, ip_tot_len, IPV4_PACKET_
ID, 0, IPV4_TTL, proto, 0,
NameError: name 'IPHEADER' is not defined

Change-Id: I94ecec23c4de60f3f200d1f8e08c03ec9ddcf32e
Signed-off-by: Reinaldo Penno <[email protected]>

Demo fix and minor flow fix

- With multiple SFs per SFF, minor problem with flows
- Minor bug fixes to sfcofl2 demo client_tool

Change-Id: I1b5b7c881fb8a1f8c50ffd5a926ed514fb8b1c6f
Signed-off-by: Brady Johnson <[email protected]>

Bug3747 SfcProviderGraph & TopologyNode unit tests

Change-Id: I7cc005313096ae33a2f482387b5133cc10ec13e6
Signed-off-by: Vlado Lavor <[email protected]>

Merge "Bug3747 fix test failures in SfcServiceFunctionRoundRobinAPI.class"

Bug3747 fix test failures in SfcServiceFunctionRoundRobinAPI.class

Change-Id: I87f7d96c55e555b6c2eeb88a88e12e9e24d8e564
Signed-off-by: Vlado Lavor <[email protected]>

Improvements to sfcofl2 demo scripts

- Improved update_tor, no longer depends on gw flows
- Added client_tool to be able to set the RSP the client will use
- sfcofl2_mininet no longer uses static/hard-coded flow files

Change-Id: I0a75c9f47b8544bf217cff1ed8df7cf2d4041e27
Signed-off-by: Brady Johnson <[email protected]>

Changing the SFCOFL2 OF thread pool queueing

- Still want to be able to limit max queue size

Change-Id: I3501e9a1d4490427acc2102a238ec01203ed381a
Signed-off-by: Brady Johnson <[email protected]>

Merge "Bug 3795: Fix TE mapping removal on RSP deletion"

Merge "MD-SAL based network topology APIs"

MD-SAL based network topology APIs

It depends on l2switch to add HostNode, a SF
(Service Function) is a HostNode, we can get
a SF's port attached to a SFF (Service Function
Forwarder) by SF's DPL(Data Plane Locator), we
can also get ports between two SFFs by SFF node
id. sfcofl2 and shortest path scheduler algorithm
can use them to simplify many operations, network
topology provides full network topology info, we
mustn't use SFC models to get some non-existing
device info.

Change-Id: I09d81ce6a9e71525dcf988aa0a862fa5837aa71e
Signed-off-by: Yi Yang <[email protected]>

Merge "Bug 3927 - SFC sonar: Use Index Of Char"

Merge "Bug 3926 - SFC sonar: Constants should be declared "final static""

Bug 3932 - Network Exceptions not caught when Python Agent Started

Change-Id: I3621f4272d397ebd1e5b738ba79d5ec81a251c91
Signed-off-by: Reinaldo Penno <[email protected]>

Bug 3927 - SFC sonar: Use Index Of Char

Change-Id: I6fdf76ecc7d174414dff0d4d30da4c456617786d
Signed-off-by: Ruijing Guo <[email protected]>

Bug 3926 - SFC sonar: Constants should be declared "final static"

Change-Id: I3ea5e65bacb9c85449758675057864b371412d12
Signed-off-by: Ruijing Guo <[email protected]>

Bug3747 sfc-provider SfcProviderServiceFunctionAPI.class additional tests

Change-Id: I19c3df35b5c99cc43ad65e4e88e3d5bbd3d64659
Signed-off-by: Vlado Lavor <[email protected]>

Merge "Bug3747 sfc-provider update SfcServiceFunctionSchedulerAPITest"

Merge changes I62d1e828,I47caa069

* changes:
  Bug3747 RandomScheduler % RoundRobinScheduler junit tests
  Bug3747 SfcProviderServiceFunctionGroupAPI.class coverage increased

Merge "Bug 3916 - SFC blocker sonar: equals and hashCode should be overridden in pairs"

Bug3747 sfc-provider update SfcServiceFunctionSchedulerAPITest

Change-Id: Id8ed494b565ebb4e2dd1f3f112d60b8711281e7c
Signed-off-by: Vlado Lavor <[email protected]>

Bug 3795: Fix TE mapping removal on RSP deletion

Change-Id: Ifd77e3d46c25ddee19fa5c804fa95adfad3ebfc3
Signed-off-by: Florin Coras <[email protected]>
(cherry picked from commit 24fe0683a7c14a7237037a78b3284dfe7d7c9539)

Merge "Bug3747 sfc-provider increase coverage - SfcProviderAclApi.class"

Bug 3916 - SFC blocker sonar: equals and hashCode should be overridden in pairs

Change-Id: I710b6d5a4a473650142a2112b3fc44ef3e6700e5
Signed-off-by: Ruijing Guo <[email protected]>

Bug3747 RandomScheduler % RoundRobinScheduler junit tests

Change-Id: I62d1e828a529a54f64e728d5bfdc6622a6645398
Signed-off-by: Vlado Lavor <[email protected]>

Use artifact imports

Rather than repeating version, use an imported dependencyManagement
section.

Change-Id: I4326ada7dbb940edce17c54756906532e4594f00
Signed-off-by: Robert Varga <[email protected]>

Remove unneeded odlparent overrides

odlparent defines versions as well as pluginManagement/build
declarations equivalent to these. Simplify pom files by removing these
unneeded overrides.

Change-Id: I6af1cf445b90f045b316fe0f15648686facf9aca
Signed-off-by: Robert Varga <[email protected]>

Bug3747 SfcProviderServiceFunctionGroupAPI.class coverage increased

Change-Id: I47caa06901a99dc58fd3c643de864daf4660f966
Signed-off-by: Vlado Lavor <[email protected]>

Bug3747 sfc-provider increase coverage - SfcProviderAclApi.class

Change-Id: Ia535d72e1acab4e45932fc6d03d8bfe4bd71f65d
Signed-off-by: Vlado Lavor <[email protected]>

Merge "Fixing Sonar Problems and Cleaning"

metadata in sfc-classifier + NSH type-3 support

Change-Id: I363afeaab345112694db793ce4c14ed65d5a4d62
Signed-off-by: Marcel Sestak <[email protected]>

Fixing Sonar Problems and Cleaning

- SfcProviderRpc.java
  - Using older datastore methods
  - Non-compliant Exception catching

Change-Id: I99e0b77d449ebd2210b8eadae3849d84bc89da0b
Signed-off-by: Reinaldo Penno <[email protected]>

Merge "Bug 3848 - SFC Client does not work on Windows"

Bug 3850 - SFC Sonar: Breaking package dependencies

Introduced a new API class so that the Locking methods
can be outside the main OpendaylightSfc class. This breaks
one of the many package cycles

Changed all other files accordingly

Change-Id: I444d62e83a726731d52da3bcdaf226c1ebfc1225
Signed-off-by: Reinaldo Penno <[email protected]>

SfcOvsUtil coverage increased + SfcOvsDataStoreAPI tests update

Change-Id: I37a8500db9581c144f8151ee14678d6da0018d15
Signed-off-by: Vlado Lavor <[email protected]>

Merge "Rework unreliable tests in sfc-provider"

Bug 3848 - SFC Client does not work on Windows

- Bug reported by Haeffner, Walter, Vodafone DE
- Availble signals in windows are different from Linux. Introduced
  platform dependent code
- import paramiko is problematic on windows. Surrounded with
  try..Except

Change-Id: Ie2195e7b423f8e8e7b9afbd0338a818e2e62c8f9
Signed-off-by: Reinaldo Penno <[email protected]>

Rework unreliable tests in sfc-provider

Change-Id: I440202f2ce602ceea2921b7cc71087a5874c4ce0
Signed-off-by: Vlado Lavor <[email protected]>

Bug 3825 : Adding NSHC fields into GUI and JSON

This patch adds Network Context Header fields into the GUI
and passes thoses fields into the corresponding JSON to
ODL

Change-Id: Iadd11221673766ca391e1ac16fd5dbdef1a86fa0
Signed-off-by: Reinaldo Penno <[email protected]>

Bug 3825 : Allowing flow keyword into OVS fields

This is part of the fix. It allows the 'flow'
keyword into OVS fields

Create new Input field at top level to provide
bridge name

Change-Id: I296b048d64ba7c157532380441b632fbf67bb0ac
Signed-off-by: Reinaldo Penno <[email protected]>

Merge "Revert "Add Connected SFF Dictionary into SFF""

Revert "Add Connected SFF Dictionary into SFF"

This reverts commit e5067e8e51f9e09e7340d029a9eaca43a0ec969b.

Change-Id: If397cc6c0d65acc5121ddcccdf1cfb26dc368d6f
Signed-off-by: Your Name <[email protected]>