bgpcep.git
10 years agoDo not hard-code HashedWheelTimer 09/5509/3
Robert Varga [Sun, 2 Mar 2014 14:28:40 +0000 (15:28 +0100)]
Do not hard-code HashedWheelTimer

This patch moves out the HashedWheelTimer from BGPDispatcherImpl and
allows it to be configured. Additionally the default configuration is
updated to reuse the global timer.

Change-Id: I09019da9e60c06ba10753344d5434294abec41cc
Signed-off-by: Robert Varga <rovarga@cisco.com>
10 years agoRemoved final modifier, so that LSPA parser can be extended. 16/5516/2
Dana Kutenicsova [Mon, 3 Mar 2014 15:22:13 +0000 (16:22 +0100)]
Removed final modifier, so that LSPA parser can be extended.

Change-Id: I4e962d88cf512a23573b0b7de2472c17e51841fd
Signed-off-by: Dana Kutenicsova <dkutenic@cisco.com>
10 years agoSplit pcep configuration to parser and provider. 13/5513/2
Dana Kutenicsova [Mon, 3 Mar 2014 13:32:00 +0000 (14:32 +0100)]
Split pcep configuration to parser and provider.

Change-Id: Ie9899635a341eff05464269f0f68fcfb80ac9b65
Signed-off-by: Dana Kutenicsova <dkutenic@cisco.com>
10 years agoFix RIBImplModuleTest to work after default modules in sal are removed. 97/5497/2
Tomas Olvecky [Fri, 28 Feb 2014 10:49:26 +0000 (11:49 +0100)]
Fix RIBImplModuleTest to work after default modules in sal are removed.

Commit http://git.opendaylight.org/gerrit/5496 will break this test, this commit fixes it.

Change-Id: Id198e77c2e5374c83e4a6e27df68c73b24bf9bb4
Signed-off-by: Tomas Olvecky <tolvecky@cisco.com>
10 years agoDo not degrate remote BGP identifier into a bytearrray 70/5470/5
Robert Varga [Wed, 26 Feb 2014 11:41:40 +0000 (12:41 +0100)]
Do not degrate remote BGP identifier into a bytearrray

Change-Id: I6bb3bf64445c6956adea6794f24d7fc538724d36
Signed-off-by: Robert Varga <rovarga@cisco.com>
10 years agoBUG-353: add remote-as awareness 68/5468/5
Robert Varga [Wed, 26 Feb 2014 09:59:40 +0000 (10:59 +0100)]
BUG-353: add remote-as awareness

This adds the configuration knob for the remote AS. Furthermore it adds
validation of the AS advertizement during negotiation. Drive-by fixes
include introduction of buildErrorNotify() and rename of fields inside
BGPObjectComparator for clarity.

Change-Id: Ie60e0633d84a8a6a239517600e4666dee2a0d3ed
Signed-off-by: Robert Varga <rovarga@cisco.com>
10 years agoRework BGP configuration 94/4794/23
Robert Varga [Sat, 25 Jan 2014 16:05:47 +0000 (17:05 +0100)]
Rework BGP configuration

This patch reworks the structure of BGP configuration so that it follows
the logical organization of the RIB.

The core change is the creation of BGPPeer as a full-blown configuration
item. This encapsulates the previous proposal configuration and has the
inverse relationship with the RIB: the RIB is its dependency and it
pulls things like the local AS and BGP identifier from it.

Futher improvement is the introduction of bgp-table-type, which allows
explicit listing of tables which should be advertized in the BGP Open
message as well as specification of which tables should be tracked in
the local RIB.

Change-Id: I905759a3d9e780394579238d48ff0aee009a5544
Signed-off-by: Robert Varga <rovarga@cisco.com>
Signed-off-by: Maros Marsalek <mmarsale@cisco.com>
10 years agoBGPCEP distribution package cleanup 79/5479/2
Miroslav Miklus [Thu, 27 Feb 2014 12:22:01 +0000 (13:22 +0100)]
BGPCEP distribution package cleanup

Removed ad-sal with all dependendent bundles
Removed NB applications, Openflow, odl web, netconf-ssh

Change-Id: I47b4ad7a3b0ad2a724c0156c9f7654f7a9d794cb
Signed-off-by: Miroslav Miklus <mmiklus@cisco.com>
10 years agoUse sendMessage() from AbstractSessionNegotiator 61/5461/2
Robert Varga [Tue, 25 Feb 2014 16:41:56 +0000 (17:41 +0100)]
Use sendMessage() from AbstractSessionNegotiator

AbstractSessionNegotiator now exposes sendMessage(), which aside from
issuing a writeAndFlush() also makes sure the message leaves the socket
and fails negotiation otherwise. Let's use that throughout our
negotiators, as that will harden them in race conditions.

Change-Id: Ice6995bc3a0121bef219268ac18cdb885118d1a1
Signed-off-by: Robert Varga <rovarga@cisco.com>
10 years agoBUG-430: Split off the various proposals 40/5440/5
Robert Varga [Fri, 21 Feb 2014 14:25:50 +0000 (15:25 +0100)]
BUG-430: Split off the various proposals

This creates the proper structure for per-revision proposals.

Change-Id: Ie17588a35cebc0a2557e7f9f3cfdbf98069d4aa5
Signed-off-by: Robert Varga <rovarga@cisco.com>
Signed-off-by: Dana Kutenicsova <dkutenic@cisco.com>
10 years agoSwitch to using ListenerRegistration from yangtools 71/5471/2
Robert Varga [Wed, 26 Feb 2014 12:20:22 +0000 (13:20 +0100)]
Switch to using ListenerRegistration from yangtools

Yangtools concepts have been updated to mmatch our ListenerRegistration
semantics, so there's no reason to keep it around. Migrate our code and
remove it from our concepts.

Also remove Immutable interface. It has been deprecated and unused --
again, yangtools concepts carry the equivalent interface.

Change-Id: I28e5b4e06df0e0b39f808768763c341ad166e352
Signed-off-by: Robert Varga <rovarga@cisco.com>
10 years agoBump config and netconf versions to 0.2.5-SNAPSHOT, bump ietf-yang-types, opendayligh... 59/5459/1
Tomas Olvecky [Tue, 25 Feb 2014 11:34:28 +0000 (12:34 +0100)]
Bump config and netconf versions to 0.2.5-SNAPSHOT, bump ietf-yang-types, opendaylight-l2-types.

Change-Id: I9400f1e43d7e8b053c614d120bc4a764bdf1e726
Signed-off-by: Tomas Olvecky <tolvecky@cisco.com>
10 years agoMerge "Update copied 00-netty.xml with name enforcing of 'netty-global-event-executor...
Dana Kutenicsova [Tue, 25 Feb 2014 09:42:43 +0000 (09:42 +0000)]
Merge "Update copied 00-netty.xml with name enforcing of 'netty-global-event-executor' to 'singleton'."

10 years agoMore tests for stateful02 module. 50/5450/1
Dana Kutenicsova [Mon, 24 Feb 2014 10:35:07 +0000 (11:35 +0100)]
More tests for stateful02 module.

Change-Id: I8a191ee66c0ffb0b762e7753a1ca3408d5768fa3
Signed-off-by: Dana Kutenicsova <dkutenic@cisco.com>
10 years agoUpdate copied 00-netty.xml with name enforcing of 'netty-global-event-executor' to... 20/5420/2
Tomas Olvecky [Thu, 20 Feb 2014 09:56:05 +0000 (10:56 +0100)]
Update copied 00-netty.xml with name enforcing of 'netty-global-event-executor' to 'singleton'.

Change-Id: Ibe4882b83ace8cbad230375cbb9d3786128e134f
Signed-off-by: Tomas Olvecky <tolvecky@cisco.com>
10 years agoCleaned up concepts. 16/5416/3
Dana Kutenicsova [Wed, 19 Feb 2014 15:53:42 +0000 (16:53 +0100)]
Cleaned up concepts.

Change-Id: Ifba0889a6c063eecc172ec01db22582ac0bf38b1
Signed-off-by: Dana Kutenicsova <dkutenic@cisco.com>
10 years agoFix tests in rib-impl-config to use 'singleton' name for global event executor. 19/5419/1
Tomas Olvecky [Thu, 20 Feb 2014 08:44:33 +0000 (09:44 +0100)]
Fix tests in rib-impl-config to use 'singleton' name for global event executor.

Change-Id: Ic9609026145edd2850dd9ac7266eb43c83a97b1a
Signed-off-by: Tomas Olvecky <tolvecky@cisco.com>
10 years agoMerge changes I9c2aaa2e,Ia94bce78,I3a84c6c8
Robert Varga [Wed, 19 Feb 2014 11:11:33 +0000 (11:11 +0000)]
Merge changes I9c2aaa2e,Ia94bce78,I3a84c6c8

* changes:
  Fixed NPE and updated logging.
  Fixed update tunnel hanging.
  Set proposal to default stateful02 session proposal.

10 years agoFixed NPE and updated logging. 10/5410/1
Dana Kutenicsova [Wed, 19 Feb 2014 09:24:43 +0000 (10:24 +0100)]
Fixed NPE and updated logging.

Change-Id: I9c2aaa2e35dad85ceccdeeb0a2fec704538ab43c
Signed-off-by: Dana Kutenicsova <dkutenic@cisco.com>
10 years agoFixed update tunnel hanging. 85/5385/2
Dana Kutenicsova [Tue, 18 Feb 2014 08:55:37 +0000 (09:55 +0100)]
Fixed update tunnel hanging.

Change-Id: Ia94bce78d4de8ca31a2c363c364bae39f6c71e5b
Signed-off-by: Dana Kutenicsova <dkutenic@cisco.com>
10 years agoMake sure to set the LSP name 89/5389/1
Robert Varga [Tue, 18 Feb 2014 10:18:29 +0000 (11:18 +0100)]
Make sure to set the LSP name

This may have contributed to LSPs not being visible.

Change-Id: I8c97c0787c00453fb5f80e96291fffce7cfff8b8
Signed-off-by: Robert Varga <rovarga@cisco.com>
10 years agoSet proposal to default stateful02 session proposal. 28/5328/1
Dana Kutenicsova [Fri, 14 Feb 2014 12:29:50 +0000 (13:29 +0100)]
Set proposal to default stateful02 session proposal.

Change-Id: I3a84c6c8b0811c10187cf36a9553bc30244aa56c
Signed-off-by: Dana Kutenicsova <dkutenic@cisco.com>
10 years agoMerge "BGPCEP distribution package core bundle version fix"
Robert Varga [Thu, 13 Feb 2014 17:39:31 +0000 (17:39 +0000)]
Merge "BGPCEP distribution package core bundle version fix"

10 years agoBGPCEP distribution package core bundle version fix 07/5307/1
Miroslav Miklus [Thu, 13 Feb 2014 15:32:38 +0000 (16:32 +0100)]
BGPCEP distribution package core bundle version fix

Fixed version of logging.bridge

Change-Id: I8bd7ee150f550656f12ee5b2f0c19aa22468253e
Signed-off-by: Miroslav Miklus <mmiklus@cisco.com>
10 years agoRefactored LspDbVersion parser. 03/5303/1
Dana Kutenicsova [Thu, 13 Feb 2014 09:30:00 +0000 (10:30 +0100)]
Refactored LspDbVersion parser.

Change-Id: Iebc6cf8626ae06b757c0f2f57e1365b3a60ba3a3
Signed-off-by: Dana Kutenicsova <dkutenic@cisco.com>
10 years agoMerge "BGPCEP distribution package fix"
Robert Varga [Wed, 12 Feb 2014 21:26:18 +0000 (21:26 +0000)]
Merge "BGPCEP distribution package fix"

10 years agoBGPCEP distribution package fix 84/5284/2
Miroslav Miklus [Wed, 12 Feb 2014 14:21:10 +0000 (15:21 +0100)]
BGPCEP distribution package fix

Multiple bundles added to distribution package

Change-Id: Ia38323e7dfcca3313f90f2373828ce04666f2d31
Signed-off-by: Miroslav Miklus <mmiklus@cisco.com>
10 years agoFixed missing tlvs from base parser. 81/5281/1
Dana Kutenicsova [Wed, 12 Feb 2014 10:24:37 +0000 (11:24 +0100)]
Fixed missing tlvs from base parser.

Change-Id: I5ce104023fec836925cd99149a228461f99ab5f8
Signed-off-by: Dana Kutenicsova <dkutenic@cisco.com>
10 years agoBGPCEP controller distribution package 14/5214/5
Miroslav Miklus [Sun, 9 Feb 2014 20:38:12 +0000 (21:38 +0100)]
BGPCEP controller distribution package

BGPCEP ZIP package contains base controller, bgp and pcep bundles

Change-Id: I8da6f7f7503cf8877960dfbc5b79b1ead6fee70b
Signed-off-by: Miroslav Miklus <mmiklus@cisco.com>
Signed-off-by: Robert Varga <rovarga@cisco.com>
Signed-off-by: Dana Kutenicsova <dkutenic@cisco.com>
10 years agoTopology provider rework to use lsp name instead of PLSPID as key. 29/5229/6
Dana Kutenicsova [Tue, 11 Feb 2014 09:59:55 +0000 (10:59 +0100)]
Topology provider rework to use lsp name instead of PLSPID as key.

Change-Id: Ib36dbdca734bc997e1d03f611a0c9c1b2076689a
Signed-off-by: Dana Kutenicsova <dkutenic@cisco.com>
10 years agoBump version of protocol-framework to 0.5.0-SNAPSHOT 54/5254/1
Maros Marsalek [Tue, 11 Feb 2014 10:33:24 +0000 (11:33 +0100)]
Bump version of protocol-framework to 0.5.0-SNAPSHOT

Change-Id: I2aaed0bd32f6b478f72319b4c4c41a17c1545a4f
Signed-off-by: Maros Marsalek <mmarsale@cisco.com>
10 years agoFix a few typos in the description 36/5236/1
Robert Varga [Tue, 4 Feb 2014 21:25:42 +0000 (22:25 +0100)]
Fix a few typos in the description

Change-Id: I96eadc28957031bd8e5d7eb73ea5ec35f263cab3
Signed-off-by: Robert Varga <rovarga@cisco.com>
10 years agoGet rid of mockito exceptions in tests. 28/5228/1
Dana Kutenicsova [Mon, 10 Feb 2014 14:32:02 +0000 (15:32 +0100)]
Get rid of mockito exceptions in tests.

Change-Id: I39a7177bb49c943b1b95017222b03d888c542e07
Signed-off-by: Dana Kutenicsova <dkutenic@cisco.com>
10 years agoRemoved duplicated code from stateful02. Extended existing parsers. 01/5201/1
Dana Kutenicsova [Sat, 8 Feb 2014 12:23:19 +0000 (13:23 +0100)]
Removed duplicated code from stateful02. Extended existing parsers.

Change-Id: Ib5f0a5776fdc47d147f592871fff03358bccf9df
Signed-off-by: Dana Kutenicsova <dkutenic@cisco.com>
10 years agoMerge "Synchronized with snapshot releases again"
Dana Kutenicsova [Fri, 7 Feb 2014 20:19:54 +0000 (20:19 +0000)]
Merge "Synchronized with snapshot releases again"

10 years agoSynchronized with snapshot releases again 76/5176/1
Robert Varga [Fri, 7 Feb 2014 18:49:06 +0000 (19:49 +0100)]
Synchronized with snapshot releases again

Change-Id: Iab5f648863690721657b2be24872c52b47b35eea
Signed-off-by: Robert Varga <rovarga@cisco.com>
10 years agoRemoved duplicated code from stateful07. 75/5175/1
Dana Kutenicsova [Fri, 7 Feb 2014 15:46:01 +0000 (16:46 +0100)]
Removed duplicated code from stateful07.
Extended existing parsers.

Change-Id: I55d3b5c45c15aa1d2723603bf254004a382a6896
Signed-off-by: Dana Kutenicsova <dkutenic@cisco.com>
10 years agoRemoved duplicate code from Open and LSPA object parsers in stateful02. 73/5173/2
Dana Kutenicsova [Fri, 7 Feb 2014 15:07:02 +0000 (16:07 +0100)]
Removed duplicate code from Open and LSPA object parsers in stateful02.

Change-Id: I98c3905d9cf6ac703bb1f76fe4eb4fe98c8d67e2
Signed-off-by: Dana Kutenicsova <dkutenic@cisco.com>
10 years agoRemoved duplicated code from stateful07 Open and LSPA object parsers. 62/5162/7
Robert Varga [Fri, 7 Feb 2014 07:06:52 +0000 (08:06 +0100)]
Removed duplicated code from stateful07 Open and LSPA object parsers.

Change-Id: I4bf7428c67a95ba75930e9a2293e8d6ad032f3fc
Signed-off-by: Robert Varga <rovarga@cisco.com>
Signed-off-by: Dana Kutenicsova <dkutenic@cisco.com>
10 years agoRename stateful02 handlers 59/5159/1
Robert Varga [Fri, 7 Feb 2014 01:34:19 +0000 (02:34 +0100)]
Rename stateful02 handlers

Preparatory work for tying them with the base implementations.

Change-Id: Ie4a6727e25b9de2217bc78ece8fae91d8c2d94fa
Signed-off-by: Robert Varga <rovarga@cisco.com>
10 years agoRename stateful07 handlers 58/5158/1
Robert Varga [Thu, 6 Feb 2014 22:34:23 +0000 (23:34 +0100)]
Rename stateful07 handlers

This prepares for sticking them under the base parser as subclasses
without getting lost in names.

Change-Id: Ia3c756399fd1ca28ae8f495ec9da790be56716ef
Signed-off-by: Robert Varga <rovarga@cisco.com>
10 years agoDefined Symbolic path name TLV to LSPA. 48/5148/5
Dana Kutenicsova [Thu, 6 Feb 2014 14:13:00 +0000 (15:13 +0100)]
Defined Symbolic path name TLV to LSPA.

Change-Id: Ib6c82582d7ff2bbed1d3cccaace53be3bc555ae3
Signed-off-by: Dana Kutenicsova <dkutenic@cisco.com>
10 years agoAdded cleanup tlv to session proposal. 41/5141/5
Dana Kutenicsova [Wed, 5 Feb 2014 23:03:27 +0000 (00:03 +0100)]
Added cleanup tlv to session proposal.

Change-Id: Ia1bd0df7370a0ec776c8ee78bfd3e982c7d37a6e
Signed-off-by: Dana Kutenicsova <dkutenic@cisco.com>
10 years agoSetting stateful02 to be primary draft version. 37/5137/6
Dana Kutenicsova [Wed, 5 Feb 2014 21:23:31 +0000 (22:23 +0100)]
Setting stateful02 to be primary draft version.

Change-Id: I67cabb804da2fc10cf52f996b407822e9c89e5d6
Signed-off-by: Dana Kutenicsova <dkutenic@cisco.com>
10 years agoRemove invalid activator references 56/5156/1
Robert Varga [Thu, 6 Feb 2014 17:27:09 +0000 (18:27 +0100)]
Remove invalid activator references

Change-Id: Ibc1471a60f8411251f938ab8f39e0ec22eff60f8
Signed-off-by: Robert Varga <rovarga@cisco.com>
10 years agoMultiRegistry now looks at class hierarchy of values 51/5151/1
Robert Varga [Thu, 6 Feb 2014 15:45:57 +0000 (16:45 +0100)]
MultiRegistry now looks at class hierarchy of values

This allows us to have two implementations of a serializer and pick the
more specific one.

Change-Id: Icccfc6da9034a1f23faefd2c1a535c30a309642c
Signed-off-by: Robert Varga <rovarga@cisco.com>
10 years agoFix LSPs not being reported 49/5149/1
Robert Varga [Thu, 6 Feb 2014 15:30:02 +0000 (16:30 +0100)]
Fix LSPs not being reported

It turns out the end-of-sync check needs to look at the PLSPID, too,
otherwise we ignore all reports after the initial sync.

Change-Id: Ib3b33222a435a7dbb17ebdeac434c127b0bbb7db
Signed-off-by: Robert Varga <rovarga@cisco.com>
10 years agoTurn stateful/impl dependecies around 39/5139/1
Robert Varga [Wed, 5 Feb 2014 21:36:45 +0000 (22:36 +0100)]
Turn stateful/impl dependecies around

Change-Id: I91bfb1d6d208fcbfb5423c6d7c97297a80d7387b
Signed-off-by: Robert Varga <rovarga@cisco.com>
10 years agoIntroduce AbstractPCEPSessionProposalFactory for reuse 38/5138/1
Robert Varga [Wed, 5 Feb 2014 19:54:28 +0000 (20:54 +0100)]
Introduce AbstractPCEPSessionProposalFactory for reuse

Change-Id: Iaa4cf995a28b1a940c03e0f0cd0e99fe4b7a1ecf
Signed-off-by: Robert Varga <rovarga@cisco.com>
10 years agoRemove empty addTlv() methods 36/5136/1
Robert Varga [Wed, 5 Feb 2014 18:18:45 +0000 (19:18 +0100)]
Remove empty addTlv() methods

This cleans the parsers up, improving visibility into who is mucking
with TLVs.

Change-Id: If4092602f7c921e3592c4352734d8a2e11396046
Signed-off-by: Robert Varga <rovarga@cisco.com>
10 years agoKeepalive message can be shared between instances 35/5135/1
Robert Varga [Wed, 5 Feb 2014 15:20:21 +0000 (16:20 +0100)]
Keepalive message can be shared between instances

Change-Id: I1d3ae97a295a348d1a0610d6f94cc1574c6638a7
Signed-off-by: Robert Varga <rovarga@cisco.com>
10 years agoBUG-393 : Fixed parsing for LSP object. 29/5129/2
Dana Kutenicsova [Wed, 5 Feb 2014 11:50:49 +0000 (12:50 +0100)]
BUG-393 : Fixed parsing for LSP object.
Removed wrong handling of PCEP messages.

Change-Id: If7b57dd2bf7ce56bee4c4f041cf64ddf667c72fa
Signed-off-by: Dana Kutenicsova <dkutenic@cisco.com>
10 years agoUse reference cache for Communities and ASes 23/5123/1
Robert Varga [Wed, 5 Feb 2014 03:01:01 +0000 (04:01 +0100)]
Use reference cache for Communities and ASes

These two type of objects get reused over and over again, so it makes
sense to actually use refcaching on them.

Change-Id: I9c63ab23cdf0480055e7a868a73107c4ac9926ff
Signed-off-by: Robert Varga <rovarga@cisco.com>
10 years agoIntroduce the ReferenceCache concept 17/5117/2
Robert Varga [Tue, 4 Feb 2014 13:15:08 +0000 (14:15 +0100)]
Introduce the ReferenceCache concept

This is a simple CPU/memory tradeoff primitive, which allows for sharing
of object references in the cardinality/frequency of a particular object
type is favorable. AsNumber is typical candidate.

Change-Id: I79ab163f5da32ad5f99ba99246ae96005ac03df5
Signed-off-by: Robert Varga <rovarga@cisco.com>
10 years agoAdd a bit of documentation to extension contexts 16/5116/1
Robert Varga [Tue, 4 Feb 2014 01:10:10 +0000 (02:10 +0100)]
Add a bit of documentation to extension contexts

Change-Id: Iaadb9e7874c68fdd1d7225ca414d7daf720728a3
Signed-off-by: Robert Varga <rovarga@cisco.com>
10 years agoFixed small bugs in PCEP. Adjusted configuration. 14/5114/4
Dana Kutenicsova [Tue, 4 Feb 2014 09:50:24 +0000 (10:50 +0100)]
Fixed small bugs in PCEP. Adjusted configuration.

Change-Id: I0879c7ffada0c8444e4cfe2694970fbebfdc6fc7
Signed-off-by: Dana Kutenicsova <dkutenic@cisco.com>
10 years agoCleaned up linkstate project. 02/5102/4
Dana Kutenicsova [Mon, 3 Feb 2014 13:40:32 +0000 (14:40 +0100)]
Cleaned up linkstate project.

Change-Id: I0b5e97e882bc694de32a8f2da7c6ef45a225ce67
Signed-off-by: Dana Kutenicsova <dkutenic@cisco.com>
10 years agoTurn putOperationalData() in replace operations 08/5108/1
Robert Varga [Mon, 3 Feb 2014 19:08:02 +0000 (20:08 +0100)]
Turn putOperationalData() in replace operations

It turns out that putOperationalData is really a merge, not a replace.
Force it to a replace by issuing an explicit remove. This depends on
https://git.opendaylight.org/gerrit/#/c/5106/ to work as designed.

Change-Id: Ic7106c51c7226d9c06aa78df56efb9adc834b74b
Signed-off-by: Robert Varga <rovarga@cisco.com>
10 years agoFix formatting 04/5104/1
Robert Varga [Wed, 29 Jan 2014 21:04:32 +0000 (22:04 +0100)]
Fix formatting

Change-Id: I4933c956a1f6b7662fe907b16718b0204d20db7d
Signed-off-by: Robert Varga <rovarga@cisco.com>
10 years agoRework Termination Point state handling 60/5060/3
Robert Varga [Mon, 27 Jan 2014 16:44:56 +0000 (17:44 +0100)]
Rework Termination Point state handling

It turns out that MD-SAL does transaction reordering and provides not
guarantees to data visibility between transactions. Until that is fixed,
do not rely on data in MD-SAL, but rather do our own state tracking.

Change-Id: Idf1a14f9f61c78d651e3f29970faa87436bdb8ca
Signed-off-by: Robert Varga <rovarga@cisco.com>
10 years agoFix topology not showing prefixes learned from BGP/LS 59/5059/2
Robert Varga [Fri, 31 Jan 2014 11:17:26 +0000 (12:17 +0100)]
Fix topology not showing prefixes learned from BGP/LS

The Linkstate RIB plugin was losing IP reachability information in the
prefix case. Fix it by using the copy builder constructor.

Also add a defensive check for IP reachability presence in the topology
builder.

Change-Id: I0b16b036397a935771d86a3c7253c998e594ec7c
Signed-off-by: Robert Varga <rovarga@cisco.com>
10 years agoMerge "Revert "Force export of *.impl package""
Dana Kutenicsova [Fri, 31 Jan 2014 13:19:00 +0000 (13:19 +0000)]
Merge "Revert "Force export of *.impl package""

10 years agoRevert "Force export of *.impl package" 63/5063/1
Robert Varga [Fri, 31 Jan 2014 13:11:34 +0000 (14:11 +0100)]
Revert "Force export of *.impl package"

This reverts commit fa59dde5163f230ec2cb594d61928c066ac55cde.

Change-Id: Id757da382ff01d0b2fd36a3390ca1b72545e5ae9
Signed-off-by: Robert Varga <rovarga@cisco.com>
10 years agoAdded some API documentation. 56/5056/1
Dana Kutenicsova [Fri, 31 Jan 2014 10:35:15 +0000 (11:35 +0100)]
Added some API documentation.

Change-Id: I4fe17f920c8483694842ac96759ef45aa3765c1f
Signed-off-by: Dana Kutenicsova <dkutenic@cisco.com>
10 years agoMerge "Fix NPE when sending a PCInitiate message"
Dana Kutenicsova [Wed, 29 Jan 2014 16:51:43 +0000 (16:51 +0000)]
Merge "Fix NPE when sending a PCInitiate message"

10 years agoMerge "Remove superfluous version declaration"
Dana Kutenicsova [Wed, 29 Jan 2014 16:50:59 +0000 (16:50 +0000)]
Merge "Remove superfluous version declaration"

10 years agoFix NPE when sending a PCInitiate message 00/5000/1
Robert Varga [Wed, 29 Jan 2014 13:23:40 +0000 (14:23 +0100)]
Fix NPE when sending a PCInitiate message

Change-Id: I4c167b5465d200a5293bb6c0b7530b116a0cbf6c
Signed-off-by: Robert Varga <rovarga@cisco.com>
10 years agoRemove superfluous version declaration 99/4999/1
Robert Varga [Tue, 28 Jan 2014 14:31:11 +0000 (15:31 +0100)]
Remove superfluous version declaration

Change-Id: Iff8638e62b77041b412b275a0c172d9b2985369a
Signed-off-by: Robert Varga <rovarga@cisco.com>
10 years agoAdd the ability to configure which stateful revision should be supported 55/4855/5
Robert Varga [Mon, 27 Jan 2014 09:53:17 +0000 (10:53 +0100)]
Add the ability to configure which stateful revision should be supported

Change-Id: I241e47873fc6ace8e2c0283bb4b38a93c3a8a98a
Signed-off-by: Robert Varga <rovarga@cisco.com>
10 years agoActivate modules by default, but do not use them 64/4864/2
Robert Varga [Mon, 27 Jan 2014 11:29:53 +0000 (12:29 +0100)]
Activate modules by default, but do not use them

Change-Id: I29d4ca38cd0d6fb7dd9e9bc72205c872d9a8992d
Signed-off-by: Robert Varga <rovarga@cisco.com>
10 years agoForce export of *.impl package 45/4945/1
Robert Varga [Mon, 27 Jan 2014 22:03:05 +0000 (23:03 +0100)]
Force export of *.impl package

Change-Id: Ia3e904ab0dbf7252d77e3d81aaae3817b5124978
Signed-off-by: Robert Varga <rovarga@cisco.com>
10 years ago[maven-release-plugin] prepare for next development iteration
jenkins-bgpcep [Mon, 27 Jan 2014 22:23:26 +0000 (22:23 +0000)]
[maven-release-plugin] prepare for next development iteration

10 years ago[maven-release-plugin] prepare release releasepom-0.3.0 releasepom-0.3.0
jenkins-bgpcep [Mon, 27 Jan 2014 22:23:24 +0000 (22:23 +0000)]
[maven-release-plugin] prepare release releasepom-0.3.0

10 years agoBump versions to controller release artifacts 32/4932/2 jenkins-bgpcep-bulk-release-prepare-only-7
Robert Varga [Mon, 27 Jan 2014 21:23:34 +0000 (22:23 +0100)]
Bump versions to controller release artifacts

Change-Id: I73c8a81273bbed8f06fbe1fb59d0cd1fd52b800d
Signed-off-by: Robert Varga <rovarga@cisco.com>
10 years agoFix test referencing controller version 35/4935/1
Robert Varga [Mon, 27 Jan 2014 21:30:27 +0000 (22:30 +0100)]
Fix test referencing controller version

Change-Id: I214df1bbdb9c0ed5e29839a982e9399892b0ab3e
Signed-off-by: Robert Varga <rovarga@cisco.com>
10 years agoUnify version handling 31/4931/1
Robert Varga [Mon, 27 Jan 2014 21:18:43 +0000 (22:18 +0100)]
Unify version handling

Change-Id: I904d944a43c47c9ac7eae23418c5ced76d0642ac
Signed-off-by: Robert Varga <rovarga@cisco.com>
10 years agoBump to yangtools 0.6.1 and related versions 03/4903/3
Robert Varga [Mon, 27 Jan 2014 16:46:25 +0000 (17:46 +0100)]
Bump to yangtools 0.6.1 and related versions

Change-Id: I9e56727c122e57ab6b0fc8e0273a4c10bad242a5
Signed-off-by: Robert Varga <rovarga@cisco.com>
10 years agoRemove exificient dependency 08/4908/1
Robert Varga [Mon, 27 Jan 2014 17:05:39 +0000 (18:05 +0100)]
Remove exificient dependency

Change-Id: I06c881a59e5bba6b52ee91c580a2f982481f6e01
Signed-off-by: Robert Varga <rovarga@cisco.com>
10 years agoUnify version handling 02/4902/1
Robert Varga [Mon, 27 Jan 2014 16:44:17 +0000 (17:44 +0100)]
Unify version handling

Change-Id: Ifab11a40932466b1d11be8f327d206a08681b43f
Signed-off-by: Robert Varga <rovarga@cisco.com>
10 years agoMerge "Improve logging of object removal" jenkins-bgpcep-bulk-release-prepare-only-6
Dana Kutenicsova [Mon, 27 Jan 2014 14:59:30 +0000 (14:59 +0000)]
Merge "Improve logging of object removal"

10 years agoMerge "Improve formatting of termination point identifiers"
Dana Kutenicsova [Mon, 27 Jan 2014 14:53:09 +0000 (14:53 +0000)]
Merge "Improve formatting of termination point identifiers"

10 years agoImprove logging of object removal 89/4889/1
Robert Varga [Mon, 27 Jan 2014 14:50:33 +0000 (15:50 +0100)]
Improve logging of object removal

Change-Id: Ie58e11e2f1111a07d1755c6a5fbf7e7e19e41bf2
Signed-off-by: Robert Varga <rovarga@cisco.com>
10 years agoAdded Ipv6 to local bgp proposal and adjusted handling of remote proposal. 65/4865/2
Dana Kutenicsova [Mon, 27 Jan 2014 12:12:00 +0000 (13:12 +0100)]
Added Ipv6 to local bgp proposal and adjusted handling of remote proposal.

Change-Id: I2641bd221e88d0d4aecbac40d52cec11dbc7e298
Signed-off-by: Dana Kutenicsova <dkutenic@cisco.com>
10 years agoImprove formatting of termination point identifiers 83/4883/1
Robert Varga [Mon, 27 Jan 2014 14:13:27 +0000 (15:13 +0100)]
Improve formatting of termination point identifiers

Change-Id: I1ed0a7f9c8454422ea5e808c5721d4835c953516
Signed-off-by: Robert Varga <rovarga@cisco.com>
10 years agoMerge changes I305a96fb,Ief4bb355
Dana Kutenicsova [Mon, 27 Jan 2014 13:16:54 +0000 (13:16 +0000)]
Merge changes I305a96fb,Ief4bb355

* changes:
  Workaround MD-SAL ordering issues, lose data anyway
  Do not rely on route attributes being present

10 years agoWorkaround MD-SAL ordering issues, lose data anyway 69/4869/1
Robert Varga [Mon, 27 Jan 2014 12:35:33 +0000 (13:35 +0100)]
Workaround MD-SAL ordering issues, lose data anyway

Fixes the following exception  into a warning:

2014-01-27 10:45:06.598 GMT [md-sal-binding-commit-8] WARN  o.o.b.b.t.p.AbstractTopologyBuilder - Data change org.opendaylight.controller.md.sal.common.impl.service.DataChangeEventImpl@34e9459f was not completely propagated to listener org.opendaylight.bgpcep.bgp.topology.provider.LinkstateTopologyBuilder@1f6c7110
java.lang.NullPointerException: null
        at org.opendaylight.bgpcep.bgp.topology.provider.LinkstateTopologyBuilder.createNode(LinkstateTopologyBuilder.java:600) ~[na:na]
        at org.opendaylight.bgpcep.bgp.topology.provider.LinkstateTopologyBuilder.createObject(LinkstateTopologyBuilder.java:682) ~[na:na]
        at org.opendaylight.bgpcep.bgp.topology.provider.LinkstateTopologyBuilder.createObject(LinkstateTopologyBuilder.java:109) ~[na:na]
        at org.opendaylight.bgpcep.bgp.topology.provider.AbstractTopologyBuilder.onLocRIBChange(AbstractTopologyBuilder.java:135) ~[na:na]
        at org.opendaylight.bgpcep.bgp.topology.provider.AbstractTopologyBuilder.onDataChanged(AbstractTopologyBuilder.java:165) ~[na:na]
        at org.opendaylight.controller.md.sal.common.impl.service.TwoPhaseCommit.publishDataChangeEvent(TwoPhaseCommit.java:131) [bundlefile:na]
        at org.opendaylight.controller.md.sal.common.impl.service.TwoPhaseCommit.call(TwoPhaseCommit.java:97) [bundlefile:na]
        at org.opendaylight.controller.md.sal.common.impl.service.TwoPhaseCommit.call(TwoPhaseCommit.java:31) [bundlefile:na]
        at java.util.concurrent.FutureTask.run(FutureTask.java:262) [na:1.7.0_45]
        at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1145) [na:1.7.0_45]
        at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:615) [na:1.7.0_45]
        at java.lang.Thread.run(Thread.java:744) [na:1.7.0_45]

Change-Id: I305a96fb4f30699d1fdf64288a3a6720961b0126
Signed-off-by: Robert Varga <rovarga@cisco.com>
10 years agoDo not rely on route attributes being present 68/4868/1
Robert Varga [Mon, 27 Jan 2014 12:27:20 +0000 (13:27 +0100)]
Do not rely on route attributes being present

Fixes the following exception:
java.lang.NullPointerException: null
        at org.opendaylight.protocol.bgp.rib.impl.RIBImpl.updateTables(RIBImpl.java:126) ~[na:na]
        at org.opendaylight.protocol.bgp.rib.impl.BGPPeer.onMessage(BGPPeer.java:46) ~[na:na]
        at org.opendaylight.protocol.bgp.rib.impl.BGPPeer.onMessage(BGPPeer.java:32) ~[na:na]
        at org.opendaylight.protocol.bgp.rib.impl.BGPSessionImpl.handleMessage(BGPSessionImpl.java:199) ~[na:na]
        at org.opendaylight.protocol.bgp.rib.impl.BGPSessionImpl.handleMessage(BGPSessionImpl.java:50) ~[na:na]
        at org.opendaylight.protocol.framework.AbstractProtocolSession.channelRead0(AbstractProtocolSession.java:45) ~[na:na]
        at io.netty.channel.SimpleChannelInboundHandler.channelRead(SimpleChannelInboundHandler.java:98) ~[bundlefile:na]
        at io.netty.channel.DefaultChannelHandlerContext.invokeChannelRead(DefaultChannelHandlerContext.java:337) [bundlefile:na]
        at io.netty.channel.DefaultChannelHandlerContext.fireChannelRead(DefaultChannelHandlerContext.java:323) [bundlefile:na]
        at io.netty.handler.codec.ByteToMessageDecoder.channelRead(ByteToMessageDecoder.java:173) [bundlefile:na]
        at io.netty.channel.DefaultChannelHandlerContext.invokeChannelRead(DefaultChannelHandlerContext.java:337) [bundlefile:na]
        at io.netty.channel.DefaultChannelHandlerContext.fireChannelRead(DefaultChannelHandlerContext.java:323) [bundlefile:na]
        at io.netty.handler.codec.ByteToMessageDecoder.channelRead(ByteToMessageDecoder.java:173) [bundlefile:na]
        at io.netty.channel.DefaultChannelHandlerContext.invokeChannelRead(DefaultChannelHandlerContext.java:337) [bundlefile:na]
        at io.netty.channel.DefaultChannelHandlerContext.fireChannelRead(DefaultChannelHandlerContext.java:323) [bundlefile:na]
        at io.netty.channel.DefaultChannelPipeline.fireChannelRead(DefaultChannelPipeline.java:785) [bundlefile:na]
        at io.netty.channel.nio.AbstractNioByteChannel$NioByteUnsafe.read(AbstractNioByteChannel.java:100) [bundlefile:na]
        at io.netty.channel.nio.NioEventLoop.processSelectedKey(NioEventLoop.java:480) [bundlefile:na]
        at io.netty.channel.nio.NioEventLoop.processSelectedKeysOptimized(NioEventLoop.java:447) [bundlefile:na]
        at io.netty.channel.nio.NioEventLoop.run(NioEventLoop.java:341) [bundlefile:na]
        at io.netty.util.concurrent.SingleThreadEventExecutor$2.run(SingleThreadEventExecutor.java:101) [bundlefile:na]
        at java.lang.Thread.run(Thread.java:744) [na:1.7.0_45]

Change-Id: Ief4bb355f3f3e4566235b2339d0593ab7307ea58
Signed-off-by: Robert Varga <rovarga@cisco.com>
10 years agoMake listen-address support IPv6 54/4854/2
Robert Varga [Mon, 27 Jan 2014 09:54:45 +0000 (10:54 +0100)]
Make listen-address support IPv6

Change-Id: I082c9def23720f4beb1c808d9718faadc2036d40
Signed-off-by: Robert Varga <rovarga@cisco.com>
10 years agoFormat whitespace before making changes 63/4863/1
Robert Varga [Mon, 27 Jan 2014 11:37:15 +0000 (12:37 +0100)]
Format whitespace before making changes

Change-Id: I5919cee9b2a0240947da2d92f6797cfb70632eaa
Signed-off-by: Robert Varga <rovarga@cisco.com>
10 years agoAdd dependency on yang-ext 29/4829/1
Robert Varga [Sun, 26 Jan 2014 22:29:20 +0000 (23:29 +0100)]
Add dependency on yang-ext

Prepares for https://git.opendaylight.org/gerrit/#/c/4602/ being merged
into yangtools.

Change-Id: I350d146fcd629bd5199dbe6c6c8b487bda9ede31
Signed-off-by: Robert Varga <rovarga@cisco.com>
10 years agoChange types of CLUSTER_ID and ORIGINATOR 28/4828/1
Robert Varga [Sun, 26 Jan 2014 21:56:31 +0000 (22:56 +0100)]
Change types of CLUSTER_ID and ORIGINATOR

Change-Id: I78b613543a3715ad067b68bdae7d26a6ff665bce
Signed-off-by: Robert Varga <rovarga@cisco.com>
10 years agoAdd exception to help debugging 23/4823/1
Robert Varga [Sun, 26 Jan 2014 20:23:57 +0000 (21:23 +0100)]
Add exception to help debugging

Change-Id: Iadde072592ad6e705f313619adeae26fbc48a74f
Signed-off-by: Robert Varga <rovarga@cisco.com>
10 years agoMerge "Updated topology provider for stateful02." jenkins-bgpcep-bulk-release-prepare-only-5
Robert Varga [Sun, 26 Jan 2014 12:21:52 +0000 (12:21 +0000)]
Merge "Updated topology provider for stateful02."

10 years agoDefault pcep stateful version switched to 07. 70/4770/7
Dana Kutenicsova [Sat, 25 Jan 2014 18:54:25 +0000 (19:54 +0100)]
Default pcep stateful version switched to 07.

Change-Id: I6b74c731139bc21b54f067f41a5efb9fe2755ecd
Signed-off-by: Dana Kutenicsova <dkutenic@cisco.com>
10 years agoUpdated topology provider for stateful02. 32/4732/6
Dana Kutenicsova [Fri, 24 Jan 2014 18:17:18 +0000 (19:17 +0100)]
Updated topology provider for stateful02.

Change-Id: Ia77cf420a272cbcf64c925c899102a818cbc6485
Signed-off-by: Dana Kutenicsova <dkutenic@cisco.com>
10 years agoFixup package move 88/4788/2
Robert Varga [Sat, 25 Jan 2014 09:52:01 +0000 (10:52 +0100)]
Fixup package move

Change-Id: I6635b33fe2c282d144d94c96e4491a2e7436d611
Signed-off-by: Robert Varga <rovarga@cisco.com>
10 years agoMerge "Make tunnel-topology independent of stateful draft"
Dana Kutenicsova [Sat, 25 Jan 2014 12:26:27 +0000 (12:26 +0000)]
Merge "Make tunnel-topology independent of stateful draft"

10 years agoMerge changes
Gerrit Code Review [Sat, 25 Jan 2014 12:23:43 +0000 (12:23 +0000)]
Merge changes

10 years agoMerge changes Ieaa9ede2,I18c02205
Dana Kutenicsova [Sat, 25 Jan 2014 12:23:43 +0000 (12:23 +0000)]
Merge changes Ieaa9ede2,I18c02205

* changes:
  Make container fail when bundles are unresolved
  Fix test dependencies to reflect BGP refactor

10 years agoMerge "Remove unnecessary workaround"
Dana Kutenicsova [Sat, 25 Jan 2014 12:18:54 +0000 (12:18 +0000)]
Merge "Remove unnecessary workaround"