Fix repackaged-shiro sources

There is a simple typo in the shading process, rendering sources empty.
Fix that.

JIRA: AAA-188
Change-Id: If3a40c92d466aef7fb96b2a479fe8f039fe47e5c
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Support async servlets in Jetty

I83d579bbe33cfeb33f44150ecbe3619654bebe36 failed to update Jetty
implementation to propagate the async flag. Fix that omission.

Change-Id: I167de479e6e26cbe88ff6f1c5c92d892e394f4ed
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Integrate upstream MRI projects

Adopt latest versions, namely;
- odlparent-9.0.1
- yangtools-7.0.1
- infrautils-2.0.1
- mdsal-8.0.0-SNAPSHOT
- controller-4.0.0-SNAPSHOT

This forms the baseline for our next major release.

Change-Id: I74c0af013cbb8545e1bef515a9b7fb392f3f09a8
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Realign odlparent version

This mistake slipped review, not that it matters that much, but it
would be problematic going forward.

JIRA: AAA-188
Change-Id: I2c9da4ee0f580470d6cc3893b2ef190d4f1bdc28
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Bump shiro to 1.7.1

This patch bumps the shiro dependency, release notes are here:

https://shiro.apache.org/news.html#1.4.0-RC2-released
https://shiro.apache.org/news.html#1.4.1-released
https://shiro.apache.org/news.html#1.4.2-released
https://shiro.apache.org/news.html#1.5.0-released
https://shiro.apache.org/news.html#1.5.1-released
https://shiro.apache.org/news.html#1.5.2-released
https://shiro.apache.org/news.html#1.5.3-released
https://shiro.apache.org/news.html#1.6.0-released
https://shiro.apache.org/news.html#1.7.0-released
https://shiro.apache.org/news.html#1.7.1-released

We end up repackaging shiro to deal with class loading issues
coming it faces. Those will be cleaned up in version shiro-2,
which when we ill just revert back to using their packaging.

JIRA: AAA-188
Change-Id: Ic1d5c4243776c5cd72778c248ba5824a4acc4a91
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Bump versions to 0.14.0-SNAPSHOT

This starts the next major version iteration.

Change-Id: I338bbb190aa3ba53711c89739fba16dd904bfa12
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Migrate javax.inject artifact references

We are using GuicedEE instead of the ancient (and broken) javax.inject
jar. Migrate references.

Change-Id: I6d4e043eca50c3af1ff3742c6809c3b8118a2100
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Migrate osgi.core references

OSGi R7's core artifact has been renamed, use that as the dependency.

Change-Id: Ib27399feadf53ca91c816ba3e24f3dd001cf2249
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Bump versions to 0.13.4-SNAPSHOT

This starts the next development iteration.

Change-Id: I4d912a211794b8605d4f2a138db7400cf71953a4
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Bump infrautils to 1.9.8

Pick up the (unneded) fixes from upstream.

Change-Id: Ie67e8136325755b016adee85877f427d33fae2ec
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Bump MRI upstreams

Adopt following versions:
- odlparent-8.1.2
- infrautils-1.9.7
- yangtools-6.0.6
- mdsal-7.0.7
- controller-3.0.8

Change-Id: I2db011755ccea35c4fce4a78ad2c77f9885c2058
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Bump versions to 0.13.3-SNAPSHOT

This starts the next development iteration.

Change-Id: Iee11b07c32c1a64e66c191a49e6abbfcfb852ee8
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Bump MRI upstreams

Adopt following versions:
- odlparent-8.1.1
- infrautils-1.9.6
- yangtools-6.0.5
- mdsal-7.0.6
- controller-3.0.7

Change-Id: I530de6f43ce6fd6897ef5d6bf65dd6e296f50219
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Remove Ryan Goulding from committers

Ryan has been inactive in this project since 15.5.2018, i.e. more
than 32 months. Remove him from committers on grounds of inactivity.

Change-Id: I7fc68e5d21d24a2e5bb04545f1db57580a9c8b78
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Bump versions to 0.13.2-SNAPSHOT

This starts the next development iteration.

Change-Id: I7310e77f7225c307abb3743a7061bba3ae4bd594
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Bump controller to 3.0.6

Use released version of the snapshots we've been using.

Change-Id: I2e512123765412437a2a9a1210cea9ebe349f32e
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Bump controller to 3.0.6-SNAPSHOT

We have an incoming integration, switch to its snapshot so it can
test with autorelease on our snapshots.

JIRA: CONTROLLER-1962
Change-Id: I631dd40be87277ec9b9ddddc939fbbcfd4dc7e04
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Bump versions to 0.13.1-SNAPSHOT

This starts the next development iteration.

Change-Id: I3bd1938363aac60c3a0950b10d6a565485badafe
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Adjust odlparent version range

We are using odlparent-8.1.x, reflect that in the dependencies.

Change-Id: I9bf28bd4b5e354feec3c0b2233b1024d15450cb8
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Bump MRI upstreams

Adopt following versions:
- odlparent-8.1.0
- infrautils-1.9.5
- yangtools-6.0.4
- mdsal-7.0.5
- controller-3.0.5

Change-Id: Id1ece586d61dbf3957e67fb04868c24883172df1
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Bump MRI upstreams

Adopt following versions:
- odlparent-8.0.3
- infrautils-1.9.4
- yangtools-6.0.3
- mdsal-7.0.4
- controller-3.0.4

Change-Id: I95bbf6ad8899a6fc3e1b7e43d19bec8fa4e4e1ab
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Fix various warnings

Cleanup isFoo() callers and perform some drive-by cleanups.

Change-Id: I5c6f6330d9156e9d3804b5e9fe6e212b7f5f3d7d
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Bump MRI upstreams

Adopt following versions:
- odlparent-8.0.2
- infrautils-1.9.3
- yangtools-6.0.2
- mdsal-7.0.3
- controller-3.0.3

Change-Id: I96985729c2d54fe69d8494e7012772d8013d6e8e
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Merge changes Ia8d45fdf,I3b4dbc83,I0219f104

* changes:
  Add @Singleton/@Inject to IdmLightProxy
  Use StandardCharsets.UTF_8
  Convert ODLAuthenticator into a component

Add @Singleton/@Inject to IdmLightProxy

This is a component, make sure it is tagged as such.

JIRA: AAA-209
Change-Id: Ia8d45fdfa932e14935faf4b9b518ab34e0d981b0
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Use StandardCharsets.UTF_8

Let's not lookup the charset, just use a constant.

Change-Id: I3b4dbc83a5d574433822b292c47e9566ec7dca8e
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Convert ODLAuthenticator into a component

ODLAuthenticator does not have any dependencies, convert it to
a Singleton/Component.

JIRA: AAA-210
Change-Id: I0219f104926f43dcd73b77f9794e3d80fc5f9f8e
Signed-off-by: Tomas Cere <tomas.cere@pantheon.tech>
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Merge "Migrate IdmLightProxy to OSGI DS"

Migrate IdmLightProxy to OSGI DS

JIRA: AAA-209
Signed-off-by: Tomas Cere <tomas.cere@pantheon.tech>
Change-Id: Ife92b83c32a3e1e6743658d2f19e9f783905769e

Merge changes from topic "passwd-svc-bp"

* changes:
  Migrate H2Datastore to OSGi DS
  Convert aaa-password-service to OSGi DS

Migrate H2Datastore to OSGi DS

Migrate this component off to OSGi DS, so we get less reliance on
blueprint.

JIRA: AAA-207
Change-Id: Ibfcbd121de30ae682e80160f6b3fb9020f0adb79
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Convert aaa-password-service to OSGi DS

This patch serves as a blueprint of what a replacement for blueprint's
clustered-app-config needs to look like. Since we are replicating
the functionality of config DS -> component, this ends up being more
complicated than we'd want it.

Providing the infrastructure replacement for odl:clustered-config
is part of MDSAL-598. This patch provides one possibility how that would
be realized.

JIRA: AAA-203
JIRA: MDSAL-598
Change-Id: I760a6514ed185fc60639f7d7195159d19bf60a76
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Make JerseyServletSupport a @Component

Rather than going for the hard-core osgi-core, let's use declarative
services to activate. This reduces the amount of wiring code we have
and we end up advertizing support for ServletSupport.

While we are at it, let's also add javax.inject compatibility for
good measure.

JIRA: AAA-211
Change-Id: I0e6d4b7ff4de15e8bff054790409b00a258bed16
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Bump infrautils to 1.9.1

We were fine with 1.9.0, but we have a bugfixed version used by
downstreams. Pick it up.

Change-Id: I10f1eb57b07d70445b457043978b6609beae2427
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Clean out last vestiges of OSGi-meddling

Nothing in AAA has a dependency on dependency manager and metatype
is alreayd provided by framework. Remove all the remaining references,
greatly improving the quality of living for everyone.

Change-Id: I91ad79f65e50f71a9e4bdbf39f4bbddba81553b2
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Clean up aaa-encrypt-service/impl

We are not using OSGi directly and do not need explicit bundle
plugin configuration. Clean these up, making this a little less
tangled.

Change-Id: Iaa4940ac3c1aaf63edb494098a87d22ab8b01ad5
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Repair AuthenticationManager

AuthenticationManager was utterly wrecked in commit
193729d84ebb567d94e75311cd3bb871e7731b0b, which removed its
binding to CM, effectively meaning it was always disabled.

This is best evidenced by the unused bits in OSGI-INF/metatype,
the unpackaged authn.cfg file and the fact AuthenticationManager
is referencing them without having the BluePrint wiring to do so.

The primary problem is addressed by switching to OSGi DS, which
eliminates all run-time dependencies on OSGi, as it is purely
compile-time.

This flushes out the rest of the problems, as in order to drive
the OSGi CM integration we really need a configurationPID --
which investigation has shown to be long-lost
'org.opendaylight.aaa.authn'.

Furthermore OSGi CM integration really discourages use of properties,
preferring those be bound to a configuration object -- which points
to src/main/resources/OSGI-INF/metatype/ -- hence we ditch those XMLs
and replace them with Metatype Annotations.

Doing all this shifts property interpretation solely down to
ConfigAdmin -- hence we do not need to deal with at all, cleaning up
AuthenticationManagerTest.

Finally, to take advantage of all this work, we re-ingrate the new
component into blueprint as a simple service. We throw in proper
@Singleton annotation as a bonus.

JIRA: AAA-201
Change-Id: I51e23dc02836208774e8cdb8fb1a999537a691a6
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Clean up DefaultPasswordHashService

The lifecycle created by DefaultPasswordHashService is a bit
interesting. Remove use of optionals and create the service
atomically.

Change-Id: Id6aa692839df9f4fd798103cae8d6c2fc3ce4d79
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Bump to mdsal-7.0.1/controller-3.0.1

Pick up mdsal fixes and improvements.

Change-Id: I70a4be1510c869a235dadc7a8686963e00b27e4d
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Do not override managed version

We are getting project versions from artifacts, do not override
them.

Change-Id: Ib26ce6f26a4dbad2e607f873925ca1ca8e78291d
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Resync javadoc links

We are pointing to the wrong place for some of these, fix that.

Change-Id: I75a0bbeb28d524e7b341c4d03bdbd2eb31f1f374
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Bump upstreams for Silicon

Adopt the following upstream versions:
- odlparent-8.0.0
- yangtools-6.0.0
- mdsal-7.0.0
- controller-3.0.0
- infrautils-1.9.0

Change-Id: Ib11bf960c231a999220b0225ec4ff16e02b1a417
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Modernize MoreObjects.firstNonNull() use

Objects.requireNonNullElse() provides a built-in alternative, use
that.

Change-Id: I882927121450ef000232823daa1d25d8c7fc302a
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Fix use of bundle-name

The tests (and implementation) are not correctly using the mandatory
bundle-name parameter. Fix that.

Change-Id: Ie37850d9308841c75b9b76463bf116fea6bf8943
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Remove jacoco configuration override

JaCoCo overrides are not appropriate, as the setup works out-of-box
from odlparent -- with SonarCloud, where aaa currently reports 0%
coverage.  Remove the overrides to fix reporting.

Change-Id: Ice606efd83786fb7629ae540a2de74ec1f647a68
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Migrate aaa-cert use of BC APIs

Substitute deprecated methods with their replacements.

JIRA: AAA-182
Change-Id: Ie8c723d1c681dbea2c8c809c97a16639ac2e5e05
Signed-off-by: Illia <illia.ihushev@pantheon.tech>

Merge "Bump MRI projects"

Bump MRI projects

This patch adopts:
- odlparent-7.0.6
- infrautils-1.8.1
- yangtools-5.0.6
- mdsal-6.0.5
- controller-2.0.4

Change-Id: I59527b716683e92f3614569c5a61d83bcadb927b
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Add rfc8040 url for docs/user-guide.rst

Change-Id: I489719282c71a11e2ffdc394f79307303a62ef97
Signed-off-by: aman1403 <170030039@iitdh.ac.in>

Bump conf.yaml versions to Silicon

Signed-off-by: Thanh Ha <zxiiro@gmail.com>
Change-Id: I01c1768b5a2b33984cab2e84b2b3ee0694d8c4f3

Bump versions by x.(y+1).z for next dev cycle

Signed-off-by: Thanh Ha <zxiiro@gmail.com>
Change-Id: I3c1da8e509b24bdaf126b9c81db00c9e7794473d

Merge "Add javadoc pointer to infrautils"

Convert web-osgi-impl to use OSGi DS

Declarative Services are a much nicer fit than blueprint for
the use case at handle. SCR can deal with most of the inter-bundle
complexity by having a component with scope=BUNDLE -- lowering
the amount of actual code we need.

Also mark all of this for future evolution, as the OSGi R7 certainly
changes things a bit.

Change-Id: I74e1a7eb34e1b1e94ec751588df0c2c643ce8efc
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Merge "Do not fail on warnings for docs-linkcheck"

Add javadoc pointer to infrautils

Now that we have infrautils on javadoc.io, we can safely point to
them.

Change-Id: Id644693120ad78c803e7127d3de3560f3fb9bb27
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Use released version of infrautils

infrautils-1.8.0 has been released, use released version instead
of snapshots.

Change-Id: Ia3747f19a02edefca9684dce2d9010c481e45a1c
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Bump odlparent/yangtools/mdsal/controller

Adopt upstream versions:
- odlparent-7.0.5
- yangtools-5.0.5
- mdsal-6.0.4
- controller-2.0.3

Change-Id: I17f1341356862e34f7a276d961b26928eb9e8f98
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Convert aaa-filterchain to OSGi DS

Declarative services make things easier than hand-written blueprint.

Change-Id: Ib4d768c6bf6e2ebd15a6574e217d92e0c16c0f2b
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Do not fail on warnings for docs-linkcheck

This is a workaround due to sphinx-tabs being incompatible with the
Sphinx linkchecker which throws a warning. We mainly use linkchecker
to catch broken links so we don't really need to fail on warnings as
the main "docs" builder will still fail for warning level issues so
this is a reasonable workaround.

Signed-off-by: Thanh Ha <zxiiro@gmail.com>
Change-Id: I489719282c71a11e2ffdc394f79307303a62ef73

Merge "Add Admin user/pass as arguments"

Update Robert's timezone

A simple update to timezone.

Change-Id: Ife4bdf04345ae7ca7001c12abc06ede777c92664
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Add INFO.yaml for AAA.

Signed-off-by: Anil Belur <abelur@linuxfoundation.org>
Change-Id: I9cf795d6800f6f1115718b2f47eb30427fcfc593

Allow securiting asynchronous endpoints

We need the possibility to allow async requests by AAA because SSE
(Server Sent Events) use async communication.

Previous behavior is set as default. New behavior is possible set by
new parameter in FilterDetails and ServletDetails. These are also
covered by an explicit test suite.

ShiroWebContextSecurer is also updated to take advantage of this
new capability.

JIRA: AAA-199
Change-Id: I83d579bbe33cfeb33f44150ecbe3619654bebe36
Signed-off-by: Lukas Baca <lbaca@luminanetworks.com>
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Add Admin user/pass as arguments

- This Patch makes admin username and password as arguments
  with censor as true instead of challenging as input. This
  will print the string as wildcard in the command line as
  well as history file.

- eliminates the use of cache to avoid one session login to
  be used in another session.

- Deleted the aliases in the options with censor enabled due to the
  problem in karaf (https://issues.apache.org/jira/browse/KARAF-6769)

JIRA: AAA-189
Signed-off-by: gvrangan <vgovindarajan@luminanetworks.com>
Change-Id: Ief5b0177273baf39fc8afe248b8e5055f40cdc0e

Update dependency-check

We have a few artifacts added, make sure we update dependency-check.

Change-Id: Ic6b160122962821c2a4f696283ba990331b00699
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Remove unneeded jersey-2.25.1 hacks

odlparent now imports jersey-bom and includes a correct packaging
of jersey-2.25.1, hence we do not need to over-specify features
and dependencies -- making future upgrades easier.

Change-Id: Ifaae956751a93eb4564255167d3079893669756a
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Integrate controller-2.0.2

This bumps versions to the following:
- odlparent-7.0.3
- yangtools-5.0.3
- mdsal-6.0.2
- controller-2.0.2

Change-Id: Ia43b4958203bdcf39e2a9b24659d02f3f302898e
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Fix odl-jolokia reference

odl-jolokia has an explicit wrong version declared, fix that by
relying solely on declared versions.

Change-Id: I13c90fce89b7df5c8f738fec1152d3db705e4e8b
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Resync javadoc links

aaa-docs uses outdated pointers and does not include upstream
pointers. Make sure we fix that.

Change-Id: Icf8fafde9ee9f94b5fc8d3848166fb55944a7e15
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Integrate controller-2.0.1

This bumps versions to the following:
- odlparent-7.0.2
- yangtools-5.0.2
- mdsal-6.0.1
- controller-2.0.1

Change-Id: I0a5c8824fb947cc65b1d7e8488967019462a0fda
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Fix Issue identified in testing with sort

The sort does not work on unmodifiable list.
This patch creates a modifiable list for sorting.

JIRA: AAA-198
Change-Id: I85f420ceded316933bcb02ef71876063ad042f15
Signed-off-by: gvrangan <vgovindarajan@luminanetworks.com>
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

AAA-198  Provide Index for Policies

This provides a simpler way to add new policy without
modifying the entire list of policies. The index can be used to
influence the new policy to be processed in the required priority.

Signed-off-by: gvrangan <vgovindarajan@luminanetworks.com>
Change-Id: I6445a3e43cf52b78c8d4934cec14febb2d78573b

Propagate PasswordCredentialAuth to AAAShiroProvider

This makes it a bit cleaner and more obvious what sort of injection
needs to happen.

Change-Id: I385179ff1fdc2aaea431f28b0a5697b08358bc3e
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Add PasswordCredentialAuth

CredentialAuth is a generic interface which needs to be specialized
to capture capture which credentials are being passed. Downstreams
(in netconf) have a FIXME related to this, as they have no way to
express the type-safe dependency.

Introduce PasswordCredentialAuth to which downstreams can safely
bind. Also add a method to allow run-time discovery of required
credetial type.

Change-Id: I844db3b460bf95110fb3adbb687ce25e996e3608
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Update MRI projects for Aluminium

This bumps versions to the following:
- odlparent-7.0.1
- yangtools-5.0.1
- mdsal-6.0.0
- controller-2.0.0

Change-Id: Id5ffcc42659550a2bc0fb6a8ca8a334ffa3d34a0
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Clean up lamdas and methods in PaxWebServer

Change the code a bit to make it more clean with respect to
references.

Change-Id: Ib86dcb2b8ee209d346d96dadecd4106c4d01251c
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Remove intermediate ServiceFactory

Since PaxWebServer implements nothing we can easily make it a
ServiceFactory, reducing one indirection and making things a bit
more clear.

Change-Id: I41385adec33fb4b0ea17f3f74140090d8642540a
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Use type-safe registration

OSGi R5+ is using generics, which offer type safety during registration.
Also remove unneded use of an empty dictionary -- null works just as well.

Change-Id: I3b062add5f05611af614da32c09810604b9a86dc
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Merge "AAA-194 Fix for Pattern Matching in Shiro"

Remove jetty-servlet-tester references

These are ancient and we do not seem to need them anymore, remove
them.

Change-Id: I4e7c3315aa53526cc2ce630db9cbe9f657fd45be
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

AAA-194 Fix for Pattern Matching in Shiro

The Path Matching is based on AntPathMatcher
(https://docs.spring.io/spring-framework/docs/current/javadoc-api
/org/springframework/util/AntPathMatcher.html).
This Patch wil ensure the default urls also match in Shiro.

Signed-off-by: Venkatrangan Govindarajan <vgovindarajan@luminanetworks.com>
Change-Id: Iaa7a18d9138dad756eda24a31190421b07f25594

Fix checkstyle

Upgraded checkstyle does not like the mess in these declarations, clean them up.

Change-Id: Id6b42dc273f25ad716f048003d64a21022b08871
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Migrate Assert.assertThat()

Migrate to non-deprecated version of assertThat().

Change-Id: I13a0387c46e758c3ba66fc0d38513311379d68d3
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Migrate OSGi compendium references

We are using OSGi R6, make sure we are also referencing the correct
compendium artifact name.

Change-Id: Ie142c309aa6b128e6223bf62d46dd2ad9ea50d8d
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Merge "Use Magnesium controller"

Master branch is now Aluminium

Signed-off-by: Thanh Ha <zxiiro@gmail.com>
Change-Id: I8e83c90ec9f84cf3b582658fee0061d2be6d60c5

Use Magnesium controller

As part of controller transition to being MRI, downgrade the version
used to Magnesium release. This will be bumped to Aluminium proper
during the MRI window.

Change-Id: Ifb020b6b4d2b133c51874babfe0f49865b6d260b
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Migrate rtd docs to python3

RTD builds have been failing on python2 since the required version
sphinx is not found in lftools-conf. Moving to python3 resolves the
issue.

Signed-off-by: Anil Belur <abelur@linuxfoundation.org>
Change-Id: I68bc86ae4cf7f97b11c7dcfdaf024131f87487d8

Cleanup KeyStoreConstant

Java 11 provides utility methods which makes it much easier to
interact with files. Use them instead of verbose code doing the
same thing.

Change-Id: I1cf5bb3e307bc31f2301b4537fc718d0c9d29d00
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Fix NPE when loading certificate

This Patch fixes the NPE when using a certificate from a
non-default location.

JIRA: AAA-191
Change-Id: If12d49d45d2e914bdc901ee692c02790bf9b51b9
Signed-off-by: gvrangan <vgovindarajan@luminanetworks.com>
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Bump versions by x.y.(z+1)

Signed-off-by: jenkins-releng <jenkins-releng@opendaylight.org>
Change-Id: Idc89480fbf5feb3231abe48ac8ecb500ffcfa0bc

AAA-180: Fix Dynamic authorization

Repeated trials indicate the initfilter from shiro is never invoked for
this filter causing the problem. This patch instead uses the other metod(ProcessPAthConfig)
for initialization.

Signed-off-by: Venkatrangan Govindarajan <vgovindarajan@luminanetworks.com>
Change-Id: I30195bf745ac30f0cfd59021cb0b2fe524bede02
(cherry picked from commit 5b35f181c0315f5bcb99f95bd9a2ab4ea92122ef)

Fix variable name s/newUser/new_user/

this bug was introduced with a pep8 refactor done in
https://git.opendaylight.org/gerrit/c/aaa/+/86832

Signed-off-by: Jamo Luhrsen <jluhrsen@gmail.com>
Change-Id: I26a3c80df1e49d1514bcceb7d7a93eeae98b7e1c

Remove infrautils-testutils dependency

We do not need this dependency, remove it.

Change-Id: I14d328d25b6a8c05c6a0580495a0264d1e76b261
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Switch to JUnit assertThrows()

We have it available, there is no point to open-code it anymore.

Change-Id: I54274591545852bb7b698f436f7cf5581aa5494b
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Bump to odlparent-6.0.4/yangtools-4.0.6/mdsal-5.0.9

Pick up latest fixes and upgrades.

Change-Id: I41f80e0822a3232c8a7b1a3077322b9727b2215f
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Fix python pep8 warnings

a few warnings were not fixed like line length over 79 and
using bare except. Those can be done later if desired.

Change-Id: Ib21f7fc803daa34f696ad3a2ad277ae8f6657b04
Signed-off-by: Jamo Luhrsen <jluhrsen@gmail.com>

Catch missing arguments in python3

See inline code comments for more details

JIRA: AAA-193
Change-Id: Id4de48147aaef26a7bb03dd00cf24dbe0d77fb05
Signed-off-by: Jamo Luhrsen <jluhrsen@gmail.com>

Drop dependencies on commons-text

We are only using commons-lang3, which is a transitive dependency
of commons-text. Remove the unintended dependency.

Change-Id: I3d8a42703996de800926cb20b17c1b65672e9324
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Update immutables.org integration

Use only annotations, the rest is already configured from odlparent.

Change-Id: I6935b867f8e412128beb9f37b4872a20cc279c61
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>