Use artifacts to import dependencyManagement

For mdsal, yangtools and config we can use the artifacts pom to import
all artifacts in that group. This simplifies version management, so
let's use it.

Change-Id: Ic5a784314f79d774edfd05d48cb09836fba4b085
Signed-off-by: Robert Varga <rovarga@cisco.com>

Remove reference to enunciate

The plugin is not used anywhere in the project, so remove references to
it.

Change-Id: I586557635d4ed5d68bb017c2a7d86bf565cd0aca
Signed-off-by: Robert Varga <rovarga@cisco.com>

Remove version overrides

odlparent already defines versions for both karaf and maven bundle
plugin, so there is no need to override.

Change-Id: I01edb22c13bd28ff3c16f3822f151e96ec491a40
Signed-off-by: Robert Varga <rovarga@cisco.com>

Merge "Removed unused argument 'payload'"

Do not force Integer creation

Instead of using explicit instantiation, let JVM's autoboxing take care
of using the right object.

Change-Id: Ia271b8c25ca11230b9cca5c630e0704f5a621209
Signed-off-by: Robert Varga <rovarga@cisco.com>

Migrate away from yangtools features-test

The replacement comes from odlparent, so migrate to the new (and
working) one.

Change-Id: Ic0fee09f5d80a3864da3bc18531d072dff84fdcf
Signed-off-by: Robert Varga <rovarga@cisco.com>

Fix odlparent reference

odlparent is not in this project, so when it is referred to in a
<parent> declaration, it has to have an empty relativePath.

Change-Id: Ia4d341e722576c0cbb2a41e6180ab94bfac112c7
Signed-off-by: Robert Varga <rovarga@cisco.com>

BUG-2647: model+nsf.app migration proposal

 - requires:
    controller https://git.opendaylight.org/gerrit/#/c/14464/
    ofplugin   https://git.opendaylight.org/gerrit/#/c/14463/

Change-Id: Ie2372781bd398819f83902c14e38e44fb25a4794
Signed-off-by: Michal Rehak <mirehak@cisco.com>

Removed unused argument 'payload'

The argument 'payload' was used in an earlier version, as the
ReactiveFlowWriter handled ARP by its own and dispatched the
payload of the ARP requests.The ARP handling is now done by the
arphandler. The leftover argument 'payload' in the ReactiveFlowWriter
is usless and should be removed.

Change-Id: I53762d12d550d523de38e7dad5839c22b51dc591
Signed-off-by: Mario Willems <ma.willems@googlemail.com>

BUG2607: Now using the right constant for no buffer

Uses OFConstants.OFP_NO_BUFFER instead of 0L. Also, this patch organizes
the imports in the modified java files.

Change-Id: I71f8cceda7a0cc657f2f5ce03cc0af7bf757171c
Signed-off-by: Colin Dixon <colin@colindixon.com>

Merge "adding .DS_Store to .gitignore"

Merge "Eclipse improvement: Adds src/main/yang-gen-config as a source folder in projects using build-helper-maven-plugin to resolve errors in Eclipse."

Merge "Set root pom.xml <name> for Sonar"

adding .DS_Store to .gitignore

Change-Id: If4be131bfc27b49e8e9a6b650249ca6b13db37d1
Signed-off-by: Colin Dixon <colin@colindixon.com>

Bug 868: Replaced use of toInstance() for build().

Change-Id: I9a4ca67c449c035dfe93c1692c779660ec910a00
Signed-off-by: Tony Tkacik <ttkacik@cisco.com>

Set root pom.xml <name> for Sonar

As mentioned on the mailing list Sonar uses the <name> field of the
pom.xml that is passed to the mvn command as the name of the project in
Sonar. In most cases this is the root pom.xml file in a project. This
patch sets the name to the project shortname.

https://lists.opendaylight.org/pipermail/discuss/2014-November/004024.html

Change-Id: I48552988c06e856136a4bdfc068f40e7e2f352a5
Signed-off-by: Thanh Ha <thanh.ha@linuxfoundation.org>

Fixing broken unit tests.

Change-Id: I99e7e1ef47e80ae20c273360af103e59ab27c488
Signed-off-by: Alex Fan <railor33@gmail.com>

Eclipse improvement: Adds src/main/yang-gen-config as a source folder in
projects using build-helper-maven-plugin to resolve errors in Eclipse.

Change-Id: I4799ad991eb8c55c685aa11d1fe31b2e3abc045c
Signed-off-by: Charalampos Kaidos <ckaidos@intracom-telecom.com>

Incrementing versions by 0.1.0 for post-Helium master branch

Change-Id: Iac5cda1dda80d1e860ae3a55743b07fc8abfd3ac
Signed-off-by: Amit Mandke <ammandke@cisco.com>

Bug 2129 fixed
loop removal now considers parallel links/edges.

Change-Id: I35e28bd7115b6e698910a9d1b3209421dbb40e1c
Signed-off-by: Amit Mandke <ammandke@cisco.com>

Bug2121 -- Make TopologyId configurable in HostTracker.

Change-Id: Ib621267f361ecb33884f51436da6eadd3e3c6e63
Signed-off-by: Alex Fan <railor33@gmail.com>
Signed-off-by: André Martins <aanm90@gmail.com>

Bug2121 -- Add configuration parameter for TopologyId.

Change-Id: I3a5f486c7fa32f10451098fcfdf6fff0d87d104d
Signed-off-by: Alex Fan <railor33@gmail.com>

Bug 2104 Fixed, creating threadpool only once.

Change-Id: Ic978c1008f2fedd02e7e837a785e74705c6242e5
Signed-off-by: Amit Mandke <ammandke@cisco.com>

BUG-2097 hosts not seen in topology.

Fixed NPE when a topology with a null list of links was checked.

Change-Id: If3b6a8f0aeb623c4bd78d41e2d812a2d3720a6d5
Signed-off-by: André Martins <aanm90@gmail.com>

Bug 2040: Reschedule flow thread in case of error.

Change-Id: I83a42d67e37a2d792dbaa85743d91c103093aa0e
Signed-off-by: Alex Fan <railor33@gmail.com>

Bug 2040: Reduce delays.

Change-Id: I7b722f3a2c9bd9a458cdc0296d2eab04feda9d49
Signed-off-by: Alex Fan <railor33@gmail.com>

Adding callbacks for errors, bug 1707.

Change-Id: Ia7078faef392517f6028a9ddd3c1aea5d4e0a799
Signed-off-by: Alex Fan <railor33@gmail.com>

Merge "Bug 2040: Install flood flows after data has been fully written to datastore."

Bug 2040: Install flood flows after data has been fully written to datastore.

Change-Id: I075cd5e66b5a7bf35b9b6d76603b75f366462759
Signed-off-by: Alex Fan <railor33@gmail.com>

Merge "Bug 1948: Separate out restconf features"

Bug 1757, Integration with Sonar.

Change-Id: Iad8097e3b0a420ed49ebcd91b1673d9ab015ad50
Signed-off-by: Alex Fan <railor33@gmail.com>

BUG-2059: Hosttracker doesn't close readTransaction.

Change-Id: Ife998eee724b256182726eb622dd1730384380d8
Signed-off-by: André Martins <aanm90@gmail.com>

Bug 1948: Separate out restconf features

In order to avoid a maven project cycle in solving
Bug 1948, we need to separate restconf features.
Note, this is a first step, suffixing everything
with -new.  Subsquently, after everywhere using
odl-restconf has been fixed to use this new repo,
we will deprecate the ones in the mdsal features.xml
and rename these to not have the -new.

This patch just adds the dependency to features/pom.xml

Change-Id: I11c7170b60a5d993c2ee7f60ad81fba8d0b965bb
Signed-off-by: Ed Warnicke <eaw@cisco.com>

Merge "BUG-2043: Hosttracker gives a NPE."

BUG-2043: Hosttracker gives a NPE.

Change-Id: Iecb04ffb18fe77d2d13a0b1299f195649fabc367
Signed-off-by: André Martins <aanm90@gmail.com>

Merge "Bug 1757 Negative test cases for addresstracker"

Bug 1757 Negative test cases for addresstracker

Change-Id: I4c68af786a9ad43c21363ae1ae071580341cca34
Signed-off-by: Aarti Lolage <aalolage@cisco.com>

Bug 2032: Integrating HostTracker with config subsystem.

Change-Id: I30362f7428e6e9e9d46b0ec6a7d202e643a278ee
Signed-off-by: Alex Fan <railor33@gmail.com>

BUG fixes.

BUG-1627: Hosts are cleaned by hosttracker.
BUG-1754: Implemented a clusterAware mechanism for hosttracker.

Change-Id: I56a7b1fada563aaf9d423c2cfed7c8dff0c9dac3
Signed-off-by: André Martins <aanm90@gmail.com>

 Bug 1757 UT for Inventory Reader

Change-Id: I6a3dc4833d03e4b997c5bf3dff4604d52a606ab6
Signed-off-by: Aarti Lolage <aalolage@cisco.com>

Adding L2SwitchMain Unit Tests, bug 1757.

Change-Id: I033f19f39a624d5d889d8d218367b403ac716f40
Signed-off-by: Alex Fan <railor33@gmail.com>

Bug 1757 UT for Flow Writer module

Change-Id: Ic5b467e7a1602f78ca42cf12ec333e0f0513e403
Signed-off-by: Aarti Lolage <aalolage@cisco.com>

Adding InstanceIdentifier UnitTests, fixing bug in previous unit tests, bug 1757.

Change-Id: I155672aae57a423f075aa3faebdfb3b504a02d1d
Signed-off-by: Alex Fan <railor33@gmail.com>

Merge "Add -rest and -ui features to make it easier for folks to get the collection they want."

Add -rest and -ui features to make it easier for folks
to get the collection they want.

Change-Id: I4c3570be7bedfd92d8d4a67814e7349e2f4e99e9
Signed-off-by: Ed Warnicke <eaw@cisco.com>

Adding java docs, bug 1757.

Change-Id: Ief6a410a1fe61cfadc466d1f984e10669172bed2
Signed-off-by: Alex Fan <railor33@gmail.com>

L2Switch now works with a single switch, bug 1916.

Change-Id: I36a1c99252ed551fafbe0ca0f4cf650e89a7c2e2
Signed-off-by: Alex Fan <railor33@gmail.com>

Unit Tests for ArpHandler module.  Bug 1757

Change-Id: I2e7572013cc58d340c119571f5af375061251ff8
Signed-off-by: Alex Fan <railor33@gmail.com>

Fix for bug 1814 - where the AddressTracker records the same address twice.

Change-Id: I79b824e81605097060ba37f51370480f1ef81fae
Signed-off-by: Alex Fan <railor33@gmail.com>

Bug 1873 - Replace Hardcoded URLs and add Missing Parent sections to poms to get distributionManagement section

Change-Id: I01c1e7447df398204b92b23bbc71405e16cb4ede
Signed-off-by: Devin Avery <devin.avery@brocade.com>

Bug 1757 UT for addresstracker

Change-Id: Iadbdc515feb18aef35720db1ca5e9dc1928a7fcc
Signed-off-by: Aarti Lolage <aalolage@cisco.com>

Unit Tests for LoopRemover module.  Bug 1757

Change-Id: I2b388894684d6e0fddafd689ffe447641f8bab65
Signed-off-by: Alex Fan <railor33@gmail.com>

Fix for bug 1834.

Change-Id: Idf4b8698d23adc9368d98469f7cbcdb3d46637e1
Signed-off-by: Alex Fan <railor33@gmail.com>

Bug 1707: Changed data updates to use merge
Now these data store updates use merge api. Also changed the
instance identifier to use augmentation so that data base can
mange it efficiently.

Change-Id: I2d05f0bd04f1b6f39a7a24dee52568ac4f26c88b
Signed-off-by: Amit Mandke <ammandke@cisco.com>

Add another configuration item to L2SwitchMain.  Refactor pom.xml to use appropriate output directories.

Change-Id: I26d2d0e692856503303237891c640881eb82a82a
Signed-off-by: Alex Fan <railor33@gmail.com>

Merge "Adding config param to choose packet types for address tracking"

Adding config param to choose packet types for address tracking

Change-Id: I6f5f4bccf31d28310a4bc1e680496b015b079a08
Signed-off-by: Amit Mandke <ammandke@cisco.com>

Integrate L2SwitchMain with config subsystem.

Change-Id: I572de5580194ac6f693a66fdd9e90ed8da55b837
Signed-off-by: Alex Fan <railor33@gmail.com>

Integrate address tracker with config subsystem.

Change-Id: Icf3e011fe21067c69d54c8a8a15e08e222ed8dbc
Signed-off-by: Alex Fan <railor33@gmail.com>

Integrate LoopRemover module with config subsystem.

Change-Id: Icfbd3fdd2e9e87d47983264e07b77301e1966ef3
Signed-off-by: Alex Fan <railor33@gmail.com>

URGENT Fix for missing dependency in features.

Change-Id: I9c541301f9db80bbb04c6cb7ed83700d21a26a5b
Signed-off-by: Amit Mandke <ammandke@cisco.com>

Integrate packethandler & arphandler with config subsystem.

Change-Id: Ia43c2b349c47e07d97a36dd45373b1a2d8c0823a
Signed-off-by: Alex Fan <railor33@gmail.com>

URGENT Fix feature for arphandler dependency.

Integration is broken until this is fixed.

Change-Id: I47cf046b340cc297a166129844ca69c810e29883
Signed-off-by: Ed Warnicke <eaw@cisco.com>

Refactoring code seperating arp handler from main
Currently address tracker needs l2switch main to work to its full potential.
So this refactoring would seprate out a module that can go as only dependency
of address tracker. This would leave only reactive flow writing in main module.

Change-Id: Ic36ba57dd69e429453f0593cbd9a935842fa8ae6
Signed-off-by: Amit Mandke <ammandke@cisco.com>

Adding Karaf features for L2switch

Also added a local karaf distributions.

cd distribution/karaf/target/assembly/bin
./karaf

And it will come up running l2switch and restconf.

Point mininet at it, pingall, and look at the host tracking
in topology:

GET http://localhost:8181/restconf/operational/network-topology:network-topology/

Had to force maven bundle plugin to 2.4.0 as 2.5.0 is incompatible
with karaf

Change-Id: I0ff09b6d330d3fc7e741cfdc8d652637fdea8ff3
Signed-off-by: Amit Mandke <ammandke@cisco.com>
Signed-off-by: Ed Warnicke <eaw@cisco.com>

Added util classes for packet decoding instead of depending on controller

Change-Id: I61f6e4cfb561ac3816b2c209c7c0cccceb70c572
Signed-off-by: Amit Mandke <ammandke@cisco.com>

Adding interval in address obsrvation writes.
Currently address observation writer updates same observation too
frequently. This change would update it only after some interval.

Change-Id: Ib329de930829438f2d10a29f0377ca299636710f
Signed-off-by: Amit Mandke <ammandke@cisco.com>

Creating separate proactive flows for internal and external ports.
1. this helps writting less address observation to store.
2. due to point 1. no conclicting commits are observed for test upto
64 switches 10 hosts each.
3. this affects mac to mac flow writer as flows are not written on
each switch. Improved solution is required for this.

Change-Id: I70024f2a300b74f65b8e16e231114a9bd1b17ba7
Signed-off-by: Amit Mandke <ammandke@cisco.com>

Adding back single flood flow.
Openflow specification confirms that oputput action would not
send a packet out of ingress port unless reserved port is used.
So it is safe to use single flood flow that only discards 'discarding'
ports.

Change-Id: Ic82013ad0ea3915b217884582c0fd9552bd21c7c
Signed-off-by: Amit Mandke <ammandke@cisco.com>

Added logic to ignore host link events.
Network graph or mst doesnt need referesh if host links are
added or removed.

Change-Id: I3cbdfa836943c45bab9b2d84b49ed8451cc90a3b
Signed-off-by: Amit Mandke <ammandke@cisco.com>

Implemented a small AddressObserver for HostTracker.

Host tracker with new methods and implementations.
Fix a bug and hosttracker checks datacreated.
Created documentations for Host.

Change-Id: I9c83287c3ed7541ac6b7af05f2a04275ab19ac00
Signed-off-by: André Martins <aanm@ua.pt>

Applied Karaf features to l2switch.

Change-Id: I55831747a4ed6b9650ab107c5e36183272406f44
Signed-off-by: André Martins <aanm@ua.pt>
Signed-off-by: Mathieu Lemay <mlemay@inocybe.com>
Signed-off-by: André Martins <aanm@ua.pt>

Making further changes to proactive flood, with additional performance improvements.
1. initial flood flows are changed to handle pingall failure.
2. removed some redundant calls to inventory reader and made some further code optimization.
3. code restructuring moved logical classes in respective packages.(arphandler & flow)
4. made pending change to address observer to generate unique key for each address observation.

Change-Id: I501f2a0082e9623c91336a445f135dc41abd1408
Signed-off-by: Amit Mandke <ammandke@cisco.com>

Adding proactive mode for L2Switch, which installs flood flows.

Change-Id: I779a49fe9e7fd4ba69dfe934fd4a742b0f77b2bc
Signed-off-by: Alex Fan <railor33@gmail.com>

Splitting Flow writing and packet dispatch(reactive flood).
This would allow either to be enabled or disabled easily based on need.

Change-Id: I271a1f58ff8df916413aa1e20154c60fa2860784
Signed-off-by: Amit Mandke <ammandke@cisco.com>

Making changes to loop remover so that it doesnt rely on in memory graph.
This would help the loopremover to behave same across cluster(in a clustered env)
and it will not reply on any in memory local state.

Change-Id: I639ce0cd87a3e61c67a69a611ded4bea050682cb
Signed-off-by: Amit Mandke <ammandke@cisco.com>

Merge "Fixed ClassCastException during decode. There was possibility of single decoder instance being registered twice as notification listner. This synchronized method would eliminate that. This was resulting in ClassCastException/ unpredictable behaviour."

Fixed ClassCastException during decode.
There was possibility of single decoder instance being registered
twice as notification listner. This synchronized method would eliminate that.
This was resulting in ClassCastException/ unpredictable behaviour.

Change-Id: I52e57b8e1568520c6742c20ea60e5b28610df68f
Signed-off-by: Amit Mandke <ammandke@cisco.com>

Removing duplicated information from poms in host tracker

This includes things already specified in parent poms like:
* dependency versions
* groupIDs
* artifact versions

Change-Id: I5c0e7fe7ea2dbd02774550c81180e653a0805b38
Signed-off-by: Colin Dixon <colin@colindixon.com>

Enabling checkstyle by default

This patch includes the default checkstyle from the controller project and
updates all currently checked in files to comply with the checkstyle rules.

Change-Id: I78f7949adf6ec0a7144c88756ccee546192879d2
Signed-off-by: Colin Dixon <colin@colindixon.com>

Fixing pom files so Eclipse works

Moved the Eclipse-related plugins and pluginMangement to the l2switch-parent
so that all relevant projects will automatically import into Eclipse correctly.

Change-Id: I27dcd4adf726634ae78501a425bf33b39130a708
Signed-off-by: Colin Dixon <colin@colindixon.com>

Adding Initial Flows on switch for performance improvement.
These sends minimum packets(ARP and LLDP) to controller for
learning addresses and programming flows as l2switch requires.

Change-Id: Id7f0ba5ca7dea6e83b02c4a8a997bcc2bade05e0
Signed-off-by: Amit Mandke <ammandke@cisco.com>

Moving address observer implementation  to address tracker.
This would help to seperate address tracking implementation
moduler and independent of other l2switch fuctionality.

Change-Id: I97a434fb105293e063a85f9dda62a0bb479aeb92
Signed-off-by: Amit Mandke <ammandke@cisco.com>

Following minor fixes done.
1. info logs changed to debug as unnecessary log was being printed at info level.
2. transaction commit changed to submit as commit is deprecated.

Change-Id: I27b1277d8f1debce328c2c6a195c5059ddfa5393
Signed-off-by: Amit Mandke <ammandke@cisco.com>

Merge "Host Tracker generated source code imports into Eclipse"

Minor fixes observeed during testing.

Change-Id: I2019e5e1e496b2caac0a435a0ae9ee4cac7b49b3
Signed-off-by: Amit Mandke <ammandke@cisco.com>

Fixing l2switch base distribution so it runs without errors

This involved commenting out the exclude for
opendaylight/plugins/org.opendaylight.controller.sal-remote*.jar

Change-Id: Ied02eb9f4cf1aa6baad70872a9f7753a1ea0640f
Signed-off-by: Colin Dixon <colin@colindixon.com>

Host Tracker generated source code imports into Eclipse

Change-Id: I97ddf55fdd69da033c7df58fed2990aab6c2b6fb
Signed-off-by: Colin Dixon <colin@colindixon.com>

Merge "Refined host model & pushing to topology"

Changing key for addresses (Bug 1470)

The addresses structure used to use the first-seen timestamp as a key.
That is not guranteed to be unique. This changes that to use an opaque
64-bit identifier. Currently, it's populated with the MAC addres
interpreted as a BigInteger, but that should not be counted on in the
future and should be checked for uniqueness.

Change-Id: I579c2c5587c62ef685317bd54049aead67406d35
Signed-off-by: Colin Dixon <colin@colindixon.com>

Refined host model & pushing to topology

Change-Id: I53acd272482e42ab43d31ebf388bd59a8f01cd4b
Signed-off-by: Evan Zeller <evanrzeller@gmail.com>

Fixed nullpointer exception and added new functionalities on hosttracker

Change-Id: I988121a16bdd95ea50e3405b55730f8bc8980f75
Signed-off-by: André Martins <aanm@ua.pt>

Avoiding Null pointer in hosttracker.
Better implementation needs to be added. Just avoiding nullpointer for now.

Change-Id: If3aabd11bb49b6fc49fc578f200c7a9c989d3aa3
Signed-off-by: Amit Mandke <ammandke@cisco.com>

Added new changes to hosttracker

Change-Id: Ib51f46111f69a887d752c96a9b4f69893a49a762
Signed-off-by: André Martins <aanm@ua.pt>

Merge "Bring hosttracker code into l2switch"

Merge "BUG-432: Fix in response to Gerrit 9362"

BUG-432: Fix in response to Gerrit 9362

https://git.opendaylight.org/gerrit/#/c/9362/
broke stuff... this fixes it.

Change-Id: Ia152a160511429a3f5cc467e48f8e880b134a28a
Signed-off-by: Ed Warnicke <eaw@cisco.com>

Changing Registrations to not use generics

This is a reaction to this patch in yangtools:
https://git.opendaylight.org/gerrit/#/c/9362/

Change-Id: I69e8d93c8d058cbe13c7aa68ad66640f3367c514
Signed-off-by: Colin Dixon <colin@colindixon.com>

Bring hosttracker code into l2switch

Change-Id: I718dca4d8a0e2ed3516499b770c0b612bb6f8718
Signed-off-by: Evan Zeller <evanrzeller@gmail.com>

Move stp status to operational datastore.

Change-Id: Ic0e4dc593e157a62a8b2a24eaf812f0166d3275c
Signed-off-by: Alex Fan <railor33@gmail.com>