gobinath [Thu, 4 May 2017 09:59:24 +0000 (15:29 +0530)]
Bug 8370 - Fib flows are not deleted after extra route deletion
Issue:
When the extra routes associated with a router are updated, the FIB flows
corresponding to the old extra routes are not deleted.
Analysis:
While there exists handling to update the loadblancing group corresponding
to the extra route, the handling to remove the FIB flows for the extra
route when the extra route is completely removed is missing.
Fix:
Changes have been added to the deletelocalfibentry to remove the FIB flows
of the removed extra route.
Change-Id: I77b5b9d46173b1c2613c28a495bc6a85bff52d9a
Signed-off-by: gobinath <gobinath@ericsson.com>
Aswin Suryanarayanan [Tue, 2 May 2017 14:49:33 +0000 (20:19 +0530)]
Bug 8340 - Rules with IP prefix not getting programmed when there
are multiple SG associated with a port
1)Remote filter table programming during port update is fixed.
2)Ingress and Egress filter table no is fixed in the respective
classes.
3)AclInterface Map logic is updated to prevent duplicate entries.
4)Test added to cover interface with intially one acl and later two.
Change-Id: If5af5ced20ed81ec27201bd4ec0def91715ebda9
Signed-off-by: Aswin Suryanarayanan <asuryana@redhat.com>
Miguel Perez [Mon, 3 Apr 2017 16:30:48 +0000 (18:30 +0200)]
Refactor InterVpnLink. Part THREE
+ This one implements the final purpose of this refactoring:
taking the route leaking out of the fibmanager to a higher level,
in this case it's the BgpManager who now takes care of the route
leaking in case of BGP routes and the VpnManager for static and
connected routes.
Change-Id: Ie73a7061a26cfa3b95fad633533d44fff87ad6fb
Signed-off-by: Miguel Perez <francisco.miguel.perez@ericsson.com>
Signed-off-by: Sam Hague <shague@redhat.com>
Philippe Guibert [Fri, 28 Apr 2017 08:25:01 +0000 (09:25 +0100)]
BUG-8331: BGP Manager labels values are passedin correct order to QBGP
L3 Label Parameter is swapped with L2 Label when calling QBGP
Change-Id: Ib5d3260a696078e6b3d1de9cd0b84eaf0ebfef7d
Signed-off-by: Philippe Guibert <philippe.guibert@6wind.com>
Brady Johnson [Thu, 4 May 2017 14:30:26 +0000 (16:30 +0200)]
BUG 8375 - Malformed NSH packets get dropped
- The NSH NextProtocol (NP) field must be set to 3 for ethernet
- Since the field isnt set, its set to 0 by default, which causes
the packets to get dropped by the SFF OVS.
Change-Id: I4d13b86ff563b76a992c5c88791015053f5688e8
Signed-off-by: Brady Johnson <brady.allen.johnson@ericsson.com>
epgoraj [Wed, 3 May 2017 09:29:11 +0000 (14:59 +0530)]
BUG:8345 & Bug:8347
* The code-review contains below Fixes
BUG:8347 -> NPE at org.opendaylight.netvirt.elan.internal.ElanSmacFlowEventListener.onFlowRemoved
BUG:8345 -> OptimisticLockFailedException for elanDpnInterface
Operational Datastore while deleting elan-instance and elan-interfaces
Change-Id: Id930e511f1f0814e17ca1f8cbbda43e9fd3d7e6f
Signed-off-by: epgoraj <p.govinda.rajulu@ericsson.com>
harikrishna [Wed, 3 May 2017 10:15:47 +0000 (15:45 +0530)]
Revert "Thrift changes to support IPv6 calls over Quagga BGP stack"
This reverts commit
cae4adebcf7f6f79736859cd2dbb04599b435091.
Change-Id: I09f01ec493bf4dc1023f5fe22f7d8aa9768d0e53
Signed-off-by: harikrishna <hari.i.krishna@ericsson.com>
harikrishna [Wed, 3 May 2017 10:09:49 +0000 (15:39 +0530)]
Revert "Thrift interface changes to support BGP VPNv6"
This reverts commit
21f5d03ca7cc0e0dfd53c3868196b6e93ec9ae19.
Change-Id: I1df917f4385ace0691b6fbf3cec408fd496e8180
Signed-off-by: harikrishna <hari.i.krishna@ericsson.com>
harikrishna [Wed, 3 May 2017 10:00:03 +0000 (15:30 +0530)]
Revert "bgpmanager VPNv6 shell command update"
This reverts commit
be855643f1ceadc9077882b81eb35533e5717148.
Change-Id: I9516ee1258f2fd3395a677a7b70ba0e5ad83e884
Signed-off-by: harikrishna <hari.i.krishna@ericsson.com>
harikrishna [Wed, 3 May 2017 08:46:53 +0000 (14:16 +0530)]
Revert "bgpmanager: IPv6 information is collected vty shell"
This reverts commit
b918dc13b79a565fb6d16194690c7d6c7eacb1e7.
Change-Id: I4a8ffda31d769ada55481ad708cd619c7c3a3a3b
Signed-off-by: harikrishna <hari.i.krishna@ericsson.com>
cgowdru [Tue, 2 May 2017 05:29:26 +0000 (10:59 +0530)]
Rollback - ADDED INFO logs for tempest issue DEBUG
Change-Id: Ic695dd7bd011313e3f615c1c2f70bd7b7d212771
Signed-off-by: cgowdru <chetan.arakere@altencalsoftlabs.com>
Vivekanandan Narasimhan [Tue, 2 May 2017 10:40:04 +0000 (16:10 +0530)]
Bug 7939: Interface management on cluster reboot
Interface state changes are missed on a cluster
reboot resulting in some flows and DS not being
properly re-written.
Change-Id: Ie91cc1226f4d6494e4ce0e82f4dd0d6e00840396
Signed-off-by: Vivekanandan Narasimhan <n.vivekanandan@ericsson.com>
eupakir [Tue, 2 May 2017 09:51:59 +0000 (15:21 +0530)]
Bug 8349 - Creation of BGPVPN with the same RD is not restricted
ODL does not support handling of multiple bgpvpns with the same RD. Hence,
a bgpvpn create request with an already used RD should be denied.
Change-Id: I60d4cc00e73ca8089a15f5b6f4298d74ab7c7b0c
Signed-off-by: eupakir <kiran.n.upadhyaya@ericsson.com>
Periyasamy Palanisamy [Mon, 27 Feb 2017 11:37:55 +0000 (17:07 +0530)]
spec for Neutron Port Allocation For DHCP Service
Use 43 as table id for ARP_CHECK_TABLE.
Change-Id: I32bc417f883dc621c35461b9f98be797caa0722c
Signed-off-by: Periyasamy Palanisamy <periyasamy.palanisamy@ericsson.com>
Signed-off-by: Achuth Maniyedath <achuth.m@altencalsoftlabs.com>
Philippe Guibert [Tue, 11 Apr 2017 16:13:11 +0000 (17:13 +0100)]
bgpmanager: IPv6 information is collected using vty shell
This extension permits retrieving the number of prefixes VPNv6 stored on
quagga, like it has been done for VPNv4.
Change-Id: I413c5b2ed1dc6d004f09a582f8510bccf1f1986a
Signed-off-by: Noel De Prandieres <prandieres@6wind.com>
Signed-off-by: Philippe Guibert <philippe.guibert@6wind.com>
Signed-off-by: Hari Krishna <hari.i.krishna@ericsson.com>
Jamo Luhrsen [Fri, 28 Apr 2017 18:53:19 +0000 (11:53 -0700)]
BUG 8340: Handle case when aceList is also empty
Change-Id: If76c63ec6c5dd00811f593ac8d6058341b8e1cf1
Signed-off-by: Jamo Luhrsen <jluhrsen@redhat.com>
Arun Sharma [Thu, 27 Apr 2017 18:47:08 +0000 (00:17 +0530)]
Netvirt: Qos Alert patch7 - last
*** patch #7 - Added EntityOwnershipListener ***
Only qosalert entity owner or master only should poll for port stats.
Once a master is elected, it shall continue polling until a new master is elected.
Spec Review Link:
https://git.opendaylight.org/gerrit/50689
Change-Id: I67ad2b3a016204b8e19e2971a0329b52aa8bd4fb
Signed-off-by: Arun Sharma <arun.e.sharma@ericsson.com>
Brady Johnson [Mon, 10 Apr 2017 10:12:58 +0000 (12:12 +0200)]
UT - Adding Netvirt classifier GeniusProvider tests
- added GeniusProviderTest.java
- added TestInterfaceManager.java to stub the Genius InterfaceMgr
- added TestOdlInterfaceRpcService.java to stub the Genius RPC calls
- added GeniusProviderTestParams.java with common test params for above 3 files
- changes to GeniusProvider for errors that the UT flushed out
Change-Id: I60e85811959319bf6e163641506aa2f26d9975d5
Signed-off-by: Brady Johnson <brady.allen.johnson@ericsson.com>
Arun Sharma [Wed, 26 Apr 2017 19:09:07 +0000 (00:39 +0530)]
Netvirt: Qos Alert patch6
*** patch #6 - Added log4j configuraton support ***
1. Added a new log4j appender with default logging properties in qosalert.cfg
2. Added listener method update in QosAlertGenerator class to handle any chage in qosalert.cfg
Spec Review Link:
https://git.opendaylight.org/gerrit/50689
Change-Id: I2008a0a2dd22661e0f45251f0aac1088270d3d96
Signed-off-by: Arun Sharma <arun.e.sharma@ericsson.com>
Yugandhar Reddy Kaku [Mon, 24 Apr 2017 11:30:26 +0000 (17:00 +0530)]
EVPN RT2 advertise and withdraw prefix changes
1) Added elan external tep listener.
When elan external tep is added update the elan remote broadcast
group for all elan dpns.
2) when an elan interface is added , advertise its prefix
when elan interface is deleted, delete its prefix.
3) Advertise prefix when we receive packet in message from silent
host.
4) Withdraw prefix when the smac flow entry of silent host expires
Change-Id: I870174f9fa0741a6508f2edec20dae7489b67d26
Signed-off-by: Yugandhar Reddy Kaku <yugandhar.reddy.kaku@ericsson.com>
Josh [Sun, 23 Apr 2017 08:37:09 +0000 (11:37 +0300)]
Set feature capability for port status update
See: https://bugs.opendaylight.org/show_bug.cgi?id=7718
DEPENDS ON: https://git.opendaylight.org/gerrit/#/c/55854/
Change-Id: Ia83d31c348176947e31e11d383f770ac97390145
Signed-off-by: Josh <jhershbe@redhat.com>
Philippe Guibert [Tue, 11 Apr 2017 16:10:50 +0000 (17:10 +0100)]
bgpmanager VPNv6 shell command update
bgp-network command is modified so as to support the ability to
configure prefixes with afi parameter, to be 1 ( IPv4) or 2 ( IPv6).
Change-Id: Ie0a5faf7160a049e930d2eb8f89af9d87693ddcd
Signed-off-by: Noel De Prandieres <prandieres@6wind.com>
Signed-off-by: Philippe Guibert <philippe.guibert@6wind.com>
Signed-off-by: Hari Krishna <hari.i.krishna@ericsson.com>
Brady Johnson [Tue, 25 Apr 2017 12:47:06 +0000 (14:47 +0200)]
BUG 8296 - Erroneous Egress Classifier flows
- Egress classifier filter flow now just matches on NSH
MD Type as set in the Ingress classifier ACL flow
- OpenflowRenderer.renderPath() is now passed the nodeIP
instead of the destination SFF IP
- Patch Set 2 : fixed minor merge issue
- Patch Set 3 : fixes found by ClassifierEntryTest UT
Change-Id: Ide70b7222b08b2b363acc36126dc08e8a9add556
Signed-off-by: Brady Johnson <brady.allen.johnson@ericsson.com>
Jaime Caamaño Ruiz [Tue, 11 Apr 2017 14:40:15 +0000 (16:40 +0200)]
Factor out executor from ClassifierService & UT
Depends on [1]
[1] https://git.opendaylight.org/gerrit/#/c/55251/
Change-Id: I4cf5bffcd33e2f4190a699a9982f75ca2d3ad8fd
Signed-off-by: Jaime Caamaño Ruiz <jaime.caamano.ruiz@ericsson.com>
Philippe Guibert [Tue, 11 Apr 2017 16:07:38 +0000 (17:07 +0100)]
Thrift interface changes to support BGP VPNv6
Thrift interface changes to include information on afi type.
Change-Id: Ie82e9a086621a551f19a0faaf9107d630277ae43
Signed-off-by: Noel De Prandieres <prandieres@6wind.com>
Signed-off-by: Philippe Guibert <philippe.guibert@6wind.com>
Signed-off-by: Hari Krishna <hari.i.krishna@ericsson.com>
Signed-off-by: Vivekanandan Narasimhan <n.vivekanandan@ericsson.com>
Philippe Guibert [Tue, 11 Apr 2017 14:43:04 +0000 (15:43 +0100)]
Thrift changes to support IPv6 calls over Quagga BGP stack
Quagga BGP stack enhancement to support IPv6 leads to Thrift interface
modifications, which specifically include the following Type changes:
a) new AFI parameter - IPv6
b) pushRoute() includes new AFI parameter
c) withdrawRoute() includes new AFI parameter
d) getRoutes() includes new AFI parameter
e) onUpdatePushRoute() includes new AFI parameter
f) onUpdateWithdrawRoute() includes new AFI parameter
Change-Id: Ibd4842624d55fd07ae88b0d2ca8094a641f8749d
Signed-off-by: Noel De Prandieres <prandieres@6wind.com>
Signed-off-by: Philippe Guibert <philippe.guibert@6wind.com>
Signed-off-by: Hari Krishna <hari.i.krishna@ericsson.com>
Periyasamy Palanisamy [Tue, 25 Apr 2017 05:55:42 +0000 (11:25 +0530)]
Bug 7866 adding retries for remote dmac programming during tunnel up event
* currently there is no retries in case of OptimisticLockFailedException
while programming remote dmac during tunnel up event. This leads to remote
dmac is programmed with drop action which leads to packet drop. Now added
retries for jc job.
* Also adding retries in case remote BC group fails (during tunnel up event) due to datastore exceptions.
Change-Id: I2bc024fc7133170c321c4a5071d6b58e00a2666b
Signed-off-by: Periyasamy Palanisamy <periyasamy.palanisamy@ericsson.com>
Riyazahmed D Talikoti [Thu, 16 Mar 2017 18:43:35 +0000 (00:13 +0530)]
EVPN RT2 NeutonVpn changes
1. EVPN RT2 RPC for create, delete, and get EVPN
creation and deletion of EVPN via REST is handled by NeutronEvpnManager.
When create EVPN RPC is received, NeutronEvpnManager will check if
vpninstance already exist with same name if not then it will create
vpninstance of type L2 for EVPN. similarly vpninstance will be deleted for
delete event.
2. Changes for attach/detach network to EVPN
NeutronEvpnManager will add/remove/update evpn name in Elan augmentation so that
EvpnElanInstanceManager will advertised and withdraw routes accordingly.
3. Few previous comments mandatory false from yang removal fix
4. Added ElanHelper file to move commonly used utility methods to avoid
cyclic dependency
Change-Id: I259734fad1ca0e19f38093b4e22a326fb6969459
Signed-off-by: Riyazahmed D Talikoti <riyazahmed.d.talikoti@ericsson.com>
Aswin Suryanarayanan [Wed, 19 Apr 2017 08:58:09 +0000 (14:28 +0530)]
Bug 8244 In Conntrack SNAT implementation G/w is not reachable when no
port in the router subnet is present in the node
1)Added a the pseudo port to vpn-dpn list.
2)Moved the router cache util to a separate class.
Change-Id: I6f5834ab3af1c3478274191bd7eafebc162dc25e
Signed-off-by: Aswin Suryanarayanan <asuryana@redhat.com>
Naveen Kumar Verma [Mon, 10 Apr 2017 13:30:22 +0000 (19:00 +0530)]
stale entry in flow rules, after deleting port associated to qos policy with dscp
When we are delete the VM which has an associated qos policy with it,
the stale entry of DSCP marking use to persist for the table number 90.
The reason for this was that when QosNeutronPortChangeListner is called
rpc called to fetch DPN id use to fail. By moving the code to
QosInterfaceStateChangeLister we can use Interface to find out DPN id.
Change-Id: I485d84806eae2bcc8341518f8186973efb171658
Signed-off-by: Naveen Kumar Verma <naveen.kumar.verma@ericsson.com>
Aswin Suryanarayanan [Wed, 26 Apr 2017 10:11:22 +0000 (15:41 +0530)]
Bug 8310 - SNAT flows not added when the first subnet is added to the
external n/w after router g/w set
1)Check for the presence of external IP during add.
2)Update now considers whether a subnet is added after router g/w set.
Change-Id: Ibb6f2a5cf031db18a624e68391415e6574242434
Signed-off-by: Aswin Suryanarayanan <asuryana@redhat.com>
Jaime Caamaño Ruiz [Wed, 19 Apr 2017 13:55:02 +0000 (15:55 +0200)]
ClassifierUpdate unit tests
Change-Id: I4baa75c75c590e35a44da8b61e86eb27e625f79c
Signed-off-by: Jaime Caamaño Ruiz <jaime.caamano.ruiz@ericsson.com>
Slava Radune [Thu, 20 Apr 2017 10:48:32 +0000 (13:48 +0300)]
Fix remote acl bugs
1. Merging metadatas of lPort and aclId.
2. Handling reg6Match for ingress
3. Fixing dupplicate AclInterfaces in AclDataUtil
4. Adding all ips to remote acl filter table, not only those with remote acl rules
5. Fixing the flows instalation logic for the case of port in more than one SG.
6. Fixing handling of SG that uses itself as remote SG.
Change-Id: I64b0e294317e0ac1a3444192a92f8058f2604f1d
Signed-off-by: Slava Radune <slava.radune@hpe.com>
Arun Sharma [Sun, 9 Apr 2017 14:28:05 +0000 (19:58 +0530)]
Netvirt: Qos Alert patch5
*** patch #5 - Port direct statistics polling ***
Added support of retrieval of port statistics data using OpenflowPlugin
direct-statistics RPC and log the alert message if packet drop ratio is
greater than the configured threshold value.
Spec Review Link:
https://git.opendaylight.org/gerrit/50689
Change-Id: I0a708ccd7eeb10c3d71fd8c08d5a2efeacdd3e25
Signed-off-by: Arun Sharma <arun.e.sharma@ericsson.com>
Brady Johnson [Mon, 24 Apr 2017 11:58:22 +0000 (13:58 +0200)]
BUG 8284 - Unmatched packets get dropped by Classifier
- Packets that enter the Netvirt classifier that dont get
matched are dropped.
- These packets should instead be resubmit back to the
Ingress Dispatcher table.
- The solution is to add a lower priority MatchAny flow
to the INGRESS_SFC_CLASSIFIER_ACL_TABLE table that
resubmits back to the Ingress Dispatcher.
- Adding UT for the newly created flow.
Change-Id: I2d8b598a1146aa72a2c64c9b12835a7612e16c11
Signed-off-by: Brady Johnson <brady.allen.johnson@ericsson.com>
Manuel Buil [Thu, 27 Apr 2017 15:28:25 +0000 (17:28 +0200)]
Fix the error in the egress classifier spec
The table numbers were wrong and could confuse newcomers
Change-Id: Idd57ab06f4c17801fc40dc90b00a410f5f4cfb74
Signed-off-by: Manuel Buil <mbuil@suse.com>
Michael Vorburger [Wed, 5 Apr 2017 21:36:27 +0000 (23:36 +0200)]
@Immutable FlowEntity with FlowEntityBuilder
This is dependent on the genius change
https://git.opendaylight.org/gerrit/#/c/53763/, which must be merged
simultaneously.
The change in the Xtend re. flowId is because the FlowEntityBuilder does
not have a getFlowId() like FlowEntity, only a setter; see
https://github.com/immutables/immutables/issues/432
Change-Id: Iecbe1ccd2c1c6cb9c914b70c6e44590d748ad739
Signed-off-by: Michael Vorburger <vorburger@redhat.com>
Signed-off-by: Sam Hague <shague@redhat.com>
Alon Kochba [Wed, 22 Mar 2017 15:23:53 +0000 (17:23 +0200)]
Bug 7758: Use Trunk instead of Transparent port for Flat networks
Netvirt should have used Trunk ports for Flat networks, instead of
Transparent ports - otherwise there are issues of mixing Trunk and
Transparent ports together, since Trunks are automatically created
once there are Trunk Members (VLAN networks) on the same port.
Change-Id: If666b672b1158919623db11b5324321f2f7b15b0
Signed-off-by: Alon Kochba <alonko@hpe.com>
Arun Sharma [Fri, 7 Apr 2017 05:54:42 +0000 (11:24 +0530)]
Netvirt: Qos Alert patch4
*** patch #4 - Building Qos Alert port cache ***
This patch builds a cache of port stats data having QoS rate-limit rule applied.
A neutron port is added into the cache if -
1. Port QoS policy has bandwidth rate limit rule.
2. If port does not have QoS policy applied, then if network QoS policy
has bandwidth rate limit rule.
Spec Review Link:
https://git.opendaylight.org/gerrit/50689
Change-Id: Iafb22bd98009b891a2ef4911ef0edf9f2ab9c767
Signed-off-by: Arun Sharma <arun.e.sharma@ericsson.com>
Aswin Suryanarayanan [Wed, 19 Apr 2017 09:03:33 +0000 (14:33 +0530)]
Bug 8244 - In Conntrack SNAT implementation G/w is not reachable
when no
port in the router subnet is present in the node
Creates an elan interface when a router port is created amd is deleted
on port delete.
Change-Id: I18fa39310f22c7ad633037c7bda54f51d193374b
Signed-off-by: Aswin Suryanarayanan <asuryana@redhat.com>
Jaime Caamaño Ruiz [Mon, 10 Apr 2017 14:30:34 +0000 (16:30 +0200)]
ClassifierEntry unit tests + javadoc
Change-Id: I1317a8e7cc0bc08bd027e8a91bf29111572feab8
Signed-off-by: Jaime Caamaño Ruiz <jaime.caamano.ruiz@ericsson.com>
Riyazahmed D Talikoti [Mon, 27 Mar 2017 09:23:51 +0000 (14:53 +0530)]
EVPN RT2 elan changes to adv/withdraw RT2 routes..
1. Elan instance changes when network is attached and detached to EVPN
Neutronvpnmanager will add/delete/update evpn augmentaion in elan instance
EvpnElanInstanceManager is listening to the augmentation and based on type
of event EvpnElanInstanceManager will advertise or withdraw RT2 routes.
2. EvpnElanInstanceManager uses vpninstance to get rd to advertise or
withdraw routes.
Change-Id: I147da46e5d869cde560f25452e9e7511206a61dd
Signed-off-by: Riyazahmed D Talikoti <riyazahmed.d.talikoti@ericsson.com>
Josh [Wed, 8 Feb 2017 11:27:26 +0000 (13:27 +0200)]
Bug-7718 Operational neutron port status
networking-odl requires feedback as to when a neutron
port can be marked as "ACTIVE". This commit places an
estimation of that information in the operational data
store. For ports that connect to OVS we wait for them
to connect and for basic L2 flows to be configured.
Note that we do not validate the flows in operational
nor do we check all flows. Ports that are implemented
purely as flows are marked ACTIVE immediately. The plan
is for networking-odl to receive notifications of these
status changes via a websocket.
It was decided at the time being
to keep the port status out of the ODL neutron project
since (a) functionally, this issue is mainly an issue for
netvirt and (b) to do it right in netvirt would require
some re-architecting.
Change-Id: Id719e904b277fe4dbb9c3d118d24c3bedf110a33
Signed-off-by: Josh <jhershbe@redhat.com>
A Vamsikrishna [Tue, 18 Apr 2017 11:18:17 +0000 (16:48 +0530)]
Error messages are displayed when the port updated with qos policy stating
that binding are not allowed to the port
Following Error message was seen when the same port updated with second
qos policy:
2017-04-05 14:42:54,116 | ERROR | pool-39-thread-7 |
FlowBasedServicesConfigListener | 338 -
org.opendaylight.genius.interfacemanager-impl - 0.1.4.SNAPSHOT | Service
Binding entry update not allowed for:
b193e270-8053-4650-8059-
a8ec57713069, Data:
BoundServices{getServiceName=qos.
b193e270-8053-4650-8059-
a8ec57713069,
getServicePriority=3, getServiceType=class
org.opendaylight.yang.gen.v1.urn.opendaylight.genius.interfacemanager.servicebinding.rev160406.ServiceTypeFlowBased,
augmentations={interface
org.opendaylight.yang.gen.v1.urn.opendaylight.genius.interfacemanager.servicebinding.rev160406.StypeOpenflow=StypeOpenflow{getFlowCookie=
67108865,
getFlowPriority=10,
getInstruction=[Instruction{getInstruction=GoToTableCase{getGoToTable=GoToTable{getTableId=90,
augmentations={}}, augmentations={}}, getOrder=1, augmentations={}}]}}}
Use case:
- create a port, say port1
- create qos policy q1 with dscp and bandwidth
- Associate qos policy to the port
- observe the policy applied properly
- update the port again with qos policy q2
- Though the 2nd qos policy (here q2) seen applied properly , below error
message was seen in ODL side:
"Service Binding entry update not allowed"
RCA:
Qos service binding is happening even during the 2nd qos policy updation
on the same port on which a 1st qos policy already associated.
Change-Id: Ia3754833d716f1e387bd7bdce00f82ed51a394ce
Signed-off-by: A Vamsikrishna <a.vamsikrishna@ericsson.com>
Tali [Sun, 9 Apr 2017 09:21:32 +0000 (12:21 +0300)]
Bug 8189 - Policy flows are not updated after ovsdb other-config changes
Change-Id: Ic27b87922dd42aac020fa6f7e65bbab53e8c4489
Signed-off-by: Tali <tali.ben-meir@hpe.com>
eswanit [Thu, 20 Apr 2017 10:38:15 +0000 (16:08 +0530)]
Bug 8255 - VPN creation with multiple RD via Rest
is not working
fixed this by removing throwing of an error when
multiple RDs are passed to create VPN.
Change-Id: I28e546ca781d87566a2eb8b70148d980fa7dad3b
Signed-off-by: eswanit <swati.udhavrao.niture@ericsson.com>
karthikeyan [Tue, 11 Apr 2017 11:35:56 +0000 (17:05 +0530)]
Bug 8200:NAPT_PFIB_TABLE(47) with Internet VPN is not programmed for EVPN
This code review will address the following problem for EVPN NAT UCs.
1) NAPT_PFIB_TABLE (47) resubmit to L3_FIB_TABLE (21) {47->21} with
external (internet) VPN Id as match flow is not programmed for if external
network with Provider type VXLAN is configured.
2) When the external router is deleted some of the EVPN stale entry flows are
presented.
3) If more than one floatingIp is available in vpn-to-dpn-list for given
dpn id, do not call for installing INTERNAL_TUNNEL_TABLE (table=36) -> PDNAT_TABLE (table=25)
flow entry with same tunnel_id again and again.
Change-Id: I5a54764da323ed1ac20f91dd40fc36c06ed59ecb
Signed-off-by: karthikeyan <karthikeyan.k@altencalsoftlabs.com>
Signed-off-by: Sam Hague <shague@redhat.com>
Brady Johnson [Thu, 20 Apr 2017 08:28:48 +0000 (10:28 +0200)]
BUG 8240 - Fix odl-netvirt-sfc dependent features
- Adding the odl-sfc-genius feature.
Change-Id: Iee6f0a3df0e4dd9b3ae5f57035d0c4a1584dd163
Signed-off-by: Brady Johnson <brady.allen.johnson@ericsson.com>
Michael Vorburger [Thu, 20 Apr 2017 16:05:31 +0000 (18:05 +0200)]
Fix equals() bug in FederatedNetworkPair found by Checkstyle
This shows up as red in Eclipse, but the CLI mvn build missed this.
required for overall move to new Checkstyle version, see
https://git.opendaylight.org/gerrit/#/q/topic:bumpCheckstyle
Change-Id: I7a46ac4c96e541d9fec17f3e6add9bcf65999a48
Signed-off-by: Michael Vorburger <vorburger@redhat.com>
gobinath [Wed, 19 Apr 2017 18:49:12 +0000 (00:19 +0530)]
Bug 8235 - Bug in group programming for directly connected subnet routes
Issue:
1. The ECMP feature enables the loadbalancing of traffic to the the extra
routes only but the discovered routes are also getting loadbalanced similar
to the extra routes.
2. This also leads to the issue in case of the discovered routes
containing macaddress(directly connected subnet route), the
loadbalancing groupId overrides the local nexthop group Id
as the parameters used for computing the groupId turns out to be same.
Analysis:
1. Since the discovered routes are also present in the vpntoextraroute
container, the discovered routes are also being currently loadbalanced by
ECMP feature.
2. Also, the loadbalancing groupId is computed from the prefix or the nexthop Ip
depending on whether the macadress is present or not(if mac is present,
the nexthopIp is used and prefix for otherwise). In case of the directly
connected subnet route, the macaddress is present and so the nexthopIp
is used for computing the loadbalancing groupId. This overlaps with
local next hop group programmed for that nexthop.
Fix:
Since the discovered routes have only 1 next hop, this
condition is now used to distinguish between discovered routes and the
extra routes. Only the extra routes are loadbalanced now and the
discovered routes are handled as before(creating a new local nexthop
group).
Change-Id: I6b0c5506f438ec1f816dfa0fdb045a8494950f48
Signed-off-by: gobinath <gobinath@ericsson.com>
Abhinav Gupta [Wed, 19 Apr 2017 18:52:28 +0000 (00:22 +0530)]
FIB: VNI support in datapath for VxLAN networks
This commit adds support for VNI based L3 forwarding for VxLAN based
provider networks.
Spec: https://git.opendaylight.org/gerrit/#/c/48640/
Following changes are done:
1.
i) FIB_TABLE will set the destination network VNI in the tun_id
field instead of the MPLS label.
ii) On egress OVS, match will happen on this VNI in table 36,
and packet will be taken to ELAN pipeline in order to reach the
destination VM.
iii) Table 36 will no longer be programmed by FIB to match on MPLS
label for internal router-based VPNs whose subnets are part
of a VxLAN network
2. Some changes are done to program VNI in tun_id for ECMP LB NH
groups.
3. The commit also incorporates the enforce-openstack-semantics
flag to enable easy turning on/off of the feature.
4. Some refactoring and cleanup has also been done, majorly to
remove the local utils/references for MDSAL sync
write/delete/update APIs.
Change-Id:Id3244bd9f72028381e1790e96428a8f541f0e6b2
Signed-off-by: Abhinav Gupta <abhinav.gupta@ericsson.com>
Abhinav Gupta [Thu, 12 Jan 2017 11:11:49 +0000 (16:41 +0530)]
ELAN: VNI support in datapath for VxLAN networks
This commit adds support for VNI based datapath forwarding for VxLAN
based provider networks.
Spec: https://git.opendaylight.org/gerrit/#/c/48640/
a. Unicast
1. Table 51 now sets VNI in tun_id field for packets egressing on
tunnel ports
2. On egress, table 36 now matches on VNI in tun_id field, sets the
ELAN tag in metadata, and forwards the traffic to table 51
b. Broadcast
1. Remote broadcast group now sets VNI in tun_id field for packets
egressing on tunnel ports
2. On egress, table 36 now matches on VNI in tun_id field, sets the
ELAN tag in metadata, and forwards the traffic to table 51
Also, integrates the openstack-vni-semantics-enforced flag to enable
easier turning on/off of the feature
Change-Id: I7a6b14897344a8d00cb19291602d92cf586f15f7
Signed-off-by: Abhinav Gupta <abhinav.gupta@ericsson.com>
gobinath [Tue, 11 Apr 2017 06:31:16 +0000 (12:01 +0530)]
Bug 8201 - ECMP not working with router based VPN
Issue:
In case of router based VPNs, the loadbalancing groups created for extra
routes are not updated with correct buckets when the extra route is
present behind different DPNs.
Analysis:
The issue is caused as the current design requires list of rds to
differentiate the extraroute present behind different DPNs.
Fix:
In case of the router based VPNs, the DpnIds are used as rds so the
vpntoextraroute is now populated correctly.
Change-Id: I18f6d39c67047a31817d442ba79aee6244bf3712
Signed-off-by: gobinath <gobinath@ericsson.com>
eupakir [Thu, 13 Apr 2017 09:51:35 +0000 (15:21 +0530)]
Bug 8221 - Remove Wait Time To Install L3VPN Groups on OVS
Currently we have a wait of 1.5s to ensure L3VPN groups are programmed
correctly in OVS, before we start programming the L3VPN Flows. This needs
to be optimized further.
This patch makes use of the OpenFlowPlugin addGroup() RPC call to directly
install the group in the OVS. This will ensure that the subsequent installation
of flows will always find the required groups in the OVS.
Group installation via the FRM is still retained to ensure consistency in the
datastore.
Change-Id: Ie4c2cf2a6199bad2a27d067d444a42ae04d3f191
Signed-off-by: eupakir <kiran.n.upadhyaya@ericsson.com>
Sam Hague [Wed, 19 Apr 2017 22:38:38 +0000 (18:38 -0400)]
Remove unused setFibManager
Change-Id: I627678151987577273bca88f5506a9faaedcd0c1
Signed-off-by: Sam Hague <shague@redhat.com>
Sam Hague [Thu, 20 Apr 2017 01:53:34 +0000 (21:53 -0400)]
cleanup ovsdb-ui bundle
Change-Id: I60da5608800bb36353e166334262e6f3bf33ac46
Signed-off-by: Sam Hague <shague@redhat.com>
Sam Hague [Thu, 20 Apr 2017 00:28:11 +0000 (20:28 -0400)]
Add ovsdb-ui bundle
Change-Id: If6b04d9ba61bcc32eac5603c13304b933318d184
Signed-off-by: Sam Hague <shague@redhat.com>
Vyshakh Krishnan CH [Thu, 13 Apr 2017 08:43:46 +0000 (14:13 +0530)]
Bug 8142 : DHCP timeout issue.
Issue:
stable/boron not usable - DHCP timeout
Analysis:
more than 5 thread were waiting on BGPConfigurationManager when BGP was
trying to send thrift messages to QBGP and QBGP is not up. BGP was
retrying it again and again. Meanwhile, services which call addPrefix is
getting blocked due to synchronized behavior of addPrefix.
Fix:
APIs exposed by BGP to other services - addPrefix, delPrefix, addvrf and
delVrf is made unsynchronized.
Change-Id: I6010b1eeef680b1f8d8908c2b9faf283b3827cfc
Signed-off-by: Vyshakh Krishnan CH <vyshakh.krishnan.c.h@ericsson.com>
Sam Hague [Fri, 14 Apr 2017 19:15:57 +0000 (15:15 -0400)]
Deprecate legacy features
Depends-on: https://git.opendaylight.org/gerrit/55083
Change-Id: Ia0ac9c5d427bd616eaa651df2e85297225afdfe3
Signed-off-by: Sam Hague <shague@redhat.com>
Sam Hague [Wed, 19 Apr 2017 18:26:47 +0000 (14:26 -0400)]
add odl-sfc-genius to odl-netvirt-sfc
Change-Id: I2512b14e15210bda5e5b8339621ea8a7b2b02f13
Signed-off-by: Sam Hague <shague@redhat.com>
Brady Johnson [Tue, 18 Apr 2017 13:50:13 +0000 (15:50 +0200)]
BUG 8240 - Fix odl-netvirt-sfc dependent features
- Needed to install odl-sfc-openflow-renderer instead of
odl-sfc-provider in order to bring in all the needed
SFC features.
Change-Id: Id83d65c5b67214a826ff903cf48efeeca61aa99a
Signed-off-by: Brady Johnson <brady.allen.johnson@ericsson.com>
karthikeyan [Sat, 8 Apr 2017 17:21:57 +0000 (22:51 +0530)]
Bug 8188: L3VNI without configured UC handled for EVPN
Problem Description:
==================
L3VNI without configured in Internet VPN needs to be handled for EVPN in
NAT feature.
Currently Internet(External) VPN with L3VNI use case only handled for
external VXLAN network (EVPN) in NAT feature.
Internet(External) VPN without L3VNI use case also needs to be handled for
external VXLAN in NAT feature. Since Openstack Operator may configure L3VNI or
may not configure L3VNI.
Solution:
=========
Unconfigured of L3VNI value in Internet(External) VPN, will carve-out
the L3VNI value from OpenDaylight VXLAN VNI Pool to use SNAT and DNAT
flows.
The following UCs are handled based on the L3VNI configured/unconfigured
for GRE and VXLAN provider type.
Ext-Net-Type || Internet-VPN-L3VNI || External and Internal VXLAN uses
===============================================================================
GRE Configured Ignore L3VNI, allocate VNI from pool and
use it for Intra-DC only
--------------------------------------------------------------------------------
GRE Not Configured A VNI taken from ODL Pool and used for
Intra-DC communication
---------------------------------------------------------------------------------
VXLAN Configured Internet-VPN-L3VNI used for both
Intra-Inter-DC communication
---------------------------------------------------------------------------------
VXLAN Not Configured A VNI taken from ODL Pool and used for both intra-
inter-DC communication
---------------------------------------------------------------------------------
Note: If VNI value is unable to get from ODL VNI Pool, router-id will be
used as tunnel-id for external network provider type as VXLAN
Change-Id: I3c3f21e026303edf7eb2ad88bfd33622523085f0
Signed-off-by: karthikeyan <karthikeyan.k@altencalsoftlabs.com>
Alon Kochba [Tue, 18 Apr 2017 17:07:17 +0000 (20:07 +0300)]
Bug 8241: Fix openstack-sfc ACLs IllegalArgumentException
Fix ace port range to be set only if mandatory lower port
is specified, otherwise we hit an exception.
Change-Id: Ic6206394e4255653a837c2b57cefc538555eefa4
Signed-off-by: Alon Kochba <alonko@hpe.com>
cgowdru [Mon, 10 Apr 2017 11:46:26 +0000 (17:16 +0530)]
ADDED INFO logs for tempest issue DEBUG
Change-Id: I25cb78056fbc6b7cbd372ac7565c21472e2c3060
Signed-off-by: cgowdru <chetan.arakere@altencalsoftlabs.com>
gobinath [Mon, 10 Apr 2017 03:26:59 +0000 (08:56 +0530)]
Bug 8170 - Loadbalancing nexthop group not updated after VM deletion
Issue:
When the last nexthop present in a DPN is deleted, the loadbalancing next
hop group is not updated. The group still contains the bucket pointing to
the deleted nexthop.
Fix:
There was an error while retrieving the endpointIpaddress for the DPN in
method getEndpointIpAddressForDPN. There was an error in converting the
IpAddress object to string. Appropriate conversion is used now.
Change-Id: I86cc77bd69446881d2ab669471f3142845e4d549
Signed-off-by: gobinath <gobinath@ericsson.com>
Sam Hague [Sat, 15 Apr 2017 01:13:54 +0000 (21:13 -0400)]
Set copyright for sfc translator back to Brocade
Change-Id: I576ff1dfe9c97cde540c1a56f77a857fb32e43eb
Signed-off-by: Sam Hague <shague@redhat.com>
Sam Hague [Fri, 14 Apr 2017 12:05:20 +0000 (08:05 -0400)]
Remove .0 from model.bgp.version
The version bump script ancorrectly added a .0 to the version.
This was a problem as during this same time the vpnservice-features
was using the value without the .0 from a different patch, so they
were not consistent.
Change-Id: I38c47898bdf706ccb0f89ce76209cbbbbb8540d8
Signed-off-by: Sam Hague <shague@redhat.com>
Yakir Dorani [Thu, 6 Apr 2017 08:52:51 +0000 (11:52 +0300)]
Bug 8166: Acl interfaces are not set and cached correctly
The acl interface can exist in the cache before an interface
was assigned one. This can happen via the AclInterfaceStateListener.
Also, an interface ID should be set when a new entry is created.
Change-Id: I3e882582731eb273da533ac15dd2c8cc7f27ffe2
Signed-off-by: Yakir Dorani <yakir.dorani@hpe.com>
Sam Hague [Wed, 12 Apr 2017 18:45:04 +0000 (14:45 -0400)]
Use ArpConstants from arputil
Depend-on: https://git.opendaylight.org/gerrit/54890
This avoids duplicating constants and also helps to
break cyclics.
Change-Id: I76689a97d1131d13cffa382bbf4d07d7a3d19044
Signed-off-by: Sam Hague <shague@redhat.com>
(cherry picked from commit
40f3c94a3068d45b5fda6b38500dbce07aadca44)
Sam Hague [Thu, 13 Apr 2017 13:17:36 +0000 (09:17 -0400)]
Name all blueprint.xml file consistently
Change-Id: I7497339a96ff0f76f11e3f3c9937f57b6993169c
Signed-off-by: Sam Hague <shague@redhat.com>
(cherry picked from commit
c553537cee52a74b78e2ca68c568ae548a941ebb)
Vratko Polak [Thu, 13 Apr 2017 10:04:51 +0000 (12:04 +0200)]
Fix model-bgp version
Change-Id: I419cbebf5df5d38501cf3793aba5ecd806c7f25c
Signed-off-by: Vratko Polak <vrpolak@cisco.com>
Janki [Wed, 5 Apr 2017 15:16:33 +0000 (20:46 +0530)]
Bug 8162 - NPE at org.opendaylight.netvirt.vpnmanager.VpnSubnetRouteHandler.onSubnetAddedToVpn
Change-Id: I2936a473841b995a496c76064249a2bb9bd96354
Signed-off-by: Janki <jchhatba@redhat.com>
Sam Hague [Wed, 12 Apr 2017 21:02:09 +0000 (17:02 -0400)]
Cleanup unused dependencies
Change-Id: I98eb44130f247108589db3aedf4e015b76ce03c1
Signed-off-by: Sam Hague <shague@redhat.com>
Sam Hague [Wed, 12 Apr 2017 19:26:25 +0000 (15:26 -0400)]
add interface for VpnFootprintService
This is another attempt to reduce cyclics.
Change-Id: I29acdc7fa4c681c24b0cafc8430716f189bd7be1
Signed-off-by: Sam Hague <shague@redhat.com>
Sam Hague [Wed, 12 Apr 2017 23:28:29 +0000 (19:28 -0400)]
Remove legacy utils from new netvirt
Change-Id: I43a183b689846924ac8344117bfa59cae0457a4a
Signed-off-by: Sam Hague <shague@redhat.com>
Akash Kumar Sahu [Wed, 12 Apr 2017 10:47:22 +0000 (16:17 +0530)]
Bug 8014 - L2Gw connectivity not working
Tunnel creation issue as cache were not populated properly
Fixed .
Change-Id: I7613afe762f0a865275c3fc492045ef4d035ba84
Signed-off-by: Akash Kumar Sahu <a.k.sahu@ericsson.com>
Sam Hague [Wed, 12 Apr 2017 22:07:13 +0000 (18:07 -0400)]
Remove utils.config
Change-Id: Iaf232a25f055b26e392d337e85a2b15409b9c03d
Signed-off-by: Sam Hague <shague@redhat.com>
Brady Johnson [Mon, 10 Apr 2017 09:27:10 +0000 (11:27 +0200)]
BUG 8193 - Fix Netvirt classifier egress service port binding
- The Netvirt classifier egress service should bind on egress
ports, not ingress ports like it does now.
- Since its not possible to know all the possible egress ports
to bind on before-hand, the egress classifier service will
bind on all switch ports. It will only process NSH packets
and return all others to the egress dispatcher.
- Also in this patch, when the SFF is on the same bridge as
the classifier, the egress classifier will resubmit the
packets directly to the SFF instead of going through the
ingress dispatcher, since we dont know the correct ingress
port to use for the SFF.
- Updated OpenFlow13ProviderTest to reflect the change to the
egress classifier resubmit.
- Changes from code review comments
- Final changes to make sure the egress binding is working.
Now using getDpnInterfaceList RPC to get the switch ports
to bind to.
Change-Id: I97bc38722064738ee22b8ddbc7163bc5dc3dd276
Signed-off-by: Brady Johnson <brady.allen.johnson@ericsson.com>
Sam Hague [Mon, 10 Apr 2017 17:40:04 +0000 (13:40 -0400)]
Cleanup version properties
Change-Id: I15c3131032866d0094b7f34ac7e4c85cfe139665
Signed-off-by: Sam Hague <shague@redhat.com>
ruby -v [Wed, 12 Apr 2017 09:29:19 +0000 (14:59 +0530)]
Bug 8105: IllegalArgumentException in getSrcIp fix
1. reading IP and ARP payload was wrong, which is fixed by getting payload from
deserialised ethernet data based on IPv4 or ARP, getPayload will return
the right payload as the offsets are maintained in Packet based on
type of payload.
2. IllegalArgumentException was for payload type IPv4 where
getSourceAddress method will return of type int, and
NWUtil.toStringIpAddress will accept input as byte.
The same was working fine with payload type ARP as
getSenderProtocolAddress return byte.
3. Tested these changes by creating 2 ports in neutron network, delete 1
port and send ping packets from deleted port to the other port.
First ARP packet hit and was able to retrieve IP address properly, and
then data traffic hit and was able to retrieve IP address.
Change-Id: I16af2e18e2c857a5529f4ffef1caf9da014d521f
Signed-off-by: Riyazahmed D Talikoti <riyazahmed.d.talikoti@ericsson.com>
Anil Belur [Tue, 11 Apr 2017 01:45:45 +0000 (11:45 +1000)]
Bump versions by x.(y+1).z for next dev cycle
Change-Id: I9934b7eaaf36c6726e0f8e6700aca63421f03b5c
Signed-off-by: Anil Belur <abelur@linuxfoundation.org>
eupakir [Mon, 3 Apr 2017 13:32:53 +0000 (19:02 +0530)]
BUG 8140 : Elect nodes for subnetroute on control path reboot
When a physical switch on the cloud management network in the cloud is
rebooted, it results in disconnection of datapath-nodes from the ODL
controller. Under such conditions, the subnetRoute is removed from all
the DPNs.
However, once the physical switch comes back up after reboot, the
datapath-nodes are all getting reconnected to the ODL controller. During
this time in a scaled environment, the subnetRoute flow rules aren't
getting reapplied to the datapath-nodes. This is because the election
process fails in figuring out a designated datapath-node for hosting
subnetroute, thereby the subnetRoute is not getting reconfigured on all
the datapath-nodes.
Co-Authored-By: Vivekanandan Narasimhan <n.vivekanandan@ericsson.com>
Change-Id: I4e2770a658e9d3b0c68fc52227845ed8546ecb97
Signed-off-by: eupakir <kiran.n.upadhyaya@ericsson.com>
Signed-off-by: Vivekanandan Narasimhan <n.vivekanandan@ericsson.com>
Sam Hague [Mon, 10 Apr 2017 16:09:40 +0000 (12:09 -0400)]
cleanup checkstyle to pull from parent poms
Change-Id: If1a78a39696a64a29ad57f56978450a1b06a947c
Signed-off-by: Sam Hague <shague@redhat.com>
Josh [Sun, 26 Mar 2017 09:15:08 +0000 (12:15 +0300)]
Bug-8053 OVS Bridge other_config:hwaddr not preserved for nodes not in config DS
1) Make sure to retain operational DS other_configs for existing bridges
2) Set other_config:datapath-id for all bridges already in operational. This
is important to guarantee dpid does not change even for bridges where the
other_config:hwaddr or other_config:datapath_id vals are not set.
DEPENDS ON: https://git.opendaylight.org/gerrit/53856
Change-Id: I5aa792262230655bf753045290666c73aaa4096b
Signed-off-by: Josh <jhershbe@redhat.com>
Brady Johnson [Fri, 7 Apr 2017 07:30:03 +0000 (09:30 +0200)]
UT for SfcProvider and NetvirtProvider
- Added SfcProviderTest.java
- Added NetvirtProviderTest.java
- modified pom.xml to add ConstantSchemaAbstractDataBrokerTest
Change-Id: If8f9a7f3e87725d279566531df4b2b431abdb417
Signed-off-by: Brady Johnson <brady.allen.johnson@ericsson.com>
Faseela K [Sun, 9 Apr 2017 18:23:07 +0000 (23:53 +0530)]
Minor code cleanup in ELAN
Change-Id: I15e80fd1d38b6a4cb96d1c947bddbc1a68bf4180
Signed-off-by: Faseela K <faseela.k@ericsson.com>
karthikeyan [Fri, 7 Apr 2017 09:40:17 +0000 (15:10 +0530)]
Bug 8001: Data validation failed for path CSIT TCs
Problem Description:
====================
On external network update or internet VPN update NAT code will trigger
the ExternalRoutersListener.update() to handle the updated changes
in NAT feature. During this invocation, for getting NAPT switch-id is
retrieved from the "router-to-napt-switch" DS. After retrieved the NAPT
switch-id from the DS, it contains the value as "0". There is no check for
NAPT switch-id validation.
clrRtsFromBgpAndDelFibTs() method is invoked with passing NAPT switch-id
as "0" value is throwing the data validation exceptions.
Solution:
===========
As part of this issue fix, invoked NAPT Switch selection if dpnId value is
"null" or "0" from "router-to-napt-switch" DS then go for electing new
Napt switch for existing router. This will resolve the data validation
exception. Since clrRtsFromBgpAndDelFibTs() method is never invoked with
NAPT switch-id as "0".
Change-Id: I851c4049397369871616834f59aff1eb16ce4472
Signed-off-by: karthikeyan <karthikeyan.k@altencalsoftlabs.com>
eupakir [Thu, 6 Apr 2017 08:47:56 +0000 (14:17 +0530)]
Bug 8165 - Learnt IP route does not reappear on DC-GW after OVSRestart
On OVS Restart, a learnt IP will have to be deleted by Liveness
Monitor, and then re-learnt once the OVS comes up.
But this IP was not learned again.
Cyclic events were getting spawned while processing removal of
Learnt IPs. This was causing deletion of re-learnt IPs.
Change-Id: I17b87fef05de8d3eb51f2a4720df98ff647e8937
Signed-off-by: eupakir <kiran.n.upadhyaya@ericsson.com>
Signed-off-by: Vivekanandan Narasimhan <n.vivekanandan@ericsson.com>
Tali [Thu, 6 Apr 2017 08:56:25 +0000 (11:56 +0300)]
Bug 8020 - Conflicting modification on VpnInterface creation for router-interface in newton
Change-Id: I918174b829075c571414bf82c40936cc950af630
Signed-off-by: Tali <tali.ben-meir@hpe.com>
Michael Vorburger [Thu, 6 Apr 2017 10:03:37 +0000 (12:03 +0200)]
Fix erroneous space in DhcpAllocationPoolRemoveJob import statement
This shows up as "red ink" (error) in Eclipse as a Checkstyle violation.
I'm not sure why the CLI mvn Checkstyle does not fail forr this - it may
be a subtle difference between the exact version of Checkstyle
internally used by the Eclipse plugin and the one used by the Maven
build.
Change-Id: I3dacb8d5c6f6eb689bfadf034c2e1db7f30ce76f
Signed-off-by: Michael Vorburger <vorburger@redhat.com>
karthikeyan [Tue, 4 Apr 2017 07:44:18 +0000 (13:14 +0530)]
Bug 8145 - DNAT to DNAT traffic is getting failed for 2nd FIP for EVPN/VNI
Problem Description:
====================
DNAT to DNAT traffic (Different Hypervisor) is getting failed for 2nd FIP
VM for VXLAN and GRE Networks.
Consider 2 FIP VMs are booted on single DPN.
When disassociation/remove of 1st FIP VM, 2nd FIP VM traffic for DNAT to
DNAT is getting failed.
When remove 1st FIP it will remove the flow 36->25 entry. Hence DNAT to
DNAT communication is not happening.
This issue is existing for VXLAN and GRE (L2_L3_VNI Based Forwarding)
external provider type networks only.
Solution:
===========
For EVPN_RT5 and L2-L3 VNI based forwarding, uses "l3vni" value as
tunnel_id in the INTERNAL_TUNNEL_TABLE (table=36). If mutiple FIPs are
existing in the single DPN, each remote tunnel_id will be setting with
same "l3vni" value. Hence removing one FIP is causing the problem
with other DNAT traffic. To avoid this problem added the fix for removing
the flow INTERNAL_TUNNEL_TABLE (table=36) -> PDNAT_TABLE (table=25) to
check if any FIP is existing on the given DPN. If not exist then only will
remove the flow table36->25.
Change-Id: I410035b4d160a22ac016a6de3fce219010e6c1f3
Signed-off-by: karthikeyan <karthikeyan.k@altencalsoftlabs.com>
eceghkl [Fri, 17 Mar 2017 06:06:43 +0000 (11:36 +0530)]
Tunnel Interface State Handling for extra routes
* Handle interface state changes for tunnel
* Handles add and delete event
* Add/remove nhList from vrfentrylistener based on event
Depends-On: I1b40ce3ea8b73707295e86ae9d4ddddf15716b2e
Change-Id: I3c091a538d201ff4f4accc04d5fb35bee482de4d
Signed-off-by: eceghkl <manu.b@ericsson.com>
Brady Johnson [Wed, 5 Apr 2017 17:48:04 +0000 (19:48 +0200)]
UT for Netvirt SFC classifier
- Added AclMatchesTest.java
- Added OpenFlow13ProviderTest.java
- Changes to remove DataBroker from OpenFlow13ProviderTest as suggested by Michael Vorburger
- Minor changes were made to OpenFlow13Provider to expose constants used in creating
flows so that OpenFlow13ProviderTest can verify they were set accordingly.
- Flushed out a bug in OpenFlow13Provider thanks to the UT: The flowId
was not being set correctly in createEgressClassifierFilterVxgpeNshFlow
- Flushed out a bug in OpenFlow13Utils thanks to the UT: The inport
NodeConnectorId was not being set correctly in addMatchInPort.
Change-Id: I950422eea7a8f0ee9aab9b14cd2ea877bceba8d8
Signed-off-by: Brady Johnson <brady.allen.johnson@ericsson.com>
Somashekar Byrappa [Fri, 3 Feb 2017 10:26:39 +0000 (15:56 +0530)]
Bug 7730: Traffic drop in ACL during port update for AAP
Issue: ARP flows in ACL tables are missing if AAP with same MAC is updated
Fix:
+ For AAP case, changed the order of programming flows to delete and add
instead of add and delete flows.
+ For port update, programming ARP flows is handled separately.
- For egress, deletion of ARP flow is skipped if AAP is updated for same
MAC.
- For ingress, no action required as ARP flow has match for lport
tag only. MAC is not used here.
Change-Id: I6c814468d80a601e127c813ee1897f9ed18315bf
Signed-off-by: Somashekar Byrappa <somashekar.b@altencalsoftlabs.com>
Aswin Suryanarayanan [Sat, 8 Apr 2017 08:45:33 +0000 (14:15 +0530)]
Added Nat Config in vpn-service feature pom.
Change-Id: Id09a72bd02bd4f82f9cdf4c28a291eb3bd52924a
Signed-off-by: Aswin Suryanarayanan <asuryana@redhat.com>
Aswin Suryanarayanan [Sat, 8 Apr 2017 07:36:14 +0000 (13:06 +0530)]
Set update-strategy to none.
Check [1] for more info.
https://git.opendaylight.org/gerrit/#/c/54103/
Change-Id: I773f11962bf9bf0240fb53391ea84341caf56b15
Signed-off-by: Aswin Suryanarayanan <asuryana@redhat.com>
Brady Johnson [Fri, 31 Mar 2017 00:53:26 +0000 (02:53 +0200)]
Final changes for netvirt sfc classifier
- correctly obtain egress port from genius
- minor changes from previous code review
- Bugs tracked to be fixed in subsequent versions:
BUG 8127
BUG 8128
BUG 8129
- Rebased
- BUG 8128 turned out to be a configuration error of mine.
IPv4 matching works just fine.
- BUG 8128 has been closed.
- Removed Legacy Netvirt flow utils usage.
- BUG 8129 is partially addressed. Removed legacy netvirt flow utils,
but in order to remove FlowBuilder usage, several changes to Genius
will be needed, and will be done in a separate patch.
- minor fix for flow deletion
- made the ACL flow key more unique
- Check for the Vxgpe option on tunnel ports
Change-Id: I9ba1853222ae72d7e70f4aa192284bb46f6c7d32
Signed-off-by: Brady Johnson <brady.allen.johnson@ericsson.com>
Aswin Suryanarayanan [Tue, 28 Mar 2017 15:42:09 +0000 (21:12 +0530)]
Added a new config parameter for selecting SNAT.
The default is set to controller mode.
The controller mode is disabled wherever applicable when conntrack is
selected.
When conntrack is selected new HA framework is used by default. The
controller mode continue to use the existing HA.
Change-Id: I00bb3ccda43cf382d6f2047298c4b25c82c73194
Signed-off-by: Aswin Suryanarayanan <asuryana@redhat.com>
Signed-off-by: Sam Hague <shague@redhat.com>
Sam Hague [Thu, 6 Apr 2017 14:38:38 +0000 (10:38 -0400)]
Update neutronvpn to use Singleton
Change-Id: Iaf1b94c06bfb69e98f13a71d4a5782293f777692
Signed-off-by: Sam Hague <shague@redhat.com>
Sam Hague [Thu, 6 Apr 2017 03:45:50 +0000 (23:45 -0400)]
Update natservice to use Singleton
Change-Id: I547755f19f4ad76699988c4db417f749453d89ab
Signed-off-by: Sam Hague <shague@redhat.com>