Bump versions to 13.1.3-SNAPSHOT

This starts the next development iteration.

Change-Id: Id005c8c6f53b2586e4f983141a897b1df52d3d8a
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Release odlparent

Remove TestBundleDiag constructor

We do not want to leak the default implementation around, its direct
injection.

JIRA: ODLPARENT-312
Change-Id: I44755d26f52aa5249e5302264d42557bf241bf1d
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Do not attach sources to features

maven-source-plugin emits a warning if we try to attach source. This
really should be solved by karaf.version being exposed from
odlparent-lite. Let's work around the warning by disabling source
plugin instead.

Change-Id: I31223e4e5e4a6b8a87cc16b2859f7d6f2b9ccb9d
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Summarize changes

We are ready for 13.1.2, update news to reflect that.

Change-Id: I4116c8a7e37a60e6ce1c1a18969d3f63f8a7f6f9
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Log unresolved bundles

Refactor bundle checking so that we perform explicit searches.

JIRA: ODLPARENT-312
Change-Id: I528f66ea1244a07b619fb82d960b2fcce124fb3f
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Improve bundle logging

Differentiate the NOK format from delta format.

For NOK we print out the diag, but for others we just skip it.
For delta we print diag in brackets.

JIRA: ODLPARENT-312
Change-Id: I43b4def38c6d415f7e16efc010d7060147dbf170
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Refactor CheckResult

Enums can have static factory methods, relocate the enum, hide it and
move checkResultOf().

JIRA: ODLPARENT-312
Change-Id: I94b3d091d040d7d2f264197763d6f3404153bb68
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Make bundless-diag a component

Integrate fully with OSGi by providing DefaultDiagProvider as a
component.

JIRA: ODLPARENT-312
Change-Id: I501f97d72c674ee7451e307b846d34828e0a2dda
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Add bundles-diag

This is a distillation of what we can report from Karaf's BundleService,
so that it can be used by multiple users.

JIRA: ODLPARENT-312
Change-Id: I2c151926bbe386a81566f42b206a60100ecf4178
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
Signed-off-by: Ruslan Kashapov <ruslan.kashapov@pantheon.tech>

Skip execution on skipTests

Previous incarnation of this test was executing via surefire, hence it
would be suppressed via -DskipTests. Restore this behaviour.

JIRA: ODLPARENT-312
Change-Id: I0c398d7b2d007161be515f8d9d7242bcee208023
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Fix default SFT interval

We should be using the interval constant, not the timeout.

JIRA: ODLPARENT-312
Change-Id: I95bba1a7dfbf240279041d43207b3df8942fcf94
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Bump error-prone-annotations to 2.27.1

https://github.com/google/error-prone/releases/tag/v2.27.0
https://github.com/google/error-prone/releases/tag/v2.27.1

Change-Id: I3db8afd27b41bb3fb18e5f8e77c01baa8e9f2278
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Bump checker-qual to 3.43.0

JUst a plain upgrade.

Change-Id: Ic51ecc323b60ee24cafba6c80184f61d8352bb44
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Bump Jersey to 2.43

https://github.com/eclipse-ee4j/jersey/releases/tag/2.43

Change-Id: I4656c3e6c056f18d087f359f0301ced6b9744da0
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Bump xmlunit to 2.10.0

https://github.com/xmlunit/xmlunit/releases/tag/v2.10.0

Change-Id: Ibff87fa73653612a06a77960465acc095fb9d5ec
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Bump checkstyle to 10.16.0

https://checkstyle.org/releasenotes.html#Release_10.16.0

Change-Id: Ib6b4a8b6a565fccb9e212da6e89b046d39126ca6
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Bump maven-shade-plugin to 3.5.3

https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12317921&version=12354342

Change-Id: I6f45b4131944c693ce28857bb6dd9743a4e86611
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Bump maven-install-plugin to 3.1.2

https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12317524&version=12353548

Change-Id: Ia256f4f606946f4b0221dc62d5140c574bc985f0
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Bump maven-deploy-plugin to 3.1.2

https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12317228&version=12354128

Change-Id: I48db9103d8c4fdfaff21a1ebfb1422b695996a38
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Rework time keeping

Do not rely on calendar time and use more modern methods of sleeping.

JIRA: ODLPARENT-312
Change-Id: Id7c3bb323e0b49f511bd58d5ae71d87feeabe8c1
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Fork JVM for SpotBugs

Downstream testing shows that parallel builds tend to hang on SpotBugs.
Run the analysis in a separate JVM again until we can figure out what is
going on.

Change-Id: I59ba05289bf2872ac25d1ac43a1ac2345b578cb2
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Fix bundle state check logic for feature-test-plugin

Using bundleContext listener is not reliable due to
only osgi bundle state change is being tracked. Using periodic
state check of all the bundles to track karaf bundle states.

Also: log messages updated for NOK bundles, check interval
configurable, timeout defaults is consistent for mojo and probe.

JIRA: ODLPARENT-312
Change-Id: I6e38216b9701d0858655d12f928eee314ee5edef
Signed-off-by: Ruslan Kashapov <ruslan.kashapov@pantheon.tech>

Bump maven-jar-plugin to 3.4.1

https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12317526&version=12354551

Change-Id: I3c9386defe3ba000a87b022f42a2d29bcb604101
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Bump commons-io to 2.16.1

https://commons.apache.org/proper/commons-io/changes-report.html#a2.16.1

Change-Id: I0b8d22176c468543fc9e117f25cdb42fc3ce8e0c
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Bump commons-text to 1.12.0

https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12318221&version=12353778

Change-Id: I8f23aca898468caa8f7e2f5c5c258cf5bfb0c6e4
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Bump Netty to 4.1.109.Final

https://netty.io/news/2024/04/15/4-1-109-Final.html

Change-Id: I9155efb2e4fb7df2b128cd306b3aad1132122977
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Bump threeten-extra to 1.8.0

https://www.threeten.org/threeten-extra/changes-report.html#a1.8.0

Change-Id: I5c654725827a5915c09779de78e2508c0e3beb06
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Bump org.slf4j to 2.0.12

https://www.slf4j.org/news.html#2.0.10
https://www.slf4j.org/news.html#2.0.11
https://www.slf4j.org/news.html#2.0.12

Change-Id: I65df446ebde082462be3875eb31dd5f1dc562cd3
Signed-off-by: Peter Suna <peter.suna@pantheon.tech>

Bump versions 13.1.2-SNAPSHOT

This starts the next development iteration.

Change-Id: Ia5d250d417011b5d6bdd6bacfa7c1e2b625a3a18
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Release odlparent

Update news for 13.1.1

Update news for 13.1.0, as they include an unplanned, but welcome update
of slf4j.

Change-Id: I45cd3c4413c1b658d8e90555cc86a8c097b31886
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Bump log4j to 2.23.1

https://logging.apache.org/log4j/2.x/release-notes.html#release-notes-2-23-1

Change-Id: I501b04dc4250c95fef17d74c76016bbcd8cd5b55
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Adopt slf4j-2.0.12

This patch upgrades baseline SLF4J to 2.0.12:
https://www.slf4j.org/faq.html#changesInVersion200
https://www.slf4j.org/news.html#2.0.1
https://www.slf4j.org/news.html#2.0.2
https://www.slf4j.org/news.html#2.0.3
https://www.slf4j.org/news.html#2.0.4
https://www.slf4j.org/news.html#2.0.5
https://www.slf4j.org/news.html#2.0.6
https://www.slf4j.org/news.html#2.0.7
https://www.slf4j.org/news.html#2.0.8
https://www.slf4j.org/news.html#2.0.9
https://www.slf4j.org/news.html#2.0.10
https://www.slf4j.org/news.html#2.0.11
https://www.slf4j.org/news.html#2.0.12

The new baseline requires:
- logback-1.3.x, hence we adopt logback-1.3.14:
https://logback.qos.ch/news.html#1.3.0
https://logback.qos.ch/news.html#1.3.1
https://logback.qos.ch/news.html#1.3.2
https://logback.qos.ch/news.html#1.3.3
https://logback.qos.ch/news.html#1.3.4
https://logback.qos.ch/news.html#1.3.5
https://logback.qos.ch/news.html#1.3.6
https://logback.qos.ch/news.html#1.3.7
https://logback.qos.ch/news.html#1.3.8
https://logback.qos.ch/news.html#1.3.9
https://logback.qos.ch/news.html#1.3.10
https://logback.qos.ch/news.html#1.3.11
https://logback.qos.ch/news.html#1.3.12
https://logback.qos.ch/news.html#1.3.13
https://logback.qos.ch/news.html#1.3.14

- log4j-2.19.0+, hence we adopt log4j-2.23.0:
https://logging.apache.org/log4j/2.x/release-notes.html#release-notes-2-18-0
https://logging.apache.org/log4j/2.x/release-notes.html#release-notes-2-19-0
https://logging.apache.org/log4j/2.x/release-notes.html#release-notes-2-20-0
https://logging.apache.org/log4j/2.x/release-notes.html#release-notes-2-21-0
https://logging.apache.org/log4j/2.x/release-notes.html#release-notes-2-21-1
https://logging.apache.org/log4j/2.x/release-notes.html#release-notes-2-22-0
https://logging.apache.org/log4j/2.x/release-notes.html#release-notes-2-22-1
https://logging.apache.org/log4j/2.x/release-notes.html#release-notes-2-23-0

Change-Id: Ib0c08b9c6d8c53f30f72e1f9dda3f86ce40059f6
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Bump versions to 13.1.1-SNAPSHOT

This starts the next development iteration.

Change-Id: I12df8f5a8fcdf5ba340491adf40572545cd248a0
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Release odlparent

Disable no-warnings in docs

We have deprecated things, hence we generate warnings.

Change-Id: I5e801abea7a1a6c980e7090db6d9b6b4988878c1
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Update NEWS for 13.1.0

Another roll up of news.

Change-Id: I487a3d4b67526cea1f8c4049e0fe3c99bdf3e4f3
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Bump maven-plugin-plugin to 3.12.0

https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12317820&version=12354176

Change-Id: I3f18d1f464866eec73909f1ca53bb971fe4d8188
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Bump maven-source-plugin to 3.3.1

https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12317924&version=12353471

Change-Id: I92f400d0497518203e3825ae2f0a14e345a0b2f3
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Bump jacoco to 0.8.12

https://github.com/jacoco/jacoco/releases/tag/v0.8.12

Change-Id: Ibc015929404dd971a5de943a726617901d1510f3
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Bump maven-jar-plugin to 3.4.0

https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12317526&version=12352303

Change-Id: I85f3de2ff36ba45503d5f639a15ea05cdd87e1fe
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Exclude Derby from pax-jdbc-features

The pax-jdbc-features 1.5.7 includes a transitive dependency on
Derby version 10.14.2.0, which introduces a critical vulnerability:
https://nvd.nist.gov/vuln/detail/CVE-2022-46337

Current fix is available only for Java 21.

JIRA: ODLPARENT-306
Change-Id: Ied65ef7392436780b7b05ae27ec49def08f66665
Signed-off-by: Peter Suna <peter.suna@pantheon.tech>
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Bump Karaf to 4.4.6

https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12311140&version=12354057
https://github.com/jetty/jetty.project/releases/tag/jetty-9.4.54.v20240208

Change-Id: I77bdb45e1fb53ab2f41a7b8d61f488daeef640fc
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Another roll up of NEWS

We have three more upgrades, mention them in the notes.

Change-Id: I0221a00da12dab5aad472005503189ce2c8e6db3
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Revert "Bump spotbugs to 4.8.4"

This reverts commit 95d40aa725ab1d2bd04902d237a90730a7bba7d4, as there
seem to be parallel execution issues.

Change-Id: I2432cbe22a5824e892372a55806d771c00193b69
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Revert "Defang most SING_SINGLETON_ Spotbugs warnings"

This reverts commit 51d80a8d57695502386ad8c351ba9fa11325f035, as it is
not needed without spotbugs-4.8.4.

Change-Id: Ide57acaad1ac76b0a0564bfa504ff700912bb311
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Defang most SING_SINGLETON_ Spotbugs warnings

These three violations are reported against perfectly-compliant classes,
making them less then useful. Disable them until upstream fixes their
heuristics.

Change-Id: I64361e2be3108ebbc044c35540df4aa0481967ae
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Bump spotbugs to 4.8.4

https://github.com/spotbugs/spotbugs/blob/master/CHANGELOG.md#484---2024-04-07
https://github.com/spotbugs/spotbugs-maven-plugin/releases/tag/spotbugs-maven-plugin-4.8.4.0

Change-Id: I33c9f5fd771d2f6a9ee49879613853e6e6f3bc1f
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Add default MANIFEST.MF Spec/Impl entries

We can auto-generate the following manifest entries:

Specification-Title: ODL :: odlparent :: bundles-test-lib
Specification-Version: 13.1
Specification-Vendor: OpenDaylight
Implementation-Title: ODL :: odlparent :: bundles-test-lib
Implementation-Version: 13.1.0-SNAPSHOT
Implementation-Vendor: OpenDaylight

Flip that particular switch on.

Change-Id: I85d8ed40a4d641e56afeef319dd5e3a6f58b1ca8
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Deprecate features-test

features-test is no longer used, as it is superseded by the maven
plugin. Deprecate it for removal.

JIRA: ODLPARENT-262
Change-Id: Ia4d1b2e6d3c0a73cf29be887338a9976ef71bcbd
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Bump commons-io to 2.16.0

https://commons.apache.org/proper/commons-io/changes-report.html#a2.16.0

Change-Id: I5500f0c5a6af81e02e65c9444fb4c15f6c60054e
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Bump checkstyle to 10.15.0

https://checkstyle.org/releasenotes.html#Release_10.15.0

Change-Id: I60f545f388c75edc3c1a59262c47e1be69a08ef0
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Bump maven-invoker-plugin to 3.6.1

https://github.com/apache/maven-invoker-plugin/releases/tag/maven-invoker-plugin-3.6.1

Change-Id: I040b6ccc64a3062ebe97e00dd4a150cf375f9b60
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Update news a bit

We have had two more patches, reflect that.

Change-Id: I2d7aa84350d3d719497d668eb6e3f49e0ba6376b
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Bump woodstox to 6.6.2

https://github.com/FasterXML/woodstox/milestone/34?closed=1

Change-Id: I4e56ae8ecc22df68146894959289a442833b35c4
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Bump maven-plugin-plugin to 3.11.0

https://github.com/apache/maven-plugin-tools/releases/tag/maven-plugin-tools-3.11.0

Change-Id: I9349c84e200d4777b86494350212eb1fc96c2f5f
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Sum up news for 13.1.0

There is quite a chunk of news, sum it up.

Change-Id: Ic457f022ba306bfbdb6c1fda146b506f3de06494
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Bump CheckStyle to 10.14.2

https://checkstyle.org/releasenotes.html#Release_10.14.2

Change-Id: I004d29e9280ff4cd84347faa2d3cba78590f48a1
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Bump maven-compiler-plugin to 3.13.0

https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12317225&version=12354079

Change-Id: I2de90b94ed7ca227a3e2b57ba6e127a9d96785f3
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Bump maven-assembly-plugin to 3.7.1

https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12317220&version=12354406

Change-Id: I58d2b089b4ecfeb8e8f7aa9d5bbcce2c4ef5c13e
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Bump cyclonedx-maven-plugin to 2.8.0

https://github.com/CycloneDX/cyclonedx-maven-plugin/releases/tag/cyclonedx-maven-plugin-2.8.0

Change-Id: Ia27c380ca682641a49233ae88c4352bd8a3a1352
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Bump git-commit-id-maven-plugin to 8.0.2

https://github.com/git-commit-id/git-commit-id-maven-plugin/releases/tag/v8.0.2

Change-Id: Iece4dda99846aa806c0b811e34d4ea8694cf3ff8
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Fix Jackson 2.16 packaging

Update feature description and patch pax-web to use Jackson 2.16.2
instead of 2.15.3.

Change-Id: I1db5224dc61c9b5bd21c4d25f50ea16d2c8dce46
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Bump awaitility to 4.2.1

https://github.com/awaitility/awaitility/blob/master/changelog.txt

Change-Id: I9ee1c8ced6851200e1af435a8282a54afeb48c17
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Bump pax-jdbc version to 1.5.7

Bump pax-jdbc from version 1.5.6 to 1.5.7
https://github.com/ops4j/org.ops4j.pax.jdbc/milestone/33?closed=1

JIRA: ODLPARENT-310
Change-Id: Iafcbc24ec727f97f73ef35c738c4eba8b5ed3baa
Signed-off-by: Peter Suna <peter.suna@pantheon.tech>

Bump Netty to 4.1.108.Final

https://netty.io/news/2024/03/21/4-1-108-Final.html

Change-Id: I61514e56b84c9b3db37dd52bc947bb239ccc042c
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Bump jersey to 2.42

https://github.com/eclipse-ee4j/jersey/releases/tag/2.42

Change-Id: Ideaa0dd1326623a142ad20f9f6e89e35a5046ef8
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Bump Jackson to 2.16.2

https://github.com/FasterXML/jackson/wiki/Jackson-Release-2.16
https://github.com/FasterXML/jackson/wiki/Jackson-Release-2.16.1
https://github.com/FasterXML/jackson/wiki/Jackson-Release-2.16.2

Change-Id: I5418038d26b36f401bec40e71fe86fe2c234ebc5
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Bump jdt-annotations to 2.3.0

This introduces lifecycle annotations:
https://github.com/eclipse-jdt/eclipse.jdt.core/pull/1716

Change-Id: I635e16c279fa5d2ea7751d0cbfac911426674d37
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Bump error_prone_annotations to 2.26.1

https://github.com/google/error-prone/releases/tag/v2.26.0
https://github.com/google/error-prone/releases/tag/v2.26.1

Change-Id: Ieffd38c861d0234967bd53a15a7a47ed9ba386c7
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Bump checkstyle to 10.14.1

https://checkstyle.org/releasenotes.html#Release_10.14.1

Change-Id: I52f47f6aa127129d514baf0c919a9b6aced5b92f
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Bump git-commit-id-maven-plugin to 8.0.1

https://github.com/git-commit-id/git-commit-id-maven-plugin/releases/tag/v8.0.1

Change-Id: Ida9e0a6c70509c6bcbd863ef95c6942fa0e81f26
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Bump maven-remote-resources-plugin to 3.2.0

https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12317825&version=12353591

Change-Id: I66091603faa893f400c696c3ddc4ede7f36032b3
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Bump maven-assembly-plugin to 3.7.0

https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12317220&version=12353243

Change-Id: I4fc805642c67e43b52a11a0750958fffd619cec0
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Update RTD configuration

ReadTheDocs build is failing due to missing OS declaration. Fix that and
modernize configuration.

Change-Id: I5791b300594cadb45c0fcd97581287b11dff85b7
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Bump git-commit-id-maven-plugin to 8.0.0

https://github.com/git-commit-id/git-commit-id-maven-plugin/releases/tag/v8.0.0

Change-Id: I76630264ac63ff19858712d4c53211e93e24c51f
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Fixup javadoc links

We have two problems:
- hamcrest is redirecting to https site
- guava docs are pointing to the wrong version
Fix both.

Change-Id: I0643368f167b08360860f024266a978e00de9ef6
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Revert "Adopt slf4j-2.0.12"

This reverts commit cf438d63b20c25ed153ea6c2898cdc6a014d9009. This would
end up leaking from all rebuilt artifacts, which is not appropriate for
a minor release bump.

Change-Id: Ie2248294807fd0dd2b751ae43569be13eb430cfd
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Adopt slf4j-2.0.12

This patch upgrades baseline SLF4J to 2.0.12:
https://www.slf4j.org/faq.html#changesInVersion200
https://www.slf4j.org/news.html#2.0.1
https://www.slf4j.org/news.html#2.0.2
https://www.slf4j.org/news.html#2.0.3
https://www.slf4j.org/news.html#2.0.4
https://www.slf4j.org/news.html#2.0.5
https://www.slf4j.org/news.html#2.0.6
https://www.slf4j.org/news.html#2.0.7
https://www.slf4j.org/news.html#2.0.8
https://www.slf4j.org/news.html#2.0.9
https://www.slf4j.org/news.html#2.0.10
https://www.slf4j.org/news.html#2.0.11
https://www.slf4j.org/news.html#2.0.12

The new baseline requires:
- logback-1.3.x, hence we adopt logback-1.3.14:
https://logback.qos.ch/news.html#1.3.0
https://logback.qos.ch/news.html#1.3.1
https://logback.qos.ch/news.html#1.3.2
https://logback.qos.ch/news.html#1.3.3
https://logback.qos.ch/news.html#1.3.4
https://logback.qos.ch/news.html#1.3.5
https://logback.qos.ch/news.html#1.3.6
https://logback.qos.ch/news.html#1.3.7
https://logback.qos.ch/news.html#1.3.8
https://logback.qos.ch/news.html#1.3.9
https://logback.qos.ch/news.html#1.3.10
https://logback.qos.ch/news.html#1.3.11
https://logback.qos.ch/news.html#1.3.12
https://logback.qos.ch/news.html#1.3.13
https://logback.qos.ch/news.html#1.3.14

- log4j-2.19.0+, hence we adopt log4j-2.23.0:
https://logging.apache.org/log4j/2.x/release-notes.html#release-notes-2-18-0
https://logging.apache.org/log4j/2.x/release-notes.html#release-notes-2-19-0
https://logging.apache.org/log4j/2.x/release-notes.html#release-notes-2-20-0
https://logging.apache.org/log4j/2.x/release-notes.html#release-notes-2-21-0
https://logging.apache.org/log4j/2.x/release-notes.html#release-notes-2-21-1
https://logging.apache.org/log4j/2.x/release-notes.html#release-notes-2-22-0
https://logging.apache.org/log4j/2.x/release-notes.html#release-notes-2-22-1
https://logging.apache.org/log4j/2.x/release-notes.html#release-notes-2-23-0

Change-Id: I7109f576256ca20d6e8281cf4ddfe70b6e2033e8
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Update maven-{deploy,install}-plugin to 3.1.1

There two plugin share expectations, so their major version needs to be
bumped at the same time.

maven-deploy-plugin:
https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12317228&version=12330476
https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12317228&version=12344166
https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12317228&version=12351654
https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12317228&version=12352181
https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12317228&version=12352894

maven-install-plugin:
https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12317524&version=12334343
https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12317524&version=12344165
https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12317524&version=12352096
https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12317524&version=12352107
https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12317524&version=12353026

Since single-feature-parent's mechanics results in what is considered an
incomplete project, https://issues.apache.org/jira/browse/MINSTALL-151,
set allowIncompleteProjects=true for those features. The same affects
feature-repo-parent.

Change-Id: I03b2019795f801e20913d30561b5ffbae0782047
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Fix dependency check for mockito-5.11.0

Previous upgrade missed the dependency check update, fix that.

Change-Id: Ie96bd0cddc556090a00c1e125636913b4f350cfb
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Fix another features-test-plugin reference

We should not be using project.version, as that actually is the version
of the feature being tested.

JIRA: ODLPARENT-262
Change-Id: Ic97d9f654ec13e19d2fa98d125838e7c51473c8d
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Clean up container stop logic

Introduce nested try/catch blocks, so that the we do not need an
AtomicBoolean to track whether the container has been started or not.

JIRA: ODLPARENT-262
Change-Id: I9807cfeacd4d4e57f9d4b376e592233d2de70aba
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Fix features-test-plugin reference

We should not be using project.version, as that actually is the version
of the feature being tested.

JIRA: ODLPARENT-262
Change-Id: Ia4e258ef47ac2bbd684436ca0d7d0908b43d7f99
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Use fair locks

When we are contended, we should try and execute tests on a first-come
first-serve basis.

JIRA: ODLPARENT-262
Change-Id: I68e45bb9d0f59130083c188c19617e1a91636234
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Use a static block in TestFeaturesMojo

We have a single-use method, use a static block instead.

JIRA: ODLPARENT-262
Change-Id: I48528311953de8bb9b9b1c8e8c27493bc3c38e63
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Access usingBundles only once

Cache the result of getUsingBundles() in a local variable, so we do not
access it twice.

JIRA: ODLPARENT-262
Change-Id: I895b5090783a018e5bbcb7adba0ac5cc672cf600
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Access ServiceReference bundle only once

Cache the result of getBundle(), as we will be needing it anyway.

JIRA: ODLPARENT-262
Change-Id: Ic3f12503ec2b81ac20165a9555900ff783e48a0e
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Package netty-codec-http2

Downstreams are interested in using HTTP/2, make sure we include the
corresponding codec.

Change-Id: I932d95a7158ff3e4e183882873decbb14e872fff
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Set spotbugs.fork to false

Do not fork a new JVM, as it wastes CPU cycles to start it up.

Change-Id: I44659518be833cd166417dad75561ce6f46ebcfd
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Migrate SFT from unit test to plugin implementation

JIRA: ODLPARENT-262
Change-Id: I47325fde0e5f3cc5395fe0ab9c948dbe440ae9ce
Signed-off-by: Ruslan Kashapov <ruslan.kashapov@pantheon.tech>

Fix warning message

We are testing everything up to and including Java 21, correct the
message.

Change-Id: I859585d700b51652c62ff3dbd04a17558123d8be
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Bump versions to 13.1.0-SNAPSHOT

This starts the next minor development iteration.

Change-Id: Ice5161c9d8c4e72559bc189136f5f7736efba082
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Bump versions 13.0.12-SNAPSHOT

This starts the next development iteration.

Change-Id: Ie17e6d96465c8b4292cc0e0ec2ca7f90501b9024
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Release odlparent

Expand features-test-plugin-it dependencies

We need odlparent-artifacts to be built before we attempt execution,
make sure they are a dependency.

Change-Id: Iee1ca1b64a3a941a0141fadd2fff2af5c1f19a37
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Fix features-test-plugin-it parent reference

The path is not pointing to the actual parent, fix that.

Change-Id: Ic4f1338df382a5edf12c58794b99f33e064012fd
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Update news for 13.0.11

Sum up the changes delivered in this iteration.

Change-Id: I2ae72402cea37955563a984f8894199d08309c61
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Bump Mockito to 5.11.0

https://github.com/mockito/mockito/releases/tag/v5.11.0

Change-Id: If109ab36cbe9918302fa40db34809d7063ce47a2
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>