Remove obsolete Maven Site configuration

Change-Id: Ia98ab43c4687b63f59c2fe39f247c3e58f71f47d
Signed-off-by: Thanh Ha <thanh.ha@linuxfoundation.org>

AlivenessMonitorUtils: wrap top-level in transactions

This uses transactions throughout based on top-level operations,
propagating the transaction through the call chain to ensure
consistent views of the MD-SAL.

Change-Id: Iae31775989102b1277a4e8a11a7f0633df21ae08
Signed-off-by: Stephen Kitt <skitt@redhat.com>

Remove MDSALDataStoreUtils

Since there are very few users left, remove the class entirely
(replacing it with SingleTransactionDataBroker).

This needs Ia012cc825a9eb7768de91c1882f76127d44c3595 to be merged
first.

Change-Id: I3c89e6549c7f2355583d6192d9134e9e589fbd39
Signed-off-by: Stephen Kitt <skitt@redhat.com>

NETVIRT-430 Ping responder on tenant network and FIP-FIP traffic between
vm in same n/w in same compute is not working in stateful SG mode.

Added Ct Clear action

Depends-on: Change-Id: I163ed99d5af8d3643749ac2a278f5c8170d7ae29
Change-Id: If86203e73a5ec516ff487f3f5c33fbd7dbfd12e1
Signed-off-by: Aswin Suryanarayanan <asuryana@redhat.com>

add requireNonNull to SingleTransactionDataBroker constructor

thought of this while seeing this which is actually broken:

  @Inject DataBroker dataBroker;
  S.T.D.B. db = new SingleTransactionDataBroker(dataBroker);

which cannot work with Dependency Injection (Guice or otherwise), and
it's better to have the null check here in the constructor already, not
fail with NPE later when one of the (non-static) methods of it is used.

see Change-Id: I63d0a93da481003b701c5a1843cece7d50cf51d1

Change-Id: I319d92c2bb50446ff59d156c4f261a51afe01863
Signed-off-by: Michael Vorburger <vorburger@redhat.com>

fix broken build; recent *Transaction change which removed commit()

The {@link ReadWriteTransaction#commit()} in JavaDoc lead to an "error:
reference not found" in maven-javadoc-plugin:3.0.0:jar (attach-javadocs)
@ mdsalutil-api during the build.

Change-Id: Ic489315ab050136f9de06a0331574aebb26e69c2
Signed-off-by: Michael Vorburger <vorburger@redhat.com>

Remove AlivenessMonitor::read

This can be entirely replaced by SingleTransactionDataBroker.

Change-Id: I8c302537f7abefafc1cf57c5e5c884a6b879c18f
Signed-off-by: Stephen Kitt <skitt@redhat.com>

Removed unused ACL constants

Ensured there are no references in netvirt for these constants.

Change-Id: I4372e2cd7733b469d0dee6f0ba0afc551eff0af5
Signed-off-by: Somashekar Byrappa <somashekar.b@altencalsoftlabs.com>

Add transaction variant of getChildInterfaces

In preparation for removing the current implementation of
IInterfaceManager::getChildInterfaces, this patch adds a variant
accepting a transaction (along with a few other related methods).

Change-Id: Idd93023de5b549c8ee7bed23fc3c485752d87548
Signed-off-by: Stephen Kitt <skitt@redhat.com>

increase max time out in AbstractTestableListenerTest from 50ms to 500ms

Change-Id: Ic45ad3bf911f81e030f7e425510a37fb2a54df0d
Signed-off-by: Michael Vorburger <vorburger@redhat.com>

Move tepsNotHosted from Config DS to Oper DS

As tepsNotHosted list was part of transport-zones container in itm.yang
and stored into config DS earlier. Since, it gets populated from
southbound only and will be available again on switch/ODL restart,
even if the switch goes away, we do not want to track these information
unnecessarily in the config DS. So, it is better to keep this data into
OperDS instead of config DS.

Change-Id: I731dfdb64ea3dc589567f4abeac3457ca0cbe395
Signed-off-by: Tarun Thakur <tarun.t@altencalsoftlabs.com>

Remove deprecated AsyncWriteTransaction#commit method

This method has been deprecated for quite some time and now has a
default implementation so can be safely removed from sub-classes.

Change-Id: I584c2e51ee1241b0198bcd310c2d2ca3d1b0f55a
Signed-off-by: Tom Pantelis <tompantelis@gmail.com>

deprecate IfmUtils' read() method

Change-Id: If1f5b547f9861f28066f3c490c2164b82c310536
Signed-off-by: Michael Vorburger <vorburger@redhat.com>

Use new Map methods

Map::computeIfAbsent models the common "initialise value collection
when missing and add to it" idiom.

Change-Id: I6e21374a8dc3fba0b4942c40d0ab1031d65b97f8
Signed-off-by: Stephen Kitt <skitt@redhat.com>

Use switch instead of chained ifs

Change-Id: I9d99d610abc7984e146b459a7fa3dcdd64425aa1
Signed-off-by: Stephen Kitt <skitt@redhat.com>

Add a model conversion method for InterfaceOpState

Change-Id: I984cb90ddd81e78bb346ece701de2ccf2de4edce
Signed-off-by: Stephen Kitt <skitt@redhat.com>

deprecate ItmUtils' async*() methods

Change-Id: I82e08e6a2a31a2dda014e69eebea1373ddc3e1a6
Signed-off-by: Michael Vorburger <vorburger@redhat.com>

Flow-based listeners: use top-level transactions

This changes the listener to use a single transaction for its
top-level operations.

Change-Id: I739ba6ce11b881331945d77ea2a9d7c3b2120206
Signed-off-by: Stephen Kitt <skitt@redhat.com>

Utils for itm performance enhancements

Change-Id: Id0400bd56473550ebc49d2968024632fcdf5b265
Signed-off-by: Edw7n <n.edwin.anthony@ericsson.com>

Re-enable interface-manager l2vlan component tests

Change-Id: I63d0a93da481003b701c5a1843cece7d50cf51d1
Signed-off-by: Faseela K <faseela.k@ericsson.com>

Make createVlanInterface APIs return ListenableFuture

Note : This will require a remerge in netvirt repo.

Change-Id: I91511a3b6e7aa6f4709c9ebb215c5ce5f4d49a55
Signed-off-by: Faseela K <faseela.k@ericsson.com>

yang changes for scaling,
to support corresponding netvirt changes

Change-Id: If29c11f61658a44f8b5614baddfe660782fb7c69
Signed-off-by: Edw7n <n.edwin.anthony@ericsson.com>

deprecate ItmUtils' read() and write() methods

Change-Id: I848145f71b3a3002898b34d26b9699514f14b684
Signed-off-by: Michael Vorburger <vorburger@redhat.com>

GENIUS-103: use a callback to start LLDP monitoring

This ensures that the transaction is *processed* before we start LLDP
monitoring.

Change-Id: I61abc7e1d03321fd94c86fbe311aed2a2e3951ca
Signed-off-by: Stephen Kitt <skitt@redhat.com>

Fix ITM UT failures

Yangtools has changed how IPAddresses are converted
to string. ITM code is using different methods to
convert String IPs to IpAddress. Fix is to use
IpAddressBuilder, which is v4/v6 anogstic, at all
places.

Change-Id: I49649152a2f97b8b1cbdc19a3bb35fd0791ff2a8
Signed-off-by: Vishal Thapar <vishal.thapar@ericsson.com>

Use Map::forEach instead of streaming maps

Change-Id: I3419d9767571ecc2ed078c0dee010fb512523938
Signed-off-by: Stephen Kitt <skitt@redhat.com>

add real Lifecycle management to DataObjectCache

by throwing an IllegalStateException if you get() or getAllPresent()
after close(), to prevent it from being used after it's closed, as was
attempted in Change-Id: I8d5f15757a805798f16b98b79b3ad03899b1130d (which
would lead to quite weird behaviour)

Change-Id: Id3a21afe5f297bebe15fc94bcd1fb24178bc334a
Signed-off-by: Michael Vorburger <vorburger@redhat.com>

minor JavaDoc fix to ManagedNewTransactionRunner

It should not @link to a (now) only package local class.

Change-Id: I444cb537be04401740793724d41e7e1b1736c441
Signed-off-by: Michael Vorburger <vorburger@redhat.com>

Service-Recovery: support for elan-interface entity type
instead of elan-instance entity type

Change-Id: I723bd2ac707bf8b34d869b9b7abfdea4b616c47a
Signed-off-by: eswanit <swati.udhavrao.niture@ericsson.com>

Remove redundant type information

Change-Id: Ic03751095df7ff7a01dc112d7f397df94fc09096
Signed-off-by: Stephen Kitt <skitt@redhat.com>

Clean up lambdas

Use method references and lambda expressions where appropriate.

Change-Id: Id329f3a6abc9d23678e6b5e4ce554778fc590c00
Signed-off-by: Stephen Kitt <skitt@redhat.com>

Service Recovery Manager for ITM

Change-Id: I5dab695d7c397606728c46f19c4f2e2e38dfef42
Signed-off-by: Nidhi Adhvaryu <nidhi.adhvaryu@ericsson.com>

Caches for newly introduced immutables in ITM

Change-Id: I8d5f15757a805798f16b98b79b3ad03899b1130d
Signed-off-by: Edw7n <n.edwin.anthony@ericsson.com>
Signed-off-by: Tom Pantelis <tompantelis@gmail.com>

enforce correct logging via findbugs-slf4j (GENIUS-118)

Modified genius/commons/binding-parent/pom.xml
to enable findbugs-slf4j enforcement in binding-parent.

This ensures we won’t have any regressions in log handling in modules
based on binding-parent.

Change-Id: I7030f32c3c5f16afb6ed7cd5e8c8ff96ca4865a2
Signed-off-by: Saurav Malani <sauravmalani1@gmail.com>
Signed-off-by: Faseela K <faseela.k@ericsson.com>
Signed-off-by: Michael Vorburger <vorburger@redhat.com>

Fix ItmAlarm Exception in logs

This is a regression caused by :

https://git.opendaylight.org/gerrit/#/c/67658/

Change-Id: I16b58dc3a08bb012dd4d9366a77a9e4bf9ef064b
Signed-off-by: Faseela K <faseela.k@ericsson.com>

Fix logging issues in ITM

Change-Id: Ie2d697ce8026f3b75022ac7150457dde9f486582
Signed-off-by: sathwik boggarapu <b.sathwik@ericsson.com>

Fix logging issues in InterfaceManager

Change-Id: Ib77840b84f6190be7537c4a6f6f32d317cf89414
Signed-off-by: sathwik boggarapu <b.sathwik@ericsson.com>

Migrate ItmTunnelEventListener to use new listeners fw

Some additional changes:

- Make some variables final
- Remove dead code
- Make some methods private

Change-Id: I2679bb74ef1aafa775ab23cb1577a6c770f617fe
Signed-off-by: David Suarez <david.suarez.fuentes@gmail.com>

GENIUS-102: interface manager: use transaction manager

Use the transaction manager to manage all write transactions.

Change-Id: If224c5193e4e9f4c12ebcaa1c31864646aafd026
Signed-off-by: Stephen Kitt <skitt@redhat.com>

Use List::sort instead of Collections::sort

Change-Id: Ia9949460dd3e09b00cabd887a70386e42370734c
Signed-off-by: Stephen Kitt <skitt@redhat.com>

Extend DataObjectCache to allow for custom key

Users want to be able to provide a custom key derived from the
DataObject instead of keying by InstanceIdentifier.

Change-Id: I5f55068ff56390998270c2813d2682763479a404
Signed-off-by: Tom Pantelis <tompantelis@gmail.com>

Fix abstract listeners

The deprecated method are now properly implemented in the base class

Change-Id: Ieab4e8e4537400a7a1d27ca85a1bee4a812c79b8
Signed-off-by: David Suarez <david.suarez.fuentes@gmail.com>

Fix logging issues in alivenessmonitor

Change-Id: I730efda2afc6ffbeed547737e47c980ae418ccd5
Signed-off-by: sathwik boggarapu <b.sathwik@ericsson.com>

Make recoverableListenerMap maintain a queue of recoverableListeners.

This was a review comment from Michael which was not addressed on the
original patch

Change-Id: I14b7d9f4a92a4439cae40b4c4b23b7972f5468b4
Signed-off-by: Faseela K <faseela.k@ericsson.com>

Fix logging issues in SRM

Change-Id: I89a5ff35903202d549a91a510f323856d78b1542
Signed-off-by: sathwik boggarapu <b.sathwik@ericsson.com>

Fix logging issues in fcapsapplication

Change-Id: I4aa3358a1c4774f6eea83b7c8b7d2805d5565f5b
Signed-off-by: sathwik boggarapu <b.sathwik@ericsson.com>

Fixed issue when null is passed in CLI cmds

Due to the karaf migration, the tep CLIs were not working as expected when
null is passed as arguments in CLI cmds.

Change-Id: I4b493c1615846651717ac345b7eaf51551b80abe
Signed-off-by: Hema Gopalakrishnan <hema.gopalkrishnan@ericsson.com>

fix logging issues in mdsalutil

Change-Id: If22e310b05d927b61d3829c7a8e7188727348afd
Signed-off-by: Faseela K <faseela.k@ericsson.com>

Add InstanceIdentifier to method add/update/remove in Genius' listeners

Some use cases require the Genius' listeners to provide the
InstanceIdentifier as a parameter in add, update and remove methods.

The change is made on the DataTreeChangeListenerActions interface by
making the new methods the default ones. The current methods are
deprecated and they will be removed once all the current implementations
are converted.

The AbstractDataTreeChangeListener will implement the old methods until
the migration to the new ones finishes.

Change-Id: I979e5f3e2480f441828f2ee87e917543df6504b0
Signed-off-by: David Suarez <david.suarez.fuentes@gmail.com>

Re-enable bindings of interfacemanager junits

Change-Id: I6618539c8349ad1fd3e83959377eb08ea8a597e6
Signed-off-by: Faseela K <faseela.k@ericsson.com>

Remove unnecessary boxing/unboxing

Change-Id: I06fee32b08066e3b1d95b7c2ca0220cef9800ab1
Signed-off-by: Stephen Kitt <skitt@redhat.com>

Revert "GENIUS-116: Efficient Handling of DPN disconnect"

This reverts commit 3cf5a4776c2b8dcd77049ecb3ba4e1b28bc1aa4c.

Change-Id: I7a377a9b4cd74fe9052843882e7b730a63cb0036
Signed-off-by: Faseela K <faseela.k@ericsson.com>
Signed-off-by: Sam Hague <shague@redhat.com>

simplify TestableJobCoordinatorEventsWaiter

Change-Id: Ic9e5ab1e695e296d983b5ed3783e40c0373b6189
Signed-off-by: Michael Vorburger <vorburger@redhat.com>

LockManager test failure

Looks like underlying error message has changed. After changing the
expected error message accordingly, test is passing.

Change-Id: I46829aa23c353c3c7a7de9968d54462f8d0ba7ba
Signed-off-by: Ankit <ankit.j.jain@ericsson.com>

fix ItmManagerRpcServiceTest ExternalTunnelBuilder destinationDevice

but ... the fact that this destinationDevice is a "String typed" instead
of "strongly typed" (a real YANG model) seems really wrong, to me.

Change-Id: Ibfab110a7488c3dfd1a8cecd3cace773c55bc277
Signed-off-by: Michael Vorburger <vorburger@redhat.com>

Updating rst doc, how to run CSIT

Change-Id: I285bd34e687945801f1b1443d523a6c3b3908915
Signed-off-by: sathwik boggarapu <b.sathwik@ericsson.com>

JobCoordinatorEventsWaiter to wait for specific job count completion

Change-Id: I88fb852a5bae667716044b61f4689f9fe258a151
Signed-off-by: Faseela K <faseela.k@ericsson.com>

Immutables for performance enhancements

Change-Id: I150d8edc58ad91724679dba15a1f269bd9e2e674
Depends-on: I250b75fea3ae29e8adb351693e7eeb0a596e18fe
Signed-off-by: Edw7n <n.edwin.anthony@ericsson.com>

Add InstanceIdDataObjectCache

DataObjectCache will be extended to allow for custom key so
add implementation that keys by InstanceIdentifier.

Change-Id: I16450c794512afde8d1091dc88f43a43ef8639b5
Signed-off-by: Tom Pantelis <tompantelis@gmail.com>

Bug: GENIUS-115 OVS Nodes Connect Quickly, Not All Get TransportZone TEPs

1) In ItemTepAddWorker do NOT use cached DPNTEPsInfos, read from DS instead
2) In ItmInternalTunnelAddWorker do not queue the new DPNTEPsInfos via
ITMBatchingUtils, instead write synchronously and unbatched in that thread

Change-Id: I91be9de8e7d098fbe94abc480605f460dfecef79
Signed-off-by: Josh <jhershbe@redhat.com>

Issues with SRM service recovery

service recovery logic was doing a close of the already registred
listeners. However the close method of the AsyncListener base classes
were shutting down the dataTreeChangeHandlerExecutor as well, which
will cause issues when we again register the listeners.

Change-Id: I2e39c9ba0226c298fbd10f114ad33be39ae961a0
Signed-off-by: Faseela K <faseela.k@ericsson.com>

ifm changes for itm performance enhancements

Change-Id: I250b75fea3ae29e8adb351693e7eeb0a596e18fe
Signed-off-by: Edw7n <n.edwin.anthony@ericsson.com>

add JavaDoc to DataTreeEventCallbackRegistrar onAddOrUpdate

in order to clarify null-ness expectation of the used BiFunction

also an appropriate @Nullable (has to be org.eclipse.jdt.annotation,
cannot be javax.annotation, because that is not a type annotation
suitable for annotating generics)

Change-Id: I73e0fc8a8313de1d51e99612d61631343f5a878c
Signed-off-by: Michael Vorburger <vorburger@redhat.com>

Add HwvtepNodeHACache interface

This is the first in a series of patches to eliminate the
static HwvtepHACache. Added an HwvtepNodeHACache interface
which HwvtepHACache temporarily implements until netvirt
is migrated to use HwvtepNodeHACache in the next patch.
The static HwvtepHACache instance is also temporarily
advertised as the HwvtepNodeHACache service.

Change-Id: I67154a0bfa21655d1158ba81b472e6501ac1ce76
Signed-off-by: Tom Pantelis <tompantelis@gmail.com>

Minor simplification in DataTreeEventCallbackRegistrarTest

the point of the testAddOrUpdateAdd(), contrary to the
testAddOrUpdateUpdate(), is that the listener will only get call once
(for the add); this change makes that more obvious when reading the
test.  It still passes.

Change-Id: I9656b7f66f023689be56af1aa24877749b611061
Signed-off-by: Michael Vorburger <vorburger@redhat.com>

Fix ActionNxConntrack.NxNat problems with xtendbeans (with a test)

Change-Id: I488c124c15e3cb8fc6c6952520893c6eabc1190a
Signed-off-by: Michael Vorburger <vorburger@redhat.com>

Fix ActionNxConntrack.NxCtMark problem with xtendbeans (with a test)

Change-Id: I0bb0d42226adbccd32775353da326a680bb4e238
Signed-off-by: Michael Vorburger <vorburger@redhat.com>

Flourine idmanager build failures

sal-common-testutil has been removed from controller,
as the relevant modules have moved to mdsal

Change-Id: Ib8ff40bed63b6a890507c93ea205f20a728527ca
Signed-off-by: Faseela K <faseela.k@ericsson.com>

Remove sal-common-testutil dependency

This was previously used for EOS Tests, but since eos
has moved to mdsal repo, this is no longer needed.

Change-Id: Ibd8a7f70513ee428da35276edd7b17ec597f3455
Signed-off-by: Faseela K <faseela.k@ericsson.com>

Service-Recovery: Support needed for ACL feature introduced in SRM
framework.

(a) srm-types.yang updated with 'netvirt-acl', 'netvirt-acl-interface' and
'netvirt-acl-instance' definitions to support ACL service and instance
recovery operations. 'netvirt-acl-interface' and
'netvirt-acl-instance' are the two instance recovery options supported.
(b) SrmRpcUtils.java and SrmCliUtils.java updated to add required ACL definitions
to the internal maps maintained to support recovery operations.

Change-Id: I4c91cd52e7595b92b494356dfa715dbdf15da3c5
Signed-off-by: Shashidhar Raja <shashidharr@altencalsoftlabs.com>

Genius Specific Changes to support QoS with SRM

Adding QOS option as recoverable service & Qos policy as recoverable
instance.

Change-Id: I0e123bec31f663d8b6673b37c5858fbcc85b8b46
Signed-off-by: Naveen Kumar Verma <naveen.kumar.verma@ericsson.com>

Enable findbugs in commons binding-parent

Change-Id: I6b5f9341e564487e4f29a817e3e1471afa461730
Signed-off-by: Tom Pantelis <tompantelis@gmail.com>

Fix findbugs violations in fcapsapplication

- Inconsistent synchronization
- Write to static field from instance method

Change-Id: I5b15553a4ced6d7ebdf7a57bdfc7590c3c221ba2
Signed-off-by: Tom Pantelis <tompantelis@gmail.com>

Fix findbugs violations in resourcemanager-impl

- Method ignores return value
- Incorrect lazy initialization of static field
- Dead store to local variable

Change-Id: I03b7a719b596af38f89db25ff0fc6547ec676bac
Signed-off-by: Tom Pantelis <tompantelis@gmail.com>

Fix findbugs violations in itm-impl

- Method ignores return value
- Dead store of class literal
- Null pointer dereference
- No relationship between generic parameter and method argument
- Invocation of toString on an array
- Reliance on default encoding
- Field should be package protected
- Inconsistent synchronization
- Inefficient use of keySet iterator instead of entrySet iterator
- Method checks to see if result of String.indexOf is positive
- Dead store to local variable
- Write to static field from instance method
- Load of known null value
- Class implements same interface as superclass
- Redundant nullcheck of value known to be non-null
- Exception is caught when Exception is not thrown
- Useless object created
- Useless control flow

Change-Id: Id0dc47011e6c2ec9f11d2876fd8fe77b63a687ec
Signed-off-by: Tom Pantelis <tompantelis@gmail.com>

SRM refactoring

Realized that some code that went in interface-manager for service
recovery can be reused across modules, and hence moving some of those
common utilities to srm.

Change-Id: I65dbb9b27bddbe11f7ca4a30a3a27838eef8cefc
Signed-off-by: Faseela K <faseela.k@ericsson.com>

GENIUS-116: Efficient Handling of DPN disconnect

Dependent on OF plugin patch https://git.opendaylight.org/gerrit/#/c/63261/

The changes in openflowplugin includes, port removal event will come with proper
reason flag set which will enable interface-manager to distinguish between a port
removal and a "port removal due to node removal" from the info in
the incoming event itself.

Change-Id: I39c5cdc6f57052521cb0061ca97ab7518637a5fe
Signed-off-by: SujaT <suja.t@ericsson.com>

Fix findbugs violations in srm-shell

- Format string should use %n rather than \n
- Consider using Locale parameterized version of invoked method

Change-Id: Id3be0c9b70c104ec0a2214e28b347add451c873a
Signed-off-by: Tom Pantelis <tompantelis@gmail.com>

DataTreeEventCallbackRegistrar: "add or update" param order

Since functions receiving add or update events need to
handle updates they have two params. As such, in event
of an add the created object should be the second
param passed to the function.

Change-Id: If27121aa8af74038f775edca118bce4917dd2e51
Signed-off-by: Josh <jhershbe@redhat.com>

add new DataTreeEventCallbackRegistrarTest

this requires infrautils' I0d54b187fd58c6456708518a3886c3aedff3f86a

Change-Id: Iee7227d63c4ab995dae1642f6da3cd1c8f4bd91e
Signed-off-by: Michael Vorburger <vorburger@redhat.com>

Bump versions by x.(y+1).z for next dev cycle

Change-Id: I87a5d8d5d22dc66190d3af950bd6f802004fc3cf
Signed-off-by: Anil Belur <abelur@linuxfoundation.org>

Fix for GENIUS-112.

This is a race condition, proper fix should remove Batching manager from add callback.

Change-Id: Ia9de21864e82b2c8ded1ea121de615cafa6dab19
Signed-off-by: Nobin Mathew <nobin.mathew@ericsson.com>

Update genius ITM Tunnel auto config spec

The TEP-IP is now obtained from other_config:local_ip,
so update the spec to reflect that change.

Change-Id: I47d04acb4897cd4c8c5e0a952a08a65dc7e36259
Signed-off-by: Victor Pickard <vpickard@redhat.com>

Revert "ifm changes for performance enhancements"

This reverts commit 51d5fab28b9fbd2c165bd0c803ad768441385d0f as discussed on the TSC mailing list: https://lists.opendaylight.org/pipermail/tsc/2018-February/008919.html

Change-Id: Icc95f983591f9c8c871dd14c1266642cba4eb9bb
Signed-off-by: Stephen Kitt <skitt@redhat.com>

ifm changes for performance enhancements

Change-Id: Icdceb46e6453b6b1e503d14d89bd1b201f9a183b
Signed-off-by: Edw7n <n.edwin.anthony@ericsson.com>

NETVIRT-1068: Upstreaming fixes 3

When ARP response is received for the learnt IPs like MIP, its not
processed due to wrong check of table-id. Hence this check is removed. One
more bug was SrcIp and DestIP had junk chars which led formation of wrong
MonitoringKey. Due to this , MIP IP Arp Response was not processed.

Change-Id: If25bbc6fdc264ac866b5cd89c247c487d9f6ca6b
Signed-off-by: HANAMANTAGOUD V Kandagal <hanamantagoud.v.kandagal@ericsson.com>

NETVIRT-1009 - Enable genius auto-tz

https://jira.opendaylight.org/browse/NETVIRT-1009

Enable genius auto tunnels. There will be a separate
patch to disable netvirt dynamic tunnels.

https://git.opendaylight.org/gerrit/#/c/66109/1

This will be the default starting in oxygen.
Carbon and nitrogen will continue to have netvirt
dynamic tunnels as the default.

Change-Id: I9b9bb5d47618b7988bcc61bcadf44a746b6a9452
Signed-off-by: Victor Pickard <vpickard@redhat.com>

InterfaceManager Service Recovery

Adding recovery support for interface-manager.
Two types of recovery are supported:

1. Service Level Recovery - This triggers deregistration and
registration of all external facing listeners

2. Interface Instance Level Recovery - This triggeres a delete and
create of a particular interface configuration so that the state can
be fully reconstructed

Change-Id: I9b8ee67730d0ce7e07ef8f70e7d9e22b35b67c63
Signed-off-by: Faseela K <faseela.k@ericsson.com>

Remove FlowBasedServicesInterfaceStateListener

Now that all applications are properly calling unbind-service,
the interfacestatelistener which by itself tries to remove
dispatcher table entries can be removed for a cleaner implementation

Change-Id: Ic37f45d8c923e8a8f8800d331c3666f50bd7a9bd
Signed-off-by: Faseela K <faseela.k@ericsson.com>

Migrating IFM PM counters to infrautils counters

Existing IFM PM counters were using JMX MBeans,
now new counters are written for IFM PM counters using
infrautils metrics counter APIs which will be common library
to populate JMX MBeans for these counters by leveraging
Codahale framework.

Change-Id: I3a0f87ec3f60a207a56ec29eef5b28a22e3fd0c3
Signed-off-by: Tarun Thakur <tarun.t@altencalsoftlabs.com>

ItmRpcTestImpl throw UnsupportedOperationException instead return null

Change-Id: I60138084a79bb2827cf363920506da5d44c29ad5
Signed-off-by: Michael Vorburger <vorburger@redhat.com>

Fix more build failure due to openflowplugin lldp attribute name changes

Change-Id: I0848efef3982ecd34e9715a375d008ffac607a36
Signed-off-by: Michael Vorburger <vorburger@redhat.com>

Migrate VtepConfigSchemaListener to use new listeners fw

Additional changes:

- Remove useless JavaDoc
- Remove IllegalCatchs

Change-Id: I0b87599af95b95920d2bea157917889c06327861
Signed-off-by: David Suarez <david.suarez.fuentes@gmail.com>

Migrating FCAPSApplication PM Counters to Infrautils Counters

Change-Id: I2a4edeeb9deb72de15b8e4b75adf225843c4ddfb
Signed-off-by: Ankit <ank123it@gmail.com>

Migrate HwVtepTunnelsStateHandler to use new listeners fw

Change-Id: I67ff8c833c13bbc8f8b6c61154309c61cac52b70
Signed-off-by: David Suarez <david.suarez.fuentes@gmail.com>

Build failures due to openflowplugin lldp attribute name changes

Change-Id: I9b06553ce1a0fcae7266492ea8fe176072d87874
Signed-off-by: Faseela K <faseela.k@ericsson.com>
Signed-off-by: Michael Vorburger <vorburger@redhat.com>

use feature for inter-project dependency

Use feature to express inter-project dependency correctly instead of
bundle.

For details, refer to
https://lists.opendaylight.org/pipermail/release/2018-January/013604.html
https://lists.opendaylight.org/pipermail/release/2017-September/012356.html

This depends on below patches to export necessary bundle as feature.
https://git.opendaylight.org/gerrit/#/c/68214/
https://git.opendaylight.org/gerrit/#/c/68233/

Change-Id: If3188ac2afaaa10d000969341e0f788c45c8bd2b
Signed-off-by: Faseela K <faseela.k@ericsson.com>

NETVIRT-1066: Scale 150 DPN

Iterating through non-L2VLAN interfaces in L3VPN Tunnel
Interface State listener is unnecessary
For scaling to 150DPN , each TunnelIntfState add event causes a read of
list of interfaces on the given DPN.This list includes even non L2Vlan
type interfaces like tunnel-port etc. By ignoring these ports , read of
operational vpn-interface is avoided.

Change-Id: I3e658eb8eb78d39dc9ed0a7fc1750ce55ae6a7ec
Signed-off-by: HANAMANTAGOUD V Kandagal <hanamantagoud.v.kandagal@ericsson.com>
Signed-off-by: Sam Hague <shague@redhat.com>

remove wrong @Inject from DataStoreMetrics (and very minor clean up)

because instances of DataStoreMetrics are created explicitly via new by
the listeners in package org.opendaylight.genius.datastoreutils, but
never by Blueprint XML or annotations, the @Inject here is not needed,
and could be confusing to humans and tools in the future (and we could
never @Inject Class<?> anyway).

Change-Id: Ia361a59f468f4fb77d30610b02882b354c66b847
Signed-off-by: Michael Vorburger <vorburger@redhat.com>

GENIUS-109: write interface state correctly

we need to provide the mandatory statistics.

Change-Id: I246a456ba8a8e767cd84e70b83dc985696c24c1d
Signed-off-by: Stephen Kitt <skitt@redhat.com>