Rpc manager not needed to instantiate DeviceManager

Change-Id: I0dc1584fb825d270c7ce18626e58724646652fe0
Signed-off-by: Martin Bobak <mbobak@cisco.com>

request context hookin java doc

Change-Id: I3033364ecf0b6f0d1046fa1144852b63b55c8e26
Signed-off-by: Martin Bobak <mbobak@cisco.com>

request context is hoooked to device context by OFJResult2RequestCtxFuture

Change-Id: I62bed2ddea7f6a2a46db65e14641f99bb65621a7
Signed-off-by: Martin Bobak <mbobak@cisco.com>

RpcResultConvertor renamed to OFJResult2RequestCtxFuture

- everytime OFJava result has to be processed and its
  future translated to request context's future it always should
  be done by OFJResult2RequestCtxFuture.

Change-Id: I0bc201f6cd0f3ca8e67dc7acc52c36c2e994bddd
Signed-off-by: Martin Bobak <mbobak@cisco.com>

multipart messge collector doesn't create own future

- future from OFJava is handled by RpcResultConvertor
- simplified multipart calls in DeviceManagerImpl#deviceConnected

Change-Id: I7f1b60808b2397c073ed0d971cb0301b9a95031b
Signed-off-by: Martin Bobak <mbobak@cisco.com>

Merge "add counter enable to TransactionChainManager"

add counter enable to TransactionChainManager

Note: TransactionChainManger has counter for an automatic submit
action, but we don't wish to submit anything before DeviceContext
are finally wired.

Change-Id: I58774b4d001eda32c9eac5e253f6220464a9422a
Signed-off-by: Vaclav Demcak <vdemcak@cisco.com>

Merge "Clean wiring inital phase for new Device"

Merge "Bug 2945: Fix read failures in StatAbstractListenCommit"

Clean wiring inital phase for new Device

* add new Interface for clean wiring of Managers
DeviceInitializator
* add new Interface for inital phase chain
DeviceInitializationPhaseHandler

Change-Id: Iac633927c1f4fe661dfa6a1e4720bcfabf6b8a42
Signed-off-by: Vaclav Demcak <vdemcak@cisco.com>

fixed portstatus  translator key

Change-Id: I408be51976e0628e74e37c656842770785766904
Signed-off-by: Martin Bobak <mbobak@cisco.com>

starting switch connections on OFPProvider initialization

Change-Id: I7d0053eb1a99f31aca733084557d24190e7edefd
Signed-off-by: Martin Bobak <mbobak@cisco.com>

setting defualt translator libraries extracted to util class

Change-Id: I1c12ccf69304450c04004b51d867cb01d4ee637f
Signed-off-by: Martin Bobak <mbobak@cisco.com>

Introduced translator librarian

Change-Id: I69e39929eb2397e55cd7840e865e07f069617a79
Signed-off-by: Martin Bobak <mbobak@cisco.com>

don't be shy and let device context know, we have translator libraries

Change-Id: I7fae7dea5a77ad269aee828b5da826d6db9edccf
Signed-off-by: Martin Bobak <mbobak@cisco.com>

Merge "introduced TraslatorKeyFactory for registering translators in OFPProvider"

Merge "Wiring message processing to deviceContext"

introduced TraslatorKeyFactory for registering translators in OFPProvider

Change-Id: Iba254c7f9b47200752d77243d475bbb73217754f
Signed-off-by: Martin Bobak <mbobak@cisco.com>

Wiring message processing to deviceContext

Change-Id: I383e10eec16b19ad322849147b79ca88912c06ea
Signed-off-by: Vaclav Demcak <vdemcak@cisco.com>

introducing TranslatorLibraryBuilder

Change-Id: I0b5f49dff5c589bc12a8bc9b60dc3bd367cc13e9
Signed-off-by: Martin Bobak <mbobak@cisco.com>

TranslatorLibrary moved to translator package

Change-Id: I94a5120047217aeb7748dd98bfc29332e7c3c1d6
Signed-off-by: Martin Bobak <mbobak@cisco.com>

translator package moved

Change-Id: I440902d624750e9e3cd461cee29012e08383fa0f
Signed-off-by: Martin Bobak <mbobak@cisco.com>

Bug 2945: Fix read failures in StatAbstractListenCommit

Added a volatile currentReadTxStale flag which onDataChanged sets instead of
closing the currentReadTx. readLatestConfiguration checks the
currentReadTxStale flag and, if set, closes the currentReadTx and
creates a new one. This prevents onDataChanged from closing the Tx when
a read is in-flight.

Added a unit test class StatAbstractListenCommitTest with test cases for
the methods that were changed.

I also changed StatListenCommitFlow#initConfigFlows to create an
ArrayList when copying the Flow List as Linkedist incurs more memory
overhead.

Change-Id: I42e5b5d55eeddd62b0ffb002d35d07b664c91861
Signed-off-by: Tom Pantelis <tpanteli@brocade.com>

Fix bugs from first run

* fix NPE
* fix TableFeatures

Change-Id: I7e48965125346030ea535546863651f8a7f4e4d8
Signed-off-by: Vaclav Demcak <vdemcak@cisco.com>

processing multipart data in statistics context

Change-Id: I326d765eb4cc1c914fdbf57332a3b63347f1d89a
Signed-off-by: Martin Bobak <mbobak@cisco.com>

added purpose multipart message translator

- this class is created as deprecated since it has to be replaced
  by single translators. No time for that right now.

Change-Id: I3bb30f0c68f8f60cb41bf542ab0cf368607307b0
Signed-off-by: Martin Bobak <mbobak@cisco.com>

statistics context implements dedicated services

Change-Id: I4e018b13d1240fc78179ae606782bdc90994ed5b
Signed-off-by: Martin Bobak <mbobak@cisco.com>

statistics context implements statistic services calls

Change-Id: Ifcda7a4e41369cbe0077e36f80354ceb339a6e13
Signed-off-by: Martin Bobak <mbobak@cisco.com>
Signed-off-by: Vaclav Demcak <vdemcak@cisco.com>

added event handlers registration to OFPProvider

Change-Id: Ic2548af5cad969348ddd48bfd8401d9a1e96f1d7
Signed-off-by: Martin Bobak <mbobak@cisco.com>
Signed-off-by: Vaclav Demcak <vdemcak@cisco.com>

statistics manager initial commit

Change-Id: Ie032cb86c271e80684053cf8e192902fdf245d9a
Signed-off-by: Martin Bobak <mbobak@cisco.com>
Signed-off-by: Vaclav Demcak <vdemcak@cisco.com>

added switch connection providers starting

 - involved netty startup upon sessionInitialized
 - small fixes

Change-Id: I6b03d5fe4d956619f414d77227c163159b611611
Signed-off-by: Jozef Gloncak <jgloncak@cisco.com>
Signed-off-by: Vaclav Demcak <vdemcak@cisco.com>

Merge "Time scheduler for transaction submit in DeviceContextImpl"

Time scheduler for transaction submit in DeviceContextImpl

Note: TransactionManager could submit transaction after specified
nr. of write action but we are missing a time scheduler for "submit"
after some time scenario. So we add a HashedWheelTimer for fix this
scenario.

* HashedWheelTimer implementation

Change-Id: If937e8700a8e83bc3d5ddac87975f14df46db122
Signed-off-by: Vaclav Demcak <vdemcak@cisco.com>

extended SatisticsManager API

Change-Id: If34bf8887209882d5a9c26de3fc0a243ee4593ec
Signed-off-by: Martin Bobak <mbobak@cisco.com>

Wiring DeviceManagerImpl and RpcManager together

Node: We wana to have only one instance of RpcManager
and it has to be an input param. for DeviceManagerImpl.

Change-Id: I347d5133e81efae6610444eaec3bb062548df1d4
Signed-off-by: Vaclav Demcak <vdemcak@cisco.com>

XidGenerator hidden inside DeviceContext

Change-Id: I2a7af338bd889065fef9b8940d04163ad8fe7aa0
Signed-off-by: Martin Bobak <mbobak@cisco.com>
Signed-off-by: Vaclav Demcak <vdemcak@cisco.com>

DeviceTransactionChainManager

Note: DeviceTransactionChainManager is a package protected class
for controlling DS WriteTransaction life cycle. It implements
TransactionChainListener and provides sync methods for write
DataObject to DS (wrapper of WriteTransaction.put method) and
submit transaction (wrapper of WriteTransaction.submit method)

* DeviceTransactionChainManager
* change DeviceContext
* change DeviceManager

TODOs:
* Test suite

Change-Id: I6942c6f590f6c311e9acc50debfcb6c6f1c95d21
Signed-off-by: Vaclav Demcak <vdemcak@cisco.com>

DevideManagerImpl

* add ProviderContext to DeviceManager constructor + fix referenced code
* implement DeviceManager#deviceConnected
* aug TableFeatures

TODO: add test suite

Change-Id: I736b3b26c3aa1f685a27bd226a6d67d6bffa8b8a
Signed-off-by: Vaclav Demcak <vdemcak@cisco.com>

NodeStaticReplyTranslatorUtil

Note: Util translator class populate MD-SAL inventory models from
OF java MultipartReply models. All methods are used in post handshake
process only. So we are calling it Static.

* NodeStaticREplyTranslatorUtil
* TODO test class

Change-Id: I20f155783ca11c5e444a863f2ff5ff6d767b248b
Signed-off-by: Vaclav Demcak <vdemcak@cisco.com>

MultiMsgCollector - add register method for xid and future

Note: we are missing method for statistics which are able to
add exist future to cache with xid key.

Change-Id: I4fdff80a1c9d0881db0dddda70a0903f085bc387
Signed-off-by: Vaclav Demcak <vdemcak@cisco.com>

NodeConnectorTranslatorUtil

Note: we need direct translation from OFJava models to
Invenotry models from PhyPort to FlowCapableNodeConnector.

* NodeConnectorTranslatorUtil
* NodeConnectorTranslatorUtilTest

Change-Id: Ibdd9293bd473b280aabdd4201aec65673ec0fa19
Signed-off-by: Vaclav Demcak <vdemcak@cisco.com>

Merge "Implementation of PacketProcessingService"

Merge "Change type parameter from <T extends DataObject> to <T>"

Handling async replies from device in DeviceCtx

- introduced simple test for PacketReceivedTranslator
- fixed asterix in inports

Change-Id: I172d7b2db82a552140e5fd3822d080df9cbb97f9
Signed-off-by: Timotej Kubas <tkubas@cisco.com>

Implementation of PacketProcessingService

Change-Id: I3293e04e2a947cf3c62edb444d457f78aa6606bf
Signed-off-by: Jozef Gloncak <jgloncak@cisco.com>

Change type parameter from <T extends DataObject> to <T>

Every service handler is returning type which is subtype of
DataObject expect service PacketProcessingService which returns
Void.

Therefore <T extends DataObject> type parameter was changed to <T>.

Change-Id: I4ad4c37bfc09cf3d6e518ecbdcdfdb877a38f891
Signed-off-by: Jozef Gloncak <jgloncak@cisco.com>

Merge "Adding ofplugin-config classifier to poms"

Handling async replies from device in DeviceCtx

Change-Id: I7afcfa9439a963cf29673d61762ea1e2d3669776
Signed-off-by: Timotej Kubas <tkubas@cisco.com>

Changed methods in DeviceContext, created DeviceReplyProcessor interface

- changed methods in DeviceContext
- .processReply methods excluded into DeviceReplyProcessor interface
- both interfaces implemented in DeviceContextImpl
- added tests

Change-Id: I7a07d94c6c018feef562f5c7f4274871b2a28c69
Signed-off-by: Timotej Kubas <tkubas@cisco.com>

Adding ofplugin-config classifier to poms

Change-Id: I1818bf337d8c70d85a728fb0f3380636aea8c2d8
Signed-off-by: Jozef Gloncak <jgloncak@cisco.com>

statistics related services moved to separate package

- statistics related services are not exposed for MD-SAl

Change-Id: Id4c94fea6bad7d68ac095944f0d836e8fc2329b2
Signed-off-by: Martin Bobak <mbobak@cisco.com>

CommonService exposes more methods and parameters

Change-Id: I4aefe586b295b762547f3f754f541f533fac23a0
Signed-off-by: Martin Bobak <mbobak@cisco.com>

DeviceContextReadyHandler propagates requst ctx and device ctx

Change-Id: I542b60a0b9de37249a2fdffdf01f05ceaeb3e264
Signed-off-by: Martin Bobak <mbobak@cisco.com>

DataCrate becomes public

Change-Id: Ic414f6db60db32423eb0d34b60cdce3c231fcbbe
Signed-off-by: Martin Bobak <mbobak@cisco.com>

RpcContext extends RequestContextStack

Change-Id: Ifa8ec430bc05ade99d0e88b149040526e06687d7
Signed-off-by: Martin Bobak <mbobak@cisco.com>

removing request context from a stack extracted to separate interface

Change-Id: Ifafb333f4385d1bb3bb0b5b213e32de63aaa70f0
Signed-off-by: Martin Bobak <mbobak@cisco.com>

DeviceContext API cleanup

- removed comments
- removed method sendRequest()

Change-Id: I9b2c9ce5c087066663ee293afdafbbec23b9fd91
Signed-off-by: Martin Bobak <mbobak@cisco.com>

 CommonService publishes its methods and properties

Change-Id: I89d6f287e90d5c71e2ca4a78cc5c4b605451b9fa
Signed-off-by: Martin Bobak <mbobak@cisco.com>

added feature odl-openflowplugin-new-southbound

- rebased

Change-Id: I68ba2436525f0a46365c6e57326b77bef83f4992
Signed-off-by: Martin Bobak <mbobak@cisco.com>

api from impl separation : created openflow-provider.yang in API

Change-Id: Ifa91422c8857ff531530195cc5ce60a31140f824
Signed-off-by: Martin Bobak <mbobak@cisco.com>

added missing dependency in artifacts

Change-Id: I29bf9ff404985052121547594780e436c0bf09ed
Signed-off-by: Martin Bobak <mbobak@cisco.com>

Fix merge job not working

As it turns out while moving out the parent pom contents I failed to
mention parent in the aggregator, which meant that the reactor was not
properly resolved locally.

Change-Id: Iffd390020cae2c9b0e2f8106edb856c5745b4550
Signed-off-by: Robert Varga <rovarga@cisco.com>

Do not mention enunciate

Enunciate is incompatible with Java 8 and is not used anywhere in this
project. Remove its mention in m2e mapping.

Change-Id: Ieb1c78563930088a5d072cbd84c43997e1327700
Signed-off-by: Robert Varga <rovarga@cisco.com>

Move openflowplugin-parent

Parent should be in a subdirectory, so we have a top-level aggregator.

Change-Id: I8b82b585acd0646d23904125b95d743b323aa8d7
Signed-off-by: Robert Varga <rovarga@cisco.com>

Start openflowplugin-artifacts

Inter-project dependencies are better tracked through a single artifact.
All our upstream projects already define one, so let's follow their
lead.

Change-Id: Iead4c5653bab895a5b0b404f24fffb01975f44f2
Signed-off-by: Robert Varga <rovarga@cisco.com>

Refactor dependency management to import upstream artifacts

Upstream projects are exposing appropriate dependencyManagement section
in $project-artifacts. Import them to simplify dependency declarations.

Change-Id: Iec4af832e22857a0147c08c9deda3830351d44b5
Signed-off-by: Robert Varga <rovarga@cisco.com>

Unify property definitions

Change-Id: I6d9da75cd6903c8695d996c6178025394388e625
Signed-off-by: Robert Varga <rovarga@cisco.com>

Fix Jdk8 compatibility

JDK8 has stricter javadoc rules, make sure we do not fail on them.

Change-Id: I13ae2d0cc750faf66dc4f0c41a7982f9e9aae4cb
Signed-off-by: Robert Varga <rovarga@cisco.com>

Merge "unifying statistics manager api packages"

Revert "PostHandshakeNodeProducer help class"

According to author - this change needs to get reworked;

This reverts commit a29553293e059ea656ec0bb3339d6e261ecf081b.

Change-Id: I686c4dbddec9f30ce61d23104a2ff292a5bd14bb
Signed-off-by: Michal Rehak <mirehak@cisco.com>

Setting xid to request context in all services.

All of the services currently set request context xid value to
xid which is generated in each service.

Change-Id: I74935bafc4c5008619fceb3f2fbcc7160debf744
Signed-off-by: Jozef Gloncak <jgloncak@cisco.com>

FlowService - standalone request context for multiflow input

If input flow is devided to more (2 maybe more) flows then result
Future isn't chained but for every flow is created standalone
request context with unique Xid. Methods addFlow and updateFlow
return future object which will contains global result of all
partial futures (if one fail then global fail, if all success then
global success)

Change-Id: I0406888a0568d6ba3905113cde69e2a96aa78141
Signed-off-by: Jozef Gloncak <jgloncak@cisco.com>

Wrap service handlers to method handleServiceCall.

Handling code in service handlers (expect PacketProcessingServiceImpl) were wrapped
to handleServiceCall() method.
Method handleServiceCall() was moved to CommonService abstract class

Change-Id: I027f1b0658b4805366748377dfd43ca9c102df44
Signed-off-by: Jozef Gloncak <jgloncak@cisco.com>

Hooking of Request context from services to device context

Change-Id: If19db05a23f3c7141cf4a044d1273fad0c25ca2b
Signed-off-by: Jozef Gloncak <jgloncak@cisco.com>

Added Xid and waitTimeout getter and setter.

Getter and setter methods for Xid and waitTimout fields
were added to interface RequestContext .

Change-Id: I85cc92f6729aac37b3a2e1cba51a67e08f3a2026
Signed-off-by: Jozef Gloncak <jgloncak@cisco.com>

Handle exceptional state while closing RequestContext.

Current close() method is wrong one. Correct one if from AutoClosable
interface and raises Exception.

Change-Id: I7fe8d65c3ac5c7ab036cee1da642c8e3c7672162
Signed-off-by: Jozef Gloncak <jgloncak@cisco.com>

DeviceContext constructor and some final property exposed methods

Note: DeviceContext has to implement TransactionChainListener
to catch async Transaction DataStore write process. So we've
changed a DeviceContext interface for providing WriteTransaction
(tx for putting new data to DataStore) and fresh ReadTransaction
which provide a possible different DataStore snapshot, but what
could make a written transaction as fast as is possible.

* DeviceContextImpl constructor, Transaction get/set methods;
* DeviceContextImplTest - add/fix relevant tests
* DeviceManager - commented out all out of date code

Change-Id: Ida5ce3d47aeffcb6dd2f987f26d62edcc696b2e7
Signed-off-by: Vaclav Demcak <vdemcak@cisco.com>

Merge "DeviceState implementation"

Merge "PostHandshakeNodeProducer help class"

Merge "MultipartRequestInputFactory"

Merge "MultiMsgCollector moving package"

unifying statistics manager api packages

Change-Id: I29b495fd26c45ce50e73b96c9d23380eeb09f4c1
Signed-off-by: Martin Bobak <mbobak@cisco.com>

DeviceState implementation

Note: DeviceState is a basic object which we need to populate
from ConnectionContext and it has to be a input object for
DeviceContext. So this implementation has to be before
DeviceContext implementation in the chain order.

* DeviceState interface - fix getNextXid and getPortsBandwidth methods
* impl DeviceStateImpl
* impl test suite in DeviceStateImplTest

Change-Id: Iadf19754c3373b25a6a320c676118d13338a0097
Signed-off-by: Vaclav Demcak <vdemcak@cisco.com>
Signed-off-by: Martin Bobak <mbobak@cisco.com>

PostHandshakeNodeProducer help class

Note: PostHandshake process has to populate complex static information about
new FlowCapableNode before add DataStore process. But whole postHandsake
process contains a lot of functionality which is related only this short
time window so we put it to one class together. This new helper has to be
forgotten after succesfull add to DataStore process and it doesn't need
to be a part of DeviceManager code.

* settableFuture<Node> produce new Node with all device info and features
  * collecting Devide description
  * collecting Device meterFutures
  * collecting Device grupFutures
  * collecting Device tableFutures (TODO : add DataStore model and finish impl)

(Tests and possible fixies for this class will be
 a part of DeviceManager#deviceConnected method implemenation and its test suite)

Change-Id: I84fdd3004f211590d5066711518490cd134d6573
Signed-off-by: Vaclav Demcak <vdemcak@cisco.com>

Fixed (de)serialization issue

 - fixed: TunnelIdValue -> TunIdValue (model misuse)
 - fixed: removed masks from setField (SetDlSrc, SetDlDst)

Change-Id: I96e4f9e3eda0cb26b455f68c9453441e07133c3a
Signed-off-by: Michal Polkorab <michal.polkorab@pantheon.sk>
Signed-off-by: Martin Bobak <mbobak@cisco.com>
Signed-off-by: Michal Rehak <mirehak@cisco.com>

MultipartRequestInputFactory

Note: Factory class produces MultipartRequestInput object
for ConnectinAdapter.multipartRequest method. Class should
help a newbie to understand relationship between MultipartType
and set MultipartRequestBody children.

* factory class with an input validation
* test suite for factory MultipartRequestInput

Change-Id: Id728fa3e6f15cf8c83442a23b0b118fd35f2c5ee
Signed-off-by: Vaclav Demcak <vdemcak@cisco.com>

MultiMsgCollector moving package

Note: MultiMsgCollector is logicaly part of ConnectionContext no DeviceContext,
so we move all implemented classes and interface to correct package.

* change package for MultiMsgCollector MultiMsgCollectorImpl
MultiMsgCollectorImplTest
* add validation for same MultipartType for same XID
* add MuliMsgCollector to ConnectionContext + implementation
delegated methods
* implement onMultipartReplyMessages method from
OpenflowProtocolListenerImpl + test

Change-Id: I3caeb83c46c9a107c8e36ce7630cee4e75fca815
Signed-off-by: Timotej Kubas <tkubas@cisco.com>
Signed-off-by: Vaclav Demcak <vdemcak@cisco.com>

Merge "Feature/Bug#2774: Decrease verbosity of flow hash duplicate."

Merge "added yang file describing openflowplugin-impl as CoSS module"

Feature/Bug#2774: Decrease verbosity of flow hash duplicate.

Patch set 3: Add more info on code path when debug is enabled.

Change-Id: Ifd722e7e427c1ebca53636d371dcf6187911b95b
Signed-off-by: Keith Burns (alagalah) <alagalah@gmail.com>

Merge "separation of api and impl - crated openflowplugin types yang"

added yang file describing openflowplugin-impl as CoSS module

Change-Id: I0ed0158e4815516e9255301c89f9bf31f460e82a
Signed-off-by: Martin Bobak <mbobak@cisco.com>

separation of api and impl - crated openflowplugin types yang

Change-Id: Iebcd7659a9d76d53c2dada234d0f8d466da87281
Signed-off-by: Martin Bobak <mbobak@cisco.com>

Implemented DeviceContext.hookRequest and DeviceContext.processReply

Change-Id: I7f440dd8623f051e071e923636c7d3d3835d9f14
Signed-off-by: Timotej Kubas <tkubas@cisco.com>

Added type parameteris.

Class type parameter was added to all classes in this change.

Change-Id: I7cd27edef23b7b52bcc2d32d42f7feac3e7a9b4c
Signed-off-by: Jozef Gloncak <jgloncak@cisco.com>

Statistics services implementation and cleanup

Change-Id: I550fb3666d021283c283398c07a95d12330c6eb3
Signed-off-by: Martin Bobak <mbobak@cisco.com>

Implementation of services Sal*Service and PacketProcessing

Implementation of:
- SalFlowService
- SalGroupService
- SalMeterService
- SalPortService
- SalTableService
- PacketProcessingService

Picking common functionality to ServiceCallProcessingUtil.

Change-Id: I071280e2d5cab7ea201c8ea829f89ca4a300b178
Signed-off-by: Jozef Gloncak <jgloncak@cisco.com>

implementation of GroupStatisticsService

Change-Id: Idb7ce9a185ae88a3216ead053d487034d7ed541b
Signed-off-by: Martin Bobak <mbobak@cisco.com>

implementation of FlowStatisticsService and FlowTableStatisticsService

- introduced RequestInputUtils

Change-Id: I71490ef9e65039b0c8d3d41357af7227d155508e
Signed-off-by: Martin Bobak <mbobak@cisco.com>

implementation of FlowStatisticsServiceImpl

Change-Id: Icde601bd22d662de777304b3feba5177e5268d3b
Signed-off-by: Martin Bobak <mbobak@cisco.com>