Automations in sfcofl2 mininet scripts

- General clean up of scripts for demo

Change-Id: I039ada2c030f6bfe5b8de29da846a7ce977cdb02
Signed-off-by: Brady Johnson <[email protected]>

Merge "Use SF from SFP hop if defined and override algorithem selection"

Use SF from SFP hop if defined and override algorithem selection

- https://bugs.opendaylight.org/show_bug.cgi?id=3297
- validate matching between SFP hops and chain definition

Change-Id: I07bea9e1f2f06f180689381330251b736ea4bd1f
Signed-off-by: shlomi <[email protected]>

Bugfixes for ARP and Mininet script:

 - Fixing Target Protocol Address and Sender Protocol Address for ARP reply packets.
 - Bugfix to create the correspondent SFs per SFF in the mininet script.

Change-Id: I2d7f9ce2e0f8b0481c0381421f8772eabf9a8711
Signed-off-by: Ricardo Noriega <[email protected]>

Merge "Enable skipdist for tox version >= 1.6"

Updates to sfcofl2_mininet script

- Setting number of SFs per SFF
- Add Top-of-Rack topology option

Change-Id: I32eacb0e8bacac5632c90c5530bd271e8131ebcc
Signed-off-by: Brady Johnson <[email protected]>

Bug 3591 - Get the SFF mac from the Mac/VLAN DPLs

- Currently always getting the mac from the SFF OFS augmentation,
  even if the DPL is Mac/Vlan.
- https://bugs.opendaylight.org/show_bug.cgi?id=3591

Change-Id: I430d8a3c2e7aea7b52a877721ff754c6062962ba
Signed-off-by: Brady Johnson <[email protected]>

Enable skipdist for tox version >= 1.6

Change-Id: Id09151cbf692499d99db6d2d02d1a970479c1ba2
Signed-off-by: Thanh Ha <[email protected]>

Merge "Bug 3571 OVSDB Connection info changed SFCOVS no longer sees node for NB SFF CRUD"

Merge "performace issue improvements"

Bug 3571 OVSDB Connection info changed SFCOVS no longer sees node for NB SFF CRUD

tp-id: changed to short string, not concatenation.

Change-Id: I444ee6ff00ab6d3c7179ead9e7120a4b16aa1098
Signed-off-by: Keith Burns (alagalah) <[email protected]>

For TcpProxy SFs, reply to the SF ARP messages

Bug ID 3294

https://bugs.opendaylight.org/show_bug.cgi?id=3294

Change-Id: I6da52c8333360e7928fc3b1d2ea3d2c992beef6b
Signed-off-by: Ricardo Noriega <[email protected]>

Patch set for already merged change.

- This change was already merged, so submitting patch-set separately
    https://git.opendaylight.org/gerrit/#/c/21612/

Change-Id: I66ec0b7e1231956b1e51ad932f7efef2b5de2872
Signed-off-by: Brady Johnson <[email protected]>

Merge "Correctly handling SFFs with multiple SFs"

Correctly handling SFFs with multiple SFs

- When getting an SF DPL, make sure it matches the SFF name
- https://bugs.opendaylight.org/show_bug.cgi?id=3537

Change-Id: I7292e8899d63b92c5a9c9d12a9cbe1fcc03a24f6
Signed-off-by: Brady Johnson <[email protected]>

SfcOvsDataStoreAPI junit tests + minor repair in SfcOvsUtil

Change-Id: I44eb767fb8392a08e44a61991d5061dafc581061
Signed-off-by: Vlado Lavor <[email protected]>

performace issue improvements

Change-Id: I11d8594f16afb50506f65e718a17ac757d3e0308
Signed-off-by: Marcel Sestak <[email protected]>

Merge "Bumping versions from Lithium to Beryllium."

Bug 3396: Ensure hop uniqueness in TE mappings.

Change-Id: Iabca1e491799da8b4406639640317d6d735538d5
Signed-off-by: Florin Coras <[email protected]>
(cherry picked from commit eccac77de25fe2f3cf8731f0d1525d42ed1ee130)

Bumping versions from Lithium to Beryllium.

- The Version-bump.sh script was used
https://wiki.opendaylight.org/view/File:Version-bump.sh
- Had to manually change yangtools versions
    from: <date>.7-SNAPSHOT
    to:   <date>.8-SNAPSHOT

Change-Id: Ic4faf8d59908807b7003f3f1d70ff8040b7d45d0
Signed-off-by: Brady Johnson <[email protected]>

Bug 3247 - Need to move vnbar stats button from main page to RSP tab of SFP page

Change-Id: I202bf67b03267df12e4447386eb29f6d48c4e8a5
Signed-off-by: Reinaldo Penno <[email protected]>

Fixing broken build cause by sfclisp compilation

- The LispApplicationDataLCAFAddress API changed in this
  upstream change:
      https://git.opendaylight.org/gerrit/#/c/21251/
- Not sure if we should be using getLocalPortLow() or getLocalPortHigh()
  using Low for now.

Change-Id: Iff000b753576a9ad9a18b994c755be11e3962cd7
Signed-off-by: Brady Johnson <[email protected]>

Fix sonar test coverage reporting

 - added sonar-jacoco-listeners dependency - picks up jacoco report and
   transforms it into sonar report
 - modified jacoco-maven-plugin - so that sonar is able to pick up jacoco report

Change-Id: Iad05d270a3b9e6cf1ba5211f1d8b1146a2d5b33a
Signed-off-by: Michal Polkorab <[email protected]>

JUnit SfcOvsRpc, SfcOvsToSffMappingAPI & SfcSffToOvsMappingAPI update

Change-Id: Ice09b55c078eb2ad5d4448f2ed8872b18e54aa7e
Signed-off-by: Vlado Lavor <[email protected]>

Merge "BUG 3279: sfc-sb-rest Add 'input-interface' and ipfix  matchers in the exported ACE"

BUG 3247 - Need to move vnbar stats button from main page to RSP tab of SFP page

Change-Id: I37ff7efdb5928a620bef1f55d567962c3f2cde8b
Signed-off-by: Reinaldo Penno <[email protected]>

The tenant-id is missing from SFP/RSP. Although it is present on SF

Change-Id: I9f8b97bde303f97243cd6a1d5f4bce74d650d86d
Signed-off-by: Reinaldo Penno <[email protected]>

Merge "fix lisp NPE"

BUG 3279: sfc-sb-rest Add 'input-interface' and ipfix  matchers in the exported ACE

Change-Id: Ic51266fc0a6b874ddc19661c16d2b84685dcef7f
Signed-off-by: Christophe Fontaine <[email protected]>

fix lisp NPE

Change-Id: I6aeaa459eec9b2312f8d2008357367c3d9d5328c
Signed-off-by: shlomi <[email protected]>

classifier.py: process_packet() fixing the issue when only first 1024 packets are processed

Change-Id: I745a8258fec048ffc95f0547e02bf15d2c1858d9
Signed-off-by: Marcel Sestak <[email protected]>

Merge "Switch sfclisp from activator to config subsystem"

Moving tests cleanup code to @after block

+ using RSP_NAME constant everywhere, to make the cleanup possible

Change-Id: I3948cb86021e6c26df9b6d37f4d6405e28c6ee8e
Signed-off-by: Andrej Kincel <[email protected]>

Switch sfclisp from activator to config subsystem

Change-Id: Ic2501e9d0a6e475258be23c4d3e798cda8b290c4
Signed-off-by: Florin Coras <[email protected]>

Merge "sfc-ui: Add the possibility to drag and drop ACEs in a ACL to order the ACEs"

Merge "Separating config files of features"

Merge "Bug3218 Handle generated traffic from TCP Proxy SF"

Bug3218 Handle generated traffic from TCP Proxy SF

- https://bugs.opendaylight.org/show_bug.cgi?id=3218
- Added boolean flag to SF to indicate its a tcpProxy
- Added service-function type TcpProxy
- Added a TcpProxy UT

Change-Id: I60a7f0dccd24f09c30d2beb7da15fb06f00b9d7d
Signed-off-by: Brady Johnson <[email protected]>

Bug 3237: Add OVSDB config via SFF PUT.

This patch adds support for configuring an SFC-OVS
Service Function Forwarder, without requiring the
user to provide the ovs-node object.

It also adds a fix that allows SFCOFL2 to get the
Inventory NodeId from a Service Function Forwarder
for flow programming

Change-Id: I5870def6986bad51df0c92408888997debfff015
Signed-off-by: Thomas Bachman <[email protected]>

sfc-ui: Add the possibility to drag and drop ACEs in a ACL to order the ACEs

Change-Id: I9fce00f990a8c377ea7874338e0b4e1bd66a8db0
Signed-off-by: Christophe Fontaine <[email protected]>

Separating config files of features

Features which are not included in odl-sfc-provider feature
(odl-sfc-test-consumer, odl-sfc-netconf and odl-sfc-sb-rest) should not
be listed as required capabilities in 80-sfc.xml. This is causing config
subsystem exception, if only odl-sfc-provider feature is installed and
the above listed features are not.

The behaviour should be:
1. odl-sfc-provider can be installed without any other features except
odl-sfc-model
2. a SFC renderer (sfc-ovs, sfcofl2, sfc-netconf) is dependent on
odl-sfc-provider, thus installation of renderer feature will triger
odl-sfc-provider installation too.

+ separating sfc-sb-rest config file
+ separating sfc-netconf config file
+ separating sfc-test-consumer config file
+ removing sfc-test-consumer from boot features

+ fixed ordering in features
  (config file after bundle)

Change-Id: I6cd942dfb43abfa5728475524c3c5be869bdc2f1
Signed-off-by: Andrej Kincel <[email protected]>

Merge "Bug 3235: Added missing NSH features."

BUG 3239: InvokationException on ServiceFunctionGroups

- Two fixes in this patch
- SFG can not access vaibale that might be null. It has to test for it first
- SCheduler initialization can not occur after Path is created. This causes
  first RSP creation to fail

Change-Id: Iec917ce4677cd18c82053da5eaa1fd217727e3ef
Signed-off-by: Reinaldo Penno <[email protected]>

Bug 3235: Added missing NSH features.

This adds some missing NSH features to
SFC-OVS.

Change-Id: I35e941bc59a13e135fa92f556af2c5f6e5e76f17
Signed-off-by: Thomas Bachman <[email protected]>

Merge "SFC + GBP Integration Phase II: enhance readRspFirstHopBySftList"

Merge "Now using NSH Nsc Registers"

Now using NSH Nsc Registers

- Add NshOneHop UT
- Copy Nsc1/Nsc2 from hop-to-hop to maintain the values through the chain
- Use Nsi, Nsp, Nsc1, and Nsc2 on the last hop (last Nsi)
-- If on the last Hop
---    If Nsc1 is not set, that is Nsc1==0
----      Output to INPORT
---    Else
----      Copy/Move Nsi, Nsp, Nsc1=>Ipv4TunDst, and Nsc2=>TunId (Vnid)

Change-Id: Ibf1a071c8de4f44a00d2e90df07e8c1df9fee305
Signed-off-by: Brady Johnson <[email protected]>

Bug 3193 - OVS-CLI to SFF path does not work

- Full fix for clustering issues that I could catch
- Caught almost all situations where we build objects but have nothing
  in them or they are simply null

Change-Id: Ia49df1d77d48c85a88b55df593b364b5847b8af7
Signed-off-by: Reinaldo Penno <[email protected]>

SFC + GBP Integration Phase II: enhance readRspFirstHopBySftList

readRspFirstHopBySftList can take two arguments now, one is
ServiceFunctionSchedulerTypeIdentity, the other is
List of ServiceFunctionTypeIdentity, this enables the caller to
specify scheduler algorithm on calling readRspFirstHopBySftList
to create a new RSP.

Change-Id: I73a742e19d0d623bf6fa49bf8911c50af610db29
Signed-off-by: Yi Yang <[email protected]>

SfcProviderRpc unit tests

Change-Id: Id1a30fb6098b87e610936bb84f92f7e680d740d1
Signed-off-by: Igor Bartak <[email protected]>
Signed-off-by: Andrej Kincel <[email protected]>

JUnit: SfcSffToOvsMappingAPI test update

Change-Id: I7677f6b36f332960b942e713dfeb53df35040310
Signed-off-by: Vladimir Lavor <[email protected]>

Merge "Minor NSH flow bug fixes"

Minor NSH flow bug fixes

- Minor fix for RSP with only one Hop
- Nsi should not be 0 on egress hop
- Minor fix to UT as a result of needing rsp.getStartingIndex()

Change-Id: I8e006e87f0a5284aca764a8406914298e150e433
Signed-off-by: Brady Johnson <[email protected]>

Merge "render grouped rsp to ofl2"

render grouped rsp to ofl2

Change-Id: I9fc513e593cbd55c85ac8acaa762a523eb141f4f
Signed-off-by: shlomi <[email protected]>

Using synchronized Maps in SfcL2ProviderUtils.

Change-Id: Iaa9d59fac937fa37b357a00d94b7943a98acd54f
Signed-off-by: Brady Johnson <[email protected]>

Bug 3184 rsp return name instead of boolean

Change-Id: I36229f4e9de6d74e49db75c0125d050e4b70fe4d
Signed-off-by: Vladimir Lavor <[email protected]>

Temporarily removing SFC-Lisp from build as its breaking Jenkins.

Change-Id: I7b844c243f0eda0decbdcc6ba4cf389210b9c888
Signed-off-by: Brady Johnson <[email protected]>

SfcProviderRenderedPathAPITest + POM

Change-Id: I7ebaf0c5d4e51b93885112e7728a0eaa8e8dbec6
Signed-off-by: Vladimir Lavor <[email protected]>

Merge "SfcProviderServicePathAPI.class, readAllServiceFunctionPath Junit test"

SfcProviderServicePathAPI.class, readAllServiceFunctionPath Junit test

Change-Id: I3bb2c0debd31b7e771db8d5d96ee9c98a63e3413
Signed-off-by: Vladimir Lavor <[email protected]>

Bug 3190 - Removing automatic augmentation names to debug OVSDB issues

Change-Id: Idbab3aad19ee5a8630fff7cc4ee2c2fe7f0ce0fc
Signed-off-by: Reinaldo Penno <[email protected]>

Merge "Bug 3187: Adding mapping list."

Merge "override lisp project junit definition"

Previous sfcofl2 files have been removed to complete the transition to new folder sfcofl2_demo folder

Change-Id: I4953fa9d7ab22f1eed3b613f697718a3bcb38d44
Signed-off-by: Rodrigo Lopez Manrique <[email protected]>

sfcofl2 test files have been moved to sfcofl2_demo folder.
JSON data files that configure ODL have been added to that folder.
Finally, README file to test everything together is included.

Change-Id: I520b02aa40c6aa4a616e6e9180b474ff628fcefb
Signed-off-by: Rodrigo Lopez Manrique <[email protected]>

override lisp project junit definition

Change-Id: Ibe383b43a611b08ac82dc073d3b5e0eaacc6605e
Signed-off-by: shlomi <[email protected]>

Bug 3187: Adding mapping list.

This adds a container to keep mappings needed
by the SFC-OVS renderer. It also adds a list that
keeps mappings of OVS UUID + Bridge Name to SFF Names
in an operational data store.

Change-Id: If9d0e83829b303a80b65d786cbacb0c9038df5e1
Signed-off-by: Thomas Bachman <[email protected]>

Making SfcL2Utils thread safe

Change-Id: I97bc4218b55a0b7e43928810a008cc9ea835922a
Signed-off-by: Brady Johnson <[email protected]>

Adding SFC OpenFlow Renderer Unit Test

- Unit Testing flow counts for VLAN, MPLS, and NSH
- Refactored SfcL2ProviderUtilsInterface to SfcL2AbstractProviderUtils
  since there are many methods that are common to the different
  implementations. Now SfcL2AbstractProviderUtils is an abstract
  class that implements the common methods

Change-Id: I7f8835b48f7a06a7b606f85e0d46ab0a919e3b83
Signed-off-by: Brady Johnson <[email protected]>

SF Tenant ID

Change-Id: I7fad27b8583dad074e899faeadd459be418108a2
Signed-off-by: Reinaldo Penno <[email protected]>

Creating SfcL2ProviderUtilsInterface and SfcL2ProviderUtils

- This allows us to easily isolate the SfcL2RspProcessor and
  SfcL2SfgDataListener classes for much easier Unit Testing.
- patch-set 2, minor compilation error fixed in comments.

Change-Id: I2c2b11a2d4902384538ab1ebf8e013e14f95f53c
Signed-off-by: Brady Johnson <[email protected]>

Merge "Some bugs have been solved and new options added. In addition, the script reads the flows automatically."

Some bugs have been solved and new options added. In addition, the script reads the flows automatically.

Change-Id: I5d3e9abbc4db0aeb82f57868d39c564b9c2f3078
Signed-off-by: Rodrigo Lopez Manrique <[email protected]>

General SFCOFL2 cleanup

- Rename methods from Ingress to PathMapper table
- Move more util methods from SfcL2RspProcessor to SfcL2Utils class
- Clean up SfcL2FlowProgrammerOFimpl action calls

Change-Id: I7fc09ad310eebe9feffd55dbfe21fc9644e9ef0d
Signed-off-by: Brady Johnson <[email protected]>

SfcProviderRenderedPathAPITest: adding unit tests

+ testCreateRenderedServicePathHopList
+ testCreateRenderedServicePathAndState

Change-Id: I3b55b196880769e93c02afbc9e5be7ae2c5ec453
Signed-off-by: Andrej Kincel <[email protected]>

SfcProviderRenderedPathApiTest: moving SFC and SFP creation

Moving SFC and SFP creation into before() block, as SFC and SFP
will be used also in other tests.

The next test patches should depend on this commit.

Change-Id: I23a214b3e41091f51474f9dedd19c27c3f020e39
Signed-off-by: Andrej Kincel <[email protected]>

Merge "Changed typing of SFC-OVS Options."

Changed typing of SFC-OVS Options.

The ovs-options were strictly typed. Unfortunately,
the options in OVS are key/value pairs of strings,
and strict typing prevents the use of values like
"flow" for remote_ip and other options. This patch
converts these types to strings so they can support
"flow" values and can be passed directly to the
OVSDB Southbound.

Signed-off-by: Thomas Bachman <[email protected]>

Removing RSP Listener from sfc-ovs.

The RSP listener isn't needed in sfc-ovs,
as the path wil be constructed using flow-mods
instead of nailed up tunnel parameters.

Signed-off-by: Thomas Bachman <[email protected]>

Merge "render groups to ofl2"

render groups to ofl2

Change-Id: Iaa5bccac7d64bfb6fad123b1e9198b87e05c4a04

Change-Id: Ib5a15feedbd22be8f09b3c527a8224b5156a9c15
Signed-off-by: shlomi <[email protected]>

sfc-ovs moving and fixing unit tests

Change-Id: I0aa108640c69c2c055aaf988686395634e32ee8b
Signed-off-by: Vladimir Lavor <[email protected]>

Merge "Bug 3143: On SFF Update operational state is removed before reading its contents"

Bug 3143: On SFF Update operational state is removed before reading its contents

Change-Id: I9fceb8f57e33bdb3ac1916261dbf0fadbc30f68a
Signed-off-by: Reinaldo Penno <[email protected]>

Merge "Bug 3124: Added dependency sfcofl2 to sfc-features."

Fixing sfcodl2 that uses OVS Yang models

Change-Id: I21ffb5ce270609ceeec58434ba0338cdc21a1ca0
Signed-off-by: Reinaldo Penno <[email protected]>

Fixing UI for Cisco Devices

Change-Id: I5c89c4b51e5832e92dc1f61d31ed98176b5f17c0
Signed-off-by: Reinaldo Penno <[email protected]>

Merge "Changing Yang to make Augmentations easiers to code"

Bug 3124: Added dependency sfcofl2 to sfc-features.

This patch also removed munge-maven-plugin from sfcofl2's dependencies, since it caused build failures and it was not used by the sfcof12.

Change-Id: I11c6e9b80dc370f9086f8b6a06890b07de96332c
Signed-off-by: Hideyuki Tai <[email protected]>

Merge "sfc-ovs adding unit tests"

sfc-ovs adding unit tests

SfcOvsToSffMappingAPI, SfcSffToOvsMappingAPI, HopOvsdbBridgePair,
SfcOvsRpc, SfcOvsUtil

Change-Id: I2cf47d961e7c305bd0a3b9961374b5a983ba843e
Signed-off-by: Vladimir Lavor <[email protected]>

Merge "Reduce the amount of INFO logging"

Reduce the amount of INFO logging

- Changed most logging to use DEBUG instead of INFO

Change-Id: I9f82663520d93ee2cd70e393c0268c7cbd7383b4
Signed-off-by: Brady Johnson <[email protected]>

Get the OpenFlow node id for OVS SFFs

- If the SFF is an OVS augmented object, then
  get the OpenFlow node id differently

Change-Id: I6d145e0411c5920de69bb0c35c7edfb0e498c8ee
Signed-off-by: Brady Johnson <[email protected]>

Changing Yang to make Augmentations easiers to code

Change-Id: Ia0fcf047525e7f6e13602097d60e803b9d29148e
Signed-off-by: Reinaldo Penno <[email protected]>

Bug 3107: Sfc-OVS lacks API for storing OVS Bridge Openflow ID

Change-Id: I87fbf73eec44d99e4612235085394efa6239abd7
Signed-off-by: Andrej Kincel <[email protected]>

Fix JDK8 compatibility

JDK8 is more picky about javadoc correctness. Fixup errors preventing
compilation.

Change-Id: I6d373b1f2987580ded725c44355806b1fe9249aa
Signed-off-by: Robert Varga <[email protected]>

Merge Layer3Match values for multiple Ipv4 Matches

- If multiple layer3 match fields need to be set, the
  MatchBuilder Layer3Match field was being overwritten,
  instead of being appended onto.

Change-Id: Iecd120056de2a49dc3a98c0a8fd2959553319612
Signed-off-by: Brady Johnson <[email protected]>

Merge EthernetMatch values for multiple Ethernet Matches

- If multiple ethernet match fields need to be set, the
  MatchBuilder EthernetMatch field was being overwritten,
  instead of being added onto.

Change-Id: I2d67060032a870e82270699040b390f730bde90c
Signed-off-by: Brady Johnson <[email protected]>