Aswin Suryanarayanan [Tue, 8 Aug 2017 07:44:16 +0000 (13:14 +0530)]
Remove transparent mode from aclservice.
Depends on https://git.opendaylight.org/gerrit/#/c/60737/ , which adds
port_security disable tests.
Change-Id: Icf83af877cdf9965b24db38573453a6433d7eca6
Signed-off-by: Aswin Suryanarayanan <asuryana@redhat.com>
Josh [Sun, 27 Aug 2017 10:55:09 +0000 (13:55 +0300)]
BUG-8893 patch port mysteriously deleted
This happens sporadically when br-int exists prior to ODL
managing the OVS node. If the event notifying ElanOvsdbNodeListener
of the existence of the br-int bridge happens BEFORE the event
notifying about the OVS node the following occurs:
1. Netvirt gets event for br-int
2. Writes patch ports
3. Netvirt gets event for the ovs node
4. Creates br-int...which already exists and this over-writes the
patch ports
Fix:
a) clean up code so that br-int is configured with a controller
and patch ports only once we receive the notification for br-int
in operational.
b) when receiving a notification for the OVSDB node in operational,
check if br-int is in operational. If it is not, create it in
config.
c) when receiving a notification for br-int in operational, check if it
is also in config. If it is not, copy br-int fields from operational
to config. The proceed to step (a).
Change-Id: I11739ccc847e65c4179ff1f73493159bd4effcd2
Signed-off-by: Josh <jhershbe@redhat.com>
vinothb [Thu, 20 Jul 2017 18:06:08 +0000 (14:06 -0400)]
Spec for Acl change reflection on existing communication
Change-Id: Id8b2e3c9bf321248a6e55f6830078b4fd6acde14
Signed-off-by: vinothb <vinothb@hcl.com>
Aswin Suryanarayanan [Fri, 8 Sep 2017 11:52:00 +0000 (17:22 +0530)]
Bug 8964 - Neutron test
neutron.tests.tempest.scenario.test_floatingip.FloatingIpSameNetwork.test_east_west
fails
1)Added FIB(Table21) flow in NON-NAPT switch to send the traffic to
the SNAT IP to the NAPT switch over the tunnel.
2)Added Tunnel table(Table 36) in NAPT switch to send the to SNAT IP to
the Inbound SNAT(Table 44) table.
table=21, n_packets=49, n_bytes=4802,
priority=42,ip,metadata=0x30d42/0xfffffe,nw_dst=192.168.56.31
actions=set_field:0x186a1->tun_id,group:225001
table=36, n_packets=22, n_bytes=2156, priority=42,ip,tun_id=0x186a1
actions=load:0x30d42->OXM_OF_METADATA[0..23],resubmit(,44)
Change-Id: I829400a1479752dd9963ac8931ca662f4f51bed2
Signed-off-by: Aswin Suryanarayanan <asuryana@redhat.com>
Michael Vorburger [Wed, 13 Sep 2017 17:56:57 +0000 (19:56 +0200)]
Fix exception handling in neutronvpn shell
see
https://wiki.opendaylight.org/view/BestPractices/Coding_Guidelines#IllegalCatch
motivated by/while reviewing
https://git.opendaylight.org/gerrit/#/c/62711/3/vpnservice/neutronvpn/neutronvpn-impl/src/main/java/org/opendaylight/netvirt/neutronvpn/NeutronvpnManager.java
Change-Id: I8ebc913e66d2fe33ffadf361214bb82263aec149
Signed-off-by: Michael Vorburger <vorburger@redhat.com>
karthikeyan [Thu, 31 Aug 2017 12:50:21 +0000 (18:20 +0530)]
Bug7380:CSIT FIP ping is getting failed for Ext Flat/VLAN Network
Problem Description:
=======================
FIP Ping TC is getting failed for external FLAT/VLAN network on single
node setup.
For Single node setup VXLAN TEP is not at all required for external
network with provider type as FLAT/VLAN.
Current Implementation on FIP handling, it is
expected nextHop IP should not be null before programming FIP local flow
entry L3_FIB_TABLE (21) -> PDNAT_TABLE (25). This validation is not
required for external provider type as FLAT/VLAN networks.
Solution:
==========
NextHopIP validation is already existing in NatUtil.addPrefixToBGP()
method before FIP advertising to BGP. Hence removing unnecessary
validation from VpnFloatingIpHandler.
This will resolve FIP local flow entry L3_FIB_TABLE (21) -> PDNAT_TABLE
(25) installation on corresponding DPN for external FLAT/VLAN network on
Single Node setup (Without VXLAN TEP Configured)
Change-Id: I6653c78733e037310827ffbcd4498097b19a2abf
Signed-off-by: karthikeyan <karthikeyan.k@altencalsoftlabs.com>
Stephen Kitt [Wed, 13 Sep 2017 12:28:55 +0000 (14:28 +0200)]
Fix cloud-servicechain YANG
This corrects the YANG revision, which becomes 160711.
Change-Id: I32b619cc29d89c0d3adb06fc264c3f26c04d50c0
Signed-off-by: Stephen Kitt <skitt@redhat.com>
Faseela K [Fri, 8 Sep 2017 17:59:36 +0000 (23:29 +0530)]
Fix elanservice tests after daexim change in genius idmanager
Change-Id: I97f97a7c926a34f9bb6764bf004e8854512f5788
Signed-off-by: Faseela K <faseela.k@ericsson.com>
Tom Pantelis [Wed, 30 Aug 2017 01:40:15 +0000 (21:40 -0400)]
Remove unused references to DataChangeListener
Change-Id: I78e8c32bd76536fd420d31b6e7b0bd2b026d7a49
Signed-off-by: Tom Pantelis <tompantelis@gmail.com>
A Vamsikrishna [Mon, 11 Sep 2017 03:35:07 +0000 (09:05 +0530)]
Bug 9136 - Suspected ReadOnlyTransaction leak in QosNeutronUtils
Description:
Bug 9136 - Suspected ReadOnlyTransaction leak in QosNeutronUtils
Fix:
Fixed ReadOnlyTransaction leak by using try-with-resources statement for automatic resource management.
Change-Id: Ib4e03a425b840427d7133f40d5a72d4bf5f85605
Signed-off-by: A Vamsikrishna <a.vamsikrishna@ericsson.com>
Faseela K [Tue, 12 Sep 2017 11:55:51 +0000 (17:25 +0530)]
Fix wrongly keyed network map in CoeUtils
Change-Id: I34c986d5b142c46b0da969e4bab36b401881a2cf
Signed-off-by: Faseela K <faseela.k@ericsson.com>
David Suarez [Thu, 7 Sep 2017 19:40:03 +0000 (21:40 +0200)]
Remove deprecated CheckedFuture
Remove deprecated CheckedFuture.
Change-Id: I69b6378867f68e18d69a23c25e14780ad305370c
Signed-off-by: David Suarez <david.suarez.fuentes@gmail.com>
Sam Hague [Fri, 8 Sep 2017 13:41:25 +0000 (09:41 -0400)]
Bug 7380: service-binding exceptions from ACL
Change-Id: Ifb4d096bb58bfa5e7670a5b0f2b8718067366c5c
Signed-off-by: Sam Hague <shague@redhat.com>
Sam Hague [Fri, 8 Sep 2017 19:35:44 +0000 (15:35 -0400)]
Ignore elan tests due to daexim failure
genius has a dependency on daexim introduced recently
so ignore the failing tests in netvirt until that is fixed.
09:49:48 1) No implementation for org.opendaylight.daexim.DataImportBootReady was bound.
09:49:48 while locating org.opendaylight.daexim.DataImportBootReady
09:49:48 for the 4th parameter of org.opendaylight.genius.idmanager.IdManager.<init>(IdManager.java:101)
09:49:48 at org.opendaylight.netvirt.elanmanager.tests.ElanServiceTestModule.configureBindings(ElanServiceTestModule.java:49)
Change-Id: I4f3718a27cb44caa19235c350bffdf64302c0ddd
Signed-off-by: Sam Hague <shague@redhat.com>
Arun Sharma [Wed, 6 Sep 2017 17:28:52 +0000 (22:58 +0530)]
Minor code cleanup in QoS
- Corrected log messages
- Renamed QosAlertEosHandler to QosEosHandler because same eos handler
is used by QoS service as well.
Change-Id: I160f500ba40ed5cfb471d4023adf04c35cbc7bf2
Signed-off-by: Arun Sharma <arun.e.sharma@ericsson.com>
Vyshakh Krishnan CH [Thu, 31 Aug 2017 05:54:17 +0000 (11:24 +0530)]
Bug 9012 : BGP not connecting to config server
Issue was there with previos commit where config_server_updated flag was
never set to false. Making it to false at correct place now
Change-Id: I5c49bf02dac8cb66033eb8a38d453ac0922cbca9
Signed-off-by: Vyshakh Krishnan CH <vyshakh.krishnan.c.h@ericsson.com>
Kency Kurian [Wed, 6 Sep 2017 11:43:17 +0000 (17:13 +0530)]
Bug 9100 : tx leak in DhcpExternalTunnelManager
Change-Id: I14a6ff3310214362fcd51cb36a0ceb509b386ee1
Signed-off-by: Kency Kurian <kency.kurian@ericsson.com>
Jaime Caamaño Ruiz [Fri, 1 Sep 2017 17:33:55 +0000 (19:33 +0200)]
BUG9095 Capture SFC tunnel traffic for path egress
On scenarios where origin and destination of traffic are on the same
node, but last SF is on a different node, SFc on last hop will not
de-encapsulate the traffic, instead it will the encpsulated traffic
to the node indicated via IP address on NSH C1 metadata.
There an egress classifier function will handle the traffic. In order
to do this, since port binding in tunnel ports is still not being used
and there is no dispatch service on tunnel ports, this egress
classification function needs to take SFC traffic (VNI=0) with priority
to handle the possible chain egress. If chain egress function is not
applied, it will resubmit this SFC traffic to the SFC pipeline.
The egress classifier function is aslo updated to match SFC traffic on
on the specific ending index of each possible path.
Change-Id: I2c6131b727c17e4a36d2b5fb931c84719f4a077b
Signed-off-by: Jaime Caamaño Ruiz <jaime.caamano.ruiz@ericsson.com>
(cherry picked from commit
64160b249a54deb31cac3021a8343b9b03006a83)
Jaime Caamaño Ruiz [Fri, 1 Sep 2017 15:11:48 +0000 (17:11 +0200)]
BUG9094 Bind to last SF interface if origin node
If the last SF is in one of the possible origin nodes for the
classified traffic, bind the classifier on it's port. This is to be
to handle the possible scenario where origin, last SF and destination
of traffic are on the same node. On this scenario, SFC on last hop will
not de-encapsulate the traffic, instead it will be handed off to the
dispatcher table for the egress classifier function to handle it. To be
able to do this, it needs to be bound to the last SF port.
Change-Id: I97f60e8cc409ea42c830e408b4df91051b50689c
Signed-off-by: Jaime Caamaño Ruiz <jaime.caamano.ruiz@ericsson.com>
(cherry picked from commit
9509d783b6c9fe5a348e0f39e86b8ae72cc53c3f)
Aswin Suryanarayanan [Mon, 7 Aug 2017 09:24:36 +0000 (14:54 +0530)]
Remove stateless mode from AclService.
Change-Id: I6307007ef23c4f58e8c543a22550109d8c778ce4
Signed-off-by: Aswin Suryanarayanan <asuryana@redhat.com>
Michael Vorburger [Mon, 4 Sep 2017 21:46:59 +0000 (23:46 +0200)]
Add LogCaptureRule to AclServiceTestBase & ElanServiceTest
which is useful as is already to see test failure causes more clearly,
but will provide even more useful full information together with
https://git.opendaylight.org/gerrit/#/c/62654/
Change-Id: I278f38a38389eccea4317d52e8035f6e464400e1
Signed-off-by: Michael Vorburger <vorburger@redhat.com>
Signed-off-by: Aswin Suryanarayanan <asuryana@redhat.com>
karthikeyan [Tue, 29 Aug 2017 08:24:45 +0000 (13:54 +0530)]
Bug9016:Using Single Transaction during NAPT SwitchOver
Problem Description:
====================
When NAPT Switch over happens, multiple transactions were made to remove
SNAT related flows from Primary NAPT switch and reinstalling flow on new
NAPT elected switch.
Optimization needs to be done to make use of single transaction taking
care of removing all SNAT related flows from old NAPT and another single
transaction for installing SNAT flows on new NAPT switch.
Solution:
==========
Used one write transaction object for used to remove all NAPT related
flows from old NAPT switch during NAPT switch over happened. Used other
write transaction object for installing all NAPT related flows on newly
elected NAPT switch. This will reduce the number of transaction object
were used during NAPT switch over happens as well as installing SNAT
related flows during first time as well.
Note:
=====
Have removed ExternalNetworkListener.java class. Since this class was
taken care for installing NAT default flow L3_FIB_TABLE(21)
PSNAT_TABLE(26) on all NAT switches. This same logic was already
implemented in ExternalRoutersListener class. Just to avoid the conflict
modification error, removed ExternalNetworkListener.java class from NAT
Module.
Change-Id: Ic2b54e7acbb01805b9a25fea28017c7353ee59d2
Signed-off-by: karthikeyan <karthikeyan.k@altencalsoftlabs.com>
Arun Sharma [Tue, 29 Aug 2017 08:41:49 +0000 (14:11 +0530)]
Cluster support for netvirt QoS
-Changed QoS policy configuration change listeners from
AsyncDataTreeChangeListenerBase to
AsyncClusteredDataTreeChangeListenerBase so that all nodes receive
QoS configuration change notifications.
-Rate limit and DSCP marking is done only by QoS entity owner. Other
nodes just update the cache. This ensures that cache is always in
sync between all the nodes.
Change-Id: Id2215e4b98cfcb238c437402a02ece640db11413
Signed-off-by: Arun Sharma <arun.e.sharma@ericsson.com>
vinothb [Thu, 31 Aug 2017 22:55:58 +0000 (18:55 -0400)]
Bug 9035: - NPE at org.opendaylight.netvirt.elan.arp.responder.ArpResponderUtil.getMatchCriteria
Problem Description:
=======================
The following exception was observed from ArpResponderUtil
Error while installing ARP responder flow
java.lang.NullPointerException
at org.opendaylight.netvirt.elan.arp.responder.ArpResponderUtil.getMatchCriteria(ArpResponderUtil.java:178)[307:org.opendaylight.netvirt.natservice-impl:0.5.0.SNAPSHOT]
Solution:
=========
We need to enhance the pre-condition check in ArpResponderUtil before
installing the flow.
Change-Id: I9558080dc41df15164d2b189168c56c83b63c6ac
Signed-off-by: vinothb <vinothb@hcl.com>
(cherry picked from commit
683ceee8c33e8bc38f5abee75a966a139ab6aaba)
epgoraj [Tue, 29 Aug 2017 10:51:17 +0000 (16:21 +0530)]
Bug:9013 ElanUtils: RPC Call to Get egress actions for interface, OptimisticLockFailedException
Change-Id: Ib9607a217ff51eeedd92ca9c9c7759d352916aa7
Signed-off-by: epgoraj <p.govinda.rajulu@ericsson.com>
Aswin Suryanarayanan [Tue, 5 Sep 2017 08:58:41 +0000 (14:28 +0530)]
Bug 9085 - CSIT Sporadic failures -
test_security_groups_basic_ops.TestSecurityGroupsBasicOps.test_cross_tenant_traffic
Fixing the cause for exception.
Change-Id: I54f9812226be346dee771a0722618edbb9558190
Signed-off-by: Aswin Suryanarayanan <asuryana@redhat.com>
David Suarez [Wed, 9 Aug 2017 15:08:06 +0000 (17:08 +0200)]
Replace size()==0 by isEmpty()
Replace size()==0 by isEmpty(). It improves readability and avoid "=0".
Change-Id: I4bba45bea95a234734079376c7439395ae38e981
Signed-off-by: David Suarez <david.suarez.fuentes@gmail.com>
David Suarez [Thu, 17 Aug 2017 07:50:18 +0000 (09:50 +0200)]
Replace <? extends Object> by <?>
Replace <? extends Object> by <?> since they are equivalent.
Change-Id: I548338da4bbc1da2c7b7401f456d08d74cec5111
Signed-off-by: David Suarez <david.suarez.fuentes@gmail.com>
Siva Kumar Perumalla [Tue, 29 Aug 2017 21:22:55 +0000 (02:52 +0530)]
Bug 6349: try connecting to qthrift only when configured.
- default values are set to invalid host/port.
- verify whether port/host configured before connecting
Change-Id: I4cd19ad1e9844435f75f08f45962c67d555a7e39
Signed-off-by: Siva Kumar Perumalla <sivakumar.perumalla@ericsson.com>
Aswin Suryanarayanan [Thu, 31 Aug 2017 14:25:22 +0000 (19:55 +0530)]
Bug 8882 - With conntrack SNAT communication with PNF fails
Traffic from Non NAPT to PNF was failing, Since from non NAPT switch the
packet came through a tunnel port to NAPT Switch. There it was failing
since the vpn interface does not exist for tunnel port. Hence it fails
to identify the router id.
Now for the tunnel port the external ip associated with router used to
identify the vpnid.
Change-Id: I60081c050ca117c99ba1809efde49d71d0909bdb
Signed-off-by: Aswin Suryanarayanan <asuryana@redhat.com>
Michael Vorburger [Mon, 4 Sep 2017 17:25:48 +0000 (19:25 +0200)]
Bug 9102 Fix ReadOnlyTransaction leak in NeutronvpnUtils
by delegating to my SingleTransactionDataBroker, which correctly closed
the transaction. Also, the exception handling here is really wrong, but
that's not really related to the bug being fixed here, so separately,
later, someone, sometime... ;)
Change-Id: Id3ef558623b69bf155796200db397a4da11c8500
Signed-off-by: Michael Vorburger <vorburger@redhat.com>
David Suarez [Sun, 3 Sep 2017 14:51:16 +0000 (16:51 +0200)]
Cleanup
- Remove dead code
- Final class & private constructor for utility classes
- Return variables directly
- Add method qualifiers
- Join some if statements
Change-Id: I2ca3cc08cbe10e4885510f9fc6bcb7f684e48922
Signed-off-by: David Suarez <david.suarez.fuentes@gmail.com>
eupakir [Fri, 1 Sep 2017 08:44:21 +0000 (14:14 +0530)]
Bug 8953 - IllegalArgumentException: vrfEntry is missing mandatory
descendant origin
Change-Id: I74d6e503268414b0635a84007b36a1f9c0c0a8cc
Signed-off-by: eupakir <kiran.n.upadhyaya@ericsson.com>
Aswin Suryanarayanan [Wed, 30 Aug 2017 14:30:47 +0000 (20:00 +0530)]
Bug 9030 - port and port security groups cannot be null
Fixing an issue caused due to the removal of null check bindAcl in [1].
Which could cause bind service being called for port which has SG
disabled.
[1]https://git.opendaylight.org/gerrit/#/c/62346
Change-Id: Icd9e75f7b0bbfa448e49aa9109c8ea562a48be27
Signed-off-by: Aswin Suryanarayanan <asuryana@redhat.com>
Michael Vorburger [Tue, 29 Aug 2017 12:34:00 +0000 (14:34 +0200)]
Bug 9060: Package mdsal trace utility in netvirt Karaf distribution
This will make it easier to detect OOM issues such as Bug 9034 on scale
test environments, based on using the mdsal-trace DataBroker wrapper.
Change-Id: I3198bffac2a7fa434b0ab2a74d257ad42f064f51
Signed-off-by: Michael Vorburger <vorburger@redhat.com>
eupakir [Wed, 5 Jul 2017 13:03:39 +0000 (18:33 +0530)]
Bug 8801 - EVPN remote routes are not pushed to ovs flow table
Change-Id: I332f9cde34e1f716b3cb9e02585101055be6624b
Signed-off-by: eupakir <kiran.n.upadhyaya@ericsson.com>
eupakir [Wed, 23 Aug 2017 08:20:05 +0000 (13:50 +0530)]
Bug 8953 - IllegalArgumentException: vrfEntry is missing mandatory
descendant origin
The PNF deletion use cases were missing a few fixes in VPN and FIB
Engines.
1) Even though FIB was created using the external subnetId as the rd, the
external network id was being used to delete the FIB entries.
2) There was a fix in the PNF FIB add cycle to get vpn operational data
using the external network id instead of external subnet id. This was
missing in the deletion cycle.
Change-Id: Ida3125bf45beed1470ab699241988bd56a791a80
Signed-off-by: eupakir <kiran.n.upadhyaya@ericsson.com>
Signed-off-by: Vivekanandan Narasimhan <n.vivekanandan@ericsson.com>
Michael Vorburger [Wed, 23 Aug 2017 15:03:49 +0000 (17:03 +0200)]
bgpmanager BgpUtil code clean-up: Make private what can, and rm unused
Change-Id: I484c456e44d2414ef4f03f86b4b1e79d6fcd52bc
Signed-off-by: Michael Vorburger <vorburger@redhat.com>
Sam Hague [Tue, 29 Aug 2017 16:46:28 +0000 (16:46 +0000)]
Revert "Add git commit coala bear"
This reverts commit
12d10f57789a5a63cf1ae6133f64205f247ff0fd.
Change-Id: I23574392ac3e152585043839c38dd749aee7ed77
Signed-off-by: Sam Hague <shague@redhat.com>
Michael Vorburger [Wed, 23 Aug 2017 15:25:07 +0000 (17:25 +0200)]
Bug 9034: bgpmanager BgpUtil rm unused pendingWrTransaction
There's no set() for the pendingWrTransaction, so it's.. completely
pointless - and that retry loop in BgpConfigurationManager's
createStaleFibMap() could never have worked anyway, as
BgpUtil.getGetPendingWrTransaction() == 0, always.
Change-Id: I8644a3a9d63c5eff4106c58865cad9969d3990a2
Signed-off-by: Michael Vorburger <vorburger@redhat.com>
Faseela K [Mon, 28 Aug 2017 13:46:18 +0000 (19:16 +0530)]
L2 Support for Pods
Whenever the first pod under a namespace is created, an elan-instance
is created. Also for each pod interface an l2vlan trunk interface as
well as an elan-interface is created.
Change-Id: Ib32b987c8c86467ead8e0b4e38d3586d4fb93f70
Signed-off-by: Faseela K <faseela.k@ericsson.com>
Vivekanandan Narasimhan [Mon, 28 Aug 2017 15:05:22 +0000 (20:35 +0530)]
Bug 8860: NPE in getElanTag from SubnetmapChangeListener
The exception is genuine, but in order to enable tightening
of exception throws in netvirt, we are logging this
exception gracefully via this fix.
The real reason why this exception occurs can be ascertained
only the context information available when this issue happens
again in any upstream job.
The bug itself does not have link to logs that have this
exception thrown, for any postmortem/analysis.
Change-Id: I1c29efad5de85bfd340ea54a3600db9997c12a4b
Signed-off-by: Vivekanandan Narasimhan <n.vivekanandan@ericsson.com>
Sam Hague [Fri, 25 Aug 2017 16:14:21 +0000 (12:14 -0400)]
Add git commit coala bear
Depends-on: https://git.opendaylight.org/gerrit/62325
Change-Id: I8523b865d60afa16c1ceac1261ee01ce6e70378c
Signed-off-by: Sam Hague <shague@redhat.com>
Aswin Suryanarayanan [Wed, 23 Aug 2017 05:34:14 +0000 (11:04 +0530)]
Bug 9030 - port and port security groups cannot be null
The error logs are written when the port has no security groups. It is
perfectly fine for a port to not have security groups and hence lowering
the log level to info.
Removed the uneccsary null check of security groups while bind service
is called.
Change-Id: Ic386938e3ef14501798499abe5d82f3c63f329af
Signed-off-by: Aswin Suryanarayanan <asuryana@redhat.com>
Andre Fredette [Thu, 24 Aug 2017 20:05:46 +0000 (16:05 -0400)]
Bug 9051 - Failed to handle router GW flow in GW-MAC table. DPN id is missing for router-id
Change log level and message.
Change-Id: I94406443eb67c6fecfc8ecaaf349ed6cb2168b80
Signed-off-by: Andre Fredette <afredette@redhat.com>
Faseela K [Thu, 24 Aug 2017 06:06:11 +0000 (11:36 +0530)]
Coe renderer merge build failed due to groupId not present in aggregator
pom
Change-Id: Ia39b2d40efe6a1521631a8a6cd13cdc3a80ed78e
Signed-off-by: Faseela K <faseela.k@ericsson.com>
Michael Vorburger [Wed, 23 Aug 2017 15:07:30 +0000 (17:07 +0200)]
Bug 9034: bgpmanager BgpUtil rm unused BindingTransactionChain & Co.
Not sure if this fixed Bug 9034, but let us please remove this clearly
un-used Transcation Chain here - it's one less to worry about when
analyzing this OOM.
Change-Id: Ide872b7d439d5b25f6cd759c129cc29190b483cc
Signed-off-by: Michael Vorburger <vorburger@redhat.com>
Aswin Suryanarayanan [Wed, 23 Aug 2017 16:24:52 +0000 (21:54 +0530)]
Bug 9039 - In Conntrack SNAT, when a router g/w is cleared traffic is
dropped for other routers
Pfib flow is made per router for inbound and outbound traffic. The
metadata rewrite from internal to external for outbound traffic happens
in the PFIB table.
Change-Id: I17bc024e66c424459d8fe8b1ddf02a1d7a96d2bb
Signed-off-by: Aswin Suryanarayanan <asuryana@redhat.com>
Faseela K [Fri, 11 Aug 2017 20:46:58 +0000 (02:16 +0530)]
Initial Bundle setup for coe renderer
This patch adds the following :
1. coe-renderer-api and coe-renderer-impl bundles
2. Add them to respective features
3. COE Pod and Service Listener skeleton
Change-Id: Ibe692953d40c781a843cb8c4632a1aedd07ab087
Signed-off-by: Faseela K <faseela.k@ericsson.com>
Shashidhar Raja [Mon, 21 Aug 2017 14:20:21 +0000 (19:50 +0530)]
Bug 9022: ACL: Broadcast traffic is dropped in ACL tables
This fix enables ACL to permit Broadcast Traffic (Both IP and Non IP).
Related to IP Broadcast, Subnet-Directed Broadcast and All-Subnet
Broadcast traffic on the same network is being allowed subject to one of
the conditions specified below is met:
(a) The ports that want to communicate share the same
remote-secuirty-group
(b) The ports that want to communicate allow the other port's IP Address
in remote-ip-prefix
(c) The ports that want to communicate have securiyt0group with
remote-ip-prefix of 0.0.0.0/0.
IP Broadcast flows configured in VM Ingress ACL table (table 241) is as
below:
all-subnet flow:
cookie=0x6900000, duration=1463.293s, table=241, n_packets=0, n_bytes=0,
priority=61010,ip,dl_dst=ff:ff:ff:ff:ff:ff,nw_dst=255.255.255.255
actions=goto_table:242
subnet-directed flow:
cookie=0x6900000, duration=975.798s, table=241, n_packets=0, n_bytes=0,
priority=61010,ip,metadata=0x10000000000/0x1fffff0000000000,
dl_dst=ff:ff:ff:ff:ff:ff,nw_dst=10.1.1.255 actions=goto_table:242
Non IP Broadcast flows (with lower priority than other flows - 61005)
configured in VM Egress(211) and Ingress(241) tables is as below:
cookie=0x6900000, duration=30.298s, table=211, n_packets=0, n_bytes=0,
priority=61005,metadata=0x10000000000/0x1fffff0000000000,
dl_src=fa:16:3e:a9:4d:81 actions=resubmit(,17)
cookie=0x6900000, duration=901.855s, table=241, n_packets=0, n_bytes=0,
priority=61005,dl_dst=ff:ff:ff:ff:ff:ff actions=resubmit(,220)
Below are change details:
- Updated to add a flow to allow broadcast traffic with destination
adddress 255.255.255.255. Changes related to this are in
AclNodeListener.java
- Updated to add flows at port level for subnetwork's broadcast addresses
- Updated to add flows in 211/241 for Non-IP broadcast traffic
- Updated to add ARP/IP/IPv6 default drop flows with lower priority than
respective flows and higher priority than non-ip broadcast flow
- New yang definition introduced in ACL for higher modules (Neutron VPN
in our case) to pass broadcast CIDRs when ACL Interface is created
- NeutronVpn is updated to pass subnet CIDRs when ACL Interface is
created
Change-Id: I71c5040454b3c00af43dcef4f47b5979cd7cf3a5
Signed-off-by: Shashidhar Raja <shashidharr@altencalsoftlabs.com>
eupakir [Tue, 22 Aug 2017 05:47:52 +0000 (11:17 +0530)]
BUG 9014 : Remove unnecessary log statements in VPN Engine
Change-Id: I501beac66cc8f9ffc44d5f12b22514d7d3b03d22
Signed-off-by: eupakir <kiran.n.upadhyaya@ericsson.com>
K.V Suneelu Verma [Mon, 21 Aug 2017 11:21:27 +0000 (16:51 +0530)]
bug 9018 l2gw designated dhcp fix
Instead of listening for logical switch creation, listen for
mcast mac creation and update the mcast mac to avoid race of updating the
mcast mac.
while updating mcast mac read the existing mac and add designated dhcp tep
ip to the existing locators.
Change-Id: Id4d99471ae0b3be306a5511ee7cea975606deaa3
Signed-off-by: K.V Suneelu Verma <k.v.suneelu.verma@ericsson.com>
Sam Hague [Tue, 22 Aug 2017 11:57:06 +0000 (07:57 -0400)]
lower BGPconnect logs to debug level
Change-Id: Ied9756d8ea082d52bc6719a0fe42a6dcf52c25ce
Signed-off-by: Sam Hague <shague@redhat.com>
Faseela K [Sat, 19 Aug 2017 06:29:34 +0000 (11:59 +0530)]
Remove unused NatNodeEventListener
This listener does not have anything else other than debug statements.
This was seen while analyzing the delay in programming default flows
when switches are connected in scaled scenario. While trying to optimize
the number of listeners and heavy operations being done in listener
thread, this came to notice. There is no heavy operation here, but if
the listener is of no use, let us avoid one unnecessary registration.
Change-Id: I87f80b851472dba7364fe16c5d39d8ed775b2d67
Signed-off-by: Faseela K <faseela.k@ericsson.com>
Vyshakh Krishnan CH [Fri, 18 Aug 2017 09:05:15 +0000 (14:35 +0530)]
Bug 9012 : BGP reconnect and retry logic to QBGP
During the internal testing we have observed that for many configs, thrift is not reliable enough and QBGP is not receiving the configs ODL is sending. So as a safer way, introducing retries while sending the configs to QBGP. Also reconnect mechanism in case of any thrift transport exception
Change-Id: I9862d3db093f85399e81207c787528da25445999
Signed-off-by: Vyshakh Krishnan CH <vyshakh.krishnan.c.h@ericsson.com>
Sam Hague [Sun, 20 Aug 2017 11:35:33 +0000 (07:35 -0400)]
Bug 9014 - ElanUtils: buildRemoteDmacFlowEntry
Bug 9014 - ElanUtils: buildRemoteDmacFlowEntry: Could not find interfaceName
These logs are not errors as the tests pass. The data eventually is available in the datastore.
Change-Id: Id09647a642dc6023b4d34f37fa12839d6a077407
Signed-off-by: Sam Hague <shague@redhat.com>
Vivekanandan Narasimhan [Mon, 21 Aug 2017 05:33:20 +0000 (11:03 +0530)]
BUG 9014: Remove unnecessary Log statements for evpn/subnetroute
1.Modified error logs to debug logs in necessary places
from evpn rt2 code, especially which hits for non-evpn scenarios.
2. This cannot find portOp Error was earlier relevant
where race conditions existed between interface-state
event southbound and subnet-port openstack configuraiton from
northbound. Later we divided handling the subnetroute
creation into two batches to address the race condition
properly in [1].
As a result with [1] being merged, the error statement for
portOp is not required anymore and so this fix removes that
error statement.
[1] https://git.opendaylight.org/gerrit/#/c/61823/
Change-Id: Ic61f7ec5e3b9733f3e2f9a6bfc56af15c8af6d73
Signed-off-by: Vivekanandan Narasimhan <n.vivekanandan@ericsson.com>
ehvkand [Wed, 16 Aug 2017 09:42:03 +0000 (15:12 +0530)]
Bug 8960: port information for 1 dpn is missing in subnet-op-data and
port-op-data
Upon PL reboot , if southbound event (PortUP) event is received first and
northbound event(OnSubnetAddedToVpn) is received later ,DPN will not be
updated in PortOpData.
Fix :
(1) When northbound event is received , SubnetOpDataEntry is created
first by using clustered wide lock based on subnetId. Then PortOpDataEntry
and subnetToDpn is created.
(2)Incase southbound event is received first,PortOpData entry may not be
available.In such case subnetId is retrieved from Neutron cache and
PortOpData entry will be created by the SubnetInterfaceStateChangeListener
thread.
Change-Id: I3a0d9c814909e6031bd1e25dd32564415fb912d8
Signed-off-by: ehvkand <hanamantagoud.v.kandagal@ericsson.com>
Shashidhar Raja [Sun, 13 Aug 2017 03:22:49 +0000 (08:52 +0530)]
Bug 8981: ACL: ARP/DHCP anti-spoofing flows does not include VM/AAP ip/mac
matches in VM egress direction
ACL updated to include IP+MAC matches for ARP and MAC only matches for DHCP
with anti-spoofing flows in VM egress direction
Change-Id: If3e3de5a4ea66dc23c6bec5ba66881abb6cdbc0a
Signed-off-by: Shashidhar Raja <shashidharr@altencalsoftlabs.com>
Signed-off-by: Vivekanandan Narasimhan <n.vivekanandan@ericsson.com>
Sam Hague [Mon, 21 Aug 2017 00:49:56 +0000 (20:49 -0400)]
cleanup for erros that should be info
Change-Id: Ic81243d4fa03f173cfa6f140e7fc3c925e3533bf
Signed-off-by: Sam Hague <shague@redhat.com>
Sam Hague [Sun, 20 Aug 2017 01:33:55 +0000 (21:33 -0400)]
Use INFO for logging GW search misses
Change-Id: Ib240dfe59804b3f101ae3fe305c6960da3046624
Signed-off-by: Sam Hague <shague@redhat.com>
Vyshakh Krishnan CH [Wed, 16 Aug 2017 08:23:09 +0000 (13:53 +0530)]
Bug 8996 : BGP EOR and some minor fixes
Today ODL is sending the neigbour config to QBGP at the end of config replay. ie after VRFS and Netwroks. SO after a cluster reboot, neighborship establishment is taking time. A new EOR mechanishm is introducd, so that ODL can send the neighbor first. QBGP will wait for EOR from ODL to send the EOR to neighbor
Also some minor BGP fixes
Change-Id: Ib00827919aa227650ca9d7f345f40a0aed55124d
Signed-off-by: Vyshakh Krishnan CH <vyshakh.krishnan.c.h@ericsson.com>
Sam Hague [Sun, 20 Aug 2017 02:49:28 +0000 (22:49 -0400)]
Bug 9015 - Unable to install group
The code checking the response for the RPC was incorrectly assuming the future would return and Rpcresult.result
This job had extra debugging to show the result is coming back as null:
https://logs.opendaylight.org/releng/jenkins092/netvirt-csit-1node-openstack-ocata-gate-stateful-nitrogen/123/odl1_karaf.log.gz
2017-08-20 04:24:59,096 | INFO | nPool-1-worker-0 | NexthopManager | 302 - org.opendaylight.netvirt.fibmanager-impl - 0.5.0.SNAPSHOT | Group 150000 with key nexthop.
10000050.0.0.2/32 has been successfully installed directly on dpn
273623493589781. rpcResult: RpcResult [successful=true, result=null, errors=[]], isSuccessful: RpcResult [successful=true, result=null, errors=[]], getResult: true
Change-Id: Ie1717102b19aca85043ff7ddbba6bce6fbd6799d
Signed-off-by: Sam Hague <shague@redhat.com>
HANAMANTAGOUD V Kandagal [Fri, 11 Aug 2017 06:22:26 +0000 (11:52 +0530)]
Bug 8974: Fix subnet-directed-broadcast-addr ARP issue
Currently subnet-directed-broadcast-addr packets are punted to controller.
Controller sends a ARP request for the same IP address.
To avoid the same, FIB entry is added with subnet-directed-broadcast-addr
match and action to drop the packet instead of punting to controller.
Change-Id: I335a040d99e91d30fb75ad84cf18045eb21524e2
Signed-off-by: HANAMANTAGOUD V Kandagal <hanamantagoud.v.kandagal@ericsson.com>
eupakir [Fri, 11 Aug 2017 12:37:42 +0000 (18:07 +0530)]
Bug 8976 - Upstreaming fixes to master
This patch includes logging enhancements in the VPN Engine
Change-Id: I83c13f221cbf0299758e2e17580681c71aa7a80f
Signed-off-by: eupakir <kiran.n.upadhyaya@ericsson.com>
eupakir [Fri, 11 Aug 2017 10:28:10 +0000 (15:58 +0530)]
Bug 8976 - Upstreaming fixes to master
This patch contains fixes:
1) To capture the last advertised state for a subnet route
2) Fixes for iRT/eRT deletion use-cases
3) Some Logging enhancements for subnet route
Change-Id: If9290d41bd5851079ecf482a4eb33f1ba3991981
Signed-off-by: eupakir <kiran.n.upadhyaya@ericsson.com>
eaksahu [Wed, 16 Aug 2017 12:33:48 +0000 (18:03 +0530)]
Bug 8998 - L2GW:Vlan bindings missing on reboot
Vlan bindings are missing upon cluster reboot.
While processing physical switch node add event , its global node
is not available yet.
Enqueued this job to global node add pending job wait list so that
eventually after the global node is added this gets processed.
Handled the tunnel ip change of the physical switch.
When the tunnel ip changes delete old itm tunnels
create new tunnels with new tunnel ip
retrigger the l2gw connection processing to take affect of the
new tunnel ip.
Handled the local ucast macs that are added to the southbound device
while odl is down.
When odl comes up as part of processing its l2gw connections
it pulls the added local ucast macs from the southbound device.
Change-Id: Id6fdbbfe852a6fc0d89f360eb498fece8f00bdb5
Signed-off-by: eaksahu <a.k.sahu@ericsson.com>
eaksahu [Fri, 11 Aug 2017 09:47:18 +0000 (15:17 +0530)]
Bug 8978 - Network deletion issue.
Elaninstance after deletion was clearing l2gateway connection
configuration , but was not deleting l2gatewayConnection object itself
from neutron config tree. This leads to reconfiguration of
l2gatewayconnection upon reboot / device reconnect also.
Fixed the above case.
Added way to cancel logical switch deletion , so that if the same
network is reconfgured while deletion is going on , it can be cancelled.
Calling logical switch delete cancel when associating the same network
to l2gw.
Change-Id: I530c4b87becf3043eb8c4ba03226447731b2db0b
Signed-off-by: eaksahu <a.k.sahu@ericsson.com>
eaksahu [Wed, 9 Aug 2017 14:22:09 +0000 (19:52 +0530)]
Bug 8965 - L2gw update is not suported
Currently l2gw once created , no update are on that are supported.
With this patch following use case has been supported.
Update existing l2gw vlanbindings
Update existing l2gw with new ports / device .
It takes care of configuring w.r.t associated l2gwconnection .
Change-Id: I37dda9cf366b1fe59ccf95f64f0574448f156d47
Signed-off-by: eaksahu <a.k.sahu@ericsson.com>
Sam Hague [Sun, 20 Aug 2017 10:56:41 +0000 (06:56 -0400)]
Remove last remaining federation-plugin
Change-Id: I6e1698395a00365ed16eda518a36ed41e11cc758
Signed-off-by: Sam Hague <shague@redhat.com>
Sam Hague [Sun, 20 Aug 2017 01:45:33 +0000 (21:45 -0400)]
set BGP connect problem to be info
Change-Id: I828d273eab454fa48f01309fe10b8c54423216f7
Signed-off-by: Sam Hague <shague@redhat.com>
Achuth Maniyedath [Fri, 30 Jun 2017 19:12:09 +0000 (00:42 +0530)]
Bug 8774 DHCP Service to use DHCP Port MAC Address
Use DHCP Port MAC Address for responding to DHCP
discover/renew requests.
Change-Id: I00ab448fb2894fc1ae38084033294ab9acd69ab6
Signed-off-by: Achuth Maniyedath <achuth.m@altencalsoftlabs.com>
cgowdru [Thu, 17 Aug 2017 18:02:25 +0000 (23:32 +0530)]
Bug8861 : Data validation failed for path /snatint-ip-port-map
Description : When interface entry is deleted from interface-state OS,
in NAT InterfaceStateListener, as part of clean-up, we try to delete all
the SNAT sessions data assocaiated with that interface. But, an attempt was
done to delete an entry from snatint-ip-port-map even there doesn't exists any
SNAT translation resulting in this exception. Changes done to delete
snatint-ip-port-map ony if an valid entry exists.
Change-Id: Ic0d4fa08b91700c2b4a63ab6e613d7554741d413
Signed-off-by: cgowdru <chetan.arakere@altencalsoftlabs.com>
Faseela K [Sat, 19 Aug 2017 10:04:57 +0000 (15:34 +0530)]
Fix Junit failures in master in ACL & SFC
The junits were broken after the recent commit in yangtools
https://git.opendaylight.org/gerrit/#/c/48672/
Change-Id: Ib37cb57de2c59d558f89b9723f685071fee9ff3b
Signed-off-by: Faseela K <faseela.k@ericsson.com>
Sridhar Gaddam [Fri, 18 Aug 2017 16:59:09 +0000 (22:29 +0530)]
Bug 8926: Fix instance doesn't get an IP after deployment
In a fresh multinode deployment with Controller node running
ODL + dhcp-agent and a Compute node, when we spawn a first VM
on the compute node, it was seen that VM does not acquire the
IPAddress.
On debugging, it turns out that the remote broadcast group
entries were not programmed on the Compute node. This is a
timing/sync issue between Netvirt (Elan) and GENIUS. The
bug description explains the issue in detail and this patch
addresses the issue.
Change-Id: Ifee63e13cf330dd3056468eba95e6451e173e30b
Signed-off-by: Sridhar Gaddam <sgaddam@redhat.com>
Kency Kurian [Thu, 10 Aug 2017 11:45:23 +0000 (17:15 +0530)]
Bug 8973 : DHCP fixes
1. For SR-IOV vm dhcp request:
After controller restart it was found that the DHCP flows were being installed
as drop on the designated DPN.
Added a check to see if the DPN being added is already a designated DPN
then, drop flows need not be installed.
2. Added a null check for gateway ipaddress and also whenver getIpv4Address
is called.
3. Added a null check for l2gwdevice in installRemoteMCastMac.
Change-Id: I2fae322af07b582fa4e5a03522513976dd2c55e5
Signed-off-by: Kency Kurian <kency.kurian@ericsson.com>
Stephen Kitt [Mon, 3 Jul 2017 13:12:25 +0000 (15:12 +0200)]
Bug 8982: avoid .transform() NPEs
Guava’s Optional::transform doesn’t support null values returned by
the mapping function — it throws a NPE if that happens. java.util’s
Optional::map does support null values and returns an empty Optional.
Combined with the current YANG-based code’s ability to return null,
this means it’s better to use java.util’s method; this patch switches
all YANG-based Optional transforms to java.util.
Change-Id: I304762b8eed03480760d36ae6903cdb495bd7b05
Signed-off-by: Stephen Kitt <skitt@redhat.com>
Abhinav Gupta [Fri, 11 Aug 2017 12:01:42 +0000 (17:31 +0530)]
Bug 8979: Logging enhancements for VPNService
This fixes logging issues related to non-parametrization of logs, printing
of exceptions, changing log levels for a few logs.
These changes have been made across NeutronVPN primarily, and also a bit
for VPNManager and FIBManager
Change-Id: Ice4b206ada6cc591f96ef75eccd820683b21a647
Signed-off-by: Abhinav Gupta <abhinav.gupta@ericsson.com>
Sam Hague [Thu, 17 Aug 2017 15:39:29 +0000 (11:39 -0400)]
rm it module
Change-Id: I0865195683a45adcef787365c4e91e217eb7e514
Signed-off-by: Sam Hague <shague@redhat.com>
Sam Hague [Thu, 17 Aug 2017 15:43:32 +0000 (11:43 -0400)]
rm federation plugin
Change-Id: I2972254584cce0ed42213590683f2b2aab5ea678
Signed-off-by: Sam Hague <shague@redhat.com>
Vishal Thapar [Thu, 17 Aug 2017 14:46:28 +0000 (20:16 +0530)]
Use correct namespace for lockmanager
Requires: https://git.opendaylight.org/gerrit/#/c/61934/
Change-Id: I554f53945e4e3f7a6a28809bbb5d79cd6f483f5e
Signed-off-by: Vishal Thapar <vishal.thapar@ericsson.com>
Manuel Buil [Thu, 10 Aug 2017 14:47:31 +0000 (16:47 +0200)]
BUG: Adapt SFC translator to SFC code in Nitrogen
BUG: 8966
SFC Translator must start using logical SFF otherwise it will not work
Change-Id: Iec8dd6ae757d230464162dd1612bcda3a8fd0f26
Signed-off-by: Manuel Buil <mbuil@suse.com>
Signed-off-by: Jaime Caamaño Ruiz <jaime.caamano.ruiz@ericsson.com>
Jaime Caamaño Ruiz [Mon, 14 Aug 2017 14:21:28 +0000 (16:21 +0200)]
BUG 9003: Support source-logical-port acl match
Neutron flow classifier includes acl matches for source and destination
neutron ports. Added support for source port, and updated the model to
also include destination port although not supported yet.
Change-Id: I83f8cc362869d046cdce756b5cbe4b13215b75f0
Signed-off-by: Jaime Caamaño Ruiz <jaime.caamano.ruiz@ericsson.com>
Jaime Caamaño Ruiz [Mon, 14 Aug 2017 17:46:29 +0000 (19:46 +0200)]
BUG 9003: Fix port chain event triggered two times
Change-Id: I4dd83824808d3faa2f515901d9171bb8e812d681
Signed-off-by: Jaime Caamaño Ruiz <jaime.caamano.ruiz@ericsson.com>
Jaime Caamaño Ruiz [Mon, 14 Aug 2017 17:45:56 +0000 (19:45 +0200)]
BUG 9003: Fix classifier entry processing order
Change-Id: Icfafe3ef3a77bd48e3ddcf249f6c1e41b3e57aa5
Signed-off-by: Jaime Caamaño Ruiz <jaime.caamano.ruiz@ericsson.com>
eupakir [Mon, 14 Aug 2017 07:02:31 +0000 (12:32 +0530)]
Bug 8945 - Missing key is getVrfId. Supplied key is VpnInstanceOpDataEntryKey
On a router delete, the internal VPN for that router was being removed
before handling external networks associated to that router.
Releasing router based lport tags, which is part of L3VPN Over VxLAN,
depends on vpn operational data, but the vpn data was being deleted much
before handling external networks for that router.
Change-Id: I72c0ff142b3929808afcfa7e49589b5420f48510
Signed-off-by: eupakir <kiran.n.upadhyaya@ericsson.com>
Michael Vorburger [Wed, 12 Jul 2017 21:34:36 +0000 (03:04 +0530)]
vpnmanager DJC enqueueJob without using AbstractDataStoreJob API
because when we moved genius.DJC to infrautils.JC we had concluded that
this method does not need to be exposed publicly, and (at the time) was
only used in 1 place (here).
In order to be able to eventually remove genius.DJC and switch to
infrautils.JC, adjusting this use to be compatible with the new API is a
first step.
Change-Id: Ia025cc542096ce417b35f57cdc723ebc9528ab14
Signed-off-by: Michael Vorburger <vorburger@redhat.com>
Thanh Ha [Mon, 14 Aug 2017 17:32:25 +0000 (13:32 -0400)]
Bump versions by x.(y+1).z for next dev cycle
Change-Id: Ibacad85a349937fa2a27554577419fdc8ceb4349
Signed-off-by: Thanh Ha <thanh.ha@linuxfoundation.org>
Sam Hague [Fri, 11 Aug 2017 23:29:13 +0000 (23:29 +0000)]
Revert "Bug 8960: port information for 1 dpn is missing in subnet-op-data and port-op-data"
This reverts commit
679f82391862995bfea11011c217ba7a1a91cb5c.
Change-Id: I62bb7890803d5e5b51cf6f1d1bc359eeac75eb13
Signed-off-by: Sam Hague <shague@redhat.com>
Robert Varga [Wed, 9 Aug 2017 21:41:26 +0000 (23:41 +0200)]
Do not catch Throwable
Java code should never catch Errors, which catching Throwable does.
Catching Exceptions is more than adequate.
Change-Id: Iee3ae475438b7f872cb8f4a07dcd0187dc73657c
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
Kency Kurian [Thu, 10 Aug 2017 10:17:08 +0000 (15:47 +0530)]
Bug 8972: dhcp-show does not display the defaults
dhcp-show was not printing the default config values for lease time and
domain.
Also earlier the default value was hardcoded in this CLI instead of
fetching from thr constants file defined.
Change-Id: Ie5c3542bad7fd73bbe9aec5ab438ec46a1c3f87e
Signed-off-by: Kency Kurian <kency.kurian@ericsson.com>
Signed-off-by: Sam Hague <shague@redhat.com>
Philippe Guibert [Wed, 26 Jul 2017 09:08:24 +0000 (10:08 +0100)]
BUG-8894 : display VPN interface count number for each VPN instance.
This value is displayed correctly in shell function.
vpn-instance-op-show --detail.
Change-Id: I9817aef44bc4b56889132aea3f17791b239bb7fd
Signed-off-by: Philippe Guibert <philippe.guibert@6wind.com>
Philippe Guibert [Fri, 7 Jul 2017 12:08:30 +0000 (13:08 +0100)]
Bug 8821 : BGP Manager / BGP counter incorrect with VPNv6 prefixes
The commit consists in not only counting separately the prefixes for
VPNv4, VPNv6, and EVPN; but also sums all previous values to get the
total numver of prefixes. That counter obtained wast taking into account
only VPNv4. Now it includes VPNv6.
Change-Id: I1c6b4acb98870ae919ef06c229537abbd966697b
Signed-off-by: Philippe Guibert <philippe.guibert@6wind.com>
Achuth Maniyedath [Thu, 11 May 2017 18:32:50 +0000 (00:02 +0530)]
Neutron Port allocation for DHCP Service
The feature enables DHCP service to make use of the
newly created Neutron ports provisioned by Openstack
networking-odl driver at the time of Subnet creation.
Additionaly an ARPResponder flow is also introduced to
service the ARP requests for these ports during VM
DHCP renewal.
All ArpResponder handling for Router interface gateway,
floating IP and DHCP ports will be moved to ElanService,
introducing a pipeline change for ARP handling.
LPort Dispatcher Table(17) -> ARP Check Table(43) -> ARPResponder Group
-> ELAN Base Table(48), ARP Responder Table(81), Controller
-> Egress Dispatcher Tabel (220)
Change-Id: If1c787c50bd3054766caaa6b11e6c8023402cce4
Depends-On: I2dce5e253d3c94180dd18e51125c5c18170b5c69
Signed-off-by: Achuth Maniyedath <achuth.m@altencalsoftlabs.com>
Signed-off-by: Vijayalakshmi Chickkamenahalli Nagaraju <vijayalakshmi.c@altencalsoftlabs.com>
Signed-off-by: karthik.p <karthik.p@altencalsoftlabs.com>
HANAMANTAGOUD V Kandagal [Wed, 9 Aug 2017 09:20:35 +0000 (14:50 +0530)]
Bug 8960: port information for 1 dpn is missing in subnet-op-data and
port-op-data
Upon PL reboot , if southbound event (PortUP) event is received first and
northbound event(OnSubnetAddedToVpn) is received later ,DPN will not be
updated in PortOpData.
Fix :
(1) When northbound event is received , SubnetOpDataEntry is created first
by using clustered wide lock based on subnetId.
Then PortOpDataEntry and subnetToDpn is created.
(2)Incase southbound event is received first,PortOpData entry may not be
available.In such case subnetId is retrieved from Neutron cache and
PortOpData entry will be created by the SubnetInterfaceStateChangeListener
thread.
Change-Id: I92ed4aa801cfcbc2da37366149b7c5f2fba2ed4c
Signed-off-by: HANAMANTAGOUD V Kandagal <hanamantagoud.v.kandagal@ericsson.com>
Signed-off-by: ehvkand <hanamantagoud.v.kandagal@ericsson.com>
Stephen Kitt [Tue, 8 Aug 2017 16:14:07 +0000 (18:14 +0200)]
Bump odlparent 2.0.2 to 2.0.4
Change-Id: I5e1f577b3aea966b2340a89eb4010707e27f2628
Signed-off-by: Stephen Kitt <skitt@redhat.com>
karthikeyan [Wed, 19 Jul 2017 09:12:03 +0000 (14:42 +0530)]
Bug 8863: NPE at VpnFloatingIpHandler
Problem Description:
=======================
The following exception was observed from VpnFloatingIpHandler in CSIT
Error in generate label or fib install process
java.lang.NullPointerException: Supplied value may not be null
org.opendaylight.netvirt.natservice.internal.VpnFloatingIpHandler.lambda$onAddFloatingIp$0(VpnFloatingIpHandler.java:194)[307:org.opendaylight.netvirt.natservice-impl:0.5.0.SNAPSHOT]
Solution:
=========
We need to enhance the pre-condition check in VpnFloatingIpHandler before
proceeding with any DNAT flow installation.
Have added the required null check for floatingIp ADD/REMOVE methods.
Change-Id: Ic516f8afc325a1e6eb515481abb2d0fef411336a
Signed-off-by: karthikeyan <karthikeyan.k@altencalsoftlabs.com>
HANAMANTAGOUD V Kandagal [Wed, 9 Aug 2017 13:08:16 +0000 (18:38 +0530)]
Bug 8962: Fix non-parameterized LOG statements as per guidelines
Non parameterized LOG statement are suspected to take more CPU cycles than
parameterized one. Hence all non-parameterized logs are enhanced.
Also some more log enhancement for better debuggability.
Change-Id: I60d258aeb30ecd4c8442e7a2e6316b21844bb3e5
Signed-off-by: HANAMANTAGOUD V Kandagal <hanamantagoud.v.kandagal@ericsson.com>
Sam Hague [Thu, 27 Jul 2017 21:13:05 +0000 (17:13 -0400)]
Docs: add supported combinations
Change-Id: I74bb7ec19059d44238c6449180c745cba11e149c
Signed-off-by: Sam Hague <shague@redhat.com>
HANAMANTAGOUD V Kandagal [Wed, 9 Aug 2017 07:56:01 +0000 (13:26 +0530)]
Bug 8958: Java Null pointer exception for display vpn-config after
deleting a vpn from CLI
When no VPN configuration is present in CONFIG datastore , success was
being returned in GetL3VPNOutput RPC. This lead to null ptr exception.
Now error message is being returned in RPC which is handled appropriately
and null ptr exception is avoided.
Change-Id: I04bce7a07cd933decf11de11e86ea958d26b7b86
Signed-off-by: HANAMANTAGOUD V Kandagal <hanamantagoud.v.kandagal@ericsson.com>