Fix pep8 violations in service_classifier.py

Change-Id: Ie6d31085cdcf5909dee0b5138bd1d48c5af2f2c3
Signed-off-by: Thanh Ha <[email protected]>

Fix pep8 violations in classifier.py

Change-Id: I8f511fc5caf3b14105c08c6265bf82dbf7f5e735
Signed-off-by: Thanh Ha <[email protected]>

Skip flake8 for nfq_class_server

Change-Id: I0e49c9ceb822b0c85bffbcde85be69ed9e61a81c
Signed-off-by: Thanh Ha <[email protected]>

Fix pep8 violations in common/services.py

Change-Id: I4016151f8f3a6c233749bb5543eea7d3b1562fd6
Signed-off-by: Thanh Ha <[email protected]>

Fix pep8 violations for common/launcher.py

Change-Id: Ic282eac1de7cf8743c6c7c173cbc39925597ab1d
Signed-off-by: Thanh Ha <[email protected]>

Fix pep8 violations in logging_config.py

Change-Id: I10920a83b92df1199dc8c23b8ff99ddb3aa0ee4b
Signed-off-by: Thanh Ha <[email protected]>

Add .tox/ to .gitignore

Change-Id: Icbbaca30fb484f74940b2b10cb8830ec970c48bd
Signed-off-by: Thanh Ha <[email protected]>

Fix pep8 violations in ovs_cli.py

Change-Id: I0f0fb0914176d70ff1b8176ac3b7300bdf4db761
Signed-off-by: Thanh Ha <[email protected]>

Fix pep8 violations in nsh/common.py

Change-Id: Id1c4a756eab5a2b2ab27e8c3f534993185b4d63b
Signed-off-by: Thanh Ha <[email protected]>

Fix pep8 violations in nsh/encode.py

Change-Id: I1bb455d57b1881d3fb94289ac607927b598c430f
Signed-off-by: Thanh Ha <[email protected]>

Fix pep8 violations in nsh/decode.py

Change-Id: Ice70ecb629a66b8fffb735f3a9683e8cd461244d
Signed-off-by: Thanh Ha <[email protected]>

Fix pep8 in sfc_agent.py

Change-Id: I4454ecfa60bc724ca3487d4e986b022eec67643b
Signed-off-by: Thanh Ha <[email protected]>

Fix pep8 in odl2ovs_cli.py

Change-Id: I2d20b0578e43d4fefc1fc141640e7ac470b429d5
Signed-off-by: Thanh Ha <[email protected]>

Fix pep8 in pysf_oldnsh.py

Change-Id: I505b4d01e98ab41e1cfb2b03af74532e6287f8a0
Signed-off-by: Thanh Ha <[email protected]>

Fix pep8 violations in odl2ovs.py

Change-Id: Ie8e9d26ab5a1474e60a2657fa59e8268fc313df9
Signed-off-by: Thanh Ha <[email protected]>

Add tox.ini to run flake8

Change-Id: Ib46b8e5970cb220e4c99b3f7a3c1b12d81772afb
Signed-off-by: Thanh Ha <[email protected]>

Merge "SFC Traceroute and OAM"

Merge "SFF locator name is filled in corresponding RSP leaf"

SFC Traceroute and OAM

Change-Id: I03e5f574d1f620a5945f8a1599594b3a9c97cc22
Signed-off-by: Reinaldo Penno <[email protected]>

Merge " SFC-PY - NFQ classifier"

SFF locator name is filled in corresponding RSP leaf

- first SFF locator is taken (as everywhere else in code)

Change-Id: I92270aa16124f87104ff04f543562c4ddd38310f
Signed-off-by: Andrej Kincel <[email protected]>

Merge "Remove <repositories> and <pluginRepositories> sections"

Merge "Add rpc for readRenderedServicePathFirstHop"

Add rpc for readRenderedServicePathFirstHop

Change-Id: Id7a1721343bdc1cb2e14ea1329d7647e0018dab8
Signed-off-by: Yi Yang <[email protected]>

 SFC-PY - NFQ classifier

Update docstrings, add some TODOs, introduce parse_ace()

Change-Id: Ifa7ba44fb72b789fca1be6d89a5237dd5b1483cf
Signed-off-by: Dusan Madar <[email protected]>

Merge "Statistics Yang model should be set to false"

SFCOFL2 minor bug fixes

- Added mac location type
- Improved logs
- minor bug fixes in SfcL2RspDataListener
- minor bug fixes in SfcL2AclDataListener
- SFCOFL2 still not complete, waiting for RSP hop ingress DPL which is coming soon.

Change-Id: I6b0b3822262434ebf44dafc4a31b5cfddf47c826
Signed-off-by: Brady Johnson <[email protected]>

Quick fixing SFC-UI

- due to restructure in DLUX, select2 js library was missing
  and preventing whole SFC-UI to load

- DLUX modularity should be working now, meaning that we need
  to rework the way SFC is integrated with DLUX

- this means adding dlux-feature instead of pulling only dlux-web bundle
 (the problem is that DLUX may be dependent on some AD-sal stuff)

Change-Id: I1fb1ef428178e855dcc1be8f2222d9d2b7f2d880
Signed-off-by: Andrej Kincel <[email protected]>

Fix for SingleFeatureTest

- As proposed by Colin Dixon on the Release mailing list

Change-Id: I555fb2eed55ced90d750a1eb4d8f625ed173471e
Signed-off-by: Brady Johnson <[email protected]>

Statistics Yang model should be set to false

Change-Id: Ibf5d2bc40fd9c4186c9ae0558dfce9c1e78ddb0b
Signed-off-by: Reinaldo Penno <[email protected]>

Fixing classifier regression tests

Change-Id: I70af3612d62f478648f89e4c7cb4a78fe55fd5b3
Signed-off-by: Andrej Kincel <[email protected]>

SFC/NSH Traceroute Fixes

- Fixed packet generation
- Fixed TLV generation for multi-hops
- Fixed SF test to add header for multi-hop
  scenario

Change-Id: I01b92f84e5d5dfacb61da17ef047db235c3b96e2
Signed-off-by: Reinaldo Penno <[email protected]>

Merge "SFC-PY - NFQ classifier"

SFC Statistics Yang Model

- Ideally devices could push these stats to ODL.
- We will change SFC agent to do just that
- Alternatively ODL could poll when UI/RESTconf
  requested the stats.

Change-Id: I8e5301af6328391c62532bd450c59e11b1586110
Signed-off-by: Reinaldo Penno <[email protected]>

Removing unused code and fixing Sonar

Change-Id: I9eaca5c7dc2c2ed03b3ffdc676a36cee67efbdee
Signed-off-by: Reinaldo Penno <[email protected]>

Remove <repositories> and <pluginRepositories> sections

It is recommended that developers and servers configure this locally via
settings.xml.

https://lists.opendaylight.org/pipermail/discuss/2015-January/004482.html

Change-Id: I0b78e64bf6bada7d5ab5832d5244a31a6c3114b7
Signed-off-by: Thanh Ha <[email protected]>

Data Plane Services Decoding Bug

- With the rework of the service code a decoding bug was
  introduced. Instead of passing a reference to the
  data payload, a reference to a data structure was
  passed to decoding function

Change-Id: I2a06a58183725967fe586195cc74058ae3dbf620
Signed-off-by: Reinaldo Penno <[email protected]>

SB REST & Agent fixes

- Try/catch to deal with invalid UUIDs
- Fixed services name in agent nat->napt44

Change-Id: I8cc485f67c1de3f0e838f1e7339e0c74ba087f8b
Signed-off-by: Reinaldo Penno <[email protected]>

SFC-PY - NFQ classifier

Add classifier/classifier.py which will serve as the NFQ classifier.
Work still in progress.

Change-Id: I7971d45a90b0035f41ed16e6ee4e83ad1fb12c3f
Signed-off-by: Dusan Madar <[email protected]>

Automatic Creation of RSP

- In order to maintain backward compatibility and at the
  same time allow multiple encaps automatic RSP will
  be created when the SFP has no constaints or
  modifiers.

- This also simplies for the user because it is one
  less step.

Change-Id: Ib44c0bbda38a19210d5e615593519c65bf3b7a6d
Signed-off-by: Reinaldo Penno <[email protected]>

SFC-GBP Integration: Multi Encap support I

- Each service-hop in the RSP will have a reference to a
  SFF data plane locator. This allows any combination
  of encap types. Until now VXLAN/NSH was exclusively
  used.

- Added API to get RSP first hop. It returns all
  NSH info + transport type + assocaited locator

- Disabled code to generate RSPs from SFPs automatically

- SFP can specify the transport-type for RSP creation.
  If nothing is given, default will be VXLAN-GPE+NSH

- (todo) RSP creation will pick SFF data plane locators
  that match the SFP transport type

- This will cleanly allow SFC to provide a straightforward API
  to get first SFF and associated data plane locator

- Fix RSP API naming bug

- Fixed SF Chain yang state

- Added API to read data plane locator of a certain SFF

- Added RSP first hop container to RSP yang model

Change-Id: Ia70ecbc50bf7b171e3ac727ad5cd5c27754948e5
Signed-off-by: Reinaldo Penno <[email protected]>

Refactor SFCOFL2 to support MPLS

SfcL2RspDataListener.java
SffGraph.java
- Added SffGraph to create a simple graph of the
  SFFs using the RSP rendered-service-path-hop.
- This allows for multiple DataPlaneLocators, which
  wasnt supported in SFCOFL2 previously.

SfcL2AclDataListener.java
- Read from RSP, not SFP

SfcL2FlowProgrammer.java
SfcOpenflowUtils.java
- refactor to use newer table structure
- now supports MPLS
- now both of these files are in the same l2renderer.openflow package

SfcL2FlowProgrammerInterface.java
- All flow programming is performed against an interface
- this will allow us to easily use an OVS impl later
-- For each SFF in the RSP check if its OF or OVS and use the corresponding impl
- this also makes it easier to unit test

SfcProviderRenderedPathAPI.java
- Added readRenderedServicePathExecutor and related methods

service-locator.yang
- Added MPLS

SfcOpenflowUtilsTest.java
- Update to reflect refactored code

Change-Id: I44f09885924ecc9ae9c67c0a356105b742ee207f
Signed-off-by: Brady Johnson <[email protected]>

Merge "SFC-NSH TRaceroute Phase II"

Change the deprecated APIs into the latest API in sfc provider

Signed-off-by: Hongli Chen <[email protected]>

SFC-NSH TRaceroute Phase II

Fixed some bugs on packet generation
When addind SF type and name to trace response packet
 SF pads with null to 32-bit boundary and encoded with UTF-8

Sending Trace packet to Service Path and Service Index: (13, 255)
Trace response...
Service-hop: 0. Service Type: firewall, Service Name: SF1, SFF Reporting Address: ('10.0.1.4', 18300)

Change-Id: Ic094f7e3970e5b69f5062ae5a4efa85489d6c9d8
Signed-off-by: Reinaldo Penno <[email protected]>

Creating set of ACL matches for classifier regression tests

+ classifier must be able to parse and configure all given
  types of ACL matches - IPV4, IPV6 and MAC

Change-Id: I87946ec1c829e94ba5cf9177e1cdcead079d170e
Signed-off-by: Andrej Kincel <[email protected]>

SFC-PY - fix sff_client.py, sfc_classifier_regression_messages.py

Fix sff_client.py when running without the '--trace-req' flag.
Fix sfc_classifier_regression_messages.py to always set 'path-id' to 1.

Change-Id: I0858492729896fb2c76e411ac574d813bbd66abf
Signed-off-by: Dusan Madar <[email protected]>

Sfcofl2 - fixing dependency on not more existing feature

- odl-flow-model feature was migrated to odl-openflowplugin-nsf-model feature
- odl-openflowplugin-nsf-model is contained in odl-openflowplugin-all, thus for fix only odl-flow-model should be removed

- also dependencies on model-flow-base and model-flow-service should be changed, as the bundles were migrated from controller to openflow project

Change-Id: I1c7528e926ce9a6eca0ada9f5cfc244a694f8eae
Signed-off-by: Andrej Kincel <[email protected]>

SFC-NSH Traceroute

Change-Id: If350902a96c29bb863b5cd2d17ec01e57d63fcbe
Signed-off-by: Reinaldo Penno <[email protected]>

Merge "Sfc-UI: fixing SFF SFdictionary data plane locator issues"

SFC-PY - fix launcher bug introduced by commit d4cdeca27ff688c9a427f94dc5c58fd3b17efe9e

Changes in commit d4cdeca27ff688c9a427f94dc5c58fd3b17efe9e breaks service stopping.

launcher.py - manage asynchronous threads starting/stopping.

Change-Id: I5ededc9f42b548578a94e96002fead12d99dbf16
Signed-off-by: Dusan Madar <[email protected]>

Sfc-UI: fixing SFF SFdictionary data plane locator issues

+ removed classifier from SFF (as it no longer exists in YANG model)

Change-Id: I570480886abe1b2eb3b21a7f6315132c9a8e4c37
Signed-off-by: Andrej Kincel <[email protected]>

Fixing service index

Change-Id: I29146435e08d3ffa3dab2be41c9162a7a8b04802
Signed-off-by: Reinaldo Penno <[email protected]>

SB REST: Enhancing Classifier listener

+ SB REST Classifier listener can send DELETE ACL message based only on ACLname (no need to fetch whole ACL DataObject)

+ SbRestAbstractTask: json is not more required. WsTask can work with json=null, even POST and PUT operations are working without exception: json=null causes only that REST message will not have any payload.

+ Fixed key service-index to service_index in sfc_agent.py

Change-Id: I16e447e41c3ff9cd47da6fdc36ceb6dbe569e9ff
Signed-off-by: Andrej Kincel <[email protected]>

Changing service_index to service-index everywhere

- Agent needs to gracefully handle data plane
  locators with something other than IP

Change-Id: Id855f137cbe620cba3de798ed6a7dc409330d6c7
Signed-off-by: Reinaldo Penno <[email protected]>

Bug when storing thread in dict

- First level dict needs to be assigned empty before
  second level can be assigned otherwise you get
  a keyError exception

Change-Id: I95dc963b65647cce60456454481cef2d6da329a9
Signed-off-by: Reinaldo Penno <[email protected]>

Logging level needs to be set before logging starts

- First message that prints the service type was not
  visible

Change-Id: I8baac6c2269b970bf5526236973261f35d7681f4
Signed-off-by: Reinaldo Penno <[email protected]>

SFC Agent needs to fail gracefully when:

- ODL has no SFFs configured
- Interfaces have no address or no IPv4 address

Change-Id: I1dfd55afed06f16cb2f2a635c51f3eb4bf64e703
Signed-off-by: Reinaldo Penno <[email protected]>

Change UDP Server to SFF Server to be more descriptive

Change-Id: Ia38887d9b3982fc04c54966adc3e78a06174d510
Signed-off-by: Reinaldo Penno <[email protected]>

Merge "Regenerate YANG XMLs used for dynamic Sfc-UI generation"

Merge "SB REST: Tests for SbRest*Task"

SFC-PY - refactor: update *_cli.py files

Make ovs_cli.py and xe_cli.py PEP 8 compliant.

Change-Id: I5d5f1228d251bd7d80ab588c29a8c0dd7734b106
Signed-off-by: Dusan Madar <[email protected]>

SFC-PY - refactor: move classfier related files to the classifier/ directory

Move nfq_class_server.py, nfq_class_thread.py and service_classifier.py to the classifier/ directory.

Fix related imports.

Change-Id: I111499e6879a5743c8634efb0c4ae5bf7f17d2a7
Signed-off-by: Dusan Madar <[email protected]>

Regenerate YANG XMLs used for dynamic Sfc-UI generation

Change-Id: I36bc5c2eead9128160ef2f1deb9e6641e7d402dd
Signed-off-by: Andrej Kincel <[email protected]>

SB REST: Tests for SbRest*Task

+ Test for SbRestAclTask
+ Test for SbRestSfTask
+ Test for SbRestSffTask
+ Test for SbRestRspTask

Change-Id: I8e4f2ce3864385a1e4078fdbf717199b5495841f
Signed-off-by: Andrej Kincel <[email protected]>

YANG Model changes to add MPLS to SFC

Also added HTTP Header Enrichment Service Function Type

Change-Id: I727b612b9619c5481c4c36a7faee02818a996b75
Signed-off-by: Brady Johnson <[email protected]>

SFC-PY - refactor

Rename common/sff_globals.py to common/sfc_globals.py, remove old [and unused] sff_globals.py, fix related imports.

sfc_agent.py: move starting, stopping threads to common/launcher.py, make the file PEP 8 compliant.

Change-Id: I74026b2c3d03bbe6c492db1c0ee401c62a80700d
Signed-off-by: Dusan Madar <[email protected]>

SFC-PY - refactor

Remove old nsh_*.py files (forget to remove them after copying to the nsh/ directory).

Make nsh/ directory content PEP 8 compliant.

Fix related imports.

Change-Id: I036c56ee438b8d7ed7e478d01ddf836b42f1528d
Signed-off-by: Dusan Madar <[email protected]>

Fixing SFC OVS build issue with southbound config file

Change-Id: I44b39afe4f8cc1208c6b7425b6352ef037ea8e6d
Signed-off-by: Reinaldo Penno <[email protected]>

SFC-PY - common:launcher.py

Fix logging error.

Change-Id: If43b8f51c5ca4d28f927cbcf357ccece4b770ca5
Signed-off-by: Dusan Madar <[email protected]>

SFC-PY - start refactor

Add 'common' and 'nsh' package, remove sf/sff_thread.py, basic sfc_agent.py refactor.

Change-Id: I7e5e5abe28e5f531f49bf4708e8d483c41e21ca6
Signed-off-by: Dusan Madar <[email protected]>

Merge "Bringing SFC OVS back into the fold"

Merge "SB REST - Exporters refactor & unit test"

Bringing SFC OVS back into the fold

Change-Id: Ia04b7c68ddf8aaea139f0a2a5b496003d6535d11
Signed-off-by: Reinaldo Penno <[email protected]>

SFC-PY - refactor

Move odl2ovs.py, odl2ovs_cli.py and pysf_oldnsh.py to 'unused/' directory

Change-Id: Iefdc2b1a8485c76c60fbd4781cf5b582b0d5c85d
Signed-off-by: Dusan Madar <[email protected]>

SFCOFL2 should only work with OpenFlow switches

- put a check in SfcL2RspDataListener to only work with OpenFlow SFFs
- Minor improvements to the  SFCOFL2 ACL listener

Change-Id: I1e005c41d869265a28f0cec0147030e75e4bbfb2
Signed-off-by: ebrjohn <[email protected]>

SB REST - Exporters refactor & unit test

+ JSON generated by Exporters is not containing pairs of key:null
anymore. This makes the work of target SB devices (e.g. sfc_agent) easier.
In other words, JSON now contains only valid key:value pairs.

+ Fixed exportJsonNameOnly to return an JSON array as top level (the same
behaviour as exportJson). In fact exportJsonNameOnly is not necessary
anymore.

+ Major refactor of Utils, SfExporter and SffExporter

+ Added test for AcLExporter
+ Added test for RspExporter
+ Added test for SfExporter
+ Added test for SffExporter
+ Added test for ExporterUtil

+ Fixed service_index key in sfc_agent.py

Change-Id: I0e78dc10cee50ae3bd526fe8b462934097c0002d
Signed-off-by: Andrej Kincel <[email protected]>

Removing OVS Southbound Dependency to Normalize Build

Change-Id: I0d7b28a4a595a3da3abdaab52ae3303bd1d50c22
Signed-off-by: Reinaldo Penno <[email protected]>

Fixing Compilation Problems

Change-Id: If36838a9952421ccd8187fd10f8f002f943234f4
Signed-off-by: Reinaldo Penno <[email protected]>

SFC OVS Implementation

- Listener
- Mapper

Change-Id: I69077352db740a43787ebec5fb19f0d8210f89f6
Signed-off-by: Reinaldo Penno <[email protected]>

Adding delete classifier operation to regression tests

Change-Id: I936c3442f990b99fc4da190a330f564d10beaf49
Signed-off-by: Andrej Kincel <[email protected]>

Merge "Adding Classifier regression tests"

Adding Classifier regression tests

- just very simple topology of 1 SF and 1 SFF

Classifier is not able to pass this test nowadays.

Change-Id: I3241a67f09ee38ff0e323ea89604a82a03e96f9d
Signed-off-by: Andrej Kincel <[email protected]>

Minor bug fixes and logging improvements

SfcL2AclDataListener should listen to ACL_ENTRY_IID
iSfcL2FlowProgrammer should write flows to CONFIGURATION, not OPERATION

Change-Id: Ic09c699d7c43db55b7efedc82634e8078850034c
Signed-off-by: ebrjohn <[email protected]>

Javadoc fixes

Change-Id: I31152213a09817355c8fd7df95149072a7cdfed8
Signed-off-by: Reinaldo Penno <[email protected]>

Merge "Classifier functionality - fixes"

Sfc-ui: FIX for width calculation of SN topology graph

Width was calculated too early, when element containing SNs graphs
was not set to proper width.

$timeout service waits until DOM is rendered and then calculates the width
of SNs graphs and adds them to DOM

Change-Id: I1f2cf847809e2a83bf7a335345b88aabf5c8a36b
Signed-off-by: Andrej Kincel <[email protected]>

Classifier functionality - fixes

(fixed) AclExporter was exporting RSP action with wrong json key
(fixed) UI was using wrong json key

+ changes to classifier python script necessary for testing

Change-Id: Ibe819120490bfc42ad33b53934074e8b0a11bcaa
Signed-off-by: Andrej Kincel <[email protected]>

Do not redefine odlparent-provided versions

These versions match the ones in odlparent -- no need to repeat them.

Change-Id: Id90d5833b26c6a65b0d7d50431c646342b70573f
Signed-off-by: Robert Varga <[email protected]>

BUG-1173: do not hard-code guava version

odlparent defines the version upstream, no need to repeat it here.

Change-Id: I0916819ef3cc44faf1b0abfec3aeb22b1dfcd219
Signed-off-by: Robert Varga <[email protected]>

SFC Agent Improvements

- Moved SFF topology to global agent class
- Fixed several return codes
- When SF/SFF locator can not be deermined, path construction fails.
- Added parent-service-path field to RSP regression test

Change-Id: I00f5f270678cc2926eb3559c4a7014b5f31942d1
Signed-off-by: Reinaldo Penno <[email protected]>

SFC Agent creates Service Functions

- SFC agent creates service function based on messages
  received from ODL. No need to start separate script or
  know any IP addresses.

Change-Id: I0644ba63ed397e351f078887a854a0bba4462add
Signed-off-by: Reinaldo Penno <[email protected]>

SB REST Critical Fixes - V

- SF Agent now processes SF PUT/POST correctly
- SF agent creates Service Function threads
- Moved more globals into new agent global class
- First implementation of SF DELETE message
- other misc

Change-Id: I797f54487c081fdf37f83c8613819ccc76549e1e
Signed-off-by: Reinaldo Penno <[email protected]>

SB REST fixes and enhancements

(fixed) AclExporter returns List of one ACL
(fixed) SfExporter returns List of one SF

(fixed) SbRestScfListener had bad operation on DELETE

+ improved and added log messages for better debugging
+ AclTask repeating code placed into methods

Change-Id: I4cb645eacd3ca6d5116adc07f1cfa2a4aa478dec
Signed-off-by: Andrej Kincel <[email protected]>

SB REST Listeners can not assume REST URI always present

Change-Id: I00557f0e5d99cb47b40dafb71e1367e8c10b59eb
Signed-off-by: ebrjohn <[email protected]>

Fix unecessary exception in Monitor code.

For every SF, there was a nullPointerException in the
monitor code, if there wasnt a mountPoint configured.
Added a simple null check to avoid the exception.

Change-Id: Ie5e7aa3437ce70eef545e8a10c49b940837522b5
Signed-off-by: ebrjohn <[email protected]>

SB REST SF Listener can not assume REST URI always present

- Also started implementing code to process SF messages on agent.

Change-Id: I7526c859f2a26d0529ddf5cba6584571aac5396d
Signed-off-by: Reinaldo Penno <[email protected]>

Sfc-UI: service-locator identityref namespace fix

+ macAddress validation fix

Change-Id: Ief84cf8b8a9a1312b932efa11cb4e2b7261afa47
Signed-off-by: Andrej Kincel <[email protected]>

SB REST Critical Fixes - IV

- (fixed) SFF Delete REST message not sent
- (fixed) Delete HTTP method can not have JSON payload
- (fixed) log message without %s
- Misc javadoc fixes

Change-Id: If03e49b7af5527f6cc294f32dfa7799a835ba0ca
Signed-off-by: Reinaldo Penno <[email protected]>

Merge "Add get SF's capability and monitoring data and store them into datastore."