ovsdb.git
10 years agoUpgrading Yangtools to 0.6.1-SNAPSHOT and hopes it wont cause any runtime issues 18/4918/1
Madhu Venugopal [Mon, 27 Jan 2014 18:05:27 +0000 (10:05 -0800)]
Upgrading Yangtools to 0.6.1-SNAPSHOT and hopes it wont cause any runtime issues

Change-Id: I3d4d64d684b31c38b5b6c6c7a380bd60a7de6cff
Signed-off-by: Madhu Venugopal <mavenugo@gmail.com>
10 years agoMoving Tunnel Out to the appropriate place and cleaned up some logs. 86/4886/1
Madhu Venugopal [Mon, 27 Jan 2014 14:44:00 +0000 (06:44 -0800)]
Moving Tunnel Out to the appropriate place and cleaned up some logs.

Change-Id: I3cc8a8654f85cae2d823114aedd605ee1505241f
Signed-off-by: Madhu Venugopal <mavenugo@gmail.com>
10 years agoFixed a class cast exception when the Node-ID is a Long that got casted to String. 45/4845/1
Madhu Venugopal [Mon, 27 Jan 2014 08:36:50 +0000 (00:36 -0800)]
Fixed a class cast exception when the Node-ID is a Long that got casted to String.

Change-Id: I4aa0aa32836fc8ebd0d6275959e2affec7a9c544
Signed-off-by: Madhu Venugopal <mavenugo@gmail.com>
10 years agoMoved InstructionBuilder order and key in OF13ProviderManager 40/4840/2
Brent Salisbury [Mon, 27 Jan 2014 06:05:12 +0000 (01:05 -0500)]
Moved InstructionBuilder order and key in OF13ProviderManager
to the OVSDB tunnel implementation.

Signed-off-by: Brent Salisbury <brent.salisbury@gmail.com>
10 years agoMerge "Fixed the Repositories and PluginRepositories directives to include nexus...
Brent Salisbury [Mon, 27 Jan 2014 04:20:01 +0000 (04:20 +0000)]
Merge "Fixed the Repositories and PluginRepositories directives to include nexus group repo."

10 years agoFixed the Repositories and PluginRepositories directives to include nexus group repo. 38/4838/3
Madhu Venugopal [Mon, 27 Jan 2014 04:12:53 +0000 (20:12 -0800)]
Fixed the Repositories and PluginRepositories directives to include nexus group repo.

Change-Id: I22387a09781daffbd68fee6f62122b8b38a6c6ce
Signed-off-by: Madhu Venugopal <mavenugo@gmail.com>
10 years agoChange OF13_Provider to ovsdb.of.version in config.ini 36/4836/3
Dave Tucker [Sun, 26 Jan 2014 23:17:40 +0000 (23:17 +0000)]
Change OF13_Provider to ovsdb.of.version in config.ini

- Defaults to "1.0" when no provider is set in config.ini
- Values other than "1.0" and "1.3" will get the OF10Provider
- Case statement added so providers for other versions can be esaily inserted

Change-Id: I878f594ce2b84c5809c7a8077e04fbb76c2fece8
Signed-off-by: Dave Tucker <dave.j.tucker@hp.com>
10 years agoInternal Vlan deletion and Tunnel Deletion cleanup 33/4833/1
Madhu Venugopal [Sun, 26 Jan 2014 23:02:17 +0000 (15:02 -0800)]
Internal Vlan deletion and Tunnel Deletion cleanup

Change-Id: Ib5ba447ac95ca5f733095ea774a318490b3aa4f5
Signed-off-by: Madhu Venugopal <mavenugo@gmail.com>
10 years agoRemove call to networkCreated in NetworkHandler 19/4819/2
Dave Tucker [Sun, 26 Jan 2014 19:19:41 +0000 (19:19 +0000)]
Remove call to networkCreated in NetworkHandler
Tenant VLAN assignment is handled as part of the interface update.
This now means that each node does not need to allocate a VLAN for each tenant.

Change-Id: If817e54a603e2abb3312b9c98a0104dee128cfb2
Signed-off-by: Dave Tucker <dave.j.tucker@hp.com>
10 years agoOVSDB Log Cleanup 95/4795/3
Dave Tucker [Sun, 26 Jan 2014 12:19:19 +0000 (12:19 +0000)]
OVSDB Log Cleanup

Change-Id: I811c28b4f45d7eb5fa8656b65381059b1928a911
Signed-off-by: Dave Tucker <dave.j.tucker@hp.com>
10 years agoFix ConnectionService to remove stale connections from the ovsdbConnections list 76/4776/2
Dave Tucker [Sat, 25 Jan 2014 22:25:03 +0000 (22:25 +0000)]
Fix ConnectionService to remove stale connections from the ovsdbConnections list

Change-Id: Ie6c23aab01858aeebc2bbd4b6a76a1993ed8d91d
Signed-off-by: Dave Tucker <dave.j.tucker@hp.com>
10 years agoDROP and FLOOD/Broadcast Support 84/4784/2
Madhu Venugopal [Sun, 26 Jan 2014 04:49:19 +0000 (20:49 -0800)]
DROP and FLOOD/Broadcast Support

Change-Id: I6cbf14382c9855387e052e133a2c91baad017283
Signed-off-by: Madhu Venugopal <mavenugo@gmail.com>
10 years agoAdded fix to prevent re-adding tunnel that was just deleted. 76/4576/4
Thomas Bachman [Sat, 25 Jan 2014 21:46:05 +0000 (16:46 -0500)]
Added fix to prevent re-adding tunnel that was just deleted.

Change-Id: I0b2275d986dfb5a93fb22794634caa130b4fa795
Signed-off-by: Thomas Bachman <tbachman@yahoo.com>
10 years agoReplace tenantVlanMap with a per Node cache 01/4601/15
Dave Tucker [Wed, 22 Jan 2014 17:12:33 +0000 (17:12 +0000)]
Replace tenantVlanMap with a per Node cache

Change-Id: I8c2aeb9960443bd9d7e51315f69f499631c91b69
Signed-off-by: Dave Tucker <dave.j.tucker@hp.com>
10 years agoResolved the OF10 to OF13 transition issues during devstack bootup. 56/4756/3
Madhu Venugopal [Sat, 25 Jan 2014 02:29:30 +0000 (18:29 -0800)]
Resolved the OF10 to OF13 transition issues during devstack bootup.

Change-Id: I9f449655096de60e9747c7c5a269db1bb8e14ab9
Signed-off-by: Madhu Venugopal <mavenugo@gmail.com>
10 years agoRelease root pom should have a relative path 63/4763/1 ovsdb-bulk-release-prepare-only-6
Giovanni Meo [Sat, 25 Jan 2014 11:43:09 +0000 (12:43 +0100)]
Release root pom should have a relative path

- This should be able to fix the wrong tagging calculation

Change-Id: I5991ed4e00951b26e73d55ad27bf1477dd54c907
Signed-off-by: Giovanni Meo <gmeo@cisco.com>
10 years agoFix for bug 278 Replace implementation of dbCache in InventoryService with a Concurre... 18/4618/7 ovsdb-bulk-release-prepare-only-4 ovsdb-bulk-release-prepare-only-5
Dave Tucker [Thu, 23 Jan 2014 06:28:16 +0000 (06:28 +0000)]
Fix for bug 278 Replace implementation of dbCache in InventoryService with a ConcurrentHashMap Replace implementation of cache in NodeDB with a ConcurrentHashMap

Change-Id: I95549730117d5ce330524cb63098e2e931c61a29
Signed-off-by: Dave Tucker <dave.j.tucker@hp.com>
10 years agoFixing a pom file issue that fails the dry-run 33/4733/2 ovsdb-bulk-release-prepare-only-3
Madhu Venugopal [Fri, 24 Jan 2014 18:29:44 +0000 (10:29 -0800)]
Fixing a pom file issue that fails the dry-run

Change-Id: Idc364a4cfdbd916a6070b986b419685a2c53e100
Signed-off-by: Madhu Venugopal <mavenugo@gmail.com>
10 years agoFix to use MacAddress for Mask for Ethernet Matches 68/4668/2 ovsdb-bulk-release-prepare-only-2
Ed Warnicke [Fri, 24 Jan 2014 02:51:01 +0000 (20:51 -0600)]
Fix to use MacAddress for Mask for Ethernet Matches

Goes with:
https://git.opendaylight.org/gerrit/#/c/4638/ (openflowplugin)
https://git.opendaylight.org/gerrit/#/c/4635/ (controller)

Change-Id: I10303d6c1dd3bf2ac60d1383e5645ce341fb2390
Signed-off-by: Ed Warnicke <eaw@cisco.com>
10 years agoReorganized the Local port programming to support the missing single node case &... 24/4624/1
Madhu Venugopal [Thu, 23 Jan 2014 08:02:12 +0000 (00:02 -0800)]
Reorganized the Local port programming to support the missing single node case & All the local forwarding.

Also, moved the Flow-IDs from a static value to a unique id per flow.

Change-Id: I878324dae28dd81d67f3a9761e479f5108843340
Signed-off-by: Madhu Venugopal <mavenugo@gmail.com>
10 years agoMerge "Removed the tunnelEndpoint cache Tunnel Endpoint address is now pulled directl...
Madhu Venugopal [Wed, 22 Jan 2014 15:29:49 +0000 (15:29 +0000)]
Merge "Removed the tunnelEndpoint cache Tunnel Endpoint address is now pulled directly from the Open_vSwitch table"

10 years agoRemoved the tunnelEndpoint cache 33/4533/6
Dave Tucker [Tue, 21 Jan 2014 22:29:52 +0000 (22:29 +0000)]
Removed the tunnelEndpoint cache
Tunnel Endpoint address is now pulled directly from the Open_vSwitch table

Change-Id: I1a7292d2e4921c3d9461c79112a4a68d5fb5f33a
Signed-off-by: Dave Tucker <dave@dtucker.co.uk>
10 years agoRemoved printstacktrace method call from ProviderManager. 40/4540/1 ovsdb-bulk-release-prepare-only-1
Madhu Venugopal [Wed, 22 Jan 2014 05:04:35 +0000 (21:04 -0800)]
Removed printstacktrace method call from ProviderManager.

Change-Id: I43c239476fa5b46bd36a4e98e4140e040cac9b56
Signed-off-by: Madhu Venugopal <mavenugo@gmail.com>
10 years agoSet the default fail-mode as secure and make sure to set the Openflow Type appropriat... 37/4537/1
Madhu Venugopal [Wed, 22 Jan 2014 00:33:07 +0000 (16:33 -0800)]
Set the default fail-mode as secure and make sure to set the Openflow Type appropriately on both insert and update case.

Change-Id: Ic0c0e3330ca0c511fb2704b7572d08e9b8ca57a8
Signed-off-by: Madhu Venugopal <mavenugo@gmail.com>
10 years agoOVSDB Neutron & OpenFlow 1.3 integration 70/4470/1
Madhu Venugopal [Tue, 21 Jan 2014 05:24:24 +0000 (21:24 -0800)]
OVSDB Neutron & OpenFlow 1.3 integration

This commit brings in a major portion of OVSDB Neutron & Openflow1.3 integration pieces & is
built on top of Brent's OF1.3 work.

Change-Id: Ic0edef2d52175aad873759513d20f42efc8dc23c
Signed-off-by: Madhu Venugopal <mavenugo@gmail.com>
10 years agoMerge "Fixed a typo in pom.xml s/includeArtifacIds/includeArtifactIds"
Madhu Venugopal [Sun, 19 Jan 2014 10:52:28 +0000 (10:52 +0000)]
Merge "Fixed a typo in pom.xml s/includeArtifacIds/includeArtifactIds"

10 years agoFixed a typo in pom.xml s/includeArtifacIds/includeArtifactIds 84/4384/1
Brent Salisbury [Sun, 19 Jan 2014 09:51:09 +0000 (04:51 -0500)]
Fixed a typo in pom.xml s/includeArtifacIds/includeArtifactIds

Change-Id: Ibcd8d2dbe3ffb500b58c966aef52029a8504cd8c
Signed-off-by: Brent Salisbury <brent.salisbury@gmail.com>
10 years agoOVSDB support for controller restart scenario to work along with Neutron interface. 80/4380/1
Madhu Venugopal [Sun, 19 Jan 2014 08:52:20 +0000 (00:52 -0800)]
OVSDB support for controller restart scenario to work along with Neutron interface.

With the Controller support for neutron config save/restore in, this fix handles the next level
of bootup handling in the ovsdb's neutron handling.
Essentially, the southboundhandler triggers the update for the existing OVSDB connection and that
handles all the programming needs.

Change-Id: Ic72af4eb5d456ac09dcce4eed6bd3cb03804b45f
Signed-off-by: Madhu Venugopal <mavenugo@gmail.com>
10 years agoMerge "Added OF v1.3 flowmod builders for neutron integration."
Madhu Venugopal [Fri, 17 Jan 2014 19:48:55 +0000 (19:48 +0000)]
Merge "Added OF v1.3 flowmod builders for neutron integration."

10 years agoAdded OF v1.3 flowmod builders for neutron integration. 48/4348/2
Brent Salisbury [Fri, 17 Jan 2014 10:29:11 +0000 (05:29 -0500)]
Added OF v1.3 flowmod builders for neutron integration.

Change-Id: Ibbe6123d12bea1d72e097552628a4f22d61a80be
Signed-off-by: Brent Salisbury <brent.salisbury@gmail.com>
10 years agoFixed the OVSDB Northbound API Postman Script that works with the Jackson Upgrade 43/4343/1
Madhu Venugopal [Fri, 17 Jan 2014 08:21:14 +0000 (00:21 -0800)]
Fixed the OVSDB Northbound API Postman Script that works with the Jackson Upgrade

Change-Id: If5b8f744eaaecd38fa6ee96b16268529bcb691c8
Signed-off-by: Madhu Venugopal <mavenugo@gmail.com>
10 years agoDeleted the POSTMAN script that got invalid after the jackson upgrade. 42/4342/1
Madhu Venugopal [Fri, 17 Jan 2014 08:19:15 +0000 (00:19 -0800)]
Deleted the POSTMAN script that got invalid after the jackson upgrade.

Change-Id: Ic9bdd7e62cc7f26df41262c14d9b23fae48b8ce1
Signed-off-by: Madhu Venugopal <mavenugo@gmail.com>
10 years agoMerge "Refactored IT's to remove dependency on com.google.code.gson.internal.Pair...
Madhu Venugopal [Thu, 16 Jan 2014 13:15:16 +0000 (13:15 +0000)]
Merge "Refactored IT's to remove dependency on com.google.code.gson.internal.Pair Renamed IT's to fix typos and keep case consistent"

10 years agoMake automagically adding a controller to each detected bridge after connecting an... 12/4012/6
Hugo Trippaers [Fri, 3 Jan 2014 13:09:06 +0000 (14:09 +0100)]
Make automagically adding a controller to each detected bridge after connecting an OVS node a configurable setting. The default is ovsdb.autoconfigurecontroller=true

I've seen multiple configurations where the ip address of a host is configured on the bridge interface.
So for example there is one bridge (cloudbr0) and one interface (eth0). Eth0 would be added as a port to cloudbr0 and the ip address of the host would be configured on cloudbr0. This is actually the recommended configuration when using CloudStack with a Xen or KVM hypervisor running OVS. I've seen this configuration is multiple other setups as well.
When a node with this configuration is added to the ODL controller, all communication will be blocked as a controller implies that the switch will be flow based. This causes ovsdb to lose communication to the outside world and effectively isolates the hypervisor from the network.

This commit adds a property to configure this feature from config.ini. Set "ovsdb.autoconfigurecontroller" to true to configure controllers on all detected openvswitch bridges.

Change-Id: I8285bd2b8a7000997b4b62373bd9e02457c93d8e
Signed-off-by: Hugo Trippaers <hugo@trippaers.nl>
10 years agoRefactored IT's to remove dependency on com.google.code.gson.internal.Pair 77/4277/1
Dave Tucker [Wed, 15 Jan 2014 18:59:46 +0000 (18:59 +0000)]
Refactored IT's to remove dependency on com.google.code.gson.internal.Pair
Renamed IT's to fix typos and keep case consistent

Change-Id: I97bf39df8a8a6b127309a495e1a8b58cba92d291
Signed-off-by: Dave Tucker <dave.j.tucker@hp.com>
10 years agoHarmonize the use of <scm> in pom.xml files 32/4232/2
Lorand Jakab [Tue, 14 Jan 2014 16:38:27 +0000 (18:38 +0200)]
Harmonize the use of <scm> in pom.xml files

Modify pom.xml files to have the same <scm> section.  Fix typo in some
of the <developerConnection> URLs.

Change-Id: I761cbc67d5230470501eacd8f474ec113c8a73d7
Signed-off-by: Lorand Jakab <lojakab@cisco.com>
10 years agoUpdate to new version of the artifacts proposed by jenkins-ovsdb-version-changes-1 40/4240/1
Jenkins ovsdb silo [Wed, 15 Jan 2014 00:23:40 +0000 (00:23 +0000)]
Update to new version of the artifacts proposed by jenkins-ovsdb-version-changes-1

Change-Id: I89d7c9944b76265650ebbc1839e1cf012b63ec77
Signed-off-by: Jenkins ovsdb silo <jenkins-ovsdb@daylight7.linux-foundation.org>
10 years agoFix build error, due to changes in FlowId: https://git.opendaylight.org/gerrit/#... 55/4155/1
Flavio Fernandes [Mon, 13 Jan 2014 03:08:45 +0000 (22:08 -0500)]
Fix build error, due to changes in FlowId: https://git.opendaylight.org/gerrit/#/c/4058/

Changes to fix build were based on changes done in commit 45b75a6ba76bf8b453b5f0de11ceb0c3bba1e842, file:
.../opendaylight/md-sal/statistics-manager/src/main/java/org/opendaylight/controller/md/statistics/manager/StatisticsUpdateCommiter.java

Change-Id: I635c7530cd9897d7c0ee8f1cb5209869c90f24b5
Signed-off-by: Flavio Fernandes <ff@member.org>
10 years agoMerge "Fixing the ColumnSchema as per RFC7047 for a enum variable."
Brent Salisbury [Fri, 10 Jan 2014 05:16:41 +0000 (05:16 +0000)]
Merge "Fixing the ColumnSchema as per RFC7047 for a enum variable."

10 years agoFixing the ColumnSchema as per RFC7047 for a enum variable. 26/4126/1
Madhu Venugopal [Fri, 10 Jan 2014 05:06:34 +0000 (21:06 -0800)]
Fixing the ColumnSchema as per RFC7047 for a enum variable.

Enums are defined as a 1 or more atomic-type and hence the current Object[] is incorrect
and is causing deser issues with vtep schema. Fixing it with a more generic Object.
This will be properly accomodated when we have schema driven OVSDB approach is in place.

Change-Id: I0c1d2896ea34bbc3c358ca0d0818860908e0b1b1
Signed-off-by: Madhu Venugopal <mavenugo@gmail.com>
10 years agoMove the java 1.7 config to the parent pom into pluginManagement so it is enforced... 11/4011/4
Madhu Venugopal [Thu, 9 Jan 2014 02:29:33 +0000 (18:29 -0800)]
Move the java 1.7 config to the parent pom into pluginManagement so it is enforced for neutron and northbound as well.
Merge failed due to conflicts and hence manually applying Hugo's changes on his behalf.

Change-Id: Ia704984f29c5f6a3371d27ad78001f904c54bb3a
Signed-off-by: Madhu Venugopal <mavenugo@gmail.com>
10 years agoUpdating the commons parent pom to 1.4.1-SNAPSHOT and checkstyle fixes 41/4041/2
Madhu Venugopal [Thu, 9 Jan 2014 21:36:00 +0000 (13:36 -0800)]
Updating the commons parent pom to 1.4.1-SNAPSHOT and checkstyle fixes

ovsdb project depends on the controller project's 1.4.0-SNAPSHOT version of commons pom.xml.
Since the latest changes (including the jackson upgrade) is done on 1.4.1-SNAPSHOT, we have
to update to the latest.
While doing so, it caught quite a few checkstyle errors, which am fixing it along.

Change-Id: Id650ffbae93f47121a7d259d0b39c6b537c2a992
Signed-off-by: Madhu Venugopal <mavenugo@gmail.com>
10 years agoMerge "Added Mockito and PowerMock to the neutron pom.xml Unit test coverage for...
Madhu Venugopal [Thu, 9 Jan 2014 02:39:36 +0000 (02:39 +0000)]
Merge "Added Mockito and PowerMock to the neutron pom.xml Unit test coverage for AdminConfigManager Unit test coverage for NetworkHandler"

10 years agoMerge "Prevent NPE when an interface is already present on the switch, but no related...
Madhu Venugopal [Thu, 9 Jan 2014 02:17:24 +0000 (02:17 +0000)]
Merge "Prevent NPE when an interface is already present on the switch, but no related port is configured."

10 years agoMerge "Small Java related improvements."
Madhu Venugopal [Thu, 9 Jan 2014 02:02:11 +0000 (02:02 +0000)]
Merge "Small Java related improvements."

10 years agoPrevent NPE when an interface is already present on the switch, but no related port... 10/4010/1
Hugo Trippaers [Fri, 3 Jan 2014 12:30:26 +0000 (13:30 +0100)]
Prevent NPE when an interface is already present on the switch, but no related port is configured.

Change-Id: I966b412d06450f75ea8940dc413b9973ec1fc1d1
Signed-off-by: Hugo Trippaers <hugo@trippaers.nl>
10 years agoAligning Jackson to the Controller's l latest upgrade (2.3.0). Also updated the north... 03/4003/1
Madhu Venugopal [Thu, 2 Jan 2014 22:25:14 +0000 (14:25 -0800)]
Aligning Jackson to the Controller's l latest upgrade (2.3.0). Also updated the northbound bundle to use the latest Jackson.

Due to this change, the ovsdb.northbound bundle will start to accept and respond OVSDB JSON messages in the same format as
expected by the ovsdb-server. (i.e) a set will be represented as ["set",[]] instead of the common sense [].
This is due to the ovsdb requirement as specified in the RFC / Draft.

Change-Id: I3a1a2548f1b8c87d1d4b63f5952d6fabaa6f3d33
Signed-off-by: Madhu Venugopal <mavenugo@gmail.com>
10 years agoSmall Java related improvements. 78/3978/1
Alissa Bonas [Mon, 30 Dec 2013 15:59:26 +0000 (17:59 +0200)]
Small Java related improvements.

Remove redundant return statement from void method,
remove redundant boxing of numeric variables,
remove statements that check a condition that is always 'true',
add braces to 'if else' statements.

Signed-off-by: Alissa Bonas <abonas@redhat.com>
10 years agoAdded Mockito and PowerMock to the neutron pom.xml 51/3951/3
Dave Tucker [Sat, 28 Dec 2013 20:19:37 +0000 (20:19 +0000)]
Added Mockito and PowerMock to the neutron pom.xml
Unit test coverage for AdminConfigManager
Unit test coverage for NetworkHandler

Change-Id: Ice7582e2a9f4dd5a4b7c9fdac01e86196f48ccf4
Signed-off-by: Dave Tucker <dave@dtucker.co.uk>
10 years agoOVSDB project's OpenFlow 1.3 ProtocolPlugin integration via Controller's MD-SAL infra... 89/3889/1
Madhu Venugopal [Sat, 21 Dec 2013 21:57:39 +0000 (13:57 -0800)]
OVSDB project's OpenFlow 1.3 ProtocolPlugin integration via Controller's MD-SAL infrastructure

This checkin brings in the basic infrastructure changes needed to integrate the ovsdb.neutron bundle
with OpenFlow1.3 via the Controller's MDSAL infrastructure. The actual work of mapping the multi-table
and various Flow programming can be done now over this infra.

Change-Id: Ia3b73e4be243fe597c8996a676cd648c6a960d62
Signed-off-by: Madhu Venugopal <mavenugo@gmail.com>
10 years agoUpdating netty to 4.0.10 version (same as the controller project). 82/3882/1
Madhu Venugopal [Fri, 20 Dec 2013 22:31:09 +0000 (14:31 -0800)]
Updating netty to 4.0.10 version (same as the controller project).

Change-Id: I8732aa5439fc250b070c0e26e008fdb65928d4ad
Signed-off-by: Madhu Venugopal <mavenugo@gmail.com>
10 years agoMerge "Updating the OVSDB project to use the LATEST known Controller bundle's SNAPSHO...
Brent Salisbury [Fri, 20 Dec 2013 04:48:50 +0000 (04:48 +0000)]
Merge "Updating the OVSDB project to use the LATEST known Controller bundle's SNAPSHOT version."

10 years agoMerge "Modified a few fields from OVSDB ambiguity"
Madhu Venugopal [Fri, 20 Dec 2013 04:44:55 +0000 (04:44 +0000)]
Merge "Modified a few fields from OVSDB ambiguity"

10 years agoModified a few fields from OVSDB ambiguity 29/2629/4
Brent Salisbury [Wed, 18 Dec 2013 00:13:23 +0000 (19:13 -0500)]
Modified a few fields from OVSDB ambiguity

Change-Id: Id86437e91ea77e76e2685c9209cb92b3f3b1e5c3
Signed-off-by: Brent Salisbury <brent.salisbury@gmail.com>
10 years agoUpdating the OVSDB project to use the LATEST known Controller bundle's SNAPSHOT version. 60/3860/2
Madhu Venugopal [Fri, 20 Dec 2013 01:10:13 +0000 (17:10 -0800)]
Updating the OVSDB project to use the LATEST known Controller bundle's SNAPSHOT version.

As discussed in the TSC meeting, with this change, the OVSDB project is upto-date with the Controller bundle SNAPSHOT version as of today.

Change-Id: I8456aea40161912b8f40f1737e7440920ce7ef77
Signed-off-by: Madhu Venugopal <mavenugo@gmail.com>
10 years agoMerge "Added folder for ovsdb.neutron tests. Created unit tests for BaseHandler."
Madhu Venugopal [Wed, 18 Dec 2013 20:44:05 +0000 (20:44 +0000)]
Merge "Added folder for ovsdb.neutron tests. Created unit tests for BaseHandler."

10 years agoAdded folder for ovsdb.neutron tests. 79/3779/3
Dave Tucker [Tue, 17 Dec 2013 01:43:19 +0000 (01:43 +0000)]
Added folder for ovsdb.neutron tests.
Created unit tests for BaseHandler.

Change-Id: Icde417fdd969a86a633da960ca36dbc713ddb76a
Signed-off-by: Dave Tucker <dave@dtucker.co.uk>
10 years agoMerge "Removed the floodEntries cache and relying on FRM's flow cache directly for...
Brent Salisbury [Tue, 17 Dec 2013 18:39:42 +0000 (18:39 +0000)]
Merge "Removed the floodEntries cache and relying on FRM's flow cache directly for updating the flood entries with new tunnels."

10 years agoMerge "Moved all Openflow 1.0 specific flow programming away from InternalNetworkMana...
Brent Salisbury [Tue, 17 Dec 2013 18:38:04 +0000 (18:38 +0000)]
Merge "Moved all Openflow 1.0 specific flow programming away from InternalNetworkManager to OF10ProviderManager class."

10 years agoRemoved the floodEntries cache and relying on FRM's flow cache directly for updating... 98/3798/1
Madhu Venugopal [Tue, 17 Dec 2013 17:30:21 +0000 (09:30 -0800)]
Removed the floodEntries cache and relying on FRM's flow cache directly for updating the flood entries with new tunnels.

With many caches/databases that we rely upon, we are taking a concious decision to avaoid caching data in our bundles
but rely on existing and tested dbs in the system. With that philosophy, it is good to have 1 less cache :-).

Change-Id: Ibc3273d86c34e58bd14b1f1e8869ceebcedc6c60
Signed-off-by: Madhu Venugopal <mavenugo@gmail.com>
10 years agoMoved all Openflow 1.0 specific flow programming away from InternalNetworkManager... 86/3786/1
Madhu Venugopal [Tue, 17 Dec 2013 10:32:23 +0000 (02:32 -0800)]
Moved all Openflow 1.0 specific flow programming away from InternalNetworkManager to OF10ProviderManager class.

Also, handled Switchmanager Node coming up event to take care of initializing the default flows.
This is needed to handle timing issues in which the ForwardingRulesManager rejects request to program
default flows from ovsdb.neutron if the request is too soon (before the OF node gets registered with other
OSGi bundles).

Change-Id: Id299c75146e504df63a45b77cc0f6be962c3abb6
Signed-off-by: Madhu Venugopal <mavenugo@gmail.com>
10 years agoMerge "Changed lookup of Controller IP to the following: - Start with OVSDB config...
Madhu Venugopal [Tue, 17 Dec 2013 00:03:29 +0000 (00:03 +0000)]
Merge "Changed lookup of Controller IP to the following:   -  Start with OVSDB config/property override   -  If not there, consult clustering services   -  If not there, consult Controller config/property override   -  If not found there, use the same IP that we connected on"

10 years agoMerge "Added the missing Copyright headers to most of the java files."
Brent Salisbury [Mon, 16 Dec 2013 23:06:56 +0000 (23:06 +0000)]
Merge "Added the missing Copyright headers to most of the java files."

10 years agoChanged lookup of Controller IP to the following: 45/3745/2
Thomas Bachman [Sat, 14 Dec 2013 12:20:48 +0000 (04:20 -0800)]
Changed lookup of Controller IP to the following:
  -  Start with OVSDB config/property override
  -  If not there, consult clustering services
  -  If not there, consult Controller config/property override
  -  If not found there, use the same IP that we connected on

Change-Id: Ia036740b57775ede5d5963a414baa611b8baa16c
Signed-off-by: Thomas Bachman <tbachman@yahoo.com>
10 years agoAdded the missing Copyright headers to most of the java files. 41/3641/2
Madhu Venugopal [Wed, 11 Dec 2013 14:19:24 +0000 (06:19 -0800)]
Added the missing Copyright headers to most of the java files.

Did my best in identyfing the appropriate Copyright owners and added Authors based
on the git history and authorship based on significant contributions.
For those files where the Copyright headers are not clear, the Authors mentioned
in the files will take care of filling them in.

Change-Id: I5243191c0753d42dccdfcdffd7c8bee53c9086ef
Signed-off-by: Madhu Venugopal <mavenugo@gmail.com>
10 years agoEnabled the ODL configuration on the Compute local.conf as well so that the ML2 auto... 52/3652/1
Madhu Venugopal [Wed, 11 Dec 2013 17:29:16 +0000 (09:29 -0800)]
Enabled the ODL configuration on the Compute local.conf as well so that the ML2 auto-config script can auto-configure manager.

Change-Id: Iead74f83b879fdfc9b4aeedbcb673390657898d9
Signed-off-by: Madhu Venugopal <mavenugo@gmail.com>
10 years ago- Added insertMirrorRow 21/3621/2
Keith Burns [Tue, 10 Dec 2013 17:55:08 +0000 (09:55 -0800)]
- Added insertMirrorRow
- Fixed bug in _insertTableRow for trIndex=0
- Added "mirrors" to Bridge Table
- removed println debugging

Change-Id: I6fa0917d67ed69bfe18ac46003295dac0db5f0ab
Signed-off-by: Keith Burns <alagalah@gmail.com>
10 years agoMerge "Added resources/ folder to track all the associated scripts and config files."
Brent Salisbury [Sun, 8 Dec 2013 05:11:57 +0000 (05:11 +0000)]
Merge "Added resources/ folder to track all the associated scripts and config files."

10 years agoMerge "Installing NORMAL rules on all the default neutron bridges."
Brent Salisbury [Sun, 8 Dec 2013 05:11:28 +0000 (05:11 +0000)]
Merge "Installing NORMAL rules on all the default neutron bridges."

10 years agoAdded resources/ folder to track all the associated scripts and config files. 49/3549/1
Madhu Venugopal [Sat, 7 Dec 2013 13:57:01 +0000 (05:57 -0800)]
Added resources/ folder to track all the associated scripts and config files.

Currently it is sub-divided into 2 directories : openstack and commons.
commons/ contains all the common script/config files such as POSTMAN scripts.
openstack/ contains all the openstack/devstack related config and scripts.
Each of these directories contain README.

We can expand this resources/ directory with more scripts as we see fit.

Change-Id: I86e7f82bfe0916b29fc069d62fb99a4a265156d8
Signed-off-by: Madhu Venugopal <mavenugo@gmail.com>
10 years agoInstalling NORMAL rules on all the default neutron bridges. 37/3537/2
Madhu Venugopal [Fri, 6 Dec 2013 21:27:30 +0000 (13:27 -0800)]
Installing NORMAL rules on all the default neutron bridges.

Opendaylight controller's OF1.0 plugin deletes all the OF rules upon initial connection.
This could be a valid scenario on regular scenario, but it breaks some basic assumptions
in a Openstack/devstack deployment. Hence this fix will override that behaviour by installing
a NORMAL rule as the default rule to avoid data traffic to be punted to the controller.
This is a temporary measure to solves some major issues seen on couple of deployment scenarios.
We will address it more elagantly once we integrate with the new OF plugin.

Change-Id: Ie53c85c3e1549d07392d6c8129adb05806ed32cd
Signed-off-by: Madhu Venugopal <mavenugo@gmail.com>
10 years agoMerge "- Addressed Queue/QoS special parent column type dependency - New files found...
Madhu Venugopal [Fri, 6 Dec 2013 07:02:42 +0000 (07:02 +0000)]
Merge "- Addressed Queue/QoS special parent column type dependency - New files found, and added to branch - Saving changes before trying SSL (0|1) check. - Complete insert sFlow insert/delete. - Modified integer type in QoS table, insert/delete for QoS and Queue ROOT tables - Added Queue table insert/delete operations (ROOT TABLE) - Netflow table insert/delete plus changes to Bridge and Netflow table definitions. - Fixed NetFlow table (wrong tablename) - Complete insert/delete Manager row - Capability row unable to be tested."

10 years ago- Addressed Queue/QoS special parent column type dependency 84/3284/5
Keith Burns [Fri, 29 Nov 2013 23:05:03 +0000 (15:05 -0800)]
- Addressed Queue/QoS special parent column type dependency
- New files found, and added to branch
- Saving changes before trying SSL (0|1) check.
- Complete insert sFlow insert/delete.
- Modified integer type in QoS table, insert/delete for QoS and Queue ROOT tables
- Added Queue table insert/delete operations (ROOT TABLE)
- Netflow table insert/delete plus changes to Bridge and Netflow table definitions.
- Fixed NetFlow table (wrong tablename)
- Complete insert/delete Manager row
- Capability row unable to be tested.

Change-Id: Iaedad50f0c15a87179904b7ca01983cd7febc4ce
Signed-off-by: Keith Burns <alagalah@gmail.com>
10 years agoMade changes in Internal Network creation to also takes care of creating br-int ... 90/3490/1
Madhu Venugopal [Thu, 5 Dec 2013 08:24:34 +0000 (00:24 -0800)]
Made changes in Internal Network creation to also takes care of creating br-int & its patch-ports if they are missing.

Please note that the current implementation creates br-int, br-tun and the patch ports upon detecting a new Node.
This can be improved by creating these bridges just when the Neutron events begin. Since this functionality is now
boxed into a single method call, it can be taken care as a future fix.

Change-Id: I71f52348d042a8ef1653fcd8e094a7a1d87d78d6
Signed-off-by: Madhu Venugopal <mavenugo@gmail.com>
10 years agoMake the eventHandler more robust. Set broad exception handlers on the process functi... 17/3417/2
Hugo Trippaers [Tue, 3 Dec 2013 21:55:22 +0000 (22:55 +0100)]
Make the eventHandler more robust. Set broad exception handlers on the process functions to catch exceptions that would otherwise cause the thread to break.

Change-Id: I7f21daba508b32e556af5215d8a3d5f4426a35ae
Signed-off-by: Hugo Trippaers <hugo@trippaers.nl>
10 years agoMerge "Identifying and ignoring uninterested SouthBound updates."
Brent Salisbury [Wed, 4 Dec 2013 16:14:14 +0000 (16:14 +0000)]
Merge "Identifying and ignoring uninterested SouthBound updates."

10 years agoMerge "Fixed JSON Deserializer to retain empty objects as empty rather than NULL...
Brent Salisbury [Wed, 4 Dec 2013 16:11:17 +0000 (16:11 +0000)]
Merge "Fixed JSON Deserializer to retain empty objects as empty rather than NULL. During Update operations, ovsdb-server sends NULL values for the columns that are not changed. If there is a change from an empty map to valid value, then that change goes undetected. Hence we need to retain the emptiness of the map and array intact in order to differentiate the behaviour."

10 years agoIdentifying and ignoring uninterested SouthBound updates. 38/3438/1
Madhu Venugopal [Wed, 4 Dec 2013 12:23:43 +0000 (04:23 -0800)]
Identifying and ignoring uninterested SouthBound updates.

Neutron bundle relies heavily on the Southbound events, especially the updates for its basic operations.
Many updates, especially the Packet statistics updates from Interface table are fast and furious and we
end up processing a lot of it unneccessarily. Due to the current implementation philosophy of maintaining
absolutely minimum cache in the neutron bundle, it relies heavily on the existing network states. Hence
such updates ends up reaching various layers. Hence identifying those updates and ignoring them becomes
critical for the stability of the system.

Change-Id: I10eb492e6e16be7931ec094bfcff54cc6b8696d6
Signed-off-by: Madhu Venugopal <mavenugo@gmail.com>
10 years agoFixed JSON Deserializer to retain empty objects as empty rather than NULL. 37/3437/1
Madhu Venugopal [Wed, 4 Dec 2013 00:41:21 +0000 (16:41 -0800)]
Fixed JSON Deserializer to retain empty objects as empty rather than NULL.
During Update operations, ovsdb-server sends NULL values for the columns that are not changed.
If there is a change from an empty map to valid value, then that change goes undetected.
Hence we need to retain the emptiness of the map and array intact in order to differentiate the
behaviour.

Change-Id: I9ff356c0f390aeaf0cb5d43bd2ba756206f3e345
Signed-off-by: Madhu Venugopal <mavenugo@gmail.com>
10 years agoGet rid of all e.printStackTrace() statements and cleanup some exception handling. 97/3397/2
Hugo Trippaers [Tue, 3 Dec 2013 13:49:07 +0000 (14:49 +0100)]
Get rid of all e.printStackTrace() statements and cleanup some exception handling.

Change-Id: I6bb8c4fc8c3315dcd909ab4b35a1bd5b8ebf1f13
Signed-off-by: Hugo Trippaers <hugo@trippaers.nl>
10 years agoWhen the controller already exists, the caller still expects to get its uuid. 49/3249/2
Hugo Trippaers [Fri, 29 Nov 2013 13:47:50 +0000 (14:47 +0100)]
When the controller already exists, the caller still expects to get its uuid.

Change-Id: I7f2aac02ae2d6b678abb4cd0866dcd6ee287604a
Signed-off-by: Hugo Trippaers <hugo@trippaers.nl>
10 years agoIntroduce a root pom in the top of the project. 29/3229/4
Hugo Trippaers [Thu, 28 Nov 2013 22:43:13 +0000 (23:43 +0100)]
Introduce a root pom in the top of the project.

Change-Id: I487312165dd5223d04b1d6bc91111a61c61b7713
Signed-off-by: Hugo Trippaers <hugo@trippaers.nl>
10 years agoFixup the pom files to add neutron to the main build profile and add both neutron... 28/3228/3
Hugo Trippaers [Thu, 28 Nov 2013 21:05:14 +0000 (22:05 +0100)]
Fixup the pom files to add neutron to the main build profile and add both neutron and northbound to the distribution pom

Change-Id: I5d4f1d6e826b6d17e6e325d67d03facc011dbf02
Signed-off-by: Hugo Trippaers <hugo@trippaers.nl>
10 years agoModified the insertRow methods to return StatusWithUuid instead of Status 20/3220/5
Madhu Venugopal [Fri, 29 Nov 2013 17:27:38 +0000 (09:27 -0800)]
Modified the insertRow methods to return StatusWithUuid instead of Status

This is in addition to Hugo's existing fixes.

Change-Id: I9671ee4afbd5e29c29e2b762f2dca91019db1e02
Signed-off-by: Madhu Venugopal <mavenugo@gmail.com>
10 years agoSimple Null check missing in setOFControllers when there are no existing bridges. 62/3262/1
Madhu Venugopal [Fri, 29 Nov 2013 16:45:51 +0000 (08:45 -0800)]
Simple Null check missing in setOFControllers when there are no existing bridges.

Change-Id: Icf8ffc49d0c3ebbe9ea9ead3a04a7fd0e5be8754
Signed-off-by: Madhu Venugopal <mavenugo@gmail.com>
10 years agoMerge "Enabling LLDP programming again. Upon debugging, it was found that the timeout...
Madhu Venugopal [Thu, 28 Nov 2013 19:27:47 +0000 (19:27 +0000)]
Merge "Enabling LLDP programming again. Upon debugging, it was found that the timeouts and instability observed on the controller were due to permgen issues (caused by multi-node devstack consuming up most of the laptop memory)."

10 years agoMerge "Minor Logging issues and removing an annoying error false positive message"
Madhu Venugopal [Thu, 28 Nov 2013 19:27:17 +0000 (19:27 +0000)]
Merge "Minor Logging issues and removing an annoying error false positive message"

10 years agoEnabling LLDP programming again. 17/3217/1
Madhu Venugopal [Thu, 28 Nov 2013 18:28:03 +0000 (10:28 -0800)]
Enabling LLDP programming again.
Upon debugging, it was found that the timeouts and instability observed on the controller were due to
permgen issues (caused by multi-node devstack consuming up most of the laptop memory).

Change-Id: Ic401615d67bd59f79369d3ff69429a2b366e817f
Signed-off-by: Madhu Venugopal <mavenugo@gmail.com>
10 years agoMinor Logging issues and removing an annoying error false positive message 16/3216/1
Madhu Venugopal [Thu, 28 Nov 2013 18:17:41 +0000 (10:17 -0800)]
Minor Logging issues and removing an annoying error false positive message

Change-Id: I0439972846bd69e96555e6e8cc97c4dc226bc3d1
Signed-off-by: Madhu Venugopal <mavenugo@gmail.com>
10 years agoMerge "Disabling the installation of LLDP Punt rules to Controller."
Brent Salisbury [Thu, 28 Nov 2013 09:28:35 +0000 (09:28 +0000)]
Merge "Disabling the installation of LLDP Punt rules to Controller."

10 years agoDisabling the installation of LLDP Punt rules to Controller. 77/3177/1
Madhu Venugopal [Thu, 28 Nov 2013 09:25:02 +0000 (01:25 -0800)]
Disabling the installation of LLDP Punt rules to Controller.

In a multi-node devstack setup, LLDP installation seems to cause issues with the Controller
(CPU spike and some OF message timeouts). It is better to debug that and once we have an idea,
we can enable it again. There is NO functional impact to the Neutron integration with OVSDB
by disabling LLDP flow installation.

Change-Id: I51e64253e09b6e863e2eea89f2570e436d3cc93f
Signed-off-by: Madhu Venugopal <mavenugo@gmail.com>
10 years agoMerge "Made changes to exception throwing."
Madhu Venugopal [Thu, 28 Nov 2013 08:57:37 +0000 (08:57 +0000)]
Merge "Made changes to exception throwing."

10 years agoBroadcast/Unknown unicast support. Also added LLDP punt to Controller. 74/3174/1
Madhu Venugopal [Thu, 28 Nov 2013 08:14:26 +0000 (00:14 -0800)]
Broadcast/Unknown unicast support. Also added LLDP punt to Controller.

Change-Id: Ia36ddd7f8cbdcb9f9ed164ffbc7332b5763fc931
Signed-off-by: Madhu Venugopal <mavenugo@gmail.com>
10 years agoMade changes to exception throwing. 15/3115/2
Keith Burns [Tue, 26 Nov 2013 23:37:37 +0000 (15:37 -0800)]
Made changes to exception throwing.

Change-Id: I8615f44e8dd98302d5ddc54b548640a1f969ef0b
Signed-off-by: Keith Burns <alagalah@gmail.com>
10 years agoOF Flow programming on br-int (NORMAL) and bidirectional br-tun (based on tenant... 11/3111/1
Madhu Venugopal [Tue, 26 Nov 2013 19:35:46 +0000 (11:35 -0800)]
OF Flow programming on br-int (NORMAL) and bidirectional br-tun (based on tenant mac/vlan)

Change-Id: I611e8fed23996b3b03a77640853fadb38b8c9513
Signed-off-by: Madhu Venugopal <mavenugo@gmail.com>
10 years agoConsolidated Container logic in 1 place and is configurable. Also fixed OF controller... 10/3110/1
Madhu Venugopal [Tue, 26 Nov 2013 10:34:19 +0000 (02:34 -0800)]
Consolidated Container logic in 1 place and is configurable. Also fixed OF controller connection for br-tun.

Change-Id: I33f4986317f386b5707e95cb90f7db532812159c
Signed-off-by: Madhu Venugopal <mavenugo@gmail.com>
10 years agoRefactored delete{Table}Row to use generic _deleteTableRow() 83/3083/1
Keith Burns [Tue, 26 Nov 2013 01:14:12 +0000 (17:14 -0800)]
Refactored delete{Table}Row to use generic _deleteTableRow()
Signed-off-by: Keith Burns <alagalah@gmail.com>
10 years agoVM location aware of Full-mesh Tenant-specific GRE Tunnel support over OF1.0 datapath. 41/3041/2
Madhu Venugopal [Sun, 24 Nov 2013 13:30:46 +0000 (05:30 -0800)]
VM location aware of Full-mesh Tenant-specific GRE Tunnel support over OF1.0 datapath.

This push also includes the following major changes :
1. OVSDB Port tagging on the internal integration bridge (br-int) on Tenant VM connected ports
2. Proper Container support with Flow Spec (internal Vlan) and Openflow ports as Container NodeConnectors
3. Moved most of the logic away from the Neutron Northbound Handlers to the Southbound Handler
4. More fixes to make the OVSDB bundles restartable without the need to force restart the Openstack components.
5. Moved the Southbound events to be handled in its own event thread.

Change-Id: Icb9ffc3a18f1dc15ca0b459ab690d98ce5d91b8f
Signed-off-by: Madhu Venugopal <mavenugo@gmail.com>
10 years agoAdded br-tun bridge installation code via InternalNetworkManager in cases when the... 27/3027/2
Madhu Venugopal [Sat, 23 Nov 2013 01:06:18 +0000 (17:06 -0800)]
Added br-tun bridge installation code via InternalNetworkManager in cases when the Node is not ready for overlay.

In DevStack environement, the Controller node is also used as compute. But the OVS is not populated with the
appropriate internal networks (such as br-tun and the corresponding patch-ports).
Witht his commit, this condition is identified and appropriate installation is done on the br-tun and br-int.

Change-Id: I8f1f65da864bd8a016912b46dbed3ed9a926ef2e
Signed-off-by: Madhu Venugopal <mavenugo@gmail.com>
10 years agoSkeleton code for the NetworkManagers : Provider, Internal and Tenant. 26/3026/2
Madhu Venugopal [Fri, 22 Nov 2013 21:01:27 +0000 (13:01 -0800)]
Skeleton code for the NetworkManagers : Provider, Internal and Tenant.

Also added a ConfigManager for the Tunnel-End point configuration that is currently proposed to be configured as :
ovs-vsctl set Open_vSwitch <uuid> other_config={"local-ip"="192.168.56.101"}.

Change-Id: I7b14fed5fdc5a1c4f6714faf41679c2f1cb9d0f5
Signed-off-by: Madhu Venugopal <mavenugo@gmail.com>