Fix incorrect BGP entity name & type pairs

Get_Owner_And_Successors_For_device requires Bgpcep as the entity type
when the BGP RIB name is given as the entity name.
Another option is to use the entity name with the '-service-group'
suffix, e.g. 'example-bgp-rib-service-group' instead of
'example-bgp-rib', with 'org.opendaylight.mdsal.ServiceEntityType'
as the entity type. In this case the initial attempt to get
the ownership information from
Get_Owner_And_Candidates_For_Device_Singleton will
fail and Get_Owner_And_Candidates_For_Device_Rpc will be used
as a fallback.

There are several test cases that incorrecly use the BGP RIB name with
'org.opendaylight.mdsal.ServiceEntityType'. Fix the errors with the
first option (use 'Bgpcep' as the type) to utilize the abstraction
provided by the keyword.

Signed-off-by: Sangwook Ha <sangwook.ha@verizon.com>
Change-Id: Ic44cd0f35531cc22bc3e4627ba2edec56084e075

Merge device specific keywords to retrieve entity ownership data

Keywords 'Get_Owner_And_Candidates_For_Device_Singleton_{device_type}'
defined for netconf, bgpcep, sxp are the same except for prefix/suffix
added to the device name. Create a dictionary for the prefix/suffix
and share the same keyword Get_Owner_And_Candidates_For_Device_Singleton.

The keyword didn't support OpenFlow device type before, because there
was no keyword specific to the OpenFlow device type, but it is
supported now.

This change also removes the odl-general-entity prefix/suffix for
bgpcep & sxp because the entity name does not include the prefix
with the new entity owner RPC - netconf does not have it.

Signed-off-by: Sangwook Ha <sangwook.ha@verizon.com>
Change-Id: I5181e2f9f531835310714789ece8df9634ee118f

Support Silicon for retrieval of entity ownership information

ClusterEntities.py uses RPC introduced in Phosphorus to retrieve
entity ownership information, hence Silicon or earlier versions,
which store entity ownership information in the data store,
are not supported.

Fall back on the REST API calls to retrieve the information from
the operational data store, if the status code for the RPC call is
400 (bad request), to support Silicon and earlier versions.

Signed-off-by: Sangwook Ha <sangwook.ha@verizon.com>
Change-Id: I18c8d667554d25e5126770235ad33ff404cbe9fe

Remove old script to push test stats

This is making builds unstable

Change-Id: I2a6e8d533140262e0cd9f7b6382c0a64b4f1fe16
Signed-off-by: Luis Gomez <ecelgp@gmail.com>

Add PCEP suite variables for sulfur

Change-Id: Ie25d294d4b82fbf2ec97bc778f3d634183180d2b
Signed-off-by: marekzatko <Marek.Zatko@pantheon.tech>

Update certificates for OpenFlow TLS connection

Certificate chains with intermediate CAs, currently used for
the OpenFlow channel TLS connection for testing, is not supported
by Open vSwitch.

Replace certificates/keystores for the switch & controller with
the ones signed directly by the root CA and create a new script,
gen-certs.sh, to make it easier to generate new certificates.

Also, fix an error in MininetKeywords in executing 'ovs-vsctl get-ssl'
command.

Signed-off-by: Sangwook Ha <sangwook.ha@verizon.com>
Change-Id: Ieb0c3c4f8285336a4ed4b48412c5d0e2fc7b27cb

Define sulfur version

bgpcep-csit-1node-gate-userfeatures-all-sulfur failed with:

  Dictionary '${Stream_dict}' has no key 'sulfur'.

We obviously need to recognize it.

Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
Change-Id: Id2b923bf9fb9db7447b1967d25bfc300d7382443

Fix no return value when deploying testtools

If the first attempt succeeds we need to return the filename
like before.

Signed-off-by: Tomas Cere <tomas.cere@pantheon.tech>
Change-Id: I133e5d8039bab7cbd1fa2350e8b9816b9331b956

Fix netconf entity name creation during lookup

Looks like the prefix contained something that was no longer
in the name of netconf entities.
We need to remove this to have the lookups for netconf entities
succeed.

Signed-off-by: Tomas Cere <tomas.cere@pantheon.tech>
Change-Id: Ia07e9500f72f1cc9a0221ee5744f4a01dc256b5a

Fallback to release url during testtool deploy

Staged autorelease does not have to contain some testing
artifacts which are needed for csit.
In that case fallback to using the release repo.

Signed-off-by: Tomas Cere <tomas.cere@pantheon.tech>
Change-Id: If6002e2080d791ce53571de68fd212879f75e0c2

Rework old entity datastore lookups to new rpcs

New entity ownership service doesnt publish entity
information to the datastore. Instead new rpcs
for the same purpose were introduced.
Rework suites relying on the entity information
to use the new rpcs.

Change-Id: I8765394c574e73a1720249b65419b64815d2f40b
Signed-off-by: Tomas Cere <tomas.cere@pantheon.tech>
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Fix netconf csit looking up nonexistant version

Due to the change of stream in netconf jobs from phosphorus to master
the test cases were looking up version which doesnt exist in the
test case values.

Signed-off-by: Tomas Cere <tomas.cere@pantheon.tech>
Change-Id: I2d2d74c2ba4cbc131cf5d87264cf55fa9b641f93

Fix a 'memeber' typo

The correct word is 'member'.

Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
Change-Id: Ie5f6b7805c81ca2fb6beba549d03bc28beba24bc

Add TopologyNetconfNodes.py library

Our current method of configuring netconf topology devices does not
really scale in terms of speed and memory footprint.

Add TopologyNetconfNodes.py, which provides a simple library to
configure and ascertain connection establishment in a scalable way --
from the perspective of RF, both actions are single keywords which do
not produce much in terms of output.

The configuration part relies on RFC8072 YANG Patch to introduce any
number of devices through a single request.

The keyword to await connection polls NETCONF topology for device status
and loops until the deadline passes or all requested devices are found
to have been connected.

// FIXME: pass down authentication

JIRA: INTTEST-125
Change-Id: I1661d84a6535abff45cbd346f54e996a4d757b33
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
Signed-off-by: Tomas Cere <tomas.cere@pantheon.tech>

Make sure we can use testtool from staging repo

While running jobs on staging artifacts the url for
testtool was incorrectly pointing to the opendaylight.release
repo, which obviously did not contain testtool.

Fix this up so we use the base path from the param
if its not pointing to release/snapshot repo.

Signed-off-by: Tomas Cere <tomas.cere@pantheon.tech>
Change-Id: Ifd5f88b0d8da67bf30d2e6c0858c2cd03f3d4554

Use proper netconf testtool artifact

When running tests with mri projects snapshot version
karaf distro, we need to point to proper testtool.

Signed-off-by: Tomas Cere <tomas.cere@pantheon.tech>
Change-Id: I564eccf4ecb1c5a56d75760ee14441f36729faf6

Fix netty-replicate test

This test suite is failing since upgrade to RF-4.1 due to
https://github.com/robotframework/robotframework/issues/4034.

Adjust argument declarations to not use list, but rather interpret the
argument as a list.

Change-Id: I2ccee5917738d4e4df844335542775512a1e20a3
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Fix shoudl typo

The word is 'should'.

Change-Id: I1b72132c9dc8b69e65d34c4f67dcb7c173aaa806
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Change opendaylight to karaf distro

Change-Id: Ie05485c0545a3eea69d7f4409c5c64014d270d5b
Signed-off-by: Luis Gomez <ecelgp@gmail.com>

Add a missing keyword

Previous patch ended up referencing a non-existing keyword, leading
to a set of failures. Make sure we define
Run_Keyword_If_At_Most_Silicon.

Change-Id: Ib04c161dc80208c1c3df06227d7f867a999a86d5
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Hack away entity-ownership:operational on Phosphorus

This is a weird default list, which has changed, as we no longer
have EOS backed by a shard. Add a hack, which will cause it to be
ignored.

Change-Id: If4bb9df2103c74a54f5b38c73ec16b8ee40ecbec
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

BGPCEP is release-integrated since Phosphorus

bgpcep should not be downloaded from autorelease repo, but rather
from our normal release repository. This should fix failures in
bgpcep-csit-1node-userfeatures-all-phosphorus, where we are failing
to download bgp-bmp-mock-0.15.0-executable.jar from
https://nexus.opendaylight.org/content/repositories/autorelease-4860/

Change-Id: I2d4334e379b114ff997e93f264227046c30186a9
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Decrease number of injected routes

Change-Id: I8eff2b04f6b758221e28eb4aa2da03a3461aa343
Signed-off-by: Luis Gomez <ecelgp@gmail.com>

Fix OFP link scale test

It is fine to stop at 52 switches and 2652 links.

Change-Id: Iefeb5e4e9b3e917309c4faac398ea0784ac28ff7
Signed-off-by: Luis Gomez <ecelgp@gmail.com>

Documentation for run integration test on local computer

Added RST document with instructions how to set up Robot framework and
run integration test on local machine.

JIRA: INTTEST-127
Change-Id: I950656a036b1ef3c782ca6c0863f192e09a83e60
Signed-off-by: Iaroslav <iaroslav.kholiavko@pantheon.tech>

Add pcep suite variables for phosphorus release

Change-Id: Ieb0349bcae384bc4813187df0d3bcf813a508015
Signed-off-by: Oleksii Mozghovyi <oleksii.mozghovyi@pantheon.tech>

Update ambv/black branch for the python formatter

The 'stable' branch of ambv/black is not available,
switch to the psf/black and branch 20.8b1 instead.

Change-Id: If8dce5f251a8c35cf0d3f5e824bd4c0f735b929c
Signed-off-by: Oleksii Mozghovyi <oleksii.mozghovyi@pantheon.tech>

NETCONF is release-integrated in Silicon+

Adjust component mapping to account for NETCONF not sitting in
autorelease.

Change-Id: I30d6e5ee594b3000b6d412ffbf2c75b4d71ad840
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Add phosphorus to release dict

Signed-off-by: Ivan Hrasko <ivan.hrasko@pantheon.tech>
Change-Id: If4184ccc2518e232de2cfb59edbcbb1bbf95aed4

Add test cases for call-home (devices connected with TLS transport)

Verification for the TLS transport based on the following flow:
- Generates certificate for the device
- Installs certificates into the netopeer2 device
- Installs certificates into the OpenDaylight controller
- Checks if the device is recognized by the OpenDaylight CallHome feature and
mounted successfully

JIRA: NETCONF-5
Change-Id: Ibe08c61ab6956d83748ae95be776a1be8c1a1d78
Signed-off-by: Oleksii Mozghovyi <oleksii.mozghovyi@pantheon.tech>
Signed-off-by: Vladyslav Marchenko <vladyslav.marchenko@pantheon.tech>

Add test cases for new API to netconf/call-home suite

This test verify new yang data models for NETCONF CallHome feature

JIRA: NETCONF-5
Change-Id: I1a96db6beb4d68fe0f767b7f1e86bd4e4f200177
Signed-off-by: Oleksii Mozghovyi <oleksii.mozghovyi@pantheon.tech>
Signed-off-by: Vladyslav Marchenko <vladyslav.marchenko@pantheon.tech>

Fix NETCONF KWs to log less

Also remove JVM KWs that throws ERRORs

Change-Id: I9eb3a50f03dcaba6ca2dd948c0d40475dc027e66
Signed-off-by: Luis Gomez <ecelgp@gmail.com>

Add 'silicon' to the list of variables used for release version comparison

This adding functionality to limit test runs for silicon and later
releases.

Change-Id: I3e62d91f830270013059d9dbf76658b7ce2db6f0
Signed-off-by: Oleksii Mozghovyi <oleksii.mozghovyi@pantheon.tech>

Fix robot KW logging

Change-Id: I9a8640c7b26a0c0172576d50fbb30482aef22163
Signed-off-by: Luis Gomez <ecelgp@gmail.com>

migrate doc index wiki URLs to wiki-archive

Signed-off-by: Guillaume Lambert <guillaume.lambert@orange.com>
Change-Id: Ic09f8b41b4315e134d1649efd81502385b449efe

Add netty replicate test suite

Add test suite for MD-SAL netty-replicate functionality.

Jira: MDSAL-648
Signed-off-by: Martin Balaz <martin.balaz@pantheon.tech>
Change-Id: I10f2f06cd32fb686b13a12d13bde50a7f6d66db8

Always use /dev/urandom

We do not care about RNG here, just use /dev/urandom.

Change-Id: If3e5ae14bef69af71c726a5d2bbaf3744f29f389
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Update yangtools validation set to newer commits, add description about reasons for excluding yang files

Signed-off-by: Martin Balaz <martin.balaz@pantheon.tech>
Change-Id: Ibd92d17dbea1c2514f7be40b3a1580b3262fce37

Fix typo in comparison operator in Open_Controller_Karaf_Console_On_Background for proper restoring ssh connection

Signed-off-by: Martin Balaz <martin.balaz@pantheon.tech>
Change-Id: I1f9fbbcd71e9f59c0d70686c57f9612d5834a7bd

Update call-home integration tests

- Replace outdated netopeer with a netopeer2-server
- Configuration of the ODL controller is done from tests(previous
  implementation used shell scripts inside the container)
- Templates for ODL requests are now stored separately
- Host key generation outside of the container
- Netopeer2 container plays only the role of netconf device

JIRA: NETCONF-5
Change-Id: I536b3c8a66cc3e92f376cb2451b888316c8a82bd
Signed-off-by: Oleksii Mozghovyi <oleksii.mozghovyi@pantheon.tech>
Signed-off-by: Vladyslav Marchenko <vladyslav.marchenko@pantheon.tech>

odlmicro scale tests

Signed-off-by: Venkatrangan Govindarajan <gvrangan@gmail.com>
Change-Id: I5132f2e1a794934e3877c20a320d9a91187ff094

Enable CRUD-RPC Test for odlmicro

Signed-off-by: Venkatrangan Govindarajan <gvrangan@gmail.com>
Change-Id: I19acadfe5c7994200f2f5e248fa05962e13075b9

Remove BGPCEP many peers test

The test fails intermitent in all the branches. Better skip until
someone spends the cycles to figure if this is a test or
a controller issue.

JIRA: BGPCEP-946

Change-Id: I1c5211c0655046c67faa655f35e9dc692c96a4d8
Signed-off-by: Luis Gomez <ecelgp@gmail.com>

Modifications for OF_Tunnels to support Aluminium release

Signed-off-by: Srinivas Rachakonda <srinivas.rachakonda@gmail.com>
Change-Id: Ieab937d11e1e0d489b4078097a20c4a4702874aa

Fix variable names consistency in DnbCommons.robot

Signed-off-by: Martin Balaz <martin.balaz@pantheon.tech>
Change-Id: Ice47186a2ecc51ec65147a2480f44ce7cdf4d3f7

change DOMNotificationBroker wait timeout to incorporate check period time

Signed-off-by: Martin Balaz <martin.balaz@pantheon.tech>
Change-Id: I7e4dc959883da5cf5a4afc1df330933a8f33f4cb

Exclude long time failing test

JIRA: OVSDB-413

Change-Id: I7b070b817abbe18bc3f4019f6d85ceb4b387d6d1
Signed-off-by: Luis Gomez <ecelgp@gmail.com>

Reduce output.xml size

Other longevity tests may need a similar fix.

Signed-off-by: Vratko Polak <vrpolak@cisco.com>
Change-Id: Ie033532a542cbb203fb4a93afb75a98bbc8f218d

Stabilize netconf callhome test

Change-Id: I49524d04d28ec0b483c432ec8f83cf240c2a447a
Signed-off-by: Luis Gomez <ecelgp@gmail.com>

Add INFO.yaml for integration/test

Signed-off-by: Anil Belur <abelur@linuxfoundation.org>
Change-Id: I1e510ac9dc35193d692188595b2842e095fd8b28

Initial tests for odlmicro netconf functionality

JIRA: ODLMICRO-32
Signed-off-by: Bhuvana Vignesh <bhuvanmailid@gmail.com>
Change-Id: Ib103551d4468f33ce180706f751028c110f7c286

Verify PCEP sessions from multiple machines

JIRA: INTTEST-121
Signed-off-by: BhuvanaVignesh <bvignesh@luminanetworks.com>
Change-Id: I3d030782ab5c4dd9b7e96de32a0609bdb908bb10

Controller component should be MRI

carpeople component is MRI from Aluminium onwards.

JIRA: INTTEST-119

Change-Id: I81e4c2d74dc5f7ce34a72d616ca02d1a708fc9dc
Signed-off-by: Luis Gomez <ecelgp@gmail.com>

Fix tox errors

It seems some updates in linters/pre-commit steps is
now catching more errors. This is just a patch accepting
all the automatic fixes from running them locally.

Signed-off-by: Jamo Luhrsen <jluhrsen@gmail.com>
Change-Id: I762637f6890eeedd2dde1e1406a6cfb65c2ff26f

Adjust PCEP module names

The names of the modules have shifted, hence we need to update the
test suite to take that into account.

magnesium/ folder contains the pre-existing files and
sodium/ is just a symlink to it. aluminium/ folder will
have the new formats and eventually when magnesium and
sodium age out we can revert the .robot changes in this
patch pointing to a ${STREAM} folder and flatten these
updated files back down to a single folder.

JIRA: BGPCEP-882
Change-Id: I4e217370f4ad908c557da852d864d458035b2586
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

GENIUS-130: OF Tunnels support For ITM Direct Tunnels (of-tunnels)

Genius already supports creation of OF-tunnels through interface-manager.
With itm-direct-tunnels, interface-manager is by-passed for all
internal tunnel operations, and in such scenarios, OF tunnels are
not currently supported. This feature adds support for flow based
tunnels on top of itm-direct-tunnels for better scalability.

Specification Gerrit : https://git.opendaylight.org/gerrit/#/c/71659/

Gerrits Topic : https://git.opendaylight.org/gerrit/#/q/topic:of-tunnels+(status:open+OR+status:merged)

Change-Id: I32c9f1796b86670263574748bb937d9f18869b58
Signed-off-by: Karthika Panneer <r.p.karthika@ericsson.com>

BGP session with LLGR capability for unsupported safi

   - A library for gobgp tool is added
   - Test case for validating BGP Session with LLGR
   - For an unsupported safi

JIRA : BGPCEP-893

Signed-off-by: pdathathraya <pdathathraya@luminanetworks.com>
Change-Id: I57cfc0ade08f37f85f5bbdb0ca7093012ac0f500

Add RESTCONF RFC8040 SSE test

The new test is executed when using RFC8040. And it is available
in Aluminium onwards.

Change-Id: Iaf74ff1d119a93d8c87227e9fc0a9c25c1fd7a04
Signed-off-by: Luis Gomez <ecelgp@gmail.com>

Convert SFC checks from python2 to python3

resp.content breaks with "should contain" style KWs.
resp.text is the way forward with that.

Signed-off-by: Jamo Luhrsen <jluhrsen@gmail.com>
Change-Id: Ia0212b48b0c531e38c18dafcde8d7eeea7065049

Add silicon to release dict

Change-Id: If50e0a5fa8f73bfe7e2f8ca1215b13502d5babea
Signed-off-by: Luis Gomez <ecelgp@gmail.com>

Setup python-black for opinionated linting

Black will automatically format code for Python 3.

Change-Id: I55d5042412f9ba275ec8e65301a21db1d4209d84
Signed-off-by: Thanh Ha <zxiiro@gmail.com>

Auto-generated patch by python-black

Refer to the next patch in the list before merging this one. This
also removes autopep8 in prep for python-black as both these tools
conflict with each other.

Change-Id: I8adbeea0d42827e9dc341b023e79da2ce389d491
Signed-off-by: Thanh Ha <zxiiro@gmail.com>

Adding new PCC delegation test cases

 - This patch contains the test case which revoke the pcc delegation in LSP updates

JIRA: INTTEST-120
Signed-off-by: BhuvanaVignesh <bvignesh@luminanetworks.com>
Change-Id: I16eb170586d6e7e1eb7736a4e09ed01a9c68570a

Test with AS Number configured more than 65535

JIRA : INTTEST-122

Signed-off-by: pdathathraya <pdathathraya@luminanetworks.com>
Change-Id: I33b3f6acfdfdcf3127f08940ab57a19c7a69170e

Disable SSE notifications

By default in Aluminium, SSE (Server Side Events) are enabled
and websocket notfications are disabled. The existing CSIT
test cases expect websocket notifications to work. For now
we need to disable SSE to allow the test cases to pass with
websockets.

This will be a NOOP for Mg and Na, although the controller
restart is a small waste of time (~2min).

In the future, tests cases for SSE will be written and doing
this config change and restart in the suite setup will
probably not make sense.

JIRA: INTTEST-107

Signed-off-by: Lukas Baca <lbaca@luminanetworks.com>
Change-Id: I0dc87e2731927c2ec61c683d1a2f238e2b03e8d0
Signed-off-by: Lukas Baca <lbaca@luminanetworks.com>

Restore OFP cluster suites original order

Change-Id: I7ef0d9ef06e842aeb50fcb353aa1f685b34a9606
Signed-off-by: Luis Gomez <ecelgp@gmail.com>

increase ping packet count

Signed-off-by: Srinivas Rachakonda <srinivas.rachakonda@gmail.com>
Change-Id: I02d265ff89be5eed2d301053f8b8ab87d86226d8

Python3 Fixes in Genius

Signed-off-by: Srinivas Rachakonda <srinivas.rachakonda@gmail.com>
Change-Id: I0f87a7f95293dd49652d19af2a99f924d5d50832

Additional Tests related to the address families

JIRA: BGPCEP-910
Change-Id: Idd36f6643374466ace0bbc11cafa4c54e6a8c477

Signed-off-by: PoojaDathathraya <pdathathraya@luminanetworks.com>
Change-Id: If5ebdc0814e27ab9f6084eeb2eeae3d046e8333e
Signed-off-by: pdathathraya <pdathathraya@luminanetworks.com>

Support for cirros-0.4.0 password

The password for cirros-0.4.0-x86_64-disk.img (and higher
cirros version images) is gocubsgo.
OpenstackOperation.robot takes cirros as username and
password as cubswin:).
So there is need to add two more arguments user=cirros and
password=gocubsgo.

The default passowrd will be changed in all library files once
we move to Openstack Stein on wards.

Signed-off-by: Srinivas Rachakonda <srinivas.rachakonda@gmail.com>
Change-Id: I92ac6c79caedc465412363d890d6e7c0c639d025

NETVIRT-1695 - Remove Association/Disaccociation IPv6 TCs.

Direct Association of IPv6 subnet to VPN id is not supported.
So removing the TCs related to it.

Signed-off-by: Srinivas Rachakonda <srinivas.rachakonda@gmail.com>
Change-Id: I0fddf6fc777d24256267e06b68d0a0a6d9a8eff6

Support for cirros-0.4.0 password

The password for cirros-0.4.0-x86_64-disk.img (and higher
cirros version images) is gocubsgo.
OpenstackOperation.robot takes cirros as username and
password as cubswin:).
So there is need to add two more arguments user=cirros and
password=gocubsgo.

The default passowrd will be changed in all library files once
we move to Openstack Stein on wards.

Signed-off-by: Srinivas Rachakonda <srinivas.rachakonda@gmail.com>
Change-Id: If55349f79304a2bf5ee688f33a0c8f5926f31b85

Additional Test for varying afi-safis

JIRA: BGPCEP-906
Signed-off-by: PoojaDathathraya <pdathathraya@luminanetworks.com>
Change-Id: I5c85b04faa77afc3b8fe5ef869d37b069c537bb1

Improve netconf max devices test logic

- there was some race condition where issuing a GET
(using the python getter.py tool) was not able to
get a 200 from every device initially after they
were all reported mounted. running the getter.py
tool once seems to resolve this and running it a
second time to do the actual checks for 200 on each
mounted device.

- also bumped the timeout factor from 2 to 3 since
I saw the larger iterations (750) hitting the timeout
once.

JIRA: NETCONF-711

Signed-off-by: Jamo Luhrsen <jluhrsen@gmail.com>
Change-Id: Iab274d89c44cc0a56bb4959e4ec67a0eaa345873

Correcting Get Value from JSON

Signed-off-by: Srinivas Rachakonda <srinivas.rachakonda@gmail.com>
Change-Id: Iff74a4a70536b4c233bdf2d2b8c014c8c724eafd
Signed-off-by: Srinivas Rachakonda <srinivas.rachakonda@gmail.com>

INTTEST-107: Add test cases to cover rpc augmentation action

Change-Id: I8c9b32aea038d7f7e2003dc0171bc36da4f85cc9
Signed-off-by: Kailash Khalasi <kailash.khalasi@gmail.com>

python3 changes in openstack scripts

Signed-off-by: Srinivas Rachakonda <srinivas.rachakonda@gmail.com>
Change-Id: I2bd8d821f3967f40f031d379bc2642d9d694a7fb

Increase timeout for apidocs URI to 90s

It seems that 60s might not be long enough in all cases as we
see this test fail sometimes. Let's try 90s to see if it helps.

Signed-off-by: Jamo Luhrsen <jluhrsen@gmail.com>
Change-Id: Id3eb7547dd4be8bac6d3a96ad384d950614a55e8

Fix BGPCEP ingest test

Python3 floor division is //

Change-Id: Id4a730a6464234f5f902069f5d684435ae2a9426
Signed-off-by: Luis Gomez <ecelgp@gmail.com>

Fix robot syntax with robot.tidy tool

- have to skip .robot files with the trailing-whitespace hook because
it will remove the blank line at the end of a file whereas robot tidy
will add one which causes a failure

This change is coming from using the latest RF and
robotframework-tidy-wrapper.

Signed-off-by: Jamo Luhrsen <jluhrsen@gmail.com>
Change-Id: I7ad30196d4ad3641901578614e3b417e4772498d

Move robot-tidy precommit back to master

Signed-off-by: Jamo Luhrsen <jluhrsen@gmail.com>
Change-Id: I1e58cdb94da31e98614561f2c00d4473aaae4622

Remove neon version of netconf testplans

neon is no longer maintained, so remove the files
specific to that.

Signed-off-by: Jamo Luhrsen <jluhrsen@gmail.com>
Change-Id: I65cce28bd05ecb3d26d1b5010a0f40df15ad5806

Tests for BGPCEP-901

- This patch have the flapping pcc sessions test cases and modified as to run 1+ more pcc sessions

JIRA: BGPCEP-901
Signed-off-by: BhuvanaVignesh <bvignesh@luminanetworks.com>
Change-Id: Ifb73a165244ddb7fbbd77327479edf0331af774f

Add gate testplan for rfc8040 job

Signed-off-by: Jamo Luhrsen <jluhrsen@gmail.com>
Change-Id: I0da8aed19459dca15f376acc66969970f475bafd

Fix python3 issues in OVSDB

Signed-off-by: Srinivas Rachakonda <srinivas.rachakonda@gmail.com>
Change-Id: I57bcf759f96c2d7d47ffd9acc9e21599d58c2c36

Add schemas with rpc action in augmentation

INTTEST-107
Change-Id: I4b7a1f96f2a947c30867eac10ce5cea4ab88c4f8
Signed-off-by: Kailash Khalasi <kailash.khalasi@gmail.com>

INTTEST-83: Add testcase for restconf notification stream

Change-Id: Ifa68dd65afd17a97d4f85025e321cf3771d0493b
Signed-off-by: Kailash Khalasi <kailash.khalasi@gmail.com>

Fix python3 issues in Netvirt

Also removed VTN library files

Signed-off-by: Srinivas Rachakonda <srinivas.rachakonda@gmail.com>
Change-Id: Ifcfbc76cc5c308f0e7126ac5b494c7e80ca64a18

INTTEST-91 - Updating list and dictionary syntax

Accessing list and dictionary items
using @{var}[item] and &{var}[item] is deprecated
from robotframework 3.2b1

https://github.com/robotframework/robotframework/blob/master/doc/releasenotes/rf-3.2b1.rst#accessing-list-and-dictionary-items-using-varitem-and-varitem-is-deprecated

Signed-off-by: Srinivas Rachakonda <srinivas.rachakonda@gmail.com>
Change-Id: Ic2e9bc0b7edc150c003171022da987b61bd9999f

Fix python3 cluster suites

Change-Id: I63d4d7906cbfc81804a2e10793e04109ddf65531
Signed-off-by: Luis Gomez <ecelgp@gmail.com>

Resolve E722 do not use bare except

Bare exceptions violates one of Pythons idioms that bare exceptions
should not be used. The reason for this is that a bare except catches
all exceptions and can make programming errors look like runtime
problems making debugging more difficult.

Change-Id: I7006639302ef2efc9301c384c19218dd6783c825
Ref: https://docs.python.org/3.1/howto/doanddont.html#except
Signed-off-by: Thanh Ha <zxiiro@gmail.com>

Print git-diff when pre-commit fails

When pre-commit fails and automatically fixes issues for us in Jenkins
we are not able to see what pre-commit automatically fixed. Adding
--show-diff-on-failure makes pre-commit perform a git-diff immediately
after failing to ensure more useful output is printed to inform the
contributor what changes are needed to pass the check.

Change-Id: I7d97b823e401bb737564a3936afa08085dcb6975
Signed-off-by: Thanh Ha <zxiiro@gmail.com>

Make GitLint actually run as part of pre-commit

The tox environment for pre-commit currently does not actually run
the gitlint hook.

Change-Id: Ia22d2d1fed8aed3689690e3f51e06905f409f82e
Signed-off-by: Thanh Ha <zxiiro@gmail.com>

Fix formatting for .pre-commit-config.yaml

File should start with `repos:` as the root level. Without this things
appear to still work anyway but we should probably have the right
formatting.

Change-Id: I437ae2b0164b85125fdeb323d27f025861da9f6b
Signed-off-by: Thanh Ha <zxiiro@gmail.com>

Restore forked ipaddr library

Change-Id: Ibdcb3c963fceeac5cd304c956d8d589aa0033912
Signed-off-by: Luis Gomez <ecelgp@gmail.com>

Increase HTTP timeout for apidocs test

Change-Id: I180d1f34b5458326ad60161c60e9c51c43ae36d0
Signed-off-by: Luis Gomez <ecelgp@gmail.com>

Install ipaddr module in Tools VM

The ipaddr.py was removed in an earlier merged patch, causing
the tests to fail. This patch uses pip to install ipaddr to TOOLS VM.

JIRA: INTTEST-105
Signed-off-by: Venkatrangan Govindarajan <vgovindarajan@luminanetworks.com>
Change-Id: Id0dcfa0b59f1326baa3a0999ac0a7647dc26a0fa

INTTEST-88: Check namespace in response header

Change-Id: Ib23bbd813c29a47a28b2d5629c9238727d39df54
Signed-off-by: Kailash Khalasi <kailash.khalasi@gmail.com>

Fix python3 issues in OFP 2

JIRA: INTTEST-105

Change-Id: I35d00e8a98df9ad1763e9de16da7915d17ef18cd
Signed-off-by: Luis Gomez <ecelgp@gmail.com>

Fix python3 issues in OFP

JIRA: INTTEST-105

Change-Id: I70deb287014630d21dbc6842678edef21d5690b7
Signed-off-by: Luis Gomez <ecelgp@gmail.com>