Bug 3866: Introduced Binding Adapters for DataTreeProducer

Change-Id: I55518ce6de7edaf8bd68d6d2fccd217684b48536
Signed-off-by: Tony Tkacik <[email protected]>

Bug 3867: Introduced Binding APIs for Data Tree Producer.

Change-Id: I234581af7704446b0a3af64723528647b58505f0
Signed-off-by: Tony Tkacik <[email protected]>

Merge "Fix duplicate artifact inclusion"

Merge changes I4b3820fd,Ib225745c

* changes:
  BUG-4264: deprecate packageNameForTypeDefinition()
  BUG-4264: do not duplicate strings needlessly

Fix a deprecation warning

SchemaNode.getPath() is deprecated, this is a simple migration.

Change-Id: Ic7b16a6aace06eaddd2562709c48d74ceab6191c
Signed-off-by: Robert Varga <[email protected]>

Add mdsal-model-artifacts to binding-parent

Given the migration to use the MD-SAL project, dependencies like
ietf-inet-types and ietf-yang-types are now imported via
org.opendaylight.mdsal.model instead of org.opendaylight.yangtools.model
groupId. However, the dependency management section of the
binding-parent does not include mdsal-model-artifacts, where the
previously mentioned artifacts are declared. This breaks imports in
bundles inheriting from binding-parent.

Change-Id: Id19c36862f8ab8bbfa70f8a538619070cf8814d7
Signed-off-by: Florin Coras <[email protected]>

Bug 4145: Issue augmenting choice inside a list

The problem occurs when target node of uses-augment statement
is added by uses from another grouping and the uses statement
is not directly inside the grouping, but it is nested below
other elements (e.g. list, container etc.) in the grouping.
In this case the original of the target node is not found and
the IllegalStateException is thrown.

Change-Id: I1b0329d5da754251040894c0ccfe920bf8190aa4
Signed-off-by: Peter Kajsa <[email protected]>

Fix duplicate artifact inclusion

Duplicate dependency is triggering a maven warning, remove it.

Change-Id: Ia38455e648f8fd8fc8eb98aec5e5313be11ebbdf
Signed-off-by: Robert Varga <[email protected]>

BUG-4264: deprecate packageNameForTypeDefinition()

This method is only used in tests and is broken, schedule it for
removal.

Change-Id: I4b3820fd9e02d4903087271e2982390e8c2573a2
Signed-off-by: Robert Varga <[email protected]>

BUG-4264: do not duplicate strings needlessly

This patch adds safeguards for string transformation methods to check if
the result is the same as input. This should address the string
duplication issues.

Change-Id: Ib225745ce35b492997edc60abd1abb3e41032795
Signed-off-by: Robert Varga <[email protected]>

Use NodeIdentifier.create()

Using create() results in reused instances, thus lowering memory
footprint.

Change-Id: If1a1a3c3c74567374093a76df6e00ed7110b4f1c
Signed-off-by: Robert Varga <[email protected]>

Merge changes from topic 'be/migration/mdsal'

* changes:
  Removed not-building code.
  Removed left-over dependencies to YANGTools models.

Removed not-building code.

Change-Id: Id89947a47aa2e5de19ac967013892a1e6a132fd3
Signed-off-by: Tony Tkacik <[email protected]>

Removed left-over dependencies to YANGTools models.

Change-Id: I71a5e1a50038629abb627d1d5cf28a5d794918c8
Signed-off-by: Tony Tkacik <[email protected]>

Merge "Added .gitreview"

Provide a single-argument variant of firstKeyOf()

InstanceIdentifier::firstKeyOf() doesn't seem to need its second
argument, even for generic type resolution (even in Java 7). This
patch adds a variant with only the component type argument.

I'm not sure what the deprecation practices are so I haven't
deprecated the two-argument version.

Change-Id: I6d4822472db627519600f5f0828f3ebe632fc00b
Signed-off-by: Stephen Kitt <[email protected]>
Signed-off-by: Robert Varga <[email protected]>

Fixed export package in mdsal-binding-generator-impl

Change-Id: Ib28bcec5674635bea781d89d97535afb195f99af
Signed-off-by: Tony Tkacik <[email protected]>

Added mdsal-model Karaf feature.

Change-Id: I08e12fb9f9db7f872cffec4b82f7e22d9414716e
Signed-off-by: Tony Tkacik <[email protected]>

Introduced MD-SAL Karaf Features

Introduced new MD-SAL Karaf features, which allows
customized inclusion only of subset of functionality
such as Java Binding without Brokers, or DOM Broker
without Binding Broker.

Change-Id: I4ddb447b7b430e004023362d91fa286f6515c225
Signed-off-by: Tony Tkacik <[email protected]>

Materialized project.groupId in -artifacts.

groupId must be materialized in -artifacts type of POM file
otherwise Maven resolves it against of groupId of project
which imported such POM file.

Change-Id: Ibd7c78957c1286836b47aaed0d0ed825b74b331a
Signed-off-by: Tony Tkacik <[email protected]>

Fixed Export-Package sections after rename.

Change-Id: I6b7fc00f53167d398bac35010fb03a81aa1f5912
Signed-off-by: Tony Tkacik <[email protected]>

Converted model packaging from jar to bundle

Change-Id: I0a6dae4ca90296b92a56c97cc5de2c6b081eed3f
Signed-off-by: Tony Tkacik <[email protected]>

Renamed test packages to use org.opendaylight.mdsal

Change-Id: Ie3272a21a39328c363a8f278cd734cdd927c995b
Signed-off-by: Tony Tkacik <[email protected]>

Renamed controller.md.sal.dom.store.impl -> mdsal.dom.store.inmemory

Change-Id: Ibe14d77f1279c8dba40d93e7ccc6acb67dc907a1
Signed-off-by: Tony Tkacik <[email protected]>

Cleaned up mdsal-common-api and mdsal-dom-spi

Renamed mdsal-dom-spi packages to mdsal.dom.spi
Renamed .controller.md.sal.common.api to mdsal.common.api
Removed legacy concepts

Change-Id: Ib2626444f6d1beb14b757c309237c20826440006
Signed-off-by: Tony Tkacik <[email protected]>

Removed legacy binding-api concepts.

Removed concepts, which were copied from Hydrogen APIs
and needs rework in Beryllium. These concepts are still
present in controller project and will be supported
in Beryllium.

Change-Id: Ie1b9ac0a725decf33b1d742ebbbc53493bae1ff7
Signed-off-by: Tony Tkacik <[email protected]>

Merge "Cleaned up dom-api and dom-broker from legacy concepts."

Cleaned up dom-api and dom-broker from legacy concepts.

Change-Id: I68d188cf43b7137caa8a3a1f9b49c37c9e4b3376
Signed-off-by: Tony Tkacik <[email protected]>

Renamed yangtools.binding.data.codec.api to mdsal.binding.data.codec.api

Change-Id: I071879001c0cdfb6040714ed7b5d6309b7961204
Signed-off-by: Tony Tkacik <[email protected]>

Added .gitreview

Change-Id: I2e63bb982082518b7c2e33c4d908993b25c99139
Signed-off-by: Tony Tkacik <[email protected]>

Renamed controller.md.sal.dom.broker.impl to mdsal.dom.broker

Change-Id: I185b2803a4c5933c8372996ced0a01bdffdb5ee4
Signed-off-by: Tony Tkacik <[email protected]>

Renamed controller.md.sal.dom.api to mdsal.dom.api

Change-Id: Ib6e9f962e0d8555567a64aa62ef7a6f9264abab4
Signed-off-by: Tony Tkacik <[email protected]>

Renamed controller.md.sal.binding.api to mdsal.binding.api

Change-Id: Iec42b3e33e64ce84c7d667d29409266158c98137
Signed-off-by: Tony Tkacik <[email protected]>

Renamed controller.md.sal.binding.impl to mdsal.binding.dom.adapter

Change-Id: Ie6ad34615f89c84b3ff0b7a5bfc51703eb758db9
Signed-off-by: Tony Tkacik <[email protected]>

Moved binding MD-SAL APIs to binding folder

Renamed artefacts:
  sal-binding-api to mdsal-binding-api
  sal-binding-broker to mdsal-binding-dom-adapter
  sal-binding-util to mdsal-binding-util

Removed deprecated Hydrogen and Helium interfaces
and adapters, since they still can be provided from
original location.

Change-Id: I0ebbfc2e927aa6c036e9be7ed216a48d970e66d0
Signed-off-by: Tony Tkacik <[email protected]>

Cleaned up sal-dom-* packages and removed legacy interfaces

 - Removed deprecated interfaces from mdsal-common-api,
   some of this interfaces will be present in controller
   for backwards compatibility

 - Changed groupId to org.opendaylight.mdsal
 - Changed artifactId from sal-core to msdal-dom

Change-Id: I222bee07e5fd13fe10d19f01ba4f9bdf102bf3e5
Signed-off-by: Tony Tkacik <[email protected]>

Cleaned up  sal-common-* to common folder

- Added mdsal- prefix
- Updated groupId to org.opendaylight.mdsal

Change-Id: I4daef4cf6c341a4f3029f3b88a17856bdd17c009
Signed-off-by: Tony Tkacik <[email protected]>

Migrated models to use MD-SAL provided code.

Change-Id: Ia92933803e133604b5a54b1b2c82210480ae3ffc
Signed-off-by: Tony Tkacik <[email protected]>

Cleaned up Java Binding code from YANG Tools

- Introduced artifacts pom
- Updated groupId from .yangtools to .mdsal
- Renamed code-generator to binding folder which
  makes more sense since it contains also codecs
  and other functionality not directly related
  to code generation.
- added mdsal- prefix to artifact id to make
  it more distinguishable from YANGTools
- joined binding-model-api, binding-generator-api,
  binding-generator spi into mdsal-binding-generator-api
- joined binding-type-provider and binding-generator-impl
  into mdsal-binding-generator-impl

Change-Id: I7edb96eff81900b90b0f6195b009a412152c2b8f
Signed-off-by: Tony Tkacik <[email protected]>

Introduce top-level pom file.

Change-Id: Ic6ba1ee2963ee0db8ba041a46025dc994976428b
Signed-off-by: Tony Tkacik <[email protected]>

Merge branch 'split-mdsal' of ../controller

Bug 4035: Fixed some sonar warnings in md.sal.binding.impl

Change-Id: I7b850b65a7bfc40ef757115ae37a031fa88bebeb
Signed-off-by: Tony Tkacik <[email protected]>

Bug 4035: Remove unused implementations from sal-common-impl

Removed  left-overs from Hydrogen and Helium which are
not used anymore in Lithium codebase and will be unnecessary
in Beryllium codebase.

Removed classes were never part of public API contracts
outside of MD-SAL.

Change-Id: I2d19373b270e539598fe31b7e493db494b017100
Signed-off-by: Tony Tkacik <[email protected]>

Bug 4035: Removed sal-common which is unused since Helium.

Change-Id: Ia6e15cc1e94fcf5794a56fbf61d260644dcb457b
Signed-off-by: Tony Tkacik <[email protected]>

Bug 4035: Fixed some sonar / findbugs issues in DOM MD-SAL.

Change-Id: Id0ab9f65e4f1663f9e6cd85a6235a0a5fdee6f88
Signed-off-by: Tony Tkacik <[email protected]>

Bug 4035: Remove references to not present artefacts.

Change-Id: Id0308a4b544572df16bf01b1742eed60246dde54
Signed-off-by: Tony Tkacik <[email protected]>

Bug 4035: Extract dom-config from core-api and broker-impl

This patch introduces two new artefacts sal-dom-config
and sal-dom-broker-config which hosts all config subsystem
related MD-SAL DOM Broker implementation.

This patch is required for MD-SAL split in order to
not have cyclic dependency between controller and md-sal
project.

Change-Id: Ic93c583c07ae3e088dcf0e74cbdaaf627a8e79f6
Signed-off-by: Tony Tkacik <[email protected]>

Enabling Data Change Notifications for all nodes in cluster.

Two new interfaces are introduced ClusteredDataChangeListener and ClusteredDOMDataChangeListener and external applications will have to implement any of that interface,
if those applications want to listen to remote data change notifications.

Datastore registers listeners, which are instance of that interface, even on followers.

Change-Id: I0e29cdf2a08a2051de5fc8ce73b9ec8ac408e45b
Signed-off-by: Harman Singh <[email protected]>

Decouple message bus from netconf connector

Change-Id: I6a143e868adc1e5c7a9b114798e7009bb6ef8675
Signed-off-by: Maros Marsalek <[email protected]>
Signed-off-by: Tomas Cere <[email protected]>

Decouple config and netconf subsystems.

Extract a common mapping for config pusher and config subsystem netconf
Add a ConfigPersisterFacade for XML that allows reads/writes from/to config
subsystem using XML format
Push notifications from YangStoreService to NetconfNotificationManager instead
of using custom listeners
Migrate netconf features from controller features, untangle features

Change-Id: I71e4ca6e0258e0b1f0d6c19119f93eb9d68b7bca
Signed-off-by: Tomas Cere <[email protected]>
Signed-off-by: Maros Marsalek <[email protected]>
Signed-off-by: Ed Warnicke <[email protected]>

Fix license header violations in binding-data-codec

Change-Id: I797ac93efabe9eea6d2ae161ec39f3028ca78807
Signed-off-by: Thanh Ha <[email protected]>

Fix license header violations in binding-generator-impl

Change-Id: If155761c145d7b6db8c4378343733a7be256ba98
Signed-off-by: Thanh Ha <[email protected]>

Fix license header violations in binding-type-provider

Change-Id: Ib00d5625f834a9de12d10f8c3d9cbaaa7e70eb05
Signed-off-by: Thanh Ha <[email protected]>

Fix license header violations in sal-binding-broker

Change-Id: If6b75f466f97149ce4f0290135a754ca6cba1034
Signed-off-by: Thanh Ha <[email protected]>

Fix license header violations in sal-dom-broker

Change-Id: I78a5b836b7ea5053ede25a31e8a40319d365fe60
Signed-off-by: Thanh Ha <[email protected]>

Fix license header violations in sal-inmemory-datastore

Change-Id: I160d107a813c28ac75f1e5e21121068de9ccc7b8
Signed-off-by: Thanh Ha <[email protected]>

Fix license header violations in sal-binding-api

Change-Id: I877608c114bf4479c760f5b5dafed5d100d12cf5
Signed-off-by: Thanh Ha <[email protected]>

Fix license header violations in sal-dom-spi

Change-Id: I82f4796c933a6cec89950d4c474a0053637b2646
Signed-off-by: Thanh Ha <[email protected]>

Fix license header violations in sal-dom-api

Change-Id: I08a3d973bb56d6ee267576b691a32bfe27db6820
Signed-off-by: Thanh Ha <[email protected]>

Fix license header violations in sal-common-impl

Change-Id: I0702d7954d59f92ab62f6887a780db8a80f42ffa
Signed-off-by: Thanh Ha <[email protected]>

Fix license header violations in sal-common-api

Change-Id: I58fdef120495514ef94f2e9681790786ba4e0841
Signed-off-by: Thanh Ha <[email protected]>

Fix license header violations in yang-binding

Change-Id: I3c3fcd27c50ef3aa3c79ddaccddf8dfcf8bad4d8
Signed-off-by: Thanh Ha <[email protected]>

Bug 4035: Invert dependency binding-impl -> binding-config

Dependency between sal-binding-broker-impl and sal-binding-config
was inverted in order to ease split-off and to provide config
wiring outside of implementation.

This is required for separation of MD-SAL Binding implementation
into MD-SAL Project.

Change-Id: Id18567b2c51045461ed12500fe5cb2f324f55b0c
Signed-off-by: Tony Tkacik <[email protected]>

Fixed wrong format in ShardedDOMDataTree

Change-Id: Ie32ff9ad72e4bbae9a5ef1290ff63d5780c92313
Signed-off-by: Tony Tkacik <[email protected]>

BUG-1485: remove deprecated range methods

This Be-cycle patch removes the methods which have been removed in
Lithium, improving class size and not leaking the enforcement details.

Change-Id: I629df675eecac10c0aad1ed212123dca0f6d81d8
Signed-off-by: Robert Varga <[email protected]>

Make more mathods static

Private methods not touching object state can be made static, make it
so. Also remove an open-coded version of Strings.isNullOrEmpty().

Change-Id: I6e62ce1a4eb4b1556654172554eb69542df60403
Signed-off-by: Robert Varga <[email protected]>

Fix some minor sonar warnings

Mostly misplaced 'final' modifiers.

Change-Id: I5197b844e73db00467f7ebb852677c39176e5c94
Signed-off-by: Robert Varga <[email protected]>

Bug 3821 - Augmentation codecs may be loaded after codec creation.

In some scenarios - where schema context already contained
schema for introduced augmentation, but class was not known
at time codec creation was triggered - codec for augmenation
was not created and any subsequent uses of codec (class is
already known) failed with IncorrectNestingException.

This patch introduces

  - new exception MissingClassInLoadingStrategy
    which is subclass used by MD-SAL to retry after context update
    or timeout
  - supports loading of  augmentation codec after parent codec
    was created and augmentation is part of schema codec

Change-Id: If85f8e2be614a139947abc5daaa1e141b3c9b22c
Signed-off-by: Tony Tkacik <[email protected]>
(cherry picked from commit acf8e80b0747bd0aa724e978288bb83f6ca338ad)

Fix features-netconf-connector not being included

mdsal-artifacts should be listing the features it needs, so users can
pick up their versions. This was not true for
features-netconf-connector.

Change-Id: I4d53d8cf3d6ff1bce57e9de223126fea5269419d
Signed-off-by: Robert Varga <[email protected]>

TypeDefinition is a generic type

Do not use it in raw format, eliminating warnings.

Change-Id: I6012f812ce7a5aba75f163a8910fb0583fefd6cc
Signed-off-by: Robert Varga <[email protected]>
(cherry picked from commit 35e731b1818688f2aee43f525873087aca25110e)

Bug 2583 - illegal escape character if generated files

When a module file name starts with 'u' character, YangTools generates
comments in file containing '\u...' character sequences which java compiler
interprets as illegal escape character.
Problem is related most probably to windows builds only.

Change-Id: I81329b754710a68ada4e9c034c8980a1acd8a1b7
Signed-off-by: Peter Kajsa <[email protected]>

Bug 2721: StackOverflowError for leafref FIX

Leafref XPath needs to be checked whether it references itself
in order to detect incoming StackOverflowError
and throw appropriate exception if necessary.

Change-Id: Iacfa1a9f9d85f947e590b1d6412c9c482b417dbf
Signed-off-by: Martin Ciglan <[email protected]>

Sonar: remove unused modifiers

public/static/final modifies are implied by the context, e.g. by being
declared in an interface.

Change-Id: Ic2f97172595d7cdb2119510c077eabac55fa0798
Signed-off-by: Robert Varga <[email protected]>

[RFC][Fix] Fix for connection in pom.xml.

The connection value was wrong.
Apply values proposed by zxiiro.

Also fix sal-dom-xsql (wrong developerConnection).

This allows me to run  mvn site
w/o failing due to the wrong entry.

Change-Id: I15d953647a40dde4b37246a78bae120552efb15b
Signed-off-by: Jan-Simon Möller <[email protected]>

Make methods static

All these can be made static, so improve their efficiency.

Change-Id: Ie6aa238eab7fef728dd22af12a64a155a9db776e
Signed-off-by: Robert Varga <[email protected]>
(cherry picked from commit 12beaed7c9f1953562f79ef9699273d0ea53926c)

Make BaseYangTypes.TYPE_MAP immutable

The lookup map is expected to be immutable.

Change-Id: I0ed6c263d34e585dcca2445ec963ea785c934ab8
Signed-off-by: Robert Varga <[email protected]>
(cherry picked from commit c8e3e8de1506e8571651f430024c14157cdb61bb)

Throw an exception from private constructor

This is a utility class, it should never be instantiated.

Change-Id: Ic2edd90d0cf084a3a38e5a6c068172b9d774799e
Signed-off-by: Robert Varga <[email protected]>
(cherry picked from commit 2e0878d894f821db411c87f2ffff094e9b32b5ee)

Bug 3336 - Binding DTOs: fix binary-derived constructor

* added condition to only check for null in value assignmet if class has
one property (because then CheckNull is generated before assgnment)

Change-Id: I3bd18ec60347b3d1d5dec32e7bcafa432c56b5ad
Signed-off-by: Jan Hajnar <[email protected]>
(cherry picked from commit 0c58b4c45c1caedd1e3ecdfa056c0c4f98185c63)

Bug 3669 - ietf-restconf binding is incomplete

- added implementation of ModuleRevisionBuilder.java

Change-Id: If50041c1b0befcb5fb8678cf95f915ef4b079bfb
Signed-off-by: Peter Kajsa <[email protected]>

Bug 3687 - StreamWriterGenerator emits UNKNOWN_SIZE

StreamWriterGenerator always emitted sizing hint
for fully-completed data and sometimes even
counting all availble augmentations, which actually
lead-up to larger sizes of collections then needed.

Fix changes the SIZE HINT for "constant" max-sized
types (containers, augmentations, list entries)
to -1 so underlaying implementation could size
them based on actual data.

Change-Id: Ibd446f71c4b066f4dab4a7d73b1bc851d9e62c99
Signed-off-by: Tony Tkacik <[email protected]>
Signed-off-by: Robert Varga <[email protected]>
(cherry picked from commit b6fdf49d349662ffa82ae6477f99bac405799a3f)

Make methods static

These methods can be made static, make them such. Also fix raw types.

Change-Id: I4b697026857aae8579f0545e7e1284a7b8d00d04
Signed-off-by: Robert Varga <[email protected]>

BUG-3641: cache hashCode value

Builder-derived classes can be used as HashMap keys, which means they
can see their hashcode computed multiple times. Since this is a
recursive operation, the cost of it can be quite high, so dedicate two
fields for caching the hashcode result.

Change-Id: I0d95fd94187a421e4018b2f6992dfeaf2e126732
Signed-off-by: Robert Varga <[email protected]>
(cherry picked from commit 0158f45b9078cdb867d3ce3c44a4ed4746f311fe)

Bug 1485: Invoke lengthCheck only on non-null object.

Change-Id: Iec3cf2fe08fbdac4e5139acab7865cd4c4b6224f
Signed-off-by: Tony Tkacik <[email protected]>
(cherry picked from commit 8dfd02dec37d796ce7a51866416675b021e85b7c)

BUG-706 Ignore anyxml nodes in binding serializer

AnyXml is not supported on that level and currently leads to null pointer ex.

Change-Id: I5c2a64ab9502e4bba02efd822d2b5294ef456cef
Signed-off-by: Maros Marsalek <[email protected]>
(cherry picked from commit 8c4ddc66b0b1ef31a65b8cabf55173a16615bab2)

BUG-3051: Fix error reporting string

The exception thrown does not accurately describe what has happened. Be
more user-friendly and report the exact pattern which failed to match.

Change-Id: I0818c92c4a8cdf8c180234635c1efe059ff1c4e2
Signed-off-by: Robert Varga <[email protected]>
(cherry picked from commit 3680886f73ef87fb2818c57b12d3bc76525c3669)

BUG-1485: convert BuilderTemplate to use LengthGenerator

This converts BuilderTemplate to use the LengthGenerator class as
appropriate, speeding operations up. Also removes caching fields.

Change-Id: I1a0bfc56df8ab36880ae8e14c111cb9aca68c626
Signed-off-by: Robert Varga <[email protected]>
(cherry picked from commit 7998081d8e1761bf4798c1642e8e6107fc4666fc)

BUG-1485: Switch ClassTemplate length checker

Switch ClassTemplate to use LengthGenerator. Also removes the static field
used to hold ranges, as that is only used by deprecated length() method.

Change-Id: I2a084a71d21c8c63a2d9733fc767aa7ecd3cff67
Signed-off-by: Robert Varga <[email protected]>
(cherry picked from commit 65cf5ea01d87cbe65633a8e13fcbb6713e334ec2)

BUG-1485: Create LengthGenerator

LengthGenerator is akin to AbstractRangeGenerator, only simpler. Since
the type of the checked property can only be an integer, we can live
without subclasses. One weirdness is that it needs to support both
String and byte[] fields, but that is easily catered with two distinct
methods.

Change-Id: I6b714b4094c332c18ee210451b3bd1672ca74129
Signed-off-by: Robert Varga <[email protected]>
(cherry picked from commit b8e6be6a350b8dd39de74ca33fa039e92b198b17)

Migrate to MoreObjects

Objects is overloaded with JDK7, use the MoreObjects class.

Change-Id: I73f9ba24e990df8160b45b6fb0763a1b2ac231d6
Signed-off-by: Robert Varga <[email protected]>

Improve BindingDOMRpcImplementationAdapter performance

BindingReflections return a non-shared QNameModule instance, which means
that we may end up using suboptimal lookups when comparing QNames.
Furthermore it is not the QNameModule which we need in the fastpath, but
rather QName of the input statement, hence create a cached reference of
that -- leading to minimal object allocation in the fast path.

Change-Id: I97ceb43d80c50d53d21cc66a31bfaae6ff0193e9
Signed-off-by: Robert Varga <[email protected]>
(cherry picked from commit c4ee9b293370b81b76cc0e06accf3cde31ac1722)

Instantiate faster RpcServiceInvokers

Now that we have the SchemaPath->Method mapping available and
RpcServiceInvoker can instantiate efficient invokers based on the
QName->Method mapping, switch over to them by creating an intermediate
map.

Change-Id: If5e17924d9deb494045965578cfcec6d321d04d2
Signed-off-by: Robert Varga <[email protected]>
(cherry picked from commit 0aedb207da64e63900e2dbc85ba2a030ea7800e4)

Rework BindingDOMRpcImplementationAdapter instantiation

Move the SchemaPath/Method map closer to where we instantiate invokers.
This has the benefit of speeding up registration code very slightly,
but more importantly it allows instantiating more efficient invokers, as
we have the SchemaPath->Method map readily available.

Change-Id: Iefc0faadcfd7df6c40240ce1f78c7b734f06c618
Signed-off-by: Robert Varga <[email protected]>
(cherry picked from commit 99783448ed6bbcad04b66379db638241c58e3ec8)

BUG 3067: Added support for blocking if schema is not available.

Codecs are able to send specific exception, which describes
reason of failure for codec failing. If the reason is
missing schema (not yet loaded) we catch it and retry
serialization after schema context is upgraded.

User thread will be blocked maximally for 5 seconds
after that it will be unblocked.

Change-Id: I3494702eae644b495211a1a34c074e268c2f5f46
Signed-off-by: Tony Tkacik <[email protected]>
(cherry picked from commit 6aba3ef282f86a84920fa5a7ccf21c91d459806b)

Take advantage of YangInstanceIdentifier methods

YangInstanceIdentifier provides new, fast methods to acquire parent,
check if it empty and size of path arguments. Take advantage of them.

Change-Id: I527ff8cefb2799cb188ffe294c69e3b81a0d6909
Signed-off-by: Robert Varga <[email protected]>
(cherry picked from commit ad7a6537b709a72e763835cae683b8cc12401ce1)

Bug 3224 - Parsing data with choice in case via augmentation results in
incorrect parsing

* added tests for multiple choices from augmentation parsing
for json, xml and bindinging aware context
* modified json parsing tests
* fixed choice augmentation resolution in ChoiceNodeCodecContext
and CompositeNodeDataWithSchema
* moved findCorrespondingAugment to SchemaUtils since it is useful for
multiple Classes
* replaced getNodeIdentifierForAugmentation code in SchemaUtils  with
the one from CompositeNodeDataWithSchema.

Change-Id: Ibf57a771b92de14ecb70dcbbe250d7c559066882
Signed-off-by: Jan Hajnar <[email protected]>
(cherry picked from commit a8f512b80e661dac1ff85db6c16c72bfbf7f5891)

BUG 3566 : Get remote-rpc working again

Some changes to moving from CompositeNode to NormalizedNode had broken
remote rpc. This patch attempts to get it working again.

Verified everything works in a 3 node cluster with the clustering-test-app

Change-Id: I2ec714f1d21d95812bd5b486260be3575df252a2
Signed-off-by: Moiz Raja <[email protected]>
(cherry picked from commit 40217346551e20a809df37cd92955cd63c61944f)

BUG-1485: remove holder for deprecated Class ranges

With the switchover to new range checks, the static caching field is not
needed. We still retain compatibility with possible users out there, but
they are now responsible for caching the result.

Change-Id: I119615255559263f98fc382b324026c4f5d35cfc
Signed-off-by: Robert Varga <[email protected]>
(cherry picked from commit 924235feb5540c5a453c522e85d13fbd1d140c5a)

BUG-1485: remove holder for deprecated Builder field ranges

Caching the result was important as long as ranges were used internally,
now that they are not, do not retain them and re-generate them on each
call. Any callers out there are now responsible for caching them
themselves.

Change-Id: Idcba7fe54c59e33d6eedb6b596a2bf4f4a5ca10c
Signed-off-by: Robert Varga <[email protected]>
(cherry picked from commit 8d510398ba320a17ba932d27b98423e8bcad1a10)

BUG-1485: switch BuilderTemplate to new range enforcement

This switches the template for builders to the new range enforcement
code.

Change-Id: I1368a6a6922b2e982b9f4274dca32cf73b888d4b
Signed-off-by: Robert Varga <[email protected]>
(cherry picked from commit 5b7dc4042d5827c60bf9ca9daaaf369242c931f9)

BUG-1485: switch ClassTemplate to new range enformcement

Switch range checks for simple classes (typedefs and similar) to the new
range checker. Also move printRangeConstraint() from BaseTemplate to
BuilderTemplate, as it ends up being used only there.

Change-Id: I16e4c1faf239d838ff415c0173ef3d06acc61701
Signed-off-by: Robert Varga <[email protected]>
(cherry picked from commit 02e503a09314f2e3192b85ed9fccaff5efb4942c)