Robert Varga [Tue, 17 Nov 2015 16:31:34 +0000 (17:31 +0100)]
Do not rely on ExtendedType when looking for the base type
A base type can be recognized as having its base type null, use that
indicator instead of specific implementation class. Also change the
implementation to use a simple loop instead of recursion.
Change-Id: Iff3e78c618bcbb7a33ae7335ea3bafe7cdf203a6
Signed-off-by: Robert Varga <[email protected]>
Robert Varga [Tue, 17 Nov 2015 14:37:29 +0000 (15:37 +0100)]
Do not import BindingGeneratorUtil.packageNameForGeneratedType()
This method is polymorphic, with one of its flavors being deprecated.
Silence a deprecation warning by not using a static import.
Change-Id: Ia4cc4cd2aeef003e047f4ae0729f51de958a152a
Signed-off-by: Robert Varga <[email protected]>
Robert Varga [Tue, 17 Nov 2015 12:41:39 +0000 (13:41 +0100)]
Do not use EnumerationType in BindingRuntimeContext
This is a preparatory patch, which makes handling of enumerations based
on interfaces rather than a deprecated implementation.
Change-Id: I0b2f610d63df2f4151d620e1e7638b8bf01b9b36
Signed-off-by: Robert Varga <[email protected]>
Robert Varga [Tue, 17 Nov 2015 12:31:05 +0000 (13:31 +0100)]
Do not use SchemaPath.getPath()
Use SchemaPath.getPathFromRoot() instead.
Change-Id: Ic7b7ede59dbe8826197e1e131be855590d0a3d98
Signed-off-by: Robert Varga <[email protected]>
Igor Foltin [Tue, 3 Nov 2015 07:17:56 +0000 (08:17 +0100)]
BUG-4322: return default valued-object
This patch modifies DataObjectCodecContext to return a default value
generated from the 'default' statement when a request is made for a
field which is not present in NormalizedNodes.
That has the effect of leaves with default value being seen as set to
the default value.
Added unit tests.
Change-Id: I99c97d796a9b32557955c4b0bd95d0051ab56f5c
Signed-off-by: Robert Varga <[email protected]>
Signed-off-by: Igor Foltin <[email protected]>
Robert Varga [Tue, 3 Nov 2015 21:35:36 +0000 (22:35 +0100)]
Speed up BindingGeneratorUtil.makeSerializable()
Instead of performing lookup on every call, use a thread-local instance
which can be reused.
Change-Id: I45e7170bcfe06bb76f87d723a703f9849e9da4a3
Signed-off-by: Robert Varga <[email protected]>
Robert Varga [Tue, 3 Nov 2015 21:34:43 +0000 (22:34 +0100)]
Speed TypeProviderImpl up a bit
Perform defensive checks before performing expensive computation. Also
make private methods static as appropriate.
Change-Id: I649b1d5ea4cac5c1617036e9e074f5a123bfc602
Signed-off-by: Robert Varga <[email protected]>
Robert Varga [Mon, 2 Nov 2015 16:24:50 +0000 (17:24 +0100)]
Use a dedicated typedef resolver
DataNodeIterator is excessively expensive for extraction of a list of
typedefs. Create a dedicated class to do that.
Change-Id: Ibf980bfe85113b5d996754c4ba6e32fd14d5ab69
Signed-off-by: Robert Varga <[email protected]>
Tony Tkacik [Thu, 12 Nov 2015 14:21:48 +0000 (15:21 +0100)]
Bug 4360: Removed incorrect precondition for class nesting.
Change-Id: I665c89934872f0685d594631d0e81db4a4413284
Signed-off-by: Tony Tkacik <[email protected]>
Tony Tkacik [Wed, 23 Sep 2015 09:33:21 +0000 (11:33 +0200)]
Generate sources to target/generated-classes/mdsal-binding
Change-Id: Ibb49339b58d7fee5f2b301a2e71d9500d893d923
Signed-off-by: Tony Tkacik <[email protected]>
Robert Varga [Tue, 10 Nov 2015 18:19:50 +0000 (18:19 +0000)]
Revert "Bug 1672: Generated javadoc contains symbols of javadoc comment tags"
This reverts commit
8d273cee83b985508fb231617f3cd23d121d38eb, as it looks like it broke controller.
Change-Id: I679ae4dac8bdf5a838ad8babfcf451958fbda904
Signed-off-by: Robert Varga <[email protected]>
Igor Foltin [Mon, 28 Sep 2015 14:08:43 +0000 (16:08 +0200)]
Bug 1672: Generated javadoc contains
symbols of javadoc comment tags
Fixed encoding of html tags
and yang description in generated
javadoc comments.
Change-Id: Ic0512287345bc633c36325217e89aa9726a4056b
Signed-off-by: Igor Foltin <[email protected]>
Signed-off-by: Igor Foltin <[email protected]>
Tony Tkacik [Tue, 3 Nov 2015 11:57:03 +0000 (12:57 +0100)]
Bug 1435: Introduced DOM Data Commit Cohort & Validation APIs
Introduced DOM Data Broker level APIs for 3PC commit cohorts
and utility abstract class for implementing Data Tree validator.
Change-Id: I54ca7e022f8dee278c8cd9156514b62dd37cfc97
Signed-off-by: Tony Tkacik <[email protected]>
Martin Ciglan [Wed, 4 Nov 2015 10:36:18 +0000 (11:36 +0100)]
Fix for unknown statements used without prefix
in tested YANG models.
Change-Id: I4d40be3785320a7d1be66fb5b77f25171998fc89
Signed-off-by: Martin Ciglan <[email protected]>
Peter Kajsa [Mon, 2 Nov 2015 13:50:22 +0000 (14:50 +0100)]
Bug 4570: Test fix after automatic removal of empty non-presence containers
Some tests in mdsal failed after automatic removal of empty non-presence containers
introduced by this patch set:
https://git.opendaylight.org/gerrit/#/c/17030/26
Change-Id: I7cd53986cf33daf35c4a3cbe96a4343ad5e40313
Signed-off-by: Peter Kajsa <[email protected]>
Stephen Kitt [Thu, 1 Oct 2015 08:06:17 +0000 (10:06 +0200)]
Upgrade upstream versions
Where possible rely on odlparent:
* maven.javadoc.version
* xmlunit
* javassist
* xml-apis
* osgi-core
* javax.ws.rs-api
* reporting configuration
Update the following dependencies:
* maven-verifier 1.5 -> 1.6
* groovy 2.1.6 -> 2.4.5
* maven-core, maven-plugin-api 3.1.1 -> 3.3.3
* xtend 2.7.3 -> 2.8.4
* jersey-client 2.0 -> 2.22
* com.lmax:disruptor 3.3.0 -> 3.3.2
* build-helper-maven-plugin 1.8 -> 1.9.1
* plexus-container-default 1.5.6 -> 1.6
Drop equinoxSDK381:org.eclipse.osgi which appears to no longer be
necessary.
Change-Id: Ia97ee869f0018ea4c1a14352f11c8898fe0968eb
Signed-off-by: Stephen Kitt <[email protected]>
Wojciech Dec [Fri, 2 Oct 2015 09:55:11 +0000 (11:55 +0200)]
Bug890 - Adding ietf-inet-types 2013-07-15 yang model
Change-Id: I195646ee95dd8b3e6b4a39b773e5eb6c462fe0ca
Signed-off-by: Wojciech Dec <[email protected]>
Robert Varga [Sat, 10 Oct 2015 13:22:12 +0000 (15:22 +0200)]
Use Objects.hashCode()/equals() in generated DTOs
Using java.util.Objects reduces complexity of generated code, leading to
leaner class files.
Change-Id: I941ede7cf9f60a9372864048bccdbb1650d2f5cf
Signed-off-by: Robert Varga <[email protected]>
Robert Varga [Tue, 29 Sep 2015 18:57:43 +0000 (20:57 +0200)]
Remove default BindingGeneratorImpl constructor
The default verbose constructor has been deprecated in Lithium, remove
it.
Change-Id: Ib54981b117ea1557138ab1820f6f41b7766973cc
Signed-off-by: Robert Varga <[email protected]>
Robert Varga [Tue, 29 Sep 2015 19:07:48 +0000 (21:07 +0200)]
Fix various eclipse warnings
Raw types and method which could be static.
Change-Id: I19dcd742674944877f4b7b53d11068f630c826db
Signed-off-by: Robert Varga <[email protected]>
Robert Varga [Sat, 10 Oct 2015 17:05:21 +0000 (19:05 +0200)]
Cleanup whitespace/formatting in codecs
This is a drive-by cleanup of whitespace.
Change-Id: Ib691ab3a04ee25938d4c1bd670ae62a01162565a
Signed-off-by: Robert Varga <[email protected]>
Robert Varga [Mon, 28 Sep 2015 13:48:50 +0000 (15:48 +0200)]
Do not emit empty strings for Generated*BuilderImpl
With a null argument, we can end up creating quite a few empty strings,
which end up being non-shared. Place an explicit check and return an
interned empty string instead.
Change-Id: I4fd9126c9502f2c80c76ca3bb38aa94a99d3ae4b
Signed-off-by: Robert Varga <[email protected]>
Robert Varga [Thu, 24 Sep 2015 15:13:50 +0000 (17:13 +0200)]
Reuse attach-sources from odlparent
odlparent already defines these, no need to override.
Change-Id: Ied060b4f746f470cde8bd61178169f3ad60d06df
Signed-off-by: Robert Varga <[email protected]>
Tony Tkacik [Tue, 6 Oct 2015 16:19:21 +0000 (18:19 +0200)]
ModuleInfoBackedContext uses YangTextSchemaResolver.
This removes locking from ModuleInfoBackedContext
and improves perforamance characteristic during
access from multiple threads.
Change-Id: I8c6c3d228fcdb384761185f5347cde284490fbde
Signed-off-by: Tony Tkacik <[email protected]>
Maros Marsalek [Wed, 30 Sep 2015 13:18:58 +0000 (15:18 +0200)]
BUG-4367 Make ModuleInfoBackedContext also a source provider
Change-Id: Ibf80071e4af4480a32e1c233738edfd4c866d450
Signed-off-by: Maros Marsalek <[email protected]>
Robert Varga [Fri, 2 Oct 2015 16:10:12 +0000 (18:10 +0200)]
Fix maven-bundle-plugin not scanning transitive dependencies
New version of the plugin seems disregard the Embed-Transitive
directive, leading to a failure to inline needed packages. Fix this up
by explicitly specifying them as dependencies.
Change-Id: Id8275584b57a14444b632b64c33e8afa9a01e16b
Signed-off-by: Robert Varga <[email protected]>
Maros Marsalek [Wed, 30 Sep 2015 14:22:53 +0000 (16:22 +0200)]
Wait for schemas when transforming BA->NormalizedNode
If the transformation fails due to missing schema, codec tries to wait for
the models to become available. The assumption is that if there already are
the BA classes, its likely that the schemas will follow shortly.
This improvement should fix possible race conditions during ODL startup.
Change-Id: I101b77d6ca8f247c271bed0a18fff20de43c24bf
Signed-off-by: Maros Marsalek <[email protected]>
Tom Pantelis [Mon, 14 Sep 2015 10:55:43 +0000 (06:55 -0400)]
Handle null BindingRuntimeContext in BindingToNormalizedNodeCodec
In the getModuleBlocking method, if timing is right, runtimeContext may
be null when it is accessed to get the SchemaContext. It is set in the
onGlobalContextUpdated method which may not have been called yet prior
to getModuleBlocking. There's already code to wait for schema via the
futureSchema so it shold check for null runtimeContext as well. Also
runtimeContext shoild be volatile as it's accessed by multiple threads.
Change-Id: I335b0c359d58f3c58da34c7255b75ac793e49bd6
Signed-off-by: Tom Pantelis <[email protected]>
Tony Tkacik [Wed, 30 Sep 2015 13:57:12 +0000 (15:57 +0200)]
Do not emit unknown nodes into javadoc.
Change-Id: I6b9ea2b752e07583ee48eda5705a03dbe96566c4
Signed-off-by: Tony Tkacik <[email protected]>
Tom Pantelis [Mon, 14 Sep 2015 10:17:37 +0000 (06:17 -0400)]
Add generated yang dirs to .gitignore
Change-Id: I283d9b5040840feb3287073cc14a33d8a0b9402c
Signed-off-by: Tom Pantelis <[email protected]>
Tony Tkacik [Tue, 29 Sep 2015 16:40:12 +0000 (18:40 +0200)]
Bug 3654: Introduction of latest topology model
Introduced latest revision of ietf-network model.
Change-Id: If83d5646c881c1cf1424317e75c5bd81c36e06dd
Signed-off-by: Tony Tkacik <[email protected]>
Peter Kajsa [Mon, 21 Sep 2015 13:04:18 +0000 (15:04 +0200)]
Bug 3670 (part 4/5 - mdsal): Use of new statement parser in yang-maven-plugin
Parser switch in mdsal:
- parser switch in ModuleInfoBackedContext
Yangtools retest:
- BUG-1485: remove deprecated range methods
- Mockito bug fix
- binding-generator-impl unit test switch to new statement parser
- null pointer in BindingGeneratorImpl fix
Change-Id: Iab1e130f29b98db95f842b2628b2a280f3cf26e0
Signed-off-by: Peter Kajsa <[email protected]>
Robert Varga [Mon, 28 Sep 2015 21:02:51 +0000 (23:02 +0200)]
Intern package names
Analysis of a heap dump has shown that we are ending up with a lot of
duplicate strings containing generate Java code package names.
Instantiate an interner which normalize these to a single instance.
Change-Id: Id6faa0474ee5fe9417732a08ba6027f7e68fb5d2
Signed-off-by: Robert Varga <[email protected]>
Robert Varga [Mon, 28 Sep 2015 20:29:22 +0000 (22:29 +0200)]
Do not store code snippets in BindingRuntimeContext
Analysis of a heap dump shows we retain a fair amount of strings which
represent the QNAME member of generated classes via ConstantImpl. This
should not be happening, as the logic to create QNames in generated
classes should be part of the templates and only emitted to source code.
Teach ClassTemplate how to generate QName constants and only store the
QName in the Constant, saving the overhead of Strings.
Change-Id: I41951f969e273bc2ef4527ef3d95d4bed45c1b7f
Signed-off-by: Robert Varga <[email protected]>
Robert Varga [Mon, 28 Sep 2015 14:37:32 +0000 (16:37 +0200)]
Bump xtend to 2.8.4
Just a regular update.
Change-Id: I02caac3cedb20dd13c2802cc909081e1a1ae03f4
Signed-off-by: Robert Varga <[email protected]>
Tony Tkacik [Mon, 24 Aug 2015 19:41:43 +0000 (21:41 +0200)]
Bug 3868: Introduction of DOM Cursor APIs.
Change-Id: I722216172dcf4ee2b40f25daf4adf55d3ce3291f
Signed-off-by: Tony Tkacik <[email protected]>
Robert Varga [Sun, 27 Sep 2015 16:55:01 +0000 (18:55 +0200)]
Use Objects.equals()
This simplifies implementations of equals() method.
Change-Id: Ib58c7417607f85224ab6d452dab2a8aac604c055
Signed-off-by: Robert Varga <[email protected]>
Robert Varga [Sun, 27 Sep 2015 13:27:55 +0000 (15:27 +0200)]
Use Objects.hashCode()
Instead of open0-coded conditionals, use the utility method, hence
making our code more linear.
Change-Id: I2fcfef8982aebe8e2c81bf8145fb35255591d688
Signed-off-by: Robert Varga <[email protected]>
Tony Tkacik [Wed, 23 Sep 2015 12:51:00 +0000 (14:51 +0200)]
Removed DataChangeListener in favour of DataTreeChangeListener
DataChangeListener does not have place in new Beryllium APIs,
since it behaviour could be built on top of DataTreeChangeListener.
DataChangeListener concept will still reside in controller-provided
APIs, but not MD-SAL project APIs.
Change-Id: I1cbae306b76f4456cf93ec34e5e020e02aae8147
Signed-off-by: Tony Tkacik <[email protected]>
Tony Tkacik [Wed, 23 Sep 2015 12:34:57 +0000 (14:34 +0200)]
Renamed Data(ReadOnly|WriteOnly) to DataTree(Read|Write)
Renamed interfaces and classes prefixed with Data
to DataTree and ommited Only, since new APIs does not
provide combitation of both behaviours.
Change-Id: I7e3377464659e2f902bb93e149a77d6184e72f46
Signed-off-by: Tony Tkacik <[email protected]>
Tony Tkacik [Wed, 23 Sep 2015 12:21:23 +0000 (14:21 +0200)]
Removed ReadWriteTransaction concept from APIs.
Change-Id: I0cdbb4b67806eb0374acd679ded07e57b436b724
Signed-off-by: Tony Tkacik <[email protected]>
Tony Tkacik [Wed, 23 Sep 2015 13:00:14 +0000 (15:00 +0200)]
Added type-safe DataObjectModification#getModifiedChildren
Change-Id: I0489a1dd41c825f74f9fc1f9c8af38ab8c5d8830
Signed-off-by: Tony Tkacik <[email protected]>
Martin Ciglan [Tue, 22 Sep 2015 12:51:25 +0000 (14:51 +0200)]
Bug 4301: Incorrect union generated code when using decimal64
Binding Java API Generator shouldn't generate getValue() method
for java.math BigDecimal & BigInteger types, representing
YANG decimal64 & uint64 types.
This is just a port from yangtools.
Change-Id: I8f50003296d1004f9799c96950f49b4a38732137
Signed-off-by: Martin Ciglan <[email protected]>
Tony Tkacik [Wed, 23 Sep 2015 12:00:49 +0000 (14:00 +0200)]
Added create method to DataTreeIdentifier
Change-Id: I96799fefa432392d5dfd441603d36cab922e2460
Signed-off-by: Tony Tkacik <[email protected]>
Michal Polkorab [Fri, 18 Sep 2015 14:10:59 +0000 (16:10 +0200)]
Bug 4327 - Fixed DataTreeChangeListener registration in PingPongDataBroker
- delegate broker was incorrectly queried for DOMDataTreeChangeService
- it must ask for supported extensions instead of instanceof
Change-Id: I0310926893fc517bb1e1dca48d4966d6ffc18c74
Signed-off-by: Michal Polkorab <[email protected]>
Robert Varga [Mon, 21 Sep 2015 15:32:53 +0000 (17:32 +0200)]
BUG-2399: handle APPEARED/DISAPPEARED modification types
This adds support for handling the appeared/disappeared modification
types when instantiating a lazy data object.
Change-Id: I7a00d2c31dcc382b8b90d4a1125ec932e3075281
Signed-off-by: Robert Varga <[email protected]>
Robert Varga [Thu, 17 Sep 2015 03:39:35 +0000 (05:39 +0200)]
BUG-2399: take into account new ModificationTypes
APPEARED/DISAPPEARED changes may occur when structural containers come
and go. These should be treated as WRITE and DELETE for change
resolution purposes.
Change-Id: I22d7c76f149b8f72decb1c81ce960cd60ba8dc6c
Signed-off-by: Robert Varga <[email protected]>
Robert Varga [Thu, 17 Sep 2015 03:33:45 +0000 (05:33 +0200)]
BUG-865: remove the use of ModificationType.MERGE
Change-Id: I5209acc1ec3165dc2d4e25851cfea50f91df524c
Signed-off-by: Robert Varga <[email protected]>
Robert Varga [Thu, 17 Sep 2015 01:40:22 +0000 (03:40 +0200)]
BUG-4309: package iana-afn-safi
This fixes a failure to package iana-afn-safi.
Change-Id: I325561606a3f48e0e337f67c639011cf15cd63b7
Signed-off-by: Robert Varga <[email protected]>
Robert Varga [Tue, 15 Sep 2015 04:56:12 +0000 (06:56 +0200)]
BUG-865: remove use of deprecated APIs
YANG parser is going to lose these, do not use them.
Change-Id: Id33e324ee0661902addb9537af34504b28d762e5
Signed-off-by: Robert Varga <[email protected]>
Robert Varga [Tue, 15 Sep 2015 04:55:55 +0000 (06:55 +0200)]
Remove duplicate dependency
Maven warns about it, remove it.
Change-Id: I6823d825a74679c66c7d2cdc08425ae8572ca6a8
Signed-off-by: Robert Varga <[email protected]>
Thanh Ha [Wed, 2 Sep 2015 02:58:42 +0000 (22:58 -0400)]
Use odlparent configuration for jacoco
Change-Id: Ic8c5e9730ea5f50e6b7ad1f345840de20cae7738
Signed-off-by: Thanh Ha <[email protected]>
Tony Tkacik [Mon, 31 Aug 2015 16:11:22 +0000 (18:11 +0200)]
Store DOMDataTreeProducer in ShardingTable
Change-Id: I785c10c68eb5b5ce09d103685488c2965340d3d5
Signed-off-by: Tony Tkacik <[email protected]>
Tony Tkacik [Mon, 31 Aug 2015 15:57:11 +0000 (17:57 +0200)]
Generalized ShardingTableEntry into generic
ShardingTableEntry was generalized into generic structure
which is indexed by YangInstanceIdentifier and may
store any arbitrary structure.
This allows for tree-base index not only of shards,
but also producers and listeners, which may be useful
during resharding operations.
Change-Id: Idde0cca1b0f4292bab0c06a0fede67fb25992e83
Signed-off-by: Tony Tkacik <[email protected]>
Tony Tkacik [Mon, 31 Aug 2015 14:01:29 +0000 (16:01 +0200)]
Bug 3868: Added support for bounding producers
ShardedDOMDataTree and ShardedDOMDataTreeProducer are updated
to support bounding of producers to listeners.
- Added simple loop detection for listener to not directly
listen on subtrees it is bound to.y
Change-Id: I1328a01a9629d4c7e7cab36acaf6082ba4bacb3d
Signed-off-by: Tony Tkacik <[email protected]>
Tony Tkacik [Mon, 31 Aug 2015 12:10:27 +0000 (14:10 +0200)]
Bug 3868: Added support for DOMDataTreeListener
Added really simplistic and naive implementation
for DOMDataTreeListener, which is just enough
to listen on underlying data store and capture
current state.
Implementation is synchronized and does not
survive resharding currently.
Added simple base unit test to test registration
fo listener and receiving data change events.
Change-Id: I07eded569207e93bb4bb311236261b5cb7982903
Signed-off-by: Tony Tkacik <[email protected]>
Tony Tkacik [Mon, 31 Aug 2015 08:59:12 +0000 (10:59 +0200)]
Bug 3869: Fixed ShardedDOMDataTree to adhere to API
ShardingTableEntry:
- Replaced emptyMap with HashMap to allow to populate
table entry
- Fixed #remove(Iterator) to remove registration
ShardedDOMWriteTransaction:
- Checks if writen path is delegated to other child
producer.
- submit() invokes DOMDataTreeProducer in order
to notify when transaction is submitted.
ShardedDOMDataTreeProducer
- #transactionSubmitted() clears openTx field
in order to allow to allocate next transaction
or close producer.
Added unit tests which tests ShardedDOMDataTree
to adhere to Shard & Producer API contracts defined
in DOMDataTreeService and DOMDataTreeProducerService
Change-Id: I39fae5f40e5b8a1cd07fcbe183c937b5c5bda348
Signed-off-by: Tony Tkacik <[email protected]>
Signed-off-by: Robert Varga <[email protected]>
Tony Tkacik [Mon, 24 Aug 2015 19:26:52 +0000 (21:26 +0200)]
Bug 3866: Introduced Binding Adapters for DataTreeProducer
Change-Id: I55518ce6de7edaf8bd68d6d2fccd217684b48536
Signed-off-by: Tony Tkacik <[email protected]>
Tony Tkacik [Mon, 24 Aug 2015 14:53:16 +0000 (16:53 +0200)]
Bug 3867: Introduced Binding APIs for Data Tree Producer.
Change-Id: I234581af7704446b0a3af64723528647b58505f0
Signed-off-by: Tony Tkacik <[email protected]>
Tony Tkacik [Mon, 14 Sep 2015 07:51:03 +0000 (07:51 +0000)]
Merge "Fix duplicate artifact inclusion"
Tony Tkacik [Mon, 14 Sep 2015 07:50:25 +0000 (07:50 +0000)]
Merge changes I4b3820fd,Ib225745c
* changes:
BUG-4264: deprecate packageNameForTypeDefinition()
BUG-4264: do not duplicate strings needlessly
Robert Varga [Mon, 24 Aug 2015 15:43:36 +0000 (17:43 +0200)]
Fix a deprecation warning
SchemaNode.getPath() is deprecated, this is a simple migration.
Change-Id: Ic7b16a6aace06eaddd2562709c48d74ceab6191c
Signed-off-by: Robert Varga <[email protected]>
Florin Coras [Thu, 10 Sep 2015 16:33:44 +0000 (18:33 +0200)]
Add mdsal-model-artifacts to binding-parent
Given the migration to use the MD-SAL project, dependencies like
ietf-inet-types and ietf-yang-types are now imported via
org.opendaylight.mdsal.model instead of org.opendaylight.yangtools.model
groupId. However, the dependency management section of the
binding-parent does not include mdsal-model-artifacts, where the
previously mentioned artifacts are declared. This breaks imports in
bundles inheriting from binding-parent.
Change-Id: Id19c36862f8ab8bbfa70f8a538619070cf8814d7
Signed-off-by: Florin Coras <[email protected]>
Peter Kajsa [Fri, 4 Sep 2015 07:50:42 +0000 (09:50 +0200)]
Bug 4145: Issue augmenting choice inside a list
The problem occurs when target node of uses-augment statement
is added by uses from another grouping and the uses statement
is not directly inside the grouping, but it is nested below
other elements (e.g. list, container etc.) in the grouping.
In this case the original of the target node is not found and
the IllegalStateException is thrown.
Change-Id: I1b0329d5da754251040894c0ccfe920bf8190aa4
Signed-off-by: Peter Kajsa <[email protected]>
Robert Varga [Mon, 7 Sep 2015 12:17:27 +0000 (14:17 +0200)]
Fix duplicate artifact inclusion
Duplicate dependency is triggering a maven warning, remove it.
Change-Id: Ia38455e648f8fd8fc8eb98aec5e5313be11ebbdf
Signed-off-by: Robert Varga <[email protected]>
Robert Varga [Sat, 5 Sep 2015 19:21:58 +0000 (21:21 +0200)]
BUG-4264: deprecate packageNameForTypeDefinition()
This method is only used in tests and is broken, schedule it for
removal.
Change-Id: I4b3820fd9e02d4903087271e2982390e8c2573a2
Signed-off-by: Robert Varga <[email protected]>
Robert Varga [Sat, 5 Sep 2015 19:10:54 +0000 (21:10 +0200)]
BUG-4264: do not duplicate strings needlessly
This patch adds safeguards for string transformation methods to check if
the result is the same as input. This should address the string
duplication issues.
Change-Id: Ib225745ce35b492997edc60abd1abb3e41032795
Signed-off-by: Robert Varga <[email protected]>
Robert Varga [Fri, 4 Sep 2015 00:01:38 +0000 (02:01 +0200)]
Use NodeIdentifier.create()
Using create() results in reused instances, thus lowering memory
footprint.
Change-Id: If1a1a3c3c74567374093a76df6e00ed7110b4f1c
Signed-off-by: Robert Varga <[email protected]>
Robert Varga [Fri, 4 Sep 2015 13:54:41 +0000 (13:54 +0000)]
Merge changes from topic 'be/migration/mdsal'
* changes:
Removed not-building code.
Removed left-over dependencies to YANGTools models.
Tony Tkacik [Thu, 3 Sep 2015 17:29:02 +0000 (19:29 +0200)]
Removed not-building code.
Change-Id: Id89947a47aa2e5de19ac967013892a1e6a132fd3
Signed-off-by: Tony Tkacik <[email protected]>
Tony Tkacik [Thu, 3 Sep 2015 10:09:04 +0000 (12:09 +0200)]
Removed left-over dependencies to YANGTools models.
Change-Id: I71a5e1a50038629abb627d1d5cf28a5d794918c8
Signed-off-by: Tony Tkacik <[email protected]>
Robert Varga [Wed, 2 Sep 2015 22:17:21 +0000 (22:17 +0000)]
Merge "Added .gitreview"
Stephen Kitt [Mon, 24 Aug 2015 13:28:22 +0000 (15:28 +0200)]
Provide a single-argument variant of firstKeyOf()
InstanceIdentifier::firstKeyOf() doesn't seem to need its second
argument, even for generic type resolution (even in Java 7). This
patch adds a variant with only the component type argument.
I'm not sure what the deprecation practices are so I haven't
deprecated the two-argument version.
Change-Id: I6d4822472db627519600f5f0828f3ebe632fc00b
Signed-off-by: Stephen Kitt <[email protected]>
Signed-off-by: Robert Varga <[email protected]>
Tony Tkacik [Thu, 27 Aug 2015 13:58:58 +0000 (15:58 +0200)]
Fixed export package in mdsal-binding-generator-impl
Change-Id: Ib28bcec5674635bea781d89d97535afb195f99af
Signed-off-by: Tony Tkacik <[email protected]>
Tony Tkacik [Thu, 27 Aug 2015 12:28:09 +0000 (14:28 +0200)]
Added mdsal-model Karaf feature.
Change-Id: I08e12fb9f9db7f872cffec4b82f7e22d9414716e
Signed-off-by: Tony Tkacik <[email protected]>
Tony Tkacik [Wed, 26 Aug 2015 12:56:26 +0000 (14:56 +0200)]
Introduced MD-SAL Karaf Features
Introduced new MD-SAL Karaf features, which allows
customized inclusion only of subset of functionality
such as Java Binding without Brokers, or DOM Broker
without Binding Broker.
Change-Id: I4ddb447b7b430e004023362d91fa286f6515c225
Signed-off-by: Tony Tkacik <[email protected]>
Tony Tkacik [Thu, 27 Aug 2015 12:07:55 +0000 (14:07 +0200)]
Materialized project.groupId in -artifacts.
groupId must be materialized in -artifacts type of POM file
otherwise Maven resolves it against of groupId of project
which imported such POM file.
Change-Id: Ibd7c78957c1286836b47aaed0d0ed825b74b331a
Signed-off-by: Tony Tkacik <[email protected]>
Tony Tkacik [Wed, 26 Aug 2015 16:18:23 +0000 (18:18 +0200)]
Fixed Export-Package sections after rename.
Change-Id: I6b7fc00f53167d398bac35010fb03a81aa1f5912
Signed-off-by: Tony Tkacik <[email protected]>
Tony Tkacik [Wed, 26 Aug 2015 13:06:18 +0000 (15:06 +0200)]
Converted model packaging from jar to bundle
Change-Id: I0a6dae4ca90296b92a56c97cc5de2c6b081eed3f
Signed-off-by: Tony Tkacik <[email protected]>
Tony Tkacik [Wed, 26 Aug 2015 09:40:24 +0000 (11:40 +0200)]
Renamed test packages to use org.opendaylight.mdsal
Change-Id: Ie3272a21a39328c363a8f278cd734cdd927c995b
Signed-off-by: Tony Tkacik <[email protected]>
Tony Tkacik [Wed, 26 Aug 2015 09:18:36 +0000 (11:18 +0200)]
Renamed controller.md.sal.dom.store.impl -> mdsal.dom.store.inmemory
Change-Id: Ibe14d77f1279c8dba40d93e7ccc6acb67dc907a1
Signed-off-by: Tony Tkacik <[email protected]>
Tony Tkacik [Wed, 26 Aug 2015 09:03:22 +0000 (11:03 +0200)]
Cleaned up mdsal-common-api and mdsal-dom-spi
Renamed mdsal-dom-spi packages to mdsal.dom.spi
Renamed .controller.md.sal.common.api to mdsal.common.api
Removed legacy concepts
Change-Id: Ib2626444f6d1beb14b757c309237c20826440006
Signed-off-by: Tony Tkacik <[email protected]>
Tony Tkacik [Tue, 25 Aug 2015 15:53:13 +0000 (17:53 +0200)]
Removed legacy binding-api concepts.
Removed concepts, which were copied from Hydrogen APIs
and needs rework in Beryllium. These concepts are still
present in controller project and will be supported
in Beryllium.
Change-Id: Ie1b9ac0a725decf33b1d742ebbbc53493bae1ff7
Signed-off-by: Tony Tkacik <[email protected]>
Robert Varga [Wed, 26 Aug 2015 06:41:03 +0000 (06:41 +0000)]
Merge "Cleaned up dom-api and dom-broker from legacy concepts."
Tony Tkacik [Tue, 25 Aug 2015 11:56:04 +0000 (13:56 +0200)]
Cleaned up dom-api and dom-broker from legacy concepts.
Change-Id: I68d188cf43b7137caa8a3a1f9b49c37c9e4b3376
Signed-off-by: Tony Tkacik <[email protected]>
Tony Tkacik [Tue, 25 Aug 2015 10:47:56 +0000 (12:47 +0200)]
Renamed yangtools.binding.data.codec.api to mdsal.binding.data.codec.api
Change-Id: I071879001c0cdfb6040714ed7b5d6309b7961204
Signed-off-by: Tony Tkacik <[email protected]>
Tony Tkacik [Tue, 25 Aug 2015 09:57:45 +0000 (11:57 +0200)]
Added .gitreview
Change-Id: I2e63bb982082518b7c2e33c4d908993b25c99139
Signed-off-by: Tony Tkacik <[email protected]>
Tony Tkacik [Mon, 24 Aug 2015 14:45:08 +0000 (16:45 +0200)]
Renamed controller.md.sal.dom.broker.impl to mdsal.dom.broker
Change-Id: I185b2803a4c5933c8372996ced0a01bdffdb5ee4
Signed-off-by: Tony Tkacik <[email protected]>
Tony Tkacik [Mon, 24 Aug 2015 14:40:14 +0000 (16:40 +0200)]
Renamed controller.md.sal.dom.api to mdsal.dom.api
Change-Id: Ib6e9f962e0d8555567a64aa62ef7a6f9264abab4
Signed-off-by: Tony Tkacik <[email protected]>
Tony Tkacik [Mon, 24 Aug 2015 14:38:43 +0000 (16:38 +0200)]
Renamed controller.md.sal.binding.api to mdsal.binding.api
Change-Id: Iec42b3e33e64ce84c7d667d29409266158c98137
Signed-off-by: Tony Tkacik <[email protected]>
Tony Tkacik [Mon, 24 Aug 2015 14:29:48 +0000 (16:29 +0200)]
Renamed controller.md.sal.binding.impl to mdsal.binding.dom.adapter
Change-Id: Ie6ad34615f89c84b3ff0b7a5bfc51703eb758db9
Signed-off-by: Tony Tkacik <[email protected]>
Tony Tkacik [Fri, 21 Aug 2015 10:40:27 +0000 (12:40 +0200)]
Moved binding MD-SAL APIs to binding folder
Renamed artefacts:
sal-binding-api to mdsal-binding-api
sal-binding-broker to mdsal-binding-dom-adapter
sal-binding-util to mdsal-binding-util
Removed deprecated Hydrogen and Helium interfaces
and adapters, since they still can be provided from
original location.
Change-Id: I0ebbfc2e927aa6c036e9be7ed216a48d970e66d0
Signed-off-by: Tony Tkacik <[email protected]>
Tony Tkacik [Fri, 21 Aug 2015 10:45:19 +0000 (12:45 +0200)]
Cleaned up sal-dom-* packages and removed legacy interfaces
- Removed deprecated interfaces from mdsal-common-api,
some of this interfaces will be present in controller
for backwards compatibility
- Changed groupId to org.opendaylight.mdsal
- Changed artifactId from sal-core to msdal-dom
Change-Id: I222bee07e5fd13fe10d19f01ba4f9bdf102bf3e5
Signed-off-by: Tony Tkacik <[email protected]>
Tony Tkacik [Fri, 21 Aug 2015 10:41:17 +0000 (12:41 +0200)]
Cleaned up sal-common-* to common folder
- Added mdsal- prefix
- Updated groupId to org.opendaylight.mdsal
Change-Id: I4daef4cf6c341a4f3029f3b88a17856bdd17c009
Signed-off-by: Tony Tkacik <[email protected]>
Tony Tkacik [Fri, 21 Aug 2015 10:38:02 +0000 (12:38 +0200)]
Migrated models to use MD-SAL provided code.
Change-Id: Ia92933803e133604b5a54b1b2c82210480ae3ffc
Signed-off-by: Tony Tkacik <[email protected]>
Tony Tkacik [Thu, 20 Aug 2015 09:16:17 +0000 (11:16 +0200)]
Cleaned up Java Binding code from YANG Tools
- Introduced artifacts pom
- Updated groupId from .yangtools to .mdsal
- Renamed code-generator to binding folder which
makes more sense since it contains also codecs
and other functionality not directly related
to code generation.
- added mdsal- prefix to artifact id to make
it more distinguishable from YANGTools
- joined binding-model-api, binding-generator-api,
binding-generator spi into mdsal-binding-generator-api
- joined binding-type-provider and binding-generator-impl
into mdsal-binding-generator-impl
Change-Id: I7edb96eff81900b90b0f6195b009a412152c2b8f
Signed-off-by: Tony Tkacik <[email protected]>
Tony Tkacik [Thu, 20 Aug 2015 08:37:45 +0000 (10:37 +0200)]
Introduce top-level pom file.
Change-Id: Ic6ba1ee2963ee0db8ba041a46025dc994976428b
Signed-off-by: Tony Tkacik <[email protected]>
Andrew Grimberg [Wed, 19 Aug 2015 20:35:44 +0000 (13:35 -0700)]
Merge branch 'split-mdsal' of ../controller
Tony Tkacik [Tue, 28 Apr 2015 13:41:05 +0000 (15:41 +0200)]
Bug 4035: Fixed some sonar warnings in md.sal.binding.impl
Change-Id: I7b850b65a7bfc40ef757115ae37a031fa88bebeb
Signed-off-by: Tony Tkacik <[email protected]>
Tony Tkacik [Thu, 23 Jul 2015 12:23:26 +0000 (14:23 +0200)]
Bug 4035: Remove unused implementations from sal-common-impl
Removed left-overs from Hydrogen and Helium which are
not used anymore in Lithium codebase and will be unnecessary
in Beryllium codebase.
Removed classes were never part of public API contracts
outside of MD-SAL.
Change-Id: I2d19373b270e539598fe31b7e493db494b017100
Signed-off-by: Tony Tkacik <[email protected]>