Bug 5384: Remove expired mapping from datastore too

Change-Id: I167673226e9fb1af08a975659acf1077aa923e93
Signed-off-by: Lorand Jakab <lojakab@cisco.com>

Remove old yang-maven-plugin configurations

Change-Id: I73f09f8b263aa5133f6a848db2a21ef27b83aaa5
Signed-off-by: Lorand Jakab <lojakab@cisco.com>

Use IetfInetUtil for Ipv4Address instantiation

Utility class for faster instantiation.

Change-Id: I1caabf2ff99ba51afe715c5159d97140b4562b59
Signed-off-by: Robert Varga <rovarga@cisco.com>

Bug 5384: Remove expired mappings from datastore when restoring

Change-Id: Iba739a38155726e790b96fcaa7298b7f00c57e24
Signed-off-by: Lorand Jakab <lojakab@cisco.com>

Sonar: Constants should be declared "final static"

Change-Id: I625dee28e39d5919f79a512a3cb95ef947870848
Signed-off-by: Lorand Jakab <lojakab@cisco.com>

Sonar: Avoid modifiers which are implied by the context

Change-Id: I366848356f2d0860f74565ad152174e5119e4465
Signed-off-by: Lorand Jakab <lojakab@cisco.com>

Merge "Optimize Ipv{4,6}(Prefix)Serializers"

Merge changes Ie652cc3c,If8a16a65,I96dba381,I23880f30

* changes:
  Optimize MapRequestUtil
  Optimize LispNotificationHelper
  Optimize MaskUtil
  Optimize LispAddressUtil

Merge "Fix ELPs"

Optimize Ipv{4,6}(Prefix)Serializers

Use InetAddresses.forString() and make private methods static where
possible.

Change-Id: I849f5eefc5d099cf792f30cd3fc65fd7e1acc0a5
Signed-off-by: Robert Varga <rovarga@cisco.com>

Optimize MapRequestUtil

Use InetAddresses for String->Address conversion.

Change-Id: Ie652cc3c53859d3eae58bf1ff7a7484b3abeb9c2
Signed-off-by: Robert Varga <rovarga@cisco.com>

Optimize LispNotificationHelper

Use a Guava Splitter to split strings into components.

Change-Id: If8a16a65ddaba55f23257d53d5b6607698624323
Signed-off-by: Robert Varga <rovarga@cisco.com>

Optimize MaskUtil

Do not instantiate temporary Strings.
Do not use String.split(String).
Usse InetAddresses.

Change-Id: I96dba381b8b1e94c2b332e5d050a2c94f06a8b90
Signed-off-by: Robert Varga <rovarga@cisco.com>

Optimize LispAddressUtil

Use a direct string literal for /32 and /128.
Use InetAddresses.forString().
Make patterns properly final.

Change-Id: I23880f30a6917de45521856675002daba26c579b
Signed-off-by: Robert Varga <rovarga@cisco.com>

Fix ELPs

Change-Id: I5c2283a7ff4b5a5b549951037f34c22327ef3ca7
Signed-off-by: Florin Coras <fcoras@cisco.com>

Update Beryllium tutorial documentation resources

Change-Id: I1e398cbb1a1b4ad4751ab50e4bd2e396044b485e
Signed-off-by: Lorand Jakab <lojakab@cisco.com>

Bug 5344: Fix NPE when restoring DAO from datastore

Change-Id: I0a31b84daa1f0d100aa12fc0d8b288efbf654707
Signed-off-by: Florin Coras <fcoras@cisco.com>

Bug 5275: Fix NPE for negative NB mappings

Change-Id: Ie97494aff82ded1a8c63d7fcf8adfc215dceeafb
Signed-off-by: Florin Coras <fcoras@cisco.com>

Merge "Bug 5270: Fix merging"

Bug 5270: Fix merging

1) Fix merge bit parsing in Map-Register/Notify
2) Sort locators in merged mapping record

Change-Id: I25047d1e39f1f4277e8d92bb9611f42b5876f178
Signed-off-by: Florin Coras <fcoras@cisco.com>

Merge "Bug 5257: Increase subscriber TTL to 1 day"

Bug 5259: Fix NPE in serializer when merge is on

Avoid null records in map-notify by ensuring that newly registered
mappings are actually stored before building the map-notify.

Change-Id: Ied01de30a9449b4dbf54dc6da0ee37066be2c164
Signed-off-by: Florin Coras <fcoras@cisco.com>

Bug 5256: Set correct src EID for src/dst SMRs

Change-Id: I7e65e782c73d8520b10db2e51223e8e7967fd270
Signed-off-by: Florin Coras <fcoras@cisco.com>

Bug 5255: Send SMRs on NB mapping creation

Change-Id: If96f59dc7ebb8fce0b6890c0eea512e01a4c64ed
Signed-off-by: Florin Coras <fcoras@cisco.com>

Bug 5258: Fix NPE

Change-Id: I6807c3e312deca44e3c56db48a590ce0f15bf930
Signed-off-by: Lorand Jakab <lojakab@cisco.com>

Bug 5257: Increase subscriber TTL to 1 day

Change-Id: Idc7509531d152132cf3a2ecc4dd506357964f74d
Signed-off-by: Lorand Jakab <lojakab@cisco.com>

Bug 5239: Fix IID Source/Dest lookup

The issue is that the source EID is passed to the map-cache lookup as an
IP, not as an IP-prefix, and therefore it is not masked accordingly when
performing the longest prefix match. This patch updates the
MaskUtil.normalize() code to convert IPs to an IP-prefixes.

Change-Id: Iafd7bef2ef0911e6cbc61b8315208eb639e41766
Signed-off-by: Florin Coras <fcoras@cisco.com>

Bug 5228: More SMR fixes

Don't send mapping update notification for southbound originated mapping
changes, since the notifications are used for sending SMRs, and that is
handled elsewhere in MapServer.java's handleMapRegister() method, no
need to handle again in onMappingChanged().

Change-Id: I07ee8110f898e92c17fed0e14fb2f2f121cef143
Signed-off-by: Lorand Jakab <lojakab@cisco.com>

Merge "Bug 5209: Fix EID string in URLs"

Bug 5228: Use custom comparator for mappings

Change-Id: If44444dded1027c2d31e78815df77d88ca8a4cb3
Signed-off-by: Lorand Jakab <lojakab@cisco.com>

Bug 5209: Fix EID string in URLs

Change-Id: Ie402cb1ca66ddd468cc2273c8e8bed3e42bce2bc
Signed-off-by: Lorand Jakab <lojakab@cisco.com>

Merge "Remove BindingAwareBroker"

Merge "BUG-5047: switch to using PingPong data broker"

Merge "BUG-5047: close read transactions"

Remove BindingAwareBroker

This is legacy API and not used in the implementation for any real
purpose. Remove references to it.

Change-Id: I4648c35cdd2a8aedd84c79f517b078fd29cffd23
Signed-off-by: Robert Varga <rovarga@cisco.com>

BUG-5047: switch to using PingPong data broker

PingPong data broker performs automatic transaction merging and ensures
the data store is not overloaded with small transactions. It works
efficiently with TransactionChains, so let's switch to using it to reap
its benefits.

Change-Id: I0f023b02f2bf2c03da1b542d816cd86b4c99a5a5
Signed-off-by: Robert Varga <rovarga@cisco.com>

BUG-5047: close read transactions

Read transactions need to be closed as per API contract. While the
datastore can recover, it is rather costly to do so, hence explicitly
close the transaction.

Change-Id: If056a9fe4f851e97a4d7d8f1c0a96aa339310554
Signed-off-by: Robert Varga <rovarga@cisco.com>

Bug 5217: Fix VNI of SB mappings in RESTCONF

Change-Id: I9ffbd07a0585c3cdea4d67dc8389ed6ac0a339a4
Signed-off-by: Lorand Jakab <lojakab@cisco.com>

Bug 5216: Fix Instance ID authentication failure

Change-Id: Ib0f1ab5442c8c7062346522a0b0bbf151b3c08ad
Signed-off-by: Lorand Jakab <lojakab@cisco.com>

Bug 5209: Add VNI to EID strings

Change-Id: I2207eae4fce2c8b4df62fa460ce40044ea1c6bb8
Signed-off-by: Lorand Jakab <lojakab@cisco.com>

Bug 5207: Fix missing Map-Notify caused NPE

Additionally, change the log level for the missing Map-Notify to DEBUG,
since in case the Want-Map-Notify bit is not set, it is normal not to
have a Map-Notify.

Change-Id: I09262fa5afcb8d769a06af2c94d9ccb180bb867c
Signed-off-by: Lorand Jakab <lojakab@cisco.com>

Remove reference to xtend

We do not use xtend, no need to to mention it.

Change-Id: I3e86cdf495531b435e04dda9245780fe7047615b
Signed-off-by: Robert Varga <rovarga@cisco.com>

Bug 5047: Move to transaction chains and async APIs

This gives ~40% performance increase in NB RPC add-mapping rate on my
local VM.

Change-Id: I92313e6e9bb5994c560a44a3b0024edef05a0c83
Signed-off-by: Lorand Jakab <lojakab@cisco.com>

BUG-2625: bump equinox version

This bumps the equinox version to 3.9.1.

Change-Id: I92c867c517fd4acc8f49f13d38575925ff42ce6c
Signed-off-by: Robert Varga <rovarga@cisco.com>

Bug 5047: Improve soutbound performance

This commit resulted in ~40% performance increase for the
Map-Request/Map-Reply tests [1] on my local VM.

[1] https://jenkins.opendaylight.org/releng/view/lispflowmapping/job/lispflowmapping-csit-1node-performance-only-beryllium/plot/#lispflowmapping-csit-1node-performance-only-beryllium-pps.csv-history.csv

Change-Id: I70a8a893a022f958e2ecfaa93271b170473ff8ce
Signed-off-by: Lorand Jakab <lojakab@cisco.com>

Bug 5022: Migrate UI to IETF YANG model

Change-Id: I1a7b64788c5298d7050abd89ff39be6cb0667f99
Signed-off-by: Lorand Jakab <lojakab@cisco.com>

Bug 5003: Fixing merging of SB mappings (for reachability) into NB Mappings when needed.
(not tested)

Change-Id: Ic7992f148bf768f1399213dbd6a2f6da00b0a992
Signed-off-by: vermagan@cisco.com <vermagan@cisco.com>

Bump yangtools to 1.0.0-SNAPSHOT

Change-Id: Ic2f0e237440cd478c081bac92e14c46a9f3f9f5b
Signed-off-by: Thanh Ha <thanh.ha@linuxfoundation.org>

Bug 5034: Fix ServicePath normalization

Check if VNI is null and build normalized address accordingly.

Change-Id: Ic110664d7d4d78cac8a14bd63e04cee268a901e8
Signed-off-by: Florin Coras <fcoras@cisco.com>

Bug 5005: Send Map-Notify to all affected xTRs

When merging is on, when a Map-Register is received send Map-Notify
containing the merged locator set to all xTRs that registered the same
prefix.

Change-Id: I50990371a077d2f405d99f0285e113333c9e2e76
Signed-off-by: Lorand Jakab <lojakab@cisco.com>

Merge "Bug 5016: Fix VNI for Source and Dest parsing in SourceDestKeyHelper"

Bug 5016: Fix VNI for Source and Dest parsing in SourceDestKeyHelper

Change-Id: Icbdc5e0d17a9b6d4eb21a9c1d6dba7268737b8be
Signed-off-by: Florin Coras <fcoras@cisco.com>

Bug 4991: Map-Notify with merged record when merging

Change-Id: Ib86db1f836893779cc0144dcf45937a45ff3c499
Signed-off-by: Lorand Jakab <lojakab@cisco.com>

Bug 4976: Fix NPE in SimpleMapCache

Change-Id: I0647c2b539876f319d71bb2186eee5a07ee3f300
Signed-off-by: Lorand Jakab <lojakab@cisco.com>

Bump versions by 0.1.0 for next dev cycle

Change-Id: I4f9c273f753ce478bfc33c73e2ea65aa479af58e
Signed-off-by: Thanh Ha <thanh.ha@linuxfoundation.org>

Bug 4906: Remove inactive SB mappings after a timeout

Change-Id: I83c28854acde09343b775154f0b2e4b4bbbc94fc
Signed-off-by: Lorand Jakab <lojakab@cisco.com>

Bug 4932: Sending SMRs to subscribers after storeing the new record.

Change-Id: I0605cc8858c32f82e87fb8564d3cca3823c8a268
Signed-off-by: vermagan@cisco.com <vermagan@cisco.com>

Bug 4822: Fix mapping record merging

Change-Id: Idee0361f31a5a0cad28ba35d3165683c64126266
Signed-off-by: Lorand Jakab <lojakab@cisco.com>

Bug 4932:  Sending SMR to the old EID key when a more specific is being registered for the first time.

Change-Id: I6a26c4230a49993ebd3442ffe4b6d46b19b61554
Signed-off-by: vermagan@cisco.com <vermagan@cisco.com>

Bug 4910: Make use of the StartingServiceIndex constant in the MappingSystem

Change-Id: Ic1e351ce6322a465ebc9072144572e5b23a02e7d
Signed-off-by: Florin Coras <fcoras@cisco.com>

Bug 4910: Make starting ServiceIndex a constant

Change-Id: I947d2676ab043039fde1b755cfc2d8554f5c09fe
Signed-off-by: Florin Coras <fcoras@cisco.com>

Bug 4909: Fix ServicePath LCAF normalization

Change-Id: Ie30450d4bf5e36aacf88fabc840eadb9a404faae
Signed-off-by: Florin Coras <fcoras@cisco.com>

Bug 4822: Simplify access to configuration variables

This patch removes the need to pass on configuration variables as part
of the API. Instead, any class can get access to any configuration
variable by accessing a single static instance of ConfigIni. This opens
up the possibility of adding new knobs to modify behavior of parts of
the code, without the need to change APIs (adding a method call
parameter for each knob).

The patch doesn't change the existing APIs (they should be cleaned up in
Boron timeframe though), but allows new confguration options with no API
changes. The main reason for this patch NOW is Bug 4822, which is
related to the merging of locators, and needs support for a new
configuration option.

Change-Id: I0f3a8680c749034f2b784cd5c24379dc3f589538
Signed-off-by: Lorand Jakab <lojakab@cisco.com>

Merge "WIP: Bug 4822: Infra for merging: store source RLOC"

WIP: Bug 4822: Infra for merging: store source RLOC

Add support for storing a list of source RLOCs inside a mapping record,
to be used for merging locators, more specificly, to send Map-Notify
messages to the appropriate xTRs on merge.

Change-Id: Ifbea9ba9471e7edb89bae7db3695828a98ad3f51
Signed-off-by: Lorand Jakab <lojakab@cisco.com>

Merge "BUG-4840: drop dependency on org.opendaylight.controller:sal"

BUG-4840: drop dependency on org.opendaylight.controller:sal

Change-Id: Ic63515f25ff773f5fe239530ee52f83535cbf536
Signed-off-by: Stephen Kitt <skitt@redhat.com>

Bug 4832: Add serializer for Service Path LCAF

Change-Id: Ie4d45e6ec9d2635d14a242c109e0e2d1c00f9cd3
Signed-off-by: Lorand Jakab <lojakab@cisco.com>

Add support for Service Path mapping records processing

The patch introduces two important changes for mapping records with
Service Path EIDs. First, it ensures that ServicePath EIDs are
normalized (i.e., Service Index is set to 0) before being used as keys
in mappings caches. Second, when doing lookups, for records with ELP
locator records, the Service Index in the requested EID is used to
select one, next hop, locator that is returned in the map-reply, instead
of the whole ELP.

Change-Id: Id487f3603f89beb5a878d5256709112ef004b4f6
Signed-off-by: Florin Coras <fcoras@cisco.com>

Add support for non-overwriting mapping storage

When the "lisp.mappingOverwrite" configuration variable is set to
"false" this new mode of operation will allow storing a separate
MappingRecord for each unique xTR-ID from southbound registration. This
is independent from (but in preparation of) the merge functionality, as
rataining all southbound registrations is useful in non-merge mode too,
i.e., for liveness detection and statistics.

Change-Id: I6d322fbb5620815dbfc09dc49770373b48ec91c2
Signed-off-by: Lorand Jakab <lojakab@cisco.com>

Pull in hamcrest from odlparent

odlparent provides hamcrest-core; unittest_tools can rely on that as
long as it re-defines the scope (from test to compile).

Change-Id: I2878ef079c550dc58dde4564286704613aa7c01d
Signed-off-by: Stephen Kitt <skitt@redhat.com>

Add missing license headers

Change-Id: Ia97bd156bc15f0022092535bb487183495c44dda
Signed-off-by: Thanh Ha <thanh.ha@linuxfoundation.org>

Add ServicePath specific calls to postman collections

Change-Id: Id63cf7ec3978c9a1a7aa4032a131ed8d20236e79
Signed-off-by: Florin Coras <fcoras@cisco.com>

Add LispAddressStringifier support for ServicePath LCAF

Change-Id: I0c8aaaf1d49dd14eae6ac2e8460cc417c60d4cf6
Signed-off-by: Florin Coras <fcoras@cisco.com>

Add xTR-ID and site-ID fields inside MappingRecord

In preparation for locator merging support.

Change-Id: I82b7fc94678af5102a5885cdd67485ac14219c79
Signed-off-by: Lorand Jakab <lojakab@cisco.com>

Bug 4778: Add missing service-path-lcaf identity

Change-Id: I018ddebf955856fc845a805b5ddbc7dd56c6c358
Signed-off-by: Florin Coras <fcoras@cisco.com>

Sonar: Don't throw generic exceptions

Fix 13 instances of Sonar issue "Generic exceptions Error,
RuntimeException, Throwable and Exception should never be thrown"
labeled as Major. The rule description says: "Using such generic
exception prevents calling methods from handling differently each kind
of error."

Change-Id: I45a65903217375ab470275a2f5346d016ecebcf1
Signed-off-by: Lorand Jakab <lojakab@cisco.com>

Use model based Enum for LISP message type

... and remove LispMessageEnum.java from lisp-proto.

Change-Id: I143d59145fb57d825bf256b6b6f59a9df411916f
Signed-off-by: Lorand Jakab <lojakab@cisco.com>

Sonar: Exception handler should preserve exception

Fix 29 instances of Sonar issue "Exception handlers should preserve the
original exception" labeled as Major. The rule description says: "When
handling a caught exception, two mandatory informations should be
logged: 1) some context to ease the reproduction of the issue; 2) the
original's exception, for its message and stack trace."

Change-Id: I172b52d86d98ad735c940738dc5c35abc1cf675e
Signed-off-by: Lorand Jakab <lojakab@cisco.com>

Rename integration tests module

Change-Id: I6633eb7dcc12cd50a59ced5bce55275f1d7fd79d
Signed-off-by: Lorand Jakab <lojakab@cisco.com>

Sonar: Method params shouldn't be reassigned

Fix 14 instances of Sonar issue "Method parameters, caught exceptions
and foreach variables should not be reassigned" labeled as Major. The
rule description says: "While it is technically correct to assign to
parameters from within method bodies, it is better to use temporary
variables to store intermediate results. This rule will typically detect
cases where a constructor parameter is assigned to itself instead of a
field of the same name, i.e. when this was forgotten. Allowing
parameters to be assigned to also reduces the code readability as
developers will not be able to know whether the original parameter or
some temporary variable is being accessed without going through the
whole method. Moreover, some developers might also expect assignments of
method parameters to be visible from callers, which is not the case and
can confuse them. All parameters should be treated as final."

Change-Id: I488d2c3fbaf28814f207f65027f80d4b7d0e622e
Signed-off-by: Lorand Jakab <lojakab@cisco.com>

Remove MapServerMapResolverUtil.java from lisp-proto

This file is no longer needed after the migration to the IETF LISP YANG
model.

Change-Id: I2fa5c4529986ceaf66e37da9d1d7f93cca90e7be
Signed-off-by: Lorand Jakab <lojakab@cisco.com>

Sonar: Utility classes shouldn't have public constructor

Fix 19 instances of Sonar issue "Utility classes should not have a
public constructor" labeled as Major. The rule descriptions says:
"Utility classes, which are a collection of static members, are not
meant to be instantiated. Even abstract utility classes, which can be
extended, should not have public constructors. Java adds an implicit
public constructor to every class which does not define at least one
explicitly. Hence, at least one non-public constructor should be
defined."

Change-Id: I5e17afe35bc44d02e238f5a1558dfcfb588c7f80
Signed-off-by: Lorand Jakab <lojakab@cisco.com>

Fix source-dest-key example in RESTCONF Postman

Additionally, add a GET for an IID prefix

Change-Id: Ifb5e7726b048835bb5f8ab5bb624576610556b9e
Signed-off-by: Lorand Jakab <lojakab@cisco.com>

Sonar: Final Class

Fix 22 instances of Sonar issue "Final Class" labeled as Major.  The
rule description says: "Checks that class which has only private
constructors is declared as final."

Change-Id: Id544a5671266756fee68424b162954321657c581
Signed-off-by: Lorand Jakab <lojakab@cisco.com>

Sonar: if/else/for/while/do statements need braces

Fix 23 instances of Sonar issue "if/else/for/while/do statements should
always use curly braces" labeled as "Major".

Add checkstyle rule to avoid introducing more of these.

Change-Id: I17152d437349c9ca45018421f6e580130c51c4e6
Signed-off-by: Lorand Jakab <lojakab@cisco.com>

Move integration tests to top-level directory

Since integration tests are now based on Karaf, they have to run after
everything else is built, so they don't seem to fit well with the
'mappingservice' component.

Change-Id: I5f5e18a3b068e430a14b53d720e8fa4e57951b80
Signed-off-by: Lorand Jakab <lojakab@cisco.com>

Merge "Use odlparent-lite as artifacts parent"

Merge topic/ietf_yang into master

Change-Id: Idf0e284cbe1bdd55106865e8f94ccc46bccfc99c
Signed-off-by: Lorand Jakab <lojakab@cisco.com>

Fix SourceDestKeyHelper

Change-Id: If9cc584aecb8648d78ec4cd3331ba57341e989ce
Signed-off-by: Florin Coras <fcoras@cisco.com>

Make source-dest-key-lcaf use simple-address

Change-Id: I406b0c7babc30dd43db0c5163df8339fb15a9130
Signed-off-by: Lorand Jakab <lojakab@cisco.com>

Fix SourceDest mappings printing

Change-Id: I5fd6d6307d4bb90ed4b5152c84fd972f739a3ead
Signed-off-by: Florin Coras <fcoras@cisco.com>

Migrate Postman collections to IETF YANG model

Change-Id: I4b7689c650fd6d9a9133e2ebcfc0e61e80a59d76
Signed-off-by: Lorand Jakab <lojakab@cisco.com>

Migrate integrationtest to IETF YANG model

Change-Id: Ib7e3fb9c1d9c30d9d97fc41130aa978b2caf946b
Signed-off-by: Lorand Jakab <lojakab@cisco.com>

Add map-cache support for EID VNI

This adds a VNI table as the first table in the multi-table lookup
process employed for matching an EID in the map-cache.

Change-Id: Ica0abddf522f5f48158df5b8b680b162d91154ab
Signed-off-by: Florin Coras <fcoras@cisco.com>

Migrate implementation/neutron/southbound to IETF YANG model

Change-Id: I2e7738f5c518a51c1a309d63854bfaced3d6375c
Signed-off-by: Lorand Jakab <lojakab@cisco.com>
Signed-off-by: Florin Coras <fcoras@cisco.com>

Migrate lisp-proto implementation to IETF YANG model

Change-Id: I8f769d01f2c643960a1693b1f385100e2c3ed34e
Signed-off-by: Lorand Jakab <lojakab@cisco.com>

Use odlparent-lite as artifacts parent

We created odlparent-lite to provide a minimal pom which allows projects
to publish to the correct server. Without this ${project}-artifacts may
fail to deploy to Nexus.

Change-Id: Id095a7c732818cefd3c5ec0792d40eafcd9feee8
Signed-off-by: Thanh Ha <thanh.ha@linuxfoundation.org>

Merge branch 'master' into topic/ietf_yang

Change-Id: I7cb3bb7f8f6423db3bf51e0b49e66a4472d2c03a
Signed-off-by: Lorand Jakab <lojakab@cisco.com>

Add odl- prefix to YANG files

Prefix all ODL originateded YANG files with odl- just like IETF
originated YANG files start with ietf- to avoid potential name clashes,
when connecting devices with their own YANG models to ODL.

Change-Id: I05b8bf89872d89cf5fb6d2a4b5d0f499f9c26449
Signed-off-by: Lorand Jakab <lojakab@cisco.com>