Robert Varga [Wed, 5 Feb 2014 03:01:01 +0000 (04:01 +0100)]
Use reference cache for Communities and ASes
These two type of objects get reused over and over again, so it makes
sense to actually use refcaching on them.
Change-Id: I9c63ab23cdf0480055e7a868a73107c4ac9926ff
Signed-off-by: Robert Varga <rovarga@cisco.com>
Robert Varga [Tue, 4 Feb 2014 13:15:08 +0000 (14:15 +0100)]
Introduce the ReferenceCache concept
This is a simple CPU/memory tradeoff primitive, which allows for sharing
of object references in the cardinality/frequency of a particular object
type is favorable. AsNumber is typical candidate.
Change-Id: I79ab163f5da32ad5f99ba99246ae96005ac03df5
Signed-off-by: Robert Varga <rovarga@cisco.com>
Robert Varga [Tue, 4 Feb 2014 01:10:10 +0000 (02:10 +0100)]
Add a bit of documentation to extension contexts
Change-Id: Iaadb9e7874c68fdd1d7225ca414d7daf720728a3
Signed-off-by: Robert Varga <rovarga@cisco.com>
Dana Kutenicsova [Tue, 4 Feb 2014 09:50:24 +0000 (10:50 +0100)]
Fixed small bugs in PCEP. Adjusted configuration.
Change-Id: I0879c7ffada0c8444e4cfe2694970fbebfdc6fc7
Signed-off-by: Dana Kutenicsova <dkutenic@cisco.com>
Dana Kutenicsova [Mon, 3 Feb 2014 13:40:32 +0000 (14:40 +0100)]
Cleaned up linkstate project.
Change-Id: I0b5e97e882bc694de32a8f2da7c6ef45a225ce67
Signed-off-by: Dana Kutenicsova <dkutenic@cisco.com>
Robert Varga [Mon, 3 Feb 2014 19:08:02 +0000 (20:08 +0100)]
Turn putOperationalData() in replace operations
It turns out that putOperationalData is really a merge, not a replace.
Force it to a replace by issuing an explicit remove. This depends on
https://git.opendaylight.org/gerrit/#/c/5106/ to work as designed.
Change-Id: Ic7106c51c7226d9c06aa78df56efb9adc834b74b
Signed-off-by: Robert Varga <rovarga@cisco.com>
Robert Varga [Wed, 29 Jan 2014 21:04:32 +0000 (22:04 +0100)]
Fix formatting
Change-Id: I4933c956a1f6b7662fe907b16718b0204d20db7d
Signed-off-by: Robert Varga <rovarga@cisco.com>
Robert Varga [Mon, 27 Jan 2014 16:44:56 +0000 (17:44 +0100)]
Rework Termination Point state handling
It turns out that MD-SAL does transaction reordering and provides not
guarantees to data visibility between transactions. Until that is fixed,
do not rely on data in MD-SAL, but rather do our own state tracking.
Change-Id: Idf1a14f9f61c78d651e3f29970faa87436bdb8ca
Signed-off-by: Robert Varga <rovarga@cisco.com>
Robert Varga [Fri, 31 Jan 2014 11:17:26 +0000 (12:17 +0100)]
Fix topology not showing prefixes learned from BGP/LS
The Linkstate RIB plugin was losing IP reachability information in the
prefix case. Fix it by using the copy builder constructor.
Also add a defensive check for IP reachability presence in the topology
builder.
Change-Id: I0b16b036397a935771d86a3c7253c998e594ec7c
Signed-off-by: Robert Varga <rovarga@cisco.com>
Dana Kutenicsova [Fri, 31 Jan 2014 13:19:00 +0000 (13:19 +0000)]
Merge "Revert "Force export of *.impl package""
Robert Varga [Fri, 31 Jan 2014 13:11:34 +0000 (14:11 +0100)]
Revert "Force export of *.impl package"
This reverts commit
fa59dde5163f230ec2cb594d61928c066ac55cde.
Change-Id: Id757da382ff01d0b2fd36a3390ca1b72545e5ae9
Signed-off-by: Robert Varga <rovarga@cisco.com>
Dana Kutenicsova [Fri, 31 Jan 2014 10:35:15 +0000 (11:35 +0100)]
Added some API documentation.
Change-Id: I4fe17f920c8483694842ac96759ef45aa3765c1f
Signed-off-by: Dana Kutenicsova <dkutenic@cisco.com>
Dana Kutenicsova [Wed, 29 Jan 2014 16:51:43 +0000 (16:51 +0000)]
Merge "Fix NPE when sending a PCInitiate message"
Dana Kutenicsova [Wed, 29 Jan 2014 16:50:59 +0000 (16:50 +0000)]
Merge "Remove superfluous version declaration"
Robert Varga [Wed, 29 Jan 2014 13:23:40 +0000 (14:23 +0100)]
Fix NPE when sending a PCInitiate message
Change-Id: I4c167b5465d200a5293bb6c0b7530b116a0cbf6c
Signed-off-by: Robert Varga <rovarga@cisco.com>
Robert Varga [Tue, 28 Jan 2014 14:31:11 +0000 (15:31 +0100)]
Remove superfluous version declaration
Change-Id: Iff8638e62b77041b412b275a0c172d9b2985369a
Signed-off-by: Robert Varga <rovarga@cisco.com>
Robert Varga [Mon, 27 Jan 2014 09:53:17 +0000 (10:53 +0100)]
Add the ability to configure which stateful revision should be supported
Change-Id: I241e47873fc6ace8e2c0283bb4b38a93c3a8a98a
Signed-off-by: Robert Varga <rovarga@cisco.com>
Robert Varga [Mon, 27 Jan 2014 11:29:53 +0000 (12:29 +0100)]
Activate modules by default, but do not use them
Change-Id: I29d4ca38cd0d6fb7dd9e9bc72205c872d9a8992d
Signed-off-by: Robert Varga <rovarga@cisco.com>
Robert Varga [Mon, 27 Jan 2014 22:03:05 +0000 (23:03 +0100)]
Force export of *.impl package
Change-Id: Ia3e904ab0dbf7252d77e3d81aaae3817b5124978
Signed-off-by: Robert Varga <rovarga@cisco.com>
jenkins-bgpcep [Mon, 27 Jan 2014 22:23:26 +0000 (22:23 +0000)]
[maven-release-plugin] prepare for next development iteration
jenkins-bgpcep [Mon, 27 Jan 2014 22:23:24 +0000 (22:23 +0000)]
[maven-release-plugin] prepare release releasepom-0.3.0
Robert Varga [Mon, 27 Jan 2014 21:23:34 +0000 (22:23 +0100)]
Bump versions to controller release artifacts
Change-Id: I73c8a81273bbed8f06fbe1fb59d0cd1fd52b800d
Signed-off-by: Robert Varga <rovarga@cisco.com>
Robert Varga [Mon, 27 Jan 2014 21:30:27 +0000 (22:30 +0100)]
Fix test referencing controller version
Change-Id: I214df1bbdb9c0ed5e29839a982e9399892b0ab3e
Signed-off-by: Robert Varga <rovarga@cisco.com>
Robert Varga [Mon, 27 Jan 2014 21:18:43 +0000 (22:18 +0100)]
Unify version handling
Change-Id: I904d944a43c47c9ac7eae23418c5ced76d0642ac
Signed-off-by: Robert Varga <rovarga@cisco.com>
Robert Varga [Mon, 27 Jan 2014 16:46:25 +0000 (17:46 +0100)]
Bump to yangtools 0.6.1 and related versions
Change-Id: I9e56727c122e57ab6b0fc8e0273a4c10bad242a5
Signed-off-by: Robert Varga <rovarga@cisco.com>
Robert Varga [Mon, 27 Jan 2014 17:05:39 +0000 (18:05 +0100)]
Remove exificient dependency
Change-Id: I06c881a59e5bba6b52ee91c580a2f982481f6e01
Signed-off-by: Robert Varga <rovarga@cisco.com>
Robert Varga [Mon, 27 Jan 2014 16:44:17 +0000 (17:44 +0100)]
Unify version handling
Change-Id: Ifab11a40932466b1d11be8f327d206a08681b43f
Signed-off-by: Robert Varga <rovarga@cisco.com>
Dana Kutenicsova [Mon, 27 Jan 2014 14:59:30 +0000 (14:59 +0000)]
Merge "Improve logging of object removal"
Dana Kutenicsova [Mon, 27 Jan 2014 14:53:09 +0000 (14:53 +0000)]
Merge "Improve formatting of termination point identifiers"
Robert Varga [Mon, 27 Jan 2014 14:50:33 +0000 (15:50 +0100)]
Improve logging of object removal
Change-Id: Ie58e11e2f1111a07d1755c6a5fbf7e7e19e41bf2
Signed-off-by: Robert Varga <rovarga@cisco.com>
Dana Kutenicsova [Mon, 27 Jan 2014 12:12:00 +0000 (13:12 +0100)]
Added Ipv6 to local bgp proposal and adjusted handling of remote proposal.
Change-Id: I2641bd221e88d0d4aecbac40d52cec11dbc7e298
Signed-off-by: Dana Kutenicsova <dkutenic@cisco.com>
Robert Varga [Mon, 27 Jan 2014 14:13:27 +0000 (15:13 +0100)]
Improve formatting of termination point identifiers
Change-Id: I1ed0a7f9c8454422ea5e808c5721d4835c953516
Signed-off-by: Robert Varga <rovarga@cisco.com>
Dana Kutenicsova [Mon, 27 Jan 2014 13:16:54 +0000 (13:16 +0000)]
Merge changes I305a96fb,Ief4bb355
* changes:
Workaround MD-SAL ordering issues, lose data anyway
Do not rely on route attributes being present
Robert Varga [Mon, 27 Jan 2014 12:35:33 +0000 (13:35 +0100)]
Workaround MD-SAL ordering issues, lose data anyway
Fixes the following exception into a warning:
2014-01-27 10:45:06.598 GMT [md-sal-binding-commit-8] WARN o.o.b.b.t.p.AbstractTopologyBuilder - Data change org.opendaylight.controller.md.sal.common.impl.service.DataChangeEventImpl@
34e9459f was not completely propagated to listener org.opendaylight.bgpcep.bgp.topology.provider.LinkstateTopologyBuilder@
1f6c7110
java.lang.NullPointerException: null
at org.opendaylight.bgpcep.bgp.topology.provider.LinkstateTopologyBuilder.createNode(LinkstateTopologyBuilder.java:600) ~[na:na]
at org.opendaylight.bgpcep.bgp.topology.provider.LinkstateTopologyBuilder.createObject(LinkstateTopologyBuilder.java:682) ~[na:na]
at org.opendaylight.bgpcep.bgp.topology.provider.LinkstateTopologyBuilder.createObject(LinkstateTopologyBuilder.java:109) ~[na:na]
at org.opendaylight.bgpcep.bgp.topology.provider.AbstractTopologyBuilder.onLocRIBChange(AbstractTopologyBuilder.java:135) ~[na:na]
at org.opendaylight.bgpcep.bgp.topology.provider.AbstractTopologyBuilder.onDataChanged(AbstractTopologyBuilder.java:165) ~[na:na]
at org.opendaylight.controller.md.sal.common.impl.service.TwoPhaseCommit.publishDataChangeEvent(TwoPhaseCommit.java:131) [bundlefile:na]
at org.opendaylight.controller.md.sal.common.impl.service.TwoPhaseCommit.call(TwoPhaseCommit.java:97) [bundlefile:na]
at org.opendaylight.controller.md.sal.common.impl.service.TwoPhaseCommit.call(TwoPhaseCommit.java:31) [bundlefile:na]
at java.util.concurrent.FutureTask.run(FutureTask.java:262) [na:1.7.0_45]
at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1145) [na:1.7.0_45]
at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:615) [na:1.7.0_45]
at java.lang.Thread.run(Thread.java:744) [na:1.7.0_45]
Change-Id: I305a96fb4f30699d1fdf64288a3a6720961b0126
Signed-off-by: Robert Varga <rovarga@cisco.com>
Robert Varga [Mon, 27 Jan 2014 12:27:20 +0000 (13:27 +0100)]
Do not rely on route attributes being present
Fixes the following exception:
java.lang.NullPointerException: null
at org.opendaylight.protocol.bgp.rib.impl.RIBImpl.updateTables(RIBImpl.java:126) ~[na:na]
at org.opendaylight.protocol.bgp.rib.impl.BGPPeer.onMessage(BGPPeer.java:46) ~[na:na]
at org.opendaylight.protocol.bgp.rib.impl.BGPPeer.onMessage(BGPPeer.java:32) ~[na:na]
at org.opendaylight.protocol.bgp.rib.impl.BGPSessionImpl.handleMessage(BGPSessionImpl.java:199) ~[na:na]
at org.opendaylight.protocol.bgp.rib.impl.BGPSessionImpl.handleMessage(BGPSessionImpl.java:50) ~[na:na]
at org.opendaylight.protocol.framework.AbstractProtocolSession.channelRead0(AbstractProtocolSession.java:45) ~[na:na]
at io.netty.channel.SimpleChannelInboundHandler.channelRead(SimpleChannelInboundHandler.java:98) ~[bundlefile:na]
at io.netty.channel.DefaultChannelHandlerContext.invokeChannelRead(DefaultChannelHandlerContext.java:337) [bundlefile:na]
at io.netty.channel.DefaultChannelHandlerContext.fireChannelRead(DefaultChannelHandlerContext.java:323) [bundlefile:na]
at io.netty.handler.codec.ByteToMessageDecoder.channelRead(ByteToMessageDecoder.java:173) [bundlefile:na]
at io.netty.channel.DefaultChannelHandlerContext.invokeChannelRead(DefaultChannelHandlerContext.java:337) [bundlefile:na]
at io.netty.channel.DefaultChannelHandlerContext.fireChannelRead(DefaultChannelHandlerContext.java:323) [bundlefile:na]
at io.netty.handler.codec.ByteToMessageDecoder.channelRead(ByteToMessageDecoder.java:173) [bundlefile:na]
at io.netty.channel.DefaultChannelHandlerContext.invokeChannelRead(DefaultChannelHandlerContext.java:337) [bundlefile:na]
at io.netty.channel.DefaultChannelHandlerContext.fireChannelRead(DefaultChannelHandlerContext.java:323) [bundlefile:na]
at io.netty.channel.DefaultChannelPipeline.fireChannelRead(DefaultChannelPipeline.java:785) [bundlefile:na]
at io.netty.channel.nio.AbstractNioByteChannel$NioByteUnsafe.read(AbstractNioByteChannel.java:100) [bundlefile:na]
at io.netty.channel.nio.NioEventLoop.processSelectedKey(NioEventLoop.java:480) [bundlefile:na]
at io.netty.channel.nio.NioEventLoop.processSelectedKeysOptimized(NioEventLoop.java:447) [bundlefile:na]
at io.netty.channel.nio.NioEventLoop.run(NioEventLoop.java:341) [bundlefile:na]
at io.netty.util.concurrent.SingleThreadEventExecutor$2.run(SingleThreadEventExecutor.java:101) [bundlefile:na]
at java.lang.Thread.run(Thread.java:744) [na:1.7.0_45]
Change-Id: Ief4bb355f3f3e4566235b2339d0593ab7307ea58
Signed-off-by: Robert Varga <rovarga@cisco.com>
Robert Varga [Mon, 27 Jan 2014 09:54:45 +0000 (10:54 +0100)]
Make listen-address support IPv6
Change-Id: I082c9def23720f4beb1c808d9718faadc2036d40
Signed-off-by: Robert Varga <rovarga@cisco.com>
Robert Varga [Mon, 27 Jan 2014 11:37:15 +0000 (12:37 +0100)]
Format whitespace before making changes
Change-Id: I5919cee9b2a0240947da2d92f6797cfb70632eaa
Signed-off-by: Robert Varga <rovarga@cisco.com>
Robert Varga [Sun, 26 Jan 2014 22:29:20 +0000 (23:29 +0100)]
Add dependency on yang-ext
Prepares for https://git.opendaylight.org/gerrit/#/c/4602/ being merged
into yangtools.
Change-Id: I350d146fcd629bd5199dbe6c6c8b487bda9ede31
Signed-off-by: Robert Varga <rovarga@cisco.com>
Robert Varga [Sun, 26 Jan 2014 21:56:31 +0000 (22:56 +0100)]
Change types of CLUSTER_ID and ORIGINATOR
Change-Id: I78b613543a3715ad067b68bdae7d26a6ff665bce
Signed-off-by: Robert Varga <rovarga@cisco.com>
Robert Varga [Sun, 26 Jan 2014 20:23:57 +0000 (21:23 +0100)]
Add exception to help debugging
Change-Id: Iadde072592ad6e705f313619adeae26fbc48a74f
Signed-off-by: Robert Varga <rovarga@cisco.com>
Robert Varga [Sun, 26 Jan 2014 12:21:52 +0000 (12:21 +0000)]
Merge "Updated topology provider for stateful02."
Dana Kutenicsova [Sat, 25 Jan 2014 18:54:25 +0000 (19:54 +0100)]
Default pcep stateful version switched to 07.
Change-Id: I6b74c731139bc21b54f067f41a5efb9fe2755ecd
Signed-off-by: Dana Kutenicsova <dkutenic@cisco.com>
Dana Kutenicsova [Fri, 24 Jan 2014 18:17:18 +0000 (19:17 +0100)]
Updated topology provider for stateful02.
Change-Id: Ia77cf420a272cbcf64c925c899102a818cbc6485
Signed-off-by: Dana Kutenicsova <dkutenic@cisco.com>
Robert Varga [Sat, 25 Jan 2014 09:52:01 +0000 (10:52 +0100)]
Fixup package move
Change-Id: I6635b33fe2c282d144d94c96e4491a2e7436d611
Signed-off-by: Robert Varga <rovarga@cisco.com>
Dana Kutenicsova [Sat, 25 Jan 2014 12:26:27 +0000 (12:26 +0000)]
Merge "Make tunnel-topology independent of stateful draft"
Gerrit Code Review [Sat, 25 Jan 2014 12:23:43 +0000 (12:23 +0000)]
Merge changes
Dana Kutenicsova [Sat, 25 Jan 2014 12:23:43 +0000 (12:23 +0000)]
Merge changes Ieaa9ede2,I18c02205
* changes:
Make container fail when bundles are unresolved
Fix test dependencies to reflect BGP refactor
Dana Kutenicsova [Sat, 25 Jan 2014 12:18:54 +0000 (12:18 +0000)]
Merge "Remove unnecessary workaround"
Robert Varga [Sat, 25 Jan 2014 11:21:24 +0000 (12:21 +0100)]
Fix stateful-02 activator
It had class/type mixed up, triggering assertions. Also add a more
descriptive message.
Change-Id: I6904c14b09a5ac2d0141cd03c8a51bb277f7643b
Signed-off-by: Robert Varga <rovarga@cisco.com>
Robert Varga [Fri, 24 Jan 2014 15:26:28 +0000 (16:26 +0100)]
Make tunnel-topology independent of stateful draft
Change-Id: I52c484c288847fd7520563305644c49c6b200989
Signed-off-by: Robert Varga <rovarga@cisco.com>
Robert Varga [Sat, 25 Jan 2014 07:47:23 +0000 (08:47 +0100)]
Fix test dependencies to reflect BGP refactor
Change-Id: I18c02205714ce5e8fbffc20b9200ff5c968db5e1
Signed-off-by: Robert Varga <rovarga@cisco.com>
Robert Varga [Sat, 25 Jan 2014 07:51:39 +0000 (08:51 +0100)]
Make container fail when bundles are unresolved
Change-Id: Ieaa9ede215b744acd06e0e3cd97a79e654c86040
Signed-off-by: Robert Varga <rovarga@cisco.com>
Robert Varga [Fri, 24 Jan 2014 16:47:08 +0000 (17:47 +0100)]
Remove unnecessary workaround
Change-Id: Ie4c8dd8b89a1f3f400ef8b1608a2fe0dd84661f1
Signed-off-by: Robert Varga <rovarga@cisco.com>
Dana Kutenicsova [Fri, 24 Jan 2014 16:23:58 +0000 (16:23 +0000)]
Merge "Make base pcep-topology-api independent of stateful"
Robert Varga [Thu, 23 Jan 2014 12:18:43 +0000 (13:18 +0100)]
Make base pcep-topology-api independent of stateful
Change-Id: I0da583e0c51932baf5559828aa5e9fbcb2fe2296
Signed-off-by: Robert Varga <rovarga@cisco.com>
Dana Kutenicsova [Fri, 24 Jan 2014 15:22:59 +0000 (15:22 +0000)]
Merge changes I3da28a45,I16df427f
* changes:
Update repositories and distributionmanagement
Remove unneeded repositories declaration
Robert Varga [Fri, 24 Jan 2014 14:39:28 +0000 (15:39 +0100)]
Update repositories and distributionmanagement
Change-Id: I3da28a4552d8f06cdb480038cdec75a7d547948a
Signed-off-by: Robert Varga <rovarga@cisco.com>
Dana Kutenicsova [Fri, 24 Jan 2014 10:35:25 +0000 (11:35 +0100)]
Final cleanup.
Change-Id: I40c0ae3b197924134eba5f78659867d0e7470f75
Signed-off-by: Dana Kutenicsova <dkutenic@cisco.com>
Dana Kutenicsova [Fri, 24 Jan 2014 10:22:17 +0000 (11:22 +0100)]
Removed unused site files.
Change-Id: I5dec4f1bfcf1e5b6f13a3e00dcb89bb264326747
Signed-off-by: Dana Kutenicsova <dkutenic@cisco.com>
Dana Kutenicsova [Fri, 24 Jan 2014 08:55:12 +0000 (09:55 +0100)]
Added more copyright headers.
Change-Id: I57847eb1712dea936bcf79e035fe3ba5fe0b979b
Signed-off-by: Dana Kutenicsova <dkutenic@cisco.com>
Dana Kutenicsova [Fri, 24 Jan 2014 08:20:56 +0000 (09:20 +0100)]
Added copyright headers to yang files.
Change-Id: I8fb3becf0b9be218b7486d09d2667d5e924918ed
Signed-off-by: Dana Kutenicsova <dkutenic@cisco.com>
Robert Varga [Fri, 24 Jan 2014 07:53:49 +0000 (08:53 +0100)]
Remove unneeded repositories declaration
Change-Id: I16df427f561ee37c0fcc7bacd9015a716afed694
Signed-off-by: Robert Varga <rovarga@cisco.com>
Dana Kutenicsova [Fri, 24 Jan 2014 07:48:05 +0000 (07:48 +0000)]
Merge "Remove duplicate dependency"
Robert Varga [Fri, 24 Jan 2014 07:40:40 +0000 (07:40 +0000)]
Merge "Cleaned up .project files."
Robert Varga [Fri, 24 Jan 2014 07:23:40 +0000 (07:23 +0000)]
Merge "Do not hard-code the artifact version"
Robert Varga [Thu, 23 Jan 2014 21:14:16 +0000 (22:14 +0100)]
Remove duplicate dependency
Change-Id: I36efb693113d0278751363849a4cc8d0bbe20b8b
Signed-off-by: Robert Varga <rovarga@cisco.com>
Robert Varga [Thu, 23 Jan 2014 21:21:49 +0000 (22:21 +0100)]
Do not hard-code the artifact version
Change-Id: Iff3363dfb35060fafc2243b72b4346120d78d760
Signed-off-by: Robert Varga <rovarga@cisco.com>
Dana Kutenicsova [Fri, 24 Jan 2014 04:49:36 +0000 (05:49 +0100)]
Cleaned up .project files.
Change-Id: Idf6ffb6d6060a2e1c613f216bea7fd7700c6c88d
Signed-off-by: Dana Kutenicsova <dkutenic@cisco.com>
Dana Kutenicsova [Fri, 24 Jan 2014 04:38:54 +0000 (05:38 +0100)]
Cleaned up .gitignore files.
Change-Id: I1c842634dc4a4d5099bd8975eb1925802ffa55f9
Signed-off-by: Dana Kutenicsova <dkutenic@cisco.com>
Dana Kutenicsova [Fri, 24 Jan 2014 04:13:09 +0000 (05:13 +0100)]
Added copyright header to pom files.
Change-Id: I50c159f5636e9fd2ca4eb29dbeccfe276bd3cee3
Signed-off-by: Dana Kutenicsova <dkutenic@cisco.com>
Dana Kutenicsova [Thu, 23 Jan 2014 15:45:19 +0000 (16:45 +0100)]
Added meta-inf to stateful02.
Change-Id: I32894efdc61650619555c9dcec67dc9b9c18dded
Signed-off-by: Dana Kutenicsova <dkutenic@cisco.com>
Robert Varga [Thu, 23 Jan 2014 17:33:37 +0000 (18:33 +0100)]
Eradicate mockito-configuration references
Change-Id: I5a36564f8ffaa2380c734329e728edbcd768e053
Signed-off-by: Robert Varga <rovarga@cisco.com>
Robert Varga [Thu, 23 Jan 2014 10:58:00 +0000 (11:58 +0100)]
Remove unused import
Change-Id: I39f60b1e5db79c08ee361da69327616135aae3d6
Signed-off-by: Robert Varga <rovarga@cisco.com>
Robert Varga [Thu, 23 Jan 2014 04:24:05 +0000 (05:24 +0100)]
Make TopologySessionListener implement AutoCloseable
Change-Id: Idb872ebb103d237fe311a78364aab0e6dd91e9e2
Signed-off-by: Robert Varga <rovarga@cisco.com>
Robert Varga [Thu, 23 Jan 2014 04:05:24 +0000 (05:05 +0100)]
Create model-agnostic AbstractTopologySessionListener
This finishes the refactor for support of multiple stateful models: we
now have an Abstract class which each of the model-specific listeners
need to implement.
Change-Id: I074e8c2a593a5e34a652364daa3e4aa21390e516
Signed-off-by: Robert Varga <rovarga@cisco.com>
Robert Varga [Thu, 23 Jan 2014 02:59:39 +0000 (03:59 +0100)]
Extract TopologySessionListener as an interface
This removes coupling between ServerSessionManager and the interface
that per-model listeners need to implement.
Change-Id: Ibdf6d91b571943edf205e8486d06dba50dbd7c10
Signed-off-by: Robert Varga <rovarga@cisco.com>
Robert Varga [Thu, 23 Jan 2014 02:28:21 +0000 (03:28 +0100)]
Break ServerSessionManager into multiple components
In order to support multiple stateful models, ServerSessionManager has
to be split into common and model-specific parts. This commit separates
the topology-wide logic from per-peer logic.
Change-Id: Ia489570270c3aece2ea260c61d222d70bc140d4b
Signed-off-by: Robert Varga <rovarga@cisco.com>
Robert Varga [Wed, 22 Jan 2014 19:07:48 +0000 (20:07 +0100)]
Dynamically manage nodes implied by links
Change-Id: Ibc0d3603124fb48319613471282ea37739c54d75
Signed-off-by: Robert Varga <rovarga@cisco.com>
Tony Tkacik [Thu, 23 Jan 2014 14:04:34 +0000 (15:04 +0100)]
Fixed incorrect mocking of bundle context.
Mock of bundle context did not adhere to contract
ServiceReference<T> getServiceReference(T)
T getService(ServiceReference<T>)
which caused class cast exception.
Change-Id: I2500d6f30aa01b68f002e87c19ba6a4d17cb393c
Signed-off-by: Tony Tkacik <ttkacik@cisco.com>
Robert Varga [Thu, 23 Jan 2014 07:33:31 +0000 (07:33 +0000)]
Merge "Created stateful and initiated 02 configuration files and make them default."
Robert Varga [Wed, 22 Jan 2014 15:41:54 +0000 (16:41 +0100)]
Add a trace when we update MD-SAL
Improves logging just a tiny bit so that we know wat are we doing
Change-Id: I7b542b973c544fe12c7fb5bc11744b6430e43374
Signed-off-by: Robert Varga <rovarga@cisco.com>
Dana Kutenicsova [Wed, 22 Jan 2014 15:11:39 +0000 (16:11 +0100)]
Created stateful and initiated 02 configuration files and make them default.
Change-Id: I12923a279e5601599c7ccf90a0368b2b9e26d26b
Signed-off-by: Dana Kutenicsova <dkutenic@cisco.com>
Dana Kutenicsova [Wed, 22 Jan 2014 14:10:19 +0000 (14:10 +0000)]
Merge "Make sure we record a reused node"
Robert Varga [Wed, 22 Jan 2014 14:09:27 +0000 (14:09 +0000)]
Merge "Renamed pcep parser stateful & initiated extensions."
Dana Kutenicsova [Wed, 22 Jan 2014 13:34:19 +0000 (14:34 +0100)]
Renamed pcep parser stateful & initiated extensions.
Change-Id: I83f4ac3054e13905a1831295baae8cd8b2094175
Signed-off-by: Dana Kutenicsova <dkutenic@cisco.com>
Robert Varga [Wed, 22 Jan 2014 13:27:28 +0000 (14:27 +0100)]
Make sure we record a reused node
This fixes a bug where we fail to record the base node identifier when
we reuse an already-existing node in MD-SAL.
Change-Id: I33f407810da6ab452a0c12933d3572bfa14a1f53
Signed-off-by: Robert Varga <rovarga@cisco.com>
Robert Varga [Wed, 22 Jan 2014 13:08:19 +0000 (14:08 +0100)]
Finish committing transactions when state resync is done
It turns out we forgot to commit the modification transaction when the
initial resync is done. Also add a few debugs so we know what we push
where.
Change-Id: Ia253bd4a421d88ea4f3ed70a73ba238a931e7a4b
Signed-off-by: Robert Varga <rovarga@cisco.com>
Robert Varga [Wed, 22 Jan 2014 11:09:10 +0000 (12:09 +0100)]
Bump version model for yangtools release
Change-Id: I8cea9472c8dc6fba90168fa7e09870fe937614a2
Signed-off-by: Robert Varga <rovarga@cisco.com>
Robert Varga [Wed, 22 Jan 2014 10:48:32 +0000 (11:48 +0100)]
Fix formatting of ISO system IDs
Change-Id: I4751384774680484c167f8b19a8f513998613c45
Signed-off-by: Robert Varga <rovarga@cisco.com>
Robert Varga [Tue, 21 Jan 2014 21:09:29 +0000 (22:09 +0100)]
Make sure we fail on any unresolved bundles
Change-Id: Icf454acf2fd02b0ab5e8866bb114851d89183870
Signed-off-by: Robert Varga <rovarga@cisco.com>
Dana Kutenicsova [Wed, 22 Jan 2014 08:44:12 +0000 (08:44 +0000)]
Merge "Fix removal of linkstate routes"
Dana Kutenicsova [Wed, 22 Jan 2014 08:42:22 +0000 (08:42 +0000)]
Merge "Change the type of some leafs to uint32"
Robert Varga [Tue, 21 Jan 2014 22:35:03 +0000 (23:35 +0100)]
Fix removal of linkstate routes
Fixes the following exception seen when processing MP_UNREACH:
java.lang.ClassCastException: org.opendaylight.yang.gen.v1.urn.opendaylight.params.xml.ns.yang.bgp.linkstate.rev131125.update.path.attributes.mp.unreach.nlri.withdrawn.routes.destination.type.DestinationLinkstateCaseBuilder$DestinationLinkstateCaseImpl cannot be cast to org.opendaylight.yang.gen.v1.urn.opendaylight.params.xml.ns.yang.bgp.linkstate.rev131125.LinkstateDestination
at org.opendaylight.protocol.bgp.linkstate.LinkstateAdjRIBsIn.removeRoutes(LinkstateAdjRIBsIn.java:214) ~[na:na]
at org.opendaylight.protocol.bgp.rib.impl.RIBImpl.updateTables(RIBImpl.java:132) ~[na:na]
at org.opendaylight.protocol.bgp.rib.impl.BGPPeer.onMessage(BGPPeer.java:46) ~[na:na]
at org.opendaylight.protocol.bgp.rib.impl.BGPPeer.onMessage(BGPPeer.java:32) ~[na:na]
at org.opendaylight.protocol.bgp.rib.impl.BGPSessionImpl.handleMessage(BGPSessionImpl.java:199) ~[na:na]
at org.opendaylight.protocol.bgp.rib.impl.BGPSessionImpl.handleMessage(BGPSessionImpl.java:50) ~[na:na]
at org.opendaylight.protocol.framework.AbstractProtocolSession.channelRead0(AbstractProtocolSession.java:45) ~[na:na]
at io.netty.channel.SimpleChannelInboundHandler.channelRead(SimpleChannelInboundHandler.java:98) ~[bundlefile:na]
at io.netty.channel.DefaultChannelHandlerContext.invokeChannelRead(DefaultChannelHandlerContext.java:337) [bundlefile:na]
at io.netty.channel.DefaultChannelHandlerContext.fireChannelRead(DefaultChannelHandlerContext.java:323) [bundlefile:na]
at io.netty.handler.codec.ByteToMessageDecoder.channelRead(ByteToMessageDecoder.java:173) ~[na:na]
at io.netty.channel.DefaultChannelHandlerContext.invokeChannelRead(DefaultChannelHandlerContext.java:337) [bundlefile:na]
at io.netty.channel.DefaultChannelHandlerContext.fireChannelRead(DefaultChannelHandlerContext.java:323) [bundlefile:na]
at io.netty.handler.codec.ByteToMessageDecoder.channelRead(ByteToMessageDecoder.java:173) ~[na:na]
at io.netty.channel.DefaultChannelHandlerContext.invokeChannelRead(DefaultChannelHandlerContext.java:337) [bundlefile:na]
at io.netty.channel.DefaultChannelHandlerContext.fireChannelRead(DefaultChannelHandlerContext.java:323) [bundlefile:na]
at io.netty.channel.DefaultChannelPipeline.fireChannelRead(DefaultChannelPipeline.java:785) ~[bundlefile:na]
at io.netty.channel.nio.AbstractNioByteChannel$NioByteUnsafe.read(AbstractNioByteChannel.java:100) ~[bundlefile:na]
at io.netty.channel.nio.NioEventLoop.processSelectedKey(NioEventLoop.java:480) ~[bundlefile:na]
at io.netty.channel.nio.NioEventLoop.processSelectedKeysOptimized(NioEventLoop.java:447) ~[bundlefile:na]
at io.netty.channel.nio.NioEventLoop.run(NioEventLoop.java:341) ~[bundlefile:na]
at io.netty.util.concurrent.SingleThreadEventExecutor$2.run(SingleThreadEventExecutor.java:101) ~[bundlefile:na]
at java.lang.Thread.run(Thread.java:724) ~[na:1.7.0_25]
Change-Id: I95d9b586ddeacbd7bc39500525e8877def604a4c
Signed-off-by: Robert Varga <rovarga@cisco.com>
Dana Kutenicsova [Tue, 21 Jan 2014 19:30:42 +0000 (20:30 +0100)]
Moved stateful07 parser to their own project.
Change-Id: I6bc8ec2bb36f8041ee95d5ff38a8640bdccc4e2d
Signed-off-by: Dana Kutenicsova <dkutenic@cisco.com>
Robert Varga [Tue, 21 Jan 2014 19:20:28 +0000 (20:20 +0100)]
Change the type of some leafs to uint32
These were four-byte entities, which are specified to be "32-bit
integers" in their specification.
Change-Id: Ibfaa7317e8034645311a6f0dddd53d6809f11f15
Signed-off-by: Robert Varga <rovarga@cisco.com>
Dana Kutenicsova [Tue, 21 Jan 2014 20:42:30 +0000 (20:42 +0000)]
Merge "Failure to send message should result in negotiation failure"
Robert Varga [Tue, 21 Jan 2014 20:23:00 +0000 (21:23 +0100)]
Failure to send message should result in negotiation failure
This is evidenced by the session getting stuck after the peer closes the
connection but we try to send the open message. The state would be
recovered by the hold timer, but there's no reason why we should wait
for that.
Change-Id: I7abb4e86ced7e36ed720614243ad1938d69fab3a
Signed-off-by: Robert Varga <rovarga@cisco.com>
Dana Kutenicsova [Tue, 21 Jan 2014 16:43:02 +0000 (16:43 +0000)]
Merge "Update Linkstate attribute parser"
Robert Varga [Tue, 21 Jan 2014 12:59:59 +0000 (13:59 +0100)]
Update Linkstate attribute parser
This updates the parser to check which NLRI type is being handled and
set attributes accordingly.
Do not trigger deserialization errors when an unexpected TLV is seen in
the attribute, just emit a warning.
Change-Id: I5be1bae5448ae299082023b4fd8f424645236c63
Signed-off-by: Robert Varga <rovarga@cisco.com>
Dana Kutenicsova [Tue, 21 Jan 2014 13:10:50 +0000 (13:10 +0000)]
Merge "Make sure attributes are parsed in order of their increasing type"
Code Review / bgpcep.git / log