Bug 1411 #5 BindingGeneratorImpl decomposition - Notifications

- resolve YANG notifications & notification tied to
data schema nodes from schema context
- further util methods added
- further decomposition in order to
decrease initial BindingGeneratorImpl complexity

TODO: JUnit tests, models

Change-Id: Ie9e16d0ee23a7e1c1f2aab7871967261a013bb6f
Signed-off-by: Martin Ciglan <[email protected]>

Bug 1411 #4 BindingGeneratorImpl decomposition - Lists

- resolve Lists from schema context
- further util methods added
- further decomposition in order to
decrease initial BindingGeneratorImpl complexity
- fixes Bug 157 too

Change-Id: Ie9b492c96276819b6e814bff5deff91e7afc1e54
Signed-off-by: Martin Ciglan <[email protected]>
Signed-off-by: Jakub Toth <[email protected]>

Bug 1411 #3 BindingGeneratorImpl decomposition - Leafs

- resolve Leafs from schema context
- preprare getters
- further util methods added
- further decomposition in order to
decrease initial BindingGeneratorImpl complexity

Change-Id: If352546fb4f0fb375705959a54242e657c285e75
Signed-off-by: Martin Ciglan <[email protected]>

Fix ForeignShardModificationContext's submit method

ForeingShardModificationContext can be reused by several transactions.
Unready it in its submit method.

Change-Id: I84a3e74176335e87c940109d6a43c9e5131a9f0c
Signed-off-by: Jakub Morvay <[email protected]>

Bug 7759 - TEST - Getter of BA object fails to construct class instance

 * negative test - if value of data is other like type of data define by yang

Change-Id: Ia6a9abd43e78384f84c867cf6a755cd07d6503c6
Signed-off-by: Jakub Toth <[email protected]>

Bug 1411 #2 BindingGeneratorImpl decomposition - Types

- resolve Types
from schema context to in-memory generated types
- further util methods added
- further decomposition in order to
decrease TypeProviderImpl Sonar complexity

TODO: jtoth - JUnit tests

Change-Id: I929a1efc66feb7dcf112eb81de542f2187d16f71
Signed-off-by: Martin Ciglan <[email protected]>

BindingGenerator v1 "copy-paste" bug in RPCs

This patch fixes kind of "copy-paste" bug revealed during
dealing with Actions in Binding Spec v2. This needs
to be cherry-picked to Boron too.

Change-Id: I22d56fd7ca899e4634ad0c2aaaec63d5b7c11403
Signed-off-by: Martin Ciglan <[email protected]>

Bug 6859: Binding generator v1 refactoring

- make sure package names differ between MDSAL Binding v1 submodules
after refactoring

Change-Id: I6f1def44682f28a00a79ac3c787eeaca5b6755d6
Signed-off-by: Martin Ciglan <[email protected]>

Bug 7759 - TEST - Getter of BA object fails to construct class instance

Change-Id: Idfb3ceabe6808bcd9c421d189566f680f8f0077f
Signed-off-by: Jakub Toth <[email protected]>
(cherry picked from commit db2d6f91b55a28d5da6e6b362295b1d412d8d363)

Add new DOMDataTreeCommitCohort#canCoomit method

If a cohort registers for yang list entries, there may be multiple
list entry modifications in a transaction thus the canCommit method
needs to take a Collection of DOMDataTreeCandidates for consistency.

For avoid breaking current implementations, I added the new method
with a default implementation that invokes the single DOMDataTreeCandidate
canCommit method with a warning that the new canCommit method should
be implemented. The single canCommit method is now deprecated with a
default implementation that logs an error and returns success.

Change-Id: If83d380a0ca8ba55be9e99b3d1da4d309e9a6487
Signed-off-by: Tom Pantelis <[email protected]>

ForeignShardModificationContext: typo

typo in ForeignShardModificationContext.
notReady should be false when readying it.

Change-Id: I6ecd3283f1917f9725579496142f3572549d9874
Signed-off-by: Isaku Yamahata <[email protected]>

Bug 1411 Binding Generator - BaseYangTypes

- provides mapping for YANG built-in types
- prevents Bug 2323 happening

Change-Id: Ic65a4f30d6219f51c8d13eb26c3ff4b14255302e
Signed-off-by: Martin Ciglan <[email protected]>

Bug 6856: Rpc definition should implicitly define input/output

- corresponding patch for MDSAL
- code clean-up in affected class

Change-Id: I715585331496d181031f5a82ce801a1b7271c56d
Signed-off-by: Martin Ciglan <[email protected]>

BUG-6859 - Binding generator v1 refactoring

Change-Id: I03caf0ec587ea9f6db0bdd87ccebc5df9a28edc6
Signed-off-by: Michael Vorburger <[email protected]>

Bug 6859 #5 Binding generator v1 refactoring

Based on transfer of Binding generator v1 from
Yangtools project to MDSAL in past, we need to finalize
this process by refactoring package naming:

org.opendaylight.yangtools       -> org.mdsal.binding
org.opendaylight.yangtools.sal -> org.mdsal.binding

This refactoring is done in subsequent steps,
covering all necessary modules. Based on experience,
this should also help users to address possible Binding generator v1
issues in MDSAL project, not in Yangtools.

- maven-sal-api-gen-plugin module refactoring

Change-Id: I17bd25507894b8b5a42579ee317f5d5fd81f3f20
Signed-off-by: Jakub Toth <[email protected]>

Bug 6859 #4 Binding generator v1 refactoring

Based on transfer of Binding generator v1 from
Yangtools project to MDSAL in past, we need to finalize
this process by refactoring package naming:

org.opendaylight.yangtools       -> org.mdsal.binding
org.opendaylight.yangtools.sal -> org.mdsal.binding

This refactoring is done in subsequent steps,
covering all necessary modules. Based on experience,
this should also help users to address possible Binding generator v1
issues in MDSAL project, not in Yangtools.

- mdsal-binding-java-api-generator module refactoring

Change-Id: Ie898adf78ac9db7f094a26f8f41145c8c960fa62
Signed-off-by: Jakub Toth <[email protected]>

Bug 6859 #3 Binding generator v1 refactoring

Based on transfer of Binding generator v1 from
Yangtools project to MDSAL in past, we need to finalize
this process by refactoring package naming:

org.opendaylight.yangtools       -> org.mdsal.binding
org.opendaylight.yangtools.sal -> org.mdsal.binding

This refactoring is done in subsequent steps,
covering all necessary modules. Based on experience,
this should also help users to address possible Binding generator v1
issues in MDSAL project, not in Yangtools.

- mdsal-binding-generator-impl module refactoring

Change-Id: If3a7615d3c2870d02eae8767ca44bcb0981aaa99
Signed-off-by: Jakub Toth <[email protected]>

Bug 6859 #2 Binding generator v1 refactoring

Based on transfer of Binding generator v1 from
Yangtools project to MDSAL in past, we need to finalize
this process by refactoring package naming:

org.opendaylight.yangtools       -> org.mdsal.binding
org.opendaylight.yangtools.sal -> org.mdsal.binding

This refactoring is done in subsequent steps,
covering all necessary modules. Based on experience,
this should also help users to address possible Binding generator v1
issues in MDSAL project, not in Yangtools.

- mdsal-binding-generator-util module refactoring

Change-Id: I978e49a68458d08a9d397a1a2d4bcc455eea1a37
Signed-off-by: Jakub Toth <[email protected]>

Bug 6859 #1 Binding generator v1 refactoring

Based on transfer of Binding generator v1 from
Yangtools project to MDSAL in past, we need to finalize
this process by refactoring package naming:

org.opendaylight.yangtools       -> org.mdsal.binding
org.opendaylight.yangtools.sal -> org.mdsal.binding

This refactoring is done in subsequent steps,
covering all necessary modules. Based on experience,
this should also help users to address possible Binding generator v1
issues in MDSAL project, not in Yangtools.

- mdsal-binding-generator-api module refactoring

Change-Id: I11537d580c8df500b80104d158de6eef515afb1e
Signed-off-by: Jakub Toth <[email protected]>

BindingGeneratorImpl Javadoc & code clean-up

- redundancies in Java code fixed
- Javadoc wrong references & missing values fixed
- less imports

Change-Id: If6ec121e74f3d936cd55d4e2cc82a33f745da8f6
Signed-off-by: Martin Ciglan <[email protected]>

Normalizing package names according to
https://docs.oracle.com/javase/tutorial/java/package/namingpkgs.html

Added parsing of special case with dash in identifier with tests
and documetationf for.

Added parsing of reserved keywords for identifiers with tests and
documentation for.

Change-Id: I7d499b3e96270a8e06e720ef7b63e08fd0362094
Signed-off-by: Jakub Toth <[email protected]>

Bug 7182 related: Remove M2E lifecycle mapping

These should never be in individual projects anymore now,
we handle this centrally, either in odlparent,
or https://github.com/vorburger/opendaylight-eclipse-setup,
or by appropriate lifecycle-mapping-metadata.xml in a Maven plugin
(that's what Bug 7182 does for the yang-maven-plugin).

Change-Id: I3649f9a10066dfacd4762b3270bbb2e112e5858f
Signed-off-by: Michael Vorburger <[email protected]>

Do not pull in yang-parser-impl

Parser is used only in tests and only via test-utils,
hence this project should not be pulling it in.

Change-Id: I336eda6effff373deea0f82f81643ac73e655e83
Signed-off-by: Robert Varga <[email protected]>

Bug 6856: Rpc definition should implicitly define input/ouput

- corresponding fix for MD-SAL
- rely on yang model API only

Change-Id: I7380b7d8366c4c18925da09a95a14f5309a8e9ef
Signed-off-by: Martin Ciglan <[email protected]>

Bump Twirl-maven-plugin version & clean-up

Change-Id: I342a36f07b39520ad99d5e9391f498e00693085c
Signed-off-by: Martin Ciglan <[email protected]>

BUG-6315: use plugin-provided path resolution

Rather than relying on SourceStreamAware, make sure we use
the resolver provided by the plugin.

Change-Id: Ia5ec8a739e10bb262f68b2838958d5111e538263
Signed-off-by: Robert Varga <[email protected]>

Bug 1411: BindingGeneratorImpl decomposition - getter name

- make sure generated getter for data schema nodes
will be compilable Java code

Change-Id: Ie09b90b452d1af3a91bf120df4cff2798ba0b76b
Signed-off-by: Martin Ciglan <[email protected]>

Fix null comparison warnings

Xtend comparisons to null should be done via !==/===, fix offenders.

Change-Id: I4dff8e444104cca427843aa88a5df989b3fed77c
Signed-off-by: Robert Varga <[email protected]>

Bug 1411: BindingGeneratorImpl decomposition - Container schema nodes

- fixes some issues with generated context
- starts using NonJavaCharsConverter utility
- code clean-up

Change-Id: I578205f7d451ed8a1b530643c8fa592f58eb5add
Signed-off-by: Martin Ciglan <[email protected]>

Bug 1411 #1 BindingGeneratorImpl decomposition - Container schema nodes

- resolve container schema nodes
from schema context to in-memory generated types
- able to deal with nested containers
- further decomposition done
- further util methods added
- review comments implemented

TODO: JUnit tests - Jakub Toth

Change-Id: Idd7b0140b03c1130c29488a377023cbdacb3ea50
Signed-off-by: Martin Ciglan <[email protected]>

Add Binding Specification v2 Documentation

This patch adds description to Binding Specification v2 documentation
how identifiers derived from YANGs are being treated, eventually resolving
to compilable generated code. These issues with compilation
using Binding specification v1 have been originally tracked in following
bugs:

Bug: 2332
Bug: 2641
Bug: 2791
Change-Id: Ib68de210cd72a6823edfc0f75577c1f9ff0f0b78
Signed-off-by: Martin Ciglan <[email protected]>

Bug 2332 - Binding Java API Generator -> doesn't handle
non-alphabetic signs in names of enum constants, allowed by
rfc6020 though

 - find and convert non Java chars in identifiers of generated transfer
   objects, initially derived from corresponding YANG
 - this patch also fixes
   https://bugs.opendaylight.org/show_bug.cgi?id=2641

Change-Id: Ide01a2b574970397ddedaf7da09e0d28219d0616
Signed-off-by: Jakub Toth <[email protected]>

BUG-7222: Improve ClusterSingletonService error handling.

The applications that are managed by singleton service
may throw an unchecked exception while handling the calls from
the service. We also need to handle these so that they don't prevent
other services from being started/stopped.

Change-Id: I711b8c1e8b2fcb8e9a9699ba96fa3b0c2daff594
Signed-off-by: Tomas Cere <[email protected]>

Fix generate of comma before augmentations in toString generator

Change-Id: Ibb4c19028b758c27126cc244a8657efbd46bc1b2
Signed-off-by: Jakub Toth <[email protected]>

Remove javadoc version declaration

javadoc plugin is declared in odlparent, no need to redeclare its
version.

Change-Id: Iafa07a67d49408bb4ea52a4319f9564119d1a7be
Signed-off-by: Robert Varga <[email protected]>

Bug 3147 - Binding spec v1: auto generated code by YANGTOOLS could
be more efficient

  *fix generating of commas in toString() for more effecient
  *tests

Change-Id: I13b59c3c5be90446a9511a9cd46969850cb77595
Signed-off-by: Jakub Toth <[email protected]>

Checkstyle: fix ParenPad violations

Enforcing no space(s) after a left parenthesis and before a right
parenthesis is a proposed change [0] which can only be merged when all
violations are fixed in projects enforcing checkstyle. This patch fixes
those violations.

[0] https://git.opendaylight.org/gerrit/#/c/51316/

Change-Id: Iae1f085f903579a264b24176d0b4c17416f6b8a0
Signed-off-by: Lorand Jakab <[email protected]>

Revert "Bug 3147 - Binding spec v1: auto generated code by YANGTOOLS could"

This reverts commit b88102998caf1d7ed9b9e720cc9fe4bbdc7e11bb.

Change-Id: If322b38d32e759522800af099b42d649e1237cb7
Signed-off-by: Robert Varga <[email protected]>

Fix getValue() of bits in union

Call Arrays.toString instead of calling toString directly for bits in union,
since getValue() of bits returns boolean[].

Change-Id: I4b06c95f07ff6d5ff81dc17613ed972b453db184
Signed-off-by: Xiao Liang <[email protected]>

Bug 3147 - Binding spec v1: auto generated code by YANGTOOLS could
           be more efficient

  *fix generating of commas in toString() for more effecient
  *tests

Change-Id: I5a1ac0ad8068655168824d89a9acb1f203a64639
Signed-off-by: Jakub Toth <[email protected]>

Don't use deprecated SourceIdentifier.create() method anymore

- replace call with right method
- bit of a code cleanup

Change-Id: Ie9dacf66cbb6494b25e1747952463326152c423a
Signed-off-by: Martin Ciglan <[email protected]>

BUG-7446: inline xbase-lib

xbase-lib requires Guava [14.0,19), leaving us with two options:
- ship two guava versions
- eliminate YangTemplate.xtend
- inline xtext-lib binding it to Guava 21

Take the last approach, choosing not to bloat the distribution.

Change-Id: Ibd2a91ed9bf52c1d3a942282ee53b951f5d42e6b
Signed-off-by: Robert Varga <[email protected]>

Bug 7566 - 1 - Map model module for binding2

  * create module model-binding2 in mdsal

Change-Id: Ic46819d9468d3c7a74856ea868ffcc2b4061d0cc
Signed-off-by: Jakub Toth <[email protected]>

Bump vorburger.xtendbeans from 1.2.1 to 1.2.2 for mockito-core

see https://github.com/vorburger/xtendbeans/blob/master/CHANGES.md

must always use mockito-core instead of mockito-all
to prevent NoSuchMethodError: org.hamcrest.Matcher ...

Bug 7662 related
Change-Id: Ib181e6b31ec0b905ca7e757d55add39d2a914f23
Signed-off-by: Michael Vorburger <[email protected]>

Bug 1411-6: MDSAL Binding2 Maven API Gen Plugin

- initial skeleton to be able to build Binding v2 with models and features
- basic placeholder class to bind the means together (TODO)
- re-organized package name

Change-Id: Ide90ea7eb8b1fa5d549c3dc5110ebeae3a32bd0c
Signed-off-by: Martin Ciglan <[email protected]>

Replace FindBugs :jsr305 by full :annotation (Bug 7663)

Change-Id: Ie91b52ee8c85ab42485588219f80ca74b125f148
Signed-off-by: Michael Vorburger <[email protected]>

Bug 7438: Allow identityref type to reference multiple base identities

- fixes failing test, reflecting changes in Yangtools patch for this bug:
https://git.opendaylight.org/gerrit/#/c/50298/

Change-Id: I9ba0b6bf37f6ceb16d0d45328c096e89f47678cc
Signed-off-by: Martin Ciglan <[email protected]>

Add Karaf 4 features

This is a simplified version of
https://git.opendaylight.org/gerrit/39468 without any changes to
bundles; it just delegates the actual features.xml generation to the
plugin.

Bug: 7487
Change-Id: I932067005975206be5fdeeaf58589502d1598760
Signed-off-by: Stephen Kitt <[email protected]>

Bug 7603: ACTION support in Binding spec v2

- API changes necessary
- RPC & Action interface differ as defined here
- ListAction needed for actions in YANG list

Change-Id: Ibf3c7b95d7fc35eb5b6a95a95d61741c41aace8e
Signed-off-by: Martin Ciglan <[email protected]>

BUG-3128: Teach DOMRpcRouter about new concepts

This is the implementation part of
https://git.opendaylight.org/gerrit/50487, teaching the
DOMRpcRouter to filter listener notifications and order
the implementations according to their cost.

Change-Id: Ib04d77786811d91bb22800eb5e64d3fd57ed659a
Signed-off-by: Robert Varga <[email protected]>

Replace mockito-all by mockito-core (see Bug 7662)

Change-Id: I897ca24b64ef078cabfde442620fd41fe7a804da
Signed-off-by: Michael Vorburger <[email protected]>

BUG-7611: Add a simple DOMEntityOwnershipService

This adds a very simplistic DOMEntityOwnershipService,
which assumes it is the only thing in town. Local node always
owns the entities registered.

Listeners are dispatched synchronously as registrations occur.

Change-Id: Ia0a4dbcc159d80b4efd2463722867eaf6a791780
Signed-off-by: Robert Varga <[email protected]>

Do not open-code routed RPC identification

The code to identify routed RPCs is available via RpcRoutingStrategy,
so remove code duplication.

Change-Id: If072a9aa6d3c54d1de7fb842398e6e3b10725013
Signed-off-by: Robert Varga <[email protected]>

Bug 1459-3 #6 - Re-organize mdsal-binding2-util

- refactor package name in mdsal-binding2-util module
- with changes at places of use

Change-Id: I797993fe6678c2ae99765d2b5f15c1513b649698
Signed-off-by: Martin Ciglan <[email protected]>

Bug 1459-3 #5 - Re-organize mdsal-binding2-java-api-generator

- refactor package name in mdsal-binding2-java-api-generator module
- with changes at places of use

Change-Id: Ibe3a2b1fe7cad4272087d9a6301f37419bbf38fe
Signed-off-by: Martin Ciglan <[email protected]>

Bug 1459-3 #4 - Re-organize mdsal-binding2-generator-util

- refactor package name in mdsal-binding2-generator-util module
- with changes at places of use

Change-Id: I398be506b178d5e4fd38bebf25d65d601ed63514
Signed-off-by: Martin Ciglan <[email protected]>

Bug 1459-3 #3 - Re-organize mdsal-binding2-generator-impl

- refactor package name in mdsal-binding2-generator-impl module
- with changes at places of use

Change-Id: I5fe7d393c1ab93b0f64b9a831985613f9698239f
Signed-off-by: Martin Ciglan <[email protected]>

Bug 1459-3 #2 - Re-organize mdsal-binding2-generator-api

- refactor package name in mdsal-binding2-generator-api module
- with changes at places of use

Change-Id: I5df404eb91fad8291811cf6324b3aea361b338a1
Signed-off-by: Martin Ciglan <[email protected]>

Bug 1459-3 #1 - Re-organize mdsal-binding2-spec

- refactor package name in mdsal-binding2-spec module
- with changes at places of use

Change-Id: Iffb8c1d9a8d8f5dd7ae758efe3ed661d5e32982d
Signed-off-by: Martin Ciglan <[email protected]>

Bug 1459-2 - Re-organize mdsal-binding2-spec

- new 'base' & 'structural' packages added
- various replacements done based on bug description
- some Javadocs added

Change-Id: I9d2266845d77a9902a1c937e21884a409585a630
Signed-off-by: Martin Ciglan <[email protected]>

Bug 1459-1 - Re-organize mdsal-binding2-spec

- new artifact mdsal-binding2-util (starts with Binding2Mapping)
- new 'runtime' package for run-time support: serializer, etc..
- various replacements done based on previous changes and review comments

Change-Id: I4525d2c3f706ce1e77051711c57a3ca55ecc8350
Signed-off-by: Martin Ciglan <[email protected]>

Set Binding RPCs cost to 1

Default DOMRpcImplementation returns cost 0. Since invoking
a binding RPC involves some codec work, we want the binding
implementation to take a back seat of there is a native
RPC implementation (for example implemented in pure DOM terms).

Change-Id: I10e3bc6133980c6fc9750f02e94450655b67020f
Signed-off-by: Robert Varga <[email protected]>

BUG-3128: Update DOM RPC concepts

This is the API part of https://git.opendaylight.org/gerrit/50487,
ported back to MD-SAL.

It allows a DOMRpcAvailabilityListener to request filtering of
notifications based on the RPC implementation class.

The other part of it is the ability for DOMRpcImplementation
to advertise its invocation cost -- allowing the RPC router
to make better routing decisions

Change-Id: Icdd36aeea0780bfae5883abd786244a9291b106f
Signed-off-by: Robert Varga <[email protected]>

Bug 1411-5 #10: MDSAL Binding2 Java API Generator

- yangModelBindingProvider interface + templates
- bit of a code clean-up

Change-Id: If58ef3945b98dc2671482ec8b4489f394a82329f
Signed-off-by: Filip Gregor <[email protected]>
Signed-off-by: Martin Ciglan <[email protected]>

Bug 1411-5 #9: MDSAL Binding2 Java API Generator

- interface generator, renderer, template TOgenerator
for generating union, union builder and class
- bit of cleanup
- review comments implemented

Change-Id: Iedbf069e629c6fb92b93046348c6a15fa3e77fd9
Signed-off-by: Filip Gregor <[email protected]>
Signed-off-by: Martin Ciglan <[email protected]>

1411-5 #8 MDSAL Binding2 API Generator

- code refactored according to review comments in
https://git.opendaylight.org/gerrit/#/c/46898/15

- Binding specification v2 fix for
https://bugs.opendaylight.org/show_bug.cgi?id=7425

Change-Id: Ieddc32ede050fea9b1320454f477f4bc3ec451ec
Signed-off-by: Martin Ciglan <[email protected]>

Bug 1411-5 #8: MDSAL Binding2 Java API Generator

- union and union builder renderers and templates
- bit of a cleanup

Change-Id: I413bf4f284d5f3151436f5a96e31e4c7ada0c021
Signed-off-by: Filip Gregor <[email protected]>
Signed-off-by: Martin Ciglan <[email protected]>

Bug 1411-5 #7: MDSAL Binding2 Java API Generator

- class renderer, templates this is parent for more renderers
- minor do comment fix
- reworked method call
- bit of a cleanup, review comments implemented

Change-Id: I66cbf521b3be36e7278b6026fd02353a337c12b4
Signed-off-by: Filip Gregor <[email protected]>
Signed-off-by: Martin Ciglan <[email protected]>

Bug 1411-5 #6: MDSAL Binding2 Java API Generator

- builder generator, renderer and templates
- fixed minor issues
- bit of cleanup, review comments implemented

Change-Id: I7cedfb4fde4e441b7d68b2717fbb4f8ea6d3d77e
Signed-off-by: Filip Gregor <[email protected]>
Signed-off-by: Martin Ciglan <[email protected]>

BUG-7446: fix tests' usage of MoreExecutors

MoreExecutors.sameThreadExecutor() is deprecated, use its
appropriate replacement instead.

Change-Id: I487285b156d3fbe7b558fecd5cbc13cb66f02a2c
Signed-off-by: Robert Varga <[email protected]>

Bump xtendbeans version for AssertBeans to support YANG union types

Change-Id: If6998d3e5dc766e67ca7bfa5f1954197759bc05f
Signed-off-by: Michael Vorburger <[email protected]>

Bug 7425: Recognize instance-identifier in union template

Previously, it was wrongly identified as a generated type,
but InstanceIdentifier is a base type, so no getValue() there.

Change-Id: I18d67357753eda6e241a608fc5a2c933aa1f9eda
Signed-off-by: Vratko Polak <[email protected]>

BUG-7435: eliminate use of yang-parser-impl internals

Switch to using YangParserTestUtil instead.

Change-Id: I98e0870051e42372adf7d7284b10b368e68516f6
Signed-off-by: Robert Varga <[email protected]>

Bug 6859: Cleanup package names for mdsal-binding-generator-util module

- correct package names in respect to change:
  https://git.opendaylight.org/gerrit/#/c/46780
  to get back sonar code coverage number
- bit of a code clean-up

Change-Id: I766745343eb6d174438834e9087c14168d68cea8
Signed-off-by: Martin Ciglan <[email protected]>

Improve binding type instantiation

This patch causes binding generator to emit valueOf()
constructors instead of explicit 'new' for well-known
types, allowing better reuse of instances.

Change-Id: I66f7cbc0b8362d82759d2276c81aed1fd5296101
Signed-off-by: Robert Varga <[email protected]>

BUG-4219: clean up features.xml

In models' features.xml, odl-mdsal-binding-base includes yang-ext so
it's not strictly necessary in odl-mdsal-models. (This is potentially
controversial of course since it should perhaps be construed as a
declared part of the odl-mdsal-models API.)

In mdsal's features.xml:
* use odl-lmax-3 instead of odl-lmax;
* drop mdsal-dom-{api,spi} from odl-mdsal-dom-broker (they're part of
  odl-mdsal-dom-api);
* odl-mdsal-binding-api needs odl-yangtools-yang-parser, and
  mdsal-binding-util;
* odl-mdsal-singleton-dom needs odl-mdsal-common.

Change-Id: I4f18d697065f4e9df2b0e621fd32d4b18b8068fd
Signed-off-by: Stephen Kitt <[email protected]>

BUG-4219: remove slf4j-api dependencies

These are provided by odlparent and cause issues when generating
features (in preparation for the Karaf 4 migration).

Change-Id: I24c392017ae4353264b721d4ea01f5769172fc4c
Signed-off-by: Stephen Kitt <[email protected]>

BUG-2138: Add shard DTO classes to spi

This patch moves common classes useful for DOMDataTreeShard
implementations public in the spi package, allowing them to be reused
rather than re-implemented.

Change-Id: I4885fd862291642c702a1bf561a920bf8459016c
Signed-off-by: Tomas Cere <[email protected]>

Make variadic enter() a default method

Implementations do not need to implement this themselves,
as it can be implemented efficiently by wrapping the argument
in Arrays.asList().

Change-Id: I07d282dbd23555642d52bc3d6a81158526c3a03e
Signed-off-by: Robert Varga <[email protected]>

Bug 1411-5 #5: MDSAL Binding2 Java API Generator

- generator to java file
- enum generator, renderer and template
- bit of cleanup

Change-Id: I79f96631e765c2d7a9b4d96c7e19c1a288bb7139
Signed-off-by: Filip Gregor <[email protected]>
Signed-off-by: Martin Ciglan <[email protected]>

Bug 1411-5 #4: MDSAL Binding2 Java API Generator

- top parent class for all renderers
- bit of cleanup, review comments implemented

Change-Id: If84b1e4505f7e16e462ae51dfe4ac4f3c6dbcc26
Signed-off-by: Filip Gregor <[email protected]>
Signed-off-by: Martin Ciglan <[email protected]>

Bug 7159: Add yang-test-util artifact

- follow-up patch for MD-SAL
- bit of a code cleanup

Please see Yangtools introduction here:
https://git.opendaylight.org/gerrit/#/c/49129/

Change-Id: I91b2cb2e07245ce1f558ecf62a9a81a1d1ed2ebc
Signed-off-by: Martin Ciglan <[email protected]>

Bug 7271: Modify AbstractDOMStoreTreeChangePublisher to batch candidates

The AbstractDOMStoreTreeChangePublisher was modified to keep track of
DataTreeCandidates per listener via a Map in order to notify listeners
of all DataTreeCandidate changes in one event. This allows the
initial event on registration to send all list entry nodes. The
previous notifyListeners abstract method was removed in lieu of a
new notifyListener that takes a listener registration and the list
of DataTreeCandidates

Change-Id: I02f14f202a46bbf9afe8de1941701849a41a431c
Signed-off-by: Tom Pantelis <[email protected]>

Bug 6163: fixed number of argument when resolving rpc input

- changed functionality of resolving rpc input. Input class is
  resolved by it's assignability from DataContainer class
- quite a bit of cleanup, comments added

https://bugs.opendaylight.org/show_bug.cgi?id=6163

Change-Id: I4a7d05283951db280c3e92301590407da4f40ffa
Signed-off-by: Peter Nosal <[email protected]>
Signed-off-by: Martin Ciglan <[email protected]>

Checkstyle compliant src/main|test/resources

Change-Id: I68823f3538bbd0fe932e6469abecbdaed8ef9702
Signed-off-by: Michael Vorburger <[email protected]>

Bug 6135: Java binding v1: IAE from provideTypeForLeafref

- add referenced types in order to resolve leafrefs (main idea of this bug)
- do it in rather conservative way to not to spoil BGPCEP build
- fix back non-sense change in GenEnumResolvingTest.java to original state

Change-Id: I0d7083c7b71e07cb60a22f3106657060a2936c9c
Signed-off-by: Martin Ciglan <[email protected]>

JavassistUtils cleanup

Change-Id: I481caf9954aec0ae2051d1722c0375cd1dcbe5d8
Signed-off-by: Martin Ciglan <[email protected]>

Removed sonar warnings.

Change-Id: I2dbe2018cc1d2672f98fd3aea9e01c7d851eacc8
Signed-off-by: Dana Kutenicsova <[email protected]>

Removed sonar warnings.

Change-Id: I30d1be315d148a3a19809f4b33bfe40cec676e84
Signed-off-by: Dana Kutenicsova <[email protected]>

Removed sonar warnings.

Change-Id: I44f590d2bb3c814898cb00b9441c16f774100974
Signed-off-by: Dana Kutenicsova <[email protected]>

Removed sonar warnings.

Change-Id: Iad015c6deab0f6fb432c36265ada159afac57b13
Signed-off-by: Dana Kutenicsova <[email protected]>

Fixup compilation after YT move

The move in YANG Tools has caused inherited type problems.
YANG Binding should not be doing this, really.

Change-Id: I518ab258f26d2db38349087736d37a76352642be
Signed-off-by: Robert Varga <[email protected]>

Bug 1411-5 #3: MDSAL Binding2 Java API Generator

- Range generators
- dedicated folder

Change-Id: I53d448049bdd0a0fcdc7e113b7c209699321fab9
Signed-off-by: Filip Gregor <[email protected]>
Signed-off-by: Martin Ciglan <[email protected]>

BUG-5222: use dependency=true between features

This patch marks feature dependencies as such, so karaf
knows not to reinstall them if they are already installed.

Change-Id: I979d85ec9dcf890a246ace63720f5ec194104cc3
Signed-off-by: Robert Varga <[email protected]>

Bug 1411-5 #2: MDSAL Binding2 Java API Generator

-new utility class for various string processings
-added comparator
-Javadocs added for all public methods

Change-Id: I26747a53544dd6deafcef21a4e8330790ed4165f
Signed-off-by: Filip Gregor <[email protected]>
Signed-off-by: Martin Ciglan <[email protected]>

Removed sonar warnings from binding-dom-adapter.

Change-Id: I25fce8206a8219e9bb5479b2df07d9bb70388d89
Signed-off-by: Dana Kutenicsova <[email protected]>

BUG-3128: Extract abstract shard implementations.

Extract abstract shard implementations that can be reused
in other shard implementations.
While we're here fix a bug with shard modification creation
when there were multiple levels between parent and child shards.

Change-Id: I1a24cb32363d8d56ef8e5817c474e35c41af49e5
Signed-off-by: Tomas Cere <[email protected]>
Signed-off-by: Robert Varga <[email protected]>

Bug 6236: Introduce "mdsal.skip.verbose" property, for build speed

This doesn't "fix" Bug 6236, but works around it - and gives us a low
hanging fruit build performance improvement.

If this change gets accepted, I would make the odlparent -Pq profile set
this to true by default.

In parallel, I'm trying to get a root cause fix in a future Xtend
version. (At which point this could be removed again.)

Change-Id: I108f401fa2fbca6f17a8b23cb098910c5a6021fb
Signed-off-by: Michael Vorburger <[email protected]>

Bug 7064: yang-to-source error on description

Existing logic of formatToParagraph() method doesn't expect a case
when very first text sequence is longer than 80 characters
and crashes in wrong condition branch. This has been fixed and tested
for various inputs.

Change-Id: Iefeb2b4063335561f3277c3ee40b3d9a46c418dc
Signed-off-by: Martin Ciglan <[email protected]>

AssertDataObjects with LOG of diff

When running failing tests in CI on build (or simply local mvn CLI),
then the ComparisonFailure for large expected/actual objects, such as
flows, is very difficult to make sense of.

In the IDE one doesn't have this problem, because the JUnit view of IDEs
will interpret an ComparisonFailure and show a very clear side-by-side
comparison of expected VS actual.

This change introduces a LOG, in case of AssertDataObjects failure,
which prints a diff for the ComparisonFailure, which will make analysing
AssertDataObjects based test failures much easier on CI build.

Change-Id: I666fbceeb794f7b810a11c2efa8e33a51afc1b2d
Signed-off-by: Michael Vorburger <[email protected]>