Tomas Olvecky [Fri, 21 Feb 2014 09:53:44 +0000 (10:53 +0100)]
Resolve Bug:445 Remove freemarker from config code generator.
Change-Id: Idf834620cb7e12e10e7fca1ce8ea0172ca730a3d
Signed-off-by: Tomas Olvecky <tolvecky@cisco.com>
Tony Tkacik [Wed, 9 Apr 2014 08:19:07 +0000 (08:19 +0000)]
Merge "BUG-704 Fix failing integration test in netconf-it"
Maros Marsalek [Wed, 9 Apr 2014 06:49:35 +0000 (08:49 +0200)]
BUG-704 Fix failing integration test in netconf-it
Ignore for now, proper fix will follow
Change-Id: Iee9bfc3bedf6daca7afd5d57ae37f758c1acd871
Signed-off-by: Maros Marsalek <mmarsale@cisco.com>
Robert Varga [Wed, 9 Apr 2014 03:29:00 +0000 (05:29 +0200)]
BUG-509: Rename StoreMetadataNode.createRecursivelly
This is a rename of StoreMetadataNode.createRecursivelly() to
StoreMetadataNode.createRecursively(), fixing an obvious typo.
Change-Id: I3891459ebae561b89c27438f2e0f187bd7b7c503
Signed-off-by: Robert Varga <rovarga@cisco.com>
Robert Varga [Tue, 8 Apr 2014 16:07:32 +0000 (18:07 +0200)]
BUG-509: Fix thread safety of listener registration
This commit fixes the race condition where a listener is registered
after preCommit() and before commit(). This is done by moving the
collection into the commit() where it is protected by the
commit/listener synchronized block.
The unregistration safety is handled by wrapping the returned
registration and invoking the equivalent synchronized block.
Change-Id: Ie9abc81b2a773418b34c3051f7665b0dcf047f76
Signed-off-by: Robert Varga <rovarga@cisco.com>
Robert Varga [Thu, 27 Mar 2014 02:52:42 +0000 (03:52 +0100)]
BUG-509: Improve InMemoryDOMDataStore structure
Introduce AbstractDOMStoreTransaction, which holds common code. Also use
ToStringHelper to get consistent toString().
Change-Id: I246c891fa4a9a4c12b21eeb2743a00097dd95fbe
Signed-off-by: Robert Varga <rovarga@cisco.com>
Ed Warnicke [Tue, 8 Apr 2014 16:12:31 +0000 (16:12 +0000)]
Merge "Bug 509: Fixed order of invoking Schema listeners."
Tony Tkacik [Tue, 8 Apr 2014 16:11:43 +0000 (16:11 +0000)]
Merge "BUG-509: Fix thread safety of DOMDataBrokerImpl.ready()"
Tony Tkacik [Tue, 8 Apr 2014 16:11:26 +0000 (16:11 +0000)]
Merge "BUG-579: Remove ImmutableMap in favor of LinkedHashMap"
Ed Warnicke [Tue, 8 Apr 2014 16:11:16 +0000 (16:11 +0000)]
Merge "Fixed potential class pool override in integration tests."
Robert Varga [Thu, 27 Mar 2014 02:51:34 +0000 (03:51 +0100)]
BUG-509: Fix thread safety of DOMDataBrokerImpl.ready()
Transition to ready has to occur precisely once, so the process of
taking cohorts has to be synchronized.
Change-Id: I8ba8fe7437dd59547d04fec73f5cd9ed43232161
Signed-off-by: Robert Varga <rovarga@cisco.com>
Robert Varga [Thu, 27 Mar 2014 03:55:56 +0000 (04:55 +0100)]
BUG-579: Remove ImmutableMap in favor of LinkedHashMap
This prevents a single round og ImmutableMapBuilder.build() as a
trade-off for not leaking a mutable reference to the map.
Change-Id: Idb97a5f4ece1d2f27af728310d9b0807ae305926
Signed-off-by: Robert Varga <rovarga@cisco.com>
Tony Tkacik [Tue, 8 Apr 2014 11:58:16 +0000 (11:58 +0000)]
Merge "Update config-module-archetype."
Tony Tkacik [Tue, 8 Apr 2014 11:54:24 +0000 (11:54 +0000)]
Merge "Add filtering capability to config.ini in order to reference logging bridge version."
Tony Tkacik [Tue, 8 Apr 2014 11:53:15 +0000 (11:53 +0000)]
Merge "Resolve Bug:522"
Tony Tkacik [Tue, 8 Apr 2014 10:13:03 +0000 (10:13 +0000)]
Merge "BUG-633: allow bootstrap customization"
Tony Tkacik [Tue, 8 Apr 2014 09:59:15 +0000 (09:59 +0000)]
Merge "Resolve Bug:623 : Generate private key using bouncycastle."
Tony Tkacik [Tue, 8 Apr 2014 09:55:33 +0000 (09:55 +0000)]
Merge "Bug 639, Bug 641, Bug 642: This is MD-SAL based sample implementation of a learning switch with optimizations in how packet is forwarded. Link to detail documetation: https://wiki.opendaylight.org/view/OpenDaylight_Controller:MD-SAL:L2_Switch"
Tony Tkacik [Tue, 8 Apr 2014 09:44:35 +0000 (09:44 +0000)]
Merge "524 bug - %2F slashes translation behind mount point (unit test)"
Tony Tkacik [Tue, 8 Apr 2014 09:39:35 +0000 (09:39 +0000)]
Merge "BUG-672 Make Xml directory adapter skip initial config files with invalid xml."
Tony Tkacik [Tue, 8 Apr 2014 09:39:15 +0000 (09:39 +0000)]
Merge changes I6029bd48,Ie8eb4152
* changes:
BUG-672 Add includeExtensions property to Xml directory persister adapter.
BUG-672 Remove deprecated plaintext/autodetect persister adapters.
Tony Tkacik [Tue, 8 Apr 2014 09:38:45 +0000 (09:38 +0000)]
Merge "bug - missing excaping of % character in String.format() method"
Madhu Venugopal [Mon, 7 Apr 2014 22:38:36 +0000 (22:38 +0000)]
Merge "Fix bug 666 - Neutron Subnet Creation Error"
Tony Tkacik [Mon, 7 Apr 2014 15:34:04 +0000 (17:34 +0200)]
Fixed potential class pool override in integration tests.
Classloader in JUnit test is shared resource and in order
to integrate well with Javassist we are required to share
also classpool in order to compile generated code
using previously existing generated code in same Classloader.
If we introduce new ClassPool for same classloader,
compilation may fail, because new ClassPool is unable
to fetch bytecode for already generated classes.
Change-Id: Idd933670fe0a1c06d40aeed182f46997a843ab91
Signed-off-by: Tony Tkacik <ttkacik@cisco.com>
Maros Marsalek [Mon, 7 Apr 2014 15:28:36 +0000 (17:28 +0200)]
BUG-672 Make Xml directory adapter skip initial config files with invalid xml.
Issue a warning and continue to next file.
Change-Id: I1950eddc80b958f5887458ebeaa53b590506c31c
Signed-off-by: Maros Marsalek <mmarsale@cisco.com>
Maros Marsalek [Mon, 7 Apr 2014 12:48:15 +0000 (14:48 +0200)]
BUG-672 Add includeExtensions property to Xml directory persister adapter.
This property allows to filter initial config files by extension.
Property supports multiple extensions separated by ','.
This property is optional, and if not present, all files are picked up regardless of their extension.
Change-Id: I6029bd48fa3b576006a4409d8f19e0c4956de036
Signed-off-by: Maros Marsalek <mmarsale@cisco.com>
Maros Marsalek [Mon, 7 Apr 2014 11:04:39 +0000 (13:04 +0200)]
BUG-672 Remove deprecated plaintext/autodetect persister adapters.
Xml adapters are the default adapters now for configuration persister.
Change-Id: Ie8eb41520671bb00503a340f6b4b55ebe1ef7bf1
Signed-off-by: Maros Marsalek <mmarsale@cisco.com>
Tony Tkacik [Mon, 7 Apr 2014 10:31:55 +0000 (12:31 +0200)]
Bug 509: Fixed order of invoking Schema listeners.
Explicitly registered SchemaServiceListeners
are invoked before listeners picked-up by whiteboard
pattern, which by default are not aware
of the service.
Change-Id: Id41b89a1ba2ccb5323d5ab5ad8a95d2048776679
Signed-off-by: Tony Tkacik <ttkacik@cisco.com>
Tomas Olvecky [Mon, 7 Apr 2014 07:44:31 +0000 (09:44 +0200)]
Resolve Bug:623 : Generate private key using bouncycastle.
Add dependency on bouncycastle and use it to generate private key in PEM
format when key file is not present on the filesystem.
Change-Id: I07290e0f361151743a50559c26255eab23cababb
Signed-off-by: Tomas Olvecky <tolvecky@cisco.com>
Tony Tkacik [Mon, 7 Apr 2014 09:04:13 +0000 (09:04 +0000)]
Merge "BUG-509: make sure datastore commits are visible"
Giovanni Meo [Mon, 7 Apr 2014 08:06:17 +0000 (08:06 +0000)]
Merge "Edges are left in TopologyManager database when nodes disconnect"
Jozef Gloncak [Mon, 7 Apr 2014 06:27:19 +0000 (08:27 +0200)]
bug - missing excaping of % character in String.format() method
Change-Id: Ic44ff0cf558efbba9c465ac760da13fcf3add2cb
Signed-off-by: Jozef Gloncak <jgloncak@cisco.com>
Dave Tucker [Sun, 6 Apr 2014 16:48:33 +0000 (17:48 +0100)]
Fix bug 666 - Neutron Subnet Creation Error
When a neutron subnet is created on the Northbound API, containing the
new "ipv6_address_mode" or "ipv6_ra_mode" fields with "null" values
Jersey will fail to deserialise the object correctly and throw an HTTP
500 error with a NullPointerException.
This commit adds the above fields to the NeutronSubnet object and
permits these fields to be nillable.
Change-Id: I225581b57a1698a5e5c17f91b117fba556b70976
Signed-off-by: Dave Tucker <dave.j.tucker@hp.com>
Robert Varga [Fri, 4 Apr 2014 17:14:57 +0000 (19:14 +0200)]
BUG-509: internal cleanup
Spell-check internal class and make it static
Make sure we don't have null name in contructor
Make sure we don't have null executor in constructor
getIdentifier() should be final
Change-Id: Ib8ebe82106d953581738bccbe1d4b878f9520b5b
Signed-off-by: Robert Varga <rovarga@cisco.com>
Robert Varga [Fri, 4 Apr 2014 17:50:57 +0000 (19:50 +0200)]
BUG-509: make sure datastore commits are visible
This wraps the datastore root in an AtomicReference, which makes sure
started transactions see the latest published commit. This will make
the datastore handling more robust under tight conditions.
Also uncovers the fact that we are invoking user code under lock, which
we fix by reusing the executor used by the commit machinery.
Finally it uncovers thread-unsafe listener list manipuation. This will
need to be addressed in a follow-up patch.
Change-Id: Ic7efd266ef680701c1f0944ee675122d8527568b
Signed-off-by: Robert Varga <rovarga@cisco.com>
Robert Varga [Sun, 6 Apr 2014 16:20:58 +0000 (18:20 +0200)]
BUG-633: allow bootstrap customization
Downstream projects may need to customize Bootstrap/ServerBootstrap
instances before they are used. Create two protected methods which
can be overridden to gain access to the instances before they are used.
Change-Id: Ibb45c7b99847cbe2fe8b90e8d1bf125c66a18e0d
Signed-off-by: Robert Varga <rovarga@cisco.com>
Maurice Qureshi [Sat, 5 Apr 2014 03:17:22 +0000 (20:17 -0700)]
Edges are left in TopologyManager database when nodes disconnect
When nodes are disconnected from ODL Controller, some edges are left
in TopologyManager's database. As a result GUI (and possibly REST APIs0
still shows some switches to be connected even when there are no
switches connected to the controller.
Change-Id: Ia4a5ae0160b07ba0207bf763dbc234e34dcf5816
Signed-off-by: Maurice Qureshi <maquresh@cisco.com>
Amit Mandke [Sat, 5 Apr 2014 00:59:52 +0000 (17:59 -0700)]
Bug 639, Bug 641, Bug 642: This is MD-SAL based sample implementation of a learning switch with optimizations in how packet is forwarded.
Link to detail documetation: https://wiki.opendaylight.org/view/OpenDaylight_Controller:MD-SAL:L2_Switch
It has following components:
PacketHandler examines Ethernet packets to find information about Mac-Port pairings.
-informs AddressTracker about new Mac-Port pairings.
-informs FlowWriterService about new flows, when the source & destination of a packet are known.
-uses InventoryService to determine external ports and only send packets to those ports when flooding packets in the network.
AddressTracker stores the Mac-Port pairings in the MD-SAL data tree.
InventoryService provides information about the nodes and node connectors in the network.
FlowWriterService adds packet forwarding (mac-to-mac) flows to the MD-SAL data tree.
-uses NetworkGraphDijkstra to determine all the intermediate nodes along a path.
TopologyLinkDataChangeHandler listens to topology updates and informs NetworkGraphDijkstra of these updates.
NetworkGraphDijkstra maintains the network graph and computes the shortest path between each node.
Change-Id: I33497a9e2136316de1db16e1c7f916cbc13f437f
Signed-off-by: Amit Mandke <ammandke@cisco.com>
Robert Varga [Fri, 4 Apr 2014 13:25:41 +0000 (15:25 +0200)]
Bug 510: Updated initial configuration to easily enable new datastore
In order to enable new in-memory datastore (and to wire it with clients)
initial configuration of md-sal (01-md-sal.xml) needs to be updated
to unwire old services and wire new one to the actual MD-SAL brokers.
This could be done by commenting out all DATA-BROKER sections
and uncommenting NEW-DATA-BROKER sections.
Change-Id: I072a65785593b82ec4b1ff6e3dae4c0af7497659
Signed-off-by: Tony Tkacik <ttkacik@cisco.com>
Signed-off-by: Martin Sunal <msunal@cisco.com>
Signed-off-by: Robert Varga <rovarga@cisco.com>
Ed Warnicke [Fri, 4 Apr 2014 17:05:09 +0000 (17:05 +0000)]
Merge "Bug 510: Implementation of Forwarded Binding Data Broker"
Ed Warnicke [Fri, 4 Apr 2014 16:41:22 +0000 (16:41 +0000)]
Merge "Resolve Bug:654 - Fix config-persister exception handling."
Robert Varga [Fri, 28 Mar 2014 21:23:07 +0000 (22:23 +0100)]
Bug 510: Implementation of Forwarded Binding Data Broker
Initial implementation of Forwarded Binding Data Broker
and Forwarded Backwards Compatible Data Broker,
which provides access to new data broker via original
API.
Added sample configuration which enables new
DOM Data Broker, In-memory Data Broker and
ForwardedCompatibleDataBroker.
Change-Id: I3569da20a9873edf352a54622be7a01fd329aa9b
Signed-off-by: Moiz Raja <moraja@cisco.com>
Signed-off-by: Tony Tkacik <ttkacik@cisco.com>
Signed-off-by: Robert Varga <rovarga@cisco.com>
Tomas Olvecky [Fri, 4 Apr 2014 10:29:19 +0000 (12:29 +0200)]
Resolve Bug:654 - Fix config-persister exception handling.
Modify NetconfUtil to fail on any <rpc-error>, not detecting transaction conflicts. Move
exception handling to ConfigPusher.
Also fix bug when config-netconf-connector detects discrepancy between yang store and
config manager factories: persister will retry as if some capabilities were not found.
Change-Id: Ibd80fd3859031ae41301481dad9b50f74207e64c
Signed-off-by: Tomas Olvecky <tolvecky@cisco.com>
Robert Varga [Wed, 26 Mar 2014 18:29:13 +0000 (19:29 +0100)]
Bug 499: Fixed normalization of InstanceIdentifier for backwards compatibility
Change-Id: I633eb004729c6013df49c3f82420adf6d2417ea9
Signed-off-by: Tony Tkacik <ttkacik@cisco.com>
Signed-off-by: Robert Varga <rovarga@cisco.com>
Robert Varga [Fri, 21 Mar 2014 12:30:45 +0000 (13:30 +0100)]
Bug 499: Improved data change listener tree management
Change-Id: I62843c3c4df32dd5a5849511d41352fa6822550b
Signed-off-by: Tony Tkacik <ttkacik@cisco.com>
Signed-off-by: Robert Varga <rovarga@cisco.com>
Michal Rehak [Fri, 4 Apr 2014 10:44:38 +0000 (12:44 +0200)]
fix for BUG 663 - causing derived IT to fail
- added version to netty-config-api test dependency
Change-Id: I6653522e447283f28d5d89884427473973eb508b
Signed-off-by: Michal Rehak <mirehak@cisco.com>
Andrew Kim [Thu, 3 Apr 2014 22:42:35 +0000 (17:42 -0500)]
Add Flood and FloodAll supported actions
This patch will return Flood and FloodAll as supported actions when a switch is queried for its supported flow actions
Change-Id: I8c4b8821bd773e3eb654f35a60a9f41e08deadb6
Signed-off-by: Andrew Kim <andrekim@cisco.com>
Ed Warnicke [Wed, 2 Apr 2014 23:28:41 +0000 (23:28 +0000)]
Merge changes I6bc37e88,I0514b26e
* changes:
Fixed missing keys in sal-compatibility flows.
Bug 508: Fixed concurrent conflicting commits by InventoryManager.
Michael Bredel [Wed, 2 Apr 2014 09:26:59 +0000 (11:26 +0200)]
Added a comment that briefly describes the ArpHander service and explains some design decisions.
Change-Id: I2dd3877e5a12ad59f4c5057de09ecab2b4e9f768
Signed-off-by: Michael Bredel <michael.bredel@cern.ch>
Jozef Gloncak [Wed, 2 Apr 2014 09:43:31 +0000 (11:43 +0200)]
524 bug - %2F slashes translation behind mount point (unit test)
New test getDataWithSlashesBehindMountPoint() tests whether URI identifier
which contains slashes encoded as %2F (e.g. in key part of URI) is translated to identifier with simple slash
characters (/).
It is checked whether InstanceIdentifier instance is created with simple
slashes. The instance is then used as input parameter of method
BrokerFacade.readOperationalDataBehindMountPoint() to get data from
datastore.
If %2F are correctly replaced with / test is succesful.
Change-Id: I131bda42fb568af23d6a1b0bbb72c505db8748e3
Signed-off-by: Jozef Gloncak <jgloncak@cisco.com>
Tony Tkacik [Wed, 2 Apr 2014 08:59:58 +0000 (08:59 +0000)]
Merge "BUG-467: reconnect-strategy configuration moved into controller/commons/protocol-framework -changed reconnect-strategy service and modules to reconnect-strategy-factory - configuration of ReconnectStrategyFactory."
Tony Tkacik [Tue, 1 Apr 2014 06:59:49 +0000 (08:59 +0200)]
Fixed missing keys in sal-compatibility flows.
Change-Id: I6bc37e88b6191701369e2b6c0e821c1433ca122d
Signed-off-by: Tony Tkacik <ttkacik@cisco.com>
Tony Tkacik [Tue, 1 Apr 2014 15:23:37 +0000 (17:23 +0200)]
Bug 508: Fixed concurrent conflicting commits by InventoryManager.
Change-Id: I0514b26e6ccdf456ec8ffb570056db43cebc89d0
Signed-off-by: Tony Tkacik <ttkacik@cisco.com>
Ed Warnicke [Tue, 1 Apr 2014 15:22:45 +0000 (15:22 +0000)]
Merge "Bug 499: Added support for old DOM Broker APIs."
Ed Warnicke [Tue, 1 Apr 2014 15:22:27 +0000 (15:22 +0000)]
Merge "Bug 499: Added support for change listeners."
Ed Warnicke [Tue, 1 Apr 2014 15:21:25 +0000 (15:21 +0000)]
Merge "Bug 499: Initial draft of in-memory datastore and data broker"
Tony Tkacik [Tue, 1 Apr 2014 11:07:44 +0000 (11:07 +0000)]
Merge "Updater toaster to use datastore"
Giovanni Meo [Tue, 1 Apr 2014 09:02:40 +0000 (09:02 +0000)]
Merge "Initial commit for new Match classes"
Ed Warnicke [Mon, 31 Mar 2014 20:13:53 +0000 (20:13 +0000)]
Merge "Bug 499: Initial implementation of data tree modifications"
Ed Warnicke [Mon, 31 Mar 2014 20:09:54 +0000 (20:09 +0000)]
Merge "Bug 499: Initial implementation of supporting tree structures"
Robert Varga [Mon, 31 Mar 2014 16:06:20 +0000 (18:06 +0200)]
Updater toaster to use datastore
This patch adds the ability to expose the toaster status into MD-SAL, as
expected by the module. It further tweaks a thinko: dark toasts take
longer to make!
Change-Id: I3054ec52f53272c3fb08494517c6c86524403949
Signed-off-by: Robert Varga <rovarga@cisco.com>
Milos Fabian [Mon, 17 Mar 2014 06:40:14 +0000 (07:40 +0100)]
BUG-467: reconnect-strategy configuration moved into controller/commons/protocol-framework
-changed reconnect-strategy service and modules to reconnect-strategy-factory - configuration of ReconnectStrategyFactory.
Change-Id: I863cf4f7cf559504d05e14293af9d2c5e9373ca7
Signed-off-by: Milos Fabian <milfabia@cisco.com>
Tony Tkacik [Mon, 31 Mar 2014 07:31:16 +0000 (07:31 +0000)]
Merge "Fix small resource leak in config-manager."
Tony Tkacik [Mon, 31 Mar 2014 07:26:27 +0000 (07:26 +0000)]
Merge "Update toaster example to emit lifecycle logs"
Tony Tkacik [Mon, 31 Mar 2014 07:25:44 +0000 (07:25 +0000)]
Merge changes I28d517fe,Ia6f0b6ce
* changes:
Remove getPort API from sal-port.yang
Avoid nullpointer exception on starting up the TopologyProvider and the InventorReadAdapter
Tony Tkacik [Mon, 31 Mar 2014 07:23:02 +0000 (07:23 +0000)]
Merge "Do not use InstanceIdentifier.builder()"
Tony Tkacik [Mon, 31 Mar 2014 07:20:57 +0000 (07:20 +0000)]
Merge "Bug 564 - add missing sal-remote dependency."
Robert Varga [Sun, 30 Mar 2014 21:17:32 +0000 (23:17 +0200)]
Fix yang-parser-impl not being pulled
sal-netconf-connect depends on it, but relies on in transiently via
yang-data-impl. That transient dependency is going away, so introduce a
proper dependency.
Change-Id: I9efbec70e5630c98d19cd113a7d7096739f90dac
Signed-off-by: Robert Varga <rovarga@cisco.com>
Alessandro Boch [Tue, 10 Dec 2013 17:42:10 +0000 (09:42 -0800)]
Initial commit for new Match classes
- Existing match classes rely on a static enum of match types.
This change is to allow extensibility for new matching fields.
- This commit introduces new classes without replacing old ones
and without migrating any code to use the new ones yet.
Change-Id: I76531c10ae480123044ec1023bce8750ce7906ba
Signed-off-by: Alessandro Boch <aboch@cisco.com>
Tony Tkacik [Wed, 26 Mar 2014 18:29:13 +0000 (19:29 +0100)]
Bug 499: Added support for old DOM Broker APIs.
Added implementation of BackwardsCompatibleBroker
which exposes sal.core.api.DataBrokerService
using new DOMDataBroker and Data Store.
Enabled configuration which allows for configuring
specificing which implementation of Data DOM Broker
should be used in the MD-SAL.
Change-Id: I6ad7172e62eac1ae0af9be08684b2ae4adba6005
Signed-off-by: Tony Tkacik <ttkacik@cisco.com>
Tony Tkacik [Fri, 21 Mar 2014 12:30:45 +0000 (13:30 +0100)]
Bug 499: Added support for change listeners.
Change-Id: I9e9c46f13f77ac8b1bda459c35724a5e0b24d91f
Signed-off-by: Tony Tkacik <ttkacik@cisco.com>
Tony Tkacik [Tue, 18 Mar 2014 16:18:37 +0000 (17:18 +0100)]
Bug 499: Initial draft of in-memory datastore and data broker
Initial implementation of InMemoryDOMDataStore with support
for commits to the store and conflict checking
- DOMDataBrokerImpl - initial implementation of DOM Data Broker which
uses InMemoryDOMDataStore instances as store for Operational
and Configuration data
- InMemoryDOMDataStore - implementation of in-memory DOM Data Store
which uses MutableDataTree
- Updated SchemaAwareApplyOperation to provide
more granular operations as
- verifyStructure - verify if correct tree node types are used
- isApplicable - verifies if modification is applicable to other
snapshot
Added test suite which tests InMemoryDOMStore, performance
of DOMDataBroker and DOM Data Broker.
Change-Id: Ia7f8659aa128e1dc1e9a8580ac46452dfe66289a
Signed-off-by: Tony Tkacik <ttkacik@cisco.com>
Tony Tkacik [Tue, 18 Mar 2014 16:10:14 +0000 (17:10 +0100)]
Bug 499: Initial implementation of data tree modifications
Initial implementation of data tree modifications using
StoreMetadataNode and NodeModification.
- DataAndMetadataSnapshot - helper class, which
contains immutable snapshot of data and metadata
- ModificationApplyOperation - interface definition
of composite hierarchical operation, which
is responsible for applying changes to provided
subtree
- SchemaAwareApplyOperation - implementations of
ModificationApplyOperation based on parsed
SchemaContext
- MutableDataTree - class which integrates
Data tree, Metadata tree, Node Modification tree
and ModificationApplyOperations into mutable logical
tree, which will serves as a basis for read-write
transactions.
- Unit test for MutableDataTree in following scenarios
- Create empty MutableDataTree, write subtree, read nested nodes
- Create empty MutableDataTree, write subtree, modify subtree
- Create MutableDataTree with existing date, write changes and deletes
Change-Id: I5c0c84764f93d150eac6d227c4bc367b67652f9d
Signed-off-by: Tony Tkacik <ttkacik@cisco.com>
Robert Varga [Tue, 18 Mar 2014 16:00:55 +0000 (17:00 +0100)]
Bug 499: Initial implementation of supporting tree structures
- StoreTreeNode - interface defining common interface to tree
structures used by data store.
- TreeNodeUtils - utility methods which uses StoreTreeNode
as tree definitions and provides functionality such
as retrieval of deep nodes.
- StoreMetadataNode - immutable tree node (and tree), representing
versioning metadata and data.
- NodeModification - mutable tree node (and tree),
representing modification (diff) which should be applied to
data tree. Tree is lazily populated by invoking client
operations to be maded.
This patchset requires https://git.opendaylight.org/gerrit/#/c/5646/
to be merged.
Change-Id: I2d2437ea64ba54565ba60826fe0e7c14f071598e
Signed-off-by: Tony Tkacik <ttkacik@cisco.com>
Signed-off-by: Robert Varga <rovarga@cisco.com>
Tony Tkacik [Fri, 28 Mar 2014 19:13:21 +0000 (19:13 +0000)]
Merge "Resolve Bug:593. Persister should communicate via OSGi SR instead of TCP."
Robert Varga [Fri, 28 Mar 2014 18:58:38 +0000 (19:58 +0100)]
Update toaster example to emit lifecycle logs
Change-Id: I8a73f71d315489d349aa3f2b701c5cbf2ef5a2c6
Signed-off-by: Robert Varga <rovarga@cisco.com>
Alessandro Boch [Fri, 28 Mar 2014 18:10:20 +0000 (18:10 +0000)]
Merge "Add Enqueue validation check in FlowConfig"
Andrew Kim [Fri, 28 Mar 2014 02:44:47 +0000 (21:44 -0500)]
Add Enqueue validation check in FlowConfig
Backend validation to check enqueue queue is within range 0 -
2147483647
Change-Id: Ib17f3259a75fe3553455775bf7f26649ced40612
Signed-off-by: Andrew Kim <andrekim@cisco.com>
Tony Tkacik [Fri, 28 Mar 2014 16:47:30 +0000 (16:47 +0000)]
Merge changes Id6b8ba01,Ic4081b36
* changes:
Bug:553 - RPC providers are not cleaned up on bundle stop, causing bundle restart to fail
Bug:441-closing listener on stop of md-topologymaneger bundle
Tony Tkacik [Fri, 28 Mar 2014 16:14:47 +0000 (16:14 +0000)]
Merge "fixed IT after netty version bump"
Michal Rehak [Fri, 28 Mar 2014 15:01:45 +0000 (08:01 -0700)]
fixed IT after netty version bump
- we need access to sun.nio.ch
- netty is needed before protocol-framework
- netty bundles internal order changed
Change-Id: I2ac25af6a559d935a733d8d28f05d95539ddc00b
Signed-off-by: Michal Rehak <mirehak@cisco.com>
Robert Varga [Sat, 15 Feb 2014 02:39:22 +0000 (03:39 +0100)]
Fix IPluginInBridgeDomainConfigService API
IPluginInBridgeDomainConfigService protomoted Throwable into a
checked-exception status. This also includes Errors, which is not a good
thing, as Errors are not something we can handle gracefully.
Introduce a dedicated exception which implementations can use to report
instantiation problems.
Change-Id: Ib16d792acfcf77c68b92b35526ed7471e2172cbe
Signed-off-by: Robert Varga <rovarga@cisco.com>
Ed Warnicke [Fri, 28 Mar 2014 01:01:22 +0000 (01:01 +0000)]
Merge "Bug 500: DOMStore SPI"
Ed Warnicke [Fri, 28 Mar 2014 00:59:11 +0000 (00:59 +0000)]
Merge "Bug 500: Type capture for DOM and Binding APIs"
Ed Warnicke [Fri, 28 Mar 2014 00:57:35 +0000 (00:57 +0000)]
Merge "Bug 500: Updated data APIs with new concepts."
Andrew Kim [Thu, 27 Mar 2014 20:53:17 +0000 (15:53 -0500)]
Fix Enqueue Action in Flow UI
Enqueue flow action accepts port and queue is optional
Change-Id: I7e6330106ed54c0ef8c3c93ffee12ded1ddf4a04
Signed-off-by: Andrew Kim <andrekim@cisco.com>
Moiz Raja [Thu, 27 Mar 2014 18:59:23 +0000 (11:59 -0700)]
Remove getPort API from sal-port.yang
This API is not in use and it has not been properly modeled.
An RPC needs to have an input to be properly routed otherwise an exception will be thrown when registering.
Also see,
- Bug 596
- Gerrit https://git.opendaylight.org/gerrit/#/c/5781/
Change-Id: I28d517fe86ed63590fbd8fa17be712b581141869
Signed-off-by: Moiz Raja <moraja@cisco.com>
Moiz Raja [Thu, 20 Mar 2014 19:58:16 +0000 (12:58 -0700)]
Avoid nullpointer exception on starting up the TopologyProvider and the InventorReadAdapter
The TopologyProvider and InventoryAndReadAdapter are Felix services which get started when all it's
dependencies are resolved (that is their start method gets called). The MD-SAL DataProviderService is not
or cannot be injected into them and so when start is called and the dataProviderService is used it throws an NPE
To fix this I simply moved most of the startup code into a separate method which I then call from the ComponentActivator
instead of start
Change-Id: Ia6f0b6cebd38f4af7f03c9da8a5e26e05c13f664
Signed-off-by: Moiz Raja <moraja@cisco.com>
Andrew Kim [Thu, 27 Mar 2014 16:59:07 +0000 (16:59 +0000)]
Merge "Bug 141: Connection Manager special characters"
Robert Varga [Tue, 11 Mar 2014 18:20:00 +0000 (19:20 +0100)]
Bug 500: DOMStore SPI
This is the API which needs to be implemented by a single logical tree
store, such that it can be plugged into the in-memory datastore
prototype.
The prototype keeps one logical data store for each of operational and
configuration subtrees. A front-end (client-visible) transaction results
in two back-end (data store) transactions. State transitions between the
three are coordinated using three-phase-commit protocol (3PC), with the
frontend transaction acting as the coordinator and the backend
transactions acting as cohorts.
Change-Id: Idfce04553e7c36ae6a1bb8c8b2699ca78c458bb4
Signed-off-by: Tony Tkacik <ttkacik@cisco.com>
Signed-off-by: Robert Varga <rovarga@cisco.com>
Robert Varga [Wed, 12 Mar 2014 14:54:52 +0000 (15:54 +0100)]
Bug 500: Type capture for DOM and Binding APIs
This commit introduces the type captures of new interfaces introduced in
the preceding commit.
Change-Id: I8da8ecd0a0404e89ae20d0d85894fc9da59e9903
Signed-off-by: Tony Tkacik <ttkacik@cisco.com>
Signed-off-by: Robert Varga <rovarga@cisco.com>
Robert Varga [Tue, 11 Mar 2014 12:28:59 +0000 (13:28 +0100)]
Bug 500: Updated data APIs with new concepts.
- Logical Datastore Type idenfier
- Asynchronous Data Broker contracts - some data broker contracts
were synchronous which could misslead consumers of APIs
- New Transaction subtypes with support for Asynchronous reads
- read-only transaction
- write-only transaction
- read-write transaction
- Scoped Data Change Publisher - client code is able
to specify scope of changes and logical datastore
type on which it is listening.
Change-Id: I2367e7df633dd07b08550014bed7a35c3e88a7ba
Signed-off-by: Tony Tkacik <ttkacik@cisco.com>
Signed-off-by: Robert Varga <rovarga@cisco.com>
Ed Warnicke [Thu, 27 Mar 2014 16:09:12 +0000 (16:09 +0000)]
Merge "Added explicit revision date import of ietf-inet-types to opendaylight-statistics-type."
Robert Varga [Sun, 9 Mar 2014 13:57:41 +0000 (14:57 +0100)]
Bump netty.io to 4.0.17.Final
Change-Id: I0f8c3d6ec41561c9c85cba5f36119a0f1b635347
Signed-off-by: Robert Varga <rovarga@cisco.com>
Robert Varga [Tue, 25 Mar 2014 21:07:14 +0000 (22:07 +0100)]
Do not use InstanceIdentifier.builder()
Stop using the type-usafe identifier builder. This eradicates the
obvious places. The leftover now are just the BI connector.
Change-Id: Iff1d1fc58e638d02e08951dbddead067d3e746e1
Signed-off-by: Robert Varga <rovarga@cisco.com>
Chi-Vien Ly [Wed, 26 Mar 2014 21:25:39 +0000 (21:25 +0000)]
Merge "1. Delete TLS KeyStore password from system property so that it won't be shown by getprop command. 2. Add a default location for TLS KeyStore files when the arguments are not provided."
Kamal Rameshan [Wed, 26 Mar 2014 21:12:19 +0000 (14:12 -0700)]
Bug:553 - RPC providers are not cleaned up on bundle stop, causing bundle restart to fail
Change-Id: Id6b8ba01194d71d2eb7ea97ca70088dec8b29d6e
Signed-off-by: Kamal Rameshan <kramesha@cisco.com>
Kamal Rameshan [Thu, 20 Mar 2014 20:36:09 +0000 (13:36 -0700)]
Bug:441-closing listener on stop of md-topologymaneger bundle
Change-Id: Ic4081b36a557110f6daeb7a6fb8a3b39ee1be8b2
Signed-off-by: Kamal Rameshan <kramesha@cisco.com>
Andrew Kim [Tue, 25 Mar 2014 21:16:37 +0000 (16:16 -0500)]
Add Flow actions to UI
Flow UI now exposes only supported flow actions for particular network element
Change-Id: Ic7e251628192a48d47350d39ecf007df25cfeb37
Signed-off-by: Andrew Kim <andrekim@cisco.com>
Tomas Olvecky [Wed, 26 Mar 2014 09:11:26 +0000 (10:11 +0100)]
Resolve Bug:593. Persister should communicate via OSGi SR instead of TCP.
Config persister now pushes configuration to netconf service directly by
java calls instead of using TCP connection to localhost. This allows
removing netconf client dependency from config-netconf-connector and
removes confusion when running more than one ODL process with same
configuration.
Change-Id: I96426b0fd1fe7110a59111a2b563e7494ebb811b
Signed-off-by: Tomas Olvecky <tolvecky@cisco.com>