odlmicro scale tests

Signed-off-by: Venkatrangan Govindarajan <gvrangan@gmail.com>
Change-Id: I5132f2e1a794934e3877c20a320d9a91187ff094

Enable CRUD-RPC Test for odlmicro

Signed-off-by: Venkatrangan Govindarajan <gvrangan@gmail.com>
Change-Id: I19acadfe5c7994200f2f5e248fa05962e13075b9

Remove BGPCEP many peers test

The test fails intermitent in all the branches. Better skip until
someone spends the cycles to figure if this is a test or
a controller issue.

JIRA: BGPCEP-946

Change-Id: I1c5211c0655046c67faa655f35e9dc692c96a4d8
Signed-off-by: Luis Gomez <ecelgp@gmail.com>

Modifications for OF_Tunnels to support Aluminium release

Signed-off-by: Srinivas Rachakonda <srinivas.rachakonda@gmail.com>
Change-Id: Ieab937d11e1e0d489b4078097a20c4a4702874aa

Fix variable names consistency in DnbCommons.robot

Signed-off-by: Martin Balaz <martin.balaz@pantheon.tech>
Change-Id: Ice47186a2ecc51ec65147a2480f44ce7cdf4d3f7

change DOMNotificationBroker wait timeout to incorporate check period time

Signed-off-by: Martin Balaz <martin.balaz@pantheon.tech>
Change-Id: I7e4dc959883da5cf5a4afc1df330933a8f33f4cb

Exclude long time failing test

JIRA: OVSDB-413

Change-Id: I7b070b817abbe18bc3f4019f6d85ceb4b387d6d1
Signed-off-by: Luis Gomez <ecelgp@gmail.com>

Reduce output.xml size

Other longevity tests may need a similar fix.

Signed-off-by: Vratko Polak <vrpolak@cisco.com>
Change-Id: Ie033532a542cbb203fb4a93afb75a98bbc8f218d

Stabilize netconf callhome test

Change-Id: I49524d04d28ec0b483c432ec8f83cf240c2a447a
Signed-off-by: Luis Gomez <ecelgp@gmail.com>

Add INFO.yaml for integration/test

Signed-off-by: Anil Belur <abelur@linuxfoundation.org>
Change-Id: I1e510ac9dc35193d692188595b2842e095fd8b28

Initial tests for odlmicro netconf functionality

JIRA: ODLMICRO-32
Signed-off-by: Bhuvana Vignesh <bhuvanmailid@gmail.com>
Change-Id: Ib103551d4468f33ce180706f751028c110f7c286

Verify PCEP sessions from multiple machines

JIRA: INTTEST-121
Signed-off-by: BhuvanaVignesh <bvignesh@luminanetworks.com>
Change-Id: I3d030782ab5c4dd9b7e96de32a0609bdb908bb10

Controller component should be MRI

carpeople component is MRI from Aluminium onwards.

JIRA: INTTEST-119

Change-Id: I81e4c2d74dc5f7ce34a72d616ca02d1a708fc9dc
Signed-off-by: Luis Gomez <ecelgp@gmail.com>

Fix tox errors

It seems some updates in linters/pre-commit steps is
now catching more errors. This is just a patch accepting
all the automatic fixes from running them locally.

Signed-off-by: Jamo Luhrsen <jluhrsen@gmail.com>
Change-Id: I762637f6890eeedd2dde1e1406a6cfb65c2ff26f

Adjust PCEP module names

The names of the modules have shifted, hence we need to update the
test suite to take that into account.

magnesium/ folder contains the pre-existing files and
sodium/ is just a symlink to it. aluminium/ folder will
have the new formats and eventually when magnesium and
sodium age out we can revert the .robot changes in this
patch pointing to a ${STREAM} folder and flatten these
updated files back down to a single folder.

JIRA: BGPCEP-882
Change-Id: I4e217370f4ad908c557da852d864d458035b2586
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

GENIUS-130: OF Tunnels support For ITM Direct Tunnels (of-tunnels)

Genius already supports creation of OF-tunnels through interface-manager.
With itm-direct-tunnels, interface-manager is by-passed for all
internal tunnel operations, and in such scenarios, OF tunnels are
not currently supported. This feature adds support for flow based
tunnels on top of itm-direct-tunnels for better scalability.

Specification Gerrit : https://git.opendaylight.org/gerrit/#/c/71659/

Gerrits Topic : https://git.opendaylight.org/gerrit/#/q/topic:of-tunnels+(status:open+OR+status:merged)

Change-Id: I32c9f1796b86670263574748bb937d9f18869b58
Signed-off-by: Karthika Panneer <r.p.karthika@ericsson.com>

BGP session with LLGR capability for unsupported safi

   - A library for gobgp tool is added
   - Test case for validating BGP Session with LLGR
   - For an unsupported safi

JIRA : BGPCEP-893

Signed-off-by: pdathathraya <pdathathraya@luminanetworks.com>
Change-Id: I57cfc0ade08f37f85f5bbdb0ca7093012ac0f500

Add RESTCONF RFC8040 SSE test

The new test is executed when using RFC8040. And it is available
in Aluminium onwards.

Change-Id: Iaf74ff1d119a93d8c87227e9fc0a9c25c1fd7a04
Signed-off-by: Luis Gomez <ecelgp@gmail.com>

Convert SFC checks from python2 to python3

resp.content breaks with "should contain" style KWs.
resp.text is the way forward with that.

Signed-off-by: Jamo Luhrsen <jluhrsen@gmail.com>
Change-Id: Ia0212b48b0c531e38c18dafcde8d7eeea7065049

Add silicon to release dict

Change-Id: If50e0a5fa8f73bfe7e2f8ca1215b13502d5babea
Signed-off-by: Luis Gomez <ecelgp@gmail.com>

Setup python-black for opinionated linting

Black will automatically format code for Python 3.

Change-Id: I55d5042412f9ba275ec8e65301a21db1d4209d84
Signed-off-by: Thanh Ha <zxiiro@gmail.com>

Auto-generated patch by python-black

Refer to the next patch in the list before merging this one. This
also removes autopep8 in prep for python-black as both these tools
conflict with each other.

Change-Id: I8adbeea0d42827e9dc341b023e79da2ce389d491
Signed-off-by: Thanh Ha <zxiiro@gmail.com>

Adding new PCC delegation test cases

 - This patch contains the test case which revoke the pcc delegation in LSP updates

JIRA: INTTEST-120
Signed-off-by: BhuvanaVignesh <bvignesh@luminanetworks.com>
Change-Id: I16eb170586d6e7e1eb7736a4e09ed01a9c68570a

Test with AS Number configured more than 65535

JIRA : INTTEST-122

Signed-off-by: pdathathraya <pdathathraya@luminanetworks.com>
Change-Id: I33b3f6acfdfdcf3127f08940ab57a19c7a69170e

Disable SSE notifications

By default in Aluminium, SSE (Server Side Events) are enabled
and websocket notfications are disabled. The existing CSIT
test cases expect websocket notifications to work. For now
we need to disable SSE to allow the test cases to pass with
websockets.

This will be a NOOP for Mg and Na, although the controller
restart is a small waste of time (~2min).

In the future, tests cases for SSE will be written and doing
this config change and restart in the suite setup will
probably not make sense.

JIRA: INTTEST-107

Signed-off-by: Lukas Baca <lbaca@luminanetworks.com>
Change-Id: I0dc87e2731927c2ec61c683d1a2f238e2b03e8d0
Signed-off-by: Lukas Baca <lbaca@luminanetworks.com>

Restore OFP cluster suites original order

Change-Id: I7ef0d9ef06e842aeb50fcb353aa1f685b34a9606
Signed-off-by: Luis Gomez <ecelgp@gmail.com>

increase ping packet count

Signed-off-by: Srinivas Rachakonda <srinivas.rachakonda@gmail.com>
Change-Id: I02d265ff89be5eed2d301053f8b8ab87d86226d8

Python3 Fixes in Genius

Signed-off-by: Srinivas Rachakonda <srinivas.rachakonda@gmail.com>
Change-Id: I0f87a7f95293dd49652d19af2a99f924d5d50832

Additional Tests related to the address families

JIRA: BGPCEP-910
Change-Id: Idd36f6643374466ace0bbc11cafa4c54e6a8c477

Signed-off-by: PoojaDathathraya <pdathathraya@luminanetworks.com>
Change-Id: If5ebdc0814e27ab9f6084eeb2eeae3d046e8333e
Signed-off-by: pdathathraya <pdathathraya@luminanetworks.com>

Support for cirros-0.4.0 password

The password for cirros-0.4.0-x86_64-disk.img (and higher
cirros version images) is gocubsgo.
OpenstackOperation.robot takes cirros as username and
password as cubswin:).
So there is need to add two more arguments user=cirros and
password=gocubsgo.

The default passowrd will be changed in all library files once
we move to Openstack Stein on wards.

Signed-off-by: Srinivas Rachakonda <srinivas.rachakonda@gmail.com>
Change-Id: I92ac6c79caedc465412363d890d6e7c0c639d025

NETVIRT-1695 - Remove Association/Disaccociation IPv6 TCs.

Direct Association of IPv6 subnet to VPN id is not supported.
So removing the TCs related to it.

Signed-off-by: Srinivas Rachakonda <srinivas.rachakonda@gmail.com>
Change-Id: I0fddf6fc777d24256267e06b68d0a0a6d9a8eff6

Support for cirros-0.4.0 password

The password for cirros-0.4.0-x86_64-disk.img (and higher
cirros version images) is gocubsgo.
OpenstackOperation.robot takes cirros as username and
password as cubswin:).
So there is need to add two more arguments user=cirros and
password=gocubsgo.

The default passowrd will be changed in all library files once
we move to Openstack Stein on wards.

Signed-off-by: Srinivas Rachakonda <srinivas.rachakonda@gmail.com>
Change-Id: If55349f79304a2bf5ee688f33a0c8f5926f31b85

Additional Test for varying afi-safis

JIRA: BGPCEP-906
Signed-off-by: PoojaDathathraya <pdathathraya@luminanetworks.com>
Change-Id: I5c85b04faa77afc3b8fe5ef869d37b069c537bb1

Improve netconf max devices test logic

- there was some race condition where issuing a GET
(using the python getter.py tool) was not able to
get a 200 from every device initially after they
were all reported mounted. running the getter.py
tool once seems to resolve this and running it a
second time to do the actual checks for 200 on each
mounted device.

- also bumped the timeout factor from 2 to 3 since
I saw the larger iterations (750) hitting the timeout
once.

JIRA: NETCONF-711

Signed-off-by: Jamo Luhrsen <jluhrsen@gmail.com>
Change-Id: Iab274d89c44cc0a56bb4959e4ec67a0eaa345873

Correcting Get Value from JSON

Signed-off-by: Srinivas Rachakonda <srinivas.rachakonda@gmail.com>
Change-Id: Iff74a4a70536b4c233bdf2d2b8c014c8c724eafd
Signed-off-by: Srinivas Rachakonda <srinivas.rachakonda@gmail.com>

INTTEST-107: Add test cases to cover rpc augmentation action

Change-Id: I8c9b32aea038d7f7e2003dc0171bc36da4f85cc9
Signed-off-by: Kailash Khalasi <kailash.khalasi@gmail.com>

python3 changes in openstack scripts

Signed-off-by: Srinivas Rachakonda <srinivas.rachakonda@gmail.com>
Change-Id: I2bd8d821f3967f40f031d379bc2642d9d694a7fb

Increase timeout for apidocs URI to 90s

It seems that 60s might not be long enough in all cases as we
see this test fail sometimes. Let's try 90s to see if it helps.

Signed-off-by: Jamo Luhrsen <jluhrsen@gmail.com>
Change-Id: Id3eb7547dd4be8bac6d3a96ad384d950614a55e8

Fix BGPCEP ingest test

Python3 floor division is //

Change-Id: Id4a730a6464234f5f902069f5d684435ae2a9426
Signed-off-by: Luis Gomez <ecelgp@gmail.com>

Fix robot syntax with robot.tidy tool

- have to skip .robot files with the trailing-whitespace hook because
it will remove the blank line at the end of a file whereas robot tidy
will add one which causes a failure

This change is coming from using the latest RF and
robotframework-tidy-wrapper.

Signed-off-by: Jamo Luhrsen <jluhrsen@gmail.com>
Change-Id: I7ad30196d4ad3641901578614e3b417e4772498d

Move robot-tidy precommit back to master

Signed-off-by: Jamo Luhrsen <jluhrsen@gmail.com>
Change-Id: I1e58cdb94da31e98614561f2c00d4473aaae4622

Remove neon version of netconf testplans

neon is no longer maintained, so remove the files
specific to that.

Signed-off-by: Jamo Luhrsen <jluhrsen@gmail.com>
Change-Id: I65cce28bd05ecb3d26d1b5010a0f40df15ad5806

Tests for BGPCEP-901

- This patch have the flapping pcc sessions test cases and modified as to run 1+ more pcc sessions

JIRA: BGPCEP-901
Signed-off-by: BhuvanaVignesh <bvignesh@luminanetworks.com>
Change-Id: Ifb73a165244ddb7fbbd77327479edf0331af774f

Add gate testplan for rfc8040 job

Signed-off-by: Jamo Luhrsen <jluhrsen@gmail.com>
Change-Id: I0da8aed19459dca15f376acc66969970f475bafd

Fix python3 issues in OVSDB

Signed-off-by: Srinivas Rachakonda <srinivas.rachakonda@gmail.com>
Change-Id: I57bcf759f96c2d7d47ffd9acc9e21599d58c2c36

Add schemas with rpc action in augmentation

INTTEST-107
Change-Id: I4b7a1f96f2a947c30867eac10ce5cea4ab88c4f8
Signed-off-by: Kailash Khalasi <kailash.khalasi@gmail.com>

INTTEST-83: Add testcase for restconf notification stream

Change-Id: Ifa68dd65afd17a97d4f85025e321cf3771d0493b
Signed-off-by: Kailash Khalasi <kailash.khalasi@gmail.com>

Fix python3 issues in Netvirt

Also removed VTN library files

Signed-off-by: Srinivas Rachakonda <srinivas.rachakonda@gmail.com>
Change-Id: Ifcfbc76cc5c308f0e7126ac5b494c7e80ca64a18

INTTEST-91 - Updating list and dictionary syntax

Accessing list and dictionary items
using @{var}[item] and &{var}[item] is deprecated
from robotframework 3.2b1

https://github.com/robotframework/robotframework/blob/master/doc/releasenotes/rf-3.2b1.rst#accessing-list-and-dictionary-items-using-varitem-and-varitem-is-deprecated

Signed-off-by: Srinivas Rachakonda <srinivas.rachakonda@gmail.com>
Change-Id: Ic2e9bc0b7edc150c003171022da987b61bd9999f

Fix python3 cluster suites

Change-Id: I63d4d7906cbfc81804a2e10793e04109ddf65531
Signed-off-by: Luis Gomez <ecelgp@gmail.com>

Resolve E722 do not use bare except

Bare exceptions violates one of Pythons idioms that bare exceptions
should not be used. The reason for this is that a bare except catches
all exceptions and can make programming errors look like runtime
problems making debugging more difficult.

Change-Id: I7006639302ef2efc9301c384c19218dd6783c825
Ref: https://docs.python.org/3.1/howto/doanddont.html#except
Signed-off-by: Thanh Ha <zxiiro@gmail.com>

Print git-diff when pre-commit fails

When pre-commit fails and automatically fixes issues for us in Jenkins
we are not able to see what pre-commit automatically fixed. Adding
--show-diff-on-failure makes pre-commit perform a git-diff immediately
after failing to ensure more useful output is printed to inform the
contributor what changes are needed to pass the check.

Change-Id: I7d97b823e401bb737564a3936afa08085dcb6975
Signed-off-by: Thanh Ha <zxiiro@gmail.com>

Make GitLint actually run as part of pre-commit

The tox environment for pre-commit currently does not actually run
the gitlint hook.

Change-Id: Ia22d2d1fed8aed3689690e3f51e06905f409f82e
Signed-off-by: Thanh Ha <zxiiro@gmail.com>

Fix formatting for .pre-commit-config.yaml

File should start with `repos:` as the root level. Without this things
appear to still work anyway but we should probably have the right
formatting.

Change-Id: I437ae2b0164b85125fdeb323d27f025861da9f6b
Signed-off-by: Thanh Ha <zxiiro@gmail.com>

Restore forked ipaddr library

Change-Id: Ibdcb3c963fceeac5cd304c956d8d589aa0033912
Signed-off-by: Luis Gomez <ecelgp@gmail.com>

Increase HTTP timeout for apidocs test

Change-Id: I180d1f34b5458326ad60161c60e9c51c43ae36d0
Signed-off-by: Luis Gomez <ecelgp@gmail.com>

Install ipaddr module in Tools VM

The ipaddr.py was removed in an earlier merged patch, causing
the tests to fail. This patch uses pip to install ipaddr to TOOLS VM.

JIRA: INTTEST-105
Signed-off-by: Venkatrangan Govindarajan <vgovindarajan@luminanetworks.com>
Change-Id: Id0dcfa0b59f1326baa3a0999ac0a7647dc26a0fa

INTTEST-88: Check namespace in response header

Change-Id: Ib23bbd813c29a47a28b2d5629c9238727d39df54
Signed-off-by: Kailash Khalasi <kailash.khalasi@gmail.com>

Fix python3 issues in OFP 2

JIRA: INTTEST-105

Change-Id: I35d00e8a98df9ad1763e9de16da7915d17ef18cd
Signed-off-by: Luis Gomez <ecelgp@gmail.com>

Fix python3 issues in OFP

JIRA: INTTEST-105

Change-Id: I70deb287014630d21dbc6842678edef21d5690b7
Signed-off-by: Luis Gomez <ecelgp@gmail.com>

Fix for Genius Tests

JIRA: INTTEST-105
Signed-off-by: Venkatrangan Govindarajan <vgovindarajan@luminanetworks.com>
Change-Id: I10e536d74518605c79326509b4245ae4cc87c8e4

Remove HTTP library

The library is old, does not work with python3. I also
do not see where it is even used in the TSDR keywords
so might have been a copy/paste relic anyway.

Signed-off-by: Jamo Luhrsen <jluhrsen@gmail.com>
Change-Id: I6e19ebfb5e07890b5090e7ce184196578bad7c2f

Remove HTTP library

The library is old and does not work with python3. It appears
that the *** Settings *** section in the affected files may
have just been copy/paste from the same source and likely the
library is not used. It's possible that some tests would break
if the library was being used. In that case, things will have
to be ported to the more commonly used RequetsLibrary keywords.

Signed-off-by: Jamo Luhrsen <jluhrsen@gmail.com>
Change-Id: I55e5d02818b0f2bfaf106cb26ecf43df9791c6e3

Remove NIC related test files

The NIC project has long since been archived as a project
and no longer active or part of OpenDaylight. So, remove
these files.

JIRA: INTTEST-105
Signed-off-by: Jamo Luhrsen <jluhrsen@gmail.com>
Change-Id: I3884a5744bca2ef48db92262a6089d1bd46159a2

Remove token auth suite and it's testplan

Neon is no longer supported or tested and was the
last release that had token authentication. So,
remove the relevant resources.

Signed-off-by: Jamo Luhrsen <jluhrsen@gmail.com>
Change-Id: I324f3de5ce83b6b6ff9ce437bf604e772c448cdd

resp.content->resp.text in Should Contain

The new python3 upgrade breaks our old checks for
Should Contain when using ${resp.content}. The
erorr is:

TypeError: a bytes-like object is required, not 'str'

There will probably be lots of places to fix this.

JIRA: INTTEST-105
Signed-off-by: Jamo Luhrsen <jluhrsen@gmail.com>
Change-Id: I14726cef95e2d2e7355d6974eacb4646566aa7a5

Fix BGPCEP test for 409 code and isolate failures

Some tests fail because exabgp route-refresh capability but this
capability is only required in the route-refresh test, so this
patch disables this capability if not required.

Change-Id: I834f3edfb2a0a757ea2f4c4786dbd5161c1db143
Signed-off-by: Luis Gomez <ecelgp@gmail.com>

Migrate Tests/Scripts to Python3

- Used 2to3 to migrate scripts to python3
- Fixed some issues due to robot 3.2.1

JIRA: INTTEST-105
Signed-off-by: Venkatrangan Govindarajan <vgovindarajan@luminanetworks.com>
Change-Id: I1028a2090ae616b192119d0eff8d27c7f95bfddd

Adjust apidocs URL for Aluminium

Change-Id: I861ed4028a53274b4fa9a73bb8abb48b2717988e
Signed-off-by: Luis Gomez <ecelgp@gmail.com>

Fix cluster suite for 409 code change

JIRA: INTTEST-102

Change-Id: Ibae69a260fc11dbc91a3b71df180ea49567b6052
Signed-off-by: Luis Gomez <ecelgp@gmail.com>

Use wildcard *journal

In Aluminium the journal/ folder is now named segmented-journal/
Using a wildcard in the tests should let it work for all branches

this was partially done already with:
https://git.opendaylight.org/gerrit/c/integration/test/+/88658

Signed-off-by: Jamo Luhrsen <jamoluhrsen@ip-192-168-86-41.us-west-1.compute.internal>
Change-Id: I4cf26da11e388c986ab5343ca1ad93d0beb352f7

Revert "Remove robot-tidy from pre-commit"

Pin to a specific hash ID instead of 'master' to workaround failure
due to:

    "error: pathspec 'master' did not match any file(s) known to git."

Not sure why this is suddenly failing with this repo but using a
specific commit hash instead appears to resolve the issue.

This also changes the clone URL from git:// to https:// to match the
other repos in this file.

This reverts commit c300e14ebc35e94f62ebc2056fad7da81a54ab40.

JIRA: RELENG-149
Change-Id: I42a1ef3e8c347820a5a482b1b530616de75cfc27
Signed-off-by: Thanh Ha <zxiiro@gmail.com>

Use DELETED_STATUS_CODES instead of 404

data-missing will now give 409 in Aluminium and beyond
by default so we can look for both 404 and 409 which is
in DELETED_STATUS_CODES

JIRA: INTTEST-102
Signed-off-by: Jamo Luhrsen <jluhrsen@gmail.com>
Change-Id: I6f979e3a46b5121f8c98db1511e734c400a70f90

Convert Python boolean to properly-encoded boolean

'True' and 'False' are not valid values for boolean where either
XML (RFC6020/RFC7950) or JSON (RFC7951) encoding is concerned. Fix
this up by explicitly converting booleans.

JIRA: INTTEST-101
Change-Id: Iefbce681e8df3f1ca7701cd89da8b3d7c00a8b1d
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Remove robot-tidy from pre-commit

Nothing wrong with the hook or the repo, but something
has changed recently with pre-commit or some dependency
that causes it to break. More details in:

JIRA: RELENG-149

Signed-off-by: Jamo Luhrsen <jluhrsen@gmail.com>
Change-Id: I43bba25e27e195224aee4e2763d2259899da8346

NETVIRT-1599 Add support for group-add-mod-enabled param

We have a flag group-add-mod-enabled in /etc/opendaylight/
datastore/initial/config/default-openflow-connection-config.xml
which needs to be enabled for upgrade scripts. Once we wipe ODL
data and then connect back the switch, this flag will enable the
ONFT_BUNDLE_ADD_MESSAGE to be accepted by the openvswitch.

Change-Id: Ie952d5ca5280fbe750495cd34dfbc065bc9c3e2f
Signed-off-by: Srinivas Rachakonda <srinivas.rachakonda@gmail.com>

Use correct kw when checking empty DS in netconf library

Change-Id: I488168ef77f7ffd8ca73489c1093b01bbe309279
Signed-off-by: Kailash Khalasi <kailash.khalasi@gmail.com>

Fix robot bug in Should_Contain assertion

Change-Id: I4f2f8b70cb63f4d09fa2c5466dad1d6371d67909
Signed-off-by: Kailash Khalasi <kailash.khalasi@gmail.com>

Use ${DELETED_STATUS_CODES} instead of hard-coded value

Change-Id: I5c992a1bb128fd1044cb2449052f85aef8555491
Signed-off-by: Kailash Khalasi <kailash.khalasi@gmail.com>

Fix typo in lisp test

Change-Id: I57111a228050a9e5756444e8537d75ee5111335b
Signed-off-by: Luis Gomez <ecelgp@gmail.com>

Allow 409 code when DS is empty

Change-Id: Ib4fc3a58fadc147623091daae8f99b5604e430e2
Signed-off-by: Luis Gomez <ecelgp@gmail.com>

Increase OF stats polling period in scale test

Change-Id: I013986e4660f84b72f95e321ea0b51db05ff9246
Signed-off-by: Luis Gomez <ecelgp@gmail.com>

Mininet clean command to use "Execute Command" vs "Write"

"EC" executes and waits until complete. "Write" requires a "read until"

Signed-off-by: Kailash Khalasi <kailash.khalasi@gmail.com>
Change-Id: Id417f4bf6afa1dcdc89dcfac13357e0830691a4e

Use correct system prompt variable for tools system vm in test suites

Signed-off-by: Kailash Khalasi <kailash.khalasi@gmail.com>
Change-Id: I4490e27cc05c1f4c59ec53981361772a2ba7cca1

Use correct system default prompt for start/stop mininet

Change-Id: I872c9dec3de76de5e5c62508b013cd7102c1513c
Signed-off-by: Kailash Khalasi <kailash.khalasi@gmail.com>

Add missing WUKS in genius CSIT

Change-Id: Ia79c8d50d34133fc90b499d79451045b662e43b9
Signed-off-by: Luis Gomez <ecelgp@gmail.com>

checking vm state before grep

Signed-off-by: Srinivas Rachakonda <srinivas.rachakonda@gmail.com>
Change-Id: I99243f2dc52c0c9f2f4c3a71b854dc5036e84fc6

remove default_java_options kw usage

It was used before when we had java 7 to worry about, but
that is long since gone. The keyword was removed in
https://git.opendaylight.org/gerrit/c/integration/test/+/88656

Signed-off-by: Jamo Luhrsen <jluhrsen@gmail.com>
Change-Id: I7813d294dbea66a5a2807974e4f27193b8867568

Add venv/ to .gitignore

some IDE/environments commonly create virtual environments by default
at the base of the repo. We don't want to worry about those.

Signed-off-by: Jamo Luhrsen <jluhrsen@gmail.com>
Change-Id: I20e7c1a34404541265c6928182d987e5ae7d0065

Alphabetize .gitignore

Signed-off-by: Jamo Luhrsen <jluhrsen@gmail.com>
Change-Id: Ibe8e49156aa63de6d0a1a7e6c6fb10f6996ebd31

Bring yang-model-validator suite/lib up to date

- using new version of the yang model repos to run the
  tool against.
- removed all files/paths for models that will fail
  validation. Each file removed was seen to have
  failed for what looked like valid reasons with
  a few exceptions which will be opened as bugs
  against yangtools to double check the results.
- moved keywords to the main test case to prevent the
  need for SUITE variables. This resulted in the loss
  of a full test case which was not really a test
  case and only collecting a log file when a failure
  happens.
- added more docs to hopefully help the next
  maintainer that works on this suite.
- modified docs to reflect the new state of this suite

JIRA: INTTEST-80
Change-Id: I08815cd10de7ad97745688d50c7f8ed37f9aebbd
Signed-off-by: Jamo Luhrsen <jluhrsen@gmail.com>

Use proper yang testtool version

Code was sticking the testtool version to something really old and not
letting the EXPLICIT_YANG_SYSTEM_TEST_URL ever be empty, which is
needed in order to dynamically find the right version of the tool
for the actual branch being tested.

JIRA: INTTEST-78
Signed-off-by: Jamo Luhrsen <jluhrsen@gmail.com>
Change-Id: I62fa8e5276a1306d510c78ac71888449fc9ea54c
Signed-off-by: Jamo Luhrsen <jluhrsen@gmail.com>

Remove java 7 leftover code

java 7 is long since dead with ODL CSIT so cleaning up

Signed-off-by: Jamo Luhrsen <jluhrsen@gmail.com>
Change-Id: I860e75556b29bd18313e597fa93eb4864bd388c3

Combine common keywords and fix argument issue

https://git.opendaylight.org/gerrit/c/integration/test/+/88446
broke the getsingle.robot suite because it was duplicating some
work that should be common. So combined the duplication between
it and max_devices in to the netconfkeywords lib. getmulti.robot
is also sharing keywords now.

Also add back 300s timeout for Wait_Connected keyword that was
migrated to NetconfKeywords.robot lib in parallel with the
review/merge of https://git.opendaylight.org/gerrit/c/integration/test/+/88662

Signed-off-by: Jamo Luhrsen <jluhrsen@gmail.com>
Change-Id: I063b6e13cdbafff778186043a2250da284365091
Signed-off-by: Jamo Luhrsen <jluhrsen@gmail.com>

Increase connection wait time to 5m

Sodium takes longer for that initial schema compilation and
now that we are using a large juniper based schema, 2m is
not long enough. In the worst case scenario where it would
never connect, then 5m is the max as the first device would
fail and the rest of the test will bail.

Signed-off-by: Jamo Luhrsen <jluhrsen@gmail.com>
Change-Id: I1e57bd7301b3c5f44d267489a1f8ce1c5e64531f
Signed-off-by: Jamo Luhrsen <jluhrsen@gmail.com>

Upgrade to python3 for pre-commit flake config

Signed-off-by: Jamo Luhrsen <jluhrsen@gmail.com>
Change-Id: Ieed91c45a5db9586e18551752507b58940aba0dd

Fix Flake8 errors

flake8 now running with python3 was turning up a lot of
errors about print statements. This fixes some of those
errors, and seems to be enough to get flake8 passing
again.

Signed-off-by: Jamo Luhrsen <jluhrsen@gmail.com>
Change-Id: Ie02f5266391702e425147b2981aad4bb828bdb0a
Signed-off-by: Jamo Luhrsen <jluhrsen@gmail.com>

Fix broken glob inside quotes

Signed-off-by: Jamo Luhrsen <jluhrsen@gmail.com>
Change-Id: I72a959d8735d3eae059d2403fedc62fc10b05b74

Enable rfc8040 requests for notification suite

also improves restconf lib to allow for rpc operations in
addition to config and operational paths

Change-Id: Ied029ef3f5d15b09aa54de7b2dd443633e567d57
Signed-off-by: Jamo Luhrsen <jluhrsen@gmail.com>

Also transfer segmented-journal directory

When using segmented-journal persistence plugin, we need to move
not 'journal' but 'segmented-journal'. Update the test suite to handle
both cases.

JIRA: CONTROLLER-1411
Change-Id: I1d05692280ae2f0437e1edb969bdf956fdd7edb3
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>