Ryan Goulding [Thu, 28 Jul 2016 16:02:51 +0000 (12:02 -0400)]
Bug 6278: Switch to use odlparent's karaf-parent
Change-Id: I0781e8ae2b14af68e32d3048fe17370cca276425
Signed-off-by: Ryan Goulding <ryandgoulding@gmail.com>
vinoth [Wed, 22 Jun 2016 13:47:20 +0000 (19:17 +0530)]
BUG-6136 - Southbound plugin throws IllegalStateException when add bridge config via POST.
* Checking isPresent() while reading a OvsdbBridgeAugumentation value.
Change-Id: I1ac53efca678c9e40f46f5e86595b0c1d9e8bc62
Signed-off-by: vinoth <m.vinoth@hcl.com>
Sam Hague [Sat, 23 Jul 2016 19:26:23 +0000 (19:26 +0000)]
Merge "Checkstyle fixes (to be enforced)"
Sam Hague [Sat, 23 Jul 2016 13:58:13 +0000 (13:58 +0000)]
Merge "Add support for setting the db schema version"
Sam Hague [Fri, 22 Jul 2016 01:38:49 +0000 (21:38 -0400)]
Add support for setting the db schema version
The db schema was a field in the ovsdb.yang but it was never copied
from the ovsdb to mdsal.
Also removed IT test code that was getting the schema version
via connecting to the ovsdb nodes.
Change-Id: Id7a49f9832c27eec746aeff9d190e9295dbd3244
Signed-off-by: Sam Hague <shague@redhat.com>
Michael Vorburger [Fri, 22 Jul 2016 21:05:19 +0000 (23:05 +0200)]
Checkstyle fixes (to be enforced)
preparing for https://git.opendaylight.org/gerrit/#/c/41305/ with:
* Utility classes should have private constructor
* potential future problems re. hidden fields
* inner assignments
Change-Id: I616414ed56e468910167a790b5e67a6807600f37
Signed-off-by: Michael Vorburger <vorburger@redhat.com>
Sam Hague [Fri, 22 Jul 2016 19:28:49 +0000 (15:28 -0400)]
Fixes for HwvtepSouthboundIT to run
Change-Id: I12adb6221e18fd5d80c9b053c4f03b7d1d79b730
Signed-off-by: Sam Hague <shague@redhat.com>
Sam Hague [Fri, 22 Jul 2016 16:56:54 +0000 (12:56 -0400)]
Checkstyle fixes for ovsdb test dirs
Change-Id: I96d5843f9b26463f89e54992aea34b2438b571d4
Signed-off-by: Sam Hague <shague@redhat.com>
Michael Vorburger [Thu, 21 Jul 2016 16:08:28 +0000 (18:08 +0200)]
Fix more Sonar (soon Checkstyle) constant name
Change-Id: I503e402c80d57c946805385ac542b992eed1cf8a
Signed-off-by: Michael Vorburger <vorburger@redhat.com>
Anil Vishnoi [Tue, 19 Jul 2016 19:43:56 +0000 (12:43 -0700)]
Bug 6185 - southbound system tests failing when
run with all other compatible OpenDaylight features.
This patch fixes following issues related to library
connection handling
*.* If any non-ovsdb device (e.g. openflow) sends a
connection request to ovsdb, library does not throw
error message, rather it holds the channel and wait
for timeout.
*.* In the above case, it also publishes the connect/disconnect
notification up to the plugin.
*.* HwvtepConnectionInstance and OvsdbConnectionInstance
is implementing OvsdbClient interface from library, that
is not required. Echo service should be done by the library
and not by the plugin logic code.
*.* RPC Future objects were not cleaned by library,
and that's leaking the memory.
*.* In case of no echo response, library dosn't fail
the respective rpc future object.
Change-Id: If7b26594b057465d0c08638857bdcb76857705e1
Signed-off-by: Anil Vishnoi <vishnoianil@gmail.com>
Michael Vorburger [Mon, 4 Jul 2016 12:26:09 +0000 (14:26 +0200)]
Checkstyle enforcement for library
Following relaxation of rule in odl-parent to have JavaDoc not even
enforced on annotation types
Change-Id: I05b27d56062b7d57928eb2f04eb538cdbf482e72
Signed-off-by: Michael Vorburger <vorburger@redhat.com>
Sam Hague [Tue, 19 Jul 2016 21:21:50 +0000 (17:21 -0400)]
Reduce IT logging
Change-Id: Ic86cca7fcd8bfa9829041dd3abd37fa276cde44f
Signed-off-by: Sam Hague <shague@redhat.com>
Anil Vishnoi [Tue, 19 Jul 2016 15:19:11 +0000 (15:19 +0000)]
Merge "checkstyle fixes for library"
Robert Varga [Mon, 18 Jul 2016 14:23:03 +0000 (16:23 +0200)]
Use StandardCharsets instead of Guava
Use of Guava's Charsets for recent Java versions is deprecated.
Change-Id: Iefdaca294dbbcfbcd0a9b97074dd4612f348cfa7
Signed-off-by: Robert Varga <rovarga@cisco.com>
Sam Hague [Sun, 17 Jul 2016 19:58:03 +0000 (15:58 -0400)]
checkstyle fixes for library
Change-Id: If68706ed7cf2bb2c605f4e2b3894c273f57643d3
Signed-off-by: Sam Hague <shague@redhat.com>
Sam Hague [Mon, 18 Jul 2016 12:10:43 +0000 (12:10 +0000)]
Merge "Add methods to SouthboundUtils for ElanService"
Oded Shvartz [Mon, 18 Jul 2016 09:10:57 +0000 (12:10 +0300)]
Fix docker compose ps command
Changed docker-compose ps command to use -f <yamlFile>.
This change is necessary after moving the docker-compose.yml file
on the netvirt project to resources folder.
Change-Id: Ibdfde4180519341ada5b105096f85cd2be77964b
Signed-off-by: Oded Shvartz <oshvartz@redhat.com>
Josh [Mon, 18 Jul 2016 07:43:53 +0000 (09:43 +0200)]
Add methods to SouthboundUtils for ElanService
Methods are required for creating bridges, etc,
for external physical networks. See:
https://git.opendaylight.org/gerrit/#/c/41925/
Change-Id: I707e8fc5298890a886352dcc90a86159b9f3236c
Signed-off-by: Josh <jhershbe@redhat.com>
Josh [Sun, 17 Jul 2016 14:53:27 +0000 (16:53 +0200)]
Fix IT failure when not running DockerOvs docker
Change-Id: If94a12f0ace958609bf135aa639128423a513228
Signed-off-by: Josh <jhershbe@redhat.com>
ananthip [Mon, 11 Jul 2016 13:49:10 +0000 (09:49 -0400)]
Bug 5938 - Updated the logging
Change-Id: I429f71d27ca751b5a53808defca98a1bbb983977
Signed-off-by: ananthip <ananthip@hcl.com>
Thanh Ha [Wed, 13 Jul 2016 16:49:49 +0000 (16:49 +0000)]
Merge "Upgrade ietf-{inet,yang}-types to 2013-07-15"
Anil Vishnoi [Mon, 11 Jul 2016 22:42:55 +0000 (15:42 -0700)]
Fixed check-style error caused by odl parents check-style patch
Odl parent merged following patch to enable check-style for
generic exception:
https://git.opendaylight.org/gerrit/#/c/41304/
That broke OVSDB because OVSDB project has check-style enabled locally
Change-Id: I2c1a8b162fb79e033b4c833f1f12cb402477cb0e
Signed-off-by: Anil Vishnoi <vishnoianil@gmail.com>
Lorand Jakab [Thu, 23 Jun 2016 23:07:50 +0000 (18:07 -0500)]
Upgrade ietf-{inet,yang}-types to 2013-07-15
Change-Id: I2a8143ec58e9c2b174fe532d7d65e8f198f3ea78
Signed-off-by: Lorand Jakab <lojakab@cisco.com>
Anil Vishnoi [Fri, 8 Jul 2016 03:55:22 +0000 (03:55 +0000)]
Merge "Fix potential future problems re. hidden fields"
Michael Vorburger [Mon, 4 Jul 2016 22:49:50 +0000 (00:49 +0200)]
Fix potential future problems re. hidden fields
None of these changes actually really change code semantics, it does
what it does today, but is hopefully clearer.
Found by Checkstyle.
Change-Id: Ie8a231a9d203ed911c0ea3d9f41eec225af6f270
Signed-off-by: Michael Vorburger <vorburger@redhat.com>
Michael Vorburger [Tue, 28 Jun 2016 20:58:30 +0000 (22:58 +0200)]
Checkstyle clean-up src/test/java of southbound-impl
Change-Id: I4646877449a09d85779d35e85ce565a620818435
Signed-off-by: Michael Vorburger <vorburger@redhat.com>
Anil Vishnoi [Fri, 8 Jul 2016 02:16:40 +0000 (02:16 +0000)]
Merge "BUG 6130 - process only qos and queue creates and updates"
Eric Multanen [Thu, 30 Jun 2016 08:04:51 +0000 (01:04 -0700)]
BUG 6130 - process only qos and queue creates and updates
Fixes issue where all qos or queue entries - including ones
that had not changed - for an ovsdb node were getting ovsdb
transactions sent to the ovs node when a qos or queue was
created or updated.
This patch only creates ovsdb transactions for qos or queue
entries that have been created or updated.
Change-Id: Ie9eef13deae768dbdc16d6ab2a35e353c1aba6bf
Signed-off-by: Eric Multanen <eric.w.multanen@intel.com>
Signed-off-by: Anil Vishnoi <vishnoianil@gmail.com>
Michael Vorburger [Mon, 4 Jul 2016 18:31:30 +0000 (20:31 +0200)]
Fix Sonar (soon Checkstyle) constant name
Change-Id: Ida7d2484956e88883f9da4cc59154d527e637bfd
Signed-off-by: Michael Vorburger <vorburger@redhat.com>
Anil Vishnoi [Wed, 6 Jul 2016 08:20:24 +0000 (08:20 +0000)]
Merge "Fix Sonar (soon Checkstyle) TrailingComment"
Michael Vorburger [Mon, 4 Jul 2016 22:45:15 +0000 (00:45 +0200)]
Fix Checkstyle "Utility classes should not have (visible) constructor"
Change-Id: Ide9e8ee132cf2c6124dba049966a77a3a385a080
Signed-off-by: Michael Vorburger <vorburger@redhat.com>
Michael Vorburger [Mon, 4 Jul 2016 17:32:29 +0000 (19:32 +0200)]
Fix Sonar (soon Checkstyle) TrailingComment
Change-Id: Ic961c8ae27060cb7ba034ca7a4ffff668d982e58
Signed-off-by: Michael Vorburger <vorburger@redhat.com>
Sam Hague [Sat, 2 Jul 2016 20:14:22 +0000 (20:14 +0000)]
Merge "Fix ALOTOF Checkstyle violation, and switch over to enforcement."
Sam Hague [Sat, 2 Jul 2016 19:54:10 +0000 (19:54 +0000)]
Merge "Schema changes for 1.7.0 support"
Sam Hague [Sat, 2 Jul 2016 19:53:30 +0000 (19:53 +0000)]
Merge "hwvtep yang changes for 1.4.1"
Sam Hague [Sat, 2 Jul 2016 19:43:36 +0000 (19:43 +0000)]
Merge "Bug 5938 - Improve the logging."
Michael Vorburger [Tue, 28 Jun 2016 21:25:09 +0000 (23:25 +0200)]
Fix ALOTOF Checkstyle violation, and switch over to enforcement.
They're all minor formatting kind of things.
Change-Id: I91a391c2b4d6fd7562872bf0d8349e0531991a82
Signed-off-by: Michael Vorburger <vorburger@redhat.com>
Sam Hague [Sat, 2 Jul 2016 19:20:48 +0000 (19:20 +0000)]
Merge "Checkstyle clean-up invalid license headers containing Authors."
Sam Hague [Sat, 2 Jul 2016 19:16:58 +0000 (19:16 +0000)]
Merge "Bug 5938 - Updated the logging."
Sam Hague [Sat, 2 Jul 2016 19:14:22 +0000 (19:14 +0000)]
Merge "Bug:5938 Updated Log messages."
ananthip [Mon, 27 Jun 2016 12:54:58 +0000 (08:54 -0400)]
Bug 5938 - Improve the logging.
Change-Id: Ic13692f262ec783982c6ae2e259bb44dbe647ffa
Signed-off-by: ananthip <ananthip@hcl.com>
ananthip [Wed, 29 Jun 2016 14:10:39 +0000 (10:10 -0400)]
Bug 5938 - Updated the logging.
Change-Id: I933a9f75ce87a4769c22f194eb06d39e1f669477
Signed-off-by: ananthip <ananthip@hcl.com>
Vishal Thapar [Tue, 28 Jun 2016 11:21:28 +0000 (16:51 +0530)]
Schema changes for 1.7.0 support
This adds the following:
1. ACL.java for ACL table
2. ACLEntry.java for ACL_entries table
3. Reference to ACL table entry in LogicalRouter
4. Reference to ACL table entry in PhysicalPort
5. Add tunnel-key to PhysicalLocator
6. Add other-config to multiple classes as per 1.5.1 an 1.7.0
7. Add replication_mode to LogicalSwitch
Change-Id: I0af839a9792890d5a6b753b8e26fb3ffcc1678de
Signed-off-by: Vishal Thapar <vishal.thapar@ericsson.com>
Michael Vorburger [Tue, 28 Jun 2016 18:56:42 +0000 (20:56 +0200)]
Checkstyle clean-up invalid license headers containing Authors.
incl. some automated clean-up actions which I make Eclipse do autom.
This is part of a set of changes that are required in order to be able
to enable Checkstyle enforcement for src/test/java as well globally, see
https://git.opendaylight.org/gerrit/#/c/40957/
Change-Id: I37d19d5826135006ff94608ce703d5cc054333fb
Signed-off-by: Michael Vorburger <vorburger@redhat.com>
Vishal Thapar [Thu, 23 Jun 2016 13:20:14 +0000 (18:50 +0530)]
hwvtep yang changes for 1.4.1
This adds following to yang:
1. Logical_Router
2. Arp_sources local and remote
3. ACL and ACL Entries
4. Logical_Binding_Stats
5. Fault status for switch and port
Change-Id: If5089785aceb035101b630ce009bb6523c37b3b8
Signed-off-by: Vishal Thapar <vishal.thapar@ericsson.com>
Stephen Kitt [Wed, 29 Jun 2016 07:47:21 +0000 (09:47 +0200)]
Add list of contributors
This was produced by looking at all the git sign-offs, and matching
where necessary with Gerrit identities.
Change-Id: Ifc3abee21dad9a13415c8902aadffd043603ae00
Signed-off-by: Stephen Kitt <skitt@redhat.com>
Anil Vishnoi [Wed, 29 Jun 2016 06:02:45 +0000 (06:02 +0000)]
Merge "Bug 4790 - 'ifindex' column from Interface table on OVS"
Michael Vorburger [Tue, 28 Jun 2016 21:33:46 +0000 (23:33 +0200)]
Use logger instead of System.out.println (found by Checkstyle)
Change-Id: I2aa3f02cea16ba48c51bbeccc4b7de2cae58d461
Signed-off-by: Michael Vorburger <vorburger@redhat.com>
Rashmi Pujar [Thu, 2 Jun 2016 21:36:56 +0000 (17:36 -0400)]
Bug 4790 - 'ifindex' column from Interface table on OVS
Change-Id: I66f7a15a36a7c877cdeb3ca6accf761b16a7a962
Signed-off-by: Rashmi Pujar <rpujar@inocybe.com>
ananthip [Wed, 22 Jun 2016 16:14:57 +0000 (12:14 -0400)]
Bug:5938 Updated Log messages.
Change-Id: I58da3c0d26f03faa8facdfebb06eca17d4b37246
Signed-off-by: ananthip <ananthip@hcl.com>
Eric Multanen [Sat, 25 Jun 2016 05:42:30 +0000 (22:42 -0700)]
BUG 5746 - Ovasb QoS and Queue enhancements part 2
Fixes 3 integration test errors. 2 errors due to bug
in the new Queue code. The other error was in the integration
test code as a result of the model changes.
Also, added support to set the qos-id and queue-id based
on the presence of the 'opendaylight-qos-id' and
'opendaylight-qeueue-id' external-id values. These
external-id keys were placed in the qos and queue
tables respectively by the original qos and queue
plugin support. The corresponding value was the
id value for the row entry used by the md-sal.
The updated qos and queue model enhancement code
use the 'opendaylight-iid' key and stores the
corresponding instance identifier for the qos or
queue object. Support for using the previous
external-id keys provides backward compatiblity
when connecting to OVS hosts which contain qos
and queue entries created using the older plugin.
Change-Id: Ifd97b1f41a497cadd1060365122cae1fd7cbfe84
Signed-off-by: Eric Multanen <eric.w.multanen@intel.com>
Anil Vishnoi [Thu, 23 Jun 2016 23:23:44 +0000 (23:23 +0000)]
Merge "Bug 5721 - br-int not created in clustered setup"
Anil Vishnoi [Thu, 23 Jun 2016 23:05:06 +0000 (23:05 +0000)]
Merge "Fixing sonar bug 1)Add a private constructor to hide the implicit public one. 2)removing the block of commented-out lines as part of code cleanup"
vinh.nguyen [Tue, 17 May 2016 17:47:49 +0000 (10:47 -0700)]
Bug 5721 - br-int not created in clustered setup
When the OVS node is hard-reset in PASSIVE mode, it takes
up to 3 minutes for the controler to detect the connection is gone.
During this time, new connection request from the same node arrives.
The latter connection request causes
CandidateAlreadyRegisteredException because the former connection
has not been cleaned up properly.
This patch fixes the issue by making sure that all stale connections
from the same node are properly cleaned up before processing new
connection request. When a new connection request arrives
all connections from same node are pinged. The pings cause
the stale netty connections to close due to IOException.
Those have not been closed after a timeout will be closed
programmatically. New connection request is then processed after
all stale connections are cleaned up in the OvsdbConnectionService
Change-Id: I8bbce8a81b9850704278220b4b75d2ab21cb34c6
Signed-off-by: vinh.nguyen <vinh.nguyen@hcl.com>
Praveen Mala [Thu, 23 Jun 2016 22:10:04 +0000 (18:10 -0400)]
Fixing sonar bug
1)Add a private constructor to hide the implicit public one.
2)removing the block of commented-out lines as part of code cleanup
Change-Id: Ib9d5f550d6168bff5d02c865568821af1be88ffc
Signed-off-by: Praveen Mala <praveen.mala@intel.com>
Sam Hague [Wed, 22 Jun 2016 21:18:15 +0000 (17:18 -0400)]
ovsdb enable checkstyle on error
Change-Id: Ie3105f3cac8b0db4762c68df36c650f6cefdca00
Signed-off-by: Sam Hague <shague@redhat.com>
Anil Vishnoi [Thu, 23 Jun 2016 06:01:27 +0000 (06:01 +0000)]
Merge changes from topic 'blueprint'
* changes:
Add blueprint wiring to library
Add blueprint wiring for southbound
Add blueprint wiring for hwvtepsouthbound
Alexis de Talhouët [Tue, 21 Jun 2016 21:46:12 +0000 (17:46 -0400)]
Add blueprint wiring to library
Change-Id: Ieb404cc0ada8fef56f9ce63ec04ffbb40029a47e
Signed-off-by: Alexis de Talhouët <adetalhouet@inocybe.com>
Alexis de Talhouët [Tue, 21 Jun 2016 22:39:49 +0000 (18:39 -0400)]
Add blueprint wiring for southbound
Change-Id: I6e5cea49f584cc93a2842533287e950eadfabb40
Signed-off-by: Alexis de Talhouët <adetalhouet@inocybe.com>
Vishal Thapar [Wed, 22 Jun 2016 12:37:46 +0000 (18:07 +0530)]
BUG 5945: Tunnel updates through Genius not working
When creating tunnels through Genius, bridge information is present only
in operational and not in config. So any data chages that come in will not
have any augmentation. This was fixed as part of BUG 4644 but changes for
DataTreeListener refactored the code and this scenario was missed.
Change-Id: Ie4982d887e555a40984a5f4ff1211b785fe5ee6d
Signed-off-by: Vishal Thapar <vishal.thapar@ericsson.com>
Anil Vishnoi [Wed, 22 Jun 2016 00:46:58 +0000 (00:46 +0000)]
Merge "BUG 5746 - Ovsdb QoS and Queue model enhancements"
Alexis de Talhouët [Tue, 21 Jun 2016 22:03:17 +0000 (18:03 -0400)]
Add blueprint wiring for hwvtepsouthbound
Change-Id: I973476d85f890f701b2b668dcebef61372e7aa58
Signed-off-by: Alexis de Talhouët <adetalhouet@inocybe.com>
Sam Hague [Mon, 20 Jun 2016 18:24:58 +0000 (14:24 -0400)]
Remove verbose logging in TransactUtils
The two logs removed are repeated constantly for every transaction and don't add much value since this is a utility.
Change-Id: I8d66c9b87e42ad93f3f91da1a5a76e9cb70e12f6
Signed-off-by: Sam Hague <shague@redhat.com>
Sam Hague [Mon, 20 Jun 2016 10:21:39 +0000 (10:21 +0000)]
Merge "Bug:5938 Added log message for OvsdbDataTreeChangeListener."
Anil Vishnoi [Mon, 20 Jun 2016 07:00:58 +0000 (07:00 +0000)]
Merge ".gitignore .factorypath created by m2e-apt"
Anil Vishnoi [Mon, 20 Jun 2016 06:51:12 +0000 (06:51 +0000)]
Merge "Patch set 2 ------------ 1. Break this up into 2 patches, as Sam suggested. This patch will add new schema dependencies and fix ovsdb code to handle ovsdb node when both schemas are present."
ananthip [Thu, 16 Jun 2016 17:10:33 +0000 (13:10 -0400)]
Bug:5938 Added log message for OvsdbDataTreeChangeListener.
Change-Id: I4ae256f2564055bac0d79abb275d1f3f371c128f
Signed-off-by: ananthip <ananthip@hcl.com>
Michael Vorburger [Sun, 19 Jun 2016 15:58:46 +0000 (17:58 +0200)]
.gitignore .factorypath created by m2e-apt
https://github.com/vorburger/opendaylight-eclipse-setup now bundles
https://github.com/jbosstools/m2e-apt, which creates .factorypath files
all over the place.
Change-Id: I34a8edc9a0a4cd65f5e273014a232c0cba106c51
Signed-off-by: Michael Vorburger <vorburger@redhat.com>
Anil Vishnoi [Fri, 17 Jun 2016 23:05:16 +0000 (23:05 +0000)]
Merge "Support for IT Ping feature"
Victor Pickard [Mon, 13 Jun 2016 22:51:17 +0000 (18:51 -0400)]
Patch set 2
------------
1. Break this up into 2 patches, as Sam
suggested. This patch will add new schema
dependencies and fix ovsdb code to handle
ovsdb node when both schemas are present.
2. Only create transaction handlers for
Open-vSwitch database.
3. Revert change to hwvtepsouthbound-it/pom.xml,
so that hwvtepIT test are skipped, until
docker image is published that contains
both Open_vSwitch and hardware_vtep schemas.
See TODO itmes below.
4. Next patch will address items in TODO below.
When the ovsdb node has other schemas, such as
hardware_vtep, the code was creating transaction
handlers for hardware_vtep database, which the ovsdb
code cannot handle.
With this change, all IT tests pass when running
docker image loaded with both Open_vSwitch schema
and hardware_vtep schema.
Additionally, all IT tests pass when running docker
image loaded with only Open_vSwitch schema.
TODO
----
1. Publish docker image that has support for both schemas.
2. Replace assumes in hardware vtep IT to asserts if/when
hardware_vtep schema is not present.
3. Enable HwvtepSouthboundIT tests, in hwvtepsouthbound-it/pom.xml.
4. Sam suggested additional testing to ensure that both ovsdb southbound
and hwvtep southbound can connect at same time to ovsdb node running
both schemas.
5. Confirm deployment model when both schemas are present on
ovsdb node.
Patch set 1
-----------
Add hardwarevtep schema to pom and features.xml.
With these changes, and my docker image with both
ovsschema and hardwarevtep schema(to be published),
library/it tests pass, as well as hwvtepsouthbound-it
tests pass.
Change-Id: I94d24d524dcafaa38c69d129190ea29140efd5c9
Signed-off-by: Victor Pickard <vpickard@redhat.com>
Sam Hague [Thu, 16 Jun 2016 14:37:23 +0000 (10:37 -0400)]
Make SchemaVersionMismatchException logging consistent
The logging for the exception was not consistent: The log level varied,
the output varied and the logging of the stack trace varied.
Now a single utility method is called for the log. The level is set
to debug, same text, and the exception message rather than the trace
is logged. In all cases these are not errors because it is expected
that different schema versions may not have support for some columns.
Change-Id: I29ef9d30e2044483da1dfd9dc573d13715d222f1
Signed-off-by: Sam Hague <shague@redhat.com>
Josh [Wed, 15 Jun 2016 09:10:37 +0000 (11:10 +0200)]
Support for IT Ping feature
Change-Id: I12860f66d0abcd521bd07756232ede9ccdebfc60
Signed-off-by: Josh <jhershbe@redhat.com>
Eric Multanen [Fri, 25 Mar 2016 16:06:29 +0000 (09:06 -0700)]
BUG 5746 - Ovsdb QoS and Queue model enhancements
Update the QoS and Queue model to improve managability
of QoS and Queue tables via MD-SAL config model.
Adds code to update operational md-sal using updated
model.
Adds code to allow creation of queue and qos in same
transaction and assign queue to the qos row via
named-uuid.
QoS and Queue entries can be managed by ODL ID
values instead of needing to know the operational
UUID value.
Adds code to support assignment of QoS to port
by MD-SAL QoS ID.
Adds a QoS entry list to the termination point
model so updates and delete operations can be made
directly on the list instead of updating the
termination point.
Support for ingress policing rate and burst configuration
for interfaces is added.
Includes updated Postman examples.
v2 - clarify some logic based on comment feedback
add additional qos types: linux-sfq, linux-codel
linux-fq_codel, egress-policer
v3 - rebase, whitespace
v4 - address review comments
v5 - Changes to address review comments:
Use a queue-ref (instance identifier instead
of queue-id in the qos queue list.
Use a qos-ref (instance identifier instead
of qos-id in the port qos list.
Use a key of '1' for the single item port qos list.
Add instance identifer to the external-ids column
of the qos and queue tables instead of just id
value. Use key of 'opendaylight-iid'.
Updated the postman collection to account for changes
Clarified the comment and code of method
bytesToHexString in TransactUtils.java.
Still to do:
- update unit tests
- update integration tests
Change-Id: I71ac462afe5a881c621fad9a3c5603e1aab8d021
Signed-off-by: Eric Multanen <eric.w.multanen@intel.com>
Patrick Roanhouse [Tue, 14 Jun 2016 18:43:40 +0000 (14:43 -0400)]
removed unused imports in HwvtepSouthboundUtil.java, 'org.opendaylight.controller.md.sal.common.api.data.TransactionCommitFailedException' and org.opendaylight.yang.gen.v1.urn.opendaylight.params.xml.ns.yang.ovsdb.hwvtep.rev150901.HwvtepLogicalSwitchAttributes'.
Change-Id: Ia3afae16031f1d43e5c4ccfc54913d636cf4facb
Signed-off-by: Patrick Roanhouse <Patrick.M.Roanhouse@intel.com>
Sam Hague [Tue, 14 Jun 2016 14:35:32 +0000 (14:35 +0000)]
Merge "Bug 5976 - Thread leak when connecting/disconnecting ovs nodes"
Sam Hague [Tue, 14 Jun 2016 12:05:17 +0000 (12:05 +0000)]
Merge "Remove OvsdbDataChangeListener"
Sam Hague [Mon, 13 Jun 2016 23:30:31 +0000 (19:30 -0400)]
Add IT for port del dtcl
Change-Id: I2db8c5a6f8d56ffe9a6609b79ffe34dcbabba9c1
Signed-off-by: Sam Hague <shague@redhat.com>
Anil Vishnoi [Wed, 8 Jun 2016 02:15:29 +0000 (19:15 -0700)]
Bug 5992 - GBP + SFC integration is broken
When Bridge and termination points are created together, it generates two data tree change
notifications. Termination point changes are part of second data change notification,
but that does not contain bridge and node augmentation, because there was no change
in those augmentations, and because of that plugin was not able to find the connection
instance for the ovsdb node. As a last resort plugin tries to find it based on the
rootNode iid from operational data store, but because in this scenario rootNode is
bridge node, and bridge creation request was process just before the second data
change notification, operational data was not updated with the bridge node details
by the time plugin checks in the operational data store. So final attempt to find
the connection instance also fails. To fix this and also optimize it a bit, this
patch added an additional attempt to get the connection instances using the
managed-by ref node of the bridge node and check for that in the operational data
store. That node is the connection node, so it must be there if device is connected
to the controller, otherwise configuration should fail, which is expected outcome.
Change-Id: I743269b5ca2f36f761bbb4a118a2837631e1847d
Signed-off-by: Anil Vishnoi <vishnoianil@gmail.com>
Dileep [Mon, 6 Jun 2016 16:21:12 +0000 (09:21 -0700)]
Bug 5976 - Thread leak when connecting/disconnecting ovs nodes
ExecutorService in OvsdbClientImpl is not shutdown properly
When the del-manager is called along with closing the channel,
the executor service is shutdown.
Set the threadfactory to distinguish the Ovsdbclient threadpool.
Change-Id: I13473ca40456ba78162591ea23cfd907d2f5b34f
Signed-off-by: Dileep Ranganathan <dileep.ranganathan@intel.com>
Stephen Kitt [Mon, 13 Jun 2016 10:09:18 +0000 (12:09 +0200)]
Remove OvsdbDataChangeListener
This has been obsoleted by OvsdbDataTreeChangeListener.
Change-Id: I741584d94fb6bae7c6a456cdd812d093c8f9974b
Signed-off-by: Stephen Kitt <skitt@redhat.com>
Patrick Roanhouse [Wed, 8 Jun 2016 16:59:00 +0000 (12:59 -0400)]
Removed unused import 'org.opendaylight.ovsdb.lib.impl.OvsdbConnectionService'." from HwvtepSouthboundProvider.java
Change-Id: I0542e44fbc94b9dca691f4aa4e5fc01c9f1dc497
Signed-off-by: Patrick Roanhouse <Patrick.M.Roanhouse@intel.com>
David Suarez [Tue, 7 Jun 2016 10:50:19 +0000 (12:50 +0200)]
Replace wildcard imports
Change-Id: Icb2884d8d3785cbe551dc0fbd8a71b1c3446782e
Signed-off-by: David Suarez <david.suarez.fuentes@ericsson.com>
Anil Vishnoi [Fri, 3 Jun 2016 08:06:58 +0000 (08:06 +0000)]
Merge "Add ability to create VxLAN-GPE tunnels"
Rashmi Pujar [Thu, 2 Jun 2016 14:26:19 +0000 (10:26 -0400)]
Bug 5944 - Looping INFO messages for UNSUPPORTED AutoAttach OVS
Change-Id: I93704b2a0997da85a3cf2373cbb0d5c77b313db6
Signed-off-by: Rashmi Pujar <rpujar@inocybe.com>
David Suarez [Tue, 31 May 2016 15:05:06 +0000 (17:05 +0200)]
Add ability to create VxLAN-GPE tunnels
Change-Id: Ic352bebeed0a7cbfdbdc92b49ac6fcf0db2b615f
Signed-off-by: David Suarez <david.suarez.fuentes@ericsson.com>
Josh [Thu, 26 May 2016 09:14:30 +0000 (11:14 +0200)]
System property awareness in DockerOvs
Change-Id: If039cd49c18f9ba55181918c66fce1eaf973df82
Signed-off-by: Josh <jhershbe@redhat.com>
Anil Vishnoi [Sat, 28 May 2016 22:34:33 +0000 (22:34 +0000)]
Merge "removed unused import 'org.opendaylight.yang.gen.v1.urn.ietf.params.xml. ns.yang.ietf.inet.types.rev100924.Ipv4Address' in HwvtepSouthboundMapper.java"
Patrick Roanhouse [Fri, 27 May 2016 22:40:26 +0000 (18:40 -0400)]
removed unused import 'org.opendaylight.yang.gen.v1.urn.ietf.params.xml. ns.yang.ietf.inet.types.rev100924.Ipv4Address' in HwvtepSouthboundMapper.java
Change-Id: I5e8ec077386e0cfc63877f01c218c52f23e73b29
Signed-off-by: Patrick Roanhouse <Patrick.M.Roanhouse@intel.com>
Anil Vishnoi [Fri, 27 May 2016 23:28:07 +0000 (16:28 -0700)]
BUG 5885 - OVSDB plugin failure to update passive ovsdb nodes
Updates the ovsdb southbound so that configuration to ovsdb
nodes which have connected to the plugin passively can be
updated (e.g. such as qos or queue entries) without requiring
connection-info to be supplied in the configuration.
Similar to what already works when adding bridges or
termination points to passively connected ovsdb nodes.
The onDataChanged() method executes the following
sequence of operations on changes to the Ovsdb data tree:
- connect(changes)
- updateConnections(changes)
- updateData(changes)
- disconnect(changes)
When an OVSDB node has connected passively, or more
generally, when the changes to the OVSDB node do not
include 'connection-info', it is not necessary to
attempt to execute connection related operations for
the specified host. This patch checks for the absence
of the connection-info and skips trying to connect or
update a connection in the connect() and updateConnections()
methods.
v2 - add in data tree change patch from master branch
now that data tree change listener is merged.
Change-Id: I8238711076a74cfa06422e5cacb127ba95fd23b7
Signed-off-by: Eric Multanen <eric.w.multanen@intel.com>
Signed-off-by: Anil Vishnoi <vishnoianil@gmail.com>
Vishal Thapar [Thu, 26 May 2016 13:50:22 +0000 (19:20 +0530)]
BUG 5506: OVSDB server doesn't close connection after peer is power down
https://git.opendaylight.org/gerrit/#/c/35436/ added code to detect when a
peer goes down without sending a FIN. However, it only did it for switch
initiated connection. In case of ODL initiated connection we are unable to
detect peer being down and reconciliation is never triggered.
Change-Id: I62d0b2cef75b889fc75b43fe51be5156f921fcfe
Signed-off-by: Vishal Thapar <vishal.thapar@ericsson.com>
Signed-off-by: Sam Hague <shague@redhat.com>
Sam Hague [Fri, 27 May 2016 16:14:55 +0000 (16:14 +0000)]
Merge "BUG 5479: HWVtep Southbound doesn't retry connection"
Vishal Thapar [Wed, 25 May 2016 04:17:51 +0000 (09:47 +0530)]
BUG 5479: HWVtep Southbound doesn't retry connection
This fix is hwvtep counterpart of
https://git.opendaylight.org/gerrit/#/c/36028/ which fixes BUG 5221.
Wiki:
https://wiki.opendaylight.org/view/OVSDB_Integration:OVSDB_SB_Reconciliation
Change-Id: I497dbfa339de157d12afe94ce5c36b35ffda5dd9
Signed-off-by: Vishal Thapar <vishal.thapar@ericsson.com>
(cherry picked from commit
9d80362e33fb2d6a2c0dc4b7994c976e46e8799f)
Jamo Luhrsen [Thu, 19 May 2016 05:49:54 +0000 (22:49 -0700)]
BUG 5769
bailing on connection if get databases is not returning anything
and then using disconnected() which seems to have the effect of
letting our threadpool service more connections. The condition
before would block any new (and good) connections if we initiated
just 10 incorrect TCP connections toward port 6640
Change-Id: I5a59762049a0460cc39ebbfce0c93d002ec24d68
Signed-off-by: Jamo Luhrsen <jluhrsen@redhat.com>
Signed-off-by: Anil Vishnoi <vishnoianil@gmail.com>
Signed-off-by: Sam Hague <shague@redhat.com>
Vishal Thapar [Fri, 27 May 2016 11:48:59 +0000 (17:18 +0530)]
Fix for verification build failures
Change-Id: Ib1b6a920042bb977ca952320cf50d53af7288e75
Signed-off-by: Vishal Thapar <vishal.thapar@ericsson.com>
Anil Vishnoi [Mon, 23 May 2016 22:16:20 +0000 (22:16 +0000)]
Merge "Infra for running ovs dockers"
Anil Vishnoi [Sun, 22 May 2016 05:07:39 +0000 (05:07 +0000)]
Merge "Patch - https://git.opendaylight.org/gerrit/#/c/39061/ is broken .This patch fixes the breakage"
Patrick Roanhouse [Wed, 11 May 2016 21:46:40 +0000 (17:46 -0400)]
Minor sonar listed bug fixed for coding style in HwvtepConnectionManager.java
Change-Id: I28bae105be378010ac109c524977705afb6e4aa0
Signed-off-by: Patrick Roanhouse <patrick.m.roanhouse@intel.com>
Signed-off-by: Anil Vishnoi <vishnoianil@gmail.com>
Anil Vishnoi [Sun, 22 May 2016 01:15:19 +0000 (18:15 -0700)]
Patch - https://git.opendaylight.org/gerrit/#/c/39061/ is broken
.This patch fixes the breakage
Change-Id: I78034a55facd10f5921000e86bf451a90faa0691
Signed-off-by: Anil Vishnoi <vishnoianil@gmail.com>
Sam Hague [Sun, 22 May 2016 00:35:02 +0000 (00:35 +0000)]
Merge "Remove logging entire exception to avoid a noisy stack trace"
Rashmi Pujar [Wed, 18 May 2016 18:21:52 +0000 (14:21 -0400)]
Remove logging entire exception to avoid a noisy stack trace
Change-Id: I8b8efe61742505b6b89b66684e482b9d4e9e550b
Signed-off-by: Rashmi Pujar <rpujar@inocybe.com>