Tom Pantelis [Fri, 2 Mar 2018 23:15:58 +0000 (18:15 -0500)]
Fix checkstyle violations in utils
NotifyingDataChangeListener is fixed to be thread-safe, with
ConcurrentHashMap-backed sets and volatile fields where necessary.
Change-Id: Ic740e964c7fbcb53caf091475e3032ad29284677
Signed-off-by: Tom Pantelis <tompantelis@gmail.com>
Tom Pantelis [Fri, 2 Mar 2018 21:50:05 +0000 (16:50 -0500)]
Fix checkstyle violations in schema
Change-Id: Ifdfeaeee54a69071758b12762fab8093974a5c6e
Signed-off-by: Tom Pantelis <tompantelis@gmail.com>
Tom Pantelis [Fri, 2 Mar 2018 19:47:14 +0000 (14:47 -0500)]
Add binding-parent pom
This will contain common configurations for checkstyle and
findbugs.
Change-Id: I9fd94099ef0446caa377fdf9f069929ba659f8e1
Signed-off-by: Tom Pantelis <tompantelis@gmail.com>
Anil Belur [Mon, 26 Feb 2018 07:41:46 +0000 (17:41 +1000)]
Bump versions by x.(y+1).z for next dev cycle
Change-Id: I7bd594fb7b5413b8a6647bd49bd07d8fc3fbbe54
Signed-off-by: Anil Belur <abelur@linuxfoundation.org>
K.V Suneelu Verma [Mon, 18 Dec 2017 12:50:33 +0000 (18:20 +0530)]
Added device transaction log cli
Added a cli to display device transaction history
Change-Id: I00d8f5bd287342691c7b69b0b75f79c2cdcee1e8
Signed-off-by: K.V Suneelu Verma <k.v.suneelu.verma@ericsson.com>
K.V Suneelu Verma [Tue, 13 Jun 2017 14:00:31 +0000 (19:30 +0530)]
bug 8671 same client notified multiple times
only leader node will initialize topology
each node listens for topology creation/add event
once it receives the add event opens the ovsdb port to clients
Now we are absolutely sure that topology node can be created for the
new incoming connections.
when a new node joins/leaves the cluster , the leader node
will reinit the topology which is a no op event
Change-Id: I45c319195f593d8bd99b19f07f5568492cf9077f
Signed-off-by: K.V Suneelu Verma <k.v.suneelu.verma@ericsson.com>
K.V Suneelu Verma [Mon, 18 Dec 2017 11:16:17 +0000 (16:46 +0530)]
bug 6578 added mdsal read retry
Change-Id: I5dba7362bf41ea84baa35dc29a6a4a6a69ba78fa
Signed-off-by: K.V Suneelu Verma <k.v.suneelu.verma@ericsson.com>
K.V Suneelu Verma [Mon, 18 Dec 2017 07:05:22 +0000 (12:35 +0530)]
make reconciliation the first transaction
jira bug ovsdb-441
When the south bound device disconnects and connects back reconciliation
task will try to reconcile to the device.
At the same time if the application pushes some more config and that gets
executed,
then the reconciliation task if executed later will end up corrupting the
device state.
Ensure that reconciliation transaction is the first towards the device
Change-Id: I5b5df1e8cdc3d96e7aa518a5012759d39afe048f
Signed-off-by: K.V Suneelu Verma <k.v.suneelu.verma@ericsson.com>
K.V Suneelu Verma [Fri, 15 Dec 2017 11:06:00 +0000 (16:36 +0530)]
OVSDB-438: missing operational node
Handle the following scenarios
client connects to only one odl controller via ha proxy
1) client disconnects and connects back to same node after some delay
2) client disconnects and connects back to same node immediately
3) client disconnects and connects to another node after some delay
4) client disconnects and connects to another node immediately
5) client disconnects and never connects back
When client disconnects all the odl controllers are trying to cleanup the oper
node.
When client connects the owner odl controller is trying to create the oper node.
When the processing of one odl controller which is trying to cleanup the opernode is
delayed , then we end up client node missing in oper topology.
Fix
Listen for oper node removal and if some client is still connected then
recreate it.
Change-Id: Ib88e8385f199c2105c51ce49e01e4318c1ae1463
Signed-off-by: K.V Suneelu Verma <k.v.suneelu.verma@ericsson.com>
Robert Varga [Tue, 13 Feb 2018 12:24:47 +0000 (13:24 +0100)]
Use packaging=bundle for utils.config
This prevents wrapping when the jar is moved to OSGi world.
Change-Id: I4f105d684bf98bede66ffb85fe4ec4de84982d41
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
Isaku Yamahata [Tue, 13 Feb 2018 20:02:28 +0000 (12:02 -0800)]
export utils.{config, mdsal-utils, southbound-utils} as feature
Those bundles are used by genius and neturon northbound.
They should be consumable as feature, not bundle.
For detailed discussion, please refer to the followings
https://lists.opendaylight.org/pipermail/release/2018-January/013604.html
https://lists.opendaylight.org/pipermail/release/2017-September/012356.html
NEUTRON-156
Change-Id: I845989115b28bfc9685ed7fdb43e604e16701fe1
Signed-off-by: Isaku Yamahata <isaku.yamahata@intel.com>
Signed-off-by: Stephen Kitt <skitt@redhat.com>
Vishal Thapar [Tue, 16 Jan 2018 06:42:09 +0000 (12:12 +0530)]
Fix IidCodec broken by new yangtools
There are multiple versions of network-topology loaded
and yangtools can't tell which one to use. It has ramifications
beyond just OVSDB, but this fixes functionality issues in
OVSDB.
Root issue is two different files with different versions
bundled together. It may not have been issue earlier but is now.
Change-Id: Ibc7f8387c5b84cb6e1c0e8a69454acb661a4acc4
Signed-off-by: Vishal Thapar <vishal.thapar@ericsson.com>
Signed-off-by: Stephen Kitt <skitt@redhat.com>
Stephen Kitt [Fri, 15 Dec 2017 14:09:52 +0000 (15:09 +0100)]
Adjust for odlparent 3 / yangtools 2
Change-Id: Ibdba54c92c44c63bef11df9f5fa9beca88c6ca3d
Signed-off-by: Stephen Kitt <skitt@redhat.com>
Stephen Kitt [Thu, 14 Dec 2017 08:45:43 +0000 (09:45 +0100)]
Adjust for odlparent 3 Checkstyle settings
This fixes the enforcing modules, library-impl and southbound-impl,
along with a few other violations in other modules.
Change-Id: I79a4872df64c01ae7d7e6a0722fe473576b3cff1
Signed-off-by: Stephen Kitt <skitt@redhat.com>
Vishal Thapar [Thu, 4 Jan 2018 05:34:48 +0000 (11:04 +0530)]
OVSDB-445 Port creation not reflected in OperDS
When a port is deleted and added in same ovs-vsctl command
it doesn't show up in OperDS. This is because
OvsdbOperationalCommandAggregator always processes removes
after Updates. Since delete is being done for same port right
after update, it ends up not adding it to datastore.
Fix is to check if same port is present in updates or not
before deleting it.
Note: This may impact other such configuration too, though
not sure of any valid use cases for bridges etc.
Change-Id: I596ceaf579c4342a3e6bc282ce140cf15a295d60
Signed-off-by: Vishal Thapar <vishal.thapar@ericsson.com>
Tim Rozet [Fri, 15 Dec 2017 21:34:32 +0000 (16:34 -0500)]
OVSDB-440: Fixes detecting SSL mode with OVSDB nodes
The OF controller in netvirt is set by detecting the mode used in the
OVSDB manager connection. However, this detection was absent for ssl
and was only working with tcp/ptcp.
Fixes: OVSDB-440
Change-Id: I66907a25e7ce5df14072218d33e0a5995081311a
Signed-off-by: Tim Rozet <trozet@redhat.com>
Stephen Kitt [Thu, 30 Nov 2017 13:14:44 +0000 (14:14 +0100)]
OVSDB-435: fix transaction leak in BridgeOperationState
Change-Id: I82708edcf710f72c1356914e9da11a5769b489c9
Signed-off-by: Stephen Kitt <skitt@redhat.com>
Michael Vorburger [Wed, 15 Nov 2017 18:26:56 +0000 (19:26 +0100)]
Fix transaction leak in OvsdbConnectionManager
see https://jira.opendaylight.org/browse/NETVIRT-985
Change-Id: I50d5e5856d813be8b40bd552c734630856257294
Signed-off-by: Michael Vorburger <vorburger@redhat.com>
Michael Vorburger [Wed, 15 Nov 2017 16:59:01 +0000 (17:59 +0100)]
Fix transaction leak in BridgeConfigReconciliationTask
see https://jira.opendaylight.org/browse/OVSDB-425
Change-Id: I9d89cb72768cff137b91773ac8ab0e1d5fce7a04
Signed-off-by: Michael Vorburger <vorburger@redhat.com>
Michael Vorburger [Wed, 15 Nov 2017 18:19:16 +0000 (19:19 +0100)]
Fix possible transaction leak in BridgeOperationalState
see https://jira.opendaylight.org/browse/NETVIRT-985
Change-Id: Ie8bd1d81cb4df55d9c75ca275756013262c12a00
Signed-off-by: Michael Vorburger <vorburger@redhat.com>
K.V Suneelu Verma [Mon, 13 Nov 2017 05:11:38 +0000 (10:41 +0530)]
fix intermittently failing unit test
Change-Id: I1445d255f10ca05ed2f1f4d0bf1f563f82164904
Signed-off-by: K.V Suneelu Verma <k.v.suneelu.verma@ericsson.com>
K.V Suneelu Verma [Tue, 31 Oct 2017 05:34:17 +0000 (11:04 +0530)]
fix unit tests which fail intermittently
using doReturn when pattern instead of when thenReturn pattern.
mockito does not work properly in multi threaded tests when we use
when thenReturn pattern.
Change-Id: I3671d2201b15d2d2061199249c269ca7d5eeb88f
Signed-off-by: K.V Suneelu Verma <k.v.suneelu.verma@ericsson.com>
Hsin-Yi Shen [Mon, 25 Sep 2017 21:53:47 +0000 (17:53 -0400)]
OVSDB-432: Add method to restart OVSDB server and limit retry times and timeout
This patch makes following changes:
1. Add restart method to restart OVSDB server. User wiil be able
to restart OVSDB server with different sets of SSL protocol
and cipher suites.
2. Limit retry times for certain SSL handshake status. In current
code, it retry infinite times for some SSL handshake status
and cause issue. This patch will fix it.
3. Add API in OvsdbClient interface to provide custom timeout value for
monitor and cancel monitor transactions. This avoids
blocking thread due to unsuccessful transaction.
4. Fix typo in Function.java
Change-Id: I4f07e2f32889099e65a06a3afc4a263714dd5946
Signed-off-by: Hsin-Yi Shen <syshen66@gmail.com>
Thanh Ha [Mon, 30 Oct 2017 21:15:48 +0000 (17:15 -0400)]
Remove deploy-site.xml
With the javadoc jobs now available to generate javadoc it is time to
remove the maven-sites and related files.
Change-Id: I765df2031218eabb07dffac1a0856ef5a45d798f
Signed-off-by: Thanh Ha <thanh.ha@linuxfoundation.org>
K.V Suneelu Verma [Mon, 14 Aug 2017 12:01:21 +0000 (17:31 +0530)]
bug 8712 vlan bindings update fix
when global node and physical switch node are updated in same transaction
from application, vlan bindings are missing.
Make vlan bindings participate in dependency workflow.
Do not create/delete port from controller.
Only update the port from controller.
port creation happens from device always.
Added port reconciliation when port is added later.
Change-Id: Ic86a3545428e186f3aeb26c8a36a783f774ecf53
Signed-off-by: K.V Suneelu Verma <k.v.suneelu.verma@ericsson.com>
K.V Suneelu Verma [Fri, 11 Aug 2017 10:44:08 +0000 (16:14 +0530)]
bug 7599 avoid unnecessary mdsal reads
avoid the un necessary reads.
skip monitoring version column
Change-Id: I82e50b973a93c57eb65dd34c6dd624c8e47e2344
Signed-off-by: K.V Suneelu Verma <k.v.suneelu.verma@ericsson.com>
K.V Suneelu Verma [Fri, 11 Aug 2017 09:23:56 +0000 (14:53 +0530)]
bug 8029 handle expired in transit entries
when ref count goes to zero , locator is kept in transit state.
if the device still has references to it from other sources like tunnels
the locator will not be deleted from device.
The transactions which wait for this locator will expire.
If the intransit state expires , query the device itself to get its
status and proceed with the transactions which depends on this locator.
added a timer job which triggers every 30sec and checks for expired
intransit keys and clears them.
Change-Id: I0022da4a3a2e748629bc031246f6e6c1509d27a4
Signed-off-by: K.V Suneelu Verma <k.v.suneelu.verma@ericsson.com>
K.V Suneelu Verma [Fri, 11 Aug 2017 09:20:36 +0000 (14:50 +0530)]
bug 8029 added ref counts for physical locators.
remote mcast and ucast macs refer to physical locators
whenever a new mac is added or updated, update their refcount for that
tep.
When the ref count of the tep goes to zero , the device may delete that
tep after the current transaction.
In that case mark the locator as in transit.
The next transaction which depends on this locator will not use this
locator uuid and will wait for the locator in transit state to be
resolved in dependency queue.
Eventually controller will get locator delete update command from the
device and proceed the transactions which are waiting for this locator
state to be changed from in transit state.
Added onSuccess and onFailure methods to transaction command.
Clear the locator refs for the succeeded delete mcast macs immediately
upon the success of the device transaction.
Clearing the locator ref count immediately upon success of delete mcast
is needed so that the next transaction will not use the possibly stale locator.
Clear the intransit status of the failed commands upon failure.
Change-Id: I84d64f7deb20f801f14e524f88431807afac3a99
Signed-off-by: K.V Suneelu Verma <k.v.suneelu.verma@ericsson.com>
Stephen Kitt [Wed, 27 Sep 2017 13:35:06 +0000 (15:35 +0200)]
Bump odlparent 2.0.4 to 2.0.5
Change-Id: I8147fda8b48b39e3010503ac8420c25c13a6903c
Signed-off-by: Stephen Kitt <skitt@redhat.com>
David Suarez [Wed, 27 Sep 2017 08:57:49 +0000 (10:57 +0200)]
Remove explicit default super-constructor calls
The default constructor is called by default (hence its name), no need
to call it explicitly
Change-Id: If72cd83d0cf4e0032d7f5fe7174c28cf4b9c5092
Signed-off-by: David Suarez <david.suarez.fuentes@gmail.com>
Victor Pickard [Mon, 18 Sep 2017 20:03:33 +0000 (16:03 -0400)]
BUG 9166 - Fix Netvirt L2GW Illegal state exception
Fix exception and modify logic for comparing OVSDB
Hardware_vtep database version retrived from device
to min version specified.
Change-Id: I0b882b4a4883af80a3ea01224781e781eaefac1a
Signed-off-by: Victor Pickard <vpickard@redhat.com>
Robert Varga [Thu, 7 Sep 2017 10:37:45 +0000 (12:37 +0200)]
Migrate SchemaService references
SchemaService is deprecated in favor of DOMSchemaService, migrate
references.
Change-Id: I8ba2ff0b4f676fc47e3069a9bdb79078c17fe61f
Signed-off-by: Robert Varga <nite@hq.sk>
Ryousuke Masuhara [Tue, 25 Jul 2017 05:06:39 +0000 (14:06 +0900)]
Bug 8874 - Tunnel_ips of hardware_vtep is cleared when Open vSwitch process restarted in Open vSwitch HWVTEP Emulator
Issue:
Tunnel_ips of hardware_vtep is cleared when Open vSwitch process
restarted in Open vSwitch HWVTEP Emulator
Cause of this issue:
After Open vSwitch process restarted, ODL attempts to acquire tunnel_ips
from CONFIGURATION MD-SAL and set it to Physical Switch.
As tunnel_ips is not set from ODL but is set by vtep-ctl command, it
does not exist in CONFIGURATION MD-SAL.
This caused an empty value is set to tunnel_ips for Physical Switch.
Fix:
Let ODL to acquire tunnel_ips from OPERATIONAL MD-SAL after
VTEP Emulator restarted.
Change-Id: I439ba08c813ede02f82592ca0051b19140f40db2
Signed-off-by: Ryousuke Masuhara <r-masuhara@zn.nes.jp.nec.com>
Vishal Thapar [Thu, 17 Aug 2017 08:48:57 +0000 (14:18 +0530)]
Refactor compareDbVersionToMinVersion
compareDbVersionToMinVersion uses ovsdb.library to
compare versions. This has added unnecessary
dependency in downstream projects. Replace usage of
ovsdb.lbrary.Version with String matching so downstream
projects don't need to add library, which is OVSDB internal
feature, as a dependency.
Change-Id: I8470970b1e7819f543615f97753fa898b3ce8bc5
Signed-off-by: Vishal Thapar <vishal.thapar@ericsson.com>
Victor Pickard [Wed, 30 Aug 2017 19:34:17 +0000 (15:34 -0400)]
BUG 9073 Fix memory leak - close TransactionChain
Part of larger effort related to bug 9060 and
bug 9034 to fix memory leaks.
Change-Id: Id3f46b83d4b98fa0d4c5a0706d0758ef98eb85ba
Signed-off-by: Victor Pickard <vpickard@redhat.com>
Victor Pickard [Wed, 30 Aug 2017 18:52:19 +0000 (14:52 -0400)]
BUG 9072 - Fix OVSDB TransactionChain memory leak
TransactionChain is never closed. Add code to
close txChain when SouthboundProvider is closed.
This fix is part of memory leak cleanup efforts
for bug 9060 and bug 9034.
Change-Id: Ic24ec8081b02a35b73a4c640e751b75ee80bd143
Signed-off-by: Victor Pickard <vpickard@redhat.com>
Tom Pantelis [Sat, 26 Aug 2017 13:54:44 +0000 (09:54 -0400)]
Convert DataChangeListeners to DataTreeChangeListeners
The DataChangeListener API has been deprecated for a couple releases
with possible removal in Oxygen.
Change-Id: Ifca15545eb1ff7a5e889e472c9456bfd2b824cf3
Signed-off-by: Tom Pantelis <tompantelis@gmail.com>
Eric Multanen [Tue, 15 Aug 2017 05:37:48 +0000 (22:37 -0700)]
Bug 8991 - Add dpdkvhostuserclient interface type to model
Add the dpdkvhostuserclient interface type to the OVSDB
model. This interface type as was added back in OVS 2.6
Change-Id: I63ab98e4e1b452c3d832c15298f3608c83d21796
Signed-off-by: Eric Multanen <eric.w.multanen@intel.com>
Tom Pantelis [Fri, 25 Aug 2017 19:42:39 +0000 (15:42 -0400)]
Remove CSS artifact remnants
The project has already been converted to blueprint (except for test-extension)
so removed he remaining CSS remnants (eg use of config-parent).
Change-Id: Ib19a47efe84702fc49ec59ba79f58fccb46e1f49
Signed-off-by: Tom Pantelis <tompantelis@gmail.com>
Thanh Ha [Mon, 14 Aug 2017 17:36:17 +0000 (13:36 -0400)]
Bump versions by x.(y+1).z for next dev cycle
Change-Id: I4ec0bfef91e3f3fd4adb230c540da790c73031c3
Signed-off-by: Thanh Ha <thanh.ha@linuxfoundation.org>
Stephen Kitt [Tue, 8 Aug 2017 16:14:08 +0000 (18:14 +0200)]
Bump odlparent 2.0.2 to 2.0.4
Change-Id: Iacdb35cb6b7fedc8c00b06ba3bd051226f7d58c4
Signed-off-by: Stephen Kitt <skitt@redhat.com>
Vratko Polak [Tue, 1 Aug 2017 13:24:24 +0000 (15:24 +0200)]
Bump all Odlparent dependencies to 2.0.2
Change-Id: Ib75a6ef1ee76e4c1440149923ab4bce7099ff006
Signed-off-by: Vratko Polak <vrpolak@cisco.com>
Victor Pickard [Tue, 25 Jul 2017 21:20:19 +0000 (17:20 -0400)]
Bug 8476 Add support for logical switch replication mode
Add helper method to SouthboundUtils to check database
version.
Change-Id: Ie271b665b3e47ad275f9c6340764013daa4fd9ad
Signed-off-by: Victor Pickard <vpickard@redhat.com>
Victor Pickard [Tue, 16 May 2017 20:27:54 +0000 (16:27 -0400)]
Bug 8476 Add support for logical switch replication mode
With OVS 2.6, the Logical Switch table, in the hardware_vtep schema, has
a new field, replication_mode. This bug will be used to add support to
netvirt, ovsdb, and genius for setting the replication_mode of logical
switches. The default will be for ODL to set the replication_mode
to "source_node" when creating logical switches.
Refer to [1] for more details on replication_mode.
[1] http://openvswitch.org/support/dist-docs/vtep.5.html
Try/catch block in place to handle case where schema
version does not support replication_mode.
Tested this with OVS 2.5, which does not support replication_mode.
Verified that logical switch is created.
Debug log will be generated when schema version does
not support replication_mode (same check as PhysicalSwitchUpdate).
Change-Id: I374ba52ff5517dacb6af498f34b7e58638f46463
Signed-off-by: Victor Pickard <vpickard@redhat.com>
K.V Suneelu Verma [Tue, 13 Jun 2017 13:19:39 +0000 (18:49 +0530)]
bug 8673 physical switch node is not removed
When the node gets disconnected , its global node alone
is getting removed sometimes.
reuse GlobalNodeRemove command which cleans global aswell as
physical switch node.
Change-Id: Ic89fb1b0606bb1d42242c860ea2f7d9fa1e2b37d
Signed-off-by: K.V Suneelu Verma <k.v.suneelu.verma@ericsson.com>
K.V Suneelu Verma [Tue, 13 Jun 2017 06:58:44 +0000 (12:28 +0530)]
bug 8674 fix port vlan bindings reconciliation
1. When controller is restarted after clearing the config by
removing journals and snapshots, it does not have any config data
for ports.
Do not fire delete of port during reconciliation.
Fire port update to clear the vlan bindings.
Port addition/deletion is always managed by southbound not by controller.
Only port update is managed by controller.
2. Sometimes logical switch does not get deleted from device due to some
local ucast/mcast references to it. Cleanup the references also while
deleting the logical switch. It can still fail if vlan binding reference
is not removed.
3. Make sure that mcast and ucast programming during reconciliation
uses proper physical locators.
Change-Id: I81f095a6e030e05d6702997600ced012d4666c36
Signed-off-by: K.V Suneelu Verma <k.v.suneelu.verma@ericsson.com>
Vishal Thapar [Thu, 29 Jun 2017 10:33:05 +0000 (16:03 +0530)]
OVSDB merge build failing, looking for library-features.jar
OVSDB merge build is broken as library-it is looking for
org.opendaylight.ovsdb:library-features:jar:1.5.0-SNAPSHOT
Change-Id: I4b229c8757c4fdb417a642a255ef6b1720a4255f
Signed-off-by: Vishal Thapar <vishal.thapar@ericsson.com>
Vishal Thapar [Tue, 20 Jun 2017 09:39:19 +0000 (15:09 +0530)]
BUG 8720: Add schema version information to Hwvtep node
Schema version information now available in HwvtGlobalNode. Applications
can use this to determine version of Hwvtp schema DB on the device.
Change-Id: I3b6dd3b296c3b263520bb622f45dfdd7ee4c4e81
Signed-off-by: Vishal Thapar <vishal.thapar@ericsson.com>
Anil Vishnoi [Wed, 21 Jun 2017 21:41:43 +0000 (14:41 -0700)]
Bump to odl-parent 2.0.0, remove karaf3 features and rename features4 to features
Change-Id: Idac9a7011449897e48da67caf9679bf0d3825f76
Signed-off-by: Anil Vishnoi <vishnoianil@gmail.com>
Vishal Thapar [Wed, 24 May 2017 09:43:58 +0000 (15:13 +0530)]
BUG 8529: Deleted vlantag and trunks present in operational
Change-Id: Iab1c46173127f74af4b81a80a5dfba4f7d29f936
Signed-off-by: Vishal Thapar <vishal.thapar@ericsson.com>
Ryan Goulding [Wed, 22 Mar 2017 10:43:47 +0000 (06:43 -0400)]
Migrate to karaf4 for the local karaf distribution
Several folks have put in incredible effort to make karaf4 a reality in ODL.
Kudos to those folks for this great effort. This patch officially converts
ovsdb's local karaf distributions to use odlparent's karaf4-parent artifact.
Change-Id: Ia86905565f739c42bb13cecb0f9e11e1cc20e02d
Signed-off-by: Ryan Goulding <ryandgoulding@gmail.com>
Stephen Kitt [Wed, 14 Jun 2017 08:13:21 +0000 (10:13 +0200)]
Don’t provide configfiles
configfiles mustn’t be <scope>provided</scope>, the dependency
resolver needs to be able to find them.
Change-Id: I924adf760e0573e40066425f6b6b3a4e3deedc53
Signed-off-by: Stephen Kitt <skitt@redhat.com>
Thanh Ha [Tue, 13 Jun 2017 20:27:10 +0000 (16:27 -0400)]
Migrate to odlparent 1.9.0
Change-Id: I5abf7f2024043a6a65675b1c0efba2df7d310792
Signed-off-by: Thanh Ha <thanh.ha@linuxfoundation.org>
Thanh Ha [Fri, 9 Jun 2017 23:10:41 +0000 (19:10 -0400)]
Migrate to odlparent 1.8.0-Carbon
Per request of odlparent project we are downgrading all Nitrogen
projects to use the released odlparent 1.8.0-Carbon to allow for the
odlparent project to start performing semver style releases.
Change-Id: I925d720fc25e82d972b7902f46f63550c3daaa5f
Jira: RELENG-159
RT: 41406
Signed-off-by: Thanh Ha <thanh.ha@linuxfoundation.org>
Anil Belur [Fri, 3 Mar 2017 04:50:58 +0000 (14:50 +1000)]
Add missing <name> fields for pom.xml files
This is used by autorelease scripts to automatically parse which project
is failing a build and report to the mailing list automatically. We need
names in the format:
ODL :: <groupId> :: <artifactId>
This patch formats in the same format as found in the startup archetypes
patch found here: https://git.opendaylight.org/gerrit/52522
Change-Id: Ib3621b8a5f2aa1e0b50aa0968b0b728081993772
Signed-off-by: Anil Belur <abelur@linuxfoundation.org>
Signed-off-by: Anil Vishnoi <vishnoianil@gmail.com>
Tomer Pearl [Wed, 15 Mar 2017 10:07:02 +0000 (12:07 +0200)]
Bug 7999 Adding Logical_Router table support
This patch adding support for using the Logical_Router table
in HWVTEP schema.
This addes data flow in (Config-Datastore -> Device) path and
(Device -> Operational-Datastore) path.
Change-Id: I3589f9b7076209c6168e698671cee8186501d3e9
Signed-off-by: Tomer Pearl <tomer.pearl@hpe.com>
K.V Suneelu Verma [Mon, 17 Apr 2017 12:57:22 +0000 (18:27 +0530)]
bug 8257 handling back to back ucast mac updates
Making the ucast mac remove command participate in
dependency resolution workflow.
Change-Id: Icc27763e3fdca46d12be89218d4f17758a7e8d93
Signed-off-by: K.V Suneelu Verma <k.v.suneelu.verma@ericsson.com>
K.V Suneelu Verma [Mon, 17 Apr 2017 12:45:14 +0000 (18:15 +0530)]
bug 8257 handling back to back logical switches
Making logical switches update/remove participate in
dependency resolution workflow.
When logical switch delete requests comes it is held until
the previous logical switch add request finishes and vice versa.
Change-Id: I5d158759a977f7a0f66dcafd297c4d2f06fa3fd4
Signed-off-by: K.V Suneelu Verma <k.v.suneelu.verma@ericsson.com>
K.V Suneelu Verma [Mon, 17 Apr 2017 11:25:13 +0000 (16:55 +0530)]
bug 8257 handling back to back mcast mac updates
Making the remove mcast mac participate in depenency resolution
flow.
Put the delete event on hold while the previous add/update on
the same key is still in transit.
Delete mcast mac event resumes after we receive the
response for the previous create.
Mark the state of the mcast mac key in transit while we execute its delete/add/update.
Change-Id: I0b15d82dad346bd2c35c0368b4d7f63dc3bfa09d
Signed-off-by: K.V Suneelu Verma <k.v.suneelu.verma@ericsson.com>
David Suarez [Wed, 10 May 2017 22:39:19 +0000 (00:39 +0200)]
Remove <prerequisites> from pom.xml to avoid WARNING
[WARNING] The project ... uses prerequisites which is only intended for
maven-plugin projects but not for non maven-plugin projects. For such
purposes you should use the maven-enforcer-plugin. See
https://maven.apache.org/enforcer/enforcer-rules/requireMavenVersion.html
This is already done in odlparent.
Change-Id: I489206437962deecf8ade54bd755f8141f228f92
Signed-off-by: David Suarez <david.suarez.fuentes@ericsson.com>
K.V Suneelu Verma [Tue, 7 Feb 2017 14:13:26 +0000 (19:43 +0530)]
bug 7985 Using UncaughtExceptionHandler in TransactionInvokerImpl
when a particular transaction command fails , it is killing the only
worker processing the transaction commands queue.
when the exection is caught log the exception and resubmit the worker
if 10 commands are to be exectuded
while executing 5th command some exception happens
then the execution resumes from 6th command ignoring the 5th command.
Again if 6th command also fails because of some exception,
then execution resumes from 7th command onwards that way it wont result in
infinite loops.
This patch does not try to address transaction failures, only addressing any
exceptions in the commands.
for transaction chain failures, let us say all 10 commands are executed
successfully and submitted to transaction chain, now we wait for
success/failure of each such transaction asynchronously.
Now our pending tx list reads as 1,2,3,4,5,6,7,8,9,10
we may get success response for 1,2,3,6,7 and failure for 5th.
Then pending tx list reads as 4,5,8,9,10.
then the transactions will resume from 8th onwards. Note 4th is not resumed.
This behavior may not be desired as we are trying to resubmit 8th one which
already got executed.
If the transactions are idempotent then it should not be an issue at all to
reexecute the succeded ones.
Now if the 8th transaction is about deleting an entry ,
in its previous run it already deleted it, so this run will fail.
Now for the 4th one we may get a success callback or failure callback.
If we get failure callback , then again 8,9,10 will be reexecuted.
This patch is not addressing this scenario , can be taken up in later
patches with the right design.
Note the difference between command execution and transaction result.
This patch is addressing exceptions in command execution.
Change-Id: I93bba958784637a4752b860d23354506f0bd98bb
Signed-off-by: K.V Suneelu Verma <k.v.suneelu.verma@ericsson.com>
K.V Suneelu Verma [Wed, 15 Mar 2017 11:52:13 +0000 (17:22 +0530)]
bug 7599 improving perf of ucast mac learning
when the device is connected all its macs are learnt in one update.
node.merge is called for each local ucast and remote ucast mac.
Now it is called only once.
when a mac update comes its physical locator need not be part of the
same update. If the locator is not available in the same update get
it from the cache ( which got filled from previous locators update msg).
Change-Id: Idbcf0b881b8ac90526f400c5d17d56a825f0a611
Signed-off-by: K.V Suneelu Verma <k.v.suneelu.verma@ericsson.com>
Praveen Mala [Mon, 9 Jan 2017 23:56:31 +0000 (18:56 -0500)]
Bug 7757 -Removing qos deprecations in carbon
remove leaf qos,leaf queue-uuid from the model and then the relevant code in the ovsdb plugin along with postman collection
Change-Id: I2003b0e9f7e7d17d1b28b19da0a2bf31cadd637a
Signed-off-by: Praveen Mala <praveen.mala@intel.com>
Vishal Thapar [Mon, 24 Apr 2017 12:25:39 +0000 (17:55 +0530)]
BUG 8280: TerminationPoint reconciliation fails
TerminationPointConfigReconciliationTask is incorrectly setting up
BridgeOperationalState to be empty. This ends up triggering reconciliation
even for ports that are already present in switch.
When we try to add ports that are already present we get constraint
violation in transaction and as per OVSDB RFC it causes all operations in
that transaction to abort. This means that the ports that actually needede
to be reconciled never get added back.
Change-Id: I48819f46b6419c15a8ba85541b06551b950a3055
Signed-off-by: Vishal Thapar <vishal.thapar@ericsson.com>
David [Thu, 20 Apr 2017 00:06:20 +0000 (02:06 +0200)]
BUG 6692 - Fix checkstyle problems not detected by the current version
This change is required for overall move to new Checkstyle version, see
https://git.opendaylight.org/gerrit/#/q/topic:bumpCheckstyle
Change-Id: If08990eaf8b849e6d826322eb1b7301996bc86c1
Signed-off-by: David <david.suarez.fuentes@ericsson.com>
K.V Suneelu Verma [Wed, 19 Apr 2017 06:28:22 +0000 (11:58 +0530)]
bug 7781 update vlan bindings and tunnel ips
When physical switch update arrives write it in op datastore.
Change-Id: I46ca4f70b59961eeebbc17c0073fe40f852278b5
Signed-off-by: K.V Suneelu Verma <k.v.suneelu.verma@ericsson.com>
Stephen Kitt [Fri, 17 Mar 2017 14:49:09 +0000 (15:49 +0100)]
Don't ignore .gitignore
Change-Id: I0153a81206b7b61e806c43eebdd8169aec0c9e20
Signed-off-by: Stephen Kitt <skitt@redhat.com>
Stephen Kitt [Mon, 10 Apr 2017 14:57:56 +0000 (16:57 +0200)]
Bug 7619: correct the southbound artifact
The feature repository should be southbound-features4, not features4.
Change-Id: I03250768f0371929f61eb79f6eca32752e16afe7
Signed-off-by: Stephen Kitt <skitt@redhat.com>
Anil Belur [Tue, 11 Apr 2017 01:45:53 +0000 (11:45 +1000)]
Bump versions by x.(y+1).z for next dev cycle
Change-Id: Ic79657f79b3797f49466d89dfba2923b67625e4c
Signed-off-by: Anil Belur <abelur@linuxfoundation.org>
Josh [Sun, 26 Mar 2017 09:11:30 +0000 (12:11 +0300)]
Bug-8053 OVS Bridge other_config:hwaddr not preserved for nodes not in config DS
SouthboundUtils.addBridge - add version that takes other configs
Change-Id: Id451a850db7e99aef013decc4466e67feb1370b7
Signed-off-by: Josh <jhershbe@redhat.com>
Tomer Pearl [Mon, 20 Mar 2017 12:08:41 +0000 (14:08 +0200)]
Bug 7779: Adding try-catch in hwvtep transactions.
Adding Try-Catch in TransactCommandAggregator
and HwvtepOperationalCommandAggregator , so no single failure
will cause us to stop processing other commands.
Catching specific exceptions instead of a generic Exception.
Change-Id: I8e552119e402de93a1c37cf87397451583f02294
Signed-off-by: Tomer Pearl <tomer.pearl@hpe.com>
Stephen Kitt [Thu, 30 Mar 2017 17:42:23 +0000 (19:42 +0200)]
Add Karaf 4 artifacts
Change-Id: I930f11d8814ac1b6eaa1f43d45ed6031f170ede8
Signed-off-by: Stephen Kitt <skitt@redhat.com>
Stephen Kitt [Fri, 31 Mar 2017 13:04:49 +0000 (15:04 +0200)]
Bug 8130: downgrade Karaf 3 dep to provided
org.apache.karaf.features.core is provided by the Karaf container, we
only need the dependency at compile-time.
Change-Id: I582602b297b639fb5884682303c047d32dd0f8f5
Signed-off-by: Stephen Kitt <skitt@redhat.com>
Stephen Kitt [Fri, 10 Mar 2017 16:37:29 +0000 (17:37 +0100)]
Bug 8055: use Java collection constructors
... instead of Guava's, where appropriate.
Change-Id: I4f20e86bd65d5b7a530fa631721d1ed7a4345c19
Signed-off-by: Stephen Kitt <skitt@redhat.com>
Stephen Kitt [Fri, 10 Mar 2017 15:59:15 +0000 (16:59 +0100)]
Bug 8055: various performance issues
* Use Collections.singletonList() instead of Arrays.asList() with a
single argument.
* Avoid calling toString() on String objects.
* Avoid constructing new Strings with String constants.
* Avoid String concatenation in StringBuffer.append() calls.
Change-Id: I9e1c338b89bc7e914092a388ccb6b3022c9992ff
Signed-off-by: Stephen Kitt <skitt@redhat.com>
Stephen Kitt [Fri, 10 Mar 2017 15:58:20 +0000 (16:58 +0100)]
Bug 8055: remove redundant array creation
Change-Id: I876410c5ac9fecaab94cecd2fb37f44bd115762b
Signed-off-by: Stephen Kitt <skitt@redhat.com>
Stephen Kitt [Fri, 10 Mar 2017 15:57:42 +0000 (16:57 +0100)]
Bug 8055: remove unnecessary type casts
Change-Id: I02000e8afff1f7748a959368742d9eb8f7fd518e
Signed-off-by: Stephen Kitt <skitt@redhat.com>
Stephen Kitt [Fri, 10 Mar 2017 15:56:22 +0000 (16:56 +0100)]
Bug 8055: remove unnecessary type arguments
Change-Id: Ifa4d36624aeea12de43744460ba0bf43b2094f1c
Signed-off-by: Stephen Kitt <skitt@redhat.com>
Stephen Kitt [Fri, 10 Mar 2017 15:53:27 +0000 (16:53 +0100)]
Bug 8055: simplify a couple of streams
Change-Id: I3cd16e6a2f2c907b96856d91c12997d98cbe9831
Signed-off-by: Stephen Kitt <skitt@redhat.com>
Stephen Kitt [Thu, 9 Mar 2017 08:16:44 +0000 (09:16 +0100)]
Bug 8055: use method references instead of lambdas
Change-Id: I34e0108612abe51bbf9fe19e4cf5cdbe41592cef
Signed-off-by: Stephen Kitt <skitt@redhat.com>
Stephen Kitt [Thu, 9 Mar 2017 08:15:17 +0000 (09:15 +0100)]
Bug 8055: use Java 8 predicates instead of Guava
Change-Id: I724a807f78c4041964e614f332cc811ebd20e60f
Signed-off-by: Stephen Kitt <skitt@redhat.com>
Stephen Kitt [Wed, 8 Mar 2017 16:03:45 +0000 (17:03 +0100)]
Bug 8055: use lambdas instead of anonymous classes
Change-Id: I72b437b9e225f022fa3c55492f6b0f9751450dea
Signed-off-by: Stephen Kitt <skitt@redhat.com>
Stephen Kitt [Wed, 8 Mar 2017 10:46:18 +0000 (11:46 +0100)]
Bug 8055: remove unnecessary type parameters
Change-Id: I8baabd6823a1876c84db323e56c120c8e2474629
Signed-off-by: Stephen Kitt <skitt@redhat.com>
Stephen Kitt [Wed, 8 Mar 2017 10:38:02 +0000 (11:38 +0100)]
Bug 8055: remove all unused imports
Change-Id: I6eef86c1c20b75c3584c702d16c8a01c22358b7a
Signed-off-by: Stephen Kitt <skitt@redhat.com>
K.V Suneelu Verma [Mon, 13 Feb 2017 10:27:22 +0000 (15:57 +0530)]
bug 7781 update vlan bindings and tunnel ips
1) when the vlan bindings is deleted in the device , the same thing is not
deleted in operational datastore because the port to be updated is not
searched properly.
2) When the tunnel ip is updated, as the physical switch is merged the
tunnel ips child is appened. Excluded the tunnel ips from physical switch
merge operation and adding and removing them seperately.
Change-Id: I64004638a6ce5031fd0f15fad3586f8c84f869db
Signed-off-by: K.V Suneelu Verma <k.v.suneelu.verma@ericsson.com>
K.V Suneelu Verma [Wed, 15 Mar 2017 11:14:44 +0000 (16:44 +0530)]
bug 7599 rename opData method as operData
Change-Id: I468ce2289fe2e11bdec0445f960cf38bb0e9798b
Signed-off-by: K.V Suneelu Verma <k.v.suneelu.verma@ericsson.com>
K.V Suneelu Verma [Tue, 7 Feb 2017 13:00:15 +0000 (18:30 +0530)]
bug 7599 avoid mdsal read
while processing the config update avoid mdsal read
maintain the instance identifier vs connectionInstance map.
Update the map upon GlobalUpdate.
Clear the map upon node disconnect event.
Use the map to identifiy the connectionInstance for the changed node.
Change-Id: I8cbb505f0e56bdc0a3f5b46104a26aa02381ad6f
Signed-off-by: K.V Suneelu Verma <k.v.suneelu.verma@ericsson.com>
K.V Suneelu Verma [Sun, 5 Feb 2017 09:05:08 +0000 (14:35 +0530)]
bug 7599 improve perf of ucast mcas
for ucast macs update do not read operational state again
get the relevant data from local device info.
This avoids reading the whole node possibly from the other cluster node
for processing a single ucast mac update.
Change-Id: I14eb4419a208a7d38cb665d1ac94b0c41c18bcfe
Signed-off-by: K.V Suneelu Verma <k.v.suneelu.verma@ericsson.com>
K.V Suneelu Verma [Sun, 5 Feb 2017 05:56:07 +0000 (11:26 +0530)]
bug 7599 performance improvement for ucast macs
Using the getModifiedChildren api on the modification to identify the
modified children data under node.
updated data and deleted data is stored in operational state for access
by all the commands.
Added the following accessor methods in operational state.
List<? extends Identifiable> getUpdatedData(InstanceIdentifier<Node> key,
Class<? extends Identifiable> cls)
List<? extends Identifiable> getDeletedData(InstanceIdentifier<Node> key,
Class<? extends Identifiable> cls)
Change-Id: I76584d7c90323313da35e28a600019c05081f9d0
Signed-off-by: K.V Suneelu Verma <k.v.suneelu.verma@ericsson.com>
Anil Vishnoi [Wed, 8 Mar 2017 08:06:48 +0000 (00:06 -0800)]
Bug 7160 - operational store still has node after ovs disconnects
Change-Id: I4b8c333bc24fd5d406a8df55f375bb9c51622eb0
Signed-off-by: Anil Vishnoi <vishnoianil@gmail.com>
Michael Vorburger [Tue, 7 Mar 2017 23:41:34 +0000 (00:41 +0100)]
Fix NPE in OvsdbConnectionService updateConfigParameter
seen in SingleFeatureTest (SFT) running under Karaf 4
maybe under Karaf 3 this was never called with null, but under 4 it is
Change-Id: I886ccf99ef4be85b6e103d69fa457ec4a0dab4d9
Signed-off-by: Michael Vorburger <vorburger@redhat.com>
Michael Vorburger [Tue, 7 Mar 2017 23:35:26 +0000 (00:35 +0100)]
Fix Checkstyle "Redundant Modifier: Redundant 'final' modifier."
Change-Id: I07c5ac0c61594fc9b2e4faa1d0d028d75348df53
Signed-off-by: Michael Vorburger <vorburger@redhat.com>
Stephen Kitt [Mon, 13 Feb 2017 16:11:07 +0000 (17:11 +0100)]
Add ovsdb southbound Karaf 4 features
Bug: 7619
Change-Id: I813e2b0bddf79b03a6c4925c28407b7857973e36
Signed-off-by: Stephen Kitt <skitt@redhat.com>
Stephen Kitt [Thu, 9 Feb 2017 07:44:46 +0000 (08:44 +0100)]
Add ovsdb hwvtep Karaf 4 features
Bug: 7619
Change-Id: Id9da6ff6362a6defb7c20362248d9c832213cd60
Signed-off-by: Stephen Kitt <skitt@redhat.com>
Stephen Kitt [Thu, 9 Feb 2017 07:24:21 +0000 (08:24 +0100)]
Add ovsdb library Karaf 4 features
Bug: 7619
Change-Id: Iac6d17015c85e21e2e3de26bfa3b2285b3869516
Signed-off-by: Stephen Kitt <skitt@redhat.com>
Anil Vishnoi [Wed, 22 Feb 2017 07:40:26 +0000 (23:40 -0800)]
Bug 7836 - Make OVSDB southbound plugin listener port configurable
Change-Id: Ic59cb1af40de46e150bb09ec584f362755ed7e62
Signed-off-by: Anil Vishnoi <vishnoianil@gmail.com>
Anil Vishnoi [Wed, 22 Feb 2017 02:38:08 +0000 (18:38 -0800)]
Bug 2487 - Too large configuration file from OVS
Change-Id: Id8d7c9864503cb996112207c6018957ca302a3ad
Signed-off-by: Anil Vishnoi <vishnoianil@gmail.com>
Lorand Jakab [Fri, 3 Feb 2017 13:06:05 +0000 (15:06 +0200)]
Checkstyle: fix ParenPad violations
Enforcing no space(s) after a left parenthesis and before a right
parenthesis is a proposed change [0] which can only be merged when all
violations are fixed in projects enforcing checkstyle. This patch fixes
those violations.
[0] https://git.opendaylight.org/gerrit/#/c/51316/
Change-Id: I70e3a8443a05615979fd149a9881bd6ca4b01125
Signed-off-by: Lorand Jakab <lojakab@cisco.com>
Michael Vorburger [Mon, 23 Jan 2017 18:58:43 +0000 (19:58 +0100)]
Replace mockito-all by mockito-core (see Bug 7662)
Change-Id: Ie67cd9d6b29672cefa581006015ca5d3a53da563
Signed-off-by: Michael Vorburger <vorburger@redhat.com>
Anil Vishnoi [Thu, 2 Feb 2017 20:26:14 +0000 (12:26 -0800)]
Bug 7023 - NPE at org.opendaylight.ovsdb.southbound.OvsdbConnectionManager.getClient
Change-Id: If157e70dbbbafa39d2334c1704f0ae9d7460bbda
Signed-off-by: Anil Vishnoi <vishnoianil@gmail.com>