Somashekar Byrappa [Wed, 16 May 2018 10:08:46 +0000 (15:38 +0530)]
Utility method to check IP address is within CIDR range
JIRA: NETVIRT-1213
Change-Id: I0714c5a8cfceee397baf4056689bee3c48d14154
Signed-off-by: Somashekar Byrappa <somashekar.b@altencalsoftlabs.com>
Faseela K [Wed, 2 May 2018 09:50:27 +0000 (15:20 +0530)]
JIRA: GENIUS-130 Spec - OF Tunnels Support For ITM Direct Tunnels
Change-Id: I63920177eaeb57f702568e7c7a93662a8bffa40c
Signed-off-by: Faseela K <faseela.k@ericsson.com>
Michael Vorburger [Wed, 23 May 2018 18:19:54 +0000 (20:19 +0200)]
migrate TepShowState from deprecated OsgiCommandSupport to Action
nota bene https://issues.apache.org/jira/browse/KARAF-5767
Change-Id: I99133078466bd400d912e6d20de11b1dcf633e69
Signed-off-by: Michael Vorburger <vorburger@redhat.com>
Faseela K [Tue, 29 May 2018 23:56:32 +0000 (05:26 +0530)]
JIRA: GENIUS-141 DataTreeEventCallbackRegistrar should use ClusteredListener
If DataTreeEventCallbackRegistrar does not use ClusteredListener, there can be cases
in a 3 node cluster where the event call back will be not executed, as the
shard leader for the DS on which the listener is registered can be on a different
node where the callback is not available.
Making DataTreeEventCallbackRegistrar directly use ClusteredDataTreeChangeListener
does not seem to be a problem, as the callback will be available only on one node.
Change-Id: Idcb4b6a3ee709aea14c5fe09bc416100ddaa5519
Signed-off-by: Faseela K <faseela.k@ericsson.com>
Faseela K [Tue, 29 May 2018 09:21:25 +0000 (14:51 +0530)]
Format ITM yang models
No changes to the model is done, only indentation is fixed :)
Change-Id: I06fc2a7285525686186dd396d0cbaf331c821d78
Signed-off-by: Faseela K <faseela.k@ericsson.com>
Karthikeyan Krishnan [Wed, 23 May 2018 12:23:07 +0000 (17:53 +0530)]
NxmOfFieldType support for IPv6 Protocol
The following NXM_NX Fields are needs to be supported as part of IPv6 Punt
Path Protection implementation. This changes is dependent on IPv6
Controller Punt Path Protection support in NETVIRT.
* NXM_NX_IPV6_SRC(19)
* NXM_NX_IPV6_DST(20)
Ref: http://www.openvswitch.org/support/dist-docs/ovs-fields.7.pdf
Change-Id: Ie2bfc988cdfe161988cc51c7fd88b1c69ee4a032
Signed-off-by: Karthikeyan Krishnan <karthikeyangceb007@gmail.com>
Michael Vorburger [Fri, 25 May 2018 13:15:35 +0000 (15:15 +0200)]
fix bug in AlivenessMonitor
introduced in change I508ef8a4c54fbc2af4ae3af56755af73bf192dae
JIRA: GENIUS-140
Change-Id: I7cdc27b5c3db0f26403d1047ac2ccdc6a59ef2b2
Signed-off-by: Michael Vorburger <vorburger@redhat.com>
Robert Varga [Fri, 25 May 2018 15:09:58 +0000 (17:09 +0200)]
Eliminate InstanceIdentifier.toInstance() reference
This method has been long-deprecated, do not use it.
Change-Id: Iedd854b3a988767d1188d944ff032d41398c0995
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
Faseela K [Wed, 16 May 2018 11:11:23 +0000 (16:41 +0530)]
ITM Tunnels State Container should be operational
Change-Id: Ifd0b84f2c0913564e0dbc3d6c9a095d7aff8c943
Signed-off-by: Faseela K <faseela.k@ericsson.com>
David Suarez [Thu, 3 May 2018 22:50:34 +0000 (00:50 +0200)]
Migrate InterfaceConfigListener to use the new listeners
- Code simplification by using lambdas
- Remove unused services injected
- Other minor changes
Change-Id: Ie60556f42b553618c13205191e1ac3e77ddf860d
Signed-off-by: David Suarez <david.suarez.fuentes@gmail.com>
Michael Vorburger [Thu, 24 May 2018 12:31:19 +0000 (14:31 +0200)]
remove non-needed Maven plugin from fcapsapplication-impl
The maven-bundle-plugin and yang-maven-plugin are configured
in genius:binding-parent already, the build-helper-maven-plugin
is not needed. (The blueprint-maven-plugin IS required.)
This avoids this ugly message we see at the top of each build:
[WARNING] Some problems were encountered while building the effective model for org.opendaylight.genius:fcapsapplication-impl:bundle:0.5.0-SNAPSHOT
[WARNING] 'build.plugins.plugin.version' for org.opendaylight.yangtools:yang-maven-plugin is missing. @ org.opendaylight.genius:fcapsapplication-impl:[unknown-version], /home/vorburger/dev/ODL/git/genius/fcapsapplication/fcapsapplication-impl/pom.xml, line 75, column 15
[WARNING]
[WARNING] It is highly recommended to fix these problems because they threaten the stability of your build.
[WARNING]
[WARNING] For this reason, future Maven versions might no longer support building such malformed projects.
Change-Id: I60fc6fd71dbde66dbac4c922eb47246aa5a5fd66
Signed-off-by: Michael Vorburger <vorburger@redhat.com>
Michael Vorburger [Thu, 24 May 2018 12:26:52 +0000 (14:26 +0200)]
remove <version>${genius.version} from GAV
because this is inherited from <parent> and avoid this:
[WARNING] Some problems were encountered while building the effective model for org.opendaylight.genius:interfacemanager-shell:bundle:0.4.2-SNAPSHOT
[WARNING] 'version' contains an expression but should be a constant. @ org.opendaylight.genius:interfacemanager-shell:${genius.version}, /w/workspace/integration-multipatch-test-fluorine/patch_tester/genius/interfacemanager/interfacemanager-shell/pom.xml, line 22, column 14
Change-Id: Ibb8b91b06ef63fb8292e02503b4c711069650e1b
Signed-off-by: Michael Vorburger <vorburger@redhat.com>
Faseela K [Mon, 30 Apr 2018 07:27:41 +0000 (12:57 +0530)]
TSC-99 Adjust to RPC method signature update
Change-Id: I1307120c6400e225a3e5e3e2344648ea5c7c5396
Signed-off-by: Faseela K <faseela.k@ericsson.com>
Dimple Jain [Fri, 18 May 2018 20:12:32 +0000 (01:42 +0530)]
Fixing bug while updating port status to UNKNOWN.
For ITM direct tunnels, state tunnel list was not getting updated to
UNKNOWN only if monitoring was disabled. Fix is removal of the
monitoring check.
Change-Id: I6fa26fab874de22b247adca3ddfc178a460a1a29
Signed-off-by: Dimple Jain <dimple.jain@ericsson.com>
Michael Vorburger [Mon, 30 Apr 2018 11:35:39 +0000 (13:35 +0200)]
introduce TestableDataBroker (with TestableDataBrokerTest)
JIRA: GENIUS-122
Change-Id: Ibebecdd2b387cc33079f2c669199b6f590866e8a
Signed-off-by: Michael Vorburger <vorburger@redhat.com>
David Suarez [Thu, 3 May 2018 21:05:57 +0000 (23:05 +0200)]
Migrate HwVTEPTunnelStateListener to use the new listeners
- Code simplification by using lambdas
- Other minor changes
Note: HwvtepAbstractDataTreeChangeListener might be removed, once
verified that is not used elsewhere, in a separate commit.
Change-Id: I686f00272fe4888cc1b00db0710248ade7313220
Signed-off-by: David Suarez <david.suarez.fuentes@gmail.com>
Josh [Sun, 22 Apr 2018 06:36:55 +0000 (09:36 +0300)]
Add default genius-mdsaulutil-config.xml
Change-Id: I87cb6fd5da8b02fafa07823ce161ab1e2b156a15
Signed-off-by: Josh <jhershbe@redhat.com>
Signed-off-by: Michael Vorburger <vorburger@redhat.com>
Hema Gopalakrishnan [Fri, 4 May 2018 05:04:57 +0000 (10:34 +0530)]
Pipeline changes incorporated for TaaS
Included the pipeline changes for Tap as a Service(TaaS) feature.
Here is a link to the Spec for TaaS - https://git.opendaylight.org/gerrit/#/c/71691/
Updated with Table no 180,181
Updated the pipeline RST file
Change-Id: I42ef02a4e6ceeff065e253d2f1d66ee4b80439d3
Signed-off-by: Hema Gopalakrishnan <hema.gopalkrishnan@ericsson.com>
Dimple Jain [Wed, 16 May 2018 08:18:06 +0000 (13:48 +0530)]
ITM Direct Tunnels: Handling of UNKNOWN port status.
Updating the tunnel interface state to UNKNOWN on receiving
FlowCapableNodeConnector remove notification with reason
other than DELETE.
Change-Id: I06a52f803c635065f1e70811b6213b869178c920
Signed-off-by: Dimple Jain <dimple.jain@ericsson.com>
Tom Pantelis [Mon, 30 Apr 2018 14:12:35 +0000 (10:12 -0400)]
Remove AsyncWriteTransaction.submit() impls
The submit() method is now defaulted in the interface
so implementations don't need to implement it.
Change-Id: I15916f53797552d165c61b9f5b637017f863011c
Signed-off-by: Tom Pantelis <tompantelis@gmail.com>
Tom Pantelis [Tue, 1 May 2018 21:22:07 +0000 (17:22 -0400)]
Fix concurrency edge cases in DataTreeEventCallbackRegistrar
Also added UT's for various edge cases.
Change-Id: Ieecb1ba9a509d606952165dad52a4c870c4b8b5e
Signed-off-by: Tom Pantelis <tompantelis@gmail.com>
Michael Vorburger [Mon, 16 Apr 2018 14:00:19 +0000 (16:00 +0200)]
add timeout support to DataTreeEventCallbackRegistrar
JIRA: GENIUS-122
Change-Id: I628d7e85f47662c82b42b55c43227b70df354680
Signed-off-by: Michael Vorburger <vorburger@redhat.com>
Edw7n [Fri, 11 May 2018 10:39:48 +0000 (16:09 +0530)]
To fix bfd status related issue
seen on ovs restart in tdd-wip
Change-Id: Iaaf997db33109941409b7da3ac405be3cdf98a8f
Signed-off-by: Edw7n <n.edwin.anthony@ericsson.com>
(cherry picked from commit
43154768adf28898381c675ba1713cd0a9639a43)
Faseela K [Thu, 10 May 2018 17:21:27 +0000 (22:51 +0530)]
Minor log clean-up and method name change to align to OVS
Change-Id: I1a410e1cfda92ad2499709cde4bc3ddf1133fe9e
Signed-off-by: Faseela K <faseela.k@ericsson.com>
Jamo Luhrsen [Wed, 9 May 2018 03:44:39 +0000 (20:44 -0700)]
Stop git from thinking logo.png has changed
something in our build systems thinks there is something
different about line endings now that the logo.png
file has been put in the genius repo. Removing eol=lf
should prevent that. I'm not totally understanding
what is happening, as this is not a problem on a local
linux system, and our build systems are centos7 so I
would expect the problem to be in both places.
some extra reading here:
https://help.github.com/articles/dealing-with-line-endings/
Change-Id: I4809c34cb04e63563f314bdc7086f0a76955c470
Signed-off-by: Jamo Luhrsen <jluhrsen@redhat.com>
Michael Vorburger [Mon, 7 May 2018 10:56:22 +0000 (12:56 +0200)]
remove un-used arguments in InterfaceInventoryStateListener
JIRA: GENIUS-133
Change-Id: I5111839d87648c458c07c597229f9a78823dcde9
Signed-off-by: Michael Vorburger <vorburger@redhat.com>
Faseela K [Fri, 4 May 2018 08:51:50 +0000 (14:21 +0530)]
OVS Port Delete not going through
JIRA: GENIUS-133
Deletion of OVS port is resulting in the below error:
mainWorker=InterfaceStateRemoveWorker{nodeConnectorIdNew=Uri{_value=openflow:
68797520762178:2},
nodeConnectorIdOld=Uri{_value=openflow:
68797520762178:2}, fcNodeConnectorOld=FlowCapableNodeConnector{
getAdvertisedFeatures=PortFeatures{_tenMbHd=false, _tenMbFd=false, _hundredMbHd=false, _hundredMbFd=false,
_oneGbHd=false, _oneGbFd=false, _tenGbFd=false, _fortyGbFd=false, _hundredGbFd=false, _oneTbFd=false, _other=false,
_copper=false, _fiber=false, _autoeng=false, _pause=false, _pauseAsym=false}, getConfiguration=PortConfig{_pORTDOWN=false,
_nORECV=false, _nOFWD=false, _nOPACKETIN=false}, getCurrentFeature=PortFeatures{_tenMbHd=false, _tenMbFd=false,
_hundredMbHd=false, _hundredMbFd=false, _oneGbHd=false, _oneGbFd=false, _tenGbFd=false, _fortyGbFd=false,
_hundredGbFd=false, _oneTbFd=false, _other=false, _copper=false, _fiber=false, _autoeng=false, _pause=false,
_pauseAsym=false}, getCurrentSpeed=0, getHardwareAddress=MacAddress{_value=9a:be:c5:8b:90:d2}, getMaximumSpeed=0,
getName=tun704bde687e8, getPeerFeatures=PortFeatures{_tenMbHd=false, _tenMbFd=false, _hundredMbHd=false,
_hundredMbFd=false, _oneGbHd=false, _oneGbFd=false, _tenGbFd=false, _fortyGbFd=false, _hundredGbFd=false, _oneTbFd=false,
_other=false, _copper=false, _fiber=false, _autoeng=false, _pause=false, _pauseAsym=false}, getPortNumber=
PortNumberUni{_uint32=2}, getQueue=[], getReason=Delete, getState=State{isBlocked=false, isLinkDown=false,
isLive=false, augmentations={}}, getSupported=PortFeatures{_tenMbHd=false, _tenMbFd=false, _hundredMbHd=false,
_hundredMbFd=false,_oneGbHd=false, _oneGbFd=false, _tenGbFd=false, _fortyGbFd=false, _hundredGbFd=false,
_oneTbFd=false, _other=false, _copper=false, _fiber=false, _autoeng=false, _pause=false, _pauseAsym=false}},
interfaceName='tun704bde687e8'}, rollbackWorker=null, retryCount=6/6, futures=[com.google.common.util.concurrent.
ImmediateFuture$ImmediateFailedFuture@
6a75e6cd[status=FAILURE, cause=[java.lang.UnsupportedOperationException: submit()
cannot be used inside a Managed[New]TransactionRunner]]]}
java.lang.UnsupportedOperationException: submit() cannot be used inside a Managed[New]TransactionRunner
at org.opendaylight.genius.infra.NonSubmitCancelableReadWriteTransaction.submit(NonSubmitCancelableReadWriteTransaction.java:36) ~[332:org.opendaylight.genius.mdsalutil-api:0.5.0.SNAPSHOT]
at org.opendaylight.genius.interfacemanager.listeners.InterfaceInventoryStateListener$InterfaceStateRemoveWorker.handleTunnelMonitoringRemoval(InterfaceInventoryStateListener.java:424) ~[?:?]
at org.opendaylight.genius.interfacemanager.listeners.InterfaceInventoryStateListener$InterfaceStateRemoveWorker.lambda$removeInterfaceStateConfiguration$0(InterfaceInventoryStateListener.java:398) ~[?:?]
at org.opendaylight.genius.infra.ManagedNewTransactionRunnerImpl.callWithNewReadWriteTransactionAndSubmit(ManagedNewTransactionRunnerImpl.java:63) [332:org.opendaylight.genius.mdsalutil-api:0.5.0.SNAPSHOT]
at org.opendaylight.genius.interfacemanager.listeners.InterfaceInventoryStateListener$InterfaceStateRemoveWorker.removeInterfaceStateConfiguration(InterfaceInventoryStateListener.java:378) [326:org.opendaylight.genius.interfacemanager-impl:0.5.0.SNAPSHOT]
at org.opendaylight.genius.interfacemanager.listeners.InterfaceInventoryStateListener$InterfaceStateRemoveWorker.call(InterfaceInventoryStateListener.java:355) [326:org.opendaylight.genius.interfacemanager-impl:0.5.0.SNAPSHOT]
at org.opendaylight.genius.interfacemanager.listeners.InterfaceInventoryStateListener$InterfaceStateRemoveWorker.call(InterfaceInventoryStateListener.java:318) [326:org.opendaylight.genius.interfacemanager-impl:0.5.0.SNAPSHOT]
at org.opendaylight.infrautils.jobcoordinator.internal.JobCoordinatorImpl$MainTask.runWithUncheckedExceptionLogging(JobCoordinatorImpl.java:401) [352:org.opendaylight.infrautils.jobcoordinator-impl:1.4.0.SNAPSHOT]
at org.opendaylight.infrautils.utils.concurrent.LoggingUncaughtThreadDeathContextRunnable.run(LoggingUncaughtThreadDeathContextRunnable.java:60) [357:org.opendaylight.infrautils.util:1.4.0.SNAPSHOT]
at java.util.concurrent.ForkJoinTask$RunnableExecuteAction.exec(ForkJoinTask.java:1402) [?:?]
at java.util.concurrent.ForkJoinTask.doExec(ForkJoinTask.java:289) [?:?]
at java.util.concurrent.ForkJoinPool$WorkQueue.runTask(ForkJoinPool.java:1056) [?:?]
at java.util.concurrent.ForkJoinPool.runWorker(ForkJoinPool.java:1692) [?:?]
at java.util.concurrent.ForkJoinWorkerThread.run(ForkJoinWorkerThread.java:157) [?:?]
Change-Id: I5d0e634bdf24f159f018ed8ff8bdf9cacd98a78a
Signed-off-by: Faseela K <faseela.k@ericsson.com>
David Suarez [Thu, 3 May 2018 21:31:37 +0000 (23:31 +0200)]
Fix a typo
Change-Id: I1c8b7b67148c0de3d4fc4624c3ec169b7511d5dc
Signed-off-by: David Suarez <david.suarez.fuentes@gmail.com>
Tom Pantelis [Fri, 27 Apr 2018 17:22:04 +0000 (13:22 -0400)]
Implement AsyncWriteTransaction.commit()
Implement the new commit() method which uses FluentFuture
instead of the deprecated CheckedFuture. The commit() method
is defaukted in the interface but, as soon as all implementations
implement commit(), the deprecated submit() method will be defaulted
instead.
Change-Id: Icbd987b95c6fc8f0a7cce61870e93365daf47967
Signed-off-by: Tom Pantelis <tompantelis@gmail.com>
Michael Vorburger [Thu, 12 Apr 2018 17:05:39 +0000 (19:05 +0200)]
remove un-used pax-cdi-api from tools-api
Change-Id: I72799ecfbf8cfca2e394abf4030df1f6fdbeec10
Signed-off-by: Michael Vorburger <vorburger@redhat.com>
Thanh Ha [Tue, 1 May 2018 18:52:22 +0000 (14:52 -0400)]
Switch to using lfdocs-conf to pull in theme
lfdocs-conf is a new project that allows us to centrally manage
project theme configuration without having to duplicate it
everywhere or have the "docs" project become a large submodule
project.
We will push to ReadTheDocs separately and then create a new path
for this doc under docs.opendaylight.org/projects/integration-packaging
For further details refer to:
http://docs.releng.linuxfoundation.org/en/latest/project-documentation.html
Issue: DOCS-69
Change-Id: I2259eea16a3cc6a52d1b72ee67a84ca6439dca6c
Signed-off-by: Thanh Ha <thanh.ha@linuxfoundation.org>
Vishal Thapar [Fri, 27 Apr 2018 06:29:41 +0000 (11:59 +0530)]
GENIUS-117 Create MPLSGRE only for OVS2.8.0+
1. Added logic to get OVS version
2. If OVS Version is 2.8.0+ create MplsOverGre tunnel
3. Else, return without creating tunnel port
Change-Id: If8178dcc2f5f49b4293bbb5ba62b37319a12daa1
Signed-off-by: Vishal Thapar <vishal.thapar@ericsson.com>
Signed-off-by: Vishal Thapar <vthapar@redhat.com>
David Suarez [Mon, 2 Apr 2018 22:07:05 +0000 (00:07 +0200)]
Migrate FlowBasedServicesInterfaceStateListener to use new listeners fw
Other minor changes
Change-Id: I480573521a755827dfc2bf6d4608975bd888397f
Signed-off-by: David Suarez <david.suarez.fuentes@gmail.com>
Michael Vorburger [Fri, 20 Apr 2018 16:31:18 +0000 (18:31 +0200)]
use MBeanUtils getMBeanAttribute instead deprecated readMBeanAttribute
and handle the possibly thrown exception here in the caller, instead of
burying that in the utility, and (erroneously) returning null to the
caller.
also fix up an unrelated logical error in this
DatastoreServiceStatusProvider which had me scratching my head for a
moment: The volatile ServiceDescriptor field really makes no sense, and
is actually not really needed; it wasn't even used in
getServiceDescriptor() anyway.
Change-Id: I1813d1a7e709b2fb3d4e564de14c0080afa4c000
Signed-off-by: Michael Vorburger <vorburger@redhat.com>
Edw7n [Sat, 28 Apr 2018 11:24:37 +0000 (16:54 +0530)]
To fix Elan Junits because of
https://git.opendaylight.org/gerrit/#/c/68397/
Change-Id: I9e2d285e18cea4ec44cfe5794ee5772843708633
Signed-off-by: Edw7n <n.edwin.anthony@ericsson.com>
Edw7n [Thu, 19 Apr 2018 04:18:25 +0000 (09:48 +0530)]
Rpc changes for performance enhacements
corresponding netvirt changes:
https://git.opendaylight.org/gerrit/#/c/68187/
Change-Id: I142de600b189ba1e803779a7ba47be714efb4764
Signed-off-by: Edw7n <n.edwin.anthony@ericsson.com>
Michael Vorburger [Thu, 19 Apr 2018 12:59:20 +0000 (14:59 +0200)]
replace findbugs' @SuppressWarnings by @SuppressFBWarnings
Change-Id: Iebe8b04c1409a769e91ea545abcbc97e987b7794
Signed-off-by: Michael Vorburger <vorburger@redhat.com>
Michael Vorburger [Fri, 20 Apr 2018 08:46:51 +0000 (10:46 +0200)]
fix catch ReadFailedException LOG.debug in TunnelTopologyStateListener
the point of callWithNewWriteOnlyTransactionAndSubmit is that it deals
with and correctly propagates (into the Future, here to the
JobCoordinator) any failures; you're abusing that with the catch.
Change-Id: Icd0d16a6bcbd01b83f1a2200843934160751b76d
Signed-off-by: Michael Vorburger <vorburger@redhat.com>
David Suarez [Sat, 21 Apr 2018 08:17:44 +0000 (10:17 +0200)]
Make new Genius' listeners testable
Make new Genius' listeners testable old ones by implementing the
ChainableDataTreeChangeListener interface.
Change-Id: Ia321ad95956eba717afb3de56c4ef4afb14e771a
Signed-off-by: David Suarez <david.suarez.fuentes@gmail.com>
Edw7n [Wed, 25 Apr 2018 03:34:21 +0000 (09:04 +0530)]
Adding API support for ELAN
Support for fetching Interface information from tunnelName
Change-Id: Ibc067c3c05b02fc30cc6bd0e20040457744c3cd4
Signed-off-by: Edw7n <n.edwin.anthony@ericsson.com>
David Suarez [Thu, 19 Apr 2018 19:17:02 +0000 (21:17 +0200)]
Move ChainableDataTreeListener to tools-api
Change-Id: I9401d9a623a0ac141d0f6d03bbf9ce2810da1462
Signed-off-by: David Suarez <david.suarez.fuentes@gmail.com>
Robert Varga [Thu, 26 Apr 2018 09:47:14 +0000 (11:47 +0200)]
Add mdsalutil-api and tools-api to artifacts
Downstreams are using properties to declare these versions in
a consistent manner. Add them to artifacts, so that a consistent
set of artifacts can be imported into dependencyManagement.
Change-Id: I020e409c80fc6fff85adb94e6f84381050e6d124
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
Tarun Thakur [Fri, 13 Apr 2018 09:31:36 +0000 (15:01 +0530)]
GENIUS-121: TEP with same local & remote IP
TEP is created with same local & remote IP when br-int is removed and added.
Change-Id: Idde1dabad34113ee41cf79a4cab973ba5d10813b
Signed-off-by: Tarun Thakur <tarun.t@altencalsoftlabs.com>
Michael Vorburger [Fri, 6 Apr 2018 19:28:51 +0000 (21:28 +0200)]
increase code quality in tools api/testutils by using infrautils' parent
Change-Id: I7485ce352b452cec2db19c5e726c9bb51438846c
Signed-off-by: Michael Vorburger <vorburger@redhat.com>
Nobin Mathew [Mon, 16 Apr 2018 09:37:41 +0000 (15:07 +0530)]
AlivenessMonitor pause/stop should work in a cluster
JIRA: GENIUS-126
Change-Id: I464c3d6bdd67ebda2c47cdbb22d69e9b254b28c6
Signed-off-by: Nobin Mathew <nobin.mathew@ericsson.com>
Edw7n [Tue, 24 Apr 2018 06:35:01 +0000 (12:05 +0530)]
Support for ITM direct tunnels in ITM workers
Modified the ItmInternalTunnel Add and Delete workers
to support creation/deletion of tunnels directly by ITM
Fixed issues while testing
Fix for bfd CSIT failure
Change-Id: I1bd9c0edf1f549168d95bc2e7c1e7c3caf6b5967
Signed-off-by: Edw7n <n.edwin.anthony@ericsson.com>
Edw7n [Thu, 5 Apr 2018 04:21:29 +0000 (09:51 +0530)]
Updating tunnel status based on tp status update
Update the ITM tunnel status by listening to the termination point status
Fixed issues while testing
Change-Id: I5b9b5389b4a2073d6648b164f2a5975484874ab1
Signed-off-by: Edw7n <n.edwin.anthony@ericsson.com>
Edw7n [Wed, 4 Apr 2018 14:59:13 +0000 (20:29 +0530)]
Implemented tunnel state updation
Listening to the inventory DS and create tunnel state information and also
program the ingress flows related to the tunnel
Fixed issues while testing
Change-Id: I83b0b6e95156ad7013cd8b3ff9902dcfed0a35ee
Signed-off-by: Edw7n <n.edwin.anthony@ericsson.com>
Edw7n [Wed, 4 Apr 2018 14:11:17 +0000 (19:41 +0530)]
Support for tunnel creation directly by ITM
Implemented creation of tunnels directly by ITM when the switch connects.
Conditional creation of listener if the itm-direct-tunnel flag is enabled.
Removed unused constants from ITMConstants.
Fixed some issues while testing
Change-Id: Ib5bef52ca85f7589057fadc2614e97de14e0109a
Signed-off-by: Edw7n <n.edwin.anthony@ericsson.com>
Michael Vorburger [Wed, 18 Apr 2018 09:50:48 +0000 (11:50 +0200)]
remove duplicate pax-cdi-api dependency in mdsalutil-impl
[WARNING] Some problems were encountered while building the effective model for org.opendaylight.genius:mdsalutil-impl:bundle:0.5.0-SNAPSHOT
[WARNING] 'dependencies.dependency.(groupId:artifactId:type:classifier)' must be unique: org.ops4j.pax.cdi:pax-cdi-api:jar -> duplicate declaration of version (?) @ line 115, column 17
Change-Id: I6a470db91686a790c76270386821bb364d75eae6
Signed-off-by: Michael Vorburger <vorburger@redhat.com>
Stephen Kitt [Sun, 25 Mar 2018 22:13:17 +0000 (15:13 -0700)]
Use OVSDB features instead of bundles
odl-genius-api depends on OVSDB’s utils.config, and currently attempts
to embed it; instead, depend on the odl-ovsdb-utils feature which
provides it.
Change-Id: I98da04b8978525946fcdeb98da4b989ef2571485
Signed-off-by: Stephen Kitt <skitt@redhat.com>
Faseela K [Wed, 11 Apr 2018 05:52:42 +0000 (11:22 +0530)]
Remove deprecated utils in mdsalutil-api
Listener base classes as well as FutureRpcResults are moved to genius/tools
and all the usages are also migrated to the new utils. Let us remove
the deprecated utils asap, so that new usages will not creep in :)
Change-Id: I27a004694ae762fc7420156be11e0a34e76cc7a7
Signed-off-by: Faseela K <faseela.k@ericsson.com>
Faseela K [Mon, 16 Apr 2018 09:15:20 +0000 (14:45 +0530)]
BFD status not reflected accurately on controller restart
Itm-direct-tunnels code patches had modified a check for handling
BFD, in a wrong manner, so that controller restart cases won't be handled
properly. Fixing the same.
Change-Id: I0a674fc337534355c45f40d0f40e134301dca1f0
Signed-off-by: Faseela K <faseela.k@ericsson.com>
David Suarez [Mon, 2 Apr 2018 21:48:59 +0000 (23:48 +0200)]
Migrate the last two listeners in itm-impl module
Migrate the last two listeners in itm-impl module to use the new
listeners framework.
Change-Id: I0a7bc5ed17634f72b7dffcd1f8818d454e3cc489
Signed-off-by: David Suarez <david.suarez.fuentes@gmail.com>
Faseela K [Wed, 18 Apr 2018 08:46:24 +0000 (14:16 +0530)]
Fix issues with SRM test plan
Change-Id: I91bfc8a1fc37d5ea4a673d6b2c26b11a0310a6ce
Signed-off-by: Faseela K <faseela.k@ericsson.com>
K.V Suneelu Verma [Wed, 11 Apr 2018 12:07:49 +0000 (17:37 +0530)]
add l2gw and dhcp for service recovery
Change-Id: Ia01f6c99016573802efce726396856dda2326138
Signed-off-by: K.V Suneelu Verma <k.v.suneelu.verma@ericsson.com>
Faseela K [Fri, 13 Apr 2018 06:31:28 +0000 (12:01 +0530)]
Re-enable FindBugs and ignore the null violations
Change-Id: I6d5e905119dfa3f57b9b6a0ce2f61f16fb924e4a
Signed-off-by: Faseela K <faseela.k@ericsson.com>
Signed-off-by: Stephen Kitt <skitt@redhat.com>
Nidhi Adhvaryu [Fri, 16 Mar 2018 11:03:59 +0000 (16:33 +0530)]
TestPlan for SRM
Change-Id: I7ebd5ed2eff066de0f1d8b373615847e65a030fe
Signed-off-by: Nidhi Adhvaryu <nidhi.adhvaryu@ericsson.com>
Stephen Kitt [Thu, 22 Mar 2018 17:24:32 +0000 (18:24 +0100)]
Bump to odlparent 3.1.0 and yangtools 2.0.3
Change-Id: If99df255661c177c6424ee7eb7f77fdb00522d63
Signed-off-by: Stephen Kitt <skitt@redhat.com>
Michael Vorburger [Thu, 12 Apr 2018 17:00:16 +0000 (19:00 +0200)]
remove un-used org.osgi.core from tools-api
Change-Id: I34b353fedafe908baacd536c58a26670e2f09a4f
Signed-off-by: Michael Vorburger <vorburger@redhat.com>
Faseela K [Thu, 12 Apr 2018 15:23:30 +0000 (20:53 +0530)]
wrong feature dependencies in newly added features.
Change-Id: Ie592de3ee8f6ba01c86e7d411dad8d5c411cf59c
Signed-off-by: Faseela K <faseela.k@ericsson.com>
Michael Vorburger [Wed, 11 Apr 2018 13:04:30 +0000 (15:04 +0200)]
remove un-used it-parent
Change-Id: I32eaa7da323298780035b2b9080ac9f9fbe36c76
Signed-off-by: Michael Vorburger <vorburger@redhat.com>
Tarun Thakur [Wed, 28 Mar 2018 09:58:45 +0000 (15:28 +0530)]
Support for dynamic update of local_ip from SBound
This change will enable support for dynamic change in TEP's local_ip.
No need to explicitly remove tep and then add to achieve update
operation.
Simply update other_config's local_ip in openvswitch table of OVSDB to
update tep in the transport-zone inside ODL.
Change-Id: Ia3ba618dd95945f8bb4b14aa8c8f9b4b74ac0e92
Signed-off-by: Tarun Thakur <tarun.t@altencalsoftlabs.com>
Tarun Thakur [Mon, 2 Apr 2018 10:42:38 +0000 (16:12 +0530)]
Change ext ID tzname key to transport_zone
This is for changing external_id's tzname key to transport_zone
which seems more understandable and better for long run.
Change-Id: I2d932b7a74bb2a21cf811e7feb27c4f372d81ec2
Signed-off-by: Tarun Thakur <tarun.t@altencalsoftlabs.com>
Tarun Thakur [Wed, 4 Apr 2018 08:31:15 +0000 (14:01 +0530)]
Spec update against reviews #70100, #70246, #70319
Spec is updated against below reviews:
Review ID: 70100
Move tepsNotHosted from Config DS to Oper DS
Review ID: 70246
Change ext ID tzname key to transport_zone
Review ID: 70319
Support for dynamic update of local_ip from Southbound
Change-Id: I99a47049f1fe850560754239d00465eaa11556db
Signed-off-by: Tarun Thakur <tarun.t@altencalsoftlabs.com>
Nishchya Gupta [Fri, 6 Apr 2018 14:02:22 +0000 (19:32 +0530)]
NETVIRT-1198: Acl Stats does not support Anti Spoof drop stats.
Support has been added in netvirt which requires few new definations in genius.
Change-Id: I9a4750209e134338e4f06506dea6e1273ecaa922
Signed-off-by: Nishchya Gupta <nishchyag@altencalsoftlabs.com>
(cherry picked from commit
754e9833ac42a6fa937894144a0b5b255faf616f)
Faseela K [Tue, 10 Apr 2018 17:41:55 +0000 (23:11 +0530)]
Revert "Revert "GENIUS-116: Efficient Handling of DPN disconnect""
This reverts commit
1c26ba35a1c6e03534151bbddeed8ec4d460c109.
Change-Id: Ie09689a0d1596c09e0a18d4e4ed462cbca46106e
Signed-off-by: Faseela K <faseela.k@ericsson.com>
Tom Pantelis [Thu, 28 Dec 2017 20:10:29 +0000 (15:10 -0500)]
Replace HwvtepHACache with HwvtepNodeHACacheImpl
HwvtepHACache is replaced by HwvtepNodeHACacheImpl in the
mdsalutil-impl bundle.
Change-Id: Id29450416ae0f738b0e91d108e22418341d70b22
Signed-off-by: Tom Pantelis <tompantelis@gmail.com>
David Suarez [Tue, 10 Apr 2018 14:05:43 +0000 (16:05 +0200)]
Remove unnecessary @Inject annotation in abstract classes
Remove unnecessary @Inject in abstract classes as described in [1].
[1]https://git.opendaylight.org/gerrit/#/c/70455/
Change-Id: I837995ae4a4ada0cd59ed5cc3c3ccb75e3341b2b
Signed-off-by: David Suarez <david.suarez.fuentes@gmail.com>
Faseela K [Mon, 9 Apr 2018 09:02:38 +0000 (14:32 +0530)]
Migrate users of mdsalutil-api/Abstract listener base classes to tools/listeners
Change-Id: Ib00afd1c8f4d45317fc5bd8ee1d3d4e0afcf7f93
Signed-off-by: Faseela K <faseela.k@ericsson.com>
Stephen Kitt [Wed, 21 Mar 2018 15:46:05 +0000 (16:46 +0100)]
InterfaceInventoryStateListener: check presence in tx
This checks node presence inside transactions, ensuring that state
changes are consistent.
Change-Id: Ia6a66a6859215c86ad393a340536fd77b9d70ec1
Signed-off-by: Stephen Kitt <skitt@redhat.com>
Michael Vorburger [Fri, 6 Apr 2018 17:22:11 +0000 (19:22 +0200)]
make DataStoreMetrics package local instead of a publicly supported API
and, exceptionally, keep it copy/pasted into the old (mdsalutil) and new
place (genius.tools); this IMHO is, exceptionally, better than keeping
something public - hopefully the duplicate in the old package will be
removed soon-ish, anyway.
Change-Id: I997dbb6eeb702f010eaee1becea1a43b57d950b3
Signed-off-by: Michael Vorburger <vorburger@redhat.com>
Michael Vorburger [Tue, 10 Apr 2018 12:45:03 +0000 (14:45 +0200)]
ignore InterfaceManagerConfigurationTest's newl2vlanInterfaceTests()
because, apparently, it has become unstable (again?!), despite much
recent progress Faseela made to finally make it more predictable :-(
Issue: GENIUS-120
Change-Id: I548ce8f6da3433cc0a0aa490b1ac76e4c0c2d685
Signed-off-by: Michael Vorburger <vorburger@redhat.com>
Faseela K [Mon, 9 Apr 2018 08:57:03 +0000 (14:27 +0530)]
Migrate mdsalutil-api/FutureRpcResults to tools/FutureRpcResults
Change-Id: I9e9e92ed3307a282b920f0b14b1a5980b0f031a4
Signed-off-by: Faseela K <faseela.k@ericsson.com>
Michael Vorburger [Fri, 6 Apr 2018 17:43:36 +0000 (19:43 +0200)]
remove test-jar from new tools-api artifact
This is not needed here, and before anyone creates a dependency to the
new (empty) attached test artifact by mistake, should be removed to
avoid any confusion.
A test-jar is only required if we need to publish src/test on Nexus.
This project does not even have a src/test; and even if it did, we would
only ever have tests for tools-api in it, not test utilities which other
projects would use - because we have the tools-testutils for that,
instead.
Change-Id: Ie1a3152386fee538eb812d52985a3ac17db8520b
Signed-off-by: Michael Vorburger <vorburger@redhat.com>
Michael Vorburger [Fri, 6 Apr 2018 16:45:25 +0000 (18:45 +0200)]
link ManagedNewTransactionRunner in SingleTransactionDataBroker's doc
Change-Id: I6e70198275f3bab31f7ab836fecf261195d1ed84
Signed-off-by: Michael Vorburger <vorburger@redhat.com>
Faseela K [Mon, 9 Apr 2018 12:05:57 +0000 (17:35 +0530)]
Add Cookie for COE Kube Proxy Table
Change-Id: Ib21556fa772ee37c80a8b205ed4cd5f099df6cac
Signed-off-by: Faseela K <faseela.k@ericsson.com>
David Suarez [Fri, 6 Apr 2018 22:55:46 +0000 (00:55 +0200)]
Migrate listener's methods
Migrate add, update and remove methods to use the new ones.
Change-Id: Ia53baaa5a2333168f2bd6983fda616fefb885b7d
Signed-off-by: David Suarez <david.suarez.fuentes@gmail.com>
Faseela K [Wed, 21 Mar 2018 12:43:48 +0000 (18:13 +0530)]
Moving datastore related utils from mdsalutil to new "genius.tools"
There are several requirements coming in where users are asking for a
simple feature with only datastore related utils. Currently all the utils
are parked in mdsalutil which has even openflowplugin related utils, and is embedded
in a heavier genius feature. This patch aims to move of these heavily used utils
to a new module, and add new features to expose the same.
Change-Id: I7d59273851c51b02fe43afcb1525c94ced1c5088
Signed-off-by: Faseela K <faseela.k@ericsson.com>
Faseela K [Thu, 29 Mar 2018 16:53:27 +0000 (22:23 +0530)]
New table for COE Kube Proxy
COE needs a new table for service implementation, Adding
Table 30 for the same. Also this will be a new service, which
should be of higher priority than L3 and hence moving all
the lower priority services by 1.
Change-Id: If14bbef5d8d7f5b54093a645c5625ee35e605730
Signed-off-by: Faseela K <faseela.k@ericsson.com>
Thanh Ha [Sat, 7 Apr 2018 01:58:10 +0000 (21:58 -0400)]
Add Karaf build profile
Project local Karaf distros are handy for devs to test their work
however is unneeded by autorelease builds and should not be released
as part of the Simultanious Release. Add a profile that is active by
default so that default behaviour is unchanged however allows the
autorelease project to disable building this module.
Issue: RELENG-86
Change-Id: I4e8ccf36f901d4127a7a9254797b87e7dc7b9c64
Signed-off-by: Thanh Ha <thanh.ha@linuxfoundation.org>
Thanh Ha [Sat, 7 Apr 2018 01:57:04 +0000 (21:57 -0400)]
Remove obsolete Maven Site configuration
Change-Id: Ia98ab43c4687b63f59c2fe39f247c3e58f71f47d
Signed-off-by: Thanh Ha <thanh.ha@linuxfoundation.org>
Stephen Kitt [Wed, 21 Mar 2018 14:51:24 +0000 (15:51 +0100)]
AlivenessMonitorUtils: wrap top-level in transactions
This uses transactions throughout based on top-level operations,
propagating the transaction through the call chain to ensure
consistent views of the MD-SAL.
Change-Id: Iae31775989102b1277a4e8a11a7f0633df21ae08
Signed-off-by: Stephen Kitt <skitt@redhat.com>
Stephen Kitt [Fri, 16 Mar 2018 10:00:40 +0000 (11:00 +0100)]
Remove MDSALDataStoreUtils
Since there are very few users left, remove the class entirely
(replacing it with SingleTransactionDataBroker).
This needs Ia012cc825a9eb7768de91c1882f76127d44c3595 to be merged
first.
Change-Id: I3c89e6549c7f2355583d6192d9134e9e589fbd39
Signed-off-by: Stephen Kitt <skitt@redhat.com>
Aswin Suryanarayanan [Sat, 3 Mar 2018 05:06:14 +0000 (10:36 +0530)]
NETVIRT-430 Ping responder on tenant network and FIP-FIP traffic between
vm in same n/w in same compute is not working in stateful SG mode.
Added Ct Clear action
Depends-on: Change-Id: I163ed99d5af8d3643749ac2a278f5c8170d7ae29
Change-Id: If86203e73a5ec516ff487f3f5c33fbd7dbfd12e1
Signed-off-by: Aswin Suryanarayanan <asuryana@redhat.com>
Michael Vorburger [Thu, 22 Mar 2018 13:54:07 +0000 (14:54 +0100)]
add requireNonNull to SingleTransactionDataBroker constructor
thought of this while seeing this which is actually broken:
@Inject DataBroker dataBroker;
S.T.D.B. db = new SingleTransactionDataBroker(dataBroker);
which cannot work with Dependency Injection (Guice or otherwise), and
it's better to have the null check here in the constructor already, not
fail with NPE later when one of the (non-static) methods of it is used.
see Change-Id: I63d0a93da481003b701c5a1843cece7d50cf51d1
Change-Id: I319d92c2bb50446ff59d156c4f261a51afe01863
Signed-off-by: Michael Vorburger <vorburger@redhat.com>
Michael Vorburger [Thu, 5 Apr 2018 14:46:36 +0000 (16:46 +0200)]
fix broken build; recent *Transaction change which removed commit()
The {@link ReadWriteTransaction#commit()} in JavaDoc lead to an "error:
reference not found" in maven-javadoc-plugin:3.0.0:jar (attach-javadocs)
@ mdsalutil-api during the build.
Change-Id: Ic489315ab050136f9de06a0331574aebb26e69c2
Signed-off-by: Michael Vorburger <vorburger@redhat.com>
Stephen Kitt [Fri, 16 Mar 2018 10:24:55 +0000 (11:24 +0100)]
Remove AlivenessMonitor::read
This can be entirely replaced by SingleTransactionDataBroker.
Change-Id: I8c302537f7abefafc1cf57c5e5c884a6b879c18f
Signed-off-by: Stephen Kitt <skitt@redhat.com>
Somashekar Byrappa [Thu, 22 Mar 2018 12:00:55 +0000 (17:30 +0530)]
Removed unused ACL constants
Ensured there are no references in netvirt for these constants.
Change-Id: I4372e2cd7733b469d0dee6f0ba0afc551eff0af5
Signed-off-by: Somashekar Byrappa <somashekar.b@altencalsoftlabs.com>
Stephen Kitt [Thu, 22 Mar 2018 09:59:05 +0000 (10:59 +0100)]
Add transaction variant of getChildInterfaces
In preparation for removing the current implementation of
IInterfaceManager::getChildInterfaces, this patch adds a variant
accepting a transaction (along with a few other related methods).
Change-Id: Idd93023de5b549c8ee7bed23fc3c485752d87548
Signed-off-by: Stephen Kitt <skitt@redhat.com>
Michael Vorburger [Tue, 3 Apr 2018 15:20:02 +0000 (17:20 +0200)]
increase max time out in AbstractTestableListenerTest from 50ms to 500ms
Change-Id: Ic45ad3bf911f81e030f7e425510a37fb2a54df0d
Signed-off-by: Michael Vorburger <vorburger@redhat.com>
Tarun Thakur [Mon, 26 Mar 2018 09:51:49 +0000 (15:21 +0530)]
Move tepsNotHosted from Config DS to Oper DS
As tepsNotHosted list was part of transport-zones container in itm.yang
and stored into config DS earlier. Since, it gets populated from
southbound only and will be available again on switch/ODL restart,
even if the switch goes away, we do not want to track these information
unnecessarily in the config DS. So, it is better to keep this data into
OperDS instead of config DS.
Change-Id: I731dfdb64ea3dc589567f4abeac3457ca0cbe395
Signed-off-by: Tarun Thakur <tarun.t@altencalsoftlabs.com>
Tom Pantelis [Thu, 22 Mar 2018 22:22:23 +0000 (18:22 -0400)]
Remove deprecated AsyncWriteTransaction#commit method
This method has been deprecated for quite some time and now has a
default implementation so can be safely removed from sub-classes.
Change-Id: I584c2e51ee1241b0198bcd310c2d2ca3d1b0f55a
Signed-off-by: Tom Pantelis <tompantelis@gmail.com>
Michael Vorburger [Thu, 22 Mar 2018 13:48:05 +0000 (14:48 +0100)]
deprecate IfmUtils' read() method
Change-Id: If1f5b547f9861f28066f3c490c2164b82c310536
Signed-off-by: Michael Vorburger <vorburger@redhat.com>
Stephen Kitt [Mon, 12 Mar 2018 16:40:56 +0000 (17:40 +0100)]
Use new Map methods
Map::computeIfAbsent models the common "initialise value collection
when missing and add to it" idiom.
Change-Id: I6e21374a8dc3fba0b4942c40d0ab1031d65b97f8
Signed-off-by: Stephen Kitt <skitt@redhat.com>
Stephen Kitt [Mon, 12 Mar 2018 16:40:39 +0000 (17:40 +0100)]
Use switch instead of chained ifs
Change-Id: I9d99d610abc7984e146b459a7fa3dcdd64425aa1
Signed-off-by: Stephen Kitt <skitt@redhat.com>
Stephen Kitt [Mon, 12 Mar 2018 16:38:20 +0000 (17:38 +0100)]
Add a model conversion method for InterfaceOpState
Change-Id: I984cb90ddd81e78bb346ece701de2ccf2de4edce
Signed-off-by: Stephen Kitt <skitt@redhat.com>
Michael Vorburger [Tue, 20 Mar 2018 13:33:21 +0000 (14:33 +0100)]
deprecate ItmUtils' async*() methods
Change-Id: I82e08e6a2a31a2dda014e69eebea1373ddc3e1a6
Signed-off-by: Michael Vorburger <vorburger@redhat.com>
Stephen Kitt [Wed, 21 Mar 2018 15:02:56 +0000 (16:02 +0100)]
Flow-based listeners: use top-level transactions
This changes the listener to use a single transaction for its
top-level operations.
Change-Id: I739ba6ce11b881331945d77ea2a9d7c3b2120206
Signed-off-by: Stephen Kitt <skitt@redhat.com>
Edw7n [Tue, 6 Mar 2018 06:11:17 +0000 (11:41 +0530)]
Utils for itm performance enhancements
Change-Id: Id0400bd56473550ebc49d2968024632fcdf5b265
Signed-off-by: Edw7n <n.edwin.anthony@ericsson.com>