git.opendaylight Code Review - odlparent.git/log

Revert "Update GSON to 2.8.6"

This reverts commit edbeb3e8d0988cc84e0cc062f7d22402505ba75d, as
GSON 2.8.6 seems to have quite a bit of trouble:

https://github.com/google/gson/issues/1601
https://github.com/google/gson/issues/1602
https://github.com/google/gson/issues/1608
https://github.com/google/gson/issues/1630

Let's wait for the dust to settle first.

Change-Id: I7d0c7b671a31bf9bf3a1861cc56b009bd0f724b6
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Add default repository to defaultRepositories

SFT reconfigures the repository layout such that Karaf ends up
ignoring its default system repository, which contains various
edits we are doing for the baseline distribution.

This leads to SFT running actually against vanilla Karaf
definitions, which is not what we want.

We need to override the repository config to ensure we pick up
the maven repository, so we can find things like pax-exam, etc.

Fix this by setting org.ops4j.pax.url.mvn.defaultRepositories
to point to karaf.default.repository, so that it is consulted
*before* all other repositories.

JIRA: ODLPARENT-209
Change-Id: I6c0fe2716ca1f4aaf695f20dc142838e13cc9e81
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
(cherry picked from commit 032a0f970970aba54318360828c10f30861a463e)

Upgrade sevntu/checkstyle to 1.36.0/8.26

https://sevntu-checkstyle.github.io/sevntu.checkstyle/#1.36.0
https://checkstyle.org/releasenotes.html#Release_8.21
https://checkstyle.org/releasenotes.html#Release_8.22
https://checkstyle.org/releasenotes.html#Release_8.23
https://checkstyle.org/releasenotes.html#Release_8.24
https://checkstyle.org/releasenotes.html#Release_8.25
https://checkstyle.org/releasenotes.html#Release_8.26

Change-Id: I955c613c706a6a62330f80dbe00d91a7e0f04e56
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Update dependencycheck

Catch up with previous changes.

Change-Id: I2db3b12fcded6f129928482492f3cc99997a7887
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Bump maven-source-plugin to 3.2.0

https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12317924&version=12345522

Change-Id: Ibe3259659234c832e7798e6d928301addd74a163
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Bump maven-jar-plugin to 3.2.0

https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12317526&version=12345503

Change-Id: I6eb5be570132ee4ca354535cec2898add01e708d
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Upgrade to karaf-4.2.6

Release notes:
https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12311140&version=12345365

This includes some important upgrades:
org.apache.aries.blueprint.core from 1.10.1 to 1.10.2
jetty from 9.4.12.v20180830 to 9.4.18.v20190429

We deal with KARAF-6345 by downgrading pax-logging back to 1.10.1,
which causes the underlying problem not to surface.

Change-Id: Ie3f46cdfb0e856ebe760dff7472ae7aefa30286e
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Enforce Java at 11

During startup, make sure the JVM version is exactly 11, because
our code requires Java 11 and karaf-4.2.2 does not support anything
newer.

JIRA: ODLPARENT-218
Change-Id: I8d46bc5c4f4fea565a8c7823271a6917eb825732
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Fixup blueprint-core version

karaf-4.2.5 is using blueprint-core 1.10.2, make sure to propagate
this version correctly.

Change-Id: I2d772a8233f7f1467fdc2abac6a7cc5075d0191d
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Fixup karaf-4.2.5 upgrade

We need to keep pax-web-api aligned with the karaf-shipped pax-web.
Also we forgot to upgrade javax.annotation-api as noted in the commit
message and finally we should be aligning Jolokia with our version.

Change-Id: Ic70f8dce2f9efdb208c5e20806694c469ac6d67e
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
(cherry picked from commit 594985ed50e50a92e875be667daac6e22cdefec5)

Make karaf patches versionless

Keeping patches with karaf.version is annoying, remove the versions
as we only support one karaf version.

Change-Id: Id54297f24cac1a6ed3136713a8dd00073ea6254f
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
(cherry picked from commit bccf9da9e4213a6ddcfb9a3af9740c8e2b0f8faa)

Bump karaf to 4.2.5

This bumps karaf to 4.2.5, removing some workarounds we had to put
in place.

Notable upgrade is javax.annotation-api going from 1.2 to 1.3,
full release notes are here:

https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12311140&version=12344587
https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12311140&version=12344856
https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12311140&version=12345153

We also fix https://issues.apache.org/jira/browse/KARAF-6259 by
manually downgrading Equinox.

Change-Id: If9719909389df5c0b92c9aade0356d4a314ff756
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
(cherry picked from commit 2e35dfeaaf555598bbf10b00cc046e7a198d081b)

Parse docs version from pom.xml

Also clean up unused configuration in conf.py.

Issue: DOCS-113
Change-Id: I3ac511ebb6010a5d0b6822d976c761a8d40f9146
Signed-off-by: Thanh Ha <zxiiro@gmail.com>

Add immutables.value to annotationProcessorPaths

Immutables do not work in our setup with JPMS modules, as they
are not picked up from general dependency path. Also we do not need
the full dependency in each module, just the annotations package.

This is based on:
https://github.com/immutables/immutables/issues/713#issuecomment-419750206
https://github.com/immutables/immutables/issues/750
https://github.com/immutables/immutables/issues/745#issuecomment-375952158

JIRA: ODLPARENT-216
Change-Id: Ib1b6f89b537fe27dbf68bec166b7ebdab042c483
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Bump H2 to 1.4.200

http://www.h2database.com/html/changelog.html

Change-Id: Ibe4e41ecfec9e406d075d16f06c0e92ab52cd755
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Bump modernizer-maven-plugin to 2.0.0

https://github.com/gaul/modernizer-maven-plugin/releases/tag/modernizer-maven-plugin-2.0.0

Change-Id: Idb4c2139c80b8ee45ff4bfa50b7950da78812112
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Update GSON to 2.8.6

https://github.com/google/gson/blob/master/CHANGELOG.md#version-286

Change-Id: I2341caeade76d33f34bd9255a756b5768f0a17ea
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Bump hamcrest to 2.2

https://github.com/hamcrest/JavaHamcrest/releases/tag/v2.2

Change-Id: I56c118eb0b6dc5bf2b0d4d9f542d55388b1531e6
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Bump maven-bundle-plugin to 4.2.1

https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12310100&version=12345491

Change-Id: Idb89938780fb6453faf511d0672877fe5d3a5f8e
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Bump akka to 2.5.26

https://akka.io/blog/news/2019/10/17/akka-2.5.26-released

Change-Id: I7a954da3b5855e1555ad17d5d6404859fe6a1509
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Bump JaCoCo to 0.8.5

https://github.com/jacoco/jacoco/releases/tag/v0.8.5

Change-Id: I0e12e7f21f40e2c45f4f9d54a747199d82f4494c
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Update powermock to 2.0.4

No official release notes (yet?), the following issues are fixed:
https://github.com/powermock/powermock/issues/685
https://github.com/powermock/powermock/issues/992
https://github.com/powermock/powermock/issues/939

Change-Id: Ie8266a961c75cb0dcb606e4639ef0b91a8992b5e
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Bump versions to 6.0.2-SNAPSHOT

This starts the next development iteration.

Change-Id: I737cd87d22894af327dfa775992b84ff443d1cc2
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Switch leveldbjni-all parent to odlparent

We are exporting a code artifact, better use the odlparent for
that, so that all dance around javadoc/sources is taken care of.

JIRA: ODLPARENT-210
Change-Id: Id1e8fd21f81b9b17d296acef89ee7ba790815bb1
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Fix leveldbjni-all not having sources

It seems we cannot deploy artifacts without sources, hence we
attach a dummy source code attachment.

JIRA: ODLPARENT-210
Change-Id: I994df58760b3044c8d9b26af7fe687fd98266253
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Update NEWS for odlparent-6.0.1

This updates NEWS in preparation for 6.0.1 release.

Change-Id: Ic400fc8983031e2e2db9a95dbd0196be46c6081c
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Bump mockito to 2.28.2

https://github.com/mockito/mockito/blob/release/2.x/doc/release-notes/official.md#2252
https://github.com/mockito/mockito/blob/release/2.x/doc/release-notes/official.md#2253
https://github.com/mockito/mockito/blob/release/2.x/doc/release-notes/official.md#2254
https://github.com/mockito/mockito/blob/release/2.x/doc/release-notes/official.md#2255
https://github.com/mockito/mockito/blob/release/2.x/doc/release-notes/official.md#2256
https://github.com/mockito/mockito/blob/release/2.x/doc/release-notes/official.md#2257
https://github.com/mockito/mockito/blob/release/2.x/doc/release-notes/official.md#2261
https://github.com/mockito/mockito/blob/release/2.x/doc/release-notes/official.md#2262
https://github.com/mockito/mockito/blob/release/2.x/doc/release-notes/official.md#2271
https://github.com/mockito/mockito/blob/release/2.x/doc/release-notes/official.md#2272
https://github.com/mockito/mockito/blob/release/2.x/doc/release-notes/official.md#2273
https://github.com/mockito/mockito/blob/release/2.x/doc/release-notes/official.md#2274
https://github.com/mockito/mockito/blob/release/2.x/doc/release-notes/official.md#2275
https://github.com/mockito/mockito/blob/release/2.x/doc/release-notes/official.md#2280

The most interesting part is 2.27.5, which fixes interaction with
JaCoCo 0.8.4, which is plaguing lispflowmapping.

Change-Id: I451b8830e26950153e9db9b24caddc0246537717
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Bump BouncyCastle to 1.64

https://www.bouncycastle.org/releasenotes.html, fixing
CVE-2019-17359 introduced by 1.63.

Change-Id: I1deb437a7e2ae8e30ed2266dea846d56f0cc9fbb
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Add an override for ARIES-1923

This replaces the feature definition to pull in proxy-impl-1.1.6
instead of stock 1.1.3.

Change-Id: I7e371aad44c561861ec987d00558e7906098564d
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Refactor URL replacement in karaf-plugin

We need to be mindful of file separators when dealing with URI/URLs.
While File-based strings are using platform-dependend separator,
either '/' (Unices) or '\' (Windows et al.), file: URI scheme is
using '/' to separate path components (as per RFC8089).

Make sure we preserve the semantic context and perform proper
conversion between the two representations.

JIRA: ODLPARENT-214
Change-Id: I8d20ee1bdb4bfb3c1f675423a3849082c21fe26c
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Remove karaf.version

This just overrides definition we are getting from odlparent,
which is already at the right version.

Change-Id: I2f6a933d7ac1316cba225725496cd9fc3775f3f1
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Make sure CLI components are scope=provided

We are filtering dependencies, but if downstreams fail to set these
dependencies to provided we'll end up pull in transitive dependencies
are required -- and those are provided by the platform. Mark CLI
components as provided, as that is what they are.

Change-Id: I32c6f4d3b24591d828d808c13849907176fd0f99
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Remove duplicate jdepend-maven-plugin declaration

This declaration is already present in odlparent-lite, eliminate
the duplicate.

Change-Id: I8518a3fbc83762f6c930d98202915b480ba73fb2
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Disable slf4j SSL link

slf4j does not provide apidocs over TLS, link HTTP site instead.

Change-Id: I2158c043a2d9e810a329587159fc6af9d57d8e56
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Bump guice to 4.2.2

https://github.com/google/guice/wiki/Guice42
https://github.com/google/guice/wiki/Guice421
https://github.com/google/guice/wiki/Guice422

Change-Id: Ib17e3cb73a1e31fd5ca3fb6eca66b7d1d2cd9e7e
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Bump Javassist to 3.26.0-GA

3.25 fixes:
- https://github.com/jboss-javassist/javassist/issues/72
- https://github.com/jboss-javassist/javassist/issues/241
- https://github.com/jboss-javassist/javassist/issues/242
- https://github.com/jboss-javassist/javassist/issues/246
- https://github.com/jboss-javassist/javassist/issues/252
3.26 fixes:
- https://github.com/jboss-javassist/javassist/issues/265
- https://github.com/jboss-javassist/javassist/issues/270
- https://github.com/jboss-javassist/javassist/issues/271
- https://github.com/jboss-javassist/javassist/issues/275

Of these #270 is most important, as it fixes an issue we've seen
with powermock downstream.

Change-Id: Ib4d75d6411e71438436249a8eb9313ccf4411ca2
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Bump jackson to 2.9.10

https://github.com/FasterXML/jackson/wiki/Jackson-Release-2.9.10

This release also accidentally bumps woodstox-core dependency
to 5.3.0, which forces us to upgrade stax2-api to 4.2:

https://github.com/FasterXML/woodstox/wiki/Woodstox-Release-5.1
https://github.com/FasterXML/woodstox/wiki/Woodstox-Release-5.2
https://github.com/FasterXML/woodstox/wiki/Woodstox-Release-5.3

https://github.com/FasterXML/stax2-api/blob/master/release-notes/VERSION

Unfurtunate, but we need this for CVE fixes.

Change-Id: If1bb6b237342f80616dd25cfeb5cb63b4e0d169f
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Use python3 as basepython for docs

Python 2 is soon to be EOL and we've been having issues with it as of
late. Bump to Python 3 as the basepython to see if it helps with the
pytest issue:

ERROR: Package u'pytest' requires a different Python: 2.7.5 not in '>=3.5'

Issue: https://jira.linuxfoundation.org/servicedesk/customer/portal/2/IT-17699
Signed-off-by: Thanh Ha <zxiiro@gmail.com>
Change-Id: Ie4c4547c9523ff5cf6c8d42e49a9514a07938e61

Use fileSeparator to concat /etc

On windows we have a different file separator, this is probably
causing:

[INFO] ------------------------------------------------------------------------
[ERROR] Failed to execute goal org.opendaylight.odlparent:karaf-plugin:6.0.0:populate-local-repo (populate-local-repo) on project distribution.opendaylight-karaf: Failed to execute: Could not resolve URI: file:D:\Open-Day-Light\magnesium-mri\controller\karaf\target\assembly/etc/3099bac6-f5e3-4ba5-81f1-de70eb9fc227.xml: Illegal character in opaque part at index 7: file:D:\Open-Day-Light\magnesium-mri\controller\karaf\target\assembly/etc/3099bac6-f5e3-4ba5-81f1-de70eb9fc227.xml -> [Help 1]

Change-Id: Id264d4bb0e15cde47da6913996d173e9bf5ea03e
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Remove accidental tabs

Previous patch added some tabs, remove them.

Change-Id: Ib93a05639d45ae6129a939084d657c80b501610c
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Upgrade reactive-streams to 1.0.3

http://www.reactive-streams.org/announce-1.0.3

Change-Id: I52f724471f516e50e65d252a142a688ffe768a9a
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Bump netty to 4.1.42

https://netty.io/news/2019/09/12/4-1-41-Final.html
https://netty.io/news/2019/09/25/4-1-42-Final.html

Change-Id: I3882602046370e4ee861335955258510bddd490e
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Add leveldbjni-all repackaging

We are publishing all our artifacts to Maven Central, but this jar
has been seeded into our Nexus manually after upstream failed to
make a public release of the contribution for years.

This jar is not present in Central and hence most our features do
not work out of the box, as you still need to point to ODL Nexus
to get this one jar.

This patch rectifies that situation by re-packaging this jar in
org.opendaylight.odlparent namespace and referencing it in our
features.

JIRA: ODLPARENT-210
Change-Id: I16895d6e9e2572ab85db9c509e06306c7acc441d
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Move maven-{antrun,jar,resource}-plugin declaration

These plugins are useful in odlparent-lite-derived projects, move
their version declaration.

Change-Id: Idb0046ef59a48dfc3a70d3e7d5a195cbb7a89ba7
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Bump pt-triemap to 1.1.0

https://github.com/PantheonTechnologies/triemap/releases/tag/triemap-1.1.0

Change-Id: Ib2fa93f5a85d16b5550d7555df87a922a8adad56
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Add a missing space

The bullet list is not formatting correctly, fix that.

Change-Id: Ib1c9df2c4aa5cfae3a4f183734fdc73a8e4b4545
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Bump version to 6.0.1-SNAPSHOT

This starts the next development cycle.

Change-Id: Ic3a8b6ef59a5ed59a38efbb18270d7b641295d44
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Update NEWS.rst for odlparent-6.0.0

This sums up the updates, making us ready for the release.

Change-Id: I929262d7142509caffbdf9f8204ff6601a265ba8
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Bump BouncyCastle to 1.63

https://www.bouncycastle.org/releasenotes.html

Change-Id: I3b7e0e440a3db38bdce8818b823b75f445c64103
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Update maven-dependency-plugin lifecycle mapping

We have changed the goal on unpack-license without adjusting
lifecycle mapping, which is making Eclipse Not Happy (tm). Fix
that up.

Change-Id: Ia65d4f3de6dd070a9e8c7390db2394d5793b6f9c
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Allow modernizer-maven-plugin target to be tuned

Downstream projects may want to target a different Java version,
this patch exposes a nice knob to achieve exactly that.

Change-Id: I7e25b9ff6e6143a7ce610a2c5657d966f774a859
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Bump mina-sshd to 2.3.0

https://github.com/apache/mina-sshd/blob/master/docs/changes/2.3.0.md

Change-Id: Ib99b3a6f38dd74398a49f8d5e1999b9bf3138539
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Bump git-commit-id-plugin to 3.0.1

https://github.com/git-commit-id/maven-git-commit-id-plugin/releases/tag/v3.0.0
https://github.com/git-commit-id/maven-git-commit-id-plugin/releases/tag/v3.0.1

As version 3.0.0+ would now perform a 'git fetch' to resolve
branch ahead/beind properties, we force the plugin to operate
in offline mode, which is what we want anyway.

Change-Id: Iafe85cbca5b47d3cd5c529bca5e8a3d93bd7f3fe
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Migrate docs into the project

This disables the root Sphinx setup and uses the same docs setup as
other ODL projects.

The developer’s guide is outdated but will be updated in a later
commit.

Change-Id: I5201529c52fe55fec7540464f896e703affdb350
Signed-off-by: Stephen Kitt <skitt@redhat.com>

Bump Scala to 2.12.10

https://github.com/scala/scala/releases/tag/v2.12.10

Change-Id: I1cf9ccb8a27ea499bf70c875482aeca18013c05b
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Bump modernizer to 1.9.0

https://github.com/gaul/modernizer-maven-plugin/releases/tag/modernizer-maven-plugin-1.9.0

Most important is the JPMS friendliness provided by the annotations.

Change-Id: I571df445b9e4c1d0d77ec33ec6e4679c1eeeb879
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Do not tolerate unresolved URLs

Not resolving repositories results in overrides not being applied
as they should be, leading to half-broken results. Do not tolerate
this happening.

As this causes the build to fail on our failure to expand karaf.etc
property, fix that up as well.

Change-Id: I5f4956215f7f016cdd012945ca0caf3d1ff2882c
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Update maven-dependency-plugin dependencies

In order to support analysis of Java 11 (version 55) classes, we
need to pull in an updated version of maven-dependency-analyzer.

Details are here: https://issues.apache.org/jira/browse/MDEP-613

Change-Id: Ib8ac01600da72244f243073990f0761d3ce5f655
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Bump commons-text 1.7 → 1.8

Release notes:
https://commons.apache.org/proper/commons-text/changes-report.html#a1.8

Change-Id: I5b4129ddceb19f89b4db83d034c980bb4cdd7794
Signed-off-by: Stephen Kitt <skitt@redhat.com>

Fix duplicate spifly jars

While investigating a blueprint issue, I came across:

[WARNING] Duplicate versions for org.apache.aries.spifly:org.apache.aries.spifly.dynamic.bundle::jar, 1.2 and 1.0.10

Which boils dows to a disagreement between karaf standard feature
and pax-web-features. Since this is a dependency, just use the
version from Karaf, which is going to win anyway.

Change-Id: I8c9f455da21971e14197b3a0917c8fbe0a38710f
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Bump xtend to 2.19.0

https://www.eclipse.org/Xtext/releasenotes.html#/releasenotes/2019/09/03/version-2-19-0

Change-Id: I53e7748a29f2d547394a21073be3663799351df9
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Bump xtend to 2.18.0

https://www.eclipse.org/xtend/releasenotes.html#/releasenotes/2019/06/04/version-2-18-0

Change-Id: Ie2ac47c42fe38ecf319ca67e6f09027bc8e90e2a
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Bump akka to 2.5.25

https://akka.io/blog/news/2019/08/20/akka-2.5.25-released

Change-Id: I948449a7704ce3af19b123d3af8a03ada4ba5b2a
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Bump slf4j 1.7.25 → 1.7.28

https://www.slf4j.org/news.html

The main news is the inclusion of JPMS declarations, which allows
us to make progress in using explicit modules.

Change-Id: Ieaa490f48490363997eee02edaf8f4d2fefd1ae8
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Allow -Pq to skip Checkstyle and SpotBugs

With the recent changes to enable Checkstyle and SpotBugs by default,
-Pq no longer skips them. This moves the properties to odlparent-list
and fixes -Pq. Modernizer gets the same treatment.

Change-Id: I2c2ff977179e84833407b13d678fa84ec6f08845
Signed-off-by: Stephen Kitt <skitt@redhat.com>
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Rework license packaging

Rather than mucking with unpacking jars, let's just attach
the license file and have the execution copy it to classes.

Change-Id: I3b6105ba7055ebdd9de14664ce7c870daff4e976
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Silence karaf preparation a bit

This explicitly tags the copy operation and silences it, so we get
a bit cleaner logs.

Change-Id: I50414650a9816e67f312b9fdc0c75b77f3348b89
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Bump jaxb to 2.3.0

Since we are requiring Java 11, we can match the declaration with
what Karaf provides. Version 2.3.0 does not pull in stax-api, so
we can remove that exclusion.

As for the implementation, we declare glassfish-2.3.1, as that is
what karaf ships.

Change-Id: I4acb7971d12b825697e46f8bc008eda40740a623
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Re-enable blueprint preemptive shutdown

This was disabled for the purposes of Config Subsystem, which has
been completely removed in Fluorine. Remove the knob now.

JIRA: ODLPARENT-34
Change-Id: I6d78065013f0349652813e822c5b122be1e2244a
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Remove netconf properties

These properties are related to netconf/CSS integration, which has
been removed in Fluorine. Remove the property bits, too.

Change-Id: I93d48c2608e37aaafd962d300b7159a2fc72abc3
JIRA: ODLPARENT-34
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Enforce checkstyle by default

This enables checkstyle enforcement by default, while allowing
downstreams to control the behavior via
odlparent.checkstyle.{enforce,skip} properties.

JIRA: ODLPARENT-206
Change-Id: I446525cfd3f3a4cd0f39f83ee36f9d8eaff4e6b9
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Enforce spotbugs by default

This exposes a new property, odlparent.spotbugs.enforce, which
controls whether spotbugs-maven-plugin should fail the build when
any violations are found.

JIRA: ODLPARENT-205
Change-Id: Id1bd3f2e7941af023e2bbdc9c435d7d5c9e009e6
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Do not fail build on modernizer violations by default

Modernizer reports a huge number of issues with our current codebase,
hence we should not force this upon our downstreams.

This patch makes enforcement disabled by default, with a simple
odlparent.modernizer.enforce=true allowing enforcement to be switched
on by downstream pom.xmls.

Similarly, the plugin can be disabled by defining
odlparent.modernizer.skip=true.

JIRA: ODLPARENT-203
Change-Id: I876c998d02d54ba4b24d9bc1e8667bf0a884304a
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Silence framework extension unpack

This eliminates a tiny bit of noise when we are unpacking
framework extensions.

Change-Id: I7333113f7feff1d9e8ad7e0c1c309daafc7dfbe2
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Move build-helper-maven-plugin declaration

Builder helper is useful in simple poms, where it can be used to
attach files. Move its declaration to odlparent-lite, so it is widely
available.

Change-Id: I84a235707b72287d7121c77ee3a0b7dd2958f965
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Bump sevntu to 1.35.0

https://sevntu-checkstyle.github.io/sevntu.checkstyle/#1.35.0

Change-Id: I2ccb96334c7b6911b3bf88ac36db407053f844ed
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Bump Commons BeanUtils to 1.9.4

Release notes:
http://www.apache.org/dist/commons/beanutils/RELEASE-NOTES.txt

Change-Id: I4fa56e9ce439c770f21737570b1dbdfc61198119
Signed-off-by: Stephen Kitt <skitt@redhat.com>

Silence license unpacking

License unpacking happens for every artifact we build, adding
some noise to the build. Suppress that noise.

Change-Id: I513e4b0cfe9aa31240bf7d8dc9bc3f4c1965e5dc
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Bump Akka to 2.5.24 and ssl-config to 0.3.8

https://akka.io/blog/news/2019/08/09/akka-2.5.24-released
https://github.com/lightbend/ssl-config/compare/v0.3.7...v0.3.8

Change-Id: Ifcc2479a39cbb904ff2d691ad6148899ca91545c
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Bump netty to 4.1.39

https://netty.io/news/2019/06/28/4-1-37-Final.html
https://netty.io/news/2019/07/24/4-1-38-Final.html
https://netty.io/news/2019/08/13/4-1-39-Final.html

Change-Id: If67c1920f0c7982989de04b8c3adc829de763b5d
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Bump maven-pmd-plugin to 3.12.0

https://blogs.apache.org/maven/entry/apache-maven-pmd-plugin-version1

This bumps used pmd to 6.13.0:
https://pmd.github.io/2018/12/09/PMD-6.10.0/
https://pmd.github.io/2019/01/27/PMD-6.11.0/
https://pmd.github.io/2019/02/24/PMD-6.12.0/
https://pmd.github.io/2019/03/31/PMD-6.13.0/

Change-Id: I046d0fdac2beaa6b84bc591f448504027ee8c6f2
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Upgrade jackson-databind for CVE-2019-14379

See https://github.com/FasterXML/jackson-databind/issues/2387 for
details.

Change-Id: I3a8a416bba7e72861512531a3a83d818daf6fd5f
Signed-off-by: Stephen Kitt <skitt@redhat.com>
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Fixup commons-codec upgrade

This adds missing overrides to karaf distribution, so that we do
not package duplicate versions.

Change-Id: Icb8b3a7b7d923f2e0cb3d9ce02f719e436dbc191
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Bump commons-codec 1.12 → 1.13

Release notes:
http://www.apache.org/dist/commons/codec/RELEASE-NOTES.txt

Change-Id: Ibcf6e1a6cd59a4341cad7a65ac1c8cbf7ceefb26
Signed-off-by: Stephen Kitt <skitt@redhat.com>

Bump scala to 2.12.9

https://github.com/scala/scala/releases/tag/v2.12.9

Change-Id: I492c89dc7cf93211174946accfeaaeefa8edab25
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
(cherry picked from commit f29ca446f8ab5e9c81af0f899e4e6550bd6544ca)

Skip checkstyle for module-info.java

checkstyle cannot handle module-info.java syntax, hence do not allow
it to touch those files.

Change-Id: I12d45daef31dea29d50159c249ed6e972d5a73b8
JIRA: ODLPARENT-201
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Drop modernizer back to Java 8

Modernizer produces a ton of recommendations to use List.of()
and similar -- which requires careful consideration, as we are
using ImmutableList.copyOf() all over the place and Java's version
does not offer a check for immutability.

This is a stop-gap until we figure out a way forward.

JIRA: ODLPARENT-201
Change-Id: I7037e6ef09f132129ac3b63145235eb6903961bc
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Add modernizer-maven-annotations

There are rare cases when we actually want to suppress modernizer,
this adds the annotations to do that.

JIRA: ODLPARENT-203
Change-Id: Ia1a28ac565b99f3a24c3e88b6320d6fb09885bb8
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Bump spotbugs-maven-plugin to 3.1.12.2

https://github.com/spotbugs/spotbugs-maven-plugin/releases/tag/spotbugs-maven-plugin-3.1.12.1
https://github.com/spotbugs/spotbugs-maven-plugin/releases/tag/spotbugs-maven-plugin-3.1.12.2

Change-Id: I547f8e224553e0898b6810520aca2dcf989f8545
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Bump Java requirement to 11

This bumps required JDK version and target versions to Java 11.

JIRA: ODLPARENT-201
Change-Id: I837f15f2bdb0d79f561fa2cae86cf8cf9a87806b
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Add odlparent-docs

This adds a proper aggregator for javadocs, so that we can ditch
the javadoc jobs.

Change-Id: I0bf15e5c0dae63a46d94b292686d46bfe11fa026
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Enable modernizer-maven-plugin by default

This enables modernizer in all projects by default.

JIRA: ODLPARENT-203
Change-Id: I1053a29dd9578b454c1da4425b3cbe69867fc28c
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Remove JSR305 artifact

We have moved away from JSR305 annotations, this removes
the dependency declaration, so that it does not creep back in.

JIRA: ODLPARENT-202
Change-Id: I8b3811af0d298edb2acdd0ed0588919f9e5f7ab8
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Bump versions to 6.0.0-SNAPSHOT

This starts the next development iteration.

Change-Id: Id858b6a794e9ef5733e32c7ea5effb77a8a4ff45
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Bump maven-javadoc-plugin to 3.1.1

https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12317529&version=12345060

Change-Id: I1950586a8774878eb7eab333680f0deac8d4cf66
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Bump triemap to 1.0.6

https://github.com/PantheonTechnologies/triemap/releases/tag/triemap-1.0.6

Change-Id: I3e77d1149de1459ee5312a4f066913c5d96534df
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Update dependency check

This updates dependecy check to catch previous updates.

Change-Id: I47aec9a6d75dc796ea30b2fe1dde3ea45332d537
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Bump Checkstyle 8.18 → 8.20

Release notes:
https://checkstyle.org/releasenotes.html#Release_8.19
https://checkstyle.org/releasenotes.html#Release_8.20

Change-Id: I1861930af1af7dc83c8b29cedc7c39adc99e9fe6
Signed-off-by: Stephen Kitt <skitt@redhat.com>
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>