Tali [Wed, 4 Jan 2017 18:27:21 +0000 (20:27 +0200)]
Bug 7481 - Flows with nicira actions get corrupted after cluster failure
Change-Id: I7fe988b54af3823e0fad672f1f3c5d7750c9095a
Signed-off-by: Tali <tali.ben-meir@hpe.com>
Sai Marapareddy [Tue, 20 Dec 2016 23:42:51 +0000 (15:42 -0800)]
Bug 7415 Reducing the severity of the log message
Whenever there is a change in configuration of l2switch,
bundle refresh happens. When bundles refresh, openflowplugin
pushes the same flow. Changing the severity of of the exception
to warning since it is expected to have a flow with same id.
Change-Id: I69874d14b83053edc97b6d299c8fdb05d7ccdd8c
Signed-off-by: Sai MarapaReddy <sai.marapareddy@gmail.com>
Author: Sai MarapaReddy <sai.marapareddy@gmail.com>
Jozef Bacigal [Tue, 20 Dec 2016 08:05:44 +0000 (08:05 +0000)]
Merge "Create YANG builders for all relevant model types"
Jozef Bacigal [Tue, 20 Dec 2016 08:05:38 +0000 (08:05 +0000)]
Merge "Add Serialization and Deserialization injectors"
Anil Vishnoi [Wed, 7 Dec 2016 20:14:43 +0000 (12:14 -0800)]
Revert the functional behavior change introduced through
https://git.opendaylight.org/gerrit/#/c/47138/3
Signed-off-by: Anil Vishnoi <vishnoianil@gmail.com>
Change-Id: I0b8fc5b1e0763bb2b91302647037e1153fd41dc1
(cherry picked from commit
43b49485d25ebdf0dca58d46c14100a4aa7c6324)
Tomas Slusny [Fri, 11 Nov 2016 11:25:27 +0000 (12:25 +0100)]
Create YANG builders for all relevant model types
Add new *message builders to flow, group, meter and port
YANG models to allow us to serialize and deserialize them
properly.
Add dependency on openflowjava for model-flow-base
Update set-tp-src and set-tp-dst yang with ip-protocol
See also: bug 7137
Change-Id: Ie552e5b06778ec0d0d803e34b9628fb1c627d1ab
Signed-off-by: Tomas Slusny <tomas.slusny@pantheon.tech>
Tomas Slusny [Fri, 11 Nov 2016 11:51:51 +0000 (12:51 +0100)]
Add Serialization and Deserialization injectors
Add SerializerInjector and DeserializerInjector that will
allow us to register new serializers and deserializers in
OpenflowPlugin easily.
Add abstract classes for unit tests to speed up unit test
development.
See also: bug 7136
Change-Id: I3135dd3d0ca49585f274f5c63f4ab6b35b525b6d
Signed-off-by: Tomas Slusny <tomas.slusny@pantheon.tech>
Anil Vishnoi [Sat, 10 Dec 2016 08:53:11 +0000 (00:53 -0800)]
Bug 7335 - Flow update rejected by switch generates
faulty flow entry in operational DS
When flow update request comes to plugin, it cleans up
the flow hashmap for the updated flow, but it does not
clean up the flow with the assumption that in the next
statistics cycle, this stale flow in operational data
store will be overwritten by the new modified flow,
but as reported in the issue, if installation of modified
flow fails, it will leave the stale flow in the data store.
Change-Id: I47905f980aabc83134c6eccfbf0655d48e71484b
Signed-off-by: Anil Vishnoi <vishnoianil@gmail.com>
Jozef Bacigal [Mon, 5 Dec 2016 11:05:01 +0000 (11:05 +0000)]
Merge "BUG-6890:Flow-Removed Notification configuration"
Jozef Bacigal [Mon, 5 Dec 2016 09:51:10 +0000 (09:51 +0000)]
Merge "Add new API's for LLDP"
Vinh Nguyen [Fri, 18 Nov 2016 23:03:39 +0000 (15:03 -0800)]
Bug 7209 - Null Pointer Exception in LearnCodecUtil when add learn flow for ipv6
The exception caused by using ByteBuf::readShort
(valid range: -32,768 32,767) for ipv6 etherType '0x86dd'
The fix is to use ByteBuf::readUnsignedShort
Change-Id: I238535565a66692b5d4dbe39b8cb7809867f3cde
Signed-off-by: Vinh Nguyen <vinh.nguyen@hcl.com>
(cherry picked from commit
e9deca32b7e455ba805adc35aa49d635b2a2537e)
senthil [Fri, 4 Nov 2016 17:26:49 +0000 (22:56 +0530)]
Add new API's for LLDP
*Right now LLDP time period is hard coded
*This patch enables to set the time period dynamically,
which increases the performance of the CPU
*Increase in CPU performance is observed clearly when we do scaling
Change-Id: I959e151c1e0f11799617bc3ae679cfb7539e764a
Signed-off-by: senthil <senthil.b@tataelxsi.co.in>
epgoraj [Thu, 27 Oct 2016 11:22:18 +0000 (16:52 +0530)]
BUG:6997 supporting OXM_OF_MPLS_LABEL in nicira extensiona
Description : currently under nicira-extension, MPLS support is not
present in nicira Move action. Mainly in ECMP use-case we need to use
mpls_label under nicira_move_action type. The mpls_label will be using as
example ( move:NXM_NX_REG1[0..19]->OXM_OF_MPLS_LABEL[] )
Change-Id: Ia497b963f30bf9ffcd09430db8ed85661a64859f
Signed-off-by: epgoraj <p.govinda.rajulu@ericsson.com>
Signed-off-by: Periyasamy Palanisamy <periyasamy.palanisamy@ericsson.com>
Jozef Bacigal [Mon, 21 Nov 2016 14:42:20 +0000 (14:42 +0000)]
Merge "Bug 6820 - Implement SalExperimenterMpMessageService"
Jamo Luhrsen [Wed, 9 Nov 2016 18:55:13 +0000 (10:55 -0800)]
lower log level when stats come before flow is written to deviceflowregistry
Change-Id: Ib24b9e97c86b2d1a24610204b61fcf9237871f0e
Signed-off-by: Jamo Luhrsen <jluhrsen@redhat.com>
(cherry picked from commit
ac114ea16d60aff29106fdf687e2f35a33f7e0d6)
Shuva Kar [Thu, 10 Nov 2016 05:47:23 +0000 (11:17 +0530)]
BUG-6890:Flow-Removed Notification configuration
Changing the flag to enable/disable flow removed
notification.
Currently the flow-removed notification is controlled by the flag
notification-flow-removed-off which is on by default(value set to false).
However this logic being double-negative causes some confusion to the
end-user. Thus modifying the flag to enable-flow-removed-notification
and setting it to true by default.
The associated logic involved at oyther places have been modified as
well as a part of this commit.
Change-Id: I1452de6e3e72030608c89168f19328d9c6aa8f1c
Signed-off-by: Shuva Kar <shuva.jyoti.kar@ericsson.com>
Shuva Jyoti Kar [Wed, 9 Nov 2016 10:16:26 +0000 (10:16 +0000)]
Merge "Bug 7058 - [Helium Plugin]Stats collection issue when controller disconnect the device"
Jozef Bacigal [Thu, 3 Nov 2016 11:40:04 +0000 (11:40 +0000)]
Merge "BUG-6890: Statistics-polling configuration"
Anil Vishnoi [Fri, 28 Oct 2016 15:58:06 +0000 (17:58 +0200)]
Bug 7058 - [Helium Plugin]Stats collection issue when controller disconnect the device
Change-Id: I50164bf9c3f09097d211b9f40a3f2325dee38d45
Signed-off-by: Anil Vishnoi <vishnoianil@gmail.com>
yunyunhan [Tue, 1 Nov 2016 18:40:15 +0000 (02:40 +0800)]
Bug 6820 - Implement SalExperimenterMpMessageService
Change-Id: Ibfbdea25957b8259a6b5070fb0598172d44108bc
Signed-off-by: yunyunhan <han.yunyun@zte.com.cn>
Shuva Kar [Mon, 24 Oct 2016 16:21:06 +0000 (21:51 +0530)]
BUG-6890: Statistics-polling configuration
Changing the current flag to enable/disable statistics
polling.
Currently the statistics polling is controlled by the flag
is-statistics-polling-off which is off by default(value set to false).
However this logic being double-negative causes some confusion to the
end-user. Thus modifying the flag to is-statistics-polling-on and setting
it to true by default.
The associated logic involved at oyther places have been modified as
well as a part of this commit.
Change-Id: Ia9a027433611912c11ff0f3166aa6f68efdc6913
Signed-off-by: Shuva Kar <shuva.jyoti.kar@ericsson.com>
Anil Vishnoi [Sat, 22 Oct 2016 12:22:14 +0000 (05:22 -0700)]
Bug 7011 - Race condition in statistics collection related transaction chain handling
Change-Id: Iabc18b2814bf2f49bb6159f0bb8f9f55eda2e07d
Signed-off-by: Anil Vishnoi <vishnoianil@gmail.com>
Signed-off-by: Shuva Kar <shuva.jyoti.kar@ericsson.com>
Jozef Bacigal [Fri, 28 Oct 2016 07:43:47 +0000 (07:43 +0000)]
Merge "Implement SalExperimenterMpMessageService"
Tomas Slusny [Thu, 27 Oct 2016 08:33:32 +0000 (10:33 +0200)]
Optimize port number lookups
- Remove unnecessary OpenflowPortsUtil#init() and
OpenflowPortsUtil#close() methods and add static constructors
instead, so BiMaps will be initialized only when really needed,
and we do not need to call OpenflowPortsUtil#init() method
everywhere
- Cache inverse port BiMaps in OpenflowPortsUtil to greatly reduce
lookup time in these BiMaps in some methods
- Try to use more short version instead of deprecated
OpenflowVersion to reduce deprecation and to reduce
memory use (less conversions from OpenflowVersion to short)
- Use proper MAX port constant when finding max port number
- Simplify some conditions in OpenflowPortsUtil
- Use proper OF_URI_PREFIX contant in InventoryDataServiceUtil
Resolves: bug 7046
Change-Id: I1ea033963fb48416d004398e2ee72909231aaea6
Signed-off-by: Tomas Slusny <tomas.slusny@pantheon.tech>
Tomas Slusny [Thu, 27 Oct 2016 12:35:19 +0000 (14:35 +0200)]
Implement SalExperimenterMpMessageService
Add missing implementation for experimenter multipart message
RPC service and register it as routed RPC implementation
Resolves: bug 6820
Change-Id: I5646f93dd6375b729e995a9e60e6d688f1508559
Signed-off-by: Tomas Slusny <tomas.slusny@pantheon.tech>
Tomas Slusny [Mon, 3 Oct 2016 15:43:08 +0000 (17:43 +0200)]
Improve cleanup after device disconnected event
- Ensure that all contexts are removed from managers at once
at end of disconnect chain right before unregistration from
cluster singleton service
- Prevent closing some services multiple times during device
disconnect chain
- Prevent some NPEs in DeviceInitializationUtils what was caused
by connecting and disconnecting device with no time in between
- Unify all openflow managers to implement OFPManager interface
- Ensure that when we will fail to set device to SLAVE we will wait
until device is removed from operational DS and then continue
Resolves: bug 6672
See also: bug 6710, bug 5271
Change-Id: I3845c7d2a9147125b185d3abcc3fc8dd63ba5da8
Depends-On: I15f89cbd43310b0a8e4b7ac78595eeaaa82a65ee
Signed-off-by: Tomas Slusny <tomas.slusny@pantheon.sk>
Jozef Bacigal [Mon, 24 Oct 2016 11:14:53 +0000 (11:14 +0000)]
Merge "BUG-6890:"
miroslav.macko [Mon, 24 Oct 2016 09:14:37 +0000 (11:14 +0200)]
Fix direct statistics
- Initialize statistics gathering
Resolves: bug 7007
Change-Id: I0970b3c690f0771dbd1637405e3064a984b1ef4c
Signed-off-by: miroslav.macko <miroslav.macko@pantheon.tech>
GauravBhagwani [Thu, 13 Oct 2016 08:09:34 +0000 (13:39 +0530)]
Bug: 6930 Notiifcation-suppliers was broken
Review contains changes required for making notification-supplier as per
Blueprint Injection method
- Removed Config Subsystem parts - Yang, Config XML, Modules/ModuleFactory
- Added Blueprint XML for notification-supplier
- Removed Config Dependency from features Pom
- Removed references to Config XML
Change-Id: Ifbdcb21140903a668ad0b8dd6e2df666b7e3e37f
Signed-off-by: GauravBhagwani <gaurav.bhagwani@ericsson.com>
Shuva Kar [Mon, 17 Oct 2016 08:57:59 +0000 (14:27 +0530)]
BUG-6890:
Fix to provide default values for configurable parameters by
handling the NumberFormatException in case the configurable
parameters are either null or absent
Change-Id: Idb37565167778a900732df2dfef428847b0efd3b
Signed-off-by: Shuva Kar <shuva.jyoti.kar@ericsson.com>
miroslav.macko [Tue, 18 Oct 2016 17:06:30 +0000 (19:06 +0200)]
Fix flow matching function
- If flow is not present in DeviceFlowRegistry,
don't write to operational DS.
- Update SalFlowService "update" method
- Update Unit tests
Resolves: bug 6917
Change-Id: If07e94be2d2e8564a2d39d88aec0ea5ea6ac7d19
Signed-off-by: miroslav.macko <miroslav.macko@pantheon.tech>
Jozef Bacigal [Thu, 20 Oct 2016 13:06:08 +0000 (13:06 +0000)]
Merge "BUG-6890: Edit to cfg file reflecting that statistics collection is turned on by default"
Michal Polkorab [Wed, 19 Oct 2016 13:04:51 +0000 (15:04 +0200)]
Revert "Revert "Move the Openflow connections blueprint to OpenflowJava project""
This reverts commit
e84b8d9e2c0e38a950db4295a61b24dd77538e01.
Change-Id: I1c79ddcb0041d4599e82fa5f6ed227d530dfab97
Signed-off-by: Michal Polkorab <michal.polkorab@pantheon.sk>
Shuva Jyoti Kar [Thu, 20 Oct 2016 07:05:20 +0000 (07:05 +0000)]
Merge "Remove RoleManager and RoleContext"
Shuva Kar [Tue, 18 Oct 2016 11:31:06 +0000 (17:01 +0530)]
BUG-6890: Edit to cfg file reflecting that statistics
collection is turned on by default
Change-Id: I8a97cb11b1b98189a04daed50961b4a912113749
Signed-off-by: Shuva Kar <shuva.jyoti.kar@ericsson.com>
Jozef Bacigal [Mon, 17 Oct 2016 10:25:32 +0000 (12:25 +0200)]
Remove RoleManager and RoleContext
- no more functionality for role manager (after Singleton changes)
- all remain functionality from role-mng and ctx were moved to device-mgn and ctx
Change-Id: I1cc1ef23c45da7b9a4288194caa7f88f7534e409
Signed-off-by: Jozef Bacigal <jozef.bacigal@pantheon.tech>
Shuva Kar [Mon, 17 Oct 2016 05:55:36 +0000 (11:25 +0530)]
BUG-6890: Updated the cfg file with detailed description
of usage
Change-Id: Ibe772a29107296cb96cf4aa48c1d3cb2dee4f3b2
Signed-off-by: Shuva Kar <shuva.jyoti.kar@ericsson.com>
Shuva Kar [Mon, 10 Oct 2016 08:40:27 +0000 (14:10 +0530)]
BUG-6890: Enabling statistics collection through a config
parameter in openflowplugin.cfg
Change-Id: If7dbedd50d7f23a075c53279654e36d33b212867
Signed-off-by: Shuva Kar <shuva.jyoti.kar@ericsson.com>
Shuva Kar [Mon, 10 Oct 2016 08:27:43 +0000 (13:57 +0530)]
BUG-6890: Enabling echo timout configurable through
config file
Change-Id: I3ff729b418809e8342a491ac6ab2a102f5a1ffe5
Signed-off-by: Shuva Kar <shuva.jyoti.kar@ericsson.com>
Shuva Kar [Mon, 10 Oct 2016 07:11:03 +0000 (12:41 +0530)]
BUG-6890: Enabling barrier configurability through
cfg file
Change-Id: Iaada857a439c7774c6e31c27cc7be1b26c68ad1b
Signed-off-by: Shuva Kar <shuva.jyoti.kar@ericsson.com>
Jozef Bacigal [Fri, 14 Oct 2016 13:20:40 +0000 (15:20 +0200)]
Revert "Move the Openflow connections blueprint to OpenflowJava project"
This reverts commit
f44ebeb5ca3e25ff4c863f374ed8b9b33466e991.
Change-Id: Ib95293482546888bbe678bf60c29c14fe4f972b3
Signed-off-by: Jozef Bacigal <jozef.bacigal@pantheon.tech>
Jozef Bacigal [Fri, 14 Oct 2016 06:23:25 +0000 (06:23 +0000)]
Merge "Optimize LLDP packet check"
Jozef Bacigal [Fri, 14 Oct 2016 06:10:51 +0000 (06:10 +0000)]
Merge "BUG-6890: Enabling statistics rpc config through openflowplugin.cfg"
Shuva Kar [Mon, 10 Oct 2016 04:39:42 +0000 (10:09 +0530)]
BUG-6890: Enabling statistics rpc config through
openflowplugin.cfg
Change-Id: I54d1de2eac18b5cde38150cbdc21174d7111f740
Signed-off-by: Shuva Kar <shuva.jyoti.kar@ericsson.com>
Mohamed El-Serngawy [Tue, 4 Oct 2016 20:50:37 +0000 (16:50 -0400)]
Move the Openflow connections blueprint to OpenflowJava project
This patch is related to https://git.opendaylight.org/gerrit/#/c/46518/
Moving the Openflow connections (defaultSwitchConnProvider and legacySwitchConnProvider)
blueprint to OpenflowJava project as its config data model "openflow-switch-connection-provider-impl"
exist in OpenflowJava project
Change-Id: Ic6db83e98d57cf17ef5883d64755118214815731
Signed-off-by: Mohamed El-Serngawy <melserngawy@inocybe.com>
miroslav.macko [Fri, 7 Oct 2016 09:19:57 +0000 (11:19 +0200)]
Optimize LLDP packet check
Deserialize only LLDP packets.
See also: bug 1462
Change-Id: Ibdd2f3eb0dfe784fd235e51a591da64971c2afd3
Signed-off-by: miroslav.macko <miroslav.macko@pantheon.tech>
miroslav.macko [Mon, 3 Oct 2016 16:07:15 +0000 (18:07 +0200)]
Bug 6745 SimplifiedOperationalListener optimation
- optimize processNodeModification method
- update test
Change-Id: I941a84bff4322c2b2b64f8404791ec6d00a9d200
Signed-off-by: miroslav.macko <miroslav.macko@pantheon.tech>
Jozef Bacigal [Mon, 3 Oct 2016 07:33:05 +0000 (07:33 +0000)]
Merge "Bug 6745 Do not skip first data for reconciliation"
Andrej Leitner [Wed, 28 Sep 2016 12:45:46 +0000 (14:45 +0200)]
Bug 6745 Do not skip first data for reconciliation
- we can accept first modification since all statistics
are intentionally collected in one step on startup
- added test
- updated comments
Change-Id: I94590fb268accb0237260a09d184c2cecd1fb324
Signed-off-by: Andrej Leitner <andrej.leitner@pantheon.tech>
Tomas Slusny [Fri, 30 Sep 2016 11:16:17 +0000 (13:16 +0200)]
Fix unregistering of cluster services
When unregistering cluster singleton services, check if we are not
already in unregistering phase, and if yes, skip this process. Also,
chain stopClusterServices futures properly, so Singleton will know, when
to finish unregistering.
See also: bug 6672
Change-Id: I07e077eb7dd655b6af9e4e3ee61e46163b8538b0
Signed-off-by: Tomas Slusny <tomas.slusny@pantheon.sk>
Andrej Leitner [Wed, 28 Sep 2016 07:17:40 +0000 (09:17 +0200)]
Create SemaphoreKeeper inside decorators
Change-Id: I29fb2da53d32b331459a4492ca15a4081ea79195
Signed-off-by: Andrej Leitner <andrej.leitner@pantheon.tech>
Jozef Bacigal [Wed, 28 Sep 2016 07:57:51 +0000 (07:57 +0000)]
Merge "Bug 6745 Improve compression queue locking and handle InterruptedException"
Jozef Bacigal [Tue, 27 Sep 2016 13:39:08 +0000 (13:39 +0000)]
Merge "Revert "Bug 6745 Do not ignore syncup return value""
Andrej Leitner [Tue, 27 Sep 2016 12:13:29 +0000 (14:13 +0200)]
Bug 6745 Improve compression queue locking and handle InterruptedException
- compression queue could be locked per device and not for every change
since there is only one entry per device in it
- IE handled in one place
Change-Id: Ic28b448d619c663757f391e7a443b28c8f6a871d
Signed-off-by: Andrej Leitner <andrej.leitner@pantheon.tech>
Andrej Leitner [Mon, 26 Sep 2016 14:24:18 +0000 (16:24 +0200)]
Add finals and move thread name constant to provider
- add onDTC annotations
- code cleanup
Change-Id: I585d08e67138805672d19293892358205650c998
Signed-off-by: Andrej Leitner <andrej.leitner@pantheon.tech>
Andrej Leitner [Tue, 27 Sep 2016 06:59:17 +0000 (08:59 +0200)]
Revert "Bug 6745 Do not ignore syncup return value"
This reverts commit
df561a83c33b7af9818d8d0d0e8e6b00f7a37a93.
Change-Id: I9133264ba297bf4293a50e26e1d2e1051df1f093
Signed-off-by: Andrej Leitner <andrej.leitner@pantheon.tech>
Jozef Bacigal [Mon, 26 Sep 2016 15:32:46 +0000 (15:32 +0000)]
Merge "Bug 6745 Set compression semaphore to fair"
Jozef Bacigal [Mon, 26 Sep 2016 15:32:41 +0000 (15:32 +0000)]
Merge "Bug 6745 Do not ignore syncup return value"
Jozef Bacigal [Mon, 26 Sep 2016 15:32:34 +0000 (15:32 +0000)]
Merge "Bug 6745 Remove thread renaming and unnecessary logging"
Jozef Bacigal [Mon, 26 Sep 2016 14:53:55 +0000 (14:53 +0000)]
Merge "Bug 6745 Fix replacing in compression queue"
Andrej Leitner [Mon, 26 Sep 2016 10:55:43 +0000 (12:55 +0200)]
Bug 6745 Set compression semaphore to fair
- prevent changing the order of incoming changes
Change-Id: If7df69334b2ff8217986cd933e25463cb6e90171
Signed-off-by: Andrej Leitner <andrej.leitner@pantheon.tech>
Andrej Leitner [Mon, 26 Sep 2016 09:40:18 +0000 (11:40 +0200)]
Bug 6745 Do not ignore syncup return value
Change-Id: Ide811a0db0d684dc3b37ea3f6707d779162cb87f
Signed-off-by: Andrej Leitner <andrej.leitner@pantheon.tech>
Andrej Leitner [Mon, 26 Sep 2016 08:05:36 +0000 (10:05 +0200)]
Bug 6745 Remove thread renaming and unnecessary logging
- change name format for thread pool
- remove thread renaming and useless logging
- remove duplicit time logging
- update return values
Change-Id: I78abca1870d278c162a7f717ff800dd37c1d4234
Signed-off-by: Andrej Leitner <andrej.leitner@pantheon.tech>
Andrej Leitner [Mon, 26 Sep 2016 08:29:26 +0000 (10:29 +0200)]
Bug 6745 Fix replacing in compression queue
When there were more changes in a row on startup it could happend
that the first syncup entry (config-operational) was not updated
but replaced with following config-config changes. Therefore we need
to update syncup entry in compression queue everytime when new config
diff is comming (not only if config-config entry resides there).
Change-Id: I9d73fb348f5e1ace1b138052bcd2a5614946efa9
Signed-off-by: Andrej Leitner <andrej.leitner@pantheon.tech>
Tomas Slusny [Mon, 26 Sep 2016 08:34:02 +0000 (10:34 +0200)]
Write SwitchFeatures to operational datastore
Ensures that SwitchFeatures are written to operational
datastore during device initialization in Lithium design.
Fixes: bug 6764
Change-Id: Ib32f15b73febe4d9115884d418bfe87b8e716635
Signed-off-by: Tomas Slusny <tomas.slusny@pantheon.sk>
Alexis de Talhouët [Wed, 24 Aug 2016 20:42:20 +0000 (16:42 -0400)]
Remove reference to sal-inmemory-datastore config system file
As it was removed from the controller
Change-Id: Ied428beee2f46cfd000afcf9ca56e0f25c8c5594
Signed-off-by: Alexis de Talhouët <adetalhouet@inocybe.com>
Andrej Leitner [Wed, 21 Sep 2016 12:34:38 +0000 (14:34 +0200)]
Remove excessive (trace) logging in FRS
- removed not so necessary logging + some updates
- added some finals
- simplify statements
Change-Id: I0db57a38a45efd6bb8334a9f05cdba991bff556d
Signed-off-by: Andrej Leitner <andrej.leitner@pantheon.tech>
Anil Vishnoi [Wed, 21 Sep 2016 07:09:23 +0000 (07:09 +0000)]
Merge "BUG-6118: making the OFentityListener aware of the InJeopardy() flag"
Jozef Bacigal [Wed, 21 Sep 2016 06:52:28 +0000 (06:52 +0000)]
Merge "ClusterSingletonService cleaning FRM/FRS"
Jozef Bacigal [Wed, 21 Sep 2016 06:38:47 +0000 (06:38 +0000)]
Merge "Create DeviceMasterShipManager before forwarders"
Tomas Slusny [Tue, 20 Sep 2016 07:22:45 +0000 (09:22 +0200)]
Fix translation to *packet.received.MatchBuilder
Fix incorrect cast of *flow.MatchBuilder to
*packet.received.MatchBuilder in Helium plugin, what
was causing PacketInTranslator to be broken.
Fixes: bug 6456
Change-Id: I9e42402a3599dd2e0a91381019c4ca86e8294aa2
Signed-off-by: Tomas Slusny <tomas.slusny@pantheon.sk>
Tomas Slusny [Tue, 20 Sep 2016 09:11:16 +0000 (11:11 +0200)]
Create DeviceMasterShipManager before forwarders
This prevents NPE when forwarder receives DataTreeChange
event faster thatn DeviceMasterShipManager is created.
Fixes: bug 6459
Change-Id: Ifb9d4520b58d9f5fc265934968386641c60772ef
Signed-off-by: Tomas Slusny <tomas.slusny@pantheon.sk>
Shuva Jyoti Kar [Tue, 20 Sep 2016 11:14:42 +0000 (11:14 +0000)]
Merge "Bug 6749: Set the openflow connection config at xml file"
melserngawy [Fri, 16 Sep 2016 21:15:51 +0000 (17:15 -0400)]
Bug 6749: Set the openflow connection config at xml file
Set the openflow connections (default and legacy) inital configuration
to xml file to be able to change it after starting the distribution
The openflow TLS configuration was missing in the blueprint,
add it with default values
Change-Id: Iad34bd3d7e237da52fe3193c4ad6d6ff2141358c
Signed-off-by: melserngawy <melserngawy@inocybe.com>
Andrej Leitner [Mon, 19 Sep 2016 16:40:43 +0000 (18:40 +0200)]
Update comments and imports after DataChangeListener changes
Change-Id: Ic8174cc2627deb12d48f6d41444f2e9b4dc60406
Signed-off-by: Andrej Leitner <andrej.leitner@pantheon.tech>
Jozef Bacigal [Mon, 19 Sep 2016 12:33:38 +0000 (12:33 +0000)]
Merge "Update comments around flat-batch service"
Jozef Bacigal [Mon, 19 Sep 2016 12:32:48 +0000 (12:32 +0000)]
Merge "Convert openflowplugin-it to use DTCL instead of DCL"
Jozef Bacigal [Mon, 19 Sep 2016 12:32:42 +0000 (12:32 +0000)]
Merge "Update old links in code to deprecated DataChangeListener"
Jozef Bacigal [Mon, 19 Sep 2016 12:32:36 +0000 (12:32 +0000)]
Merge "Convert OF samples to use DTCL instead of DCL"
Tomas Slusny [Tue, 13 Sep 2016 06:26:15 +0000 (08:26 +0200)]
Fix connection closing before initialization
Check if connection is fully initialized when closing
objects created during initialization phase to prevent
NPEs, what can cause incorrect close of connection
and later program unstability.
Also, increase timeout to propagate role to 10 seconds
in case of slower machine.
Resolves: bug 5271
See also: bug 6672
Change-Id: I0f009edf5fe3b382e2bfee64f72036ba599ccc5d
Signed-off-by: Tomas Slusny <tomas.slusny@pantheon.tech>
Jozef Bacigal [Mon, 19 Sep 2016 08:30:48 +0000 (08:30 +0000)]
Merge "Bug 6665 Clean code"
Jozef Bacigal [Mon, 19 Sep 2016 08:30:26 +0000 (08:30 +0000)]
Merge "Bug 6665 - Fix switches scalability"
Andrej Leitner [Wed, 14 Sep 2016 14:39:28 +0000 (16:39 +0200)]
Convert openflowplugin-it to use DTCL instead of DCL
Change-Id: I8a3f3b690bef5d29dcd9b51e243bd83ad5c501c6
Signed-off-by: Andrej Leitner <andrej.leitner@pantheon.tech>
Andrej Leitner [Tue, 13 Sep 2016 12:57:50 +0000 (14:57 +0200)]
Update old links in code to deprecated DataChangeListener
- update old links to DataChangeListener in comments, logs,
names of variables since DataTreeChangeListener is already used
- optimize imports and cleanup
Change-Id: I20f3359f5f7c4bbd3af844bc45506a5575c98285
Signed-off-by: Andrej Leitner <andrej.leitner@pantheon.tech>
Andrej Leitner [Wed, 14 Sep 2016 14:25:50 +0000 (16:25 +0200)]
Convert OF samples to use DTCL instead of DCL
Change-Id: I53eebe8672996ed4351240a8c649e6c2815e8a0c
Signed-off-by: Andrej Leitner <andrej.leitner@pantheon.tech>
Shuva Jyoti Kar [Thu, 15 Sep 2016 16:15:15 +0000 (16:15 +0000)]
Merge "Bug 6633 : NXM_OF_IN_PORT support in openflowplugin"
Andrej Leitner [Tue, 30 Aug 2016 13:16:51 +0000 (15:16 +0200)]
ClusterSingletonService cleaning FRM/FRS
Change-Id: I7c9a31ccab5b7b79b318cc7b59742aa5652e41f8
Signed-off-by: Andrej Leitner <andrej.leitner@pantheon.tech>
Andrej Leitner [Tue, 13 Sep 2016 12:16:26 +0000 (14:16 +0200)]
Update comments around flat-batch service
Change-Id: I62f3ccbf38fd6f5aeb830e55c5f60923c6f8e8da
Signed-off-by: Andrej Leitner <andrej.leitner@pantheon.tech>
Jozef Bacigal [Thu, 8 Sep 2016 14:56:30 +0000 (16:56 +0200)]
Bug 6665 Clean code
Change-Id: Ia87a66c37f906a3351f3a982209f6778f7c8a311
Signed-off-by: Jozef Bacigal <jozef.bacigal@pantheon.tech>
Jozef Bacigal [Thu, 8 Sep 2016 09:25:30 +0000 (11:25 +0200)]
Bug 6665 - Fix switches scalability
- Stop gathering services if going to be slave or disconected
- Duplicate code removed in role context
- Lifecycle service LOG info cleaning
- Propagate close even if we are in close state
- NPE in statistics manager
- Test correction
Change-Id: Iaad1a8ed4abc3d39014713ca018d6357f8a95267
Signed-off-by: Jozef Bacigal <jozef.bacigal@pantheon.tech>
Chetan A G [Tue, 6 Sep 2016 04:21:48 +0000 (09:51 +0530)]
Bug 6633 : NXM_OF_IN_PORT support in openflowplugin
Description : OVS split-horizon logic will drop pkts by default if value
of in_port and out_port is same. But, if we have two vlan-trunk member
VM for which trunk interface is same, the connectivity between these two
VM cannot be established as OVS drops such packets. So, it is required to
override the value of in_port so that split_horizon check is bypassed.
Nicra NXM_OF_IN_PORT support is required in order to achieve this. The
in_port value will be overrriden using load(ex:
load:0x1->NXM_OF_IN_PORT[]).
Change-Id: Ica0a1b2da27fc189b8906462a4420473215a22af
Signed-off-by: xcheara <chetan.arakere@altencalsoftlabs.com>
Shuva Kar [Thu, 1 Sep 2016 16:33:25 +0000 (22:03 +0530)]
BUG-6595: Need more information in logging
Enabling port information in the logging to
understand better which port status addition
is failing
Change-Id: I9eb116fa58e85ddb711ca423071ee1d78a088f19
Signed-off-by: Shuva Kar <shuva.jyoti.kar@ericsson.com>
Jozef Bacigal [Wed, 7 Sep 2016 06:23:56 +0000 (06:23 +0000)]
Merge "Bug 6554 Fix rejecting connections"
Jozef Bacigal [Wed, 7 Sep 2016 06:23:45 +0000 (06:23 +0000)]
Merge "Bug 6176 - Decrease logging level in Sal-F/G/M-Service and use synchronized BiMap"
Jozef Bacigal [Mon, 22 Aug 2016 11:42:50 +0000 (13:42 +0200)]
Bug 6554 Fix rejecting connections
- two way device context close removed
- txManager lambda improvements
- txManager logs improvements
- device context lazy initialization
- role context close improvement
Change-Id: I1a9f5890f267ada9a2978f9a92f792ab2411c1aa
Signed-off-by: Jozef Bacigal <jozef.bacigal@pantheon.tech>
Shuva Kar [Tue, 28 Jun 2016 15:52:31 +0000 (21:22 +0530)]
BUG-6118: making the OFentityListener aware of the InJeopardy() flag
Change-Id: I8e489b9afd7f433b924e009fe8ba64166b7c146e
Signed-off-by: Shuva Kar <shuva.jyoti.kar@ericsson.com>
Andrej Leitner [Fri, 26 Aug 2016 11:18:03 +0000 (13:18 +0200)]
Bug 6542 FRS - prevent concurrent reconciliation node config add
- unregister for reconciliation if there was an attempt but no
config present for node
- when node config is added essentially reconciliation is done
- junit updates
Change-Id: Ic8f759e1638285ef7e82a35a0c9d330a2b0340e7
Signed-off-by: Andrej Leitner <andrej.leitner@pantheon.tech>
Andrej Leitner [Tue, 30 Aug 2016 15:09:28 +0000 (17:09 +0200)]
Bug 6176 - Decrease logging level in Sal-F/G/M-Service and use synchronized BiMap
- decrease logging level to prevent overloading of netty
thread with logging errors (seen in troughput test)
- despite the fact that unsuccesful RPCresult brings errors
from device there is no reason for throwing error since
it is not error of karaf ot OFP itself (therefore debug)
- change BiMap to synchronized because of ConcurrentModificationException
seen in tests
Change-Id: Ia37212647a9c119ecd51d6685ea8fffb8ee94a39
Signed-off-by: Andrej Leitner <andrej.leitner@pantheon.tech>
Andrej Leitner [Wed, 24 Aug 2016 14:10:27 +0000 (16:10 +0200)]
Bug 6524 FlowDescriptor instead of SwitchFlowId in FRS
Change-Id: Ibb02c310be27f02c7543e157d2f5e7ca7cc430a8
Signed-off-by: Andrej Leitner <andrej.leitner@pantheon.tech>
Andrej Leitner [Tue, 23 Aug 2016 13:15:14 +0000 (15:15 +0200)]
Bug 6513 Remove FD from registry immediately
- remove FlowDescriptor from DeviceFlowRegistry immeadiately
instead of marking it as to-be-removed
- updated tests
Change-Id: I269a510fa67b6d04181039515aaefda90b53b827
Signed-off-by: Andrej Leitner <andrej.leitner@pantheon.tech>