Convert interfacemanager to datastore-constrained

Change-Id: Ia5fd297e7b81a4508887278972cd7a36055774f0
Signed-off-by: Stephen Kitt <skitt@redhat.com>

Make read-only transactions cancel themselves

When a read-write transaction is only used to read from the datastore,
there's no point in committing it; this patch changes managed
read-write transactions so they are cancelled rather than submitted
when appropriate.

Change-Id: Ic7175574097702a45290c7500fcad2c37475a228
Signed-off-by: Stephen Kitt <skitt@redhat.com>

Return Set instead of Iterable in test

Method signature will be changed to Set to define equality, prepare
for that.

Change-Id: I073a3939dce0c6e0fb9d21026c9da19ecb1976b4
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Drop odlparent FindBugs override

Now that we're using odlparent 3.1.3, we no longer need to pull in a
newer version of its FindBugs configuration.

Change-Id: I6a9e37d36e0a82edbb8e4030fdf531ce825d332d
Signed-off-by: Stephen Kitt <skitt@redhat.com>

use managed transaction in AlivenessMonitor processReceivedMonitorKey()

JIRA: GENIUS-180
Change-Id: I7b1a5d14c78b650e46ab2af6e1dffc570409fa13
Signed-off-by: Michael Vorburger <vorburger@redhat.com>

Remove references to mdsal-model-artifacts

This artifact is going away, migrate to mdsal-artifacts.

Change-Id: I393eeec82914f73b689307d9e0dd06852f7fc8ea
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

make MDSALManager's 3 inner classes private instead of package local

and make some private helper methods static because they can be

Change-Id: I74e3f367a991bc275f0f0f6308490d3c2bef1331
Signed-off-by: Michael Vorburger <vorburger@redhat.com>

remove not needed version number in alivenessmonitor POM

Change-Id: I7221d759e206c00dcbe378a5f0e353fbd85b4d39
Signed-off-by: Michael Vorburger <vorburger@redhat.com>

Bump versions by x.(y+1).z for next dev cycle

Change-Id: I037dfc09ba940fd2d3ffab2bcb9eae20d8606621
Signed-off-by: Anil Belur <abelur@linuxfoundation.org>

API to expose tunnelstate cache

Providing an API to get tunnel state from cache
to avoid DS read.

Change-Id: I961ce3bcac9d89d998814846633220414cdc605d
Signed-off-by: Nidhi <nidhi.adhvaryu@ericsson.com>

GENIUS-189: Enforce use of managed transactions
- uses the wrapper provided in c/74759/

Change-Id: Ia2df255cdc585b8fdd212ea1491f2c483882a38d
Signed-off-by: Edw7n <n.edwin.anthony@ericsson.com>

Bump yangtools to 2.0.10

This fixes an issue with actions, hence we need it in Fluorine.

Change-Id: I5f47930673ed7f57ee84d832216308a957db6a01
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Fix for ITM reporting wrong tunnel status

When the tunnel is down and the controller undergoes a reboot, the tunnel
BFD states come as UP and DOWN back to back and this results in the DOWN
state not getting reflected correctly in ITM.
Fix is to cache the tunnel status that comes as DOWN in "update" and
process the add DTCN and then process the update tunnel state DTCN
Fixed checkstyle issues
Fixed issues due to rebase
Moved the unprocessed cache to a separate class
Addressed review comments

Change-Id: Iee89e482b8d55f806264f23904e74c5122c0c399
Signed-off-by: Hema Gopalakrishnan <hema.gopalkrishnan@ericsson.com>

Upgrade support for ItmDirectTunnels

When the controller gets upgraded from non-itmdirecttunnels version to
itmdirecttunnels version, then some datastores need to be cleaned up.
This patch cleans up two such datastores.
Using TunnelLstenerCreator for conditional instantiation of config and
Internal listener for ITM Direct Tunnels

Change-Id: I4c9da895783d4689aab7ff6a4013f862c23dd16f
Signed-off-by: Hema Gopalakrishnan <hema.gopalkrishnan@ericsson.com>

netvirt 3node CSIT - Unable to initialize bean tepCommandHelper

In a 3 node setup, TepCommandHelper bean initialization fails, as all
3 nodes are writing to the same DS, resulting in ConflicitngModificationException.
The bigger question here, whether we really want to do such a heavy method
configureTunnelType() in the bundle bringup thread. It is having several datastore
reads and writes.

JIRA: GENIUS-192

Change-Id: I6607997478cebc4c7d1fc7ebf18ae89ae2eaa857
Signed-off-by: Faseela K <faseela.k@ericsson.com>

Bug: Genius-167

Change-Id: Id078d379d0fe4824e13d156abe55e09dd92097af
Signed-off-by: Chintan Apte <chintan.apte@ericsson.com>

GENIUS-195: Transport Zone default-transport-zone has no subnets

This patch is for fix of JIRA bug GENIUS-195
Non-relevant error log message will be removed occuring in karaf logs
which are not error in nature.

Change-Id: I0d407d9859bfe437ab8dfad402f7cb10e66dae17
Signed-off-by: Tarun Thakur <tarun.t@altencalsoftlabs.com>

Enforce use of (only) managed transactions in fcapsmanager

JIRA: GENIUS-182

Change-Id: If886a40a172c414a5b9a8089820254ce027e8d14
Signed-off-by: Faseela K <faseela.k@ericsson.com>

Enforce use of (only) managed transactions in fcapsapplication

JIRA: GENIUS-182

Change-Id: I7a8ec02e1ca63cafaaa6c445c8818df9a1023cf2
Signed-off-by: Faseela K <faseela.k@ericsson.com>

Enforce use of (only) managed transactions in idmanager

The real work of changing the code was previously done
by Stephen, so this change just enforces future non-regression.

JIRA: GENIUS-179
Change-Id: I34ddd61dcf7bad4ba4c44c559ca3ebc65addab80
Signed-off-by: Michael Vorburger <vorburger@redhat.com>

Enforce use of (only) managed transactions in arputil

JIRA: GENIUS-181

Change-Id: I3643e4c05d50858ed344b6ff39609fa22cafdeee
Signed-off-by: Faseela K <faseela.k@ericsson.com>

Tweaks to avoid unncessary .toString

- includes removing redundant if check

Change-Id: I16b71a0d839b683bdfd279e6d466c3bc02cf0e06
Signed-off-by: Edw7n <n.edwin.anthony@ericsson.com>

Renaming workers in itm listeners

Change-Id: Ib4ad9499cd47a588741a7f8481093471fa9f733f
Signed-off-by: Edw7n <n.edwin.anthony@ericsson.com>

Remove openflowplugin app-config-pusher dependency

This feature is not used by GENIUS.

Change-Id: Ica63b5f18a7052f17effd2e477adbf0e8bd06083
Signed-off-by: Faseela K <faseela.k@ericsson.com>

TepCommandHelper clean-up

Change-Id: I8da4d9b95f7fc793458def6a30d2b97c6f00ddc6
Signed-off-by: Faseela K <faseela.k@ericsson.com>

finish lockmanager's managed transaction conversions

by also switching LockManagerServiceImpl's readWriteLock() to
RetryingManagedNewTransactionRunner, which is easy now that
ManagedNewTransactionRunner has not only the initial call* methods but
also the new apply* methods which can return a value.

Strictly speaking this isn't 100% equivalent to before, because now
readWriteLock() itself will already do 3 retries, whereas before that
happened (and still does) only in the caller.  I can't see how that
would be a problem though - on the contrary.  (E.g. if I am ever
motivated to finish up the infrautils.metrics based monitoring I've long
been meaning to add to the RetryingManagedNewTransactionRunner, then it
would monitor retries in lockmanager also.)

We now also enforce use of (only) managed transactions in lockmanager.

JIRA: GENIUS-183
Change-Id: I766f507b3ad047ca8480b0669ca740ab000eacc2
Signed-off-by: Michael Vorburger <vorburger@redhat.com>

Bump yangtools to 2.0.9

This patch bumps yangtools to latest release.

Change-Id: Ic25f0c507f1544523a77363b494273ad515606db
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

IFM Instance Recovery failing randomly.

Recovery logic was triggering a back to back delete and create.
More deterministic way is to wait for delete to complete and then
proceed with create.

JIRA: GENIUS-191

Change-Id: I065e5c4c94443cda8a953a2dc58c78aa2ef31caa
Signed-off-by: Faseela K <faseela.k@ericsson.com>

Default monitor interval changed to 1000.

Change-Id: I6542fa715a2d1aab7ad4d4b64645547f9be7ec4d
Signed-off-by: Dimple Jain <dimple.jain@ericsson.com>

use Tx commit() instead of deprecated submit() in LockManagerServiceImpl

Change-Id: Ieefb4d5e7db81e05308eaaef6c52ab408ab5d960
Signed-off-by: Michael Vorburger <vorburger@redhat.com>

Bump to odlparent 3.1.3

Change-Id: Ib36163e35fed7d1808aaad5f434717fc7b49c855
Signed-off-by: Stephen Kitt <skitt@redhat.com>

Enforce use of (only) managed transactions in resourcemanager

JIRA: GENIUS-176

Change-Id: Ia9e29267676548f8eac256b2673bb22b247a51ff
Signed-off-by: Faseela K <faseela.k@ericsson.com>

Enforce use of (only) managed transactions in ipv6util

JIRA: GENIUS-184

Change-Id: I1048aeb5021ab364a3a4dfdd0292bcaa23a61614
Signed-off-by: Faseela K <faseela.k@ericsson.com>

reduce version number duplication in interfacemanager-impl POM

Change-Id: I717283ec1b9737dd5a5dc71ad9777c711e485e06
Signed-off-by: Michael Vorburger <vorburger@redhat.com>

Use IetfYangUtils to canonize addresses

IetfYangUtils provides optized utility methods for converting
Mac/PhysAddress to its canonical lower-case format. Use it wherever
possible.

Change-Id: I58860912befbaad74b13287a5c2a53fa91fd80d0
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Simplify ActionConverterUtil

Rather than using uncached reflections, use ready-made logic present
in generated builders.

Change-Id: I5a83dd002ebf7e6121fe915f81a96313d323aede
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

add @Named to UpgradeStateListener @Singleton

this helped me to finally locally reproduce the confusing problem we
were chasing in genius change I91466c31c0526ff227700f23b48b9db0dfb15f5a
<https://git.opendaylight.org/gerrit/#/c/73678/> ...

this does *NOT* fix the problem, and is technically not required now
that we've fixed it via Icacba88d577a4fc5da61fd490a3c9fee13f7034f
<https://git.opendaylight.org/gerrit/#/c/74400/> - but it seems useful
to keep this anyway, just in case we ever hit a similar problem in the
future again.

Fixing https://issues.apache.org/jira/browse/ARIES-1820 could later be a
better real long term solution to immediately see this kind of problem.

Change-Id: I10a750cc4c5eda4ba60c994b76071209565015bf
Signed-off-by: Michael Vorburger <vorburger@redhat.com>

Add DataBroker exclusion checks

This ports the DataBroker exclusion checks (using Checkstyle) from
NetVirt, and enforces them for interfacemanager.

Change-Id: I4ff045b9063f529b793e29814bf51086e5749ce8
JIRA: GENIUS-177
Signed-off-by: Stephen Kitt <skitt@redhat.com>

Fix binding reflections package change

Change-Id: If23949e698d1ebe4fe63cc4c6a9ec25078dc9fbc
Signed-off-by: Faseela K <faseela.k@ericsson.com>

Add support for official OVS NSH implementation

push_nsh and pop_nsh actions are not available in the official
OVS NSH implementation.

Added support for new action encap, decap and dec_nsh_ttl.

Change-Id: I0c3bd980081bcfcb04477b5dfae44c2c8a7162e9
JIRA: TSC-114
Signed-off-by: Jaime Caamaño Ruiz <jcaamano@suse.com>

Use new UpgradeConfig

SRVUTILS-2 added a new upgrade config. For backward
compatibility set the new flag each time old one is
changed.

JIRA: GENIUS-173
DependsOn: Idd3690f23ba6c048689f0d93f767eb62aad40b9e
Change-Id: I91466c31c0526ff227700f23b48b9db0dfb15f5a
Signed-off-by: Vishal Thapar <vthapar@redhat.com>

fix minor JavaDoc typos in UpgradeState

Change-Id: I75471387a0be7281f6e984321f35171778950735
Signed-off-by: Michael Vorburger <vorburger@redhat.com>

simplify NWUtilTest, test IllegalArgumentException and address

but not the exact message content, because it is useful for debugging to
see the address that was invalid, but it's not important to assert on
the exact message.

Change-Id: I438c66a959d08baedcdcc5a1b3a1c55608eaed64
Signed-off-by: Michael Vorburger <vorburger@redhat.com>

Fixup exception message tests

The message reported has changed, adjust for that.

Change-Id: Ia092143fe1dd18e073d48a828769d3e22197bd53
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Add alternative createHwvtepPhysicalLocatorAugmentation()

Callers usually have an IpAddress handy, no need to muck with
string conversion.

Change-Id: I87826a745400393ce980ef110d6286816ff8ee4f
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Use union's stringValue()

getValue() is a bad interface and is going away. use stringValue()
instead.

Change-Id: Ic74394e1c6c8641495fe6c073b2088dd8412bc2a
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Improve IFM/ITM DiagStatus

JIRA: GENIUS-108
Change-Id: Ibcc506fc628cbdbbdd545e97fa2893a747cbf11b
Signed-off-by: Vishal Thapar <vthapar@redhat.com>

Remove DJC documentation

This is already moved to infrautils.

Change-Id: I2a0b0b39a7a14007700888dc8b9841dbb8d7097e
Signed-off-by: Faseela K <faseela.k@ericsson.com>

Minimize feature dependencies

Nothing in genius seems to require odl-mdsal-broker, remove
this dependency to speed things up.

Change-Id: I9e9edb36bc0ad65038c660483b802500ee1fb721
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Use ipAdressBuilder.getDefaultInstance()

Instead of converting to char[], use utility class provided.

Change-Id: Idd43fa9577c4cc5a3f92e1d26801b3e69aab592f
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Avoid ofp topology discovery

openflowplugin is packaging lldp based topology discovery
along with "odl-openflowplugin-flow-services. This feature sends
periodic lldp messages on all the links available, to discover
the topology. Genius does not use this feature, but is coming
by default with the feature we were including.

This patch removes the feature which was previously used, and
use only the appropriate features needed for Genius functionality.

JIRA: OPNFLWPLUG-1024

Change-Id: Idbe860e66ade16f52a5a1860fe231ada26086af4
Signed-off-by: Faseela K <faseela.k@ericsson.com>

Pull in specific models

Rather than pulling in odl-mdsal-models, which contains a lot of
models, pull in just what's needed: RFC7223/7224 ietf-interfaces
and the iana-if-type.

JIRA: MDSAL-363
Change-Id: Ia8ea49cbeb91e7af7cf793ddc7fadd6e93061449
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

GENIUS-164 Fix-Table 0 not programmed occasionally

Occasionally Table 0 flows for ITM is not programmed due to timing issues.
Fix is to synchronize the north and south bound events. If south bound
event doesnt find the config then the event is parked temporarily. WHen
the north bound config event is fired, the parked event will be processed.
These two processing needs to be synchronized else the event may be missed
occasionally resulting in Table 0 not being programmed at all.
Fix using InfraUtils KeyedLocks
Added another cache for parking events if DPNTepsInfo is not available.

Change-Id: I21afc30dea4df2f68410353c1fe8a0a73d55ff20
Signed-off-by: Hema Gopalakrishnan <hema.gopalkrishnan@ericsson.com>

Remove some BigInteger/String conversions

These are quite expensive, so let’s remove them where possible.
Having a String instead of a BigInteger for the DPN id doesn’t seem
much worse type-wise (it would be better to have a specific type...).

Change-Id: Ib890316aacb3c485867ee9c3b8d825b5e0b7f421
Signed-off-by: Stephen Kitt <skitt@redhat.com>

Support of IPv6ND based aliveness monitor.

+ Supported IPv6ND based aliveness monitor.
+ This functionality will be used by VPN manager to monitor
  learnt/hidden IPv6 addresses.

JIRA: NETVIRT-1213

Change-Id: I53c06b4a00feaa2df257435952cfaab8862ae003
Signed-off-by: nithi thomas <nithi.t@altencalsoftlabs.com>
Signed-off-by: Somashekar Byrappa <somashekar.b@altencalsoftlabs.com>

Add MDSALManager exceptions and missing methods

This patch propagates errors from reading methods in MDSALManager; it
needs I66ad8c2643a03d64ccb4abed94628498636f9152 in NetVirt to avoid
breaking the latter.

It also adds a couple of bucket-related methods which are needed for
fibmanager in NetVirt.

Change-Id: Ic63fd992b33e9e1cd4049bc129545a9830b7a8c0
JIRA: NETVIRT-1318
Signed-off-by: Stephen Kitt <skitt@redhat.com>

vlan member interface creation fails in netvirt 3 node CSIT

When a trunk port, and a trunk-member is created back to back,
there is a race condition in interface-manager that the trunk member
tries to fetch the interface-state information for the trunk,
and it fails, as trunk-interface-state is parallelly getting updated.
With Job Coordinator, this works properly in single node, but when
3 node comes, the synchronization is not at all valid.

The fix uses DataTreeEventCallBackRegistrar to delay the vlan-member
interface configuration till interface-state for vlan-trunk shows up.

JIRA: GENIUS-175

Change-Id: Iccb5d5e08a8a33c7b04d36e4ed348bcef6b17756
Signed-off-by: Faseela K <faseela.k@ericsson.com>

To drop update interface in case of tep add

- prevent retry of update for a tep

Change-Id: I1ed9646f9a864a07f2e61e7dab9e57fc961598f2
Signed-off-by: Edw7n <n.edwin.anthony@ericsson.com>

Cleaning up InterfacestateRemoveWorker

- flowCapableNodeConnector event was always getting passed as NULL
- Removing that parameter altogether

Change-Id: I75782d7e43e081e7b18f65deba8f3100ef1da4b7
Signed-off-by: Edw7n <n.edwin.anthony@ericsson.com>

Fix typo in interfacemanager design document

Change-Id: Iee9038532bca5450c8043212edd5d69042a3f8c8
Signed-off-by: Faseela K <faseela.k@ericsson.com>

Use interruptible functions in managed txes

This requires Iddf13dfd59d50495024b2d5291f6607fa8d48d4f.

Change-Id: Ia5b53d7c44a58d55c5bf8de542b5be09a15d1ad4
Signed-off-by: Stephen Kitt <skitt@redhat.com>

Avoid proxy errors in DTEventCallbackRegistrarTest

I8e54ec344d010a91e06ef2f1fb63586de3b26949 added a proxy for listeners,
breaking the log test in DataTreeEventCallbackRegistrarTest. This
patch makes the test less specific, still looking for the appropriate
error but without depending on the specific class name.

Change-Id: I89ed0b7deb1a795ce60199b16ff16a8da15aaf81
Signed-off-by: Stephen Kitt <skitt@redhat.com>

Remove use of JdkFutureAdapters

RPCs are now exposing ListenableFuture, there is no need to adapt
them.

Change-Id: Iee32036c0a2a1c044dc4c14c19f6d6eb408588af
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

getInterfaceFromIfIndex() should not log ERROR

With itm-direct-tunnels, there are several cases
where ifindex-interface map in interface-manager
will not have the mapping populated. The RPC should
not be logging ERROR in case of the same.

Change-Id: If14a4738f436b1519ac429a1c06d0383f74af1e0
Signed-off-by: Faseela K <faseela.k@ericsson.com>

servicerecovery handler cleanup

Change-Id: I489cc38bc7f7e34eec969aa15c9816884bfe63ab
Signed-off-by: Faseela K <faseela.k@ericsson.com>

Handling external tunnel Deletion

WHen a tep is deleted the internal tunnels are cleaned up but not
external tunnels towards DC gateway. The issue was when internal
tunnels were deleted the teps were also cleaned up and so resulted
in NPE when handling external tunnel deletion. Using the same object
reference was the problem. Fix was to return a copy.

Change-Id: Ic65f596d4eb2a89b7468b7ea6af12f3cac4d415a
Signed-off-by: Nidhi <nidhi.adhvaryu@ericsson.com>

Fix invalid models

These models do not contain correct import stanzas and were resolved
accidentally via prefixes declared in modules thy are importing.

JIRA: YANGTOOLS-889
Change-Id: Ia77d1e5199b51ad805e304dcb21c1edee04dfcd3
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

mdsalutil datastore-constrained migration, ifc 1

This migrates interfacemanager to the new IMdsalApiManager methods.

Change-Id: Ia9a2beb9de5f814bcbab50522584987062f21d4d
Signed-off-by: Stephen Kitt <skitt@redhat.com>

mdsalutil datastore-constrained migration, itm 1

This migrates itm to the new IMdsalApiManager methods.

Change-Id: I3a4c39bd2f53ab8fdbbc3593aaac29af99551bca
JIRA: GENIUS-168
Signed-off-by: Stephen Kitt <skitt@redhat.com>

Omitting group-id from DS:dpn-teps-state

Change-Id: Idbee55d52f7d247ba0fc42ec3e1ad3d8d45bd5bc
Signed-off-by: Edw7n <n.edwin.anthony@ericsson.com>

Updating service recovery spec to point to
existing service recovery test-plans

Change-Id: Iaa0e2108f5f21524286cab78b7e4327ab4a31073
Signed-off-by: eswanit <swati.udhavrao.niture@ericsson.com>

Add IfIndex-Interface Cache

In an incident of heavy packet-in messages(30K events per minute),
each packet-in was making an RPC call to getinterfaceNameForIfIndex(),
which was internally doing a datastore read. In a particular case, all these
READS ended up being remote in a 3 node cluster, which was causing trouble
for the cluster.

Change-Id: I4f7f3adb2ed2c076a954cde25bd7186cb581d63c
Signed-off-by: Faseela K <faseela.k@ericsson.com>

move AlivenessProtocolHandlerRegistryImpl from internal to impl package

because there is already an internal package in the impl-protocols

This fixes this "split package" issue:

[INFO] --- maven-bundle-plugin:3.3.0:bundle (default-bundle) @alivenessmonitor-impl-protocols ---
[WARNING] Bundle org.opendaylight.genius:alivenessmonitor-impl-protocols:bundle:0.5.0-SNAPSHOT:
    Split package, multiple jars provide the same package:org/opendaylight/genius/alivenessmonitor/protocols/internal
    Use Import/Export Package directive -split-package:=(merge-first|merge-last|error|first) to get rid of this

JIRA: GENIUS-170
Change-Id: Ifd4d17769e3c96f344de8c383dec75591358d1ef
Signed-off-by: Michael Vorburger <vorburger@redhat.com>

Remove genius/tools and genius/srm

As these modules are moved to a new repo serviceutils,
let us migrate all the usages to the same.

Change-Id: Ib3f6b77f711d775c4ea615b986ab215dcdc26e88
Signed-off-by: Faseela K <faseela.k@ericsson.com>

Port idmanager to datastore-constrained txs

Change-Id: I1f3a50453cd7519e78b104eb8a8a1c4e8bbaed62
Signed-off-by: Stephen Kitt <skitt@redhat.com>

mdsalutil datastore-constrained migration, part 1

This adds constrained methods to IMdsalApiManager and HwvtepUtils, in
particular to allow their use in NetVirt.

Change-Id: Ifeb6a43dd263583e2158ddf4b0b82f9e9a0597fd
JIRA: GENIUS-168
Signed-off-by: Stephen Kitt <skitt@redhat.com>

Bump yangtools to 2.0.7

This patch brings in the latest yangtools version.

Change-Id: I2ee4591f8203967d127d1ad74559073174fe4634
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Improve declarations of static queues

Change-Id: Ia6db4b34738ca52d66b74b910e56bea2064a6470
Signed-off-by: David Suarez <david.suarez.fuentes@gmail.com>

Bump to odlparent-3.1.2

This place was missed in the bump and was left at 3.1.0, fix that.

Change-Id: I3fec393504a910ae66197f0c26da77b86902cc5d
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>

Add Equinox Common to the Xtend Maven plugin

As pointed out by Robert Varga in
I556c934db07148f05f701d1c541fd1f1bfc34219,
org.eclipse.platform:org.eclipse.equinox.common:3.10.0 appears to be
required by the Xtend Maven plugin now.

Change-Id: I8d4e47bab44672b5d6bda5d458f1472985be9469
Signed-off-by: Stephen Kitt <skitt@redhat.com>

genius: NwConstants change L3_VPNV6_SERVICE_INDEX

Change L3_VPNV6_SERVICE_INDEX value to 9.

Change-Id: I3428d9daab6daf3dc0e685e27104bfc300418217
Signed-off-by: Valentina <valentina.krasnobaeva@6wind.com>

Bump odlparent to 3.1.2

Change-Id: I63a0ecec2f2fa558e4f228a514bc5af2444df291
Signed-off-by: Stephen Kitt <skitt@redhat.com>

make new Datastore type a class instead of an interface

with a private constructor, just to prevent any users
from doing new Datastore() { } by accident or confusion.

also include a simple unit test for its conversion methods.

Change-Id: Ifa0b8d8ba81a9599d4e68cf519a5ccdaa88852d4
Signed-off-by: Michael Vorburger <vorburger@redhat.com>

Drop deprecated odl-infrautils-counters

This is no longer used.

Change-Id: I4d99ec7d6df20133f036d2eae18d2fb759b989bb
Signed-off-by: Stephen Kitt <skitt@redhat.com>

Add datastore-constrained transactions

This introduces new transactions which constrain the datastore being
used, and thus no longer require it to be specified with each
operation.

Since this involves adding new methods to ManagedNewTransactionRunner,
this patch also switches to FluentFuture (for the new methods only).

JIRA: NETVIRT-1321
Change-Id: I4f5f46f3a3eb144827f131d31cf4b8f776b6be57
Signed-off-by: Stephen Kitt <skitt@redhat.com>

To prevent implicit type casting

- can lead to RPC failure in case of tunnelId not being set

Change-Id: I81c70110e97405e7caa8cea536041189983eba23
Signed-off-by: Edw7n <n.edwin.anthony@ericsson.com>

Set Proper EtherType for MPLS Pop Action based on the IP Prefix address family

Problem Description:
======================
When IPv6 L3VPN traffic is coming from DC-GW to OVS switch via MPLSoGRE tunnel
at table L3_LFIB_TABLE(20) is doing removal of MPLS label and it is setting with
ethertype is 0x800(IPv4) always which is wrong for IPv6 traffic.

Solution:
=========
As part of this review, have done the required code modifications to accept both
IPv4(0x800) and IPv6(0x86dd) ethertype for MPLS Pop Action. Also added new utilty for
getting etherType based on the IP Prefix address family (Either IPv4 or
IPv6)

Issue: NETVIRT-1307

Change-Id: Ia84d25d6ba2ba8a2c53e7e9b99d4f65c3381d1a2
Signed-off-by: Karthikeyan Krishnan <karthikeyangceb007@gmail.com>

GENIUS-162: Minor changes to karaf log levels and messages

Change-Id: I5ddb8d83bdc53f79938ef7e80404565a22d193b6
Signed-off-by: Nidhi <nidhi.adhvaryu@ericsson.com>

Add a returning variant of managed transactions

This patch adds a returnFromSubmittedNewReadWriteTransaction() method
to ManagedNewTransactionRunner, to allow building transaction runners
which return a value to the caller (via a Future).

It also adds unit tests for the callWithNewReadWrite... variant, which
didn’t have any.

Change-Id: I74f155fc487853d1eb1f9e9f7d06a760a638331f
Signed-off-by: Stephen Kitt <skitt@redhat.com>

New module - ipv6util

+ This is refactoring of ipv6service module in Netvirt.
+ Moved all the IPv6 generic/common functionality from ipv6service module to
  ipv6util module in Genius.
+ This is required to support ND based Aliveness monitor which will be used in
  subnet routing for hidden IPv6 addresses.
+ ND based Aliveness monitor will be using ipv6util's RPC to send NS packet.
+ This also includes addition of new RPC to send NS packet to an OF group
  which is raised as part of [1].

Note: Removing the corresponding code in ipv6service of Netvirt, will be
handled in a separate patch.

[1] https://git.opendaylight.org/gerrit/#/c/71567/

JIRA: NETVIRT-1213

Change-Id: I9263e27ed0533414de0401a87c9595764b23139f
Signed-off-by: Somashekar Byrappa <somashekar.b@altencalsoftlabs.com>

Use the new Executors's shutdown method to stop listeners

Use the new Executor's shutdown method to stop listener using default
paramenters.

Change-Id: I1db913aa2575b2e0be0245cf4d8a683e01aac619
Signed-off-by: David Suarez <david.suarez.fuentes@gmail.com>

Subnet Route Table Miss Cookie Constant

To support the feature rate limiting for subnet route punt
packets for IPv6 and IPv4 traffic, in this code changes is
defining the new cookie constant value for subnet route table
miss flow from NETVIRT VPN module.

Issue: NETVIRT-1213

Change-Id: I1145f6e1a7d6f4c1a442780fbfb358754a921d98
Signed-off-by: Karthikeyan Krishnan <karthikeyangceb007@gmail.com>

fix broken DataTreeEventCallbackRegistrar onAddOrUpdate()

actually fixes two technically completely unrelated bugs:
firstly the use of onUpdate instead of onAddOrUpdate in
two API default methods; and secondly a hard-coded
Duration.ZERO instead of timeoutDuration impl arg.

Change-Id: I6c2092d1b48fafe1a6b90821f0907cb2e064bac1
Signed-off-by: Michael Vorburger <vorburger@redhat.com>

remove useless diagstatus ServiceDescriptor descriptions

following Change-Id: I22109f46e4505ec4336f5d8fdc1794bbb8d05562

Change-Id: Ie5d2a0e572328e7260fd97ad1a35714222e3c317
Signed-off-by: Michael Vorburger <vorburger@redhat.com>

extend DatastoreServiceStatusProvider with Shard Leader/Follower status

This first requires I563105e8af79c0687cbb99444b34b540e80cbaa5 in
controller to fix CONTROLLER-1835; otherwise it will build, but fail at
runtime.

This also removes the "Data store is fully operational" status
description
in case of a ServiceState.OPERATIONAL; see
I22109f46e4505ec4336f5d8fdc1794bbb8d05562
(and this should not break anything, because until
I65529fc617bb2968ecccefcdd32ff66f7b808952
that was not displayed on the diagstatus CLI anyway).

JIRA: GENIUS-138
Change-Id: Ibbf1ad281880df8da862c9b28b8ca5d360d43bcd
Signed-off-by: Michael Vorburger <vorburger@redhat.com>

Fixing ItmRpcService to return tunnelName
- requires TestModule, as IITMProvider will be injected in elanItmUtils
dependent changes: https://git.opendaylight.org/gerrit/#/c/72867/

Change-Id: I5d4c22682200ed63d3edb88d0769d7622328813b
Signed-off-by: Edw7n <n.edwin.anthony@ericsson.com>

Add new openflowutils to batchedAddFlow()/batchedRemoveFlow()

Change-Id: I271162acf229d20be816c9220728cccbcdbc45f3
Signed-off-by: Faseela K <faseela.k@ericsson.com>

Add New Table for ITM Egress Tunnel Table

JIRA: GENIUS-143

Change-Id: I9371d597508f7f7e317026b147f4cff0c000a8d4
Signed-off-by: Faseela K <faseela.k@ericsson.com>

look up MBean in DatastoreServiceStatusProvider constructor

instead of every time in getServiceDescriptor()

JIRA: GENIUS-138
Change-Id: I8590242f1e9c20a690a544803265be96b9c82369
Signed-off-by: Michael Vorburger <vorburger@redhat.com>

use strong instead "stringly" typing in DatastoreServiceStatusProvider

getSyncStatus() is better than getMBeanAttribute("SyncStatus")

This requires I3020a86b5221d36eace4359031558fb2bd6b979d in infrautils
and Ie0cb62db5ee2dd98fa1a0e55791c9551089e6aac in controller.

JIRA: GENIUS-138
Change-Id: Ic8df4299b46a4dd21310619e295552404266fb80
Signed-off-by: Michael Vorburger <vorburger@redhat.com>