Dana Kutenicsova [Fri, 1 May 2015 07:35:36 +0000 (09:35 +0200)]
Removed deprecated classes.
AdjRibIns are no longer used and needed.
Change-Id: Iaa1a2268aabc2f4404f72fb78349168885f69dfc
Signed-off-by: Dana Kutenicsova <dkutenic@cisco.com>
Robert Varga [Thu, 30 Apr 2015 23:40:20 +0000 (23:40 +0000)]
Merge "BUG-2383 : cleanup RIBImpl"
Dana Kutenicsova [Mon, 20 Apr 2015 07:54:00 +0000 (09:54 +0200)]
BUG-2383 : cleanup RIBImpl
The creation by RIB itself and Loc-RIB was still done in
binding-aware form. This commit changes it to binding
independent and removes all the methods that are not needed
anymore.
Change-Id: I51ec54264747cff584f1ece24884d2732b39f0a2
Signed-off-by: Dana Kutenicsova <dkutenic@cisco.com>
Dana Kutenicsova [Mon, 20 Apr 2015 12:56:24 +0000 (14:56 +0200)]
Implementation for Path Binding Tlv.
As per: https://tools.ietf.org/html/draft-sivabalan-pce-binding-label-sid
Implemented PathBindingTlv, its parser and wired
the TLV to LSP object.
Change-Id: I1803d6adca1132c88ca009417af6738759a5f443
Signed-off-by: Dana Kutenicsova <dkutenic@cisco.com>
Dana Kutenicsova [Tue, 28 Apr 2015 08:10:06 +0000 (10:10 +0200)]
Fixed linkstate NLRI serializer registration.
The registered DataObject is not used in parsing, but
for creating correct MpReachNlri codec. Adding another
capability discovered this bug.
Change-Id: I626bccfee4974a5fe223b7588e77eda663d111b7
Signed-off-by: Dana Kutenicsova <dkutenic@cisco.com>
Dana Kutenicsova [Mon, 27 Apr 2015 09:16:05 +0000 (11:16 +0200)]
Reordered serialization of prefix attributes.
TLV types serialized must be in ascending order.
Change-Id: I02009ff56b857e58f2efbaa1846bf69fa1277a82
Signed-off-by: Dana Kutenicsova <dkutenic@cisco.com>
Dana Kutenicsova [Sat, 25 Apr 2015 17:42:29 +0000 (19:42 +0200)]
Removed some sonar warnings.
Inlcuding order of modifiers, magic numbers, unused
variables etc.
Change-Id: I4b77c48d558bbf02a3e99bb520656f133132d4f4
Signed-off-by: Dana Kutenicsova <dkutenic@cisco.com>
Dana Kutenicsova [Fri, 24 Apr 2015 16:58:58 +0000 (18:58 +0200)]
Revived Peer test.
First test tests onDataTreeChanged method in Application peer, second tests
the advertisement of routes from one peer to another.
Change-Id: Iee684935e67a4a9e62b4634b74858106da1734c8
Signed-off-by: Dana Kutenicsova <dkutenic@cisco.com>
Dana Kutenicsova [Fri, 24 Apr 2015 17:05:33 +0000 (19:05 +0200)]
BUG-2963 : fixed config file
Change-Id: Ia7b19eb3af2afcc1cf01880c628cae455460ae2e
Signed-off-by: Dana Kutenicsova <dkutenic@cisco.com>
Dana Kutenicsova [Fri, 24 Apr 2015 13:31:53 +0000 (15:31 +0200)]
Fixed missing break statements in switch.
Change-Id: Ib1d895aa40976a12dbe7f6f28660ffb62dd9954d
Signed-off-by: Dana Kutenicsova <dkutenic@cisco.com>
Dana Kutenicsova [Mon, 20 Apr 2015 14:34:41 +0000 (16:34 +0200)]
BUG-2571 : created method for serializing FS NLRI to string
We will use this string key as a list key in flowspec-routes.
Change-Id: I5707e9f1ef2b999ad240af4a8e7a4d5c555aca44
Signed-off-by: Dana Kutenicsova <dkutenic@cisco.com>
Ladislav Borak [Mon, 20 Apr 2015 11:46:57 +0000 (13:46 +0200)]
Bug 2963 - Make BGP peer role configurable
- added support for BGP peer role configurable
Change-Id: I756c013538a3c10a509c48ab1b69cefac2c033da
Signed-off-by: Ladislav Borak <lborak@cisco.com>
Robert Varga [Wed, 22 Apr 2015 13:57:24 +0000 (13:57 +0000)]
Merge "Mark with FIXMEs places where manual conversion is made."
Robert Varga [Wed, 22 Apr 2015 13:57:17 +0000 (13:57 +0000)]
Merge "BUG-2571 : implemented (partially) conversion of Flowspec from BI to BA form"
Dana Kutenicsova [Wed, 22 Apr 2015 12:08:17 +0000 (14:08 +0200)]
Mark with FIXMEs places where manual conversion is made.
Rather than making the conversion ourselves, we should rely on
the codec.
Change-Id: I9fe5cfc6251b4dab718f498fce93a0a9ec1f6b00
Signed-off-by: Dana Kutenicsova <dkutenic@cisco.com>
Dana Kutenicsova [Wed, 22 Apr 2015 08:08:19 +0000 (10:08 +0200)]
BUG-2571 : implemented (partially) conversion of Flowspec
from BI to BA form
We need this to advertise Flowspec back to peers. The
advertising is done in BA form.
Change-Id: Ifc5e0e1bffaaf756afdfd44944281e3b9a36250a
Signed-off-by: Dana Kutenicsova <dkutenic@cisco.com>
Robert Varga [Thu, 9 Apr 2015 10:49:04 +0000 (12:49 +0200)]
Migrate to DataTreeChangeListener
This eliminates the inefficient DataChangeListener interface in favor of
DataTreeChangeListener.
Change-Id: I18474d45ca8a08d6a9344e5c23e83a1ebe209816
Signed-off-by: Robert Varga <rovarga@cisco.com>
Robert Varga [Mon, 20 Apr 2015 09:32:47 +0000 (09:32 +0000)]
Merge "BUG-2383 : clean up transaction chains in Peers"
Dana Kutenicsova [Sun, 19 Apr 2015 14:00:00 +0000 (16:00 +0200)]
BUG-2383 : clean up transaction chains in Peers
Change-Id: Iaec5b3b8b1c910c32c08fa63aa9fba4e4374ae0c
Signed-off-by: Dana Kutenicsova <dkutenic@cisco.com>
Dana Kutenicsova [Sun, 19 Apr 2015 13:40:48 +0000 (15:40 +0200)]
BUG-2383 : filled in MP(Un)reachNlri RIB support builders
Change-Id: I4c7fb8b1af56cfda7f28775b04fa93a1cc4f5c7b
Signed-off-by: Dana Kutenicsova <dkutenic@cisco.com>
Dana Kutenicsova [Fri, 27 Mar 2015 10:13:08 +0000 (11:13 +0100)]
BUG-2383 : wire AdjRibOutListener to BGPPeer
With RIBSupport in place, we can start emitting routes to our peers.
Change-Id: Idcec38e59a2c4b60c291400b6baff6b67f38e0f3
Signed-off-by: Dana Kutenicsova <dkutenic@cisco.com>
Signed-off-by: Robert Varga <rovarga@cisco.com>
Dana Kutenicsova [Fri, 17 Apr 2015 11:52:23 +0000 (13:52 +0200)]
BUG-3013 : added method for creating Update message from DOM
On egress we are have routes in NormalizedNode format and we need to
create DataObjects to pass to serializer. Introduce a RIBSupport method
to provide the required support.
Change-Id: Ibbc6f9d8e3c7c90429dcd4f7bb6a80a0118c7fe2
Signed-off-by: Dana Kutenicsova <dkutenic@cisco.com>
Signed-off-by: Robert Varga <rovarga@cisco.com>
Dana Kutenicsova [Fri, 17 Apr 2015 13:08:37 +0000 (15:08 +0200)]
BUG-2571 : initial cut on Flowspec RIB Support
Change-Id: I83697949e1b203f09a12584ead80bd5ed1b7638c
Signed-off-by: Dana Kutenicsova <dkutenic@cisco.com>
Dana Kutenicsova [Fri, 17 Apr 2015 12:51:38 +0000 (14:51 +0200)]
BUG-2571 : fixed flowspec model
Change-Id: Id38fcd8543a0a248a5cc0bb4058f6f7fa1f37784
Signed-off-by: Dana Kutenicsova <dkutenic@cisco.com>
Dana Kutenicsova [Tue, 14 Apr 2015 10:37:55 +0000 (12:37 +0200)]
BUG-2383 : Application peer rework.
Change-Id: I152c7d265d81c58018976dcbbef46fca735e6dd8
Signed-off-by: Dana Kutenicsova <dkutenic@cisco.com>
Dana Kutenicsova [Wed, 15 Apr 2015 12:28:07 +0000 (14:28 +0200)]
BUG-2982 : fixed forgotten PathAttribute container creation
- leftover javadoc bugs
Change-Id: Ia2bc4742f5801b0dd2aec6db44454f04e1a1e4d1
Signed-off-by: Dana Kutenicsova <dkutenic@cisco.com>
Robert Varga [Tue, 14 Apr 2015 19:39:12 +0000 (19:39 +0000)]
Merge "BUG-2982 : moved path-attributes container to grouping"
Robert Varga [Tue, 14 Apr 2015 14:39:45 +0000 (16:39 +0200)]
Fix NPE on route delete
Local testing has uncovered this:
2015-04-14 16:34:51,211 | INFO | upCloseable-3-11 | BGPSessionImpl | 209 - org.opendaylight.bgpcep.bgp-rib-impl - 0.4.0.SNAPSHOT | Closing session: BGPSessionImpl{channel=[id: 0x0ff0457c, /127.0.0.2:36180 :> /127.0.0.1:179], state=IDLE}
2015-04-14 16:36:03,441 | ERROR | lt-dispatcher-16 | DataTreeChangeListenerActor | 202 - org.opendaylight.controller.sal-distributed-datastore - 1.2.0.SNAPSHOT | Error notifying listener org.opendaylight.protocol.bgp.rib.impl.LocRibWriter@
5917453f
java.lang.NullPointerException
at org.opendaylight.protocol.bgp.rib.impl.LocRibWriter.onDataTreeChanged(LocRibWriter.java:183)[209:org.opendaylight.bgpcep.bgp-rib-impl:0.4.0.SNAPSHOT]
at org.opendaylight.controller.cluster.datastore.DataTreeChangeListenerActor.dataChanged(DataTreeChangeListenerActor.java:53)[202:org.opendaylight.controller.sal-distributed-datastore:1.2.0.SNAPSHOT]
Which turns out to be a failure to check for deleted entry.
Change-Id: Ib4e0be69bbafdaf3e29698395a85224fdfa6c347
Signed-off-by: Robert Varga <rovarga@cisco.com>
Robert Varga [Tue, 14 Apr 2015 14:36:15 +0000 (14:36 +0000)]
Merge "Fixed javadocs for java8."
Dana Kutenicsova [Mon, 13 Apr 2015 13:27:35 +0000 (15:27 +0200)]
BUG-2982 : moved path-attributes container to grouping
- this eliminates the Attributes class and unifies the
view of the attributes for routes and messages
Change-Id: Id1fa5ac8fa4f48acc7c19fd0e497880e148617d1
Signed-off-by: Dana Kutenicsova <dkutenic@cisco.com>
Dana Kutenicsova [Tue, 14 Apr 2015 14:13:51 +0000 (16:13 +0200)]
Fixed javadocs for java8.
Change-Id: Id9e47d4d8af0113b2f03de91df9521c8d5b1bb34
Signed-off-by: Dana Kutenicsova <dkutenic@cisco.com>
Dana Kutenicsova [Tue, 14 Apr 2015 11:29:30 +0000 (13:29 +0200)]
BUG-2383 : make LocalRIB count on complexity of the routes
- by creating complex route we can ensure that no data
goes missing in LocalRIB
Change-Id: Ide263d4c277b8a2ab598f1a3ae2306b9ee031590
Signed-off-by: Robert Varga <rovarga@cisco.com>
Signed-off-by: Dana Kutenicsova <dkutenic@cisco.com>
Dana Kutenicsova [Tue, 14 Apr 2015 11:24:16 +0000 (13:24 +0200)]
BUG-2994 : added new method to RIBSupport to expose complexity of its route
Change-Id: Id781e5499b87e969b5d354eb804f3693cd17dcaa
Signed-off-by: Dana Kutenicsova <dkutenic@cisco.com>
Robert Varga [Tue, 14 Apr 2015 10:37:26 +0000 (10:37 +0000)]
Merge "Fixed parser-to-sal test."
Dana Kutenicsova [Tue, 14 Apr 2015 08:29:28 +0000 (10:29 +0200)]
Fixed parser-to-sal test.
- getModuleInfos() override
- use different context for Ipv4/Linkstate
Change-Id: I04564c695ecf568f59a2f84009b6f946c69bca9b
Signed-off-by: Dana Kutenicsova <dkutenic@cisco.com>
Dana Kutenicsova [Sun, 12 Apr 2015 12:48:52 +0000 (14:48 +0200)]
BUG-2978 : Linkstate path attribute extracted to grouping
Change-Id: I75f40ce8acabf8c41002f5f32d96de6fee2257be
Signed-off-by: Dana Kutenicsova <dkutenic@cisco.com>
Dana Kutenicsova [Sat, 11 Apr 2015 16:26:52 +0000 (18:26 +0200)]
BUG-2383 : finish up LinkstateRIBSupport
Change-Id: I6a787866e99238412fd83b6267f7c915dbbb5680
Signed-off-by: Dana Kutenicsova <dkutenic@cisco.com>
Dana Kutenicsova [Fri, 10 Apr 2015 19:49:26 +0000 (21:49 +0200)]
BUG-2383 : DOM Linkstate NLRI serializer
- we need to serialize the NLRi to obtain route-key
Change-Id: Ibe228b72b6fde8e8156074449709d2bceeaf6f40
Signed-off-by: Dana Kutenicsova <dkutenic@cisco.com>
Dana Kutenicsova [Wed, 11 Mar 2015 14:06:09 +0000 (15:06 +0100)]
BUG-2383 : introduce LinkstateRIBSupport
Change-Id: I4a540076512f99dd704784cf5447b3aa86cc7adb
Signed-off-by: Dana Kutenicsova <dkutenic@cisco.com>
Dana Kutenicsova [Thu, 9 Apr 2015 12:23:18 +0000 (14:23 +0200)]
BUG-2383 : fix creating AdjRibsOut tables in datastore
Change-Id: Idd8028be92a5d2fafa6a2bf314852c8d16924a44
Signed-off-by: Dana Kutenicsova <dkutenic@cisco.com>
Dana Kutenicsova [Fri, 10 Apr 2015 15:08:27 +0000 (17:08 +0200)]
BUG-2975 : implemented missing augmentations
Change-Id: Ieaf2ce516b9039ca8fcff1f1319cbf19c62f993e
Signed-off-by: Dana Kutenicsova <dkutenic@cisco.com>
Dana Kutenicsova [Thu, 9 Apr 2015 13:57:34 +0000 (13:57 +0000)]
Merge "Bug 2959 - wrong result for selecting high local perf"
Dana Kutenicsova [Thu, 9 Apr 2015 09:25:02 +0000 (11:25 +0200)]
BUG-2383 : do not ignore ipv6 rib support
Change-Id: I2c8451cb5805d4f45a5f4ab742b032a3eef838ae
Signed-off-by: Dana Kutenicsova <dkutenic@cisco.com>
Ladislav Borak [Wed, 8 Apr 2015 12:33:28 +0000 (14:33 +0200)]
Bug 2959 - wrong result for selecting high local perf
- corrected condition by selecting best path with higher local pref
Change-Id: Ic3fd84002fb068bf6848bc7f98c0aed681c5cd30
Signed-off-by: Ladislav Borak <lborak@cisco.com>
Dana Kutenicsova [Wed, 8 Apr 2015 19:21:25 +0000 (21:21 +0200)]
BUG-2383 : revive AdjRibsOut in datastore
- fixed small bugs along the path
- added logging
Change-Id: I2e1451c1d93e3a6363833d3eafcf69c114ccfa73
Signed-off-by: Dana Kutenicsova <dkutenic@cisco.com>
Dana Kutenicsova [Wed, 8 Apr 2015 19:36:31 +0000 (19:36 +0000)]
Merge "BUG-2383: optimize locRibTarget"
Thanh Ha [Sat, 14 Mar 2015 23:35:59 +0000 (19:35 -0400)]
Fix pep8 violations in message/_message.py
Change-Id: I030e7a3e9971e135ee4762a09f5eb7c8e6f1b189
Signed-off-by: Thanh Ha <thanh.ha@linuxfoundation.org>
Thanh Ha [Sat, 14 Mar 2015 23:33:20 +0000 (19:33 -0400)]
Fix pep8 violations in message/rsvp.py
Change-Id: Icb5d5b299136e5856b95702f5977995fcf58c07e
Signed-off-by: Thanh Ha <thanh.ha@linuxfoundation.org>
Thanh Ha [Sat, 14 Mar 2015 23:29:07 +0000 (19:29 -0400)]
Fix pep8 violations in message/code.py
Change-Id: I68a4b531e44c2f8ba9f1a8a1058254207884b059
Signed-off-by: Thanh Ha <thanh.ha@linuxfoundation.org>
Thanh Ha [Sat, 14 Mar 2015 23:11:59 +0000 (19:11 -0400)]
Fix pep8 violations in message/tlv.py
Change-Id: Ib1e60db32a2aaa2e9da05fa2be4605bf16cc6033
Signed-off-by: Thanh Ha <thanh.ha@linuxfoundation.org>
Thanh Ha [Sat, 14 Mar 2015 23:07:18 +0000 (19:07 -0400)]
Fix pep8 violations in message/object.py
Change-Id: I1e5644421c6b90f593405b23058af2d28a36d9af
Signed-off-by: Thanh Ha <thanh.ha@linuxfoundation.org>
Thanh Ha [Sat, 14 Mar 2015 23:02:14 +0000 (19:02 -0400)]
Fix pep8 violations in message/data.py
Change-Id: Iad8f58570356074a0f170dae3c3414b1fceaef5f
Signed-off-by: Thanh Ha <thanh.ha@linuxfoundation.org>
Thanh Ha [Sat, 14 Mar 2015 22:52:46 +0000 (18:52 -0400)]
Fix pep8 violations in message/base.py
Adds missing spacing between classes and functions.
Change-Id: I697f34eea072862754b77befda0fb51be6c655fa
Signed-off-by: Thanh Ha <thanh.ha@linuxfoundation.org>
Thanh Ha [Sat, 14 Mar 2015 22:41:58 +0000 (18:41 -0400)]
Ignore pep8 violations in message/__init__.py
Change-Id: Ieb696453db1f7618393303772bbee23ffb6f46d0
Signed-off-by: Thanh Ha <thanh.ha@linuxfoundation.org>
Thanh Ha [Sat, 14 Mar 2015 22:40:12 +0000 (18:40 -0400)]
Fix pep8 violations in peer/pcc.py
Change-Id: I2b84a8ad5f17d647d299f872d8fefa67bec610bf
Signed-off-by: Thanh Ha <thanh.ha@linuxfoundation.org>
Thanh Ha [Sat, 14 Mar 2015 22:36:04 +0000 (18:36 -0400)]
Fix pep8 violations in peer/pce.py
Change-Id: I79470c5ac5bacd022f82d7b444a9d563beb6cb45
Signed-off-by: Thanh Ha <thanh.ha@linuxfoundation.org>
Thanh Ha [Sat, 14 Mar 2015 22:31:01 +0000 (18:31 -0400)]
Fix pep8 violations in peer/base.py
Change-Id: I34842eef64bd33dcf84aa97ddfe79e86474abc86
Signed-off-by: Thanh Ha <thanh.ha@linuxfoundation.org>
Thanh Ha [Wed, 11 Mar 2015 01:31:05 +0000 (21:31 -0400)]
Fix pep8 violations in peer/lsp.py
Change-Id: I671575613b7836b660f61a30978ad5868ea8884d
Signed-off-by: Thanh Ha <thanh.ha@linuxfoundation.org>
Dana Kutenicsova [Wed, 8 Apr 2015 10:59:04 +0000 (10:59 +0000)]
Merge "Fix pep8 violations in peer/context.py"
Robert Varga [Wed, 8 Apr 2015 10:56:49 +0000 (12:56 +0200)]
BUG-2383: optimize locRibTarget
Since we will be using this instance identifier extensively, make sure
it is compacted, speeding up operations on it. Also remove unneeded
method.
Change-Id: I2b92c1bed21b4c7b0a78eb1c7e2c363b429642ab
Signed-off-by: Robert Varga <rovarga@cisco.com>
Robert Varga [Wed, 8 Apr 2015 10:50:23 +0000 (10:50 +0000)]
Merge "BUG-2383 : put empty routes structure to Loc-RIB"
Dana Kutenicsova [Wed, 8 Apr 2015 09:06:06 +0000 (11:06 +0200)]
BUG-2383 : put empty routes structure to Loc-RIB
Change-Id: Ida7afd1f404e406000b431d8b9df91d39e353bf8
Signed-off-by: Dana Kutenicsova <dkutenic@cisco.com>
Thanh Ha [Wed, 11 Mar 2015 01:27:40 +0000 (21:27 -0400)]
Fix pep8 violations in peer/context.py
Change-Id: I633895414cb9d7077a2fc42ca7110b200818f574
Signed-off-by: Thanh Ha <thanh.ha@linuxfoundation.org>
Thanh Ha [Wed, 11 Mar 2015 01:25:33 +0000 (21:25 -0400)]
Fix pep8 violations in peer/__init__.py
Change-Id: Ia6fa39e4de13a7a4950209bf618600ce15fd01b2
Signed-off-by: Thanh Ha <thanh.ha@linuxfoundation.org>
Thanh Ha [Tue, 10 Mar 2015 03:04:11 +0000 (23:04 -0400)]
Fix pep8 violations in sessions (2/2)
Change-Id: I3a57d8fe63aa414d501d676177d8719616de4a96
Signed-off-by: Thanh Ha <thanh.ha@linuxfoundation.org>
Thanh Ha [Tue, 10 Mar 2015 03:03:53 +0000 (23:03 -0400)]
Fix pep8 violations in sessions (1/2)
Change-Id: I997ab441ac109f72419bcc4d34deef29fb3c5909
Signed-off-by: Thanh Ha <thanh.ha@linuxfoundation.org>
Thanh Ha [Tue, 10 Mar 2015 02:37:47 +0000 (22:37 -0400)]
Add tox.ini to run flake8
Change-Id: Ie942e2418b9ec9858278227882f5ffa8f14944be
Signed-off-by: Thanh Ha <thanh.ha@linuxfoundation.org>
Signed-off-by: Dana Kutenicsova <dkutenic@cisco.com>
Robert Varga [Tue, 7 Apr 2015 15:25:13 +0000 (15:25 +0000)]
Merge "BUG-2383 : fixed various small bugs in end-to-end RIB integration"
Dana Kutenicsova [Thu, 2 Apr 2015 21:58:09 +0000 (23:58 +0200)]
BUG-2383 : fixed various small bugs in end-to-end RIB integration
- added more logging for debugging
Change-Id: I17aec4926568ad77bef6f0246bacaeed8b0c8257
Signed-off-by: Dana Kutenicsova <dkutenic@cisco.com>
Dana Kutenicsova [Tue, 7 Apr 2015 14:11:14 +0000 (14:11 +0000)]
Merge "Bug 2938: register serializers for all augmentations"
Milos Fabian [Mon, 6 Apr 2015 17:12:12 +0000 (19:12 +0200)]
Bug-2208: connect and re-establish connection strategy for pcc-mock
-new argument --reconnect <number>
-the number specifies how many seconds waits for new reconnect attempt
-if the argument is ommited, pcc will never try to reconnect
Change-Id: Icdb965c3cf7f504ab51e012dcd1272283f849327
Signed-off-by: Milos Fabian <milfabia@cisco.com>
Milos Fabian [Tue, 24 Mar 2015 09:48:54 +0000 (10:48 +0100)]
Bug-2208: Include symbolic path name in PCRpt
-include SYMBOLIC-PATH-NAME TLV in a PCRpt's LSP object as a response to PCUpd message.
Change-Id: If804c7bb2832f0750ffedf2dc22081177e0d8e97
Signed-off-by: Milos Fabian <milfabia@cisco.com>
Dana Kutenicsova [Fri, 3 Apr 2015 14:34:00 +0000 (16:34 +0200)]
Move parser to SAL test to rib-impl.
- it has actually nothing to do with topology
Change-Id: I690275b698d1c1d530603e8a65e43f6ee6386385
Signed-off-by: Dana Kutenicsova <dkutenic@cisco.com>
Robert Varga [Sat, 4 Apr 2015 00:14:02 +0000 (00:14 +0000)]
Merge "BUG-2383 : LocRib smal fixes + logs"
Milos Fabian [Fri, 3 Apr 2015 14:32:48 +0000 (16:32 +0200)]
Bug 2938: register serializers for all augmentations
-register all augmentations serializers of ERO and RRO subtypes for segment routing
Change-Id: I27fd4ddaf0c7dc083806559575026054c1d2071b
Signed-off-by: Milos Fabian <milfabia@cisco.com>
Dana Kutenicsova [Thu, 2 Apr 2015 08:40:52 +0000 (10:40 +0200)]
Trace hexa bytes of encoded messages for debug purposes.
Change-Id: Iee361791c9eb3b9130809b881c5748c0be61383e
Signed-off-by: Dana Kutenicsova <dkutenic@cisco.com>
Dana Kutenicsova [Wed, 1 Apr 2015 15:37:56 +0000 (17:37 +0200)]
BUG-2383 : LocRib smal fixes + logs
Change-Id: I911c9e0cf1eda3af4e45b73f7a4dd84e38ce3b14
Signed-off-by: Dana Kutenicsova <dkutenic@cisco.com>
Robert Varga [Thu, 2 Apr 2015 18:15:39 +0000 (18:15 +0000)]
Merge "Revert "Fixed omission of new path setup type for segment routing""
Robert Varga [Thu, 2 Apr 2015 15:21:15 +0000 (17:21 +0200)]
BUG-2383: Fix array instantiation
Arrays cannot be trivially cast, so use a reflective method to
instantiate new arrays.
Change-Id: I821ae52c49f94414813ebc6f753194db716cd15a
Signed-off-by: Robert Varga <rovarga@cisco.com>
Dana Kutenicsova [Thu, 2 Apr 2015 14:07:50 +0000 (14:07 +0000)]
Revert "Fixed omission of new path setup type for segment routing"
This reverts commit
021dc91874f0e3753dcb934d0ebf3183134bb3e8.
Change-Id: I8d6647d7eda36388018252db2f977974d733d7fc
Signed-off-by: Dana Kutenicsova <dkutenic@cisco.com>
Dana Kutenicsova [Wed, 1 Apr 2015 16:00:22 +0000 (18:00 +0200)]
Fixed omission of new path setup type for segment routing
Change-Id: I7f7a41e004f391c0a91e8f4b55ccbfab3e811776
Signed-off-by: Dana Kutenicsova <dkutenic@cisco.com>
Robert Varga [Wed, 1 Apr 2015 15:17:06 +0000 (17:17 +0200)]
BUG-2383: make sure we update routerId correctly
The routerId needs to be propagated to the writer, so we adjust it
properly. Also make sure we instantiate it in proper form.
Change-Id: I6462df0433381bb9fe0154dc6f370c7cdeb3ea8f
Signed-off-by: Robert Varga <rovarga@cisco.com>
Robert Varga [Wed, 1 Apr 2015 21:30:14 +0000 (23:30 +0200)]
Add missing bundle
Change-Id: I42bc006bdc48b4079b33fd4339da741dda984a0e
Signed-off-by: Robert Varga <rovarga@cisco.com>
Robert Varga [Wed, 1 Apr 2015 15:03:10 +0000 (15:03 +0000)]
Merge "BUG-2383 : proper wildcard and Tables for EffectiveRIB"
Dana Kutenicsova [Tue, 31 Mar 2015 15:28:35 +0000 (17:28 +0200)]
BUG-2383 : proper wildcard and Tables for EffectiveRIB
+ some logging
Change-Id: I056b47cc97be8470547ed1d885c6389ae3a29bdb
Signed-off-by: Dana Kutenicsova <dkutenic@cisco.com>
Robert Varga [Tue, 31 Mar 2015 21:37:09 +0000 (23:37 +0200)]
BUG-2383: mark classes/methods as deprecated
The RIB rework should result in major simplification of the interfaces
exposed and general mechanics. Mark classes which are slated for
removal.
Change-Id: Ie8ed18035089261695495ba29c1638776ebc9391
Signed-off-by: Robert Varga <rovarga@cisco.com>
Tony Tkacik [Tue, 31 Mar 2015 11:01:22 +0000 (13:01 +0200)]
Bug 2383: Added RibSupport lookup using DOM Path Argument.
Change-Id: I26915e9187c1aa0e1c69668f0fd2e9722fcc6eec
Signed-off-by: Tony Tkacik <ttkacik@cisco.com>
Robert Varga [Tue, 31 Mar 2015 14:49:29 +0000 (14:49 +0000)]
Merge "Simplified ASNumber subobject parsing."
Robert Varga [Tue, 31 Mar 2015 14:47:38 +0000 (14:47 +0000)]
Merge "Simplified ErrorMessage subclassing by extracting cases"
Robert Varga [Tue, 31 Mar 2015 14:47:01 +0000 (14:47 +0000)]
Merge "Simplified inheritance within stateful module."
Robert Varga [Tue, 31 Mar 2015 14:36:47 +0000 (14:36 +0000)]
Merge "Simplified some pcep classes to avoid sonar warnings."
Dana Kutenicsova [Sun, 29 Mar 2015 18:36:46 +0000 (20:36 +0200)]
Simplified ASNumber subobject parsing.
Change-Id: I6625d0c5cc4ed3e1f2a74b4a42031930dbd6f75e
Signed-off-by: Dana Kutenicsova <dkutenic@cisco.com>
Dana Kutenicsova [Tue, 31 Mar 2015 11:40:07 +0000 (13:40 +0200)]
Simplified ErrorMessage subclassing by extracting cases
Change-Id: I342c8d9785e4fa8fcc825acd1a6183ef962478f2
Signed-off-by: Dana Kutenicsova <dkutenic@cisco.com>
Dana Kutenicsova [Tue, 31 Mar 2015 12:53:01 +0000 (14:53 +0200)]
Simplified inheritance within stateful module.
- extracted parsing and serializing of flags into separate methods, so they can be overridden
Change-Id: I0c602fa91d89a2c84e2a5b4be3e8e865c80a410e
Signed-off-by: Dana Kutenicsova <dkutenic@cisco.com>
Dana Kutenicsova [Sat, 28 Mar 2015 18:52:48 +0000 (19:52 +0100)]
Simplified some pcep classes to avoid sonar warnings.
Change-Id: I4a8f1a87349d42aa831cc6d982970972e1295f8e
Signed-off-by: Dana Kutenicsova <dkutenic@cisco.com>
Dana Kutenicsova [Tue, 31 Mar 2015 11:07:40 +0000 (13:07 +0200)]
BUG-2383 : wired cluster id with effective RIB
- added some logging along happy path
Change-Id: I4918aa9e107d143b2a09138294c5109aad827f98
Signed-off-by: Dana Kutenicsova <dkutenic@cisco.com>
Robert Varga [Tue, 31 Mar 2015 07:57:40 +0000 (07:57 +0000)]
Merge "BUG-2794 : implemented comments for this class."
Dana Kutenicsova [Tue, 31 Mar 2015 07:35:40 +0000 (07:35 +0000)]
Merge "Revert "Add odlparent relativepath relative to autorelease""
Robert Varga [Mon, 30 Mar 2015 18:32:26 +0000 (18:32 +0000)]
Merge "Revert "Add odlparent relativepath relative to autorelease""
Robert Varga [Fri, 13 Mar 2015 09:10:06 +0000 (10:10 +0100)]
Revert "Add odlparent relativepath relative to autorelease"
This reverts commit
f5ebb0f1b031002110bc6da992e7a0572d8663f9.
That commit makes assumptions about the layout outside of this
repostory, making builds unpredictable.
Change-Id: I5e2ca21f12480bf97107b348b88007b015b330b1
Signed-off-by: Robert Varga <rovarga@cisco.com>
Code Review / bgpcep.git / log