bgpcep.git
7 years agoRemove deprecated class AbstractDataBrokerTest 31/52731/9
Claudio D. Gasparini [Fri, 3 Mar 2017 07:56:14 +0000 (08:56 +0100)]
Remove deprecated class AbstractDataBrokerTest

Remove deprecated class AbstractDataBrokerTest under
programming and data-change-counter tests
Perform some code clean up

Change-Id: I2ff02760338d8774c3908d107ff76de433acba2a
Signed-off-by: Claudio D. Gasparini <claudio.gasparini@pantheon.tech>
7 years agoBUG-7946: Fix SomeModifiersUnresolvedException 86/53086/2
Claudio D. Gasparini [Thu, 9 Mar 2017 15:01:04 +0000 (16:01 +0100)]
BUG-7946: Fix  SomeModifiersUnresolvedException

SomeModifiersUnresolvedException under ConfigLoaderImplTest
Fix by remove duplicated schema.

Change-Id: I1200e21e76e6da0d35a10932eede27df4a410aa0
Signed-off-by: Claudio D. Gasparini <claudio.gasparini@pantheon.tech>
7 years agoBUG-7894: Fix ConcurrentModificationException under test 50/52750/3
Claudio D. Gasparini [Fri, 3 Mar 2017 10:51:16 +0000 (11:51 +0100)]
BUG-7894: Fix ConcurrentModificationException under test

-Fix ConcurrentModificationException under
testSessionTriggeredFullDBReSync test
-Perform some code clean up

Change-Id: I8e4652f273ea994efa5b9477f8af59239e92dd08
Signed-off-by: Claudio D. Gasparini <claudio.gasparini@pantheon.tech>
7 years agoRemove pcep-service.yang.disabled 18/52518/2
Claudio D. Gasparini [Tue, 28 Feb 2017 16:47:38 +0000 (17:47 +0100)]
Remove pcep-service.yang.disabled

Remove pcep-service.yang.disabled

Change-Id: Ib862326a5cd976c6cc9fb714892c8064915a3cfb
Signed-off-by: Claudio D. Gasparini <claudio.gasparini@pantheon.tech>
7 years agoRemove deprecated class AbstractDataBrokerTest under BGP 23/52923/6
Claudio D. Gasparini [Tue, 7 Mar 2017 07:02:55 +0000 (08:02 +0100)]
Remove deprecated class AbstractDataBrokerTest under BGP

Remove deprecated class AbstractDataBrokerTest on tests.
Perform some code clean up under tests.

Change-Id: I64b120bdbbf59db4df0e4d4e2d769eac22738c33
Signed-off-by: Claudio D. Gasparini <claudio.gasparini@pantheon.tech>
7 years agoBUG-7937: Fix BGPTerminationReason 21/53021/3
Claudio D. Gasparini [Wed, 8 Mar 2017 16:26:25 +0000 (17:26 +0100)]
BUG-7937: Fix BGPTerminationReason

When closing the session because of some error
2 Notify messages are sent. One containing the
reason and other with CEASE.
Fix by dont send CEASE Termination Notification
if already other termination notification has
been sent.

Change-Id: Ibfabd7cfb038bef7a452a7458cd5cc1e6fa4b9a7
Signed-off-by: Claudio D. Gasparini <claudio.gasparini@pantheon.tech>
7 years agoBUG-7003: Remove sleeping from Tests 59/52359/11
Claudio D. Gasparini [Tue, 28 Feb 2017 12:20:49 +0000 (13:20 +0100)]
BUG-7003: Remove sleeping from Tests

Remove sleeping from test whenever possible.
Clean up some tests.

Change-Id: I734ca5721090669c75f09d107ee4c5ea1e3d14ee
Signed-off-by: Claudio D. Gasparini <claudio.gasparini@pantheon.tech>
7 years agoBUG-7505: Conflict Modification 66/52866/7
Claudio D. Gasparini [Fri, 3 Mar 2017 14:53:35 +0000 (15:53 +0100)]
BUG-7505: Conflict Modification

When closing Peer and Rib, can cause
race condition between the removal
of the peer and the rib when updating DS.
Fix by close peers on blocking mode, and once
they are closed proceed with rib.
Same its applied in case that peer/rib is updated.
First we close it and then once DS is updated
we proceed with creating the new instance.

Change-Id: Ibe70e0324ae12bcbb88b2e7f039671141447ddb1
Signed-off-by: Claudio D. Gasparini <claudio.gasparini@pantheon.tech>
7 years agoRemove deprecated class AbstractDataBrokerTest under PCEP 90/52990/3
Claudio D. Gasparini [Tue, 7 Mar 2017 08:19:38 +0000 (09:19 +0100)]
Remove deprecated class AbstractDataBrokerTest under PCEP

-Remove deprecated class AbstractDataBrokerTest on tests.
-Perform some code clean up under tests.

Change-Id: Iee8bdb1e190c80aa0ae883e52963afb6b29cc4f0
Signed-off-by: Claudio D. Gasparini <claudio.gasparini@pantheon.tech>
7 years agoProgramming Clean up 16/52616/4
Claudio D. Gasparini [Thu, 2 Mar 2017 07:35:07 +0000 (08:35 +0100)]
Programming Clean up

Migrate deprecated classes
Code clean up

Change-Id: I06551491a30499d81d4c0dc7f0e1dbe68dc04eab
Signed-off-by: Claudio D. Gasparini <claudio.gasparini@pantheon.tech>
7 years agoBUG-6975: Integrate Programming with Cluster Singleton Service 16/52516/6
Claudio D. Gasparini [Wed, 1 Mar 2017 16:25:53 +0000 (17:25 +0100)]
BUG-6975:  Integrate Programming with Cluster Singleton Service

Integrate Programming with Cluster Singleton Service

Change-Id: I95e3c8c1dc1e596c060256d3f59fec9cfe882456
Signed-off-by: Claudio D. Gasparini <claudio.gasparini@pantheon.tech>
7 years agoBUG-6973: Implement Programming config via DS 15/52515/6
Claudio D. Gasparini [Wed, 1 Mar 2017 12:01:20 +0000 (13:01 +0100)]
BUG-6973: Implement Programming config via DS

-Expose programming's configuration in config DS
-Allow multiple programming configuration

Change-Id: Ib6de3355dae6533367890ef87c504edbdca04654
Signed-off-by: Claudio D. Gasparini <claudio.gasparini@pantheon.tech>
7 years agoBUG-6973: Wire Programming with BP 14/52514/6
Claudio D. Gasparini [Wed, 1 Mar 2017 11:24:05 +0000 (12:24 +0100)]
BUG-6973: Wire Programming with BP

-Wire Programming with BP
-Preserve backwards compatibility

Change-Id: I750fdb86a6c22d3b1a90e7466466ab7c5426d729
Signed-off-by: Claudio D. Gasparini <claudio.gasparini@pantheon.tech>
7 years agoBug 6859 - Binding generator v1 refactoring 61/52561/5
Jakub Toth [Wed, 1 Mar 2017 21:40:11 +0000 (22:40 +0100)]
Bug 6859 - Binding generator v1 refactoring

Based on transfer of Binding generator v1 from
Yangtools project to MDSAL in past, we need to finalize
this process by refactoring package naming:
org.opendaylight.yangtools -> org.mdsal.binding
org.opendaylight.yangtools.sal -> org.mdsal.binding

Refactoring changes in MDSAL, see:
https://git.opendaylight.org/gerrit/#/c/52107

By using of Binding generator v1, this change needs to be addressed in
Bgpcep project.

- refactoring itself

Change-Id: Iccb2af9806db18a3e5bf98092ca70ae9b350dabf
Signed-off-by: Jakub Toth <jatoth@cisco.com>
7 years agoImprove Singleton Service Logs 55/52155/2
Claudio D. Gasparini [Wed, 22 Feb 2017 09:08:05 +0000 (10:08 +0100)]
Improve Singleton Service Logs

Improve Singleton Service Logs

Change-Id: Ie09d2e00e7159539dcecc520ef0e9cd39ca4e02f
Signed-off-by: Claudio D. Gasparini <claudio.gasparini@pantheon.tech>
7 years agoBug-7614: LocRibWriter does not recover well from transaction chain failure 54/52354/2
Ajay [Tue, 14 Feb 2017 06:59:09 +0000 (06:59 +0000)]
Bug-7614: LocRibWriter does not recover well from transaction chain failure

If transaction chain associated with LocRibWriter fails, create a
new transaction chain and re-initialize it with the new chain.

Change-Id: Ibbb60c41594ad6b3602cabac18f5e4bccaa093bb
Signed-off-by: Ajay <ajayl.bro@gmail.com>
Signed-off-by: Claudio D. Gasparini <claudio.gasparini@pantheon.tech>
7 years agoBUG-7768 Fix missing registration 28/52328/2
Kevin Wang [Mon, 27 Feb 2017 22:00:30 +0000 (14:00 -0800)]
BUG-7768 Fix missing registration

In previous BUG-7768 fix, pcep topology registration was
missing. This patch adds it back. It also adds several debug
logging and unit test.

Change-Id: I4c82a7fcd9cb1ed7371817ffabc52fdf927ab51e
Signed-off-by: Kevin Wang <kevixw@gmail.com>
Signed-off-by: Claudio D. Gasparini <claudio.gasparini@pantheon.tech>
7 years agoAdd CheckUtil coverage 30/52130/5
Claudio D. Gasparini [Mon, 20 Feb 2017 17:33:41 +0000 (18:33 +0100)]
Add CheckUtil coverage

Add CheckUtil coverage

Change-Id: I90524766fa989c97ab2e10d7fbe08904e269770c
Signed-off-by: Claudio D. Gasparini <claudio.gasparini@pantheon.tech>
7 years agoBUG-7222: Make BGP DS clean up asynchronous 93/51893/3
Claudio D. Gasparini [Wed, 15 Feb 2017 08:58:38 +0000 (09:58 +0100)]
BUG-7222: Make BGP DS clean up asynchronous

Close of the service must be done async, otherwise
will bock the thread.
Fix by make BGP DS clean up asynchronous

Change-Id: Icb19ef7b7f118fbc6b07407d1df2cb5f6cffc0fb
Signed-off-by: Claudio D. Gasparini <claudio.gasparini@pantheon.tech>
7 years agoClean up check tests and util tests 11/51911/2
Claudio D. Gasparini [Wed, 15 Feb 2017 12:15:21 +0000 (13:15 +0100)]
Clean up check tests and  util tests

Remove duplicated code on check utils for tests.
Clean up PCC mock tests

Change-Id: I1347f6561cb4ede6c8f4147680d92c3a84f92520
Signed-off-by: Claudio D. Gasparini <claudio.gasparini@pantheon.tech>
7 years agoBUG-4808: remove reference to IdentityHashMap 82/51882/1
Robert Varga [Wed, 15 Feb 2017 00:59:03 +0000 (01:59 +0100)]
BUG-4808: remove reference to IdentityHashMap

Class documentation is misleading, as the internal cache is implemented
by a weak key/weak value equivalent.

Change-Id: Ie0d08ee990b725c5ed1a52cb074b6f72eff2a26f
Signed-off-by: Robert Varga <rovarga@cisco.com>
7 years agoCode clean up 29/51229/6
Claudio D. Gasparini [Tue, 31 Jan 2017 10:47:45 +0000 (11:47 +0100)]
Code clean up

Remove redundant cast/type argument

Change-Id: I446cb24bdbcb5156136899798eb6d3d607291e62
Signed-off-by: Claudio D. Gasparini <cgaspari@cisco.com>
7 years agoRemove unused test class 58/51858/1
Claudio D. Gasparini [Tue, 14 Feb 2017 11:31:08 +0000 (12:31 +0100)]
Remove unused test class

Remove unused test class MockPCE

Change-Id: If0afe1e8f78beca02dd397c9e18f3da408a939bf
Signed-off-by: Claudio D. Gasparini <claudio.gasparini@pantheon.tech>
7 years agoRemove no longer required pcepdump 36/51836/2
Claudio D. Gasparini [Tue, 14 Feb 2017 08:26:16 +0000 (09:26 +0100)]
Remove no longer required pcepdump

Remove no longer required pcepdump.py

Change-Id: I662f6971c3b0e210e4c692402a23617d6e473939
Signed-off-by: Claudio D. Gasparini <claudio.gasparini@pantheon.tech>
7 years agoBUG-7768 Synchronize ServerSessionManager for PCEP 67/51767/2
Kevin Wang [Thu, 9 Feb 2017 22:40:23 +0000 (14:40 -0800)]
BUG-7768 Synchronize ServerSessionManager for PCEP

Add the check so that session manager can only be closed once
and becomes unusable after closing.

A java.util.ConcurrentModificationException is possible to happen
due to the close() method of ServerSessionManager is not synchronized.
The situation mostly likely will happen during a controller reboot.
It may also happen when a PCEP config is updated. The ServerSessionManager
is being restarted while all the PCEP negotiation is still happening.

Change-Id: I0e0d387add046a4fe9ec5ac74a85f8350e238d60
Signed-off-by: Kevin Wang <kevixw@gmail.com>
(cherry picked from commit 7a866eee4dec5dc368ef11c90473b3c2a256f281)

7 years agoBUG-7550: Implement CSS under Operational State 97/51297/7
Claudio D. Gasparini [Tue, 31 Jan 2017 11:49:36 +0000 (12:49 +0100)]
BUG-7550: Implement CSS under Operational State

Implement Cluster singleton service under
Operational State.

Change-Id: Iaea4d97948b8c260fb38172107a155a298fd889e
Signed-off-by: Claudio D. Gasparini <claudio.gasparini@pantheon.tech>
7 years agoCode clean up 27/51227/7
Claudio D. Gasparini [Tue, 31 Jan 2017 10:40:11 +0000 (11:40 +0100)]
Code clean up

replace long literal 'l' by 'L'

Change-Id: I9d8bffb3559887336299e84d77db82fdf7e5f379
Signed-off-by: Claudio D. Gasparini <claudio.gasparini@pantheon.tech>
7 years agoBUG-7776 Fix Test 01/51701/2
Kevin Wang [Fri, 10 Feb 2017 20:03:40 +0000 (12:03 -0800)]
BUG-7776 Fix Test

Change-Id: I86bafac12ceada82f18b27bb7adeeaa4ca6783c3
Signed-off-by: Kevin Wang <kevixw@gmail.com>
7 years agoBUG-7706: Fix ServiceUnavailableException 18/51218/5
Claudio D. Gasparini [Mon, 30 Jan 2017 09:17:02 +0000 (10:17 +0100)]
BUG-7706: Fix ServiceUnavailableException

Reconfigure BGP Server durin a session, will produce
ServiceUnavailableException at the moment session is
closed and tries to remove peer from StrictRegistry.
Fix by put aside registry from Peer Acceptor, therefore
when BP container is restarted reference wont be lost.

Change-Id: I4eb018a24e5c5ea2a4b479cba61d94cb3658f583
Signed-off-by: Claudio D. Gasparini <claudio.gasparini@pantheon.tech>
Signed-off-by: Robert Varga <rovarga@cisco.com>
7 years agoCode clean up 26/51226/9
Claudio D. Gasparini [Tue, 31 Jan 2017 10:39:12 +0000 (11:39 +0100)]
Code clean up

Migrate test from junit 3 to junit 4

Change-Id: I88e78739de6acf531154e2238e569ad5abd2f0da
Signed-off-by: Claudio D. Gasparini <claudio.gasparini@pantheon.tech>
7 years agoBUG-7512: BMP features migration to karaf 4 89/51289/15
Claudio D. Gasparini [Fri, 20 Jan 2017 10:16:51 +0000 (11:16 +0100)]
BUG-7512: BMP features migration to karaf 4

BMP features migration to karaf 4

Change-Id: Iee8a60c7831cb8a5af791b297b2052648e21b26e
Signed-off-by: Claudio D. Gasparini <claudio.gasparini@pantheon.tech>
Signed-off-by: Robert Varga <rovarga@cisco.com>
7 years agoBUG-7510: BGP features migration to karaf 4 88/51288/15
Claudio D. Gasparini [Fri, 20 Jan 2017 10:59:13 +0000 (11:59 +0100)]
BUG-7510: BGP features migration to karaf 4

BGP features migration to karaf 4

Change-Id: I78156ba3da5a5da396d8b98bc77f79e16ae8d2c7
Signed-off-by: Claudio D. Gasparini <cgaspari@cisco.com>
7 years agoBUG-7739: Fix ParserToSalTest/Topology Tests 69/51469/6
Claudio D. Gasparini [Mon, 6 Feb 2017 12:29:57 +0000 (13:29 +0100)]
BUG-7739: Fix ParserToSalTest/Topology Tests

Fix ParserToSalTest/Topology failing test

Change-Id: I01cec1b9ab83c14cec8674465ed690e77d820adc
Signed-off-by: Claudio D. Gasparini <claudio.gasparini@pantheon.tech>
7 years agoBug-7708: Invalid Route Distinguisher error while processing withdraw update containi... 54/51454/2
Ajay [Wed, 1 Feb 2017 08:24:22 +0000 (08:24 +0000)]
Bug-7708: Invalid Route Distinguisher error while processing withdraw update containing VPN route

 - RFC 3107 says that label value in withdraw message should be 0x800000
   ref. https://tools.ietf.org/html/rfc3107#section-3
 - Changed code to correctly handle this value in withdraw message received from peer.
   Also ODL will now use this value when sending withdraw message to its peer
 - Updated unit-tests accordingly

Change-Id: Ie9d90779c32e9141f953a18b07a86d0624eaee5c
Signed-off-by: Ajay <ajayl.bro@gmail.com>
(cherry picked from commit 16e0aa31e782252f25860556bd3eb4fd59431789)

7 years agoPull in osgi.core explicitly 68/51568/2
Robert Varga [Wed, 8 Feb 2017 16:26:03 +0000 (17:26 +0100)]
Pull in osgi.core explicitly

Inherited scope runtime is not sufficient, as something
in the dependecies is causing us to compile against 4.3,
which does not have generics.

Change-Id: I7a4fda07f10859698892414b43ba64cbb6e5f3fb
Signed-off-by: Robert Varga <rovarga@cisco.com>
7 years agoCode clean up 28/51228/5
Claudio D. Gasparini [Tue, 31 Jan 2017 10:44:07 +0000 (11:44 +0100)]
Code clean up

replace asList by singletonList

Change-Id: Ie3235ce8e7c7df527765e69183a52a1d56f30d70
Signed-off-by: Claudio D. Gasparini <claudio.gasparini@pantheon.tech>
7 years agoSwitch to using odl-netty-4 20/51420/4
Robert Varga [Fri, 3 Feb 2017 20:56:16 +0000 (21:56 +0100)]
Switch to using odl-netty-4

odl-netty is deprecated by odlparent, the new name is odl-netty-4
and shares odlparent's version.

Change-Id: Ib07fea42952d9c9a157fb8d3c9fa7f6a2ce7128c
Signed-off-by: Robert Varga <rovarga@cisco.com>
7 years agoCode clean up 25/51225/7
Claudio D. Gasparini [Thu, 2 Feb 2017 12:54:32 +0000 (13:54 +0100)]
Code clean up

Remove unnecessary semicolon

Change-Id: I1fae14a786876bdb5da830a31d64987498bd18ca
Signed-off-by: Claudio D. Gasparini <claudio.gasparini@pantheon.tech>
7 years agoBUG-7511: PCEP features migration to karaf 4 87/51287/8
Claudio D. Gasparini [Thu, 19 Jan 2017 18:18:22 +0000 (19:18 +0100)]
BUG-7511: PCEP features migration to karaf 4

PCEP features migration to karaf 4

Change-Id: I490f7504c078cf21642d9fd527d2bd4ac9dd83bd
Signed-off-by: Claudio D. Gasparini <cgaspari@cisco.com>
Signed-off-by: Robert Varga <rovarga@cisco.com>
7 years agoBUG-7514: Extras features migration to karaf 4 86/51286/7
Claudio D. Gasparini [Thu, 19 Jan 2017 15:35:09 +0000 (16:35 +0100)]
BUG-7514: Extras features migration to karaf 4

Extras features migration to karaf 4

Change-Id: Ie5f459a45ab74baa17b3544cba101beaadaabf12
Signed-off-by: Claudio D. Gasparini <claudio.gasparini@pantheon.tech>
Signed-off-by: Robert Varga <rovarga@cisco.com>
7 years agoRemove duplicate code for test utilities 83/51383/5
Claudio D. Gasparini [Fri, 3 Feb 2017 09:21:33 +0000 (10:21 +0100)]
Remove duplicate code for test utilities

Remove duplicate code for test Utilities

Change-Id: I8d7d2652cd5159af106d439a6b62767a73296e87
Signed-off-by: Claudio D. Gasparini <claudio.gasparini@pantheon.tech>
7 years agoBUG-7732: Improve BGPDeployer synchronization 22/51222/7
Claudio D. Gasparini [Tue, 31 Jan 2017 10:27:13 +0000 (11:27 +0100)]
BUG-7732: Improve BGPDeployer synchronization

Improve BGPDeployer synchronization

Change-Id: I0a4c321ac36efefea473d0e2557588c6d687d5d3
Signed-off-by: Claudio D. Gasparini <claudio.gasparini@pantheon.tech>
7 years agoBUG-7723 Change BGP connection failure log level 14/51314/1
Kevin Wang [Wed, 1 Feb 2017 19:56:31 +0000 (11:56 -0800)]
BUG-7723 Change BGP connection failure log level

Change the BGP connection failure log level from DEBUG to WARN.

Change-Id: I68766d8849a7ce246959534b5fc80aa2eaf8fc3c
Signed-off-by: Kevin Wang <kevixw@gmail.com>
7 years agoBUG-7251: Remove pcepy 66/51066/2
Claudio D. Gasparini [Thu, 26 Jan 2017 13:02:05 +0000 (14:02 +0100)]
BUG-7251: Remove pcepy

Remove pcepy folder

Change-Id: I571c9f8f646c0b8207a203a06a49a47649a59c83
Signed-off-by: Claudio D. Gasparini <cgaspari@cisco.com>
7 years agoFix missing relativePath 47/51247/2
Robert Varga [Tue, 31 Jan 2017 14:03:33 +0000 (15:03 +0100)]
Fix missing relativePath

odlparent-lite is outside of bgpcep project, hence
it should have an empty relativePath

Change-Id: If40a1eed870c69bb71290cd19139681fafa18e4e
Signed-off-by: Robert Varga <rovarga@cisco.com>
7 years agoAdd relativePath to RSVP4-features 15/51215/1
Claudio D. Gasparini [Mon, 30 Jan 2017 18:34:45 +0000 (19:34 +0100)]
Add relativePath to RSVP4-features

Add feature-repo-parent as relativePath

Change-Id: I91167632297b629a023b49a019a4fad99dda4ac2
Signed-off-by: Claudio D. Gasparini <cgaspari@cisco.com>
7 years agoBUG-7364: BGP Peer Acceptor Rework 44/50944/6
Claudio D. Gasparini [Tue, 24 Jan 2017 12:55:20 +0000 (13:55 +0100)]
BUG-7364: BGP Peer Acceptor Rework

- Decouple BGP Peer acceptor from BGPAcceptorConfig
- Add missing destroy method close to BP

Change-Id: I3aeaa9923f02466255cf98bc50dca9b06b7959f2
Signed-off-by: Claudio D. Gasparini <cgaspari@cisco.com>
7 years agoBUG-7513: RSVP features migration to karaf 4 38/50838/5
Claudio D. Gasparini [Thu, 19 Jan 2017 11:14:06 +0000 (12:14 +0100)]
BUG-7513: RSVP features migration to karaf 4

RSVP features migration to karaf 4

Change-Id: Ic37f898e73a56ac76526ebd92ef0068a9fc95908
Signed-off-by: Claudio D. Gasparini <cgaspari@cisco.com>
7 years agoRemove deprecated Interfaces/Methods 05/51105/3
Claudio D. Gasparini [Tue, 17 Jan 2017 10:59:21 +0000 (11:59 +0100)]
Remove deprecated Interfaces/Methods

Remove deprecated Interfaces/Methods

Change-Id: Ia543c2e6afd09c753c0a662d4811cb7a4ce1fcc5
Signed-off-by: Claudio D. Gasparini <cgaspari@cisco.com>
7 years ago\BUG-7386 Remove blocking gracefulshutdown 26/51126/2
Claudio D. Gasparini [Tue, 17 Jan 2017 10:59:21 +0000 (11:59 +0100)]
\BUG-7386 Remove blocking gracefulshutdown

Remove blocking gracefulshutdown for EventLoopGroup

Change-Id: I03fd04cd77d613ce4b8c83f1f48deb3142227bfb
Signed-off-by: Claudio D. Gasparini <cgaspari@cisco.com>
7 years agoBUG-7673: Improve synchonization under BGP/PCEP Session 83/51083/3
Claudio D. Gasparini [Thu, 26 Jan 2017 17:46:31 +0000 (18:46 +0100)]
BUG-7673: Improve synchonization under BGP/PCEP Session

- Improve synchonization under BGP/PCEP Session
- Code clean up

Change-Id: I93851323232fa9df0c23e1e23751320cdf578031
Signed-off-by: Claudio D. Gasparini <cgaspari@cisco.com>
7 years agoBUG-7351: Update IRO reference 06/51106/2
Claudio D. Gasparini [Fri, 27 Jan 2017 08:47:33 +0000 (09:47 +0100)]
BUG-7351: Update IRO reference

IRO is compliant of rfc7896 therefore we
update the reference.

Change-Id: Ia31d2e5c59ba68b966a53f92482dad56380c809b
Signed-off-by: Claudio D. Gasparini <cgaspari@cisco.com>
7 years agoReplace FindBugs :jsr305 by full :annotation (Bug 7663) 01/50901/3
Michael Vorburger [Mon, 23 Jan 2017 20:05:46 +0000 (21:05 +0100)]
Replace FindBugs :jsr305 by full :annotation (Bug 7663)

Change-Id: Ic036e549569cc5eb02958bc22702266eaaed7ff5
Signed-off-by: Michael Vorburger <vorburger@redhat.com>
7 years agoBUG-7673: Fix PCC Mock test failures 01/51001/3
Claudio D. Gasparini [Thu, 26 Jan 2017 11:00:46 +0000 (12:00 +0100)]
BUG-7673: Fix PCC Mock test failures

Fix PCC Pcep test failures by passing missing executor
Fix annotations
Fix warns for keepAlive size

Change-Id: I0013af17e01d2d8afa136a16d6315719e0aac3fd
Signed-off-by: Claudio D. Gasparini <cgaspari@cisco.com>
7 years agoBUG-5032: Implement BGP Operational State test 35/49935/10
Claudio D. Gasparini [Sun, 1 Jan 2017 18:07:28 +0000 (19:07 +0100)]
BUG-5032: Implement BGP Operational State test

BGP Operational State test implementation

Change-Id: I88805d83c55b20661619da091c69025af1413f81
Signed-off-by: Claudio D. Gasparini <cgaspari@cisco.com>
7 years agoBUG-5032: BGP Openconfig State Impl test 34/49934/10
Claudio D. Gasparini [Wed, 21 Dec 2016 18:07:47 +0000 (19:07 +0100)]
BUG-5032: BGP Openconfig State Impl test

Test implementation for check of BGP Openconfig State Imp

Change-Id: I86d58892a30dc995898b637d903bec2b606d60c1
Signed-off-by: Claudio D. Gasparini <cgaspari@cisco.com>
7 years agoBUG-7558: BGP SingleFeatureTest Failure 39/50539/2
Claudio D. Gasparini [Tue, 17 Jan 2017 11:55:05 +0000 (12:55 +0100)]
BUG-7558: BGP SingleFeatureTest Failure

BGP SingleFeatureTest Failure fix by
create an specific feature for all
config-file and added as a dependency
for Config-loader feature.

Change-Id: Ifb79c898ea8cba4e68fdd257c2d8c3498ebb559b
Signed-off-by: Claudio D. Gasparini <cgaspari@cisco.com>
7 years agoBUG-5032: BGP Operational State 33/49933/12
Claudio D. Gasparini [Wed, 16 Nov 2016 14:11:44 +0000 (15:11 +0100)]
BUG-5032: BGP Operational State

Implement BGP Operational State per
Global and Neighbor.
Operational State per PeerGroup is also
implemented and will need to be plug in
once Peer Group is supported.

Change-Id: Ic1a75348e370bdd06777267c153b924acc3b4c15
Signed-off-by: Claudio D. Gasparini <cgaspari@cisco.com>
7 years agoRework Openconfig State Features dependencies 01/50401/1
Claudio D. Gasparini [Fri, 13 Jan 2017 10:09:28 +0000 (11:09 +0100)]
Rework Openconfig State Features dependencies

Openconfig State Features should depend on rib-impl
feature and not the other way around

Change-Id: Id40c99a637b670d6d4591c090321f77ecab39a8f
Signed-off-by: Claudio D. Gasparini <cgaspari@cisco.com>
7 years agoPrepare upgrade to Netty 4.1 99/40999/3
Stephen Kitt [Wed, 29 Jun 2016 09:18:28 +0000 (11:18 +0200)]
Prepare upgrade to Netty 4.1

We need to widen the range of allowed versions for odl-netty.

Change-Id: Ib2340ef08a41dcb6508afccbb420b52f94be6051
Signed-off-by: Stephen Kitt <skitt@redhat.com>
7 years agoBUG-5032: BGP Openconfig State Implementation 29/49929/3
Claudio D. Gasparini [Tue, 15 Nov 2016 12:17:17 +0000 (13:17 +0100)]
BUG-5032: BGP Openconfig State Implementation

Introduce service on charge of store
BGP Operational State as an Openconfig
Operational State format.
Introduce Utilities to convert BGP Operational
State to Openconfig State.

Intruce a cache TableType-AfiSafi under
BGPTableTypeRegistry. Table type will be stored
as they are required.

Change-Id: I3cb546f7f332e7f9eb7bba0a45d366fca0c4d0e5
Signed-off-by: Claudio D. Gasparini <cgaspari@cisco.com>
7 years agoBUG-5032: Implement BGP State Collector 28/49928/3
Claudio D. Gasparini [Tue, 20 Dec 2016 13:15:23 +0000 (14:15 +0100)]
BUG-5032: Implement BGP State Collector

BGP State Collector act as a provider of
all BGP Rib States.

Change-Id: I4d4919d10d168561c087b742fcd76dfbe9b6912b
Signed-off-by: Claudio D. Gasparini <cgaspari@cisco.com>
7 years agoBUG-5032: Introduce BGP Operational State 27/49927/3
Claudio D. Gasparini [Mon, 19 Dec 2016 19:16:29 +0000 (20:16 +0100)]
BUG-5032: Introduce BGP Operational State

Introduce interfaces for expose BGP Operational State for:
-RIB
-PeerGroup
-Neighbor
-BGPState Collector

Change-Id: Ib6b053f4e7e734eb3f4525f7de4643c9b89c9a31
Signed-off-by: Claudio D. Gasparini <cgaspari@cisco.com>
7 years agoReplace UnsignedInt32Counter by LongAdder 26/49926/3
Claudio D. Gasparini [Mon, 19 Dec 2016 22:36:09 +0000 (23:36 +0100)]
Replace UnsignedInt32Counter by LongAdder

Replace UnsignedInt32Counter, which is not
efficient and only provides of logs which are of
not use for a more suitable counter(LongAdder).

Change-Id: Iaad4879c9c3a783ac45f21d47f3379b22f22e3e4
Signed-off-by: Claudio D. Gasparini <cgaspari@cisco.com>
7 years agoFix invalid YANG 1.0 leafrefs 13/50013/1
Igor Foltin [Wed, 4 Jan 2017 11:31:10 +0000 (12:31 +0100)]
Fix invalid YANG 1.0 leafrefs

Two YANG 1.0 models contain leafrefs with require-instance substatements
which is not valid for YANG 1.0 version. Comment out these substatements
for now. In the future, when YANG 1.1 support for such substatements
will be available, they can be uncommented.

Change-Id: I59cc7bd8f3fdcd14d96ee672fbceaf1d48f5836d
Signed-off-by: Igor Foltin <ifoltin@cisco.com>
7 years agoBUG-7251: Remove pcepy 37/49937/4
Vratko Polak [Wed, 4 Jan 2017 09:06:31 +0000 (10:06 +0100)]
BUG-7251: Remove pcepy

remove no longer required pcepy code

Change-Id: Ib99682fc221b33b17ef972f1309dab43506cfa08
Signed-off-by: Claudio D. Gasparini <cgaspari@cisco.com>
Signed-off-by: Vratko Polak <vrpolak@cisco.com>
7 years agoBUG-7159: eliminate use of CrossSourceStatementReactor 54/49754/4
Robert Varga [Thu, 22 Dec 2016 18:38:20 +0000 (19:38 +0100)]
BUG-7159: eliminate use of CrossSourceStatementReactor

We have YangParserTestUtils which are more convenient, use them
instead.

Change-Id: Ia7810aec6f7a6c66a71a1523993b45d274c57606
Signed-off-by: Robert Varga <rovarga@cisco.com>
7 years agoFix Sonar complains 64/48664/4
Claudio D. Gasparini [Thu, 24 Nov 2016 13:59:00 +0000 (14:59 +0100)]
Fix Sonar complains

Fix naming convention, etc..

Change-Id: I2048e319bcef7bf41c47631413e0e9c9468c499d
Signed-off-by: Claudio D. Gasparini <cgaspari@cisco.com>
7 years agoBUG-7215: Fix App Peer ModifiedNodeDoesNotExistException 82/48882/6
Claudio D. Gasparini [Wed, 30 Nov 2016 10:14:58 +0000 (11:14 +0100)]
BUG-7215: Fix App Peer ModifiedNodeDoesNotExistException

If Rib is reconfigured with different Family than the
previous supported one, application peer will be
reconfigured. In the case there are some routes or,
family table configured on Config DS, when restarting
App peer with new configuration will end on
ModifiedNodeDoesNotExistException.

Fix by:
   -Make Application peer more defensiveness by ingore changes
 on config DS for non supported Families.
   - Register Change Listener once AdjRibIn has been
 succesfully initialized.

Change-Id: I25b08b057fad02df365070c0a6d5177b9e0392a0
Signed-off-by: Claudio D. Gasparini <cgaspari@cisco.com>
7 years agoBUG-7028: Migrate BGP Benchmark App to BP wiring 91/48791/2
Claudio D. Gasparini [Tue, 8 Nov 2016 08:12:09 +0000 (09:12 +0100)]
BUG-7028: Migrate BGP Benchmark App to BP wiring

Migrate BGP Benchmark App to BP wiring

Change-Id: I5632a5ec3afde41862004e172e451fc358c53eab
Signed-off-by: Claudio D. Gasparini <cgaspari@cisco.com>
7 years agoBUG-7222: Fix clustering BGPPeer NPE 32/48732/2
Claudio D. Gasparini [Mon, 28 Nov 2016 10:46:33 +0000 (11:46 +0100)]
BUG-7222: Fix clustering BGPPeer NPE

Fix NPE: Any call to rib should be done
during singleton service instantiation or after.
Any call before can cause a NPE since RIB might be
on undefined status yet.

Change-Id: Ia1ebbc334f07362f325ac599f39f9d601e717321
Signed-off-by: Claudio D. Gasparini <cgaspari@cisco.com>
7 years agoPcepy: Address pep8 violations 81/48581/1
Vratko Polak [Tue, 22 Nov 2016 15:05:54 +0000 (16:05 +0100)]
Pcepy: Address pep8 violations

Newer libraries used in verification are more sensitive to
"E305 expected 2 blank lines after class or function definition".

Change-Id: I3f94115bb70b069f3eb417429bbc457c73048a7a
Signed-off-by: Vratko Polak <vrpolak@cisco.com>
7 years agoBUG-7003: Remove Thread.sleep() calls in tests 28/48228/4
Claudio D. Gasparini [Thu, 10 Nov 2016 12:59:51 +0000 (13:59 +0100)]
BUG-7003: Remove Thread.sleep() calls in tests

Partial improvement under Additional Paths tests.
The time spent has been reduced.

Change-Id: I8ebfd19af9147a10f1d5856b5478501f2ab890ab
Signed-off-by: Claudio D. Gasparini <cgaspari@cisco.com>
7 years agoMisspelled method name correction 26/29926/3
Iveta Halanova [Thu, 19 Nov 2015 09:27:55 +0000 (10:27 +0100)]
Misspelled method name correction

Change-Id: Ic6d803b6853324efa9e7868d142cf184fda47f58
Signed-off-by: Iveta Halanova <ihalanov@cisco.com>
7 years agoBUG-7006: Unit-tests sometimes hangs during execution 85/47885/5
Claudio D. Gasparini [Thu, 3 Nov 2016 10:53:33 +0000 (11:53 +0100)]
BUG-7006: Unit-tests sometimes hangs during execution

Fix sporadically hangs during unit-tests execution

Change-Id: Ia339af6d9181a7be8e4b3e6335bba250aaecd822
Signed-off-by: Claudio D. Gasparini <cgaspari@cisco.com>
7 years agoBUG-7098: Fix Sonar complains 40/48040/1
Claudio D. Gasparini [Mon, 7 Nov 2016 08:24:10 +0000 (09:24 +0100)]
BUG-7098: Fix Sonar complains

Fix duplicate code
Naming conventions

Change-Id: I2425fc111b5890100cda942913b0d617b4029f2c
Signed-off-by: Claudio D. Gasparini <cgaspari@cisco.com>
7 years agoBUG-7003: Introduce CheckUtil 22/48022/2
Claudio D. Gasparini [Fri, 4 Nov 2016 13:02:30 +0000 (14:02 +0100)]
BUG-7003: Introduce CheckUtil

Introduce CheckUtil for replace Thread.sleep on tests

Change-Id: I6a74b7dc9563594424c8b1a0b03ca39890d3e803
Signed-off-by: Claudio D. Gasparini <cgaspari@cisco.com>
7 years agoBUG-7088: pcep-pcc-mock fails to start 82/47982/1
Claudio D. Gasparini [Fri, 4 Nov 2016 10:18:06 +0000 (11:18 +0100)]
BUG-7088: pcep-pcc-mock fails to start

Fix by exclude the signatures otherwise
we get an SecurityException.

Change-Id: I4eb8a6d945e6c0ff4e5d9612e59d93ea95044d03
Signed-off-by: Claudio D. Gasparini <cgaspari@cisco.com>
7 years agoFix wrong config version 95/47795/1
Robert Varga [Tue, 1 Nov 2016 12:58:31 +0000 (13:58 +0100)]
Fix wrong config version

This break autorelease, fix the version declaration.

Change-Id: I50ac84924ff4eaae47b8891485310df351d6ed56
Signed-off-by: Robert Varga <rovarga@cisco.com>
7 years agoRemove openconfig-impl module 88/47688/2
Milos Fabian [Thu, 27 Oct 2016 15:33:50 +0000 (17:33 +0200)]
Remove openconfig-impl module

This module's code is no longer used in project.
The modules funtionality has been moved to rib-impl an openconfig-spi.

Change-Id: I25a7d3f7da7326abe8dea915cfb62515e394f8e5
Signed-off-by: Milos Fabian <milfabia@cisco.com>
7 years agoDo not install openconfig-impl bundle 87/47687/2
Milos Fabian [Thu, 27 Oct 2016 15:29:04 +0000 (17:29 +0200)]
Do not install openconfig-impl bundle

This bundle is not longer used, remove it from BGP's features.

Change-Id: I4c919468966dc96c8498148eafd3b407649defee
Signed-off-by: Milos Fabian <milfabia@cisco.com>
7 years agoUse BGPTableTypeRegistryConsumer instead of BGPOpenConfigMappingService 86/47686/2
Milos Fabian [Thu, 27 Oct 2016 15:14:56 +0000 (17:14 +0200)]
Use BGPTableTypeRegistryConsumer instead of BGPOpenConfigMappingService

The BGPTableTypeRegistryConsumer is providing access to the map supported AFI/SAFI.

Remove BGPOpenConfigMappingService in a next step.

Change-Id: I837fe90446da983a4bad1f91fed871052ca67ef6
Signed-off-by: Milos Fabian <milfabia@cisco.com>
7 years agoRegister L2VPN EVPN AFI/SAFI 85/47685/3
Milos Fabian [Thu, 27 Oct 2016 12:18:59 +0000 (14:18 +0200)]
Register L2VPN EVPN AFI/SAFI

Change-Id: If2f3c18606053df53c9e5c1c69e976c3b8ea16df
Signed-off-by: Milos Fabian <milfabia@cisco.com>
7 years agoRegister IP L3VPN AFI/SAFI 84/47684/3
Milos Fabian [Thu, 27 Oct 2016 12:04:21 +0000 (14:04 +0200)]
Register IP L3VPN AFI/SAFI

Change-Id: If084f0b653af09d7729c038077ef908621840e2b
Signed-off-by: Milos Fabian <milfabia@cisco.com>
7 years agoRegister IP Labeled Unicast AFI/SAFI 83/47683/3
Milos Fabian [Thu, 27 Oct 2016 11:01:02 +0000 (13:01 +0200)]
Register IP Labeled Unicast AFI/SAFI

Change-Id: I0b17e3bd205122a84b2c7f22adc1e71ac2a7fa3a
Signed-off-by: Milos Fabian <milfabia@cisco.com>
7 years agoRegister Link-state AFI/SAFI 82/47682/3
Milos Fabian [Thu, 27 Oct 2016 10:41:34 +0000 (12:41 +0200)]
Register Link-state AFI/SAFI

Change-Id: I7c5c6ccafa23e555d10a0f8461513200c4173d6d
Signed-off-by: Milos Fabian <milfabia@cisco.com>
7 years agoRegister Flowspecs AFI/SAFI 81/47681/3
Milos Fabian [Thu, 27 Oct 2016 09:57:08 +0000 (11:57 +0200)]
Register Flowspecs AFI/SAFI

Change-Id: I6394e921688ebcdf163e129ff01ebdc251dfd0df
Signed-off-by: Milos Fabian <milfabia@cisco.com>
7 years agoBUG-6857: Network topology configuration file loader test 14/47614/6
Claudio D. Gasparini [Tue, 25 Oct 2016 11:34:15 +0000 (13:34 +0200)]
BUG-6857: Network topology configuration file loader test

 Network topology configuration file loader
 implementation test

Change-Id: I243aac6f2de35b8f867c766116fa6b0a9d6278bd
Signed-off-by: Claudio D. Gasparini <cgaspari@cisco.com>
7 years agoRegister IP Unicast AFI/SAFI in inet extension 80/47680/2
Milos Fabian [Wed, 26 Oct 2016 11:19:49 +0000 (13:19 +0200)]
Register IP Unicast AFI/SAFI in inet extension

Change-Id: I53c4cfeca8cc81c2ebd6b067b287366850f5cbe2
Signed-off-by: Milos Fabian <milfabia@cisco.com>
7 years agoBUG-6857: Protocol config loader tests 14/47514/9
Claudio D. Gasparini [Tue, 25 Oct 2016 11:28:51 +0000 (13:28 +0200)]
BUG-6857: Protocol config loader tests

Protocol config loader tests

Change-Id: I0dfb4db04b23cab700ee7dd41a59734bfd4ce690
Signed-off-by: Claudio D. Gasparini <cgaspari@cisco.com>
7 years agoDefine OpenConfig API feature 79/47679/1
Milos Fabian [Wed, 26 Oct 2016 10:02:20 +0000 (12:02 +0200)]
Define OpenConfig API feature

In order to register AFI/SAFI suppport in BGP-MP extension,
define new OpenConfig API feature carrying API and SPI bundles.

Change-Id: I9f91639bf91b98924cb80fe4f8bbbd4903ff1d5d
Signed-off-by: Milos Fabian <milfabia@cisco.com>
7 years agoIntroduce BGPTableType Registry 78/47678/1
Milos Fabian [Wed, 26 Oct 2016 09:49:07 +0000 (11:49 +0200)]
Introduce BGPTableType Registry

The registry is holding supported AFI/SAFI in form of BGPTableType and OpenConfig AfiSafiType.
Currenlty, this two AFI/SAFI representations mapping is held in static map, which lacks of extensibility.
The registry provider context is supposed to be activated in BGP-MP extensions.
The registry would be consumed in BGP configuration mapping procedures.

Change-Id: Ib34147f56d85bf418b29924d6d1f805d4ed1a757
Signed-off-by: Milos Fabian <milfabia@cisco.com>
7 years agoOpenConfig IMPL clean-up 77/47677/1
Milos Fabian [Thu, 27 Oct 2016 08:59:36 +0000 (10:59 +0200)]
OpenConfig IMPL clean-up

Move all mapping utilities from OpenConfig IMPL to RIB-IMPL.

Next step - get rid of the static map (BgpTableType<->AfiSafiType) - extensibility is essenatial here.

Change-Id: Id88b8564d89138e78803bc7a6cf7d7b1ed5b879f
Signed-off-by: Milos Fabian <milfabia@cisco.com>
7 years agoBUG-6857: Config file loader test 13/47513/10
Claudio D. Gasparini [Tue, 25 Oct 2016 11:27:24 +0000 (13:27 +0200)]
BUG-6857: Config file loader test

+ config file loader test implementation

Change-Id: I5035d333d0eb5a57be19cca0ebd2e4a57de5bd40
Signed-off-by: Claudio D. Gasparini <cgaspari@cisco.com>
7 years agoBUG-6857: Migrate from CSS initial config 16/47616/2
Claudio D. Gasparini [Tue, 25 Oct 2016 11:35:54 +0000 (13:35 +0200)]
BUG-6857: Migrate from CSS initial config

Migrate from CSS initial config to Config Loader.

Change-Id: I8b2cb0e1cbcab62b2a50f94c3011ca0b8e70677f
Signed-off-by: Claudio D. Gasparini <cgaspari@cisco.com>
7 years agoDerive aggregators from odlparent-lite 20/47220/13
Robert Varga [Thu, 20 Oct 2016 18:24:13 +0000 (20:24 +0200)]
Derive aggregators from odlparent-lite

There is no point in inheriting from parent,
just use odlparent-lite. Should speed up the build
process.

Change-Id: Iecdf1b5d7c44d7f5f1c84a2107bf51c7011b6f23
Signed-off-by: Robert Varga <rovarga@cisco.com>
7 years agoBUG-6857: Network Topology Config Loader 07/47607/3
Claudio D. Gasparini [Tue, 25 Oct 2016 11:31:45 +0000 (13:31 +0200)]
BUG-6857: Network Topology Config Loader

- Create NetworkTopologyConfigFileProcessors
  Serialize Topology normalized node to BI
  and notifies Deployer, loading new configuration.
- network-topology-config.xml Contains Ipv4 topology,
  Ipv6 topology, Linkstate Topology.

Change-Id: I7f0a607f43586e54952ff623ac1250bb55e33b54
Signed-off-by: Claudio D. Gasparini <cgaspari@cisco.com>
7 years agoBUG-6857: ConfigLoader rework 05/47505/5
Claudio D. Gasparini [Tue, 25 Oct 2016 11:22:22 +0000 (13:22 +0200)]
BUG-6857: ConfigLoader rework

ConfigLoader rework. Split Watchservice.

Change-Id: If0a07f03b3f923d940eb0c8dc31acc691870cb0b
Signed-off-by: Claudio D. Gasparini <cgaspari@cisco.com>
7 years agoBUG-6857: ProtocolsConfigFileProcessor fix 64/47564/1
Claudio D. Gasparini [Tue, 25 Oct 2016 21:01:29 +0000 (23:01 +0200)]
BUG-6857: ProtocolsConfigFileProcessor fix

sort registration

Change-Id: I852def5a937d55580b4cb9d9c54a2f5938854bc3
Signed-off-by: Claudio D. Gasparini <cgaspari@cisco.com>
7 years agoBug 6622 - ClusterSingletonService registration race condition 16/47416/1
Milos Fabian [Mon, 17 Oct 2016 13:34:13 +0000 (15:34 +0200)]
Bug 6622 - ClusterSingletonService registration race condition

This is a hot fix for a race condition issue which can happen during a service lifecycle.
An application which manages services in not aware when the unregistration is finished, hence
service close is followed by immendiate service registration which may fail consequently.
This condition is handled by reatempting service regsiration after 10 ms.

Also fixes RIBImpl - create TX chain in #instantiateServiceInstance and asynchronously clean operatoinal DS.

Change-Id: I110badc8bfb482a5b7cb6545b882cda2d0c661ae
Signed-off-by: Milos Fabian <milfabia@cisco.com>