Stephen Kitt [Wed, 15 Nov 2017 08:30:14 +0000 (09:30 +0100)]
Dependency check: avoid dependency loops
Exclude all org.opendaylight dependencies to avoid introducing
dependency loops with dependency management on third-party artifacts
re-packaged in ODL projects.
Change-Id: I19a235e395f4b8e89e86a054d4e266cc8e101905
Signed-off-by: Stephen Kitt <skitt@redhat.com>
Robert Varga [Wed, 18 Oct 2017 11:46:10 +0000 (13:46 +0200)]
BUG-9202: update maven-javadoc-plugin
Required to make build work with Java 9, release notes are at
https://mail-archives.apache.org/mod_mbox/maven-announce/201707.mbox/%3Cop.y3p20je4kdkhrr%40desktop-2khsk44%3E
Change-Id: I46d348026a41587a04ebc6508fcc649dd5be9a48
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
Stephen Kitt [Wed, 15 Nov 2017 09:06:36 +0000 (10:06 +0100)]
SFT needs Karaf branding
For some reason SFT now needs our Karaf branding. We should fix this
so that it’s no longer the case — see
https://jira.opendaylight.org/browse/ODLPARENT-130 — but in the
interest of getting odlparent 3.0.0 out, this adds an explicit test
dependency.
Change-Id: I548e421a63073503be47d239cd9536306ab92bd9
Signed-off-by: Stephen Kitt <skitt@redhat.com>
Stephen Kitt [Thu, 9 Nov 2017 17:09:39 +0000 (18:09 +0100)]
Add a dependency check to validate management
To avoid issues such as the invalid uncommon-maths version bump, add a
module whose sole purpose is to depend on all artifacts specified in
dependency management in odlparent. This ensures that the artifacts
are actually available.
Remove two artifacts which don’t exist (and aren’t used anywhere):
* ssl-config-akka_2.12
* jetty-servlet-tester
Change-Id: Ia18132fb45eb5f87afdc0d63ac3fff4f2caaf04c
Signed-off-by: Stephen Kitt <skitt@redhat.com>
Stephen Kitt [Fri, 10 Nov 2017 17:32:54 +0000 (18:32 +0100)]
Don’t exclude pax-url-commons from pax-url-wrap
Excluding pax-url-commons from pax-url-wrap means that anything
depending on -wrap without -aether fails (including karaf-plugin).
Change-Id: I861f63caac4fdf6405174df4e05e6242d747b2b5
Signed-off-by: Stephen Kitt <skitt@redhat.com>
Michael Vorburger [Thu, 9 Nov 2017 17:36:01 +0000 (18:36 +0100)]
Remove io.dropwizard.metrics dependencyManagement
https://lists.opendaylight.org/pipermail/odlparent-dev/2017-November/001460.html
for https://jira.opendaylight.org/browse/INFRAUTILS-19
Change-Id: I0ce0e4b7ad54e171c061e1bb91d568b25e9d1145
Signed-off-by: Michael Vorburger <vorburger@redhat.com>
Michael Vorburger [Mon, 23 Jan 2017 21:41:14 +0000 (22:41 +0100)]
Fail build if classpath contains duplicates
duplicate-finder-maven-plugin fails build if duplicate classpath entries
see https://github.com/basepom/duplicate-finder-maven-plugin/
This is currently not enforced, but projects opt-in to this quality via:
<properties><duplicate-finder.skip>false
FTR: There are a few other tools in this space, incl. e.g.
http://www.mojohaus.org/extra-enforcer-rules/banDuplicateClasses.html
and http://tattletale.jboss.org/ and http://jhades.github.io, but
duplicate-finder-maven-plugin fits best here.
See https://git.opendaylight.org/gerrit/#/c/50851/ for a related util.
Bug: 7662
Change-Id: I79142549ba7c739ce39285d35f179172d7b099a6
Signed-off-by: Michael Vorburger <vorburger@redhat.com>
Robert Varga [Tue, 7 Nov 2017 02:12:21 +0000 (03:12 +0100)]
Bump jacoco to 0.7.9
https://github.com/jacoco/jacoco/releases/tag/v0.7.8
https://github.com/jacoco/jacoco/releases/tag/v0.7.9
Change-Id: Iced1a38897da53fcf80d2cde4ee76baa93cd8242
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
Stephen Kitt [Tue, 7 Nov 2017 16:07:35 +0000 (16:07 +0000)]
Revert "Checkstyle InnerAssignment"
This reverts commit
c115daf2f2548b49b505a12fb3ab26c7e096dd8c.
The Checkstyle InnerAssignment check only handles a subset of cases,
which ends up being confusing.
(E.g. while() { }, but not do { } while().)
Change-Id: I813679f18214e8729bc588ae4e0987579b0e3786
Signed-off-by: Stephen Kitt <skitt@redhat.com>
Stephen Kitt [Wed, 8 Nov 2017 09:28:47 +0000 (09:28 +0000)]
Revert "Bump Uncommons Maths 1.2.2a → 1.2.3"
This reverts commit
cf236575fa87a2928bb83393bb9e5355b8eedd01.
Version 1.2.3 isn’t available on Maven Central...
Change-Id: If524032a85f17dee7a553e5e27cdeb9816904af6
Signed-off-by: Stephen Kitt <skitt@redhat.com>
Michael Vorburger [Sat, 4 Nov 2017 03:15:10 +0000 (04:15 +0100)]
Revert "Checkstyle TrailingComment, Sonar aligned"
This reverts commit
f7680f6a688e26e28515c907328c52d0a35a4515.
This code format convention is actually stupid IMHO after all.
For example, I really do like this a lot more:
@SuppressFBWarnings("SE_BAD_FIELD") // Runnable is not Serializable
private final TrackingLinkedBlockingQueue<Runnable> backingQueue;
than being forced by Checkstyle to have to write this:
// Runnable is not Serializable
@SuppressFBWarnings("SE_BAD_FIELD")
private final TrackingLinkedBlockingQueue<Runnable> backingQueue;
We should change Sonar's configuraiton, not enforce this in odlparent.
Change-Id: Ib3a8708a7a4b43bb72859f69aca33aafb8b6080c
Signed-off-by: Michael Vorburger <vorburger@redhat.com>
Robert Varga [Fri, 27 Oct 2017 11:27:08 +0000 (13:27 +0200)]
Bump scala to 2.12.4
https://github.com/scala/scala/releases/tag/v2.12.4
Change-Id: Id179520eb109053dd99197f5f9665d6be6d40bab
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
Robert Varga [Tue, 7 Nov 2017 01:55:14 +0000 (02:55 +0100)]
Add -Xlint:deprecation
We do need to clean up callers of deprecated methods. Make sure
we emit details during build.
Change-Id: I3259edafcf0f54b087b38f5270cf67009a0fd885
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
Stephen Kitt [Fri, 3 Nov 2017 15:11:39 +0000 (16:11 +0100)]
Bump Awaitility 2 → 3
Release notes:
https://github.com/awaitility/awaitility/wiki/ReleaseNotes30
Change-Id: Iee993116d976a6f61104681e055e8d5f60575895
Signed-off-by: Stephen Kitt <skitt@redhat.com>
Stephen Kitt [Fri, 3 Nov 2017 15:09:08 +0000 (16:09 +0100)]
Bump Felix dependencies
Dependency Manager 4.3.0 → 4.4.1
Dependency Manager Shell 4.0.4 → 4.0.6
Metatype 1.1.2 → 1.1.6
Release notes are few and far between...
Change-Id: Ib13e01ad62ba31d30b8efe20fab10d1564337bd7
Signed-off-by: Stephen Kitt <skitt@redhat.com>
Michael Vorburger [Sun, 5 Nov 2017 11:19:21 +0000 (12:19 +0100)]
maven-compiler-plugin showWarnings
This won't break anything, just spew a few more logs, which MAYBE *some*
people will start looking it. I will be enabled with the upcoming
proposed error-prone integration anyway, so we may as well make a start
with it now, even before getting error-prone in.
Change-Id: Ica17b1a250562c0f083ed252d921dc86278abd3b
Signed-off-by: Michael Vorburger <vorburger@redhat.com>
Stephen Kitt [Fri, 3 Nov 2017 12:55:31 +0000 (13:55 +0100)]
Bump webcohesion enunciate 2.6.0 → 2.10.1
Release notes: https://github.com/stoicflame/enunciate/releases
Change-Id: Id60106cd18b822eb84589bc4bf7c2e9e35c577e8
Signed-off-by: Stephen Kitt <skitt@redhat.com>
Stephen Kitt [Fri, 3 Nov 2017 14:44:32 +0000 (15:44 +0100)]
Remove obsolete dependency management entries
Remove a number of dependencies which are no longer used:
* xml-apis
* Xerces
* txw2
* Eclipse Link
* Gemini Web
* Orbit
* Felix File Install and Web Console
* Equinox HTTP service bridge
* Chameleon MBeans
* Spring Framework
Change-Id: Icbc4368941f109e7b835323b2dfbcef0b335e8bb
Signed-off-by: Stephen Kitt <skitt@redhat.com>
Michael Vorburger [Wed, 1 Nov 2017 10:47:15 +0000 (11:47 +0100)]
Checkstyle InnerAssignment
see http://checkstyle.sourceforge.net/config_coding.html#InnerAssignment
Change-Id: Icaaaa3ff3a08843b2ed1bf013edf7110b49b547c
Signed-off-by: Michael Vorburger <vorburger@redhat.com>
Stephen Kitt [Fri, 3 Nov 2017 15:54:27 +0000 (16:54 +0100)]
Bump Uncommons Maths 1.2.2a → 1.2.3
This version adds OSGi bundle information:
https://maths.uncommons.org/changelog.php
Change-Id: I379e8d857f936f4471a1529adb0f3cc363d20d3e
Signed-off-by: Stephen Kitt <skitt@redhat.com>
Stephen Kitt [Thu, 2 Nov 2017 16:55:43 +0000 (17:55 +0100)]
Bump logback 1.2.2 → 1.2.3
Release notes: https://logback.qos.ch/news.html
Change-Id: If03272caf0a419541d1e4203539a83b85622737b
Signed-off-by: Stephen Kitt <skitt@redhat.com>
Stephen Kitt [Thu, 2 Nov 2017 16:58:58 +0000 (17:58 +0100)]
Bump gson 2.7 → 2.8.2
Release notes: https://github.com/google/gson/blob/master/CHANGELOG.md
Change-Id: If6c7369442a68ce9d2545010335cb422d2f45238
Signed-off-by: Stephen Kitt <skitt@redhat.com>
Stephen Kitt [Fri, 3 Nov 2017 10:39:21 +0000 (11:39 +0100)]
Bump lmax disruptor 3.3.6 → 3.3.7
Release notes: https://github.com/LMAX-Exchange/disruptor/releases/tag/3.3.7
Change-Id: I0fd240efa3d24fb524961cfed01ebf091650adb7
Signed-off-by: Stephen Kitt <skitt@redhat.com>
Stephen Kitt [Fri, 3 Nov 2017 12:57:33 +0000 (13:57 +0100)]
Bump commons-fileupload 1.3.2 → 1.3.3
Release notes:
http://www.apache.org/dist/commons/fileupload/RELEASE-NOTES.txt
Change-Id: Ic18fec72aea51fe33debd160b03d984e512ecbed
Signed-off-by: Stephen Kitt <skitt@redhat.com>
Stephen Kitt [Fri, 3 Nov 2017 12:58:57 +0000 (13:58 +0100)]
Bump commons-io 2.5 → 2.6
Release notes: http://www.apache.org/dist/commons/io/RELEASE-NOTES.txt
This version is now a Java 9 module.
Change-Id: Ie5ca856b636347927d4bf9e3d1fd824d79b02a8d
Signed-off-by: Stephen Kitt <skitt@redhat.com>
Stephen Kitt [Fri, 3 Nov 2017 15:49:29 +0000 (16:49 +0100)]
Bump JSONassert 1.3.0 → 1.5.0
Release notes: https://github.com/skyscreamer/JSONassert/releases
Change-Id: I5d066a5168a22d1b56b61e19d9582deacf9f21a9
Signed-off-by: Stephen Kitt <skitt@redhat.com>
Stephen Kitt [Fri, 3 Nov 2017 15:52:07 +0000 (16:52 +0100)]
Bump SLF4J 1.7.21 → 1.7.25
Release notes: https://www.slf4j.org/news.html
Change-Id: I8092ba8f07824c8433774898c24d25d5e3510680
Signed-off-by: Stephen Kitt <skitt@redhat.com>
Stephen Kitt [Fri, 3 Nov 2017 15:59:23 +0000 (16:59 +0100)]
Bump Karaf 4.1.2 → 4.1.3
Change-Id: Ia3eb52ca11cc3e3e870badf469ef8ead7294d031
Signed-off-by: Stephen Kitt <skitt@redhat.com>
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
Robert Varga [Tue, 19 Sep 2017 09:08:07 +0000 (11:08 +0200)]
BUG-8258: Bump karaf 4.1.2
This is a straightforward upgrade from 4.0.9 to 4.1.2 and will need
to be updated to 4.1.3.
Change-Id: I9275dd42e53dec3e46bc169b6aafb5cb75b40753
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
Signed-off-by: Stephen Kitt <skitt@redhat.com>
Stephen Kitt [Fri, 3 Nov 2017 14:58:17 +0000 (15:58 +0100)]
Bump Coda Hale Metrics 3.1.2 → 3.2.3
Release notes:
http://metrics.dropwizard.io/3.2.3/about/release-notes.html
Change-Id: I723e77d1907fc6dde8724f8236ee9c545a20ebbe
Signed-off-by: Stephen Kitt <skitt@redhat.com>
Stephen Kitt [Fri, 3 Nov 2017 10:47:02 +0000 (11:47 +0100)]
Bump checkstyle 8.2 → 8.4
Release notes:
http://checkstyle.sourceforge.net/releasenotes.html#Release_8.4
Change-Id: Ibf0f3079d0c7911c1106d8dbbbf7a4f32037dc8b
Signed-off-by: Stephen Kitt <skitt@redhat.com>
Stephen Kitt [Tue, 31 Oct 2017 14:50:20 +0000 (15:50 +0100)]
Add support for local feature files
Karaf 4.1 introduces local feature files for some dependencies. This
patch adjusts populate-local-repo so that it copes with them instead
of crashing.
Change-Id: Ia709011d928abd4994346fde5002c3ff35fe874a
Signed-off-by: Stephen Kitt <skitt@redhat.com>
Stephen Kitt [Fri, 3 Nov 2017 15:15:29 +0000 (16:15 +0100)]
Bump Xtend 2.12 → 2.13
Release notes: https://www.eclipse.org/xtend/releasenotes.html
Change-Id: I97f878b8904dc83b04c78e9759d38adf48116b64
Signed-off-by: Stephen Kitt <skitt@redhat.com>
Stephen Kitt [Fri, 3 Nov 2017 10:21:11 +0000 (11:21 +0100)]
Bump Google Truth 0.28 → 0.36
Release notes: https://github.com/google/truth/releases
This also enables the Java 8 extensions.
Change-Id: If374852847f0669d03cd08f6a541465cfbc6bd95
Signed-off-by: Stephen Kitt <skitt@redhat.com>
Robert Varga [Thu, 2 Nov 2017 10:13:13 +0000 (11:13 +0100)]
Bump guava to 23.3-jre
https://github.com/google/guava/releases/tag/v23.3
Change-Id: I887206256c1f4ed611dc350eac3bf887fab6f72e
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
Michael Vorburger [Wed, 1 Nov 2017 10:50:35 +0000 (11:50 +0100)]
Checkstyle HiddenField
see http://checkstyle.sourceforge.net/config_coding.html#HiddenField
Change-Id: I7c25835837e63a9580a9f870d2c1d7cef9e2f57d
Signed-off-by: Michael Vorburger <vorburger@redhat.com>
Michael Vorburger [Wed, 29 Jun 2016 23:01:16 +0000 (01:01 +0200)]
Checkstyle TrailingComment, aligned with Sonar
http://checkstyle.sourceforge.net/config_misc.html#TrailingComment
Change-Id: I063cc5b40b561292d3d412d595669851b29951bb
Signed-off-by: Michael Vorburger <vorburger@redhat.com>
Robert Varga [Wed, 18 Oct 2017 11:42:10 +0000 (13:42 +0200)]
BUG-9201: bump maven-enforcer-plugin to 3.0.0-M1
This is required for building with Java 9. Release notes are at:
http://maven.40175.n5.nabble.com/ANN-Apache-Maven-Enforcer-Plugin-3-0-0-M1-Released-td5911744.html
Change-Id: I4b32b3703efea41aed8e3e685896c8fcbd13b4f9
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
Robert Varga [Wed, 18 Oct 2017 11:56:13 +0000 (13:56 +0200)]
BUG-9200: upgrade maven-shade-plugin
Version 3.1.0 is required for Java 9, release notes at:
https://mail-archives.apache.org/mod_mbox/maven-announce/201708.mbox/raw/%3Cop.y5d393zfkdkhrr%40desktop-2khsk44.dynamic.ziggo.nl%3E/
Change-Id: I5892cba22d1f50708b219aaee35be5ed2af2d2ec
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
Robert Varga [Wed, 18 Oct 2017 11:49:28 +0000 (13:49 +0200)]
BUG-9200: update failsafe/surefire plugin version
Version 2.20.1 is required to support Java 9, changelogs are at
https://mail-archives.apache.org/mod_mbox/maven-announce/201709.mbox/%3CCAKuVzBTt6gPWkjDS7AcLBKj7C1i9C7CgjRa3s0mQ0S-P%3D3CiiQ%40mail.gmail.com%3E
Change-Id: I08c48631b3ddcec3d36476e759d16f49a1c0a70f
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
Stephen Kitt [Mon, 23 Oct 2017 08:17:57 +0000 (10:17 +0200)]
Bump commons-codec 1.10 → 1.11
Release notes: http://www.apache.org/dist/commons/codec/RELEASE-NOTES.txt
Change-Id: I402e984c90e9f59b65c06244a8bade3e2156db6c
Signed-off-by: Stephen Kitt <skitt@redhat.com>
Thanh Ha [Mon, 30 Oct 2017 20:45:42 +0000 (16:45 -0400)]
Remove deploy-site.xml
With the javadoc jobs now available to generate javadoc it is time to
remove the maven-sites and related files.
Change-Id: If751fe5cf6c4b122063699f4ac234c25fc8daffb
Signed-off-by: Thanh Ha <thanh.ha@linuxfoundation.org>
Michael Vorburger [Mon, 30 Oct 2017 18:22:16 +0000 (19:22 +0100)]
Switch bundles4-test from FindBugs to SpotBug
Change-Id: I4d4a92d3800a1b23705f8cac3d24c44dfcc01950
Signed-off-by: Michael Vorburger <vorburger@redhat.com>
Stephen Kitt [Wed, 11 Oct 2017 02:28:08 +0000 (19:28 -0700)]
Add SpotBugs dependencies
SpotBugs is the maintained replacement for FindBugs, which has been
abandoned. See https://spotbugs.github.io/ for details.
This patch is phase 1 of the (long-term) migration from FindBugs to
SpotBugs: it adds the spotbugs-maven-plugin to plugin management with
the appropriate version specifications and default configuration.
Change-Id: I29a47604bdd25a20dc0fe56f41cd0083ad934e13
Signed-off-by: Stephen Kitt <skitt@redhat.com>
Robert Varga [Wed, 18 Oct 2017 14:47:28 +0000 (16:47 +0200)]
Bump Guava to 23.2-jre
https://github.com/google/guava/releases/tag/v23.1
https://github.com/google/guava/releases/tag/v23.2
Change-Id: I6c9992ad6caf1810359a79203038aaf79a5c8eb5
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
Stephen Kitt [Wed, 18 Oct 2017 11:50:57 +0000 (13:50 +0200)]
Exclude jsr305 from guava-testlib
... in the same way as for guava itself. Otherwise our own enforcer
fails builds...
Change-Id: Ibecbbf48c9045c290d439f3666f01fde519b842f
Signed-off-by: Stephen Kitt <skitt@redhat.com>
Stephen Kitt [Mon, 16 Oct 2017 07:53:35 +0000 (09:53 +0200)]
Bump pax-url 2.5.2 → 2.5.3
Release notes:
https://ops4j1.jira.com/browse/PAXURL-345?jql=project%20%3D%20PAXURL%20AND%20fixVersion%20%3D%202.5.3
(in particular, this addresses CVE-2015-5262).
Change-Id: I2c7bfdb9139ae15573fc9d92f47d28a14ef0e345
Signed-off-by: Stephen Kitt <skitt@redhat.com>
Robert Varga [Tue, 10 Oct 2017 08:38:43 +0000 (10:38 +0200)]
Bump netty to 4.1.16
http://netty.io/news/2017/09/25/4-0-52-Final-4-1-16-Final.html
Change-Id: I327ac3968dd3421a20f514a70a25002f7aebfbd5
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
Robert Varga [Tue, 10 Oct 2017 08:09:52 +0000 (10:09 +0200)]
Bump reactive-streams to 1.0.1
No changes, just clarifications according to
http://www.reactive-streams.org/announce-1.0.1
Change-Id: I9932ef2ede27cce4bae61ab7332c3f5746e2e27e
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
Ryan Goulding [Fri, 29 Sep 2017 18:16:04 +0000 (14:16 -0400)]
Bug 9229: Bump bouncycastle from 1.57 to 1.58
Release notes can be found here:
https://www.bouncycastle.org/releasenotes.html
Change-Id: Ie686001b8f02a08ee9f94a8e34c8079a8222366d
Signed-off-by: Ryan Goulding <ryandgoulding@gmail.com>
Michael Vorburger [Fri, 29 Sep 2017 04:12:28 +0000 (06:12 +0200)]
Bug 9169: Bump jdt.annotation from 2.0.0 to 2.1.0
Most importantly, this introduces a handy util for legacy interop
org.eclipse.jdt.annotation.Checks; see its JavaDoc on:
https://help.eclipse.org/neon/index.jsp?topic=%2Forg.eclipse.jdt.doc.isv%2Freference%2Fapi%2Forg%2Feclipse%2Fjdt%2Fannotation%2FChecks.html
Full git change log with more details available on
https://gist.github.com/vorburger/
0479be76f9cd3d10aa5ef86d4034a090
I'm starting to explore using org.eclipse.jdt.annotation more, and want
to have its latest version at my disposal for this. This is part of
https://git.opendaylight.org/gerrit/#/c/47370/ but that's bigger and
still WIP and it would be great if you would agree to get this one in
already now.
This should be very low risk and not break anything anywhere.
Change-Id: Ib1f6389cc0929e08d1585efc7bdc5e75097a3544
Signed-off-by: Michael Vorburger <vorburger@redhat.com>
Michael Vorburger [Thu, 28 Sep 2017 23:37:28 +0000 (01:37 +0200)]
Bump maven-compiler-plugin from 3.6.1 to 3.7.0
This also removes a number of uses of the
maven-compiler-plugin and maven-surefire-plugin
from project with odlparent-lite as parent, which
should not require these two plugins.
Change-Id: Iec5ad374633903cdcda6344eb736ec337f727a1d
Signed-off-by: Michael Vorburger <vorburger@redhat.com>
Ryan Goulding [Fri, 29 Sep 2017 18:09:58 +0000 (14:09 -0400)]
Bug 9228: Package bcprov-ext-jdk15on jar
Bouncycastle is hotwired as the default JCE provider in ODL
since it has greater capabilities than those provided with
the default Oracle and OpenJDK JCE implementations. This
change adds an overlooked and missing jar to the existing
provider infra.
Change-Id: I16cdab1d838285b3d690c61ae9fb3586e8cc69d3
Signed-off-by: Ryan Goulding <ryandgoulding@gmail.com>
Michael Vorburger [Thu, 28 Sep 2017 23:32:56 +0000 (01:32 +0200)]
Bump maven-dependency-plugin from 3.0.1 to 3.0.2
Change-Id: Ib3d7831d2c62bbd1d8b5da1302454f6793c4b554
Signed-off-by: Michael Vorburger <vorburger@redhat.com>
Robert Varga [Mon, 25 Sep 2017 10:12:36 +0000 (12:12 +0200)]
BUG-9161: Bump karaf to 4.0.10
Upstream has delivered a speed up in initial repository indexing
and couple of other fixes. Bump karaf version to consume them.
Release notes:
https://github.com/apache/karaf/commit/
a16c3b095a6f17fb3641c98cbe56b7e9f69418c5
Change-Id: I1a632c51e8af62802473afb3d314743f5ca31cfc
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
(cherry picked from commit
b0e04a0c274d86ea3dbbd71f85ec148c383458f2)
Michael Vorburger [Mon, 11 Sep 2017 14:45:46 +0000 (16:45 +0200)]
maven-archetype-plugin pluginManagement
The new version property introduced here will be used in controller.
Change-Id: Idf0859ee1be990c130735ca93dabf2e7557703a7
Signed-off-by: Michael Vorburger <vorburger@redhat.com>
Michael Vorburger [Tue, 19 Sep 2017 17:12:21 +0000 (19:12 +0200)]
Bump Checkstyle core from 7.6.1 to 8.2
and Sevntu from 1.21.0 to 1.24.2 (note the required change in groupId)
also includes removal of LeftCurly.maxLineLength = 100, which is not
supported (anymore; or -more likely- never was, probably the validation
just became stricter)
and removal of a duplicate RightCurly, which was always wrong
and required fixes to odlparent Java code showing violations now
Change-Id: I3efc1d2e97c87a9c072b3fe097cf388f5a457cf5
Signed-off-by: Michael Vorburger <vorburger@redhat.com>
Robert Varga [Tue, 19 Sep 2017 08:56:52 +0000 (10:56 +0200)]
Eliminate scala.version and scala.micro.version
These properties are interfering with scala-maven-plugin, which is
using scala.version to control target versions.
Change-Id: I501cd941b35f2c0ca738209ca2db1c722743b2e8
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
Robert Varga [Thu, 7 Sep 2017 12:52:36 +0000 (14:52 +0200)]
Bump akka to 2.5.4
http://akka.io/blog/news/2017/08/10/akka-2.5.4-released
Change-Id: Ib22206bdaf1c0aa4a218d33ecf8335f718868bc7
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
Robert Varga [Thu, 7 Sep 2017 12:49:46 +0000 (14:49 +0200)]
Bump netty to 4.1.15
http://netty.io/news/2017/08/25/4-0-51-Final-4-1-15-Final.html
Change-Id: Icc6415af8d73ab22f75fceb9f7d3fd574d3ebd0a
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
Robert Varga [Mon, 14 Aug 2017 13:29:22 +0000 (15:29 +0200)]
Add net.sf.jung dependency declaration
Downstreams are using an old revision backaged from controller,
which is completely out-dated. Add a dependency declaration and
a proper feature.
Change-Id: I77b1e42aa8a21d94f96a967c0c21af497a65f18e
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
Michael Vorburger [Tue, 22 Aug 2017 10:42:17 +0000 (12:42 +0200)]
Checkstyle AvoidHidingCauseExceptionCheck
http://sevntu-checkstyle.github.io/sevntu.checkstyle/apidocs/com/github/sevntu/checkstyle/checks/coding/AvoidHidingCauseExceptionCheck.html
Change-Id: I37d22c88869911f26daad023d66c5559a3cd1fa8
Signed-off-by: Michael Vorburger <vorburger@redhat.com>
Michael Vorburger [Mon, 8 Aug 2016 14:27:02 +0000 (16:27 +0200)]
CS new FinalClass & HideUtilityClassConstructor
* http://checkstyle.sourceforge.net/config_design.html#FinalClass
* http://checkstyle.sourceforge.net/config_design.html#HideUtilityClassConstructor
Change-Id: I4ab4d4550c2bba4e25a19cae7a0c20aa1241757e
Signed-off-by: Michael Vorburger <vorburger@redhat.com>
Michael Vorburger [Mon, 23 Jan 2017 20:27:05 +0000 (21:27 +0100)]
Remove & forbid mockito-all + findbugs:jsr305
via the maven-enforcer-plugin
as all projects should only use findbugs:annotations, to avoid duplicate
classpath entries from FindBugs annotations which are present in both
:jsr305 as well as :annotations (which is more recent, bigger, and
maintained)
https://git.opendaylight.org/gerrit/#/q/topic:bug/7663, which replaces
all current existing usages of findbugs:jsr305 by :annotations in ODL
project, is the 1st pre-req. to this change.
https://git.opendaylight.org/gerrit/#/c/47337/, which changes the
dependencyManagement re. FindBugs, is the 2nd pre-req. to this change.
Related to Bug 7663 & Bug 7662.
Change-Id: Ifcd9c833af37fe52182dbc8604978fb82cdbcba7
Signed-off-by: Michael Vorburger <vorburger@redhat.com>
Michael Vorburger [Tue, 29 Aug 2017 10:18:55 +0000 (12:18 +0200)]
Add karaf.shell.core dependencyManagement
see also https://github.com/apache/karaf/pull/338
Change-Id: Ia1e732dfe5b83b5795bf022d8bdd89417f0c0d62
Signed-off-by: Michael Vorburger <vorburger@redhat.com>
Robert Varga [Thu, 9 Feb 2017 17:04:47 +0000 (18:04 +0100)]
BUG-7767: Bump servlet-api to 3.1.0
This reverts commit
63c56783199d6fba319fc92373c1714dc8816d8e,
reinstating servlet-api 3.1.0. Also bump H2, which breaks unless
upgraded.
Change-Id: Icb141c95812b2d30a6a23801386a8e931c34b5be
Signed-off-by: Robert Varga <rovarga@cisco.com>
Robert Varga [Mon, 14 Aug 2017 14:20:21 +0000 (16:20 +0200)]
Bump guava to 23.0
https://github.com/google/guava/wiki/Release23
Change-Id: I1efaea3a901f93e4a95aabf13b7dacd4f544aad9
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
Robert Varga [Sun, 13 Aug 2017 18:40:09 +0000 (20:40 +0200)]
Upgrade jolokia to 1.3.7
https://github.com/rhuss/jolokia/releases/tag/v1.3.7
Change-Id: I6a1174ba6a9621b66d495d92d87f05a4e75d0083
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
Robert Varga [Sun, 13 Aug 2017 18:36:03 +0000 (20:36 +0200)]
Bump jettison to 1.3.8
https://github.com/jettison-json/jettison/compare/jettison-1.3.7...jettison-1.3.8
Change-Id: Ie1f260e7673d10822c1cc1f43eba32775f8810c9
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
Robert Varga [Mon, 14 Aug 2017 09:08:43 +0000 (11:08 +0200)]
Remove equinoxSDK381 artifact declarations
These should not be used anywhere, the only downstream of these
is openflowplugin, which does not really need it.
Change-Id: I0c06aa5a951af78002a9e17545f610fe96d58589
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
Stephen Kitt [Mon, 24 Oct 2016 15:53:46 +0000 (17:53 +0200)]
Bump maven-bundle-plugin 2.4.0/3.0.1 -> 3.3.0
Change-Id: I4f4909f69f57fcdfbe703a91251fd2c038d777ab
Signed-off-by: Stephen Kitt <skitt@redhat.com>
Stephen Kitt [Fri, 16 Jun 2017 12:09:03 +0000 (14:09 +0200)]
Bump depends-maven-plugin 1.3.1 → 1.4.0
Change-Id: I72ecfa4178042ce7bf994f717edad1e32a70823f
Signed-off-by: Stephen Kitt <skitt@redhat.com>
Vratko Polak [Thu, 10 Aug 2017 16:18:36 +0000 (18:18 +0200)]
Configurable path to place SFT heap dumps
Change-Id: Ib9e56f9147f972b4b28db2e7db7426402adb220e
Signed-off-by: Vratko Polak <vrpolak@cisco.com>
(cherry picked from commit
3b3dc36e0af2d848a044f2a5841e10fcb3258e20)
Vratko Polak [Mon, 7 Aug 2017 10:11:15 +0000 (12:11 +0200)]
Make SingleFeatureTest max heap size configurable
Currently, CSIT jobs of -only- type use 2GB of heap and CSIT
of -all- type use 3GB. But we are seeing occasional failures
in distribution, especially odl-integration-all feature can take
more heap than usual.
Address the TODO item by allowing maximum heap size to be specified
as a system property -- thus can be overridden by downstreams in
their pom.xml.
Change-Id: I84adda01f3bd20180c6d81d3da807d38b5af6fa1
Signed-off-by: Vratko Polak <vrpolak@cisco.com>
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
(cherry picked from commit
1aa0ac18166b3183e7733b50612f9706efa3c8b9)
Michael Vorburger [Thu, 10 Aug 2017 11:39:39 +0000 (17:09 +0530)]
Move karaf-util dependency
from bundles-test to features-test
The new karaf-util artifact introduced in
https://git.opendaylight.org/gerrit/#/c/61293/ should not be a
dependency of bundles-test but rather of features-test IMHO.
This is because bundles-test actually not have a compile time dependency
to the CustomBundleUrlStreamHandlerFactory from karaf-util; only
features-test (in PerRepoTestRunner).
However, bundles-test is also used in infrautils' ready. Bumping to
odlparent 2.0.4 (which includes this) fell over with "...
odl-infrautils-ready ... Unable to resolve
org.opendaylight.odlparent.karaf-util...", because of the
<Embed-Dependency>bundles-test-lib in ready-impl.
We could add karaf-util to the <Embed-Dependency> of ready-impl to work
around this, at least temporarily to unblock, but the root cause is that
the dependency is wrong.
Change-Id: I031fbbc8fb9d8eebba3550ef0683b8363397d8a8
Signed-off-by: Michael Vorburger <vorburger@redhat.com>
Robert Varga [Wed, 9 Aug 2017 18:49:18 +0000 (20:49 +0200)]
Bump netty to 4.1.14
http://netty.io/news/2017/08/03/4-0-50-Final-4-1-14-Final.html
Change-Id: Iff5310e47cfbfd4e12bb33ac38cebc1fe6c20ccc
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
Robert Varga [Thu, 10 Aug 2017 08:59:02 +0000 (10:59 +0200)]
Eliminate triemap declaration
Triemap is forked and delivered in yangtools, this was a private
stop-gap build.
Change-Id: Ife6f1b29e28d7fea2e80b49dc6670d92458d3240
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
Robert Varga [Thu, 10 Aug 2017 09:02:35 +0000 (11:02 +0200)]
Bump scala to 2.12.3
http://scala-lang.org/news/2.12.3
Change-Id: I39b18bd3abbd8aeaa6693f098599f9362cfe0023
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
Robert Varga [Wed, 9 Aug 2017 15:09:30 +0000 (17:09 +0200)]
Remove opendaylight-karaf-empty scope=provided
Having a scope=provided breaks features-test, as it fails to
pull in its required resources, leading to SFT failure.
Change-Id: I1203f224f72f0678c7ccab976d4eb1ae530bc774
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
(cherry picked from commit
3e11458209eee6a61cc9837928a016e82bab8866)
Robert Varga [Mon, 7 Aug 2017 14:20:48 +0000 (16:20 +0200)]
BUG-8923: use karaf-empty for SFT
Since we are excluding bouncy castle from generated features (and
we want to assume it is installed), we cannot run SFT against
vanilla karaf. This patch adjusts features-test to pull in our
pre-build opendaylight-karaf-empty instead of vanilla upstream.
Change-Id: Ic45ff713e90c0be7c232e0a1cee36b27c83efe95
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
(cherry picked from commit
70f33da04cfdd2e9ddea9a322da5e0b9f6610106)
Robert Varga [Mon, 7 Aug 2017 15:32:48 +0000 (17:32 +0200)]
BUG-8923: create karaf-util
We need to use opendaylight-karaf-empty for SFT, but doing so
directly leads to a circular dependency, as karaf-plugin needs
sft (which needs karaf-empty, which needs karaf-plugin).
Resolve the dependency cycle by breaking out the single class
karaf-plugin requires into a separate artifact.
Change-Id: Id0649dd8203087ed82c1b936428cb6d9295f2957
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
(cherry picked from commit
5d3c00c2b98de5ebb4a7eda6e5cc0734c86b74f8)
Stephen Kitt [Fri, 4 Aug 2017 16:39:51 +0000 (18:39 +0200)]
BUG-8923: Bouncy Castle is provided
We need to exclude the Bouncy Castle artifacts from generated feature
descriptors, since they’re provided in our startup configuration.
Change-Id: I26814b09efa37d12c1e567e5622f509eea9241be
Signed-off-by: Stephen Kitt <skitt@redhat.com>
(cherry picked from commit
580bee99d255788f8e0f879075b8a12cb92c607f)
Robert Varga [Fri, 4 Aug 2017 14:08:28 +0000 (16:08 +0200)]
BUG-8923: package javassist in a feature
Javassist is an optional dependency to netty and is required by
binding mdsal. This can lead to re-wires when mdsal is pulled in
after anything using odl-netty-4 is installed.
Change-Id: Ia5135dfd27dd6227d9897d1a2ab24e0078673d8c
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
(cherry picked from commit
e1b90dbbcdf55251192c2bf5b34c5a6f61e58590)
Stephen Kitt [Fri, 4 Aug 2017 09:08:01 +0000 (11:08 +0200)]
Fix tagGz property
karaf.archiveTagGz should be karaf.archiveTarGz, as used in the plugin
configuration.
Change-Id: I7173180a0e602867bd6a9c5b9fe1ac41a0a4ab6a
Signed-off-by: Stephen Kitt <skitt@redhat.com>
Robert Varga [Mon, 31 Jul 2017 01:11:40 +0000 (03:11 +0200)]
Bump immutables to 2.5.6
General house-keeping to keep us uptodate.
Change-Id: Ic8ce978f8274701677997ac2987ec483816d7842
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
Robert Varga [Thu, 3 Aug 2017 09:15:28 +0000 (11:15 +0200)]
Add commons-text declaration
commons-lang3's WordUtils is deprecated in favor of commons-text
version. Downstreams should be able to migrate without having to
deal with versions.
Change-Id: I592f92b79372a21a8ada3225d05bed410a00363b
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
Robert Varga [Sun, 14 May 2017 22:18:52 +0000 (00:18 +0200)]
Bump javassist to 3.21.0GA
https://github.com/jboss-javassist/javassist/compare/rel_3_20_0_ga...rel_3_21_0_ga
Change-Id: I56af3a4a7ecacd919300e5c2a0332e749b1ed708
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
Robert Varga [Wed, 19 Jul 2017 12:30:36 +0000 (14:30 +0200)]
Bump akka to 2.5.3
http://akka.io/blog/news/2017/04/13/akka-2.5.0-released
http://akka.io/blog/news/2017/05/02/akka-2.5.1-released
http://akka.io/blog/news/2017/05/24/akka-2.5.2-released
http://akka.io/blog/news/2017/06/19/akka-2.5.3-released
Also leaks sun.net from the JDK, as it is required now :(
Change-Id: I65ab6b1a2024084281774cfb17ea1bdd54cd1848
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
Robert Varga [Sat, 29 Jul 2017 12:25:55 +0000 (14:25 +0200)]
Bump jackson to 2.8.9
Version 2.3.2 is really ancient, bump it to 2.8.9.
Change-Id: I92b5aa15c49fe0742f0069a88328e700d2e04f82
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
Robert Varga [Sat, 29 Jul 2017 12:24:05 +0000 (14:24 +0200)]
Add stax2-api declaration to match jackson
stax2-api is useful for others even without a provider, but
we cannot use 4.0.0 (as we'd like) because jackson has not upgraded
to it.
Change-Id: I69c15a360c2624fb842d4512accad67769de5d1d
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
David Suarez [Sun, 23 Jul 2017 12:01:22 +0000 (14:01 +0200)]
Add Javadoc links for third parties
Add some links for third party libraries declared as dependencies in
odlparent-lite so that those links are automatically added to the Maven
javadoc:aggregate or javadoc:javadoc goals. The list is not
comprehensive, it is just an starting point to continue adding more
links.
The projects/modules/aggregators referencing odlparent-lite will inherit
these links.
The <detectLinks> flag is set to false until [1] is resolved.
[1] https://issues.apache.org/jira/browse/MJAVADOC-427
Change-Id: I56a6eabe0ba7b9f32ffed7748ab13a79aa6bc2e1
Signed-off-by: David Suarez <david.suarez.fuentes@gmail.com>
Stephen Kitt [Fri, 28 Jul 2017 07:59:26 +0000 (07:59 +0000)]
Revert "Add an origin ID from the MDC into ..."
"... Karaf logs" until we agree on terminology etc.
This reverts commit
03609ff917ea5a187664614252a3e777108cb2ab.
Change-Id: I947fb2e44622f33e71614a66cf2ded816a61b26c
Signed-off-by: Stephen Kitt <skitt@redhat.com>
Michael Vorburger [Thu, 27 Jul 2017 18:31:37 +0000 (00:01 +0530)]
Remove logback.xml
as well as the reference to it in etc/custom.properties
as discussed on https://lists.opendaylight.org/pipermail/odlparent-dev/2017-July/001262.html
Change-Id: I4423d3950e3d5f23be6d59423ef8b39abd0866a8
Signed-off-by: Michael Vorburger <vorburger@redhat.com>
Michael Vorburger [Thu, 27 Jul 2017 17:52:04 +0000 (23:22 +0530)]
Add an origin ID from the MDC into Karaf logs
see https://git.opendaylight.org/gerrit/#/q/topic:mdc related changes
and read https://logback.qos.ch/manual/mdc.html
or https://logging.apache.org/log4j/2.x/manual/thread-context.html
This change will show the OID in all logs, for example like this:
2017-07-27 23:14:16,034 | WARN |
0000000000000 | ion(1)-127.0.0.1 |
InfrautilsIT | 93 -
PAXEXAM-PROBE-
41ce6a29-abaf-44c0-8044-
71d3e2bf99da - 0.0.0 | Ho, ho - do
you also see this funky Origin ID at the <== start of this log message:
0000000000000
If there is no originID available, then the new column will just be 13
empty spaces (for correct padding, like all other columns in the log),
like this:
2017-07-27 23:14:16,554 | ERROR | | 0e6-
c784b3cb4f5b |
core | 6 - org.apache.karaf.features.core -
4.0.9 | FrameworkEvent ERROR - org.apache.karaf.features.core
Change-Id: If18e1d35d71da5bd5c0fee5f2212915cccb0992e
Signed-off-by: Michael Vorburger <vorburger@redhat.com>
Robert Varga [Wed, 19 Jul 2017 12:21:46 +0000 (14:21 +0200)]
BUG-7464: do not package upstream triemap
yangtools carries a reworked fork with a large number of bugfixes
and it is no longer using upstream. Remove odl-triemap, letting
downstreams consume the yangtools fork.
Change-Id: I5c04c5bed193594a57d4845f857ab62637b70ce4
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
Robert Varga [Wed, 19 Jul 2017 12:20:32 +0000 (14:20 +0200)]
Bump versions to 3.0.0-SNAPSHOT
We are making backwards-incompatible changes, hence we need to bump
major version.
Change-Id: I1bbd7d55f3a4f1a8cb31e03be9e9215a7bbca4dd
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
Stephen Kitt [Tue, 18 Jul 2017 16:33:47 +0000 (18:33 +0200)]
Bug 8771: add bcpkix to the startup bundles
This will avoid bundle refreshes due to wiring in bcpkix.
Change-Id: Ia7ceb119d96c8ffa642e3d427e3357c2b7e750d3
Signed-off-by: Stephen Kitt <skitt@redhat.com>
Robert Varga [Sat, 15 Jul 2017 22:39:51 +0000 (00:39 +0200)]
Bump scala to 2.12.2
This updates scala runtime to 2.12 and adjusts features accordingly.
Change-Id: I1cffaa9c4e7ef2e615d41e125d4d75a377acf537
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
Robert Varga [Mon, 10 Apr 2017 14:01:20 +0000 (16:01 +0200)]
Bump netty to 4.1.13
http://netty.io/news/2017/03/10/4-0-45-Final-4-1-9-Final.html
http://netty.io/news/2017/04/30/4-0-46-Final-4-1-10-Final.html
http://netty.io/news/2017/05/12/4-0-47-Final-4-1-11-Final.html
http://netty.io/news/2017/06/09/4-0-48-Final-4-1-12-Final.html
http://netty.io/news/2017/07/06/4-0-49-Final-4-1-13-Final.html
Change-Id: I950a06bcb8e70f07803912a6d7c2f55eb67a0394
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
Stephen Kitt [Thu, 8 Oct 2015 12:09:13 +0000 (14:09 +0200)]
Upgrade Jacoco Listeners 2.4 -> 3.8
Change-Id: I951403569556ded05380bb65e5e30addb643dc64
Signed-off-by: Stephen Kitt <skitt@redhat.com>
Code Review / odlparent.git / log