integration/packaging/puppet-opendaylight.git
7 years agoRefactor Overview/Description/Affests README sects 34/55534/1
Daniel Farrell [Fri, 24 Apr 2015 21:34:38 +0000 (17:34 -0400)]
Refactor Overview/Description/Affests README sects

Change-Id: Ia01fafb41a59bab149ecd73aeb3933d0959ec9db
Signed-off-by: Daniel Farrell <dfarrell@redhat.com>
7 years agoRefactor metadata.json mod summery for clarity 33/55533/1
Daniel Farrell [Fri, 24 Apr 2015 21:34:05 +0000 (17:34 -0400)]
Refactor metadata.json mod summery for clarity

Change-Id: I395d3e9629609dab04cccf576916809dabe18c73
Signed-off-by: Daniel Farrell <dfarrell@redhat.com>
7 years agoRefactor README class list docs 32/55532/1
Daniel Farrell [Fri, 24 Apr 2015 20:54:01 +0000 (16:54 -0400)]
Refactor README class list docs

* Add top level bit to ODL's class, be explicit
* Reorder list to be same as dependency order
* Relevant to #77

Change-Id: I053124955ccc0b0cfaf71d1cd3333a22dfbcec40
Signed-off-by: Daniel Farrell <dfarrell@redhat.com>
7 years agoReorder README ODL class param docs to ABC order 31/55531/1
Daniel Farrell [Fri, 24 Apr 2015 20:49:54 +0000 (16:49 -0400)]
Reorder README ODL class param docs to ABC order

* Best practice mentioned in http://goo.gl/yLKB9n
* Relevant to #77

Change-Id: Ib3ad45230051fd0191deb603d36bb75c3489814b
Signed-off-by: Daniel Farrell <dfarrell@redhat.com>
7 years agoMake Default and Valid Options docs paragraphs 30/55530/1
Daniel Farrell [Fri, 24 Apr 2015 20:42:36 +0000 (16:42 -0400)]
Make Default and Valid Options docs paragraphs

Difficult to read once rendered in MD otherwise.

Relevant to: #77

Change-Id: Ieb7ead6603f46ab44c645c544b2980c84846a4a3
Signed-off-by: Daniel Farrell <dfarrell@redhat.com>
7 years agoRefactor all ODL class param docs in README 29/55529/1
Daniel Farrell [Fri, 24 Apr 2015 20:40:22 +0000 (16:40 -0400)]
Refactor all ODL class param docs in README

* Major refactoring to attempt to follow best practices
* Relevant to #77
* See: http://goo.gl/JOWf1X

Change-Id: Ic46dbce5b1265a5e3d1be13b2a9f0628062d79b9
Signed-off-by: Daniel Farrell <dfarrell@redhat.com>
7 years agoChange contrib docs link to use new MD extension 28/55528/1
Daniel Farrell [Fri, 24 Apr 2015 18:28:37 +0000 (14:28 -0400)]
Change contrib docs link to use new MD extension

* Relevant to #77

Change-Id: I1798323eef0fd7d87994021ebd642bca8db9aa8d
Signed-off-by: Daniel Farrell <dfarrell@redhat.com>
7 years agoRemove incorrect param docs from config class 27/55527/1
Daniel Farrell [Fri, 24 Apr 2015 18:20:16 +0000 (14:20 -0400)]
Remove incorrect param docs from config class

Change-Id: I986ecb76df91f9754bf263cc8a842a017304ab42
Signed-off-by: Daniel Farrell <dfarrell@redhat.com>
7 years agoRemove sub-sections of Reference README index sec 26/55526/1
Daniel Farrell [Fri, 24 Apr 2015 18:19:27 +0000 (14:19 -0400)]
Remove sub-sections of Reference README index sec

* Too many too include all, so include none
* Relevant to #77

Change-Id: I9dabc05a1991c0506336ae5716e07f1d9d4b616c
Signed-off-by: Daniel Farrell <dfarrell@redhat.com>
7 years agoAdd README docs about ODL class params 25/55525/1
Daniel Farrell [Fri, 24 Apr 2015 18:18:00 +0000 (14:18 -0400)]
Add README docs about ODL class params

* Suggested by Puppet's best practice docs
* Relevant to #77

Change-Id: Icb0158d5b8227326b2a693249d4c3ba6b473d062
Signed-off-by: Daniel Farrell <dfarrell@redhat.com>
7 years agoAdd links to release tags and commits in README 24/55524/1
Daniel Farrell [Fri, 24 Apr 2015 17:48:00 +0000 (13:48 -0400)]
Add links to release tags and commits in README

* Relevant to #77

Change-Id: I34eb58d760f25cbfa7c5777fec0aec20676d27d9
Signed-off-by: Daniel Farrell <dfarrell@redhat.com>
7 years agoAdd docs on destroying Beaker Vagrant boxes 23/55523/1
Daniel Farrell [Fri, 24 Apr 2015 17:43:04 +0000 (13:43 -0400)]
Add docs on destroying Beaker Vagrant boxes

* Also a minor typo fix in same docs

Change-Id: Idf2b1ce791d6c070d597588725385cbf916e0eff
Signed-off-by: Daniel Farrell <dfarrell@redhat.com>
7 years agoRefactor Beginning with ODL README section 22/55522/1
Daniel Farrell [Fri, 24 Apr 2015 17:34:10 +0000 (13:34 -0400)]
Refactor Beginning with ODL README section

* Add more vagrant-opendaylight info
* Clarity refactoring
* Relevant to #77

Change-Id: I2b51e2e8f8c20951a5c90952a0f1c22dad325aa5
Signed-off-by: Daniel Farrell <dfarrell@redhat.com>
7 years agoAdd syntax highlighting hint to README examples 21/55521/1
Daniel Farrell [Fri, 24 Apr 2015 17:12:25 +0000 (13:12 -0400)]
Add syntax highlighting hint to README examples

* Relevant to #77

Change-Id: I9008c29851521aa6f63309f69a37acb9476295e8
Signed-off-by: Daniel Farrell <dfarrell@redhat.com>
7 years agoFix indentation style issue in README example code 20/55520/1
Daniel Farrell [Fri, 24 Apr 2015 17:10:38 +0000 (13:10 -0400)]
Fix indentation style issue in README example code

* Relevant to #77

Change-Id: I9dc556dad5a8d24b06c93f26c0c8e8f6d093e0a6
Signed-off-by: Daniel Farrell <dfarrell@redhat.com>
7 years agoRefactor usage/getting started sections of README 19/55519/1
Daniel Farrell [Fri, 24 Apr 2015 17:10:04 +0000 (13:10 -0400)]
Refactor usage/getting started sections of README

* Relevant to #77

Change-Id: I1b316cf524de551da511b4daad660ff05c4630c7
Signed-off-by: Daniel Farrell <dfarrell@redhat.com>
7 years agoRefactor README's table of contents 18/55518/1
Daniel Farrell [Fri, 24 Apr 2015 16:52:40 +0000 (12:52 -0400)]
Refactor README's table of contents

* Use two-space indents, per GitHub docs
* Add indexes to Reference sub-sections
* Relevant to #77

Change-Id: I466759e14231732759a87a3b1fb05f395aa88d0b
Signed-off-by: Daniel Farrell <dfarrell@redhat.com>
7 years agoRemove MD ShellSession syntax highlight hint 17/55517/1
Daniel Farrell [Fri, 24 Apr 2015 16:39:23 +0000 (12:39 -0400)]
Remove MD ShellSession syntax highlight hint

* Doesn't seem to actually work well for shell output
* Relevant to #64

Change-Id: If055d8d2d2055f9b25275166ad7481f264783343
Signed-off-by: Daniel Farrell <dfarrell@redhat.com>
7 years agoAdd docs about connecting to Beaker Vagrant box 16/55516/1
Daniel Farrell [Fri, 24 Apr 2015 16:38:03 +0000 (12:38 -0400)]
Add docs about connecting to Beaker Vagrant box

* Relevant to #64

Change-Id: Ia24b070ba80feb0510fa47457baea1197824e2ee
Signed-off-by: Daniel Farrell <dfarrell@redhat.com>
7 years agoFollow ODL tradition by including a cookie ref 15/55515/1
Daniel Farrell [Fri, 24 Apr 2015 16:21:33 +0000 (12:21 -0400)]
Follow ODL tradition by including a cookie ref

Change-Id: I502e73216eb81d78cdf5f910dd5058ffeb780107
Signed-off-by: Daniel Farrell <dfarrell@redhat.com>
7 years agoCorrect case of BEAKER_destroy var in contrib docs 14/55514/1
Daniel Farrell [Fri, 24 Apr 2015 16:15:52 +0000 (12:15 -0400)]
Correct case of BEAKER_destroy var in contrib docs

Change-Id: Idf9668df5d416735c9bcaa1e7119faa13ea4682a
Signed-off-by: Daniel Farrell <dfarrell@redhat.com>
7 years agoAdd link to recommended git commit msg style 13/55513/1
Daniel Farrell [Fri, 24 Apr 2015 16:13:26 +0000 (12:13 -0400)]
Add link to recommended git commit msg style

Change-Id: I0b15456af6b07f5a23b804f9753168919650dd79
Signed-off-by: Daniel Farrell <dfarrell@redhat.com>
7 years agoRefactor README, mainly ToC updates 12/55512/1
Daniel Farrell [Fri, 24 Apr 2015 15:57:11 +0000 (11:57 -0400)]
Refactor README, mainly ToC updates

* Major update to table of contents, remove template artifacts
* Removed note about systemd config as we also have Upstart config
* Minor link addition
* Added recommended module name H1 section

Change-Id: I783cae19be22c29bbcd2354b4df63c948577a877
Signed-off-by: Daniel Farrell <dfarrell@redhat.com>
7 years agoMinor updates to contrib docs, communication sec 11/55511/1
Daniel Farrell [Fri, 24 Apr 2015 15:40:55 +0000 (11:40 -0400)]
Minor updates to contrib docs, communication sec

* Corrected sentence flagged as confusing during peer review
* Trivial capitalization fix
* The CONTRIBUTING.markdown docs seem to be in good shape
* Closes #64

Change-Id: Icc09bdabcd6c4b492a61b654c8e77aad80f1afd5
Signed-off-by: Daniel Farrell <dfarrell@redhat.com>
7 years agoUpdate contrib docs index with CI section 10/55510/1
Daniel Farrell [Fri, 24 Apr 2015 15:16:09 +0000 (11:16 -0400)]
Update contrib docs index with CI section

* Relevant to #64

Change-Id: I931375369cb1474596a9f444849f9a92f692c38d
Signed-off-by: Daniel Farrell <dfarrell@redhat.com>
7 years agoAdd info about tests in CI to contrib docs 09/55509/1
Daniel Farrell [Fri, 24 Apr 2015 15:14:50 +0000 (11:14 -0400)]
Add info about tests in CI to contrib docs

Change-Id: I5b043f2a740ddd3feb26147e5adb770e45594a7f
Signed-off-by: Daniel Farrell <dfarrell@redhat.com>
7 years agoMinor cleanup of Beaker docs for clarity 08/55508/1
Daniel Farrell [Fri, 24 Apr 2015 15:04:02 +0000 (11:04 -0400)]
Minor cleanup of Beaker docs for clarity

* Relevant to #64

Change-Id: Ibd0f03166253a10af657d2a581aafbf2832ad49b
Signed-off-by: Daniel Farrell <dfarrell@redhat.com>
7 years agoMinor updates to Issues section of contrib docs 07/55507/1
Daniel Farrell [Fri, 24 Apr 2015 14:57:25 +0000 (10:57 -0400)]
Minor updates to Issues section of contrib docs

Change-Id: I7a3e9b3bf9976eb92d5c8a28155c94e9b1d1e478
Signed-off-by: Daniel Farrell <dfarrell@redhat.com>
7 years agoMinor updates to contributing docs 06/55506/1
Daniel Farrell [Fri, 24 Apr 2015 14:48:34 +0000 (10:48 -0400)]
Minor updates to contributing docs

* Update index for new section headers
* Relevant to #64

Change-Id: Ieda33f7a2d17814a6eeaf9311b61f8b75d4813c3
Signed-off-by: Daniel Farrell <dfarrell@redhat.com>
7 years agoMajor refactoring of testing contributing docs 05/55505/1
Daniel Farrell [Fri, 24 Apr 2015 14:40:35 +0000 (10:40 -0400)]
Major refactoring of testing contributing docs

* Re-write of all sections (deps, style, unit, system)
* Relevant to #64

Change-Id: I4e352f1ff0adb22d3c51dcf7fcbe1d3162128af0
Signed-off-by: Daniel Farrell <dfarrell@redhat.com>
7 years agoMinor spelling fixes in README 04/55504/1
Daniel Farrell [Fri, 24 Apr 2015 05:21:00 +0000 (01:21 -0400)]
Minor spelling fixes in README

* Relevant to #77

Change-Id: I9660d63dd3fc6b3274bba20c69f45b485940c381
Signed-off-by: Daniel Farrell <dfarrell@redhat.com>
7 years agoAdd README docs on failing F21 Beaker tests 03/55503/1
Daniel Farrell [Fri, 24 Apr 2015 05:11:52 +0000 (01:11 -0400)]
Add README docs on failing F21 Beaker tests

* Likely an issue with Vagrant image, not Puppet mod
* Relevant to issue #63

Change-Id: I7bee26a047c58044cec0d18d79df9a3a5104871b
Signed-off-by: Daniel Farrell <dfarrell@redhat.com>
7 years agoRemove ref to removed contributors file in README 02/55502/1
Daniel Farrell [Fri, 24 Apr 2015 05:09:20 +0000 (01:09 -0400)]
Remove ref to removed contributors file in README

* Also mentioned git commit history, the real source of truth

Change-Id: If52cd6c15eafc9657e6ddb9b9b5319e40eac1be0
Signed-off-by: Daniel Farrell <dfarrell@redhat.com>
7 years agoRemoved unused, out-of-date contributors list file 01/55501/1
Daniel Farrell [Fri, 24 Apr 2015 05:06:31 +0000 (01:06 -0400)]
Removed unused, out-of-date contributors list file

* Just use Git commit history

Change-Id: Ie58c352ae29aad7254eba4f4a45adfed542be0d3
Signed-off-by: Daniel Farrell <dfarrell@redhat.com>
7 years agoUpdate index of contributing docs to reality 00/55500/1
Daniel Farrell [Fri, 24 Apr 2015 05:03:20 +0000 (01:03 -0400)]
Update index of contributing docs to reality

Change-Id: Icb4e347f42e351cd56ec946069effab5bc544bde
Signed-off-by: Daniel Farrell <dfarrell@redhat.com>
7 years agoFirst pass at updating testing contributing docs 99/55499/1
Daniel Farrell [Fri, 24 Apr 2015 04:45:21 +0000 (00:45 -0400)]
First pass at updating testing contributing docs

* Mostly just reformatted, removed wrong/old/useless content
* Still needs attention
* Relevant to #64

Change-Id: I457fe86e445b56205002da0cf788a5236177543f
Signed-off-by: Daniel Farrell <dfarrell@redhat.com>
7 years agoRemove unused, unsupported, Guardfile 98/55498/1
Daniel Farrell [Fri, 24 Apr 2015 04:28:42 +0000 (00:28 -0400)]
Remove unused, unsupported, Guardfile

Change-Id: If7f12a64d3df59113c260750697c642f7738415e
Signed-off-by: Daniel Farrell <dfarrell@redhat.com>
7 years agoUpdated PR-related info in contributing docs 97/55497/1
Daniel Farrell [Fri, 24 Apr 2015 02:20:06 +0000 (22:20 -0400)]
Updated PR-related info in contributing docs

Change-Id: I03735a6c069cdbe6a43db376f3fdfb210ad78fed
Signed-off-by: Daniel Farrell <dfarrell@redhat.com>
7 years agoTrivial spelling fix in contrib docs 96/55496/1
Daniel Farrell [Mon, 20 Apr 2015 05:56:15 +0000 (01:56 -0400)]
Trivial spelling fix in contrib docs

Change-Id: Icf5395f08105309bd21b3c77301be4f97f053f95
Signed-off-by: Daniel Farrell <dfarrell@redhat.com>
7 years agoBugfix in some links in contributing docs 95/55495/1
Daniel Farrell [Mon, 20 Apr 2015 05:41:28 +0000 (01:41 -0400)]
Bugfix in some links in contributing docs

* Some docs were copied from my vagrant-odl project

Change-Id: Ibeb9791becbc78232624638458704bca83455307
Signed-off-by: Daniel Farrell <dfarrell@redhat.com>
7 years agoProper Markdown extension for contributing docs 94/55494/1
Daniel Farrell [Tue, 14 Apr 2015 02:43:04 +0000 (22:43 -0400)]
Proper Markdown extension for contributing docs

* The .md extension is used for GCC machine descriptions
* http://superuser.com/questions/249436/file-extension-for-markdown-files

Change-Id: I6225c958173e8a15444d54723f96297b587a9e8d
Signed-off-by: Daniel Farrell <dfarrell@redhat.com>
7 years agoMajor refactoring of contributing documentation 93/55493/1
Daniel Farrell [Tue, 14 Apr 2015 02:35:05 +0000 (22:35 -0400)]
Major refactoring of contributing documentation

* Better overview of contributing to the project
* Add communication info, including Issues and Gitter
* Better PR submission docs
* Initial index
* Put most of the old content in a new testing sub-section

Change-Id: Ib001fac851afd14ee408dcd3b2f715a86af56335
Signed-off-by: Daniel Farrell <dfarrell@redhat.com>
7 years agoUpdate limitations to reflect Ubuntu support 92/55492/1
Daniel Farrell [Thu, 9 Apr 2015 21:56:56 +0000 (17:56 -0400)]
Update limitations to reflect Ubuntu support

Change-Id: Iee44673b6174f6cbddbccb2973dc3bd19702afcc
Signed-off-by: Daniel Farrell <dfarrell@redhat.com>
7 years agoBugfix in Ubuntu Upstart config, ODL service gtg 91/55491/1
Daniel Farrell [Wed, 8 Apr 2015 17:08:35 +0000 (13:08 -0400)]
Bugfix in Ubuntu Upstart config, ODL service gtg

* The Upstart file wasn't being installed correctly
* Relevant to #72
* We now have proper Ubuntu 14.04 support, huzzah!

Change-Id: Iccd00e35e0a33d43ee9e31225e475ddcc2e40aa7
Signed-off-by: Daniel Farrell <dfarrell@redhat.com>
7 years agoAdd CentOS tarball install to acceptance rake task 90/55490/1
Daniel Farrell [Tue, 7 Apr 2015 18:15:04 +0000 (14:15 -0400)]
Add CentOS tarball install to acceptance rake task

Change-Id: Ie953ffff1b7fcb2eeb7215b83d4769ea04aa8992
Signed-off-by: Daniel Farrell <dfarrell@redhat.com>
7 years agoDon't continue when Beaker stdlib install fails 89/55489/1
Daniel Farrell [Mon, 6 Apr 2015 21:48:22 +0000 (17:48 -0400)]
Don't continue when Beaker stdlib install fails

Change-Id: Ie9f38c4935388caab61c92c7580587c5f13dcfa9
Signed-off-by: Daniel Farrell <dfarrell@redhat.com>
7 years agoUpdate to OpenDaylight 0.2.3 SR3 88/55488/1
Daniel Farrell [Mon, 6 Apr 2015 21:47:32 +0000 (17:47 -0400)]
Update to OpenDaylight 0.2.3 SR3

Change-Id: If63b8d5302e7f011808de95924bdd3bd1180868e
Signed-off-by: Daniel Farrell <dfarrell@redhat.com>
7 years agoAdd default install method (RPM) for Fedora Rakes 87/55487/1
Daniel Farrell [Mon, 6 Apr 2015 14:53:07 +0000 (10:53 -0400)]
Add default install method (RPM) for Fedora Rakes

Change-Id: Ieac2489bd09a68c577b96ef8fe91a74b05b2bcc3
Signed-off-by: Daniel Farrell <dfarrell@redhat.com>
7 years agoRemoved unnecessary .gitkeep 86/55486/1
Daniel Farrell [Tue, 31 Mar 2015 17:58:15 +0000 (13:58 -0400)]
Removed unnecessary .gitkeep

Change-Id: Iddd76a11c0ceee211f3b7af5f2733e7d2c2017a0
Signed-off-by: Daniel Farrell <dfarrell@redhat.com>
7 years agoIgnore third party resource in rspec coverage 85/55485/1
Daniel Farrell [Tue, 31 Mar 2015 17:54:26 +0000 (13:54 -0400)]
Ignore third party resource in rspec coverage

* We don't own that code, can't test it

Change-Id: I82c5aa23df87e22b1f43d087821264b5ea1fb950
Signed-off-by: Daniel Farrell <dfarrell@redhat.com>
7 years agoAdd rspec-puppet tests for ODL REST port 84/55484/1
Daniel Farrell [Tue, 31 Mar 2015 17:51:32 +0000 (13:51 -0400)]
Add rspec-puppet tests for ODL REST port

* Hook into previously added rspec helper method
* Minor bugfix in odl rest port test rspec-puppet helper
* Closes #47

Change-Id: I20a7c3d195a52aa6acabfe6b1eb82ff500d7c902
Signed-off-by: Daniel Farrell <dfarrell@redhat.com>
7 years agoTrivial doc fix 83/55483/1
Daniel Farrell [Tue, 31 Mar 2015 17:42:22 +0000 (13:42 -0400)]
Trivial doc fix

Change-Id: Ic6943d3a92bfd43253ca414b5cd59a2f74e619c9
Signed-off-by: Daniel Farrell <dfarrell@redhat.com>
7 years agoRemoved unused section from README index 82/55482/1
Daniel Farrell [Tue, 31 Mar 2015 06:06:12 +0000 (02:06 -0400)]
Removed unused section from README index

Change-Id: I0b670140b2c6397ac1abc3780c2595112f3d1048
Signed-off-by: Daniel Farrell <dfarrell@redhat.com>
7 years agoAdd rspec-puppet helper for testing ODL REST port 81/55481/1
Daniel Farrell [Tue, 31 Mar 2015 05:22:34 +0000 (01:22 -0400)]
Add rspec-puppet helper for testing ODL REST port

* Relevant to #47

Change-Id: I997c1cfdcae2bfe700b69c5a60804e3166c55844
Signed-off-by: Daniel Farrell <dfarrell@redhat.com>
7 years agoDon't do yum-specific checks for non-RH OSs 80/55480/1
Daniel Farrell [Tue, 31 Mar 2015 05:40:13 +0000 (01:40 -0400)]
Don't do yum-specific checks for non-RH OSs

* Yumrepo checks fail inelegantly on Ubuntu, avoid

Change-Id: Ib341a7019b5127feb89dbdf7256de7e7ace6bfae
Signed-off-by: Daniel Farrell <dfarrell@redhat.com>
7 years agoRefactoring/small fixes for Beaker REST port tests 79/55479/1
Daniel Farrell [Tue, 31 Mar 2015 02:33:44 +0000 (22:33 -0400)]
Refactoring/small fixes for Beaker REST port tests

* All Beaker REST port tests now passing
* Related to #67, closes #73

Change-Id: I88396055d71bbe6ccc57be37c4ef3fce9e4a8342
Signed-off-by: Daniel Farrell <dfarrell@redhat.com>
7 years agoUse template for REST port config, closes #67 78/55478/1
Daniel Farrell [Tue, 31 Mar 2015 02:32:02 +0000 (22:32 -0400)]
Use template for REST port config, closes #67

Change-Id: I8b66a41c88390c4968a3c011dfff4292b7b84c72
Signed-off-by: Daniel Farrell <dfarrell@redhat.com>
7 years agoFix Java package name for Ubuntu installs 77/55477/1
Daniel Farrell [Wed, 25 Mar 2015 19:56:54 +0000 (15:56 -0400)]
Fix Java package name for Ubuntu installs

Change-Id: I77215fe7beb41e44429109cf57f866354ce9c5c9
Signed-off-by: Daniel Farrell <dfarrell@redhat.com>
7 years agoMade Upstart config more consistent with others 76/55476/1
Daniel Farrell [Wed, 25 Mar 2015 19:29:55 +0000 (15:29 -0400)]
Made Upstart config more consistent with others

* Most of the configs in Beaker box use this style

Change-Id: Ie82740f8d31c87bc8799699f810605ee4fee7006
Signed-off-by: Daniel Farrell <dfarrell@redhat.com>
7 years agoFix minor indentation errors in rspec-puppet tests 75/55475/1
Daniel Farrell [Wed, 25 Mar 2015 19:24:25 +0000 (15:24 -0400)]
Fix minor indentation errors in rspec-puppet tests

Change-Id: Ica08188257f55ff984c61d29112c11b01cd3865a
Signed-off-by: Daniel Farrell <dfarrell@redhat.com>
7 years agoMinor typo bug in architecture fact 74/55474/1
Daniel Farrell [Wed, 25 Mar 2015 19:11:39 +0000 (15:11 -0400)]
Minor typo bug in architecture fact

* This should fix Travis

Change-Id: I62c0d64c954ca5ed87f6535f5ff434ebaff37e1e
Signed-off-by: Daniel Farrell <dfarrell@redhat.com>
7 years agoAdd initial support for Ubuntu 14.04 Beaker tests 73/55473/1
Daniel Farrell [Wed, 25 Mar 2015 18:58:41 +0000 (14:58 -0400)]
Add initial support for Ubuntu 14.04 Beaker tests

* Relevant to #71
* Failing due with Upstart errors and Java errors
* Also port errors, but those are unrelated to Ubuntu

Change-Id: Iba2aaf861708dbc1bcaddf15d3c31c12044fa05e
Signed-off-by: Daniel Farrell <dfarrell@redhat.com>
7 years agoPass alternative fact, required by Java mod 72/55472/1
Daniel Farrell [Wed, 25 Mar 2015 18:22:27 +0000 (14:22 -0400)]
Pass alternative fact, required by Java mod

* Travis (with strict var checking) fails without this
* Worked without this on my local system

Change-Id: Ib4e68d99170af3d5970aecb68d396f6c2af35ba8
Signed-off-by: Daniel Farrell <dfarrell@redhat.com>
7 years agoAttempt fixing Travis fail - Use full Puppet URL 71/55471/1
Daniel Farrell [Wed, 25 Mar 2015 17:24:30 +0000 (13:24 -0400)]
Attempt fixing Travis fail - Use full Puppet URL

* Currently using file helper fn, but Travis fails
* Both methods work on my local system

Change-Id: I9fcb59b44fe29d9111b3735d2b9bb4c5e46eaf50
Signed-off-by: Daniel Farrell <dfarrell@redhat.com>
7 years agoDo Karaf/install tests with defaults for all OSs 70/55470/1
Daniel Farrell [Wed, 25 Mar 2015 16:40:29 +0000 (12:40 -0400)]
Do Karaf/install tests with defaults for all OSs

* Only testing defaults! See #43 for reasoning.
* By 'all', of course I mean 'all supported' (others fail)
* Refactored RPM rspec helper fn to support Fedora
* Minor doc fix

Change-Id: Iae3768581644d1b65c265c761b07269ae4e4d82d
Signed-off-by: Daniel Farrell <dfarrell@redhat.com>
7 years agoDo Karaf rspec tests with default values for Deb 69/55469/1
Daniel Farrell [Wed, 25 Mar 2015 16:16:11 +0000 (12:16 -0400)]
Do Karaf rspec tests with default values for Deb

* Only testing defaults! See #43 for reasoning.
* May add this to other OSs

Change-Id: Ie3f2cf6377e4093b3ec6106f2ab88bedcd13117f
Signed-off-by: Daniel Farrell <dfarrell@redhat.com>
7 years agoConvert Karaf tests to use options hash 68/55468/1
Daniel Farrell [Wed, 25 Mar 2015 16:09:32 +0000 (12:09 -0400)]
Convert Karaf tests to use options hash

* Much cleaner logic in main spec file
* Required for calling without knowledge of defaults
* ^^Want that for future refactoring

Change-Id: I35dca936c5f85feb77725c94bcafc17b354b28bc
Signed-off-by: Daniel Farrell <dfarrell@redhat.com>
7 years agoAdd owner:group rspec tests for Karaf file 67/55467/1
Daniel Farrell [Wed, 25 Mar 2015 15:46:17 +0000 (11:46 -0400)]
Add owner:group rspec tests for Karaf file

Change-Id: I090f4e0d9a46e93e341d6dfda249896fc79d897a
Signed-off-by: Daniel Farrell <dfarrell@redhat.com>
7 years agoRefactored OS warning/error rspec-puppet tests #70 66/55466/1
Daniel Farrell [Wed, 25 Mar 2015 15:34:42 +0000 (11:34 -0400)]
Refactored OS warning/error rspec-puppet tests #70

Change-Id: I4cf6a34d49bd5d0d3149d60eda19c011729f1435
Signed-off-by: Daniel Farrell <dfarrell@redhat.com>
7 years agoMajor refactoring of rspec-puppet tests for Debian 65/55465/1
Daniel Farrell [Wed, 25 Mar 2015 04:24:35 +0000 (00:24 -0400)]
Major refactoring of rspec-puppet tests for Debian

* Generally refactored rspec tests as added Debain support
* Add basic upstart config and Debian Java pkg tests
* Split install method checks into two functions
* Do systemd/upstart checks based on osfamily for tb installs
* Use nicer options hashes for refactored helper fn params
* Cleans up default tarball/unitfile/yum repo URLs

Change-Id: I11e6eb9b099ad30c4a9759bc3061d24759b2a7dc
Signed-off-by: Daniel Farrell <dfarrell@redhat.com>
7 years agoUse file vs template for upstart config 64/55464/1
Daniel Farrell [Wed, 25 Mar 2015 02:25:24 +0000 (22:25 -0400)]
Use file vs template for upstart config

* It's not dynamic ERB, so should be a file

Change-Id: If2aaff04d252e5e320393ea253a56877ee157f73
Signed-off-by: Daniel Farrell <dfarrell@redhat.com>
7 years agoIndentation fix, removed old TODO 63/55463/1
Daniel Farrell [Wed, 25 Mar 2015 00:32:04 +0000 (20:32 -0400)]
Indentation fix, removed old TODO

Change-Id: I37e992307f04dbeda5c93a321ef4dbf8202641f1
Signed-off-by: Daniel Farrell <dfarrell@redhat.com>
7 years agoConnect generic rspec tests to Ubuntu 14.04 tests 62/55462/1
Daniel Farrell [Wed, 25 Mar 2015 00:23:15 +0000 (20:23 -0400)]
Connect generic rspec tests to Ubuntu 14.04 tests

* Fixed issue with missing path for java archive

Change-Id: I04a36aa3ec67da25fa94d55ab9f4d40ed8679752
Signed-off-by: Daniel Farrell <dfarrell@redhat.com>
7 years agoGeneric bugfixes and cleanups for Deb rspec tests 61/55461/1
Daniel Farrell [Tue, 24 Mar 2015 22:18:23 +0000 (18:18 -0400)]
Generic bugfixes and cleanups for Deb rspec tests

Change-Id: I5fb32f659a7d833c9d0faad097ec30054a7ae840
Signed-off-by: Daniel Farrell <dfarrell@redhat.com>
7 years agoAdd basic rspec-puppet for Ubuntu 14.04 60/55460/1
Daniel Farrell [Tue, 24 Mar 2015 21:41:03 +0000 (17:41 -0400)]
Add basic rspec-puppet for Ubuntu 14.04

* Proper connection to unsupported OS versions (14.10..)
* Stub connection to supported OS version tests (only 14.04)

Change-Id: If75097b0a1249fcf18fd82551711490c225545e1
Signed-off-by: Daniel Farrell <dfarrell@redhat.com>
7 years agoSmall formatting cleanup in init.pp 59/55459/1
Daniel Farrell [Tue, 24 Mar 2015 21:40:34 +0000 (17:40 -0400)]
Small formatting cleanup in init.pp

Change-Id: I92f1c101f505bdfd9fbd5b9adaca7debd22aca1e
Signed-off-by: Daniel Farrell <dfarrell@redhat.com>
7 years agoBugfix in Beaker check of port file content #48 58/55458/1
Daniel Farrell [Fri, 20 Mar 2015 19:30:37 +0000 (15:30 -0400)]
Bugfix in Beaker check of port file content #48

Change-Id: Icf75f3f2a1be10d59890c5ccd1dbc2278618c88a
Signed-off-by: Daniel Farrell <dfarrell@redhat.com>
7 years agoAdd Beaker tests for ODL port param #48 57/55457/1
Daniel Farrell [Fri, 20 Mar 2015 19:25:59 +0000 (15:25 -0400)]
Add Beaker tests for ODL port param #48

Change-Id: I50cddaf1a50c1dd8a70de272aa8df7e3461ec614
Signed-off-by: Daniel Farrell <dfarrell@redhat.com>
7 years agoAdd template for ODL NB REST port config #67 56/55456/1
Daniel Farrell [Fri, 20 Mar 2015 19:23:28 +0000 (15:23 -0400)]
Add template for ODL NB REST port config #67

Change-Id: I0b5141813cb2533393fcd8fa1cd5a8a3e4f82568
Signed-off-by: Daniel Farrell <dfarrell@redhat.com>
7 years agoMinor cleanup of upstart conf, add support warning 55/55455/1
Daniel Farrell [Tue, 24 Mar 2015 20:50:31 +0000 (16:50 -0400)]
Minor cleanup of upstart conf, add support warning

* I don't know much about upstart, so can't guarantee quality
* Will attempt to support as best I can, but can't guarantee

Change-Id: I1833161d8fe4dea3620f9b11ecf44356742b10ff
Signed-off-by: Daniel Farrell <dfarrell@redhat.com>
7 years agoRemove Debian from unsupported OSs, stub rspec 54/55454/1
Daniel Farrell [Tue, 24 Mar 2015 20:48:31 +0000 (16:48 -0400)]
Remove Debian from unsupported OSs, stub rspec

* Gets `bundle exec rake test` passing
* Relevant to #70

Change-Id: I42d500e24ad8d0c2a782dfac33c27c1aecc46af2
Signed-off-by: Daniel Farrell <dfarrell@redhat.com>
7 years agoTrivial style fix 53/55453/1
Daniel Farrell [Tue, 24 Mar 2015 20:48:21 +0000 (16:48 -0400)]
Trivial style fix

Change-Id: I488d7939e96ef70c2d2aa9d80e969c9258734fa9
Signed-off-by: Daniel Farrell <dfarrell@redhat.com>
7 years agorecover Fedora 20/21 52/55452/1
David Blaisonneau [Tue, 24 Mar 2015 13:17:28 +0000 (14:17 +0100)]
recover Fedora 20/21

Change-Id: Ic45ae69de0c04ebeb42d99fb1374765db7b731cd
Signed-off-by: Daniel Farrell <dfarrell@redhat.com>
7 years agoadd ubuntu support 51/55451/1
David Blaisonneau [Tue, 24 Mar 2015 13:03:35 +0000 (14:03 +0100)]
add ubuntu support

Change-Id: Iaf0c4855b25373beea99346472a1ff3b6b1ad573
Signed-off-by: Daniel Farrell <dfarrell@redhat.com>
7 years agoLink to ODL homepage in README, clear headings 50/55450/1
Daniel Farrell [Wed, 18 Mar 2015 16:36:07 +0000 (12:36 -0400)]
Link to ODL homepage in README, clear headings

* Backticks for ODL in headings hopefully show class vs project

Change-Id: I46fc8847b4e1e8ff1f6416c1f7829d3e09a9caca
Signed-off-by: Daniel Farrell <dfarrell@redhat.com>
7 years agoGeneral cleanup of README 49/55449/1
Daniel Farrell [Wed, 18 Mar 2015 16:30:05 +0000 (12:30 -0400)]
General cleanup of README

* Assorted small changes
* Noted Java dep

Change-Id: I0f5f12765ce35c742338cfbb20f22aacf456c48c
Signed-off-by: Daniel Farrell <dfarrell@redhat.com>
7 years agoTarball install method now stable, remove warning 48/55448/1
Daniel Farrell [Tue, 17 Mar 2015 15:08:25 +0000 (11:08 -0400)]
Tarball install method now stable, remove warning

* Relevant to #45 and others

Change-Id: I144e8f2402c80a33a7e7541652fc8663dc6123f1
Signed-off-by: Daniel Farrell <dfarrell@redhat.com>
7 years agoRPM sets odl user's home dir to `/opt/opendaylight` 47/55447/1
Daniel Farrell [Sat, 14 Mar 2015 05:13:11 +0000 (01:13 -0400)]
RPM sets odl user's home dir to `/opt/opendaylight`

* There's no trailing slash! Having one == Beaker fails.
* May want to fix this in future version of RPM?
* Relevant to #66

Change-Id: Iac2826ac38d53430d9aec8c2e5bd2b5a9734e3e4
Signed-off-by: Daniel Farrell <dfarrell@redhat.com>
7 years agoClean up file name endings (trailing slash or not) 46/55446/1
Daniel Farrell [Sat, 14 Mar 2015 04:53:34 +0000 (00:53 -0400)]
Clean up file name endings (trailing slash or not)

* Was causing some strange dep cycle test failure

Change-Id: I08b4ae169a753eb527525a5067f7acd0567b420f
Signed-off-by: Daniel Farrell <dfarrell@redhat.com>
7 years agoRemove ODL version from ODL dir name 45/55445/1
Daniel Farrell [Sat, 14 Mar 2015 03:18:31 +0000 (23:18 -0400)]
Remove ODL version from ODL dir name

* Follows change made by RPM
* Relevant to #66

Change-Id: I6ad56a8e47418bc98f7b6415fd77173aeccc1aa7
Signed-off-by: Daniel Farrell <dfarrell@redhat.com>
7 years agoMove from pre-PR fork to official rspec-puppet 44/55444/1
Daniel Farrell [Fri, 13 Mar 2015 19:27:29 +0000 (15:27 -0400)]
Move from pre-PR fork to official rspec-puppet

* Closes issue #16
* This commit has an interesting back story, see issue

Change-Id: I4a40fb133f8b06c33def54d75b4e51465895519e
Signed-off-by: Daniel Farrell <dfarrell@redhat.com>
7 years agoBeaker tests, including tarball install ones 43/55443/1
Daniel Farrell [Wed, 11 Mar 2015 18:09:32 +0000 (14:09 -0400)]
Beaker tests, including tarball install ones

* Closes #45

Change-Id: Ifb3b024163a06eaf70fb9077c23dae4a72a0c3a7
Signed-off-by: Daniel Farrell <dfarrell@redhat.com>
7 years agoFix two tarball Beaker test failures 42/55442/1
Daniel Farrell [Tue, 10 Mar 2015 21:51:56 +0000 (17:51 -0400)]
Fix two tarball Beaker test failures

* The tarball extract isn't idempotent, don't assert it is (#45)
* We're no longer setting modes, don't assert one

Change-Id: Ic73092c2814ab6243880f171670fa0a965428ef2
Signed-off-by: Daniel Farrell <dfarrell@redhat.com>
7 years agoDo all tarball Beaker tests with a tarball install[ 41/55441/1
Daniel Farrell [Tue, 10 Mar 2015 20:04:21 +0000 (16:04 -0400)]
Do all tarball Beaker tests with a tarball install[

* Used to do install tests with correct tarball/RPM method, but
all other tests with always-RPM method.
* Relevant to #45

Change-Id: I76eb3bc47c3c80e9ed133dba52e33e77375d273e
Signed-off-by: Daniel Farrell <dfarrell@redhat.com>
7 years agoDon't set Karaf config file mode, leave default 40/55440/1
Daniel Farrell [Tue, 10 Mar 2015 20:03:39 +0000 (16:03 -0400)]
Don't set Karaf config file mode, leave default

Change-Id: I151792b62bd3a3bea9b8a6f96a551018555d1ec7
Signed-off-by: Daniel Farrell <dfarrell@redhat.com>
7 years agoFix Beaker test failure related to new mode config 39/55439/1
Daniel Farrell [Tue, 10 Mar 2015 15:41:15 +0000 (11:41 -0400)]
Fix Beaker test failure related to new mode config

* Related to #65

Change-Id: Ib6ffb32121ce4386ff17f798ade955fa85c68c5d
Signed-off-by: Daniel Farrell <dfarrell@redhat.com>
7 years agoDon't set ODL archive mode, leave default 38/55438/1
Daniel Farrell [Tue, 10 Mar 2015 15:05:28 +0000 (11:05 -0400)]
Don't set ODL archive mode, leave default

* Relevant to #65

Change-Id: I6743f8fc15ec464e813eab1b3c0d0ebd358c34f2
Signed-off-by: Daniel Farrell <dfarrell@redhat.com>
7 years agoMinor in-line docs spelling fix 37/55437/1
Daniel Farrell [Tue, 10 Mar 2015 01:30:04 +0000 (21:30 -0400)]
Minor in-line docs spelling fix

Change-Id: I27223dba7aaf91c3040a4aaeb41060316ddbbfc8
Signed-off-by: Daniel Farrell <dfarrell@redhat.com>
7 years agoMajor update of tarball install Beaker tests 36/55436/1
Daniel Farrell [Mon, 9 Mar 2015 20:42:44 +0000 (16:42 -0400)]
Major update of tarball install Beaker tests

Move to totally different method of passing info about
which install method to test from rake command. We now
set env vars in the Rakefile, the access them in the
test context (not a helper) to get RPM xor tarball
behavior.

All tarball tests passing except a general one, debugging.

Large portion of #45.

Change-Id: I3ef3eeee6dc8999b1e93390ace162fc08f7be3d6
Signed-off-by: Daniel Farrell <dfarrell@redhat.com>
7 years agoFix user/group/mod of features file (tarball only) 35/55435/1
Daniel Farrell [Mon, 9 Mar 2015 18:53:21 +0000 (14:53 -0400)]
Fix user/group/mod of features file (tarball only)

* A more specific file config was overriding ODL dir config
* Fixes some tests for #45

Change-Id: Ife6a7cbb89a0ed1823784ba6af43876100c74803
Signed-off-by: Daniel Farrell <dfarrell@redhat.com>