Ravit Peretz [Thu, 15 Sep 2016 15:17:19 +0000 (18:17 +0300)]
Bug 6708
Neighbor NAPT switches group table buckets remain empty
Fix race by triggering NAPT neighbor group table update
upon tunnel interface state addition
Change-Id: If1774c91eb9a42a5da575ec25ca83935fbb178b2
Signed-off-by: Ravit Peretz <ravit.peretz@hpe.com>
Ravit Peretz [Thu, 15 Sep 2016 15:21:18 +0000 (18:21 +0300)]
Bug 6727
ExternalRouterListener ignore multiple routers implementation
Change-Id: I390a666dd61304816f73b7405cc3abbccc45028b
Signed-off-by: Ravit Peretz <ravit.peretz@hpe.com>
yair [Tue, 13 Sep 2016 09:00:56 +0000 (12:00 +0300)]
Bug 6628 - DMAC for L3 entities flows installation only after reversal
Will install router interface, router GW and floating IPs DMAC table flows
only when L2 is before L3 in the Netvirt pipeline.
Change-Id: Ibcb025ecf44811ce02259c1e1aaf4d32782ece16
Signed-off-by: yair <yair.zinger@hpe.com>
Michael Vorburger [Wed, 21 Sep 2016 13:39:25 +0000 (15:39 +0200)]
Clearer failure message in AclServiceTest if no flows are created
Change-Id: I6832dd4af90865bb0227bb097271af8b25e932b8
Signed-off-by: Michael Vorburger <vorburger@redhat.com>
Michael Vorburger [Wed, 21 Sep 2016 15:08:52 +0000 (17:08 +0200)]
Upgrade AssertBeans version, intro. nicer syntax w.o. build()
Also incl. some general clean-up: now all code in *-impl instead of some
in *-api, as that is probably much cleaner, and simpler to follow when
reading.
The 3 classes that are in test.infra will eventually move somewhere else
(but let's anyway get this in as proposed here ASAP already).
Change-Id: Iaf136a88d1f6740a56159efc3c5349348b9516b0
Signed-off-by: Michael Vorburger <vorburger@redhat.com>
Sam Hague [Wed, 21 Sep 2016 19:10:32 +0000 (19:10 +0000)]
Merge "Bug-6741: eth1 flows on table 0 are missing from d2 ovs"
Sam Hague [Wed, 21 Sep 2016 17:32:55 +0000 (17:32 +0000)]
Merge "Fix wiring issue in openstack.sfc-translator-impl"
Sam Hague [Wed, 21 Sep 2016 12:51:50 +0000 (12:51 +0000)]
Merge "Bug 6752: DHCP service is not bound"
Sam Hague [Wed, 21 Sep 2016 12:45:24 +0000 (12:45 +0000)]
Merge "Bug 6748: ACL mechanism uses reg5 instead of reg6."
Sam Hague [Wed, 21 Sep 2016 12:44:07 +0000 (12:44 +0000)]
Merge "Bug 6756: Fix related to missing ACL flows"
Michael Vorburger [Wed, 21 Sep 2016 10:05:17 +0000 (12:05 +0200)]
Fix & un-@Ignore AclServiceTest
It turns out that c/45261 re. "@Override init() instead @PostConstruct
start()" broke AclServiceTest (c/42109); somehow Mycila Guice
Jsr250Module interprets @PostConstruct in parent class, or protected VS
public, differently than Apache Aries Blueprint impl.
This fixes it by putting @PostConstruct back, for now. I'll separately
investigate a cleaner fix (probably going either in Mycila Guice, Genius
or infrautils; not netvirt).
This problem was not seen pre-merge, and thus broke master, because we
are in the unhealthy habit of merging a bunch of changes without
re-re-rebasing EVERY change after EVERY merge. While that certainly
adds some overhead for commiters and build infra, doing that would lead
to more stability in such cases, as well as avoid Guitar Hero git log
<https://twitter.com/henryhoffman/status/
694184106440200192>, which in
turn would make it easier to locally try git revert and git bisect to
find out which commit cause what.
Change-Id: Ife74e3b920cca1fdf43fdf3aedc6401723050c46
Signed-off-by: Michael Vorburger <vorburger@redhat.com>
Somashekar Byrappa [Tue, 20 Sep 2016 13:37:28 +0000 (19:07 +0530)]
Bug 6756: Fix related to missing ACL flows
When two SG's having common rules are swapped for a VM, ACL flows related
to common rules were missing.
Fix:
+ When SG's having common rules are swapped for a VM, delete the flows
related to previous SG and then add flows related to new SG instead of the
reverse order.
+ Fixed a NPE in AclInterfaceCacheUtil.
Change-Id: Ifdb3139b737ec53cd75378851593d0b096efedc1
Signed-off-by: Somashekar Byrappa <somashekar.b@altencalsoftlabs.com>
Sam Hague [Wed, 21 Sep 2016 00:59:15 +0000 (00:59 +0000)]
Merge "Fixes default SG remote groups rules. 1))Remote default SG rules are not added with Ip addres asn same is fixed 2)Flow id is fixed for ipv4 and ipv6 rules."
Sam Hague [Wed, 21 Sep 2016 00:58:03 +0000 (00:58 +0000)]
Merge "Bug 6690 - when mixing dpdk & non-dpdk OVS with the same ODL no way to configure different datapath types"
Sam Hague [Tue, 20 Sep 2016 23:17:09 +0000 (23:17 +0000)]
Merge "Bug 6742 FloatingIPHanlder should use the external interface-name"
Koby Aizer [Mon, 19 Sep 2016 21:15:51 +0000 (00:15 +0300)]
Bug 6732: ARP Replies Intermittent for Floating IP Addresses
Don't stop ARP responder logic in case there is an ARP cache entry
for targetIp.
Even though this cache entry should never exist for IPs that the ARP responder
is responsible for, there is no reason to stop the ARP request
processing because of that.
Disabled AclServiceTest#newInterface() because it was failing.
Will fix it in another patch since it has nothing to do with this patch.
Change-Id: I392d9d9132350201e8d5761fe99c348223ea858d
Signed-off-by: Koby Aizer <koby.aizer@hpe.com>
Signed-off-by: Sam Hague <shague@redhat.com>
Ravit Peretz [Sun, 18 Sep 2016 17:04:38 +0000 (20:04 +0300)]
Bug 6742 FloatingIPHanlder should use the external interface-name
Change-Id: I9fb58b26139afec6d09fa7792b7e94570804244d
Signed-off-by: Ravit Peretz <ravit.peretz@hpe.com>
Tomer [Mon, 19 Sep 2016 14:53:06 +0000 (17:53 +0300)]
Bug 6748: ACL mechanism uses reg5 instead of reg6.
Also, removed match on MACs in learned flows
Change-Id: I7d686532abe60585c7f4294c27da044716127cb0
Signed-off-by: Tomer <tomer.pearl@hpe.com>
Andre Fredette [Tue, 20 Sep 2016 15:20:46 +0000 (15:20 +0000)]
Merge "Bug 6707 - FIB table rules are not created when DPNTEPInfo is not available"
Kency Kurian [Tue, 20 Sep 2016 07:30:18 +0000 (13:00 +0530)]
Bug 6752: DHCP service is not bound
After making the changes in genius for ACL as highest priority both ACL
and DHCP were sharing the same service index because of which the service
was not getting bound.
Fixed this by making use of the service index provided in NwConstants.
Change-Id: I7a110ce0d454bc33c2f7e8c00690a4e800178ab1
Signed-off-by: Kency Kurian <kency.kurian@ericsson.com>
Sam Hague [Mon, 19 Sep 2016 23:09:10 +0000 (23:09 +0000)]
Merge changes from topic 'bp/annotation'
* changes:
aclservice-impl *Listener without dumb @PreDestroy super.close()
aclservice-impl use infrautils AbstractLifecycle
Michael Vorburger [Tue, 5 Jul 2016 22:06:44 +0000 (00:06 +0200)]
aclservice end-to-end test, with a bunch of cool new patterns
This originally increased coverage of aclservice from 53% as of
de3d70d
to 65% (but things have moved a bit since this work was started). The
new approach introduced should make it easy to push it up further.
Meant also as an example for replication elsewhere; illustrates:
* manual Xtend objects for Flows
* generated Xtend objects by XtendBeanGenerator
* AssertBeans helper for readable test object comparison
* Mockito with CallsRealOrExceptionAnswer etc. (formerly "Mikito")
* Wiring DI best practice pattern, based on Guice
Change-Id: Icfb0a77ebfe807d30ea591d2997ef76718d2d0d1
Signed-off-by: Michael Vorburger <vorburger@redhat.com>
Tali [Mon, 19 Sep 2016 12:01:56 +0000 (15:01 +0300)]
Bug 6690 - when mixing dpdk & non-dpdk OVS with the same ODL
no way to configure different datapath types
Change-Id: I0c23e8ecc4bc998a1694d1ca2196666264a43011
Signed-off-by: Tali <tali.ben-meir@hpe.com>
Olga [Mon, 19 Sep 2016 04:39:41 +0000 (07:39 +0300)]
Bug-6741: eth1 flows on table 0 are missing from d2 ovs
Change-Id: Iaf5b6a7b8787c89af9d13d23059f15a56b72231e
Signed-off-by: Olga <olga.schukin@hpe.com>
Tali [Thu, 15 Sep 2016 12:00:30 +0000 (15:00 +0300)]
Bug 6707 - FIB table rules are not created when DPNTEPInfo is not available
When new TunnelEndPoint gets created, attempt to re-process
associated adjacencies that were skipped when the VM port
was initially broght up as the TEP was still missing
Change-Id: I67b0ce164dbcb6217bcbf0b16cd771e4249e0a4c
Signed-off-by: Tali <tali.ben-meir@hpe.com>
Alexis de Talhouët [Sat, 17 Sep 2016 22:01:11 +0000 (18:01 -0400)]
Fix wiring issue in openstack.sfc-translator-impl
The bundle is pulling in the rpc-service RenderedServicePathService.
But in order to use it, we should use the odl-sfc-provider feature,
providing the implementation of this rpc-service, and also, registering
it in the OSGi service regisry.
Using the odl-sfc-model is exposing the class RenderedServicePathService
but don't register any implementation for this service in the OSGi
service registry.
Change-Id: I8b583bae9cdff7804b204d63ee88765a24679441
Signed-off-by: Alexis de Talhouët <adetalhouet@inocybe.com>
epgoraj [Thu, 15 Sep 2016 06:01:14 +0000 (11:31 +0530)]
BUG 6452: Error logs when deleting neutron network
Change-Id: Id3448e93d3dd0f8bcea83a178e6abe81de75a8da
Signed-off-by: epgoraj <p.govinda.rajulu@ericsson.com>
Michael Vorburger [Tue, 6 Sep 2016 10:26:58 +0000 (12:26 +0200)]
aclservice AclInterfaceStateListener update() TODO replace with comment
Change-Id: Ic3bd87e29e35b9d424c5fcfefed43fc88cc0bd1d
Signed-off-by: Michael Vorburger <vorburger@redhat.com>
Signed-off-by: Aswin Suryanarayanan <asuryana@redhat.com>
Andre Fredette [Mon, 12 Sep 2016 21:39:35 +0000 (21:39 +0000)]
Merge "Bug 6688 - Patch port is not correctly associated to ELAN"
Andre Fredette [Mon, 12 Sep 2016 21:39:20 +0000 (21:39 +0000)]
Merge "Bug 6677: Create ext-routers when a router is created with ext-gw"
Andre Fredette [Mon, 12 Sep 2016 21:39:04 +0000 (21:39 +0000)]
Merge "Bug 6687: Fix NPE when updating ExternalNetwork"
eceghkl [Mon, 29 Aug 2016 11:17:56 +0000 (16:47 +0530)]
Code for myMAC in the L3VPN pipeline
Code to program the L3_GW_MAC_TABLE.
Change-Id: I02252a9904c24c8ff37338b4b52cef49e73e9382
Signed-off-by: eceghkl <manu.b@ericsson.com>
Tali [Sun, 11 Sep 2016 11:27:13 +0000 (14:27 +0300)]
Bug 6688 - Patch port is not correctly associated to ELAN
Change-Id: Iaa96881879ea1fc32dfa3001abd45bbb0595ce91
Signed-off-by: Tali <tali.ben-meir@hpe.com>
Koby Aizer [Sat, 10 Sep 2016 09:52:23 +0000 (12:52 +0300)]
Bug 6677: Create ext-routers when a router is created with ext-gw
When a router is created with an External Network, no ext-routers entry
is created. This flow is used by horizon & several tempest tests.
Change-Id: I33d520a24db1c6f455c98213e31e081c8c8509e9
Signed-off-by: Koby Aizer <koby.aizer@hpe.com>
Koby Aizer [Sat, 10 Sep 2016 09:29:33 +0000 (12:29 +0300)]
Bug 6687: Fix NPE when updating ExternalNetwork
Happens when there are routers which are not associated with
a DPN yet.
Change-Id: I80f25439484d2e8c9f813826bec880a406421ee2
Signed-off-by: Koby Aizer <koby.aizer@hpe.com>
Michael Vorburger [Tue, 6 Sep 2016 17:20:19 +0000 (19:20 +0200)]
aclservice-impl *Listener without dumb @PreDestroy super.close()
and with @Override init() instead @PostConstruct start()
This goes with (requires, depends on)
https://git.opendaylight.org/gerrit/#/c/45258/, and complements
https://git.opendaylight.org/gerrit/#/c/45249/
I've manually tested this in Karaf and made sure BP (diag) is OK.
Change-Id: Ia09ec0ffb87adfdf3e1c43e5655253eed18bd5ab
Signed-off-by: Michael Vorburger <vorburger@redhat.com>
Michael Vorburger [Tue, 6 Sep 2016 15:43:50 +0000 (17:43 +0200)]
aclservice-impl use infrautils AbstractLifecycle
and do NOT use (repeat) @PostConstruct and @PreDestroy - they are on
AbstractLifecycle, which does correct exception handling etc.
Based on https://git.opendaylight.org/gerrit/#/c/44554/ &
https://git.opendaylight.org/gerrit/#/c/45248/ (follow-up); on which
this is dependent.
Also includes fixed up features.xml in line with above.
I've manually tested this in Karaf and made sure BP (diag) is OK.
Change-Id: I4fbc088fee359b74d9d47b89bb441cdeaecc2f84
Signed-off-by: Michael Vorburger <vorburger@redhat.com>
Aswin Suryanarayanan [Fri, 9 Sep 2016 07:49:49 +0000 (13:19 +0530)]
Fixes default SG remote groups rules.
1))Remote default SG rules are not added with Ip addres asn same is
fixed
2)Flow id is fixed for ipv4 and ipv6 rules.
Change-Id: Ibe61e3b218cf51a9da1f6118f23591de4ded113d
Signed-off-by: Aswin Suryanarayanan <asuryana@redhat.com>
Sam Hague [Thu, 8 Sep 2016 13:39:38 +0000 (13:39 +0000)]
Merge "Bug 6666: Making sure no 0 datapathID is used when adding interfaces to the model, and when the node updated with the datapathID, create the relevant interfaces"
Sam Hague [Thu, 8 Sep 2016 12:15:48 +0000 (12:15 +0000)]
Merge "Bug 6628 - Handling missing router entities DMAC table flows"
Sam Hague [Thu, 8 Sep 2016 12:11:46 +0000 (12:11 +0000)]
Merge "Bug 6609: when 2 vm belonging to the same NETWORK/SUBNET get created in different COMOUTE NODE - ping between those 2 did not work"
Sam Hague [Thu, 8 Sep 2016 12:07:31 +0000 (12:07 +0000)]
Merge "Support multiple routers per external GW"
Tomer [Wed, 7 Sep 2016 13:38:19 +0000 (16:38 +0300)]
Bug 6666: Making sure no 0 datapathID is used when adding interfaces to the model, and when the node updated with the datapathID, create the relevant interfaces
Change-Id: I213afac94544dc4e806cb684fc12126e358747b3
Signed-off-by: Tomer <tomer.pearl@hpe.com>
Stephen Kitt [Thu, 8 Sep 2016 11:45:35 +0000 (11:45 +0000)]
Merge "Fix bad design of AclClusterUtil to make it pluggable for e2e tests"
yair [Thu, 1 Sep 2016 11:11:56 +0000 (14:11 +0300)]
Bug 6628 - Handling missing router entities DMAC table flows
This is part of the L2 L3 pipeline reversal.
Change-Id: If91c3cf3a06ddfb5dbf1317fc8dea0a72616e25f
Signed-off-by: yair <yair.zinger@hpe.com>
Gobinath [Thu, 1 Sep 2016 12:59:07 +0000 (18:29 +0530)]
Bug 6609: when 2 vm belonging to the same NETWORK/SUBNET get created in different COMOUTE NODE - ping between those 2 did not work
Fix for avoiding race condition while programming remote BC
group in participating DPNs. With earlier code, there was a chance of this
group getting overwritten by another thread
Change-Id: I09ae213c69ae971011661e713aaa92788eec1ea7
Signed-off-by: Gobinath <gobinath@ericsson.com>
Koby Aizer [Thu, 1 Sep 2016 10:23:47 +0000 (13:23 +0300)]
Support multiple routers per external GW
Was finally able to see the basic tempest scenario test
passing with this patch! (with a small tempest workaround
to disable ping to router interface, which is currently not
supported in netvirt)
It includes the following changes:
* Create a vpninstance (with a new vpnId) for the neutron external network
* Associate the external interface with that vpninstance
* Partially revert changes done in [1] & [2], to make sure external
floating IP & NAT rules are associated with the new vpnId
* Fix ExternalNetworkGroupInstaller to look for the gateway IP in the
under the new vpnId. Also do some refactoring to allow better debug messages
for ARP resolving.
Also, drop traffic sent to external gw traffic if its mac is not resolved (Bug 6653)
This code leverages current implementation of NAT tables to translate external vpnId
to internal vpnIds for specific floating / PNAT IPs.
[1] https://git.opendaylight.org/gerrit/#/c/43303/
[2] https://git.opendaylight.org/gerrit/#/c/43102/
Change-Id: I8d3019389d7fe6fc923a509082e7a13d61a91444
Signed-off-by: Koby Aizer <koby.aizer@hpe.com>
Michael Vorburger [Fri, 2 Sep 2016 16:48:16 +0000 (18:48 +0200)]
Fix bad design of AclClusterUtil to make it pluggable for e2e tests
Having AclClusterUtil as a "Bean" with a @PostContruct start() method
but then a static method (isEntityOwner()) which relies on that start()
is bad design - it's either static or it's not, not half-half. It's
better not be static, and have an interface; this way the (upcoming)
end-to-end AclServiceTest can easily plug in an "always true"
implementation.
Change-Id: Ia2c07ba1cfc5b7447fcd10ad88e1008fca3df35f
Signed-off-by: Michael Vorburger <vorburger@redhat.com>
Sam Hague [Fri, 2 Sep 2016 20:05:25 +0000 (20:05 +0000)]
Merge "Fixes Bug 6624"
Sridhar Gaddam [Fri, 2 Sep 2016 11:35:30 +0000 (17:05 +0530)]
Bug 6623: Fix NPE in AclServiceUtils
This patch fixes couple of exceptions when an IPv6 address
is present in allowed_address_pairs.
Change-Id: If0660b299500b7c00609d97484ea42961bb73dd9
Signed-off-by: Sridhar Gaddam <sgaddam@redhat.com>
Signed-off-by: Aswin Suryanarayanan <asuryana@redhat.com>
Aswin Suryanarayanan [Fri, 2 Sep 2016 13:12:07 +0000 (18:42 +0530)]
Fixes Bug 6624
Null check is added for dpid and aclUuidList.
Change-Id: Ib11bcd599474d474ee8157d44249d0e82484363b
Signed-off-by: Aswin Suryanarayanan <asuryana@redhat.com>
Sam Hague [Thu, 1 Sep 2016 22:40:20 +0000 (22:40 +0000)]
Merge "Fix Checkstyle violations related to exception handling in elanmanager."
Sam Hague [Thu, 1 Sep 2016 22:29:05 +0000 (22:29 +0000)]
Merge "Fix NPE and other exceptions"
Michael Vorburger [Mon, 29 Aug 2016 12:07:07 +0000 (14:07 +0200)]
Fix Checkstyle violations related to exception handling in elanmanager.
read
https://wiki.opendaylight.org/view/BestPractices/Coding_Guidelines#IllegalCatch
This change also includes a few additional non-Exception handling
related minor Checkstyle fixes, and can now enable enforcement of
Checkstyle for elanmanager. (This is not directly related to the
exception handling fixes, but those were simply the last Checkstyle
violations left, and in order to ensure future non-regression, we can
now, finally, enable enforcement.)
Change-Id: If233f3d856b2f5402ef551f8ceceb242376b671c
Signed-off-by: Michael Vorburger <vorburger@redhat.com>
Signed-off-by: Sam Hague <shague@redhat.com>
Sam Hague [Thu, 1 Sep 2016 20:32:54 +0000 (16:32 -0400)]
Fix NPE and other exceptions
Change-Id: I691c475c6d032e543d741872afee7bbe8ec0c0ea
Signed-off-by: Sam Hague <shague@redhat.com>
Sam Hague [Thu, 1 Sep 2016 18:12:38 +0000 (14:12 -0400)]
Add config for neutronvpn
Change-Id: I63945c786808a93a8c825ee4862eb8f76cc7593c
Signed-off-by: Sam Hague <shague@redhat.com>
Sam Hague [Thu, 1 Sep 2016 18:38:26 +0000 (18:38 +0000)]
Merge "Use right docker instance"
Sam Hague [Thu, 1 Sep 2016 18:24:30 +0000 (18:24 +0000)]
Merge "Bug 6614: Fix NPE in AclInterfaceCacheUtil"
Sam Hague [Thu, 1 Sep 2016 18:21:38 +0000 (18:21 +0000)]
Merge "Fix FloatingIp add GARP handling"
Sam Hague [Thu, 1 Sep 2016 13:03:32 +0000 (09:03 -0400)]
Use right docker instance
Change-Id: Id30c7034674fdf08557a8fccd63a37b7b4fa1fed
Signed-off-by: Sam Hague <shague@redhat.com>
Slava [Thu, 1 Sep 2016 12:10:44 +0000 (15:10 +0300)]
Bug 6608: Solve TZ name mismatch
Change-Id: I1d567bec97773a44ce16f1127b4ee43bdb0cf1c5
Signed-off-by: Slava <slava.radune@hpe.com>
Sridhar Gaddam [Thu, 1 Sep 2016 15:24:12 +0000 (20:54 +0530)]
Bug 6614: Fix NPE in AclInterfaceCacheUtil
Change-Id: I9337c8fb2beffb6e5b07d186974c75a3ec25740f
Signed-off-by: Sridhar Gaddam <sgaddam@redhat.com>
Ravit Peretz [Wed, 31 Aug 2016 15:49:20 +0000 (18:49 +0300)]
Fix FloatingIp add GARP handling
Consolidate VpnFloatingIPHanlder
Send GARP only for VM OVS
Reuse SendArpRequestInput
Change-Id: I0ff992d3175470163a77f4f216c5febeeb6b53a3
Signed-off-by: Ravit Peretz <ravit.peretz@hpe.com>
Sam Hague [Thu, 1 Sep 2016 15:05:04 +0000 (15:05 +0000)]
Merge "BUG: 6582 copying DHCP service config file to etc/..config"
Sam Hague [Thu, 1 Sep 2016 14:02:38 +0000 (14:02 +0000)]
Merge "BUG 6598 listen to a change on BridgeRefEntry"
Sam Hague [Thu, 1 Sep 2016 14:01:35 +0000 (14:01 +0000)]
Merge "Fix NPE when updating vpnInterface"
Sam Hague [Thu, 1 Sep 2016 14:00:57 +0000 (14:00 +0000)]
Merge "Fix DMAC flows for Vlan E/W provider"
epgoraj [Wed, 31 Aug 2016 09:50:38 +0000 (15:20 +0530)]
BUG: 6582 copying DHCP service config file to etc/..config
Change-Id: Icaf6e9e9f18f70b74d98dcfbbbc6ba2b5f0531ad
Signed-off-by: epgoraj <p.govinda.rajulu@ericsson.com>
Shlomi [Wed, 31 Aug 2016 22:16:08 +0000 (01:16 +0300)]
BUG 6598 listen to a change on BridgeRefEntry
in cases a bridge is created without dpnId the creation of TZ fails. we need to re-try when the entry is updated.
Change-Id: Ifc808b8895911df69703adf4122828a7056a0d6e
Signed-off-by: Shlomi <shlomi.alfasi@hpe.com>
Stephen Kitt [Thu, 1 Sep 2016 08:19:27 +0000 (08:19 +0000)]
Merge "fix security groups IT"
Sam Hague [Thu, 1 Sep 2016 00:54:03 +0000 (20:54 -0400)]
fix security groups IT
Change-Id: I6cb9b226ed15241cb206e412352e9af02ef5a766
Signed-off-by: Sam Hague <shague@redhat.com>
Sam Hague [Thu, 1 Sep 2016 00:26:57 +0000 (00:26 +0000)]
Merge "Bug 6592: Adding output to group of external network when using NAPT"
Sam Hague [Wed, 31 Aug 2016 20:11:34 +0000 (20:11 +0000)]
Merge "Bug 6509 - External network group tables removal is not working - indirect type"
Sam Hague [Wed, 31 Aug 2016 20:05:51 +0000 (20:05 +0000)]
Merge "Reduce IPv6 Periodic Unsolicited RA timer interval"
Josh [Wed, 24 Aug 2016 18:30:09 +0000 (20:30 +0200)]
Fix DMAC flows for Vlan E/W provider
This fix addresses two bugs related only in that
they both prevent vlan provider networks from
working:
1) Wrong (remote) dmac flows generated for Vlan provider networks
https://bugs.opendaylight.org/show_bug.cgi?id=6583
2) Mac learning in vlan provider networks clobbers static flows with wrong flows
https://bugs.opendaylight.org/show_bug.cgi?id=6584
The fix for the (1) is to test if the net is
of type vlan and then retrieve the correct action.
The fix for (2) is to simply disable configuration
of remote dmac flows when the interface from whence
entered the unknown smac is a vlan or flat network
provider interface.
Change-Id: Id3431e94d96dac5230679fcb70fe0a79efbd96a4
Signed-off-by: Josh <jhershbe@redhat.com>
Koby Aizer [Wed, 24 Aug 2016 22:40:49 +0000 (01:40 +0300)]
Fix NPE when updating vpnInterface
Change-Id: Ib7c3a8ab804947d018fc21c2fedcbf8894346c03
Signed-off-by: Koby Aizer <koby.aizer@hpe.com>
Sridhar Gaddam [Wed, 31 Aug 2016 17:32:04 +0000 (23:02 +0530)]
Reduce IPv6 Periodic Unsolicited RA timer interval
In some situations it was noticed that flow programming is taking
some time. Due to this, the Router Soliciation requests from the
VMs are not punted to the controller (VMs are able to acquire IPv6
address only upon arrival of unsolicited Router Advts from the ODL
controller). Currently the periodic unsolicited RA interval is set
to 5 mins. This patch reduces the interval to 60 seconds to mitgate
such situations.
In a future patch, we would enhance the periodic RA interval to an
updated algorithm which will provide a better user experience.
Change-Id: I2eb4061b487cfa709ef02b7d093481799294adb3
Signed-off-by: Sridhar Gaddam <sgaddam@redhat.com>
Sam Hague [Wed, 31 Aug 2016 16:26:05 +0000 (16:26 +0000)]
Merge "BUG: 6569 Exceptions thrown while removing mac-entries"
Sam Hague [Wed, 31 Aug 2016 16:23:25 +0000 (16:23 +0000)]
Merge "aclservice Java @Inject etc. instead of XML for "inner" wiring"
Tomer [Mon, 29 Aug 2016 09:33:44 +0000 (12:33 +0300)]
Bug 6592: Adding output to group of external network when using NAPT
https://bugs.opendaylight.org/show_bug.cgi?id=6592
Change-Id: I40b40f5f65c177b3a77a3206c95a4720ed0e66de
Signed-off-by: Tomer <tomer.pearl@hpe.com>
yair [Wed, 31 Aug 2016 09:10:31 +0000 (12:10 +0300)]
Bug 6509 - External network group tables removal is not working - indirect type
Change external network group tables type to All instead of Indirect
This is a workaround fix to the 6509
https://bugs.opendaylight.org/show_bug.cgi?id=6509
The real cause for the bug will be solve in Openflowplugin in the future
https://bugs.opendaylight.org/show_bug.cgi?id=6492
Change-Id: I8bb48a644e6d815f1fe52588aef6ddc668df4956
Signed-off-by: yair <yair.zinger@hpe.com>
epgoraj [Wed, 31 Aug 2016 09:41:53 +0000 (15:11 +0530)]
BUG: 6569 Exceptions thrown while removing mac-entries
Change-Id: I40b3ad8865994f9481dedff3c14074dc55c9db9e
Signed-off-by: epgoraj <p.govinda.rajulu@ericsson.com>
Andre Fredette [Wed, 31 Aug 2016 03:28:33 +0000 (03:28 +0000)]
Merge "Fixes the SSH drop from DHCP namespace"
Sam Hague [Tue, 30 Aug 2016 21:12:28 +0000 (21:12 +0000)]
Merge "correct default prootcol handling in stateless ACL"
Sam Hague [Tue, 30 Aug 2016 21:12:05 +0000 (21:12 +0000)]
Merge "Bug 6559: Create TZ for routed networks"
Aswin Suryanarayanan [Tue, 30 Aug 2016 16:59:17 +0000 (22:29 +0530)]
Fixes the SSH drop from DHCP namespace
1)Changed netvirt neutron DCL to match the neutron object
representation.
2)Changed the TCP_SYN rule per to make it per port. Added IPv6 SYN drop
rule.
Change-Id: I94cef12de99f87b156e54cc07d7ea135a1549522
Signed-off-by: Aswin Suryanarayanan <asuryana@redhat.com>
Sam Hague [Tue, 30 Aug 2016 16:23:50 +0000 (16:23 +0000)]
Merge "Fixed the use of index NwConstants"
Sam Hague [Tue, 30 Aug 2016 16:23:40 +0000 (16:23 +0000)]
Merge "Bug 6486: add security-group-mode options"
Slava [Tue, 30 Aug 2016 10:15:44 +0000 (13:15 +0300)]
Bug 6559: Create TZ for routed networks
Change-Id: Id3fda9454b5c73aaa6c5de696036309a8cc0f53b
Signed-off-by: Slava <slava.radune@hpe.com>
Slava [Thu, 25 Aug 2016 12:25:39 +0000 (15:25 +0300)]
correct default prootcol handling in stateless ACL
Change-Id: I0f87bfc77bd8c2d44fb4f8c522486779138a9df2
Signed-off-by: Slava <slava.radune@hpe.com>
Sam Hague [Tue, 30 Aug 2016 12:39:45 +0000 (12:39 +0000)]
Merge "Fix Checkstyle violations (formatting only, no real changes)"
Sam Hague [Tue, 30 Aug 2016 12:33:06 +0000 (12:33 +0000)]
Merge "Bug 6556 - Fix to send the first unsolicited RA message for a Router interface"
yair [Thu, 25 Aug 2016 09:52:16 +0000 (12:52 +0300)]
Fixed the use of index NwConstants
There was a change to support L2 before L3
https://git.opendaylight.org/gerrit/#/c/43126/
Change the use of constnats to the new way of work
Change-Id: I493e80fac8c49d667cf7d9a498d0f7a82892b687
Signed-off-by: yair <yair.zinger@hpe.com>
Sam Hague [Mon, 29 Aug 2016 21:30:15 +0000 (17:30 -0400)]
Bug 6486: add security-group-mode options
Change-Id: I62d46b4fec6f2e406b319972a068671647330477
Signed-off-by: Sam Hague <shague@redhat.com>
Anil Vishnoi [Mon, 29 Aug 2016 19:14:11 +0000 (12:14 -0700)]
Bug 6555 - Translation layer skip the RSP creation API call
Change-Id: Id02c7efed8d78960c7b74c813980b42a88335143
Signed-off-by: Anil Vishnoi <vishnoianil@gmail.com>
kalaiselvik [Mon, 29 Aug 2016 09:48:01 +0000 (15:18 +0530)]
Bug 6556 - Fix to send the first unsolicited RA message for a Router interface
On creation of the router interface, the 1st unsolicited RA is sent before
the association of the subnets with the interface. So the RA packet was not
transmitted as no valid gateway address was available for the interface.
The unsolicited RA is tranmitted after network/subnet association.
Change-Id: Ifcf8e0dbe395070ff2a1731b9cf2c151ed024e9d
Signed-off-by: kalaiselvik <Kalaiselvi_K@Dell.com>
Michael Vorburger [Mon, 29 Aug 2016 10:59:42 +0000 (12:59 +0200)]
Fix Checkstyle violations (formatting only, no real changes)
All of changes made here are purely "formatting", and none change code
behaviour in any way. This should thus be safe to merge ASAP.
Change-Id: I9214f254426aae90b20d31c73422363ca69b177e
Signed-off-by: Michael Vorburger <vorburger@redhat.com>
Sam Hague [Fri, 26 Aug 2016 21:04:45 +0000 (21:04 +0000)]
Merge "fix checkstyle for NetvirtIT"
Sam Hague [Fri, 26 Aug 2016 20:42:40 +0000 (16:42 -0400)]
fix checkstyle for NetvirtIT
Change-Id: I51517f242d063ab2b68be692a96cf7c7b24bfec8
Signed-off-by: Sam Hague <shague@redhat.com>
Sam Hague [Fri, 26 Aug 2016 19:55:32 +0000 (19:55 +0000)]
Merge "Fix broken legacy NetvirtIT"