mdsal.git
7 years agoRecover removed test case for JavaIdentifierNormalizerTest 36/59236/1
Jakub Toth [Tue, 20 Jun 2017 13:37:45 +0000 (15:37 +0200)]
Recover removed test case for JavaIdentifierNormalizerTest

Change-Id: Ia4064aec360e3e5f31a1322ded0730ca746f6bdf
Signed-off-by: Jakub Toth <jakub.toth@pantheon.tech>
7 years agoBinding v2 runtime - adapters - impl - operations invoker 70/59170/10
Jakub Toth [Mon, 19 Jun 2017 13:38:57 +0000 (15:38 +0200)]
Binding v2 runtime - adapters - impl - operations invoker

  * added marker for operations

Change-Id: I7bf7144bf35882694c7223d6b3e5e2196757bd12
Signed-off-by: Jakub Toth <jakub.toth@pantheon.tech>
7 years agoBinding v2 runtime - adapters - impl - notifications 71/59071/11
Jakub Toth [Fri, 16 Jun 2017 10:54:20 +0000 (12:54 +0200)]
Binding v2 runtime - adapters - impl - notifications

Change-Id: Ibfff70b6f4e9c5e4c7c198c95fb41ac278301eca
Signed-off-by: Jakub Toth <jakub.toth@pantheon.tech>
7 years agoBinding generator v2 - augments fix #3 99/59199/5
Jie Han [Tue, 20 Jun 2017 07:11:24 +0000 (15:11 +0800)]
Binding generator v2 - augments fix #3

- handle Choice Cases augmentation
- add test yangs
- delete deprecated methods and fix tests
Change-Id: I78724808fcf4d5451cf2e0df29edf829abadb8dc
Signed-off-by: Jie Han <han.jie@zte.com.cn>
7 years agoBinding generator v2 - augments fix #2 83/59083/12
Martin Ciglan [Fri, 16 Jun 2017 13:44:22 +0000 (15:44 +0200)]
Binding generator v2 - augments fix #2

- handle uses-augment statements
for grouped augments by target path
- testing yang(s) included

- augmentations in groupings

TODO #3 Choice Cases

Change-Id: Ie670c03992bc41bb3e2f6efc1367f9bdf18da1b5
Signed-off-by: Martin Ciglan <martin.ciglan@pantheon.tech>
Signed-off-by: Jie Han <han.jie@zte.com.cn>
7 years agoBinding generator v2 - Namespace - Typedef package name fix 65/59065/6
Jie Han [Fri, 16 Jun 2017 09:37:05 +0000 (17:37 +0800)]
Binding generator v2 - Namespace - Typedef package name fix

- add namespace to typedef type package name:
  bits, unions, enumerations
Change-Id: Ifabac091c59e44780cdde34a18b6790c3b046d69
Signed-off-by: Jie Han <han.jie@zte.com.cn>
7 years agoBinding generator v2 - augments fix #1 26/59026/8
Martin Ciglan [Thu, 15 Jun 2017 05:56:51 +0000 (07:56 +0200)]
Binding generator v2 - augments fix #1

- group augments by target path and generate code
accordingly.

TODO #2 uses-augment
     #3 augmented choice-cases

Note: ignore some of failing existing tests
      until all work here is done

Explanation:

yang snippet

   container foo {
        leaf my-leaf {
            type string;
        }
    }

    augment /foo:foo {
        leaf bar {
            type string;
        }
    }

    augment /foo:foo {
        leaf baz {
            type string;
        }
    }

produces same generated code as

   container foo {
        leaf my-leaf {
            type string;
        }
    }

    augment /foo:foo {
        leaf bar {
            type string;
        }
        leaf baz {
            type string;
        }
    }

Change-Id: I2bdb3ecf22bf2cb72fab3080f2b40748775ba49b
Signed-off-by: Martin Ciglan <martin.ciglan@pantheon.tech>
7 years agoBinding v2 runtime - adapters - impl - mount point 31/59031/6
Jakub Toth [Thu, 15 Jun 2017 13:02:40 +0000 (15:02 +0200)]
Binding v2 runtime - adapters - impl - mount point

Change-Id: Ie714a6d22f5fcf033b8ba157bd3fae9772846807
Signed-off-by: Jakub Toth <jakub.toth@pantheon.tech>
7 years agoBinding v2 runtime - adapters - transactions 30/59030/6
Jakub Toth [Thu, 15 Jun 2017 12:44:50 +0000 (14:44 +0200)]
Binding v2 runtime - adapters - transactions

Change-Id: I2b9734de0662c96d8388516024034da4240a3141
Signed-off-by: Jakub Toth <jakub.toth@pantheon.tech>
7 years agoBinding v2 runtime - adapters - impl - data tree 29/59029/5
Jakub Toth [Thu, 15 Jun 2017 12:17:16 +0000 (14:17 +0200)]
Binding v2 runtime - adapters - impl - data tree

Change-Id: Ice951cd38386a50efdf084f209faa5a902817e48
Signed-off-by: Jakub Toth <jakub.toth@pantheon.tech>
7 years agoBinding v2 runtime - adapters - registration 62/58962/5
Jakub Toth [Wed, 14 Jun 2017 16:14:28 +0000 (18:14 +0200)]
Binding v2 runtime - adapters - registration

Change-Id: Ibb2dfbfa869852fda66972395d6a2a54633e7909
Signed-off-by: Jakub Toth <jakub.toth@pantheon.tech>
7 years agoBinding v2 runtime - adapters - spi 47/58947/7
Jakub Toth [Wed, 14 Jun 2017 12:44:16 +0000 (14:44 +0200)]
Binding v2 runtime - adapters - spi

Change-Id: I824c5c29fd71ad288df0b3ef9fbeedbc760b98dc
Signed-off-by: Jakub Toth <jakub.toth@pantheon.tech>
7 years agoBinding v2 runtime - adapters - extractors 46/58946/6
Jakub Toth [Wed, 14 Jun 2017 10:06:45 +0000 (12:06 +0200)]
Binding v2 runtime - adapters - extractors

Change-Id: I0ee755ae25ad772b844ce70c3afdb76ba25d3b15
Signed-off-by: Jakub Toth <jakub.toth@pantheon.tech>
7 years agoBinding2 runtime - Codecs - serialized 12/58812/8
Jakub Toth [Tue, 13 Jun 2017 12:08:00 +0000 (14:08 +0200)]
Binding2 runtime - Codecs - serialized

Change-Id: I45eef52b91b0a493d7352a7ea46479cb9fff709e
Signed-off-by: Jakub Toth <jakub.toth@pantheon.tech>
7 years agoBinding v2 runtime - codecs - modificators 11/58811/12
Jakub Toth [Tue, 13 Jun 2017 09:54:00 +0000 (11:54 +0200)]
Binding v2 runtime - codecs - modificators

Change-Id: Ifd0512bbcb2c6de7cf2d02feedc8976ddd325e61
Signed-off-by: Jakub Toth <jakub.toth@pantheon.tech>
7 years agoBinding2 runtime - Codecs impl - codecs - part4 43/58743/14
Jakub Toth [Mon, 12 Jun 2017 11:18:41 +0000 (13:18 +0200)]
Binding2 runtime - Codecs impl - codecs - part4

Change-Id: I65a814a2f84ecfae51ea1f67f7cded48622096a8
Signed-off-by: Jakub Toth <jakub.toth@pantheon.tech>
7 years agoBinding generator v2 - Decimal* - getDefaultInstance() fix 56/59056/3
Jie Han [Fri, 16 Jun 2017 06:15:21 +0000 (14:15 +0800)]
Binding generator v2 - Decimal* - getDefaultInstance() fix

- add testing yang
Change-Id: I8b5761ee0f65dcbb9df17d858b97e2eafb10594b
Signed-off-by: Jie Han <han.jie@zte.com.cn>
7 years agoBinding generator v2 - Bits - getDefaultInstance() fix 54/59054/3
Jie Han [Fri, 16 Jun 2017 04:00:25 +0000 (12:00 +0800)]
Binding generator v2 - Bits - getDefaultInstance() fix

- add testing yang
Change-Id: I8e35707f65b3c1800545e36b48abbc97b3c212e5
Signed-off-by: Jie Han <han.jie@zte.com.cn>
7 years agoBinding generator v2 - Identityref - Compilability fix 10/59010/4
Jie Han [Thu, 15 Jun 2017 10:05:12 +0000 (18:05 +0800)]
Binding generator v2 - Identityref - Compilability fix

- only one base support currently
- add testing yang
Change-Id: I5e277fcfbf5e92bdc31420dfefaa04d0d68b47c4
Signed-off-by: Jie Han <han.jie@zte.com.cn>
7 years agoBinding generator v2 - Augmentation - Fix package name for recursively uses augment 46/57746/24
Jie Han [Wed, 24 May 2017 08:15:08 +0000 (16:15 +0800)]
Binding generator v2 - Augmentation - Fix package name for recursively uses augment

- Fix package name for recursively uses augmentation, the yang file like:
         ...
         grouping D{
                uses "grp:A" {
                    augment "A1/A1-inner" {
                        leaf D-aug-A1 {
                            type string;
                        }
                        uses B {
                            augment "B1/B1-inner" {
                                 leaf D-aug-B1-inner {
                                      type string;
                                 }
                                 uses C {
                                         augment  "C1/C1-inner" {
                                              leaf D-aug-C1-inner {
                                                   type string;
                                              }
                                         }
                                     }
                            }

                        }

                    }
                }
            }
       ...
- add UT and yang file

Change-Id: If0b1131f15ab42be5c64a0fd087bd2a14a6597ce
Signed-off-by: Jie Han <han.jie@zte.com.cn>
7 years agoBinding generator v2 - Package name 79/58479/17
Jie Han [Thu, 8 Jun 2017 08:30:29 +0000 (16:30 +0800)]
Binding generator v2 - Package name

Change-Id: I65f291fe09a8e355545d6b218386b3cf9f0d27b1
Signed-off-by: Jie Han <han.jie@zte.com.cn>
7 years agoBinding generator v2 - Enumeration fix 74/58674/16
Jie Han [Sun, 11 Jun 2017 02:23:22 +0000 (10:23 +0800)]
Binding generator v2 - Enumeration fix

Change-Id: Ic1368cbb398d72b25830549cd0ec8bd32dad787a
Signed-off-by: Jie Han <han.jie@zte.com.cn>
7 years agoBinding generator v2 - Instantiable compilability fix 81/58781/14
Jie Han [Tue, 13 Jun 2017 03:07:07 +0000 (11:07 +0800)]
Binding generator v2 - Instantiable compilability fix

Change-Id: I43f784d724f8d29bda669a043015944d78ed3597
Signed-off-by: Jie Han <han.jie@zte.com.cn>
7 years agoBinding generator v2 - Unions - Union's builder fix 23/58923/10
Jie Han [Wed, 14 Jun 2017 07:59:49 +0000 (15:59 +0800)]
Binding generator v2 - Unions - Union's builder fix

- fix return type name of treeIdentifier with fully qualified name
  to avoid name conflict
- recursive unoin builder support
- add yang file
Change-Id: I8770b849e6e50c04633eecb067d0f1d83bffb2c8
Signed-off-by: Jie Han <han.jie@zte.com.cn>
7 years agoBinding generator v2 - Unions - fix getValue() 40/58340/33
Jie Han [Tue, 6 Jun 2017 12:05:33 +0000 (20:05 +0800)]
Binding generator v2 - Unions - fix getValue()

- set value NOT ReadOnly
- fix type instance identifier package
Change-Id: I8cfa676111952b169d6d6f31ce902adcce5bf45b
Signed-off-by: Jie Han <han.jie@zte.com.cn>
7 years agoBinding generator v2 - Unions - Enclosing type fix 04/58504/30
Jie Han [Thu, 8 Jun 2017 12:31:18 +0000 (20:31 +0800)]
Binding generator v2 - Unions - Enclosing type fix

- fix enclosing type for recursive unoins
- fix package name for reursive  inner class
Change-Id: Ie1bd0df3afc1d600d94ff73b0c97aa349c242c78
Signed-off-by: Jie Han <han.jie@zte.com.cn>
7 years agoBinding2 runtime - Codecs impl - tests 81/58581/13
Jakub Toth [Fri, 9 Jun 2017 08:22:01 +0000 (10:22 +0200)]
Binding2 runtime - Codecs impl - tests

Change-Id: Id6f1fc05bcdc7c156eb66b6c50f483b93d772bf7
Signed-off-by: Jakub Toth <jakub.toth@pantheon.tech>
7 years agoBinding2 runtime - Codecs 59/58559/14
Jakub Toth [Thu, 8 Jun 2017 23:07:04 +0000 (01:07 +0200)]
Binding2 runtime - Codecs

  * new codecs and contexts
  * BindingContextCodec
  * BindingNormalizdeNodeCodecRegistry

Change-Id: Ieab1cac667f755962b818c452171da9dc74ab979
Signed-off-by: Jakub Toth <jakub.toth@pantheon.tech>
7 years agoBinding2 runtime - Module info context 34/58534/16
Jakub Toth [Thu, 8 Jun 2017 16:31:19 +0000 (18:31 +0200)]
Binding2 runtime - Module info context

  * fix template for yangModuleInfo baed on change in
    YangModuleInfo interface

Change-Id: I3161bc19559b1bd38bccaf2148a6745c12141745
Signed-off-by: Jakub Toth <jakub.toth@pantheon.tech>
7 years agoBinding2 runtime - Codecs impl - codecs - part3 33/58533/15
Jakub Toth [Thu, 8 Jun 2017 16:21:43 +0000 (18:21 +0200)]
Binding2 runtime - Codecs impl - codecs - part3

Change-Id: Ice1f15d71425020e3002d408be6652e9032ca3cf
Signed-off-by: Jakub Toth <jakub.toth@pantheon.tech>
7 years agoBinding2 runtime - Codecs impl - context - part3 32/58532/16
Jakub Toth [Thu, 8 Jun 2017 16:00:01 +0000 (18:00 +0200)]
Binding2 runtime - Codecs impl - context - part3

  * contexts based on operation codecs

Change-Id: Ide1797b1b4cb2f665e2708c3c1697aca063489bd
Signed-off-by: Jakub Toth <jakub.toth@pantheon.tech>
7 years agoBinding2 runtime - Codecs impl - codecs - part2 31/58531/15
Jakub Toth [Thu, 8 Jun 2017 15:58:47 +0000 (17:58 +0200)]
Binding2 runtime - Codecs impl - codecs - part2

  * operation codecs

Change-Id: I8c08617ec52d47b424d41aa04c7bf574055f1662
Signed-off-by: Jakub Toth <jakub.toth@pantheon.tech>
7 years agoBinding2 runtime - Codecs impl - context - part2 23/58523/15
Jakub Toth [Thu, 8 Jun 2017 15:31:33 +0000 (17:31 +0200)]
Binding2 runtime - Codecs impl - context - part2

  * derived parts
  * fixed base parts

Change-Id: Ib46351557a42e914bba3c4a34abf2ef94ec9bb80
Signed-off-by: Jakub Toth <jakub.toth@pantheon.tech>
7 years agoBinding2 runtime - Codecs impl - codecs 22/58522/11
Jakub Toth [Thu, 8 Jun 2017 10:15:35 +0000 (12:15 +0200)]
Binding2 runtime - Codecs impl - codecs

  * remove codec.*.codecs packages

Change-Id: I17897e62d5343ee059489a999d68c6bab0fe9c2c
Signed-off-by: Jakub Toth <jakub.toth@pantheon.tech>
7 years agoMigrate to odlparent 1.9.0 44/58844/1
Thanh Ha [Tue, 13 Jun 2017 18:39:24 +0000 (14:39 -0400)]
Migrate to odlparent 1.9.0

Change-Id: I100a35acd3f47c49cb7d93a972f6c01a4804b446
Signed-off-by: Thanh Ha <thanh.ha@linuxfoundation.org>
7 years agoBug 8634: list & leaf-list compilability fix 05/58805/5
Martin Ciglan [Tue, 13 Jun 2017 10:39:12 +0000 (12:39 +0200)]
Bug 8634: list & leaf-list compilability fix

- compilability fix for list & leaf-list generated code
- tested yangs
- make sure 'leaf key' as key makes no harm

Change-Id: I1b4e5f4ac7c0070672d6a33b0db62976c2b3f507
Signed-off-by: Martin Ciglan <martin.ciglan@pantheon.tech>
7 years agoBinding2 runtime - Codecs impl - cache 06/58406/16
Jakub Toth [Wed, 7 Jun 2017 11:29:57 +0000 (13:29 +0200)]
Binding2 runtime - Codecs impl - cache

  * caching data part

Change-Id: If0b595c4c50dd3a0741629432623210c31bce381
Signed-off-by: Jakub Toth <jakub.toth@pantheon.tech>
7 years agoBinding2 runtime - Codecs impl - writers 05/58405/14
Jakub Toth [Wed, 7 Jun 2017 10:18:19 +0000 (12:18 +0200)]
Binding2 runtime - Codecs impl - writers

  * writers of Binding v2 and DOM for serializing data

Change-Id: I947f902f8acd97c67646b65750edf470f04ccc3e
Signed-off-by: Jakub Toth <jakub.toth@pantheon.tech>
7 years agoAdd endline to gettermethod and property 33/58333/14
Jie Han [Tue, 6 Jun 2017 11:29:42 +0000 (19:29 +0800)]
Add endline to gettermethod and property

Change-Id: I6bec99d905e1021e064bd5d9b66858782b7b2f4f
Signed-off-by: Jie Han <han.jie@zte.com.cn>
7 years agoBinding2 runtime - Codecs impl - context 04/58404/12
Jakub Toth [Wed, 7 Jun 2017 09:18:30 +0000 (11:18 +0200)]
Binding2 runtime - Codecs impl - context

  * derived contexts
  * fixed based contexts

Change-Id: I2900f4356a7750553180a043d450b3f279c99d63
Signed-off-by: Jakub Toth <jakub.toth@pantheon.tech>
7 years agoBinding2 runtime - Codecs impl #2 53/58253/16
Martin Ciglan [Mon, 5 Jun 2017 14:27:47 +0000 (16:27 +0200)]
Binding2 runtime - Codecs impl #2

- NodeCodecContext & relatives

TODO: test coverage

Change-Id: I024618f2b80207e47eec85819390868ee34b6407
Signed-off-by: Martin Ciglan <martin.ciglan@pantheon.tech>
7 years agoBinding v2 runtime - refactor - part3 13/58613/8
Jakub Toth [Fri, 9 Jun 2017 13:09:22 +0000 (15:09 +0200)]
Binding v2 runtime - refactor - part3

  * various runtime classes lost in generator or even spec v2 packages
    are grouped in new runtime v2 module and used in runtime v2
  * move javassist part from spec

Change-Id: I87522a6f79f7bcc0ebcb66a87cedd75e506b51a8
Signed-off-by: Jakub Toth <jakub.toth@pantheon.tech>
7 years agoBinding v2 runtime - refactor - part2 12/58612/8
Jakub Toth [Fri, 9 Jun 2017 13:04:12 +0000 (15:04 +0200)]
Binding v2 runtime - refactor - part2

  * various runtime classes lost in generator or even spec v2 packages
    are grouped in new runtime v2 module and used in runtime v2
  * move AugmentationFieldGetter and BindingReflections
  * move tests

Change-Id: I61459f6a392890e2a2c038ab25e4592c2b135e05
Signed-off-by: Jakub Toth <jakub.toth@pantheon.tech>
7 years agoBinding v2 runtime - refactor - part1 11/58611/7
Jakub Toth [Fri, 9 Jun 2017 12:41:16 +0000 (14:41 +0200)]
Binding v2 runtime - refactor - part1

  * various runtime classes lost in generator or even spec v2 packages
    are grouped in new runtime v2 module and used in runtime v2
  * move BindingRuntimeContext and BindingSchemaContextUtils

Change-Id: Iad8316c29a424b3dae881849d0c59c261d608629
Signed-off-by: Jakub Toth <jakub.toth@pantheon.tech>
7 years agoBinding v2 runtime - init modul 10/58610/5
Jakub Toth [Fri, 9 Jun 2017 12:03:47 +0000 (14:03 +0200)]
Binding v2 runtime - init modul

  * various runtime classes lost in generator or even spec v2 packages
    are grouped in new runtime v2 module and used in runtime v2

Change-Id: Ie9b2d8e9c25076301e87728061969e7ff7607a1b
Signed-off-by: Jakub Toth <jakub.toth@pantheon.tech>
7 years agoSupport for Yang 1.1 Anydata statement in mdsal-binding2-generator 75/58475/4
Martin Ciglan [Thu, 8 Jun 2017 07:11:27 +0000 (09:11 +0200)]
Support for Yang 1.1 Anydata statement in mdsal-binding2-generator

- able to recognize anydata statement in root or data schema node
- generate type & Java code for it
- YANG test example

Change-Id: I79baeb831ed1b663d332800cca556f6e1dc53cb6
Signed-off-by: Martin Ciglan <martin.ciglan@pantheon.tech>
7 years ago Add implement type 'BindingTypes.INSTANTIABLE' to augment type 40/57740/6
Jie Han [Wed, 24 May 2017 03:06:02 +0000 (11:06 +0800)]
 Add implement type 'BindingTypes.INSTANTIABLE' to augment type
 -Add implement type 'BindingTypes.INSTANTIABLE' to augment type
 to replace 'DataObject' as to  override the interface "implementedInterface"
 in it's builder.

Change-Id: I2ece953f805a8246a3f1ca7532e5c170047eff44
Signed-off-by: Jie Han <han.jie@zte.com.cn>
7 years agoBinding v2 DOM Codec - generator - SPI - part 2 49/58349/12
Jakub Toth [Tue, 6 Jun 2017 13:20:02 +0000 (15:20 +0200)]
Binding v2 DOM Codec - generator - SPI - part 2

  * prepare base SPI parts of generating serializers for writers
  * added implementation of StreamWriterGenerator

Change-Id: I9445495e5893296e1384b258856eca8236ea6698
Signed-off-by: Jakub Toth <jakub.toth@pantheon.tech>
7 years agoBinding v2 DOM Codec - choice serializer implementation 48/58348/10
Jakub Toth [Tue, 6 Jun 2017 13:18:42 +0000 (15:18 +0200)]
Binding v2 DOM Codec - choice serializer implementation

Change-Id: I2147b0ef3e254d552134ccf371a25fcdb18fe402
Signed-off-by: Jakub Toth <jakub.toth@pantheon.tech>
7 years agoBinding v2 DOM Codec - generator - SPI - part 1 27/58327/14
Jakub Toth [Tue, 6 Jun 2017 12:30:27 +0000 (14:30 +0200)]
Binding v2 DOM Codec - generator - SPI - part 1

 * prepare base SPI parts of generating serializers for writers
 * add missing method to GeneratedClassLoadingStrategy
   * resolving class from class loader according to fully qualified
     name
 * checkstyle issues solved

Change-Id: I55aa8286c8d02c69db2af3534076c13f443d7544
Signed-off-by: Jakub Toth <jakub.toth@pantheon.tech>
7 years agoBinding v2 DOM Codec - augmentation 45/58345/11
Jakub Toth [Tue, 6 Jun 2017 12:29:06 +0000 (14:29 +0200)]
Binding v2 DOM Codec - augmentation

  * api for augmentation
  * impl of agumentation serializer
  * fix jdoc in spec
    * use of TreeNode instead of DataObject

Change-Id: I7c6ec42ddb8bc7f3957e3a82b55fb982fab6de4d
Signed-off-by: Jakub Toth <jakub.toth@pantheon.tech>
7 years agoBinding generator v2 - leaf-list support 15/58615/1
Martin Ciglan [Fri, 9 Jun 2017 13:27:22 +0000 (15:27 +0200)]
Binding generator v2 - leaf-list support

- generate types & Java code
- test yang file

Change-Id: Idccbcf49bddb7a465e5951d5fa5490e0304bf7f8
Signed-off-by: Martin Ciglan <martin.ciglan@pantheon.tech>
7 years agoBinding generator v2 - Choice/Cases support 83/58583/2
Martin Ciglan [Fri, 9 Jun 2017 09:09:53 +0000 (11:09 +0200)]
Binding generator v2 - Choice/Cases support

- generate types & Java code
- builder template fix
- test yang file

Change-Id: Ia001b5e02a3b2e870ae0b46f59a7a9546395b48b
Signed-off-by: Martin Ciglan <martin.ciglan@pantheon.tech>
7 years agoBug 8583 - Duplicate appending rank to augement class 70/58170/4
Jie Han [Fri, 2 Jun 2017 08:46:43 +0000 (16:46 +0800)]
Bug 8583 - Duplicate appending rank to augement class

- The rank was appended repeatedly in both ReferencedTypeImpl
  and addRawAugmentGenTypeDefinition

Change-Id: If139626f4fafd2824f9c24437918067e78a909b2
Signed-off-by: Jie Han <han.jie@zte.com.cn>
7 years agoBug 8593 - Augmentation's Builder overrides a method from interface Augmentable. 35/58235/5
Jie Han [Mon, 5 Jun 2017 11:05:38 +0000 (19:05 +0800)]
Bug 8593 - Augmentation's Builder overrides a method from interface Augmentable.

Change-Id: I87b5b66679aa8825f4ce46e6c25a2d05eba680dd
Signed-off-by: Jie Han <han.jie@zte.com.cn>
7 years agoBug 8575 - IllegalArgumentException thrown when uses a grouping which name is not... 90/58090/11
Jie Han [Thu, 1 Jun 2017 02:43:29 +0000 (10:43 +0800)]
Bug 8575 - IllegalArgumentException thrown when uses a grouping which name is not unique

- find target uses grouping which name is not unique
- add JUnit Test and Yang file
Change-Id: Idc0d782a2443ed2cd3339f4f7ed4c712a04a60fe
Signed-off-by: Jie Han <han.jie@zte.com.cn>
7 years agoBug 706: - Missing support for anyxml statement in java generator and mapping service 13/58413/7
Martin Ciglan [Wed, 7 Jun 2017 13:36:40 +0000 (15:36 +0200)]
Bug 706: - Missing support for anyxml statement in java generator and mapping service

- basic logic to recognize anyxml node within root or data schema node
- generate type and Java code for it

Change-Id: I0a7dd00661b569dd76d95b6404e4590f6544e415
Signed-off-by: Martin Ciglan <martin.ciglan@pantheon.tech>
7 years agoBinding generator v2 - Unions compilability fix 25/58225/4
Martin Ciglan [Mon, 5 Jun 2017 07:19:13 +0000 (09:19 +0200)]
Binding generator v2 - Unions compilability fix

Change-Id: I8ae28571069c2d0f966d9953f43229bce941083f
Signed-off-by: Martin Ciglan <martin.ciglan@pantheon.tech>
7 years agoBinding v2 DOM Codec - generator - base implementation 52/58252/10
Jakub Toth [Mon, 5 Jun 2017 14:00:09 +0000 (16:00 +0200)]
Binding v2 DOM Codec - generator - base implementation

 * prototype of implementation of tree node serializer
 * static property for Binding objects

Change-Id: I67ba59924044adf12bed0bd2293f91ddf3f02025
Signed-off-by: Jakub Toth <jakub.toth@pantheon.tech>
7 years agoBinding v2 DOM Codec - generator - API 51/58251/9
Jakub Toth [Mon, 5 Jun 2017 13:32:39 +0000 (15:32 +0200)]
Binding v2 DOM Codec - generator - API

  * api for getting serializer fo specific type

Change-Id: I04288cf4d514193a1bae363781a29517cf5adb2f
Signed-off-by: Jakub Toth <jakub.toth@pantheon.tech>
7 years agoBinding v2 DOM Codec - Javassist part 26/58326/6
Jakub Toth [Tue, 6 Jun 2017 08:33:16 +0000 (10:33 +0200)]
Binding v2 DOM Codec - Javassist part

Change-Id: I9f07629ef79729650e44b1caba239a25a23db81e
Signed-off-by: Jakub Toth <jakub.toth@pantheon.tech>
7 years agoAdd version declaration 61/58361/1
Robert Varga [Tue, 6 Jun 2017 17:57:54 +0000 (19:57 +0200)]
Add version declaration

This is another missed version declaration.

Change-Id: I2b3674b830a71cefd7b925434e019f179a78ea25
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
7 years agoFix missing version declaration 57/58357/1
Robert Varga [Tue, 6 Jun 2017 16:52:45 +0000 (18:52 +0200)]
Fix missing version declaration

Change-Id: I39ed597273861b0c3792c00217ee4c417a4da5ef
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
7 years agoMigrate to odlparent 1.8.0-Carbon 95/58295/2
Thanh Ha [Tue, 6 Jun 2017 02:13:13 +0000 (22:13 -0400)]
Migrate to odlparent 1.8.0-Carbon

Per request of odlparent project we are downgrading all Nitrogen
projects to use the released odlparent 1.8.0-Carbon to allow for the
odlparent project to start performing semver style releases.

Jira: RELENG-159
RT: 41406
Change-Id: Ica7007072c5f10e052c4aab6c46feb26e89c5915
Signed-off-by: Thanh Ha <thanh.ha@linuxfoundation.org>
7 years agoBinding2 runtime - Codecs impl #1 28/58228/3
Martin Ciglan [Mon, 5 Jun 2017 09:02:30 +0000 (11:02 +0200)]
Binding2 runtime - Codecs impl #1

- value based codecs & relatives

TODO: more Javadocs, test coverage

Change-Id: I1c780772ea93d613c4e220ded61c07d6582c8954
Signed-off-by: Martin Ciglan <martin.ciglan@pantheon.tech>
7 years agoBinding v2 DOM Codec - codecs API - Part 2 03/58103/10
Jakub Toth [Thu, 1 Jun 2017 09:53:59 +0000 (11:53 +0200)]
Binding v2 DOM Codec - codecs API - Part 2

  *factory
  *serializer

Change-Id: I63ef1b59b31514e8e6d583d3b9aaa17ad1224365
Signed-off-by: Jakub Toth <jakub.toth@pantheon.tech>
7 years agoBinding v2 runtime context 99/58099/13
Jakub Toth [Thu, 1 Jun 2017 06:10:08 +0000 (08:10 +0200)]
Binding v2 runtime context

  *preparing of binding runtime context via reflection
  *tests

Change-Id: I02a3e568942fe4f31621299c12bf978bcaa4940b
Signed-off-by: Jakub Toth <jakub.toth@pantheon.tech>
7 years agoBinding v2 DOM Codec - codecs API - Part 1 36/58036/13
Jakub Toth [Wed, 31 May 2017 09:12:10 +0000 (11:12 +0200)]
Binding v2 DOM Codec - codecs API - Part 1

  * normalized node codec
  * tree codec
  * tree node codec

Change-Id: Id58cf84d337ce310afb889c54f913fdbb59d79b0
Signed-off-by: Jakub Toth <jakub.toth@pantheon.tech>
7 years agoBinding spec runtime v2 - TreeNodeSerializer & relatives 32/58032/6
Martin Ciglan [Wed, 31 May 2017 07:54:10 +0000 (09:54 +0200)]
Binding spec runtime v2 - TreeNodeSerializer & relatives

Change-Id: I6ad9cf2f0fc6fb9b55c7ba788fa6ece86ba7f8c0
Signed-off-by: Martin Ciglan <martin.ciglan@pantheon.tech>
7 years agoBinding2 runtime - API #7 73/57773/17
Martin Ciglan [Wed, 24 May 2017 13:44:29 +0000 (15:44 +0200)]
Binding2 runtime - API #7

- NotificationPublishService & its relatives
- test coverage for classes
- Javadocs provided

Change-Id: I888f72924d8fe38e76f0990fec34b040824439c6
Signed-off-by: Martin Ciglan <martin.ciglan@pantheon.tech>
7 years agoBinding2 runtime - API #6 71/57771/18
Martin Ciglan [Wed, 24 May 2017 13:09:53 +0000 (15:09 +0200)]
Binding2 runtime - API #6

- DataTreeCommitCohortRegistry & its relatives
- Javadocs provided

Change-Id: I86f5771140f7c151dfad78b0066cc8d0b8790625
Signed-off-by: Martin Ciglan <martin.ciglan@pantheon.tech>
7 years agoBinding2 runtime - API #5 65/57665/18
Martin Ciglan [Tue, 23 May 2017 09:15:50 +0000 (11:15 +0200)]
Binding2 runtime - API #5

- Rpc, Action, ListAction API support
- Javadocs provided

Change-Id: I8250bf00579c5743be50d3fcf8296fddb3be1d69
Signed-off-by: Martin Ciglan <martin.ciglan@pantheon.tech>
7 years agoBinding2 runtime - API #4 61/57661/17
Martin Ciglan [Tue, 23 May 2017 08:11:25 +0000 (10:11 +0200)]
Binding2 runtime - API #4

- MountPointService & its relatives
- Javadocs provided

Change-Id: I15c55a34b0b4bb4df9aefd92749743c4a0cc2c3e
Signed-off-by: Martin Ciglan <martin.ciglan@pantheon.tech>
7 years agoBinding2 runtime - API #3 35/57635/22
Martin Ciglan [Mon, 22 May 2017 14:33:18 +0000 (16:33 +0200)]
Binding2 runtime - API #3

- DataTreeProducer, DataTreeService & its relatives
- Javadocs provided
- test coverage for classes

Change-Id: I75e2b4666db95153d97a24be38a9e2e78c37237f
Signed-off-by: Martin Ciglan <martin.ciglan@pantheon.tech>
7 years agoBinding2 runtime - API #2 29/57629/18
Martin Ciglan [Mon, 22 May 2017 13:31:46 +0000 (15:31 +0200)]
Binding2 runtime - API #2

- DataTreeWriteCursor & its relatives
- Javadocs provided

Change-Id: I1e6d6e6f609d048f78821875a0ef37f7aa6f47b1
Signed-off-by: Martin Ciglan <martin.ciglan@pantheon.tech>
7 years agoBinding2 runtime - API #1 26/57626/18
Martin Ciglan [Mon, 22 May 2017 12:24:28 +0000 (14:24 +0200)]
Binding2 runtime - API #1

- BindingService, DataTreeModification, transactions basics & its relatives
- Javadocs provided
- test coverage for classes

Change-Id: I2d032ec3a0a565941266610194fb8d176c5392ff
Signed-off-by: Martin Ciglan <martin.ciglan@pantheon.tech>
7 years agoFix checkstyle problems not detected by the current version 87/58187/2
David Suarez [Fri, 2 Jun 2017 20:30:54 +0000 (22:30 +0200)]
Fix checkstyle problems not detected by the current version

This change is required for overall move to new Checkstyle version, see
https://git.opendaylight.org/gerrit/#/q/topic:bumpCheckstyle

Change-Id: I422841dc64a48a67e0c1d3656dbf0a4e50763baa
Signed-off-by: David Suarez <david.suarez.fuentes@ericsson.com>
7 years agoBinding generator v2 - Identities support 13/58113/8
Martin Ciglan [Thu, 1 Jun 2017 12:20:10 +0000 (14:20 +0200)]
Binding generator v2 - Identities support

- naming conflict prevention added

Change-Id: Iac43a3ed45ed13b113fd48a2dce3829a9ce7c21a
Signed-off-by: Martin Ciglan <martin.ciglan@pantheon.tech>
7 years agoBinding generator v2 - Unions fix 98/58098/7
Jakub Toth [Thu, 1 Jun 2017 14:51:48 +0000 (16:51 +0200)]
Binding generator v2 - Unions fix

- generate Java code fixes

TODO: template compilability issues

Change-Id: Icfa857df13617edec93b3a8de47bbba5d4a9b966
Signed-off-by: Martin Ciglan <martin.ciglan@pantheon.tech>
Signed-off-by: Jakub Toth <jakub.toth@pantheon.tech>
7 years agoBinding generator v2 - Notifications 12/58012/3
Martin Ciglan [Tue, 30 May 2017 12:17:01 +0000 (14:17 +0200)]
Binding generator v2 - Notifications

- generated Java code compilability fixes

Change-Id: I82e1f59820820c1d6717fc4227031e7d33465cab
Signed-off-by: Martin Ciglan <martin.ciglan@pantheon.tech>
7 years agoMDSAL Binding2 Artifacts missing dependency fix 08/58008/1
Martin Ciglan [Tue, 30 May 2017 07:50:28 +0000 (09:50 +0200)]
MDSAL Binding2 Artifacts missing dependency fix

Change-Id: I7b6f0bc98cc951c654207ebc62d55cfbfe804bf2
Signed-off-by: Martin Ciglan <martin.ciglan@pantheon.tech>
7 years agoBinding v2 runtime 62/57062/5
Martin Ciglan [Mon, 15 May 2017 13:07:35 +0000 (15:07 +0200)]
Binding v2 runtime

- main placeholders with pom.xml files

Change-Id: Idda2c78a00412b71a1366fb4c222329e981946d6
Signed-off-by: Martin Ciglan <martin.ciglan@pantheon.tech>
7 years agoFix ShardedDOMDataTree registration result 22/57622/5
Robert Varga [Mon, 22 May 2017 11:28:19 +0000 (13:28 +0200)]
Fix ShardedDOMDataTree registration result

Since the returned registration is public, we should override the
return. This will allow controller to ditch an unsafe (but safe)
cast.

Also fixes a bunch of reflection-based tests by using
@VisibleForTesting package-private methods.

Change-Id: Ie544cdc873cd7b5d65b9d469db1000743b104609
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
7 years agoBug 8307: Add the option for activating deviation statements 09/57409/1
Martin Ciglan [Fri, 19 May 2017 10:14:56 +0000 (12:14 +0200)]
Bug 8307: Add the option for activating deviation statements

- follow-up patch for Yangtools changes:
https://git.opendaylight.org/gerrit/#/c/56452/

Change-Id: Ia78b119fee3bdf12be90dbb95d8d811576df57ed
Signed-off-by: Martin Ciglan <martin.ciglan@pantheon.tech>
7 years agoFix warnings in mdsal-binding-generator-impl 29/57029/2
Robert Varga [Sun, 14 May 2017 22:11:19 +0000 (00:11 +0200)]
Fix warnings in mdsal-binding-generator-impl

- xtend comparison to null
- unnecessary boxing
- unneeded imports
- raw types

Change-Id: Id2d987fdf0cc3b94c78250018bc06b77ab0726f4
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
7 years agoCleanup binding-dom-codec generator 98/56998/2
Robert Varga [Sat, 13 May 2017 18:25:24 +0000 (20:25 +0200)]
Cleanup binding-dom-codec generator

- use lambdas
- use fluent StringBuilder
- make methods static

This should improve codec generation slightly due to gains of
invoke_static vs. invoke_virtual and overall bytecode size diet.

Change-Id: Id8d3a442f63a452111907b7d683d2167dd489ca7
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
7 years agoBUG-8226: do not import nested classes 40/56840/2
Robert Varga [Thu, 11 May 2017 09:28:38 +0000 (11:28 +0200)]
BUG-8226: do not import nested classes

Importing a nested classes leads to a unused import warning, so compare
the declared package name with the class being generated and do not emit
an import declaration if the package name matches FQDN.

Change-Id: I4240cac663476c1405962631a9d173f5ed434ee9
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
7 years agoBindingDOMRpcProviderServiceAdapter should implement its interface 36/56936/2
Martin Ciglan [Fri, 12 May 2017 11:09:06 +0000 (13:09 +0200)]
BindingDOMRpcProviderServiceAdapter should implement its interface

Change-Id: I773f244bff3c08eb7982187089f6f0e8f0eefb65
Signed-off-by: Martin Ciglan <mciglan@cisco.com>
7 years agoFix generating of description for operations 62/56862/2
Jakub Toth [Thu, 11 May 2017 12:50:01 +0000 (14:50 +0200)]
Fix generating of description for operations

Change-Id: I8cc45bd00910377429c95fd3ab818c7d93299275
Signed-off-by: Jakub Toth <jatoth@cisco.com>
7 years agoDisable maven site build 56/56856/1
Robert Varga [Thu, 11 May 2017 13:30:02 +0000 (15:30 +0200)]
Disable maven site build

Change-Id: I9f4ac30cffcd58d2873aeae955a6626082f3479d
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
7 years agoBUG-8226: fix toString() formatting 39/56839/1
Robert Varga [Thu, 11 May 2017 09:04:22 +0000 (11:04 +0200)]
BUG-8226: fix toString() formatting

Fix closing curly brace offset.

Change-Id: I56d577387231a300dc508a8062f3aa07c861734a
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
7 years agoBUG-8226: fix augmentation argument overlap 34/56834/2
Robert Varga [Thu, 11 May 2017 07:56:15 +0000 (09:56 +0200)]
BUG-8226: fix augmentation argument overlap

This fixes a trivial warning of argument name shadowing the field
name.

Change-Id: Ie0cd8f010778e198db26102a6e42274a03aee118
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
7 years agoBUG-8226: fix Enumeration.forValue() javadoc 33/56833/2
Robert Varga [Thu, 11 May 2017 07:48:48 +0000 (09:48 +0200)]
BUG-8226: fix Enumeration.forValue() javadoc

Fix a missing description warning.

Change-Id: I26b1d0b01b56e6a3fb5d553decc4d109fc6f762c
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
7 years agoBinding generator implementation & decomposition 79/56779/4
Martin Ciglan [Wed, 10 May 2017 10:59:37 +0000 (12:59 +0200)]
Binding generator implementation & decomposition

- various fixes to make sure binding & code generator
generates compilable Java code for RPCs

Change-Id: I87def49a28ffa5f978e64a3d8c3de1b0adc2049c
Signed-off-by: Martin Ciglan <mciglan@cisco.com>
7 years agoRepeated instantiation of typeProvider 51/56751/2
Jie Han [Wed, 10 May 2017 01:52:06 +0000 (09:52 +0800)]
Repeated instantiation of typeProvider
Another instantiation is at line 253 of the same file in function:
public List<Type> generateTypes(final SchemaContext context, final Set<Module> modules)

Change-Id: Ic6dab97de47f54db193f5da7952e97bade656fd9
Signed-off-by: Jie Han <han.jie@zte.com.cn>
7 years agoFix of generating inner class with same name like parent 89/56489/10
Jakub Toth [Wed, 3 May 2017 20:40:28 +0000 (22:40 +0200)]
Fix of generating inner class with same name like parent

Change-Id: I9ad44f50e48f71145012fd32b1f5d9e7c322afb3
Signed-off-by: Jakub Toth <jatoth@cisco.com>
7 years agoBUG-8360: add mdsal-binding-dom-codec-osgi 80/56480/8
Robert Varga [Wed, 3 May 2017 11:21:54 +0000 (13:21 +0200)]
BUG-8360: add mdsal-binding-dom-codec-osgi

This is an OSGi binding producing all context needed required
to implement binding/dom/external serialization. It is similar
to how the config-manager service operates, except associated
services are explicitly covered instead of sneaking them through
properties.

Change-Id: I31f2bdb11153d6e514dacf2b070b073d768c1ff3
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
7 years agoFix merging lines in JavaCodePrettyPrint 21/56621/1
Jakub Toth [Fri, 5 May 2017 20:15:34 +0000 (22:15 +0200)]
Fix merging lines in JavaCodePrettyPrint

Change-Id: Ice139808fdad35ee329ee87c10c05edef7984195
Signed-off-by: Jakub Toth <jatoth@cisco.com>
7 years agoFix null warning in FutureSchema 08/56508/2
Robert Varga [Wed, 3 May 2017 21:38:45 +0000 (23:38 +0200)]
Fix null warning in FutureSchema

Using SettableFuture<?> implies possible requirement of non-nullness.
If we provise a Void, it is understand to only be null, which is what
we really want here.

Change-Id: I06f2d90cd5bb1c8f7959170d8b8d936b3c714323
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
7 years agoUtil class for cleaning of generated Java files 61/56161/12
Jakub Toth [Thu, 27 Apr 2017 13:12:04 +0000 (15:12 +0200)]
Util class for cleaning of generated Java files

  *comment generateImplementedMethods in builderTemplate, was
   breaking buil + tests

Change-Id: I5880adec4b9629d8a6761b5e75161e89235a9fe5
Signed-off-by: Jakub Toth <jatoth@cisco.com>