vtn.git
11 years agoFixed incorrect Javadoc links in unit test sources. 38/2938/1
Shigeru Yasuda [Thu, 21 Nov 2013 12:17:20 +0000 (21:17 +0900)]
Fixed incorrect Javadoc links in unit test sources.

Change-Id: I0195ea504d3b684ef91316adf7e5ec9cc22a6308
Signed-off-by: Shigeru Yasuda <s-yasuda@da.jp.nec.com>
11 years agoLoad the VTN configuration into cluster cache atomically. 37/2937/1
Shigeru Yasuda [Thu, 21 Nov 2013 11:50:07 +0000 (20:50 +0900)]
Load the VTN configuration into cluster cache atomically.

  * If one controller in the cluster is loading the VTN configuration into
    cluster cache, other controllers should wait for completion.
    In that case VTN Manager should ignore configuration in the local
    filesystem.
  * The VTN configuration should be saved to files if it is loaded by
    another controller in the cluster.

Change-Id: I9ebcc26571076eef950b21ed9eba5cecb8e50093
Signed-off-by: Shigeru Yasuda <s-yasuda@da.jp.nec.com>
11 years agoAdded and Fixed unit test cases for VTNManager to improve test coverage. 27/2927/1
Takayuki Kawagishi [Thu, 21 Nov 2013 07:30:09 +0000 (16:30 +0900)]
Added and Fixed unit test cases for VTNManager to improve test coverage.

* added test cases for clustering function.
* added test cases for ArpHandler.
* fixed comments.

Change-Id: Ia9e6a8e4486814988754836c848e26a769e9f2b6
Signed-off-by: Takayuki Kawagishi <kawagishi-takayuki@mxj.nes.nec.co.jp>
11 years agoDon't destroy cluster caches if cluster service is not available. 67/2867/1
Shigeru Yasuda [Tue, 19 Nov 2013 14:07:11 +0000 (23:07 +0900)]
Don't destroy cluster caches if cluster service is not available.

Change-Id: I36d6744a908d2de81e0ebfb42f09a4448d73506c
Signed-off-by: Shigeru Yasuda <s-yasuda@da.jp.nec.com>
11 years agoVlanMapImpl.transmit(): Check existence of mapped node connector correctly. 52/2852/1
Shigeru Yasuda [Tue, 19 Nov 2013 07:22:04 +0000 (16:22 +0900)]
VlanMapImpl.transmit(): Check existence of mapped node connector correctly.

getPorts() never returns null, and it returns an empty set if no port is
mapped to the VLAN mapping.

Change-Id: Idce2f6ac0f2b2f66f20d0b92e234312f7968612b
Signed-off-by: Shigeru Yasuda <s-yasuda@da.jp.nec.com>
11 years agoFix typo in PortMap.java 20/2820/1
Hideyuki [Mon, 18 Nov 2013 11:43:03 +0000 (06:43 -0500)]
Fix typo in PortMap.java

Change-Id: Idbf62bfa7e31ec9afb33517715e530f00d5ed56b
Signed-off-by: Hideyuki Tai <h-tai@cd.jp.nec.com>
11 years agoFixed sonar reported issues in VTN neutron code. 07/2807/1
Sarath Babu Gurujala [Mon, 18 Nov 2013 04:06:19 +0000 (13:06 +0900)]
Fixed sonar reported issues in VTN neutron code.

Change-Id: Idd3492fc39a8133bb440395cd8d90cd47535d706
Signed-off-by: Sarath Babu Gurujala <sarathbg@hcl.com>
11 years agoMerge "FT Scripts for testing the VTN Coordinator Interface"
Sarath Babu Gurujala [Mon, 18 Nov 2013 02:37:48 +0000 (02:37 +0000)]
Merge "FT Scripts for testing the VTN Coordinator Interface"

11 years agoMake vtndrvintf UT stable. 65/2765/1
Shigeru Yasuda [Fri, 15 Nov 2013 08:24:16 +0000 (17:24 +0900)]
Make vtndrvintf UT stable.

GetMultipleEntrySuccess test is unstable because it passes uninitialized
local variable (ret1) to EXPECT_EQ().

In addition, so many tests in controller_fw_ut.cc don't check the results.
So I added EXPECT_EQ() macros to check the results.

Change-Id: I617a2bf9a4d857bde64806dea6b3ca9d80f1e22d
Signed-off-by: Shigeru Yasuda <s-yasuda@da.jp.nec.com>
11 years agoLink json-c library using make variables provided by build environment. 62/2762/1
Shigeru Yasuda [Fri, 15 Nov 2013 06:42:23 +0000 (15:42 +0900)]
Link json-c library using make variables provided by build environment.

See below URI for more details:

  https://git.opendaylight.org/gerrit/2734

Change-Id: I2a9315a80f8bdedd24102b6ad3ab605bc4efccbb
Signed-off-by: Shigeru Yasuda <s-yasuda@da.jp.nec.com>
11 years agoMerge "Tests for controller component of vtndrvintf module in ODC Driver"
Sarath Babu Gurujala [Fri, 15 Nov 2013 04:01:16 +0000 (04:01 +0000)]
Merge "Tests for controller component of vtndrvintf module in ODC Driver"

11 years agoMerge "Fixed VTN coordinator build failure with the latest json-c library."
Sarath Babu Gurujala [Fri, 15 Nov 2013 02:42:47 +0000 (02:42 +0000)]
Merge "Fixed VTN coordinator build failure with the latest json-c library."

11 years agoTests for controller component of vtndrvintf module in ODC Driver 41/2741/3
balakrishnan [Thu, 14 Nov 2013 07:04:48 +0000 (12:34 +0530)]
Tests for controller component of vtndrvintf module in ODC Driver

Change-Id: I34f004be7191e4a17a5a0adfa86369bd8e549f3f
Signed-off-by: balakrishnan <balakrishnan.ka@hcl.com>
11 years agoFT Scripts for testing the VTN Coordinator Interface 07/2707/4
gvrangan [Wed, 13 Nov 2013 19:47:19 +0000 (01:17 +0530)]
FT Scripts for testing the VTN Coordinator Interface

  * Tests for Controller Operations
  * Tests for VTN/VBR Operations on single controller
  * Tests for VBRIF has been added

Change-Id: I20153cace6c9b025e55c67b49c13e532e5a79ea9
Signed-off-by: gvrangan <venkatrangang@hcl.com>
11 years agoTests for odcdriver module in ODC Driver Daemon 78/2678/4
susant [Wed, 13 Nov 2013 07:32:55 +0000 (13:02 +0530)]
Tests for odcdriver module in ODC Driver Daemon

Change-Id: Ied72267f438a53afda2ae78835b6b08136407226
Signed-off-by: susant <susantchandra.s@hcl.com>
11 years agoFixed VTN coordinator build failure with the latest json-c library. 34/2734/1
Shigeru Yasuda [Thu, 14 Nov 2013 13:04:27 +0000 (22:04 +0900)]
Fixed VTN coordinator build failure with the latest json-c library.

The name of json-c library was changed to libjson-c as of version 0.11.
This patch detects compiler and linker flags required to link json-c library,
and defines them as makefile variables.

If you want to use libjson-c in your component, put the following lines
to your Makefile:

  EXTRA_CPPFLAGS          = $(JSON_C_CPPFLAGS)
  EXTRA_LIBDIRS           = $(JSON_C_LIBDIRS)
  EXTRA_LDLIBS            = $(JSON_C_LDFLAGS)
  EXTRA_RUNTIME_DIR       = $(JSON_C_RUNPATH)

In addition, libcurl is also detected by configure script.
The following lines need to be added to your Makefile to link libcurl:

  EXTRA_CPPFLAGS          = $(LIBCURL_CPPFLAGS)
  EXTRA_LIBDIRS           = $(LIBCURL_LIBDIRS)
  EXTRA_LDLIBS            = $(LIBCURL_LDFLAGS)
  EXTRA_RUNTIME_DIR       = $(LIBCURL_RUNPATH)

Note that this patch requires pkg-config command in build host.

Change-Id: Ie1a0352c7db598160269c6045b3ede04e57364eb
Signed-off-by: Shigeru Yasuda <s-yasuda@da.jp.nec.com>
11 years agoUpdated vlanmap code to use new getVlanMap API supported by VTN Manager 29/2729/1
Sarath Babu Gurujala [Thu, 14 Nov 2013 08:26:00 +0000 (17:26 +0900)]
Updated vlanmap code to use new getVlanMap API supported by VTN Manager

Change-Id: I5368f23344cf0dd2fbd2581af2cc32a82dbcc077
Signed-off-by: Sarath Babu Gurujala <sarathbg@hcl.com>
11 years agoMerge "Tests for vtncacheutil module for ODC Driver Daemon"
Sarath Babu Gurujala [Thu, 14 Nov 2013 03:18:43 +0000 (03:18 +0000)]
Merge "Tests for vtncacheutil module for ODC Driver Daemon"

11 years agoMerge "ArpHandler emulator: Check for valid path on IPv4 packet forwarding."
Hideyuki Tai [Thu, 14 Nov 2013 02:57:03 +0000 (02:57 +0000)]
Merge "ArpHandler emulator: Check for valid path on IPv4 packet forwarding."

11 years agoMerge "Tests for vtndrvintf module in ODC driver daemon"
Sarath Babu Gurujala [Thu, 14 Nov 2013 02:06:03 +0000 (02:06 +0000)]
Merge "Tests for vtndrvintf module in ODC driver daemon"

11 years agoMerge "Tests for restjsonutil Module in ODC driver daemon"
Sarath Babu Gurujala [Thu, 14 Nov 2013 00:49:38 +0000 (00:49 +0000)]
Merge "Tests for restjsonutil Module in ODC driver daemon"

11 years agoArpHandler emulator: Check for valid path on IPv4 packet forwarding. 06/2706/1
Shigeru Yasuda [Wed, 13 Nov 2013 14:58:06 +0000 (23:58 +0900)]
ArpHandler emulator: Check for valid path on IPv4 packet forwarding.

ArpHandler emulator will forward IPv4 packet only if it is reachable to
the destination host.

Change-Id: I2fdb0c8af7d185688e5da1a68af901ae6f3e2349
Signed-off-by: Shigeru Yasuda <s-yasuda@da.jp.nec.com>
11 years agoTests for vtncacheutil module for ODC Driver Daemon 76/2676/2
surya.s [Tue, 12 Nov 2013 22:11:21 +0000 (03:41 +0530)]
Tests for vtncacheutil module for ODC Driver Daemon

Change-Id: Iad4bb1b9aeea032fb0e7e7371904a8ec535ec341
Signed-off-by: surya.s <surya.s@hcl.com>
11 years agoTests for vtndrvintf module in ODC driver daemon 72/2672/3
balakrishnan [Wed, 13 Nov 2013 04:15:27 +0000 (09:45 +0530)]
Tests for vtndrvintf module in ODC driver daemon

  * Test for Handling Message from platform
  * Test for driver method invocation

Change-Id: I633584c433827aa4ab92a29439ef82bbabb171c6
Signed-off-by: balakrishnan <balakrishnan.ka@hcl.com>
11 years agoTests for restjsonutil Module in ODC driver daemon 74/2674/2
balakrishnan [Wed, 13 Nov 2013 05:44:10 +0000 (11:14 +0530)]
Tests for restjsonutil Module in ODC driver daemon

Change-Id: Icd5d4670b58242c0f9fd17e8e60fc542fb56c79f
Signed-off-by: balakrishnan <balakrishnan.ka@hcl.com>
11 years agoFixed incorrect links in Javadoc comments. 01/2701/1
Shigeru Yasuda [Wed, 13 Nov 2013 13:11:28 +0000 (22:11 +0900)]
Fixed incorrect links in Javadoc comments.

Change-Id: Ib7ff43f9119404f3a6e904a78db859ee2bd59c52
Signed-off-by: Shigeru Yasuda <s-yasuda@da.jp.nec.com>
11 years agoProvide new API to search for a VLAN mapping by its configuration. 94/2694/1
Shigeru Yasuda [Wed, 13 Nov 2013 10:59:28 +0000 (19:59 +0900)]
Provide new API to search for a VLAN mapping by its configuration.

  IVTNManager.getVlanMap(VBridgePath, VlanMapConfig)
    Search for a VLAN mapping information by the specified pair of
    vBridge path and VLAN mapping configuration.

The above method can be invoked via NB API by appending
"/vlanmapsearch/byconf" to an URI associated with a vBridge.

Change-Id: Idfd47ffee838aa691ef6953a293624a4ca22d8cb
Signed-off-by: Shigeru Yasuda <s-yasuda@da.jp.nec.com>
11 years agoAdd unit tests for manager.neutron bundle 87/2687/1
Hideyuki [Wed, 13 Nov 2013 07:48:45 +0000 (02:48 -0500)]
Add unit tests for manager.neutron bundle

Change-Id: Ibfae2b1efe5297c4211c76dc55530f115faac8d4
Signed-off-by: Hideyuki <h-tai@cd.jp.nec.com>
11 years agoOpenStack Neutron API support for VTN Manager. 85/2685/2
Sarath Babu Gurujala [Wed, 13 Nov 2013 05:38:29 +0000 (14:38 +0900)]
OpenStack Neutron API support for VTN Manager.

Change-Id: I99bd0c1fa2bc763fafe1671c251fca2a168b7b28
Signed-off-by: Sarath Babu Gurujala <sarathbg@hcl.com>
11 years agoAdded unit test codes for VTNManager. 49/2649/5
Takayuki Kawagishi [Tue, 12 Nov 2013 09:31:50 +0000 (18:31 +0900)]
Added unit test codes for VTNManager.

* added unit test relevant to ClusterEvent.

Change-Id: Ie1d181fdf294a31217824f06c4947085d92c66b2
Signed-off-by: Takayuki Kawagishi <kawagishi-takayuki@mxj.nes.nec.co.jp>
11 years agoMerge "Add test cases for integration test of VTN Manager."
Takayuki Kawagishi [Tue, 12 Nov 2013 11:45:24 +0000 (11:45 +0000)]
Merge "Add test cases for integration test of VTN Manager."

11 years agoAdd test cases for integration test of VTN Manager. 58/2658/1
Taiki Kondo [Tue, 12 Nov 2013 11:04:05 +0000 (20:04 +0900)]
Add test cases for integration test of VTN Manager.

* Add test cases of invalid values for VTN, VBridge, and VBridge Interface names.

Signed-off-by: Taiki Kondo <kondo-taiki@mxt.nes.nec.co.jp>
11 years agoImprovement to ODC Driver Code 21/2621/1
gvrangan [Mon, 11 Nov 2013 23:45:40 +0000 (05:15 +0530)]
Improvement to ODC Driver Code

   * Additional code review comments addressed
   * Fixes for bugs identified in testing

Change-Id: I202735309218aa83c34ce4a06b22d60cf1687a68
Signed-off-by: gvrangan <venkatrangang@hcl.com>
11 years agoDon't filter out non-OF packet if there is no VTN. 55/2555/1
Shigeru Yasuda [Fri, 8 Nov 2013 14:16:59 +0000 (23:16 +0900)]
Don't filter out non-OF packet if there is no VTN.

In that case all received packets need to be passed to ArpHandler emulator.

Change-Id: I6d4fcf695bdc181c46bcf8120760c5aacd2ad75d
Signed-off-by: Shigeru Yasuda <s-yasuda@da.jp.nec.com>
11 years agoArpHandler emulator: Forward packets to known hosts as the controller does. 18/2518/1
Shigeru Yasuda [Thu, 7 Nov 2013 17:07:26 +0000 (02:07 +0900)]
ArpHandler emulator: Forward packets to known hosts as the controller does.

Additional changes:

  * Use NetUtils.getBroadcastMACAddr() to create broadcast MAC address.
  * VTNExceptionTest: Fixed incorrect link doclet.

Change-Id: I83d3f7089402f4860f3f37d3c492b48cc0b5ba0a
Signed-off-by: Shigeru Yasuda <s-yasuda@da.jp.nec.com>
11 years agoFixed unstable unit test for VTN Manager. 95/2495/2
Takayuki Kawagishi [Thu, 7 Nov 2013 12:42:58 +0000 (21:42 +0900)]
Fixed unstable unit test for VTN Manager.

installFlowEntry() and uninstallFlowEntry() in TestStub should be thread safety.

Change-Id: I122b6668e6a1ad007ca84e82fd5f5635822efe71
Signed-off-by: Takayuki Kawagishi <kawagishi-takayuki@mxj.nes.nec.co.jp>
11 years agoFixed a bug in FlowEventTest. 20/2420/1
Takayuki Kawagishi [Wed, 6 Nov 2013 03:43:16 +0000 (12:43 +0900)]
Fixed a bug in FlowEventTest.

Change-Id: I0ff216319805abb4f28d495e1e09c4ec6f5b5206
Signed-off-by: Takayuki Kawagishi <kawagishi-takayuki@mxj.nes.nec.co.jp>
11 years agoAdded unit test case for VTNManager. 14/2314/3
Takayuki Kawagishi [Fri, 1 Nov 2013 09:31:11 +0000 (18:31 +0900)]
Added unit test case for VTNManager.

* added new unit test codes of VTNException, ActionList, FlowAddEvent, FlowRemoveEvent, FlowModResultEvent, MacVlan, VTNFlow, VTNThreadData, VTNThreadPool.
* added test cases for MacAddressTable, PacketContext.
* removed unnecessary code which was commented out in VtnNorthboundIT.java.

Change-Id: If9e947ee103aaf712ee15d9cf4288cdf8b3794ad
Signed-off-by: Takayuki Kawagishi <kawagishi-takayuki@mxj.nes.nec.co.jp>
11 years agoExpand the size of global thread pool to 8. 81/2381/1
Shigeru Yasuda [Tue, 5 Nov 2013 11:03:59 +0000 (20:03 +0900)]
Expand the size of global thread pool to 8.

Change-Id: I53d53b3de708960ec7060b4b49ab79fb605f48e4
Signed-off-by: Shigeru Yasuda <s-yasuda@da.jp.nec.com>
11 years agoMinor changes to common pom.xml. 77/2377/1
Shigeru Yasuda [Tue, 5 Nov 2013 09:13:13 +0000 (18:13 +0900)]
Minor changes to common pom.xml.

  * Use mirror repository provided by nexusproxy.
  * Specify 1.7 to java version explicitly.

Change-Id: Ia39e9db8ccae6521400750e547b31b756eff5e2c
Signed-off-by: Shigeru Yasuda <s-yasuda@da.jp.nec.com>
11 years agoMerge "Monitoring interval for connection status of controller(VTN Manager) made...
Sarath Babu Gurujala [Wed, 30 Oct 2013 07:54:38 +0000 (07:54 +0000)]
Merge "Monitoring interval for connection status of controller(VTN Manager) made configurable"

11 years agoMonitoring interval for connection status of controller(VTN Manager) made configurable 15/2215/4
balakrishnan [Tue, 29 Oct 2013 12:24:28 +0000 (17:54 +0530)]
Monitoring interval for connection status of controller(VTN Manager) made configurable

Change-Id: Ic9886a53d93fda9ba341bd9cde3b0e1b8f3a5fbd
Signed-off-by: balakrishnan <balakrishnan.ka@hcl.com>
11 years agoFixed VTNConfig and added test case for it. 67/2267/1
Takayuki Kawagishi [Wed, 30 Oct 2013 05:39:34 +0000 (14:39 +0900)]
Fixed VTNConfig and added test case for it.

* Close used file stream in VTNConfig.loadProperty().
* Add test cases for each configuration parameters.

Change-Id: I8de4c4108061ad31e079c813b972a6f5816e5cd2
Signed-off-by: Takayuki Kawagishi <kawagishi-takayuki@mxj.nes.nec.co.jp>
11 years agoMerge "Controller(VTN Manager) connection status notification from ODC Driver to...
Sarath Babu Gurujala [Wed, 30 Oct 2013 03:06:56 +0000 (03:06 +0000)]
Merge "Controller(VTN Manager) connection status notification from ODC Driver to UPPL"

11 years agoMerge "VTNThreadPool: Try to expand the pool if there is no idle thread."
Takayuki Kawagishi [Wed, 30 Oct 2013 02:40:45 +0000 (02:40 +0000)]
Merge "VTNThreadPool: Try to expand the pool if there is no idle thread."

11 years agoFix test failure due to changing version of ISwitchManager. 66/2266/1
Taiki Kondo [Wed, 30 Oct 2013 01:27:33 +0000 (10:27 +0900)]
Fix test failure due to changing version of ISwitchManager.

This patch fixes following issue.

* Test failure due to changing version of ISwitchManager,
  posted at following URI.
  https://git.opendaylight.org/gerrit/#/c/2143/

* Build failure due to added API above.

Signed-off-by: Taiki Kondo <kondo-taiki@mxt.nes.nec.co.jp>
11 years agoVTNThreadPool: Try to expand the pool if there is no idle thread. 40/2240/1
Shigeru Yasuda [Tue, 29 Oct 2013 11:57:23 +0000 (20:57 +0900)]
VTNThreadPool: Try to expand the pool if there is no idle thread.

execute() tries to expand the pool if the number of blocked threads is
less than or equal to the number of pending wake-up signals.

Change-Id: I0ce00c1442d5af1c9ea802da94787918eb105e0b
Signed-off-by: Shigeru Yasuda <s-yasuda@da.jp.nec.com>
11 years agoReturn 404 response if an invalid container name is specified to NB API. 26/2226/1
Shigeru Yasuda [Mon, 28 Oct 2013 17:23:47 +0000 (02:23 +0900)]
Return 404 response if an invalid container name is specified to NB API.

Change-Id: I06af9bcfc7704653b446088bd30ebac883c7aac7
Signed-off-by: Shigeru Yasuda <s-yasuda@da.jp.nec.com>
11 years agoMerge "Added test cases of VTNNorthbound IT."
Taiki Kondo [Mon, 28 Oct 2013 10:42:03 +0000 (10:42 +0000)]
Merge "Added test cases of VTNNorthbound IT."

11 years agoAdded test cases of VTNNorthbound IT. 28/2128/4
Kasumi Takeshige [Thu, 24 Oct 2013 09:04:08 +0000 (18:04 +0900)]
Added test cases of VTNNorthbound IT.

Test cases which was not implemented before is added.

Change-Id: I6345955307ebe66294e37e75deb944aefbc6984f
Signed-off-by: Kasumi Takeshige <takeshige-kasumi@mxk.nes.nec.co.jp>
11 years agoMinor fix for the previous uppl patch. 04/2204/1
Shigeru Yasuda [Mon, 28 Oct 2013 07:35:33 +0000 (16:35 +0900)]
Minor fix for the previous uppl patch.

  PhyUtil::FillDbSchema()
    Share the code for DATATYPE_IPV6 and DATATYPE_UINT8_ARRAY_16.

Change-Id: Ia84509affbbdf02efccefce63280005aab9c4463
Signed-off-by: Shigeru Yasuda <s-yasuda@da.jp.nec.com>
11 years agoController(VTN Manager) connection status notification from ODC Driver to UPPL 69/2169/2
mayura [Sat, 26 Oct 2013 14:15:42 +0000 (19:45 +0530)]
Controller(VTN Manager) connection status notification from ODC Driver to UPPL

Change-Id: Id2ccc0a608d78a645cca03f51ea94850c2fb5d87
Signed-off-by: mayura <karpagamd@hcl.com>
11 years agoFixed bug in uppl module. 72/2172/1
Shigeru Yasuda [Fri, 25 Oct 2013 17:03:28 +0000 (02:03 +0900)]
Fixed bug in uppl module.

  * itc_kt_boundary.cc, itc_kt_controller.cc
    Eliminate access to out-of-scoped local variable.
  * phy_util.c
    Fix bug that may cause buffer overrun.

In addition, this patch refines unit tests for uppl and upll coordinator
modules:

  * Provide build environment for coodinator module unit test, and use it.
    * Don't create any file in the source directory.
  * Remove destructive tests.
  * Remove so many unused local variables and functions.
  * Eliminate access to uninitialized memory.

Change-Id: Ib88363e2002d3aa7489ace81b651f14b237219a0
Signed-off-by: Shigeru Yasuda <s-yasuda@da.jp.nec.com>
11 years agoInitial push of VTN Manager Neutron Interface 92/2092/4
Hideyuki Tai [Wed, 23 Oct 2013 14:23:53 +0000 (10:23 -0400)]
Initial push of VTN Manager Neutron Interface

It creates directories, pom.xml, Activator.java,
and prototype source files of VTN Manager Neutron Interface
for future development.

Change-Id: Ic18be1e04b9200c157d90889ee9ccd8d2e58d294
Signed-off-by: Hideyuki Tai <h-tai@cd.jp.nec.com>
11 years agoFixed unit test codes due to a change of IConnectionManager. 54/2154/1
Takayuki Kawagishi [Fri, 25 Oct 2013 01:18:19 +0000 (10:18 +0900)]
Fixed unit test codes due to a change of IConnectionManager.

Change-Id: I6c2098dcdb23eb57127e3e2819d146ccca8265dd
Signed-off-by: Takayuki Kawagishi <kawagishi-takayuki@mxj.nes.nec.co.jp>
11 years agoMerge "Support for controller status handling and Audit Configurations"
Sarath Babu Gurujala [Thu, 24 Oct 2013 09:45:11 +0000 (09:45 +0000)]
Merge "Support for controller status handling and Audit Configurations"

11 years agoFix build failure due to changing in IForwardingRulesManager. 22/2122/2
Taiki Kondo [Thu, 24 Oct 2013 02:53:33 +0000 (11:53 +0900)]
Fix build failure due to changing in IForwardingRulesManager.

This patch fixes following issues.

* Build failure due to changing in IForwardingRulesManager,
  posted at following URI.
  https://git.opendaylight.org/gerrit/#/c/2119/

* Test failure due to changing in pom.xml of StatisticsManager,
  posted at following URI.
  https://git.opendaylight.org/gerrit/#/c/2120/

Signed-off-by: Taiki Kondo <kondo-taiki@mxt.nes.nec.co.jp>
11 years agoSupport for controller status handling and Audit Configurations 16/2016/5
gvrangan [Sat, 19 Oct 2013 16:41:47 +0000 (22:11 +0530)]
Support for controller status handling and Audit Configurations

Change-Id: I2285e47f1465d9cc11cc6bfced27b2e8d15c6615
Signed-off-by: gvrangan <venkatrangang@hcl.com>
11 years agoMerge "Fixed bug in VTNFlowDatabase."
Takayuki Kawagishi [Mon, 21 Oct 2013 10:36:38 +0000 (10:36 +0000)]
Merge "Fixed bug in VTNFlowDatabase."

11 years agoMerge "Fixed bug in FlowAddTask."
Takayuki Kawagishi [Mon, 21 Oct 2013 10:03:28 +0000 (10:03 +0000)]
Merge "Fixed bug in FlowAddTask."

11 years agoMerge "Fixed bug in RemoteFlowRequest."
Takayuki Kawagishi [Mon, 21 Oct 2013 09:45:43 +0000 (09:45 +0000)]
Merge "Fixed bug in RemoteFlowRequest."

11 years agoFixed bug in VTNFlowDatabase. 41/2041/1
Shigeru Yasuda [Mon, 21 Oct 2013 08:55:39 +0000 (17:55 +0900)]
Fixed bug in VTNFlowDatabase.

  removeFlows(VTNManagerImpl, List<VTNFlow>):
    Do NOT create FlowRemoveTask if there is no VTN flow to be removed.
  removeIndex(VTNManagerImpl, VTNFlow):
    Return true only if the given VTN flow was actually removed.

Change-Id: Id27fed309b94b458b98746e3a5d25cecc102fb75
Signed-off-by: Shigeru Yasuda <s-yasuda@da.jp.nec.com>
11 years agoFixed bug in FlowAddTask. 35/2035/1
Shigeru Yasuda [Mon, 21 Oct 2013 07:25:00 +0000 (16:25 +0900)]
Fixed bug in FlowAddTask.

execute(): It should return false in case there is no ingress flow.

Change-Id: Ida95f7f6ea0c4e4b8e6bbcf55a4808d2808dc6d1
Signed-off-by: Shigeru Yasuda <s-yasuda@da.jp.nec.com>
11 years agoFixed bug in RemoteFlowRequest. 34/2034/1
Shigeru Yasuda [Mon, 21 Oct 2013 06:50:23 +0000 (15:50 +0900)]
Fixed bug in RemoteFlowRequest.

updateResult(boolean) should return a non-null value if there is no
pending request.

Change-Id: I52a991042bda11f9ba2b201b19c310814da9600f
Signed-off-by: Shigeru Yasuda <s-yasuda@da.jp.nec.com>
11 years agoTests for KT_VTN ,KT_VBR,KT_VBRIF,KT_CONTROLLER,KT_BOUNDARY (Messages exchanged betwe... 25/1325/4
gvrangan [Sat, 21 Sep 2013 18:07:11 +0000 (23:37 +0530)]
Tests for KT_VTN ,KT_VBR,KT_VBRIF,KT_CONTROLLER,KT_BOUNDARY (Messages exchanged between Platform (UPPL/UPLL) and Driver for VTN/VBR configurations)

Makefile modified to fix build failure

Change-Id: Iea00cc08d392a6e61a79f0cbf0759bf0e265070f
Signed-off-by: gvrangan <venkatrangang@hcl.com>
11 years agoAdded unit tests for flow mod tasks. 07/2007/1
Takayuki Kawagishi [Fri, 18 Oct 2013 10:22:36 +0000 (19:22 +0900)]
Added unit tests for flow mod tasks.

Change-Id: Ib19343fd3c00d6e48a682432ced1d23ea5173b5b
Signed-off-by: Takayuki Kawagishi <kawagishi-takayuki@mxj.nes.nec.co.jp>
11 years agoFixed unstable tests that may block the test process forever. 90/1990/1
Shigeru Yasuda [Fri, 18 Oct 2013 06:43:51 +0000 (15:43 +0900)]
Fixed unstable tests that may block the test process forever.

Change-Id: Ic6c8096bb2e52a73080743bace542717aab03b11
Signed-off-by: Shigeru Yasuda <s-yasuda@da.jp.nec.com>
11 years agoEliminate unnecessary files from the binary distribution package. 84/1984/1
Shigeru Yasuda [Fri, 18 Oct 2013 04:50:54 +0000 (13:50 +0900)]
Eliminate unnecessary files from the binary distribution package.

  * Add only the "opendaylight" directory to the ZIP package.
  * Remove SAL from distribution.vtn-manager dependencies.

Additional Changes:
  * manager.common: Eliminate duplicates in <dependencyManagement>.

Change-Id: Ifc40123fe080a2e81d50dbe729157b5047961e1a
Signed-off-by: Shigeru Yasuda <s-yasuda@da.jp.nec.com>
11 years agoCentralize project version management in manager.common. 98/1898/1
Shigeru Yasuda [Tue, 15 Oct 2013 08:46:24 +0000 (17:46 +0900)]
Centralize project version management in manager.common.

  * Inherit VTN Manager's project version from manager.common.
  * Declare dependent project versions in <dependencyManagement> in
    manager.common.
  * Eliminate duplicated dependencies.

Change-Id: Ic29962e6d4c9a5c35fc1a1e812e4e6b6f5260264
Signed-off-by: Shigeru Yasuda <s-yasuda@da.jp.nec.com>
11 years agoAdded Destructor and removed unwanted assignations 80/1780/3
balakrishnan [Thu, 10 Oct 2013 17:32:34 +0000 (23:02 +0530)]
Added Destructor and removed unwanted assignations
Fix for multi-controller vlink creation Failure
addressed review comments

Change-Id: Iee2b40662ba9f686bf4829310727038d86f268dc
Signed-off-by: balakrishnan <balakrishnan.ka@hcl.com>
11 years agoMerge "Fixed unstable unit tests for VTN coordinator."
Hideyuki Tai [Fri, 11 Oct 2013 00:34:16 +0000 (00:34 +0000)]
Merge "Fixed unstable unit tests for VTN coordinator."

11 years agoFixed unstable unit tests for VTN coordinator. 00/1800/1
Shigeru Yasuda [Thu, 10 Oct 2013 12:38:14 +0000 (21:38 +0900)]
Fixed unstable unit tests for VTN coordinator.

  * Signal from a child process needs to be bound to the test thread.
  * Wait for a child process with timeout in order to avoid infinite loop.

Change-Id: I53d653ef1cf3c90eec48e51c368e0c47ff6989f4
Signed-off-by: Shigeru Yasuda <s-yasuda@da.jp.nec.com>
11 years agoUse NorthboundApplication for VTN Manager NB API. 97/1797/1
Shigeru Yasuda [Thu, 10 Oct 2013 11:34:20 +0000 (20:34 +0900)]
Use NorthboundApplication for VTN Manager NB API.

Note that this patch affects JSON format of VTN Manager NB API.
A '@' character is no longer prepended to attribute name.

Additional changes:

  * VTNFlowDatabase: Suppress verbose informational log.

Change-Id: I973293037fe9f8e844c5abb58152fa5d9098d9bc
Signed-off-by: Shigeru Yasuda <s-yasuda@da.jp.nec.com>
11 years agoFixed unstable IT test. 95/1795/1
Shigeru Yasuda [Thu, 10 Oct 2013 10:57:35 +0000 (19:57 +0900)]
Fixed unstable IT test.

testICacheUpdateAware() needs to wait for a tenant ADDED event generated
by addTenant(), or succeeding test may fail.

Change-Id: Ifbb2a388d3d8ee21feb433f3bd3fd1d42e7a1060
Signed-off-by: Shigeru Yasuda <s-yasuda@da.jp.nec.com>
11 years agoAdded a dependency which was removed unintentionally to pom.xml of northboundIT. 90/1790/1
Takayuki Kawagishi [Thu, 10 Oct 2013 06:05:11 +0000 (15:05 +0900)]
Added a dependency which was removed unintentionally to pom.xml of northboundIT.

This is a additional patch for the following patch
  https://git.opendaylight.org/gerrit/#/c/1763/
and this revert a dependency which was removed by the following patch
  https://git.opendaylight.org/gerrit/#/c/1745/

Change-Id: Ie5558a4fa5c25737c4248d4dfc5d621c938bd7ba
Signed-off-by: Takayuki Kawagishi <kawagishi-takayuki@mxj.nes.nec.co.jp>
11 years agoAdded a dependency to pom.xml of northboundIT to avoid the build failure of northboundIT. 63/1763/1
Takayuki Kawagishi [Wed, 9 Oct 2013 08:35:47 +0000 (17:35 +0900)]
Added a dependency to pom.xml of northboundIT to avoid the build failure of northboundIT.

This is a temporary patch to avoid build failure. This should be fixed later.

Change-Id: Icc9e48d9f06e2c48aa52f48e82b9d3d41eab4268
Signed-off-by: Takayuki Kawagishi <kawagishi-takayuki@mxj.nes.nec.co.jp>
11 years agoMerge "Changes to UPLL, UPPL and TC to interact with new driver for ODC. Also include...
Tomohisa Yamabe [Wed, 9 Oct 2013 04:12:54 +0000 (04:12 +0000)]
Merge "Changes to UPLL, UPPL and TC to interact with new driver for ODC. Also included, the changes in WEB API to allow users to configure vtn for the new controller type (ODC)."

11 years agoMerge "Modules for ODC Driver and Daemon Makefile a) restjsonutil - Utility Module...
Tomohisa Yamabe [Wed, 9 Oct 2013 03:15:53 +0000 (03:15 +0000)]
Merge "Modules for ODC Driver and Daemon Makefile a) restjsonutil - Utility Module for JSON(Build/Parse) and REST Interface b) vtncacheutil - Utility Module for storing VTN Configuration to validate and commit c) vtndrvintf   - Modules that serves as an interface for platform to send messages to driver d) odcdriver    - Invokes VTN Manager API"

11 years agoChanges to UPLL, UPPL and TC to interact with new driver for ODC. 59/1659/3
balakrishnan [Fri, 4 Oct 2013 21:31:05 +0000 (03:01 +0530)]
Changes to UPLL, UPPL and TC to interact with new driver for ODC.
Also included, the changes in WEB API to allow users to configure vtn
for the new controller type (ODC).

Updated for daemon name Change as drvodcd

Change-Id: I09cfdf26e1a545fe1b0362a0bb955f7ef446506f
Signed-off-by: balakrishnan <balakrishnan.ka@hcl.com>
11 years agoReduce Sonar warnings. 48/1748/1
Shigeru Yasuda [Tue, 8 Oct 2013 14:15:20 +0000 (23:15 +0900)]
Reduce Sonar warnings.

  * Split large method.
  * Reduce cyclomatic complexity.

Additional changes:
  * VTNManagerImpl: Fix typo in log message.
  * MacAddressTable: Make internal API more efficient.

Change-Id: I98a6e1cdaf3d44e0bb2f8c49761d0cd422320dad
Signed-off-by: Shigeru Yasuda <s-yasuda@da.jp.nec.com>
11 years agoSeparate common settings for integration test. 45/1745/1
Shigeru Yasuda [Tue, 8 Oct 2013 09:28:46 +0000 (18:28 +0900)]
Separate common settings for integration test.

Change-Id: Id073a1eeee54546e540ffcf4f00f191413a4dee4
Signed-off-by: Shigeru Yasuda <s-yasuda@da.jp.nec.com>
11 years agoFixed test codes of VTN Manager to output detail information as error message. 37/1737/2
Takayuki Kawagishi [Tue, 8 Oct 2013 04:09:11 +0000 (13:09 +0900)]
Fixed test codes of VTN Manager to output detail information as error message.

 * Replaced assertTrue() used for a test which tests a method or a value
   return non-boolean result to assertEquals().
 * Output parameters which caused error when assertion methods of JUnit
   are failed.
 * Added some comments.
 * Deleted testPortMapInvalidCase() from VTNManagerImplWithNodesTest.java
   because same test implemented in VTNManagerTest.java.

Change-Id: Ib9464949be63fcc9f406f4fcf12932a75180729b
Signed-off-by: Takayuki Kawagishi <kawagishi-takayuki@mxj.nes.nec.co.jp>
11 years agoModules for ODC Driver and Daemon Makefile 19/1719/3
susant [Fri, 4 Oct 2013 21:00:27 +0000 (02:30 +0530)]
Modules for ODC Driver and Daemon Makefile
a) restjsonutil - Utility Module for JSON(Build/Parse) and REST Interface
b) vtncacheutil - Utility Module for storing VTN Configuration to validate and commit
c) vtndrvintf   - Modules that serves as an interface for platform to send messages to driver
d) odcdriver    - Invokes VTN Manager API

Change-Id: I16011ff616a74a9638061193277d0e3fa0bec4d8
Signed-off-by: susant <susantchandra.s@hcl.com>
11 years agoAdded API for getting version information of the VTN Manager. 25/1725/1
Shigeru Yasuda [Mon, 7 Oct 2013 15:13:28 +0000 (00:13 +0900)]
Added API for getting version information of the VTN Manager.

Currently below values are returned as version information:

  API version
    An integer value which determines the version of VTN Manager API.
    API version is incremented when incompatible changes are made to
    VTN Manager API.

  OSGi bundle version
    The version of the OSGi bundle which implements the VTN Manager.

Change-Id: I0001135163f2b828deb7cb31a9cabed668bd1c59
Signed-off-by: Shigeru Yasuda <s-yasuda@da.jp.nec.com>
11 years agoFix unstable unit tests. 22/1722/1
Shigeru Yasuda [Mon, 7 Oct 2013 14:20:25 +0000 (23:20 +0900)]
Fix unstable unit tests.

Change-Id: Iffb67f28490b11f318f6f92d8fac794fd7123349
Signed-off-by: Shigeru Yasuda <s-yasuda@da.jp.nec.com>
11 years agoMerge "Maintain inter-switch links."
Hideyuki Tai [Mon, 7 Oct 2013 02:29:20 +0000 (02:29 +0000)]
Merge "Maintain inter-switch links."

11 years agoMaintain inter-switch links. 82/1682/1
Shigeru Yasuda [Fri, 4 Oct 2013 18:48:45 +0000 (03:48 +0900)]
Maintain inter-switch links.

VTN Manager supports Openflow network only. So a switch port linked to
non-Openflow switch should not be treated as internal port.

Change-Id: Ica359bb52483ece2bef3c162679353f0e2990acb
Signed-off-by: Shigeru Yasuda <s-yasuda@da.jp.nec.com>
11 years agoMacAddressTable: Remove unused local variable. 74/1674/1
Shigeru Yasuda [Fri, 4 Oct 2013 13:17:03 +0000 (22:17 +0900)]
MacAddressTable: Remove unused local variable.

Change-Id: I37af086a862ea0b058259c517acd25c2483290b7
Signed-off-by: Shigeru Yasuda <s-yasuda@da.jp.nec.com>
11 years agoShare learnt MAC addresses with controllers in the cluster. 54/1654/1
Shigeru Yasuda [Thu, 3 Oct 2013 17:17:11 +0000 (02:17 +0900)]
Share learnt MAC addresses with controllers in the cluster.

This patch enables the VTN Manager to install flow entries across switches
connected to different controllers.

Signed-off-by: Shigeru Yasuda <s-yasuda@da.jp.nec.com>
11 years agoFixed bogus vBridge changed event. 33/1633/1
Shigeru Yasuda [Thu, 3 Oct 2013 08:00:03 +0000 (17:00 +0900)]
Fixed bogus vBridge changed event.

This patch fixes a bug that vBridgeChanged() of IVTNManagerAware may
be called even though the bridge state is not changed.

Signed-off-by: Shigeru Yasuda <s-yasuda@da.jp.nec.com>
11 years agoAdded test case for Unit test of VTN Manager and fixed some comments. 24/1624/1
Takayuki Kawagishi [Thu, 3 Oct 2013 01:15:50 +0000 (10:15 +0900)]
Added test case for Unit test of VTN Manager and fixed some comments.

Change-Id: If4ba826eee1b28309ad5091050dbacfdc7a2c94d
Signed-off-by: Takayuki Kawagishi <kawagishi-takayuki@mxj.nes.nec.co.jp>
11 years agoDeploy parent pom.xml files. 92/1592/2
Shigeru Yasuda [Wed, 2 Oct 2013 02:53:50 +0000 (11:53 +0900)]
Deploy parent pom.xml files.

Change-Id: I2311238d81f512b47b42a2690ea86bd8caf94ce6
Signed-off-by: Shigeru Yasuda <s-yasuda@da.jp.nec.com>
11 years agoFixed TestStub due to change of ISwitchManager. 67/1567/1
Takayuki Kawagishi [Tue, 1 Oct 2013 00:26:30 +0000 (09:26 +0900)]
Fixed TestStub due to change of ISwitchManager.

Change-Id: Ic18b0e1d0891d7b7473a940038c5b491f430d27e
Signed-off-by: Takayuki Kawagishi <kawagishi-takayuki@mxj.nes.nec.co.jp>
11 years agoFixed VTN flow clean-up on startup. 00/1500/1
Shigeru Yasuda [Mon, 30 Sep 2013 08:26:31 +0000 (17:26 +0900)]
Fixed VTN flow clean-up on startup.

VTNManagerImpl.initFlowDatabase() should remove VTN flows only relevant
to nodes connected to the local controller.

Signed-off-by: Shigeru Yasuda <s-yasuda@da.jp.nec.com>
11 years agoFixed incorrect vBridge state change. 96/1496/1
Shigeru Yasuda [Mon, 30 Sep 2013 07:52:31 +0000 (16:52 +0900)]
Fixed incorrect vBridge state change.

VBridgeImpl.setPortMap() should not change the vBridge state if the
target virtual interface is disabled.

Signed-off-by: Shigeru Yasuda <s-yasuda@da.jp.nec.com>
11 years agoVTNException: Use string representation of SAL status as exception's message. 94/1494/1
Shigeru Yasuda [Mon, 30 Sep 2013 06:47:30 +0000 (15:47 +0900)]
VTNException: Use string representation of SAL status as exception's message.

Signed-off-by: Shigeru Yasuda <s-yasuda@da.jp.nec.com>
11 years agoFixed vBridge state corruption. 93/1493/1
Shigeru Yasuda [Mon, 30 Sep 2013 06:15:48 +0000 (15:15 +0900)]
Fixed vBridge state corruption.

VBridgeIfImpl.mapPort() expects that the given node connector is not yet
mapped to the virtual interface. But VBridgeIfImpl.resume() will call it
if a node connector is mapped by another controller in the cluster.

Signed-off-by: Shigeru Yasuda <s-yasuda@da.jp.nec.com>
11 years agoFollow changes to the latest base controller. 92/1492/1
Shigeru Yasuda [Mon, 30 Sep 2013 02:50:24 +0000 (11:50 +0900)]
Follow changes to the latest base controller.

  * ConnectionLocality was moved to sal.connection package.
  * isHostRefreshEnabled() and getHostRetryCount() were removed from
    ISwitchManager.
  * Change version number of controller bundles.
  * Define scm element in every pom.xml.

Signed-off-by: Shigeru Yasuda <s-yasuda@da.jp.nec.com>
11 years agoFix unstable test that depends on kernel thread scheduling. 30/1430/1
Shigeru Yasuda [Thu, 26 Sep 2013 00:34:00 +0000 (09:34 +0900)]
Fix unstable test that depends on kernel thread scheduling.

Signed-off-by: Shigeru Yasuda <s-yasuda@da.jp.nec.com>
11 years agoReduce Sonar warnings. 93/1393/1
Shigeru Yasuda [Tue, 24 Sep 2013 09:50:33 +0000 (18:50 +0900)]
Reduce Sonar warnings.

  * Eliminate assignment of parameter.
  * Eliminate duplicated string literals.
  * Eliminate magic number in Java code.
  * Eliminate trailing comments.
  * Combine nested "if" statements.
  * Set @SuppressWarnings("unused") to private methods for JAXB.
  * Add javadoc comment for serialVersionUID.
  * Add configuration for checkstyle plugin.

Signed-off-by: Shigeru Yasuda <s-yasuda@da.jp.nec.com>