Tom Pantelis [Sat, 27 Jan 2018 17:24:44 +0000 (12:24 -0500)]
Fix remaining checkstyle violations in openflowjava
Change-Id: I720977b96996a462946c5b6114a6b6b7dd1285bc
Signed-off-by: Tom Pantelis <tompantelis@gmail.com>
Tom Pantelis [Sun, 21 Jan 2018 02:50:17 +0000 (21:50 -0500)]
Fix checkstyle violations in openflow-protocol-impl - part 12
Many violations - more to follow
Change-Id: I909943b0b0b3e8974dd73422843238042b4bac1b
Signed-off-by: Tom Pantelis <tompantelis@gmail.com>
Tom Pantelis [Sun, 21 Jan 2018 02:05:03 +0000 (21:05 -0500)]
Fix checkstyle violations in openflow-protocol-impl - part 11
Many violations - more to follow
Change-Id: Iaa832ec597a543b1d963cd58307d7fed05f50720
Signed-off-by: Tom Pantelis <tompantelis@gmail.com>
Tom Pantelis [Sun, 21 Jan 2018 01:39:35 +0000 (20:39 -0500)]
Fix checkstyle violations in openflow-protocol-impl - part 10
Many violations - more to follow
Change-Id: I3b7ab07f56a13982f88df17805c3d82bbf14a062
Signed-off-by: Tom Pantelis <tompantelis@gmail.com>
Tom Pantelis [Sun, 21 Jan 2018 01:12:03 +0000 (20:12 -0500)]
Fix checkstyle violations in openflow-protocol-impl - part 9
Many violations - more to follow
Change-Id: Ide57e636e33d752cd9a6c912de071fd1493a7097
Signed-off-by: Tom Pantelis <tompantelis@gmail.com>
Tom Pantelis [Sun, 21 Jan 2018 00:22:57 +0000 (19:22 -0500)]
Fix checkstyle violations in openflow-protocol-impl - part 8
Many violations - more to follow
Change-Id: Ie7aac9d6bc6b1372ff425b89d83cf44b617f7751
Signed-off-by: Tom Pantelis <tompantelis@gmail.com>
Tom Pantelis [Sat, 20 Jan 2018 23:11:32 +0000 (18:11 -0500)]
Fix checkstyle violations in openflow-protocol-impl - part 7
Many violations - more to follow
Change-Id: I35f1ada078217cc89d03f2953829ac2274a53655
Signed-off-by: Tom Pantelis <tompantelis@gmail.com>
Tom Pantelis [Sat, 20 Jan 2018 22:30:59 +0000 (17:30 -0500)]
Fix checkstyle violations in openflow-protocol-impl - part 6
Many violations - more to follow
Change-Id: I18badf1a7b759dfbe63d240ea786c716d3135c97
Signed-off-by: Tom Pantelis <tompantelis@gmail.com>
Tom Pantelis [Sat, 20 Jan 2018 22:11:16 +0000 (17:11 -0500)]
Fix checkstyle violations in openflow-protocol-impl - part 5
Many violations - more to follow
Change-Id: I19ea3b92b66c0121946e88699af5e7c2742ea54d
Signed-off-by: Tom Pantelis <tompantelis@gmail.com>
Tom Pantelis [Sat, 20 Jan 2018 21:45:52 +0000 (16:45 -0500)]
Fix checkstyle violations in openflow-protocol-impl - part 4
Many violations - more to follow
Change-Id: I9107de913adef9e19cdf7583b996598d4b9a63b0
Signed-off-by: Tom Pantelis <tompantelis@gmail.com>
Tom Pantelis [Sat, 20 Jan 2018 21:33:37 +0000 (16:33 -0500)]
Fix checkstyle violations in openflow-protocol-impl - part 3
Many violations - more to follow
Change-Id: I5cba0f1e5d8f61106db5d1461c205b80be585993
Signed-off-by: Tom Pantelis <tompantelis@gmail.com>
Tom Pantelis [Sat, 20 Jan 2018 21:10:55 +0000 (16:10 -0500)]
Fix checkstyle violations in openflow-protocol-impl - part 2
Many violations - more to follow
Change-Id: I360cd3cd431d1c05df1262df8debeb68f95ffac9
Signed-off-by: Tom Pantelis <tompantelis@gmail.com>
Tom Pantelis [Sat, 20 Jan 2018 19:43:20 +0000 (14:43 -0500)]
Fix checkstyle violations in openflow-protocol-impl - part 1
Many violations - more to follow
Change-Id: I3467223dd8ab3a9fe52906a2b029b0ab130b0b7d
Signed-off-by: Tom Pantelis <tompantelis@gmail.com>
Anil Vishnoi [Sat, 27 Jan 2018 02:20:22 +0000 (02:20 +0000)]
Merge "Spec: OFPGC_ADD_OR_MOD support in openflowplugin"
Anil Vishnoi [Sat, 27 Jan 2018 02:18:06 +0000 (02:18 +0000)]
Merge "Fix checkstyle violations in openflowjava-util"
Anil Vishnoi [Sat, 27 Jan 2018 01:21:19 +0000 (01:21 +0000)]
Merge "Fix checkstyle violations in openflow-protocol-api"
Anil Vishnoi [Sat, 27 Jan 2018 01:06:08 +0000 (01:06 +0000)]
Merge "Remove unused interface"
Anil Vishnoi [Sat, 27 Jan 2018 01:05:25 +0000 (01:05 +0000)]
Merge "Remove dependency on sal-common-util"
Anil Vishnoi [Sat, 27 Jan 2018 01:03:41 +0000 (01:03 +0000)]
Merge "Remove deprecated EOS services"
Robert Varga [Fri, 26 Jan 2018 10:31:49 +0000 (11:31 +0100)]
Remove dependency on sal-common-util
This dependency is no longer used, remove it along with use
of controller's odl-mdsal-common.
Change-Id: Id15cc085c56dcb45796593f12da9b4fd4f95a99b
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
Anil Vishnoi [Tue, 23 Jan 2018 06:25:36 +0000 (06:25 +0000)]
Merge "OPNFLWPLUG-969: ONF Extension is not installed due to which bundle based resync is failing:"
D Arunprakash [Tue, 16 Jan 2018 15:53:54 +0000 (21:23 +0530)]
OPNFLWPLUG-972: Add liblldp module to openflowplugin pom
1. Change package from org.opendaylight.controller
to org.opendaylight.openflowplugin.libraries
2. Enable liblldp module - Add to openfloplugin pom.xml
Change-Id: I0d6fa73a78e4fea587e250aed5577c10375e6b31
Signed-off-by: D Arunprakash <d.arunprakash@ericsson.com>
Anil Vishnoi [Tue, 23 Jan 2018 02:35:28 +0000 (02:35 +0000)]
Merge "OPNFLWPLUG-963 : Updating ports delete reason from OFP:"
SujaT [Thu, 4 Jan 2018 13:07:06 +0000 (18:37 +0530)]
OPNFLWPLUG-969: ONF Extension is not installed due to which bundle based
resync is failing:
Feature ONF Extension is not installed due to dependency missing hence
bundle based resync event is not taking place.It's resolved by adding
corresponding dependency in odl-openflowplugin-southbound pom.xml file.
Change-Id: Iaae13d0a327bcc6c867ca4f7b7945c81fde32118
Signed-off-by: SujaT <suja.t@ericsson.com>
Anil Vishnoi [Tue, 23 Jan 2018 02:33:23 +0000 (02:33 +0000)]
Merge "OPNFLWPLUG-929 : Remove deprecated guava library"
Anil Vishnoi [Tue, 23 Jan 2018 02:32:38 +0000 (02:32 +0000)]
Merge "OPNFLWPLUG-929 : Remove deprecated guava library"
Anil Vishnoi [Tue, 23 Jan 2018 02:30:52 +0000 (02:30 +0000)]
Merge "OFPGC_ADD_OR_MOD support in openflowplugin"
Tom Pantelis [Sat, 20 Jan 2018 18:38:58 +0000 (13:38 -0500)]
Fix checkstyle violations in openflowjava-util
Change-Id: Iac5a02900711a36c79481f0ee19be06c20bbd879
Signed-off-by: Tom Pantelis <tompantelis@gmail.com>
Tom Pantelis [Sat, 20 Jan 2018 18:03:32 +0000 (13:03 -0500)]
Fix checkstyle violations in openflow-protocol-api
Change-Id: Ie6aa924aeb857035e8389a50a70d6c9149d4e4ee
Signed-off-by: Tom Pantelis <tompantelis@gmail.com>
Tom Pantelis [Sat, 20 Jan 2018 16:14:28 +0000 (11:14 -0500)]
Eliminate explicit yangtools dependencies and pom cleanup
Changed the openflowplugin-parent pom to derive from bindng-parent so
yangtools version and dependencies come from mdsal. Also removed
unnecessary, duplicated configurations, eg yang-maven-plugin, in derived
poms thatcare inherited from the parents.
Change-Id: Ie331b93a5f1d6784109ff82afe63ca481c67ceec
Signed-off-by: Tom Pantelis <tompantelis@gmail.com>
Luis Gomez [Thu, 18 Jan 2018 23:27:27 +0000 (15:27 -0800)]
Bump yangtools to 2.0.1
Change-Id: I10fbb74bc762768e90d1f4b1f3fe0ad2a607af82
Signed-off-by: Luis Gomez <ecelgp@gmail.com>
Thanh Ha [Tue, 16 Jan 2018 15:17:34 +0000 (10:17 -0500)]
Merge remote-tracking branch 'liblldp/master'
Change-Id: I7be037f65e45d138e07e3fd136c82bdd65d23c3d
Signed-off-by: Thanh Ha <thanh.ha@linuxfoundation.org>
Thanh Ha [Tue, 16 Jan 2018 15:09:37 +0000 (10:09 -0500)]
Move liblldp into libraries/liblldp
Signed-off-by: Thanh Ha <thanh.ha@linuxfoundation.org>
Tom Pantelis [Fri, 15 Dec 2017 02:19:54 +0000 (21:19 -0500)]
Bump to yangtools-2.0.0 and odlparent-3.0.2
Change-Id: I55e46a801fa02d37117caf80f2f9ddcd7941dfb7
Signed-off-by: Tom Pantelis <tompantelis@gmail.com>
Anil Vishnoi [Fri, 12 Jan 2018 19:31:26 +0000 (19:31 +0000)]
Merge "Fix odlparent 3 Checkstyle issues"
Tom Pantelis [Thu, 14 Dec 2017 23:29:22 +0000 (18:29 -0500)]
Bump to odlparent 3.0.2
Change-Id: Ifb16521edc9fa7209c0af8e13745c6b5611d77b7
Signed-off-by: Tom Pantelis <tompantelis@gmail.com>
Jozef Bacigal [Fri, 15 Dec 2017 06:19:51 +0000 (07:19 +0100)]
Remove unused interface
- remove unused OpenflowPluginTimer
See bug: OPNFLWPLUG-966
Change-Id: I18f9d5db28cc9f8780db1fe513619a438ca88793
Signed-off-by: Jozef Bacigal <jozef.bacigal@me.com>
Robert Varga [Wed, 11 Oct 2017 18:54:53 +0000 (20:54 +0200)]
Bump yangtools to 2.0.0
This bumps odlparent to 3.0.1 and yangtools to 2.0.0. Also fixes
references to features, so that the build reactor is consistent.
Compilation fixes are addressed in a follow-up patch.
Change-Id: I24f9997c2ec22861e674b74fb01d43f783e3dbc1
Signed-off-by: Robert Varga <robert.varga@pantheon.tech>
D Arunprakash [Fri, 5 Jan 2018 12:41:37 +0000 (18:11 +0530)]
OPNFLWPLUG-929 : Remove deprecated guava library
use overloaded transformAsync api
Change-Id: I8c087f1b77f7d3f5364a3b545033e16631c48f60
Signed-off-by: D Arunprakash <d.arunprakash@ericsson.com>
D Arunprakash [Fri, 5 Jan 2018 12:38:19 +0000 (18:08 +0530)]
OPNFLWPLUG-929 : Remove deprecated guava library
use overloaded transformAsync api
Change-Id: I9c6cc9b78aeba0afe3b08bedc978a800fc804ab3
Signed-off-by: D Arunprakash <d.arunprakash@ericsson.com>
Gobinath [Thu, 21 Dec 2017 05:41:03 +0000 (11:11 +0530)]
OFPGC_ADD_OR_MOD support in openflowplugin
Addition of new command OFPGC_ADD_OR_MOD for OFPT_GROUP_MOD message
that adds a new group that does not exist (like ADD) or modifies
an existing groups like (MODIFY).
Added a configurable property group_add_mod_enabled which when set to
"true", the addition/updation of a group would send OFPGC_ADD_OR_MOD
message to the switches. When set to false, the addition/updation of the
group has the same existing behavior,ie, OFPGC_ADD for addition and
OFPGC_UPDATE for the updation of the groups.
This patch fixes the following bugs: OPNFLWPLUG-788, OPNFLWPLUG-877, OPNFLWPLUG-667
Gerrit link for the specs: https://git.opendaylight.org/gerrit/#/c/65465/
Change-Id: Ifb2f7ff55d07ca565d87eaa8b253021cad667fd6
Signed-off-by: Gobinath <gobinath@ericsson.com>
Jozef Bacigal [Thu, 3 Aug 2017 12:22:30 +0000 (14:22 +0200)]
Remove deprecated EOS services
See also: OPNFLWPLUG-927
Change-Id: Ie9a4b7904c492f2f3b2a011f358e70bfee6bd510
Signed-off-by: Jozef Bacigal <jozef.bacigal@pantheon.tech>
Anil Vishnoi [Thu, 4 Jan 2018 17:12:37 +0000 (17:12 +0000)]
Merge "OPNFLWPLUG-929 : Remove deprecated guava library in openflowplugin-impl"
Anil Vishnoi [Thu, 4 Jan 2018 17:10:32 +0000 (17:10 +0000)]
Merge "OPNFLWPLUG-929 : Remove deprecated guava library in applications"
Anil Vishnoi [Thu, 4 Jan 2018 17:08:48 +0000 (17:08 +0000)]
Merge "OPNFLWPLUG-929 : Remove deprecated guava library"
eeiillu [Tue, 19 Sep 2017 06:30:04 +0000 (12:00 +0530)]
OPNFLWPLUG-963 : Updating ports delete reason from OFP:
This patch is required by interface manager (GENIUS) to differentiate
NodeConnector removal due to PORT DEL Openflow Message or due to node
itself gets removed.
Change-Id: I84ab57abda78b5796ef94dc07e83e0f4e30fd2ce
Signed-off-by: eeiillu <suja.t@ericsson.com>
D Arunprakash [Wed, 20 Dec 2017 12:36:39 +0000 (18:06 +0530)]
OPNFLWPLUG-929 : Remove deprecated guava library in openflowplugin-impl
Change-Id: Ie95eb2e4af6917e9594c5774e91147619f88d590
Signed-off-by: D Arunprakash <d.arunprakash@ericsson.com>
D Arunprakash [Wed, 20 Dec 2017 12:30:58 +0000 (18:00 +0530)]
OPNFLWPLUG-929 : Remove deprecated guava library
Change-Id: Ica86ef2e1ad320a1fdedc1b1266cb980acd2464b
Signed-off-by: D Arunprakash <d.arunprakash@ericsson.com>
D Arunprakash [Wed, 20 Dec 2017 09:24:06 +0000 (14:54 +0530)]
OPNFLWPLUG-929 : Remove deprecated guava library in applications
Change-Id: I7c21fc9fdb2529968c68e1a535f400cd5f5a61b2
Signed-off-by: D Arunprakash <d.arunprakash@ericsson.com>
D Arunprakash [Wed, 25 Oct 2017 16:16:27 +0000 (21:46 +0530)]
OPNFLWPLUG-953: Property change listener for lldp discovery config properties
Runtime update for properties in openflowplugin.cfg is failing
as there is no listener added for newly added toplogy lldp
discovery properties
Change-Id: I87bcba910f8d51a5b940b82c588a06d39092404a
Signed-off-by: D Arunprakash <d.arunprakash@ericsson.com>
Tom Pantelis [Fri, 15 Dec 2017 03:22:27 +0000 (22:22 -0500)]
Fix odlparent 3 Checkstyle issues
Change-Id: I9ed666294ecdfa04290dc56dcf3610c85b117e92
Signed-off-by: Tom Pantelis <tompantelis@gmail.com>
Anil Vishnoi [Fri, 8 Dec 2017 21:57:35 +0000 (21:57 +0000)]
Merge "Rename addDeleteOperationTotTxChain => addDeleteOperationToTxChain"
gobinath [Tue, 28 Nov 2017 08:27:05 +0000 (13:57 +0530)]
Run time check and update of OFP service status
Change-Id: I8b41cd32990e7c4ea14cabbf862008fe77c7cc91
Signed-off-by: gobinath <gobinath@ericsson.com>
(cherry picked from commit
042a4f1a62e14cd78fab243b450f77bc6e0bc86e)
Signed-off-by: gobinath <gobinath@ericsson.com>
Prasanna Huddar [Fri, 8 Dec 2017 09:25:56 +0000 (09:25 +0000)]
Merge "System ready integration for OFP"
Gobinath [Fri, 24 Nov 2017 06:31:22 +0000 (12:01 +0530)]
System ready integration for OFP
The openflowplugin will start switch connections only on the system
ready event triggered by the infrautils.
Change-Id: Ia60b36cb2446ed92d58d3507d2de9524d6efbc00
Signed-off-by: gobinath <gobinath@ericsson.com>
Michael Vorburger [Fri, 1 Dec 2017 00:19:53 +0000 (01:19 +0100)]
Rename addDeleteOperationTotTxChain => addDeleteOperationToTxChain
to drop the 't' which looks like an obvious typo in this method
Change-Id: I0c7648f13bc1ea2312fa8fd31f8e9238260e731e
Signed-off-by: Michael Vorburger <vorburger@redhat.com>
Anil Vishnoi [Fri, 1 Dec 2017 05:47:39 +0000 (05:47 +0000)]
Merge "Minor: Remove 3 un-used private methods found by FindBugs"
Anil Vishnoi [Fri, 1 Dec 2017 05:35:21 +0000 (05:35 +0000)]
Merge "Make HandshakeManagerImpl more thread-safe, as recommended by FindBugs"
Anil Vishnoi [Fri, 1 Dec 2017 05:27:44 +0000 (05:27 +0000)]
Merge changes I400fdd74,I18d70f22,Icc83aef3,I3a67dc87,I05b3e988
* changes:
Make two classes _static_ inner classes, as recommended by FindBugs
Suppress FindBugs null analysis warning in FlowDescriptorDtoTest
Suppress FindBugs concurrency warning which is wrong
Fix FindBugs null analysis problems due to wrong @Nullable
Fix FindBugs level "Scariest" problem in SalAsyncConfigServiceImplTest
Anil Vishnoi [Fri, 1 Dec 2017 05:14:40 +0000 (05:14 +0000)]
Merge "FindBugs enforcement in module openflowplugin-api/"
Anil Vishnoi [Fri, 1 Dec 2017 05:13:12 +0000 (05:13 +0000)]
Merge changes Ic5f4324c,I7611359f
* changes:
FindBugs enforcement in module common/
Checkstyle enforcement (and required fixes) in module common/
Michael Vorburger [Thu, 30 Nov 2017 23:59:22 +0000 (00:59 +0100)]
Fix possible transaction leak in StatisticsGatheringUtils
see https://jira.opendaylight.org/projects/OPNFLWPLUG/issues/OPNFLWPLUG-961;
5x transactions opened here which were not closed
Change-Id: I1d9983a257881a7618943f76a6780a14c4e97e82
Signed-off-by: Michael Vorburger <vorburger@redhat.com>
Michael Vorburger [Thu, 30 Nov 2017 23:32:57 +0000 (00:32 +0100)]
Minor: Remove 3 un-used private methods found by FindBugs
Change-Id: I6fc436746b35bd4971a35f9af45201a2065bd438
Signed-off-by: Michael Vorburger <vorburger@redhat.com>
Michael Vorburger [Thu, 30 Nov 2017 23:23:12 +0000 (00:23 +0100)]
Make HandshakeManagerImpl more thread-safe, as recommended by FindBugs
Change-Id: I7b60abf3dfca6cad9936acdb1ce03f77f1a97768
Signed-off-by: Michael Vorburger <vorburger@redhat.com>
Change-Id: I7b60abf3dfca6cad9936acdb1ce03f77f1a97768
Signed-off-by: Michael Vorburger <vorburger@redhat.com>
Michael Vorburger [Thu, 30 Nov 2017 23:08:17 +0000 (00:08 +0100)]
Make two classes _static_ inner classes, as recommended by FindBugs
Change-Id: I400fdd7492f18728690ccd5ef5063936a8021ae0
Signed-off-by: Michael Vorburger <vorburger@redhat.com>
Michael Vorburger [Thu, 30 Nov 2017 23:01:42 +0000 (00:01 +0100)]
Suppress FindBugs null analysis warning in FlowDescriptorDtoTest
Change-Id: I18d70f22a4bb979f2153bf34d1b131e7139f807a
Signed-off-by: Michael Vorburger <vorburger@redhat.com>
Michael Vorburger [Thu, 30 Nov 2017 22:55:39 +0000 (23:55 +0100)]
Suppress FindBugs concurrency warning which is wrong
Change-Id: Icc83aef349ce1c16ce774c1aebfa108a7718c4bd
Signed-off-by: Michael Vorburger <vorburger@redhat.com>
Michael Vorburger [Thu, 30 Nov 2017 22:51:53 +0000 (23:51 +0100)]
Fix FindBugs null analysis problems due to wrong @Nullable
In each of these 3 cases, the RpcResult is very clearly de facto not
@Nullable (because it is de-referenced in the method, so if it was null,
that would cause a NPE) - so just remove the @Nullable.
Change-Id: I3a67dc87a7b2f538b830d189d287d32c583f81b9
Signed-off-by: Michael Vorburger <vorburger@redhat.com>
Michael Vorburger [Thu, 30 Nov 2017 22:48:07 +0000 (23:48 +0100)]
Fix FindBugs level "Scariest" problem in SalAsyncConfigServiceImplTest
FB says: "VERY confusing to have methods
org.opendaylight.openflowplugin.impl.services.sal.SalAsyncConfigServiceImplTest.setUp()
and org.opendaylight.openflowplugin.impl.services.ServiceMocking.setup()
The referenced methods have names that differ only by capitalization.
This is very confusing because if the capitalization were identical then
one of the methods would override the other."
Change-Id: I05b3e98833d22b3915b0564d05d2ec8968811457
Signed-off-by: Michael Vorburger <vorburger@redhat.com>
Michael Vorburger [Thu, 30 Nov 2017 22:34:15 +0000 (23:34 +0100)]
FindBugs enforcement in module openflowplugin-api/
No serious FindBugs violation needed to be corrected (1 very minor)
Change-Id: Ibb1ea7a0d3bbcd775187c4639f7549fbdb254dc5
Signed-off-by: Michael Vorburger <vorburger@redhat.com>
Michael Vorburger [Thu, 30 Nov 2017 22:18:50 +0000 (23:18 +0100)]
FindBugs enforcement in module common/
No FindBugs violation needed to be corrected in TransactionChainManager
Includes .gitignore of .fbExcludeFilterFile created by FB Eclipse plugin
Change-Id: Ic5f4324c5b4855a489585083cb2964c527f2fc9a
Signed-off-by: Michael Vorburger <vorburger@redhat.com>
Michael Vorburger [Thu, 30 Nov 2017 22:12:09 +0000 (23:12 +0100)]
Checkstyle enforcement (and required fixes) in module common/
Change-Id: I7611359fee604b2a68b42e16ca5bb673813c1e13
Signed-off-by: Michael Vorburger <vorburger@redhat.com>
Anil Vishnoi [Thu, 30 Nov 2017 10:46:03 +0000 (10:46 +0000)]
Merge "Clean up in module reconciliation-framework"
D Arunprakash [Thu, 23 Nov 2017 06:43:00 +0000 (12:13 +0530)]
Spec: OFPGC_ADD_OR_MOD support in openflowplugin
Implementation spec for OFPGC_ADD_OR_MOD
https://jira.opendaylight.org/browse/OPNFLWPLUG-877
Change-Id: Ief5b63416b586b44e0b73a4bab816b2844ddcaae
Signed-off-by: D Arunprakash <d.arunprakash@ericsson.com>
D Arunprakash [Fri, 17 Nov 2017 08:39:02 +0000 (14:09 +0530)]
Spec: Reconciliation framework
Change-Id: I80c8a6ce4b073f59d69ecd01558ce024adce0748
Signed-off-by: D Arunprakash <d.arunprakash@ericsson.com>
Stephen Kitt [Wed, 22 Nov 2017 10:39:30 +0000 (11:39 +0100)]
Allow PacketException to store the cause
This avoids callers’ losing the original exception.
Change-Id: I99f11dd6866670229f8e3d2aa6556f540369de19
Signed-off-by: Stephen Kitt <skitt@redhat.com>
David Suarez [Mon, 20 Nov 2017 15:10:45 +0000 (16:10 +0100)]
Clean up in module reconciliation-framework
- Remove some deprecated
- Make some variables final
- Other minor clean up
Change-Id: Ib87f59bf31009d5222c7512fa5d2d29a14454fef
Signed-off-by: David Suarez <david.suarez.fuentes@gmail.com>
Anil Vishnoi [Fri, 17 Nov 2017 08:05:46 +0000 (08:05 +0000)]
Merge "Revert "Bug 8902 : Spec for Reconciliation Framework""
D Arunprakash [Fri, 17 Nov 2017 03:51:00 +0000 (09:21 +0530)]
Remove the rst file and add later with proper formatting
Change-Id: Ib92caeb6c7e657b51e76dd169c5569e2bb45bbe7
Signed-off-by: D Arunprakash <d.arunprakash@ericsson.com>
Anil Belur [Fri, 17 Nov 2017 01:56:03 +0000 (11:56 +1000)]
Revert "Bug 8902 : Spec for Reconciliation Framework"
Patch #60283 is preventing patch #65556 from being verified
This reverts commit
f1e058a660cf98d1411ba763c6b0989e2439fabc.
Change-Id: I11c277ae85a366ed83dd240586d5ef8e2ca60d0e
Signed-off-by: Anil Belur <abelur@linuxfoundation.org>
Anil Vishnoi [Wed, 15 Nov 2017 20:40:06 +0000 (20:40 +0000)]
Merge "Add Docs for Openflowplugin"
Anil Vishnoi [Wed, 15 Nov 2017 20:40:01 +0000 (20:40 +0000)]
Merge "Bug 8902 : Spec for Reconciliation Framework"
Shuva Jyoti Kar [Wed, 15 Nov 2017 14:24:13 +0000 (14:24 +0000)]
Merge "DiagStatus integration for openflowplugin"
D Arunprakash [Wed, 15 Nov 2017 08:29:36 +0000 (13:59 +0530)]
Add Docs for Openflowplugin
This patch just initializes sphinx for Openflowplugin
Change-Id: Ie7d0e2004d48e7ddacaf32ab18d0f94f5bc40c27
Signed-off-by: D Arunprakash <d.arunprakash@ericsson.com>
D Arunprakash [Wed, 12 Jul 2017 09:06:48 +0000 (14:36 +0530)]
Bug 8902 : Spec for Reconciliation Framework
This spec provides the documentation for Reconciliation framework
implementation and usage
Change-Id: I10c312d9890effb317a695450d381ee4d6725b60
Signed-off-by: D Arunprakash <d.arunprakash@ericsson.com>
Stephen Kitt [Wed, 8 Nov 2017 15:01:41 +0000 (16:01 +0100)]
Drop Karaf shell specifiers
We no longer need to support Karaf 3, and the karaf.shell
"[3.0.0,4.1)" declarations prevent us from upgrading to Karaf 4.1
(which is coming with odlparent 3).
Change-Id: I4367b34229246064319ee9e34199623666911f6a
Signed-off-by: Stephen Kitt <skitt@redhat.com>
Faseela K [Thu, 12 Oct 2017 11:43:29 +0000 (17:13 +0530)]
DiagStatus integration for openflowplugin
Openflowplugin should report their initial status once
all switch connection providers are initialized.
Subsequent patches will query the dynamic status of port
6653/6633 to advertise the live status.
Further enhancements can be done if openflowplugin can query
some of the major service status before opening up the
southbound interfaces.
Change-Id: Id57f52d3ad02d59f7469762b1e1f0fb468b785ce
Signed-off-by: Faseela K <faseela.k@ericsson.com>
Anil Vishnoi [Fri, 27 Oct 2017 22:40:11 +0000 (15:40 -0700)]
OPNFLWPLUG-930 Inconsistent flow IDs between flows
in config and operational data stores
Change-Id: I4ee8787e163a6ab64a4574f0dc906c7c91a7d0b2
Signed-off-by: Anil Vishnoi <vishnoianil@gmail.com>
Anil Vishnoi [Mon, 30 Oct 2017 06:21:37 +0000 (06:21 +0000)]
Merge "Fix issues related to checkstyle enforcement on openflow-impl module"
Anil Vishnoi [Mon, 30 Oct 2017 05:56:01 +0000 (05:56 +0000)]
Merge "Remove deprecated"
Luis Gomez [Fri, 27 Oct 2017 00:59:54 +0000 (17:59 -0700)]
Do not use fix custom version in ofp feature
Change-Id: Ic0a7c69a3f92b2d874fa64b168ccda50c6696351
Signed-off-by: Luis Gomez <ecelgp@gmail.com>
David Suárez [Fri, 20 Oct 2017 11:45:18 +0000 (13:45 +0200)]
Remove deprecated
- CheckedFuture
- Futures.addCallback
- Some other changes regarding checkstyle, sonar and annotations
Change-Id: I6ab7b10a6170bee6e78895b21d40ee1a047d961a
Signed-off-by: David Suárez <david.suarez.fuentes@gmail.com>
David Suarez [Sun, 8 Oct 2017 17:04:59 +0000 (19:04 +0200)]
Fix issues related to checkstyle enforcement on openflow-impl module
This is the last commit. It enforces the checkstyle level to error.
Change-Id: I954f0cbabd68134254e3a05216d6f6f126e33d37
Signed-off-by: David Suarez <david.suarez.fuentes@gmail.com>
D Arunprakash [Mon, 16 Oct 2017 09:06:50 +0000 (14:36 +0530)]
Fix checkstyle issues in openflowplugin-impl module
Change-Id: I8d6aa0b35078350bf897c5bf2b9a6cc11d0a4bf2
Signed-off-by: D Arunprakash <d.arunprakash@ericsson.com>
Anil Vishnoi [Fri, 13 Oct 2017 06:21:20 +0000 (06:21 +0000)]
Merge "Cli to display all the connected DPNs"
Gobinath [Tue, 26 Sep 2017 09:37:45 +0000 (15:07 +0530)]
Cli to display all the connected DPNs
Change-Id: I519450772b670750ccb38391a3c633ba572340d1
Signed-off-by: Gobinath <gobinath@ericsson.com>
Signed-off-by: gobinath <gobinath@ericsson.com>
Anil Vishnoi [Thu, 12 Oct 2017 06:06:23 +0000 (06:06 +0000)]
Merge "Fix log message"
David Suarez [Wed, 11 Oct 2017 09:43:22 +0000 (11:43 +0200)]
Fix log message
Change-Id: If70c25133d0a430ebb7b2a2906ac95fdad4d7bde
Signed-off-by: David Suarez <david.suarez.fuentes@gmail.com>
Anil Vishnoi [Wed, 11 Oct 2017 07:40:34 +0000 (00:40 -0700)]
Disable the test that's causing merge failure
It's bit of a weird situation. Locally this unit test is passing consistently
but it's failing in merge job. Looks like merge job for the following patch
https://git.opendaylight.org/gerrit/#/c/62822/
failed and it didn't publish the artifacts and looks like that's causing
the merge job failure. This patch is an attempt to get a green merge job
and once all the latest artifacts are publish, this test will be re-enabled.
Change-Id: I99742b756040382b249072cd21782f42b4de3b21
Signed-off-by: Anil Vishnoi <vishnoianil@gmail.com>
Anil Vishnoi [Tue, 10 Oct 2017 23:51:18 +0000 (23:51 +0000)]
Merge "BUG-9218: use packaged inventory model"
Code Review / openflowplugin.git / log